[VOTE] [RESULT] Release Apache Commons Pool 2.12.0 based on RC5

2023-09-29 Thread Phil Steitz 
This vote has passed with binding +1 votes from

Bruno Kinoshita
Gary Gregory
Rob Tompkins
Phil Steitz

and no other votes.

Thanks to all who reviewed the release candidate.

Phil


On Tue, Sep 26, 2023 at 12:50 PM Phil Steitz  wrote:

> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons Pool 2.11.1 was released, so I would like to release
> Apache Commons Pool 2.12.0.
>
> Apache Commons Pool 2.12.0 RC5 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/pool/2.12.0-RC5 (svn
> revision 64211)
>
> The Git tag commons-pool-2.12.0-RC5 commit for this RC is
> commons-pool-1.12.0-RC5 which you can browse here:
>
> https://github.com/apache/commons-pool/releases/tag/commons-pool-2.12.0-RC5
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-pool.git
> --branch commons-pool-2.12.0-RC5 commons-pool-2.12.0-RC5
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1659/org/apache/commons/commons-pool2/2.12.0/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Tue Sep 26 11:50:36 MST 2023
>
> commons-pool2-2.12.0-bom.xml=46f6d5da5c530b482bf3d23d53c337f28507d9d27b5f4ef56dc3523fe27c24833de0e05d20460a1c0b77dd5569f1d1207e9d95bbf5332ae103503abf00a0bdfb
>
> commons-pool2-2.12.0-bin.zip=08ea2579002276e6e5ff576bd3cfc1b4b29e1ecd471c6a38b263f57c9a887a158eee62a6ff3093e6017cb947409194dd1d7a9d681ae32588eb241404da3796e0
>
> commons-pool2-2.12.0-tests.jar=697ac4c33eca5067dedfbc6b7f656aa230ba71908aed6450ca49a0419aad0f588bd0a238c9e7198999265b79c7fab2e760f3575bdad7ff13109ef2aaf72c36a4
>
> commons-pool2-2.12.0-sources.jar=470d45652b9c63e92feb26c517edfd324878214a87faeee79e70772fd6ead1553aaa362b209dc1cb950cc144004223b186e142810a72be0caa839e87446999b6
>
> commons-pool2-2.12.0-src.zip=c09424e2a6209adf0e1660de421c35c3b80c395a5d4ef30e6ff58c499b5768cde15e508f858dffc0dfde1c9a3d18d5d7681d67ca5c796d99e5922c712889e195
>
> commons-pool2-2.12.0-bom.json=f2ac923db32811d691c304ab8425fff757ebe3102cbacafad7244dc3f5d742e1376ba7fb906b177a626dd766f49baa2da977efb260e3d66aa8dd8b3034954276
>
> org.apache.commons_commons-pool2-2.12.0.spdx.json=2e8e3f1f2aa69abc7c49b0487960159cf6690e5de4ad74706c47e00f55479490b7ed31a478b82f6b51c94ef23501fc8850432d00d7364180bba5486d63cd33bc
>
> commons-pool2-2.12.0-src.tar.gz=fefb22459519b92712a9e5178099d19cc7fc8a5b07f633387c11f5b30d86ae8f73e237728be08a2705cf56f986be5a51c11a084b01224e5a0c9ccf7b34dc6258
>
> commons-pool2-2.12.0-javadoc.jar=a4b3df904311892327d210f0c507b4c9cba1e2289071a87d873ea72f60052a5658728f6412715c6e1cb0528f8df15cd9c74fe20d173b17cc887120048334a119
>
> commons-pool2-2.12.0-test-sources.jar=b93d6529527029f26aa51bf451e2c0250e5e20c7c884b51d2c1377d3e58c218679ba56f87e10bd1062fbc87bb8db3a2bfe98c5b54910566a57260ab77f530482
>
> commons-pool2-2.12.0-bin.tar.gz=3d75b997287df339acfd76662cf6e4b645b10fff825bffc58dd2238dbaaccf7b81c61aa59ada6f667a3f29d9db0730e34b25526f7d309db36361e4d1e8c6ec70
>
> I have tested the build of this release candidate with
>
> mvn clean package site
> under
> openjdk version "17.0.8.1" 2023-08-24
> OpenJDK Runtime Environment (build 17.0.8.1+1-Ubuntu-0ubuntu120.04)
> OpenJDK 64-Bit Server VM (build 17.0.8.1+1-Ubuntu-0ubuntu120.04, mixed
> mode, sharing)
>
> openjdk version "11.0.20.1" 2023-08-24
> OpenJDK Runtime Environment (build 11.0.20.1+1-post-Ubuntu-0ubuntu120.04)
> OpenJDK 64-Bit Server VM (build 11.0.20.1+1-post-Ubuntu-0ubuntu120.04,
> mixed mode, sharing)
>
> openjdk version "1.8.0_382"
> OpenJDK Runtime Environment (build 1.8.0_382-8u382-ga-1~20.04.1-b05)
> OpenJDK 64-Bit Server VM (build 25.382-b05, mixed mode)
>
> Using
> Apache Maven 3.9.3 (21122926829f1ead511c958d89bd2f672198ae9f)
> Linux 5.15.0-83-generic #92~20.04.1-Ubuntu SMP
>
> And
> openjdk version "20.0.1" 2023-04-18
> OpenJDK Runtime Environment Homebrew (build 20.0.1)
> OpenJDK 64-Bit Server VM Homebrew (build 20.0.1, mixed mode, sharing)
> Darwin Darwin Kernel Version 22.6.0: Wed Jul  5 22:21:56 PDT 2023;
> root:xnu-8796.141.3~6/RELEASE_X86_64
>
> I have also tested the compiled jar against DBCP 2.10 and run soak and
> performance tests using Commons Performance.  Performance was not
> significantly different from earlier 2.x versions for the tested workloads.
>
> Details of changes since 2.11.1 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/pool/2.12.0-RC5/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/pool/2.12.0-RC5/site/changes-report.html
>
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/pool/2.12.0-RC5/site/index.html
> (note some *relative* links are broken and the 2.12.0 directories are
> not yet created - these will be OK once the site is deployed.)
>
> JApiCmp Report (compared to 2.11.1):
>
> https://dist.apache.org/repos/dist/dev/commons/pool/2.12.0-RC5/site/japicmp.html
>
> RAT Report:
>
>

Re: [logging] Broken link to FAQ in docs

2023-09-29 Thread Bruno Kinoshita 
Hi,

The link was indeed broken, thanks for pointing that out and for the
correction. I've updated it on master (credited you by name in the commit
[1], hope that's OK), and re-published the site.

Cheers,

Bruno

[1]
https://github.com/apache/commons-logging/commit/176a1462a86d65ba0b1de4f199e74409c1dc07c6

On Fri, 29 Sept 2023 at 16:23, Ed Brannin 
wrote:

> Hello,
>
> The FAQ link at the bottom of this page is broken:
>
> https://commons.apache.org/proper/commons-logging/guide.html#Frequently_Asked_Questions
>
> The link currently points to:
> http://wiki.apache.org/commons/Logging/FrequentlyAskedQuestions
>
> The correct link is:
>
> https://cwiki.apache.org/confluence/display/COMMONS/Logging+FrequentlyAskedQuestions
>
> --
> Ed Brannin
> Software Developer II
> bandwidth.com  • Rochester, USA
>
> M: +1-585-261-0279 •
> 
>

Re: [VOTE] Release Apache Commons IO 2.14.0 based on RC1

2023-09-29 Thread Phil Steitz 
After carefully reviewing the Spotbugs report, I am going to change my vote
to

+1

Most of the complaints are about returning references vs copies of things
in getters.  The SA_LOCAL_SELF_COMPARISON complaint looks legit, but
probably harmless because it appears to have been there for a long time.
It is basically dead code - comparing references vs buffer contents, which
it looks like it is intended to do.  The errors in the report should be
fixed or filtered, but I don't think any of them are show-stoppers for
release.

Phil

On Tue, Sep 26, 2023 at 9:38 AM Gary Gregory  wrote:

> We have fixed a few bugs and added some enhancements since Apache
> Commons IO 2.13.0 was released, so I would like to release Apache
> Commons IO 2.14.0.
>
> Apache Commons IO 2.14.0 RC1 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/io/2.14.0-RC1 (svn
> revision 64208)
>
> The Git tag commons-io-2.14.0-RC1 commit for this RC is
> 82250a879112e9b58c58d289e166d66942d77341 which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-io.git;a=commit;h=82250a879112e9b58c58d289e166d66942d77341
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-io.git
> --branch commons-io-2.14.0-RC1 commons-io-2.14.0-RC1
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1657/commons-io/commons-io/2.14.0/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Mon Sep 25 06:51:48 EDT 2023
>
> commons-io-2.14.0-sources.jar=cb32b6c6b6c875633103e248c7998c8a0082c0c4d476688897a16549573b4d53e63fec4255f100521f265bf58b16cb4f4b7e09f4ce4b2f086eb13a15b9cce539
>
> commons-io-2.14.0-bin.zip=f80efb25e30d89fe9ea26fc85baa3666c1c69c3bcdda6d566e9e95d1c627c52a16582ed48f13a06bf4d89e49e14dc1f19608f32e6dbaecd66725acc2d58d720d
>
> commons-io-2.14.0-src.tar.gz=f96568e55dec789661c02a1f9455bf30eece5b621f99258385112d39aded37b1ec3dea93275d3ccaed9590e9cf95ae4958ef9d028db4275900180e269c9db970
>
> commons-io-2.14.0-src.zip=d6a469218279bb9be92caa43eaf49478ecc5d90056677c504c2d16f2f44677baf0929c01c2c096d18b99158d641ef5a6dcba44b88076db0f062746afa684ca5d
>
> commons-io-2.14.0-bom.json=9eb19600b17cfaa68d0e52f1986f09802f8bfea7a031eff536249fcca18e47bc25144b60187158ef0e8f80adeae4ae8c9b10925b6995b1e0191aa76ecf550e7a
>
> commons-io-2.14.0-tests.jar=4692a6fc8b11b8c0f60b0896cdc1a3a8bb5f0710e8a47c4589aa0bffe683b31fb512743af03ac699f639c2bb55342bd6c833c5dac52dcf6b0f68a8e3e9ff1d21
>
> commons-io-2.14.0-test-sources.jar=ccefebb9113638343d15e05f1e25442e4cbc201ae8c6b07bc52c1ba3cdb069fda98418aa6f2731895012b76cc0fa21eb4599220dd6c9d4f9386c8b1fc27e99d3
>
> commons-io_commons-io-2.14.0.spdx.json=1e509681b8e883ed500ba2c349fed3d3527e6a69101fa0f7b305e5b2f4b12bcbe67869dbefc5e26d66875b6161fab8a2747a87c553e40da1902e9ed1b6e306e8
>
> commons-io-2.14.0-bin.tar.gz=a15eb43dede3c82895fe0411963ce2ba7b75716378dd93aa02f68f909f8777fdba8d738d7f895e7c4d6931bf0bba18fd409b5f6c7e0f02452047ac71f8dba313
>
> commons-io-2.14.0-javadoc.jar=24ed778593714a8eb200d2daa235ca755f9c8cf06d8b1c0b164df72049b1706d3827bf9ba772297334aa3ff1833f6257249c1bcdb66e4e9e3f6874cd58a1e212
>
> commons-io-2.14.0-bom.xml=256580d4b1ef0d6fce4d9379e87d62a05ca1f954abd6864406023800b5679067f50c33d8139dd830a55b016abffa6d8cba97d4f7bb06bae1f4a0307c0fec046a
>
> I have tested this with:
>
> mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site
> deploy
>
> Using:
>
> Apache Maven 3.9.4 (dfbb324ad4a7c8fb0bf182e6d91b0ae20e3d2dd9)
> Maven home: /usr/local/Cellar/maven/3.9.4/libexec
> Java version: 17.0.8.1, vendor: Homebrew, runtime:
> /usr/local/Cellar/openjdk@17/17.0.8.1/libexec/openjdk.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "13.5.2", arch: "x86_64", family: "mac"
> Darwin gdg-mac-mini.local 22.6.0 Darwin Kernel Version 22.6.0: Wed Jul
>  5 22:21:56 PDT 2023; root:xnu-8796.141.3~6/RELEASE_X86_64 x86_64
>
> Details of changes since 2.13.0 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/io/2.14.0-RC1/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/io/2.14.0-RC1/site/changes-report.html
>
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/io/2.14.0-RC1/site/index.html
> (note some *relative* links are broken and the 2.14.0 directories
> are not yet created - these will be OK once the site is deployed.)
>
> RAT Report:
>
> https://dist.apache.org/repos/dist/dev/commons/io/2.14.0-RC1/site/rat-report.html
>
> KEYS:
>   https://downloads.apache.org/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thank you,
>
> Gary Gregory,
> Release Manager (using key 86fdc7e2a11262cb)
>
> For following is intended as a helper and refresher for reviewers.
>
> Validating a

[VOTE][RESULT] Release Apache Commons IO 2.14.0 based on RC1

2023-09-29 Thread Gary Gregory 
This vote thread passes with the following binding votes:

- Rob Tompkins +1
- Phil Steitz +0
- Bruno Kinoshita +1
- Gary Gregory +1

Gary


On Fri, Sep 29, 2023 at 2:52 PM Gary Gregory  wrote:
>
> My +1
>
> Gary
>
> On Wed, Sep 27, 2023 at 7:38 AM Bruno Kinoshita  
> wrote:
> >
> >[x] +1 Release these artifacts
> >
> > On Tue, 26 Sept 2023 at 18:39, Gary Gregory  wrote:
> >
> > > We have fixed a few bugs and added some enhancements since Apache
> > > Commons IO 2.13.0 was released, so I would like to release Apache
> > > Commons IO 2.14.0.
> > >
> > > Apache Commons IO 2.14.0 RC1 is available for review here:
> > > https://dist.apache.org/repos/dist/dev/commons/io/2.14.0-RC1 (svn
> > > revision 64208)
> > >
> > > The Git tag commons-io-2.14.0-RC1 commit for this RC is
> > > 82250a879112e9b58c58d289e166d66942d77341 which you can browse here:
> > >
> > > https://gitbox.apache.org/repos/asf?p=commons-io.git;a=commit;h=82250a879112e9b58c58d289e166d66942d77341
> > > You may checkout this tag using:
> > > git clone https://gitbox.apache.org/repos/asf/commons-io.git
> > > --branch commons-io-2.14.0-RC1 commons-io-2.14.0-RC1
> > >
> > > Maven artifacts are here:
> > >
> > > https://repository.apache.org/content/repositories/orgapachecommons-1657/commons-io/commons-io/2.14.0/
> > >
> > > These are the artifacts and their hashes:
> > >
> > > #Release SHA-512s
> > > #Mon Sep 25 06:51:48 EDT 2023
> > >
> > > commons-io-2.14.0-sources.jar=cb32b6c6b6c875633103e248c7998c8a0082c0c4d476688897a16549573b4d53e63fec4255f100521f265bf58b16cb4f4b7e09f4ce4b2f086eb13a15b9cce539
> > >
> > > commons-io-2.14.0-bin.zip=f80efb25e30d89fe9ea26fc85baa3666c1c69c3bcdda6d566e9e95d1c627c52a16582ed48f13a06bf4d89e49e14dc1f19608f32e6dbaecd66725acc2d58d720d
> > >
> > > commons-io-2.14.0-src.tar.gz=f96568e55dec789661c02a1f9455bf30eece5b621f99258385112d39aded37b1ec3dea93275d3ccaed9590e9cf95ae4958ef9d028db4275900180e269c9db970
> > >
> > > commons-io-2.14.0-src.zip=d6a469218279bb9be92caa43eaf49478ecc5d90056677c504c2d16f2f44677baf0929c01c2c096d18b99158d641ef5a6dcba44b88076db0f062746afa684ca5d
> > >
> > > commons-io-2.14.0-bom.json=9eb19600b17cfaa68d0e52f1986f09802f8bfea7a031eff536249fcca18e47bc25144b60187158ef0e8f80adeae4ae8c9b10925b6995b1e0191aa76ecf550e7a
> > >
> > > commons-io-2.14.0-tests.jar=4692a6fc8b11b8c0f60b0896cdc1a3a8bb5f0710e8a47c4589aa0bffe683b31fb512743af03ac699f639c2bb55342bd6c833c5dac52dcf6b0f68a8e3e9ff1d21
> > >
> > > commons-io-2.14.0-test-sources.jar=ccefebb9113638343d15e05f1e25442e4cbc201ae8c6b07bc52c1ba3cdb069fda98418aa6f2731895012b76cc0fa21eb4599220dd6c9d4f9386c8b1fc27e99d3
> > >
> > > commons-io_commons-io-2.14.0.spdx.json=1e509681b8e883ed500ba2c349fed3d3527e6a69101fa0f7b305e5b2f4b12bcbe67869dbefc5e26d66875b6161fab8a2747a87c553e40da1902e9ed1b6e306e8
> > >
> > > commons-io-2.14.0-bin.tar.gz=a15eb43dede3c82895fe0411963ce2ba7b75716378dd93aa02f68f909f8777fdba8d738d7f895e7c4d6931bf0bba18fd409b5f6c7e0f02452047ac71f8dba313
> > >
> > > commons-io-2.14.0-javadoc.jar=24ed778593714a8eb200d2daa235ca755f9c8cf06d8b1c0b164df72049b1706d3827bf9ba772297334aa3ff1833f6257249c1bcdb66e4e9e3f6874cd58a1e212
> > >
> > > commons-io-2.14.0-bom.xml=256580d4b1ef0d6fce4d9379e87d62a05ca1f954abd6864406023800b5679067f50c33d8139dd830a55b016abffa6d8cba97d4f7bb06bae1f4a0307c0fec046a
> > >
> > > I have tested this with:
> > >
> > > mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site
> > > deploy
> > >
> > > Using:
> > >
> > > Apache Maven 3.9.4 (dfbb324ad4a7c8fb0bf182e6d91b0ae20e3d2dd9)
> > > Maven home: /usr/local/Cellar/maven/3.9.4/libexec
> > > Java version: 17.0.8.1, vendor: Homebrew, runtime:
> > > /usr/local/Cellar/openjdk@17/17.0.8.1/libexec/openjdk.jdk/Contents/Home
> > > Default locale: en_US, platform encoding: UTF-8
> > > OS name: "mac os x", version: "13.5.2", arch: "x86_64", family: "mac"
> > > Darwin gdg-mac-mini.local 22.6.0 Darwin Kernel Version 22.6.0: Wed Jul
> > >  5 22:21:56 PDT 2023; root:xnu-8796.141.3~6/RELEASE_X86_64 x86_64
> > >
> > > Details of changes since 2.13.0 are in the release notes:
> > >
> > > https://dist.apache.org/repos/dist/dev/commons/io/2.14.0-RC1/RELEASE-NOTES.txt
> > >
> > > https://dist.apache.org/repos/dist/dev/commons/io/2.14.0-RC1/site/changes-report.html
> > >
> > > Site:
> > >
> > > https://dist.apache.org/repos/dist/dev/commons/io/2.14.0-RC1/site/index.html
> > > (note some *relative* links are broken and the 2.14.0 directories
> > > are not yet created - these will be OK once the site is deployed.)
> > >
> > > RAT Report:
> > >
> > > https://dist.apache.org/repos/dist/dev/commons/io/2.14.0-RC1/site/rat-report.html
> > >
> > > KEYS:
> > >   https://downloads.apache.org/commons/KEYS
> > >
> > > Please review the release candidate and vote.
> > > This vote will close no sooner than 72 hours from now.
> > >
> > >   [ ] +1 Release these artifacts
> > >   [ ] +0 OK, but...
> > >   [ ] -0 OK, but really should fix...
> > >   [ ] -1 I oppose this release because...
> > >
> > > Thank you,

Re: [VOTE] Release Apache Commons IO 2.14.0 based on RC1

2023-09-29 Thread Gary Gregory 
My +1

Gary

On Wed, Sep 27, 2023 at 7:38 AM Bruno Kinoshita  wrote:
>
>[x] +1 Release these artifacts
>
> On Tue, 26 Sept 2023 at 18:39, Gary Gregory  wrote:
>
> > We have fixed a few bugs and added some enhancements since Apache
> > Commons IO 2.13.0 was released, so I would like to release Apache
> > Commons IO 2.14.0.
> >
> > Apache Commons IO 2.14.0 RC1 is available for review here:
> > https://dist.apache.org/repos/dist/dev/commons/io/2.14.0-RC1 (svn
> > revision 64208)
> >
> > The Git tag commons-io-2.14.0-RC1 commit for this RC is
> > 82250a879112e9b58c58d289e166d66942d77341 which you can browse here:
> >
> > https://gitbox.apache.org/repos/asf?p=commons-io.git;a=commit;h=82250a879112e9b58c58d289e166d66942d77341
> > You may checkout this tag using:
> > git clone https://gitbox.apache.org/repos/asf/commons-io.git
> > --branch commons-io-2.14.0-RC1 commons-io-2.14.0-RC1
> >
> > Maven artifacts are here:
> >
> > https://repository.apache.org/content/repositories/orgapachecommons-1657/commons-io/commons-io/2.14.0/
> >
> > These are the artifacts and their hashes:
> >
> > #Release SHA-512s
> > #Mon Sep 25 06:51:48 EDT 2023
> >
> > commons-io-2.14.0-sources.jar=cb32b6c6b6c875633103e248c7998c8a0082c0c4d476688897a16549573b4d53e63fec4255f100521f265bf58b16cb4f4b7e09f4ce4b2f086eb13a15b9cce539
> >
> > commons-io-2.14.0-bin.zip=f80efb25e30d89fe9ea26fc85baa3666c1c69c3bcdda6d566e9e95d1c627c52a16582ed48f13a06bf4d89e49e14dc1f19608f32e6dbaecd66725acc2d58d720d
> >
> > commons-io-2.14.0-src.tar.gz=f96568e55dec789661c02a1f9455bf30eece5b621f99258385112d39aded37b1ec3dea93275d3ccaed9590e9cf95ae4958ef9d028db4275900180e269c9db970
> >
> > commons-io-2.14.0-src.zip=d6a469218279bb9be92caa43eaf49478ecc5d90056677c504c2d16f2f44677baf0929c01c2c096d18b99158d641ef5a6dcba44b88076db0f062746afa684ca5d
> >
> > commons-io-2.14.0-bom.json=9eb19600b17cfaa68d0e52f1986f09802f8bfea7a031eff536249fcca18e47bc25144b60187158ef0e8f80adeae4ae8c9b10925b6995b1e0191aa76ecf550e7a
> >
> > commons-io-2.14.0-tests.jar=4692a6fc8b11b8c0f60b0896cdc1a3a8bb5f0710e8a47c4589aa0bffe683b31fb512743af03ac699f639c2bb55342bd6c833c5dac52dcf6b0f68a8e3e9ff1d21
> >
> > commons-io-2.14.0-test-sources.jar=ccefebb9113638343d15e05f1e25442e4cbc201ae8c6b07bc52c1ba3cdb069fda98418aa6f2731895012b76cc0fa21eb4599220dd6c9d4f9386c8b1fc27e99d3
> >
> > commons-io_commons-io-2.14.0.spdx.json=1e509681b8e883ed500ba2c349fed3d3527e6a69101fa0f7b305e5b2f4b12bcbe67869dbefc5e26d66875b6161fab8a2747a87c553e40da1902e9ed1b6e306e8
> >
> > commons-io-2.14.0-bin.tar.gz=a15eb43dede3c82895fe0411963ce2ba7b75716378dd93aa02f68f909f8777fdba8d738d7f895e7c4d6931bf0bba18fd409b5f6c7e0f02452047ac71f8dba313
> >
> > commons-io-2.14.0-javadoc.jar=24ed778593714a8eb200d2daa235ca755f9c8cf06d8b1c0b164df72049b1706d3827bf9ba772297334aa3ff1833f6257249c1bcdb66e4e9e3f6874cd58a1e212
> >
> > commons-io-2.14.0-bom.xml=256580d4b1ef0d6fce4d9379e87d62a05ca1f954abd6864406023800b5679067f50c33d8139dd830a55b016abffa6d8cba97d4f7bb06bae1f4a0307c0fec046a
> >
> > I have tested this with:
> >
> > mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site
> > deploy
> >
> > Using:
> >
> > Apache Maven 3.9.4 (dfbb324ad4a7c8fb0bf182e6d91b0ae20e3d2dd9)
> > Maven home: /usr/local/Cellar/maven/3.9.4/libexec
> > Java version: 17.0.8.1, vendor: Homebrew, runtime:
> > /usr/local/Cellar/openjdk@17/17.0.8.1/libexec/openjdk.jdk/Contents/Home
> > Default locale: en_US, platform encoding: UTF-8
> > OS name: "mac os x", version: "13.5.2", arch: "x86_64", family: "mac"
> > Darwin gdg-mac-mini.local 22.6.0 Darwin Kernel Version 22.6.0: Wed Jul
> >  5 22:21:56 PDT 2023; root:xnu-8796.141.3~6/RELEASE_X86_64 x86_64
> >
> > Details of changes since 2.13.0 are in the release notes:
> >
> > https://dist.apache.org/repos/dist/dev/commons/io/2.14.0-RC1/RELEASE-NOTES.txt
> >
> > https://dist.apache.org/repos/dist/dev/commons/io/2.14.0-RC1/site/changes-report.html
> >
> > Site:
> >
> > https://dist.apache.org/repos/dist/dev/commons/io/2.14.0-RC1/site/index.html
> > (note some *relative* links are broken and the 2.14.0 directories
> > are not yet created - these will be OK once the site is deployed.)
> >
> > RAT Report:
> >
> > https://dist.apache.org/repos/dist/dev/commons/io/2.14.0-RC1/site/rat-report.html
> >
> > KEYS:
> >   https://downloads.apache.org/commons/KEYS
> >
> > Please review the release candidate and vote.
> > This vote will close no sooner than 72 hours from now.
> >
> >   [ ] +1 Release these artifacts
> >   [ ] +0 OK, but...
> >   [ ] -0 OK, but really should fix...
> >   [ ] -1 I oppose this release because...
> >
> > Thank you,
> >
> > Gary Gregory,
> > Release Manager (using key 86fdc7e2a11262cb)
> >
> > For following is intended as a helper and refresher for reviewers.
> >
> > Validating a release candidate
> > ==
> >
> > These guidelines are NOT complete.
> >
> > Requirements: Git, Java, Maven.
> >
> > You can validate a release from a release candidate (RC) tag as follows.
> >
> > 1a)

[logging] Broken link to FAQ in docs

2023-09-29 Thread Ed Brannin 
Hello,

The FAQ link at the bottom of this page is broken:
https://commons.apache.org/proper/commons-logging/guide.html#Frequently_Asked_Questions

The link currently points to:
http://wiki.apache.org/commons/Logging/FrequentlyAskedQuestions

The correct link is:
https://cwiki.apache.org/confluence/display/COMMONS/Logging+FrequentlyAskedQuestions

-- 
Ed Brannin
Software Developer II
bandwidth.com  • Rochester, USA

M: +1-585-261-0279 •

Re: [EMAIL] Fluent interface

2023-09-29 Thread Gary Gregory 
At some point in the future we will have a 2.0 and that's when to revist
this issue. Feel free to create a Jira ticket to request this as a feature
for a future 2.0.

Gary


On Fri, Sep 29, 2023, 7:47 AM Elliotte Rusty Harold 
wrote:

> Personal opinion: it probably wasn't intentional, but please don't do
> that. It doesn't help anyone and is needless churn. Fluent methods are
> not better than non-fluent ones, and are in fact less semantic and
> harder to debug. They prioritize saving code writing over code
> maintainability.
>
> Not just personal opinion: The API MUST not be changed in an
> incompatible way. Changing the return type of an overridable method is
> an incompatible change that is forbidden. Return types of
> non-overridable methods (final, private, or static) might be able to
> be changed, but still shouldn;t be.
>
> On Fri, Sep 29, 2023 at 7:13 AM Filip Strajnar 
> wrote:
> >
> > Greetings,
> >
> >
> > I've noticed that some methods on the org.apache.commons.mail.Email
> > class provide fluent interface (examples include setCc, addBcc,
> > addReplyTo), and some do not (to name a few: setAuthentication,
> > setSmtpPort, setMailSession). Is this intentional, or am I allowed to
> > submit a PR that would change all relevant void methods so that they
> > would return an Email object instead?
> >
> >
> > Sincerely,
> >
> > Filip Strajnar
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
>
>
> --
> Elliotte Rusty Harold
> elh...@ibiblio.org
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Re: [EMAIL] Fluent interface

2023-09-29 Thread Elliotte Rusty Harold 
Personal opinion: it probably wasn't intentional, but please don't do
that. It doesn't help anyone and is needless churn. Fluent methods are
not better than non-fluent ones, and are in fact less semantic and
harder to debug. They prioritize saving code writing over code
maintainability.

Not just personal opinion: The API MUST not be changed in an
incompatible way. Changing the return type of an overridable method is
an incompatible change that is forbidden. Return types of
non-overridable methods (final, private, or static) might be able to
be changed, but still shouldn;t be.

On Fri, Sep 29, 2023 at 7:13 AM Filip Strajnar  wrote:
>
> Greetings,
>
>
> I've noticed that some methods on the org.apache.commons.mail.Email
> class provide fluent interface (examples include setCc, addBcc,
> addReplyTo), and some do not (to name a few: setAuthentication,
> setSmtpPort, setMailSession). Is this intentional, or am I allowed to
> submit a PR that would change all relevant void methods so that they
> would return an Email object instead?
>
>
> Sincerely,
>
> Filip Strajnar
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>


-- 
Elliotte Rusty Harold
elh...@ibiblio.org

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [EMAIL] Fluent interface

2023-09-29 Thread Mike Drob 
I think the natural next question is whether we can have a major version
change?

Mike

On Fri, Sep 29, 2023 at 6:24 AM sebb  wrote:

> On Fri, 29 Sept 2023 at 12:13, Filip Strajnar 
> wrote:
> >
> > Greetings,
> >
> >
> > I've noticed that some methods on the org.apache.commons.mail.Email
> > class provide fluent interface (examples include setCc, addBcc,
> > addReplyTo), and some do not (to name a few: setAuthentication,
> > setSmtpPort, setMailSession). Is this intentional, or am I allowed to
> > submit a PR that would change all relevant void methods so that they
> > would return an Email object instead?
>
> The return type is part of the Java method signature.
>
> Changing it would affect binary compatibility, so would not be
> possible without a major version change.
>
> >
> > Sincerely,
> >
> > Filip Strajnar
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Re: [EMAIL] Fluent interface

2023-09-29 Thread sebb 
On Fri, 29 Sept 2023 at 12:13, Filip Strajnar  wrote:
>
> Greetings,
>
>
> I've noticed that some methods on the org.apache.commons.mail.Email
> class provide fluent interface (examples include setCc, addBcc,
> addReplyTo), and some do not (to name a few: setAuthentication,
> setSmtpPort, setMailSession). Is this intentional, or am I allowed to
> submit a PR that would change all relevant void methods so that they
> would return an Email object instead?

The return type is part of the Java method signature.

Changing it would affect binary compatibility, so would not be
possible without a major version change.

>
> Sincerely,
>
> Filip Strajnar
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[EMAIL] Fluent interface

2023-09-29 Thread Filip Strajnar 

Greetings,


I've noticed that some methods on the org.apache.commons.mail.Email 
class provide fluent interface (examples include setCc, addBcc, 
addReplyTo), and some do not (to name a few: setAuthentication, 
setSmtpPort, setMailSession). Is this intentional, or am I allowed to 
submit a PR that would change all relevant void methods so that they 
would return an Email object instead?



Sincerely,

Filip Strajnar


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org