Re: [VOTE] Release Apache Commons BCEL 6.8.0 based on RC1
+1 everything looks good. Nits, coverage a tad low, cpd, pmd, todo’s Send it -Rob > On Dec 3, 2023, at 11:33 AM, Gary Gregory wrote: > > We have fixed a few bugs and added some enhancements since Apache > Commons BCEL 6.7.0 was released, so I would like to release Apache > Commons BCEL 6.8.0. > > Apache Commons BCEL 6.8.0 RC1 is available for review here: >https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1 (svn > revision 65804) > > The Git tag commons-bcel-6.8.0-RC1 commit for this RC is > cf6f7e710abf4eda2e0aa9aa914aa17878999583 which you can browse here: > > https://gitbox.apache.org/repos/asf?p=commons-bcel.git;a=commit;h=cf6f7e710abf4eda2e0aa9aa914aa17878999583 > You may checkout this tag using: >git clone https://gitbox.apache.org/repos/asf/commons-bcel.git > --branch commons-bcel-6.8.0-RC1 commons-bcel-6.8.0-RC1 > > Maven artifacts are here: > > https://repository.apache.org/content/repositories/orgapachecommons-1678/org/apache/bcel/bcel/6.8.0/ > > These are the artifacts and their hashes: > > #Release SHA-512s > #Sun Dec 03 11:17:12 EST 2023 > bcel-6.8.0-bin.tar.gz=955d66a5a34d25c90c71273467a2f876f3b3fb3437fc533f7a7583ea0390474817aefbb9a9b4190973011ad053e145c9c0bac42832f8198b562e693a25b2803f > bcel-6.8.0-bin.zip=04e5fe2830127add83108de8df61aab185e38a5117dddfa348533260b5d355da1fb0db56b0b5361e680308d2feea6a3b04acc99d6a93b9ad2dfdb943893cb583 > bcel-6.8.0-bom.json=1555e608b267a74adc10938377f8eb60f1b2fa477c1834582ded805530d3cf676ac14d6f1966bdd5d9ccef4cc9f2a32ff1ce6d9b6963fc1d288f8263585b639f > bcel-6.8.0-bom.xml=e1bb499766046147619dd1f1443089b043ee11bf09234c19f14b15261ae54e186c51bd2f7f9f622a71dac1d6a6712bef4c504bd21e975550bef6cfe886c607ba > bcel-6.8.0-javadoc.jar=5fdaa3d79e57a6fcff8e3dfd9295e4681d3f7b35ae6f248b6bee292e46f0f7cff6b80a88f198c6eed6a966be1e59d272e68f3d8dd39cee0b48ce8920e4ef7495 > bcel-6.8.0-sources.jar=a55973bc87409c525860709ff94055808cb46ce13f236f5a119e763ee4a024b9c0c3ac78c80c6e8489f6fc9c535aff8468f09a796889d5dc5c4f9dd593bb337e > bcel-6.8.0-src.tar.gz=fcec4920f841b9b22b7fe05190ed09a31e2edd32dbc9bc6217981af34fecab0725249bbaf0e5810e0c7ef8a347dbe07fa1dfc1a80a7b651368ad4ea852f54f6e > bcel-6.8.0-src.zip=4d7c00f9400b206db48823a77cb09bbb2b25074108e8980c84c701d6b73f77290cf3bed56e392d270c8e084d7c2306ac3fb9b4a4f7f1e6cb883b683f7b3d972e > bcel-6.8.0-test-sources.jar=8924279acde0fc8d101cc27b9e69b514b98a69793c990cadaae193da0fe5913630b99ebfd10568a3baa5e79bd4d93f8020202accf12a6a0e14ef07deb31736db > bcel-6.8.0-tests.jar=4d7715acb6d38d50f8a9e4cbef232190fd3d7efaf54ade772d677e129c89af69a528a1bff6dae6300058f2e1c1393acf18a554c85ac0a6f6d95f0aad4680426c > org.apache.bcel_bcel-6.8.0.spdx.json=dc47d97c197e3e0ce124b7f3a03e74552b6764e46195058d47daca19a597fb49469119115a58e7f3dc951cb851c031e60840e09d94632c4687332049dc305c10 > > I have tested this with: > > mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site deploy > > Using: > > Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae) > Maven home: /usr/local/Cellar/maven/3.9.6/libexec > Java version: 21.0.1, vendor: Homebrew, runtime: > /usr/local/Cellar/openjdk/21.0.1/libexec/openjdk.jdk/Contents/Home > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "14.1.1", arch: "x86_64", family: "mac" > > Darwin 23.1.0 Darwin Kernel Version 23.1.0: Mon Oct 9 21:27:27 > PDT 2023; root:xnu-10002.41.9~6/RELEASE_X86_64 x86_64 > > Details of changes since 6.7.0 are in the release notes: > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/RELEASE-NOTES.txt > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/changes-report.html > > Site: > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/index.html >(note some *relative* links are broken and the 6.8.0 directories > are not yet created - these will be OK once the site is deployed.) > > JApiCmp Report (compared to 6.7.0): > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/japicmp.html > >Note that the above report notes one issue: >MODIFIED (Serializable incompatible(!): field changed from > nontransient to transient) public class > org.apache.bcel.util.ClassVector >Note that a java.util.List of org.apache.bcel.classfile.JavaClass > is not serializable in the first place because JavaClass is not > serializable. > > RAT Report: > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/rat-report.html > > KEYS: > https://downloads.apache.org/commons/KEYS > > Please review the release candidate and vote. > This vote will close no sooner than 72 hours from now. > > [ ] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... > > Thank you, > > Gary Gregory, > Release Manager (using key 86fdc7e2a11262cb) > > For following is intended as a helper and refresher for reviewers. > > Validating a release candidate >
Re: [VOTE] Release Apache Commons Validator 1.8.0 based on RC1
+1 all looks good > On Dec 2, 2023, at 10:26 AM, Gary Gregory wrote: > > We have fixed a few bugs and added some enhancements since Apache > Commons Validator 1.7 was released, so I would like to release Apache > Commons Validator 1.8.0. > > Apache Commons Validator 1.8.0 RC1 is available for review here: >https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1 > (svn revision 65799) > > The Git tag commons-validator-1.8.0-RC1 commit for this RC is > c4b1afc87797f7826b84ae7f024f3d8959781ddd which you can browse here: > > https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=c4b1afc87797f7826b84ae7f024f3d8959781ddd > You may checkout this tag using: >git clone https://gitbox.apache.org/repos/asf/commons-validator.git > --branch commons-validator-1.8.0-RC1 commons-validator-1.8.0-RC1 > > Maven artifacts are here: > > https://repository.apache.org/content/repositories/orgapachecommons-1677/commons-validator/commons-validator/1.8.0/ > > These are the artifacts and their hashes: > > #Release SHA-512s > #Sat Dec 02 10:19:35 EST 2023 > commons-validator-1.8.0-bin.tar.gz=32128ff8ec1d992a1654e1cab0451152e844dd3076c25c80122b331dd4d3546a60b0325476ae079b83a4b8d852dc8dd48fbde64f04d19e22013e99b95b98978e > commons-validator-1.8.0-bin.zip=436aa1b614144b35c644dc7f1725a72b16ba276ef2d66ceafb9964e2a2484cd3438f1d76bf82c8fdd9d6c4da47a34c8bad6897bad77528a7e1531f6c8eedf67a > commons-validator-1.8.0-bom.json=111c721363c61cd2a85a8f6b881b2d0fbaa0b2ac12401458e65e4e39ebc4a68ec339bf21d11d424ef0034ab0ad1239458011444a99843152b5a0c35f8922975a > commons-validator-1.8.0-bom.xml=1ecb419c19dce8d596cbe43e6c1690d8ce121fd1a9907b6e3a85a497517fedc0fa0ffc26acb3f7124672590a48b401e5a149c6d6fae3ee5067de8aabd7233ca7 > commons-validator-1.8.0-javadoc.jar=7a0b2ef23f2feb5f52269c47216f69137c62eec80a64bdd0e7ee7e413fd0d05c5c8b4c054f83a25dae8f0b3e3f4ef46663a05d9e67745196f870d4ce4a6e1b9e > commons-validator-1.8.0-sources.jar=fe6a7039615a53638df01b1100d25a6f38451b58cd5be88027e3bc0f86b40dfa440a8a466b7097054a1133c71089958e5f8a5bf6fad67e6c7bacc9210d04e97a > commons-validator-1.8.0-src.tar.gz=f0c2662e5db0bbc6ee9d05d5508caa02bf45b7c7ada92f4a97a867848f3d704b35552d47859a46567705194248e7b88cd8df8f082939012ab60b6aed446e36b2 > commons-validator-1.8.0-src.zip=530063f04d300c0322ef5c53960bd6dd2ea9879169efe64d28234ac9877b5638876e8ed020a16eb67198d528405d9656f6e94f08ffb7cdfaa0d9e916c77aa32f > commons-validator-1.8.0-test-sources.jar=f111abe654dbc2241d81dbf5b7742c33a1dd304ba1f2ffe902546b1e8b97a7d8940cffd1692e7787124fd08f54a235f92a19ade41fd88a136e5135ea10db4222 > commons-validator-1.8.0-tests.jar=bc5440747c3192574b75378fceb535ab7f988403d24fb1fb9ca74de30a5d7790fb9ed953bda3c727b5552778cdcf03e7e85500fadb3350a888c8adaf86da957d > commons-validator_commons-validator-1.8.0.spdx.json=36d397ce0e251258ec7a6a90f54a1d76585762e9ee680160b79979f73f4c31e506e8b6bc6e07186db83bc0e34a9996ccbefc069569f69753ef4fea2cdd40bb8b > > I have tested this with > > mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site deploy > > Using: > > Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae) > Maven home: /usr/local/Cellar/maven/3.9.6/libexec > Java version: 21.0.1, vendor: Homebrew, runtime: > /usr/local/Cellar/openjdk/21.0.1/libexec/openjdk.jdk/Contents/Home > Default locale: en_US, platform encoding: UTF-8 > OS name: "mac os x", version: "14.1.1", arch: "x86_64", family: "mac" > > Darwin 23.1.0 Darwin Kernel Version 23.1.0: Mon Oct 9 21:27:27 > PDT 2023; root:xnu-10002.41.9~6/RELEASE_X86_64 x86_64 > > Details of changes since 1.7 are in the release notes: > > https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/RELEASE-NOTES.txt > > https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/site/changes-report.html > > Site: > > https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/site/index.html >(note some *relative* links are broken and the 1.8.0 directories > are not yet created - these will be OK once the site is deployed.) > > JApiCmp Report (compared to 1.7): > > https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/site/japicmp.html > > RAT Report: > > https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/site/rat-report.html > > KEYS: > https://downloads.apache.org/commons/KEYS > > Please review the release candidate and vote. > This vote will close no sooner than 72 hours from now. > > [ ] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... > > Thank you, > > Gary Gregory, > Release Manager (using key 86fdc7e2a11262cb) > > For following is intended as a helper and refresher for reviewers. > > Validating a release candidate > == > > These guidelines are NOT complete. > > Requirements: Git, Java, Maven. > > You can validate a release from a release candidate (RC) tag as follows. > > 1a) Clone and checkout
Re: [CRYPTO] Basic SSL 3.x support added
On Fri, 24 Nov 2023 at 13:44, sebb wrote: > > On Thu, 23 Nov 2023 at 11:57, sebb wrote: > > > > The test suite now runs on ubuntu-latest, windows-latest and > > macos-latest with Java 8,11,17,21 > > > > On macOS, the OpenSSL library path has to be provided, otherwise the > > test can crash with > > > > '"...bin/java is loading libcrypto in an unsafe way" > > > > AFAICT, this is where libcrypto.dylib does not resolve to a filename > > that contains a version number. > > (Normally libcrypto.dylib is a link pointing to libcrypto.1.1.dylib or > > similar in the same directory) > > > > I have not yet found this lone library, so I am beginning to wonder if > > it is in the dylib cache? > > On further investigation, it appears that the default crypto library > is a dummy that does not have an in-built version. > It does not matter if the file name includes a version or not. That > was a red herring. > > > If so, then macOS will always require the library path to be provided. > > The user will either have to provide jn[ai].library.path or ensure > that there is a suitable library in the current working directory. > (This can be a soft link) > > > I don't think it's possible to trap the error, so it cannot be > > automatically recovered. > > It might perhaps be possible to use dlopen_preflight() to check if a > > file exists; will need to run further checks. > > > > AFAICT, dlopen_preflight() returns true if (and only if) the library > load will succeed, so could be used to avoid a crash. > It has to do the same checks as dlopen(), so should only be used if necessary. > > I think it would make sense to only do the check if the user has not > provided a library path. > This could be added to the JNI loads quite easily. > > However so far I have been unable to get the method working in the JNA case. > It would need to be done in an independent class that is only loaded on macOS. That issue is now resolved for both JNI and JNA. I think the code is now in quite a good state. > > On Sat, 18 Nov 2023 at 03:26, Alex Remily wrote: > > > > > > Just pulled master and successfully ran tests against OpenSSL 3.1.3 on Mac > > > OS 11 BigSur. Nice work sebb! > > > > > > Apache Commons Crypto 1.2.1-SNAPSHOT > > > > > > Native code loaded OK: 1.2.1-SNAPSHOT > > > > > > Native name: Apache Commons Crypto > > > > > > Native built: Nov 17 2023 > > > > > > OpenSSL library loaded OK, version: 0x30100030 > > > > > > OpenSSL library info: OpenSSL 3.1.3 19 Sep 2023 > > > > > > DLL name: libcrypto.dylib > > > > > > DLL path: /usr/local/Cellar/openssl@3/3.1.3/lib/libcrypto.3.dylib > > > > > > Additional OpenSSL_version(n) details: > > > > > > OpenSSLVersion(1): compiler: clang -fPIC -arch x86_64 -O3 -Wall -DL_ENDIAN > > > -DOPENSSL_PIC -D_REENTRANT -DOPENSSL_BUILDING_OPENSSL -DNDEBUG > > > > > > OpenSSLVersion(2): built on: Tue Sep 19 13:01:49 2023 UTC > > > > > > OpenSSLVersion(3): platform: darwin64-x86_64-cc > > > > > > OpenSSLVersion(4): OPENSSLDIR: "/usr/local/etc/openssl@3" > > > > > > OpenSSLVersion(5): ENGINESDIR: "/usr/local/Cellar/openssl@3 > > > /3.1.3/lib/engines-3" > > > > > > OpenSSLVersion(6): 3.1.3 > > > > > > OpenSSLVersion(7): 3.1.3 > > > > > > OpenSSLVersion(8): MODULESDIR: "/usr/local/Cellar/openssl@3 > > > /3.1.3/lib/ossl-modules" > > > > > > OpenSSLVersion(9): CPUINFO: OPENSSL_ia32cap=0x7ffaf3eb:0x27ab > > > > > > Random instance created OK: > > > org.apache.commons.crypto.random.OpenSslCryptoRandom@30c4e352 > > > > > > Cipher AES/CTR/NoPadding instance created OK: > > > org.apache.commons.crypto.cipher.OpenSslCipher@673c4f6e > > > > > > On Tue, Nov 14, 2023 at 8:27 AM sebb wrote: > > > > > > > On Tue, 14 Nov 2023 at 13:17, Alex Remily wrote: > > > > > > > > > > That's fantastic. I read that there were big API changes with the > > > > > move > > > > to > > > > > OpenSSL 3, but maybe those changes were not in the functionality that > > > > > commons crypto exposes. Have you merged into master yet? I look > > > > > forward > > > > > to playing around with it. > > > > > > > > Yes, it is in master. > > > > > > > > > Alex > > > > > > > > > > On Wed, Nov 8, 2023 at 7:12 PM sebb wrote: > > > > > > > > > > > Crypto now builds and tests OK on > > > > > > macOS-latest - OpenSSL 3.1.4 24 Oct 2023 > > > > > > and > > > > > > Ubuntu-latest - OpenSSL 3.0.2 15 Mar 2022 > > > > > > Tested with Java 8 and 21 > > > > > > > > > > > > I only had to allow for two changed names: > > > > > > > > > > > > EVP_CIPHER_CTX_block_size => EVP_CIPHER_CTX_get_block_size > > > > > > EVP_CIPHER_flags => EVP_CIPHER_get_flags > > > > > > > > > > > > This seems too easy, so I suspect there may be some missing tests. > > > > > > > > > > > > Sebb > > > > > > > > > > > > - > > > > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > > > > > > > > > > > > > >
Re: [VOTE] Release Apache Commons BCEL 6.8.0 based on RC1
[ +1 ] Built locally using: mvn -s "$HOME/.m2/commons-settings.xml" -P jacoco -P japicmp clean package site On: Darwin henrib-MBP16 23.1.0 Darwin Kernel Version 23.1.0: Mon Oct 9 21:27:24 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T6000 arm64 With: OpenJDK Runtime Environment (Zulu 8.66.0.15-CA-macos-aarch64) (build 1.8.0_352-b08) OpenJDK 64-Bit Server VM (Zulu 8.66.0.15-CA-macos-aarch64) (build 25.352-b08, mixed mode) Compile, tests and generates site. Not precluding release but release notes are *not* 6.8.0 but still 6.7 and test coverage is a tad low (hopefully, it goes up with versions...). - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [VOTE] Release Apache Commons Validator 1.8.0 based on RC1
[ +1 ] Built using: mvn -s "$HOME/.m2/commons-settings.xml" -P jacoco -P japicmp clean package site On: Darwin henrib-MBP16 23.1.0 Darwin Kernel Version 23.1.0: Mon Oct 9 21:27:24 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T6000 arm64 With: OpenJDK Runtime Environment (Zulu 8.66.0.15-CA-macos-aarch64) (build 1.8.0_352-b08) Build, tests and site are ok. Nothing to stop releasing but coverage is not great for some (one liner) methods; Javadoc could link to replacement instead of just stating their name; release-notes are crude. - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
