[BCEL] help for https://github.com/apache/commons-bcel/pull/254#pullrequestreview-1802310976

2024-01-03 Thread Gary Gregory
Hi all,

If anyone has recollections or answers for questions in
https://github.com/apache/commons-bcel/pull/254#pullrequestreview-1802310976
please post.

TY!
Gary


Re: [VOTE] Release Apache Commons Exec 1.4.0 based on RC1

2024-01-03 Thread Rob Tompkins
+1 signatures good, builds on java 8, 11, 17, and 21, reports all good, 
RELEASE-NOTES.txt good. Nit, the coverage is a touch low, but this is a very 
minor nit.

Send it!!!

Cheers,
-Rob

> On Jan 1, 2024, at 7:29 AM, Gary Gregory  wrote:
> 
> We have fixed a few bugs and added some enhancements since Apache
> Commons Exec 1.3 was released, so I would like to release Apache
> Commons Exec 1.4.0.
> 
> Apache Commons Exec 1.4.0 RC1 is available for review here:
>https://dist.apache.org/repos/dist/dev/commons/exec/1.4.0-RC1 (svn
> revision 66375)
> 
> The Git tag commons-exec-1.4.0-RC1 commit for this RC is
> 00307444cc1274f631c0e0931472b3d01cf4b4dd which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-exec.git;a=commit;h=00307444cc1274f631c0e0931472b3d01cf4b4dd
> You may checkout this tag using:
>git clone https://gitbox.apache.org/repos/asf/commons-exec.git
> --branch commons-exec-1.4.0-RC1 commons-exec-1.4.0-RC1
> 
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1683/org/apache/commons/commons-exec/1.4.0/
> 
> These are the artifacts and their hashes:
> 
> #Release SHA-512s
> #Mon Jan 01 12:15:41 UTC 2024
> commons-exec-1.4.0-bin.tar.gz=4835da440d9f88bba7253b544647272fa4a6a298afcd99e4e83e58d1a9d16d18f05ee58a251719033e2f6b321d08cc0db6d23230b79a5cf451aea5e1a7041e04
> commons-exec-1.4.0-bin.zip=35b806102a714ea8a269b74eb126a6c04968fa2ea61d8e88ffdef5f71583859675d60caef7752c6db63f37e1c8056143f0ad657a5022fc1263e13274c01427ca
> commons-exec-1.4.0-bom.json=eee53518c448730d2a4d21c674399098f49ae8123a079cd03b68fc614cc5b8a1ad8aea62b81d0f347629b75644623c2ef1e44d69890b31c2ede51d0ca55d4db9
> commons-exec-1.4.0-bom.xml=dbbda1effcaa4a66c9d3842f21030a3cc0645168534fcf7745e59b9ae08661f31a2389c2cd8651fede38f06d3b5688e7dae381785854f51dd4369d54a7b03cb3
> commons-exec-1.4.0-javadoc.jar=a8084e90c4941000c93185d89d60752a1652b1fb7d5d372bb5292921a7927bfd0a9fab59039d914df46e224e60a20ed1c68d7f55d518474f06d8ee9891270bc6
> commons-exec-1.4.0-sources.jar=d09a1275677b71ea86f2536baf28290c06b069ea57001b7ab86a18edad5decc794a811bfc8d6ad194ee514ab0155e5742d7348c47a72b63dfdd6605b3a6f633d
> commons-exec-1.4.0-src.tar.gz=18ec2f138100e7d029425b805093a40f9ae86362c2ce82bc828716c7c4eda6df64b17a4798afe05925d2730488b9d7cef1425d0ef5229345c77a00ffa250de9f
> commons-exec-1.4.0-src.zip=26fa7c3707a9cfddf4c197844a8f216e3c02fc846ea7d68611807e4eabcfab909d26b9ec67dc0c1a1f6438006728a05a5610227559fa8b8ae05f5bea901d0c51
> commons-exec-1.4.0-test-sources.jar=971236b9a856d93f3cd38f29e48cdb5f890c205d28c1b810bc199283b3bee244535c5e9da22c3def1d76e8e8523385a2feedab73159eca9aa9fd28121cbe71c4
> commons-exec-1.4.0-tests.jar=06f1eda8d81c74b15a8eb8fc6009ff00bed943df6edcdbf6a106d93d98372ea7f214bfbd44ec46d998b64ff51d858d1363a5ff1c2da40236fcf608871f9f67a1
> org.apache.commons_commons-exec-1.4.0.spdx.json=cf16ce26bb47d078a2578cce0cd11e333d7428406d7537b952ff3a7e8ff3c61747415007abe394654a44e8c1080444bf21d15638c6285223bcebea855f288360
> 
> I have tested this with:
> 
> export TZ=UTC
> mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site deploy
> mvn clean package artifact:compare -Dreference.repo=apache.snapshots
> -DskipTests -Dcommons.spdx.version=0.7.1 -Dspdx.skip
> 
> using:
> 
> Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> Maven home: /usr/local/Cellar/maven/3.9.6/libexec
> Java version: 21.0.1, vendor: Homebrew, runtime:
> /usr/local/Cellar/openjdk/21.0.1/libexec/openjdk.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "14.2.1", arch: "x86_64", family: "mac"
> 
> Darwin  23.2.0 Darwin Kernel Version 23.2.0: Wed Nov 15 21:54:10
> PST 2023; root:xnu-10002.61.3~2/RELEASE_X86_64 x86_64
> 
> Details of changes since 1.3 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/exec/1.4.0-RC1/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/exec/1.4.0-RC1/site/changes-report.html
> 
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/exec/1.4.0-RC1/site/index.html
>(note some *relative* links are broken and the 1.4.0 directories
> are not yet created - these will be OK once the site is deployed.)
> 
> JApiCmp Report (compared to 1.3):
>
> https://dist.apache.org/repos/dist/dev/commons/exec/1.4.0-RC1/site/japicmp.html
> 
> RAT Report:
>
> https://dist.apache.org/repos/dist/dev/commons/exec/1.4.0-RC1/site/rat-report.html
> 
> KEYS:
>  https://downloads.apache.org/commons/KEYS
> 
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
> 
>  [ ] +1 Release these artifacts
>  [ ] +0 OK, but...
>  [ ] -0 OK, but really should fix...
>  [ ] -1 I oppose this release because...
> 
> Thank you,
> 
> Gary Gregory,
> Release Manager (using key 86fdc7e2a11262cb)
> 
> For following is intended as a helper and refresher for reviewers.
> 
> Validating a release candidate
> ==