Re: [VOTE] Release Apache Commons Validator 1.9.0 based on RC1

2024-05-26 Thread Gary Gregory 
My +1

Gary


On Sat, May 25, 2024, 5:11 PM Gary Gregory  wrote:

> We have fixed a few bugs and added enhancements since Apache Commons
> Validator 1.8.0 was released, so I would like to release Apache
> Commons Validator 1.9.0.
>
> Apache Commons Validator 1.9.0 RC1 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1
> (svn revision 69387)
>
> The Git tag commons-validator-1.9.0-RC1 commit for this RC is
> 191171b2fb1500d24c42a809cf13386ac8f4ecac which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=191171b2fb1500d24c42a809cf13386ac8f4ecac
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-validator.git
> --branch
> 
> commons-validator-1.9.0-RC1 commons-validator-1.9.0-RC1
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1734/commons-validator/commons-validator/1.9.0/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Sat May 25 20:36:23 UTC 2024
>
> commons-validator-1.9.0-bin.tar.gz=a755d2be1b9fb3cb75cb71c2c6143969eabd8ba48401dd86cad6c658e0de72e52a887e157ef38e780471382c2da68db228866303f3d4cb4500f995b8b3967476
>
> commons-validator-1.9.0-bin.zip=7c0cb444f4e162c46cbd356c8a3c8b166b06bcaf79b6c433ee5ad585498a1f0b4dfef3606ca4beedeef418b5b56209f86cac6dd2c1c8fa4dfe62c679df0018db
>
> commons-validator-1.9.0-bom.json=7e9baecc1b58f5de101d247b95d871a5b3227603a99eddf8bcce07e3656024dffc615b8ec0b765376bf640f9596581cb483830861878474fe79339bb84352cd3
>
> commons-validator-1.9.0-bom.xml=d4a5d380ade4eec7f7a71cb260a61901b5945129bc448894c89ae10d3375a4dac2898be6498eb3aaba60cd8c464837f7884521fc467285c0fc2f129b92e52bf9
>
> commons-validator-1.9.0-javadoc.jar=b4b3dee67453e72ea070140d858ff66c45ed5794b69b68760639726cea0edba1224cb2c1cda64411893ded0ba96e2758a7677e2ffa21249899630e39949d88ed
>
> commons-validator-1.9.0-sources.jar=f91890e90979ed1c7abcebb4b37f223a163bfc73bc3da6a4bc3469d399e7d0ff9315d89e528bab88b53cd0ef0a1c3f8c7e0e463a784f47546ae8ca8f3d4c2269
>
> commons-validator-1.9.0-src.tar.gz=4e36f0ec5b1b8ae9724f020c51396332444d7359988fbcceaab004cde30e223b8130315e85d9b3d568fdc30399e9e503783bb81f217fe5f846f9e14c484a1fe0
>
> commons-validator-1.9.0-src.zip=201ee0723d5f078b128aa7a54bc2b03494c467e6f2df843d74bf3607d085067a0ea395e1e2174fd3237248f18f8bc5e7469e72fc9378813cbe7e5397e20c03d1
>
> commons-validator-1.9.0-test-sources.jar=6fee6648f66e666ff49e99ef3ee49039436bd19b150eb2294d3b6a0e57dab7c0a9e7bcaecde005c478f24a21729d59365e4deb096a579b5044aafa513c90972c
>
> commons-validator-1.9.0-tests.jar=2c2a13fd3c242c1ab06e9ef8f6f18ed3eae392b8fb0a5c9bbce137ce0e9873820c37197a8517984a42d4804433501521c5f5970ef8ae868f8c6d2a061e88b05e
>
> commons-validator_commons-validator-1.9.0.spdx.json=bd19d362ae59afbe41425f57e02d4d5c32f99b9e218ebdf6ea8eaa388cb9fb28721e93781f084533e98eb345d9d7bc5a96790e06e0ac1f0d0aaff6db063042fe
>
> I have tested this with 'mvn' and 'mvn -V -Prelease -Ptest-deploy -P
> jacoco -P japicmp clean package site deploy' using:
>
> openjdk version "17.0.11" 2024-04-16
> OpenJDK Runtime Environment Homebrew (build 17.0.11+0)
> OpenJDK 64-Bit Server VM Homebrew (build 17.0.11+0, mixed mode, sharing)
>
> Apache Maven 3.9.7 (8b094c9513efc1b9ce2d952b3b9c8eaedaf8cbf0)
> Maven home: /usr/local/Cellar/maven/3.9.7/libexec
> Java version: 17.0.11, vendor: Homebrew, runtime:
> /usr/local/Cellar/openjdk@17/17.0.11/libexec/openjdk.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "14.5", arch: "x86_64", family: "mac"
>
> Darwin  23.5.0 Darwin Kernel Version 23.5.0: Wed May  1 20:09:52
> PDT 2024; root:xnu-10063.121.3~5/RELEASE_X86_64 x86_64
>
> Details of changes since 1.8.0 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/site/changes-report.html
>
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/site/index.html
> (note some *relative* links are broken and the 1.9.0 directories
> are not yet created - these will be OK once the site is deployed.)
>
> JApiCmp Report (compared to 1.8.0):
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/site/japicmp.html
>
> RAT Report:
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/site/rat-report.html
>
> KEYS:
>   https://downloads.apache.org/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thank you,
>
> Gary Gregory,
> Release Manager (using key 86fdc7e2a11262cb)
>
> For following is intended as a helper and refresher for reviewers.
>
> Validating a

Re: [VOTE] Release Apache Commons Validator 1.9.0 based on RC1

2024-05-26 Thread Phil Steitz 
[+1]
Checked build, sigs, reports, notes.  All look good.
Tested on
Apache Maven 3.9.3
Java version: 17.0.10, java-17-openjdk-amd64
OS name: "linux", version: "5.15.0-107-generic", arch: "amd64", family:
"unix"

Phil


On Sat, May 25, 2024 at 2:12 PM Gary Gregory  wrote:

> We have fixed a few bugs and added enhancements since Apache Commons
> Validator 1.8.0 was released, so I would like to release Apache
> Commons Validator 1.9.0.
>
> Apache Commons Validator 1.9.0 RC1 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1
> (svn revision 69387)
>
> The Git tag commons-validator-1.9.0-RC1 commit for this RC is
> 191171b2fb1500d24c42a809cf13386ac8f4ecac which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=191171b2fb1500d24c42a809cf13386ac8f4ecac
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-validator.git
> --branch
> 
> commons-validator-1.9.0-RC1 commons-validator-1.9.0-RC1
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1734/commons-validator/commons-validator/1.9.0/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Sat May 25 20:36:23 UTC 2024
>
> commons-validator-1.9.0-bin.tar.gz=a755d2be1b9fb3cb75cb71c2c6143969eabd8ba48401dd86cad6c658e0de72e52a887e157ef38e780471382c2da68db228866303f3d4cb4500f995b8b3967476
>
> commons-validator-1.9.0-bin.zip=7c0cb444f4e162c46cbd356c8a3c8b166b06bcaf79b6c433ee5ad585498a1f0b4dfef3606ca4beedeef418b5b56209f86cac6dd2c1c8fa4dfe62c679df0018db
>
> commons-validator-1.9.0-bom.json=7e9baecc1b58f5de101d247b95d871a5b3227603a99eddf8bcce07e3656024dffc615b8ec0b765376bf640f9596581cb483830861878474fe79339bb84352cd3
>
> commons-validator-1.9.0-bom.xml=d4a5d380ade4eec7f7a71cb260a61901b5945129bc448894c89ae10d3375a4dac2898be6498eb3aaba60cd8c464837f7884521fc467285c0fc2f129b92e52bf9
>
> commons-validator-1.9.0-javadoc.jar=b4b3dee67453e72ea070140d858ff66c45ed5794b69b68760639726cea0edba1224cb2c1cda64411893ded0ba96e2758a7677e2ffa21249899630e39949d88ed
>
> commons-validator-1.9.0-sources.jar=f91890e90979ed1c7abcebb4b37f223a163bfc73bc3da6a4bc3469d399e7d0ff9315d89e528bab88b53cd0ef0a1c3f8c7e0e463a784f47546ae8ca8f3d4c2269
>
> commons-validator-1.9.0-src.tar.gz=4e36f0ec5b1b8ae9724f020c51396332444d7359988fbcceaab004cde30e223b8130315e85d9b3d568fdc30399e9e503783bb81f217fe5f846f9e14c484a1fe0
>
> commons-validator-1.9.0-src.zip=201ee0723d5f078b128aa7a54bc2b03494c467e6f2df843d74bf3607d085067a0ea395e1e2174fd3237248f18f8bc5e7469e72fc9378813cbe7e5397e20c03d1
>
> commons-validator-1.9.0-test-sources.jar=6fee6648f66e666ff49e99ef3ee49039436bd19b150eb2294d3b6a0e57dab7c0a9e7bcaecde005c478f24a21729d59365e4deb096a579b5044aafa513c90972c
>
> commons-validator-1.9.0-tests.jar=2c2a13fd3c242c1ab06e9ef8f6f18ed3eae392b8fb0a5c9bbce137ce0e9873820c37197a8517984a42d4804433501521c5f5970ef8ae868f8c6d2a061e88b05e
>
> commons-validator_commons-validator-1.9.0.spdx.json=bd19d362ae59afbe41425f57e02d4d5c32f99b9e218ebdf6ea8eaa388cb9fb28721e93781f084533e98eb345d9d7bc5a96790e06e0ac1f0d0aaff6db063042fe
>
> I have tested this with 'mvn' and 'mvn -V -Prelease -Ptest-deploy -P
> jacoco -P japicmp clean package site deploy' using:
>
> openjdk version "17.0.11" 2024-04-16
> OpenJDK Runtime Environment Homebrew (build 17.0.11+0)
> OpenJDK 64-Bit Server VM Homebrew (build 17.0.11+0, mixed mode, sharing)
>
> Apache Maven 3.9.7 (8b094c9513efc1b9ce2d952b3b9c8eaedaf8cbf0)
> Maven home: /usr/local/Cellar/maven/3.9.7/libexec
> Java version: 17.0.11, vendor: Homebrew, runtime:
> /usr/local/Cellar/openjdk@17/17.0.11/libexec/openjdk.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "14.5", arch: "x86_64", family: "mac"
>
> Darwin  23.5.0 Darwin Kernel Version 23.5.0: Wed May  1 20:09:52
> PDT 2024; root:xnu-10063.121.3~5/RELEASE_X86_64 x86_64
>
> Details of changes since 1.8.0 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/site/changes-report.html
>
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/site/index.html
> (note some *relative* links are broken and the 1.9.0 directories
> are not yet created - these will be OK once the site is deployed.)
>
> JApiCmp Report (compared to 1.8.0):
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/site/japicmp.html
>
> RAT Report:
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/site/rat-report.html
>
> KEYS:
>   https://downloads.apache.org/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1

Re: Re: [LANG] Support single quotes in DurationFormatUtils methods' formats

2024-05-26 Thread sebb 
On Sun, 26 May 2024 at 08:25, Laertes Moustakas  wrote:
>
> Hello Gary,
>
> Thank you for your response. Some of the new assertions indeed fail when 
> interpreting the duplicate single quote as an escaped quote instead of a 
> closing and opening quote. In particular, "y' ''years' M 'months'" is 
> interpreted as "4 'years 0 months" while the expected text lacks the quote 
> before "years". Same for "hello''world": it's interpreted as "hello'world" 
> instead of "helloworld".

Please see https://github.com/apache/commons-lang/pull/1227 for an
alternate solution.
This does not cause issues with any existing tests.

However, it does change the behaviour of a duplicate single quote
which is found outside an existing opening and closing quote.
Instead of the empty string, it generates a lone single quote.

Whilst this is a change in behaviour, it seems to me that there should
be no need for anyone to use a format that uses a pair of adjacent
single quotes to generate an empty string in the output, so it seems
unlikely that this will cause any breakages.

> I understand this brings forth a breaking change in formats that use two 
> single quotes to close and open new literals (or even add an empty string), 
> but this is consistent with what java.text.SimpleDateFormat expects. And I 
> believe that most developers would favor consistency between format strings 
> in equivalent classes. Thus, I think the cases described above where the two 
> single quotes terminate and begin a literal should no longer be supported.
>
> Should this change go forward, I expect it to be part of a major release 
> (e.g. version 4.0.0, 5.0.0, etc.) instead of 3.x.x, as it does contain a 
> breaking change.
>
> If you have more questions, please don't hesitate to contact me.
>
> Best regards,
> Laertes
>
> On 2024/05/25 13:47:23 Gary Gregory wrote:
> > Hello Laertes,
> >
> > Thank you for your interest in improving Apache Commons Lang :-)
> >
> > Do you foresee any compatibility issues for existing call sites and
> > format strings?
> >
> > For example, can you make your use cases work and still support:
> >
> > https://github.com/apache/commons-lang/blob/d861f1b2116a41a45949d1401785220119a57e56/src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java#L463-L473
> >
> > Or, should these cases no longer be supported?
> >
> > TY!
> > Gary
> >
> > On Fri, May 24, 2024 at 4:15 PM Laertes Moustakas  wrote:
> > >
> > > Greetings,
> > >
> > > org.apache.commons.lang3.time.DurationFormatUtils contains useful methods
> > > to format a duration or period of milliseconds in the textual
> > > representation given by the format argument. It even allows arbitrary text
> > > to be printed between single quotes, on the condition that any opening
> > > single quotes will eventually close with another single quote.
> > >
> > > For example,
> > > DurationFormatUtils.formatDuration(64000L, "mm:ss")
> > > will return "01:04".
> > >
> > > While
> > > DurationFormatUtils.formatDuration(1804000L, "m'min' s'sec'")
> > > will yield "34min 4sec".
> > >
> > > However, as per the JavaDoc page for this class
> > > 
> > > including
> > > a single quote is currently not supported. Other classes that format
> > > datetime such as the java.text.SimpleDateFormat do, by putting two single
> > > quotes next to each other.
> > >
> > > So something like
> > > new SimpleDateFormat("mm'' ss'sec'").format(new Date()); // note the two
> > > single quotes after "mm"
> > > will return something like this:
> > > "42' 02sec"
> > >
> > > Instead,
> > > DurationFormatUtils.formatDuration(64000L, "mm'' ss'sec'")
> > > will return "01 04sec".
> > >
> > > I wish to implement support for single quotes in the DurationFormatUtils
> > > format the same way SimpleDateFormat does; by escaping it with two
> > > consecutive single quote characters. I have searched the mailing list and
> > > found no similar request. I have already tested on the copy of a source
> > > code, including adding tests, and no test throughout the commons-lang
> > > project failed.
> > >
> > > Please let me know if this is an acceptable change, and the next steps to
> > > take should this move forward.
> > >
> > > Best regards,
> > > Laertes Moustakas
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
> >

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: Javadoc usability

2024-05-26 Thread Gary D. Gregory 
Emmanuel,

It looks like you updated the Commons Parent POM to add a profile without 
documenting the change in changes.xml. Would you please do that?

TY,
Gary

On 2024/05/18 12:21:54 sebb wrote:
> If we are changing the Javadoc settings, we should update the footer
> to include the full list of attributions.
> 
> On Sat, 18 May 2024 at 12:59, Emmanuel Bourg  wrote:
> >
> > Le 18/05/2024 à 13:07, Gary Gregory a écrit :
> > > You must be talking about this:
> > >
> > > https://bugs.openjdk.org/browse/JDK-8202961
> > >
> > > The frames command line option might be completely gone from the current
> > > Java version but I haven't tried
> >
> > Digging a bit, frames were deprecated in JDK 11 and eventually removed
> > in JDK 13 [1].
> >
> >
> > > I don't think we should use an antique version of the doclet.
> >
> > As long as a component doesn't require Java 13+ we could at least keep
> > the frames, for example by adding the -frame option to the javadoc
> > plugin configuration in the parent pom when building with JDK 11.
> >
> > Emmanuel Bourg
> >
> >
> > [1] https://bugs.openjdk.org/browse/JDK-8215599
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
> 
> 

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Apache Commons Validator 1.9.0 based on RC1

2024-05-26 Thread Gary Gregory 
Tomas,

The link you provided is not relevant to Commons CLI because the class
SetUniqueList from Commons Collections the link mentions is not used
by CLI, so there is nothing to change.

Gary

On Sun, May 26, 2024 at 10:06 AM Tomas Lanik  wrote:
>
> Hi All,
> Has the security issue (
> https://devhub.checkmarx.com/cve-details/Cx78f40514-81ff/ ) related
> to commons-collections:commons-collections:3.2.2 been addressed?
> I can not see it in release notes.
>
> FYI
>
> Tom
>
> On Sat, May 25, 2024 at 11:12 PM Gary Gregory  wrote:
>
> > We have fixed a few bugs and added enhancements since Apache Commons
> > Validator 1.8.0 was released, so I would like to release Apache
> > Commons Validator 1.9.0.
> >
> > Apache Commons Validator 1.9.0 RC1 is available for review here:
> > https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1
> > (svn revision 69387)
> >
> > The Git tag commons-validator-1.9.0-RC1 commit for this RC is
> > 191171b2fb1500d24c42a809cf13386ac8f4ecac which you can browse here:
> >
> > https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=191171b2fb1500d24c42a809cf13386ac8f4ecac
> > You may checkout this tag using:
> > git clone https://gitbox.apache.org/repos/asf/commons-validator.git
> > --branch
> > 
> > commons-validator-1.9.0-RC1 commons-validator-1.9.0-RC1
> >
> > Maven artifacts are here:
> >
> > https://repository.apache.org/content/repositories/orgapachecommons-1734/commons-validator/commons-validator/1.9.0/
> >
> > These are the artifacts and their hashes:
> >
> > #Release SHA-512s
> > #Sat May 25 20:36:23 UTC 2024
> >
> > commons-validator-1.9.0-bin.tar.gz=a755d2be1b9fb3cb75cb71c2c6143969eabd8ba48401dd86cad6c658e0de72e52a887e157ef38e780471382c2da68db228866303f3d4cb4500f995b8b3967476
> >
> > commons-validator-1.9.0-bin.zip=7c0cb444f4e162c46cbd356c8a3c8b166b06bcaf79b6c433ee5ad585498a1f0b4dfef3606ca4beedeef418b5b56209f86cac6dd2c1c8fa4dfe62c679df0018db
> >
> > commons-validator-1.9.0-bom.json=7e9baecc1b58f5de101d247b95d871a5b3227603a99eddf8bcce07e3656024dffc615b8ec0b765376bf640f9596581cb483830861878474fe79339bb84352cd3
> >
> > commons-validator-1.9.0-bom.xml=d4a5d380ade4eec7f7a71cb260a61901b5945129bc448894c89ae10d3375a4dac2898be6498eb3aaba60cd8c464837f7884521fc467285c0fc2f129b92e52bf9
> >
> > commons-validator-1.9.0-javadoc.jar=b4b3dee67453e72ea070140d858ff66c45ed5794b69b68760639726cea0edba1224cb2c1cda64411893ded0ba96e2758a7677e2ffa21249899630e39949d88ed
> >
> > commons-validator-1.9.0-sources.jar=f91890e90979ed1c7abcebb4b37f223a163bfc73bc3da6a4bc3469d399e7d0ff9315d89e528bab88b53cd0ef0a1c3f8c7e0e463a784f47546ae8ca8f3d4c2269
> >
> > commons-validator-1.9.0-src.tar.gz=4e36f0ec5b1b8ae9724f020c51396332444d7359988fbcceaab004cde30e223b8130315e85d9b3d568fdc30399e9e503783bb81f217fe5f846f9e14c484a1fe0
> >
> > commons-validator-1.9.0-src.zip=201ee0723d5f078b128aa7a54bc2b03494c467e6f2df843d74bf3607d085067a0ea395e1e2174fd3237248f18f8bc5e7469e72fc9378813cbe7e5397e20c03d1
> >
> > commons-validator-1.9.0-test-sources.jar=6fee6648f66e666ff49e99ef3ee49039436bd19b150eb2294d3b6a0e57dab7c0a9e7bcaecde005c478f24a21729d59365e4deb096a579b5044aafa513c90972c
> >
> > commons-validator-1.9.0-tests.jar=2c2a13fd3c242c1ab06e9ef8f6f18ed3eae392b8fb0a5c9bbce137ce0e9873820c37197a8517984a42d4804433501521c5f5970ef8ae868f8c6d2a061e88b05e
> >
> > commons-validator_commons-validator-1.9.0.spdx.json=bd19d362ae59afbe41425f57e02d4d5c32f99b9e218ebdf6ea8eaa388cb9fb28721e93781f084533e98eb345d9d7bc5a96790e06e0ac1f0d0aaff6db063042fe
> >
> > I have tested this with 'mvn' and 'mvn -V -Prelease -Ptest-deploy -P
> > jacoco -P japicmp clean package site deploy' using:
> >
> > openjdk version "17.0.11" 2024-04-16
> > OpenJDK Runtime Environment Homebrew (build 17.0.11+0)
> > OpenJDK 64-Bit Server VM Homebrew (build 17.0.11+0, mixed mode, sharing)
> >
> > Apache Maven 3.9.7 (8b094c9513efc1b9ce2d952b3b9c8eaedaf8cbf0)
> > Maven home: /usr/local/Cellar/maven/3.9.7/libexec
> > Java version: 17.0.11, vendor: Homebrew, runtime:
> > /usr/local/Cellar/openjdk@17/17.0.11/libexec/openjdk.jdk/Contents/Home
> > Default locale: en_US, platform encoding: UTF-8
> > OS name: "mac os x", version: "14.5", arch: "x86_64", family: "mac"
> >
> > Darwin  23.5.0 Darwin Kernel Version 23.5.0: Wed May  1 20:09:52
> > PDT 2024; root:xnu-10063.121.3~5/RELEASE_X86_64 x86_64
> >
> > Details of changes since 1.8.0 are in the release notes:
> >
> > https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/RELEASE-NOTES.txt
> >
> > https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/site/changes-report.html
> >
> > Site:
> >
> > https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/site/index.html
> > (note some *relative* links are broken and the 1.9.0 directories
> > are not yet created - these will be OK once the site is deployed.)
> >
> > JApiCmp Report (compared to 1.8.0):
> >
> >

Re: [VOTE] Release Apache Commons Validator 1.9.0 based on RC1

2024-05-26 Thread Henri Biestro 


[+1]

Site looks good, reports are clean (nit: coverage is low, JIRA report need some 
work wrt fix version/reported version).
Build using:
Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
Maven home: /Users/hbiestro/Java/apache-maven-3.8.6
Java version: 1.8.0_352, vendor: Azul Systems, Inc., runtime: 
/Library/Java/JavaVirtualMachines/zulu-8.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "14.5", arch: "aarch64", family: "mac"

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[CANCEL][VOTE] Release Apache Commons JCS 3.2.1 based on rc2

2024-05-26 Thread Thomas Vandahl 
Next attempt.

> Am 20.04.2024 um 12:25 schrieb Thomas Vandahl :
> 
> Hi folks,
> 
> We have fixed a few bugs since Apache Commons JCS 3.2 was released, so I 
> would like to release Apache Commons JCS 3.2.1.
> 
> Apache Commons JCS 3.2.1 rc2 is available for review here:
>https://dist.apache.org/repos/dist/dev/commons/jcs/3.2.1-rc2 (svn revision 
> 68673)
> 
> The Git tag commons-jcs3-3.2.1-rc2 commit for this RC is 
> a2263c39fb07410ec75cf961362f9d9371298844 which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-jcs.git;a=commit;h=a2263c39fb07410ec75cf961362f9d9371298844
> You may checkout this tag using:
>git clone https://gitbox.apache.org/repos/asf/commons-jcs.git --branch 
> commons-jcs3-3.2.1-rc2 commons-jcs3-3.2.1-rc2
> 
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1722/org/apache/commons/commons-jcs3/3.2.1/
> 
> These are the artifacts and their hashes:
> 
> 20f898a3f7c41de29249d9e7e57cab754c5aa710da43c7018ce25413fa695d4edb363e036fd57884652e05ccf1e6b5946c7f4ff4b9a723affca42914e89935af
>   commons-jcs3-dist-3.2.1-bin.tar.gz
> fe454deabd3311c2c7b59db7ce25db49f6ba0bccfd97bb9262e38adaeb00cbb16d6ba8542b75d816a5ca05098782cf44374d3fe0573814370923fef940d00c56
>   commons-jcs3-dist-3.2.1-bin.zip
> 7c9d912978f0f88a01e9e2a9475bd07a6c81379bb12f4a4cbdeec890899c7dbdcb6421c45c0655d28cf951f284ab32ca61d8a1aedbdad46d05bd127c060c5968
>   commons-jcs3-dist-3.2.1-src.tar.gz
> 4c513b03909fdfe9dff1e6d6689e33b8badd92f5d6d470172ad1fdfe86f0869398cc77ff2cb114db8648a332d47375c6615ac26d574fa9882b7564481cc14f72
>   commons-jcs3-dist-3.2.1-src.zip
> 
> I have tested this with ***'mvn clean install site site:stage'*** using:
> --
> Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537)
> Java version: 17.0.8, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk-17.jdk/Contents/Home
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "mac os x", version: "11.7.10", arch: "x86_64", family: "mac"
> --
> 
> NOTE: Some JCS tests require a working multicast setup. If you get test 
> failures from tests 
> starting with UDPDiscovery*, make sure that your network supports multicast 
> (most VPNs do not,
> for example).
> 
> 
> Details of changes since 3.2 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/jcs/3.2.1-rc2/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/jcs/3.2.1-rc2/site/changes-report.html
> 
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/jcs/3.2.1-rc2/site/index.html
>(note some *relative* links are broken and the 3.2.1 directories are not 
> yet created - these will be OK once the site is deployed.)
> 
> JApiCmp Report (compared to 3.2):
>
> https://dist.apache.org/repos/dist/dev/commons/jcs/3.2.1-rc2/site/commons-jcs3-core/japicmp.html
> 
> RAT Report:
>
> https://dist.apache.org/repos/dist/dev/commons/jcs/3.2.1-rc2/site/commons-jcs3-core/rat-report.html
> 
> KEYS:
>  https://www.apache.org/dist/commons/KEYS
> 
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
> 
>  [ ] +1 Release these artifacts
>  [ ] +0 OK, but...
>  [ ] -0 OK, but really should fix...
>  [ ] -1 I oppose this release because...
> 
> Thank you,
> 
> tv,
> Release Manager (using key 88817402)
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Apache Commons Validator 1.9.0 based on RC1

2024-05-26 Thread Tomas Lanik 
Hi All,
Has the security issue (
https://devhub.checkmarx.com/cve-details/Cx78f40514-81ff/ ) related
to commons-collections:commons-collections:3.2.2 been addressed?
I can not see it in release notes.

FYI

Tom

On Sat, May 25, 2024 at 11:12 PM Gary Gregory  wrote:

> We have fixed a few bugs and added enhancements since Apache Commons
> Validator 1.8.0 was released, so I would like to release Apache
> Commons Validator 1.9.0.
>
> Apache Commons Validator 1.9.0 RC1 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1
> (svn revision 69387)
>
> The Git tag commons-validator-1.9.0-RC1 commit for this RC is
> 191171b2fb1500d24c42a809cf13386ac8f4ecac which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=191171b2fb1500d24c42a809cf13386ac8f4ecac
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-validator.git
> --branch
> 
> commons-validator-1.9.0-RC1 commons-validator-1.9.0-RC1
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1734/commons-validator/commons-validator/1.9.0/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Sat May 25 20:36:23 UTC 2024
>
> commons-validator-1.9.0-bin.tar.gz=a755d2be1b9fb3cb75cb71c2c6143969eabd8ba48401dd86cad6c658e0de72e52a887e157ef38e780471382c2da68db228866303f3d4cb4500f995b8b3967476
>
> commons-validator-1.9.0-bin.zip=7c0cb444f4e162c46cbd356c8a3c8b166b06bcaf79b6c433ee5ad585498a1f0b4dfef3606ca4beedeef418b5b56209f86cac6dd2c1c8fa4dfe62c679df0018db
>
> commons-validator-1.9.0-bom.json=7e9baecc1b58f5de101d247b95d871a5b3227603a99eddf8bcce07e3656024dffc615b8ec0b765376bf640f9596581cb483830861878474fe79339bb84352cd3
>
> commons-validator-1.9.0-bom.xml=d4a5d380ade4eec7f7a71cb260a61901b5945129bc448894c89ae10d3375a4dac2898be6498eb3aaba60cd8c464837f7884521fc467285c0fc2f129b92e52bf9
>
> commons-validator-1.9.0-javadoc.jar=b4b3dee67453e72ea070140d858ff66c45ed5794b69b68760639726cea0edba1224cb2c1cda64411893ded0ba96e2758a7677e2ffa21249899630e39949d88ed
>
> commons-validator-1.9.0-sources.jar=f91890e90979ed1c7abcebb4b37f223a163bfc73bc3da6a4bc3469d399e7d0ff9315d89e528bab88b53cd0ef0a1c3f8c7e0e463a784f47546ae8ca8f3d4c2269
>
> commons-validator-1.9.0-src.tar.gz=4e36f0ec5b1b8ae9724f020c51396332444d7359988fbcceaab004cde30e223b8130315e85d9b3d568fdc30399e9e503783bb81f217fe5f846f9e14c484a1fe0
>
> commons-validator-1.9.0-src.zip=201ee0723d5f078b128aa7a54bc2b03494c467e6f2df843d74bf3607d085067a0ea395e1e2174fd3237248f18f8bc5e7469e72fc9378813cbe7e5397e20c03d1
>
> commons-validator-1.9.0-test-sources.jar=6fee6648f66e666ff49e99ef3ee49039436bd19b150eb2294d3b6a0e57dab7c0a9e7bcaecde005c478f24a21729d59365e4deb096a579b5044aafa513c90972c
>
> commons-validator-1.9.0-tests.jar=2c2a13fd3c242c1ab06e9ef8f6f18ed3eae392b8fb0a5c9bbce137ce0e9873820c37197a8517984a42d4804433501521c5f5970ef8ae868f8c6d2a061e88b05e
>
> commons-validator_commons-validator-1.9.0.spdx.json=bd19d362ae59afbe41425f57e02d4d5c32f99b9e218ebdf6ea8eaa388cb9fb28721e93781f084533e98eb345d9d7bc5a96790e06e0ac1f0d0aaff6db063042fe
>
> I have tested this with 'mvn' and 'mvn -V -Prelease -Ptest-deploy -P
> jacoco -P japicmp clean package site deploy' using:
>
> openjdk version "17.0.11" 2024-04-16
> OpenJDK Runtime Environment Homebrew (build 17.0.11+0)
> OpenJDK 64-Bit Server VM Homebrew (build 17.0.11+0, mixed mode, sharing)
>
> Apache Maven 3.9.7 (8b094c9513efc1b9ce2d952b3b9c8eaedaf8cbf0)
> Maven home: /usr/local/Cellar/maven/3.9.7/libexec
> Java version: 17.0.11, vendor: Homebrew, runtime:
> /usr/local/Cellar/openjdk@17/17.0.11/libexec/openjdk.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "14.5", arch: "x86_64", family: "mac"
>
> Darwin  23.5.0 Darwin Kernel Version 23.5.0: Wed May  1 20:09:52
> PDT 2024; root:xnu-10063.121.3~5/RELEASE_X86_64 x86_64
>
> Details of changes since 1.8.0 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/site/changes-report.html
>
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/site/index.html
> (note some *relative* links are broken and the 1.9.0 directories
> are not yet created - these will be OK once the site is deployed.)
>
> JApiCmp Report (compared to 1.8.0):
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/site/japicmp.html
>
> RAT Report:
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/site/rat-report.html
>
> KEYS:
>   https://downloads.apache.org/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I

RE: Re: [LANG] Support single quotes in DurationFormatUtils methods' formats

2024-05-26 Thread Laertes Moustakas 
Hello Gary,

Thank you for your response. Some of the new assertions indeed fail when 
interpreting the duplicate single quote as an escaped quote instead of a 
closing and opening quote. In particular, "y' ''years' M 'months'" is 
interpreted as "4 'years 0 months" while the expected text lacks the quote 
before "years". Same for "hello''world": it's interpreted as "hello'world" 
instead of "helloworld".

I understand this brings forth a breaking change in formats that use two single 
quotes to close and open new literals (or even add an empty string), but this 
is consistent with what java.text.SimpleDateFormat expects. And I believe that 
most developers would favor consistency between format strings in equivalent 
classes. Thus, I think the cases described above where the two single quotes 
terminate and begin a literal should no longer be supported.

Should this change go forward, I expect it to be part of a major release (e.g. 
version 4.0.0, 5.0.0, etc.) instead of 3.x.x, as it does contain a breaking 
change.

If you have more questions, please don't hesitate to contact me.

Best regards,
Laertes

On 2024/05/25 13:47:23 Gary Gregory wrote:
> Hello Laertes,
>
> Thank you for your interest in improving Apache Commons Lang :-)
>
> Do you foresee any compatibility issues for existing call sites and
> format strings?
>
> For example, can you make your use cases work and still support:
>
> https://github.com/apache/commons-lang/blob/d861f1b2116a41a45949d1401785220119a57e56/src/test/java/org/apache/commons/lang3/time/DurationFormatUtilsTest.java#L463-L473
>
> Or, should these cases no longer be supported?
>
> TY!
> Gary
>
> On Fri, May 24, 2024 at 4:15 PM Laertes Moustakas  wrote:
> >
> > Greetings,
> >
> > org.apache.commons.lang3.time.DurationFormatUtils contains useful methods
> > to format a duration or period of milliseconds in the textual
> > representation given by the format argument. It even allows arbitrary text
> > to be printed between single quotes, on the condition that any opening
> > single quotes will eventually close with another single quote.
> >
> > For example,
> > DurationFormatUtils.formatDuration(64000L, "mm:ss")
> > will return "01:04".
> >
> > While
> > DurationFormatUtils.formatDuration(1804000L, "m'min' s'sec'")
> > will yield "34min 4sec".
> >
> > However, as per the JavaDoc page for this class
> > 
> > including
> > a single quote is currently not supported. Other classes that format
> > datetime such as the java.text.SimpleDateFormat do, by putting two single
> > quotes next to each other.
> >
> > So something like
> > new SimpleDateFormat("mm'' ss'sec'").format(new Date()); // note the two
> > single quotes after "mm"
> > will return something like this:
> > "42' 02sec"
> >
> > Instead,
> > DurationFormatUtils.formatDuration(64000L, "mm'' ss'sec'")
> > will return "01 04sec".
> >
> > I wish to implement support for single quotes in the DurationFormatUtils
> > format the same way SimpleDateFormat does; by escaping it with two
> > consecutive single quote characters. I have searched the mailing list and
> > found no similar request. I have already tested on the copy of a source
> > code, including adding tests, and no test throughout the commons-lang
> > project failed.
> >
> > Please let me know if this is an acceptable change, and the next steps to
> > take should this move forward.
> >
> > Best regards,
> > Laertes Moustakas
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>