[GitHub] commons-fileupload issue #5: Update DiskFileItem.java: Avoiding NPE when not...
Github user OleHornischer commented on the issue: https://github.com/apache/commons-fileupload/pull/5 Hi @garydgregory, yes, that potential NullPointerException I also addressed in my fix, as well as others. I updated the sources now to handle exceptions and fixed a few compile errors. The test now includes a test for all methods that have been fixed. Ole --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-fileupload issue #5: Update DiskFileItem.java: Avoiding NPE when not...
Github user OleHornischer commented on the issue: https://github.com/apache/commons-fileupload/pull/5 Thanks for the tip. I updated my repository in accordance to the script on the linked blog post. Hope things are in order now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-fileupload issue #5: Update DiskFileItem.java: Avoiding NPE when not...
Github user OleHornischer commented on the issue: https://github.com/apache/commons-fileupload/pull/5 Hi @garydgregory I created a Unit test illustrating the issue. However, since this is my first pull request, I am not sure what you mean by updating the patch. I forked the trunk and changed only the files required for my change. Do I rather need to create a branch in your repository instead? Ole --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-fileupload pull request #5: Update DiskFileItem.java: Avoiding NPE w...
GitHub user OleHornischer opened a pull request: https://github.com/apache/commons-fileupload/pull/5 Update DiskFileItem.java: Avoiding NPE when not explicitely initializ⦠â¦ing the outputstream When accessing e.g. getSize() on a DiskFileItem before having called getOutputStream() a NullPointerException would be thrown. Consequent use of the "intelligent" getter already in place avoids this issue. You can merge this pull request into a Git repository by running: $ git pull https://github.com/OleHornischer/commons-fileupload trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-fileupload/pull/5.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5 commit 07b66bb1ebf9ab6b1077c453895e4f0dd62163d7 Author: OleHornischer Date: 2016-11-25T09:40:06Z Update DiskFileItem.java: Avoiding NPE when not explicitely initializing the outputstream When accessing e.g. getSize() on a DiskFileItem before having called getOutputStream() a NullPointerException would be thrown. Consequent use of the "intelligent" getter already in place avoids this issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
