[GitHub] commons-collections issue #57: COLLECTIONS-701 SetUniqueList.add() crashes d...
Github user drajakumar commented on the issue: https://github.com/apache/commons-collections/pull/57 @garydgregory can you kindly check the new fix, thank you! --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections issue #57: COLLECTIONS-701 SetUniqueList.add() crashes d...
Github user drajakumar commented on the issue: https://github.com/apache/commons-collections/pull/57 @garydgregory can you kindly check the new fix, thank you! --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections pull request #57: COLLECTIONS-701 SetUniqueList.add() cr...
GitHub user drajakumar reopened a pull request: https://github.com/apache/commons-collections/pull/57 COLLECTIONS-701 SetUniqueList.add() crashes due to infinite recursion⦠⦠when it receives itself You can merge this pull request into a Git repository by running: $ git pull https://github.com/drajakumar/commons-collections master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-collections/pull/57.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #57 commit be0cea3c907bb4ab1083384377521942d17e15bd Author: Don Jeba Date: 2018-11-08T17:36:05Z COLLECTIONS-701 SetUniqueList.add() crashes due to infinite recursion when it receives itself commit ddde35c943058b55a59e88c9f5d60ed53f3e08ef Author: Rajakumar Date: 2018-11-09T14:27:11Z Merge branch 'master' of github.com:apache/commons-collections --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections pull request #57: COLLECTIONS-701 SetUniqueList.add() cr...
GitHub user drajakumar reopened a pull request: https://github.com/apache/commons-collections/pull/57 COLLECTIONS-701 SetUniqueList.add() crashes due to infinite recursion⦠⦠when it receives itself You can merge this pull request into a Git repository by running: $ git pull https://github.com/drajakumar/commons-collections master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-collections/pull/57.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #57 commit be0cea3c907bb4ab1083384377521942d17e15bd Author: Don Jeba Date: 2018-11-08T17:36:05Z COLLECTIONS-701 SetUniqueList.add() crashes due to infinite recursion when it receives itself commit ddde35c943058b55a59e88c9f5d60ed53f3e08ef Author: Rajakumar Date: 2018-11-09T14:27:11Z Merge branch 'master' of github.com:apache/commons-collections --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections issue #57: COLLECTIONS-701 SetUniqueList.add() crashes d...
Github user drajakumar commented on the issue: https://github.com/apache/commons-collections/pull/57 sure @garydgregory i am analyzing for a fix as per the expectation, will update you. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections pull request #57: COLLECTIONS-701 SetUniqueList.add() cr...
Github user drajakumar closed the pull request at: https://github.com/apache/commons-collections/pull/57 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections issue #57: COLLECTIONS-701 SetUniqueList.add() crashes d...
Github user drajakumar commented on the issue: https://github.com/apache/commons-collections/pull/57 closing the pr as the fix is not as expected --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections pull request #57: COLLECTIONS-701 SetUniqueList.add() cr...
Github user drajakumar closed the pull request at: https://github.com/apache/commons-collections/pull/57 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections pull request #57: COLLECTIONS-701 SetUniqueList.add() cr...
GitHub user drajakumar opened a pull request: https://github.com/apache/commons-collections/pull/57 COLLECTIONS-701 SetUniqueList.add() crashes due to infinite recursion⦠⦠when it receives itself You can merge this pull request into a Git repository by running: $ git pull https://github.com/drajakumar/commons-collections master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-collections/pull/57.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #57 commit be0cea3c907bb4ab1083384377521942d17e15bd Author: Don Jeba Date: 2018-11-08T17:36:05Z COLLECTIONS-701 SetUniqueList.add() crashes due to infinite recursion when it receives itself --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #92: TEXT-138 TextStringBuilder append sub-sequenc...
Github user drajakumar closed the pull request at: https://github.com/apache/commons-text/pull/92 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #92: TEXT-138 TextStringBuilder append sub-sequence not c...
Github user drajakumar commented on the issue: https://github.com/apache/commons-text/pull/92 closing as its consider in this commit https://github.com/apache/commons-text/commit/70c080b146e8e6fb79cd97f780b65f863d4ec6d8 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #92: TEXT-138 TextStringBuilder append sub-sequenc...
GitHub user drajakumar opened a pull request: https://github.com/apache/commons-text/pull/92 TEXT-138 TextStringBuilder append sub-sequence not consistant with Appendable 1 considered the end index as exclusive because its exclusive as per the definition done in Appendable. 2 considered start index not to be same as the end index because start index is inclusive, end index is not. 3 there is an overloaded append function in TextStringBuilder which takes String, int, int as parameters. The last parameter here is length. I didn't touch this because, its NOT an overridden function from Appendable. You can merge this pull request into a Git repository by running: $ git pull https://github.com/drajakumar/commons-text master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-text/pull/92.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #92 commit d3bfb518ccde125b45b9d7a874cf717321578e7f Author: Don Jeba Date: 2018-10-29T18:05:19Z TEXT-127 Detect when a variable is unknown in StringSubstitutor commit dde0a395438bf8c7626076c56912a4405f856628 Author: Don Jeba Date: 2018-10-29T18:21:04Z fixing build failure commit 60bed4374a2db82bc7842d3ccd33e2158d2b80f6 Author: Don Jeba Date: 2018-10-29T18:29:19Z removing trailing space at L131 commit 2ac7b5029cea1234accca7ec5f48cf17bed364ac Author: Don Jeba Date: 2018-11-07T09:33:50Z TEXT-138 TextStringBuilder append sub-sequence not consistant with Appendable commit a7d1a89e9aafa2f296758583e661c13f2ab58c20 Author: Don Jeba Date: 2018-11-07T09:42:24Z fixing merge conflict commit a8d94daaa59eef6709b70e66a46319c3c75cd718 Author: Don Jeba Date: 2018-11-07T09:45:30Z removing empty lines from StringSubstitutorTest.java --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #91: TEXT-127 Detect when a variable is unknown in String...
Github user drajakumar commented on the issue: https://github.com/apache/commons-text/pull/91 closed the pr as @garydgregory made applied a different patch that changes the instance variable name and method name. He also provided the variable name that is not found. He added some missing Javadoc throws tags. https://github.com/apache/commons-text/commit/ed94773e2d2e4da4e993e5a50ee72624587cf76b --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #91: TEXT-127 Detect when a variable is unknown in...
Github user drajakumar closed the pull request at: https://github.com/apache/commons-text/pull/91 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #91: TEXT-127 Detect when a variable is unknown in...
GitHub user drajakumar opened a pull request: https://github.com/apache/commons-text/pull/91 TEXT-127 Detect when a variable is unknown in StringSubstitutor You can merge this pull request into a Git repository by running: $ git pull https://github.com/drajakumar/commons-text master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-text/pull/91.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #91 commit d3bfb518ccde125b45b9d7a874cf717321578e7f Author: Don Jeba Date: 2018-10-29T18:05:19Z TEXT-127 Detect when a variable is unknown in StringSubstitutor --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text pull request #72: fix for TEXT-100
GitHub user drajakumar opened a pull request: https://github.com/apache/commons-text/pull/72 fix for TEXT-100 You can merge this pull request into a Git repository by running: $ git pull https://github.com/drajakumar/commons-text master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-text/pull/72.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #72 commit 390e16b6b62561ae1de3d3918175ea04a037ec2a Author: drajakumar <drajaku...@paypal.com> Date: 2017-10-18T16:14:46Z fix for TEXT-100 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
