[GitHub] commons-fileupload pull request #17: Move static analysis plugins from repor...
GitHub user krichter722 opened a pull request: https://github.com/apache/commons-fileupload/pull/17 Move static analysis plugins from reporting to build Moving the static code analysis plugins maven-checkstyle-plugin and maven-pmd-plugin from the reporting to the build section and executing them in the validate phase has the advantage to actively prevent code style issues to ever be committed rather then passively react to them after the report section has been run (not part of the current CI script and build instructions anyway). Some notes: * PMD's `RedundantThrows` is no longer available. I can research the stackoverflow.com post again if you absolutely need a reference. * Renaming tests ending in `TestCase` to `Test` and making the prefix `Mock` a suffix has been done for convenience. * Some Javadoc comments in the form of "The [field name]" are poor. Leave a line comment is you have suggestions. You can merge this pull request into a Git repository by running: $ git pull https://github.com/krichter722/commons-fileupload checkstyle Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-fileupload/pull/17.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #17 commit b33c20cab9e96ad89168569de08916a0b1539f38 Author: Karl-Philipp Richter Date: 2018-05-21T17:06:33Z Move static analysis plugins from reporting to build Moving the static code analysis plugins maven-checkstyle-plugin and maven-pmd-plugin from the reporting to the build section and executing them in the validate phase has the advantage to actively prevent code style issues to ever be committed rather then passively react to them after the report section has been run (not part of the current CI script and build instructions anyway). --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-fileupload pull request #16: Use Apache Commons I/O in tests
GitHub user krichter722 opened a pull request: https://github.com/apache/commons-fileupload/pull/16 Use Apache Commons I/O in tests Replace File.delete and File.mkdir with Apache Commons I/O's FileUtils equivalent which throw IOException instead of returning false which reduces the change to miss unexpected failures and removed assertions testing the function of Apache Commons I/O which is not our job. You can merge this pull request into a Git repository by running: $ git pull https://github.com/krichter722/commons-fileupload commons-io Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-fileupload/pull/16.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #16 commit 41694d54cf4fc2d8db1d3cb2651e52ed72aab166 Author: Karl-Philipp Richter Date: 2018-05-21T18:12:53Z Use Apache Commons I/O in tests Replace File.delete and File.mkdir with Apache Commons I/O's FileUtils equivalent which throw IOException instead of returning false which reduces the change to miss unexpected failures and removed assertions testing the function of Apache Commons I/O which is not our job. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-fileupload issue #13: FileItem.java: remove throwing of Exception
Github user krichter722 commented on the issue: https://github.com/apache/commons-fileupload/pull/13 > I run my FooDiskFileItem that throws an Exception (not an IOException). How? If `DiskItem.write` doesn't throw `Exception` `FooDiskItem.write` can't. > My new code obviously does not catch that Exception and it percolates up the stack. That's what you want because that's the meaning of a raw `Exception` and that's why `throws Exception` and `catch(Exception)` is generally a bad idea. The system works, it just might cause an inconvenience in this situation where idioms have not been used correctly in the first place. I don't think the situation is possible, though because `FooDiskItem.write` in 1.4.x can't throw Exception anymore. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-fileupload pull request #15: pom.xml: Remove tab characters
Github user krichter722 closed the pull request at: https://github.com/apache/commons-fileupload/pull/15 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-fileupload pull request #15: pom.xml: Remove tab characters
GitHub user krichter722 opened a pull request: https://github.com/apache/commons-fileupload/pull/15 pom.xml: Remove tab characters pom.xml contains a mixture of spaces and tab characters in order to indent markup which is confusing. Spaces should be used instead where applicable. You can merge this pull request into a Git repository by running: $ git pull https://github.com/krichter722/commons-fileupload pom-tabs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-fileupload/pull/15.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #15 commit e23e2aab745ccb6c63d2b54c894d3ab64c5b0a96 Author: Karl-Philipp Richter Date: 2018-05-21T15:57:24Z pom.xml: Remove tab characters pom.xml contains a mixture of spaces and tab characters in order to indent markup which is confusing. Spaces should be used instead where applicable. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-fileupload issue #13: FileItem.java: remove throwing of Exception
Github user krichter722 commented on the issue: https://github.com/apache/commons-fileupload/pull/13 > True, but what if I have a subclass of DiskFileItem that throws an Exception? What happens at runtime? Correct, I didn't think about that. I'm already glad, you're willing to change this, so just put it into the next major release. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-fileupload issue #14: Add missing @Override annotations
Github user krichter722 commented on the issue: https://github.com/apache/commons-fileupload/pull/14 I made a mistake during rebase, the results are identical. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-fileupload pull request #14: Add missing @Override annotations
Github user krichter722 closed the pull request at: https://github.com/apache/commons-fileupload/pull/14 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-fileupload issue #13: FileItem.java: remove throwing of Exception
Github user krichter722 commented on the issue: https://github.com/apache/commons-fileupload/pull/13 In any previous situation users needed to catch `Exception`. Since both exception extend `Exception` there's no case where they need to change any code. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-fileupload issue #14: Add missing @Override annotations
Github user krichter722 commented on the issue: https://github.com/apache/commons-fileupload/pull/14 > Thank you for your report. I used Eclipse'd clean up feature to implement this change instead of applying this patch. Please verify and close. NetBeans seems to find some more :) --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-fileupload pull request #14: Add missing @Override annotations
GitHub user krichter722 opened a pull request: https://github.com/apache/commons-fileupload/pull/14 Add missing @Override annotations @Override annotations help to detect architectural errors and respond quicker to method changes. Unclear why the checkstyle configuration which includes MissingOverride passes the validation if they're missing. You can merge this pull request into a Git repository by running: $ git pull https://github.com/krichter722/commons-fileupload override Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-fileupload/pull/14.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #14 commit 6377a58148c7a24d890007df13ee202a818f4a34 Author: Karl-Philipp Richter Date: 2018-05-21T03:16:05Z Add missing @Override annotations @Override annotations help to detect architectural errors and respond quicker to method changes. Unclear why the checkstyle configuration which includes MissingOverride passes the validation if they're missing. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-fileupload pull request #13: FileItem.java: remove throwing of Excep...
GitHub user krichter722 opened a pull request: https://github.com/apache/commons-fileupload/pull/13 FileItem.java: remove throwing of Exception Indicating that an interface method throws Exception is overly broad and hides design issues after inheritance changes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/krichter722/commons-fileupload throws-exception Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-fileupload/pull/13.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #13 commit 77d68a7ce0d15c05d93ef56f8bd28d0cd454a131 Author: Karl-Philipp Richter Date: 2018-05-21T01:20:47Z FileItem.java: remove throwing of Exception Indicating that an interface method throws Exception is overly broad and hides design issues after inheritance changes. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-collections issue #21: Add VI[M] temporary files to .gitignore
Github user krichter722 commented on the issue: https://github.com/apache/commons-collections/pull/21 A `.gitignore` should be agnostic to the editor or IDE devs use for the project. Those files belong into `.git/info/excludes`. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-exec pull request #1: making CommandLine.addArgument and CommandLine...
GitHub user krichter722 opened a pull request: https://github.com/apache/commons-exec/pull/1 making CommandLine.addArgument and CommandLine.addArguments fail on null and empty arguments Making CommandLine.addArgument and CommandLine.addArguments fail on null and empty (for addArguments) arguments which makes it easier to track unwanted behavior/arguments. This changes the API slightly, but imo it's more intuitive and error proof than before, i.e. the change would be appreciated by users. You can merge this pull request into a Git repository by running: $ git pull https://github.com/krichter722/commons-exec fail_on_null_and_empty Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-exec/pull/1.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1 commit 8a102f1bb42cd732b78de5281a7f92d78cc8c8f3 Author: Karl-Philipp Richter Date: 2017-08-04T11:18:22Z making CommandLine.addArgument and CommandLine.addArguments fail on null and empty (for addArguments) arguments which makes it easier to track unwanted behavior/arguments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
