[GitHub] commons-pool issue #10: POOL-347 : Regard waiting object creation as failure...
Github user sunsuk7tp commented on the issue: https://github.com/apache/commons-pool/pull/10 Hmm.. I tried many times but it always succeeded like below: https://gist.github.com/sunsuk7tp/c6ad1c73c77403c32bab546ca86198ff Also, test all passed on travis ci: https://travis-ci.org/apache/commons-pool/builds/406334648?utm_source=github_status&utm_medium=notification I guess `mvn clean` somehow doesn't work well in your local because the cause is `java.lang.NoSuchMethodError`. BTW do you get same error even if you get rid of new test case from my patch? --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-pool issue #10: POOL-347 : Regard waiting object creation as failure...
Github user sunsuk7tp commented on the issue: https://github.com/apache/commons-pool/pull/10 @garydgregory Oh, really? I tried that from latest master brach and it passed with no error. Could you tell me your jdk version and stuff? (mine is `1.8.0_171`) BTW this PR didn't modify codes related to the 3 test cases. Test with master branch passes in your environment, right? --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-pool pull request #10: POOL-347 : Regard waiting object creation as ...
GitHub user sunsuk7tp opened a pull request: https://github.com/apache/commons-pool/pull/10 POOL-347 : Regard waiting object creation as failure if pool is full and maxWaitTime passed JIRA: https://issues.apache.org/jira/browse/POOL-347 You can merge this pull request into a Git repository by running: $ git pull https://github.com/sunsuk7tp/commons-pool POOL-347 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-pool/pull/10.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #10 commit 7b3a83479ea3d57c624aa1ecd0260b86b12272de Author: Shunsuke Nakamura Date: 2018-07-20T16:47:28Z [POOL-347] Regard waiting object creation as failure if pool is full and maxWaitTime passed --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
