[GitHub] commons-pool issue #10: POOL-347 : Regard waiting object creation as failure...
Github user sunsuk7tp commented on the issue: https://github.com/apache/commons-pool/pull/10 Hmm.. I tried many times but it always succeeded like below: https://gist.github.com/sunsuk7tp/c6ad1c73c77403c32bab546ca86198ff Also, test all passed on travis ci: https://travis-ci.org/apache/commons-pool/builds/406334648?utm_source=github_status&utm_medium=notification I guess `mvn clean` somehow doesn't work well in your local because the cause is `java.lang.NoSuchMethodError`. BTW do you get same error even if you get rid of new test case from my patch? --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-pool issue #10: POOL-347 : Regard waiting object creation as failure...
Github user garydgregory commented on the issue: https://github.com/apache/commons-pool/pull/10 I am using: ``` Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T12:33:14-06:00) Maven home: C:\Java\apache-maven-3.5.4\bin\.. Java version: 1.8.0_172, vendor: Oracle Corporation, runtime: C:\Program Files\Java\jdk1.8.0_172\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" ``` I tried again and it worked, but then, trying again, I get 5 errors instead of the 3 above: ``` [ERROR] Tests run: 82, Failures: 0, Errors: 5, Skipped: 0, Time elapsed: 78.346 s <<< FAILURE! - in org.apache.commons.pool2.impl.TestGenericObjectPool [ERROR] testConstructors(org.apache.commons.pool2.impl.TestGenericObjectPool) Time elapsed: 0.179 s <<< ERROR! java.lang.NoSuchMethodError: org.apache.commons.pool2.impl.TestGenericObjectPool$DummyFactory.(Lorg/apache/commons/pool2/impl/TestGenericObjectPool$1;)V at org.apache.commons.pool2.impl.TestGenericObjectPool.testConstructors(TestGenericObjectPool.java:140) [ERROR] testFailingFactoryDoesNotBlockThreads(org.apache.commons.pool2.impl.TestGenericObjectPool) Time elapsed: 0.015 s <<< ERROR! java.lang.NoSuchMethodError: org.apache.commons.pool2.impl.TestGenericObjectPool$CreateFailFactory.(Lorg/apache/commons/pool2/impl/TestGenericObjectPool$1;)V at org.apache.commons.pool2.impl.TestGenericObjectPool.testFailingFactoryDoesNotBlockThreads(TestGenericObjectPool.java:2570) [ERROR] testMutable(org.apache.commons.pool2.impl.TestGenericObjectPool) Time elapsed: 0.032 s <<< ERROR! java.lang.NoSuchMethodError: org.apache.commons.pool2.impl.TestGenericObjectPool$HashSetFactory.(Lorg/apache/commons/pool2/impl/TestGenericObjectPool$1;)V at org.apache.commons.pool2.impl.TestGenericObjectPool.testMutable(TestGenericObjectPool.java:2445) [ERROR] testErrorFactoryDoesNotBlockThreads(org.apache.commons.pool2.impl.TestGenericObjectPool) Time elapsed: 0.035 s <<< ERROR! java.lang.NoSuchMethodError: org.apache.commons.pool2.impl.TestGenericObjectPool$CreateErrorFactory.(Lorg/apache/commons/pool2/impl/TestGenericObjectPool$1;)V at org.apache.commons.pool2.impl.TestGenericObjectPool.testErrorFactoryDoesNotBlockThreads(TestGenericObjectPool.java:2685) [ERROR] testEqualsIndiscernible(org.apache.commons.pool2.impl.TestGenericObjectPool) Time elapsed: 0.005 s <<< ERROR! java.lang.NoSuchMethodError: org.apache.commons.pool2.impl.TestGenericObjectPool$HashSetFactory.(Lorg/apache/commons/pool2/impl/TestGenericObjectPool$1;)V at org.apache.commons.pool2.impl.TestGenericObjectPool.testEqualsIndiscernible(TestGenericObjectPool.java:2427) ``` Now I am trying to build without the patch and it passes. I tried 3 times in a row without errors. Each build (mvn clean test) takes about 5:15 minutes. So there is a side-effect in play with the patch... Can you run the build many times in a row and report? --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-pool issue #10: POOL-347 : Regard waiting object creation as failure...
Github user sunsuk7tp commented on the issue: https://github.com/apache/commons-pool/pull/10 @garydgregory Oh, really? I tried that from latest master brach and it passed with no error. Could you tell me your jdk version and stuff? (mine is `1.8.0_171`) BTW this PR didn't modify codes related to the 3 test cases. Test with master branch passes in your environment, right? --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-pool issue #10: POOL-347 : Regard waiting object creation as failure...
Github user garydgregory commented on the issue: https://github.com/apache/commons-pool/pull/10 When I apply this match to master, I get: [INFO] Running org.apache.commons.pool2.impl.TestGenericObjectPool [ERROR] Tests run: 82, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 81.078 s <<< FAILURE! - in org.apache.commons.pool2.impl.TestGenericObjectPool [ERROR] testMutable(org.apache.commons.pool2.impl.TestGenericObjectPool) Time elapsed: 0.037 s <<< ERROR! java.lang.NoSuchMethodError: org.apache.commons.pool2.impl.TestGenericObjectPool$HashSetFactory.(Lorg/apache/commons/pool2/impl/TestGenericObjectPool$1;)V at org.apache.commons.pool2.impl.TestGenericObjectPool.testMutable(TestGenericObjectPool.java:2445) [ERROR] testErrorFactoryDoesNotBlockThreads(org.apache.commons.pool2.impl.TestGenericObjectPool) Time elapsed: 0.011 s <<< ERROR! java.lang.NoSuchMethodError: org.apache.commons.pool2.impl.TestGenericObjectPool$CreateErrorFactory.(Lorg/apache/commons/pool2/impl/TestGenericObjectPool$1;)V at org.apache.commons.pool2.impl.TestGenericObjectPool.testErrorFactoryDoesNotBlockThreads(TestGenericObjectPool.java:2685) [ERROR] testEqualsIndiscernible(org.apache.commons.pool2.impl.TestGenericObjectPool) Time elapsed: 0 s <<< ERROR! java.lang.NoSuchMethodError: org.apache.commons.pool2.impl.TestGenericObjectPool$HashSetFactory.(Lorg/apache/commons/pool2/impl/TestGenericObjectPool$1;)V at org.apache.commons.pool2.impl.TestGenericObjectPool.testEqualsIndiscernible(TestGenericObjectPool.java:2427) --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-pool issue #10: POOL-347 : Regard waiting object creation as failure...
Github user coveralls commented on the issue: https://github.com/apache/commons-pool/pull/10 [](https://coveralls.io/builds/18088758) Coverage increased (+0.1%) to 85.146% when pulling **7b3a83479ea3d57c624aa1ecd0260b86b12272de on sunsuk7tp:POOL-347** into **3e6dfcd61ddcd88b18934738ebda05c84c948a80 on apache:master**. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
