[GitHub] commons-rng issue #5: Feature rng 37
Github user cur4so commented on the issue: https://github.com/apache/commons-rng/pull/5 now it's more clear @kinow :) Fixed. And rephrased the git commit message as Gilles suggested --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-rng issue #5: Feature rng 37
Github user cur4so commented on the issue: https://github.com/apache/commons-rng/pull/5 fixed --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-rng issue #5: Feature rng 37
Github user cur4so commented on the issue: https://github.com/apache/commons-rng/pull/5 thanks @kinow for your suggestions and patience. I've implemented them in the last commit --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-rng issue #5: Feature rng 37
Github user kinow commented on the issue: https://github.com/apache/commons-rng/pull/5 Builds successfully in Apache Maven 3.3.9 Maven home: /usr/share/maven Java version: 1.8.0_131, vendor: Oracle Corporation Java home: /opt/jdk1.8.0_131/jre Default locale: en_NZ, platform encoding: UTF-8 OS name: "linux", version: "4.10.0-35-generic", arch: "amd64", family: "unix" I suspect the Travis CI build is not related to the PR, though would need someone else's opinion too. The coverage report indicates 99% line coverage, and 86% branch coverage. :clap: --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-rng issue #5: Feature rng 37
Github user kinow commented on the issue: https://github.com/apache/commons-rng/pull/5 Thank you @cur4so for the pull request. Travis CI failed to build this pull request, but I suspect it may be related to some thing else. ``` Results : Failed tests: ContinuousSamplerParametricTest.testSampling:53->check:127 Gaussian deviate [Box-Muller normalized Gaussian deviate [rng=org.apache.commons.rng.core.source32.MersenneTwister]]: Too many failures for sample size = 2 (3 out of 50 tests failed, chi2=[22.6820002, 24.3670004, 24.088] ``` I checked out your pull request locally (https://gist.github.com/piscisaureus/3342247). Then built it with `mvn clean site`. Finally, under commons-rng/commons-rng-sampling/target/site/, opened the index.html file in my browser. There, under Project Reports, I can see that PMD has two new issues from this PR (I'll comment on them). And Checkstyle has 4 new errors, which I'll also add a note to the PR. Can you have a look at these issues @cur4so ? Great work so far. Thanks a lot for your contribution, and patience :-) Bruno --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
