[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...
Github user chtompki commented on the issue:
https://github.com/apache/commons-text/pull/45
I believe the reason that we're getting a "success" to be the fact that the
`docker` command exits with a 0. So might we want to do a `{docker run -v
`pwd`:/work library/ibmjava:8-sdk /bin/bash -c "apt-get update && cd work &&
apt-get install -y maven && mvn} || exit 1` in the docker command.
Further, I've been thinking about this more:
1. I submitted some changes to the official maven docker image (which I
think we should be using). 2. Would we want to have two builds here, one that
builds in a bunch of containers, and a second (presumably running on the target
usage jdk) that does the coveralls bit?
3. Depending on how we do this we loose a certain amount of paralellization.
I think I'll bubble this up to the ML for more discussion. It seems clear
to me that folks want to do this, but it's just a matter of how.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/45 The build failure I quoted occurs after the findbugs exceptions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/45 Hi @PascalSchumacher , where did you see build is failing ? I see all builds passed given in your link https://travis-ci.org/apache/commons-text/jobs/243003865, Yes ibmjdk8 is running after each build , that's how Travis handling it , but its ok over the cost of not checking code with ibmjdk8 And if build fails it do mark build as failed i did verified that because maven return exit code as -1 which all the way go to Travis to mark RED. At this point all (openjdk7, oraclejdk7, oraclejdk7, ibmjdk8*3) = 6 builds as passing . I see some exception on findbug library and that's not issue with Commons Text code but in findbug code and that's because they might not have considered ibmjdk8 for their build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/45 Hm. I'll give this a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/45 I guess this failure is also the reason that the coveralls integration is broken. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/45 This does not seem to really work. It looks like ibm jdk build is run after each (oracle8, openjdk(7|8)) build and actually fails, but the build is still marked successful, e.g.: ``` [INFO] BUILD FAILURE [INFO] [INFO] Total time: 2.039s [INFO] Finished at: Wed Jun 14 20:58:38 UTC 2017 [INFO] Final Memory: 10M/143M [INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-clean-plugin:3.0.0:clean (default-clean) on project commons-text: Failed to clean project: Failed to delete /home/travis/build/apache/commons-text/target/surefire-reports/org.apache.commons.text.similarity.LevenshteinDetailedDistanceTest.txt -> [Help 1] ``` https://travis-ci.org/apache/commons-text/jobs/243003865 (see raw build log) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/45 Agreed. Will pull this in tonight or in the morning (UTC-4) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/45 @chtompki, I think we are good to merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/45 Created one image containing maven with ibmjava8, same can be pushed to apache dockerhub repo https://hub.docker.com/r/ameyjadiye/ibmjava8/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...
Github user joehni commented on the issue: https://github.com/apache/commons-text/pull/45 In Maven "verify" implies "test", since "verify" is a later step in the Maven [build lifecycle](http://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html#Build_Lifecycle_Basics). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/45 Hi @garydgregory , I think removing ``` test ``` is not good idea, better we can have ```verify``` along with ```test``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...
Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/45 [](https://coveralls.io/builds/11892865) Coverage remained the same at 96.653% when pulling **90b5426b33476d091b19eb50de8d352a2295b8c7 on ameyjadiye:travis-ibmjdk8** into **5f498c0f4783d035bfeb77517731c948f8567b1e on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...
Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/45 [](https://coveralls.io/builds/11892865) Coverage remained the same at 96.653% when pulling **90b5426b33476d091b19eb50de8d352a2295b8c7 on ameyjadiye:travis-ibmjdk8** into **5f498c0f4783d035bfeb77517731c948f8567b1e on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
