[GitHub] commons-text issue #46: TEXT-85:Added CaseUtils class with camel case conver...
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/46 Will try to get to this today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #46: TEXT-85:Added CaseUtils class with camel case conver...
Github user arunvinudss commented on the issue: https://github.com/apache/commons-text/pull/46 @chtompki Updated with the changes you suggested . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #46: TEXT-85:Added CaseUtils class with camel case conver...
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/46 Regarding the `WordUtils.capitalizeFully`, let's open that discussion up in a new Jira. I'll do that now. I think those questions are quite valid. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #46: TEXT-85:Added CaseUtils class with camel case conver...
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/46 Will look this over in the morning. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #46: TEXT-85:Added CaseUtils class with camel case conver...
Github user sebbASF commented on the issue: https://github.com/apache/commons-text/pull/46 I've just realised: this issue is about adding CaseUtils.toCamelCase. Problems with WordUtils belong in a separate issue or JIRA --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #46: TEXT-85:Added CaseUtils class with camel case conver...
Github user arunvinudss commented on the issue: https://github.com/apache/commons-text/pull/46 @sebbASF Nope the first letter is not capitalized and I expected the same . It seems to happen if the specified delimiters are not available on the input though . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #46: TEXT-85:Added CaseUtils class with camel case conver...
Github user sebbASF commented on the issue:
https://github.com/apache/commons-text/pull/46
An empty delimiter array means the caller does not want any delimiters to
be used.
But I would expect the output to capitalise the first letter:
WordUtils.capitalizeFully("i am fine", new char[]{}) --> I am fine
Likewise if the specified delimiters are not found in the input the first
letter should be capitalised.
Does it not do so?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #46: TEXT-85:Added CaseUtils class with camel case conver...
Github user arunvinudss commented on the issue:
https://github.com/apache/commons-text/pull/46
@chtompki Just wondering why space is added as a default delimiter for null
delimiter arrays but not for empty delimiter array in WordUtils.capitalizeFully
.
WordUtils.capitalizeFully("i am fine") --> I Am Fine
WordUtils.capitalizeFully("i am fine", null) --> I Am Fine
WordUtils.capitalizeFully("i am fine", new char[]{}) --> i am fine
I do understand why it happens but not sure if it was intentional ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #46: TEXT-85:Added CaseUtils class with camel case conver...
Github user arunvinudss commented on the issue: https://github.com/apache/commons-text/pull/46 @chtompki The current implementation is based on these assumptions. - All delimiters are stripped off . - Space(32) is added as the default delimiter for all scenarios including null and empty delimiter array. - The boolean parameter for capitalizeFirstCharacter gets higher precedence than delimiters. For ex if '-' is the delimiter then -abc will give Abc as output if true is set for capitalizeFirstCharacter. - A string with no alphabets and only delimiters will return back the input with no changes. Just made logical conclusions let me know if need any changes . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #46: TEXT-85:Added CaseUtils class with camel case conver...
Github user arunvinudss commented on the issue: https://github.com/apache/commons-text/pull/46 @chtompki Using HashSets for checking delimiters it reduces the time complexity from O(nk) to O(n) . I feel it's more efficient . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #46: TEXT-85:Added CaseUtils class with camel case conver...
Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/46 [](https://coveralls.io/builds/11920859) Coverage increased (+0.04%) to 96.691% when pulling **2de01ba6a343ffcce673768e1c603e27dfbda3e9 on arunvinudss:TEXT-85** into **5f498c0f4783d035bfeb77517731c948f8567b1e on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #46: TEXT-85:Added CaseUtils class with camel case conver...
Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/46 [](https://coveralls.io/builds/11920859) Coverage increased (+0.04%) to 96.691% when pulling **2de01ba6a343ffcce673768e1c603e27dfbda3e9 on arunvinudss:TEXT-85** into **5f498c0f4783d035bfeb77517731c948f8567b1e on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #46: TEXT-85:Added CaseUtils class with camel case conver...
Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/46 [](https://coveralls.io/builds/11920859) Coverage increased (+0.04%) to 96.691% when pulling **2de01ba6a343ffcce673768e1c603e27dfbda3e9 on arunvinudss:TEXT-85** into **5f498c0f4783d035bfeb77517731c948f8567b1e on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
