Re: [Math] FastMath missing methods from java.lang.Math...

2021-05-31 Thread Gilles Sadowski 
Le ven. 28 mai 2021 à 10:23, Erik Svensson  a écrit :
>
> https://issues.apache.org/jira/browse/MATH-1591
>
> Please check it out.
> I should base it on the modularized_master branch,

No, it is outdated (merged into "master").

> I take it?

Sure.

Functionality should go in module "commons-math-legacy-core"
(where "FastMath" was moved and renamed "AccurateMath").
Note that the "legacy" specifier refers to codes that depend on other
legacy codes ("legacy-core" still depends on "legacy-exception").
[Of course you are welcome to provide a fully refactored module.]

Regards,
Gilles

>> [...]

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [Math] FastMath missing methods from java.lang.Math...

2021-05-28 Thread Erik Svensson 
https://issues.apache.org/jira/browse/MATH-1591

Please check it out.
I should base it on the modularized_master branch, I take it?

Cheers

Erik Svensson
Principal Architect
Strategic Programs, Platform & Product Engineering
 
Desk
Mobile
Email
Address  
+ 46 8 405 66 39
+ 46 73 449 66 39
erik.svens...@nasdaq.com
Tullvaktsvägen 15, Stockholm
 
 
 
 
 
rewritetomorrow.com 
 

On 2021-05-27, 16:44, "Gilles Sadowski"  wrote:

WARNING - External email; exercise caution.

Le jeu. 27 mai 2021 à 13:53, Erik Svensson  a 
écrit :
>
>
>
> On 2021-05-27, 11:59, "Gilles Sadowski"  wrote:
>
> WARNING - External email; exercise caution.
>
> Hi.
>
> Le jeu. 27 mai 2021 à 11:32, Erik Svensson  
a écrit :
> >
> > Howdy all!
> >
> >
> >
> > I’m comparing FastMath with java.lang.Math and I notice that 
FastMath is no longer Math-complete.
> >
> > Ie, jlM has methods that FastMath doesn’t have.
>
> Incidentally, that's why the unit test suite fails when building with
> JDK 9+ (when
> "JAVA_HOME" is not set properly).
>
>
> >
> > FM is documented as ‘drop-in replacement’ so should the new jlM 
methods be added to FM?
>
> Do you propose to write/port pure Java implementations for those?
>
> I can do that.

Great!
Please create a JIRA report.[1]

Thanks,
Gilles

[1] https://issues.apache.org/jira/browse/MATH

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org


***
CONFIDENTIALITY AND PRIVACY NOTICE: This e-mail and any attachments are for the 
exclusive and confidential use of the intended recipient and may constitute 
non-public information.  Personal data in this email is governed by our Privacy 
Policy at  https://www.nasdaq.com/privacy-statement  unless explicitly excluded 
from it; please see the section in the policy entitled “Situations Where This 
Privacy Policy Does Not Apply” for circumstances where different privacy terms 
govern emailed personal data.  If you received this e-mail in error, 
disclosing, copying, distributing or taking any action in reliance of this 
e-mail is strictly prohibited and may be unlawful. Instead, please notify us 
immediately by return e-mail and promptly delete this message and its 
attachments from your computer system. We do not waive any work product or 
other applicable legal privilege(s) by the transmission of this message.
***

Re: [Math] FastMath missing methods from java.lang.Math...

2021-05-27 Thread Gilles Sadowski 
Le jeu. 27 mai 2021 à 13:53, Erik Svensson  a écrit :
>
>
>
> On 2021-05-27, 11:59, "Gilles Sadowski"  wrote:
>
> WARNING - External email; exercise caution.
>
> Hi.
>
> Le jeu. 27 mai 2021 à 11:32, Erik Svensson  a 
> écrit :
> >
> > Howdy all!
> >
> >
> >
> > I’m comparing FastMath with java.lang.Math and I notice that FastMath 
> is no longer Math-complete.
> >
> > Ie, jlM has methods that FastMath doesn’t have.
>
> Incidentally, that's why the unit test suite fails when building with
> JDK 9+ (when
> "JAVA_HOME" is not set properly).
>
>
> >
> > FM is documented as ‘drop-in replacement’ so should the new jlM methods 
> be added to FM?
>
> Do you propose to write/port pure Java implementations for those?
>
> I can do that.

Great!
Please create a JIRA report.[1]

Thanks,
Gilles

[1] https://issues.apache.org/jira/browse/MATH

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [Math] FastMath missing methods from java.lang.Math...

2021-05-27 Thread Erik Svensson 


On 2021-05-27, 11:59, "Gilles Sadowski"  wrote:

WARNING - External email; exercise caution.

Hi.

Le jeu. 27 mai 2021 à 11:32, Erik Svensson  a 
écrit :
>
> Howdy all!
>
>
>
> I’m comparing FastMath with java.lang.Math and I notice that FastMath is 
no longer Math-complete.
>
> Ie, jlM has methods that FastMath doesn’t have.

Incidentally, that's why the unit test suite fails when building with
JDK 9+ (when
"JAVA_HOME" is not set properly).


>
> FM is documented as ‘drop-in replacement’ so should the new jlM methods 
be added to FM?

Do you propose to write/port pure Java implementations for those?

I can do that. 

/Erik

Regards,
Gilles

> [...]

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org


***
CONFIDENTIALITY AND PRIVACY NOTICE: This e-mail and any attachments are for the 
exclusive and confidential use of the intended recipient and may constitute 
non-public information.  Personal data in this email is governed by our Privacy 
Policy at  https://www.nasdaq.com/privacy-statement  unless explicitly excluded 
from it; please see the section in the policy entitled “Situations Where This 
Privacy Policy Does Not Apply” for circumstances where different privacy terms 
govern emailed personal data.  If you received this e-mail in error, 
disclosing, copying, distributing or taking any action in reliance of this 
e-mail is strictly prohibited and may be unlawful. Instead, please notify us 
immediately by return e-mail and promptly delete this message and its 
attachments from your computer system. We do not waive any work product or 
other applicable legal privilege(s) by the transmission of this message.
***

Re: [Math] FastMath missing methods from java.lang.Math...

2021-05-27 Thread Gilles Sadowski 
Hi.

Le jeu. 27 mai 2021 à 11:32, Erik Svensson  a écrit :
>
> Howdy all!
>
>
>
> I’m comparing FastMath with java.lang.Math and I notice that FastMath is no 
> longer Math-complete.
>
> Ie, jlM has methods that FastMath doesn’t have.

Incidentally, that's why the unit test suite fails when building with
JDK 9+ (when
"JAVA_HOME" is not set properly).

>
> FM is documented as ‘drop-in replacement’ so should the new jlM methods be 
> added to FM?

Do you propose to write/port pure Java implementations for those?

Regards,
Gilles

> [...]

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[Math] FastMath missing methods from java.lang.Math...

2021-05-27 Thread Erik Svensson 
Howdy all!

I’m comparing FastMath with java.lang.Math and I notice that FastMath is no 
longer Math-complete.
Ie, jlM has methods that FastMath doesn’t have.
FM is documented as ‘drop-in replacement’ so should the new jlM methods be 
added to FM?

Methods in question:
fma 
(https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/Math.html#fma(double,double,double))
multiplyFull 
(https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/Math.html#multiplyFull(int,int))
multiplyHigh 
(https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/Math.html#multiplyHigh(long,long))
negateExact 
(https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/Math.html#negateExact(int))
toDegrees 
(https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/Math.html#toDegrees(double))
toRadians 
(https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/Math.html#toRadians(double))

Cheers

Erik Svensson
Principal Architect
Strategic Programs, Platform & Product Engineering

[Nasdaq, Inc.]

Desk
Mobile
Email
Address

+ 46 8 405 66 39
+ 46 73 449 66 39
erik.svens...@nasdaq.com
Tullvaktsvägen 15, Stockholm


[signature_1493358005]

[signature_1597307541]

[signature_204513274]

[signature_2011745041]

[signature_930914556]


rewritetomorrow.com


***
CONFIDENTIALITY AND PRIVACY NOTICE: This e-mail and any attachments are for the 
exclusive and confidential use of the intended recipient and may constitute 
non-public information.  Personal data in this email is governed by our Privacy 
Policy at  https://www.nasdaq.com/privacy-statement  unless explicitly excluded 
from it; please see the section in the policy entitled “Situations Where This 
Privacy Policy Does Not Apply” for circumstances where different privacy terms 
govern emailed personal data.  If you received this e-mail in error, 
disclosing, copying, distributing or taking any action in reliance of this 
e-mail is strictly prohibited and may be unlawful. Instead, please notify us 
immediately by return e-mail and promptly delete this message and its 
attachments from your computer system. We do not waive any work product or 
other applicable legal privilege(s) by the transmission of this message.
***