Re: [bcel] Backwards Incompatible Change to Visitor

2011-08-20 Thread Dave Brosius 

Sebb is right... my mistake... apologies, and thanks for the fix.

dave

On 08/20/2011 09:15 PM, sebb wrote:

On 17 August 2011 07:06, Stefan Bodewig  wrote:

Hi,

with svn revision 1158060 the bcel.generic.Visitor interface has become
package private, breaking the Gump builds of Xalan XSLTC,
commons-javaflow and likely other downstream code.

Has this change been intentional?

I don't think so.

The rest of the commit just removes public from methods.

I assume that was a mistake to change the interface itself, as it does
not agree with the log message.

I've reverted the change of interface visibilty.


Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [bcel] Backwards Incompatible Change to Visitor

2011-08-20 Thread sebb 
On 17 August 2011 07:06, Stefan Bodewig  wrote:
> Hi,
>
> with svn revision 1158060 the bcel.generic.Visitor interface has become
> package private, breaking the Gump builds of Xalan XSLTC,
> commons-javaflow and likely other downstream code.
>
> Has this change been intentional?

I don't think so.

The rest of the commit just removes public from methods.

I assume that was a mistake to change the interface itself, as it does
not agree with the log message.

I've reverted the change of interface visibilty.

> Stefan
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [bcel] Backwards Incompatible Change to Visitor

2011-08-17 Thread Torsten Curdt 
On Wed, Aug 17, 2011 at 8:06 AM, Stefan Bodewig  wrote:
> Hi,
>
> with svn revision 1158060 the bcel.generic.Visitor interface has become
> package private, breaking the Gump builds of Xalan XSLTC,
> commons-javaflow and likely other downstream code.

Gump is so cool :)

cheers,
Torsten

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[bcel] Backwards Incompatible Change to Visitor

2011-08-16 Thread Stefan Bodewig 
Hi,

with svn revision 1158060 the bcel.generic.Visitor interface has become
package private, breaking the Gump builds of Xalan XSLTC,
commons-javaflow and likely other downstream code.

Has this change been intentional?

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org