Re: [ANNOUNCE] Apache Commons Validator 1.9.0

[Gary Gregory]

In this case, the dependency on 3.x will remain the same for the given
major release line for binary compatibility. When we want a Validator 2,
that when we can drop support for Collections 3.

HTH,
Gary

On Mon, Jun 3, 2024, 10:45 AM Amit Pande 
wrote:

> Hello Apache Commons Team,
>
> Reaching out to understand how to migrate to commons-collection4 from
> commons-collections3 given that commons-collection is transitive dependency
> of multiple other artifacts such as commons-validator, commons-beanutils.
>
>
> Thanks,
> Amit
>
>
>
> -Original Message-
> From: Gary Gregory 
> Sent: Tuesday, May 28, 2024 6:31 PM
> To: annou...@apache.org; Commons Developers List ;
> Commons Users List 
> Subject: [ANNOUNCE] Apache Commons Validator 1.9.0
>
>
> CAUTION: This email originated from outside the organization. Do not click
> links or open attachments unless you recognize the sender and know the
> content is safe. If you believe this is a phishing email, use the Report to
> Cybersecurity icon in Outlook.
>
>
>
> The Apache Commons Validator team is pleased to announce the release of
> Apache Commons Validator 1.9.0.
>
> Apache Commons Validator provides the building blocks for both client-side
> and server-side data validation. It may be used standalone or with a
> framework like Struts.
>
> This is a maintenance and bug fix release that requires Java 8.
>
> For complete information on Apache Commons Validator, including
> instructions on how to submit bug reports, patches, or suggestions for
> improvement, see the Apache Commons Validator website:
>
> http://commons.apache.org/proper/commons-validator/
>
> Download page:
> http://commons.apache.org/proper/commons-validator/download_validator.cgi
>
> Historical list of changes:
> http://commons.apache.org/proper/commons-validator/changes-report.html
>
> Enjoy!
> Gary Gregory
> -Apache Commons Team
>
> -
> To unsubscribe, e-mail: user-unsubscr...@commons.apache.org
> For additional commands, e-mail: user-h...@commons.apache.org
>
>
> -
> To unsubscribe, e-mail: user-unsubscr...@commons.apache.org
> For additional commands, e-mail: user-h...@commons.apache.org
>
>

RE: [ANNOUNCE] Apache Commons Validator 1.9.0

[Amit Pande]

Hello Apache Commons Team,

Reaching out to understand how to migrate to commons-collection4 from 
commons-collections3 given that commons-collection is transitive dependency of 
multiple other artifacts such as commons-validator, commons-beanutils.


Thanks,
Amit



-Original Message-
From: Gary Gregory 
Sent: Tuesday, May 28, 2024 6:31 PM
To: annou...@apache.org; Commons Developers List ; 
Commons Users List 
Subject: [ANNOUNCE] Apache Commons Validator 1.9.0


CAUTION: This email originated from outside the organization. Do not click 
links or open attachments unless you recognize the sender and know the content 
is safe. If you believe this is a phishing email, use the Report to 
Cybersecurity icon in Outlook.



The Apache Commons Validator team is pleased to announce the release of Apache 
Commons Validator 1.9.0.

Apache Commons Validator provides the building blocks for both client-side and 
server-side data validation. It may be used standalone or with a framework like 
Struts.

This is a maintenance and bug fix release that requires Java 8.

For complete information on Apache Commons Validator, including instructions on 
how to submit bug reports, patches, or suggestions for improvement, see the 
Apache Commons Validator website:

http://commons.apache.org/proper/commons-validator/

Download page: 
http://commons.apache.org/proper/commons-validator/download_validator.cgi

Historical list of changes:
http://commons.apache.org/proper/commons-validator/changes-report.html

Enjoy!
Gary Gregory
-Apache Commons Team

-
To unsubscribe, e-mail: user-unsubscr...@commons.apache.org
For additional commands, e-mail: user-h...@commons.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[ANNOUNCE] Apache Commons Validator 1.9.0

[Gary Gregory]

The Apache Commons Validator team is pleased to announce the release
of Apache Commons Validator 1.9.0.

Apache Commons Validator provides the building blocks for both
client-side and server-side data validation. It may be used standalone
or with a framework like Struts.

This is a maintenance and bug fix release that requires Java 8.

For complete information on Apache Commons Validator, including
instructions on how to submit bug reports, patches, or suggestions for
improvement, see the Apache Commons Validator website:

http://commons.apache.org/proper/commons-validator/

Download page: 
http://commons.apache.org/proper/commons-validator/download_validator.cgi

Historical list of changes:
http://commons.apache.org/proper/commons-validator/changes-report.html

Enjoy!
Gary Gregory
-Apache Commons Team

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[RESULT][VOTE] Release Apache Commons Validator 1.9.0 based on RC1

[Gary Gregory]

This vote thread passes with the following +1 binding votes:

- Henri Biestro (henrib)
- Phil Steitz (psteitz)
- Gary Gregory (ggregory)

Gary

On Sun, May 26, 2024 at 9:49 PM Gary Gregory  wrote:
>
> My +1
>
> Gary
>
>
> On Sat, May 25, 2024, 5:11 PM Gary Gregory  wrote:
>>
>> We have fixed a few bugs and added enhancements since Apache Commons
>> Validator 1.8.0 was released, so I would like to release Apache
>> Commons Validator 1.9.0.
>>
>> Apache Commons Validator 1.9.0 RC1 is available for review here:
>> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1
>> (svn revision 69387)
>>
>> The Git tag commons-validator-1.9.0-RC1 commit for this RC is
>> 191171b2fb1500d24c42a809cf13386ac8f4ecac which you can browse here:
>> 
>> https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=191171b2fb1500d24c42a809cf13386ac8f4ecac
>> You may checkout this tag using:
>>     git clone https://gitbox.apache.org/repos/asf/commons-validator.git
>> --branch commons-validator-1.9.0-RC1 commons-validator-1.9.0-RC1
>>
>> Maven artifacts are here:
>> 
>> https://repository.apache.org/content/repositories/orgapachecommons-1734/commons-validator/commons-validator/1.9.0/
>>
>> These are the artifacts and their hashes:
>>
>> #Release SHA-512s
>> #Sat May 25 20:36:23 UTC 2024
>> commons-validator-1.9.0-bin.tar.gz=a755d2be1b9fb3cb75cb71c2c6143969eabd8ba48401dd86cad6c658e0de72e52a887e157ef38e780471382c2da68db228866303f3d4cb4500f995b8b3967476
>> commons-validator-1.9.0-bin.zip=7c0cb444f4e162c46cbd356c8a3c8b166b06bcaf79b6c433ee5ad585498a1f0b4dfef3606ca4beedeef418b5b56209f86cac6dd2c1c8fa4dfe62c679df0018db
>> commons-validator-1.9.0-bom.json=7e9baecc1b58f5de101d247b95d871a5b3227603a99eddf8bcce07e3656024dffc615b8ec0b765376bf640f9596581cb483830861878474fe79339bb84352cd3
>> commons-validator-1.9.0-bom.xml=d4a5d380ade4eec7f7a71cb260a61901b5945129bc448894c89ae10d3375a4dac2898be6498eb3aaba60cd8c464837f7884521fc467285c0fc2f129b92e52bf9
>> commons-validator-1.9.0-javadoc.jar=b4b3dee67453e72ea070140d858ff66c45ed5794b69b68760639726cea0edba1224cb2c1cda64411893ded0ba96e2758a7677e2ffa21249899630e39949d88ed
>> commons-validator-1.9.0-sources.jar=f91890e90979ed1c7abcebb4b37f223a163bfc73bc3da6a4bc3469d399e7d0ff9315d89e528bab88b53cd0ef0a1c3f8c7e0e463a784f47546ae8ca8f3d4c2269
>> commons-validator-1.9.0-src.tar.gz=4e36f0ec5b1b8ae9724f020c51396332444d7359988fbcceaab004cde30e223b8130315e85d9b3d568fdc30399e9e503783bb81f217fe5f846f9e14c484a1fe0
>> commons-validator-1.9.0-src.zip=201ee0723d5f078b128aa7a54bc2b03494c467e6f2df843d74bf3607d085067a0ea395e1e2174fd3237248f18f8bc5e7469e72fc9378813cbe7e5397e20c03d1
>> commons-validator-1.9.0-test-sources.jar=6fee6648f66e666ff49e99ef3ee49039436bd19b150eb2294d3b6a0e57dab7c0a9e7bcaecde005c478f24a21729d59365e4deb096a579b5044aafa513c90972c
>> commons-validator-1.9.0-tests.jar=2c2a13fd3c242c1ab06e9ef8f6f18ed3eae392b8fb0a5c9bbce137ce0e9873820c37197a8517984a42d4804433501521c5f5970ef8ae868f8c6d2a061e88b05e
>> commons-validator_commons-validator-1.9.0.spdx.json=bd19d362ae59afbe41425f57e02d4d5c32f99b9e218ebdf6ea8eaa388cb9fb28721e93781f084533e98eb345d9d7bc5a96790e06e0ac1f0d0aaff6db063042fe
>>
>> I have tested this with 'mvn' and 'mvn -V -Prelease -Ptest-deploy -P
>> jacoco -P japicmp clean package site deploy' using:
>>
>> openjdk version "17.0.11" 2024-04-16
>> OpenJDK Runtime Environment Homebrew (build 17.0.11+0)
>> OpenJDK 64-Bit Server VM Homebrew (build 17.0.11+0, mixed mode, sharing)
>>
>> Apache Maven 3.9.7 (8b094c9513efc1b9ce2d952b3b9c8eaedaf8cbf0)
>> Maven home: /usr/local/Cellar/maven/3.9.7/libexec
>> Java version: 17.0.11, vendor: Homebrew, runtime:
>> /usr/local/Cellar/openjdk@17/17.0.11/libexec/openjdk.jdk/Contents/Home
>> Default locale: en_US, platform encoding: UTF-8
>> OS name: "mac os x", version: "14.5", arch: "x86_64", family: "mac"
>>
>> Darwin  23.5.0 Darwin Kernel Version 23.5.0: Wed May  1 20:09:52
>> PDT 2024; root:xnu-10063.121.3~5/RELEASE_X86_64 x86_64
>>
>> Details of changes since 1.8.0 are in the release notes:
>> 
>> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/RELEASE-NOTES.txt
>>     
>> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/site/changes-report.html
>>
>> Site:
>> 
>> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/site/index.html
>> (note some *relative* links are broken and the 1.9.0 directories
>> are not yet created - these will be OK once the site is deployed.)
>>
>> JApiCm

Re: [VOTE] Release Apache Commons Validator 1.9.0 based on RC1

[Gary Gregory]

My +1

Gary


On Sat, May 25, 2024, 5:11 PM Gary Gregory  wrote:

> We have fixed a few bugs and added enhancements since Apache Commons
> Validator 1.8.0 was released, so I would like to release Apache
> Commons Validator 1.9.0.
>
> Apache Commons Validator 1.9.0 RC1 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1
> (svn revision 69387)
>
> The Git tag commons-validator-1.9.0-RC1 commit for this RC is
> 191171b2fb1500d24c42a809cf13386ac8f4ecac which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=191171b2fb1500d24c42a809cf13386ac8f4ecac
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-validator.git
> --branch
> <https://gitbox.apache.org/repos/asf/commons-validator.git--branch>
> commons-validator-1.9.0-RC1 commons-validator-1.9.0-RC1
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1734/commons-validator/commons-validator/1.9.0/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Sat May 25 20:36:23 UTC 2024
>
> commons-validator-1.9.0-bin.tar.gz=a755d2be1b9fb3cb75cb71c2c6143969eabd8ba48401dd86cad6c658e0de72e52a887e157ef38e780471382c2da68db228866303f3d4cb4500f995b8b3967476
>
> commons-validator-1.9.0-bin.zip=7c0cb444f4e162c46cbd356c8a3c8b166b06bcaf79b6c433ee5ad585498a1f0b4dfef3606ca4beedeef418b5b56209f86cac6dd2c1c8fa4dfe62c679df0018db
>
> commons-validator-1.9.0-bom.json=7e9baecc1b58f5de101d247b95d871a5b3227603a99eddf8bcce07e3656024dffc615b8ec0b765376bf640f9596581cb483830861878474fe79339bb84352cd3
>
> commons-validator-1.9.0-bom.xml=d4a5d380ade4eec7f7a71cb260a61901b5945129bc448894c89ae10d3375a4dac2898be6498eb3aaba60cd8c464837f7884521fc467285c0fc2f129b92e52bf9
>
> commons-validator-1.9.0-javadoc.jar=b4b3dee67453e72ea070140d858ff66c45ed5794b69b68760639726cea0edba1224cb2c1cda64411893ded0ba96e2758a7677e2ffa21249899630e39949d88ed
>
> commons-validator-1.9.0-sources.jar=f91890e90979ed1c7abcebb4b37f223a163bfc73bc3da6a4bc3469d399e7d0ff9315d89e528bab88b53cd0ef0a1c3f8c7e0e463a784f47546ae8ca8f3d4c2269
>
> commons-validator-1.9.0-src.tar.gz=4e36f0ec5b1b8ae9724f020c51396332444d7359988fbcceaab004cde30e223b8130315e85d9b3d568fdc30399e9e503783bb81f217fe5f846f9e14c484a1fe0
>
> commons-validator-1.9.0-src.zip=201ee0723d5f078b128aa7a54bc2b03494c467e6f2df843d74bf3607d085067a0ea395e1e2174fd3237248f18f8bc5e7469e72fc9378813cbe7e5397e20c03d1
>
> commons-validator-1.9.0-test-sources.jar=6fee6648f66e666ff49e99ef3ee49039436bd19b150eb2294d3b6a0e57dab7c0a9e7bcaecde005c478f24a21729d59365e4deb096a579b5044aafa513c90972c
>
> commons-validator-1.9.0-tests.jar=2c2a13fd3c242c1ab06e9ef8f6f18ed3eae392b8fb0a5c9bbce137ce0e9873820c37197a8517984a42d4804433501521c5f5970ef8ae868f8c6d2a061e88b05e
>
> commons-validator_commons-validator-1.9.0.spdx.json=bd19d362ae59afbe41425f57e02d4d5c32f99b9e218ebdf6ea8eaa388cb9fb28721e93781f084533e98eb345d9d7bc5a96790e06e0ac1f0d0aaff6db063042fe
>
> I have tested this with 'mvn' and 'mvn -V -Prelease -Ptest-deploy -P
> jacoco -P japicmp clean package site deploy' using:
>
> openjdk version "17.0.11" 2024-04-16
> OpenJDK Runtime Environment Homebrew (build 17.0.11+0)
> OpenJDK 64-Bit Server VM Homebrew (build 17.0.11+0, mixed mode, sharing)
>
> Apache Maven 3.9.7 (8b094c9513efc1b9ce2d952b3b9c8eaedaf8cbf0)
> Maven home: /usr/local/Cellar/maven/3.9.7/libexec
> Java version: 17.0.11, vendor: Homebrew, runtime:
> /usr/local/Cellar/openjdk@17/17.0.11/libexec/openjdk.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "14.5", arch: "x86_64", family: "mac"
>
> Darwin  23.5.0 Darwin Kernel Version 23.5.0: Wed May  1 20:09:52
> PDT 2024; root:xnu-10063.121.3~5/RELEASE_X86_64 x86_64
>
> Details of changes since 1.8.0 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/site/changes-report.html
>
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/site/index.html
> (note some *relative* links are broken and the 1.9.0 directories
> are not yet created - these will be OK once the site is deployed.)
>
> JApiCmp Report (compared to 1.8.0):
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/site/japicmp.html
>
> RAT Report:
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/site/rat-report.html
>
> KEYS:
>   https://downloads.apache.org/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will c

Re: [VOTE] Release Apache Commons Validator 1.9.0 based on RC1

[Phil Steitz]

[+1]
Checked build, sigs, reports, notes.  All look good.
Tested on
Apache Maven 3.9.3
Java version: 17.0.10, java-17-openjdk-amd64
OS name: "linux", version: "5.15.0-107-generic", arch: "amd64", family:
"unix"

Phil


On Sat, May 25, 2024 at 2:12 PM Gary Gregory  wrote:

> We have fixed a few bugs and added enhancements since Apache Commons
> Validator 1.8.0 was released, so I would like to release Apache
> Commons Validator 1.9.0.
>
> Apache Commons Validator 1.9.0 RC1 is available for review here:
>     https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1
> (svn revision 69387)
>
> The Git tag commons-validator-1.9.0-RC1 commit for this RC is
> 191171b2fb1500d24c42a809cf13386ac8f4ecac which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=191171b2fb1500d24c42a809cf13386ac8f4ecac
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-validator.git
> --branch
> <https://gitbox.apache.org/repos/asf/commons-validator.git--branch>
> commons-validator-1.9.0-RC1 commons-validator-1.9.0-RC1
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1734/commons-validator/commons-validator/1.9.0/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Sat May 25 20:36:23 UTC 2024
>
> commons-validator-1.9.0-bin.tar.gz=a755d2be1b9fb3cb75cb71c2c6143969eabd8ba48401dd86cad6c658e0de72e52a887e157ef38e780471382c2da68db228866303f3d4cb4500f995b8b3967476
>
> commons-validator-1.9.0-bin.zip=7c0cb444f4e162c46cbd356c8a3c8b166b06bcaf79b6c433ee5ad585498a1f0b4dfef3606ca4beedeef418b5b56209f86cac6dd2c1c8fa4dfe62c679df0018db
>
> commons-validator-1.9.0-bom.json=7e9baecc1b58f5de101d247b95d871a5b3227603a99eddf8bcce07e3656024dffc615b8ec0b765376bf640f9596581cb483830861878474fe79339bb84352cd3
>
> commons-validator-1.9.0-bom.xml=d4a5d380ade4eec7f7a71cb260a61901b5945129bc448894c89ae10d3375a4dac2898be6498eb3aaba60cd8c464837f7884521fc467285c0fc2f129b92e52bf9
>
> commons-validator-1.9.0-javadoc.jar=b4b3dee67453e72ea070140d858ff66c45ed5794b69b68760639726cea0edba1224cb2c1cda64411893ded0ba96e2758a7677e2ffa21249899630e39949d88ed
>
> commons-validator-1.9.0-sources.jar=f91890e90979ed1c7abcebb4b37f223a163bfc73bc3da6a4bc3469d399e7d0ff9315d89e528bab88b53cd0ef0a1c3f8c7e0e463a784f47546ae8ca8f3d4c2269
>
> commons-validator-1.9.0-src.tar.gz=4e36f0ec5b1b8ae9724f020c51396332444d7359988fbcceaab004cde30e223b8130315e85d9b3d568fdc30399e9e503783bb81f217fe5f846f9e14c484a1fe0
>
> commons-validator-1.9.0-src.zip=201ee0723d5f078b128aa7a54bc2b03494c467e6f2df843d74bf3607d085067a0ea395e1e2174fd3237248f18f8bc5e7469e72fc9378813cbe7e5397e20c03d1
>
> commons-validator-1.9.0-test-sources.jar=6fee6648f66e666ff49e99ef3ee49039436bd19b150eb2294d3b6a0e57dab7c0a9e7bcaecde005c478f24a21729d59365e4deb096a579b5044aafa513c90972c
>
> commons-validator-1.9.0-tests.jar=2c2a13fd3c242c1ab06e9ef8f6f18ed3eae392b8fb0a5c9bbce137ce0e9873820c37197a8517984a42d4804433501521c5f5970ef8ae868f8c6d2a061e88b05e
>
> commons-validator_commons-validator-1.9.0.spdx.json=bd19d362ae59afbe41425f57e02d4d5c32f99b9e218ebdf6ea8eaa388cb9fb28721e93781f084533e98eb345d9d7bc5a96790e06e0ac1f0d0aaff6db063042fe
>
> I have tested this with 'mvn' and 'mvn -V -Prelease -Ptest-deploy -P
> jacoco -P japicmp clean package site deploy' using:
>
> openjdk version "17.0.11" 2024-04-16
> OpenJDK Runtime Environment Homebrew (build 17.0.11+0)
> OpenJDK 64-Bit Server VM Homebrew (build 17.0.11+0, mixed mode, sharing)
>
> Apache Maven 3.9.7 (8b094c9513efc1b9ce2d952b3b9c8eaedaf8cbf0)
> Maven home: /usr/local/Cellar/maven/3.9.7/libexec
> Java version: 17.0.11, vendor: Homebrew, runtime:
> /usr/local/Cellar/openjdk@17/17.0.11/libexec/openjdk.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "14.5", arch: "x86_64", family: "mac"
>
> Darwin  23.5.0 Darwin Kernel Version 23.5.0: Wed May  1 20:09:52
> PDT 2024; root:xnu-10063.121.3~5/RELEASE_X86_64 x86_64
>
> Details of changes since 1.8.0 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/site/changes-report.html
>
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/site/index.html
> (note some *relative* links are broken and the 1.9.0 directories
> are not yet created - these will be OK once the site is deployed.)
>
> JApiCmp Report (compared to 1.8.0):
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/site/japicmp.html
>
> RAT Report:

Re: [VOTE] Release Apache Commons Validator 1.9.0 based on RC1

[Gary Gregory]

Tomas,

The link you provided is not relevant to Commons CLI because the class
SetUniqueList from Commons Collections the link mentions is not used
by CLI, so there is nothing to change.

Gary

On Sun, May 26, 2024 at 10:06 AM Tomas Lanik  wrote:
>
> Hi All,
> Has the security issue (
> https://devhub.checkmarx.com/cve-details/Cx78f40514-81ff/ ) related
> to commons-collections:commons-collections:3.2.2 been addressed?
> I can not see it in release notes.
>
> FYI
>
> Tom
>
> On Sat, May 25, 2024 at 11:12 PM Gary Gregory  wrote:
>
> > We have fixed a few bugs and added enhancements since Apache Commons
> > Validator 1.8.0 was released, so I would like to release Apache
> > Commons Validator 1.9.0.
> >
> > Apache Commons Validator 1.9.0 RC1 is available for review here:
> > https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1
> > (svn revision 69387)
> >
> > The Git tag commons-validator-1.9.0-RC1 commit for this RC is
> > 191171b2fb1500d24c42a809cf13386ac8f4ecac which you can browse here:
> >
> > https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=191171b2fb1500d24c42a809cf13386ac8f4ecac
> > You may checkout this tag using:
> > git clone https://gitbox.apache.org/repos/asf/commons-validator.git
> > --branch
> > <https://gitbox.apache.org/repos/asf/commons-validator.git--branch>
> > commons-validator-1.9.0-RC1 commons-validator-1.9.0-RC1
> >
> > Maven artifacts are here:
> >
> > https://repository.apache.org/content/repositories/orgapachecommons-1734/commons-validator/commons-validator/1.9.0/
> >
> > These are the artifacts and their hashes:
> >
> > #Release SHA-512s
> > #Sat May 25 20:36:23 UTC 2024
> >
> > commons-validator-1.9.0-bin.tar.gz=a755d2be1b9fb3cb75cb71c2c6143969eabd8ba48401dd86cad6c658e0de72e52a887e157ef38e780471382c2da68db228866303f3d4cb4500f995b8b3967476
> >
> > commons-validator-1.9.0-bin.zip=7c0cb444f4e162c46cbd356c8a3c8b166b06bcaf79b6c433ee5ad585498a1f0b4dfef3606ca4beedeef418b5b56209f86cac6dd2c1c8fa4dfe62c679df0018db
> >
> > commons-validator-1.9.0-bom.json=7e9baecc1b58f5de101d247b95d871a5b3227603a99eddf8bcce07e3656024dffc615b8ec0b765376bf640f9596581cb483830861878474fe79339bb84352cd3
> >
> > commons-validator-1.9.0-bom.xml=d4a5d380ade4eec7f7a71cb260a61901b5945129bc448894c89ae10d3375a4dac2898be6498eb3aaba60cd8c464837f7884521fc467285c0fc2f129b92e52bf9
> >
> > commons-validator-1.9.0-javadoc.jar=b4b3dee67453e72ea070140d858ff66c45ed5794b69b68760639726cea0edba1224cb2c1cda64411893ded0ba96e2758a7677e2ffa21249899630e39949d88ed
> >
> > commons-validator-1.9.0-sources.jar=f91890e90979ed1c7abcebb4b37f223a163bfc73bc3da6a4bc3469d399e7d0ff9315d89e528bab88b53cd0ef0a1c3f8c7e0e463a784f47546ae8ca8f3d4c2269
> >
> > commons-validator-1.9.0-src.tar.gz=4e36f0ec5b1b8ae9724f020c51396332444d7359988fbcceaab004cde30e223b8130315e85d9b3d568fdc30399e9e503783bb81f217fe5f846f9e14c484a1fe0
> >
> > commons-validator-1.9.0-src.zip=201ee0723d5f078b128aa7a54bc2b03494c467e6f2df843d74bf3607d085067a0ea395e1e2174fd3237248f18f8bc5e7469e72fc9378813cbe7e5397e20c03d1
> >
> > commons-validator-1.9.0-test-sources.jar=6fee6648f66e666ff49e99ef3ee49039436bd19b150eb2294d3b6a0e57dab7c0a9e7bcaecde005c478f24a21729d59365e4deb096a579b5044aafa513c90972c
> >
> > commons-validator-1.9.0-tests.jar=2c2a13fd3c242c1ab06e9ef8f6f18ed3eae392b8fb0a5c9bbce137ce0e9873820c37197a8517984a42d4804433501521c5f5970ef8ae868f8c6d2a061e88b05e
> >
> > commons-validator_commons-validator-1.9.0.spdx.json=bd19d362ae59afbe41425f57e02d4d5c32f99b9e218ebdf6ea8eaa388cb9fb28721e93781f084533e98eb345d9d7bc5a96790e06e0ac1f0d0aaff6db063042fe
> >
> > I have tested this with 'mvn' and 'mvn -V -Prelease -Ptest-deploy -P
> > jacoco -P japicmp clean package site deploy' using:
> >
> > openjdk version "17.0.11" 2024-04-16
> > OpenJDK Runtime Environment Homebrew (build 17.0.11+0)
> > OpenJDK 64-Bit Server VM Homebrew (build 17.0.11+0, mixed mode, sharing)
> >
> > Apache Maven 3.9.7 (8b094c9513efc1b9ce2d952b3b9c8eaedaf8cbf0)
> > Maven home: /usr/local/Cellar/maven/3.9.7/libexec
> > Java version: 17.0.11, vendor: Homebrew, runtime:
> > /usr/local/Cellar/openjdk@17/17.0.11/libexec/openjdk.jdk/Contents/Home
> > Default locale: en_US, platform encoding: UTF-8
> > OS name: "mac os x", version: "14.5", arch: "x86_64", family: "mac"
> >
> > Darwin  23.5.0 Darwin Kernel Version 23.5.0: Wed May  1 20:09:52
> > PDT 2024; root:xnu-10063.121.3~5/RELEASE_X86_64 x86_64
> >
> > Details of changes since 1.8.0 are in the release notes:
> >
> 

Re: [VOTE] Release Apache Commons Validator 1.9.0 based on RC1

[Henri Biestro]

[+1]

Site looks good, reports are clean (nit: coverage is low, JIRA report need some 
work wrt fix version/reported version).
Build using:
Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
Maven home: /Users/hbiestro/Java/apache-maven-3.8.6
Java version: 1.8.0_352, vendor: Azul Systems, Inc., runtime: 
/Library/Java/JavaVirtualMachines/zulu-8.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "14.5", arch: "aarch64", family: "mac"

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Apache Commons Validator 1.9.0 based on RC1

[Tomas Lanik]

Hi All,
Has the security issue (
https://devhub.checkmarx.com/cve-details/Cx78f40514-81ff/ ) related
to commons-collections:commons-collections:3.2.2 been addressed?
I can not see it in release notes.

FYI

Tom

On Sat, May 25, 2024 at 11:12 PM Gary Gregory  wrote:

> We have fixed a few bugs and added enhancements since Apache Commons
> Validator 1.8.0 was released, so I would like to release Apache
> Commons Validator 1.9.0.
>
> Apache Commons Validator 1.9.0 RC1 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1
> (svn revision 69387)
>
> The Git tag commons-validator-1.9.0-RC1 commit for this RC is
> 191171b2fb1500d24c42a809cf13386ac8f4ecac which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=191171b2fb1500d24c42a809cf13386ac8f4ecac
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-validator.git
> --branch
> <https://gitbox.apache.org/repos/asf/commons-validator.git--branch>
> commons-validator-1.9.0-RC1 commons-validator-1.9.0-RC1
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1734/commons-validator/commons-validator/1.9.0/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Sat May 25 20:36:23 UTC 2024
>
> commons-validator-1.9.0-bin.tar.gz=a755d2be1b9fb3cb75cb71c2c6143969eabd8ba48401dd86cad6c658e0de72e52a887e157ef38e780471382c2da68db228866303f3d4cb4500f995b8b3967476
>
> commons-validator-1.9.0-bin.zip=7c0cb444f4e162c46cbd356c8a3c8b166b06bcaf79b6c433ee5ad585498a1f0b4dfef3606ca4beedeef418b5b56209f86cac6dd2c1c8fa4dfe62c679df0018db
>
> commons-validator-1.9.0-bom.json=7e9baecc1b58f5de101d247b95d871a5b3227603a99eddf8bcce07e3656024dffc615b8ec0b765376bf640f9596581cb483830861878474fe79339bb84352cd3
>
> commons-validator-1.9.0-bom.xml=d4a5d380ade4eec7f7a71cb260a61901b5945129bc448894c89ae10d3375a4dac2898be6498eb3aaba60cd8c464837f7884521fc467285c0fc2f129b92e52bf9
>
> commons-validator-1.9.0-javadoc.jar=b4b3dee67453e72ea070140d858ff66c45ed5794b69b68760639726cea0edba1224cb2c1cda64411893ded0ba96e2758a7677e2ffa21249899630e39949d88ed
>
> commons-validator-1.9.0-sources.jar=f91890e90979ed1c7abcebb4b37f223a163bfc73bc3da6a4bc3469d399e7d0ff9315d89e528bab88b53cd0ef0a1c3f8c7e0e463a784f47546ae8ca8f3d4c2269
>
> commons-validator-1.9.0-src.tar.gz=4e36f0ec5b1b8ae9724f020c51396332444d7359988fbcceaab004cde30e223b8130315e85d9b3d568fdc30399e9e503783bb81f217fe5f846f9e14c484a1fe0
>
> commons-validator-1.9.0-src.zip=201ee0723d5f078b128aa7a54bc2b03494c467e6f2df843d74bf3607d085067a0ea395e1e2174fd3237248f18f8bc5e7469e72fc9378813cbe7e5397e20c03d1
>
> commons-validator-1.9.0-test-sources.jar=6fee6648f66e666ff49e99ef3ee49039436bd19b150eb2294d3b6a0e57dab7c0a9e7bcaecde005c478f24a21729d59365e4deb096a579b5044aafa513c90972c
>
> commons-validator-1.9.0-tests.jar=2c2a13fd3c242c1ab06e9ef8f6f18ed3eae392b8fb0a5c9bbce137ce0e9873820c37197a8517984a42d4804433501521c5f5970ef8ae868f8c6d2a061e88b05e
>
> commons-validator_commons-validator-1.9.0.spdx.json=bd19d362ae59afbe41425f57e02d4d5c32f99b9e218ebdf6ea8eaa388cb9fb28721e93781f084533e98eb345d9d7bc5a96790e06e0ac1f0d0aaff6db063042fe
>
> I have tested this with 'mvn' and 'mvn -V -Prelease -Ptest-deploy -P
> jacoco -P japicmp clean package site deploy' using:
>
> openjdk version "17.0.11" 2024-04-16
> OpenJDK Runtime Environment Homebrew (build 17.0.11+0)
> OpenJDK 64-Bit Server VM Homebrew (build 17.0.11+0, mixed mode, sharing)
>
> Apache Maven 3.9.7 (8b094c9513efc1b9ce2d952b3b9c8eaedaf8cbf0)
> Maven home: /usr/local/Cellar/maven/3.9.7/libexec
> Java version: 17.0.11, vendor: Homebrew, runtime:
> /usr/local/Cellar/openjdk@17/17.0.11/libexec/openjdk.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "14.5", arch: "x86_64", family: "mac"
>
> Darwin  23.5.0 Darwin Kernel Version 23.5.0: Wed May  1 20:09:52
> PDT 2024; root:xnu-10063.121.3~5/RELEASE_X86_64 x86_64
>
> Details of changes since 1.8.0 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/site/changes-report.html
>
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/site/index.html
> (note some *relative* links are broken and the 1.9.0 directories
> are not yet created - these will be OK once the site is deployed.)
>
> JApiCmp Report (compared to 1.8.0):
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/site/japicmp.html
>
> RAT Report:
>
> https://dist.apache.org/repos/d

[VOTE] Release Apache Commons Validator 1.9.0 based on RC1

[Gary Gregory]

We have fixed a few bugs and added enhancements since Apache Commons
Validator 1.8.0 was released, so I would like to release Apache
Commons Validator 1.9.0.

Apache Commons Validator 1.9.0 RC1 is available for review here:
https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1
(svn revision 69387)

The Git tag commons-validator-1.9.0-RC1 commit for this RC is
191171b2fb1500d24c42a809cf13386ac8f4ecac which you can browse here:

https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=191171b2fb1500d24c42a809cf13386ac8f4ecac
You may checkout this tag using:
git clone https://gitbox.apache.org/repos/asf/commons-validator.git
--branch commons-validator-1.9.0-RC1 commons-validator-1.9.0-RC1

Maven artifacts are here:

https://repository.apache.org/content/repositories/orgapachecommons-1734/commons-validator/commons-validator/1.9.0/

These are the artifacts and their hashes:

#Release SHA-512s
#Sat May 25 20:36:23 UTC 2024
commons-validator-1.9.0-bin.tar.gz=a755d2be1b9fb3cb75cb71c2c6143969eabd8ba48401dd86cad6c658e0de72e52a887e157ef38e780471382c2da68db228866303f3d4cb4500f995b8b3967476
commons-validator-1.9.0-bin.zip=7c0cb444f4e162c46cbd356c8a3c8b166b06bcaf79b6c433ee5ad585498a1f0b4dfef3606ca4beedeef418b5b56209f86cac6dd2c1c8fa4dfe62c679df0018db
commons-validator-1.9.0-bom.json=7e9baecc1b58f5de101d247b95d871a5b3227603a99eddf8bcce07e3656024dffc615b8ec0b765376bf640f9596581cb483830861878474fe79339bb84352cd3
commons-validator-1.9.0-bom.xml=d4a5d380ade4eec7f7a71cb260a61901b5945129bc448894c89ae10d3375a4dac2898be6498eb3aaba60cd8c464837f7884521fc467285c0fc2f129b92e52bf9
commons-validator-1.9.0-javadoc.jar=b4b3dee67453e72ea070140d858ff66c45ed5794b69b68760639726cea0edba1224cb2c1cda64411893ded0ba96e2758a7677e2ffa21249899630e39949d88ed
commons-validator-1.9.0-sources.jar=f91890e90979ed1c7abcebb4b37f223a163bfc73bc3da6a4bc3469d399e7d0ff9315d89e528bab88b53cd0ef0a1c3f8c7e0e463a784f47546ae8ca8f3d4c2269
commons-validator-1.9.0-src.tar.gz=4e36f0ec5b1b8ae9724f020c51396332444d7359988fbcceaab004cde30e223b8130315e85d9b3d568fdc30399e9e503783bb81f217fe5f846f9e14c484a1fe0
commons-validator-1.9.0-src.zip=201ee0723d5f078b128aa7a54bc2b03494c467e6f2df843d74bf3607d085067a0ea395e1e2174fd3237248f18f8bc5e7469e72fc9378813cbe7e5397e20c03d1
commons-validator-1.9.0-test-sources.jar=6fee6648f66e666ff49e99ef3ee49039436bd19b150eb2294d3b6a0e57dab7c0a9e7bcaecde005c478f24a21729d59365e4deb096a579b5044aafa513c90972c
commons-validator-1.9.0-tests.jar=2c2a13fd3c242c1ab06e9ef8f6f18ed3eae392b8fb0a5c9bbce137ce0e9873820c37197a8517984a42d4804433501521c5f5970ef8ae868f8c6d2a061e88b05e
commons-validator_commons-validator-1.9.0.spdx.json=bd19d362ae59afbe41425f57e02d4d5c32f99b9e218ebdf6ea8eaa388cb9fb28721e93781f084533e98eb345d9d7bc5a96790e06e0ac1f0d0aaff6db063042fe

I have tested this with 'mvn' and 'mvn -V -Prelease -Ptest-deploy -P
jacoco -P japicmp clean package site deploy' using:

openjdk version "17.0.11" 2024-04-16
OpenJDK Runtime Environment Homebrew (build 17.0.11+0)
OpenJDK 64-Bit Server VM Homebrew (build 17.0.11+0, mixed mode, sharing)

Apache Maven 3.9.7 (8b094c9513efc1b9ce2d952b3b9c8eaedaf8cbf0)
Maven home: /usr/local/Cellar/maven/3.9.7/libexec
Java version: 17.0.11, vendor: Homebrew, runtime:
/usr/local/Cellar/openjdk@17/17.0.11/libexec/openjdk.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "14.5", arch: "x86_64", family: "mac"

Darwin  23.5.0 Darwin Kernel Version 23.5.0: Wed May  1 20:09:52
PDT 2024; root:xnu-10063.121.3~5/RELEASE_X86_64 x86_64

Details of changes since 1.8.0 are in the release notes:

https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/RELEASE-NOTES.txt

https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/site/changes-report.html

Site:

https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/site/index.html
(note some *relative* links are broken and the 1.9.0 directories
are not yet created - these will be OK once the site is deployed.)

JApiCmp Report (compared to 1.8.0):

https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/site/japicmp.html

RAT Report:

https://dist.apache.org/repos/dist/dev/commons/validator/1.9.0-RC1/site/rat-report.html

KEYS:
  https://downloads.apache.org/commons/KEYS

Please review the release candidate and vote.
This vote will close no sooner than 72 hours from now.

  [ ] +1 Release these artifacts
  [ ] +0 OK, but...
  [ ] -0 OK, but really should fix...
  [ ] -1 I oppose this release because...

Thank you,

Gary Gregory,
Release Manager (using key 86fdc7e2a11262cb)

For following is intended as a helper and refresher for reviewers.

Validating a release candidate
==

These guidelines are NOT complete.

Requirements: Git, Java, Maven.

You can validate a release from a release candidate (RC) tag as follows.

1a) Clone and chec

Re: Proposal to make DomainValidator#isValidDomainSyntax public in commons-validator

[sebb]

On Tue, 2 Apr 2024 at 15:40, mogasale.tech  wrote:
>
> Thanks for the response.
>
> I have thoughts about this change not only within DomainValidator, but also
> to make it configurable at the two classes (EmailValidator and
> UrlValidator) where DomainValidator#isValid is consumed today.
>
> I'll give it a try in a few days.

In the same way that Local Addresses are allowed (or not), it might
make sense to allow the DomainValidator to be constructed with a flag
to skip TLD validation.

This might simplify the calling code.

> Regards,
> Ram
>
> On Sun, 31 Mar 2024 at 08:16, Gary Gregory  wrote:
>
> > Ram,
> >
> > Feel free to provide a PR on GitHub.
> >
> > Gary
> >
> > On Sat, Mar 30, 2024, 10:43 PM mogasale.tech 
> > wrote:
> >
> > > Hi Team,
> > >
> > > Here is the proposal to make DomainValidator#isValidDomainSyntax method
> > in
> > > commons-validator library public, currently it is package private. Below
> > > are the reasoning behind the same.
> > >
> > > 1. In many use cases, products just need to validate the syntax of the
> > > given input. Conformation to the IANA maintained generic TLDs is not
> > > required in such cases. So, DomainValidator#isValid cannot be used as it
> > is
> > > strict about Generic TLDs.
> > >
> > > 2. Products end up implementing their own regex based implementations.
> > This
> > > is not only error prone, but also wastage of developer productivity to
> > > write and maintain the boilerplate code for something already handled by
> > > this library.
> > >
> > > Kindly consider the same and do the needful.
> > >
> > > Regards,
> > > Ram
> > >
> >

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: Proposal to make DomainValidator#isValidDomainSyntax public in commons-validator

[Oliver B. Fischer]

+1

Am 31.03.24 um 04:43 schrieb mogasale.tech:

Hi Team,

Here is the proposal to make DomainValidator#isValidDomainSyntax method in
commons-validator library public, currently it is package private. Below
are the reasoning behind the same.

1. In many use cases, products just need to validate the syntax of the
given input. Conformation to the IANA maintained generic TLDs is not
required in such cases. So, DomainValidator#isValid cannot be used as it is
strict about Generic TLDs.

2. Products end up implementing their own regex based implementations. This
is not only error prone, but also wastage of developer productivity to
write and maintain the boilerplate code for something already handled by
this library.

Kindly consider the same and do the needful.

Regards,
Ram


--
N Oliver B. Fischer
A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
P +49 30 44793251
M +49 178 7903538
E o.b.fisc...@swe-blog.net


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: Proposal to make DomainValidator#isValidDomainSyntax public in commons-validator

[mogasale.tech]

Thanks for the response.

I have thoughts about this change not only within DomainValidator, but also
to make it configurable at the two classes (EmailValidator and
UrlValidator) where DomainValidator#isValid is consumed today.

I'll give it a try in a few days.

Regards,
Ram

On Sun, 31 Mar 2024 at 08:16, Gary Gregory  wrote:

> Ram,
>
> Feel free to provide a PR on GitHub.
>
> Gary
>
> On Sat, Mar 30, 2024, 10:43 PM mogasale.tech 
> wrote:
>
> > Hi Team,
> >
> > Here is the proposal to make DomainValidator#isValidDomainSyntax method
> in
> > commons-validator library public, currently it is package private. Below
> > are the reasoning behind the same.
> >
> > 1. In many use cases, products just need to validate the syntax of the
> > given input. Conformation to the IANA maintained generic TLDs is not
> > required in such cases. So, DomainValidator#isValid cannot be used as it
> is
> > strict about Generic TLDs.
> >
> > 2. Products end up implementing their own regex based implementations.
> This
> > is not only error prone, but also wastage of developer productivity to
> > write and maintain the boilerplate code for something already handled by
> > this library.
> >
> > Kindly consider the same and do the needful.
> >
> > Regards,
> > Ram
> >
>

Re: Proposal to make DomainValidator#isValidDomainSyntax public in commons-validator

[Gary Gregory]

Ram,

Feel free to provide a PR on GitHub.

Gary

On Sat, Mar 30, 2024, 10:43 PM mogasale.tech 
wrote:

> Hi Team,
>
> Here is the proposal to make DomainValidator#isValidDomainSyntax method in
> commons-validator library public, currently it is package private. Below
> are the reasoning behind the same.
>
> 1. In many use cases, products just need to validate the syntax of the
> given input. Conformation to the IANA maintained generic TLDs is not
> required in such cases. So, DomainValidator#isValid cannot be used as it is
> strict about Generic TLDs.
>
> 2. Products end up implementing their own regex based implementations. This
> is not only error prone, but also wastage of developer productivity to
> write and maintain the boilerplate code for something already handled by
> this library.
>
> Kindly consider the same and do the needful.
>
> Regards,
> Ram
>

Proposal to make DomainValidator#isValidDomainSyntax public in commons-validator

[mogasale.tech]

Hi Team,

Here is the proposal to make DomainValidator#isValidDomainSyntax method in
commons-validator library public, currently it is package private. Below
are the reasoning behind the same.

1. In many use cases, products just need to validate the syntax of the
given input. Conformation to the IANA maintained generic TLDs is not
required in such cases. So, DomainValidator#isValid cannot be used as it is
strict about Generic TLDs.

2. Products end up implementing their own regex based implementations. This
is not only error prone, but also wastage of developer productivity to
write and maintain the boilerplate code for something already handled by
this library.

Kindly consider the same and do the needful.

Regards,
Ram

Re: [VOTE] Release Apache Commons Validator 1.8.0 based on RC1

[Gary Gregory]

This vote passes with the following binding +1 votes:

- Gary Gregory
- Henri Biestro
- Rob Tompkins

Gary

On Wed, Dec 6, 2023 at 11:39 PM Rob Tompkins  wrote:
>
> +1 all looks good
>
> > On Dec 2, 2023, at 10:26 AM, Gary Gregory  wrote:
> >
> > We have fixed a few bugs and added some enhancements since Apache
> > Commons Validator 1.7 was released, so I would like to release Apache
> > Commons Validator 1.8.0.
> >
> > Apache Commons Validator 1.8.0 RC1 is available for review here:
> >    https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1
> > (svn revision 65799)
> >
> > The Git tag commons-validator-1.8.0-RC1 commit for this RC is
> > c4b1afc87797f7826b84ae7f024f3d8959781ddd which you can browse here:
> >
> > https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=c4b1afc87797f7826b84ae7f024f3d8959781ddd
> > You may checkout this tag using:
> >git clone https://gitbox.apache.org/repos/asf/commons-validator.git
> > --branch commons-validator-1.8.0-RC1 commons-validator-1.8.0-RC1
> >
> > Maven artifacts are here:
> >
> > https://repository.apache.org/content/repositories/orgapachecommons-1677/commons-validator/commons-validator/1.8.0/
> >
> > These are the artifacts and their hashes:
> >
> > #Release SHA-512s
> > #Sat Dec 02 10:19:35 EST 2023
> > commons-validator-1.8.0-bin.tar.gz=32128ff8ec1d992a1654e1cab0451152e844dd3076c25c80122b331dd4d3546a60b0325476ae079b83a4b8d852dc8dd48fbde64f04d19e22013e99b95b98978e
> > commons-validator-1.8.0-bin.zip=436aa1b614144b35c644dc7f1725a72b16ba276ef2d66ceafb9964e2a2484cd3438f1d76bf82c8fdd9d6c4da47a34c8bad6897bad77528a7e1531f6c8eedf67a
> > commons-validator-1.8.0-bom.json=111c721363c61cd2a85a8f6b881b2d0fbaa0b2ac12401458e65e4e39ebc4a68ec339bf21d11d424ef0034ab0ad1239458011444a99843152b5a0c35f8922975a
> > commons-validator-1.8.0-bom.xml=1ecb419c19dce8d596cbe43e6c1690d8ce121fd1a9907b6e3a85a497517fedc0fa0ffc26acb3f7124672590a48b401e5a149c6d6fae3ee5067de8aabd7233ca7
> > commons-validator-1.8.0-javadoc.jar=7a0b2ef23f2feb5f52269c47216f69137c62eec80a64bdd0e7ee7e413fd0d05c5c8b4c054f83a25dae8f0b3e3f4ef46663a05d9e67745196f870d4ce4a6e1b9e
> > commons-validator-1.8.0-sources.jar=fe6a7039615a53638df01b1100d25a6f38451b58cd5be88027e3bc0f86b40dfa440a8a466b7097054a1133c71089958e5f8a5bf6fad67e6c7bacc9210d04e97a
> > commons-validator-1.8.0-src.tar.gz=f0c2662e5db0bbc6ee9d05d5508caa02bf45b7c7ada92f4a97a867848f3d704b35552d47859a46567705194248e7b88cd8df8f082939012ab60b6aed446e36b2
> > commons-validator-1.8.0-src.zip=530063f04d300c0322ef5c53960bd6dd2ea9879169efe64d28234ac9877b5638876e8ed020a16eb67198d528405d9656f6e94f08ffb7cdfaa0d9e916c77aa32f
> > commons-validator-1.8.0-test-sources.jar=f111abe654dbc2241d81dbf5b7742c33a1dd304ba1f2ffe902546b1e8b97a7d8940cffd1692e7787124fd08f54a235f92a19ade41fd88a136e5135ea10db4222
> > commons-validator-1.8.0-tests.jar=bc5440747c3192574b75378fceb535ab7f988403d24fb1fb9ca74de30a5d7790fb9ed953bda3c727b5552778cdcf03e7e85500fadb3350a888c8adaf86da957d
> > commons-validator_commons-validator-1.8.0.spdx.json=36d397ce0e251258ec7a6a90f54a1d76585762e9ee680160b79979f73f4c31e506e8b6bc6e07186db83bc0e34a9996ccbefc069569f69753ef4fea2cdd40bb8b
> >
> > I have tested this with
> >
> > mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site 
> > deploy
> >
> > Using:
> >
> > Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> > Maven home: /usr/local/Cellar/maven/3.9.6/libexec
> > Java version: 21.0.1, vendor: Homebrew, runtime:
> > /usr/local/Cellar/openjdk/21.0.1/libexec/openjdk.jdk/Contents/Home
> > Default locale: en_US, platform encoding: UTF-8
> > OS name: "mac os x", version: "14.1.1", arch: "x86_64", family: "mac"
> >
> > Darwin  23.1.0 Darwin Kernel Version 23.1.0: Mon Oct  9 21:27:27
> > PDT 2023; root:xnu-10002.41.9~6/RELEASE_X86_64 x86_64
> >
> > Details of changes since 1.7 are in the release notes:
> >
> > https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/RELEASE-NOTES.txt
> >
> > https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/site/changes-report.html
> >
> > Site:
> >
> > https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/site/index.html
> >(note some *relative* links are broken and the 1.8.0 directories
> > are not yet created - these will be OK once the site is deployed.)
> >
> > JApiCmp Report (compared to 1.7):
> >
> > https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/site/japicmp.html
> >
> > RAT Report:
> >

Re: [VOTE] Release Apache Commons Validator 1.8.0 based on RC1

[Gary Gregory]

On Wed, Dec 6, 2023 at 11:39 PM Rob Tompkins  wrote:
>
> +1 all looks good
>
> > On Dec 2, 2023, at 10:26 AM, Gary Gregory  wrote:
> >
> > We have fixed a few bugs and added some enhancements since Apache
> > Commons Validator 1.7 was released, so I would like to release Apache
> > Commons Validator 1.8.0.
> >
> > Apache Commons Validator 1.8.0 RC1 is available for review here:
> >    https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1
> > (svn revision 65799)
> >
> > The Git tag commons-validator-1.8.0-RC1 commit for this RC is
> > c4b1afc87797f7826b84ae7f024f3d8959781ddd which you can browse here:
> >
> > https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=c4b1afc87797f7826b84ae7f024f3d8959781ddd
> > You may checkout this tag using:
> >git clone https://gitbox.apache.org/repos/asf/commons-validator.git
> > --branch commons-validator-1.8.0-RC1 commons-validator-1.8.0-RC1
> >
> > Maven artifacts are here:
> >
> > https://repository.apache.org/content/repositories/orgapachecommons-1677/commons-validator/commons-validator/1.8.0/
> >
> > These are the artifacts and their hashes:
> >
> > #Release SHA-512s
> > #Sat Dec 02 10:19:35 EST 2023
> > commons-validator-1.8.0-bin.tar.gz=32128ff8ec1d992a1654e1cab0451152e844dd3076c25c80122b331dd4d3546a60b0325476ae079b83a4b8d852dc8dd48fbde64f04d19e22013e99b95b98978e
> > commons-validator-1.8.0-bin.zip=436aa1b614144b35c644dc7f1725a72b16ba276ef2d66ceafb9964e2a2484cd3438f1d76bf82c8fdd9d6c4da47a34c8bad6897bad77528a7e1531f6c8eedf67a
> > commons-validator-1.8.0-bom.json=111c721363c61cd2a85a8f6b881b2d0fbaa0b2ac12401458e65e4e39ebc4a68ec339bf21d11d424ef0034ab0ad1239458011444a99843152b5a0c35f8922975a
> > commons-validator-1.8.0-bom.xml=1ecb419c19dce8d596cbe43e6c1690d8ce121fd1a9907b6e3a85a497517fedc0fa0ffc26acb3f7124672590a48b401e5a149c6d6fae3ee5067de8aabd7233ca7
> > commons-validator-1.8.0-javadoc.jar=7a0b2ef23f2feb5f52269c47216f69137c62eec80a64bdd0e7ee7e413fd0d05c5c8b4c054f83a25dae8f0b3e3f4ef46663a05d9e67745196f870d4ce4a6e1b9e
> > commons-validator-1.8.0-sources.jar=fe6a7039615a53638df01b1100d25a6f38451b58cd5be88027e3bc0f86b40dfa440a8a466b7097054a1133c71089958e5f8a5bf6fad67e6c7bacc9210d04e97a
> > commons-validator-1.8.0-src.tar.gz=f0c2662e5db0bbc6ee9d05d5508caa02bf45b7c7ada92f4a97a867848f3d704b35552d47859a46567705194248e7b88cd8df8f082939012ab60b6aed446e36b2
> > commons-validator-1.8.0-src.zip=530063f04d300c0322ef5c53960bd6dd2ea9879169efe64d28234ac9877b5638876e8ed020a16eb67198d528405d9656f6e94f08ffb7cdfaa0d9e916c77aa32f
> > commons-validator-1.8.0-test-sources.jar=f111abe654dbc2241d81dbf5b7742c33a1dd304ba1f2ffe902546b1e8b97a7d8940cffd1692e7787124fd08f54a235f92a19ade41fd88a136e5135ea10db4222
> > commons-validator-1.8.0-tests.jar=bc5440747c3192574b75378fceb535ab7f988403d24fb1fb9ca74de30a5d7790fb9ed953bda3c727b5552778cdcf03e7e85500fadb3350a888c8adaf86da957d
> > commons-validator_commons-validator-1.8.0.spdx.json=36d397ce0e251258ec7a6a90f54a1d76585762e9ee680160b79979f73f4c31e506e8b6bc6e07186db83bc0e34a9996ccbefc069569f69753ef4fea2cdd40bb8b
> >
> > I have tested this with
> >
> > mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site 
> > deploy
> >
> > Using:
> >
> > Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> > Maven home: /usr/local/Cellar/maven/3.9.6/libexec
> > Java version: 21.0.1, vendor: Homebrew, runtime:
> > /usr/local/Cellar/openjdk/21.0.1/libexec/openjdk.jdk/Contents/Home
> > Default locale: en_US, platform encoding: UTF-8
> > OS name: "mac os x", version: "14.1.1", arch: "x86_64", family: "mac"
> >
> > Darwin  23.1.0 Darwin Kernel Version 23.1.0: Mon Oct  9 21:27:27
> > PDT 2023; root:xnu-10002.41.9~6/RELEASE_X86_64 x86_64
> >
> > Details of changes since 1.7 are in the release notes:
> >
> > https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/RELEASE-NOTES.txt
> >
> > https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/site/changes-report.html
> >
> > Site:
> >
> > https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/site/index.html
> >(note some *relative* links are broken and the 1.8.0 directories
> > are not yet created - these will be OK once the site is deployed.)
> >
> > JApiCmp Report (compared to 1.7):
> >
> > https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/site/japicmp.html
> >
> > RAT Report:
> >
> > https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/site/rat-report.html
> >
> > KEY

Re: [VOTE] Release Apache Commons Validator 1.8.0 based on RC1

[Rob Tompkins]

+1 all looks good

> On Dec 2, 2023, at 10:26 AM, Gary Gregory  wrote:
> 
> We have fixed a few bugs and added some enhancements since Apache
> Commons Validator 1.7 was released, so I would like to release Apache
> Commons Validator 1.8.0.
> 
> Apache Commons Validator 1.8.0 RC1 is available for review here:
>https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1
> (svn revision 65799)
> 
> The Git tag commons-validator-1.8.0-RC1 commit for this RC is
> c4b1afc87797f7826b84ae7f024f3d8959781ddd which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=c4b1afc87797f7826b84ae7f024f3d8959781ddd
> You may checkout this tag using:
>git clone https://gitbox.apache.org/repos/asf/commons-validator.git
> --branch commons-validator-1.8.0-RC1 commons-validator-1.8.0-RC1
> 
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1677/commons-validator/commons-validator/1.8.0/
> 
> These are the artifacts and their hashes:
> 
> #Release SHA-512s
> #Sat Dec 02 10:19:35 EST 2023
> commons-validator-1.8.0-bin.tar.gz=32128ff8ec1d992a1654e1cab0451152e844dd3076c25c80122b331dd4d3546a60b0325476ae079b83a4b8d852dc8dd48fbde64f04d19e22013e99b95b98978e
> commons-validator-1.8.0-bin.zip=436aa1b614144b35c644dc7f1725a72b16ba276ef2d66ceafb9964e2a2484cd3438f1d76bf82c8fdd9d6c4da47a34c8bad6897bad77528a7e1531f6c8eedf67a
> commons-validator-1.8.0-bom.json=111c721363c61cd2a85a8f6b881b2d0fbaa0b2ac12401458e65e4e39ebc4a68ec339bf21d11d424ef0034ab0ad1239458011444a99843152b5a0c35f8922975a
> commons-validator-1.8.0-bom.xml=1ecb419c19dce8d596cbe43e6c1690d8ce121fd1a9907b6e3a85a497517fedc0fa0ffc26acb3f7124672590a48b401e5a149c6d6fae3ee5067de8aabd7233ca7
> commons-validator-1.8.0-javadoc.jar=7a0b2ef23f2feb5f52269c47216f69137c62eec80a64bdd0e7ee7e413fd0d05c5c8b4c054f83a25dae8f0b3e3f4ef46663a05d9e67745196f870d4ce4a6e1b9e
> commons-validator-1.8.0-sources.jar=fe6a7039615a53638df01b1100d25a6f38451b58cd5be88027e3bc0f86b40dfa440a8a466b7097054a1133c71089958e5f8a5bf6fad67e6c7bacc9210d04e97a
> commons-validator-1.8.0-src.tar.gz=f0c2662e5db0bbc6ee9d05d5508caa02bf45b7c7ada92f4a97a867848f3d704b35552d47859a46567705194248e7b88cd8df8f082939012ab60b6aed446e36b2
> commons-validator-1.8.0-src.zip=530063f04d300c0322ef5c53960bd6dd2ea9879169efe64d28234ac9877b5638876e8ed020a16eb67198d528405d9656f6e94f08ffb7cdfaa0d9e916c77aa32f
> commons-validator-1.8.0-test-sources.jar=f111abe654dbc2241d81dbf5b7742c33a1dd304ba1f2ffe902546b1e8b97a7d8940cffd1692e7787124fd08f54a235f92a19ade41fd88a136e5135ea10db4222
> commons-validator-1.8.0-tests.jar=bc5440747c3192574b75378fceb535ab7f988403d24fb1fb9ca74de30a5d7790fb9ed953bda3c727b5552778cdcf03e7e85500fadb3350a888c8adaf86da957d
> commons-validator_commons-validator-1.8.0.spdx.json=36d397ce0e251258ec7a6a90f54a1d76585762e9ee680160b79979f73f4c31e506e8b6bc6e07186db83bc0e34a9996ccbefc069569f69753ef4fea2cdd40bb8b
> 
> I have tested this with
> 
> mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site deploy
> 
> Using:
> 
> Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> Maven home: /usr/local/Cellar/maven/3.9.6/libexec
> Java version: 21.0.1, vendor: Homebrew, runtime:
> /usr/local/Cellar/openjdk/21.0.1/libexec/openjdk.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "14.1.1", arch: "x86_64", family: "mac"
> 
> Darwin  23.1.0 Darwin Kernel Version 23.1.0: Mon Oct  9 21:27:27
> PDT 2023; root:xnu-10002.41.9~6/RELEASE_X86_64 x86_64
> 
> Details of changes since 1.7 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/site/changes-report.html
> 
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/site/index.html
>(note some *relative* links are broken and the 1.8.0 directories
> are not yet created - these will be OK once the site is deployed.)
> 
> JApiCmp Report (compared to 1.7):
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/site/japicmp.html
> 
> RAT Report:
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/site/rat-report.html
> 
> KEYS:
>  https://downloads.apache.org/commons/KEYS
> 
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
> 
>  [ ] +1 Release these artifacts
>  [ ] +0 OK, but...
>  [ ] -0 OK, but really should fix...
>  [ ] -1 I oppose this release because...
> 
> Thank you,
> 
> Gary Gregory,
> Release Manager (using key 86fdc7e2a11262cb)
> 
> For f

Re: [VOTE] Release Apache Commons Validator 1.8.0 based on RC1

[Henri Biestro]

[ +1 ]

Built using:  mvn -s "$HOME/.m2/commons-settings.xml" -P jacoco -P japicmp 
clean package site
On: Darwin henrib-MBP16 23.1.0 Darwin Kernel Version 23.1.0: Mon Oct  9 
21:27:24 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T6000 arm64
With: OpenJDK Runtime Environment (Zulu 8.66.0.15-CA-macos-aarch64) (build 
1.8.0_352-b08)

Build, tests and site are ok.

Nothing to stop releasing but coverage is not great for some (one liner) 
methods; Javadoc could link to replacement instead of just stating their name; 
release-notes are crude.

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Apache Commons Validator 1.8.0 based on RC1

[Gary Gregory]

My +1

Gary


On Sat, Dec 2, 2023, 10:26 AM Gary Gregory  wrote:

> We have fixed a few bugs and added some enhancements since Apache
> Commons Validator 1.7 was released, so I would like to release Apache
> Commons Validator 1.8.0.
>
> Apache Commons Validator 1.8.0 RC1 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1
> (svn revision 65799)
>
> The Git tag commons-validator-1.8.0-RC1 commit for this RC is
> c4b1afc87797f7826b84ae7f024f3d8959781ddd which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=c4b1afc87797f7826b84ae7f024f3d8959781ddd
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-validator.git
> --branch
> <https://gitbox.apache.org/repos/asf/commons-validator.git--branch>
> commons-validator-1.8.0-RC1 commons-validator-1.8.0-RC1
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1677/commons-validator/commons-validator/1.8.0/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Sat Dec 02 10:19:35 EST 2023
>
> commons-validator-1.8.0-bin.tar.gz=32128ff8ec1d992a1654e1cab0451152e844dd3076c25c80122b331dd4d3546a60b0325476ae079b83a4b8d852dc8dd48fbde64f04d19e22013e99b95b98978e
>
> commons-validator-1.8.0-bin.zip=436aa1b614144b35c644dc7f1725a72b16ba276ef2d66ceafb9964e2a2484cd3438f1d76bf82c8fdd9d6c4da47a34c8bad6897bad77528a7e1531f6c8eedf67a
>
> commons-validator-1.8.0-bom.json=111c721363c61cd2a85a8f6b881b2d0fbaa0b2ac12401458e65e4e39ebc4a68ec339bf21d11d424ef0034ab0ad1239458011444a99843152b5a0c35f8922975a
>
> commons-validator-1.8.0-bom.xml=1ecb419c19dce8d596cbe43e6c1690d8ce121fd1a9907b6e3a85a497517fedc0fa0ffc26acb3f7124672590a48b401e5a149c6d6fae3ee5067de8aabd7233ca7
>
> commons-validator-1.8.0-javadoc.jar=7a0b2ef23f2feb5f52269c47216f69137c62eec80a64bdd0e7ee7e413fd0d05c5c8b4c054f83a25dae8f0b3e3f4ef46663a05d9e67745196f870d4ce4a6e1b9e
>
> commons-validator-1.8.0-sources.jar=fe6a7039615a53638df01b1100d25a6f38451b58cd5be88027e3bc0f86b40dfa440a8a466b7097054a1133c71089958e5f8a5bf6fad67e6c7bacc9210d04e97a
>
> commons-validator-1.8.0-src.tar.gz=f0c2662e5db0bbc6ee9d05d5508caa02bf45b7c7ada92f4a97a867848f3d704b35552d47859a46567705194248e7b88cd8df8f082939012ab60b6aed446e36b2
>
> commons-validator-1.8.0-src.zip=530063f04d300c0322ef5c53960bd6dd2ea9879169efe64d28234ac9877b5638876e8ed020a16eb67198d528405d9656f6e94f08ffb7cdfaa0d9e916c77aa32f
>
> commons-validator-1.8.0-test-sources.jar=f111abe654dbc2241d81dbf5b7742c33a1dd304ba1f2ffe902546b1e8b97a7d8940cffd1692e7787124fd08f54a235f92a19ade41fd88a136e5135ea10db4222
>
> commons-validator-1.8.0-tests.jar=bc5440747c3192574b75378fceb535ab7f988403d24fb1fb9ca74de30a5d7790fb9ed953bda3c727b5552778cdcf03e7e85500fadb3350a888c8adaf86da957d
>
> commons-validator_commons-validator-1.8.0.spdx.json=36d397ce0e251258ec7a6a90f54a1d76585762e9ee680160b79979f73f4c31e506e8b6bc6e07186db83bc0e34a9996ccbefc069569f69753ef4fea2cdd40bb8b
>
> I have tested this with
>
> mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site
> deploy
>
> Using:
>
> Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> Maven home: /usr/local/Cellar/maven/3.9.6/libexec
> Java version: 21.0.1, vendor: Homebrew, runtime:
> /usr/local/Cellar/openjdk/21.0.1/libexec/openjdk.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "14.1.1", arch: "x86_64", family: "mac"
>
> Darwin  23.1.0 Darwin Kernel Version 23.1.0: Mon Oct  9 21:27:27
> PDT 2023; root:xnu-10002.41.9~6/RELEASE_X86_64 x86_64
>
> Details of changes since 1.7 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/site/changes-report.html
>
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/site/index.html
> (note some *relative* links are broken and the 1.8.0 directories
> are not yet created - these will be OK once the site is deployed.)
>
> JApiCmp Report (compared to 1.7):
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/site/japicmp.html
>
> RAT Report:
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/site/rat-report.html
>
> KEYS:
>   https://downloads.apache.org/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thank you

Re: [VOTE] Release Apache Commons Validator 1.8.0 based on RC1

[Elliotte Rusty Harold]

The claimed security issue on apache commons appears to be broken.
Possibly they're referring to this:
https://news.apache.org/foundation/entry/apache_commons_statement_to_widespread
which did not have a CVE

On Sun, Dec 3, 2023 at 4:11 PM Piotr P. Karwasz  wrote:
>
> Hi Elliotte,
>
> On Sun, 3 Dec 2023 at 14:13, Elliotte Rusty Harold  wrote:
> >
> > https://issues.apache.org/jira/projects/VALIDATOR/issues/VALIDATOR-390
> > and https://issues.apache.org/jira/projects/VALIDATOR/issues/VALIDATOR-357
> > are both open dependency upgrades with security implications. If
> > they've already been fixed, then please close the issues.
> >
> > If they haven't been fixed, I vote -1 until they are. Looking at head,
> > I think VALIDATOR-357 has been fixed and should be closed, but
> > VALIDATOR-390 is still open.
>
> Looking at the SBOM, the only dependencies (including transitive ones) are:
>
> * commons-beanutils 1.9.4,
> * commons-digester 2.1,
> * commons-logging 1.3.0,
> * commons-collections 3.3.2.
>
> None of them have CVEs.
>
> Piotr
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>


-- 
Elliotte Rusty Harold
elh...@ibiblio.org

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Apache Commons Validator 1.8.0 based on RC1

[Piotr P. Karwasz]

Hi Elliotte,

On Sun, 3 Dec 2023 at 14:13, Elliotte Rusty Harold  wrote:
>
> https://issues.apache.org/jira/projects/VALIDATOR/issues/VALIDATOR-390
> and https://issues.apache.org/jira/projects/VALIDATOR/issues/VALIDATOR-357
> are both open dependency upgrades with security implications. If
> they've already been fixed, then please close the issues.
>
> If they haven't been fixed, I vote -1 until they are. Looking at head,
> I think VALIDATOR-357 has been fixed and should be closed, but
> VALIDATOR-390 is still open.

Looking at the SBOM, the only dependencies (including transitive ones) are:

* commons-beanutils 1.9.4,
* commons-digester 2.1,
* commons-logging 1.3.0,
* commons-collections 3.3.2.

None of them have CVEs.

Piotr

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Apache Commons Validator 1.8.0 based on RC1

[Gary Gregory]

We just have no idea how public and protected API are used. Binary
compatibility is easy to understand and check. I think we should keep it
that way.

Gary

On Sun, Dec 3, 2023, 9:23 AM Elliotte Rusty Harold 
wrote:

> That is annoying. Unless there are much more major breaking changes
> than FastHashMap planned for 2.0 in the near future, my inclination
> would be to kill it and jump straight to 2.0. But if you want to
> release 1.8 now, +0.
>
> On Sun, Dec 3, 2023 at 1:39 PM Gary Gregory 
> wrote:
> >
> > Hello Elliotte,
> >
> > As Sebb's comments in VALIDATOR-390 point out, this issue can't be
> > fixed in the 1.x line, so your -1 would mean that there can't ever be
> > a 1.x release again. Or am I missing something?
> >
> > I am happy to switch master a 2.x line after 1.8.0 is out and break
> > binary compatibility at that point.
> >
> > Gary
> >
> > On Sun, Dec 3, 2023 at 8:13 AM Elliotte Rusty Harold 
> wrote:
> > >
> > > https://issues.apache.org/jira/projects/VALIDATOR/issues/VALIDATOR-390
> > > and
> https://issues.apache.org/jira/projects/VALIDATOR/issues/VALIDATOR-357
> > > are both open dependency upgrades with security implications. If
> > > they've already been fixed, then please close the issues.
> > >
> > > If they haven't been fixed, I vote -1 until they are. Looking at head,
> > > I think VALIDATOR-357 has been fixed and should be closed, but
> > > VALIDATOR-390 is still open.
> > >
> > > On Sat, Dec 2, 2023 at 3:26 PM Gary Gregory 
> wrote:
> > > >
> > > > We have fixed a few bugs and added some enhancements since Apache
> > > > Commons Validator 1.7 was released, so I would like to release Apache
> > > > Commons Validator 1.8.0.
> > > >
> > > > Apache Commons Validator 1.8.0 RC1 is available for review here:
> > > >
> https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1
> > > > (svn revision 65799)
> > > >
> > > > The Git tag commons-validator-1.8.0-RC1 commit for this RC is
> > > > c4b1afc87797f7826b84ae7f024f3d8959781ddd which you can browse here:
> > > >
> https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=c4b1afc87797f7826b84ae7f024f3d8959781ddd
> > > > You may checkout this tag using:
> > > > git clone
> https://gitbox.apache.org/repos/asf/commons-validator.git
> > > > --branch commons-validator-1.8.0-RC1 commons-validator-1.8.0-RC1
> > > >
> > > > Maven artifacts are here:
> > > >
> https://repository.apache.org/content/repositories/orgapachecommons-1677/commons-validator/commons-validator/1.8.0/
> > > >
> > > > These are the artifacts and their hashes:
> > > >
> > > > #Release SHA-512s
> > > > #Sat Dec 02 10:19:35 EST 2023
> > > >
> commons-validator-1.8.0-bin.tar.gz=32128ff8ec1d992a1654e1cab0451152e844dd3076c25c80122b331dd4d3546a60b0325476ae079b83a4b8d852dc8dd48fbde64f04d19e22013e99b95b98978e
> > > >
> commons-validator-1.8.0-bin.zip=436aa1b614144b35c644dc7f1725a72b16ba276ef2d66ceafb9964e2a2484cd3438f1d76bf82c8fdd9d6c4da47a34c8bad6897bad77528a7e1531f6c8eedf67a
> > > >
> commons-validator-1.8.0-bom.json=111c721363c61cd2a85a8f6b881b2d0fbaa0b2ac12401458e65e4e39ebc4a68ec339bf21d11d424ef0034ab0ad1239458011444a99843152b5a0c35f8922975a
> > > >
> commons-validator-1.8.0-bom.xml=1ecb419c19dce8d596cbe43e6c1690d8ce121fd1a9907b6e3a85a497517fedc0fa0ffc26acb3f7124672590a48b401e5a149c6d6fae3ee5067de8aabd7233ca7
> > > >
> commons-validator-1.8.0-javadoc.jar=7a0b2ef23f2feb5f52269c47216f69137c62eec80a64bdd0e7ee7e413fd0d05c5c8b4c054f83a25dae8f0b3e3f4ef46663a05d9e67745196f870d4ce4a6e1b9e
> > > >
> commons-validator-1.8.0-sources.jar=fe6a7039615a53638df01b1100d25a6f38451b58cd5be88027e3bc0f86b40dfa440a8a466b7097054a1133c71089958e5f8a5bf6fad67e6c7bacc9210d04e97a
> > > >
> commons-validator-1.8.0-src.tar.gz=f0c2662e5db0bbc6ee9d05d5508caa02bf45b7c7ada92f4a97a867848f3d704b35552d47859a46567705194248e7b88cd8df8f082939012ab60b6aed446e36b2
> > > >
> commons-validator-1.8.0-src.zip=530063f04d300c0322ef5c53960bd6dd2ea9879169efe64d28234ac9877b5638876e8ed020a16eb67198d528405d9656f6e94f08ffb7cdfaa0d9e916c77aa32f
> > > >
> commons-validator-1.8.0-test-sources.jar=f111abe654dbc2241d81dbf5b7742c33a1dd304ba1f2ffe902546b1e8b97a7d8940cffd1692e7787124fd08f54a235f92a19ade41fd88a136e5135ea10db4222
> > > >
> commons-validator-1.8.0-tests.jar=bc5440747c3192574b75378fceb535ab7f988403d24fb1fb9ca74de30a5d7790fb9ed953bda3

Re: [VOTE] Release Apache Commons Validator 1.8.0 based on RC1

[Elliotte Rusty Harold]

That is annoying. Unless there are much more major breaking changes
than FastHashMap planned for 2.0 in the near future, my inclination
would be to kill it and jump straight to 2.0. But if you want to
release 1.8 now, +0.

On Sun, Dec 3, 2023 at 1:39 PM Gary Gregory  wrote:
>
> Hello Elliotte,
>
> As Sebb's comments in VALIDATOR-390 point out, this issue can't be
> fixed in the 1.x line, so your -1 would mean that there can't ever be
> a 1.x release again. Or am I missing something?
>
> I am happy to switch master a 2.x line after 1.8.0 is out and break
> binary compatibility at that point.
>
> Gary
>
> On Sun, Dec 3, 2023 at 8:13 AM Elliotte Rusty Harold  
> wrote:
> >
> > https://issues.apache.org/jira/projects/VALIDATOR/issues/VALIDATOR-390
> > and https://issues.apache.org/jira/projects/VALIDATOR/issues/VALIDATOR-357
> > are both open dependency upgrades with security implications. If
> > they've already been fixed, then please close the issues.
> >
> > If they haven't been fixed, I vote -1 until they are. Looking at head,
> > I think VALIDATOR-357 has been fixed and should be closed, but
> > VALIDATOR-390 is still open.
> >
> > On Sat, Dec 2, 2023 at 3:26 PM Gary Gregory  wrote:
> > >
> > > We have fixed a few bugs and added some enhancements since Apache
> > > Commons Validator 1.7 was released, so I would like to release Apache
> > > Commons Validator 1.8.0.
> > >
> > > Apache Commons Validator 1.8.0 RC1 is available for review here:
> > > https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1
> > > (svn revision 65799)
> > >
> > > The Git tag commons-validator-1.8.0-RC1 commit for this RC is
> > > c4b1afc87797f7826b84ae7f024f3d8959781ddd which you can browse here:
> > > 
> > > https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=c4b1afc87797f7826b84ae7f024f3d8959781ddd
> > > You may checkout this tag using:
> > > git clone https://gitbox.apache.org/repos/asf/commons-validator.git
> > > --branch commons-validator-1.8.0-RC1 commons-validator-1.8.0-RC1
> > >
> > > Maven artifacts are here:
> > > 
> > > https://repository.apache.org/content/repositories/orgapachecommons-1677/commons-validator/commons-validator/1.8.0/
> > >
> > > These are the artifacts and their hashes:
> > >
> > > #Release SHA-512s
> > > #Sat Dec 02 10:19:35 EST 2023
> > > commons-validator-1.8.0-bin.tar.gz=32128ff8ec1d992a1654e1cab0451152e844dd3076c25c80122b331dd4d3546a60b0325476ae079b83a4b8d852dc8dd48fbde64f04d19e22013e99b95b98978e
> > > commons-validator-1.8.0-bin.zip=436aa1b614144b35c644dc7f1725a72b16ba276ef2d66ceafb9964e2a2484cd3438f1d76bf82c8fdd9d6c4da47a34c8bad6897bad77528a7e1531f6c8eedf67a
> > > commons-validator-1.8.0-bom.json=111c721363c61cd2a85a8f6b881b2d0fbaa0b2ac12401458e65e4e39ebc4a68ec339bf21d11d424ef0034ab0ad1239458011444a99843152b5a0c35f8922975a
> > > commons-validator-1.8.0-bom.xml=1ecb419c19dce8d596cbe43e6c1690d8ce121fd1a9907b6e3a85a497517fedc0fa0ffc26acb3f7124672590a48b401e5a149c6d6fae3ee5067de8aabd7233ca7
> > > commons-validator-1.8.0-javadoc.jar=7a0b2ef23f2feb5f52269c47216f69137c62eec80a64bdd0e7ee7e413fd0d05c5c8b4c054f83a25dae8f0b3e3f4ef46663a05d9e67745196f870d4ce4a6e1b9e
> > > commons-validator-1.8.0-sources.jar=fe6a7039615a53638df01b1100d25a6f38451b58cd5be88027e3bc0f86b40dfa440a8a466b7097054a1133c71089958e5f8a5bf6fad67e6c7bacc9210d04e97a
> > > commons-validator-1.8.0-src.tar.gz=f0c2662e5db0bbc6ee9d05d5508caa02bf45b7c7ada92f4a97a867848f3d704b35552d47859a46567705194248e7b88cd8df8f082939012ab60b6aed446e36b2
> > > commons-validator-1.8.0-src.zip=530063f04d300c0322ef5c53960bd6dd2ea9879169efe64d28234ac9877b5638876e8ed020a16eb67198d528405d9656f6e94f08ffb7cdfaa0d9e916c77aa32f
> > > commons-validator-1.8.0-test-sources.jar=f111abe654dbc2241d81dbf5b7742c33a1dd304ba1f2ffe902546b1e8b97a7d8940cffd1692e7787124fd08f54a235f92a19ade41fd88a136e5135ea10db4222
> > > commons-validator-1.8.0-tests.jar=bc5440747c3192574b75378fceb535ab7f988403d24fb1fb9ca74de30a5d7790fb9ed953bda3c727b5552778cdcf03e7e85500fadb3350a888c8adaf86da957d
> > > commons-validator_commons-validator-1.8.0.spdx.json=36d397ce0e251258ec7a6a90f54a1d76585762e9ee680160b79979f73f4c31e506e8b6bc6e07186db83bc0e34a9996ccbefc069569f69753ef4fea2cdd40bb8b
> > >
> > > I have tested this with
> > >
> > > mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site 
> > > deploy
> > >
> > > Using:
> > >
> > > Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> > > Maven hom

Re: [VOTE] Release Apache Commons Validator 1.8.0 based on RC1

[Gary Gregory]

Oops, I got the process wrong: A -1 vote on a release candidate is not a veto.

Gary

On Sun, Dec 3, 2023 at 8:39 AM Gary Gregory  wrote:
>
> Hello Elliotte,
>
> As Sebb's comments in VALIDATOR-390 point out, this issue can't be
> fixed in the 1.x line, so your -1 would mean that there can't ever be
> a 1.x release again. Or am I missing something?
>
> I am happy to switch master a 2.x line after 1.8.0 is out and break
> binary compatibility at that point.
>
> Gary
>
> On Sun, Dec 3, 2023 at 8:13 AM Elliotte Rusty Harold  
> wrote:
> >
> > https://issues.apache.org/jira/projects/VALIDATOR/issues/VALIDATOR-390
> > and https://issues.apache.org/jira/projects/VALIDATOR/issues/VALIDATOR-357
> > are both open dependency upgrades with security implications. If
> > they've already been fixed, then please close the issues.
> >
> > If they haven't been fixed, I vote -1 until they are. Looking at head,
> > I think VALIDATOR-357 has been fixed and should be closed, but
> > VALIDATOR-390 is still open.
> >
> > On Sat, Dec 2, 2023 at 3:26 PM Gary Gregory  wrote:
> > >
> > > We have fixed a few bugs and added some enhancements since Apache
> > > Commons Validator 1.7 was released, so I would like to release Apache
> > > Commons Validator 1.8.0.
> > >
> > > Apache Commons Validator 1.8.0 RC1 is available for review here:
> > > https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1
> > > (svn revision 65799)
> > >
> > > The Git tag commons-validator-1.8.0-RC1 commit for this RC is
> > > c4b1afc87797f7826b84ae7f024f3d8959781ddd which you can browse here:
> > > 
> > > https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=c4b1afc87797f7826b84ae7f024f3d8959781ddd
> > > You may checkout this tag using:
> > > git clone https://gitbox.apache.org/repos/asf/commons-validator.git
> > > --branch commons-validator-1.8.0-RC1 commons-validator-1.8.0-RC1
> > >
> > > Maven artifacts are here:
> > > 
> > > https://repository.apache.org/content/repositories/orgapachecommons-1677/commons-validator/commons-validator/1.8.0/
> > >
> > > These are the artifacts and their hashes:
> > >
> > > #Release SHA-512s
> > > #Sat Dec 02 10:19:35 EST 2023
> > > commons-validator-1.8.0-bin.tar.gz=32128ff8ec1d992a1654e1cab0451152e844dd3076c25c80122b331dd4d3546a60b0325476ae079b83a4b8d852dc8dd48fbde64f04d19e22013e99b95b98978e
> > > commons-validator-1.8.0-bin.zip=436aa1b614144b35c644dc7f1725a72b16ba276ef2d66ceafb9964e2a2484cd3438f1d76bf82c8fdd9d6c4da47a34c8bad6897bad77528a7e1531f6c8eedf67a
> > > commons-validator-1.8.0-bom.json=111c721363c61cd2a85a8f6b881b2d0fbaa0b2ac12401458e65e4e39ebc4a68ec339bf21d11d424ef0034ab0ad1239458011444a99843152b5a0c35f8922975a
> > > commons-validator-1.8.0-bom.xml=1ecb419c19dce8d596cbe43e6c1690d8ce121fd1a9907b6e3a85a497517fedc0fa0ffc26acb3f7124672590a48b401e5a149c6d6fae3ee5067de8aabd7233ca7
> > > commons-validator-1.8.0-javadoc.jar=7a0b2ef23f2feb5f52269c47216f69137c62eec80a64bdd0e7ee7e413fd0d05c5c8b4c054f83a25dae8f0b3e3f4ef46663a05d9e67745196f870d4ce4a6e1b9e
> > > commons-validator-1.8.0-sources.jar=fe6a7039615a53638df01b1100d25a6f38451b58cd5be88027e3bc0f86b40dfa440a8a466b7097054a1133c71089958e5f8a5bf6fad67e6c7bacc9210d04e97a
> > > commons-validator-1.8.0-src.tar.gz=f0c2662e5db0bbc6ee9d05d5508caa02bf45b7c7ada92f4a97a867848f3d704b35552d47859a46567705194248e7b88cd8df8f082939012ab60b6aed446e36b2
> > > commons-validator-1.8.0-src.zip=530063f04d300c0322ef5c53960bd6dd2ea9879169efe64d28234ac9877b5638876e8ed020a16eb67198d528405d9656f6e94f08ffb7cdfaa0d9e916c77aa32f
> > > commons-validator-1.8.0-test-sources.jar=f111abe654dbc2241d81dbf5b7742c33a1dd304ba1f2ffe902546b1e8b97a7d8940cffd1692e7787124fd08f54a235f92a19ade41fd88a136e5135ea10db4222
> > > commons-validator-1.8.0-tests.jar=bc5440747c3192574b75378fceb535ab7f988403d24fb1fb9ca74de30a5d7790fb9ed953bda3c727b5552778cdcf03e7e85500fadb3350a888c8adaf86da957d
> > > commons-validator_commons-validator-1.8.0.spdx.json=36d397ce0e251258ec7a6a90f54a1d76585762e9ee680160b79979f73f4c31e506e8b6bc6e07186db83bc0e34a9996ccbefc069569f69753ef4fea2cdd40bb8b
> > >
> > > I have tested this with
> > >
> > > mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site 
> > > deploy
> > >
> > > Using:
> > >
> > > Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> > > Maven home: /usr/local/Cellar/maven/3.9.6/libexec
> > > Java version: 21.0.1, vendor: Homebrew, runtime:
> > > /usr/local/Cell

Re: [VOTE] Release Apache Commons Validator 1.8.0 based on RC1

[Gary Gregory]

Hello Elliotte,

As Sebb's comments in VALIDATOR-390 point out, this issue can't be
fixed in the 1.x line, so your -1 would mean that there can't ever be
a 1.x release again. Or am I missing something?

I am happy to switch master a 2.x line after 1.8.0 is out and break
binary compatibility at that point.

Gary

On Sun, Dec 3, 2023 at 8:13 AM Elliotte Rusty Harold  wrote:
>
> https://issues.apache.org/jira/projects/VALIDATOR/issues/VALIDATOR-390
> and https://issues.apache.org/jira/projects/VALIDATOR/issues/VALIDATOR-357
> are both open dependency upgrades with security implications. If
> they've already been fixed, then please close the issues.
>
> If they haven't been fixed, I vote -1 until they are. Looking at head,
> I think VALIDATOR-357 has been fixed and should be closed, but
> VALIDATOR-390 is still open.
>
> On Sat, Dec 2, 2023 at 3:26 PM Gary Gregory  wrote:
> >
> > We have fixed a few bugs and added some enhancements since Apache
> > Commons Validator 1.7 was released, so I would like to release Apache
> > Commons Validator 1.8.0.
> >
> > Apache Commons Validator 1.8.0 RC1 is available for review here:
> > https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1
> > (svn revision 65799)
> >
> > The Git tag commons-validator-1.8.0-RC1 commit for this RC is
> > c4b1afc87797f7826b84ae7f024f3d8959781ddd which you can browse here:
> > 
> > https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=c4b1afc87797f7826b84ae7f024f3d8959781ddd
> > You may checkout this tag using:
> > git clone https://gitbox.apache.org/repos/asf/commons-validator.git
> > --branch commons-validator-1.8.0-RC1 commons-validator-1.8.0-RC1
> >
> > Maven artifacts are here:
> > 
> > https://repository.apache.org/content/repositories/orgapachecommons-1677/commons-validator/commons-validator/1.8.0/
> >
> > These are the artifacts and their hashes:
> >
> > #Release SHA-512s
> > #Sat Dec 02 10:19:35 EST 2023
> > commons-validator-1.8.0-bin.tar.gz=32128ff8ec1d992a1654e1cab0451152e844dd3076c25c80122b331dd4d3546a60b0325476ae079b83a4b8d852dc8dd48fbde64f04d19e22013e99b95b98978e
> > commons-validator-1.8.0-bin.zip=436aa1b614144b35c644dc7f1725a72b16ba276ef2d66ceafb9964e2a2484cd3438f1d76bf82c8fdd9d6c4da47a34c8bad6897bad77528a7e1531f6c8eedf67a
> > commons-validator-1.8.0-bom.json=111c721363c61cd2a85a8f6b881b2d0fbaa0b2ac12401458e65e4e39ebc4a68ec339bf21d11d424ef0034ab0ad1239458011444a99843152b5a0c35f8922975a
> > commons-validator-1.8.0-bom.xml=1ecb419c19dce8d596cbe43e6c1690d8ce121fd1a9907b6e3a85a497517fedc0fa0ffc26acb3f7124672590a48b401e5a149c6d6fae3ee5067de8aabd7233ca7
> > commons-validator-1.8.0-javadoc.jar=7a0b2ef23f2feb5f52269c47216f69137c62eec80a64bdd0e7ee7e413fd0d05c5c8b4c054f83a25dae8f0b3e3f4ef46663a05d9e67745196f870d4ce4a6e1b9e
> > commons-validator-1.8.0-sources.jar=fe6a7039615a53638df01b1100d25a6f38451b58cd5be88027e3bc0f86b40dfa440a8a466b7097054a1133c71089958e5f8a5bf6fad67e6c7bacc9210d04e97a
> > commons-validator-1.8.0-src.tar.gz=f0c2662e5db0bbc6ee9d05d5508caa02bf45b7c7ada92f4a97a867848f3d704b35552d47859a46567705194248e7b88cd8df8f082939012ab60b6aed446e36b2
> > commons-validator-1.8.0-src.zip=530063f04d300c0322ef5c53960bd6dd2ea9879169efe64d28234ac9877b5638876e8ed020a16eb67198d528405d9656f6e94f08ffb7cdfaa0d9e916c77aa32f
> > commons-validator-1.8.0-test-sources.jar=f111abe654dbc2241d81dbf5b7742c33a1dd304ba1f2ffe902546b1e8b97a7d8940cffd1692e7787124fd08f54a235f92a19ade41fd88a136e5135ea10db4222
> > commons-validator-1.8.0-tests.jar=bc5440747c3192574b75378fceb535ab7f988403d24fb1fb9ca74de30a5d7790fb9ed953bda3c727b5552778cdcf03e7e85500fadb3350a888c8adaf86da957d
> > commons-validator_commons-validator-1.8.0.spdx.json=36d397ce0e251258ec7a6a90f54a1d76585762e9ee680160b79979f73f4c31e506e8b6bc6e07186db83bc0e34a9996ccbefc069569f69753ef4fea2cdd40bb8b
> >
> > I have tested this with
> >
> > mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site 
> > deploy
> >
> > Using:
> >
> > Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> > Maven home: /usr/local/Cellar/maven/3.9.6/libexec
> > Java version: 21.0.1, vendor: Homebrew, runtime:
> > /usr/local/Cellar/openjdk/21.0.1/libexec/openjdk.jdk/Contents/Home
> > Default locale: en_US, platform encoding: UTF-8
> > OS name: "mac os x", version: "14.1.1", arch: "x86_64", family: "mac"
> >
> > Darwin  23.1.0 Darwin Kernel Version 23.1.0: Mon Oct  9 21:27:27
> > PDT 2023; root:xnu-10002.41.9~6/RELEASE_X86_64 x86_64
> >
> > Details of changes since 1.7 are in the release notes:
> > 
> > https://dist.apache

Re: [VOTE] Release Apache Commons Validator 1.8.0 based on RC1

[Elliotte Rusty Harold]

https://issues.apache.org/jira/projects/VALIDATOR/issues/VALIDATOR-390
and https://issues.apache.org/jira/projects/VALIDATOR/issues/VALIDATOR-357
are both open dependency upgrades with security implications. If
they've already been fixed, then please close the issues.

If they haven't been fixed, I vote -1 until they are. Looking at head,
I think VALIDATOR-357 has been fixed and should be closed, but
VALIDATOR-390 is still open.

On Sat, Dec 2, 2023 at 3:26 PM Gary Gregory  wrote:
>
> We have fixed a few bugs and added some enhancements since Apache
> Commons Validator 1.7 was released, so I would like to release Apache
> Commons Validator 1.8.0.
>
> Apache Commons Validator 1.8.0 RC1 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1
> (svn revision 65799)
>
> The Git tag commons-validator-1.8.0-RC1 commit for this RC is
> c4b1afc87797f7826b84ae7f024f3d8959781ddd which you can browse here:
> 
> https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=c4b1afc87797f7826b84ae7f024f3d8959781ddd
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-validator.git
> --branch commons-validator-1.8.0-RC1 commons-validator-1.8.0-RC1
>
> Maven artifacts are here:
> 
> https://repository.apache.org/content/repositories/orgapachecommons-1677/commons-validator/commons-validator/1.8.0/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Sat Dec 02 10:19:35 EST 2023
> commons-validator-1.8.0-bin.tar.gz=32128ff8ec1d992a1654e1cab0451152e844dd3076c25c80122b331dd4d3546a60b0325476ae079b83a4b8d852dc8dd48fbde64f04d19e22013e99b95b98978e
> commons-validator-1.8.0-bin.zip=436aa1b614144b35c644dc7f1725a72b16ba276ef2d66ceafb9964e2a2484cd3438f1d76bf82c8fdd9d6c4da47a34c8bad6897bad77528a7e1531f6c8eedf67a
> commons-validator-1.8.0-bom.json=111c721363c61cd2a85a8f6b881b2d0fbaa0b2ac12401458e65e4e39ebc4a68ec339bf21d11d424ef0034ab0ad1239458011444a99843152b5a0c35f8922975a
> commons-validator-1.8.0-bom.xml=1ecb419c19dce8d596cbe43e6c1690d8ce121fd1a9907b6e3a85a497517fedc0fa0ffc26acb3f7124672590a48b401e5a149c6d6fae3ee5067de8aabd7233ca7
> commons-validator-1.8.0-javadoc.jar=7a0b2ef23f2feb5f52269c47216f69137c62eec80a64bdd0e7ee7e413fd0d05c5c8b4c054f83a25dae8f0b3e3f4ef46663a05d9e67745196f870d4ce4a6e1b9e
> commons-validator-1.8.0-sources.jar=fe6a7039615a53638df01b1100d25a6f38451b58cd5be88027e3bc0f86b40dfa440a8a466b7097054a1133c71089958e5f8a5bf6fad67e6c7bacc9210d04e97a
> commons-validator-1.8.0-src.tar.gz=f0c2662e5db0bbc6ee9d05d5508caa02bf45b7c7ada92f4a97a867848f3d704b35552d47859a46567705194248e7b88cd8df8f082939012ab60b6aed446e36b2
> commons-validator-1.8.0-src.zip=530063f04d300c0322ef5c53960bd6dd2ea9879169efe64d28234ac9877b5638876e8ed020a16eb67198d528405d9656f6e94f08ffb7cdfaa0d9e916c77aa32f
> commons-validator-1.8.0-test-sources.jar=f111abe654dbc2241d81dbf5b7742c33a1dd304ba1f2ffe902546b1e8b97a7d8940cffd1692e7787124fd08f54a235f92a19ade41fd88a136e5135ea10db4222
> commons-validator-1.8.0-tests.jar=bc5440747c3192574b75378fceb535ab7f988403d24fb1fb9ca74de30a5d7790fb9ed953bda3c727b5552778cdcf03e7e85500fadb3350a888c8adaf86da957d
> commons-validator_commons-validator-1.8.0.spdx.json=36d397ce0e251258ec7a6a90f54a1d76585762e9ee680160b79979f73f4c31e506e8b6bc6e07186db83bc0e34a9996ccbefc069569f69753ef4fea2cdd40bb8b
>
> I have tested this with
>
> mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site deploy
>
> Using:
>
> Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> Maven home: /usr/local/Cellar/maven/3.9.6/libexec
> Java version: 21.0.1, vendor: Homebrew, runtime:
> /usr/local/Cellar/openjdk/21.0.1/libexec/openjdk.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "14.1.1", arch: "x86_64", family: "mac"
>
> Darwin  23.1.0 Darwin Kernel Version 23.1.0: Mon Oct  9 21:27:27
> PDT 2023; root:xnu-10002.41.9~6/RELEASE_X86_64 x86_64
>
> Details of changes since 1.7 are in the release notes:
> 
> https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/RELEASE-NOTES.txt
> 
> https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/site/changes-report.html
>
> Site:
> 
> https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/site/index.html
>     (note some *relative* links are broken and the 1.8.0 directories
> are not yet created - these will be OK once the site is deployed.)
>
> JApiCmp Report (compared to 1.7):
> 
> https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/site/japicmp.html
>
> RAT Report:
> 
> https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/site/rat-report.html
>
> KEYS:
>   https

[VOTE] Release Apache Commons Validator 1.8.0 based on RC1

[Gary Gregory]

We have fixed a few bugs and added some enhancements since Apache
Commons Validator 1.7 was released, so I would like to release Apache
Commons Validator 1.8.0.

Apache Commons Validator 1.8.0 RC1 is available for review here:
https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1
(svn revision 65799)

The Git tag commons-validator-1.8.0-RC1 commit for this RC is
c4b1afc87797f7826b84ae7f024f3d8959781ddd which you can browse here:

https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=c4b1afc87797f7826b84ae7f024f3d8959781ddd
You may checkout this tag using:
git clone https://gitbox.apache.org/repos/asf/commons-validator.git
--branch commons-validator-1.8.0-RC1 commons-validator-1.8.0-RC1

Maven artifacts are here:

https://repository.apache.org/content/repositories/orgapachecommons-1677/commons-validator/commons-validator/1.8.0/

These are the artifacts and their hashes:

#Release SHA-512s
#Sat Dec 02 10:19:35 EST 2023
commons-validator-1.8.0-bin.tar.gz=32128ff8ec1d992a1654e1cab0451152e844dd3076c25c80122b331dd4d3546a60b0325476ae079b83a4b8d852dc8dd48fbde64f04d19e22013e99b95b98978e
commons-validator-1.8.0-bin.zip=436aa1b614144b35c644dc7f1725a72b16ba276ef2d66ceafb9964e2a2484cd3438f1d76bf82c8fdd9d6c4da47a34c8bad6897bad77528a7e1531f6c8eedf67a
commons-validator-1.8.0-bom.json=111c721363c61cd2a85a8f6b881b2d0fbaa0b2ac12401458e65e4e39ebc4a68ec339bf21d11d424ef0034ab0ad1239458011444a99843152b5a0c35f8922975a
commons-validator-1.8.0-bom.xml=1ecb419c19dce8d596cbe43e6c1690d8ce121fd1a9907b6e3a85a497517fedc0fa0ffc26acb3f7124672590a48b401e5a149c6d6fae3ee5067de8aabd7233ca7
commons-validator-1.8.0-javadoc.jar=7a0b2ef23f2feb5f52269c47216f69137c62eec80a64bdd0e7ee7e413fd0d05c5c8b4c054f83a25dae8f0b3e3f4ef46663a05d9e67745196f870d4ce4a6e1b9e
commons-validator-1.8.0-sources.jar=fe6a7039615a53638df01b1100d25a6f38451b58cd5be88027e3bc0f86b40dfa440a8a466b7097054a1133c71089958e5f8a5bf6fad67e6c7bacc9210d04e97a
commons-validator-1.8.0-src.tar.gz=f0c2662e5db0bbc6ee9d05d5508caa02bf45b7c7ada92f4a97a867848f3d704b35552d47859a46567705194248e7b88cd8df8f082939012ab60b6aed446e36b2
commons-validator-1.8.0-src.zip=530063f04d300c0322ef5c53960bd6dd2ea9879169efe64d28234ac9877b5638876e8ed020a16eb67198d528405d9656f6e94f08ffb7cdfaa0d9e916c77aa32f
commons-validator-1.8.0-test-sources.jar=f111abe654dbc2241d81dbf5b7742c33a1dd304ba1f2ffe902546b1e8b97a7d8940cffd1692e7787124fd08f54a235f92a19ade41fd88a136e5135ea10db4222
commons-validator-1.8.0-tests.jar=bc5440747c3192574b75378fceb535ab7f988403d24fb1fb9ca74de30a5d7790fb9ed953bda3c727b5552778cdcf03e7e85500fadb3350a888c8adaf86da957d
commons-validator_commons-validator-1.8.0.spdx.json=36d397ce0e251258ec7a6a90f54a1d76585762e9ee680160b79979f73f4c31e506e8b6bc6e07186db83bc0e34a9996ccbefc069569f69753ef4fea2cdd40bb8b

I have tested this with

mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site deploy

Using:

Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
Maven home: /usr/local/Cellar/maven/3.9.6/libexec
Java version: 21.0.1, vendor: Homebrew, runtime:
/usr/local/Cellar/openjdk/21.0.1/libexec/openjdk.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "14.1.1", arch: "x86_64", family: "mac"

Darwin  23.1.0 Darwin Kernel Version 23.1.0: Mon Oct  9 21:27:27
PDT 2023; root:xnu-10002.41.9~6/RELEASE_X86_64 x86_64

Details of changes since 1.7 are in the release notes:

https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/RELEASE-NOTES.txt

https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/site/changes-report.html

Site:

https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/site/index.html
(note some *relative* links are broken and the 1.8.0 directories
are not yet created - these will be OK once the site is deployed.)

JApiCmp Report (compared to 1.7):

https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/site/japicmp.html

RAT Report:

https://dist.apache.org/repos/dist/dev/commons/validator/1.8.0-RC1/site/rat-report.html

KEYS:
  https://downloads.apache.org/commons/KEYS

Please review the release candidate and vote.
This vote will close no sooner than 72 hours from now.

  [ ] +1 Release these artifacts
  [ ] +0 OK, but...
  [ ] -0 OK, but really should fix...
  [ ] -1 I oppose this release because...

Thank you,

Gary Gregory,
Release Manager (using key 86fdc7e2a11262cb)

For following is intended as a helper and refresher for reviewers.

Validating a release candidate
==

These guidelines are NOT complete.

Requirements: Git, Java, Maven.

You can validate a release from a release candidate (RC) tag as follows.

1a) Clone and checkout the RC tag

git clone https://gitbox.apache.org/repos/asf/commons-validator.git
--branch commons-validator-1.8.0-RC1 commons-validator-1.8.0-RC1
cd commons-validator-1.8.0-RC1

1b) Download and unpack the source arch

[ANNOUNCE] Apache Commons Validator 1.7

[sebb AT ASF]

The Apache Commons Validator team is pleased to announce the release
of Apache Commons Validator 1.7

Apache Commons Validator provides the building blocks for both client
side validation and server side data validation.
It may be used standalone or with a framework like Struts.


This is primarily a maintenance release.
All projects are encouraged to update to this release of Apache
Commons Validator.

Commons Validator requires Java 7 or later.

Main enhancements
=

* CreditCard validation specification by numeric range
* DomainValidator instances can be created with instance overrides
* DomainValidator supports overrides of LOCAL TLDs

IMPORTANT NOTES
===

BREAKING CHANGES:

* Now requires Java 7
* N.B. Java 9 changed the way Locales are handled. This affects the
output from some Date-related methods, and may cause some tests to
break.

DEPENDENCIES


* Updates Apache Commons BeanUtils dependency from 1.9.2 to 1.9.4.
 This picks up BEANUTILS-482: Update commons-collections from 3.2.1 to
3.2.2 (CVE-2015-4852).

For the current list of dependencies, please see
http://commons.apache.org/validator/dependencies.html

For complete information on Apache Commons Validator, including
instructions on how to submit bug reports,
patches, or suggestions for improvement, see the Apache Apache Commons
Validator website:

http://commons.apache.org/proper/commons-validator/

Download page: 
http://commons.apache.org/proper/commons-validator/download_validator.cgi

Changes in this version include:
===

New features:
o VALIDATOR-474:  DomainValidator should allow local overrides
o VALIDATOR-473:  Allow Email- and UrlValidator to use specified DomainValidator
o VALIDATOR-471:  Allow DomainValidator overrides at run-time
o VALIDATOR-423:  Add ISINValidator
o VALIDATOR-455:  Add IBAN validator for VA – Vatican City State
Thanks to Eugen Hanussek.
o VALIDATOR-446:  ISSN Validator extract ISSN from EAN-13 Thanks to Alex.

Fixed Bugs:
o VALIDATOR-403:  Accept Discover cards of 17 digits long that start
with 6011 Thanks to Tanya.
o VALIDATOR-408:  DISCOVER Card Validation Patterns Thanks to Raj Vaida.
o VALIDATOR-472:  UrlValidator should not be more lax than java.net.URI
o VALIDATOR-283:  URLValidator should check for illegal Hex characters
Thanks to RC Johnson.
o VALIDATOR-445:  Inet6Address may also contain a scope id Thanks to devson.
o VALIDATOR-452:  Validation of URL containing IPv4-mapped IPv6
address Thanks to devson.
o VALIDATOR-438:  IBANValidator fails for El Salvador
  Add definition Thanks to Simon Marti.
o VALIDATOR-434:  Field does not synchronize iteration on synchronized
list Thanks to emopers.
o VALIDATOR-437:  Update Apache Commons BeanUtils dependency from
1.9.2 to 1.9.3.
  This picks up BEANUTILS-482: Update
commons-collections from 3.2.1 to 3.2.2 (CVE-2015-4852).
o VALIDATOR-460:  Update Apache Commons BeanUtils dependency from 1.9.3 to 1.9.4
  This picks up BEANUTILS-520: Mitigate CVE-2014-0114.
Thanks to Jeff Schram.
o VALIDATOR-461:  Generic .gmbh top level domain is considered invalid
Thanks to Nils Reischmann.
o VALIDATOR-444:  LongValidator: numbers bigger than the maxvalue are
Valid Thanks to Martin Scholz.
o VALIDATOR-416:  CreditCardValidator default ctor disagrees with Javadoc
o VALIDATOR-467:  URL validator fails if path starts with double slash
and has underscores Thanks to Ivan Larionov.
o VALIDATOR-464:  UrlValidator says "file://bad ^
domain.com/label/test" is valid Thanks to Sebastian Choina.
o VALIDATOR-449:  Leading and trailing spaces in EmailValidator should
not be valid Thanks to Frederic Boutin.
o VALIDATOR-302:  EMailValidator: Addresses with leading spaces must
not be accepted Thanks to Guido Zockoll.
o VALIDATOR-468:  DomainValidator.getTLDArray does not synch mutable arrays

Changes:
o Drop Clirr and Cobertura in favour of JApiCmp and JaCoCo
o IANA TLD lists: Updated to Version 2020073100, Last
Updated Fri Jul 31 07:07:01 2020 UTC
o VALIDATOR-428:  Update commons digester to 2.1 Thanks to Matthew Zavislak.


Historical list of changes:
http://commons.apache.org/proper/commons-validator/changes-report.html

Enjoy!
-Apache Commons Validator team

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[RESULT] Release Apache Commons Validator 1.7 based on RC3

[sebb]

On Mon, 3 Aug 2020 at 18:12, sebb  wrote:I

More than 72 hours have now passed, and there have been the following
binding votes:

+1 Gary Gregory
+1 Rob Tomkins
+1 Sebb

The vote has therefore succeeded, and publication will take place soon.

Thanks again to all who voted.

Sebb.
> Thanks to those who voted for RC2, hopefully this will be OK
>
> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons Validator 1.6 was released, so I would like to
> release Apache Commons Validator 1.7.
>
> Apache Commons Validator 1.7 RC3 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC3
> (svn revision 40841)
>
> The Git tag VALIDATOR_1_7_RC3 commit for this RC is
> f9bb21748a9f9c50fbc31862de25ed49433ecc88 which you can browse here:
> 
> https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=f9bb21748a9f9c50fbc31862de25ed49433ecc88
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-validator.git
> --branch VALIDATOR_1_7_RC3 VALIDATOR_1_7_RC3
>
> Maven artifacts are here:
> 
> https://repository.apache.org/content/repositories/orgapachecommons-1520/commons-validator/commons-validator/1.7/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Mon Aug 03 17:52:07 BST 2020
> commons-validator-1.7-bin.tar.gz=c2f8ae044aeb3b078420189cde83ab5ed92fc6ea0d080099b187d8be3ace872e5bce4c020945cd9b0084a3ae7d746c1462acf4c397fe700ca4e4bccb8f1f601d
> commons-validator-1.7-bin.zip=a1450772ba23c4d8f52c7611271987a560b2419343bd60f9870af9de2a5c28bffb17bcb8bd31c16352b98124950b7b51abda742a9b1f9c6daaf0274e57276d13
> commons-validator-1.7-javadoc.jar=5ffb10492960e13f9902c88051888590dca67ac3332bcf53bb1108d5d4c26a8acb5eef134a498556d4c7214efb25539a3acabf46d2afaef1756375229824b419
> commons-validator-1.7-sources.jar=dcda50175444f68800a952ada033a7903b61af775f0d788d8f6c937debacb38d90f0a9a4a4b78d679c2659777eaf1b688c84ce100b7f77631a4a20d5c6df9719
> commons-validator-1.7-src.tar.gz=4007872fda856e9e154f325270748081920d21a716143389713706ca0e5a8ec3c88b9b978d75801a5926723764a81f1dbfd77a8fd4b361b16cd65e84cf47a868
> commons-validator-1.7-src.zip=996c4d8e2e1c1f08ed011343c88bcaae1cd15a3b1d30535df456d366768760ddb9b4655ac3057727dc12aa30b69c66534795740b94c28a7fa2f0af885ef2b299
> commons-validator-1.7-test-sources.jar=62880ed9c39809c40ff53ece2eba545fdaf2ae86ca7416dd3eb3d376ee53a3bd84b32d7672e1d9208b5b80c121e6db88959e714ef84d707232ab10aac991c5ec
> commons-validator-1.7-tests.jar=83b7f39d9d2870f2e8d907cfdb4b6510d53eb3c9c9ed4adad0be25ef2acdb0ab86ded9448cb4013cf9889c36f14ae236367c0148d6ca6fdce8d543e2569d9e48
>
>
> I have tested this with 'mvn clean install -Pjacoco -Pjapicmp site
> deploy -Prelease -Pjava-1.7' using:
>
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> 2018-06-17T19:33:14+01:00)
> Maven home: /opt/apache-maven-3.5.4
> Java version: 1.8.0_261, vendor: Oracle Corporation, runtime:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_261.jdk/Contents/Home/jre
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "mac os x", version: "10.15.6", arch: "x86_64", family: "mac"
>
> Details of changes since 1.6 are in the release notes:
> 
> https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC3/RELEASE-NOTES.txt
> 
> https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC3/site/changes-report.html
>
> Site:
> 
> https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC3/site/index.html
>     (note some *relative* links are broken and the 1.7 directories are
> not yet created - these will be OK once the site is deployed.)
>
> JApiCmp Report (compared to 1.6):
> 
> https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC3/site/japicmp.html
>
> RAT Report:
> 
> https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC3/site/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thank you,
>
> Sebb,
> Release Manager (using key 4FAD5F62)
>
> For following is intended as a helper and refresher for reviewers.
>
> Validating a release candidate
> ==
>
> These guidelines are NOT complete.
>
> Requirements: Git, Java, Maven.
>
> You can validate a release from a release candidate (RC) tag as follows.
>
> 1) Clone and checkout the RC tag
>
> git clone https://gitbox.apache.org/repos/asf/commons-validator.

Re: [VOTE] Release Apache Commons Validator 1.7 based on RC3

[sebb]

Here's my

+1

On Mon, 3 Aug 2020 at 18:12, sebb  wrote:
>
> Thanks to those who voted for RC2, hopefully this will be OK
>
> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons Validator 1.6 was released, so I would like to
> release Apache Commons Validator 1.7.
>
> Apache Commons Validator 1.7 RC3 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC3
> (svn revision 40841)
>
> The Git tag VALIDATOR_1_7_RC3 commit for this RC is
> f9bb21748a9f9c50fbc31862de25ed49433ecc88 which you can browse here:
> 
> https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=f9bb21748a9f9c50fbc31862de25ed49433ecc88
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-validator.git
> --branch VALIDATOR_1_7_RC3 VALIDATOR_1_7_RC3
>
> Maven artifacts are here:
> 
> https://repository.apache.org/content/repositories/orgapachecommons-1520/commons-validator/commons-validator/1.7/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Mon Aug 03 17:52:07 BST 2020
> commons-validator-1.7-bin.tar.gz=c2f8ae044aeb3b078420189cde83ab5ed92fc6ea0d080099b187d8be3ace872e5bce4c020945cd9b0084a3ae7d746c1462acf4c397fe700ca4e4bccb8f1f601d
> commons-validator-1.7-bin.zip=a1450772ba23c4d8f52c7611271987a560b2419343bd60f9870af9de2a5c28bffb17bcb8bd31c16352b98124950b7b51abda742a9b1f9c6daaf0274e57276d13
> commons-validator-1.7-javadoc.jar=5ffb10492960e13f9902c88051888590dca67ac3332bcf53bb1108d5d4c26a8acb5eef134a498556d4c7214efb25539a3acabf46d2afaef1756375229824b419
> commons-validator-1.7-sources.jar=dcda50175444f68800a952ada033a7903b61af775f0d788d8f6c937debacb38d90f0a9a4a4b78d679c2659777eaf1b688c84ce100b7f77631a4a20d5c6df9719
> commons-validator-1.7-src.tar.gz=4007872fda856e9e154f325270748081920d21a716143389713706ca0e5a8ec3c88b9b978d75801a5926723764a81f1dbfd77a8fd4b361b16cd65e84cf47a868
> commons-validator-1.7-src.zip=996c4d8e2e1c1f08ed011343c88bcaae1cd15a3b1d30535df456d366768760ddb9b4655ac3057727dc12aa30b69c66534795740b94c28a7fa2f0af885ef2b299
> commons-validator-1.7-test-sources.jar=62880ed9c39809c40ff53ece2eba545fdaf2ae86ca7416dd3eb3d376ee53a3bd84b32d7672e1d9208b5b80c121e6db88959e714ef84d707232ab10aac991c5ec
> commons-validator-1.7-tests.jar=83b7f39d9d2870f2e8d907cfdb4b6510d53eb3c9c9ed4adad0be25ef2acdb0ab86ded9448cb4013cf9889c36f14ae236367c0148d6ca6fdce8d543e2569d9e48
>
>
> I have tested this with 'mvn clean install -Pjacoco -Pjapicmp site
> deploy -Prelease -Pjava-1.7' using:
>
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> 2018-06-17T19:33:14+01:00)
> Maven home: /opt/apache-maven-3.5.4
> Java version: 1.8.0_261, vendor: Oracle Corporation, runtime:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_261.jdk/Contents/Home/jre
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "mac os x", version: "10.15.6", arch: "x86_64", family: "mac"
>
> Details of changes since 1.6 are in the release notes:
> 
> https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC3/RELEASE-NOTES.txt
> 
> https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC3/site/changes-report.html
>
> Site:
> 
> https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC3/site/index.html
>     (note some *relative* links are broken and the 1.7 directories are
> not yet created - these will be OK once the site is deployed.)
>
> JApiCmp Report (compared to 1.6):
> 
> https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC3/site/japicmp.html
>
> RAT Report:
> 
> https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC3/site/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thank you,
>
> Sebb,
> Release Manager (using key 4FAD5F62)
>
> For following is intended as a helper and refresher for reviewers.
>
> Validating a release candidate
> ==
>
> These guidelines are NOT complete.
>
> Requirements: Git, Java, Maven.
>
> You can validate a release from a release candidate (RC) tag as follows.
>
> 1) Clone and checkout the RC tag
>
> git clone https://gitbox.apache.org/repos/asf/commons-validator.git
> --branch VALIDATOR_1_7_RC3 VALIDATOR_1_7_RC3
> cd VALIDATOR_1_7_RC3
>
> 2) Check Apache licenses
>
> This step is not required if the site includes a RAT report page which
> you then mus

Re: [VOTE] Release Apache Commons Validator 1.7 based on RC3

[Rob Tompkins]

+1

Java 8, Java 11 builds successfully
Signatures validated (see 
https://github.com/chtompki/notes/tree/master/commons-release-validation 
<https://github.com/chtompki/notes/tree/master/commons-release-validation>) if 
anyone else wants to use my process
Reports look good enough (curious about japicmp or clirr here, and curious 
about jacoco…maybe nits??)

Many thanks Sebb!

Cheers,
-Rob

> On Aug 3, 2020, at 1:12 PM, sebb  wrote:
> 
> Thanks to those who voted for RC2, hopefully this will be OK
> 
> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons Validator 1.6 was released, so I would like to
> release Apache Commons Validator 1.7.
> 
> Apache Commons Validator 1.7 RC3 is available for review here:
>https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC3
> (svn revision 40841)
> 
> The Git tag VALIDATOR_1_7_RC3 commit for this RC is
> f9bb21748a9f9c50fbc31862de25ed49433ecc88 which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=f9bb21748a9f9c50fbc31862de25ed49433ecc88
> You may checkout this tag using:
>git clone https://gitbox.apache.org/repos/asf/commons-validator.git
> --branch VALIDATOR_1_7_RC3 VALIDATOR_1_7_RC3
> 
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1520/commons-validator/commons-validator/1.7/
> 
> These are the artifacts and their hashes:
> 
> #Release SHA-512s
> #Mon Aug 03 17:52:07 BST 2020
> commons-validator-1.7-bin.tar.gz=c2f8ae044aeb3b078420189cde83ab5ed92fc6ea0d080099b187d8be3ace872e5bce4c020945cd9b0084a3ae7d746c1462acf4c397fe700ca4e4bccb8f1f601d
> commons-validator-1.7-bin.zip=a1450772ba23c4d8f52c7611271987a560b2419343bd60f9870af9de2a5c28bffb17bcb8bd31c16352b98124950b7b51abda742a9b1f9c6daaf0274e57276d13
> commons-validator-1.7-javadoc.jar=5ffb10492960e13f9902c88051888590dca67ac3332bcf53bb1108d5d4c26a8acb5eef134a498556d4c7214efb25539a3acabf46d2afaef1756375229824b419
> commons-validator-1.7-sources.jar=dcda50175444f68800a952ada033a7903b61af775f0d788d8f6c937debacb38d90f0a9a4a4b78d679c2659777eaf1b688c84ce100b7f77631a4a20d5c6df9719
> commons-validator-1.7-src.tar.gz=4007872fda856e9e154f325270748081920d21a716143389713706ca0e5a8ec3c88b9b978d75801a5926723764a81f1dbfd77a8fd4b361b16cd65e84cf47a868
> commons-validator-1.7-src.zip=996c4d8e2e1c1f08ed011343c88bcaae1cd15a3b1d30535df456d366768760ddb9b4655ac3057727dc12aa30b69c66534795740b94c28a7fa2f0af885ef2b299
> commons-validator-1.7-test-sources.jar=62880ed9c39809c40ff53ece2eba545fdaf2ae86ca7416dd3eb3d376ee53a3bd84b32d7672e1d9208b5b80c121e6db88959e714ef84d707232ab10aac991c5ec
> commons-validator-1.7-tests.jar=83b7f39d9d2870f2e8d907cfdb4b6510d53eb3c9c9ed4adad0be25ef2acdb0ab86ded9448cb4013cf9889c36f14ae236367c0148d6ca6fdce8d543e2569d9e48
> 
> 
> I have tested this with 'mvn clean install -Pjacoco -Pjapicmp site
> deploy -Prelease -Pjava-1.7' using:
> 
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> 2018-06-17T19:33:14+01:00)
> Maven home: /opt/apache-maven-3.5.4
> Java version: 1.8.0_261, vendor: Oracle Corporation, runtime:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_261.jdk/Contents/Home/jre
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "mac os x", version: "10.15.6", arch: "x86_64", family: "mac"
> 
> Details of changes since 1.6 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC3/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC3/site/changes-report.html
> 
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC3/site/index.html
>(note some *relative* links are broken and the 1.7 directories are
> not yet created - these will be OK once the site is deployed.)
> 
> JApiCmp Report (compared to 1.6):
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC3/site/japicmp.html
> 
> RAT Report:
>
> https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC3/site/rat-report.html
> 
> KEYS:
>  https://www.apache.org/dist/commons/KEYS
> 
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
> 
>  [ ] +1 Release these artifacts
>  [ ] +0 OK, but...
>  [ ] -0 OK, but really should fix...
>  [ ] -1 I oppose this release because...
> 
> Thank you,
> 
> Sebb,
> Release Manager (using key 4FAD5F62)
> 
> For following is intended as a helper and refresher for reviewers.
> 
> Validating a release candidate
> ==
> 
> These guidelines are NOT complete.
> 
> Requirements: Git, Java, Maven.
> 
> You can vali

Re: [VOTE] Release Apache Commons Validator 1.7 based on RC3

[Gary Gregory]

+1

Testing based on the git tag

Running: mvn clean -V install site

Reports OK (RAT clean, manual JApiCmp OK)

Building OK with:

Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: C:\Java\apache-maven-3.6.3\bin\..
Java version: *1.8.0_262*, vendor: AdoptOpenJDK, runtime: C:\Program
Files\AdoptOpenJDK\jdk-8.0.262.10-hotspot\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: C:\Java\apache-maven-3.6.3\bin\..
Java version: *11.0.8*, vendor: AdoptOpenJDK, runtime: C:\Program
Files\AdoptOpenJDK\jdk-11.0.8.10-hotspot
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: C:\Java\apache-maven-3.6.3\bin\..
Java version: *14.0.2*, vendor: AdoptOpenJDK, runtime: C:\Program
Files\AdoptOpenJDK\jdk-14.0.2.12-hotspot
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: C:\Java\apache-maven-3.6.3\bin\..
Java version: *15-ea*, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\openjdk\jdk-15
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: C:\Java\apache-maven-3.6.3\bin\..
Java version: *16-ea*, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\openjdk\jdk-16
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Gary

On Mon, Aug 3, 2020 at 1:12 PM sebb  wrote:

> Thanks to those who voted for RC2, hopefully this will be OK
>
> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons Validator 1.6 was released, so I would like to
> release Apache Commons Validator 1.7.
>
> Apache Commons Validator 1.7 RC3 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC3
> (svn revision 40841)
>
> The Git tag VALIDATOR_1_7_RC3 commit for this RC is
> f9bb21748a9f9c50fbc31862de25ed49433ecc88 which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=f9bb21748a9f9c50fbc31862de25ed49433ecc88
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-validator.git
> --branch
> <https://gitbox.apache.org/repos/asf/commons-validator.git--branch>
> VALIDATOR_1_7_RC3 VALIDATOR_1_7_RC3
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1520/commons-validator/commons-validator/1.7/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Mon Aug 03 17:52:07 BST 2020
>
> commons-validator-1.7-bin.tar.gz=c2f8ae044aeb3b078420189cde83ab5ed92fc6ea0d080099b187d8be3ace872e5bce4c020945cd9b0084a3ae7d746c1462acf4c397fe700ca4e4bccb8f1f601d
>
> commons-validator-1.7-bin.zip=a1450772ba23c4d8f52c7611271987a560b2419343bd60f9870af9de2a5c28bffb17bcb8bd31c16352b98124950b7b51abda742a9b1f9c6daaf0274e57276d13
>
> commons-validator-1.7-javadoc.jar=5ffb10492960e13f9902c88051888590dca67ac3332bcf53bb1108d5d4c26a8acb5eef134a498556d4c7214efb25539a3acabf46d2afaef1756375229824b419
>
> commons-validator-1.7-sources.jar=dcda50175444f68800a952ada033a7903b61af775f0d788d8f6c937debacb38d90f0a9a4a4b78d679c2659777eaf1b688c84ce100b7f77631a4a20d5c6df9719
>
> commons-validator-1.7-src.tar.gz=4007872fda856e9e154f325270748081920d21a716143389713706ca0e5a8ec3c88b9b978d75801a5926723764a81f1dbfd77a8fd4b361b16cd65e84cf47a868
>
> commons-validator-1.7-src.zip=996c4d8e2e1c1f08ed011343c88bcaae1cd15a3b1d30535df456d366768760ddb9b4655ac3057727dc12aa30b69c66534795740b94c28a7fa2f0af885ef2b299
>
> commons-validator-1.7-test-sources.jar=62880ed9c39809c40ff53ece2eba545fdaf2ae86ca7416dd3eb3d376ee53a3bd84b32d7672e1d9208b5b80c121e6db88959e714ef84d707232ab10aac991c5ec
>
> commons-validator-1.7-tests.jar=83b7f39d9d2870f2e8d907cfdb4b6510d53eb3c9c9ed4adad0be25ef2acdb0ab86ded9448cb4013cf9889c36f14ae236367c0148d6ca6fdce8d543e2569d9e48
>
>
> I have tested this with 'mvn clean install -Pjacoco -Pjapicmp site
> deploy -Prelease -Pjava-1.7' using:
>
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> 2018-06-17T19:33:14+01:00)
> Maven home: /opt/apache-maven-3.5.4
> Java version: 1.8.0_261, vendor: Oracle Corporation, runtime

[VOTE] Release Apache Commons Validator 1.7 based on RC3

[sebb]

Thanks to those who voted for RC2, hopefully this will be OK

We have fixed quite a few bugs and added some significant enhancements
since Apache Commons Validator 1.6 was released, so I would like to
release Apache Commons Validator 1.7.

Apache Commons Validator 1.7 RC3 is available for review here:
https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC3
(svn revision 40841)

The Git tag VALIDATOR_1_7_RC3 commit for this RC is
f9bb21748a9f9c50fbc31862de25ed49433ecc88 which you can browse here:

https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=f9bb21748a9f9c50fbc31862de25ed49433ecc88
You may checkout this tag using:
git clone https://gitbox.apache.org/repos/asf/commons-validator.git
--branch VALIDATOR_1_7_RC3 VALIDATOR_1_7_RC3

Maven artifacts are here:

https://repository.apache.org/content/repositories/orgapachecommons-1520/commons-validator/commons-validator/1.7/

These are the artifacts and their hashes:

#Release SHA-512s
#Mon Aug 03 17:52:07 BST 2020
commons-validator-1.7-bin.tar.gz=c2f8ae044aeb3b078420189cde83ab5ed92fc6ea0d080099b187d8be3ace872e5bce4c020945cd9b0084a3ae7d746c1462acf4c397fe700ca4e4bccb8f1f601d
commons-validator-1.7-bin.zip=a1450772ba23c4d8f52c7611271987a560b2419343bd60f9870af9de2a5c28bffb17bcb8bd31c16352b98124950b7b51abda742a9b1f9c6daaf0274e57276d13
commons-validator-1.7-javadoc.jar=5ffb10492960e13f9902c88051888590dca67ac3332bcf53bb1108d5d4c26a8acb5eef134a498556d4c7214efb25539a3acabf46d2afaef1756375229824b419
commons-validator-1.7-sources.jar=dcda50175444f68800a952ada033a7903b61af775f0d788d8f6c937debacb38d90f0a9a4a4b78d679c2659777eaf1b688c84ce100b7f77631a4a20d5c6df9719
commons-validator-1.7-src.tar.gz=4007872fda856e9e154f325270748081920d21a716143389713706ca0e5a8ec3c88b9b978d75801a5926723764a81f1dbfd77a8fd4b361b16cd65e84cf47a868
commons-validator-1.7-src.zip=996c4d8e2e1c1f08ed011343c88bcaae1cd15a3b1d30535df456d366768760ddb9b4655ac3057727dc12aa30b69c66534795740b94c28a7fa2f0af885ef2b299
commons-validator-1.7-test-sources.jar=62880ed9c39809c40ff53ece2eba545fdaf2ae86ca7416dd3eb3d376ee53a3bd84b32d7672e1d9208b5b80c121e6db88959e714ef84d707232ab10aac991c5ec
commons-validator-1.7-tests.jar=83b7f39d9d2870f2e8d907cfdb4b6510d53eb3c9c9ed4adad0be25ef2acdb0ab86ded9448cb4013cf9889c36f14ae236367c0148d6ca6fdce8d543e2569d9e48


I have tested this with 'mvn clean install -Pjacoco -Pjapicmp site
deploy -Prelease -Pjava-1.7' using:

Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
2018-06-17T19:33:14+01:00)
Maven home: /opt/apache-maven-3.5.4
Java version: 1.8.0_261, vendor: Oracle Corporation, runtime:
/Library/Java/JavaVirtualMachines/jdk1.8.0_261.jdk/Contents/Home/jre
Default locale: en_GB, platform encoding: UTF-8
OS name: "mac os x", version: "10.15.6", arch: "x86_64", family: "mac"

Details of changes since 1.6 are in the release notes:
    
https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC3/RELEASE-NOTES.txt
    
https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC3/site/changes-report.html

Site:
    
https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC3/site/index.html
(note some *relative* links are broken and the 1.7 directories are
not yet created - these will be OK once the site is deployed.)

JApiCmp Report (compared to 1.6):
    
https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC3/site/japicmp.html

RAT Report:
    
https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC3/site/rat-report.html

KEYS:
  https://www.apache.org/dist/commons/KEYS

Please review the release candidate and vote.
This vote will close no sooner than 72 hours from now.

  [ ] +1 Release these artifacts
  [ ] +0 OK, but...
  [ ] -0 OK, but really should fix...
  [ ] -1 I oppose this release because...

Thank you,

Sebb,
Release Manager (using key 4FAD5F62)

For following is intended as a helper and refresher for reviewers.

Validating a release candidate
==

These guidelines are NOT complete.

Requirements: Git, Java, Maven.

You can validate a release from a release candidate (RC) tag as follows.

1) Clone and checkout the RC tag

git clone https://gitbox.apache.org/repos/asf/commons-validator.git
--branch VALIDATOR_1_7_RC3 VALIDATOR_1_7_RC3
cd VALIDATOR_1_7_RC3

2) Check Apache licenses

This step is not required if the site includes a RAT report page which
you then must check.

mvn apache-rat:check

3) Check binary compatibility

Older components still use Apache Clirr:

This step is not required if the site includes a Clirr report page
which you then must check.

mvn clirr:check

Newer components use JApiCmp with the japicmp Maven Profile:

This step is not required if the site includes a JApiCmp report page
which you then must check.

mvn install -DskipTests -P japicmp japicmp:cmp

4) Build the package

mvn -V clean package

You can record the Maven and Java version produced by -V in your VOTE reply.
To gather OS i

Re: [OFF-LIST][CANCELLED][VOTE] Release Apache Commons Validator 1.7 based on RC2

[Rob Tompkins]

   CurrencyValidatorTest.testInvalid:121 US wrong negative
>>>>>>>> [ERROR]   CurrencyValidatorTest.testValid:93 US negative
>>>>>>>> expected:<-1234.56> but was:
>>>>>>>> [ERROR]   DateValidatorTest.testDateValidatorMethods:69 validate(A)
>>>>>> both
>>>>>>>> expected: but was:
>>>>>>>> [ERROR]   TimeValidatorTest.testTimeZone:224 pattern result
>>>>>>>> [ERROR] Errors:
>>>>>>>> [ERROR]   CalendarValidatorTest.testCalendarValidatorMethods:70
>>>>>> NullPointer
>>>>>>>> [INFO]
>>>>>>>> [ERROR] Tests run: 575, Failures: 7, Errors: 1, Skipped: 1
>>>>>>>> 
>>>>>>>> 14:23:44.86 C:\temp\rc\VALIDATOR_1_7_RC2>mvn -version && java
>>>>> -version
>>>>>>>> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
>>>>>>>> Maven home: C:\Java\apache-maven-3.6.3\bin\..
>>>>>>>> Java version: 11.0.7, vendor: Oracle Corporation, runtime: C:\Program
>>>>>>>> Files\Java\jdk-11.0.7
>>>>>>>> Default locale: en_US, platform encoding: Cp1252
>>>>>>>> OS name: "windows 10", version: "10.0", arch: "amd64", family:
>>>>>> "windows"
>>>>>>>> java version "11.0.7" 2020-04-14 LTS
>>>>>>>> Java(TM) SE Runtime Environment 18.9 (build 11.0.7+8-LTS)
>>>>>>>> Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11.0.7+8-LTS, mixed
>>>>> mode)
>>>>>>>> 
>>>>>>>> So something needs a fix somewhere, either in the tests or in the
>>>>> code.
>>>>>>> 
>>>>>>> I think the issue is with Windows Java.
>>>>>>> It's certainly not a regression, since the same failure on Windows
>>>>>>> occurs with release 1.6:
>>>>>>> 
>>>>>>> Perhaps you could try testing against git checkout VALIDATOR_1_6
>>>>>>> 
>>>>>>> Java 9 changed the default Locale definitions; some Locales now have
>>>>>>> different output/input formats.
>>>>>>> These cause tests to fail.
>>>>>>> 
>>>>>>> Setting the system property
>>>>>>> COMPAT,CLDR
>>>>>>> or
>>>>>>> COMPAT,SPI
>>>>>>> is supposed to tell Java to use compatibility mode.
>>>>>>> 
>>>>>>> This works fine on MacOS and Linux, but appears to have no effect on
>>>>>> Windows
>>>>>>> 
>>>>>>>> Otherwise, I can't take a release tag and patch it and test
>>>>>> successfully
>>>>>>>> since I am not starting from a passing build.
>>>>>>> 
>>>>>>> If you patch the failing test ...
>>>>>> 
>>>>>> Or just try adding the following definition to the Maven command line (*)
>>>>>> 
>>>>>> -Dcommons.surefire.version=2.21.0
>>>>>> 
>>>>>> Something changed between Surefire 2.21.0 and 2.22.0 which results in
>>>>>> the wrong Locale definitions being used, but apparently only on
>>>>>> Windows.
>>>>>> 
>>>>>> The correct value of java.locale.providers is seen by the test case,
>>>>>> so I assume the system property must be being set too late for it to
>>>>>> be picked up by the Locale initialisation.
>>>>>> 
>>>>>> Weird error, but it's not an issue with Validator per se.
>>>>>> 
>>>>>> Needs more investigation.
>>>>>> 
>>>>>> I've discovered that setting
>>>>>> -DargLine=-Djava.locale.providers=COMPAT,... also works.
>>>>>> (This is used by Surefire to set the Java command-line params)
>>>>>> 
>>>>>> I tried using COMPAT,SPI instead of COMPAT,CLDR (as per
>>>>>> SystemProperties in the POM).
>>>>>> The value seen by the test is COMPAT,CLDR, which shows that the System
>>>>>> property is being overridden by Surefire sometime after startup.
>>>>>> Presumably it is 

Re: [OFF-LIST][CANCELLED][VOTE] Release Apache Commons Validator 1.7 based on RC2

[sebb]

Errors: 1, Skipped: 1
> >>>>>>
> >>>>>> 14:23:44.86 C:\temp\rc\VALIDATOR_1_7_RC2>mvn -version && java
> >>> -version
> >>>>>> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> >>>>>> Maven home: C:\Java\apache-maven-3.6.3\bin\..
> >>>>>> Java version: 11.0.7, vendor: Oracle Corporation, runtime: C:\Program
> >>>>>> Files\Java\jdk-11.0.7
> >>>>>> Default locale: en_US, platform encoding: Cp1252
> >>>>>> OS name: "windows 10", version: "10.0", arch: "amd64", family:
> >>>> "windows"
> >>>>>> java version "11.0.7" 2020-04-14 LTS
> >>>>>> Java(TM) SE Runtime Environment 18.9 (build 11.0.7+8-LTS)
> >>>>>> Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11.0.7+8-LTS, mixed
> >>> mode)
> >>>>>>
> >>>>>> So something needs a fix somewhere, either in the tests or in the
> >>> code.
> >>>>>
> >>>>> I think the issue is with Windows Java.
> >>>>> It's certainly not a regression, since the same failure on Windows
> >>>>> occurs with release 1.6:
> >>>>>
> >>>>> Perhaps you could try testing against git checkout VALIDATOR_1_6
> >>>>>
> >>>>> Java 9 changed the default Locale definitions; some Locales now have
> >>>>> different output/input formats.
> >>>>> These cause tests to fail.
> >>>>>
> >>>>> Setting the system property
> >>>>> COMPAT,CLDR
> >>>>> or
> >>>>> COMPAT,SPI
> >>>>> is supposed to tell Java to use compatibility mode.
> >>>>>
> >>>>> This works fine on MacOS and Linux, but appears to have no effect on
> >>>> Windows
> >>>>>
> >>>>>> Otherwise, I can't take a release tag and patch it and test
> >>>> successfully
> >>>>>> since I am not starting from a passing build.
> >>>>>
> >>>>> If you patch the failing test ...
> >>>>
> >>>> Or just try adding the following definition to the Maven command line (*)
> >>>>
> >>>> -Dcommons.surefire.version=2.21.0
> >>>>
> >>>> Something changed between Surefire 2.21.0 and 2.22.0 which results in
> >>>> the wrong Locale definitions being used, but apparently only on
> >>>> Windows.
> >>>>
> >>>> The correct value of java.locale.providers is seen by the test case,
> >>>> so I assume the system property must be being set too late for it to
> >>>> be picked up by the Locale initialisation.
> >>>>
> >>>> Weird error, but it's not an issue with Validator per se.
> >>>>
> >>>> Needs more investigation.
> >>>>
> >>>> I've discovered that setting
> >>>> -DargLine=-Djava.locale.providers=COMPAT,... also works.
> >>>> (This is used by Surefire to set the Java command-line params)
> >>>>
> >>>> I tried using COMPAT,SPI instead of COMPAT,CLDR (as per
> >>>> SystemProperties in the POM).
> >>>> The value seen by the test is COMPAT,CLDR, which shows that the System
> >>>> property is being overridden by Surefire sometime after startup.
> >>>> Presumably it is being done later in Windows for some odd reason.
> >>>>
> >>>> This would be a work-round, but one ought to be able to use
> >>>> SystemProperties...
> >>>>
> >>>> Sebb
> >>>> (*) The investigation made use of 'git bisect' - one of the best
> >>>> aspects of Git I have come across.
> >>>>
> >>>>>> Gary
> >>>>>>
> >>>>>>
> >>>>>>>
> >>>>>>> Likewise with Java 14.
> >>>>>>>
> >>>>>>> However -P jacoco fails for me with Java 9, 11 and 14:
> >>>>>>>
> >>>>>>> Plugin org.codehaus.mojo:cobertura-maven-plugin:2.7 or one of its
> >>>>>>> dependen

[OFF-LIST][CANCELLED][VOTE] Release Apache Commons Validator 1.7 based on RC2

[Rob Tompkins]

-LTS, mixed
>>> mode)
>>>>>> 
>>>>>> So something needs a fix somewhere, either in the tests or in the
>>> code.
>>>>> 
>>>>> I think the issue is with Windows Java.
>>>>> It's certainly not a regression, since the same failure on Windows
>>>>> occurs with release 1.6:
>>>>> 
>>>>> Perhaps you could try testing against git checkout VALIDATOR_1_6
>>>>> 
>>>>> Java 9 changed the default Locale definitions; some Locales now have
>>>>> different output/input formats.
>>>>> These cause tests to fail.
>>>>> 
>>>>> Setting the system property
>>>>> COMPAT,CLDR
>>>>> or
>>>>> COMPAT,SPI
>>>>> is supposed to tell Java to use compatibility mode.
>>>>> 
>>>>> This works fine on MacOS and Linux, but appears to have no effect on
>>>> Windows
>>>>> 
>>>>>> Otherwise, I can't take a release tag and patch it and test
>>>> successfully
>>>>>> since I am not starting from a passing build.
>>>>> 
>>>>> If you patch the failing test ...
>>>> 
>>>> Or just try adding the following definition to the Maven command line (*)
>>>> 
>>>> -Dcommons.surefire.version=2.21.0
>>>> 
>>>> Something changed between Surefire 2.21.0 and 2.22.0 which results in
>>>> the wrong Locale definitions being used, but apparently only on
>>>> Windows.
>>>> 
>>>> The correct value of java.locale.providers is seen by the test case,
>>>> so I assume the system property must be being set too late for it to
>>>> be picked up by the Locale initialisation.
>>>> 
>>>> Weird error, but it's not an issue with Validator per se.
>>>> 
>>>> Needs more investigation.
>>>> 
>>>> I've discovered that setting
>>>> -DargLine=-Djava.locale.providers=COMPAT,... also works.
>>>> (This is used by Surefire to set the Java command-line params)
>>>> 
>>>> I tried using COMPAT,SPI instead of COMPAT,CLDR (as per
>>>> SystemProperties in the POM).
>>>> The value seen by the test is COMPAT,CLDR, which shows that the System
>>>> property is being overridden by Surefire sometime after startup.
>>>> Presumably it is being done later in Windows for some odd reason.
>>>> 
>>>> This would be a work-round, but one ought to be able to use
>>>> SystemProperties...
>>>> 
>>>> Sebb
>>>> (*) The investigation made use of 'git bisect' - one of the best
>>>> aspects of Git I have come across.
>>>> 
>>>>>> Gary
>>>>>> 
>>>>>> 
>>>>>>> 
>>>>>>> Likewise with Java 14.
>>>>>>> 
>>>>>>> However -P jacoco fails for me with Java 9, 11 and 14:
>>>>>>> 
>>>>>>> Plugin org.codehaus.mojo:cobertura-maven-plugin:2.7 or one of its
>>>>>>> dependencies could not be resolved:
>>>>>>> Could not find artifact com.sun:tools:jar:0 at specified path
>>>>>>> 
>>>>>>> 
>>>> 
>>> /Library/Java/JavaVirtualMachines/jdk-9.0.1.jdk/Contents/Home/../lib/tools.jar
>>>>>>> 
>>>>>>> 
>>>>>>>> [INFO] Running
>>>> org.apache.commons.validator.routines.TimeValidatorTest
>>>>>>>> [ERROR] Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time
>>>> elapsed:
>>>>>>>> 0.026 s <<< FAILURE! - in
>>>>>>>> org.apache.commons.validator.routines.TimeValidatorTest
>>>>>>>> [ERROR]
>>>>>>>> 
>>>> testTimeZone(org.apache.commons.validator.routines.TimeValidatorTest)
>>>>>>> Time
>>>>>>>> elapsed: 0 s  <<< FAILURE!
>>>>>>>> junit.framework.AssertionFailedError: pattern result
>>>>>>>>    at
>>>>>>>> 
>>>>>>> 
>>>> 
>>> org.apache.commons.validator.routines.TimeValidatorTest.testTimeZone(TimeValidatorTest.java:224)
>>>>>>>> 
>

[CANCELLED][VOTE] Release Apache Commons Validator 1.7 based on RC2

[sebb]

 with Windows Java.
> > > > It's certainly not a regression, since the same failure on Windows
> > > > occurs with release 1.6:
> > > >
> > > > Perhaps you could try testing against git checkout VALIDATOR_1_6
> > > >
> > > > Java 9 changed the default Locale definitions; some Locales now have
> > > > different output/input formats.
> > > > These cause tests to fail.
> > > >
> > > > Setting the system property
> > > > COMPAT,CLDR
> > > > or
> > > > COMPAT,SPI
> > > > is supposed to tell Java to use compatibility mode.
> > > >
> > > > This works fine on MacOS and Linux, but appears to have no effect on
> > > Windows
> > > >
> > > > > Otherwise, I can't take a release tag and patch it and test
> > > successfully
> > > > > since I am not starting from a passing build.
> > > >
> > > > If you patch the failing test ...
> > >
> > > Or just try adding the following definition to the Maven command line (*)
> > >
> > >  -Dcommons.surefire.version=2.21.0
> > >
> > > Something changed between Surefire 2.21.0 and 2.22.0 which results in
> > > the wrong Locale definitions being used, but apparently only on
> > > Windows.
> > >
> > > The correct value of java.locale.providers is seen by the test case,
> > > so I assume the system property must be being set too late for it to
> > > be picked up by the Locale initialisation.
> > >
> > > Weird error, but it's not an issue with Validator per se.
> > >
> > > Needs more investigation.
> > >
> > > I've discovered that setting
> > > -DargLine=-Djava.locale.providers=COMPAT,... also works.
> > > (This is used by Surefire to set the Java command-line params)
> > >
> > > I tried using COMPAT,SPI instead of COMPAT,CLDR (as per
> > > SystemProperties in the POM).
> > > The value seen by the test is COMPAT,CLDR, which shows that the System
> > > property is being overridden by Surefire sometime after startup.
> > > Presumably it is being done later in Windows for some odd reason.
> > >
> > > This would be a work-round, but one ought to be able to use
> > > SystemProperties...
> > >
> > > Sebb
> > > (*) The investigation made use of 'git bisect' - one of the best
> > > aspects of Git I have come across.
> > >
> > > > > Gary
> > > > >
> > > > >
> > > > > >
> > > > > > Likewise with Java 14.
> > > > > >
> > > > > > However -P jacoco fails for me with Java 9, 11 and 14:
> > > > > >
> > > > > > Plugin org.codehaus.mojo:cobertura-maven-plugin:2.7 or one of its
> > > > > > dependencies could not be resolved:
> > > > > > Could not find artifact com.sun:tools:jar:0 at specified path
> > > > > >
> > > > > >
> > >
> > /Library/Java/JavaVirtualMachines/jdk-9.0.1.jdk/Contents/Home/../lib/tools.jar
> > > > > >
> > > > > >
> > > > > > > [INFO] Running
> > > org.apache.commons.validator.routines.TimeValidatorTest
> > > > > > > [ERROR] Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time
> > > elapsed:
> > > > > > > 0.026 s <<< FAILURE! - in
> > > > > > > org.apache.commons.validator.routines.TimeValidatorTest
> > > > > > > [ERROR]
> > > > > > >
> > > testTimeZone(org.apache.commons.validator.routines.TimeValidatorTest)
> > > > > > Time
> > > > > > > elapsed: 0 s  <<< FAILURE!
> > > > > > > junit.framework.AssertionFailedError: pattern result
> > > > > > > at
> > > > > > >
> > > > > >
> > >
> > org.apache.commons.validator.routines.TimeValidatorTest.testTimeZone(TimeValidatorTest.java:224)
> > > > > > >
> > > > > > > [ERROR] Failures:
> > > > > > > [ERROR]   CalendarValidatorTest.testDateTimeStyle:197 validate(A)
> > > default
> > > > > > > [ERROR]   CalendarValidatorTest.testFormat:215 default
> > > > > > > expected:<31/12/[]05> but was:<31/12/[20]05>
> > > > > > > [ERROR]   CurrencyValid

Re: [VOTE] Release Apache Commons Validator 1.7 based on RC2

[Matt Sicker]

.
> >
> > Or just try adding the following definition to the Maven command line (*)
> >
> >  -Dcommons.surefire.version=2.21.0
> >
> > Something changed between Surefire 2.21.0 and 2.22.0 which results in
> > the wrong Locale definitions being used, but apparently only on
> > Windows.
> >
> > The correct value of java.locale.providers is seen by the test case,
> > so I assume the system property must be being set too late for it to
> > be picked up by the Locale initialisation.
> >
> > Weird error, but it's not an issue with Validator per se.
> >
> > Needs more investigation.
> >
> > I've discovered that setting
> > -DargLine=-Djava.locale.providers=COMPAT,... also works.
> > (This is used by Surefire to set the Java command-line params)
> >
> > I tried using COMPAT,SPI instead of COMPAT,CLDR (as per
> > SystemProperties in the POM).
> > The value seen by the test is COMPAT,CLDR, which shows that the System
> > property is being overridden by Surefire sometime after startup.
> > Presumably it is being done later in Windows for some odd reason.
> >
> > This would be a work-round, but one ought to be able to use
> > SystemProperties...
> >
> > Sebb
> > (*) The investigation made use of 'git bisect' - one of the best
> > aspects of Git I have come across.
> >
> > > > Gary
> > > >
> > > >
> > > > >
> > > > > Likewise with Java 14.
> > > > >
> > > > > However -P jacoco fails for me with Java 9, 11 and 14:
> > > > >
> > > > > Plugin org.codehaus.mojo:cobertura-maven-plugin:2.7 or one of its
> > > > > dependencies could not be resolved:
> > > > > Could not find artifact com.sun:tools:jar:0 at specified path
> > > > >
> > > > >
> >
> /Library/Java/JavaVirtualMachines/jdk-9.0.1.jdk/Contents/Home/../lib/tools.jar
> > > > >
> > > > >
> > > > > > [INFO] Running
> > org.apache.commons.validator.routines.TimeValidatorTest
> > > > > > [ERROR] Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time
> > elapsed:
> > > > > > 0.026 s <<< FAILURE! - in
> > > > > > org.apache.commons.validator.routines.TimeValidatorTest
> > > > > > [ERROR]
> > > > > >
> > testTimeZone(org.apache.commons.validator.routines.TimeValidatorTest)
> > > > > Time
> > > > > > elapsed: 0 s  <<< FAILURE!
> > > > > > junit.framework.AssertionFailedError: pattern result
> > > > > > at
> > > > > >
> > > > >
> >
> org.apache.commons.validator.routines.TimeValidatorTest.testTimeZone(TimeValidatorTest.java:224)
> > > > > >
> > > > > > [ERROR] Failures:
> > > > > > [ERROR]   CalendarValidatorTest.testDateTimeStyle:197 validate(A)
> > default
> > > > > > [ERROR]   CalendarValidatorTest.testFormat:215 default
> > > > > > expected:<31/12/[]05> but was:<31/12/[20]05>
> > > > > > [ERROR]   CurrencyValidatorTest.testIntegerValid:142 US negative
> > > > > > expected:<-1234.00> but was:
> > > > > > [ERROR]   CurrencyValidatorTest.testInvalid:121 US wrong negative
> > > > > > [ERROR]   CurrencyValidatorTest.testValid:93 US negative
> > > > > > expected:<-1234.56> but was:
> > > > > > [ERROR]   DateValidatorTest.testDateValidatorMethods:69
> > validate(A) both
> > > > > > expected: but was:
> > > > > > [ERROR]   TimeValidatorTest.testTimeZone:224 pattern result
> > > > > > [ERROR] Errors:
> > > > > > [ERROR]   CalendarValidatorTest.testCalendarValidatorMethods:70
> > > > > NullPointer
> > > > > > [INFO]
> > > > > > [ERROR] Tests run: 575, Failures: 7, Errors: 1, Skipped: 1
> > > > > >
> > > > > > I also get the same failure on the current Java version 14:
> > > > > >
> > > > > > Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> > > > > > Maven home: C:\Java\apache-maven-3.6.3\bin\..
> > > > > > Java version: 14.0.2, vendor: AdoptOpenJDK, runtime: C:\Program
> > > > > > Files\AdoptOpenJDK\jdk-14.0.2.12-hotspot
> > > > > > Default loca

Re: [VOTE] Release Apache Commons Validator 1.7 based on RC2

[Gary Gregory]

his would be a work-round, but one ought to be able to use
> SystemProperties...
>
> Sebb
> (*) The investigation made use of 'git bisect' - one of the best
> aspects of Git I have come across.
>
> > > Gary
> > >
> > >
> > > >
> > > > Likewise with Java 14.
> > > >
> > > > However -P jacoco fails for me with Java 9, 11 and 14:
> > > >
> > > > Plugin org.codehaus.mojo:cobertura-maven-plugin:2.7 or one of its
> > > > dependencies could not be resolved:
> > > > Could not find artifact com.sun:tools:jar:0 at specified path
> > > >
> > > >
> /Library/Java/JavaVirtualMachines/jdk-9.0.1.jdk/Contents/Home/../lib/tools.jar
> > > >
> > > >
> > > > > [INFO] Running
> org.apache.commons.validator.routines.TimeValidatorTest
> > > > > [ERROR] Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time
> elapsed:
> > > > > 0.026 s <<< FAILURE! - in
> > > > > org.apache.commons.validator.routines.TimeValidatorTest
> > > > > [ERROR]
> > > > >
> testTimeZone(org.apache.commons.validator.routines.TimeValidatorTest)
> > > > Time
> > > > > elapsed: 0 s  <<< FAILURE!
> > > > > junit.framework.AssertionFailedError: pattern result
> > > > > at
> > > > >
> > > >
> org.apache.commons.validator.routines.TimeValidatorTest.testTimeZone(TimeValidatorTest.java:224)
> > > > >
> > > > > [ERROR] Failures:
> > > > > [ERROR]   CalendarValidatorTest.testDateTimeStyle:197 validate(A)
> default
> > > > > [ERROR]   CalendarValidatorTest.testFormat:215 default
> > > > > expected:<31/12/[]05> but was:<31/12/[20]05>
> > > > > [ERROR]   CurrencyValidatorTest.testIntegerValid:142 US negative
> > > > > expected:<-1234.00> but was:
> > > > > [ERROR]   CurrencyValidatorTest.testInvalid:121 US wrong negative
> > > > > [ERROR]   CurrencyValidatorTest.testValid:93 US negative
> > > > > expected:<-1234.56> but was:
> > > > > [ERROR]   DateValidatorTest.testDateValidatorMethods:69
> validate(A) both
> > > > > expected: but was:
> > > > > [ERROR]   TimeValidatorTest.testTimeZone:224 pattern result
> > > > > [ERROR] Errors:
> > > > > [ERROR]   CalendarValidatorTest.testCalendarValidatorMethods:70
> > > > NullPointer
> > > > > [INFO]
> > > > > [ERROR] Tests run: 575, Failures: 7, Errors: 1, Skipped: 1
> > > > >
> > > > > I also get the same failure on the current Java version 14:
> > > > >
> > > > > Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> > > > > Maven home: C:\Java\apache-maven-3.6.3\bin\..
> > > > > Java version: 14.0.2, vendor: AdoptOpenJDK, runtime: C:\Program
> > > > > Files\AdoptOpenJDK\jdk-14.0.2.12-hotspot
> > > > > Default locale: en_US, platform encoding: Cp1252
> > > > > OS name: "windows 10", version: "10.0", arch: "amd64", family:
> "windows"
> > > >
> > > > There is a profile 'jdk9-cldr' which is supposed to fix that issue.
> > > >
> > > > Personally, I don't think it is a blocker.
> > > > Java 9 changed the way locales are handled.
> > > >
> > > > But if it does not work on Windows for some reason then I guess it
> > > > should be mentioned in the release notes
> > > >
> > > > > Gary
> > > > >
> > > > >
> > > > >
> > > > > On Sat, Aug 1, 2020, 09:20 sebb  wrote:
> > > > >
> > > > > > We have fixed quite a few bugs and added some significant
> enhancements
> > > > > > since Apache Commons Validator 1.6 was released, so I would like
> to
> > > > > > release Apache Commons Validator 1.7.
> > > > > >
> > > > > > Apache Commons Validator 1.7 RC2 is available for review here:
> > > > > >
> https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC2
> > > > > > (svn revision 40802)
> > > > > >
> > > > > > The Git tag VALIDATOR_1_7_RC2 commit for this RC is
> > > > > > 5b75344ace5a8864e3936010524684272145bbcd which you can browse
> here:
> > > > > >
> &

Re: [VOTE] Release Apache Commons Validator 1.7 based on RC2

[sebb]

t; > > > elapsed: 0 s  <<< FAILURE!
> > > > junit.framework.AssertionFailedError: pattern result
> > > > at
> > > >
> > > org.apache.commons.validator.routines.TimeValidatorTest.testTimeZone(TimeValidatorTest.java:224)
> > > >
> > > > [ERROR] Failures:
> > > > [ERROR]   CalendarValidatorTest.testDateTimeStyle:197 validate(A) 
> > > > default
> > > > [ERROR]   CalendarValidatorTest.testFormat:215 default
> > > > expected:<31/12/[]05> but was:<31/12/[20]05>
> > > > [ERROR]   CurrencyValidatorTest.testIntegerValid:142 US negative
> > > > expected:<-1234.00> but was:
> > > > [ERROR]   CurrencyValidatorTest.testInvalid:121 US wrong negative
> > > > [ERROR]   CurrencyValidatorTest.testValid:93 US negative
> > > > expected:<-1234.56> but was:
> > > > [ERROR]   DateValidatorTest.testDateValidatorMethods:69 validate(A) both
> > > > expected: but was:
> > > > [ERROR]   TimeValidatorTest.testTimeZone:224 pattern result
> > > > [ERROR] Errors:
> > > > [ERROR]   CalendarValidatorTest.testCalendarValidatorMethods:70
> > > NullPointer
> > > > [INFO]
> > > > [ERROR] Tests run: 575, Failures: 7, Errors: 1, Skipped: 1
> > > >
> > > > I also get the same failure on the current Java version 14:
> > > >
> > > > Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> > > > Maven home: C:\Java\apache-maven-3.6.3\bin\..
> > > > Java version: 14.0.2, vendor: AdoptOpenJDK, runtime: C:\Program
> > > > Files\AdoptOpenJDK\jdk-14.0.2.12-hotspot
> > > > Default locale: en_US, platform encoding: Cp1252
> > > > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
> > >
> > > There is a profile 'jdk9-cldr' which is supposed to fix that issue.
> > >
> > > Personally, I don't think it is a blocker.
> > > Java 9 changed the way locales are handled.
> > >
> > > But if it does not work on Windows for some reason then I guess it
> > > should be mentioned in the release notes
> > >
> > > > Gary
> > > >
> > > >
> > > >
> > > > On Sat, Aug 1, 2020, 09:20 sebb  wrote:
> > > >
> > > > > We have fixed quite a few bugs and added some significant enhancements
> > > > > since Apache Commons Validator 1.6 was released, so I would like to
> > > > > release Apache Commons Validator 1.7.
> > > > >
> > > > > Apache Commons Validator 1.7 RC2 is available for review here:
> > > > > https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC2
> > > > > (svn revision 40802)
> > > > >
> > > > > The Git tag VALIDATOR_1_7_RC2 commit for this RC is
> > > > > 5b75344ace5a8864e3936010524684272145bbcd which you can browse here:
> > > > >
> > > > >
> > > https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=5b75344ace5a8864e3936010524684272145bbcd
> > > > > You may checkout this tag using:
> > > > > git clone
> > > https://gitbox.apache.org/repos/asf/commons-validator.git
> > > > > --branch
> > > > > <https://gitbox.apache.org/repos/asf/commons-validator.git--branch>
> > > > > VALIDATOR_1_7_RC2 VALIDATOR_1_7_RC2
> > > > >
> > > > > Maven artifacts are here:
> > > > >
> > > > >
> > > https://repository.apache.org/content/repositories/orgapachecommons-1515/org/apache/commons/commons-validator/1.7/
> > > > >
> > > > > These are the artifacts and their hashes:
> > > > >
> > > > > #Release SHA-512s
> > > > > #Sat Aug 01 13:37:45 BST 2020
> > > > >
> > > > >
> > > commons-validator-1.7-bin.tar.gz=c64463b7f2c10cf826db37b6b5b89893e1ac5add56fb74bf546eb43f9efef1381173abdf695a601fcef1a604e116acc3723876e9318304714003b7db00c9ca74
> > > > >
> > > > >
> > > commons-validator-1.7-bin.zip=41918449e823fa1ae2fd166808e014bf04913a9a14e5645b2f4d28a763e6fe5cabcae1d771d8668b48e4bfea0e2d94d594766cb17889cf0d4c73b99fe49d6fe3
> > > > >
> > > > >
> > > commons-validator-1.7-javadoc.jar=c0f3c56deca2e1449efe76f738ceafcbe293199ab4d7d641855caff4f2c06ed51756d1a2bcb9011a9ff7d8f

Re: [VOTE] Release Apache Commons Validator 1.7 based on RC2

[sebb]

IntegerValid:142 US negative
> expected:<-1234.00> but was:
> [ERROR]   CurrencyValidatorTest.testInvalid:121 US wrong negative
> [ERROR]   CurrencyValidatorTest.testValid:93 US negative
> expected:<-1234.56> but was:
> [ERROR]   DateValidatorTest.testDateValidatorMethods:69 validate(A) both
> expected: but was:
> [ERROR]   TimeValidatorTest.testTimeZone:224 pattern result
> [ERROR] Errors:
> [ERROR]   CalendarValidatorTest.testCalendarValidatorMethods:70 NullPointer
> [INFO]
> [ERROR] Tests run: 575, Failures: 7, Errors: 1, Skipped: 1
>
> 14:23:44.86 C:\temp\rc\VALIDATOR_1_7_RC2>mvn -version && java -version
> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: C:\Java\apache-maven-3.6.3\bin\..
> Java version: 11.0.7, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk-11.0.7
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
> java version "11.0.7" 2020-04-14 LTS
> Java(TM) SE Runtime Environment 18.9 (build 11.0.7+8-LTS)
> Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11.0.7+8-LTS, mixed mode)
>
> So something needs a fix somewhere, either in the tests or in the code.

I think the issue is with Windows Java.
It's certainly not a regression, since the same failure on Windows
occurs with release 1.6:

Perhaps you could try testing against git checkout VALIDATOR_1_6

Java 9 changed the default Locale definitions; some Locales now have
different output/input formats.
These cause tests to fail.

Setting the system property
COMPAT,CLDR
or
COMPAT,SPI
is supposed to tell Java to use compatibility mode.

This works fine on MacOS and Linux, but appears to have no effect on Windows

> Otherwise, I can't take a release tag and patch it and test successfully
> since I am not starting from a passing build.

If you patch the failing test ...

> Gary
>
>
> >
> > Likewise with Java 14.
> >
> > However -P jacoco fails for me with Java 9, 11 and 14:
> >
> > Plugin org.codehaus.mojo:cobertura-maven-plugin:2.7 or one of its
> > dependencies could not be resolved:
> > Could not find artifact com.sun:tools:jar:0 at specified path
> >
> > /Library/Java/JavaVirtualMachines/jdk-9.0.1.jdk/Contents/Home/../lib/tools.jar
> >
> >
> > > [INFO] Running org.apache.commons.validator.routines.TimeValidatorTest
> > > [ERROR] Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> > > 0.026 s <<< FAILURE! - in
> > > org.apache.commons.validator.routines.TimeValidatorTest
> > > [ERROR]
> > > testTimeZone(org.apache.commons.validator.routines.TimeValidatorTest)
> > Time
> > > elapsed: 0 s  <<< FAILURE!
> > > junit.framework.AssertionFailedError: pattern result
> > > at
> > >
> > org.apache.commons.validator.routines.TimeValidatorTest.testTimeZone(TimeValidatorTest.java:224)
> > >
> > > [ERROR] Failures:
> > > [ERROR]   CalendarValidatorTest.testDateTimeStyle:197 validate(A) default
> > > [ERROR]   CalendarValidatorTest.testFormat:215 default
> > > expected:<31/12/[]05> but was:<31/12/[20]05>
> > > [ERROR]   CurrencyValidatorTest.testIntegerValid:142 US negative
> > > expected:<-1234.00> but was:
> > > [ERROR]   CurrencyValidatorTest.testInvalid:121 US wrong negative
> > > [ERROR]   CurrencyValidatorTest.testValid:93 US negative
> > > expected:<-1234.56> but was:
> > > [ERROR]   DateValidatorTest.testDateValidatorMethods:69 validate(A) both
> > > expected: but was:
> > > [ERROR]   TimeValidatorTest.testTimeZone:224 pattern result
> > > [ERROR] Errors:
> > > [ERROR]   CalendarValidatorTest.testCalendarValidatorMethods:70
> > NullPointer
> > > [INFO]
> > > [ERROR] Tests run: 575, Failures: 7, Errors: 1, Skipped: 1
> > >
> > > I also get the same failure on the current Java version 14:
> > >
> > > Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> > > Maven home: C:\Java\apache-maven-3.6.3\bin\..
> > > Java version: 14.0.2, vendor: AdoptOpenJDK, runtime: C:\Program
> > > Files\AdoptOpenJDK\jdk-14.0.2.12-hotspot
> > > Default locale: en_US, platform encoding: Cp1252
> > > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
> >
> > There is a profile 'jdk9-cldr' which is supposed to fix that issue.
> >
> > Personally, I don't think 

Re: [VOTE] Release Apache Commons Validator 1.7 based on RC2

[Gary Gregory]

OR_1_7_RC2>mvn -version && java -version
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: C:\Java\apache-maven-3.6.3\bin\..
Java version: 11.0.7, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\jdk-11.0.7
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
java version "11.0.7" 2020-04-14 LTS
Java(TM) SE Runtime Environment 18.9 (build 11.0.7+8-LTS)
Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11.0.7+8-LTS, mixed mode)

So something needs a fix somewhere, either in the tests or in the code.
Otherwise, I can't take a release tag and patch it and test successfully
since I am not starting from a passing build.

Gary


>
> Likewise with Java 14.
>
> However -P jacoco fails for me with Java 9, 11 and 14:
>
> Plugin org.codehaus.mojo:cobertura-maven-plugin:2.7 or one of its
> dependencies could not be resolved:
> Could not find artifact com.sun:tools:jar:0 at specified path
>
> /Library/Java/JavaVirtualMachines/jdk-9.0.1.jdk/Contents/Home/../lib/tools.jar
>
>
> > [INFO] Running org.apache.commons.validator.routines.TimeValidatorTest
> > [ERROR] Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> > 0.026 s <<< FAILURE! - in
> > org.apache.commons.validator.routines.TimeValidatorTest
> > [ERROR]
> > testTimeZone(org.apache.commons.validator.routines.TimeValidatorTest)
> Time
> > elapsed: 0 s  <<< FAILURE!
> > junit.framework.AssertionFailedError: pattern result
> > at
> >
> org.apache.commons.validator.routines.TimeValidatorTest.testTimeZone(TimeValidatorTest.java:224)
> >
> > [ERROR] Failures:
> > [ERROR]   CalendarValidatorTest.testDateTimeStyle:197 validate(A) default
> > [ERROR]   CalendarValidatorTest.testFormat:215 default
> > expected:<31/12/[]05> but was:<31/12/[20]05>
> > [ERROR]   CurrencyValidatorTest.testIntegerValid:142 US negative
> > expected:<-1234.00> but was:
> > [ERROR]   CurrencyValidatorTest.testInvalid:121 US wrong negative
> > [ERROR]   CurrencyValidatorTest.testValid:93 US negative
> > expected:<-1234.56> but was:
> > [ERROR]   DateValidatorTest.testDateValidatorMethods:69 validate(A) both
> > expected: but was:
> > [ERROR]   TimeValidatorTest.testTimeZone:224 pattern result
> > [ERROR] Errors:
> > [ERROR]   CalendarValidatorTest.testCalendarValidatorMethods:70
> NullPointer
> > [INFO]
> > [ERROR] Tests run: 575, Failures: 7, Errors: 1, Skipped: 1
> >
> > I also get the same failure on the current Java version 14:
> >
> > Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> > Maven home: C:\Java\apache-maven-3.6.3\bin\..
> > Java version: 14.0.2, vendor: AdoptOpenJDK, runtime: C:\Program
> > Files\AdoptOpenJDK\jdk-14.0.2.12-hotspot
> > Default locale: en_US, platform encoding: Cp1252
> > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>
> There is a profile 'jdk9-cldr' which is supposed to fix that issue.
>
> Personally, I don't think it is a blocker.
> Java 9 changed the way locales are handled.
>
> But if it does not work on Windows for some reason then I guess it
> should be mentioned in the release notes
>
> > Gary
> >
> >
> >
> > On Sat, Aug 1, 2020, 09:20 sebb  wrote:
> >
> > > We have fixed quite a few bugs and added some significant enhancements
> > > since Apache Commons Validator 1.6 was released, so I would like to
> > > release Apache Commons Validator 1.7.
> > >
> > > Apache Commons Validator 1.7 RC2 is available for review here:
> > >     https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC2
> > > (svn revision 40802)
> > >
> > > The Git tag VALIDATOR_1_7_RC2 commit for this RC is
> > > 5b75344ace5a8864e3936010524684272145bbcd which you can browse here:
> > >
> > >
> https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=5b75344ace5a8864e3936010524684272145bbcd
> > > You may checkout this tag using:
> > > git clone
> https://gitbox.apache.org/repos/asf/commons-validator.git
> > > --branch
> > > <https://gitbox.apache.org/repos/asf/commons-validator.git--branch>
> > > VALIDATOR_1_7_RC2 VALIDATOR_1_7_RC2
> > >
> > > Maven artifacts are here:
> > >
> > >
> https://repository.apache.org/content/repositories/orgapachecommons-1515/org/apache/commons/comm

Re: [VOTE] Release Apache Commons Validator 1.7 based on RC2

[Gary Gregory]

On Sun, Aug 2, 2020 at 12:00 PM sebb  wrote:

> On Sun, 2 Aug 2020 at 14:13, Gary Gregory  wrote:
> >
> > -1: I do not think we should release when a test breaks on Java 11, an
> LTS
> > version; see below.
> >
> > The release notes mention the wrong version here:
> >
> > "Updates Apache Commons BeanUtils dependency from 1.9.2 to 1.9.3."
> >
> > It should be 1.9.4.
>
> Looks like this was true before the dependency was updated a second time.
>
> > Building from the git tag with "mvn clean install site -P jacoco -P
> japicmp
> > -V".
> >
> > This must be an older style of build because the above downloads the site
> > in a folder called "site-content", not sure why.
> >
> > Then when you look at the site for the build command above, the JApiCmp
> > report contains cobertura instrumentation which is quite confusing.
> >
> > This build should be migrated to JApiCmp from Cobertura.
>
> Don't you mean Jacoco?
>

Yes, sorry:
- Cobertura -> JaCoCo
- Clirr -> JapiCmp
- FindBugs -> SpotBugs

Gary


>
> I thought JApiCmp was more akin to Clirr.
> Or do you mean Clirr?
>
> > Builds OK with:
> >
> > Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> > Maven home: C:\Java\apache-maven-3.6.3\bin\..
> > Java version: 1.8.0_262, vendor: AdoptOpenJDK, runtime: C:\Program
> > Files\AdoptOpenJDK\jdk-8.0.262.10-hotspot\jre
> > Default locale: en_US, platform encoding: Cp1252
> > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
> >
> > But fails on Java 11:
> >
> > Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> > Maven home: C:\Java\apache-maven-3.6.3\bin\..
> > Java version: 11.0.8, vendor: AdoptOpenJDK, runtime: C:\Program
> > Files\AdoptOpenJDK\jdk-11.0.8.10-hotspot
> > Default locale: en_US, platform encoding: Cp1252
> > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>
> Works OK for me with Java 11
>
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> 2018-06-17T19:33:14+01:00)
> Maven home: /opt/apache-maven-3.5.4
> Java version: 11.0.5, vendor: Oracle Corporation, runtime:
> /Library/Java/JavaVirtualMachines/jdk-11.0.5.jdk/Contents/Home
> Default locale: en_GB, platform encoding: UTF-8
> OS name: "mac os x", version: "10.15.6", arch: "x86_64", family: "mac"
>
> Likewise with Java 14.
>
> However -P jacoco fails for me with Java 9, 11 and 14:
>
> Plugin org.codehaus.mojo:cobertura-maven-plugin:2.7 or one of its
> dependencies could not be resolved:
> Could not find artifact com.sun:tools:jar:0 at specified path
>
> /Library/Java/JavaVirtualMachines/jdk-9.0.1.jdk/Contents/Home/../lib/tools.jar
>
>
> > [INFO] Running org.apache.commons.validator.routines.TimeValidatorTest
> > [ERROR] Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> > 0.026 s <<< FAILURE! - in
> > org.apache.commons.validator.routines.TimeValidatorTest
> > [ERROR]
> > testTimeZone(org.apache.commons.validator.routines.TimeValidatorTest)
> Time
> > elapsed: 0 s  <<< FAILURE!
> > junit.framework.AssertionFailedError: pattern result
> > at
> >
> org.apache.commons.validator.routines.TimeValidatorTest.testTimeZone(TimeValidatorTest.java:224)
> >
> > [ERROR] Failures:
> > [ERROR]   CalendarValidatorTest.testDateTimeStyle:197 validate(A) default
> > [ERROR]   CalendarValidatorTest.testFormat:215 default
> > expected:<31/12/[]05> but was:<31/12/[20]05>
> > [ERROR]   CurrencyValidatorTest.testIntegerValid:142 US negative
> > expected:<-1234.00> but was:
> > [ERROR]   CurrencyValidatorTest.testInvalid:121 US wrong negative
> > [ERROR]   CurrencyValidatorTest.testValid:93 US negative
> > expected:<-1234.56> but was:
> > [ERROR]   DateValidatorTest.testDateValidatorMethods:69 validate(A) both
> > expected: but was:
> > [ERROR]   TimeValidatorTest.testTimeZone:224 pattern result
> > [ERROR] Errors:
> > [ERROR]   CalendarValidatorTest.testCalendarValidatorMethods:70
> NullPointer
> > [INFO]
> > [ERROR] Tests run: 575, Failures: 7, Errors: 1, Skipped: 1
> >
> > I also get the same failure on the current Java version 14:
> >
> > Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> > Maven home: C:\Java\apache-maven-3.6.3\bin\..
> > Java version: 14.0.2, vendor: AdoptOpenJDK, runtime: C:\Program
> > Files\AdoptOpenJ

Re: [VOTE] Release Apache Commons Validator 1.7 based on RC2

[sebb]

On Sun, 2 Aug 2020 at 14:13, Gary Gregory  wrote:
>
> -1: I do not think we should release when a test breaks on Java 11, an LTS
> version; see below.
>
> The release notes mention the wrong version here:
>
> "Updates Apache Commons BeanUtils dependency from 1.9.2 to 1.9.3."
>
> It should be 1.9.4.

Looks like this was true before the dependency was updated a second time.

> Building from the git tag with "mvn clean install site -P jacoco -P japicmp
> -V".
>
> This must be an older style of build because the above downloads the site
> in a folder called "site-content", not sure why.
>
> Then when you look at the site for the build command above, the JApiCmp
> report contains cobertura instrumentation which is quite confusing.
>
> This build should be migrated to JApiCmp from Cobertura.

Don't you mean Jacoco?

I thought JApiCmp was more akin to Clirr.
Or do you mean Clirr?

> Builds OK with:
>
> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: C:\Java\apache-maven-3.6.3\bin\..
> Java version: 1.8.0_262, vendor: AdoptOpenJDK, runtime: C:\Program
> Files\AdoptOpenJDK\jdk-8.0.262.10-hotspot\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>
> But fails on Java 11:
>
> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: C:\Java\apache-maven-3.6.3\bin\..
> Java version: 11.0.8, vendor: AdoptOpenJDK, runtime: C:\Program
> Files\AdoptOpenJDK\jdk-11.0.8.10-hotspot
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Works OK for me with Java 11

Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
2018-06-17T19:33:14+01:00)
Maven home: /opt/apache-maven-3.5.4
Java version: 11.0.5, vendor: Oracle Corporation, runtime:
/Library/Java/JavaVirtualMachines/jdk-11.0.5.jdk/Contents/Home
Default locale: en_GB, platform encoding: UTF-8
OS name: "mac os x", version: "10.15.6", arch: "x86_64", family: "mac"

Likewise with Java 14.

However -P jacoco fails for me with Java 9, 11 and 14:

Plugin org.codehaus.mojo:cobertura-maven-plugin:2.7 or one of its
dependencies could not be resolved:
Could not find artifact com.sun:tools:jar:0 at specified path
/Library/Java/JavaVirtualMachines/jdk-9.0.1.jdk/Contents/Home/../lib/tools.jar


> [INFO] Running org.apache.commons.validator.routines.TimeValidatorTest
> [ERROR] Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 0.026 s <<< FAILURE! - in
> org.apache.commons.validator.routines.TimeValidatorTest
> [ERROR]
> testTimeZone(org.apache.commons.validator.routines.TimeValidatorTest)  Time
> elapsed: 0 s  <<< FAILURE!
> junit.framework.AssertionFailedError: pattern result
> at
> org.apache.commons.validator.routines.TimeValidatorTest.testTimeZone(TimeValidatorTest.java:224)
>
> [ERROR] Failures:
> [ERROR]   CalendarValidatorTest.testDateTimeStyle:197 validate(A) default
> [ERROR]   CalendarValidatorTest.testFormat:215 default
> expected:<31/12/[]05> but was:<31/12/[20]05>
> [ERROR]   CurrencyValidatorTest.testIntegerValid:142 US negative
> expected:<-1234.00> but was:
> [ERROR]   CurrencyValidatorTest.testInvalid:121 US wrong negative
> [ERROR]   CurrencyValidatorTest.testValid:93 US negative
> expected:<-1234.56> but was:
> [ERROR]   DateValidatorTest.testDateValidatorMethods:69 validate(A) both
> expected: but was:
> [ERROR]   TimeValidatorTest.testTimeZone:224 pattern result
> [ERROR] Errors:
> [ERROR]   CalendarValidatorTest.testCalendarValidatorMethods:70 NullPointer
> [INFO]
> [ERROR] Tests run: 575, Failures: 7, Errors: 1, Skipped: 1
>
> I also get the same failure on the current Java version 14:
>
> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: C:\Java\apache-maven-3.6.3\bin\..
> Java version: 14.0.2, vendor: AdoptOpenJDK, runtime: C:\Program
> Files\AdoptOpenJDK\jdk-14.0.2.12-hotspot
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

There is a profile 'jdk9-cldr' which is supposed to fix that issue.

Personally, I don't think it is a blocker.
Java 9 changed the way locales are handled.

But if it does not work on Windows for some reason then I guess it
should be mentioned in the release notes

> Gary
>
>
>
> On Sat, Aug 1, 2020, 09:20 sebb  wrote:
>
> > We have fixed quite a few bugs and added some significant enhancements
&

Re: [VOTE] Release Apache Commons Validator 1.7 based on RC2

[Gilles Sadowski]

Le dim. 2 août 2020 à 15:37, Rob Tompkins  a écrit :
>
>
>
> > On Aug 2, 2020, at 9:32 AM, Gilles Sadowski  wrote:
> >
> > Le dim. 2 août 2020 à 15:13, Gary Gregory  a écrit 
> > :
> >>
> >> -1: I do not think we should release when a test breaks on Java 11, an LTS
> >> version; see below.
> >
> > If everybody agrees, doesn't this become a Commons' *rule*
> > that could be taken off the RM's shoulders?
> > I mean, by setting up appropriate "release barrier" Jenkins jobs
> > (for all the components), one should not need to run locally at
> > release time for all the possible combinations (OS + JDK).
> >
>
> Please don’t use the Apache Jenkins instance here. It is so clugey in its 
> integration with the github README.md

I've absolutely no clue how the two relate.
Could you please be specific on what should be put in place
in order to satisfy the requirement?

Gilles

P.S. This discussion about replacing Jenkins should probably
go in a new thread.

>
> This is just my 2 cents though. You may take it or leave it as you see fit
>
> -Rob
>
> >> [...]

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Apache Commons Validator 1.7 based on RC2

[Gary Gregory]

On Sun, Aug 2, 2020 at 9:32 AM Gilles Sadowski  wrote:

> Le dim. 2 août 2020 à 15:13, Gary Gregory  a
> écrit :
> >
> > -1: I do not think we should release when a test breaks on Java 11, an
> LTS
> > version; see below.
>
> If everybody agrees, doesn't this become a Commons' *rule*
> that could be taken off the RM's shoulders?
> I mean, by setting up appropriate "release barrier" Jenkins jobs
> (for all the components), one should not need to run locally at
> release time for all the possible combinations (OS + JDK).
>
> > The release notes mention the wrong version here:
> >
> > "Updates Apache Commons BeanUtils dependency from 1.9.2 to 1.9.3."
> >
> > It should be 1.9.4.
> >
> > Building from the git tag with "mvn clean install site -P jacoco -P
> japicmp
> > -V".
> >
> > This must be an older style of build because the above downloads the site
> > in a folder called "site-content", not sure why.
>
> Recurrent issue: It happens when that directory does not exist.
> IIRC, this "feature" is triggered in CP.  It should probably be fixed
> as, to my knowledge, it has only ever caused trouble (i.e. unwanted
> SVN traffic).
> Some components' POM are customized (thanks to Alex) so that
> it won't happen.
>
> > Then when you look at the site for the build command above, the JApiCmp
> > report contains cobertura instrumentation which is quite confusing.
> >
> > This build should be migrated to JApiCmp from Cobertura.
>
> s/JApiCmp/Jacoco/
>

Righ!

Gary


> (?)
>
> Gilles
>
> >
> > Builds OK with:
> >
> > Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> > Maven home: C:\Java\apache-maven-3.6.3\bin\..
> > Java version: 1.8.0_262, vendor: AdoptOpenJDK, runtime: C:\Program
> > Files\AdoptOpenJDK\jdk-8.0.262.10-hotspot\jre
> > Default locale: en_US, platform encoding: Cp1252
> > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
> >
> > But fails on Java 11:
> >
> > Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> > Maven home: C:\Java\apache-maven-3.6.3\bin\..
> > Java version: 11.0.8, vendor: AdoptOpenJDK, runtime: C:\Program
> > Files\AdoptOpenJDK\jdk-11.0.8.10-hotspot
> > Default locale: en_US, platform encoding: Cp1252
> > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
> >
> > [INFO] Running org.apache.commons.validator.routines.TimeValidatorTest
> > [ERROR] Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> > 0.026 s <<< FAILURE! - in
> > org.apache.commons.validator.routines.TimeValidatorTest
> > [ERROR]
> > testTimeZone(org.apache.commons.validator.routines.TimeValidatorTest)
> Time
> > elapsed: 0 s  <<< FAILURE!
> > junit.framework.AssertionFailedError: pattern result
> > at
> >
> org.apache.commons.validator.routines.TimeValidatorTest.testTimeZone(TimeValidatorTest.java:224)
> >
> > [ERROR] Failures:
> > [ERROR]   CalendarValidatorTest.testDateTimeStyle:197 validate(A) default
> > [ERROR]   CalendarValidatorTest.testFormat:215 default
> > expected:<31/12/[]05> but was:<31/12/[20]05>
> > [ERROR]   CurrencyValidatorTest.testIntegerValid:142 US negative
> > expected:<-1234.00> but was:
> > [ERROR]   CurrencyValidatorTest.testInvalid:121 US wrong negative
> > [ERROR]   CurrencyValidatorTest.testValid:93 US negative
> > expected:<-1234.56> but was:
> > [ERROR]   DateValidatorTest.testDateValidatorMethods:69 validate(A) both
> > expected: but was:
> > [ERROR]   TimeValidatorTest.testTimeZone:224 pattern result
> > [ERROR] Errors:
> > [ERROR]   CalendarValidatorTest.testCalendarValidatorMethods:70
> NullPointer
> > [INFO]
> > [ERROR] Tests run: 575, Failures: 7, Errors: 1, Skipped: 1
> >
> > I also get the same failure on the current Java version 14:
> >
> > Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> > Maven home: C:\Java\apache-maven-3.6.3\bin\..
> > Java version: 14.0.2, vendor: AdoptOpenJDK, runtime: C:\Program
> > Files\AdoptOpenJDK\jdk-14.0.2.12-hotspot
> > Default locale: en_US, platform encoding: Cp1252
> > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
> >
> > Gary
> >
> >
> >
> > On Sat, Aug 1, 2020, 09:20 sebb  wrote:
> >
> > > We have fixed quite a f

Re: [VOTE] Release Apache Commons Validator 1.7 based on RC2

[Rob Tompkins]

> On Aug 2, 2020, at 9:32 AM, Gilles Sadowski  wrote:
> 
> Le dim. 2 août 2020 à 15:13, Gary Gregory  a écrit :
>> 
>> -1: I do not think we should release when a test breaks on Java 11, an LTS
>> version; see below.
> 
> If everybody agrees, doesn't this become a Commons' *rule*
> that could be taken off the RM's shoulders?
> I mean, by setting up appropriate "release barrier" Jenkins jobs
> (for all the components), one should not need to run locally at
> release time for all the possible combinations (OS + JDK).
> 

Please don’t use the Apache Jenkins instance here. It is so clugey in its 
integration with the github README.md

This is just my 2 cents though. You may take it or leave it as you see fit

-Rob

>> The release notes mention the wrong version here:
>> 
>> "Updates Apache Commons BeanUtils dependency from 1.9.2 to 1.9.3."
>> 
>> It should be 1.9.4.
>> 
>> Building from the git tag with "mvn clean install site -P jacoco -P japicmp
>> -V".
>> 
>> This must be an older style of build because the above downloads the site
>> in a folder called "site-content", not sure why.
> 
> Recurrent issue: It happens when that directory does not exist.
> IIRC, this "feature" is triggered in CP.  It should probably be fixed
> as, to my knowledge, it has only ever caused trouble (i.e. unwanted
> SVN traffic).
> Some components' POM are customized (thanks to Alex) so that
> it won't happen.
> 
>> Then when you look at the site for the build command above, the JApiCmp
>> report contains cobertura instrumentation which is quite confusing.
>> 
>> This build should be migrated to JApiCmp from Cobertura.
> 
> s/JApiCmp/Jacoco/
> (?)
> 
> Gilles
> 
>> 
>> Builds OK with:
>> 
>> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
>> Maven home: C:\Java\apache-maven-3.6.3\bin\..
>> Java version: 1.8.0_262, vendor: AdoptOpenJDK, runtime: C:\Program
>> Files\AdoptOpenJDK\jdk-8.0.262.10-hotspot\jre
>> Default locale: en_US, platform encoding: Cp1252
>> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>> 
>> But fails on Java 11:
>> 
>> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
>> Maven home: C:\Java\apache-maven-3.6.3\bin\..
>> Java version: 11.0.8, vendor: AdoptOpenJDK, runtime: C:\Program
>> Files\AdoptOpenJDK\jdk-11.0.8.10-hotspot
>> Default locale: en_US, platform encoding: Cp1252
>> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>> 
>> [INFO] Running org.apache.commons.validator.routines.TimeValidatorTest
>> [ERROR] Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
>> 0.026 s <<< FAILURE! - in
>> org.apache.commons.validator.routines.TimeValidatorTest
>> [ERROR]
>> testTimeZone(org.apache.commons.validator.routines.TimeValidatorTest)  Time
>> elapsed: 0 s  <<< FAILURE!
>> junit.framework.AssertionFailedError: pattern result
>>at
>> org.apache.commons.validator.routines.TimeValidatorTest.testTimeZone(TimeValidatorTest.java:224)
>> 
>> [ERROR] Failures:
>> [ERROR]   CalendarValidatorTest.testDateTimeStyle:197 validate(A) default
>> [ERROR]   CalendarValidatorTest.testFormat:215 default
>> expected:<31/12/[]05> but was:<31/12/[20]05>
>> [ERROR]   CurrencyValidatorTest.testIntegerValid:142 US negative
>> expected:<-1234.00> but was:
>> [ERROR]   CurrencyValidatorTest.testInvalid:121 US wrong negative
>> [ERROR]   CurrencyValidatorTest.testValid:93 US negative
>> expected:<-1234.56> but was:
>> [ERROR]   DateValidatorTest.testDateValidatorMethods:69 validate(A) both
>> expected: but was:
>> [ERROR]   TimeValidatorTest.testTimeZone:224 pattern result
>> [ERROR] Errors:
>> [ERROR]   CalendarValidatorTest.testCalendarValidatorMethods:70 NullPointer
>> [INFO]
>> [ERROR] Tests run: 575, Failures: 7, Errors: 1, Skipped: 1
>> 
>> I also get the same failure on the current Java version 14:
>> 
>> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
>> Maven home: C:\Java\apache-maven-3.6.3\bin\..
>> Java version: 14.0.2, vendor: AdoptOpenJDK, runtime: C:\Program
>> Files\AdoptOpenJDK\jdk-14.0.2.12-hotspot
>> Default locale: en_US, platform encoding: Cp1252
>> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>> 
>> Gary
>> 
>> 
>&

Re: [VOTE] Release Apache Commons Validator 1.7 based on RC2

[Gilles Sadowski]

Le dim. 2 août 2020 à 15:13, Gary Gregory  a écrit :
>
> -1: I do not think we should release when a test breaks on Java 11, an LTS
> version; see below.

If everybody agrees, doesn't this become a Commons' *rule*
that could be taken off the RM's shoulders?
I mean, by setting up appropriate "release barrier" Jenkins jobs
(for all the components), one should not need to run locally at
release time for all the possible combinations (OS + JDK).

> The release notes mention the wrong version here:
>
> "Updates Apache Commons BeanUtils dependency from 1.9.2 to 1.9.3."
>
> It should be 1.9.4.
>
> Building from the git tag with "mvn clean install site -P jacoco -P japicmp
> -V".
>
> This must be an older style of build because the above downloads the site
> in a folder called "site-content", not sure why.

Recurrent issue: It happens when that directory does not exist.
IIRC, this "feature" is triggered in CP.  It should probably be fixed
as, to my knowledge, it has only ever caused trouble (i.e. unwanted
SVN traffic).
Some components' POM are customized (thanks to Alex) so that
it won't happen.

> Then when you look at the site for the build command above, the JApiCmp
> report contains cobertura instrumentation which is quite confusing.
>
> This build should be migrated to JApiCmp from Cobertura.

s/JApiCmp/Jacoco/
(?)

Gilles

>
> Builds OK with:
>
> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: C:\Java\apache-maven-3.6.3\bin\..
> Java version: 1.8.0_262, vendor: AdoptOpenJDK, runtime: C:\Program
> Files\AdoptOpenJDK\jdk-8.0.262.10-hotspot\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>
> But fails on Java 11:
>
> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: C:\Java\apache-maven-3.6.3\bin\..
> Java version: 11.0.8, vendor: AdoptOpenJDK, runtime: C:\Program
> Files\AdoptOpenJDK\jdk-11.0.8.10-hotspot
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>
> [INFO] Running org.apache.commons.validator.routines.TimeValidatorTest
> [ERROR] Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 0.026 s <<< FAILURE! - in
> org.apache.commons.validator.routines.TimeValidatorTest
> [ERROR]
> testTimeZone(org.apache.commons.validator.routines.TimeValidatorTest)  Time
> elapsed: 0 s  <<< FAILURE!
> junit.framework.AssertionFailedError: pattern result
> at
> org.apache.commons.validator.routines.TimeValidatorTest.testTimeZone(TimeValidatorTest.java:224)
>
> [ERROR] Failures:
> [ERROR]   CalendarValidatorTest.testDateTimeStyle:197 validate(A) default
> [ERROR]   CalendarValidatorTest.testFormat:215 default
> expected:<31/12/[]05> but was:<31/12/[20]05>
> [ERROR]   CurrencyValidatorTest.testIntegerValid:142 US negative
> expected:<-1234.00> but was:
> [ERROR]   CurrencyValidatorTest.testInvalid:121 US wrong negative
> [ERROR]   CurrencyValidatorTest.testValid:93 US negative
> expected:<-1234.56> but was:
> [ERROR]   DateValidatorTest.testDateValidatorMethods:69 validate(A) both
> expected: but was:
> [ERROR]   TimeValidatorTest.testTimeZone:224 pattern result
> [ERROR] Errors:
> [ERROR]   CalendarValidatorTest.testCalendarValidatorMethods:70 NullPointer
> [INFO]
> [ERROR] Tests run: 575, Failures: 7, Errors: 1, Skipped: 1
>
> I also get the same failure on the current Java version 14:
>
> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: C:\Java\apache-maven-3.6.3\bin\..
> Java version: 14.0.2, vendor: AdoptOpenJDK, runtime: C:\Program
> Files\AdoptOpenJDK\jdk-14.0.2.12-hotspot
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>
> Gary
>
>
>
> On Sat, Aug 1, 2020, 09:20 sebb  wrote:
>
> > We have fixed quite a few bugs and added some significant enhancements
> > since Apache Commons Validator 1.6 was released, so I would like to
> > release Apache Commons Validator 1.7.
> >
> > Apache Commons Validator 1.7 RC2 is available for review here:
> > https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC2
> > (svn revision 40802)
> >
> > The Git tag VALIDATOR_1_7_RC2 commit for this RC is
> > 5b75344ace5a8864e3936010524684272145bbcd which you can browse here:
> >
> > https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=5b75344ace5a

Re: [VOTE] Release Apache Commons Validator 1.7 based on RC2

[Gary Gregory]

-1: I do not think we should release when a test breaks on Java 11, an LTS
version; see below.

The release notes mention the wrong version here:

"Updates Apache Commons BeanUtils dependency from 1.9.2 to 1.9.3."

It should be 1.9.4.

Building from the git tag with "mvn clean install site -P jacoco -P japicmp
-V".

This must be an older style of build because the above downloads the site
in a folder called "site-content", not sure why.

Then when you look at the site for the build command above, the JApiCmp
report contains cobertura instrumentation which is quite confusing.

This build should be migrated to JApiCmp from Cobertura.

Builds OK with:

Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: C:\Java\apache-maven-3.6.3\bin\..
Java version: 1.8.0_262, vendor: AdoptOpenJDK, runtime: C:\Program
Files\AdoptOpenJDK\jdk-8.0.262.10-hotspot\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

But fails on Java 11:

Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: C:\Java\apache-maven-3.6.3\bin\..
Java version: 11.0.8, vendor: AdoptOpenJDK, runtime: C:\Program
Files\AdoptOpenJDK\jdk-11.0.8.10-hotspot
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

[INFO] Running org.apache.commons.validator.routines.TimeValidatorTest
[ERROR] Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
0.026 s <<< FAILURE! - in
org.apache.commons.validator.routines.TimeValidatorTest
[ERROR]
testTimeZone(org.apache.commons.validator.routines.TimeValidatorTest)  Time
elapsed: 0 s  <<< FAILURE!
junit.framework.AssertionFailedError: pattern result
at
org.apache.commons.validator.routines.TimeValidatorTest.testTimeZone(TimeValidatorTest.java:224)

[ERROR] Failures:
[ERROR]   CalendarValidatorTest.testDateTimeStyle:197 validate(A) default
[ERROR]   CalendarValidatorTest.testFormat:215 default
expected:<31/12/[]05> but was:<31/12/[20]05>
[ERROR]   CurrencyValidatorTest.testIntegerValid:142 US negative
expected:<-1234.00> but was:
[ERROR]   CurrencyValidatorTest.testInvalid:121 US wrong negative
[ERROR]   CurrencyValidatorTest.testValid:93 US negative
expected:<-1234.56> but was:
[ERROR]   DateValidatorTest.testDateValidatorMethods:69 validate(A) both
expected: but was:
[ERROR]   TimeValidatorTest.testTimeZone:224 pattern result
[ERROR] Errors:
[ERROR]   CalendarValidatorTest.testCalendarValidatorMethods:70 NullPointer
[INFO]
[ERROR] Tests run: 575, Failures: 7, Errors: 1, Skipped: 1

I also get the same failure on the current Java version 14:

Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: C:\Java\apache-maven-3.6.3\bin\..
Java version: 14.0.2, vendor: AdoptOpenJDK, runtime: C:\Program
Files\AdoptOpenJDK\jdk-14.0.2.12-hotspot
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Gary



On Sat, Aug 1, 2020, 09:20 sebb  wrote:

> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons Validator 1.6 was released, so I would like to
> release Apache Commons Validator 1.7.
>
> Apache Commons Validator 1.7 RC2 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC2
> (svn revision 40802)
>
> The Git tag VALIDATOR_1_7_RC2 commit for this RC is
> 5b75344ace5a8864e3936010524684272145bbcd which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=5b75344ace5a8864e3936010524684272145bbcd
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-validator.git
> --branch
> <https://gitbox.apache.org/repos/asf/commons-validator.git--branch>
> VALIDATOR_1_7_RC2 VALIDATOR_1_7_RC2
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1515/org/apache/commons/commons-validator/1.7/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Sat Aug 01 13:37:45 BST 2020
>
> commons-validator-1.7-bin.tar.gz=c64463b7f2c10cf826db37b6b5b89893e1ac5add56fb74bf546eb43f9efef1381173abdf695a601fcef1a604e116acc3723876e9318304714003b7db00c9ca74
>
> commons-validator-1.7-bin.zip=41918449e823fa1ae2fd166808e014bf04913a9a14e5645b2f4d28a763e6fe5cabcae1d771d8668b48e4bfea0e2d94d594766cb17889cf0d4c73b99fe49d6fe3
>
> commons-validator-1.7-javadoc.jar=c0f3c56deca2e1449efe76f738ceafcbe293199ab4d7d641855caff4f2c06ed51756d1a2bcb9011a9ff7d8fac6243f5ed26b5cbb490625508b705c9bf89722a0
>
> commons-validator-1.7-javadoc.jar.asc=dcf5281336e3613b556f3b72899a0205

Re: [VOTE] Release Apache Commons Validator 1.7 based on RC2

[Bruno P. Kinoshita]

  [x] +1 Release these artifacts

Build successfully with JDK 8, Ubuntu LTS, Maven 3.5, from tag with `mvn clean 
test install`.

Site reports look good. Had a look around files in dist area checking license, 
structure, release-notes, etc. Everything looks OK.

Checked signatures of the dist area files, and of the Maven repository files, 
found no issues.

Thanks for RM'ing.

Bruno




On Sunday, 2 August 2020, 1:20:05 am NZST, sebb  wrote: 





We have fixed quite a few bugs and added some significant enhancements
since Apache Commons Validator 1.6 was released, so I would like to
release Apache Commons Validator 1.7.

Apache Commons Validator 1.7 RC2 is available for review here:
    https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC2
(svn revision 40802)

The Git tag VALIDATOR_1_7_RC2 commit for this RC is
5b75344ace5a8864e3936010524684272145bbcd which you can browse here:
    
https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=5b75344ace5a8864e3936010524684272145bbcd
You may checkout this tag using:
    git clone https://gitbox.apache.org/repos/asf/commons-validator.git
--branch VALIDATOR_1_7_RC2 VALIDATOR_1_7_RC2

Maven artifacts are here:
    
https://repository.apache.org/content/repositories/orgapachecommons-1515/org/apache/commons/commons-validator/1.7/

These are the artifacts and their hashes:

#Release SHA-512s
#Sat Aug 01 13:37:45 BST 2020
commons-validator-1.7-bin.tar.gz=c64463b7f2c10cf826db37b6b5b89893e1ac5add56fb74bf546eb43f9efef1381173abdf695a601fcef1a604e116acc3723876e9318304714003b7db00c9ca74
commons-validator-1.7-bin.zip=41918449e823fa1ae2fd166808e014bf04913a9a14e5645b2f4d28a763e6fe5cabcae1d771d8668b48e4bfea0e2d94d594766cb17889cf0d4c73b99fe49d6fe3
commons-validator-1.7-javadoc.jar=c0f3c56deca2e1449efe76f738ceafcbe293199ab4d7d641855caff4f2c06ed51756d1a2bcb9011a9ff7d8fac6243f5ed26b5cbb490625508b705c9bf89722a0
commons-validator-1.7-javadoc.jar.asc=dcf5281336e3613b556f3b72899a0205d8a27b1a6b83e036008ca8d16a7b03c893e0b595573e039def9255b54dde8086bbc7f6af47b98dfe67e196d0e91c09aa
commons-validator-1.7-sources.jar=8e7699b03916b76623518525fc8bdf54ebf9dea15be68c6dd709acaced44ee4fce9badd57273504b304ba601e81fbdb71ab36b6234291b8c725d782ab49d976b
commons-validator-1.7-src.tar.gz=a9f3242776757b05da59913ff54491d8cf71c7229e6bb9eb6fa52a8a910bc2fd52eafe582a5378e0c0bf14ef115b20eb3734f6fc1c5233c56095d960f97c6124
commons-validator-1.7-src.zip=8329b54c9cb8175126958453b0d819baa5d0906736c13e1118f011cdd15671b0cb7519c97426e11147e339950adfaa9fcb50bbecbfc283b39adf1976fe2bdf39
commons-validator-1.7-test-sources.jar=86fb0021b9ffd048fa28ed67418b78780534988f17da472c62dba758f8a7443a7dfbb00df4fa74e59d951f7e06e5af7fe4e303400e8e9870d6f6d18b65ca5714
commons-validator-1.7-tests.jar=2f7521b8ccdecb8cc6d93da17bef628a82a3ddcc370c938549d5659de136ef8d39ccb9e5ea430487575d850805a299d895c27e619ed862342765fe191f1ec9f4


I have tested this with ***'mvn clean install site'*** using:

Maven home: /opt/apache-maven-3.5.4
Java version: 1.8.0_231, vendor: Oracle Corporation, runtime:
/Library/Java/JavaVirtualMachines/jdk1.8.0_231.jdk/Contents/Home/jre
Default locale: en_GB, platform encoding: UTF-8
OS name: "mac os x", version: "10.15.6", arch: "x86_64", family: "mac"

Details of changes since 1.6 are in the release notes:
    
https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC2/RELEASE-NOTES.txt
    
https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC2/site/changes-report.html

Site:
    
https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC2/site/index.html
    (note some *relative* links are broken and the 1.7 directories are
not yet created - these will be OK once the site is deployed.)

CLIRR Report (compared to 1.6):
    
https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC2/site/clirr-report.html

JApiCmp Report (compared to 1.6):
    
https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC2/site/japicmp.html

RAT Report:
    
https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC2/site/rat-report.html

KEYS:
  https://www.apache.org/dist/commons/KEYS

Please review the release candidate and vote.
This vote will close no sooner than 72 hours from now.

  [ ] +1 Release these artifacts
  [ ] +0 OK, but...
  [ ] -0 OK, but really should fix...
  [ ] -1 I oppose this release because...

Thank you,

Sebb,
Release Manager (using key 4FAD5F62)

For following is intended as a helper and refresher for reviewers.

Validating a release candidate
==

These guidelines are NOT complete.

Requirements: Git, Java, Maven.

You can validate a release from a release candidate (RC) tag as follows.

1) Clone and checkout the RC tag

git clone https://gitbox.apache.org/repos/asf/commons-validator.git
--branch VALIDATOR_1_7_RC2 VALIDATOR_1_7_RC2
cd VALIDATOR_1_7_RC2

2) Check Apache licenses

This step is not required if the site includes a RAT report page which
you 

Re: [VOTE] Release Apache Commons Validator 1.7 based on RC2

[sebb]

On Sat, 1 Aug 2020 at 14:19, sebb  wrote:
...
>
> Maven artifacts are here:
> 
> https://repository.apache.org/content/repositories/orgapachecommons-1515/org/apache/commons/commons-validator/1.7/

That should be
https://repository.apache.org/content/repositories/orgapachecommons-1515/commons-validator/commons-validator/1.7/

...

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[VOTE] Release Apache Commons Validator 1.7 based on RC2

[sebb]

We have fixed quite a few bugs and added some significant enhancements
since Apache Commons Validator 1.6 was released, so I would like to
release Apache Commons Validator 1.7.

Apache Commons Validator 1.7 RC2 is available for review here:
https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC2
(svn revision 40802)

The Git tag VALIDATOR_1_7_RC2 commit for this RC is
5b75344ace5a8864e3936010524684272145bbcd which you can browse here:

https://gitbox.apache.org/repos/asf?p=commons-validator.git;a=commit;h=5b75344ace5a8864e3936010524684272145bbcd
You may checkout this tag using:
git clone https://gitbox.apache.org/repos/asf/commons-validator.git
--branch VALIDATOR_1_7_RC2 VALIDATOR_1_7_RC2

Maven artifacts are here:

https://repository.apache.org/content/repositories/orgapachecommons-1515/org/apache/commons/commons-validator/1.7/

These are the artifacts and their hashes:

#Release SHA-512s
#Sat Aug 01 13:37:45 BST 2020
commons-validator-1.7-bin.tar.gz=c64463b7f2c10cf826db37b6b5b89893e1ac5add56fb74bf546eb43f9efef1381173abdf695a601fcef1a604e116acc3723876e9318304714003b7db00c9ca74
commons-validator-1.7-bin.zip=41918449e823fa1ae2fd166808e014bf04913a9a14e5645b2f4d28a763e6fe5cabcae1d771d8668b48e4bfea0e2d94d594766cb17889cf0d4c73b99fe49d6fe3
commons-validator-1.7-javadoc.jar=c0f3c56deca2e1449efe76f738ceafcbe293199ab4d7d641855caff4f2c06ed51756d1a2bcb9011a9ff7d8fac6243f5ed26b5cbb490625508b705c9bf89722a0
commons-validator-1.7-javadoc.jar.asc=dcf5281336e3613b556f3b72899a0205d8a27b1a6b83e036008ca8d16a7b03c893e0b595573e039def9255b54dde8086bbc7f6af47b98dfe67e196d0e91c09aa
commons-validator-1.7-sources.jar=8e7699b03916b76623518525fc8bdf54ebf9dea15be68c6dd709acaced44ee4fce9badd57273504b304ba601e81fbdb71ab36b6234291b8c725d782ab49d976b
commons-validator-1.7-src.tar.gz=a9f3242776757b05da59913ff54491d8cf71c7229e6bb9eb6fa52a8a910bc2fd52eafe582a5378e0c0bf14ef115b20eb3734f6fc1c5233c56095d960f97c6124
commons-validator-1.7-src.zip=8329b54c9cb8175126958453b0d819baa5d0906736c13e1118f011cdd15671b0cb7519c97426e11147e339950adfaa9fcb50bbecbfc283b39adf1976fe2bdf39
commons-validator-1.7-test-sources.jar=86fb0021b9ffd048fa28ed67418b78780534988f17da472c62dba758f8a7443a7dfbb00df4fa74e59d951f7e06e5af7fe4e303400e8e9870d6f6d18b65ca5714
commons-validator-1.7-tests.jar=2f7521b8ccdecb8cc6d93da17bef628a82a3ddcc370c938549d5659de136ef8d39ccb9e5ea430487575d850805a299d895c27e619ed862342765fe191f1ec9f4


I have tested this with ***'mvn clean install site'*** using:

Maven home: /opt/apache-maven-3.5.4
Java version: 1.8.0_231, vendor: Oracle Corporation, runtime:
/Library/Java/JavaVirtualMachines/jdk1.8.0_231.jdk/Contents/Home/jre
Default locale: en_GB, platform encoding: UTF-8
OS name: "mac os x", version: "10.15.6", arch: "x86_64", family: "mac"

Details of changes since 1.6 are in the release notes:
    
https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC2/RELEASE-NOTES.txt
    
https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC2/site/changes-report.html

Site:
    
https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC2/site/index.html
(note some *relative* links are broken and the 1.7 directories are
not yet created - these will be OK once the site is deployed.)

CLIRR Report (compared to 1.6):
    
https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC2/site/clirr-report.html

JApiCmp Report (compared to 1.6):
    
https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC2/site/japicmp.html

RAT Report:
    
https://dist.apache.org/repos/dist/dev/commons/validator/1.7-RC2/site/rat-report.html

KEYS:
  https://www.apache.org/dist/commons/KEYS

Please review the release candidate and vote.
This vote will close no sooner than 72 hours from now.

  [ ] +1 Release these artifacts
  [ ] +0 OK, but...
  [ ] -0 OK, but really should fix...
  [ ] -1 I oppose this release because...

Thank you,

Sebb,
Release Manager (using key 4FAD5F62)

For following is intended as a helper and refresher for reviewers.

Validating a release candidate
==

These guidelines are NOT complete.

Requirements: Git, Java, Maven.

You can validate a release from a release candidate (RC) tag as follows.

1) Clone and checkout the RC tag

git clone https://gitbox.apache.org/repos/asf/commons-validator.git
--branch VALIDATOR_1_7_RC2 VALIDATOR_1_7_RC2
cd VALIDATOR_1_7_RC2

2) Check Apache licenses

This step is not required if the site includes a RAT report page which
you then must check.

mvn apache-rat:check

3) Check binary compatibility

Older components still use Apache Clirr:

This step is not required if the site includes a Clirr report page
which you then must check.

mvn clirr:check

Newer components use JApiCmp with the japicmp Maven Profile:

This step is not required if the site includes a JApiCmp report page
which you then must check.

mvn install -DskipTests -P japicmp japicmp:cmp

4) Build the package

mvn -V clean 

Re: Commons Validator

[sebb]

On Sat, 11 May 2019 at 08:30, Andre van der Wal  wrote:
>
> Hi,
>
> When can we expect a new release of the validator?

When someone decides to release it...

> New email domains we
> need were added in April 2017 but the latest release is still from Feb 2017.

The list changes too frequently to be able to keep up with the changes.

You can update the GENERIC_TLDS array programmatically, so long as you
do it before first usage.

http://commons.apache.org/proper/commons-validator/apidocs/org/apache/commons/validator/routines/DomainValidator.html#updateTLDOverride(org.apache.commons.validator.routines.DomainValidator.ArrayType,%20java.lang.String[])

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Commons Validator

[Andre van der Wal]

Hi,

When can we expect a new release of the validator? New email domains we
need were added in April 2017 but the latest release is still from Feb 2017.

[GitHub] commons-validator pull request #16: ISBNValidator Javadoc updated with 979 p...

[alcole]

GitHub user alcole opened a pull request:

https://github.com/apache/commons-validator/pull/16

ISBNValidator Javadoc updated with 979 prefix explanation



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alcole/commons-validator 
Alcole/VALIDATOR-447/ISBN-979-prefix-docs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-validator/pull/16.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #16


commit 66376f85a43ec653ca73b244545e91dfc7958142
Author: alex-cole 
Date:   2018-09-18T16:20:32Z

ISBNValidator Javadoc updated with 979 prefix explanation




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-validator pull request #14: VALIDATOR-446 ISSN extraction from EAN-1...

[alcole]

Github user alcole closed the pull request at:

https://github.com/apache/commons-validator/pull/14


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-validator pull request #15: VALIDATOR-424 LuhnCheckDigit extends Mod...

[alcole]

GitHub user alcole opened a pull request:

https://github.com/apache/commons-validator/pull/15

VALIDATOR-424 LuhnCheckDigit extends ModulusCheckDigit



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alcole/commons-validator 
alcole/VALIDATOR-424/Luhn-ISIN

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-validator/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #15


commit 79dd80dc0ac2ba1d030f6c109137ebe476857354
Author: alex-cole 
Date:   2018-08-22T01:34:58Z

VALIDATOR-424 LuhnCheckDigit extends ModulusCheckDigit




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-validator pull request #14: VALIDATOR-446 ISSN extraction from EAN-1...

[alcole]

GitHub user alcole opened a pull request:

https://github.com/apache/commons-validator/pull/14

VALIDATOR-446 ISSN extraction from EAN-13

added extract to ISSNValidator and test cases

also included feedback re: tidied whitespace and static import

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alcole/commons-validator 
alcole/VALIDATOR-446/issn-ean13

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-validator/pull/14.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #14


commit 36dab0147b5e23f3cae75e8b620d27915426ec86
Author: alex-cole 
Date:   2018-08-21T19:41:16Z

VALIDATOR-446 ISSN extraction from EAN-13

added extract to ISSNValidator and test cases




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-validator pull request #13: validator-446

[alcole]

GitHub user alcole opened a pull request:

https://github.com/apache/commons-validator/pull/13

validator-446

added issn extraction from ean-13 and test cases

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alcole/commons-validator 
alex/validator-446/issn-ean13

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-validator/pull/13.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #13


commit 001ceb34a469923d8b2576823bf8f774017c57a2
Author: alex-cole 
Date:   2018-08-21T18:57:03Z

validator-446

added issn extraction from ean-13 and test cases




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-validator pull request #12: VALIDATOR-446 extract ISSN from EAN-13

[alcole]

Github user alcole closed the pull request at:

https://github.com/apache/commons-validator/pull/12


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-validator pull request #12: VALIDATOR-446 extract ISSN from EAN-13

[alcole]

GitHub user alcole opened a pull request:

https://github.com/apache/commons-validator/pull/12

VALIDATOR-446 extract ISSN from EAN-13



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alcole/commons-validator 
alex/VALIDATOR-446/ISSN-EAN13

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-validator/pull/12.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #12


commit 3c62546bb9712d8613fc9bc0d57359b1dbf09677
Author: alex-cole 
Date:   2018-08-21T18:14:12Z

VALIDATOR-446 extract ISSN from EAN-13




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-validator pull request #10: Add El Salvador (SV)

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-validator/pull/10


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-validator pull request #11: add Belarus (BY) valid example

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-validator/pull/11


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-validator pull request #11: add Belarus (BY) valid example

[h0l0gram]

GitHub user h0l0gram opened a pull request:

https://github.com/apache/commons-validator/pull/11

add Belarus (BY) valid example



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/h0l0gram/commons-validator belarus-test

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-validator/pull/11.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #11


commit 9260f73125bff8ac4dff7284b972856d030877fa
Author: h0l0gram 
Date:   2018-04-18T15:48:34Z

add Belarus (BY) valid example




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-validator pull request #10: Add El Salvador (SV)

[h0l0gram]

GitHub user h0l0gram opened a pull request:

https://github.com/apache/commons-validator/pull/10

Add El Salvador (SV)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/h0l0gram/commons-validator trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-validator/pull/10.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10


commit 1050799f3bfa32ac83e1da7a00058ebc0f138ec5
Author: h0l0gram 
Date:   2018-04-18T15:18:48Z

Add El Salvador (SV)




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: Jenkins build is back to normal : commons-validator #64

[Gary Gregory]

On Wed, Mar 14, 2018 at 8:46 AM, sebb  wrote:

> FIxed by changing the Jenkins JDK to 1.8 (latest).
>
> Also had to exclude some nodes (e.g. cassandra-*) which don't seem to
> have publish rights.
>

Ugh, what a mess :-(

Gary


>
> On 14 March 2018 at 13:42, Apache Jenkins Server
>  wrote:
> > See <https://builds.apache.org/job/commons-validator/64/display/redirect
> >
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

Re: Jenkins build is back to normal : commons-validator #64

[sebb]

FIxed by changing the Jenkins JDK to 1.8 (latest).

Also had to exclude some nodes (e.g. cassandra-*) which don't seem to
have publish rights.

On 14 March 2018 at 13:42, Apache Jenkins Server
 wrote:
> See <https://builds.apache.org/job/commons-validator/64/display/redirect>
>

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

AW: Build failed in Jenkins: commons-validator #61

[jhm]

It seems that there is lot of work on the nodes ATM.
So we have to wait for results ...

Jan

> -Ursprüngliche Nachricht-
> Von: Jan Matèrne (jhm) [mailto:apa...@materne.de]
> Gesendet: Mittwoch, 14. März 2018 09:33
> An: 'Commons Developers List'
> Betreff: AW: Build failed in Jenkins: commons-validator #61
> 
> I solved the same problem for commons-email.
> https://builds.apache.org/view/All/job/commons-email/configure
> 
> The project requires via the chosen Maven profile a specific Java
> version.
> This Java installation must be available via a specific environment
> variable "JAVA_1_7_HOME".
> 
> commons-validator sets this to a fixed value, where I don't know this
> location exists on the build node.
> 
> Jenkins could inject the value, but on another name
> "JDK_1_7_LATEST__HOME".
> 'Inject environment variables to the build process > Properties
> Content': "JAVA_1_7_HOME=$JDK_1_7_LATEST__HOME"
> and specify the required value sources via 'Tool Environment'.
> 
> 
> I adapted the email configuration and started a new build.
> 
> 
> Jan
> 
> 
> > -Ursprüngliche Nachricht-
> > Von: sebb [mailto:seb...@gmail.com]
> > Gesendet: Mittwoch, 14. März 2018 00:58
> > An: Commons Developers List
> > Betreff: Re: Build failed in Jenkins: commons-validator #61
> >
> > I think this has happened before.
> >
> > Jenkins now needs Java 8.
> > It attempts recovery but that does not work.
> >
> > On 13 March 2018 at 16:17, Gary Gregory 
> wrote:
> > > Thoughts on how to fix this?
> > >
> > > Gary
> > >
> > > -- Forwarded message -
> > > From: Apache Jenkins Server 
> > > Date: Tue, Mar 13, 2018, 09:48
> > > Subject: Build failed in Jenkins: commons-validator #61
> > > To: 
> > >
> > >
> > > See
> > > <https://builds.apache.org/job/commons-
> validator/61/display/redirect
> > > >
> > >
> > > --
> > > Started by user ggregory
> > > [EnvInject] - Loading node environment variables.
> > > Building remotely on windows-2012-1 (Windows) in workspace <
> > > https://builds.apache.org/job/commons-validator/ws/>
> > > Updating
> > > https://svn.apache.org/repos/asf/commons/proper/validator/trunk at
> > revision '2018-03-13T15:47:38.139 +'
> > > At revision 1826655
> > >
> > > No changes for
> > > https://svn.apache.org/repos/asf/commons/proper/validator/trunk
> > > since the previous build [EnvInject] - Executing scripts and
> > > injecting environment variables after the SCM step.
> > > [EnvInject] - Injecting as environment variables the properties
> > > content JAVA_1_6_HOME=/home/jenkins/tools/java/latest1.6/
> > >
> > > [EnvInject] - Variables injected successfully.
> > > Parsing POMs
> > > Established TCP socket on 62574
> > > maven35-agent.jar already up to date maven35-interceptor.jar
> already
> > > up to date maven3-interceptor-commons.jar already up to date
> > > [commons-validator] $ f:\\jenkins\\tools\\java\\latest1.7/bin/java
> > > -Xmx2g -Xms256m -cp
> > > f:\jenkins\jenkins-slave\maven35-
> > agent.jar;f:\jenkins\tools\maven\late
> > > st3\boot\plexus-classworlds-
> > 2.5.2.jar;f:\\jenkins\\tools\\maven\\lates
> > > t3/conf/logging jenkins.maven3.agent.Maven35Main
> > > f:\\jenkins\\tools\\maven\\latest3
> > > F:\jenkins\jenkins-slave\slave.jar
> > > f:\jenkins\jenkins-slave\maven35-interceptor.jar
> > > f:\jenkins\jenkins-slave\maven3-interceptor-commons.jar 62574
> > > <===[JENKINS REMOTING CAPACITY]===>   channel started
> > > ERROR:
> > >
> >
> ==
> > > ==
> > > ERROR: Invalid project setup:
> jenkins/security/MasterToSlaveCallable
> > :
> > > Unsupported major.minor version 52.0
> > > ERROR: [JENKINS-18403][JENKINS-28294] JDK 'JDK 1.7 (latest)' not
> > > supported to run Maven projects.
> > > ERROR: Maven projects have to be launched with a Java version
> > > greater or equal to the minimum version required by the master.
> > > ERROR: Use the Maven JDK Toolchains (plugin) to build your maven
> > > project with an older JDK.
> > > ERROR: Retrying with slave Java and setting compile/test properties
> > to
> > > point to

AW: Build failed in Jenkins: commons-validator #61

[jhm]

I solved the same problem for commons-email.
https://builds.apache.org/view/All/job/commons-email/configure

The project requires via the chosen Maven profile a specific Java version.
This Java installation must be available via a specific environment variable 
"JAVA_1_7_HOME".

commons-validator sets this to a fixed value, where I don't know this location 
exists on the build node.

Jenkins could inject the value, but on another name "JDK_1_7_LATEST__HOME".
'Inject environment variables to the build process > Properties Content': 
"JAVA_1_7_HOME=$JDK_1_7_LATEST__HOME"
and specify the required value sources via 'Tool Environment'.


I adapted the email configuration and started a new build.


Jan


> -Ursprüngliche Nachricht-
> Von: sebb [mailto:seb...@gmail.com]
> Gesendet: Mittwoch, 14. März 2018 00:58
> An: Commons Developers List
> Betreff: Re: Build failed in Jenkins: commons-validator #61
> 
> I think this has happened before.
> 
> Jenkins now needs Java 8.
> It attempts recovery but that does not work.
> 
> On 13 March 2018 at 16:17, Gary Gregory  wrote:
> > Thoughts on how to fix this?
> >
> > Gary
> >
> > -- Forwarded message -
> > From: Apache Jenkins Server 
> > Date: Tue, Mar 13, 2018, 09:48
> > Subject: Build failed in Jenkins: commons-validator #61
> > To: 
> >
> >
> > See
> > <https://builds.apache.org/job/commons-validator/61/display/redirect>
> >
> > ------
> > Started by user ggregory
> > [EnvInject] - Loading node environment variables.
> > Building remotely on windows-2012-1 (Windows) in workspace <
> > https://builds.apache.org/job/commons-validator/ws/>
> > Updating
> > https://svn.apache.org/repos/asf/commons/proper/validator/trunk at
> revision '2018-03-13T15:47:38.139 +'
> > At revision 1826655
> >
> > No changes for
> > https://svn.apache.org/repos/asf/commons/proper/validator/trunk since
> > the previous build [EnvInject] - Executing scripts and injecting
> > environment variables after the SCM step.
> > [EnvInject] - Injecting as environment variables the properties
> > content JAVA_1_6_HOME=/home/jenkins/tools/java/latest1.6/
> >
> > [EnvInject] - Variables injected successfully.
> > Parsing POMs
> > Established TCP socket on 62574
> > maven35-agent.jar already up to date
> > maven35-interceptor.jar already up to date
> > maven3-interceptor-commons.jar already up to date [commons-validator]
> > $ f:\\jenkins\\tools\\java\\latest1.7/bin/java -Xmx2g -Xms256m -cp
> > f:\jenkins\jenkins-slave\maven35-
> agent.jar;f:\jenkins\tools\maven\late
> > st3\boot\plexus-classworlds-
> 2.5.2.jar;f:\\jenkins\\tools\\maven\\lates
> > t3/conf/logging jenkins.maven3.agent.Maven35Main
> > f:\\jenkins\\tools\\maven\\latest3
> > F:\jenkins\jenkins-slave\slave.jar
> > f:\jenkins\jenkins-slave\maven35-interceptor.jar
> > f:\jenkins\jenkins-slave\maven3-interceptor-commons.jar 62574
> > <===[JENKINS REMOTING CAPACITY]===>   channel started
> > ERROR:
> >
> ==
> > ==
> > ERROR: Invalid project setup: jenkins/security/MasterToSlaveCallable
> :
> > Unsupported major.minor version 52.0
> > ERROR: [JENKINS-18403][JENKINS-28294] JDK 'JDK 1.7 (latest)' not
> > supported to run Maven projects.
> > ERROR: Maven projects have to be launched with a Java version greater
> > or equal to the minimum version required by the master.
> > ERROR: Use the Maven JDK Toolchains (plugin) to build your maven
> > project with an older JDK.
> > ERROR: Retrying with slave Java and setting compile/test properties
> to
> > point to f:\\jenkins\\tools\\java\\latest1.7.
> > ERROR:
> >
> ==
> > ==
> > Established TCP socket on 62579
> > maven35-agent.jar already up to date
> > maven35-interceptor.jar already up to date
> > maven3-interceptor-commons.jar already up to date [commons-validator]
> > $ "C:\Program Files\Java\jre1.8.0_152/bin/java" -Xmx2g -Xms256m -cp
> > f:\jenkins\jenkins-slave\maven35-
> agent.jar;f:\jenkins\tools\maven\late
> > st3\boot\plexus-classworlds-
> 2.5.2.jar;f:\\jenkins\\tools\\maven\\lates
> > t3/conf/logging jenkins.maven3.agent.Maven35Main
> > f:\\jenkins\\tools\\maven\\latest3
> > F:\jenkins\jenkins-slave\slave.jar
> > f:\jenkins\jenkins-slave\maven35-interceptor.jar
> > f:\jenkins\jenkins-slave\

Re: Build failed in Jenkins: commons-validator #61

[sebb]

I think this has happened before.

Jenkins now needs Java 8.
It attempts recovery but that does not work.

On 13 March 2018 at 16:17, Gary Gregory  wrote:
> Thoughts on how to fix this?
>
> Gary
>
> -- Forwarded message -
> From: Apache Jenkins Server 
> Date: Tue, Mar 13, 2018, 09:48
> Subject: Build failed in Jenkins: commons-validator #61
> To: 
>
>
> See <https://builds.apache.org/job/commons-validator/61/display/redirect>
>
> --
> Started by user ggregory
> [EnvInject] - Loading node environment variables.
> Building remotely on windows-2012-1 (Windows) in workspace <
> https://builds.apache.org/job/commons-validator/ws/>
> Updating https://svn.apache.org/repos/asf/commons/proper/validator/trunk at
> revision '2018-03-13T15:47:38.139 +'
> At revision 1826655
>
> No changes for
> https://svn.apache.org/repos/asf/commons/proper/validator/trunk since the
> previous build
> [EnvInject] - Executing scripts and injecting environment variables after
> the SCM step.
> [EnvInject] - Injecting as environment variables the properties content
> JAVA_1_6_HOME=/home/jenkins/tools/java/latest1.6/
>
> [EnvInject] - Variables injected successfully.
> Parsing POMs
> Established TCP socket on 62574
> maven35-agent.jar already up to date
> maven35-interceptor.jar already up to date
> maven3-interceptor-commons.jar already up to date
> [commons-validator] $ f:\\jenkins\\tools\\java\\latest1.7/bin/java -Xmx2g
> -Xms256m -cp
> f:\jenkins\jenkins-slave\maven35-agent.jar;f:\jenkins\tools\maven\latest3\boot\plexus-classworlds-2.5.2.jar;f:\\jenkins\\tools\\maven\\latest3/conf/logging
> jenkins.maven3.agent.Maven35Main f:\\jenkins\\tools\\maven\\latest3
> F:\jenkins\jenkins-slave\slave.jar
> f:\jenkins\jenkins-slave\maven35-interceptor.jar
> f:\jenkins\jenkins-slave\maven3-interceptor-commons.jar 62574
> <===[JENKINS REMOTING CAPACITY]===>   channel started
> ERROR:
> 
> ERROR: Invalid project setup: jenkins/security/MasterToSlaveCallable :
> Unsupported major.minor version 52.0
> ERROR: [JENKINS-18403][JENKINS-28294] JDK 'JDK 1.7 (latest)' not supported
> to run Maven projects.
> ERROR: Maven projects have to be launched with a Java version greater or
> equal to the minimum version required by the master.
> ERROR: Use the Maven JDK Toolchains (plugin) to build your maven project
> with an older JDK.
> ERROR: Retrying with slave Java and setting compile/test properties to
> point to f:\\jenkins\\tools\\java\\latest1.7.
> ERROR:
> ========
> Established TCP socket on 62579
> maven35-agent.jar already up to date
> maven35-interceptor.jar already up to date
> maven3-interceptor-commons.jar already up to date
> [commons-validator] $ "C:\Program Files\Java\jre1.8.0_152/bin/java" -Xmx2g
> -Xms256m -cp
> f:\jenkins\jenkins-slave\maven35-agent.jar;f:\jenkins\tools\maven\latest3\boot\plexus-classworlds-2.5.2.jar;f:\\jenkins\\tools\\maven\\latest3/conf/logging
> jenkins.maven3.agent.Maven35Main f:\\jenkins\\tools\\maven\\latest3
> F:\jenkins\jenkins-slave\slave.jar
> f:\jenkins\jenkins-slave\maven35-interceptor.jar
> f:\jenkins\jenkins-slave\maven3-interceptor-commons.jar 62579
> <===[JENKINS REMOTING CAPACITY]===>   channel started
> Executing Maven:  -B -f <
> https://builds.apache.org/job/commons-validator/ws/pom.xml>
> -Dmaven.repo.local=f:\jenkins\jenkins-slave\maven-repositories\0 -V clean
> install --batch-mode -Dgpg.skip -Prelease -Pjava-1.6
>  [1mApache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d;
> 2017-10-18T07:58:13Z) [m
> Maven home: F:\jenkins\tools\maven\latest3
> Java version: 1.8.0_152, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jre1.8.0_152
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows server 2012 r2", version: "6.3", arch: "amd64", family:
> "windows"
> [INFO] Scanning for projects...
> [INFO]
> [INFO]
> ----
> [INFO] Building Apache Commons Validator 1.7-SNAPSHOT
> [INFO]
> ----
> [INFO]
> [INFO] --- maven-clean-plugin:3.0.0:clean (default-clean) @
> commons-validator ---
> [INFO] Deleting <https://builds.apache.org/job/commons-validator/ws/target>
> [INFO]
> [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-3) @
> commons-validator ---
> [INFO]
> [INFO] --- build-helper-maven-plugin:3.0.0:parse-version (parse-versi

Fwd: Build failed in Jenkins: commons-validator #61

[Gary Gregory]

Thoughts on how to fix this?

Gary

-- Forwarded message -
From: Apache Jenkins Server 
Date: Tue, Mar 13, 2018, 09:48
Subject: Build failed in Jenkins: commons-validator #61
To: 


See <https://builds.apache.org/job/commons-validator/61/display/redirect>

--
Started by user ggregory
[EnvInject] - Loading node environment variables.
Building remotely on windows-2012-1 (Windows) in workspace <
https://builds.apache.org/job/commons-validator/ws/>
Updating https://svn.apache.org/repos/asf/commons/proper/validator/trunk at
revision '2018-03-13T15:47:38.139 +'
At revision 1826655

No changes for
https://svn.apache.org/repos/asf/commons/proper/validator/trunk since the
previous build
[EnvInject] - Executing scripts and injecting environment variables after
the SCM step.
[EnvInject] - Injecting as environment variables the properties content
JAVA_1_6_HOME=/home/jenkins/tools/java/latest1.6/

[EnvInject] - Variables injected successfully.
Parsing POMs
Established TCP socket on 62574
maven35-agent.jar already up to date
maven35-interceptor.jar already up to date
maven3-interceptor-commons.jar already up to date
[commons-validator] $ f:\\jenkins\\tools\\java\\latest1.7/bin/java -Xmx2g
-Xms256m -cp
f:\jenkins\jenkins-slave\maven35-agent.jar;f:\jenkins\tools\maven\latest3\boot\plexus-classworlds-2.5.2.jar;f:\\jenkins\\tools\\maven\\latest3/conf/logging
jenkins.maven3.agent.Maven35Main f:\\jenkins\\tools\\maven\\latest3
F:\jenkins\jenkins-slave\slave.jar
f:\jenkins\jenkins-slave\maven35-interceptor.jar
f:\jenkins\jenkins-slave\maven3-interceptor-commons.jar 62574
<===[JENKINS REMOTING CAPACITY]===>   channel started
ERROR:

ERROR: Invalid project setup: jenkins/security/MasterToSlaveCallable :
Unsupported major.minor version 52.0
ERROR: [JENKINS-18403][JENKINS-28294] JDK 'JDK 1.7 (latest)' not supported
to run Maven projects.
ERROR: Maven projects have to be launched with a Java version greater or
equal to the minimum version required by the master.
ERROR: Use the Maven JDK Toolchains (plugin) to build your maven project
with an older JDK.
ERROR: Retrying with slave Java and setting compile/test properties to
point to f:\\jenkins\\tools\\java\\latest1.7.
ERROR:

Established TCP socket on 62579
maven35-agent.jar already up to date
maven35-interceptor.jar already up to date
maven3-interceptor-commons.jar already up to date
[commons-validator] $ "C:\Program Files\Java\jre1.8.0_152/bin/java" -Xmx2g
-Xms256m -cp
f:\jenkins\jenkins-slave\maven35-agent.jar;f:\jenkins\tools\maven\latest3\boot\plexus-classworlds-2.5.2.jar;f:\\jenkins\\tools\\maven\\latest3/conf/logging
jenkins.maven3.agent.Maven35Main f:\\jenkins\\tools\\maven\\latest3
F:\jenkins\jenkins-slave\slave.jar
f:\jenkins\jenkins-slave\maven35-interceptor.jar
f:\jenkins\jenkins-slave\maven3-interceptor-commons.jar 62579
<===[JENKINS REMOTING CAPACITY]===>   channel started
Executing Maven:  -B -f <
https://builds.apache.org/job/commons-validator/ws/pom.xml>
-Dmaven.repo.local=f:\jenkins\jenkins-slave\maven-repositories\0 -V clean
install --batch-mode -Dgpg.skip -Prelease -Pjava-1.6
 [1mApache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d;
2017-10-18T07:58:13Z) [m
Maven home: F:\jenkins\tools\maven\latest3
Java version: 1.8.0_152, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jre1.8.0_152
Default locale: en_US, platform encoding: Cp1252
OS name: "windows server 2012 r2", version: "6.3", arch: "amd64", family:
"windows"
[INFO] Scanning for projects...
[INFO]
[INFO]
--------
[INFO] Building Apache Commons Validator 1.7-SNAPSHOT
[INFO]
--------
[INFO]
[INFO] --- maven-clean-plugin:3.0.0:clean (default-clean) @
commons-validator ---
[INFO] Deleting <https://builds.apache.org/job/commons-validator/ws/target>
[INFO]
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-3) @
commons-validator ---
[INFO]
[INFO] --- build-helper-maven-plugin:3.0.0:parse-version (parse-version) @
commons-validator ---
[INFO]
[INFO] --- maven-antrun-plugin:1.8:run (javadoc.resources) @
commons-validator ---
[INFO] Executing tasks

main:
 [copy] Copying 2 files to <
https://builds.apache.org/job/commons-validator/ws/target\apidocs\META-INF>
[INFO] Executed tasks
[INFO]
[INFO] --- maven-remote-resources-plugin:1.5:process
(process-resource-bundles) @ commons-validator ---
[INFO]
[INFO] --- buildnumber-maven-plugin:1.4:create (default) @
commons-validator ---
[INFO] Executing: cmd.exe /X /C "svn --non-interactive info"
[INFO] Working directory: <
https://builds.apache.org/job/commons-validator/ws/

[GitHub] commons-validator pull request #9: fix email with dot and whitespace end val...

[unintended]

GitHub user unintended opened a pull request:

https://github.com/apache/commons-validator/pull/9

fix email with dot and whitespace end validation



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/unintended/commons-validator 
email_validation_fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-validator/pull/9.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #9


commit 3c675eb91a1d8efcac93bd5de8841dcb75f9c5be
Author: Ilya Samartsev 
Date:   2018-02-16T12:30:06Z

fix email with dot and whitespace end validation




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-validator pull request #5: VALIDATOR-387 Userinfo without colon shou...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-validator/pull/5


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-validator pull request #4: Field does not synchronize iteration on s...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-validator/pull/4


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [RESULT][VOTE][LAZY] Migrate Apache Commons Validator to git

[Gary Gregory]

Benedikt: Thank you again for shepherding this through.

On Sat, Oct 28, 2017 at 10:37 AM, Benedikt Ritter 
wrote:

> Hi,
>
> > Am 21.10.2017 um 10:22 schrieb Benedikt Ritter :
> >
> > Hello,
> >
> > I’d like to move Apache Commons Validator codebase to git, so I’m
> calling a vote by lazy consensus. If nobody objects within the next 72
> hours this vote passes and I will start with the migration.
> >
> > This vote will be open until at least 24-October-2017, 10:30 CEST
> (UTC+2).
>
> This vote passes - there have been no objections. There has been one +1
> vote by Gary Gregory.
>
> I’ll move the codebase when I find the time to do it. Probably by the end
> of next week.
>
> Regards,
> Benedikt
>
> >
> > Regards,
> > Benedikt
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

[RESULT][VOTE][LAZY] Migrate Apache Commons Validator to git

[Benedikt Ritter]

Hi,

> Am 21.10.2017 um 10:22 schrieb Benedikt Ritter :
> 
> Hello,
> 
> I’d like to move Apache Commons Validator codebase to git, so I’m calling a 
> vote by lazy consensus. If nobody objects within the next 72 hours this vote 
> passes and I will start with the migration.
> 
> This vote will be open until at least 24-October-2017, 10:30 CEST (UTC+2).

This vote passes - there have been no objections. There has been one +1 vote by 
Gary Gregory.

I’ll move the codebase when I find the time to do it. Probably by the end of 
next week.

Regards,
Benedikt

> 
> Regards,
> Benedikt
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE][LAZY] Migrate Apache Commons Validator to git

[Gary Gregory]

+

Gary

On Oct 21, 2017 02:22, "Benedikt Ritter"  wrote:

> Hello,
>
> I’d like to move Apache Commons Validator codebase to git, so I’m calling
> a vote by lazy consensus. If nobody objects within the next 72 hours this
> vote passes and I will start with the migration.
>
> This vote will be open until at least 24-October-2017, 10:30 CEST (UTC+2).
>
> Regards,
> Benedikt
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>

[VOTE][LAZY] Migrate Apache Commons Validator to git

[Benedikt Ritter]

Hello,

I’d like to move Apache Commons Validator codebase to git, so I’m calling a 
vote by lazy consensus. If nobody objects within the next 72 hours this vote 
passes and I will start with the migration.

This vote will be open until at least 24-October-2017, 10:30 CEST (UTC+2).

Regards,
Benedikt
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-validator pull request #8: Update commons digester

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-validator/pull/8


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: commons validator saying valid email is invalid

[sebb]

Two periods together is invalid. (RFC 2822, section 3.4.1)

On 27 February 2017 at 21:37, Pascal Schumacher
 wrote:
> Hi Tim,
>
> please report issues at https://issues.apache.org/jira/browse/VALIDATOR
>
> Thanks,
> Pascal
>
> Am 27.02.2017 um 21:52 schrieb Tim Cronin:
>>
>> calling org.apache.commons.validator.routines.EmailValidator.isValid()
>> with "jane..s@test.com" as email returns false but is valid.
>>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: commons validator saying valid email is invalid

[Pascal Schumacher]

Hi Tim,

please report issues at https://issues.apache.org/jira/browse/VALIDATOR

Thanks,
Pascal

Am 27.02.2017 um 21:52 schrieb Tim Cronin:

calling org.apache.commons.validator.routines.EmailValidator.isValid()
with "jane..s@test.com" as email returns false but is valid.




-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

commons validator saying valid email is invalid

[Tim Cronin]

calling org.apache.commons.validator.routines.EmailValidator.isValid()
with "jane..s@test.com" as email returns false but is valid.

Build failed in Jenkins: commons-validator #41

[Apache Jenkins Server]

See <https://builds.apache.org/job/commons-validator/41/display/redirect>

--
[...truncated 3.18 KB...]
AU
src/test/java/org/apache/commons/validator/routines/PercentValidatorTest.java
AU
src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java
AU
src/test/java/org/apache/commons/validator/routines/ByteValidatorTest.java
AU
src/test/java/org/apache/commons/validator/routines/CreditCardValidatorTest.java
AU
src/test/java/org/apache/commons/validator/routines/InetAddressValidatorTest.java
AU
src/test/java/org/apache/commons/validator/routines/FloatValidatorTest.java
AU
src/test/java/org/apache/commons/validator/routines/DomainValidatorTest.java
A src/test/java/org/apache/commons/validator/routines/checkdigit
AU
src/test/java/org/apache/commons/validator/routines/checkdigit/ISINCheckDigitTest.java
AU
src/test/java/org/apache/commons/validator/routines/checkdigit/AbstractCheckDigitTest.java
AU
src/test/java/org/apache/commons/validator/routines/checkdigit/ModulusTenABACheckDigitTest.java
AU
src/test/java/org/apache/commons/validator/routines/checkdigit/ModulusTenCUSIPCheckDigitTest.java
AU
src/test/java/org/apache/commons/validator/routines/checkdigit/VerhoeffCheckDigitTest.java
AU
src/test/java/org/apache/commons/validator/routines/checkdigit/LuhnCheckDigitTest.java
AU
src/test/java/org/apache/commons/validator/routines/checkdigit/SedolCheckDigitTest.java
AU
src/test/java/org/apache/commons/validator/routines/checkdigit/EAN13CheckDigitTest.java
AU
src/test/java/org/apache/commons/validator/routines/checkdigit/IBANCheckDigitTest.java
AU
src/test/java/org/apache/commons/validator/routines/checkdigit/ISSNCheckDigitTest.java
AU
src/test/java/org/apache/commons/validator/routines/checkdigit/CUSIPCheckDigitTest.java
AU
src/test/java/org/apache/commons/validator/routines/checkdigit/ModulusTenLuhnCheckDigitTest.java
AU
src/test/java/org/apache/commons/validator/routines/checkdigit/ModulusTenSedolCheckDigitTest.java
AU
src/test/java/org/apache/commons/validator/routines/checkdigit/ModulusTenEAN13CheckDigitTest.java
AU
src/test/java/org/apache/commons/validator/routines/checkdigit/ISBNCheckDigitTest.java
AU
src/test/java/org/apache/commons/validator/routines/checkdigit/ABANumberCheckDigitTest.java
AU
src/test/java/org/apache/commons/validator/routines/checkdigit/ISBN10CheckDigitTest.java
AU
src/test/java/org/apache/commons/validator/routines/IBANValidatorTest.java
AU
src/test/java/org/apache/commons/validator/routines/CalendarValidatorTest.java
AU
src/test/java/org/apache/commons/validator/routines/DoubleValidatorTest.java
AU
src/test/java/org/apache/commons/validator/routines/CodeValidatorTest.java
AU
src/test/java/org/apache/commons/validator/routines/RegexValidatorTest.java
AU
src/test/java/org/apache/commons/validator/routines/AbstractNumberValidatorTest.java
AU
src/test/java/org/apache/commons/validator/routines/ISSNValidatorTest.java
AU
src/test/java/org/apache/commons/validator/routines/DateValidatorTest.java
AU
src/test/java/org/apache/commons/validator/routines/BigIntegerValidatorTest.java
AU
src/test/java/org/apache/commons/validator/routines/BigDecimalValidatorTest.java
AU
src/test/java/org/apache/commons/validator/routines/EmailValidatorTest.java
AU
src/test/java/org/apache/commons/validator/routines/CurrencyValidatorTest.java
AU
src/test/java/org/apache/commons/validator/routines/ISBNValidatorTest.java
AU
src/test/java/org/apache/commons/validator/routines/IntegerValidatorTest.java
AU
src/test/java/org/apache/commons/validator/routines/AbstractCalendarValidatorTest.java
AU
src/test/java/org/apache/commons/validator/routines/TimeValidatorTest.java
AU
src/test/java/org/apache/commons/validator/routines/ShortValidatorTest.java
AU
src/test/java/org/apache/commons/validator/routines/LongValidatorTest.java
AUsrc/test/java/org/apache/commons/validator/MultipleTest.java
AUsrc/test/java/org/apache/commons/validator/IntegerTest.java
AUsrc/test/java/org/apache/commons/validator/ExceptionTest.java
AUsrc/test/java/org/apache/commons/validator/LongTest.java
AUsrc/test/java/org/apache/commons/validator/ShortTest.java
AUsrc/test/java/org/apache/commons/validator/UrlTest.java
AUsrc/test/java/org/apache/commons/validator/ByteTest.java
AUsrc/test/java/org/apache/commons/validator/FloatTest.java
AU
src/test/java/org/apache/commons/validator/GenericTypeValidatorImpl.java
AUsrc/test/java/org/apache/commons/validator/NameBean.java
AUsrc/test/java/org/apache/commons/validator/ValidatorResultsTest.java
AUsrc/test/java/org/apache/c

Build failed in Jenkins: commons-validator #40

[Apache Jenkins Server]

See <https://builds.apache.org/job/commons-validator/40/display/redirect>

--
Started by user pono
[EnvInject] - Loading node environment variables.
ERROR: SEVERE ERROR occurs
org.jenkinsci.lib.envinject.EnvInjectException: 
hudson.remoting.ChannelClosedException: channel is already closed
at 
org.jenkinsci.plugins.envinject.service.EnvironmentVariablesNodeLoader.gatherEnvironmentVariablesNode(EnvironmentVariablesNodeLoader.java:79)
at 
org.jenkinsci.plugins.envinject.EnvInjectListener.loadEnvironmentVariablesNode(EnvInjectListener.java:80)
at 
org.jenkinsci.plugins.envinject.EnvInjectListener.setUpEnvironment(EnvInjectListener.java:42)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.createLauncher(AbstractBuild.java:572)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:492)
at hudson.model.Run.execute(Run.java:1728)
at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:544)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:404)
Caused by: hudson.remoting.ChannelClosedException: channel is already closed
at hudson.remoting.Channel.send(Channel.java:604)
at hudson.remoting.Request.call(Request.java:130)
at hudson.remoting.Channel.call(Channel.java:821)
at hudson.FilePath.act(FilePath.java:1080)
at 
org.jenkinsci.plugins.envinject.service.EnvironmentVariablesNodeLoader.gatherEnvironmentVariablesNode(EnvironmentVariablesNodeLoader.java:48)
... 8 more
Caused by: java.io.IOException
at hudson.remoting.Channel.close(Channel.java:1284)
at hudson.slaves.ChannelPinger$1.onDead(ChannelPinger.java:115)
at hudson.remoting.PingThread.ping(PingThread.java:130)
at hudson.remoting.PingThread.run(PingThread.java:86)
Caused by: java.util.concurrent.TimeoutException: Ping started at 1487712527382 
hasn't completed by 1487712767383
... 2 more
[EnvInject] - [ERROR] - SEVERE ERROR occurs: channel is already closed

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: Build failed in Jenkins: commons-validator #39

[Rob Tompkins]

> On Feb 21, 2017, at 11:04 AM, sebb  wrote:
> 
>> On 21 February 2017 at 15:53, Rob Tompkins  wrote:
>> 
>>> On Feb 21, 2017, at 10:48 AM, sebb  wrote:
>>> 
>>> On 21 February 2017 at 15:20, Rob Tompkins >> <mailto:chtom...@apache.org>> wrote:
>>>> I actually get this error when I attempt any maven execution on my machine 
>>>> OS X 10.12.3 using maven 3.3.9 and:
>>>> 
>>>> $java -version
>>>> java version "1.6.0_65"
>>>> Java(TM) SE Runtime Environment (build 1.6.0_65-b14-468-11M4833)
>>>> Java HotSpot(TM) 64-Bit Server VM (build 20.65-b04-468, mixed mode)
>>>> 
>>>> It feels to me like a java-1.6/maven incompatibility.
>>> 
>>> Maven 3.3.9 requires Java 1.7
>>> 
>>> However that job uses Maven 2.2.5 and it used to work until a few days ago.
>> 
>> It looks like it’s using Maven 3.2.5:
>> 
>> "/home/jenkins/tools/maven/apache-maven-3.2.5/conf/logging 
>> jenkins.maven3.agent.Maven32Main"
>> 
> 
> Sorry typo, 3.2.5 is what I meant.
> It still only requires Java 1.6
> 
> http://maven.apache.org/docs/history.html

Fair, feels like something changed in that maven install then. 

> 
>>> 
>>> The failure occurs before Maven is started.
>>> 
>>>>> On Feb 21, 2017, at 10:07 AM, sebb  wrote:
>>>>> 
>>>>> Seems to be a bug in Jenkins - this is before Maven is even invoked,
>>>>> and Validator used to build fine with 1.6.
>>>>> Raised INFRA-13556
>>>>> 
>>>>> On 21 February 2017 at 15:00, Apache Jenkins Server
>>>>>  wrote:
>>>>>> See <https://builds.apache.org/job/commons-validator/39/display/redirect>
>>>>>> 
>>>>>> --
>>>>>> Started by user sebb
>>>>>> [EnvInject] - Loading node environment variables.
>>>>>> Building remotely on ubuntu-1 (ubuntu) in workspace 
>>>>>> <https://builds.apache.org/job/commons-validator/ws/>
>>>>>> Updating https://svn.apache.org/repos/asf/commons/proper/validator/trunk 
>>>>>> at revision '2017-02-21T15:00:12.349 +'
>>>>>> At revision 1783899
>>>>>> 
>>>>>> No changes for 
>>>>>> https://svn.apache.org/repos/asf/commons/proper/validator/trunk since 
>>>>>> the previous build
>>>>>> Parsing POMs
>>>>>> Established TCP socket on 32827
>>>>>> maven32-agent.jar already up to date
>>>>>> maven32-interceptor.jar already up to date
>>>>>> maven3-interceptor-commons.jar already up to date
>>>>>> [commons-validator] $ /home/jenkins/tools/java/latest1.6/bin/java -Xmx2g 
>>>>>> -Xms256m -cp 
>>>>>> /home/jenkins/jenkins-slave/maven32-agent.jar:/home/jenkins/tools/maven/apache-maven-3.2.5/boot/plexus-classworlds-2.5.2.jar:/home/jenkins/tools/maven/apache-maven-3.2.5/conf/logging
>>>>>>  jenkins.maven3.agent.Maven32Main 
>>>>>> /home/jenkins/tools/maven/apache-maven-3.2.5 
>>>>>> /home/jenkins/jenkins-slave/slave.jar 
>>>>>> /home/jenkins/jenkins-slave/maven32-interceptor.jar 
>>>>>> /home/jenkins/jenkins-slave/maven3-interceptor-commons.jar 32827
>>>>>> Exception in thread "main" java.lang.UnsupportedClassVersionError: 
>>>>>> hudson/remoting/Launcher : Unsupported major.minor version 51.0
>>>>>>  at java.lang.ClassLoader.defineClass1(Native Method)
>>>>>>  at java.lang.ClassLoader.defineClassCond(ClassLoader.java:631)
>>>>>>  at java.lang.ClassLoader.defineClass(ClassLoader.java:615)
>>>>>>  at 
>>>>>> java.security.SecureClassLoader.defineClass(SecureClassLoader.java:141)
>>>>>>  at java.net.URLClassLoader.defineClass(URLClassLoader.java:283)
>>>>>>  at java.net.URLClassLoader.access$000(URLClassLoader.java:58)
>>>>>>  at java.net.URLClassLoader$1.run(URLClassLoader.java:197)
>>>>>>  at java.security.AccessController.doPrivileged(Native Method)
>>>>>>  at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
>>>>>>  at 
>>>>>> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClassFromSelf(ClassRealm.java:401)
>>>>

Re: Build failed in Jenkins: commons-validator #39

[sebb]

On 21 February 2017 at 15:53, Rob Tompkins  wrote:
>
>> On Feb 21, 2017, at 10:48 AM, sebb  wrote:
>>
>> On 21 February 2017 at 15:20, Rob Tompkins > <mailto:chtom...@apache.org>> wrote:
>>> I actually get this error when I attempt any maven execution on my machine 
>>> OS X 10.12.3 using maven 3.3.9 and:
>>>
>>> $java -version
>>> java version "1.6.0_65"
>>> Java(TM) SE Runtime Environment (build 1.6.0_65-b14-468-11M4833)
>>> Java HotSpot(TM) 64-Bit Server VM (build 20.65-b04-468, mixed mode)
>>>
>>> It feels to me like a java-1.6/maven incompatibility.
>>
>> Maven 3.3.9 requires Java 1.7
>>
>> However that job uses Maven 2.2.5 and it used to work until a few days ago.
>
> It looks like it’s using Maven 3.2.5:
>
> "/home/jenkins/tools/maven/apache-maven-3.2.5/conf/logging 
> jenkins.maven3.agent.Maven32Main"
>

Sorry typo, 3.2.5 is what I meant.
It still only requires Java 1.6

http://maven.apache.org/docs/history.html

>>
>> The failure occurs before Maven is started.
>>
>>>> On Feb 21, 2017, at 10:07 AM, sebb  wrote:
>>>>
>>>> Seems to be a bug in Jenkins - this is before Maven is even invoked,
>>>> and Validator used to build fine with 1.6.
>>>> Raised INFRA-13556
>>>>
>>>> On 21 February 2017 at 15:00, Apache Jenkins Server
>>>>  wrote:
>>>>> See <https://builds.apache.org/job/commons-validator/39/display/redirect>
>>>>>
>>>>> --
>>>>> Started by user sebb
>>>>> [EnvInject] - Loading node environment variables.
>>>>> Building remotely on ubuntu-1 (ubuntu) in workspace 
>>>>> <https://builds.apache.org/job/commons-validator/ws/>
>>>>> Updating https://svn.apache.org/repos/asf/commons/proper/validator/trunk 
>>>>> at revision '2017-02-21T15:00:12.349 +'
>>>>> At revision 1783899
>>>>>
>>>>> No changes for 
>>>>> https://svn.apache.org/repos/asf/commons/proper/validator/trunk since the 
>>>>> previous build
>>>>> Parsing POMs
>>>>> Established TCP socket on 32827
>>>>> maven32-agent.jar already up to date
>>>>> maven32-interceptor.jar already up to date
>>>>> maven3-interceptor-commons.jar already up to date
>>>>> [commons-validator] $ /home/jenkins/tools/java/latest1.6/bin/java -Xmx2g 
>>>>> -Xms256m -cp 
>>>>> /home/jenkins/jenkins-slave/maven32-agent.jar:/home/jenkins/tools/maven/apache-maven-3.2.5/boot/plexus-classworlds-2.5.2.jar:/home/jenkins/tools/maven/apache-maven-3.2.5/conf/logging
>>>>>  jenkins.maven3.agent.Maven32Main 
>>>>> /home/jenkins/tools/maven/apache-maven-3.2.5 
>>>>> /home/jenkins/jenkins-slave/slave.jar 
>>>>> /home/jenkins/jenkins-slave/maven32-interceptor.jar 
>>>>> /home/jenkins/jenkins-slave/maven3-interceptor-commons.jar 32827
>>>>> Exception in thread "main" java.lang.UnsupportedClassVersionError: 
>>>>> hudson/remoting/Launcher : Unsupported major.minor version 51.0
>>>>>   at java.lang.ClassLoader.defineClass1(Native Method)
>>>>>   at java.lang.ClassLoader.defineClassCond(ClassLoader.java:631)
>>>>>   at java.lang.ClassLoader.defineClass(ClassLoader.java:615)
>>>>>   at 
>>>>> java.security.SecureClassLoader.defineClass(SecureClassLoader.java:141)
>>>>>   at java.net.URLClassLoader.defineClass(URLClassLoader.java:283)
>>>>>   at java.net.URLClassLoader.access$000(URLClassLoader.java:58)
>>>>>   at java.net.URLClassLoader$1.run(URLClassLoader.java:197)
>>>>>   at java.security.AccessController.doPrivileged(Native Method)
>>>>>   at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
>>>>>   at 
>>>>> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClassFromSelf(ClassRealm.java:401)
>>>>>   at 
>>>>> org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:42)
>>>>>   at 
>>>>> org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass(ClassRealm.java:271)
>>>>>   at 
>>>>> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:254)
>>>>>   at 
>>>>> org

Re: Build failed in Jenkins: commons-validator #39

[Rob Tompkins]

> On Feb 21, 2017, at 10:48 AM, sebb  wrote:
> 
> On 21 February 2017 at 15:20, Rob Tompkins  <mailto:chtom...@apache.org>> wrote:
>> I actually get this error when I attempt any maven execution on my machine 
>> OS X 10.12.3 using maven 3.3.9 and:
>> 
>> $java -version
>> java version "1.6.0_65"
>> Java(TM) SE Runtime Environment (build 1.6.0_65-b14-468-11M4833)
>> Java HotSpot(TM) 64-Bit Server VM (build 20.65-b04-468, mixed mode)
>> 
>> It feels to me like a java-1.6/maven incompatibility.
> 
> Maven 3.3.9 requires Java 1.7
> 
> However that job uses Maven 2.2.5 and it used to work until a few days ago.

It looks like it’s using Maven 3.2.5:

"/home/jenkins/tools/maven/apache-maven-3.2.5/conf/logging 
jenkins.maven3.agent.Maven32Main"

> 
> The failure occurs before Maven is started.
> 
>>> On Feb 21, 2017, at 10:07 AM, sebb  wrote:
>>> 
>>> Seems to be a bug in Jenkins - this is before Maven is even invoked,
>>> and Validator used to build fine with 1.6.
>>> Raised INFRA-13556
>>> 
>>> On 21 February 2017 at 15:00, Apache Jenkins Server
>>>  wrote:
>>>> See <https://builds.apache.org/job/commons-validator/39/display/redirect>
>>>> 
>>>> --
>>>> Started by user sebb
>>>> [EnvInject] - Loading node environment variables.
>>>> Building remotely on ubuntu-1 (ubuntu) in workspace 
>>>> <https://builds.apache.org/job/commons-validator/ws/>
>>>> Updating https://svn.apache.org/repos/asf/commons/proper/validator/trunk 
>>>> at revision '2017-02-21T15:00:12.349 +'
>>>> At revision 1783899
>>>> 
>>>> No changes for 
>>>> https://svn.apache.org/repos/asf/commons/proper/validator/trunk since the 
>>>> previous build
>>>> Parsing POMs
>>>> Established TCP socket on 32827
>>>> maven32-agent.jar already up to date
>>>> maven32-interceptor.jar already up to date
>>>> maven3-interceptor-commons.jar already up to date
>>>> [commons-validator] $ /home/jenkins/tools/java/latest1.6/bin/java -Xmx2g 
>>>> -Xms256m -cp 
>>>> /home/jenkins/jenkins-slave/maven32-agent.jar:/home/jenkins/tools/maven/apache-maven-3.2.5/boot/plexus-classworlds-2.5.2.jar:/home/jenkins/tools/maven/apache-maven-3.2.5/conf/logging
>>>>  jenkins.maven3.agent.Maven32Main 
>>>> /home/jenkins/tools/maven/apache-maven-3.2.5 
>>>> /home/jenkins/jenkins-slave/slave.jar 
>>>> /home/jenkins/jenkins-slave/maven32-interceptor.jar 
>>>> /home/jenkins/jenkins-slave/maven3-interceptor-commons.jar 32827
>>>> Exception in thread "main" java.lang.UnsupportedClassVersionError: 
>>>> hudson/remoting/Launcher : Unsupported major.minor version 51.0
>>>>   at java.lang.ClassLoader.defineClass1(Native Method)
>>>>   at java.lang.ClassLoader.defineClassCond(ClassLoader.java:631)
>>>>   at java.lang.ClassLoader.defineClass(ClassLoader.java:615)
>>>>   at 
>>>> java.security.SecureClassLoader.defineClass(SecureClassLoader.java:141)
>>>>   at java.net.URLClassLoader.defineClass(URLClassLoader.java:283)
>>>>   at java.net.URLClassLoader.access$000(URLClassLoader.java:58)
>>>>   at java.net.URLClassLoader$1.run(URLClassLoader.java:197)
>>>>   at java.security.AccessController.doPrivileged(Native Method)
>>>>   at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
>>>>   at 
>>>> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClassFromSelf(ClassRealm.java:401)
>>>>   at 
>>>> org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:42)
>>>>   at 
>>>> org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass(ClassRealm.java:271)
>>>>   at 
>>>> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:254)
>>>>   at 
>>>> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:239)
>>>>   at jenkins.maven3.agent.Maven32Main.main(Maven32Main.java:143)
>>>>   at jenkins.maven3.agent.Maven32Main.main(Maven32Main.java:74)
>>>> ERROR: Failed to parse POMs
>>>> java.io.EOFException: unexpected stream termination
>>>>   at hudson.remoting.ChannelBuilder.negotiate(ChannelBuilder.java:365)
>>>>   at hudson.remoting

Re: Build failed in Jenkins: commons-validator #39

[sebb]

On 21 February 2017 at 15:20, Rob Tompkins  wrote:
> I actually get this error when I attempt any maven execution on my machine OS 
> X 10.12.3 using maven 3.3.9 and:
>
> $java -version
> java version "1.6.0_65"
> Java(TM) SE Runtime Environment (build 1.6.0_65-b14-468-11M4833)
> Java HotSpot(TM) 64-Bit Server VM (build 20.65-b04-468, mixed mode)
>
> It feels to me like a java-1.6/maven incompatibility.

Maven 3.3.9 requires Java 1.7

However that job uses Maven 2.2.5 and it used to work until a few days ago.

The failure occurs before Maven is started.

>> On Feb 21, 2017, at 10:07 AM, sebb  wrote:
>>
>> Seems to be a bug in Jenkins - this is before Maven is even invoked,
>> and Validator used to build fine with 1.6.
>> Raised INFRA-13556
>>
>> On 21 February 2017 at 15:00, Apache Jenkins Server
>>  wrote:
>>> See <https://builds.apache.org/job/commons-validator/39/display/redirect>
>>>
>>> --
>>> Started by user sebb
>>> [EnvInject] - Loading node environment variables.
>>> Building remotely on ubuntu-1 (ubuntu) in workspace 
>>> <https://builds.apache.org/job/commons-validator/ws/>
>>> Updating https://svn.apache.org/repos/asf/commons/proper/validator/trunk at 
>>> revision '2017-02-21T15:00:12.349 +'
>>> At revision 1783899
>>>
>>> No changes for 
>>> https://svn.apache.org/repos/asf/commons/proper/validator/trunk since the 
>>> previous build
>>> Parsing POMs
>>> Established TCP socket on 32827
>>> maven32-agent.jar already up to date
>>> maven32-interceptor.jar already up to date
>>> maven3-interceptor-commons.jar already up to date
>>> [commons-validator] $ /home/jenkins/tools/java/latest1.6/bin/java -Xmx2g 
>>> -Xms256m -cp 
>>> /home/jenkins/jenkins-slave/maven32-agent.jar:/home/jenkins/tools/maven/apache-maven-3.2.5/boot/plexus-classworlds-2.5.2.jar:/home/jenkins/tools/maven/apache-maven-3.2.5/conf/logging
>>>  jenkins.maven3.agent.Maven32Main 
>>> /home/jenkins/tools/maven/apache-maven-3.2.5 
>>> /home/jenkins/jenkins-slave/slave.jar 
>>> /home/jenkins/jenkins-slave/maven32-interceptor.jar 
>>> /home/jenkins/jenkins-slave/maven3-interceptor-commons.jar 32827
>>> Exception in thread "main" java.lang.UnsupportedClassVersionError: 
>>> hudson/remoting/Launcher : Unsupported major.minor version 51.0
>>>at java.lang.ClassLoader.defineClass1(Native Method)
>>>at java.lang.ClassLoader.defineClassCond(ClassLoader.java:631)
>>>at java.lang.ClassLoader.defineClass(ClassLoader.java:615)
>>>at 
>>> java.security.SecureClassLoader.defineClass(SecureClassLoader.java:141)
>>>at java.net.URLClassLoader.defineClass(URLClassLoader.java:283)
>>>at java.net.URLClassLoader.access$000(URLClassLoader.java:58)
>>>at java.net.URLClassLoader$1.run(URLClassLoader.java:197)
>>>at java.security.AccessController.doPrivileged(Native Method)
>>>at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
>>>at 
>>> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClassFromSelf(ClassRealm.java:401)
>>>at 
>>> org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:42)
>>>at 
>>> org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass(ClassRealm.java:271)
>>>at 
>>> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:254)
>>>at 
>>> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:239)
>>>at jenkins.maven3.agent.Maven32Main.main(Maven32Main.java:143)
>>>at jenkins.maven3.agent.Maven32Main.main(Maven32Main.java:74)
>>> ERROR: Failed to parse POMs
>>> java.io.EOFException: unexpected stream termination
>>>at hudson.remoting.ChannelBuilder.negotiate(ChannelBuilder.java:365)
>>>at hudson.remoting.ChannelBuilder.build(ChannelBuilder.java:310)
>>>at hudson.slaves.Channels.forProcess(Channels.java:115)
>>>at 
>>> hudson.maven.AbstractMavenProcessFactory.newProcess(AbstractMavenProcessFactory.java:294)
>>>at hudson.maven.ProcessCache.get(ProcessCache.java:236)
>>>at 
>>> hudson.maven.MavenModuleSetBuild$MavenModuleSetBuildExecution.doRun(MavenModuleSetBuild.java:798)
>>>at 
>>> hudson.model.AbstractBuild$AbstractBuildExecution.run(Abs

Re: Build failed in Jenkins: commons-validator #39

[Rob Tompkins]

I actually get this error when I attempt any maven execution on my machine OS X 
10.12.3 using maven 3.3.9 and:

$java -version
java version "1.6.0_65"
Java(TM) SE Runtime Environment (build 1.6.0_65-b14-468-11M4833)
Java HotSpot(TM) 64-Bit Server VM (build 20.65-b04-468, mixed mode)

It feels to me like a java-1.6/maven incompatibility.

> On Feb 21, 2017, at 10:07 AM, sebb  wrote:
> 
> Seems to be a bug in Jenkins - this is before Maven is even invoked,
> and Validator used to build fine with 1.6.
> Raised INFRA-13556
> 
> On 21 February 2017 at 15:00, Apache Jenkins Server
>  wrote:
>> See <https://builds.apache.org/job/commons-validator/39/display/redirect>
>> 
>> --
>> Started by user sebb
>> [EnvInject] - Loading node environment variables.
>> Building remotely on ubuntu-1 (ubuntu) in workspace 
>> <https://builds.apache.org/job/commons-validator/ws/>
>> Updating https://svn.apache.org/repos/asf/commons/proper/validator/trunk at 
>> revision '2017-02-21T15:00:12.349 +'
>> At revision 1783899
>> 
>> No changes for 
>> https://svn.apache.org/repos/asf/commons/proper/validator/trunk since the 
>> previous build
>> Parsing POMs
>> Established TCP socket on 32827
>> maven32-agent.jar already up to date
>> maven32-interceptor.jar already up to date
>> maven3-interceptor-commons.jar already up to date
>> [commons-validator] $ /home/jenkins/tools/java/latest1.6/bin/java -Xmx2g 
>> -Xms256m -cp 
>> /home/jenkins/jenkins-slave/maven32-agent.jar:/home/jenkins/tools/maven/apache-maven-3.2.5/boot/plexus-classworlds-2.5.2.jar:/home/jenkins/tools/maven/apache-maven-3.2.5/conf/logging
>>  jenkins.maven3.agent.Maven32Main 
>> /home/jenkins/tools/maven/apache-maven-3.2.5 
>> /home/jenkins/jenkins-slave/slave.jar 
>> /home/jenkins/jenkins-slave/maven32-interceptor.jar 
>> /home/jenkins/jenkins-slave/maven3-interceptor-commons.jar 32827
>> Exception in thread "main" java.lang.UnsupportedClassVersionError: 
>> hudson/remoting/Launcher : Unsupported major.minor version 51.0
>>at java.lang.ClassLoader.defineClass1(Native Method)
>>at java.lang.ClassLoader.defineClassCond(ClassLoader.java:631)
>>at java.lang.ClassLoader.defineClass(ClassLoader.java:615)
>>at 
>> java.security.SecureClassLoader.defineClass(SecureClassLoader.java:141)
>>at java.net.URLClassLoader.defineClass(URLClassLoader.java:283)
>>at java.net.URLClassLoader.access$000(URLClassLoader.java:58)
>>at java.net.URLClassLoader$1.run(URLClassLoader.java:197)
>>at java.security.AccessController.doPrivileged(Native Method)
>>at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
>>at 
>> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClassFromSelf(ClassRealm.java:401)
>>at 
>> org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:42)
>>at 
>> org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass(ClassRealm.java:271)
>>at 
>> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:254)
>>at 
>> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:239)
>>at jenkins.maven3.agent.Maven32Main.main(Maven32Main.java:143)
>>at jenkins.maven3.agent.Maven32Main.main(Maven32Main.java:74)
>> ERROR: Failed to parse POMs
>> java.io.EOFException: unexpected stream termination
>>at hudson.remoting.ChannelBuilder.negotiate(ChannelBuilder.java:365)
>>at hudson.remoting.ChannelBuilder.build(ChannelBuilder.java:310)
>>at hudson.slaves.Channels.forProcess(Channels.java:115)
>>at 
>> hudson.maven.AbstractMavenProcessFactory.newProcess(AbstractMavenProcessFactory.java:294)
>>at hudson.maven.ProcessCache.get(ProcessCache.java:236)
>>at 
>> hudson.maven.MavenModuleSetBuild$MavenModuleSetBuildExecution.doRun(MavenModuleSetBuild.java:798)
>>at 
>> hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:534)
>>at hudson.model.Run.execute(Run.java:1728)
>>at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:544)
>>at hudson.model.ResourceController.execute(ResourceController.java:98)
>>at hudson.model.Executor.run(Executor.java:404)
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
>> For additional commands, e-mail: dev-h...@commons.apache.org
>> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: Build failed in Jenkins: commons-validator #39

[sebb]

Seems to be a bug in Jenkins - this is before Maven is even invoked,
and Validator used to build fine with 1.6.
Raised INFRA-13556

On 21 February 2017 at 15:00, Apache Jenkins Server
 wrote:
> See <https://builds.apache.org/job/commons-validator/39/display/redirect>
>
> --
> Started by user sebb
> [EnvInject] - Loading node environment variables.
> Building remotely on ubuntu-1 (ubuntu) in workspace 
> <https://builds.apache.org/job/commons-validator/ws/>
> Updating https://svn.apache.org/repos/asf/commons/proper/validator/trunk at 
> revision '2017-02-21T15:00:12.349 +'
> At revision 1783899
>
> No changes for 
> https://svn.apache.org/repos/asf/commons/proper/validator/trunk since the 
> previous build
> Parsing POMs
> Established TCP socket on 32827
> maven32-agent.jar already up to date
> maven32-interceptor.jar already up to date
> maven3-interceptor-commons.jar already up to date
> [commons-validator] $ /home/jenkins/tools/java/latest1.6/bin/java -Xmx2g 
> -Xms256m -cp 
> /home/jenkins/jenkins-slave/maven32-agent.jar:/home/jenkins/tools/maven/apache-maven-3.2.5/boot/plexus-classworlds-2.5.2.jar:/home/jenkins/tools/maven/apache-maven-3.2.5/conf/logging
>  jenkins.maven3.agent.Maven32Main 
> /home/jenkins/tools/maven/apache-maven-3.2.5 
> /home/jenkins/jenkins-slave/slave.jar 
> /home/jenkins/jenkins-slave/maven32-interceptor.jar 
> /home/jenkins/jenkins-slave/maven3-interceptor-commons.jar 32827
> Exception in thread "main" java.lang.UnsupportedClassVersionError: 
> hudson/remoting/Launcher : Unsupported major.minor version 51.0
> at java.lang.ClassLoader.defineClass1(Native Method)
> at java.lang.ClassLoader.defineClassCond(ClassLoader.java:631)
> at java.lang.ClassLoader.defineClass(ClassLoader.java:615)
> at 
> java.security.SecureClassLoader.defineClass(SecureClassLoader.java:141)
> at java.net.URLClassLoader.defineClass(URLClassLoader.java:283)
> at java.net.URLClassLoader.access$000(URLClassLoader.java:58)
> at java.net.URLClassLoader$1.run(URLClassLoader.java:197)
> at java.security.AccessController.doPrivileged(Native Method)
> at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
> at 
> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClassFromSelf(ClassRealm.java:401)
> at 
> org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:42)
> at 
> org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass(ClassRealm.java:271)
> at 
> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:254)
> at 
> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:239)
> at jenkins.maven3.agent.Maven32Main.main(Maven32Main.java:143)
> at jenkins.maven3.agent.Maven32Main.main(Maven32Main.java:74)
> ERROR: Failed to parse POMs
> java.io.EOFException: unexpected stream termination
> at hudson.remoting.ChannelBuilder.negotiate(ChannelBuilder.java:365)
> at hudson.remoting.ChannelBuilder.build(ChannelBuilder.java:310)
> at hudson.slaves.Channels.forProcess(Channels.java:115)
> at 
> hudson.maven.AbstractMavenProcessFactory.newProcess(AbstractMavenProcessFactory.java:294)
> at hudson.maven.ProcessCache.get(ProcessCache.java:236)
> at 
> hudson.maven.MavenModuleSetBuild$MavenModuleSetBuildExecution.doRun(MavenModuleSetBuild.java:798)
> at 
> hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:534)
> at hudson.model.Run.execute(Run.java:1728)
> at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:544)
> at hudson.model.ResourceController.execute(ResourceController.java:98)
> at hudson.model.Executor.run(Executor.java:404)
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Build failed in Jenkins: commons-validator #39

[Apache Jenkins Server]

See <https://builds.apache.org/job/commons-validator/39/display/redirect>

--
Started by user sebb
[EnvInject] - Loading node environment variables.
Building remotely on ubuntu-1 (ubuntu) in workspace 
<https://builds.apache.org/job/commons-validator/ws/>
Updating https://svn.apache.org/repos/asf/commons/proper/validator/trunk at 
revision '2017-02-21T15:00:12.349 +'
At revision 1783899

No changes for https://svn.apache.org/repos/asf/commons/proper/validator/trunk 
since the previous build
Parsing POMs
Established TCP socket on 32827
maven32-agent.jar already up to date
maven32-interceptor.jar already up to date
maven3-interceptor-commons.jar already up to date
[commons-validator] $ /home/jenkins/tools/java/latest1.6/bin/java -Xmx2g 
-Xms256m -cp 
/home/jenkins/jenkins-slave/maven32-agent.jar:/home/jenkins/tools/maven/apache-maven-3.2.5/boot/plexus-classworlds-2.5.2.jar:/home/jenkins/tools/maven/apache-maven-3.2.5/conf/logging
 jenkins.maven3.agent.Maven32Main /home/jenkins/tools/maven/apache-maven-3.2.5 
/home/jenkins/jenkins-slave/slave.jar 
/home/jenkins/jenkins-slave/maven32-interceptor.jar 
/home/jenkins/jenkins-slave/maven3-interceptor-commons.jar 32827
Exception in thread "main" java.lang.UnsupportedClassVersionError: 
hudson/remoting/Launcher : Unsupported major.minor version 51.0
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClassCond(ClassLoader.java:631)
at java.lang.ClassLoader.defineClass(ClassLoader.java:615)
at 
java.security.SecureClassLoader.defineClass(SecureClassLoader.java:141)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:283)
at java.net.URLClassLoader.access$000(URLClassLoader.java:58)
at java.net.URLClassLoader$1.run(URLClassLoader.java:197)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
at 
org.codehaus.plexus.classworlds.realm.ClassRealm.loadClassFromSelf(ClassRealm.java:401)
at 
org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:42)
at 
org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass(ClassRealm.java:271)
at 
org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:254)
at 
org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:239)
at jenkins.maven3.agent.Maven32Main.main(Maven32Main.java:143)
at jenkins.maven3.agent.Maven32Main.main(Maven32Main.java:74)
ERROR: Failed to parse POMs
java.io.EOFException: unexpected stream termination
at hudson.remoting.ChannelBuilder.negotiate(ChannelBuilder.java:365)
at hudson.remoting.ChannelBuilder.build(ChannelBuilder.java:310)
at hudson.slaves.Channels.forProcess(Channels.java:115)
at 
hudson.maven.AbstractMavenProcessFactory.newProcess(AbstractMavenProcessFactory.java:294)
at hudson.maven.ProcessCache.get(ProcessCache.java:236)
at 
hudson.maven.MavenModuleSetBuild$MavenModuleSetBuildExecution.doRun(MavenModuleSetBuild.java:798)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:534)
at hudson.model.Run.execute(Run.java:1728)
at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:544)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:404)

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Build failed in Jenkins: commons-validator #38

[Apache Jenkins Server]

See 
<https://builds.apache.org/job/commons-validator/38/display/redirect?page=changes>

Changes:

[sebb] 1.6 Released

[sebb] Fix layout

--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on ubuntu-1 (ubuntu) in workspace 
<https://builds.apache.org/job/commons-validator/ws/>
Updating https://svn.apache.org/repos/asf/commons/proper/validator/trunk at 
revision '2017-02-21T12:05:11.635 +'
U RELEASE-NOTES.txt
U src/changes/changes.xml
U pom.xml
At revision 1783877

Parsing POMs
Established TCP socket on 51758
Copied maven32-agent.jar
Copied maven32-interceptor.jar
maven3-interceptor-commons.jar already up to date
[commons-validator] $ /home/jenkins/tools/java/latest1.6/bin/java -Xmx2g 
-Xms256m -cp 
/home/jenkins/jenkins-slave/maven32-agent.jar:/home/jenkins/tools/maven/apache-maven-3.2.5/boot/plexus-classworlds-2.5.2.jar:/home/jenkins/tools/maven/apache-maven-3.2.5/conf/logging
 jenkins.maven3.agent.Maven32Main /home/jenkins/tools/maven/apache-maven-3.2.5 
/home/jenkins/jenkins-slave/slave.jar 
/home/jenkins/jenkins-slave/maven32-interceptor.jar 
/home/jenkins/jenkins-slave/maven3-interceptor-commons.jar 51758
Exception in thread "main" java.lang.UnsupportedClassVersionError: 
hudson/remoting/Launcher : Unsupported major.minor version 51.0
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClassCond(ClassLoader.java:631)
at java.lang.ClassLoader.defineClass(ClassLoader.java:615)
at 
java.security.SecureClassLoader.defineClass(SecureClassLoader.java:141)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:283)
at java.net.URLClassLoader.access$000(URLClassLoader.java:58)
at java.net.URLClassLoader$1.run(URLClassLoader.java:197)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
at 
org.codehaus.plexus.classworlds.realm.ClassRealm.loadClassFromSelf(ClassRealm.java:401)
at 
org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:42)
at 
org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass(ClassRealm.java:271)
at 
org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:254)
at 
org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:239)
at jenkins.maven3.agent.Maven32Main.main(Maven32Main.java:143)
at jenkins.maven3.agent.Maven32Main.main(Maven32Main.java:74)
ERROR: Failed to parse POMs
java.io.EOFException: unexpected stream termination
at hudson.remoting.ChannelBuilder.negotiate(ChannelBuilder.java:365)
at hudson.remoting.ChannelBuilder.build(ChannelBuilder.java:310)
at hudson.slaves.Channels.forProcess(Channels.java:115)
at 
hudson.maven.AbstractMavenProcessFactory.newProcess(AbstractMavenProcessFactory.java:294)
at hudson.maven.ProcessCache.get(ProcessCache.java:236)
at 
hudson.maven.MavenModuleSetBuild$MavenModuleSetBuildExecution.doRun(MavenModuleSetBuild.java:798)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:534)
at hudson.model.Run.execute(Run.java:1728)
at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:544)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:404)

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[ANNOUNCE] Apache Commons Validator 1.6 released

[sebb]

The Apache Commons Team is pleased to announce the release of Apache
Commons Validator 1.6

Apache Commons Validator provides the building blocks for both client side
validation and server side data validation. It may be used standalone or
with a framework like Struts.

The main changes are:

* Modulus Ten Check Digit Implementation
* Generic CreditCard validation (syntax and checkdigit only; does not check IIN)
* CreditCard validation specification by numeric range

Details of all the changes in 1.6 can be found in the changelog:

http://commons.apache.org/proper/commons-validator/changes-report.html

1.6 is fully binary compatible to the last release. No client code
changes are required to migrate from version 1.4.x (or later) to 1.6.
The minimum required JDK version for this release is 1.6.

However note that the Javascript code has been dropped, see
https://issues.apache.org/jira/browse/VALIDATOR-371

Source and binary distributions are available for download from the Apache
Commons download site:

http://commons.apache.org/proper/commons-validator/download_validator.cgi

When downloading, please verify signatures using the KEYS file available at

http://www.apache.org/dist/commons/KEYS

Alternatively the release can be fetched from Maven Central:


  commons-validator
  commons-validator
  1.6


For complete information on Commons Validator, including instructions on
how to submit bug reports, patches, or suggestions for improvement, see the
Apache Commons Validator website:

http://commons.apache.org/proper/commons-validator/

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: svn commit: r1781790 - /commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java

[Benedikt Ritter]

+1

> Am 05.02.2017 um 20:03 schrieb s...@apache.org:
> 
> Author: sebb
> Date: Sun Feb  5 19:03:59 2017
> New Revision: 1781790
> 
> URL: http://svn.apache.org/viewvc?rev=1781790&view=rev
> Log:
> Not useful
> 
> Modified:
>
> commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java
> 
> Modified: 
> commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java
> URL: 
> http://svn.apache.org/viewvc/commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java?rev=1781790&r1=1781789&r2=1781790&view=diff
> ======
> --- 
> commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java
>  (original)
> +++ 
> commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java
>  Sun Feb  5 19:03:59 2017
> @@ -491,17 +491,6 @@ protected void setUp() {
>assertTrue(validator.isValid("http://www.apache.org:/path";));
>}
> 
> -   /**
> -* Only used to debug the unit tests.
> -* @param argv
> -*/
> -   public static void main(String[] argv) {
> -
> -  UrlValidatorTest fct = new UrlValidatorTest("url test");
> -  fct.setUp();
> -  fct.testIsValid();
> -  fct.testIsValidScheme();
> -   }
>// Test data for creating a composite URL
>/**
> * The data given below approximates the 4 parts of a URL
> 
> 


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: svn commit: r1781780 - /commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/CreditCardValidator.java

[Benedikt Ritter]

Hello Sebb,

> Am 05.02.2017 um 17:34 schrieb s...@apache.org:
> 
> Author: sebb
> Date: Sun Feb  5 16:34:46 2017
> New Revision: 1781780
> 
> URL: http://svn.apache.org/viewvc?rev=1781780&view=rev
> Log:
> Document the number ranges
> 
> Modified:
>
> commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/CreditCardValidator.java
> 
> Modified: 
> commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/CreditCardValidator.java
> URL: 
> http://svn.apache.org/viewvc/commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/CreditCardValidator.java?rev=1781780&r1=1781779&r2=1781780&view=diff
> ======
> --- 
> commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/CreditCardValidator.java
>  (original)
> +++ 
> commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/CreditCardValidator.java
>  Sun Feb  5 16:34:46 2017
> @@ -121,19 +121,38 @@ public class CreditCardValidator impleme
>  */
> private static final CheckDigit LUHN_VALIDATOR = 
> LuhnCheckDigit.LUHN_CHECK_DIGIT;
> 
> -/** American Express (Amex) Card Validator */
> +/**
> + * American Express (Amex) Card Validator
> + * 34 (15)
> + * 37 (15)

Have you checked how this looks in the rendered JavaDoc? Maybe we should wrap 
this into  ?

Regards,
Benedikt

> + */
> public static final CodeValidator AMEX_VALIDATOR = new 
> CodeValidator("^(3[47]\\d{13})$", LUHN_VALIDATOR);
> 
> -/** Diners Card Validator */
> +/**
> + * Diners Card Validator
> + * 300xxx - 305xxx (14)
> + * 3095xx (14)
> + * 36 (14)
> + * 38 (14)
> + * 39 (14)
> + */
> public static final CodeValidator DINERS_VALIDATOR = new 
> CodeValidator("^(30[0-5]\\d{11}|3095\\d{10}|36\\d{12}|3[8-9]\\d{12})$", 
> LUHN_VALIDATOR);
> 
> -/** Discover Card regular expressions */
> +/**
> + * Discover Card regular expressions
> + * 6011xx (16)
> + * 644xxx - 65 (16)
> + */
> private static final RegexValidator DISCOVER_REGEX = new 
> RegexValidator(new String[] {"^(6011\\d{12})$", "^(64[4-9]\\d{13})$", 
> "^(65\\d{14})$"});
> 
> /** Discover Card Validator */
> public static final CodeValidator DISCOVER_VALIDATOR = new 
> CodeValidator(DISCOVER_REGEX, LUHN_VALIDATOR);
> 
> -/** Mastercard regular expressions */
> +/**
> + * Mastercard regular expressions
> + * 2221xx - 2720xx (16)
> + * 51xxx - 55xxx (16)
> + */
> private static final RegexValidator MASTERCARD_REGEX = new RegexValidator(
> new String[] {
> "^(5[1-5]\\d{14})$",  // 51 - 55 (pre Oct 2016)
> @@ -156,10 +175,14 @@ public class CreditCardValidator impleme
> @Deprecated
> public static final CodeValidator MASTERCARD_VALIDATOR_PRE_OCT2016 = new 
> CodeValidator("^(5[1-5]\\d{14})$", LUHN_VALIDATOR);
> 
> -/** Visa Card Validator */
> +/**
> + * Visa Card Validator
> + * 4x (13 or 16)
> + */
> public static final CodeValidator VISA_VALIDATOR = new 
> CodeValidator("^(4)(\\d{12}|\\d{15})$", LUHN_VALIDATOR);
> 
> -/** VPay (Visa) Card Validator 
> +/** VPay (Visa) Card Validator
> + * 4x (13-19) 
>  * @since 1.5.0
>  */
> public static final CodeValidator VPAY_VALIDATOR = new 
> CodeValidator("^(4)(\\d{12,18})$", LUHN_VALIDATOR);
> 
> 


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: svn commit: r1781676 - /commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/UrlValidator.java

[Benedikt Ritter]

Nice!

> Am 04.02.2017 um 15:49 schrieb s...@apache.org:
> 
> Author: sebb
> Date: Sat Feb  4 14:49:00 2017
> New Revision: 1781676
> 
> URL: http://svn.apache.org/viewvc?rev=1781676&view=rev
> Log:
> Use constant instead of magic number
> 
> Modified:
>
> commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/UrlValidator.java
> 
> Modified: 
> commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/UrlValidator.java
> URL: 
> http://svn.apache.org/viewvc/commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/UrlValidator.java?rev=1781676&r1=1781675&r2=1781676&view=diff
> ======
> --- 
> commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/UrlValidator.java
>  (original)
> +++ 
> commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/UrlValidator.java
>  Sat Feb  4 14:49:00 2017
> @@ -78,6 +78,8 @@ public class UrlValidator implements Ser
> 
> private static final long serialVersionUID = 7557161713937335013L;
> 
> +private static final int MAX_UNSIGNED_16_BIT_INT = 0x; // port max
> +
> /**
>  * Allows all validly formatted schemes to pass validation instead of
>  * supplying a set of valid schemes.
> @@ -416,7 +418,7 @@ public class UrlValidator implements Ser
> if (port != null && port.length() > 0) {
>   try {
>   int iPort = Integer.parseInt(port);
> - if (iPort < 0 || iPort > 0x) {
> + if (iPort < 0 || iPort > MAX_UNSIGNED_16_BIT_INT) {
>   return false;
>   }
>   } catch (NumberFormatException nfe) {
> 
> 


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: svn commit: r1781587 - /commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/IBANValidator.java

[Gary Gregory]

which of course https://www.youtube.com/watch?v=G2eUopy9sd8

G

On Sat, Feb 4, 2017 at 3:22 PM, Gary Gregory  wrote:

> Good one Matt ;-)
>
> G
>
> On Fri, Feb 3, 2017 at 5:06 PM, Matt Sicker  wrote:
>
>> Yup, found it: <
>> https://lists.apache.org/thread.html/095664f9bb67602f308cf1a
>> 0d492de662992462314eb1e97fbd34ec6@%3Cdev.commons.apache.org%3E
>> >
>>
>> On 3 February 2017 at 19:05, Matt Sicker  wrote:
>>
>> > I'm pretty sure you two have had almost this exact conversation before.
>> >
>> > On 3 February 2017 at 17:41, sebb  wrote:
>> >
>> >> I don't see the point; it changes only rarely and it would require
>> >> extra work to read the data and handle errors.
>> >>
>> >> On 3 February 2017 at 18:59, Gary Gregory 
>> wrote:
>> >> > How about externalizing this in a txt file?
>> >> >
>> >> > Gary
>> >> >
>> >> > -- Forwarded message --
>> >> > From: 
>> >> > Date: Fri, Feb 3, 2017 at 10:58 AM
>> >> > Subject: svn commit: r1781587 -
>> >> > /commons/proper/validator/trunk/src/main/java/org/apache/
>> >> commons/validator/routines/IBANValidator.java
>> >> > To: comm...@commons.apache.org
>> >> >
>> >> >
>> >> > Author: sebb
>> >> > Date: Fri Feb  3 18:58:57 2017
>> >> > New Revision: 1781587
>> >> >
>> >> > URL: http://svn.apache.org/viewvc?rev=1781587&view=rev
>> >> > Log:
>> >> > Sort by country-code
>> >> >
>> >> > Modified:
>> >> > commons/proper/validator/trunk/src/main/java/org/
>> >> > apache/commons/validator/routines/IBANValidator.java
>> >> >
>> >> > Modified: commons/proper/validator/trunk/src/main/java/org/
>> >> > apache/commons/validator/routines/IBANValidator.java
>> >> > URL: http://svn.apache.org/viewvc/commons/proper/validator/
>> >> > trunk/src/main/java/org/apache/commons/validator/
>> >> > routines/IBANValidator.java?rev=1781587&r1=1781586&r2=178158
>> 7&view=diff
>> >> > 
>> >> > ==
>> >> > --- commons/proper/validator/trunk/src/main/java/org/
>> >> > apache/commons/validator/routines/IBANValidator.java (original)
>> >> > +++ commons/proper/validator/trunk/src/main/java/org/
>> >> > apache/commons/validator/routines/IBANValidator.java Fri Feb  3
>> >> 18:58:57
>> >> > 2017
>> >> > @@ -94,78 +94,78 @@ public class IBANValidator {
>> >> >   */
>> >> >
>> >> >  private static final Validator[] DEFAULT_FORMATS = {
>> >> > -new Validator("AL", 28, "AL\\d{10}[A-Z0-9]{16}"
>> >> >  ), // Albania
>> >> >  new Validator("AD", 24, "AD\\d{10}[A-Z0-9]{12}"
>> >> >  ), // Andorra
>> >> > +new Validator("AE", 23, "AE\\d{21}"
>> >> >  ), // United Arab Emirates
>> >> > +new Validator("AL", 28, "AL\\d{10}[A-Z0-9]{16}"
>> >> >  ), // Albania
>> >> >  new Validator("AT", 20, "AT\\d{18}"
>> >> >  ), // Austria
>> >> >  new Validator("AZ", 28, "AZ\\d{2}[A-Z]{4}[A-Z0-9]{20}"
>> >> >   ), // Republic of Azerbaijan
>> >> > -new Validator("BH", 22, "BH\\d{2}[A-Z]{4}[A-Z0-9]{14}"
>> >> >   ), // Bahrain (Kingdom of)
>> >> > -new Validator("BE", 16, "BE\\d{14}"
>> >> >  ), // Belgium
>> >> >  new Validator("BA", 20, "BA\\d{18}"
>> >> >  ), // Bosnia and Herzegovina
>> >> > -new Validator("BR", 29, "BR\\d{25}[A-Z]{1}[A-Z0-9]{1}"
>> >> >   ), // Brazil
>> >> > +new Validator("BE", 16, "BE\\d{14}"
>> >> >  ), // Belgium
>> >> >  new Validator("BG", 22, "BG\\d{2}[A-Z]{4}\\d{6}[A-Z0-9
>> >> ]{8}"
>> >> >  ), // Bulgaria
>> >> > +new Validator(

Re: svn commit: r1781587 - /commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/IBANValidator.java

[Gary Gregory]

Good one Matt ;-)

G

On Fri, Feb 3, 2017 at 5:06 PM, Matt Sicker  wrote:

> Yup, found it: <
> https://lists.apache.org/thread.html/095664f9bb67602f308cf1a0d492de
> 662992462314eb1e97fbd34ec6@%3Cdev.commons.apache.org%3E
> >
>
> On 3 February 2017 at 19:05, Matt Sicker  wrote:
>
> > I'm pretty sure you two have had almost this exact conversation before.
> >
> > On 3 February 2017 at 17:41, sebb  wrote:
> >
> >> I don't see the point; it changes only rarely and it would require
> >> extra work to read the data and handle errors.
> >>
> >> On 3 February 2017 at 18:59, Gary Gregory 
> wrote:
> >> > How about externalizing this in a txt file?
> >> >
> >> > Gary
> >> >
> >> > -- Forwarded message --
> >> > From: 
> >> > Date: Fri, Feb 3, 2017 at 10:58 AM
> >> > Subject: svn commit: r1781587 -
> >> > /commons/proper/validator/trunk/src/main/java/org/apache/
> >> commons/validator/routines/IBANValidator.java
> >> > To: comm...@commons.apache.org
> >> >
> >> >
> >> > Author: sebb
> >> > Date: Fri Feb  3 18:58:57 2017
> >> > New Revision: 1781587
> >> >
> >> > URL: http://svn.apache.org/viewvc?rev=1781587&view=rev
> >> > Log:
> >> > Sort by country-code
> >> >
> >> > Modified:
> >> > commons/proper/validator/trunk/src/main/java/org/
> >> > apache/commons/validator/routines/IBANValidator.java
> >> >
> >> > Modified: commons/proper/validator/trunk/src/main/java/org/
> >> > apache/commons/validator/routines/IBANValidator.java
> >> > URL: http://svn.apache.org/viewvc/commons/proper/validator/
> >> > trunk/src/main/java/org/apache/commons/validator/
> >> > routines/IBANValidator.java?rev=1781587&r1=1781586&r2=
> 1781587&view=diff
> >> > 
> >> > ==
> >> > --- commons/proper/validator/trunk/src/main/java/org/
> >> > apache/commons/validator/routines/IBANValidator.java (original)
> >> > +++ commons/proper/validator/trunk/src/main/java/org/
> >> > apache/commons/validator/routines/IBANValidator.java Fri Feb  3
> >> 18:58:57
> >> > 2017
> >> > @@ -94,78 +94,78 @@ public class IBANValidator {
> >> >   */
> >> >
> >> >  private static final Validator[] DEFAULT_FORMATS = {
> >> > -new Validator("AL", 28, "AL\\d{10}[A-Z0-9]{16}"
> >> >  ), // Albania
> >> >  new Validator("AD", 24, "AD\\d{10}[A-Z0-9]{12}"
> >> >  ), // Andorra
> >> > +new Validator("AE", 23, "AE\\d{21}"
> >> >  ), // United Arab Emirates
> >> > +new Validator("AL", 28, "AL\\d{10}[A-Z0-9]{16}"
> >> >  ), // Albania
> >> >  new Validator("AT", 20, "AT\\d{18}"
> >> >  ), // Austria
> >> >  new Validator("AZ", 28, "AZ\\d{2}[A-Z]{4}[A-Z0-9]{20}"
> >> >   ), // Republic of Azerbaijan
> >> > -new Validator("BH", 22, "BH\\d{2}[A-Z]{4}[A-Z0-9]{14}"
> >> >   ), // Bahrain (Kingdom of)
> >> > -new Validator("BE", 16, "BE\\d{14}"
> >> >  ), // Belgium
> >> >  new Validator("BA", 20, "BA\\d{18}"
> >> >  ), // Bosnia and Herzegovina
> >> > -new Validator("BR", 29, "BR\\d{25}[A-Z]{1}[A-Z0-9]{1}"
> >> >   ), // Brazil
> >> > +new Validator("BE", 16, "BE\\d{14}"
> >> >  ), // Belgium
> >> >  new Validator("BG", 22, "BG\\d{2}[A-Z]{4}\\d{6}[A-Z0-9
> >> ]{8}"
> >> >  ), // Bulgaria
> >> > +new Validator("BH", 22, "BH\\d{2}[A-Z]{4}[A-Z0-9]{14}"
> >> >   ), // Bahrain (Kingdom of)
> >> > +new Validator("BR", 29, "BR\\d{25}[A-Z]{1}[A-Z0-9]{1}"
> >> >   ), // Brazil
> >> > +new Validator("CH", 21, "CH\\d{7}[A-Z0-9]{12}"
> >> >   ), // Switzerland
> >> >  new Validator("CR", 22, "CR\\d{20}"
>

Re: svn commit: r1781587 - /commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/IBANValidator.java

[Benedikt Ritter]

Matt, you just made my day! :-)

Matt Sicker  schrieb am Sa. 4. Feb. 2017 um 02:07:

> Yup, found it: <
>
> https://lists.apache.org/thread.html/095664f9bb67602f308cf1a0d492de662992462314eb1e97fbd34ec6@%3Cdev.commons.apache.org%3E
> >
>
> On 3 February 2017 at 19:05, Matt Sicker  wrote:
>
> > I'm pretty sure you two have had almost this exact conversation before.
> >
> > On 3 February 2017 at 17:41, sebb  wrote:
> >
> >> I don't see the point; it changes only rarely and it would require
> >> extra work to read the data and handle errors.
> >>
> >> On 3 February 2017 at 18:59, Gary Gregory 
> wrote:
> >> > How about externalizing this in a txt file?
> >> >
> >> > Gary
> >> >
> >> > -- Forwarded message --
> >> > From: 
> >> > Date: Fri, Feb 3, 2017 at 10:58 AM
> >> > Subject: svn commit: r1781587 -
> >> > /commons/proper/validator/trunk/src/main/java/org/apache/
> >> commons/validator/routines/IBANValidator.java
> >> > To: comm...@commons.apache.org
> >> >
> >> >
> >> > Author: sebb
> >> > Date: Fri Feb  3 18:58:57 2017
> >> > New Revision: 1781587
> >> >
> >> > URL: http://svn.apache.org/viewvc?rev=1781587&view=rev
> >> > Log:
> >> > Sort by country-code
> >> >
> >> > Modified:
> >> > commons/proper/validator/trunk/src/main/java/org/
> >> > apache/commons/validator/routines/IBANValidator.java
> >> >
> >> > Modified: commons/proper/validator/trunk/src/main/java/org/
> >> > apache/commons/validator/routines/IBANValidator.java
> >> > URL: http://svn.apache.org/viewvc/commons/proper/validator/
> >> > trunk/src/main/java/org/apache/commons/validator/
> >> >
> routines/IBANValidator.java?rev=1781587&r1=1781586&r2=1781587&view=diff
> >> > 
> >> > ==
> >> > --- commons/proper/validator/trunk/src/main/java/org/
> >> > apache/commons/validator/routines/IBANValidator.java (original)
> >> > +++ commons/proper/validator/trunk/src/main/java/org/
> >> > apache/commons/validator/routines/IBANValidator.java Fri Feb  3
> >> 18:58:57
> >> > 2017
> >> > @@ -94,78 +94,78 @@ public class IBANValidator {
> >> >   */
> >> >
> >> >  private static final Validator[] DEFAULT_FORMATS = {
> >> > -new Validator("AL", 28, "AL\\d{10}[A-Z0-9]{16}"
> >> >  ), // Albania
> >> >  new Validator("AD", 24, "AD\\d{10}[A-Z0-9]{12}"
> >> >  ), // Andorra
> >> > +new Validator("AE", 23, "AE\\d{21}"
> >> >  ), // United Arab Emirates
> >> > +new Validator("AL", 28, "AL\\d{10}[A-Z0-9]{16}"
> >> >  ), // Albania
> >> >  new Validator("AT", 20, "AT\\d{18}"
> >> >  ), // Austria
> >> >  new Validator("AZ", 28, "AZ\\d{2}[A-Z]{4}[A-Z0-9]{20}"
> >> >   ), // Republic of Azerbaijan
> >> > -new Validator("BH", 22, "BH\\d{2}[A-Z]{4}[A-Z0-9]{14}"
> >> >   ), // Bahrain (Kingdom of)
> >> > -new Validator("BE", 16, "BE\\d{14}"
> >> >  ), // Belgium
> >> >  new Validator("BA", 20, "BA\\d{18}"
> >> >  ), // Bosnia and Herzegovina
> >> > -new Validator("BR", 29, "BR\\d{25}[A-Z]{1}[A-Z0-9]{1}"
> >> >   ), // Brazil
> >> > +new Validator("BE", 16, "BE\\d{14}"
> >> >  ), // Belgium
> >> >  new Validator("BG", 22, "BG\\d{2}[A-Z]{4}\\d{6}[A-Z0-9
> >> ]{8}"
> >> >  ), // Bulgaria
> >> > +new Validator("BH", 22, "BH\\d{2}[A-Z]{4}[A-Z0-9]{14}"
> >> >   ), // Bahrain (Kingdom of)
> >> > +new Validator("BR", 29, "BR\\d{25}[A-Z]{1}[A-Z0-9]{1}"
> >> >   ), // Brazil
> >> > +new Validator("CH", 21, "CH\\d{7}[A-Z0-9]{12}"
> >> >   ), // Switzerland
> >> >  new Validator("CR", 22, "CR\\d{20}"
>