Re: [LANG] Proposing 3.0.1
sebb wrote: > On 6 August 2011 19:37, sebb wrote: >> On 5 August 2011 07:28, Jörg Schaible >> wrote: >>> Hi, >>> >>> Gary Gregory wrote: >>> On Wed, Aug 3, 2011 at 10:02 AM, Jörg Schaible wrote: > Hi Hen, > > Henri Yandell wrote: > >> I'd like to release 3.0.1 of Lang. > > Do we have any policies regarding Serializable types? I'd like to make > StrMatcher, StrLookup and StrSubstitutor serializable. One step > further to a serializable Configuration. I do not recall such a thing. We should document somewhere the fact that we do or do not have one though! In an overview.html or package html perhaps. >>> >>> Actually I am also unsure whether this counts as binary incompatible ... >>> ?!? >> >> AFAIK, implementing an interface is binary compatible, so adding >> Serializable is not an issue. >> >> However, implementing it is not always trivial, and changing the >> serialised form later can affect binary compat, so the implementation >> needs to be done carefully. > > By which I mean: if the serialisation format changes, then any old > serialised instances may be incompatible. Yeah, that's when you should change the UID again. - Jörg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [LANG] Proposing 3.0.1
On 6 August 2011 19:37, sebb wrote: > On 5 August 2011 07:28, Jörg Schaible wrote: >> Hi, >> >> Gary Gregory wrote: >> >>> On Wed, Aug 3, 2011 at 10:02 AM, Jörg Schaible >>> wrote: Hi Hen, Henri Yandell wrote: > I'd like to release 3.0.1 of Lang. Do we have any policies regarding Serializable types? I'd like to make StrMatcher, StrLookup and StrSubstitutor serializable. One step further to a serializable Configuration. >>> >>> I do not recall such a thing. We should document somewhere the fact >>> that we do or do not have one though! In an overview.html or package >>> html perhaps. >> >> Actually I am also unsure whether this counts as binary incompatible ... ?!? > > AFAIK, implementing an interface is binary compatible, so adding > Serializable is not an issue. > > However, implementing it is not always trivial, and changing the > serialised form later can affect binary compat, so the implementation > needs to be done carefully. By which I mean: if the serialisation format changes, then any old serialised instances may be incompatible. >> - Jörg >> >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [LANG] Proposing 3.0.1
On 5 August 2011 07:28, Jörg Schaible wrote: > Hi, > > Gary Gregory wrote: > >> On Wed, Aug 3, 2011 at 10:02 AM, Jörg Schaible >> wrote: >>> Hi Hen, >>> >>> Henri Yandell wrote: >>> I'd like to release 3.0.1 of Lang. >>> >>> Do we have any policies regarding Serializable types? I'd like to make >>> StrMatcher, StrLookup and StrSubstitutor serializable. One step further >>> to a serializable Configuration. >> >> I do not recall such a thing. We should document somewhere the fact >> that we do or do not have one though! In an overview.html or package >> html perhaps. > > Actually I am also unsure whether this counts as binary incompatible ... ?!? AFAIK, implementing an interface is binary compatible, so adding Serializable is not an issue. However, implementing it is not always trivial, and changing the serialised form later can affect binary compat, so the implementation needs to be done carefully. > - Jörg > > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [LANG] Proposing 3.0.1
Hi, Gary Gregory wrote: > On Wed, Aug 3, 2011 at 10:02 AM, Jörg Schaible > wrote: >> Hi Hen, >> >> Henri Yandell wrote: >> >>> I'd like to release 3.0.1 of Lang. >> >> Do we have any policies regarding Serializable types? I'd like to make >> StrMatcher, StrLookup and StrSubstitutor serializable. One step further >> to a serializable Configuration. > > I do not recall such a thing. We should document somewhere the fact > that we do or do not have one though! In an overview.html or package > html perhaps. Actually I am also unsure whether this counts as binary incompatible ... ?!? - Jörg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [LANG] Proposing 3.0.1
On Wed, Aug 3, 2011 at 10:02 AM, Jörg Schaible wrote: > Hi Hen, > > Henri Yandell wrote: > >> I'd like to release 3.0.1 of Lang. > > Do we have any policies regarding Serializable types? I'd like to make > StrMatcher, StrLookup and StrSubstitutor serializable. One step further to a > serializable Configuration. I do not recall such a thing. We should document somewhere the fact that we do or do not have one though! In an overview.html or package html perhaps. Gary > > Cheers, > Jörg > > > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- Thank you, Gary http://garygregory.wordpress.com/ http://garygregory.com/ http://people.apache.org/~ggregory/ http://twitter.com/GaryGregory - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [LANG] Proposing 3.0.1
Hi Hen, Henri Yandell wrote: > I'd like to release 3.0.1 of Lang. Do we have any policies regarding Serializable types? I'd like to make StrMatcher, StrLookup and StrSubstitutor serializable. One step further to a serializable Configuration. Cheers, Jörg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [LANG] Proposing 3.0.1
I've updated the site. * Checkstyle: A javadoc item that Matt has said he'll work on. * FindBugs: Complains about an NPE, however it's not true and is because FindBugs doesn't understand our Validate library. * PMD: Down to one item to do with equals + hashcode. Might be worth fixing, but no rush. Cobertura looks a bit weak for a couple of classes; TypeUtils and ToStringStyle stand out. Again no blocker. I've double checked that the items mentioned in Clirr have @since 3.0.1 (apart from any very recent changes, but IIRC they looked good too). One oddity in Clirr is that building under JDK 1.6 identifies enums as no longer having final values() methods. Interesting item :) Should go away when I build a release candidate under JDK 1.5 (Mac=1.6; RC's happen on my Linux machine). Generally things look good. Two JIRA items outstanding, neither are blockers and I'll be looking to push both to 3.0.2. Hen On Tue, Aug 2, 2011 at 12:49 AM, Henri Yandell wrote: > Here's a generated site: > > http://people.apache.org/~bayard/commons-lang-3.0.1-SNAPSHOT-site/ > > Review the additions in the clirr report. Note the checkstyle and > findbugs reports have items that need cleanup prior to release. > > Hen > > On Tue, Aug 2, 2011 at 12:27 AM, Henri Yandell wrote: >> I'd like to release 3.0.1 of Lang. It would contain the following 11 fixes: >> >> https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+LANG+AND+fixVersion+%3D+%223.0.1%22+AND+resolution+in+%28Fixed%2C+%22Won%27t+Fix%22%2C+Duplicate%2C+Invalid%2C+Incomplete%2C+%22Cannot+Reproduce%22%2C+Later%2C+%22Not+A+Problem%22%2C+Unresolved%29 >> >> LANG-611 Consider improvements in LANG-396 >> LANG-626 object cloning with SerializationUtils has classloader >> problems with no workaround >> LANG-708 StringEscapeUtils.escapeEcmaScript from lang3 cuts off long >> unicode string >> LANG-717 Specify source encoding for build >> LANG-720 StringEscapeUtils.escapeXml(input) outputs wrong results >> when an input contains characters in Supplementary Planes. >> LANG-721 Complement ArrayUtils.addAll() variants with by-index and >> by-value removal methods >> LANG-722 Add BooleanUtils.and/or varargs methods to complement xor >> LANG-723 Add mode and median Comparable... methods to ObjectUtils >> LANG-726 Add a method e.g. Range >> Range.intersectionWith(Range) >> LANG-727 ToStringBuilderTest.testReflectionHierarchyArrayList fails >> with IBM JDK 6 >> LANG-730 EnumSet -> BitVector >> >> Two issues were pushed back to 3.0.2 as 'not ready', and there are 54 >> items in 3.x for consideration. >> >> The biggest issue needing feedback would (imo) be LANG-626. >> >> I'll get a clirr report put together (and update the site); for now >> use this thread if you have any objections to a 3.0.1 release. >> >> Hen >> > - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [LANG] Proposing 3.0.1
Jörg Schaible wrote: [snip] > I'd like to add first a getRawMessage() calling super.getMessage() to > Contexted(Runtime)Exception as counter part to the > getFormattedExceptionMessage(). I'll do it this evening. Done. - Jörg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [LANG] Proposing 3.0.1
I love that we are still rolling along here :) Gary On Aug 2, 2011, at 3:50, Henri Yandell wrote: > Here's a generated site: > >http://people.apache.org/~bayard/commons-lang-3.0.1-SNAPSHOT-site/ > > Review the additions in the clirr report. Note the checkstyle and > findbugs reports have items that need cleanup prior to release. > > Hen > > On Tue, Aug 2, 2011 at 12:27 AM, Henri Yandell wrote: >> I'd like to release 3.0.1 of Lang. It would contain the following 11 fixes: >> >> https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+LANG+AND+fixVersion+%3D+%223.0.1%22+AND+resolution+in+%28Fixed%2C+%22Won%27t+Fix%22%2C+Duplicate%2C+Invalid%2C+Incomplete%2C+%22Cannot+Reproduce%22%2C+Later%2C+%22Not+A+Problem%22%2C+Unresolved%29 >> >> LANG-611Consider improvements in LANG-396 >> LANG-626object cloning with SerializationUtils has classloader >> problems with no workaround >> LANG-708StringEscapeUtils.escapeEcmaScript from lang3 cuts off long >> unicode string >> LANG-717Specify source encoding for build >> LANG-720StringEscapeUtils.escapeXml(input) outputs wrong results >> when an input contains characters in Supplementary Planes. >> LANG-721Complement ArrayUtils.addAll() variants with by-index and >> by-value removal methods >> LANG-722Add BooleanUtils.and/or varargs methods to complement xor >> LANG-723Add mode and median Comparable... methods to ObjectUtils >> LANG-726Add a method e.g. Range >> Range.intersectionWith(Range) >> LANG-727ToStringBuilderTest.testReflectionHierarchyArrayList fails >> with IBM JDK 6 >> LANG-730EnumSet -> BitVector >> >> Two issues were pushed back to 3.0.2 as 'not ready', and there are 54 >> items in 3.x for consideration. >> >> The biggest issue needing feedback would (imo) be LANG-626. >> >> I'll get a clirr report put together (and update the site); for now >> use this thread if you have any objections to a 3.0.1 release. >> >> Hen >> > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [LANG] Proposing 3.0.1
Here's a generated site: http://people.apache.org/~bayard/commons-lang-3.0.1-SNAPSHOT-site/ Review the additions in the clirr report. Note the checkstyle and findbugs reports have items that need cleanup prior to release. Hen On Tue, Aug 2, 2011 at 12:27 AM, Henri Yandell wrote: > I'd like to release 3.0.1 of Lang. It would contain the following 11 fixes: > > https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+LANG+AND+fixVersion+%3D+%223.0.1%22+AND+resolution+in+%28Fixed%2C+%22Won%27t+Fix%22%2C+Duplicate%2C+Invalid%2C+Incomplete%2C+%22Cannot+Reproduce%22%2C+Later%2C+%22Not+A+Problem%22%2C+Unresolved%29 > > LANG-611 Consider improvements in LANG-396 > LANG-626 object cloning with SerializationUtils has classloader > problems with no workaround > LANG-708 StringEscapeUtils.escapeEcmaScript from lang3 cuts off long > unicode string > LANG-717 Specify source encoding for build > LANG-720 StringEscapeUtils.escapeXml(input) outputs wrong results > when an input contains characters in Supplementary Planes. > LANG-721 Complement ArrayUtils.addAll() variants with by-index and > by-value removal methods > LANG-722 Add BooleanUtils.and/or varargs methods to complement xor > LANG-723 Add mode and median Comparable... methods to ObjectUtils > LANG-726 Add a method e.g. Range Range.intersectionWith(Range) > LANG-727 ToStringBuilderTest.testReflectionHierarchyArrayList fails > with IBM JDK 6 > LANG-730 EnumSet -> BitVector > > Two issues were pushed back to 3.0.2 as 'not ready', and there are 54 > items in 3.x for consideration. > > The biggest issue needing feedback would (imo) be LANG-626. > > I'll get a clirr report put together (and update the site); for now > use this thread if you have any objections to a 3.0.1 release. > > Hen > - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [LANG] Proposing 3.0.1
Hi Hen, Henri Yandell wrote: > I'd like to release 3.0.1 of Lang. It would contain the following 11 > fixes: > > https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&jqlQuery=project+%3D+LANG+AND+fixVersion+%3D+%223.0.1%22+AND+resolution+in+%28Fixed%2C+%22Won%27t+Fix%22%2C+Duplicate%2C+Invalid%2C+Incomplete%2C+%22Cannot+Reproduce%22%2C+Later%2C+%22Not+A+Problem%22%2C+Unresolved%29 > > LANG-611 Consider improvements in LANG-396 > LANG-626 object cloning with SerializationUtils has classloader > problems with no workaround > LANG-708 StringEscapeUtils.escapeEcmaScript from lang3 cuts off long > unicode string > LANG-717 Specify source encoding for build > LANG-720 StringEscapeUtils.escapeXml(input) outputs wrong results > when an input contains characters in Supplementary Planes. > LANG-721 Complement ArrayUtils.addAll() variants with by-index and > by-value removal methods > LANG-722 Add BooleanUtils.and/or varargs methods to complement xor > LANG-723 Add mode and median Comparable... methods to ObjectUtils > LANG-726 Add a method e.g. Range Range.intersectionWith(Range) > LANG-727 ToStringBuilderTest.testReflectionHierarchyArrayList fails > with IBM JDK 6 > LANG-730 EnumSet -> BitVector > > Two issues were pushed back to 3.0.2 as 'not ready', and there are 54 > items in 3.x for consideration. > > The biggest issue needing feedback would (imo) be LANG-626. > > I'll get a clirr report put together (and update the site); for now > use this thread if you have any objections to a 3.0.1 release. I'd like to add first a getRawMessage() calling super.getMessage() to Contexted(Runtime)Exception as counter part to the getFormattedExceptionMessage(). I'll do it this evening. Cheers, Jörg - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
