Re: [VOTE][CANCEL] Release Apache Commons Pool 2.6.1 based on RC1
yes, they are. I create a new test to showcase the problem and only then fix it. All other tests still pass. LieGrue, strub > Am 12.11.2018 um 16:05 schrieb Gary Gregory : > > Hi Mark, > > Too many bits flying around on my end here. Can you check that your changes > are covered by unit tests? That should do it I hope. > > Gary > > On Mon, Nov 12, 2018 at 12:56 AM Mark Struberg > wrote: > >> sorry should have read "did anyone TEST my pool fixes". >> >> LieGrue, >> strub >> >> >>> Am 10.11.2018 um 23:24 schrieb Gary Gregory : >>> >>> On Sat, Nov 10, 2018 at 1:24 PM Mark Struberg >> >>> wrote: >>> Did anyone fix my pool fixes? >>> >>> >>> Hi Mark, >>> >>> Can you be more specific or just check git master? >>> >>> The latest deployed pool and dbcp2 snapshots do contain them. >>> >>> So we are good then, right? >>> >>> Would love to start a release but I think I need some guidance. Any docs for how it runs in commons land? >>> >>> I think Rob updated the Wiki: >> https://commons.apache.org/releases/index.html >>> >>> Gary >>> >>> txs and LieGrue,strub On Friday, 2 November 2018, 17:01:44 CET, Gary Gregory < garydgreg...@gmail.com> wrote: I am cancelling this VOTE, long overdue, sorry. There are additional bug fixes that have come in as well... Gary On Thu, Aug 23, 2018 at 7:39 AM Gary Gregory wrote: > > > On Wed, Aug 22, 2018 at 1:14 PM Benedikt Ritter > wrote: > >> Hi Gary, >> Am Mi., 22. Aug. 2018 um 16:04 Uhr schrieb Gary Gregory < >> garydgreg...@gmail.com>: >> >>> WRT signing tags, ATM, I cannot git's -s option to work with GPG on >>> Windows. Any clues? >>> >> >> Sorry, I'm on macOS. For that to work I needed to have the gpg-agent >> running. But I don't know whether this is a unix thing. >> >> The tag signing alone would not cause me to vote -1. I can live with >> an >> unsigned tag. What really needs to be fixed are the differences >> between >> src >> distribution and release tag in my opinion. I'll have time on Saturday to >> have a look into that if you don't get to it until then. >> > > I welcome the help :-) Quite busy at work. > > Gary > >> >> Regards, >> Benedikt >> >> >>> >>> Gary >>> >>> On Tue, Aug 21, 2018 at 1:06 AM Benedikt Ritter >>> wrote: >>> Hello Gary, -1, I there are several issues that we need to fix this before we can release 2.6.1. I think the RELEASE NOTES need more work: "The Apache Commons Pool team is pleased to announce the release of >>> Apache Commons Pool 2.6.1-SNAPSHOT." "No client code changes are required to migrate from versions 2.0-2.3 >> to version 2.4.3." - what about migration to 2.6.1? "Version 2 requires JDK level 1.6 or above" - Website states that >> Java 7 >>> is required. The release tag is not signed: ~/w/a/r/p/commons-pool git:(master) > git tag -v >> commons-pool-2.6.1-RC1 object 87c5dc14a967a70dd6e640395d4e842b021cdb8f type commit tag commons-pool-2.6.1-RC1 tagger Gary Gregory 1534517006 -0600 Tag Apache Commons Pool release 2.6.1 RC1 error: no signature found There are various differences between to release tag in git and the contents of the src archive: ~/w/a/r/pool-2.6.1 > diff -rq commons-pool commons-pool2-2.6.1-src Only in commons-pool: .git Only in commons-pool: .gitignore Only in commons-pool: .travis.yml Only in commons-pool: CONTRIBUTING.md Files commons-pool/NOTICE.txt and commons-pool2-2.6.1-src/NOTICE.txt >>> differ Only in commons-pool: README.md Files commons-pool/RELEASE-NOTES.txt and commons-pool2-2.6.1-src/RELEASE-NOTES.txt differ Files commons-pool/pom.xml and commons-pool2-2.6.1-src/pom.xml differ Only in commons-pool: pool-RC.sh Only in commons-pool: pool-pre-RC.sh Only in commons-pool: pool-release.sh Only in commons-pool/src: assembly Files commons-pool/src/changes/changes.xml and commons-pool2-2.6.1-src/src/changes/changes.xml differ Files commons-pool/src/site/resources/download_pool.cgi and commons-pool2-2.6.1-src/src/site/resources/download_pool.cgi differ Files commons-pool/src/site/site.xml and commons-pool2-2.6.1-src/src/site/site.xml differ Files commons-pool/src/site/xdoc/index.xml and commons-pool2-2.6.1-src/src/site/xdoc/index.xml differ Files commons-pool/src/site/xdoc/issue-tracking.xml and commons-pool2-2.6.1-src/src/site/xdoc/issu
Re: [VOTE][CANCEL] Release Apache Commons Pool 2.6.1 based on RC1
Hi Mark, Too many bits flying around on my end here. Can you check that your changes are covered by unit tests? That should do it I hope. Gary On Mon, Nov 12, 2018 at 12:56 AM Mark Struberg wrote: > sorry should have read "did anyone TEST my pool fixes". > > LieGrue, > strub > > > > Am 10.11.2018 um 23:24 schrieb Gary Gregory : > > > > On Sat, Nov 10, 2018 at 1:24 PM Mark Struberg > > > wrote: > > > >> Did anyone fix my pool fixes? > > > > > > Hi Mark, > > > > Can you be more specific or just check git master? > > > > > >> The latest deployed pool and dbcp2 snapshots do contain them. > >> > > > > So we are good then, right? > > > > > >> Would love to start a release but I think I need some guidance. > >> Any docs for how it runs in commons land? > >> > > > > I think Rob updated the Wiki: > https://commons.apache.org/releases/index.html > > > > Gary > > > > > >> txs and LieGrue,strub > >> > >>On Friday, 2 November 2018, 17:01:44 CET, Gary Gregory < > >> garydgreg...@gmail.com> wrote: > >> > >> I am cancelling this VOTE, long overdue, sorry. There are additional bug > >> fixes that have come in as well... > >> > >> Gary > >> > >> On Thu, Aug 23, 2018 at 7:39 AM Gary Gregory > >> wrote: > >> > >>> > >>> > >>> On Wed, Aug 22, 2018 at 1:14 PM Benedikt Ritter > >>> wrote: > >>> > Hi Gary, > Am Mi., 22. Aug. 2018 um 16:04 Uhr schrieb Gary Gregory < > garydgreg...@gmail.com>: > > > WRT signing tags, ATM, I cannot git's -s option to work with GPG on > > Windows. Any clues? > > > > Sorry, I'm on macOS. For that to work I needed to have the gpg-agent > running. But I don't know whether this is a unix thing. > > The tag signing alone would not cause me to vote -1. I can live with > an > unsigned tag. What really needs to be fixed are the differences > between > src > distribution and release tag in my opinion. I'll have time on Saturday > >> to > have a look into that if you don't get to it until then. > > >>> > >>> I welcome the help :-) Quite busy at work. > >>> > >>> Gary > >>> > > Regards, > Benedikt > > > > > > Gary > > > > On Tue, Aug 21, 2018 at 1:06 AM Benedikt Ritter > > wrote: > > > >> Hello Gary, > >> > >> -1, I there are several issues that we need to fix this before we > >> can > >> release 2.6.1. > >> > >> I think the RELEASE NOTES need more work: > >> > >> "The Apache Commons Pool team is pleased to announce the release of > > Apache > >> Commons Pool 2.6.1-SNAPSHOT." > >> "No client code changes are required to migrate from versions > >> 2.0-2.3 > to > >> version 2.4.3." - what about migration to 2.6.1? > >> "Version 2 requires JDK level 1.6 or above" - Website states that > Java 7 > > is > >> required. > >> > >> The release tag is not signed: > >> ~/w/a/r/p/commons-pool git:(master) > git tag -v > commons-pool-2.6.1-RC1 > >> object 87c5dc14a967a70dd6e640395d4e842b021cdb8f > >> type commit > >> tag commons-pool-2.6.1-RC1 > >> tagger Gary Gregory 1534517006 -0600 > >> > >> Tag Apache Commons Pool release 2.6.1 RC1 > >> error: no signature found > >> > >> There are various differences between to release tag in git and the > >> contents of the src archive: > >> ~/w/a/r/pool-2.6.1 > diff -rq commons-pool commons-pool2-2.6.1-src > >> Only in commons-pool: .git > >> Only in commons-pool: .gitignore > >> Only in commons-pool: .travis.yml > >> Only in commons-pool: CONTRIBUTING.md > >> Files commons-pool/NOTICE.txt and commons-pool2-2.6.1-src/NOTICE.txt > > differ > >> Only in commons-pool: README.md > >> Files commons-pool/RELEASE-NOTES.txt and > >> commons-pool2-2.6.1-src/RELEASE-NOTES.txt differ > >> Files commons-pool/pom.xml and commons-pool2-2.6.1-src/pom.xml > >> differ > >> Only in commons-pool: pool-RC.sh > >> Only in commons-pool: pool-pre-RC.sh > >> Only in commons-pool: pool-release.sh > >> Only in commons-pool/src: assembly > >> Files commons-pool/src/changes/changes.xml and > >> commons-pool2-2.6.1-src/src/changes/changes.xml differ > >> Files commons-pool/src/site/resources/download_pool.cgi and > >> commons-pool2-2.6.1-src/src/site/resources/download_pool.cgi differ > >> Files commons-pool/src/site/site.xml and > >> commons-pool2-2.6.1-src/src/site/site.xml differ > >> Files commons-pool/src/site/xdoc/index.xml and > >> commons-pool2-2.6.1-src/src/site/xdoc/index.xml differ > >> Files commons-pool/src/site/xdoc/issue-tracking.xml and > >> commons-pool2-2.6.1-src/src/site/xdoc/issue-tracking.xml differ > >> > >> Some of them are okay (e.g. git files) but others are not (like > >> changes.xml) > >> > >> The build works on my machine using: > >> ~/w/a/r/p/commons-pool2-2.6.1-src > mvn -version > >> Apache
Re: [VOTE][CANCEL] Release Apache Commons Pool 2.6.1 based on RC1
sorry should have read "did anyone TEST my pool fixes". LieGrue, strub > Am 10.11.2018 um 23:24 schrieb Gary Gregory : > > On Sat, Nov 10, 2018 at 1:24 PM Mark Struberg > wrote: > >> Did anyone fix my pool fixes? > > > Hi Mark, > > Can you be more specific or just check git master? > > >> The latest deployed pool and dbcp2 snapshots do contain them. >> > > So we are good then, right? > > >> Would love to start a release but I think I need some guidance. >> Any docs for how it runs in commons land? >> > > I think Rob updated the Wiki: https://commons.apache.org/releases/index.html > > Gary > > >> txs and LieGrue,strub >> >>On Friday, 2 November 2018, 17:01:44 CET, Gary Gregory < >> garydgreg...@gmail.com> wrote: >> >> I am cancelling this VOTE, long overdue, sorry. There are additional bug >> fixes that have come in as well... >> >> Gary >> >> On Thu, Aug 23, 2018 at 7:39 AM Gary Gregory >> wrote: >> >>> >>> >>> On Wed, Aug 22, 2018 at 1:14 PM Benedikt Ritter >>> wrote: >>> Hi Gary, Am Mi., 22. Aug. 2018 um 16:04 Uhr schrieb Gary Gregory < garydgreg...@gmail.com>: > WRT signing tags, ATM, I cannot git's -s option to work with GPG on > Windows. Any clues? > Sorry, I'm on macOS. For that to work I needed to have the gpg-agent running. But I don't know whether this is a unix thing. The tag signing alone would not cause me to vote -1. I can live with an unsigned tag. What really needs to be fixed are the differences between src distribution and release tag in my opinion. I'll have time on Saturday >> to have a look into that if you don't get to it until then. >>> >>> I welcome the help :-) Quite busy at work. >>> >>> Gary >>> Regards, Benedikt > > Gary > > On Tue, Aug 21, 2018 at 1:06 AM Benedikt Ritter > wrote: > >> Hello Gary, >> >> -1, I there are several issues that we need to fix this before we >> can >> release 2.6.1. >> >> I think the RELEASE NOTES need more work: >> >> "The Apache Commons Pool team is pleased to announce the release of > Apache >> Commons Pool 2.6.1-SNAPSHOT." >> "No client code changes are required to migrate from versions >> 2.0-2.3 to >> version 2.4.3." - what about migration to 2.6.1? >> "Version 2 requires JDK level 1.6 or above" - Website states that Java 7 > is >> required. >> >> The release tag is not signed: >> ~/w/a/r/p/commons-pool git:(master) > git tag -v commons-pool-2.6.1-RC1 >> object 87c5dc14a967a70dd6e640395d4e842b021cdb8f >> type commit >> tag commons-pool-2.6.1-RC1 >> tagger Gary Gregory 1534517006 -0600 >> >> Tag Apache Commons Pool release 2.6.1 RC1 >> error: no signature found >> >> There are various differences between to release tag in git and the >> contents of the src archive: >> ~/w/a/r/pool-2.6.1 > diff -rq commons-pool commons-pool2-2.6.1-src >> Only in commons-pool: .git >> Only in commons-pool: .gitignore >> Only in commons-pool: .travis.yml >> Only in commons-pool: CONTRIBUTING.md >> Files commons-pool/NOTICE.txt and commons-pool2-2.6.1-src/NOTICE.txt > differ >> Only in commons-pool: README.md >> Files commons-pool/RELEASE-NOTES.txt and >> commons-pool2-2.6.1-src/RELEASE-NOTES.txt differ >> Files commons-pool/pom.xml and commons-pool2-2.6.1-src/pom.xml >> differ >> Only in commons-pool: pool-RC.sh >> Only in commons-pool: pool-pre-RC.sh >> Only in commons-pool: pool-release.sh >> Only in commons-pool/src: assembly >> Files commons-pool/src/changes/changes.xml and >> commons-pool2-2.6.1-src/src/changes/changes.xml differ >> Files commons-pool/src/site/resources/download_pool.cgi and >> commons-pool2-2.6.1-src/src/site/resources/download_pool.cgi differ >> Files commons-pool/src/site/site.xml and >> commons-pool2-2.6.1-src/src/site/site.xml differ >> Files commons-pool/src/site/xdoc/index.xml and >> commons-pool2-2.6.1-src/src/site/xdoc/index.xml differ >> Files commons-pool/src/site/xdoc/issue-tracking.xml and >> commons-pool2-2.6.1-src/src/site/xdoc/issue-tracking.xml differ >> >> Some of them are okay (e.g. git files) but others are not (like >> changes.xml) >> >> The build works on my machine using: >> ~/w/a/r/p/commons-pool2-2.6.1-src > mvn -version >> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; >> 2018-06-17T20:33:14+02:00) >> Maven home: /usr/local/Cellar/maven/3.5.4/libexec >> Java version: 1.8.0_161, vendor: Oracle Corporation, runtime: >> /Library/Java/JavaVirtualMachines/jdk1.8.0_161.jdk/Contents/Home/jre >> Default locale: de_DE, platform encoding: UTF-8 >> OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: >> "mac" >> >> Regards, >> Benedi
Re: [VOTE][CANCEL] Release Apache Commons Pool 2.6.1 based on RC1
On Sat, Nov 10, 2018 at 1:24 PM Mark Struberg wrote: > Did anyone fix my pool fixes? Hi Mark, Can you be more specific or just check git master? > The latest deployed pool and dbcp2 snapshots do contain them. > So we are good then, right? > Would love to start a release but I think I need some guidance. > Any docs for how it runs in commons land? > I think Rob updated the Wiki: https://commons.apache.org/releases/index.html Gary > txs and LieGrue,strub > > On Friday, 2 November 2018, 17:01:44 CET, Gary Gregory < > garydgreg...@gmail.com> wrote: > > I am cancelling this VOTE, long overdue, sorry. There are additional bug > fixes that have come in as well... > > Gary > > On Thu, Aug 23, 2018 at 7:39 AM Gary Gregory > wrote: > > > > > > > On Wed, Aug 22, 2018 at 1:14 PM Benedikt Ritter > > wrote: > > > >> Hi Gary, > >> Am Mi., 22. Aug. 2018 um 16:04 Uhr schrieb Gary Gregory < > >> garydgreg...@gmail.com>: > >> > >> > WRT signing tags, ATM, I cannot git's -s option to work with GPG on > >> > Windows. Any clues? > >> > > >> > >> Sorry, I'm on macOS. For that to work I needed to have the gpg-agent > >> running. But I don't know whether this is a unix thing. > >> > >> The tag signing alone would not cause me to vote -1. I can live with an > >> unsigned tag. What really needs to be fixed are the differences between > >> src > >> distribution and release tag in my opinion. I'll have time on Saturday > to > >> have a look into that if you don't get to it until then. > >> > > > > I welcome the help :-) Quite busy at work. > > > > Gary > > > >> > >> Regards, > >> Benedikt > >> > >> > >> > > >> > Gary > >> > > >> > On Tue, Aug 21, 2018 at 1:06 AM Benedikt Ritter > >> > wrote: > >> > > >> > > Hello Gary, > >> > > > >> > > -1, I there are several issues that we need to fix this before we > can > >> > > release 2.6.1. > >> > > > >> > > I think the RELEASE NOTES need more work: > >> > > > >> > > "The Apache Commons Pool team is pleased to announce the release of > >> > Apache > >> > > Commons Pool 2.6.1-SNAPSHOT." > >> > > "No client code changes are required to migrate from versions > 2.0-2.3 > >> to > >> > > version 2.4.3." - what about migration to 2.6.1? > >> > > "Version 2 requires JDK level 1.6 or above" - Website states that > >> Java 7 > >> > is > >> > > required. > >> > > > >> > > The release tag is not signed: > >> > > ~/w/a/r/p/commons-pool git:(master) > git tag -v > >> commons-pool-2.6.1-RC1 > >> > > object 87c5dc14a967a70dd6e640395d4e842b021cdb8f > >> > > type commit > >> > > tag commons-pool-2.6.1-RC1 > >> > > tagger Gary Gregory 1534517006 -0600 > >> > > > >> > > Tag Apache Commons Pool release 2.6.1 RC1 > >> > > error: no signature found > >> > > > >> > > There are various differences between to release tag in git and the > >> > > contents of the src archive: > >> > > ~/w/a/r/pool-2.6.1 > diff -rq commons-pool commons-pool2-2.6.1-src > >> > > Only in commons-pool: .git > >> > > Only in commons-pool: .gitignore > >> > > Only in commons-pool: .travis.yml > >> > > Only in commons-pool: CONTRIBUTING.md > >> > > Files commons-pool/NOTICE.txt and commons-pool2-2.6.1-src/NOTICE.txt > >> > differ > >> > > Only in commons-pool: README.md > >> > > Files commons-pool/RELEASE-NOTES.txt and > >> > > commons-pool2-2.6.1-src/RELEASE-NOTES.txt differ > >> > > Files commons-pool/pom.xml and commons-pool2-2.6.1-src/pom.xml > differ > >> > > Only in commons-pool: pool-RC.sh > >> > > Only in commons-pool: pool-pre-RC.sh > >> > > Only in commons-pool: pool-release.sh > >> > > Only in commons-pool/src: assembly > >> > > Files commons-pool/src/changes/changes.xml and > >> > > commons-pool2-2.6.1-src/src/changes/changes.xml differ > >> > > Files commons-pool/src/site/resources/download_pool.cgi and > >> > > commons-pool2-2.6.1-src/src/site/resources/download_pool.cgi differ > >> > > Files commons-pool/src/site/site.xml and > >> > > commons-pool2-2.6.1-src/src/site/site.xml differ > >> > > Files commons-pool/src/site/xdoc/index.xml and > >> > > commons-pool2-2.6.1-src/src/site/xdoc/index.xml differ > >> > > Files commons-pool/src/site/xdoc/issue-tracking.xml and > >> > > commons-pool2-2.6.1-src/src/site/xdoc/issue-tracking.xml differ > >> > > > >> > > Some of them are okay (e.g. git files) but others are not (like > >> > > changes.xml) > >> > > > >> > > The build works on my machine using: > >> > > ~/w/a/r/p/commons-pool2-2.6.1-src > mvn -version > >> > > Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; > >> > > 2018-06-17T20:33:14+02:00) > >> > > Maven home: /usr/local/Cellar/maven/3.5.4/libexec > >> > > Java version: 1.8.0_161, vendor: Oracle Corporation, runtime: > >> > > /Library/Java/JavaVirtualMachines/jdk1.8.0_161.jdk/Contents/Home/jre > >> > > Default locale: de_DE, platform encoding: UTF-8 > >> > > OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: > "mac" > >> > > > >> > > Regards, > >> > > Benedikt > >> > > > >> > > Am Fr., 17. Aug. 2018 um 18:08 Uhr schrieb Gary Gregor
Re: [VOTE][CANCEL] Release Apache Commons Pool 2.6.1 based on RC1
Did anyone fix my pool fixes?The latest deployed pool and dbcp2 snapshots do contain them. Would love to start a release but I think I need some guidance. Any docs for how it runs in commons land? txs and LieGrue,strub On Friday, 2 November 2018, 17:01:44 CET, Gary Gregory wrote: I am cancelling this VOTE, long overdue, sorry. There are additional bug fixes that have come in as well... Gary On Thu, Aug 23, 2018 at 7:39 AM Gary Gregory wrote: > > > On Wed, Aug 22, 2018 at 1:14 PM Benedikt Ritter > wrote: > >> Hi Gary, >> Am Mi., 22. Aug. 2018 um 16:04 Uhr schrieb Gary Gregory < >> garydgreg...@gmail.com>: >> >> > WRT signing tags, ATM, I cannot git's -s option to work with GPG on >> > Windows. Any clues? >> > >> >> Sorry, I'm on macOS. For that to work I needed to have the gpg-agent >> running. But I don't know whether this is a unix thing. >> >> The tag signing alone would not cause me to vote -1. I can live with an >> unsigned tag. What really needs to be fixed are the differences between >> src >> distribution and release tag in my opinion. I'll have time on Saturday to >> have a look into that if you don't get to it until then. >> > > I welcome the help :-) Quite busy at work. > > Gary > >> >> Regards, >> Benedikt >> >> >> > >> > Gary >> > >> > On Tue, Aug 21, 2018 at 1:06 AM Benedikt Ritter >> > wrote: >> > >> > > Hello Gary, >> > > >> > > -1, I there are several issues that we need to fix this before we can >> > > release 2.6.1. >> > > >> > > I think the RELEASE NOTES need more work: >> > > >> > > "The Apache Commons Pool team is pleased to announce the release of >> > Apache >> > > Commons Pool 2.6.1-SNAPSHOT." >> > > "No client code changes are required to migrate from versions 2.0-2.3 >> to >> > > version 2.4.3." - what about migration to 2.6.1? >> > > "Version 2 requires JDK level 1.6 or above" - Website states that >> Java 7 >> > is >> > > required. >> > > >> > > The release tag is not signed: >> > > ~/w/a/r/p/commons-pool git:(master) > git tag -v >> commons-pool-2.6.1-RC1 >> > > object 87c5dc14a967a70dd6e640395d4e842b021cdb8f >> > > type commit >> > > tag commons-pool-2.6.1-RC1 >> > > tagger Gary Gregory 1534517006 -0600 >> > > >> > > Tag Apache Commons Pool release 2.6.1 RC1 >> > > error: no signature found >> > > >> > > There are various differences between to release tag in git and the >> > > contents of the src archive: >> > > ~/w/a/r/pool-2.6.1 > diff -rq commons-pool commons-pool2-2.6.1-src >> > > Only in commons-pool: .git >> > > Only in commons-pool: .gitignore >> > > Only in commons-pool: .travis.yml >> > > Only in commons-pool: CONTRIBUTING.md >> > > Files commons-pool/NOTICE.txt and commons-pool2-2.6.1-src/NOTICE.txt >> > differ >> > > Only in commons-pool: README.md >> > > Files commons-pool/RELEASE-NOTES.txt and >> > > commons-pool2-2.6.1-src/RELEASE-NOTES.txt differ >> > > Files commons-pool/pom.xml and commons-pool2-2.6.1-src/pom.xml differ >> > > Only in commons-pool: pool-RC.sh >> > > Only in commons-pool: pool-pre-RC.sh >> > > Only in commons-pool: pool-release.sh >> > > Only in commons-pool/src: assembly >> > > Files commons-pool/src/changes/changes.xml and >> > > commons-pool2-2.6.1-src/src/changes/changes.xml differ >> > > Files commons-pool/src/site/resources/download_pool.cgi and >> > > commons-pool2-2.6.1-src/src/site/resources/download_pool.cgi differ >> > > Files commons-pool/src/site/site.xml and >> > > commons-pool2-2.6.1-src/src/site/site.xml differ >> > > Files commons-pool/src/site/xdoc/index.xml and >> > > commons-pool2-2.6.1-src/src/site/xdoc/index.xml differ >> > > Files commons-pool/src/site/xdoc/issue-tracking.xml and >> > > commons-pool2-2.6.1-src/src/site/xdoc/issue-tracking.xml differ >> > > >> > > Some of them are okay (e.g. git files) but others are not (like >> > > changes.xml) >> > > >> > > The build works on my machine using: >> > > ~/w/a/r/p/commons-pool2-2.6.1-src > mvn -version >> > > Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; >> > > 2018-06-17T20:33:14+02:00) >> > > Maven home: /usr/local/Cellar/maven/3.5.4/libexec >> > > Java version: 1.8.0_161, vendor: Oracle Corporation, runtime: >> > > /Library/Java/JavaVirtualMachines/jdk1.8.0_161.jdk/Contents/Home/jre >> > > Default locale: de_DE, platform encoding: UTF-8 >> > > OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac" >> > > >> > > Regards, >> > > Benedikt >> > > >> > > Am Fr., 17. Aug. 2018 um 18:08 Uhr schrieb Gary Gregory < >> > > ggreg...@apache.org >> > > >: >> > > >> > > > We have fixed one bug and updated optional dependencies since Apache >> > > > Commons Pool 2.6.0 was released, so I would like to release Apache >> > > Commons >> > > > Pool 2.6.1. >> > > > >> > > > Apache Commons Pool 2.6.1 RC1 is available for review here: >> > > > https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1 >> (svn >> > > > revision 28810) >> > > > >> > > > The Git tag commons-pool-2.6.1-RC1 commit for this RC is >> > > > 87c5dc14a967a70dd
Re: [VOTE][CANCEL] Release Apache Commons Pool 2.6.1 based on RC1
Hi Mark, I think you should give RM'ing a shot. We have a nice new release plugin that helps a lot. Rob is planning on refining the Commons release docs, if he has not already done so. Gary On Mon, Oct 29, 2018, 01:02 Mark Struberg wrote: > Txs gary! > > When will there be a new reelase run? > > If it's worth I could also do the release manager IF the project is > properly set up. > Means if it's a straight forward maven release then I gonna run it the > same as my other dozen ASF projects. > > LieGrue, > strub > > > > Am 28.10.2018 um 15:29 schrieb Gary Gregory : > > > > I am canceling this VOTE. It is stale and I've not taken the time to look > > into the tagging issue. Furthermore, there are additional fixes that have > > just come in. > > > > Gary > > > > On Thu, Aug 23, 2018 at 7:39 AM Gary Gregory > wrote: > > > >> > >> > >> On Wed, Aug 22, 2018 at 1:14 PM Benedikt Ritter > >> wrote: > >> > >>> Hi Gary, > >>> Am Mi., 22. Aug. 2018 um 16:04 Uhr schrieb Gary Gregory < > >>> garydgreg...@gmail.com>: > >>> > WRT signing tags, ATM, I cannot git's -s option to work with GPG on > Windows. Any clues? > > >>> > >>> Sorry, I'm on macOS. For that to work I needed to have the gpg-agent > >>> running. But I don't know whether this is a unix thing. > >>> > >>> The tag signing alone would not cause me to vote -1. I can live with an > >>> unsigned tag. What really needs to be fixed are the differences between > >>> src > >>> distribution and release tag in my opinion. I'll have time on Saturday > to > >>> have a look into that if you don't get to it until then. > >>> > >> > >> I welcome the help :-) Quite busy at work. > >> > >> Gary > >> > >>> > >>> Regards, > >>> Benedikt > >>> > >>> > > Gary > > On Tue, Aug 21, 2018 at 1:06 AM Benedikt Ritter > wrote: > > > Hello Gary, > > > > -1, I there are several issues that we need to fix this before we can > > release 2.6.1. > > > > I think the RELEASE NOTES need more work: > > > > "The Apache Commons Pool team is pleased to announce the release of > Apache > > Commons Pool 2.6.1-SNAPSHOT." > > "No client code changes are required to migrate from versions 2.0-2.3 > >>> to > > version 2.4.3." - what about migration to 2.6.1? > > "Version 2 requires JDK level 1.6 or above" - Website states that > >>> Java 7 > is > > required. > > > > The release tag is not signed: > > ~/w/a/r/p/commons-pool git:(master) > git tag -v > >>> commons-pool-2.6.1-RC1 > > object 87c5dc14a967a70dd6e640395d4e842b021cdb8f > > type commit > > tag commons-pool-2.6.1-RC1 > > tagger Gary Gregory 1534517006 -0600 > > > > Tag Apache Commons Pool release 2.6.1 RC1 > > error: no signature found > > > > There are various differences between to release tag in git and the > > contents of the src archive: > > ~/w/a/r/pool-2.6.1 > diff -rq commons-pool commons-pool2-2.6.1-src > > Only in commons-pool: .git > > Only in commons-pool: .gitignore > > Only in commons-pool: .travis.yml > > Only in commons-pool: CONTRIBUTING.md > > Files commons-pool/NOTICE.txt and commons-pool2-2.6.1-src/NOTICE.txt > differ > > Only in commons-pool: README.md > > Files commons-pool/RELEASE-NOTES.txt and > > commons-pool2-2.6.1-src/RELEASE-NOTES.txt differ > > Files commons-pool/pom.xml and commons-pool2-2.6.1-src/pom.xml differ > > Only in commons-pool: pool-RC.sh > > Only in commons-pool: pool-pre-RC.sh > > Only in commons-pool: pool-release.sh > > Only in commons-pool/src: assembly > > Files commons-pool/src/changes/changes.xml and > > commons-pool2-2.6.1-src/src/changes/changes.xml differ > > Files commons-pool/src/site/resources/download_pool.cgi and > > commons-pool2-2.6.1-src/src/site/resources/download_pool.cgi differ > > Files commons-pool/src/site/site.xml and > > commons-pool2-2.6.1-src/src/site/site.xml differ > > Files commons-pool/src/site/xdoc/index.xml and > > commons-pool2-2.6.1-src/src/site/xdoc/index.xml differ > > Files commons-pool/src/site/xdoc/issue-tracking.xml and > > commons-pool2-2.6.1-src/src/site/xdoc/issue-tracking.xml differ > > > > Some of them are okay (e.g. git files) but others are not (like > > changes.xml) > > > > The build works on my machine using: > > ~/w/a/r/p/commons-pool2-2.6.1-src > mvn -version > > Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; > > 2018-06-17T20:33:14+02:00) > > Maven home: /usr/local/Cellar/maven/3.5.4/libexec > > Java version: 1.8.0_161, vendor: Oracle Corporation, runtime: > > /Library/Java/JavaVirtualMachines/jdk1.8.0_161.jdk/Contents/Home/jre > > Default locale: de_DE, platform encoding: UTF-8 > > OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: > "mac" > > > > Regards, > > Benedikt > > > > Am Fr., 17. Aug.
Re: [VOTE][CANCEL] Release Apache Commons Pool 2.6.1 based on RC1
Txs gary! When will there be a new reelase run? If it's worth I could also do the release manager IF the project is properly set up. Means if it's a straight forward maven release then I gonna run it the same as my other dozen ASF projects. LieGrue, strub > Am 28.10.2018 um 15:29 schrieb Gary Gregory : > > I am canceling this VOTE. It is stale and I've not taken the time to look > into the tagging issue. Furthermore, there are additional fixes that have > just come in. > > Gary > > On Thu, Aug 23, 2018 at 7:39 AM Gary Gregory wrote: > >> >> >> On Wed, Aug 22, 2018 at 1:14 PM Benedikt Ritter >> wrote: >> >>> Hi Gary, >>> Am Mi., 22. Aug. 2018 um 16:04 Uhr schrieb Gary Gregory < >>> garydgreg...@gmail.com>: >>> WRT signing tags, ATM, I cannot git's -s option to work with GPG on Windows. Any clues? >>> >>> Sorry, I'm on macOS. For that to work I needed to have the gpg-agent >>> running. But I don't know whether this is a unix thing. >>> >>> The tag signing alone would not cause me to vote -1. I can live with an >>> unsigned tag. What really needs to be fixed are the differences between >>> src >>> distribution and release tag in my opinion. I'll have time on Saturday to >>> have a look into that if you don't get to it until then. >>> >> >> I welcome the help :-) Quite busy at work. >> >> Gary >> >>> >>> Regards, >>> Benedikt >>> >>> Gary On Tue, Aug 21, 2018 at 1:06 AM Benedikt Ritter wrote: > Hello Gary, > > -1, I there are several issues that we need to fix this before we can > release 2.6.1. > > I think the RELEASE NOTES need more work: > > "The Apache Commons Pool team is pleased to announce the release of Apache > Commons Pool 2.6.1-SNAPSHOT." > "No client code changes are required to migrate from versions 2.0-2.3 >>> to > version 2.4.3." - what about migration to 2.6.1? > "Version 2 requires JDK level 1.6 or above" - Website states that >>> Java 7 is > required. > > The release tag is not signed: > ~/w/a/r/p/commons-pool git:(master) > git tag -v >>> commons-pool-2.6.1-RC1 > object 87c5dc14a967a70dd6e640395d4e842b021cdb8f > type commit > tag commons-pool-2.6.1-RC1 > tagger Gary Gregory 1534517006 -0600 > > Tag Apache Commons Pool release 2.6.1 RC1 > error: no signature found > > There are various differences between to release tag in git and the > contents of the src archive: > ~/w/a/r/pool-2.6.1 > diff -rq commons-pool commons-pool2-2.6.1-src > Only in commons-pool: .git > Only in commons-pool: .gitignore > Only in commons-pool: .travis.yml > Only in commons-pool: CONTRIBUTING.md > Files commons-pool/NOTICE.txt and commons-pool2-2.6.1-src/NOTICE.txt differ > Only in commons-pool: README.md > Files commons-pool/RELEASE-NOTES.txt and > commons-pool2-2.6.1-src/RELEASE-NOTES.txt differ > Files commons-pool/pom.xml and commons-pool2-2.6.1-src/pom.xml differ > Only in commons-pool: pool-RC.sh > Only in commons-pool: pool-pre-RC.sh > Only in commons-pool: pool-release.sh > Only in commons-pool/src: assembly > Files commons-pool/src/changes/changes.xml and > commons-pool2-2.6.1-src/src/changes/changes.xml differ > Files commons-pool/src/site/resources/download_pool.cgi and > commons-pool2-2.6.1-src/src/site/resources/download_pool.cgi differ > Files commons-pool/src/site/site.xml and > commons-pool2-2.6.1-src/src/site/site.xml differ > Files commons-pool/src/site/xdoc/index.xml and > commons-pool2-2.6.1-src/src/site/xdoc/index.xml differ > Files commons-pool/src/site/xdoc/issue-tracking.xml and > commons-pool2-2.6.1-src/src/site/xdoc/issue-tracking.xml differ > > Some of them are okay (e.g. git files) but others are not (like > changes.xml) > > The build works on my machine using: > ~/w/a/r/p/commons-pool2-2.6.1-src > mvn -version > Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; > 2018-06-17T20:33:14+02:00) > Maven home: /usr/local/Cellar/maven/3.5.4/libexec > Java version: 1.8.0_161, vendor: Oracle Corporation, runtime: > /Library/Java/JavaVirtualMachines/jdk1.8.0_161.jdk/Contents/Home/jre > Default locale: de_DE, platform encoding: UTF-8 > OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac" > > Regards, > Benedikt > > Am Fr., 17. Aug. 2018 um 18:08 Uhr schrieb Gary Gregory < > ggreg...@apache.org >> : > >> We have fixed one bug and updated optional dependencies since Apache >> Commons Pool 2.6.0 was released, so I would like to release Apache > Commons >> Pool 2.6.1. >> >> Apache Commons Pool 2.6.1 RC1 is available for review here: >>https://dist.apache.org/repos/dist/dev/commons/pool/2.6.1-RC1 >>> (svn >> revision 28810) >> >> The Git tag commons-po
