Re: [VOTE] Release Apache Commons CSV 1.8 based on RC2

2020-02-06 Thread Gary Gregory 
My +1

Gary

On Sat, Feb 1, 2020 at 8:55 PM Gary Gregory  wrote:

> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons CSV 1.7 was released, so I would like to release
> Apache Commons CSV 1.8.
>
> Apache Commons CSV 1.8 RC2 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2 (svn
> revision 37829)
>
> The Git tag commons-csv-1.8-RC2 commit for this RC is
> 660f7c9f853092ec8abf5d6c81d260e3c80c2194 which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-csv.git;a=commit;h=660f7c9f853092ec8abf5d6c81d260e3c80c2194
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-csv.git
> --branch commons-csv-1.8-RC2 commons-csv-1.8-RC2
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1490/org/apache/commons/commons-csv/1.8/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Sat Feb 01 20:19:25 EST 2020
>
> commons-csv-1.8-bin.tar.gz=ed0ebd0fdae603480b83dca93a1591161c5939b69306ab8eab17e4cd578157f3aadfe81796ec4c180b6e0f9a143507ffcfb123fe181163cf78b3ca0d1c7c9438
>
> commons-csv-1.8-bin.zip=e9ff3bfef662e89b15019a33272e3a44e68cc8ee3c44fa2559021612158f154180b8e5bf0704f5e2453ed5a36061df76bdf9f9d36918c11e0a311107a653317c
>
> commons-csv-1.8-javadoc.jar=c26f284b98adf6321d84dd426ab8fbbf7ab1d4e3c43bfb62b9b3ce0706399a6034837a8f1164fc66f810c8282a82f168b0ab077d917e45991df337ece6b61d3c
>
> commons-csv-1.8-sources.jar=4d716b1cb7c2e75253bc7e89a49caf5acb80112974ca4211a5dfabcca5602177bcc2f0796a23f4fbed3eb2f84212507aac124b44acef80b424bdf1f0862d7069
>
> commons-csv-1.8-src.tar.gz=e0a7f7dbb0bf381f0f8f703e0ccb689f96c0a610b7afbd771cfeecab7042416f6dddc15c0a6e9a23f157da87c2bf3f16efb2e2aeb135ef1ac8c7306659936443
>
> commons-csv-1.8-src.zip=4703f33559ac1fc90aaf5d86408bc593554ef251d01ea5b14d24946d1cd9c7dab74ff96711375befec2b0314d53f907318494d3ba943982c6eb344af29cf6236
>
> commons-csv-1.8-test-sources.jar=d0016b3c8ce139a775f376c1b268295f553b97487ce1a9e1a1cce20e3d0b9e709143a44f22c02aa4fc1e1ecc4812de82c14c1b082c644c5ca5bba80230140405
>
> commons-csv-1.8-tests.jar=11c109f650643fe8f9da6f46c9c6467728bdbf89484d74a8a71ce1d0b347d5e4f16228eaeb6d1507de2244d7ebea0fc9f5efa869ce5d535ad5d0fa0306cb6dc9
>
> I have tested this with 'mvn -V -Prelease -Ptest-deploy -P jacoco -P
> japicmp clean package site deploy' using:
>
> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: C:\Java\apache-maven-3.6.3\bin\..
> Java version: 1.8.0_241, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk1.8.0_241\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>
> Details of changes since 1.7 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/changes-report.html
>
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/index.html
> (note some *relative* links are broken and the 1.8 directories are not
> yet created - these will be OK once the site is deployed.)
>
> JApiCmp Report (compared to 1.7):
>
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/japicmp.html
> This release fixes serialization compatibility of CSVRecord with
> versions 1.0 to 1.6. New fields added since
> 1.7 are not serialized. Support for Serializable is scheduled to be
> removed in version 2.0.
>
> RAT Report:
>
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thank you,
>
> Gary Gregory,
> Release Manager (using key 86fdc7e2a11262cb)
>
> For following is intended as a helper and refresher for reviewers.
>
> Validating a release candidate
> ==
>
> These guidelines are NOT complete.
>
> Requirements: Git, Java, Maven.
>
> You can validate a release from a release candidate (RC) tag as follows.
>
> 1) Clone and checkout the RC tag
>
> git clone https://gitbox.apache.org/repos/asf/commons-csv.git --branch
> commons-csv-1.8-RC2 commons-csv-1.8-RC2
> cd commons-csv-1.8-RC2
>
> 2) Check Apache licenses
>
> This step is not required if the site includes a RAT report page which you
> then must check.
>
> mvn apache-rat:check
>
> 3) Check binary compatibility
>
> Older components still use Apache Clirr:
>
> This step is not required if the site includes a Clirr report page which
> you then must check.
>
> mvn clirr:check
>
> Newer components use JApiCmp with the japicmp Maven Profile:
>
> This step is not required if the site includes a JApiCmp report page

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC2

2020-02-06 Thread Alex Herbert 

Verified from the git tag using:

Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /usr/local/apache-maven-3.6.3
Java version: 1.8.0_242, vendor: Private Build, runtime: 
/usr/lib/jvm/java-8-openjdk-amd64/jre

Default locale: en_GB, platform encoding: UTF-8
OS name: "linux", version: "4.4.0-173-generic", arch: "amd64", family: 
"unix"


mvn clean package site -P japicmp


Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /usr/local/apache-maven-3.6.3
Java version: 11.0.5, vendor: AdoptOpenJDK, runtime: 
/usr/lib/jvm/jdk-11.0.5+10

Default locale: en_GB, platform encoding: UTF-8
OS name: "linux", version: "4.4.0-173-generic", arch: "amd64", family: 
"unix"


mvn clean package site -P japicmp


Verified from the both the download tar.gz and .zip source archives using:

Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /usr/local/apache-maven-3.6.3
Java version: 11.0.5, vendor: AdoptOpenJDK, runtime: 
/usr/lib/jvm/jdk-11.0.5+10

Default locale: en_GB, platform encoding: UTF-8
OS name: "linux", version: "4.4.0-173-generic", arch: "amd64", family: 
"unix"


mvn test install


Verified all the 512 sums match. Verified the ASC signatures.


Site reports look good.

We now have a 'Bad Practice' bug for not setting the CSVRecord.parser 
field on deserialisation. Since this is intentional to allow it to be 
null after deserialisation then this should be put as an exclusion in 
the FindBugs config.


There are quite a few skipped tests in CSVRecord and TODO comments in 
the tag list report. Comparing to the live CSV 1.7 site the number of 
skipped tests is the same and there is only one extra NOTE tag. This is OK.



+1 (binding)

Alex


On 06/02/2020 14:15, Gary Gregory wrote:

May I get more binding votes please?

Gary

On Sat, Feb 1, 2020 at 8:55 PM Gary Gregory  wrote:


We have fixed quite a few bugs and added some significant enhancements
since Apache Commons CSV 1.7 was released, so I would like to release
Apache Commons CSV 1.8.

Apache Commons CSV 1.8 RC2 is available for review here:
 https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2 (svn
revision 37829)

The Git tag commons-csv-1.8-RC2 commit for this RC is
660f7c9f853092ec8abf5d6c81d260e3c80c2194 which you can browse here:

https://gitbox.apache.org/repos/asf?p=commons-csv.git;a=commit;h=660f7c9f853092ec8abf5d6c81d260e3c80c2194
You may checkout this tag using:
 git clone https://gitbox.apache.org/repos/asf/commons-csv.git
--branch commons-csv-1.8-RC2 commons-csv-1.8-RC2

Maven artifacts are here:

https://repository.apache.org/content/repositories/orgapachecommons-1490/org/apache/commons/commons-csv/1.8/

These are the artifacts and their hashes:

#Release SHA-512s
#Sat Feb 01 20:19:25 EST 2020

commons-csv-1.8-bin.tar.gz=ed0ebd0fdae603480b83dca93a1591161c5939b69306ab8eab17e4cd578157f3aadfe81796ec4c180b6e0f9a143507ffcfb123fe181163cf78b3ca0d1c7c9438

commons-csv-1.8-bin.zip=e9ff3bfef662e89b15019a33272e3a44e68cc8ee3c44fa2559021612158f154180b8e5bf0704f5e2453ed5a36061df76bdf9f9d36918c11e0a311107a653317c

commons-csv-1.8-javadoc.jar=c26f284b98adf6321d84dd426ab8fbbf7ab1d4e3c43bfb62b9b3ce0706399a6034837a8f1164fc66f810c8282a82f168b0ab077d917e45991df337ece6b61d3c

commons-csv-1.8-sources.jar=4d716b1cb7c2e75253bc7e89a49caf5acb80112974ca4211a5dfabcca5602177bcc2f0796a23f4fbed3eb2f84212507aac124b44acef80b424bdf1f0862d7069

commons-csv-1.8-src.tar.gz=e0a7f7dbb0bf381f0f8f703e0ccb689f96c0a610b7afbd771cfeecab7042416f6dddc15c0a6e9a23f157da87c2bf3f16efb2e2aeb135ef1ac8c7306659936443

commons-csv-1.8-src.zip=4703f33559ac1fc90aaf5d86408bc593554ef251d01ea5b14d24946d1cd9c7dab74ff96711375befec2b0314d53f907318494d3ba943982c6eb344af29cf6236

commons-csv-1.8-test-sources.jar=d0016b3c8ce139a775f376c1b268295f553b97487ce1a9e1a1cce20e3d0b9e709143a44f22c02aa4fc1e1ecc4812de82c14c1b082c644c5ca5bba80230140405

commons-csv-1.8-tests.jar=11c109f650643fe8f9da6f46c9c6467728bdbf89484d74a8a71ce1d0b347d5e4f16228eaeb6d1507de2244d7ebea0fc9f5efa869ce5d535ad5d0fa0306cb6dc9

I have tested this with 'mvn -V -Prelease -Ptest-deploy -P jacoco -P
japicmp clean package site deploy' using:

Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: C:\Java\apache-maven-3.6.3\bin\..
Java version: 1.8.0_241, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\jdk1.8.0_241\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Details of changes since 1.7 are in the release notes:

https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/RELEASE-NOTES.txt

https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/changes-report.html

Site:

https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/index.html
 (note some *relative* links are broken and the 1.8 directories are not
yet created - these will be OK once the site is deployed.)

JApiCmp Report (compared to 1.7):

https://dist.apache.org/repos/dist/dev/c

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC2

2020-02-06 Thread Gary Gregory 
May I get more binding votes please?

Gary

On Sat, Feb 1, 2020 at 8:55 PM Gary Gregory  wrote:

> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons CSV 1.7 was released, so I would like to release
> Apache Commons CSV 1.8.
>
> Apache Commons CSV 1.8 RC2 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2 (svn
> revision 37829)
>
> The Git tag commons-csv-1.8-RC2 commit for this RC is
> 660f7c9f853092ec8abf5d6c81d260e3c80c2194 which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-csv.git;a=commit;h=660f7c9f853092ec8abf5d6c81d260e3c80c2194
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-csv.git
> --branch commons-csv-1.8-RC2 commons-csv-1.8-RC2
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1490/org/apache/commons/commons-csv/1.8/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Sat Feb 01 20:19:25 EST 2020
>
> commons-csv-1.8-bin.tar.gz=ed0ebd0fdae603480b83dca93a1591161c5939b69306ab8eab17e4cd578157f3aadfe81796ec4c180b6e0f9a143507ffcfb123fe181163cf78b3ca0d1c7c9438
>
> commons-csv-1.8-bin.zip=e9ff3bfef662e89b15019a33272e3a44e68cc8ee3c44fa2559021612158f154180b8e5bf0704f5e2453ed5a36061df76bdf9f9d36918c11e0a311107a653317c
>
> commons-csv-1.8-javadoc.jar=c26f284b98adf6321d84dd426ab8fbbf7ab1d4e3c43bfb62b9b3ce0706399a6034837a8f1164fc66f810c8282a82f168b0ab077d917e45991df337ece6b61d3c
>
> commons-csv-1.8-sources.jar=4d716b1cb7c2e75253bc7e89a49caf5acb80112974ca4211a5dfabcca5602177bcc2f0796a23f4fbed3eb2f84212507aac124b44acef80b424bdf1f0862d7069
>
> commons-csv-1.8-src.tar.gz=e0a7f7dbb0bf381f0f8f703e0ccb689f96c0a610b7afbd771cfeecab7042416f6dddc15c0a6e9a23f157da87c2bf3f16efb2e2aeb135ef1ac8c7306659936443
>
> commons-csv-1.8-src.zip=4703f33559ac1fc90aaf5d86408bc593554ef251d01ea5b14d24946d1cd9c7dab74ff96711375befec2b0314d53f907318494d3ba943982c6eb344af29cf6236
>
> commons-csv-1.8-test-sources.jar=d0016b3c8ce139a775f376c1b268295f553b97487ce1a9e1a1cce20e3d0b9e709143a44f22c02aa4fc1e1ecc4812de82c14c1b082c644c5ca5bba80230140405
>
> commons-csv-1.8-tests.jar=11c109f650643fe8f9da6f46c9c6467728bdbf89484d74a8a71ce1d0b347d5e4f16228eaeb6d1507de2244d7ebea0fc9f5efa869ce5d535ad5d0fa0306cb6dc9
>
> I have tested this with 'mvn -V -Prelease -Ptest-deploy -P jacoco -P
> japicmp clean package site deploy' using:
>
> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: C:\Java\apache-maven-3.6.3\bin\..
> Java version: 1.8.0_241, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk1.8.0_241\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>
> Details of changes since 1.7 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/changes-report.html
>
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/index.html
> (note some *relative* links are broken and the 1.8 directories are not
> yet created - these will be OK once the site is deployed.)
>
> JApiCmp Report (compared to 1.7):
>
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/japicmp.html
> This release fixes serialization compatibility of CSVRecord with
> versions 1.0 to 1.6. New fields added since
> 1.7 are not serialized. Support for Serializable is scheduled to be
> removed in version 2.0.
>
> RAT Report:
>
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thank you,
>
> Gary Gregory,
> Release Manager (using key 86fdc7e2a11262cb)
>
> For following is intended as a helper and refresher for reviewers.
>
> Validating a release candidate
> ==
>
> These guidelines are NOT complete.
>
> Requirements: Git, Java, Maven.
>
> You can validate a release from a release candidate (RC) tag as follows.
>
> 1) Clone and checkout the RC tag
>
> git clone https://gitbox.apache.org/repos/asf/commons-csv.git --branch
> commons-csv-1.8-RC2 commons-csv-1.8-RC2
> cd commons-csv-1.8-RC2
>
> 2) Check Apache licenses
>
> This step is not required if the site includes a RAT report page which you
> then must check.
>
> mvn apache-rat:check
>
> 3) Check binary compatibility
>
> Older components still use Apache Clirr:
>
> This step is not required if the site includes a Clirr report page which
> you then must check.
>
> mvn clirr:check
>
> Newer components use JApiCmp with the japicmp Maven Profile:
>
> This step is not required if the site

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC2

2020-02-05 Thread Amey Jadiye 
Checked RC2 of Commons CSV 1.8 and here is my +1 (non-binding).

1. Build and Tests look good.
2. Clirr looks good.
3. Rat is good.
4. Spotbug looks good (I wonder why dont we have it in plugins ? ),[there
is one issue with spotbug but i saw in comments its intentionaly done, so
okey]
5. Checkstyle is good.
6. Hashes and Site look good.

Checked on:-

Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
2018-06-18T00:03:14+05:30)
Maven home: /usr/lib/maven/apache-maven-3.5.4
Java version: 1.8.0_181, vendor: Oracle Corporation, runtime:
/usr/lib/jvm/jdk1.8.0_181/jre
Default locale: en_IN, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-20-generic", arch: "amd64", family:
"unix"

Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
2018-06-18T00:03:14+05:30)
Maven home: /usr/lib/maven/apache-maven-3.5.4
Java version: 11.0.6, vendor: Ubuntu, runtime:
/usr/lib/jvm/java-11-openjdk-amd64
Default locale: en_IN, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-20-generic", arch: "amd64", family:
"unix"


Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
2018-06-18T00:03:14+05:30)
Maven home: /usr/lib/maven/apache-maven-3.5.4
Java version: 13.0.1, vendor: Oracle Corporation, runtime:
/usr/lib/jvm/jdk-13.0.1
Default locale: en_IN, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-20-generic", arch: "amd64", family:
"unix"

Regards,
Amey


On Sun, Feb 2, 2020 at 7:26 AM Gary Gregory  wrote:

> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons CSV 1.7 was released, so I would like to release
> Apache Commons CSV 1.8.
>
> Apache Commons CSV 1.8 RC2 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2 (svn
> revision 37829)
>
> The Git tag commons-csv-1.8-RC2 commit for this RC is
> 660f7c9f853092ec8abf5d6c81d260e3c80c2194 which you can browse here:
>
>
> https://gitbox.apache.org/repos/asf?p=commons-csv.git;a=commit;h=660f7c9f853092ec8abf5d6c81d260e3c80c2194
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-csv.git --branch
> commons-csv-1.8-RC2 commons-csv-1.8-RC2
>
> Maven artifacts are here:
>
>
> https://repository.apache.org/content/repositories/orgapachecommons-1490/org/apache/commons/commons-csv/1.8/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Sat Feb 01 20:19:25 EST 2020
>
> commons-csv-1.8-bin.tar.gz=ed0ebd0fdae603480b83dca93a1591161c5939b69306ab8eab17e4cd578157f3aadfe81796ec4c180b6e0f9a143507ffcfb123fe181163cf78b3ca0d1c7c9438
>
> commons-csv-1.8-bin.zip=e9ff3bfef662e89b15019a33272e3a44e68cc8ee3c44fa2559021612158f154180b8e5bf0704f5e2453ed5a36061df76bdf9f9d36918c11e0a311107a653317c
>
> commons-csv-1.8-javadoc.jar=c26f284b98adf6321d84dd426ab8fbbf7ab1d4e3c43bfb62b9b3ce0706399a6034837a8f1164fc66f810c8282a82f168b0ab077d917e45991df337ece6b61d3c
>
> commons-csv-1.8-sources.jar=4d716b1cb7c2e75253bc7e89a49caf5acb80112974ca4211a5dfabcca5602177bcc2f0796a23f4fbed3eb2f84212507aac124b44acef80b424bdf1f0862d7069
>
> commons-csv-1.8-src.tar.gz=e0a7f7dbb0bf381f0f8f703e0ccb689f96c0a610b7afbd771cfeecab7042416f6dddc15c0a6e9a23f157da87c2bf3f16efb2e2aeb135ef1ac8c7306659936443
>
> commons-csv-1.8-src.zip=4703f33559ac1fc90aaf5d86408bc593554ef251d01ea5b14d24946d1cd9c7dab74ff96711375befec2b0314d53f907318494d3ba943982c6eb344af29cf6236
>
> commons-csv-1.8-test-sources.jar=d0016b3c8ce139a775f376c1b268295f553b97487ce1a9e1a1cce20e3d0b9e709143a44f22c02aa4fc1e1ecc4812de82c14c1b082c644c5ca5bba80230140405
>
> commons-csv-1.8-tests.jar=11c109f650643fe8f9da6f46c9c6467728bdbf89484d74a8a71ce1d0b347d5e4f16228eaeb6d1507de2244d7ebea0fc9f5efa869ce5d535ad5d0fa0306cb6dc9
>
> I have tested this with 'mvn -V -Prelease -Ptest-deploy -P jacoco -P
> japicmp clean package site deploy' using:
>
> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: C:\Java\apache-maven-3.6.3\bin\..
> Java version: 1.8.0_241, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk1.8.0_241\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>
> Details of changes since 1.7 are in the release notes:
>
>
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/RELEASE-NOTES.txt
>
>
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/changes-report.html
>
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/index.html
> (note some *relative* links are broken and the 1.8 directories are not
> yet created - these will be OK once the site is deployed.)
>
> JApiCmp Report (compared to 1.7):
>
>
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/japicmp.html
> This release fixes serialization compatibility of CSVRecord with
> versions 1.0 to 1.6. New fields added since
> 1.7 are not serialized. Support for Serializable is scheduled to be
> removed in version 2.0.
>
> RAT Report:
>
>
> https://dis

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC2

2020-02-05 Thread Gary Gregory 
May we get more reviews please?

Gary


On Sat, Feb 1, 2020 at 8:55 PM Gary Gregory  wrote:

> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons CSV 1.7 was released, so I would like to release
> Apache Commons CSV 1.8.
>
> Apache Commons CSV 1.8 RC2 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2 (svn
> revision 37829)
>
> The Git tag commons-csv-1.8-RC2 commit for this RC is
> 660f7c9f853092ec8abf5d6c81d260e3c80c2194 which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-csv.git;a=commit;h=660f7c9f853092ec8abf5d6c81d260e3c80c2194
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-csv.git
> --branch commons-csv-1.8-RC2 commons-csv-1.8-RC2
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1490/org/apache/commons/commons-csv/1.8/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Sat Feb 01 20:19:25 EST 2020
>
> commons-csv-1.8-bin.tar.gz=ed0ebd0fdae603480b83dca93a1591161c5939b69306ab8eab17e4cd578157f3aadfe81796ec4c180b6e0f9a143507ffcfb123fe181163cf78b3ca0d1c7c9438
>
> commons-csv-1.8-bin.zip=e9ff3bfef662e89b15019a33272e3a44e68cc8ee3c44fa2559021612158f154180b8e5bf0704f5e2453ed5a36061df76bdf9f9d36918c11e0a311107a653317c
>
> commons-csv-1.8-javadoc.jar=c26f284b98adf6321d84dd426ab8fbbf7ab1d4e3c43bfb62b9b3ce0706399a6034837a8f1164fc66f810c8282a82f168b0ab077d917e45991df337ece6b61d3c
>
> commons-csv-1.8-sources.jar=4d716b1cb7c2e75253bc7e89a49caf5acb80112974ca4211a5dfabcca5602177bcc2f0796a23f4fbed3eb2f84212507aac124b44acef80b424bdf1f0862d7069
>
> commons-csv-1.8-src.tar.gz=e0a7f7dbb0bf381f0f8f703e0ccb689f96c0a610b7afbd771cfeecab7042416f6dddc15c0a6e9a23f157da87c2bf3f16efb2e2aeb135ef1ac8c7306659936443
>
> commons-csv-1.8-src.zip=4703f33559ac1fc90aaf5d86408bc593554ef251d01ea5b14d24946d1cd9c7dab74ff96711375befec2b0314d53f907318494d3ba943982c6eb344af29cf6236
>
> commons-csv-1.8-test-sources.jar=d0016b3c8ce139a775f376c1b268295f553b97487ce1a9e1a1cce20e3d0b9e709143a44f22c02aa4fc1e1ecc4812de82c14c1b082c644c5ca5bba80230140405
>
> commons-csv-1.8-tests.jar=11c109f650643fe8f9da6f46c9c6467728bdbf89484d74a8a71ce1d0b347d5e4f16228eaeb6d1507de2244d7ebea0fc9f5efa869ce5d535ad5d0fa0306cb6dc9
>
> I have tested this with 'mvn -V -Prelease -Ptest-deploy -P jacoco -P
> japicmp clean package site deploy' using:
>
> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: C:\Java\apache-maven-3.6.3\bin\..
> Java version: 1.8.0_241, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk1.8.0_241\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>
> Details of changes since 1.7 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/changes-report.html
>
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/index.html
> (note some *relative* links are broken and the 1.8 directories are not
> yet created - these will be OK once the site is deployed.)
>
> JApiCmp Report (compared to 1.7):
>
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/japicmp.html
> This release fixes serialization compatibility of CSVRecord with
> versions 1.0 to 1.6. New fields added since
> 1.7 are not serialized. Support for Serializable is scheduled to be
> removed in version 2.0.
>
> RAT Report:
>
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thank you,
>
> Gary Gregory,
> Release Manager (using key 86fdc7e2a11262cb)
>
> For following is intended as a helper and refresher for reviewers.
>
> Validating a release candidate
> ==
>
> These guidelines are NOT complete.
>
> Requirements: Git, Java, Maven.
>
> You can validate a release from a release candidate (RC) tag as follows.
>
> 1) Clone and checkout the RC tag
>
> git clone https://gitbox.apache.org/repos/asf/commons-csv.git --branch
> commons-csv-1.8-RC2 commons-csv-1.8-RC2
> cd commons-csv-1.8-RC2
>
> 2) Check Apache licenses
>
> This step is not required if the site includes a RAT report page which you
> then must check.
>
> mvn apache-rat:check
>
> 3) Check binary compatibility
>
> Older components still use Apache Clirr:
>
> This step is not required if the site includes a Clirr report page which
> you then must check.
>
> mvn clirr:check
>
> Newer components use JApiCmp with the japicmp Maven Profile:
>
> This step is not required if the site incl

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC2

2020-02-03 Thread Rob Tompkins 
Wasn’t done yet…just finished.

+1

-Rob

> On Feb 3, 2020, at 4:06 PM, Gary Gregory  wrote:
> 
> On Mon, Feb 3, 2020 at 11:47 AM Rob Tompkins  wrote:
> 
>> 
>> 
>>> On Feb 3, 2020, at 11:45 AM, Gary Gregory 
>> wrote:
>>> 
>>> On Mon, Feb 3, 2020 at 10:20 AM Rob Tompkins > > wrote:
>>> 
 Bit odd that we have neither clirr or japicmp in the reports in the
>> site.
 (Could be convinced to go +1). Willing to help get japicmp into project
>> if
 decision is to go with RC3. Would also be willing to roll RC3 if that’s
>> the
 call.
 
>>> 
>>> The JApiCmp report is present on the site:
>>> 
>> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/japicmp.html
>> <
>> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/japicmp.html
>>> 
>>> 
>>> It is also correctly linked from the menu.
>> 
>> 
>> Ah, pardon my missing that. Seemingly didn’t get generated from my build.
>> Will rely on the site that’s committed to svn.
>> 
> 
> Hi Rob,
> 
> Please make sure to clarify your vote if you are done.
> 
> Gary
> 
> 
>> -Rob
>> 
>>> 
>>> Gary
>>> 
>>> 
 
 -Rob
 
> On Feb 1, 2020, at 8:55 PM, Gary Gregory  wrote:
> 
> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons CSV 1.7 was released, so I would like to release
> Apache Commons CSV 1.8.
> 
> Apache Commons CSV 1.8 RC2 is available for review here:
>  https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2 (svn
> revision 37829)
> 
> The Git tag commons-csv-1.8-RC2 commit for this RC is
> 660f7c9f853092ec8abf5d6c81d260e3c80c2194 which you can browse here:
> 
> 
 
>> https://gitbox.apache.org/repos/asf?p=commons-csv.git;a=commit;h=660f7c9f853092ec8abf5d6c81d260e3c80c2194
> You may checkout this tag using:
>  git clone https://gitbox.apache.org/repos/asf/commons-csv.git
 --branch
> commons-csv-1.8-RC2 commons-csv-1.8-RC2
> 
> Maven artifacts are here:
> 
> 
 
>> https://repository.apache.org/content/repositories/orgapachecommons-1490/org/apache/commons/commons-csv/1.8/
> 
> These are the artifacts and their hashes:
> 
> #Release SHA-512s
> #Sat Feb 01 20:19:25 EST 2020
> 
 
>> commons-csv-1.8-bin.tar.gz=ed0ebd0fdae603480b83dca93a1591161c5939b69306ab8eab17e4cd578157f3aadfe81796ec4c180b6e0f9a143507ffcfb123fe181163cf78b3ca0d1c7c9438
> 
 
>> commons-csv-1.8-bin.zip=e9ff3bfef662e89b15019a33272e3a44e68cc8ee3c44fa2559021612158f154180b8e5bf0704f5e2453ed5a36061df76bdf9f9d36918c11e0a311107a653317c
> 
 
>> commons-csv-1.8-javadoc.jar=c26f284b98adf6321d84dd426ab8fbbf7ab1d4e3c43bfb62b9b3ce0706399a6034837a8f1164fc66f810c8282a82f168b0ab077d917e45991df337ece6b61d3c
> 
 
>> commons-csv-1.8-sources.jar=4d716b1cb7c2e75253bc7e89a49caf5acb80112974ca4211a5dfabcca5602177bcc2f0796a23f4fbed3eb2f84212507aac124b44acef80b424bdf1f0862d7069
> 
 
>> commons-csv-1.8-src.tar.gz=e0a7f7dbb0bf381f0f8f703e0ccb689f96c0a610b7afbd771cfeecab7042416f6dddc15c0a6e9a23f157da87c2bf3f16efb2e2aeb135ef1ac8c7306659936443
> 
 
>> commons-csv-1.8-src.zip=4703f33559ac1fc90aaf5d86408bc593554ef251d01ea5b14d24946d1cd9c7dab74ff96711375befec2b0314d53f907318494d3ba943982c6eb344af29cf6236
> 
 
>> commons-csv-1.8-test-sources.jar=d0016b3c8ce139a775f376c1b268295f553b97487ce1a9e1a1cce20e3d0b9e709143a44f22c02aa4fc1e1ecc4812de82c14c1b082c644c5ca5bba80230140405
> 
 
>> commons-csv-1.8-tests.jar=11c109f650643fe8f9da6f46c9c6467728bdbf89484d74a8a71ce1d0b347d5e4f16228eaeb6d1507de2244d7ebea0fc9f5efa869ce5d535ad5d0fa0306cb6dc9
> 
> I have tested this with 'mvn -V -Prelease -Ptest-deploy -P jacoco -P
> japicmp clean package site deploy' using:
> 
> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: C:\Java\apache-maven-3.6.3\bin\..
> Java version: 1.8.0_241, vendor: Oracle Corporation, runtime:
>> C:\Program
> Files\Java\jdk1.8.0_241\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family:
>> "windows"
> 
> Details of changes since 1.7 are in the release notes:
> 
> 
 
>> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/RELEASE-NOTES.txt
> 
> 
 
>> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/changes-report.html
> 
> Site:
> 
> 
 
>> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/index.html
>  (note some *relative* links are broken and the 1.8 directories are
>> not
> yet created - these will be OK once the site is deployed.)
> 
> JApiCmp Report (compared to 1.7):
> 
> 
 
>> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/japicmp.html
>  This release fixes serialization compatibility of CSVRecord with
> versions 1.0 to 1.6. New fields added since
>  1.7 are not

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC2

2020-02-03 Thread Gary Gregory 
On Mon, Feb 3, 2020 at 11:47 AM Rob Tompkins  wrote:

>
>
> > On Feb 3, 2020, at 11:45 AM, Gary Gregory 
> wrote:
> >
> > On Mon, Feb 3, 2020 at 10:20 AM Rob Tompkins  > wrote:
> >
> >> Bit odd that we have neither clirr or japicmp in the reports in the
> site.
> >> (Could be convinced to go +1). Willing to help get japicmp into project
> if
> >> decision is to go with RC3. Would also be willing to roll RC3 if that’s
> the
> >> call.
> >>
> >
> > The JApiCmp report is present on the site:
> >
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/japicmp.html
> <
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/japicmp.html
> >
> >
> > It is also correctly linked from the menu.
>
>
> Ah, pardon my missing that. Seemingly didn’t get generated from my build.
> Will rely on the site that’s committed to svn.
>

Hi Rob,

Please make sure to clarify your vote if you are done.

Gary


> -Rob
>
> >
> > Gary
> >
> >
> >>
> >> -Rob
> >>
> >>> On Feb 1, 2020, at 8:55 PM, Gary Gregory  wrote:
> >>>
> >>> We have fixed quite a few bugs and added some significant enhancements
> >>> since Apache Commons CSV 1.7 was released, so I would like to release
> >>> Apache Commons CSV 1.8.
> >>>
> >>> Apache Commons CSV 1.8 RC2 is available for review here:
> >>>   https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2 (svn
> >>> revision 37829)
> >>>
> >>> The Git tag commons-csv-1.8-RC2 commit for this RC is
> >>> 660f7c9f853092ec8abf5d6c81d260e3c80c2194 which you can browse here:
> >>>
> >>>
> >>
> https://gitbox.apache.org/repos/asf?p=commons-csv.git;a=commit;h=660f7c9f853092ec8abf5d6c81d260e3c80c2194
> >>> You may checkout this tag using:
> >>>   git clone https://gitbox.apache.org/repos/asf/commons-csv.git
> >> --branch
> >>> commons-csv-1.8-RC2 commons-csv-1.8-RC2
> >>>
> >>> Maven artifacts are here:
> >>>
> >>>
> >>
> https://repository.apache.org/content/repositories/orgapachecommons-1490/org/apache/commons/commons-csv/1.8/
> >>>
> >>> These are the artifacts and their hashes:
> >>>
> >>> #Release SHA-512s
> >>> #Sat Feb 01 20:19:25 EST 2020
> >>>
> >>
> commons-csv-1.8-bin.tar.gz=ed0ebd0fdae603480b83dca93a1591161c5939b69306ab8eab17e4cd578157f3aadfe81796ec4c180b6e0f9a143507ffcfb123fe181163cf78b3ca0d1c7c9438
> >>>
> >>
> commons-csv-1.8-bin.zip=e9ff3bfef662e89b15019a33272e3a44e68cc8ee3c44fa2559021612158f154180b8e5bf0704f5e2453ed5a36061df76bdf9f9d36918c11e0a311107a653317c
> >>>
> >>
> commons-csv-1.8-javadoc.jar=c26f284b98adf6321d84dd426ab8fbbf7ab1d4e3c43bfb62b9b3ce0706399a6034837a8f1164fc66f810c8282a82f168b0ab077d917e45991df337ece6b61d3c
> >>>
> >>
> commons-csv-1.8-sources.jar=4d716b1cb7c2e75253bc7e89a49caf5acb80112974ca4211a5dfabcca5602177bcc2f0796a23f4fbed3eb2f84212507aac124b44acef80b424bdf1f0862d7069
> >>>
> >>
> commons-csv-1.8-src.tar.gz=e0a7f7dbb0bf381f0f8f703e0ccb689f96c0a610b7afbd771cfeecab7042416f6dddc15c0a6e9a23f157da87c2bf3f16efb2e2aeb135ef1ac8c7306659936443
> >>>
> >>
> commons-csv-1.8-src.zip=4703f33559ac1fc90aaf5d86408bc593554ef251d01ea5b14d24946d1cd9c7dab74ff96711375befec2b0314d53f907318494d3ba943982c6eb344af29cf6236
> >>>
> >>
> commons-csv-1.8-test-sources.jar=d0016b3c8ce139a775f376c1b268295f553b97487ce1a9e1a1cce20e3d0b9e709143a44f22c02aa4fc1e1ecc4812de82c14c1b082c644c5ca5bba80230140405
> >>>
> >>
> commons-csv-1.8-tests.jar=11c109f650643fe8f9da6f46c9c6467728bdbf89484d74a8a71ce1d0b347d5e4f16228eaeb6d1507de2244d7ebea0fc9f5efa869ce5d535ad5d0fa0306cb6dc9
> >>>
> >>> I have tested this with 'mvn -V -Prelease -Ptest-deploy -P jacoco -P
> >>> japicmp clean package site deploy' using:
> >>>
> >>> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> >>> Maven home: C:\Java\apache-maven-3.6.3\bin\..
> >>> Java version: 1.8.0_241, vendor: Oracle Corporation, runtime:
> C:\Program
> >>> Files\Java\jdk1.8.0_241\jre
> >>> Default locale: en_US, platform encoding: Cp1252
> >>> OS name: "windows 10", version: "10.0", arch: "amd64", family:
> "windows"
> >>>
> >>> Details of changes since 1.7 are in the release notes:
> >>>
> >>>
> >>
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/RELEASE-NOTES.txt
> >>>
> >>>
> >>
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/changes-report.html
> >>>
> >>> Site:
> >>>
> >>>
> >>
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/index.html
> >>>   (note some *relative* links are broken and the 1.8 directories are
> not
> >>> yet created - these will be OK once the site is deployed.)
> >>>
> >>> JApiCmp Report (compared to 1.7):
> >>>
> >>>
> >>
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/japicmp.html
> >>>   This release fixes serialization compatibility of CSVRecord with
> >>> versions 1.0 to 1.6. New fields added since
> >>>   1.7 are not serialized. Support for Serializable is scheduled to be
> >>> removed in version 2.0.
> >>>
> >>> RAT Report:
> >>>
> >>>
> >>
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/rat-report.html

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC2

2020-02-03 Thread Rob Tompkins 


> On Feb 3, 2020, at 11:45 AM, Gary Gregory  wrote:
> 
> On Mon, Feb 3, 2020 at 10:20 AM Rob Tompkins  > wrote:
> 
>> Bit odd that we have neither clirr or japicmp in the reports in the site.
>> (Could be convinced to go +1). Willing to help get japicmp into project if
>> decision is to go with RC3. Would also be willing to roll RC3 if that’s the
>> call.
>> 
> 
> The JApiCmp report is present on the site:
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/japicmp.html 
> 
> 
> It is also correctly linked from the menu.


Ah, pardon my missing that. Seemingly didn’t get generated from my build. Will 
rely on the site that’s committed to svn.

-Rob

> 
> Gary
> 
> 
>> 
>> -Rob
>> 
>>> On Feb 1, 2020, at 8:55 PM, Gary Gregory  wrote:
>>> 
>>> We have fixed quite a few bugs and added some significant enhancements
>>> since Apache Commons CSV 1.7 was released, so I would like to release
>>> Apache Commons CSV 1.8.
>>> 
>>> Apache Commons CSV 1.8 RC2 is available for review here:
>>>   https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2 (svn
>>> revision 37829)
>>> 
>>> The Git tag commons-csv-1.8-RC2 commit for this RC is
>>> 660f7c9f853092ec8abf5d6c81d260e3c80c2194 which you can browse here:
>>> 
>>> 
>> https://gitbox.apache.org/repos/asf?p=commons-csv.git;a=commit;h=660f7c9f853092ec8abf5d6c81d260e3c80c2194
>>> You may checkout this tag using:
>>>   git clone https://gitbox.apache.org/repos/asf/commons-csv.git
>> --branch
>>> commons-csv-1.8-RC2 commons-csv-1.8-RC2
>>> 
>>> Maven artifacts are here:
>>> 
>>> 
>> https://repository.apache.org/content/repositories/orgapachecommons-1490/org/apache/commons/commons-csv/1.8/
>>> 
>>> These are the artifacts and their hashes:
>>> 
>>> #Release SHA-512s
>>> #Sat Feb 01 20:19:25 EST 2020
>>> 
>> commons-csv-1.8-bin.tar.gz=ed0ebd0fdae603480b83dca93a1591161c5939b69306ab8eab17e4cd578157f3aadfe81796ec4c180b6e0f9a143507ffcfb123fe181163cf78b3ca0d1c7c9438
>>> 
>> commons-csv-1.8-bin.zip=e9ff3bfef662e89b15019a33272e3a44e68cc8ee3c44fa2559021612158f154180b8e5bf0704f5e2453ed5a36061df76bdf9f9d36918c11e0a311107a653317c
>>> 
>> commons-csv-1.8-javadoc.jar=c26f284b98adf6321d84dd426ab8fbbf7ab1d4e3c43bfb62b9b3ce0706399a6034837a8f1164fc66f810c8282a82f168b0ab077d917e45991df337ece6b61d3c
>>> 
>> commons-csv-1.8-sources.jar=4d716b1cb7c2e75253bc7e89a49caf5acb80112974ca4211a5dfabcca5602177bcc2f0796a23f4fbed3eb2f84212507aac124b44acef80b424bdf1f0862d7069
>>> 
>> commons-csv-1.8-src.tar.gz=e0a7f7dbb0bf381f0f8f703e0ccb689f96c0a610b7afbd771cfeecab7042416f6dddc15c0a6e9a23f157da87c2bf3f16efb2e2aeb135ef1ac8c7306659936443
>>> 
>> commons-csv-1.8-src.zip=4703f33559ac1fc90aaf5d86408bc593554ef251d01ea5b14d24946d1cd9c7dab74ff96711375befec2b0314d53f907318494d3ba943982c6eb344af29cf6236
>>> 
>> commons-csv-1.8-test-sources.jar=d0016b3c8ce139a775f376c1b268295f553b97487ce1a9e1a1cce20e3d0b9e709143a44f22c02aa4fc1e1ecc4812de82c14c1b082c644c5ca5bba80230140405
>>> 
>> commons-csv-1.8-tests.jar=11c109f650643fe8f9da6f46c9c6467728bdbf89484d74a8a71ce1d0b347d5e4f16228eaeb6d1507de2244d7ebea0fc9f5efa869ce5d535ad5d0fa0306cb6dc9
>>> 
>>> I have tested this with 'mvn -V -Prelease -Ptest-deploy -P jacoco -P
>>> japicmp clean package site deploy' using:
>>> 
>>> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
>>> Maven home: C:\Java\apache-maven-3.6.3\bin\..
>>> Java version: 1.8.0_241, vendor: Oracle Corporation, runtime: C:\Program
>>> Files\Java\jdk1.8.0_241\jre
>>> Default locale: en_US, platform encoding: Cp1252
>>> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>>> 
>>> Details of changes since 1.7 are in the release notes:
>>> 
>>> 
>> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/RELEASE-NOTES.txt
>>> 
>>> 
>> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/changes-report.html
>>> 
>>> Site:
>>> 
>>> 
>> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/index.html
>>>   (note some *relative* links are broken and the 1.8 directories are not
>>> yet created - these will be OK once the site is deployed.)
>>> 
>>> JApiCmp Report (compared to 1.7):
>>> 
>>> 
>> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/japicmp.html
>>>   This release fixes serialization compatibility of CSVRecord with
>>> versions 1.0 to 1.6. New fields added since
>>>   1.7 are not serialized. Support for Serializable is scheduled to be
>>> removed in version 2.0.
>>> 
>>> RAT Report:
>>> 
>>> 
>> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/rat-report.html
>>> 
>>> KEYS:
>>> https://www.apache.org/dist/commons/KEYS
>>> 
>>> Please review the release candidate and vote.
>>> This vote will close no sooner that 72 hours from now.
>>> 
>>> [ ] +1 Release these artifacts
>>> [ ] +0 OK, but...
>>> [ ] -0 OK, but really should fix...
>>> [ ] -1 I oppose this release because...
>>> 
>>> Thank you,
>>> 
>>> Gary

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC2

2020-02-03 Thread Gary Gregory 
On Mon, Feb 3, 2020 at 10:20 AM Rob Tompkins  wrote:

> Bit odd that we have neither clirr or japicmp in the reports in the site.
> (Could be convinced to go +1). Willing to help get japicmp into project if
> decision is to go with RC3. Would also be willing to roll RC3 if that’s the
> call.
>

The JApiCmp report is present on the site:
https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/japicmp.html

It is also correctly linked from the menu.

Gary


>
> -Rob
>
> > On Feb 1, 2020, at 8:55 PM, Gary Gregory  wrote:
> >
> > We have fixed quite a few bugs and added some significant enhancements
> > since Apache Commons CSV 1.7 was released, so I would like to release
> > Apache Commons CSV 1.8.
> >
> > Apache Commons CSV 1.8 RC2 is available for review here:
> >https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2 (svn
> > revision 37829)
> >
> > The Git tag commons-csv-1.8-RC2 commit for this RC is
> > 660f7c9f853092ec8abf5d6c81d260e3c80c2194 which you can browse here:
> >
> >
> https://gitbox.apache.org/repos/asf?p=commons-csv.git;a=commit;h=660f7c9f853092ec8abf5d6c81d260e3c80c2194
> > You may checkout this tag using:
> >git clone https://gitbox.apache.org/repos/asf/commons-csv.git
> --branch
> > commons-csv-1.8-RC2 commons-csv-1.8-RC2
> >
> > Maven artifacts are here:
> >
> >
> https://repository.apache.org/content/repositories/orgapachecommons-1490/org/apache/commons/commons-csv/1.8/
> >
> > These are the artifacts and their hashes:
> >
> > #Release SHA-512s
> > #Sat Feb 01 20:19:25 EST 2020
> >
> commons-csv-1.8-bin.tar.gz=ed0ebd0fdae603480b83dca93a1591161c5939b69306ab8eab17e4cd578157f3aadfe81796ec4c180b6e0f9a143507ffcfb123fe181163cf78b3ca0d1c7c9438
> >
> commons-csv-1.8-bin.zip=e9ff3bfef662e89b15019a33272e3a44e68cc8ee3c44fa2559021612158f154180b8e5bf0704f5e2453ed5a36061df76bdf9f9d36918c11e0a311107a653317c
> >
> commons-csv-1.8-javadoc.jar=c26f284b98adf6321d84dd426ab8fbbf7ab1d4e3c43bfb62b9b3ce0706399a6034837a8f1164fc66f810c8282a82f168b0ab077d917e45991df337ece6b61d3c
> >
> commons-csv-1.8-sources.jar=4d716b1cb7c2e75253bc7e89a49caf5acb80112974ca4211a5dfabcca5602177bcc2f0796a23f4fbed3eb2f84212507aac124b44acef80b424bdf1f0862d7069
> >
> commons-csv-1.8-src.tar.gz=e0a7f7dbb0bf381f0f8f703e0ccb689f96c0a610b7afbd771cfeecab7042416f6dddc15c0a6e9a23f157da87c2bf3f16efb2e2aeb135ef1ac8c7306659936443
> >
> commons-csv-1.8-src.zip=4703f33559ac1fc90aaf5d86408bc593554ef251d01ea5b14d24946d1cd9c7dab74ff96711375befec2b0314d53f907318494d3ba943982c6eb344af29cf6236
> >
> commons-csv-1.8-test-sources.jar=d0016b3c8ce139a775f376c1b268295f553b97487ce1a9e1a1cce20e3d0b9e709143a44f22c02aa4fc1e1ecc4812de82c14c1b082c644c5ca5bba80230140405
> >
> commons-csv-1.8-tests.jar=11c109f650643fe8f9da6f46c9c6467728bdbf89484d74a8a71ce1d0b347d5e4f16228eaeb6d1507de2244d7ebea0fc9f5efa869ce5d535ad5d0fa0306cb6dc9
> >
> > I have tested this with 'mvn -V -Prelease -Ptest-deploy -P jacoco -P
> > japicmp clean package site deploy' using:
> >
> > Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> > Maven home: C:\Java\apache-maven-3.6.3\bin\..
> > Java version: 1.8.0_241, vendor: Oracle Corporation, runtime: C:\Program
> > Files\Java\jdk1.8.0_241\jre
> > Default locale: en_US, platform encoding: Cp1252
> > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
> >
> > Details of changes since 1.7 are in the release notes:
> >
> >
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/RELEASE-NOTES.txt
> >
> >
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/changes-report.html
> >
> > Site:
> >
> >
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/index.html
> >(note some *relative* links are broken and the 1.8 directories are not
> > yet created - these will be OK once the site is deployed.)
> >
> > JApiCmp Report (compared to 1.7):
> >
> >
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/japicmp.html
> >This release fixes serialization compatibility of CSVRecord with
> > versions 1.0 to 1.6. New fields added since
> >1.7 are not serialized. Support for Serializable is scheduled to be
> > removed in version 2.0.
> >
> > RAT Report:
> >
> >
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/rat-report.html
> >
> > KEYS:
> >  https://www.apache.org/dist/commons/KEYS
> >
> > Please review the release candidate and vote.
> > This vote will close no sooner that 72 hours from now.
> >
> >  [ ] +1 Release these artifacts
> >  [ ] +0 OK, but...
> >  [ ] -0 OK, but really should fix...
> >  [ ] -1 I oppose this release because...
> >
> > Thank you,
> >
> > Gary Gregory,
> > Release Manager (using key 86fdc7e2a11262cb)
> >
> > For following is intended as a helper and refresher for reviewers.
> >
> > Validating a release candidate
> > ==
> >
> > These guidelines are NOT complete.
> >
> > Requirements: Git, Java, Maven.
> >
> > You can validate a release from a release candidate (RC) tag as follows.
> >
>

Re: [VOTE] Release Apache Commons CSV 1.8 based on RC2

2020-02-03 Thread Rob Tompkins 
Bit odd that we have neither clirr or japicmp in the reports in the site. 
(Could be convinced to go +1). Willing to help get japicmp into project if 
decision is to go with RC3. Would also be willing to roll RC3 if that’s the 
call.

-Rob

> On Feb 1, 2020, at 8:55 PM, Gary Gregory  wrote:
> 
> We have fixed quite a few bugs and added some significant enhancements
> since Apache Commons CSV 1.7 was released, so I would like to release
> Apache Commons CSV 1.8.
> 
> Apache Commons CSV 1.8 RC2 is available for review here:
>https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2 (svn
> revision 37829)
> 
> The Git tag commons-csv-1.8-RC2 commit for this RC is
> 660f7c9f853092ec8abf5d6c81d260e3c80c2194 which you can browse here:
> 
> https://gitbox.apache.org/repos/asf?p=commons-csv.git;a=commit;h=660f7c9f853092ec8abf5d6c81d260e3c80c2194
> You may checkout this tag using:
>git clone https://gitbox.apache.org/repos/asf/commons-csv.git --branch
> commons-csv-1.8-RC2 commons-csv-1.8-RC2
> 
> Maven artifacts are here:
> 
> https://repository.apache.org/content/repositories/orgapachecommons-1490/org/apache/commons/commons-csv/1.8/
> 
> These are the artifacts and their hashes:
> 
> #Release SHA-512s
> #Sat Feb 01 20:19:25 EST 2020
> commons-csv-1.8-bin.tar.gz=ed0ebd0fdae603480b83dca93a1591161c5939b69306ab8eab17e4cd578157f3aadfe81796ec4c180b6e0f9a143507ffcfb123fe181163cf78b3ca0d1c7c9438
> commons-csv-1.8-bin.zip=e9ff3bfef662e89b15019a33272e3a44e68cc8ee3c44fa2559021612158f154180b8e5bf0704f5e2453ed5a36061df76bdf9f9d36918c11e0a311107a653317c
> commons-csv-1.8-javadoc.jar=c26f284b98adf6321d84dd426ab8fbbf7ab1d4e3c43bfb62b9b3ce0706399a6034837a8f1164fc66f810c8282a82f168b0ab077d917e45991df337ece6b61d3c
> commons-csv-1.8-sources.jar=4d716b1cb7c2e75253bc7e89a49caf5acb80112974ca4211a5dfabcca5602177bcc2f0796a23f4fbed3eb2f84212507aac124b44acef80b424bdf1f0862d7069
> commons-csv-1.8-src.tar.gz=e0a7f7dbb0bf381f0f8f703e0ccb689f96c0a610b7afbd771cfeecab7042416f6dddc15c0a6e9a23f157da87c2bf3f16efb2e2aeb135ef1ac8c7306659936443
> commons-csv-1.8-src.zip=4703f33559ac1fc90aaf5d86408bc593554ef251d01ea5b14d24946d1cd9c7dab74ff96711375befec2b0314d53f907318494d3ba943982c6eb344af29cf6236
> commons-csv-1.8-test-sources.jar=d0016b3c8ce139a775f376c1b268295f553b97487ce1a9e1a1cce20e3d0b9e709143a44f22c02aa4fc1e1ecc4812de82c14c1b082c644c5ca5bba80230140405
> commons-csv-1.8-tests.jar=11c109f650643fe8f9da6f46c9c6467728bdbf89484d74a8a71ce1d0b347d5e4f16228eaeb6d1507de2244d7ebea0fc9f5efa869ce5d535ad5d0fa0306cb6dc9
> 
> I have tested this with 'mvn -V -Prelease -Ptest-deploy -P jacoco -P
> japicmp clean package site deploy' using:
> 
> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: C:\Java\apache-maven-3.6.3\bin\..
> Java version: 1.8.0_241, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk1.8.0_241\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
> 
> Details of changes since 1.7 are in the release notes:
> 
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/RELEASE-NOTES.txt
> 
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/changes-report.html
> 
> Site:
> 
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/index.html
>(note some *relative* links are broken and the 1.8 directories are not
> yet created - these will be OK once the site is deployed.)
> 
> JApiCmp Report (compared to 1.7):
> 
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/japicmp.html
>This release fixes serialization compatibility of CSVRecord with
> versions 1.0 to 1.6. New fields added since
>1.7 are not serialized. Support for Serializable is scheduled to be
> removed in version 2.0.
> 
> RAT Report:
> 
> https://dist.apache.org/repos/dist/dev/commons/csv/1.8-RC2/site/rat-report.html
> 
> KEYS:
>  https://www.apache.org/dist/commons/KEYS
> 
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now.
> 
>  [ ] +1 Release these artifacts
>  [ ] +0 OK, but...
>  [ ] -0 OK, but really should fix...
>  [ ] -1 I oppose this release because...
> 
> Thank you,
> 
> Gary Gregory,
> Release Manager (using key 86fdc7e2a11262cb)
> 
> For following is intended as a helper and refresher for reviewers.
> 
> Validating a release candidate
> ==
> 
> These guidelines are NOT complete.
> 
> Requirements: Git, Java, Maven.
> 
> You can validate a release from a release candidate (RC) tag as follows.
> 
> 1) Clone and checkout the RC tag
> 
> git clone https://gitbox.apache.org/repos/asf/commons-csv.git --branch
> commons-csv-1.8-RC2 commons-csv-1.8-RC2
> cd commons-csv-1.8-RC2
> 
> 2) Check Apache licenses
> 
> This step is not required if the site includes a RAT report page which you
> then must check.
> 
> mvn apache-rat:check
> 
> 3) Check binary compatibility
> 
> Older components still use Apache Clirr:
> 
> This step is no