Re: Patch for reporter.a.o

2023-02-15 Thread Andrew Musselman
On Wed, Feb 15, 2023 at 5:19 AM  wrote:

> On Tue, 2023-02-14 at 14:33 -0800, Andrew Musselman wrote:
> > Looks good to me. Maybe similar language on this page
> > too? https://reporter.apache.org/wizard/statistics?lucene
>
> That page is generated by the code affected by that patch.


Got it

>


Re: Patch for reporter.a.o

2023-02-15 Thread rbowen
On Tue, 2023-02-14 at 14:33 -0800, Andrew Musselman wrote:
> Looks good to me. Maybe similar language on this page
> too? https://reporter.apache.org/wizard/statistics?lucene 

That page is generated by the code affected by that patch.

> 
> This ticket could be a good link to point the "Patches welcome"
> to: COMDEV-487
> 
> On Tue, Feb 14, 2023 at 1:22 PM  wrote:
> > I'd like to propose the attached patch to reporter.a.o so that
> > people
> > don't keep submitting the same mailing list stats, quarter after
> > quarter, a year after that part of the reporter is broken.
> > 
> > Thoughts?
> > 
> > ---
> > --
> > To unsubscribe, e-mail: dev-unsubscr...@community.apache.org
> > For additional commands, e-mail: dev-h...@community.apache.org
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@community.apache.org
> For additional commands, e-mail: dev-h...@community.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@community.apache.org
For additional commands, e-mail: dev-h...@community.apache.org



Re: Patch for reporter.a.o

2023-02-14 Thread Andrew Musselman
Looks good to me. Maybe similar language on this page too?
https://reporter.apache.org/wizard/statistics?lucene

This ticket could be a good link to point the "Patches welcome" to:
COMDEV-487 

On Tue, Feb 14, 2023 at 1:22 PM  wrote:

> I'd like to propose the attached patch to reporter.a.o so that people
> don't keep submitting the same mailing list stats, quarter after
> quarter, a year after that part of the reporter is broken.
>
> Thoughts?
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@community.apache.org
> For additional commands, e-mail: dev-h...@community.apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@community.apache.org
For additional commands, e-mail: dev-h...@community.apache.org

Patch for reporter.a.o

2023-02-14 Thread rbowen
I'd like to propose the attached patch to reporter.a.o so that people
don't keep submitting the same mailing list stats, quarter after
quarter, a year after that part of the reporter is broken.

Thoughts?
Index: source/generators.js
===
--- source/generators.js(revision 1907541)
+++ source/generators.js(working copy)
@@ -455,7 +455,7 @@
 // Append header IF there is data, otherwise nah.
 if (txt.length > 0) {
   txt = "See full metrics (new tab)".format(project) + txt;
-  txt = "Potentially useful observations on community 
health:" + txt + "";
+  txt = "Please note that this part of the report is broken. Patches 
welcome:" + txt + "";
   txt += "PLEASE DON'T COPY 
THESE METRICS INTO THE REPORT ALONE!While these metrics might offer 
insights into the wellbeing of the project, what the board of directors 
 wants to see is the story behind these 
metrics.Please take some time to explain why these metrics are the way 
they are, and what this means for the project. If you are unsure how to do 
this, please take a look at some of the examples provided above  (click the 
button!).";
 }
 return txt;
Index: wizard.js
===
--- wizard.js   (revision 1907541)
+++ wizard.js   (working copy)
@@ -1669,7 +1669,7 @@
 // Append header IF there is data, otherwise nah.
 if (txt.length > 0) {
   txt = "See full metrics (new tab)".format(project) + txt;
-  txt = "Potentially useful observations on community 
health:" + txt + "";
+  txt = "Please note that this part of the report is broken. Patches 
welcome:" + txt + "";
   txt += "PLEASE DON'T COPY 
THESE METRICS INTO THE REPORT ALONE!While these metrics might offer 
insights into the wellbeing of the project, what the board of directors 
 wants to see is the story behind these 
metrics.Please take some time to explain why these metrics are the way 
they are, and what this means for the project. If you are unsure how to do 
this, please take a look at some of the examples provided above  (click the 
button!).";
 }
 return txt;

-
To unsubscribe, e-mail: dev-unsubscr...@community.apache.org
For additional commands, e-mail: dev-h...@community.apache.org