Re: Review Request 16988: Cache pbxproj to avoid re-parsing it for each plugin during prepare

[Anis Kadri]

> On Jan. 17, 2014, 11:51 p.m., Anis Kadri wrote:
> > Ship It!

side note, this file is super unmaintainable but not your fault.


- Anis


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16988/#review32228
---


On Jan. 17, 2014, 7:11 p.m., Mark Koudritsky wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16988/
> ---
> 
> (Updated Jan. 17, 2014, 7:11 p.m.)
> 
> 
> Review request for cordova.
> 
> 
> Bugs: CB-5299
> https://issues.apache.org/jira/browse/CB-5299
> 
> 
> Repository: cordova-plugman
> 
> 
> Description
> ---
> 
> Same diff on github: 
> https://github.com/kamrik/cordova-plugman/compare/fast_prepare
> Corresponding change in cordova-cli: https://reviews.apache.org/r/16991/
> 
> Parsing pbxproj is slow (~250ms on my machine). When running "cordova 
> prepare" it is done for each plugin that needs to add frameworks to the ios 
> project. This change is a quick and dirty fix to allow caching the parsed 
> pbxproj object so that it can be reused for multiple plugins during prepare. 
> Non ios projects are not affected.
> 
> Sample timings for "cordova prepare ios" on a test project with 3 relevant 
> plugins:
> before: 1.623s
> after:  0.981s
> 
> 
> Diffs
> -
> 
>   spec/util/config-changes.spec.js 795d825 
>   src/util/config-changes.js 2009f7f 
> 
> Diff: https://reviews.apache.org/r/16988/diff/
> 
> 
> Testing
> ---
> 
> npm test
> cordova prepare 
> cordova build
> cordova create ...
> 
> 
> Thanks,
> 
> Mark Koudritsky
> 
>

Re: Review Request 16988: Cache pbxproj to avoid re-parsing it for each plugin during prepare

[Anis Kadri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16988/#review32228
---

Ship it!


Ship It!

- Anis Kadri


On Jan. 17, 2014, 7:11 p.m., Mark Koudritsky wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16988/
> ---
> 
> (Updated Jan. 17, 2014, 7:11 p.m.)
> 
> 
> Review request for cordova.
> 
> 
> Bugs: CB-5299
> https://issues.apache.org/jira/browse/CB-5299
> 
> 
> Repository: cordova-plugman
> 
> 
> Description
> ---
> 
> Same diff on github: 
> https://github.com/kamrik/cordova-plugman/compare/fast_prepare
> Corresponding change in cordova-cli: https://reviews.apache.org/r/16991/
> 
> Parsing pbxproj is slow (~250ms on my machine). When running "cordova 
> prepare" it is done for each plugin that needs to add frameworks to the ios 
> project. This change is a quick and dirty fix to allow caching the parsed 
> pbxproj object so that it can be reused for multiple plugins during prepare. 
> Non ios projects are not affected.
> 
> Sample timings for "cordova prepare ios" on a test project with 3 relevant 
> plugins:
> before: 1.623s
> after:  0.981s
> 
> 
> Diffs
> -
> 
>   spec/util/config-changes.spec.js 795d825 
>   src/util/config-changes.js 2009f7f 
> 
> Diff: https://reviews.apache.org/r/16988/diff/
> 
> 
> Testing
> ---
> 
> npm test
> cordova prepare 
> cordova build
> cordova create ...
> 
> 
> Thanks,
> 
> Mark Koudritsky
> 
>

Review Request 17064: Add a CordovaError exception class for better error reporting in CLI

[Mark Koudritsky]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17064/
---

Review request for cordova.


Bugs: CB-5782
https://issues.apache.org/jira/browse/CB-5782


Repository: cordova-cli


Description
---

The on('uncaughtException') handler was removed recently in cordova-cli because
it was hiding the stack traces of some legit exceptions, but this results in
scary traces for simple errors like running outside a corodva project.

This change reintroduces the on('uncaughtException') handler and adds a special
CordovaError class for such simple errors. For exceptions of CordovaError class
only the message will be printed, for all other errors - the full stack trace.

Another pass over the code will be needed to find and convert the Errors to
CordovaErrors where appropriate. Will be done in a separate change.


Diffs
-

  src/cli.js d22ba56 
  src/util.js 278172a 

Diff: https://reviews.apache.org/r/17064/diff/


Testing
---

npm test
cordova plugin ls (inside and outside a a proj)
cordova bad_command


Thanks,

Mark Koudritsky

Re: Review Request 16988: Cache pbxproj to avoid re-parsing it for each plugin during prepare

[Max Woghiren]

> On Jan. 17, 2014, 2:04 p.m., Max Woghiren wrote:
> > spec/util/config-changes.spec.js, line 309
> > 
> >
> > Is this function intentionally empty?
> 
> Mark Koudritsky wrote:
> Yes, it's needed only to avoid an error when add_plugin_changes() tries 
> to call it. 
> Before this, add_plugin_changes was not using that write() function, 
> don't know why.

Ah, I investigated more and I understand now.  Thanks!


- Max


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16988/#review32176
---


On Jan. 17, 2014, 2:11 p.m., Mark Koudritsky wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16988/
> ---
> 
> (Updated Jan. 17, 2014, 2:11 p.m.)
> 
> 
> Review request for cordova.
> 
> 
> Bugs: CB-5299
> https://issues.apache.org/jira/browse/CB-5299
> 
> 
> Repository: cordova-plugman
> 
> 
> Description
> ---
> 
> Same diff on github: 
> https://github.com/kamrik/cordova-plugman/compare/fast_prepare
> Corresponding change in cordova-cli: https://reviews.apache.org/r/16991/
> 
> Parsing pbxproj is slow (~250ms on my machine). When running "cordova 
> prepare" it is done for each plugin that needs to add frameworks to the ios 
> project. This change is a quick and dirty fix to allow caching the parsed 
> pbxproj object so that it can be reused for multiple plugins during prepare. 
> Non ios projects are not affected.
> 
> Sample timings for "cordova prepare ios" on a test project with 3 relevant 
> plugins:
> before: 1.623s
> after:  0.981s
> 
> 
> Diffs
> -
> 
>   spec/util/config-changes.spec.js 795d825 
>   src/util/config-changes.js 2009f7f 
> 
> Diff: https://reviews.apache.org/r/16988/diff/
> 
> 
> Testing
> ---
> 
> npm test
> cordova prepare 
> cordova build
> cordova create ...
> 
> 
> Thanks,
> 
> Mark Koudritsky
> 
>

Re: Review Request 16988: Cache pbxproj to avoid re-parsing it for each plugin during prepare

[Mark Koudritsky]

> On Jan. 17, 2014, 7:04 p.m., Max Woghiren wrote:
> > spec/util/config-changes.spec.js, line 309
> > 
> >
> > Is this function intentionally empty?

Yes, it's needed only to avoid an error when add_plugin_changes() tries to call 
it. 
Before this, add_plugin_changes was not using that write() function, don't know 
why.


- Mark


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16988/#review32176
---


On Jan. 17, 2014, 7:11 p.m., Mark Koudritsky wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16988/
> ---
> 
> (Updated Jan. 17, 2014, 7:11 p.m.)
> 
> 
> Review request for cordova.
> 
> 
> Bugs: CB-5299
> https://issues.apache.org/jira/browse/CB-5299
> 
> 
> Repository: cordova-plugman
> 
> 
> Description
> ---
> 
> Same diff on github: 
> https://github.com/kamrik/cordova-plugman/compare/fast_prepare
> Corresponding change in cordova-cli: https://reviews.apache.org/r/16991/
> 
> Parsing pbxproj is slow (~250ms on my machine). When running "cordova 
> prepare" it is done for each plugin that needs to add frameworks to the ios 
> project. This change is a quick and dirty fix to allow caching the parsed 
> pbxproj object so that it can be reused for multiple plugins during prepare. 
> Non ios projects are not affected.
> 
> Sample timings for "cordova prepare ios" on a test project with 3 relevant 
> plugins:
> before: 1.623s
> after:  0.981s
> 
> 
> Diffs
> -
> 
>   spec/util/config-changes.spec.js 795d825 
>   src/util/config-changes.js 2009f7f 
> 
> Diff: https://reviews.apache.org/r/16988/diff/
> 
> 
> Testing
> ---
> 
> npm test
> cordova prepare 
> cordova build
> cordova create ...
> 
> 
> Thanks,
> 
> Mark Koudritsky
> 
>

Re: Review Request 16988: Cache pbxproj to avoid re-parsing it for each plugin during prepare

[Mark Koudritsky]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16988/
---

(Updated Jan. 17, 2014, 7:11 p.m.)


Review request for cordova.


Changes
---

Added caching in config-changes.process() where it calls add_plugin_changes()


Bugs: CB-5299
https://issues.apache.org/jira/browse/CB-5299


Repository: cordova-plugman


Description
---

Same diff on github: 
https://github.com/kamrik/cordova-plugman/compare/fast_prepare
Corresponding change in cordova-cli: https://reviews.apache.org/r/16991/

Parsing pbxproj is slow (~250ms on my machine). When running "cordova prepare" 
it is done for each plugin that needs to add frameworks to the ios project. 
This change is a quick and dirty fix to allow caching the parsed pbxproj object 
so that it can be reused for multiple plugins during prepare. Non ios projects 
are not affected.

Sample timings for "cordova prepare ios" on a test project with 3 relevant 
plugins:
before: 1.623s
after:  0.981s


Diffs (updated)
-

  spec/util/config-changes.spec.js 795d825 
  src/util/config-changes.js 2009f7f 

Diff: https://reviews.apache.org/r/16988/diff/


Testing
---

npm test
cordova prepare 
cordova build
cordova create ...


Thanks,

Mark Koudritsky

Re: Review Request 16988: Cache pbxproj to avoid re-parsing it for each plugin during prepare

[Max Woghiren]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16988/#review32176
---



spec/util/config-changes.spec.js


Is this function intentionally empty?


- Max Woghiren


On Jan. 16, 2014, 10:03 p.m., Mark Koudritsky wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16988/
> ---
> 
> (Updated Jan. 16, 2014, 10:03 p.m.)
> 
> 
> Review request for cordova.
> 
> 
> Bugs: CB-5299
> https://issues.apache.org/jira/browse/CB-5299
> 
> 
> Repository: cordova-plugman
> 
> 
> Description
> ---
> 
> Same diff on github: 
> https://github.com/kamrik/cordova-plugman/compare/fast_prepare
> Corresponding change in cordova-cli: https://reviews.apache.org/r/16991/
> 
> Parsing pbxproj is slow (~250ms on my machine). When running "cordova 
> prepare" it is done for each plugin that needs to add frameworks to the ios 
> project. This change is a quick and dirty fix to allow caching the parsed 
> pbxproj object so that it can be reused for multiple plugins during prepare. 
> Non ios projects are not affected.
> 
> Sample timings for "cordova prepare ios" on a test project with 3 relevant 
> plugins:
> before: 1.623s
> after:  0.981s
> 
> 
> Diffs
> -
> 
>   spec/util/config-changes.spec.js 795d825 
>   src/util/config-changes.js 2009f7f 
> 
> Diff: https://reviews.apache.org/r/16988/diff/
> 
> 
> Testing
> ---
> 
> npm test
> cordova prepare 
> cordova build
> cordova create ...
> 
> 
> Thanks,
> 
> Mark Koudritsky
> 
>

Re: Cordova's borked on npm

[Marcel Kinard]

+1

Letting users know we are aware of a problem, and giving them a workaround, is 
goodness.

On Jan 16, 2014, at 12:31 PM, Brian LeRoux  wrote:

> lame, looks like iris couch is giving plugins.cordova.io issues too
> 
> wonder if we should pump out a blog post explaining to our users that
> installing from a git url is possible (for both plugins and npm modules)

Re: [Android] LAST CHANCE: Adding Drawables from AOSP to InAppBrowser to conform to OS guidelines

[Marcel Kinard]

Nice!

On Jan 16, 2014, at 2:38 PM, Joe Bowser  wrote:

> This is merged in!  We now have language neutral hawtness.  We'll have
> to revisit this for accessibility, but at least we no longer have
> "Done" hardcoded.

Re: Review Request 16988: Cache pbxproj to avoid re-parsing it for each plugin during prepare

[Andrew Grieve]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16988/#review32160
---

Ship it!


Ship It!

- Andrew Grieve


On Jan. 16, 2014, 10:03 p.m., Mark Koudritsky wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16988/
> ---
> 
> (Updated Jan. 16, 2014, 10:03 p.m.)
> 
> 
> Review request for cordova.
> 
> 
> Bugs: CB-5299
> https://issues.apache.org/jira/browse/CB-5299
> 
> 
> Repository: cordova-plugman
> 
> 
> Description
> ---
> 
> Same diff on github: 
> https://github.com/kamrik/cordova-plugman/compare/fast_prepare
> Corresponding change in cordova-cli: https://reviews.apache.org/r/16991/
> 
> Parsing pbxproj is slow (~250ms on my machine). When running "cordova 
> prepare" it is done for each plugin that needs to add frameworks to the ios 
> project. This change is a quick and dirty fix to allow caching the parsed 
> pbxproj object so that it can be reused for multiple plugins during prepare. 
> Non ios projects are not affected.
> 
> Sample timings for "cordova prepare ios" on a test project with 3 relevant 
> plugins:
> before: 1.623s
> after:  0.981s
> 
> 
> Diffs
> -
> 
>   spec/util/config-changes.spec.js 795d825 
>   src/util/config-changes.js 2009f7f 
> 
> Diff: https://reviews.apache.org/r/16988/diff/
> 
> 
> Testing
> ---
> 
> npm test
> cordova prepare 
> cordova build
> cordova create ...
> 
> 
> Thanks,
> 
> Mark Koudritsky
> 
>

Re: plugins release

[Andrew Grieve]

No one's announced their intent to do one yet that I've seen.


On Thu, Jan 16, 2014 at 2:17 PM, Herm Wong wrote:

> Are we planning on a plugin release soon?
> There have been quite a few commits for FirefoxOS that need to be released
> into the main branch.

Re: 2014 planning F2F / Google Hangout

[Marcel Kinard]

I'm assuming that time is PST. I added that to the wiki. Please shout if I'm 
wrong.

On Jan 16, 2014, at 2:29 PM, Brian LeRoux  wrote:

> Lets go w/ 9:30am Wed 29th