[windows] Build fails if app path contains whitespaces

2014-02-23 Thread Sergey Grebnov (Akvelon)
Hi, could someone review and merge?
https://issues.apache.org/jira/browse/CB-6091 
fix for windows8 
https://github.com/apache/cordova-windows/pull/18 
fix for wp8
https://github.com/apache/cordova-wp8/pull/27

Thx!
Sergey


Re: mobile-spec and releases: How do we test?

2014-02-23 Thread ????
Hi all,
How's the progress? Where's JIRA I could follow?

We're building a Cordova-based framework and working closely to Cordova 
daily bits. We're still keeping tests in each plugin repo, and manually sync 
with Cordova-Mobile-Spec, that's even more painful after most of tests got 
removed from plugin repos.
We added a little script to cli (a new command actually) to integrate tests 
of all currently installed plugins into to target app, that's way how we 
perform testing for now.

Need some advice, thanks.

 
-- Original --
From:  Michal Mocnymmo...@chromium.org;
Date:  Thu, Oct 31, 2013 11:35 PM
To:  devdev@cordova.apache.org; 

Subject:  Re: mobile-spec and releases: How do we test?

 
This is awesome progress, guys, thanks for the help.

I'm going to put all the bits together and compile a list of tasks left and
write-up instructions for those who have yet to take a look.  If everyone
on the lists is still happy with the direction, I'll move those to JIRA.


On Thu, Oct 31, 2013 at 11:08 AM, David Kemp drk...@chromium.org wrote:

 I converted the couchdb reporter to the 2.0 style and added it to the repo.
 It works(hard coded config), but still needs the configuration components
 completed and some final adjustments to the data.




 On Thu, Oct 31, 2013 at 11:05 AM, Anis KADRI anis.ka...@gmail.com wrote:

  I ported the contacts plugin [1] to the new style and I found the
  process to be more or less straightforward. I also kept the eval in
  there but there might be a better way ?
 
  [1] http://goo.gl/uhnwtz
 
  On Wed, Oct 30, 2013 at 3:42 PM, Michal Mocny mmo...@chromium.org
 wrote:
   Sadly, we are approaching an in-between time of moving the mobile-spec
   tests out of the app and into plugins.  We are still investigating the
  best
   way to do this without disruption.
  
   For what its worth: several plugins now have a 'cdvtest' branch which
   supplies new-style tests ripped out of mobile-spec.  If you are having
   issues cleaning up the old style tests, take a look at the new ones (or
  try
   porting yourself).
  
   I'm going to write up a doc with the summary of the state of testing
  within
   a day or so given the results of this week to make it easier for you
 (and
   others) to pick up.
  
   -Michal
  
  
   On Wed, Oct 30, 2013 at 1:54 PM, Naik, Archana na...@lab126.com
 wrote:
  
Thanks Michal. You answered my questions.
  
More to elaborate on my question: I am testing amazon-fireos
   port(platform) with all plug-ins using mobile-spec. I am seeing some
   failures in 3.1.0 version because of test cases timing out. I am
 pretty
  new
   to cordova and still in learning phase. :) I am trying to understand
  these
   failures. Interestingly they pass on 3.0.x version.
  
Archana
  
  
 From: Michal Mocny mmo...@chromium.org
   Date: Wednesday, October 30, 2013 10:27 AM
   To: Naik, Archana na...@lab126.com
   Cc: dev@cordova.apache.org dev@cordova.apache.org, Michal Mocny 
   mmo...@chromium.org
  
   Subject: Re: mobile-spec and releases: How do we test?
  
 May you clarify?
  
Right now, there is no formal way to test plugins, we are trying to
   invent that way now.  Check out cordova-labs repo's cdvtest branch
 for a
   sample app  plugin to track progress.
  
Jasmine is hosted in that sample app, but plugins will not directly
   know/care.  Any testing framework which is api-compatible should work.
   In
   practice, I'm not sure how compatible they all are, so it may very
 well
  be
   limited to jasmine -- but it does mean you can make local
 modifications
   such as our CI is doing to create a custom test reporter.
  
-Michal
  
  
   On Wed, Oct 30, 2013 at 12:57 PM, Naik, Archana na...@lab126.com
  wrote:
  
   Hi, Guys
  
   While on this topic, I have a question: how do I test individual
  plug-in?
   Where is the this jasmine version specified?
  
   Thanks
   Archana
  
   On 10/30/13 7:26 AM, Michal Mocny mmo...@chromium.org wrote:
  
   Here are some links to jasmine-2 docs since its a hard time finding
  them:
   
   http://jasmine.github.io/2.0/introduction.html
   
   
 https://github.com/pivotal/jasmine/blob/master/release_notes/20rc5.md
   
   
   On Wed, Oct 30, 2013 at 10:16 AM, Michal Mocny mmo...@chromium.org
 
   wrote:
   
   
   
   
On Tue, Oct 29, 2013 at 5:29 PM, Bryan Higgins
   br...@bryanhiggins.netwrote:
   
I just converted geolocation to the new test style [1]
   
I'm happy with the process overall, and I find the jasmine 2
 tests
  are
more
succinct.
   
There are a few things worth noting:
- I kept the eval code in. At google today, it was discussed that
  this
   may
not be the best approach.
- Jasmine 2: You must hit at least one expect statement or the
 test
   will
timeout even though done was called.
   
   
We could file a bug (I ran into it during setup once too), but
  really,
what is the worth of a 

Re: CB-4846

2014-02-23 Thread Erik Jan de Wit

On 22 Feb,2014, at 0:01 , Shazron shaz...@gmail.com wrote:

 Joe - this calls a background fetch handler for your app at an interval, it
 doesn't really run in the background.
 
 Erik - just a quick code review:
 1. The method swizzling stuff is great but what I have planned (sometime in
 the future, in progress) is this:
 https://issues.apache.org/jira/browse/CB-5601

Ahh cool, I’ll keep an eye on that one.

 2. The way you are using callbacks is not quite correct

Could you elaborate on that, I’ll be more then happy to fix it

 
 Agree on it being a user space plugin -- but I was thinking it could be in
 cordova-plugins maybe when the time comes

I would love for it to be a cordova core plugin

 
 
 On Fri, Feb 21, 2014 at 1:47 PM, Joe Bowser bows...@gmail.com wrote:
 
 Is this actually running a service?  I thought this just runs a
 Cordova App in the background, which Android already has a setting
 for.
 
 On Fri, Feb 21, 2014 at 1:44 PM, Brian LeRoux b...@brian.io wrote:
 I think its cool as a user space plugin for now though. Have you
 published
 it to http://plugins.cordova.io ? (Its just like npm / you can read up
 on
 how here: https://github.com/apache/cordova-plugman)
 
 I really like the idea of us looking at background processing.
 
 Android services: how would that work? Does Firefox OS have the concept
 of
 background services? I know Chrome Mobile Apps guys have been doing some
 thinking here too.
 
 
 On Fri, Feb 21, 2014 at 2:53 AM, Erik Jan de Wit ede...@redhat.com
 wrote:
 
 Hi,
 
 I've created an initial version for
 https://issues.apache.org/jira/browse/CB-4846 the plugin is located at
 https://github.com/edewit/cordova-background-plugin
 
 Cheers,
Erik Jan