[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...
Github user AleksMeshkov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-46529001
Hi to all! Have anyone noticed bug with getting wrong contact instance?
When I run code below I get contact instance witch I didn't pick. When I select
"Mom" in picker's interface I get, for example, "Dmitri". It happens on Android
4.3 and 4.4.3.
```
navigator.contacts.pickContact(function (contact) {
if (contact.id == -1) {
return false;
}
alert(contact.name.formatted);
});
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
Re: Project Release: Patatap
Yeah, it's way cool! I'm glad to hear you had a great time using Cordova! I'd be interested to hear about some of your development challenges and what changes we can make to make it easier for other app developers. Nice work though! On Wed, Jun 18, 2014 at 5:40 PM, Shazron wrote: > Thanks for using Cordova Jono! > > On Wed, Jun 18, 2014 at 8:21 AM, Jono Brandel > wrote: > > Hey dev! > > > > I wanted to share an HTML5 app I ported to iOS using cordova. The process > > was fantastic and it's made me rethink my abilities to create native > > applications. Thanks so much for making Cordova! > > > > https://itunes.apple.com/us/app/patatap/id880626868?ls=1&mt=8 > > > > -Jono > > > > -- > > http://jonobr1.com/ > > jonobran...@gmail.com >
[GitHub] cordova-cli pull request: CB-6542 Delay creating project until the...
Github user kamrik commented on the pull request: https://github.com/apache/cordova-cli/pull/174#issuecomment-46514286 Ok, all merged :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-mobile-spec pull request: CB-6928: Add 304 response test
GitHub user jpuerto opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/71 CB-6928: Add 304 response test You can merge this pull request into a Git repository by running: $ git pull https://github.com/jpuerto/cordova-mobile-spec master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-mobile-spec/pull/71.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #71 commit 4f78beb5c55e5d02a0abc589db116e24220d52b2 Author: Javier Puerto Date: 2014-06-19T00:59:22Z CB-6928: Add 304 response test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file-transfer pull request: CB-6928: Implements NOT...
GitHub user jpuerto opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/32 CB-6928: Implements NOT_MODIFIED check downloading resources. Introduce FileTransferError.NOT_MODIFIED_ERR, execute error callback for 304 status code. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jpuerto/cordova-plugin-file-transfer pull-request Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file-transfer/pull/32.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #32 commit 369e6170605b5db99a6a568174078f185d31ca0c Author: Javier Puerto Date: 2014-06-12T08:34:42Z CB-6928: Open output stream only if it's necessary. commit 5a834df72ff690e8d6a6d58b7c7df1aa448edbb4 Author: Javier Puerto Date: 2014-06-19T00:20:51Z CB-6928: Handle 304 status code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [Android] URI routing
Change looks good to me! On Wed, Jun 18, 2014 at 7:51 PM, Joe Bowser wrote: > Hey > > After looking at the breakout code, it seems that there may actually > be a lot of duplicate code between Crosswalk, default AndroidWebView > and others, so I created a helper class that could be used to abstract > the shouldOverrideUrlLoading logic. While I was in there, I deleted > most of the handlers, and now we have the correct behaviour for custom > URIs which register a broadcast receiver. > > I put it on my branch here: > https://github.com/infil00p/cordova-android/tree/UriHelper > > I've constantly closed every bug that's said "Add support for custom > URIs" because Android by design already supports them. However, > partly due to legacy Android bugs, there was logic for specific URIs. > Once I ripped out the old logic and tested it on Kitkat, it appears > everything works as it should. I'm going to test this on older > versions of Cordova, but it'd be good if other people looked at this > before I land it in the 4.0.x branch. > > Thoughts? > > Joe >
[Android] URI routing
Hey After looking at the breakout code, it seems that there may actually be a lot of duplicate code between Crosswalk, default AndroidWebView and others, so I created a helper class that could be used to abstract the shouldOverrideUrlLoading logic. While I was in there, I deleted most of the handlers, and now we have the correct behaviour for custom URIs which register a broadcast receiver. I put it on my branch here: https://github.com/infil00p/cordova-android/tree/UriHelper I've constantly closed every bug that's said "Add support for custom URIs" because Android by design already supports them. However, partly due to legacy Android bugs, there was logic for specific URIs. Once I ripped out the old logic and tested it on Kitkat, it appears everything works as it should. I'm going to test this on older versions of Cordova, but it'd be good if other people looked at this before I land it in the 4.0.x branch. Thoughts? Joe
Re: Using Gradle in an Apache Project
On Wed, Jun 18, 2014 at 4:19 PM, Carlos Santana wrote: > Joe what is the project structure that you don't like and think we should > not adopt? > This structure is totally different than what we currently tell people to use? How do we upgrade people? Moving around the files is a breaking change! For example, the project you generated doesn't have an assets directory. That's also different than the same code that I generated last week with Gradle using Android Studio!! Yay standards! > I'm trying to learn how to use gradle, since we have a project here that we > want to align better with what most Android developers want to use. > Do we know that most Android developers want to use Gradle? I'm not totally convinced of this yet, and I want to be as IDE-agnostic as possible. Most of the users of Cordova shouldn't have to care whether we're using Gradle or Eclipse, and last year at OSCON when I talked to someone who does Android training, they were still discouraging people from using Android Studio. That's the main strength of Ian's solution so far. > Here is what I tried out: > > *$ android create project -n FooName -t android-19 -p FooPath -g -k > io.csantana -a FooMain -v 0.9.0* > > I was not sure what value to pass for "-v" Gradle Android plugin version. > But it looks it worked and created an Android Gradle project in "FooPath" > > First time I ran ./gradlew it download a set of files, then after that any > time I run it again it doesn't dowload I guess they are cache somewhere in > my system. > > I didn't installed gradle, I just have the android sdk, and my path setup > for both "tools" and "platform-tools" for $android and $adb > Yeah, I did the same command. The gradle-wrapper is bundled with the Android SDK. We don't use the Android SDK to generate projects, we run the update to fix our template, which is still very Ant based. It should be trivial once you update the Android project to get the path from local.properties, but I looked at the JS and wondered why we're returning exec. > > Stop reading if you don't want the details :-) > > $ android create project -n FooName -t android-19 -p FooPath -g -k > io.csantana -a FooMain -v 0.9.0 > > Created project directory: FooPath > > Created directory /Users/csantana23/foo/android/FooPath/src/main/java > > Created directory > /Users/csantana23/foo/android/FooPath/src/main/java/io/csantana > > Added file FooPath/src/main/java/io/csantana/FooMain.java > > Created directory > /Users/csantana23/foo/android/FooPath/src/instrumentTest/java > > Created directory > /Users/csantana23/foo/android/FooPath/src/instrumentTest/java/io/csantana > > Added file FooPath/src/instrumentTest/java/io/csantana/FooMainTest.java > > Created directory /Users/csantana23/foo/android/FooPath/src/main/res > > Created directory /Users/csantana23/foo/android/FooPath/src/main/res/values > > Added file FooPath/src/main/res/values/strings.xml > > Created directory /Users/csantana23/foo/android/FooPath/src/main/res/layout > > Added file FooPath/src/main/res/layout/main.xml > > Created directory > /Users/csantana23/foo/android/FooPath/src/main/res/drawable-xhdpi > > Created directory > /Users/csantana23/foo/android/FooPath/src/main/res/drawable-hdpi > > Created directory > /Users/csantana23/foo/android/FooPath/src/main/res/drawable-mdpi > > Created directory > /Users/csantana23/foo/android/FooPath/src/main/res/drawable-ldpi > > Added file FooPath/src/main/AndroidManifest.xml > > Added file FooPath/build.gradle > > Created directory /Users/csantana23/foo/android/FooPath/gradle/wrapper > > $ tree FooPath/ > > FooPath/ > > ├── build.gradle > > ├── gradle > > │ └── wrapper > > │ ├── gradle-wrapper.jar > > │ └── gradle-wrapper.properties > > ├── gradlew > > ├── gradlew.bat > > ├── local.properties > > └── src > > ├── instrumentTest > > │ └── java > > │ └── io > > │ └── csantana > > │ └── FooMainTest.java > > └── main > > ├── AndroidManifest.xml > > ├── java > > │ └── io > > │ └── csantana > > │ └── FooMain.java > > └── res > > ├── drawable-hdpi > > │ └── ic_launcher.png > > ├── drawable-ldpi > > │ └── ic_launcher.png > > ├── drawable-mdpi > > │ └── ic_launcher.png > > ├── drawable-xhdpi > > │ └── ic_launcher.png > > ├── layout > > │ └── main.xml > > └── values > > └── strings.xml > > > 18 directories, 15 files > > $ ./gradlew > > Download > http://repo1.maven.org/maven2/com/android/tools/build/gradle/0.9.0/gradle-0.9.0.pom > > Download > http://repo1.maven.org/maven2/com/android/tools/build/builder/0.9.0/builder-0.9.0.pom > > Download > http://repo1.maven.org/maven2/com/android/tools/lint/lint/22.7.0/lint-22.7.0.pom > > Download > http://repo1.maven.org/maven2/com/android/tools/sdk-common/22.7.0/
Re: Using Gradle in an Apache Project
Joe what is the project structure that you don't like and think we should not adopt? I'm trying to learn how to use gradle, since we have a project here that we want to align better with what most Android developers want to use. Here is what I tried out: *$ android create project -n FooName -t android-19 -p FooPath -g -k io.csantana -a FooMain -v 0.9.0* I was not sure what value to pass for "-v" Gradle Android plugin version. But it looks it worked and created an Android Gradle project in "FooPath" First time I ran ./gradlew it download a set of files, then after that any time I run it again it doesn't dowload I guess they are cache somewhere in my system. I didn't installed gradle, I just have the android sdk, and my path setup for both "tools" and "platform-tools" for $android and $adb Stop reading if you don't want the details :-) $ android create project -n FooName -t android-19 -p FooPath -g -k io.csantana -a FooMain -v 0.9.0 Created project directory: FooPath Created directory /Users/csantana23/foo/android/FooPath/src/main/java Created directory /Users/csantana23/foo/android/FooPath/src/main/java/io/csantana Added file FooPath/src/main/java/io/csantana/FooMain.java Created directory /Users/csantana23/foo/android/FooPath/src/instrumentTest/java Created directory /Users/csantana23/foo/android/FooPath/src/instrumentTest/java/io/csantana Added file FooPath/src/instrumentTest/java/io/csantana/FooMainTest.java Created directory /Users/csantana23/foo/android/FooPath/src/main/res Created directory /Users/csantana23/foo/android/FooPath/src/main/res/values Added file FooPath/src/main/res/values/strings.xml Created directory /Users/csantana23/foo/android/FooPath/src/main/res/layout Added file FooPath/src/main/res/layout/main.xml Created directory /Users/csantana23/foo/android/FooPath/src/main/res/drawable-xhdpi Created directory /Users/csantana23/foo/android/FooPath/src/main/res/drawable-hdpi Created directory /Users/csantana23/foo/android/FooPath/src/main/res/drawable-mdpi Created directory /Users/csantana23/foo/android/FooPath/src/main/res/drawable-ldpi Added file FooPath/src/main/AndroidManifest.xml Added file FooPath/build.gradle Created directory /Users/csantana23/foo/android/FooPath/gradle/wrapper $ tree FooPath/ FooPath/ ├── build.gradle ├── gradle │ └── wrapper │ ├── gradle-wrapper.jar │ └── gradle-wrapper.properties ├── gradlew ├── gradlew.bat ├── local.properties └── src ├── instrumentTest │ └── java │ └── io │ └── csantana │ └── FooMainTest.java └── main ├── AndroidManifest.xml ├── java │ └── io │ └── csantana │ └── FooMain.java └── res ├── drawable-hdpi │ └── ic_launcher.png ├── drawable-ldpi │ └── ic_launcher.png ├── drawable-mdpi │ └── ic_launcher.png ├── drawable-xhdpi │ └── ic_launcher.png ├── layout │ └── main.xml └── values └── strings.xml 18 directories, 15 files $ ./gradlew Download http://repo1.maven.org/maven2/com/android/tools/build/gradle/0.9.0/gradle-0.9.0.pom Download http://repo1.maven.org/maven2/com/android/tools/build/builder/0.9.0/builder-0.9.0.pom Download http://repo1.maven.org/maven2/com/android/tools/lint/lint/22.7.0/lint-22.7.0.pom Download http://repo1.maven.org/maven2/com/android/tools/sdk-common/22.7.0/sdk-common-22.7.0.pom Download http://repo1.maven.org/maven2/com/android/tools/build/manifest-merger/22.7.0/manifest-merger-22.7.0.pom Download http://repo1.maven.org/maven2/com/android/tools/ddms/ddmlib/22.7.0/ddmlib-22.7.0.pom Download http://repo1.maven.org/maven2/com/android/tools/common/22.7.0/common-22.7.0.pom Download http://repo1.maven.org/maven2/com/android/tools/build/builder-test-api/0.9.0/builder-test-api-0.9.0.pom Download http://repo1.maven.org/maven2/com/android/tools/build/builder-model/0.9.0/builder-model-0.9.0.pom Download http://repo1.maven.org/maven2/com/android/tools/sdklib/22.7.0/sdklib-22.7.0.pom Download http://repo1.maven.org/maven2/com/android/tools/lint/lint-checks/22.7.0/lint-checks-22.7.0.pom Download http://repo1.maven.org/maven2/com/android/tools/layoutlib/layoutlib-api/22.7.0/layoutlib-api-22.7.0.pom Download http://repo1.maven.org/maven2/com/android/tools/dvlib/22.7.0/dvlib-22.7.0.pom Download http://repo1.maven.org/maven2/com/android/tools/lint/lint-api/22.7.0/lint-api-22.7.0.pom Download http://repo1.maven.org/maven2/com/android/tools/build/gradle/0.9.0/gradle-0.9.0.jar Download http://repo1.maven.org/maven2/com/android/tools/build/builder/0.9.0/builder-0.9.0.jar Download http://repo1.maven.org/maven2/com/android/tools/lint/lint/22.7.0/lint-22.7.0.jar Download http://repo1.maven.org/maven2/com/android/tools/sdk-common/22.7.0/sdk-common-22.7.0.jar Download http://repo1.m
[GitHub] cordova-lib pull request: CB-3571: support for element in...
Github user surajpindoria commented on the pull request: https://github.com/apache/cordova-lib/pull/30#issuecomment-46506676 Can you add some tests for this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: Adding tizen support
Github user surajpindoria commented on the pull request:
https://github.com/apache/cordova-lib/pull/16#issuecomment-46504429
Exception loading:
/Users/spindori/Documents/Projects/cordova-lib/cordova-lib/spec-cordova/metadata/tizen_parser.spec.js
{ [Error: Cannot find module '../../src/cordova/ConfigParser'] code:
'MODULE_NOT_FOUND' }
ConfigParser has become its own module, please fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: CB-6540 Error for creating a project ins...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/35 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-cli pull request: CB-6542 Delay creating project until the...
Github user jsoref commented on the pull request: https://github.com/apache/cordova-cli/pull/174#issuecomment-46502577 @kamrik : can you please merge these things in cordova-lib so that they don't sit around lost? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-cli pull request: CB-6537 Consistently indicate `cordova ....
Github user jsoref commented on the pull request: https://github.com/apache/cordova-cli/pull/172#issuecomment-46502217 Integrated as https://github.com/apache/cordova-lib/pull/20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-cli pull request: CB-6537 Consistently indicate `cordova ....
Github user jsoref closed the pull request at: https://github.com/apache/cordova-cli/pull/172 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-cli pull request: CB-6542 Delay creating project until the...
Github user kamrik commented on the pull request: https://github.com/apache/cordova-cli/pull/174#issuecomment-46502024 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-cli pull request: CB-6415 Make project/.cordova/config.jso...
Github user jsoref commented on the pull request: https://github.com/apache/cordova-cli/pull/162#issuecomment-46501910 Migrated to https://github.com/apache/cordova-lib/pull/9 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: CB-6542 Delay creating project until the...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-cli pull request: CB-6415 Make project/.cordova/config.jso...
Github user jsoref closed the pull request at: https://github.com/apache/cordova-cli/pull/162 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-cli pull request: CB-6540 Error for creating a project ins...
Github user jsoref closed the pull request at: https://github.com/apache/cordova-cli/pull/173 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: CB-6540 Error for creating a project ins...
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-lib/pull/35 CB-6540 Error for creating a project inside its template is confusing From https://github.com/apache/cordova-cli/pull/173 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-lib cb_6540 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/35.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #35 commit 7a41b67807a7f9ae404a8e8a219affe0a9705422 Author: Josh Soref Date: 2014-06-18T22:17:19Z CB-6540 Error for creating a project inside its template is confusing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: CB-6542 Delay creating project until the...
Github user jsoref commented on the pull request: https://github.com/apache/cordova-lib/pull/34#issuecomment-46501549 Migrated from https://github.com/apache/cordova-cli/pull/174 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-cli pull request: CB-6542 Delay creating project until the...
Github user jsoref commented on the pull request: https://github.com/apache/cordova-cli/pull/174#issuecomment-46501511 https://github.com/apache/cordova-lib/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-cli pull request: CB-6542 Delay creating project until the...
Github user jsoref closed the pull request at: https://github.com/apache/cordova-cli/pull/174 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: CB-6542 Delay creating project until the...
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-lib/pull/34 CB-6542 Delay creating project until there's some chance that it will su... ...cceed You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-lib cb_6542 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/34.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #34 commit bf8e4158ec2a2810fd51c101ec5b50fcdf2dce05 Author: Josh Soref Date: 2014-06-18T22:13:23Z CB-6542 Delay creating project until there's some chance that it will succeed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-cli pull request: CB-6542 Delay creating project until the...
Github user jsoref commented on the pull request: https://github.com/apache/cordova-cli/pull/174#issuecomment-46501065 Probably... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-blackberry pull request: CB-6968 fix bashism (source) in u...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-blackberry/pull/163 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-blackberry pull request: CB-6934 run should complain about...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-blackberry/pull/162 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-cli pull request: CB-6542 Delay creating project until the...
Github user kamrik commented on the pull request: https://github.com/apache/cordova-cli/pull/174#issuecomment-46500400 @jsoref, is this still relevant? If yes, could you please rebase it onto cordova-lib. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: CB-6756 Initial implementation for the s...
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/18#issuecomment-46500220 My bad. this is restore platforms.. Restore plugins is already merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: CB-6756 Initial implementation for the s...
GitHub user gorkem reopened a pull request: https://github.com/apache/cordova-lib/pull/18 CB-6756 Initial implementation for the save and restore platforms command Adds implementation of the save and restore command for platforms. It also enhances the ConfigParser to support engine elements and cordova namespace. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gorkem/cordova-lib restore-platforms Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/18.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #18 commit a829dafb56c0543b0ffdfab8e2e1914d57a2917c Author: Gorkem Ercan Date: 2014-05-25T23:11:57Z Initial implementation for the restore platforms command Adds implementation of the save and restore command for platforms. It also enhances the ConfigParser to support engine elements and cordova namespace. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: CB-6756 Initial implementation for the s...
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/18#issuecomment-46499679 closing as merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: CB-6756 Initial implementation for the s...
Github user gorkem closed the pull request at: https://github.com/apache/cordova-lib/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-cli pull request: CB-6756 Add save and restore platforms
Github user kamrik commented on the pull request: https://github.com/apache/cordova-cli/pull/178#issuecomment-46499213 Hi @gorkem, looks like this functionality was already merged. Is this correct? If yes, could you please close the pull request. Same question for https://github.com/apache/cordova-lib/pull/18 Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Project Release: Patatap
Thanks for using Cordova Jono! On Wed, Jun 18, 2014 at 8:21 AM, Jono Brandel wrote: > Hey dev! > > I wanted to share an HTML5 app I ported to iOS using cordova. The process > was fantastic and it's made me rethink my abilities to create native > applications. Thanks so much for making Cordova! > > https://itunes.apple.com/us/app/patatap/id880626868?ls=1&mt=8 > > -Jono > > -- > http://jonobr1.com/ > jonobran...@gmail.com
[GitHub] cordova-lib pull request: Fixed windows8 platform build error when...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/33 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: staff change
Hi everyone, Yea I'm glad that I will be getting a chance to get a chance to work on an open source project. I'm hoping to learn a lot. Eric On Tue, Jun 17, 2014 at 1:50 PM, Michael Brooks wrote: > Thanks for the update Marcel. > > James, it's been great working with you and I hope we still cross paths! > It's incredibly important for all of us to use the product/tool that we > create, so I'm happy to hear that you're stepping into the consumer-side! > Don't be a stranger to submitting issues and nagging us to fix the ones > that impact your work! > > Eric, awesome to meet you! Straight out of college and into open source. > You're set! > > Michael > > > On Mon, Jun 16, 2014 at 12:43 PM, Michal Mocny > wrote: > > > Thanks for the update. See you around James, and hello Eric! > > > > > > On Mon, Jun 16, 2014 at 3:40 PM, Marcel Kinard > wrote: > > > > > Wanted to let the community know about a staff change here at IBM. > > > > > > James Jong, who has been working in the iOS area, is transferring to a > > > different department internally to work on a new product. He will be > > using > > > Cordova and writing some new native code for the product, so he’s a > > natural > > > fit, though we are sad to see him step away from the Cordova team. We > > > should expect to see James from time to time, since he’s now wearing a > > > consumer hat. His cube is still next to mine, so I can throw things at > > him > > > if needed. > > > > > > We just gained a new person to help backfill James. Eric Weiterman just > > > graduated from college and is joining us. Eric is new to iOS, but is > > > training and coming up to speed. Friday he deployed mobile-spec to an > > > iPhone and ran through the tests ;-) We should see pull requests coming > > > from him soon, and he is exercising our README.md’s. > > > > > > Thanks! > > > > > > > > > > > >
[GitHub] cordova-lib pull request: CB-6970 Share win project files manipula...
Github user kamrik commented on the pull request: https://github.com/apache/cordova-lib/pull/32#issuecomment-46496437 Thanks! This looks much cleaner. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: CB-6970 Share win project files manipula...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/32 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-firefoxos pull request: some cleanup and linting
Github user zalun commented on the pull request: https://github.com/apache/cordova-firefoxos/pull/2#issuecomment-46491942 Should it be closed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file-transfer pull request: [ubuntu] Update to work...
Github user Zaspire closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/22 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-vibration pull request: ubuntu: Implemented vibrate...
GitHub user Zaspire opened a pull request: https://github.com/apache/cordova-plugin-vibration/pull/12 ubuntu: Implemented vibrateWithPattern/cancelVibration You can merge this pull request into a Git repository by running: $ git pull https://github.com/Zaspire/cordova-plugin-vibration master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-vibration/pull/12.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12 commit 6e0a6897f3338473eec52874e7edbab0d05419f0 Author: Maxim Ermilov Date: 2014-06-18T20:28:00Z ubuntu: Implemented vibrateWithPattern/cancelVibration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Amazon Fire Phone
Announced today: http://www.amazon.com/gp/product/B00EOE0WKQ/ Runs Fire OS 3.5 https://developer.amazon.com/appsandservices/solutions/devices/fire-phone -- Carlos Santana
Re: Using Gradle in an Apache Project
Found it, it's located here: $ANDROID_SDK_PATH/tools/templates/gradle/wrapper On Wed, Jun 18, 2014 at 8:46 AM, Joe Bowser wrote: > Actually, it's not by default, but it does generate a gradle project > if you use the right flags. However, the project structure is > radically different that I'm not sure we want to adopt it. Still, we > can find where the JAR is and copy it out of the Android SDK > directory. > > On Wed, Jun 18, 2014 at 8:45 AM, Joe Bowser wrote: >> The Android Dev Tools generate a gradle project by default. Where >> does it store gradle-wrapper? >> >> On Wed, Jun 18, 2014 at 7:59 AM, Josh Soref wrote: >>> Ian Clelland wrote: But Gradle is a Java project, and so the script invokes Java, and makes use of a bundled .jar file, and therein lies the problem: We're not supposed to be including compiled JAR files in our repository. In this case, the .jar isn't actually part of our code; it's just used by the build, and including it makes it closer to trivial for developers to start building Cordova projects. It's easy to recreate, too, once you have Gradle installed, it's as easy as running "gradle wrapper" to get it to rebuild the wrapper, jar and all. The catch is that you already have to have gradle installed for that to work. Egg, meet chicken. >>> >>> Can we cheat and just have a script that uses curl/wget to retrieve Gradle >>> from Apache's dist directory? >>> >>> Or, could we publish Gradle to npm and then have our thing depend on >>> cordova-gradle ? >>>
[GitHub] cordova-lib pull request: Fixed windows8 platform build error when...
GitHub user strille opened a pull request: https://github.com/apache/cordova-lib/pull/33 Fixed windows8 platform build error when www (or one of its sub folders) contains .svn folders. .svn folders are now ignored when adding file references to the jsproj file (They are already correctly ignored when copying the www folder, so referencing them in the jsproj file breaks the build since the svn files cannot be found in www). You can merge this pull request into a Git repository by running: $ git pull https://github.com/strille/cordova-lib master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/33.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #33 commit 50eb8dfb739dbb0c09da6778c34a62da5b750ce6 Author: strille Date: 2014-06-18T13:10:16Z folder_contents() now ignores .svn folders .svn folders should not be referenced in the jsproj file. They are already correctly ignored when copying the www folder, and this causes the build to fail (since the jsproj references files that cannot be found in www). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Using Gradle in an Apache Project
Actually, it's not by default, but it does generate a gradle project if you use the right flags. However, the project structure is radically different that I'm not sure we want to adopt it. Still, we can find where the JAR is and copy it out of the Android SDK directory. On Wed, Jun 18, 2014 at 8:45 AM, Joe Bowser wrote: > The Android Dev Tools generate a gradle project by default. Where > does it store gradle-wrapper? > > On Wed, Jun 18, 2014 at 7:59 AM, Josh Soref wrote: >> Ian Clelland wrote: >>>But Gradle is a Java project, and so the script invokes Java, and makes >>>use >>>of a bundled .jar file, and therein lies the problem: We're not supposed >>>to >>>be including compiled JAR files in our repository. >>> >>>In this case, the .jar isn't actually part of our code; it's just used by >>>the build, and including it makes it closer to trivial for developers to >>>start building Cordova projects. It's easy to recreate, too, once you have >>>Gradle installed, it's as easy as running "gradle wrapper" to get it to >>>rebuild the wrapper, jar and all. The catch is that you already have to >>>have gradle installed for that to work. Egg, meet chicken. >> >> Can we cheat and just have a script that uses curl/wget to retrieve Gradle >> from Apache's dist directory? >> >> Or, could we publish Gradle to npm and then have our thing depend on >> cordova-gradle ? >>
Re: Using Gradle in an Apache Project
The Android Dev Tools generate a gradle project by default. Where does it store gradle-wrapper? On Wed, Jun 18, 2014 at 7:59 AM, Josh Soref wrote: > Ian Clelland wrote: >>But Gradle is a Java project, and so the script invokes Java, and makes >>use >>of a bundled .jar file, and therein lies the problem: We're not supposed >>to >>be including compiled JAR files in our repository. >> >>In this case, the .jar isn't actually part of our code; it's just used by >>the build, and including it makes it closer to trivial for developers to >>start building Cordova projects. It's easy to recreate, too, once you have >>Gradle installed, it's as easy as running "gradle wrapper" to get it to >>rebuild the wrapper, jar and all. The catch is that you already have to >>have gradle installed for that to work. Egg, meet chicken. > > Can we cheat and just have a script that uses curl/wget to retrieve Gradle > from Apache's dist directory? > > Or, could we publish Gradle to npm and then have our thing depend on > cordova-gradle ? >
Project Release: Patatap
Hey dev! I wanted to share an HTML5 app I ported to iOS using cordova. The process was fantastic and it's made me rethink my abilities to create native applications. Thanks so much for making Cordova! https://itunes.apple.com/us/app/patatap/id880626868?ls=1&mt=8 -Jono -- http://jonobr1.com/ jonobran...@gmail.com
Re: Using Gradle in an Apache Project
Ian Clelland wrote: >But Gradle is a Java project, and so the script invokes Java, and makes >use >of a bundled .jar file, and therein lies the problem: We're not supposed >to >be including compiled JAR files in our repository. > >In this case, the .jar isn't actually part of our code; it's just used by >the build, and including it makes it closer to trivial for developers to >start building Cordova projects. It's easy to recreate, too, once you have >Gradle installed, it's as easy as running "gradle wrapper" to get it to >rebuild the wrapper, jar and all. The catch is that you already have to >have gradle installed for that to work. Egg, meet chicken. Can we cheat and just have a script that uses curl/wget to retrieve Gradle from Apache's dist directory? Or, could we publish Gradle to npm and then have our thing depend on cordova-gradle ?
Re: File-transfer: delete target file on process error
Okay, think I got it and sounds good to me. On Wed, Jun 18, 2014 at 3:48 AM, Javier Puerto wrote: > I've explained my use case in the issue CB-6928 but as summary I'm creating > a simple rsync to keep the data in the device up to date. > > 2014-06-18 4:08 GMT+02:00 Ian Clelland : > > > On Tue, Jun 17, 2014 at 9:34 PM, Andrew Grieve > > wrote: > > > > > If it's cached... won't it exist? > > > > > > > Exactly this. A 304 request should only be received in response to a > > conditional GET request. There's generally no reason to send a > conditional > > GET unless you already have a cached copy of the file -- that is, unless > > you really don't care about its contents; only whether it's changed. But > if > > that's the case, then why are you using the file-transfer plugin? > > > > That's right. I use the file-transfer plugin because I see that it allows > custom headers so I thought that this way I can avoid an unnecessary HEAD > request first, just set the header and expect that the content is updated > if it's necessary or skipped in case that it's not. > > > > > > File-transfer is designed to be really simple. I think that we should > allow > > the developer to set If-Modified-Since headers any way that they like -- > or > > even If-None-Match, or crazier headers like If-Range, but we shouldn't > set > > those headers by default. Then, if a 304 is returned, then the right > thing > > to do is return *success* and not touch the file on disk at all. > > File-transfer has fulfilled its API: the file exists where it should. > > > > I'm agree. The patch I sent just skips the buffer copy if a 304 is detected > as response status. The problem is that if we are using a temporary file as > target, the plugin will return an invalid file entry. Adding an extra > parameter to communicate a cached response should do the job but for me it > looks too complicated, error has an status parameter in the callback and > conceptually the file-transfer didn't transferred anything so use the error > callback it's fine with me defining a new status for caching. > > > > > > I don't think that we should automatically set the If-Modified-Since > > header. My concern is that lots of other file operations could change > that > > date -- usually by modifying the file and setting it to *now* -- and in > > that case, you might never get a newer copy of the resource you've > > requested.'ve' > > > > The developer should be responsible to set the headers that he wants. For > my use case, the "rsync" updates the device and the application will just > consume the resources so no more modifications in FS. > > > > > > We could certainly add a flag to insert the header, based on the file's > > timestamp. Then a dev who knows the file hasn't been touched can set it. > > > > I think that anyone looking for something more complicated than this > should > > just use XHR and File, and manage the request and response headers > > themselves. > > > > > I don't think that my use case is complicated, I just expect that the > file-transfer update the file if it's necessary. Definitively the current > behaviour is wrong as doesn't makes sense to read a 304 response, it's > empty. Try to avoid an initial HEAD request it's just to save an extra > request that it's not necessary. Using different request means that in the > worst case, I will have to do two request per resource to update. > > > > Ian > > > > > > > > > > On Tue, Jun 17, 2014 at 11:56 AM, Javier Puerto > > wrote: > > > > > > > I think it's better to use the error callback because for cached > > > resources > > > > doesn't makes sense to use the "Entry" as parameter as the target > will > > > not > > > > exists..There's no error but the file transfer was unable to download > > > > anything due to the 304 response so IMO the error callback could do > the > > > > job. > > > > > > > > > > > > 2014-06-17 16:27 GMT+02:00 Andrew Grieve : > > > > > > > > > How about adding a second parameter to the callback? Android and > iOS > > > > > bridges both support this natively, and you can simulate it on > other > > > > > platforms by manually unpacking the parameters in your own > callback. > > > > > > > > > > > > > > > On Tue, Jun 17, 2014 at 4:18 AM, Javier Puerto > > > > wrote: > > > > > > > > > > > 2014-06-16 17:01 GMT+02:00 Andrew Grieve : > > > > > > > > > > > > > I think this behaviour has been around for a while, and makes > > sense > > > > in > > > > > > the > > > > > > > majority of cases. > > > > > > > > > > > > > > > > > > Yep, I did a "git blame" and this fragment of code was there from > > the > > > > > > beginning. > > > > > > > > > > > > > > > > > > > Best practice is to download to a temporary location, > > > > > > > and then upon success move the file to its final spot. > > > > > > > > > > > > > > > > > > > Yes, this is what I will have to do at the end. The thing is > that I > > > > want > > > > > to > > > > > > avoid a double step process. Anyway I'm still thinking that a > hard >
[GitHub] cordova-plugin-splashscreen pull request: Splashscreen crash on WP...
GitHub user nadyaA opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/20 Splashscreen crash on WP8 The UI elements cannot be accessed from any other than the UI thread directly. So, enclose UI access code in the Dispatcher.BeginInvoke() You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-plugin-splashscreen natanasova/splashscreen-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-splashscreen/pull/20.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #20 commit fcd69247f11c49c79d5d21a2ad77eb97d24619cf Author: Nadya Atanasova Date: 2014-06-18T13:53:08Z Splashscreen crash on WP8 The UI elements cannot be accessed from any other than the UI thread directly. So, enclose UI access code in the Dispatcher.BeginInvoke() --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-network-information pull request: fix NullPointerEx...
Github user SantechDev commented on the pull request: https://github.com/apache/cordova-plugin-network-information/pull/10#issuecomment-46433981 OK thanks, I'll keep an eye out --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-network-information pull request: fix NullPointerEx...
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-network-information/pull/10#issuecomment-46433863 No, it hasn't been pushed to the plugin repository. That will go out with the next plugin release. (Hopefully next week or the following, but I haven't heard of any plans to start that yet.) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-network-information pull request: fix NullPointerEx...
Github user SantechDev commented on the pull request: https://github.com/apache/cordova-plugin-network-information/pull/10#issuecomment-46432858 sorry to ask but as that modif been "pushed" to cordova plugin repo? I just did a ``` cordova plugin add org.apache.cordova.network-information ``` and I can't see the change in ```src/android/NetworkManager.java``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Build Cordova container on Windows 8
I am developing Metro application using the Cordova plugins. My application will be side-loaded to BYOD in my company and will not be published to the Store. My application is a container- it performed authentication and authorization and then should launch a URL (receive the URL from a different application). The URL is a web application which contains the Javascript code which use the Cordova plugins. Unfortunately, Cordova didn't supply the developers with WebView( http://docs.phonegap.com/en/2.2.0/guide_cordova-webview_android.md.html). Microsoft, on the other hand , supply the developers thier own WebView. The problem with Microsoft WebView is that it will run in local context- which means that the client application will not be able to call Cordova. few notes: 1. I don't have access to the applications code only to the URL's. 2. Cordova WebView works great on iOS and Android. Any ideas how can I solve this issue? Thanks in advance!
[GitHub] cordova-lib pull request: CB-6970 Share win project files manipula...
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-lib/pull/32 CB-6970 Share win project files manipulation code between cordova and plugman https://issues.apache.org/jira/browse/CB-6970 1. Shared csproj and jsproj classes 2. Updated code to use those classes instead of manual manipulation 3. Updated removeSourceFile method to support regexp as parameter (ability to remove batch files or all files from specific folder). You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-6970 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/32.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #32 commit 09759f285e698e16746304f1f6d074a4cc019008 Author: sgrebnov Date: 2014-06-18T12:58:20Z CB-6970 Share win project files manipulation code between cordova and plugman --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Using Gradle in an Apache Project
I'm attempting to get cordova-android to build with Gradle, and I have generally been successful, but now that it's time to commit this into the repository, I think I've run into a conflict with Apache policies. In order to be as simple to use as possible, Gradle is usually run from a wrapper script, "gradlew", which they recommend that you check into source control with your project. Running this wrapper takes care of downloading the correct version of gradle, as well as any of its dependencies, such as plugins, for building the code. This solves a lot of the problems involved with setting up a working build system. But Gradle is a Java project, and so the script invokes Java, and makes use of a bundled .jar file, and therein lies the problem: We're not supposed to be including compiled JAR files in our repository. In this case, the .jar isn't actually part of our code; it's just used by the build, and including it makes it closer to trivial for developers to start building Cordova projects. It's easy to recreate, too, once you have Gradle installed, it's as easy as running "gradle wrapper" to get it to rebuild the wrapper, jar and all. The catch is that you already have to have gradle installed for that to work. Egg, meet chicken. Is there any way (and I'm reaching out the ASF folks here, as well) that we can include this in the project, to make our developers' lives better? Gradle itself is Apache-licensed, but including its source code instead won't actually help anyone. Perhaps if we include full instructions for recreating the wrapper, or for downloading, installing and configuring gradle as well, for those that want to do it the hard way? Thanks, Ian
[GitHub] cordova-medic pull request: CB-6909 shellCmd and shellRunParam in ...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-medic/pull/11#issuecomment-46406000 +1, LGTM, tested on Windows and OS slaves --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: File-transfer: delete target file on process error
I've explained my use case in the issue CB-6928 but as summary I'm creating a simple rsync to keep the data in the device up to date. 2014-06-18 4:08 GMT+02:00 Ian Clelland : > On Tue, Jun 17, 2014 at 9:34 PM, Andrew Grieve > wrote: > > > If it's cached... won't it exist? > > > > Exactly this. A 304 request should only be received in response to a > conditional GET request. There's generally no reason to send a conditional > GET unless you already have a cached copy of the file -- that is, unless > you really don't care about its contents; only whether it's changed. But if > that's the case, then why are you using the file-transfer plugin? > That's right. I use the file-transfer plugin because I see that it allows custom headers so I thought that this way I can avoid an unnecessary HEAD request first, just set the header and expect that the content is updated if it's necessary or skipped in case that it's not. > > File-transfer is designed to be really simple. I think that we should allow > the developer to set If-Modified-Since headers any way that they like -- or > even If-None-Match, or crazier headers like If-Range, but we shouldn't set > those headers by default. Then, if a 304 is returned, then the right thing > to do is return *success* and not touch the file on disk at all. > File-transfer has fulfilled its API: the file exists where it should. > I'm agree. The patch I sent just skips the buffer copy if a 304 is detected as response status. The problem is that if we are using a temporary file as target, the plugin will return an invalid file entry. Adding an extra parameter to communicate a cached response should do the job but for me it looks too complicated, error has an status parameter in the callback and conceptually the file-transfer didn't transferred anything so use the error callback it's fine with me defining a new status for caching. > > I don't think that we should automatically set the If-Modified-Since > header. My concern is that lots of other file operations could change that > date -- usually by modifying the file and setting it to *now* -- and in > that case, you might never get a newer copy of the resource you've > requested.'ve' > The developer should be responsible to set the headers that he wants. For my use case, the "rsync" updates the device and the application will just consume the resources so no more modifications in FS. > > We could certainly add a flag to insert the header, based on the file's > timestamp. Then a dev who knows the file hasn't been touched can set it. > > I think that anyone looking for something more complicated than this should > just use XHR and File, and manage the request and response headers > themselves. > > I don't think that my use case is complicated, I just expect that the file-transfer update the file if it's necessary. Definitively the current behaviour is wrong as doesn't makes sense to read a 304 response, it's empty. Try to avoid an initial HEAD request it's just to save an extra request that it's not necessary. Using different request means that in the worst case, I will have to do two request per resource to update. > Ian > > > > > > On Tue, Jun 17, 2014 at 11:56 AM, Javier Puerto > wrote: > > > > > I think it's better to use the error callback because for cached > > resources > > > doesn't makes sense to use the "Entry" as parameter as the target will > > not > > > exists..There's no error but the file transfer was unable to download > > > anything due to the 304 response so IMO the error callback could do the > > > job. > > > > > > > > > 2014-06-17 16:27 GMT+02:00 Andrew Grieve : > > > > > > > How about adding a second parameter to the callback? Android and iOS > > > > bridges both support this natively, and you can simulate it on other > > > > platforms by manually unpacking the parameters in your own callback. > > > > > > > > > > > > On Tue, Jun 17, 2014 at 4:18 AM, Javier Puerto > > > wrote: > > > > > > > > > 2014-06-16 17:01 GMT+02:00 Andrew Grieve : > > > > > > > > > > > I think this behaviour has been around for a while, and makes > sense > > > in > > > > > the > > > > > > majority of cases. > > > > > > > > > > > > > > > Yep, I did a "git blame" and this fragment of code was there from > the > > > > > beginning. > > > > > > > > > > > > > > > > Best practice is to download to a temporary location, > > > > > > and then upon success move the file to its final spot. > > > > > > > > > > > > > > > > Yes, this is what I will have to do at the end. The thing is that I > > > want > > > > to > > > > > avoid a double step process. Anyway I'm still thinking that a hard > > > coded > > > > > and undocumented behaviour is not a good practice neither, mostly > > > because > > > > > there's the tools for the developer to act as he needs with the > > success > > > > or > > > > > error callback. It's about flexibility. > > > > > > > > > > > > > > > > > > > > > > That said, I think it'd be fine to add an option for not delete > on
[GitHub] cordova-plugin-file-transfer pull request: properly uses the fileK...
Github user cristi-badila commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/15#issuecomment-46403386 @purplecabbage yes, the version you pointed to works for me. Thanks for the help. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
