[GitHub] cordova-lib pull request: CB-6481 adds plugin level hooks support
Github user sgrebnov closed the pull request at: https://github.com/apache/cordova-lib/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: CB-6481 adds plugin level hooks support
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/12#issuecomment-47623059 New plugin hooks implementation is coming...closing this one --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: [CB- 7057] Improve File API docu...
GitHub user kerrishotts opened a pull request: https://github.com/apache/cordova-plugin-file/pull/59 [CB- 7057] Improve File API documentation, especially wrt to cordova.file.* properties As discussed on the google groups, the documentation for the `cordova.file.*` properties is unclear (see post: https://groups.google.com/forum/#!topic/phonegap/W1ZR6WG5XwM). Revised documentation to make it clearer, and also added a table indicating how the properties relate to the file system and the various properties on each path (read-write, private, etc.) Bug # is CB-7057. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kerrishotts/cordova-plugin-file CB-7057 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/59.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #59 commit da486e42ec3d5908f8013f9f2a6c42e7aca0a7f5 Author: Kerri Shotts Date: 2014-07-01T01:06:37Z Reworded description Added note that under iOS this directory is read-only (one must use a subdirectory like /Documents). Also indicated that the contents within the folder are private. commit 2575d9e714f020954fa251d733a6415a2f2f1f76 Author: Kerri Shotts Date: 2014-07-01T01:07:31Z Reworded description Reworded to make it clear that the data is persistent and private and within internal memory. Also added additional options for Android if external memory is needed and indicated that this directory is not synced. commit d6b44960f640f9d2326968f5fd2795d40543d825 Author: Kerri Shotts Date: 2014-07-01T01:09:05Z Reworded description Based on email from @jcesarmobile in dev group (titled More questions on FileSystem directories) commit 3bda96d6939f2b69380573ffbec7b958af0fce8a Author: Kerri Shotts Date: 2014-07-01T01:09:42Z Reformatted as list commit bdc14902bfc22fc86b1f790dbc8297598868c87f Author: Kerri Shotts Date: 2014-07-01T01:09:58Z Added note not to rely on OS clearing commit 9ea0c3cc74fdce67d42dbbe6c2d2022ea508483b Author: Kerri Shotts Date: 2014-07-01T01:11:03Z Added file system layout information This is useful information, especially for native developers who may already be familiar with the file system, but also useful for marking which directories are writeable, which ones are private/public and which ones sync, etc. commit 2a0f0884d063171a8099c35022ea579398c06482 Author: Kerri Shotts Date: 2014-07-01T01:12:09Z Formatting commit 80b172361ba71c318041d29ecf917ce8b8bc8708 Author: Kerri Shotts Date: 2014-07-01T01:12:32Z Promoted heading To match Android/iOS quirk headings commit 1175156cecf7f5e581fa653451e0a03b737593cf Author: Kerri Shotts Date: 2014-07-01T01:12:41Z Converted to table commit 67f929bfba49e321c91eb4abd157f1a20ee0776a Author: Kerri Shotts Date: 2014-07-01T01:12:59Z Added quirk Noted that `applicationStorageDirectory` is read-only. commit f1e18ebba1193031beb8b81f12b3a7bd59d21abd Author: Kerri Shotts Date: 2014-07-01T01:13:10Z formatting --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: CB-7056 serve: return promise of server
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/48 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: removed "pkgName "
Github user rodms10 commented on the pull request: https://github.com/apache/cordova-lib/pull/49#issuecomment-47591641 r+! @zalun, good to merge by me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: removed "pkgName "
Github user marti1125 commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/49#discussion_r14377248
--- Diff: cordova-lib/src/cordova/metadata/firefoxos_parser.js ---
@@ -58,8 +58,7 @@ module.exports.prototype = {
manifest.installs_allowed_from = manifest.installs_allowed_from ||
['*'];
manifest.version = config.version();
-manifest.name = config.name();
-manifest.pkgName = config.packageName();
+manifest.name = config.name();
--- End diff --
ok :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: removed "pkgName "
Github user rodms10 commented on the pull request: https://github.com/apache/cordova-lib/pull/49#issuecomment-47590172 Tested it, works fine. Just a minor nit on whitespaces. Thanks again! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: removed "pkgName "
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/49#discussion_r14377111
--- Diff: cordova-lib/src/cordova/metadata/firefoxos_parser.js ---
@@ -58,8 +58,7 @@ module.exports.prototype = {
manifest.installs_allowed_from = manifest.installs_allowed_from ||
['*'];
manifest.version = config.version();
-manifest.name = config.name();
-manifest.pkgName = config.packageName();
+manifest.name = config.name();
--- End diff --
nit: Can you remove the extra whitespace in the end of this line?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-network-information pull request: CB-6964. Port net...
GitHub user javierbb31 opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/12 CB-6964. Port network tests to test-framework Ported camera test from mobilespec to the new test-framework in jasmine 2.0 Added test folder. Added tests.js file inside the test folder. You can merge this pull request into a Git repository by running: $ git pull https://github.com/javierbb31/cordova-plugin-network-information master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-network-information/pull/12.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12 commit 2bcb34135a2ba1224584e592a52daa466683f924 Author: javierbb31 Date: 2014-06-30T21:06:50Z CB-6964. Port network tests to test-framework Ported camera test from mobilespec to the new test-framework in jasmine 2.0 Added test folder. Added tests.js file inside the test folder. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-dialogs pull request: CB-6965. Port notification te...
GitHub user javierbb31 opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/22 CB-6965. Port notification tests to test-framework Ported notification test from mobilespec to the new test-framework in jasmine 2.0 Added test folder. Added tests.js file inside the test folder. You can merge this pull request into a Git repository by running: $ git pull https://github.com/javierbb31/cordova-plugin-dialogs master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-dialogs/pull/22.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #22 commit d00470f79a926ab11801cfec12eb38db28ea9ba7 Author: javierbb31 Date: 2014-06-30T20:56:43Z CB-6965. Port notification tests to test-framework Ported notification test from mobilespec to the new test-framework in jasmine 2.0 Added test folder. Added tests.js file inside the test folder. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-camera pull request: CB-6958. Port camera tests to ...
GitHub user javierbb31 opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/36 CB-6958. Port camera tests to plugin-test-framework Ported camera test from mobilespec to the new test-framework in jasmine 2.0 Added test folder. Added tes.js file inside the test folder. You can merge this pull request into a Git repository by running: $ git pull https://github.com/javierbb31/cordova-plugin-camera master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/36.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #36 commit 7305c64db09c4c277bbe83a3b1341f6b70a938ec Author: javierbb31 Date: 2014-06-30T20:37:18Z CB-6958. Port camera tests to plugin-test-framework Ported camera test from mobilespec to the new test-framework in jasmine 2.0 Added test folder. Added tes.js file inside the test folder. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
RE: More questions on FileSystem directories
Kerri Shotts is going to be filing one soon. From: julio cesar sanchez Sent: Monday, June 30, 2014 1:44 PM To: dev@cordova.apache.org Subject: Re: More questions on FileSystem directories Maybe we can wait to hear more opinios about my modification. Or you can create the pull request and they will merge if they agree. 2014-06-30 16:44 GMT+02:00 Ray Camden : > Yes, I meant that the doc for cacheDirectory implies, at least to me, that > the previous entry (dataDirectorry) will not persist. I think your > modification makes sense. Do you want to make a PR for the doc or should I? > > > From: julio cesar sanchez > Sent: Monday, June 30, 2014 2:19 AM > To: dev@cordova.apache.org > Subject: Re: More questions on FileSystem directories > > "If you read this immediately after reading the docs for > cordova.file.dataDirectory, you may think that files there do NOT > survive app restarts." > > > Which ones, the files from dataDirectory or the files from cacheDirectory? > > If you mean dataDirectory, maybe the doc should be something like this: > > cordova.file.dataDirectory - Persistent data directory where to put > app-specific data files. (iOS, Android) > > cordova.file.cacheDirectory - Directory for cached data files or any > files that your app can re-create easily. The OS may delete these > files when the device runs low on storage, nevertheless, apps should > not rely on the OS to delete files in here. (iOS, Android) > > It's a mix from the apple > https://developer.apple.com/library/ios/Documentation/FileManagement/Conceptual/FileSystemProgrammingGUide/AccessingFilesandDirectories/AccessingFilesandDirectories.html#//apple_ref/doc/uid/TP40010672-CH3-SW11 > and android doc > http://developer.android.com/guide/topics/data/data-storage.html > > 2014-06-29 19:08 GMT+02:00 Ray Camden : >> According to the docs, cordova.file.cacheDirectory is: "Cached files that >> should survive app restarts. Apps should not rely on the OS to delete files >> in here. " >> >> If you read this immediately after reading the docs for >> cordova.file.dataDirectory, you may think that files there do NOT survive >> app restarts. >> >> Can we flesh out this a bit more perhaps?
[GitHub] cordova-lib pull request: removed "pkgName "
GitHub user marti1125 opened a pull request: https://github.com/apache/cordova-lib/pull/49 removed "pkgName " https://issues.apache.org/jira/browse/CB-7055 You can merge this pull request into a Git repository by running: $ git pull https://github.com/marti1125/cordova-lib CB-7055 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/49.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #49 commit d190f776405ad4ea7026695d842b0a390c423460 Author: Willy Aguirre Date: 2014-06-30T19:41:20Z removed "pkgName " --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-app-hello-world pull request: update index.html and index....
Github user zalun commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47574935 Looks good to me - I haven't tested it though. Moving JS to separate file is a good practice. I'd suggest doing that even if it wouldn't be about CSP. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-app-hello-world pull request: update index.html and index....
Github user rodms10 commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47574133 > The pull request looks fine to me. My only suggestion would be to leave a comment explaining that initialization must happen after cordova.js: > > // initialize the app after the cordova.js script so that deviceready is registered. > app.initialize(); I'm not sure this comment will be clear at this point. Maybe add something to `index.html`, right before loading `js/index.js`? Although I don't think this change really complicates this bit and the comment seems overkill. > It would be nice to have an addition Mozillian verify that the change solves CB-6949, before we merge the pull request. I tested it and @zalun will take a look too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-lib pull request: CB-7056 serve: return promise of server
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-lib/pull/48 CB-7056 serve: return promise of server + restore serve tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-lib cb_7056 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/48.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #48 commit 883720146a484f65ba35061a6f25e4a232df0b76 Author: Josh Soref Date: 2014-06-30T13:50:47Z CB-7056 serve: return promise of server + restore serve tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: More questions on FileSystem directories
Maybe we can wait to hear more opinios about my modification. Or you can create the pull request and they will merge if they agree. 2014-06-30 16:44 GMT+02:00 Ray Camden : > Yes, I meant that the doc for cacheDirectory implies, at least to me, that > the previous entry (dataDirectorry) will not persist. I think your > modification makes sense. Do you want to make a PR for the doc or should I? > > > From: julio cesar sanchez > Sent: Monday, June 30, 2014 2:19 AM > To: dev@cordova.apache.org > Subject: Re: More questions on FileSystem directories > > "If you read this immediately after reading the docs for > cordova.file.dataDirectory, you may think that files there do NOT > survive app restarts." > > > Which ones, the files from dataDirectory or the files from cacheDirectory? > > If you mean dataDirectory, maybe the doc should be something like this: > > cordova.file.dataDirectory - Persistent data directory where to put > app-specific data files. (iOS, Android) > > cordova.file.cacheDirectory - Directory for cached data files or any > files that your app can re-create easily. The OS may delete these > files when the device runs low on storage, nevertheless, apps should > not rely on the OS to delete files in here. (iOS, Android) > > It's a mix from the apple > https://developer.apple.com/library/ios/Documentation/FileManagement/Conceptual/FileSystemProgrammingGUide/AccessingFilesandDirectories/AccessingFilesandDirectories.html#//apple_ref/doc/uid/TP40010672-CH3-SW11 > and android doc > http://developer.android.com/guide/topics/data/data-storage.html > > 2014-06-29 19:08 GMT+02:00 Ray Camden : >> According to the docs, cordova.file.cacheDirectory is: "Cached files that >> should survive app restarts. Apps should not rely on the OS to delete files >> in here. " >> >> If you read this immediately after reading the docs for >> cordova.file.dataDirectory, you may think that files there do NOT survive >> app restarts. >> >> Can we flesh out this a bit more perhaps?
[GitHub] cordova-app-hello-world pull request: update index.html and index....
Github user mwbrooks commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47569377 Generally, our philosophy for the Hello World app is to avoid over complicating the code. This is why we use the `app` object instead of a self executing anonymous function, which would require a certain level of JavaScript knowledge. The pull request looks fine to me. My only suggestion would be to leave a comment explaining that initialization must happen after `cordova.js`: // initialize the app after the cordova.js script so that deviceready is registered. app.initialize(); It would be nice to have an addition Mozillian verify that the change solves [CB-6949](https://issues.apache.org/jira/browse/CB-6949), before we merge the pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-android pull request: Fix for `android` not being in PATH ...
Github user ankitjaininfo commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/103#discussion_r14366860
--- Diff: bin/lib/check_reqs.js ---
@@ -81,7 +81,7 @@ module.exports.check_android = function() {
}
return Q();
}, function(stderr) {
-if (stderr.match(/command\snot\sfound/)) {
+if (stderr.match(/command\snot\sfound/) || stderr.match(/is not
recognized as an internal or external command/)) {
--- End diff --
Same kind of error, i found on ubuntu. The way to match regex shall break
at may platforms. I have created a pull request so that it prints and error
message for easier debug.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-android pull request: Displaying error when regex does not...
GitHub user ankitjaininfo opened a pull request: https://github.com/apache/cordova-android/pull/104 Displaying error when regex does not match. On my ubuntu when `android` was not found typical output is: ``` /bin/sh: 1: android: not found ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/ankitjaininfo/cordova-android master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/104.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #104 commit ef3c8524731e98188235f1000b104a4a0ca48685 Author: Ankit Jain Date: 2014-06-30T18:29:53Z Displaying error when regex does not match. On my ubuntu when `android` is not found typical output is: ``` /bin/sh: 1: android: not found ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-app-hello-world pull request: update index.html and index....
Github user rodms10 commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47561643 Code looks good to me too. @zalun, can you take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-app-hello-world pull request: update index.html and index....
Github user marti1125 commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47559877 @JohnMcLear ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: CB-6571 Fix getParentForLocalURL...
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/58#issuecomment-47559238 No, I have all 131 tests passing. But I am not using the latest spec project -- mine is from [https://github.com/Icenium/cordova-mobile-spec/commits/fix-automatic-tests](https://github.com/Icenium/cordova-mobile-spec/commits/fix-automatic-tests). I am sorry but I have to go now and won't be available till next week. So I hope the fixes are good and get merged by then. :smiley: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: CB-6571 Fix getParentForLocalURL...
Github user martincgg commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/58#issuecomment-47558500 Ok, good. I have the latest test failing, spec 129, it is failing for you as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-device-orientation pull request: [CB-6960] Port com...
GitHub user SSRico opened a pull request: https://github.com/apache/cordova-plugin-device-orientation/pull/10 [CB-6960] Port compass tests to plugin-test-framework Ported the compass plugin (device-orientation) from mobile-spec to the new test framework with Jasmine 2.0 -Added test folder -Added test.js file inside the test folder. You can merge this pull request into a Git repository by running: $ git pull https://github.com/SSRico/cordova-plugin-device-orientation master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-device-orientation/pull/10.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #10 commit 6e44a4a9d21ea86b4af5063c5cfa4577cf7d8ff3 Author: Samir Silva Date: 2014-06-30T18:31:36Z [CB-6960] Port compass tests to plugin-test-framework Ported the compass plugin (device-orientation) from mobile-spec to the new test framework with Jasmine 2.0 -Added test folder -Added test.js file inside the test folder. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-media-capture pull request: [CB-6959] Port capture ...
GitHub user SSRico opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/21 [CB-6959] Port capture tests to plugin-test-framework Ported the compass plugin (device-orientation) from mobile-spec to the new test framework with Jasmine 2.0 -Added test folder -Added test.js file inside the test folder. You can merge this pull request into a Git repository by running: $ git pull https://github.com/SSRico/cordova-plugin-media-capture master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-media-capture/pull/21.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #21 commit 19f625a793988d976996a3afbf4edc7e78a2bdc9 Author: Samir Silva Date: 2014-06-30T18:57:31Z [CB-6959] Port capture tests to plugin-test-framework Ported the compass plugin (device-orientation) from mobile-spec to the new test framework with Jasmine 2.0 -Added test folder -Added test.js file inside the test folder. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-app-hello-world pull request: update index.html and index....
Github user JohnMcLear commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47555716 @marti1125 wut? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-firefoxos pull request: cordova.js needs to be copied to p...
Github user rodms10 closed the pull request at: https://github.com/apache/cordova-firefoxos/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-firefoxos pull request: CB-6893 Update Readme
Github user rodms10 closed the pull request at: https://github.com/apache/cordova-firefoxos/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: CB-6571 Fix getParentForLocalURL...
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/58#issuecomment-47554562 My first attempt didn't fix the second unit test -- 112. Now both must be fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-app-hello-world pull request: update index.html and index....
Github user marti1125 commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47554060 why I removed this line? because it has a warning about CSP when I validated in marketplace https://developer.mozilla.org/en-US/Apps/CSP @JohnMcLear, maybe I have to create main.js where it will have app.initialize() --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: CB-6571 Fix getParentForLocalURL...
Github user martincgg commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/58#issuecomment-47549670 It fixes file.spec.49, that was the only that I had failing, which other was failing @mbektchiev ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: CB-6571 Fix getParentForLocalURL...
Github user martincgg commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/58#issuecomment-47548810 Which unit tests are failing? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: CB-6571 Fix getParentForLocalURL...
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-plugin-file/pull/58 CB-6571 Fix getParentForLocalURL to work correctly with directories with trailing '/' Fixes 2 failing unit tests in mobile spec. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-plugin-file bektchiev/fix-android-get-parent-with-trailing-slash Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/58.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #58 commit 6990df01c98fa146d5f0ca3d125c63b103411d5e Author: Martin Bektchiev Date: 2014-06-30T15:21:08Z CB-6571 Fix getParentForLocalURL to work correctly with directories with trailing '/' Fixes 2 failing unit tests in mobile spec. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
RE: More questions on FileSystem directories
Yes, I meant that the doc for cacheDirectory implies, at least to me, that the previous entry (dataDirectorry) will not persist. I think your modification makes sense. Do you want to make a PR for the doc or should I? From: julio cesar sanchez Sent: Monday, June 30, 2014 2:19 AM To: dev@cordova.apache.org Subject: Re: More questions on FileSystem directories "If you read this immediately after reading the docs for cordova.file.dataDirectory, you may think that files there do NOT survive app restarts." Which ones, the files from dataDirectory or the files from cacheDirectory? If you mean dataDirectory, maybe the doc should be something like this: cordova.file.dataDirectory - Persistent data directory where to put app-specific data files. (iOS, Android) cordova.file.cacheDirectory - Directory for cached data files or any files that your app can re-create easily. The OS may delete these files when the device runs low on storage, nevertheless, apps should not rely on the OS to delete files in here. (iOS, Android) It's a mix from the apple https://developer.apple.com/library/ios/Documentation/FileManagement/Conceptual/FileSystemProgrammingGUide/AccessingFilesandDirectories/AccessingFilesandDirectories.html#//apple_ref/doc/uid/TP40010672-CH3-SW11 and android doc http://developer.android.com/guide/topics/data/data-storage.html 2014-06-29 19:08 GMT+02:00 Ray Camden : > According to the docs, cordova.file.cacheDirectory is: "Cached files that > should survive app restarts. Apps should not rely on the OS to delete files > in here. " > > If you read this immediately after reading the docs for > cordova.file.dataDirectory, you may think that files there do NOT survive app > restarts. > > Can we flesh out this a bit more perhaps?
Howdy
This is my first attempt at joining an Open Source project. I'm a Software Engineering student at OIT in Wilsonville Oregon. I've got my first job as a developer just a little over a year ago, and I've never been happier. Most of my work is web services in PHP, and some C++ for miscellaneous reasons. I'm very excited about the Cordova project and want to learn more about it and hopefully (between work and school) participate whenever I can. Thanks for having me! Chris
[GitHub] cordova-docs pull request: CB-6257 Add BatteryStatus row to Platfo...
GitHub user kant2002 opened a pull request: https://github.com/apache/cordova-docs/pull/216 CB-6257 Add BatteryStatus row to Platform Support You can merge this pull request into a Git repository by running: $ git pull https://github.com/kant2002/cordova-docs CB-6257 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/216.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #216 commit 1aa539e944708619dbed4516adaa940910f2a3c3 Author: Andrey Kurdyumov Date: 2014-06-30T13:56:45Z CB-6257 Add BatteryStatus row to Platform Support --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-docs pull request: CB-6261 Add Vibration row to Platform S...
GitHub user kant2002 opened a pull request: https://github.com/apache/cordova-docs/pull/215 CB-6261 Add Vibration row to Platform Support You can merge this pull request into a Git repository by running: $ git pull https://github.com/kant2002/cordova-docs CB-6261 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/215.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #215 commit 3002694e74f25b65025cd35cbf6051db3477114e Author: Andrey Kurdyumov Date: 2014-06-30T13:48:46Z CB-6261 Add Vibration row to Platform Support commit 6bbd1f064132fd19aae8c621f3f18998110fc0b6 Author: Andrey Kurdyumov Date: 2014-06-30T13:50:57Z CB-6261 Add Vibration row to Platform Support --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-docs pull request: CB-6262 Add StatusBar to Plugin APIs
GitHub user kant2002 opened a pull request: https://github.com/apache/cordova-docs/pull/214 CB-6262 Add StatusBar to Plugin APIs You can merge this pull request into a Git repository by running: $ git pull https://github.com/kant2002/cordova-docs CB-6262 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/214.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #214 commit 67f3ed95a0df629eb8959e56d3352a6b109259da Author: Andrey Kurdyumov Date: 2014-06-30T13:38:16Z CB-6262 Add StatusBar to Plugin APIs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
RE: Releasing contacts
Here is fix for CB-7003. Tested on Android 4.3 and 2.3.6 https://github.com/apache/cordova-plugin-contacts/pull/32 Thx! Sergey -Original Message- From: iclell...@google.com [mailto:iclell...@google.com] On Behalf Of Ian Clelland Sent: Friday, June 27, 2014 11:01 PM To: dev@cordova.apache.org Subject: Re: Releasing contacts That seems legitimate; I think we can delay for that. How long do you think it'll take to deal with it? On Fri, Jun 27, 2014 at 2:44 PM, Sergey Grebnov (Akvelon) < v-seg...@microsoft.com> wrote: > Hi Ian, > > I planned to take a look on CB-7003 navigator.contacts.pickContact > picks wrong contact on Android 4.3 and 4.4.3 versions" on Monday. It > will be great if we can include this fix to release. > > https://issues.apache.org/jira/browse/CB-7003 > > Thx! > Sergey > -Original Message- > From: iclell...@google.com [mailto:iclell...@google.com] On Behalf Of > Ian Clelland > Sent: Friday, June 27, 2014 10:36 PM > To: dev@cordova.apache.org > Subject: Releasing contacts > > I've reverted the change to Contacts that switched the order of > parameters in navigator.contacts.find (Sorry, guys, it's just a change > that we can't make in a point release, no matter how out-of-line the > signature is with the rest of the Cordova methods) > > That fixes all of the contacts failures for me on iOS and Android, so > I'm going to add that to the 0.2.11 candidate release and send that > out for vote again. People have been asking for an update to Contacts > in the registry, so hopefully we can all pull together and get this > out there :) > > I'll start a vote thread as soon as I've created all of the necessary > artifacts. > > Ian >
[GitHub] cordova-plugin-contacts pull request: fixes CB-7003 navigator.cont...
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/32 fixes CB-7003 navigator.contacts.pickContact picks wrong contact on Android 4.3 and 4.4.3 versions https://issues.apache.org/jira/browse/CB-7003 pickContact: added logic to convert CONTACT_ID to RAW_CONTACT_ID required by contactAccessor.getContactById Tested on Android 4.3 and 2.3.6 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-contacts CB-7003 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-contacts/pull/32.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #32 commit 6e08ee7239723c251d75e91f25af7b1bfae9c8c8 Author: sgrebnov Date: 2014-06-30T11:46:26Z fixes CB-7003 navigator.contacts.pickContact picks wrong contact on Android 4.3 and 4.4.3 versions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-app-hello-world pull request: update index.html and index....
Github user JohnMcLear commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47515954 PR looks fine to me, this i how I would have made this change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-firefoxos pull request: cordova.js needs to be copied to p...
Github user zalun commented on the pull request: https://github.com/apache/cordova-firefoxos/pull/16#issuecomment-47512259 Merged - please close --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-firefoxos pull request: CB-6893 Update Readme
Github user zalun commented on the pull request: https://github.com/apache/cordova-firefoxos/pull/17#issuecomment-47512212 No idea why it's not closed - merged already --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-file pull request: changed header
GitHub user morenoh149 opened a pull request: https://github.com/apache/cordova-plugin-file/pull/57 changed header changed Firefox OS Quirks header to match ios quirks You can merge this pull request into a Git repository by running: $ git pull https://github.com/morenoh149/cordova-plugin-file patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/57.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #57 commit 5ca9d2d9fdd9492733556a92d3b5f04be9b8ea94 Author: Harry Moreno Date: 2014-06-30T08:53:51Z changed header changed Firefox OS Quirks header to match ios quirks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cordova-plugin-splashscreen pull request: CB-3562 Disable screen r...
Github user emarashliev commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-47504184 Hi @agrieve, it's necessary because we have to disable auto rotation during the splash screen is shown. And then after splash screen is hidden we have to restore default auto rotation state. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: More questions on FileSystem directories
"If you read this immediately after reading the docs for cordova.file.dataDirectory, you may think that files there do NOT survive app restarts." Which ones, the files from dataDirectory or the files from cacheDirectory? If you mean dataDirectory, maybe the doc should be something like this: cordova.file.dataDirectory - Persistent data directory where to put app-specific data files. (iOS, Android) cordova.file.cacheDirectory - Directory for cached data files or any files that your app can re-create easily. The OS may delete these files when the device runs low on storage, nevertheless, apps should not rely on the OS to delete files in here. (iOS, Android) It's a mix from the apple https://developer.apple.com/library/ios/Documentation/FileManagement/Conceptual/FileSystemProgrammingGUide/AccessingFilesandDirectories/AccessingFilesandDirectories.html#//apple_ref/doc/uid/TP40010672-CH3-SW11 and android doc http://developer.android.com/guide/topics/data/data-storage.html 2014-06-29 19:08 GMT+02:00 Ray Camden : > According to the docs, cordova.file.cacheDirectory is: "Cached files that > should survive app restarts. Apps should not rely on the OS to delete files > in here. " > > If you read this immediately after reading the docs for > cordova.file.dataDirectory, you may think that files there do NOT survive app > restarts. > > Can we flesh out this a bit more perhaps?
