[GitHub] cordova-docs pull request: Corrected the documentation for splash ...

2014-07-12 Thread AxelNennker
GitHub user AxelNennker opened a pull request:

https://github.com/apache/cordova-docs/pull/219

Corrected the documentation for splash screens

The documentation was for the Phonegap Build system and did not apply to 
Cordova.
Updated the documentation to reflect the improvements introduced by CB-3571

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/AxelNennker/cordova-docs master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/219.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #219


commit 6f5a461c7d675178f1d411d617229dc175ab28a7
Author: AxelNennker 
Date:   2013-11-16T09:35:19Z

Update plugin.md

commit ce6ebd68eb5b5a8bf8530edc24b2a1da8722c12f
Author: ignisvulpis 
Date:   2014-06-05T12:34:27Z

Merge remote-tracking branch 'upstream/master'

commit ccb7c1b72fcd64a3d90ae7c6525edfda46a6bc7f
Author: ignisvulpis 
Date:   2014-06-05T12:44:01Z

CB-2606: base directory of 
Date:   2014-06-09T22:42:51Z

Add Vagrant support.

commit 911e00527b7e1323f68dd2f4961ec9cdd3896b75
Author: Michael Brooks 
Date:   2014-06-09T22:43:10Z

Fix rendering of Polish documentation.

commit 9f2b117fd06da38e2660f0f77f34b16a00958d5d
Author: Michael Brooks 
Date:   2014-06-09T23:06:56Z

[lib] Improve version menu rendering performance.

commit c316b346bfeefc7ff82449b58bdc35a9d6c234bd
Author: Michael Brooks 
Date:   2014-06-09T23:35:35Z

[lib] Remove debug put messages from version_menu.rb.

commit 5653f0f17d376d54501b2e8fa14786e20cb87852
Author: Marcel Kinard 
Date:   2014-06-10T12:35:26Z

Add a bit more explanation about vagrant.

commit 24c814aa61ebd706f6233bd7629c9cdb1333915e
Author: Michael Brooks 
Date:   2014-06-11T18:17:12Z

Fix version menu selection of current langauge.

commit dfd5cc1f0963bf018ed152623816fde79ab48464
Author: Jesse MacFadyen 
Date:   2014-06-11T20:47:49Z

updated wp8 plugin authoring to not use wp7 terms or classpath

commit 353c7b51327f81271e1a3d9776db1b8ec71911cc
Author: Jesse MacFadyen 
Date:   2014-06-11T20:48:57Z

link to new windows 8 plugin auth guide

commit 4c2cb8c57421bd0e53d503373c2716f29259ed53
Author: Jesse MacFadyen 
Date:   2014-06-11T20:49:43Z

Created Windows 8 plugin auth guide.

commit dfca8511a51b27342ba1c1c7ea1204513208beb7
Author: Marcel Kinard 
Date:   2014-06-11T21:14:15Z

CB-6926 Clarify some misconceptions

- Cordova does not provide any UI widgets or MV* frameworks
- plugins should have a unified JS interface
- no plugins are present in a newly-created project
- HTML5 app assets usually are local to the device instead of served 
remotely

commit 0d426670931d88fa7a80197267f0ab8f3a0906be
Author: Marcel Kinard 
Date:   2014-06-11T21:31:01Z

CB-6926 Clarify locally stored HTML5 assets

commit 5b944031e57942fef7fee9d89014c889d4d9fb15
Author: Marcel Kinard 
Date:   2014-06-12T01:36:25Z

Clarify a heading

commit df3864aace36f343b418bfdb5b579a69c8349f88
Author: mbillau 
Date:   2014-06-16T18:07:39Z

CB-5294 fixed by Android 4.4.3

commit ea6e6a612371efe18b1628658cf82af464c8b4fd
Author: Jesse MacFadyen 
Date:   2014-06-16T18:54:48Z

update edge without windows phone 7

commit 2eb16134342cd564b65391cd6e8a272feff7c138
Author: Jesse MacFadyen 
Date:   2014-06-16T19:13:18Z

update [en] 3.5.0 without windows phone 7

commit b43bf09b105aa6e4fa2a8e7781bcba2f0a451cf9
Author: Archana Naik 
Date:   2014-06-03T20:25:01Z

[CB-6740][amazon-fireos]Clean up error reporting when AmazonWebView SDK not 
found
Updated amazon-fireos platform guide with new location for AWV SDK.

commit 243b974eef67710442fde9837e5cc94c0f9b20fc
Author: Jesse MacFadyen 
Date:   2014-06-16T20:36:31Z

Fix format issue with license headers

commit b1c615ce208abe2ec83a57655c3919f2846a0122
Author: Michal Mocny 
Date:   2014-06-23T14:33:21Z

CB-6772 Document AndroidLaunchMode preference

commit ff02f38c7f3eed8e2126393270f08b9e69d95104
Author: Lisa Seacat DeLuca 
Date:   2014-05-30T14:54:01Z

Added wiki details for crowdin best practices

close #208

commit d221be5bea44f5d43ff527c5de2966b196b43794
Author: Michael Brooks 
Date:   2014-06-26T23:45:08Z

[CB-5226] Fix BlackBerry 10 Configuration link.

commit e6f1e94da74059e4b7fb93ff4d567e91ad701514
Author: Andrew Grieve 
Date:   2014-06-27T15:09:47Z

Use markdown-style links instead of  tags in README.md

commit 4a90b7ddb678b02cb591efb44218493d38ee9192
Author: Martin Bektchiev 
Date:   2014-06-04T15:22:03Z

CB-6344 CB-6698 `after` for ``, `` for Android

close #210

commit cc62edee63eb30de96a5331982a54d57f93e2d71
Author: Andrew Grieve 
Date:   2014-06-27T15:13:09Z

CB-6698 Remove explicit `` from example since `` 
now copies it in by default

commit a919b2745f5ebdc21389124e780ffdb954398706
Author: Lisa 

[GitHub] cordova-lib pull request: CB-7118 iOS: add target-device and Minim...

2014-07-12 Thread sriranggd
Github user sriranggd commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/57#discussion_r14855708
  
--- Diff: cordova-lib/src/cordova/metadata/ios_parser.js ---
@@ -217,6 +220,38 @@ module.exports.prototype = {
 self.update_overrides();
 util.deleteSvnFolders(self.www_dir());
 });
+},
+
+update_build_settings:function(config) {
+var targetDevice = 
parseTargetDevicePreference(config.getPreference('target-device', 'ios'));
+var deploymentTarget = config.getPreference('deployment-target', 
'ios');
+
+// no build settings provided, we don't need to parse and update 
.pbxproj file
+if (!targetDevice && !deploymentTarget) {
+return Q();
+}
+
+var me = this;
+var d = Q.defer();
+var proj = new xcode.project(this.pbxproj);
+proj.parse(function(err,hash) {
+if (err) {
+d.reject(new Error('An error occured during parsing of 
project.pbxproj. Start weeping. Output: ' + err));
+return;
+}
+var buildConfiguration = proj.pbxXCBuildConfigurationSection();
+if (targetDevice) {
+// TODO: replace propReplace with proj.updateBuildProperty 
after below is release
+// https://github.com/alunny/node-xcode/pull/33
--- End diff --

Looks like your changes to xcode module were accepted and also released as 
version `0.6.7`. I think it would be best to put in the new 
`updateBuildProperty` and get this merged, along with an update to the `xcode` 
version in the dependency list.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cordova-app-harness pull request: CB-7098 Fix reference to Cordova...

2014-07-12 Thread disusered
Github user disusered closed the pull request at:

https://github.com/apache/cordova-app-harness/pull/2


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


RE: recent tools update, Splash screen support

2014-07-12 Thread Ray Camden
Just raising this again - are there docs for this?


From: Ray Camden 
Sent: Friday, July 11, 2014 5:46 AM
To: dev@cordova.apache.org
Subject: RE: recent tools update, Splash screen support

So basically the docs are *not* up to the date for any of this yet?

From: Sergey Grebnov (Akvelon) 
Sent: Friday, July 11, 2014 1:15 AM
To: dev@cordova.apache.org
Subject: RE: recent tools update, Splash screen support

I volunteer to test splash/icons support one more time and update the docs 
where it is required.

* The old documentation refers to PG Build. Cordova implementation is based on 
this idea, but there are some differences, for example we don't support gap: 
prefix and platform attribute, platform specific icons must be placed inside 
corresponding  element
* We updated icons related docs as part of Cordova icons support 
implementation, I will double check that it is still accurate (for example I 
see that it mentions platform attribute which is not supported)
* We should update splash screen related docs part (as per our implementation + 
examples)
* Splash screen plugin and splash screen images support are related but 
different features. Core splash screen support by CLI allows replacing default 
template images which are showed automatically, where the plugin works on top 
of this and allows programmatically show/hide splash screen (pls correct me if 
I'm wrong).



Re: Playing sound on Android does not respect system settings

2014-07-12 Thread Andrey Kurdumov
I mean that I could not play sound file in the notification media stream on
Android. Not using Media plugin, and not using Notification plugin.
12 Июл 2014 г. 15:46 пользователь "Jan Velecký"  написал:

> Well, you sure, but Notification plugin should respect notification volume
> settings like Media plugin respect media volume settings. If it's not
> respect that, then it's a bug in Notification plugin I think.
>
>
> -- Původní zpráva --
>
> Od: Andrey Kurdumov 
>
> Komu: dev@cordova.apache.org
>
> Datum: 12. 7. 2014 11:20:19
>
> Předmět: Re: Playing sound on Android does not respect system settings
>
>
> "You are right Jan. Current plugin does respect media sound volume. I did
>
> not realize that because when I turn off sound I expect that it would be
>
> turned off entirely, not only for calls, notifications and system sounds.
>
> Then I have another question. I play short sounds and treat them as
>
> notifications. So I expecting that they would be suppressed. Current
>
> implementation does not support that scenario. Notification plugin also
>
> does not support such scenario. Maybe we could provide some workaround for
>
> Android to allow playing files on notification stream on Android?
>
> 12 Июл 2014 г. 14:53 пользователь "Jan Velecký" 
> написал:
>
>
>
> > @Andrey Kurdumov:
>
> > Do you sure you think a media volume system settings? Because there are
> on
>
> > Android separated media, notifications and alarm volume. Media plugin
>
> > should
>
> > respect media volume settings, not notifications system settings.
>
> >
>
> > I ask only for do it clear for me."


Re: Why CordovaPlugin doesn't implementing powerful event such as onCofigurationchanged or onSizeChanged?

2014-07-12 Thread Jan Velecký
Well, I did some testing and you are wright, but there's problem. 
OnLayoutChangeListener is Android thing since API11+. I don't know if 
Cordova still supports Android 2.2, but surely still supports Android 2.3. 
So, onSizeChanged event for plugin is still needed.

"

For onSizeChanged, I think you can use addOnLayoutChangedListener(). 

onConfigurationChanged seems reasonable though. Filed this as https://
issues.apache.org/jira/browse/CB-7085
(https://issues.apache.org/jira/browse/CB-7085) 

"

Re: Playing sound on Android does not respect system settings

2014-07-12 Thread Jan Velecký
Well, you sure, but Notification plugin should respect notification volume 
settings like Media plugin respect media volume settings. If it's not 
respect that, then it's a bug in Notification plugin I think.


-- Původní zpráva --

Od: Andrey Kurdumov 

Komu: dev@cordova.apache.org

Datum: 12. 7. 2014 11:20:19

Předmět: Re: Playing sound on Android does not respect system settings


"You are right Jan. Current plugin does respect media sound volume. I did

not realize that because when I turn off sound I expect that it would be

turned off entirely, not only for calls, notifications and system sounds.

Then I have another question. I play short sounds and treat them as

notifications. So I expecting that they would be suppressed. Current

implementation does not support that scenario. Notification plugin also

does not support such scenario. Maybe we could provide some workaround for

Android to allow playing files on notification stream on Android?

12 Июл 2014 г. 14:53 пользователь "Jan Velecký"  написал:



> @Andrey Kurdumov:

> Do you sure you think a media volume system settings? Because there are on

> Android separated media, notifications and alarm volume. Media plugin

> should

> respect media volume settings, not notifications system settings.

>

> I ask only for do it clear for me."

Re: Playing sound on Android does not respect system settings

2014-07-12 Thread Andrey Kurdumov
You are right Jan. Current plugin does respect media sound volume. I did
not realize that because when I turn off sound I expect that it would be
turned off entirely, not only for calls, notifications and system sounds.
Then I have another question. I play short sounds and treat them as
notifications. So I expecting that they would be suppressed. Current
implementation does not support that scenario. Notification plugin also
does not support such scenario. Maybe we could provide some workaround for
Android to allow playing files on notification stream on Android?
12 Июл 2014 г. 14:53 пользователь "Jan Velecký"  написал:

> @Andrey Kurdumov:
> Do you sure you think a media volume system settings? Because there are on
> Android separated media, notifications and alarm volume. Media plugin
> should
> respect media volume settings, not notifications system settings.
>
> I ask only for do it clear for me.


Re: Playing sound on Android does not respect system settings

2014-07-12 Thread Jan Velecký
@Andrey Kurdumov:
Do you sure you think a media volume system settings? Because there are on 
Android separated media, notifications and alarm volume. Media plugin should
respect media volume settings, not notifications system settings.

I ask only for do it clear for me.

Re: Playing sound on Android does not respect system settings

2014-07-12 Thread Andrey Kurdumov
I do and will send pull request when fix would be ready.
11 Июл 2014 г. 23:22 пользователь "Joe Bowser"  написал:

> Please file an issue in JIRA, otherwise we can't track it, and it'll be
> forgotten.
> On Jul 11, 2014 9:37 AM, "Andrew Grieve"  wrote:
>
> > Makes sense to me! :)
> >
> >
> > On Fri, Jul 11, 2014 at 11:35 AM, Andrey Kurdumov <
> kant2...@googlemail.com
> > >
> > wrote:
> >
> > > Hi guys,
> > >
> > > I have latest version of Media plugin on Android and have following
> > > behavior when playing sound. When playing sound it does not respect
> > > settings which user set on their phone. For example when user mute
> sound
> > > entirely, sounds still playing, when I lower volume of the sound, it is
> > > still playing loud, as this change is not applied. I see only setVolume
> > > method and no getVolume method, so I could not manually set volume for
> > the
> > > sound as a workaround.
> > >
> > > What I think would be good is that by default if I play sounds on
> Android
> > > it will be played with same volume which is specified in system
> settings
> > by
> > > user and setVolume operates respectful to the current user preference
> for
> > > the volume. For example when calling setVolume(1.0) lead to playind
> sound
> > > with volume specified in the current settings, not max volume available
> > to
> > > the device.
> > >
> > > Regarding that I have following concerns:
> > > 1. What are behavior on other platforms, should it be changed also to
> > match
> > > with proposed behavior?
> > > 2. Would this be breaking change, and thus should be avoided?
> > >
> > > For me as a developer which using Cordova proposed behavoir is
> preferred,
> > > since t allows me easier way of handling sound. I could live with
> > getVolume
> > > provided me current system volume settings, but that way each developer
> > > like me would implement similar system like me. Would be good that
> > actually
> > > Cordova provide such implementation without the need to reimplement
> that
> > > for each application.
> > >
> > > I interested in having this on Android and iOS and could implement that
> > > myself on both platforms if needed.
> > > I would like to hear from you guys about this idea, before I jump in
> and
> > > start creating patch/pull request with implementation.
> > >
> > > For reference I have Samsung Galaxy Note 3 with Android 4.4.2 and
> Samsung
> > > S4 with Android 4.4.2 and on both I experience same behaviour
> > >
> > > Thanks,
> > > Andrey Kurdyumov
> > >
> >
>