[GitHub] cordova-android pull request: CB-8201 Add support for auth dialogs...

[sgrebnov]

Github user sgrebnov commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/143#discussion_r22919310
  
--- Diff: framework/src/org/apache/cordova/CordovaWebViewClient.java ---
@@ -89,6 +97,15 @@ public void setWebView(CordovaWebView view) {
 this.appView = view;
 helper = new CordovaUriHelper(cordova, view);
 }
+
+/**
+ * Specifies the HTTP auth handler for handling auth challenge 
requests.
+ *
+ * @param handler HTTP auth handler.
+ */
+public void setHttpAuthRequestHandler(HttpAuthRequestHandler handler) {
--- End diff --

Understand and thx!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-7667 iOS8: Handle case wher...

[dpolivy]

Github user dpolivy commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/49#issuecomment-69861487
  
I cleaned up the merge conflict, and I believe it's now working again. I 
had a bunch of issues upgrading my plugin (CDVCamera.m seemed to drop off the 
list of compiled source files?), but got those sorted out and it seems ok. 
Please do sanity test it on your side as well!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Renaming CordovaWebView CordovaWebInterface

[Andrew Grieve]

Looking at our core plugins, several of them would break if we renamed this
file. For that reason, I think keep it as-is for now.

Here's my grep:

http://pastebin.com/dqvyiMLS

On Tue, Jan 13, 2015 at 7:30 PM, Josh Soref  wrote:

> I'm not an Android developer, but I recently ‎saw how the
> getPluginManager() -> pluginManager change can be handled. I also know that
> it's possible to build wrappers for interface changes.
>
> I wouldn't be opposed to this change.
>
> I'd probably ask for sample transition code so that people who want to
> support both can copy and paste to get there.
>
> (There should be copy and paste code for the Plug-in Manager, I'm not sure
> if there is...)
>
> Sent from my BlackBerry 10 smartphone.
>   Original Message
> From: Joe Bowser
> Sent: Tuesday, January 13, 2015 7:26 PM
> To: dev
> Reply To: dev@cordova.apache.org
> Subject: Renaming CordovaWebView CordovaWebInterface
>
> So, this was something that was brought up numerous times, but I think we
> should probably discuss this at least one more time before we move to
> finish off 4.0.x.
>
> Given that we're breaking the API for CordovaWebView already, would it make
> sense for us to call it a CordovaWebInterface instead? The class has been
> changed to an interface, and this would changing it in the Plugin API, but
> it would make it more clear what we intend to do with this method in the
> future.
>
> What do people think? Should we rename this, or keep it the way it is so
> that we keep most of the plugins, including third party plugins working
> with 4.0.x, and then do the breakage in 5.0.x.
>
> Note: I want the timeframe between 4.0.x and 5.0.x to be a lot shorter.
> There's a lot of iterations that people want to do on this, and we should
> release major releases a little more often than once a year for Android,
> but that's for another thread.
>
> Thoughts?
>
> Joe
>
>

Re: Introduction

[Andrew Grieve]

Welcome Nikhil!

On Tue, Jan 13, 2015 at 4:59 PM, Steven Gill  wrote:

> Welcome Nikhil!
>
> On Tue, Jan 13, 2015 at 1:56 PM, Nikhil Khandelwal  >
> wrote:
>
> > Hi,
> > I am an engineering manager at Microsoft leading a team working on
> > Cordova. I have been following some of the discussions on the dev mailing
> > list and love the energy of this project.
> >
> > I have already signed and submitted the Apache ICLA. I have my first pull
> > request for the browser platform - support for 'cordova platform update'
> > for browser platform (CB-8206):
> > https://github.com/apache/cordova-browser/pull/6
> >
> > I would love to hear your feedback on this.
> >
> > Thanks,
> > Nikhil
> >
>

[GitHub] cordova-mobile-spec pull request: CB-8295 Enable CSP for mobile sp...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-mobile-spec/pull/115


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-browser/pull/6#discussion_r22911133
  
--- Diff: node_modules/.bin/shjs ---
@@ -1 +1,15 @@
-../shelljs/bin/shjs
--- End diff --

This is done automagically by node on windows to create a shim for a *nix 
batch file: 
http://stackoverflow.com/questions/10396305/npm-package-bin-script-for-windows. 
While I agree with you that this is not strictly related to `update` change, 
since this is in the `node_modules` directory, I would prefer to keep this as 
is. Let me know if you still disagree. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: CB-8296 add check at re...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-file-transfer/pull/57


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-8201 Add support for auth dialogs...

[agrieve]

Github user agrieve commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/143#discussion_r22909913
  
--- Diff: framework/src/org/apache/cordova/CordovaWebViewClient.java ---
@@ -89,6 +97,15 @@ public void setWebView(CordovaWebView view) {
 this.appView = view;
 helper = new CordovaUriHelper(cordova, view);
 }
+
+/**
+ * Specifies the HTTP auth handler for handling auth challenge 
requests.
+ *
+ * @param handler HTTP auth handler.
+ */
+public void setHttpAuthRequestHandler(HttpAuthRequestHandler handler) {
--- End diff --

Right now, almost all plugin hooks are implemented by adding a method to 
CordovaPlugin and PluginManager (which loops over all plugins and calls the 
corresponding CordovaPlugin method).

Calling plugins based on what interfaces they implement is a neat idea, 
although it'd be a new concept to the project. I'm not actually sure if there 
are benefits to it or not! Likely we could use that info to improve performance 
a bit, but perf isn't an issue atm afaik.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Renaming CordovaWebView CordovaWebInterface

[Josh Soref]

I'm not an Android developer, but I recently ‎saw how the getPluginManager() -> 
pluginManager change can be handled. I also know that it's possible to build 
wrappers for interface changes. 

I wouldn't be opposed to this change. 

I'd probably ask for sample transition code so that people who want to support 
both can copy and paste to get there. 

(There should be copy and paste code for the Plug-in Manager, I'm not sure if 
there is...)

Sent from my BlackBerry 10 smartphone.
  Original Message  
From: Joe Bowser
Sent: Tuesday, January 13, 2015 7:26 PM
To: dev
Reply To: dev@cordova.apache.org
Subject: Renaming CordovaWebView CordovaWebInterface

So, this was something that was brought up numerous times, but I think we
should probably discuss this at least one more time before we move to
finish off 4.0.x.

Given that we're breaking the API for CordovaWebView already, would it make
sense for us to call it a CordovaWebInterface instead? The class has been
changed to an interface, and this would changing it in the Plugin API, but
it would make it more clear what we intend to do with this method in the
future.

What do people think? Should we rename this, or keep it the way it is so
that we keep most of the plugins, including third party plugins working
with 4.0.x, and then do the breakage in 5.0.x.

Note: I want the timeframe between 4.0.x and 5.0.x to be a lot shorter.
There's a lot of iterations that people want to do on this, and we should
release major releases a little more often than once a year for Android,
but that's for another thread.

Thoughts?

Joe



smime.p7s
Description: S/MIME cryptographic signature

Renaming CordovaWebView CordovaWebInterface

[Joe Bowser]

So, this was something that was brought up numerous times, but I think we
should probably discuss this at least one more time before we move to
finish off 4.0.x.

Given that we're breaking the API for CordovaWebView already, would it make
sense for us to call it a CordovaWebInterface instead? The class has been
changed to an interface, and this would changing it in the Plugin API, but
it would make it more clear what we intend to do with this method in the
future.

What do people think? Should we rename this, or keep it the way it is so
that we keep most of the plugins, including third party plugins working
with 4.0.x, and then do the breakage in 5.0.x.

Note: I want the timeframe between 4.0.x and 5.0.x to be a lot shorter.
There's a lot of iterations that people want to do on this, and we should
release major releases a little more often than once a year for Android,
but that's for another thread.

Thoughts?

Joe

RE: platforms/plugins save and restore from config.xml

[Mefire O .]

This PR adds support for git-urls to 'cordova platform add' : 
https://github.com/apache/cordova-lib/pull/148
Please, review.

Thanks,
Mefire

-Original Message-
From: Treggiari, Leo [mailto:leo.treggi...@intel.com] 
Sent: Tuesday, January 13, 2015 8:18 AM
To: dev@cordova.apache.org
Subject: RE: platforms/plugins save and restore from config.xml

I agree with always saving and automatically re-fetching sources and platforms 
when needed.  With regards to the other conversation going on re: automatic add 
of a platform, I think the CLI should automatically do things when it is 
reasonably unambiguous what the user wants - e.g. if they explicitly say build 
for iOS then CLI adds the platform if it is needed.  If you are on Windows and 
you say build for iOS, you get an error, which you would even if CLI had 
allowed you to add the platform - e.g. for a cross platform, multi-developer 
scenario.

If save/restore are 'optional', then as others have pointed out, other problems 
cannot be solved unless the user has used the save and restore command/options. 
 I don't want my IDE to be saying:  "didn't I tell you that you need to use the 
save/restore command options if you want to do any operations outside of the 
IDE!".

Leo

-Original Message-
From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve
Sent: Tuesday, January 13, 2015 6:57 AM
To: Gorkem Ercan
Cc: dev; Andrew Grieve; Michael Brooks
Subject: Re: platforms/plugins save and restore from config.xml

Saving all the time certainly would make this simpler. If we save all of the 
time, we can also make uninstall a part of prepare. E.g. If users edits their 
config.xml and removes a , then prepare can detect that and plugman 
uninstall it before building. If we don't always save, then editing your 
config.xml wouldn't be that meaningful unless you delete & recreate platforms 
every time.

On Mon, Jan 12, 2015 at 10:29 PM, Gorkem Ercan 
wrote:

>
>
> On 12 Jan 2015, at 22:09, Andrew Grieve wrote:
>
>  Related to this, but maybe can be discussed outside of the doc just fine:
>>
>> https://issues.apache.org/jira/browse/CB-4275
>>
>> Right now when we add a new platform, we do a for-each on directories 
>> within plugins/ and add them as well. This causes all plugins to wind 
>> up as top-level plugins even when they are dependent plugins on 
>> existing platforms.
>>
>> Having plugins listed in config.xml, I think it would make sense to 
>> change this logic to plugin add based on plugins within config.xml 
>> rather than directories that exist within plugins. We could 
>> potentially still add all of them if no plugins are listed in config.xml for 
>> backwards compat.
>>
>>
> Related to that, I was looking at CB-8278[1] this bug not only causes 
> the variables to be lost also it causes the top-level plugin info to 
> vanish as well.
> We could also fix this problem easier too if we are saving plugins to 
> config.xml all the time. Which means no save command or --save.
>
> [1] https://issues.apache.org/jira/browse/CB-8278
>
>
>
>>
>> On Mon, Jan 12, 2015 at 9:19 PM, Andrew Grieve 
>> wrote:
>>
>>  Thanks for putting the doc together. Added some comments to it.
>>>
>>> On Mon, Jan 12, 2015 at 5:39 PM, Mefire O. 
>>> wrote:
>>>
>>>  Google docs link :
 https://docs.google.com/document/d/1qKjhzSf48ybGg2GFZPtjXP8dkF4Z5
 Jnc7FU41V3-jFc/edit

 Thanks,
 Mefire

 -Original Message-
 From: Mefire O. [mailto:ommen...@microsoft.com]
 Sent: Monday, January 12, 2015 2:12 PM
 To: dev@cordova.apache.org
 Cc: Michael Brooks
 Subject: RE: platforms/plugins save and restore from config.xml

 Here's what I propose, let me know what you think :

 'cordova platform add'
  * No -save flag, No 'autosave' setting in 
 project_dir/.cordova/config.json
  1. 'cordova platform add android' => restores the 
 android platform from config.xml. If config.xml doesn't have any 
 android engine, falls back to using the pinned CLI version.
  * With -save flag or 'autosave' setting in 
 project_dir/.cordova/config.json
  1. 'cordova platform add 
 https://github.com/apache/cordova-android.git -save' => clones the 
 git repo and adds the android platform to the project, then updates 
 config.xml and point its version to the specified git-url.
  2. 'cordova platform add android@ 
 https://github.com/apache/cordova-android.git -save' => clones the 
 git repo and adds the android platform to the project, then updates 
 config.xml and point its version to the specified git-url.
  3. 'cordova platform add C:/path/to/android/platform 
 -save' => adds the android platform to the project, then updates 
 config.xml and point its version to the specified folder location.
  * --Save flag is used in CLI-based workflows, and 'autosave'
 (project_dir/.cordova/co

[GitHub] cordova-plugin-media pull request: Add Media.prototype.setRate met...

[whitecolor]

Github user whitecolor commented on the pull request:

https://github.com/apache/cordova-plugin-media/pull/40#issuecomment-69843977
  
Any comments?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

[purplecabbage]

Github user purplecabbage commented on a diff in the pull request:

https://github.com/apache/cordova-browser/pull/6#discussion_r22905510
  
--- Diff: bin/lib/update.js ---
@@ -0,0 +1,59 @@
+/*
+   Licensed to the Apache Software Foundation (ASF) under one
+   or more contributor license agreements.  See the NOTICE file
+   distributed with this work for additional information
+   regarding copyright ownership.  The ASF licenses this file
+   to you under the Apache License, Version 2.0 (the
+   "License"); you may not use this file except in compliance
+   with the License.  You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing,
+   software distributed under the License is distributed on an
+   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+   KIND, either express or implied.  See the License for the
+   specific language governing permissions and limitations
+   under the License.
+*/
+
+var Q  = require('Q'),
+create = require('./create'),
+fs = require('fs'),
+shell = require('shelljs');
+
+module.exports.help = function () {
+console.log("WARNING : Make sure to back up your project before 
updating!");
+console.log("Usage: update PathToProject ");
+console.log("PathToProject : The path the project you would like 
to update.");
+console.log("examples:");
+console.log("update C:\\Users\\anonymous\\Desktop\\MyProject");
+};
+
+module.exports.run = function (argv) {
+var projectPath = argv[2];
+if (!fs.existsSync(projectPath)) {
+// if specified project path is not valid then reject promise
+Q.reject("Browser platform does not exist here: " + projectPath);
+}
+return Q().then(function() {
+console.log("Removing existing browser platform.");
+shellfatal(shell.rm, '-rf', projectPath);
+create.createProject(projectPath);
+});
+}
+
+function shellfatal(shellFunc)
+{
+var slicedArgs = Array.prototype.slice.call(arguments, 1);
+try
+{
+shell.config.fatal = true;
+var returnVal = shellFunc.apply(shell, slicedArgs);
+}   
+finally
+{
+shell.config.fatal = false;
+}
+return returnVal;
+}
--- End diff --


http://stackoverflow.com/questions/729692/why-should-files-end-with-a-newline
Generally a best practice, not just js, and not just this project.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-browser/pull/6#discussion_r22905187
  
--- Diff: bin/lib/update.js ---
@@ -0,0 +1,59 @@
+/*
+   Licensed to the Apache Software Foundation (ASF) under one
+   or more contributor license agreements.  See the NOTICE file
+   distributed with this work for additional information
+   regarding copyright ownership.  The ASF licenses this file
+   to you under the Apache License, Version 2.0 (the
+   "License"); you may not use this file except in compliance
+   with the License.  You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing,
+   software distributed under the License is distributed on an
+   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+   KIND, either express or implied.  See the License for the
+   specific language governing permissions and limitations
+   under the License.
+*/
+
+var Q  = require('Q'),
+create = require('./create'),
+fs = require('fs'),
+shell = require('shelljs');
+
+module.exports.help = function () {
+console.log("WARNING : Make sure to back up your project before 
updating!");
+console.log("Usage: update PathToProject ");
+console.log("PathToProject : The path the project you would like 
to update.");
+console.log("examples:");
+console.log("update C:\\Users\\anonymous\\Desktop\\MyProject");
+};
+
+module.exports.run = function (argv) {
+var projectPath = argv[2];
+if (!fs.existsSync(projectPath)) {
+// if specified project path is not valid then reject promise
+Q.reject("Browser platform does not exist here: " + projectPath);
+}
+return Q().then(function() {
+console.log("Removing existing browser platform.");
+shellfatal(shell.rm, '-rf', projectPath);
+create.createProject(projectPath);
+});
+}
+
+function shellfatal(shellFunc)
+{
+var slicedArgs = Array.prototype.slice.call(arguments, 1);
+try
+{
+shell.config.fatal = true;
+var returnVal = shellFunc.apply(shell, slicedArgs);
+}   
+finally
+{
+shell.config.fatal = false;
+}
+return returnVal;
+}
--- End diff --

Interesting! I will fix this. I'm curious - what's the rationale behind 
this? Is this just a styling best practice on this project or in JavaScript 
community?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-browser/pull/6#discussion_r22905021
  
--- Diff: bin/lib/create.js ---
@@ -26,14 +26,11 @@ var fs = require('fs'),
 ROOT= path.join(__dirname, '..', '..'),
 check_reqs = require('./check_reqs');
 
-
 exports.createProject = function(project_path,package_name,project_name){
 var VERSION = fs.readFileSync(path.join(ROOT, 'VERSION'), 'utf-8');
 
 // Set default values for path, package and name
 project_path = typeof project_path !== 'undefined' ? project_path : 
"CordovaExample";
-package_name = typeof package_name !== 'undefined' ? package_name : 
'org.apache.cordova.example';
--- End diff --

Turns out that `update` depends on `create`. As I mentioned in my pull 
request, I had to remove these console.log messages as for the browser platform 
we do not save the package and project name on creation. On upgrade, I do not 
have a package and project name when I invoke `createProject`. These messages 
had marginal value so I decided to remove them. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-8239 Add support for git urls to 'cor...

[omefire]

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/148#discussion_r22904360
  
--- Diff: cordova-lib/spec-cordova/platform.spec.js ---
@@ -354,22 +359,94 @@ describe('add function', function () {
 });
 });
 
-it('fails if there is an error while getting the platform details', 
function (done) {
+it('tries to git-clone if there is an error while getting the platform 
details as specified from the command line', function (done) {
 
-var targets = ['C:\\Projects\\cordova-projects\\cordova-android'];
+var targets = ['https://github.com/apache/cordova-android'],
+   targetPlatform = 'android',
+   libDir = 
'C:\\Projects\\cordova-projects\\cordova-android-clone-directory';
+
+   var cloneGitRepoMock = jasmine.createSpy().andReturn(Q({
+   platform: targetPlatform,
+   libDir: libDir
+   }));
+   platform.__set__('cloneGitRepo', cloneGitRepoMock);
--- End diff --

@jsoref , why do I still need a PR to update 
https://github.com/apache/cordova-cli/blob/38dd67242841dd2ec254f7f9f402f495f7a28f5b/doc/platform.txt#L20
 ?
It seems like the file already refers to s


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-8239 Add support for git urls to 'cor...

[jsoref]

Github user jsoref commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/148#discussion_r22900366
  
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -76,97 +77,94 @@ function add(hooksRunner, projectRoot, targets, opts) {
 }
 
 return hooksRunner.fire('before_platform_add', opts)
-.then(function() {
-return promiseutil.Q_chainmap(targets, function(target) {
-// For each platform, download it and call its "create" script.
-var parts = target.split('@');
-var platform = parts[0];
-var version = parts[1];
-
-return Q.when().then(function() {
-if (!(platform in platforms)) {
-return getPlatformDetailsFromDir(target);
-} else {
-if (!version) {
-events.emit('verbose', 'No version supplied. 
Retrieving version from config.xml...');
-}
-version = version || 
getVersionFromConfigFile(platform, cfg);
-var tgt = version ? (platform + '@' + version) : 
platform;
-return isDirectory(version) ? 
getPlatformDetailsFromDir(version) : downloadPlatform(projectRoot, tgt, opts);
-}
-}).then(function(platDetails) {
-var template = config_json && config_json.lib && 
config_json.lib[platform] && config_json.lib[platform].template || null;
-return call_into_create(platDetails.platform, projectRoot, 
cfg, platDetails.libDir, template, opts);
-});
-});
-})
-.then(function() {
-return hooksRunner.fire('after_platform_add', opts);
-});
+   .then(function () {
--- End diff --

please don't insert tabs. and please try to avoid rewriting large chunks of 
files when adding features.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-8239 Add support for git urls to 'cor...

[jsoref]

Github user jsoref commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/148#discussion_r22900311
  
--- Diff: cordova-lib/spec-cordova/platform.spec.js ---
@@ -354,22 +359,94 @@ describe('add function', function () {
 });
 });
 
-it('fails if there is an error while getting the platform details', 
function (done) {
+it('tries to git-clone if there is an error while getting the platform 
details as specified from the command line', function (done) {
 
-var targets = ['C:\\Projects\\cordova-projects\\cordova-android'];
+var targets = ['https://github.com/apache/cordova-android'],
+   targetPlatform = 'android',
+   libDir = 
'C:\\Projects\\cordova-projects\\cordova-android-clone-directory';
+
+   var cloneGitRepoMock = jasmine.createSpy().andReturn(Q({
+   platform: targetPlatform,
+   libDir: libDir
+   }));
+   platform.__set__('cloneGitRepo', cloneGitRepoMock);
--- End diff --

you're inserting some tabs.

in general, tabs are frowned upon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-8239 Add support for git urls to 'cor...

[jsoref]

Github user jsoref commented on the pull request:

https://github.com/apache/cordova-lib/pull/148#issuecomment-69831696
  
please ensure there's a PR to update:

https://github.com/apache/cordova-cli/blob/38dd67242841dd2ec254f7f9f402f495f7a28f5b/doc/platform.txt#L20


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

[jsoref]

Github user jsoref commented on a diff in the pull request:

https://github.com/apache/cordova-browser/pull/6#discussion_r22899820
  
--- Diff: node_modules/.bin/shjs ---
@@ -1 +1,15 @@
-../shelljs/bin/shjs
--- End diff --

this change looks like you replaced a *nix symlink w/ a file.

the change shouldn't be done in the same commit as adding support for 
`update`.
and you should probably do something to ensure that someone doesn't later 
undo this when working from *nix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

[jsoref]

Github user jsoref commented on a diff in the pull request:

https://github.com/apache/cordova-browser/pull/6#discussion_r22899501
  
--- Diff: bin/lib/create.js ---
@@ -26,14 +26,11 @@ var fs = require('fs'),
 ROOT= path.join(__dirname, '..', '..'),
 check_reqs = require('./check_reqs');
 
-
 exports.createProject = function(project_path,package_name,project_name){
 var VERSION = fs.readFileSync(path.join(ROOT, 'VERSION'), 'utf-8');
 
 // Set default values for path, package and name
 project_path = typeof project_path !== 'undefined' ? project_path : 
"CordovaExample";
-package_name = typeof package_name !== 'undefined' ? package_name : 
'org.apache.cordova.example';
--- End diff --

this looks suspiciously like you saved after updating and overwrote someone 
else's changes.

in general, adding a feature (like `update`) shouldn't have any impact to a 
parallel command (like `create`)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-8239 Add support for git urls to 'cor...

[omefire]

GitHub user omefire opened a pull request:

https://github.com/apache/cordova-lib/pull/148

CB-8239 Add support for git urls to 'cordova platform add'

CB-8239 Add support for git urls to 'cordova platform add'

These changes allow the following scenarios:
 *users can issue 'cordova platform add 
https://github.com/apache/cordova-android.git' and the git repo will be cloned 
and used.
 *users can issue 'cordova platform add 
android@https://github.com/apache/cordova-android.git' and the git repo will be 
cloned and used.
 *users can issue 'cordova platform add android' and if their 
config.xml file contains: ', then the git repo 
pointed to by config.xml will be cloned and used.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-lib CB-8239

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/148.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #148


commit be356c294c35152b4698fa90458dbd77ad7c4b42
Author: Omar Mefire 
Date:   2015-01-05T17:29:02Z

CB-8239 Add support for git urls to 'cordova platform add'




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

[jsoref]

Github user jsoref commented on a diff in the pull request:

https://github.com/apache/cordova-browser/pull/6#discussion_r22899370
  
--- Diff: bin/lib/update.js ---
@@ -0,0 +1,59 @@
+/*
+   Licensed to the Apache Software Foundation (ASF) under one
+   or more contributor license agreements.  See the NOTICE file
+   distributed with this work for additional information
+   regarding copyright ownership.  The ASF licenses this file
+   to you under the Apache License, Version 2.0 (the
+   "License"); you may not use this file except in compliance
+   with the License.  You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing,
+   software distributed under the License is distributed on an
+   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+   KIND, either express or implied.  See the License for the
+   specific language governing permissions and limitations
+   under the License.
+*/
+
+var Q  = require('Q'),
+create = require('./create'),
+fs = require('fs'),
+shell = require('shelljs');
+
+module.exports.help = function () {
+console.log("WARNING : Make sure to back up your project before 
updating!");
+console.log("Usage: update PathToProject ");
+console.log("PathToProject : The path the project you would like 
to update.");
+console.log("examples:");
+console.log("update C:\\Users\\anonymous\\Desktop\\MyProject");
+};
+
+module.exports.run = function (argv) {
+var projectPath = argv[2];
+if (!fs.existsSync(projectPath)) {
+// if specified project path is not valid then reject promise
+Q.reject("Browser platform does not exist here: " + projectPath);
+}
+return Q().then(function() {
+console.log("Removing existing browser platform.");
+shellfatal(shell.rm, '-rf', projectPath);
+create.createProject(projectPath);
+});
+}
+
+function shellfatal(shellFunc)
+{
+var slicedArgs = Array.prototype.slice.call(arguments, 1);
+try
+{
+shell.config.fatal = true;
+var returnVal = shellFunc.apply(shell, slicedArgs);
+}   
+finally
+{
+shell.config.fatal = false;
+}
+return returnVal;
+}
--- End diff --

The red mark here means that you didn't insert a newline at the end of your 
file. please do insert one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device pull request: Internet Explorer browser supp...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-device/pull/28


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Introduction

[Steven Gill]

Welcome Nikhil!

On Tue, Jan 13, 2015 at 1:56 PM, Nikhil Khandelwal 
wrote:

> Hi,
> I am an engineering manager at Microsoft leading a team working on
> Cordova. I have been following some of the discussions on the dev mailing
> list and love the energy of this project.
>
> I have already signed and submitted the Apache ICLA. I have my first pull
> request for the browser platform - support for 'cordova platform update'
> for browser platform (CB-8206):
> https://github.com/apache/cordova-browser/pull/6
>
> I would love to hear your feedback on this.
>
> Thanks,
> Nikhil
>

Introduction

[Nikhil Khandelwal]

Hi,
I am an engineering manager at Microsoft leading a team working on Cordova. I 
have been following some of the discussions on the dev mailing list and love 
the energy of this project.

I have already signed and submitted the Apache ICLA. I have my first pull 
request for the browser platform - support for 'cordova platform update' for 
browser platform (CB-8206): https://github.com/apache/cordova-browser/pull/6

I would love to hear your feedback on this.

Thanks,
Nikhil

[GitHub] cordova-mobile-spec pull request: CB-8295 Enable CSP for mobile sp...

[jpchase]

GitHub user jpchase opened a pull request:

https://github.com/apache/cordova-mobile-spec/pull/115

CB-8295 Enable CSP for mobile spec

- Uses a javascript include file to document.write a CSP  tag on page
- Minor changes to test pages where need to comply with CSP (e.g. remove 
inline event handler)
- Changed to Bridge auto tests to remove nested specs, which was causing an 
error on Android
- Some test pages excluded from CSP (e.g. those with heavy use of inline 
javascript)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jpchase/cordova-mobile-spec CB-8295

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-mobile-spec/pull/115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #115


commit 008fa545d97479080aa577407bb18c0503753379
Author: Jason Chase 
Date:   2015-01-13T21:51:18Z

CB-8295 Enable CSP for mobile spec
- Uses a javascript include file to document.write a CSP  tag on page
- Minor changes to test pages where need to comply with CSP (e.g. remove 
inline event handler)
- Changed to Bridge auto tests to remove nested specs, which was causing an 
error on Android
- Some test pages excluded from CSP (e.g. those with heavy use of inline 
javascript)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

[nikhilkh]

GitHub user nikhilkh opened a pull request:

https://github.com/apache/cordova-browser/pull/6

CB-8206: Browser platform: Add support for update

This change add supports for updating the browser platform. I ended up 
deleting a couple of log messages from create as there is no way to retrieve 
and log them on update.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-browser CB-8206

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-browser/pull/6.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #6


commit aad4c25d489468df32b871fd00ec4a1f64d9a34d
Author: Nikhil Khandelwal 
Date:   2014-12-19T01:14:18Z

CB-8206: Browser platform: Add support for update




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-js pull request: Cleanup unused stuff. CB-8057

[purplecabbage]

Github user purplecabbage closed the pull request at:

https://github.com/apache/cordova-js/pull/90


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Deprecation Wars: ICS vs Gingerbread

[Joe Bowser]

Firefox works on 2.3, and Chrome does not. It also depends on the device

On Tue, Jan 13, 2015, 12:20 PM Josh Soref  wrote:

> Michal Mocny wrote:
> >... we aren't telling those individuals that they cannot use
> >their phones, we are telling developers that want to create new
> >applications for that target to either build mobile web, packaged native,
> >or just stick to existing versions of cordova if really needed.
> >
> >I do not buy the argument that you are doing those individuals with those
> >phones a favour by building them hybrid apps using the antiquated 2.3
> >webview on antiquated machine specs.
>
> I don't have an opinion on this. But I do have a question.
>
> Ignoring the fact that GeckoView is flaky today,
>
> 1. Does GeckoView / Firefox work (at all? well?) on a sample / typical 2.3
> device?
> 2. Can I run Chrome (or some relative) on that same device (at all? well?)
>

Re: Deprecation Wars: ICS vs Gingerbread

[Josh Soref]

Michal Mocny wrote:
>... we aren't telling those individuals that they cannot use
>their phones, we are telling developers that want to create new
>applications for that target to either build mobile web, packaged native,
>or just stick to existing versions of cordova if really needed.
>
>I do not buy the argument that you are doing those individuals with those
>phones a favour by building them hybrid apps using the antiquated 2.3
>webview on antiquated machine specs.

I don't have an opinion on this. But I do have a question.

Ignoring the fact that GeckoView is flaky today,

1. Does GeckoView / Firefox work (at all? well?) on a sample / typical 2.3
device?
2. Can I run Chrome (or some relative) on that same device (at all? well?)


smime.p7s
Description: S/MIME cryptographic signature

Re: Deprecation Wars: ICS vs Gingerbread

[Michal Mocny]

Victor, I don't disagree with your observation that those phones serve a
purpose.  But we aren't telling those individuals that they cannot use
their phones, we are telling developers that want to create new
applications for that target to either build mobile web, packaged native,
or just stick to existing versions of cordova if really needed.

I do not buy the argument that you are doing those individuals with those
phones a favour by building them hybrid apps using the antiquated 2.3
webview on antiquated machine specs.

-Michal

On Tue, Jan 13, 2015 at 2:02 PM, Joe Bowser  wrote:

> Those are the exact people the Android One program is meant to target.  I
> rounded up when I stated the price of these devices.
>
> On Tue Jan 13 2015 at 10:42:38 AM Victor Sosa 
> wrote:
>
> > Well... Not trying to create a polemic here, but you can ask that to
> > persons who earn $10USD a day, and yes, many of these persons have a
> > very-old-yet-cheap smartphone
> >
> > 2015-01-13 12:33 GMT-06:00 Joe Bowser :
> >
> > > Agreed.  That would mean that 3.7.x would be the last release where we
> > > support Android 2.3.x.  I don't think that MozillaView is in a good
> > enough
> > > state for us to recommend that path to users.  At this point, I can say
> > > that the owners of these 78 million phones should buy a new phone.
> It's
> > > not like a phone running KitKat can't be bought for $100.
> > >
> > > On Tue Jan 13 2015 at 10:26:17 AM Brian LeRoux  wrote:
> > >
> > > > I agree, we're not really supporting these devices, and it is
> > > disingenuous
> > > > of the project to advertise that we do. Any apps concerning
> themselves
> > > with
> > > > privacy/security won't be targeting or testing on those devices
> either.
> > > >
> > > > I think a clean break w/ the message 4.x === 4.x, coupled with many
> > > > webviews and we have a very solid forward looking release.
> > > >
> > > > On Tue, Jan 13, 2015 at 10:10 AM, Michal Mocny 
> > > > wrote:
> > > >
> > > > > Does it really matter?  I think Joe summarized it best, we can only
> > > claim
> > > > > to support what is actually being supported (aka actively tested,
> > > > actively
> > > > > maintained).  Market share doesn't impact that.
> > > > >
> > > > > Not that we should not actively break 2.3 support, but with 3.7 on
> > the
> > > > > horizon, and big changes coming in 4.0, it would be nice to signal
> > that
> > > > as
> > > > > the last version supporting 2.3 and have us be free to make changes
> > > that
> > > > > cannot be compatible with the older version.
> > > > >
> > > > > -Michal
> > > > >
> > > > > On Tue, Jan 13, 2015 at 12:22 PM, Joe Bowser 
> > > wrote:
> > > > >
> > > > > > So, where are these numbers coming from?  Can we get a breakdown
> by
> > > > > region?
> > > > > >
> > > > > > On Tue Jan 13 2015 at 3:30:23 AM Marcel Kinard <
> cmarc...@gmail.com
> > >
> > > > > wrote:
> > > > > >
> > > > > > > Another stat: Forbes estimates that the existing number of
> > Android
> > > > > phones
> > > > > > > is 1.56 billion. Five percent of that is 78 million.
> > > > > > >
> > > > > > > > On Jan 13, 2015, at 1:14 AM, Ally Ogilvie <
> aogil...@wizcorp.jp
> > >
> > > > > wrote:
> > > > > > > >
> > > > > > > > moar stats:
> > > > > > > > https://mixpanel.com/trends/#report/android_os_adoption/
> > > > > > > from_date:-365,to_date:0
> > > > > > >
> > > > > > >
> > > > > > > 
> > > > -
> > > > > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > > > > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> >
> >
> > --
> > Victor Adrian Sosa Herrera
> > IBM Software Engineer
> > Guadalajara, Jalisco
> >
>

[GitHub] cordova-plugin-globalization pull request: CB-7972 Add cordova-plu...

[sgrebnov]

Github user sgrebnov commented on the pull request:


https://github.com/apache/cordova-plugin-globalization/pull/31#issuecomment-69810429
  
thank you @purplecabbage


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-8201 Add support for auth dialogs...

[sgrebnov]

Github user sgrebnov commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/143#discussion_r22890354
  
--- Diff: framework/src/org/apache/cordova/HttpAuthRequestHandler.java ---
@@ -0,0 +1,30 @@
+/*
+   Licensed to the Apache Software Foundation (ASF) under one
+   or more contributor license agreements.  See the NOTICE file
+   distributed with this work for additional information
+   regarding copyright ownership.  The ASF licenses this file
+   to you under the Apache License, Version 2.0 (the
+   "License"); you may not use this file except in compliance
+   with the License.  You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing,
+   software distributed under the License is distributed on an
+   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+   KIND, either express or implied.  See the License for the
+   specific language governing permissions and limitations
+   under the License.
+*/
+package org.apache.cordova;
+
+import android.webkit.HttpAuthHandler;
+import android.webkit.WebView;
--- End diff --

Thank you, will be updated!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-8201 Add support for auth dialogs...

[sgrebnov]

Github user sgrebnov commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/143#discussion_r22890349
  
--- Diff: framework/src/org/apache/cordova/CordovaWebViewClient.java ---
@@ -89,6 +97,15 @@ public void setWebView(CordovaWebView view) {
 this.appView = view;
 helper = new CordovaUriHelper(cordova, view);
 }
+
+/**
+ * Specifies the HTTP auth handler for handling auth challenge 
requests.
+ *
+ * @param handler HTTP auth handler.
+ */
+public void setHttpAuthRequestHandler(HttpAuthRequestHandler handler) {
--- End diff --

Andrew could you please clarify the callback idea in more details? - Does 
it mean walk thru all available plugins and see which one implements some 
specific interface (like HttpAuthRequestHandler) and if so call corresponding 
method?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-globalization pull request: CB-7972 Add cordova-plu...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-globalization/pull/31


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Cordova-Android 3.7.0 Release

[Andrew Grieve]

Left some comments

On Tue, Jan 13, 2015 at 12:49 PM, Sergey Grebnov (Akvelon) <
v-seg...@microsoft.com> wrote:

> +1 Could someone also take a look on the following pending PR and merge it
> before starting release if possible
>
> CB-8201 Add support for auth dialogs into Cordova Android
> https://github.com/apache/cordova-android/pull/143
>
> Thx!
> Sergey
> -Original Message-
> From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew
> Grieve
> Sent: Tuesday, January 13, 2015 6:17 PM
> To: dev
> Subject: Re: [DISCUSS] Cordova-Android 3.7.0 Release
>
> +1
>
> On Mon, Jan 12, 2015 at 6:04 PM, Shazron  wrote:
>
> > +1
> >
> > On Mon, Jan 12, 2015 at 12:15 PM, Steven Gill 
> > wrote:
> > > Do it! +1
> > >
> > > On Mon, Jan 12, 2015 at 10:44 AM, Joe Bowser 
> wrote:
> > >
> > >> Hey
> > >>
> > >> How do people feel about releasing 3.7.0 this week.  I'm trying to
> give
> > as
> > >> much notice as possible since that's my style and this is January.
> > 3.7.0
> > >> will be our very last 3.x release, and we should try to make sure that
> > it's
> > >> good for the next six months of support.
> > >>
> > >> Thoughts?
> > >>
> > >> Joe
> > >>
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>

[GitHub] cordova-android pull request: CB-8201 Add support for auth dialogs...

[agrieve]

Github user agrieve commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/143#discussion_r22887338
  
--- Diff: framework/src/org/apache/cordova/HttpAuthRequestHandler.java ---
@@ -0,0 +1,30 @@
+/*
+   Licensed to the Apache Software Foundation (ASF) under one
+   or more contributor license agreements.  See the NOTICE file
+   distributed with this work for additional information
+   regarding copyright ownership.  The ASF licenses this file
+   to you under the Apache License, Version 2.0 (the
+   "License"); you may not use this file except in compliance
+   with the License.  You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing,
+   software distributed under the License is distributed on an
+   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+   KIND, either express or implied.  See the License for the
+   specific language governing permissions and limitations
+   under the License.
+*/
+package org.apache.cordova;
+
+import android.webkit.HttpAuthHandler;
+import android.webkit.WebView;
--- End diff --

For android-4.0.x, we're trying to do away with referring to 
android.webkit.WebView explicitly. It'd be better to pass in the 
CordovaWebView, and to create an abstraction around HttpAuthHandler that just 
wraps the webkit one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-8201 Add support for auth dialogs...

[agrieve]

Github user agrieve commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/143#discussion_r22887184
  
--- Diff: framework/src/org/apache/cordova/CordovaWebViewClient.java ---
@@ -89,6 +97,15 @@ public void setWebView(CordovaWebView view) {
 this.appView = view;
 helper = new CordovaUriHelper(cordova, view);
 }
+
+/**
+ * Specifies the HTTP auth handler for handling auth challenge 
requests.
+ *
+ * @param handler HTTP auth handler.
+ */
+public void setHttpAuthRequestHandler(HttpAuthRequestHandler handler) {
--- End diff --

Why use a setter here instead of following the plugin pattern of allowing 
all plugins to handle the callback?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-8201 Add support for auth dialogs...

[agrieve]

Github user agrieve commented on a diff in the pull request:

https://github.com/apache/cordova-android/pull/143#discussion_r22887157
  
--- Diff: framework/src/org/apache/cordova/CordovaActivity.java ---
@@ -147,6 +147,17 @@ public void setAuthenticationToken(AuthenticationToken 
authenticationToken, Stri
 }
 
 /**
+ * Specifies the HTTP auth handler for handling auth challenge 
requests.
+ *
+ * @param handler The HTTP auth handler.
+ */
+public void setHttpAuthRequestHandler(HttpAuthRequestHandler handler) {
--- End diff --

If there's no direct reason to add this to CordovaActivity, I'd prefer it 
not added. CordovaActivity has a lot of symbols in it already, and they a 
little bit just add noise.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: proposed utility

[Staci Cooper]

When I was implementing this I initially did add it as a '--local / -l'
option to the cli. My concern was that it requires the developer to have a
global installation of Cordova even if all they want is the local command.
And assuming the user's global and local installs have different version
numbers, all they would have to do is accidentally omit the -l and they
would unwittingly use the wrong version of Cordova.

I could add it back in as a flag, or have separate 'cordova' and
'cordova-local' commands in
the cli. Or were you suggesting changing the default behavior of the
cordova command to shell
out to local? In which case we could have a flag to turn that behavior off
for backwards
compatibility... or to fallback to the global version if no local version
is found. Hm, I'm not sure..

On Fri, Jan 9, 2015 at 4:35 PM, Jesse  wrote:

> Do we need to start a discussion around cordova-cli plugins?
>
> Personally I prefer keeping this in a separate repo.
>
> @purplecabbage
> risingj.com
>
> On Fri, Jan 9, 2015 at 1:08 PM, Tommy Williams  wrote:
>
> > Just as an aside, I have resorted to:
> >
> > alias cdv="./node_modules/.bin/cordova"
> >
> > Heh.
> > On 10/01/2015 8:06 am, "Tommy Williams"  wrote:
> >
> > > +1 for what Michal describes. Better going forward as well as backwards
> > > compatibility.
> > >
> > > Win win?
> > > On 10/01/2015 7:54 am, "Michal Mocny"  wrote:
> > >
> > >> I like the way gulp works: the same package acts different when
> > installed
> > >> globally/locally.  Namely, the global always shells work off to the
> > local.
> > >>
> > >> So, instead of a separate cordova-local utility (akin to grunt and
> > >> grunt-cli), perhaps we just add your feature directly into
> cordova-cli?
> > >>
> > >> For backwards compat, I think we should still allow the global
> > cordova-cli
> > >> to do work as we do now (i.e. we don't *require* local installs), but
> > if a
> > >> local install happens to exist it would shell out to that.
> > >>
> > >> Anyway, neat that you've implemented this already!
> > >>
> > >> On Fri, Jan 9, 2015 at 3:41 PM, Staci Cooper 
> > wrote:
> > >>
> > >> > A while ago I made a utility called cordova-local for managing
> > multiple
> > >> > local Cordova installations. It's similar to how grunt/grunt-cli
> > works;
> > >> > once installed globally, you run 'cordova-local' instead of
> 'cordova'
> > >> and
> > >> > it will locate and pass its arguments off to the closest
> installation.
> > >> >
> > >> > It's kept and installed independently of the cli but my initial idea
> > >> was to
> > >> > keep it in the cordova-cli repo. Since that would complicate the
> > >> > tools-release/versioning process I closed that PR and would like to
> > >> propose
> > >> > including it as a new repo. I added some specs and docs and put it
> in
> > a
> > >> > utilities repo that could be used for similar cli-independent tools,
> > >> > currently here: https://github.com/stacic/cordova-utility. I added
> > some
> > >> > tests to it and also made PRs for documenting the utility in
> > >> cordova-docs
> > >> >  and adding it to
> > the
> > >> > tools release in cordova-coho
> > >> > .
> > >> >
> > >> > Opinions? Concerns?
> > >> >
> > >>
> > >
> >
>

Re: Deprecation Wars: ICS vs Gingerbread

[Joe Bowser]

Those are the exact people the Android One program is meant to target.  I
rounded up when I stated the price of these devices.

On Tue Jan 13 2015 at 10:42:38 AM Victor Sosa 
wrote:

> Well... Not trying to create a polemic here, but you can ask that to
> persons who earn $10USD a day, and yes, many of these persons have a
> very-old-yet-cheap smartphone
>
> 2015-01-13 12:33 GMT-06:00 Joe Bowser :
>
> > Agreed.  That would mean that 3.7.x would be the last release where we
> > support Android 2.3.x.  I don't think that MozillaView is in a good
> enough
> > state for us to recommend that path to users.  At this point, I can say
> > that the owners of these 78 million phones should buy a new phone.  It's
> > not like a phone running KitKat can't be bought for $100.
> >
> > On Tue Jan 13 2015 at 10:26:17 AM Brian LeRoux  wrote:
> >
> > > I agree, we're not really supporting these devices, and it is
> > disingenuous
> > > of the project to advertise that we do. Any apps concerning themselves
> > with
> > > privacy/security won't be targeting or testing on those devices either.
> > >
> > > I think a clean break w/ the message 4.x === 4.x, coupled with many
> > > webviews and we have a very solid forward looking release.
> > >
> > > On Tue, Jan 13, 2015 at 10:10 AM, Michal Mocny 
> > > wrote:
> > >
> > > > Does it really matter?  I think Joe summarized it best, we can only
> > claim
> > > > to support what is actually being supported (aka actively tested,
> > > actively
> > > > maintained).  Market share doesn't impact that.
> > > >
> > > > Not that we should not actively break 2.3 support, but with 3.7 on
> the
> > > > horizon, and big changes coming in 4.0, it would be nice to signal
> that
> > > as
> > > > the last version supporting 2.3 and have us be free to make changes
> > that
> > > > cannot be compatible with the older version.
> > > >
> > > > -Michal
> > > >
> > > > On Tue, Jan 13, 2015 at 12:22 PM, Joe Bowser 
> > wrote:
> > > >
> > > > > So, where are these numbers coming from?  Can we get a breakdown by
> > > > region?
> > > > >
> > > > > On Tue Jan 13 2015 at 3:30:23 AM Marcel Kinard  >
> > > > wrote:
> > > > >
> > > > > > Another stat: Forbes estimates that the existing number of
> Android
> > > > phones
> > > > > > is 1.56 billion. Five percent of that is 78 million.
> > > > > >
> > > > > > > On Jan 13, 2015, at 1:14 AM, Ally Ogilvie  >
> > > > wrote:
> > > > > > >
> > > > > > > moar stats:
> > > > > > > https://mixpanel.com/trends/#report/android_os_adoption/
> > > > > > from_date:-365,to_date:0
> > > > > >
> > > > > >
> > > > > > 
> > > -
> > > > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > > > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
>
>
> --
> Victor Adrian Sosa Herrera
> IBM Software Engineer
> Guadalajara, Jalisco
>

Re: Deprecation Wars: ICS vs Gingerbread

[Joe Bowser]

On Tue Jan 13 2015 at 10:42:38 AM Victor Sosa 
wrote:

> Well... Not trying to create a polemic here, but you can ask that to
> persons who earn $10USD a day, and yes, many of these persons have a
> very-old-yet-cheap smartphone
>
> 2015-01-13 12:33 GMT-06:00 Joe Bowser :
>
> > Agreed.  That would mean that 3.7.x would be the last release where we
> > support Android 2.3.x.  I don't think that MozillaView is in a good
> enough
> > state for us to recommend that path to users.  At this point, I can say
> > that the owners of these 78 million phones should buy a new phone.  It's
> > not like a phone running KitKat can't be bought for $100.
> >
> > On Tue Jan 13 2015 at 10:26:17 AM Brian LeRoux  wrote:
> >
> > > I agree, we're not really supporting these devices, and it is
> > disingenuous
> > > of the project to advertise that we do. Any apps concerning themselves
> > with
> > > privacy/security won't be targeting or testing on those devices either.
> > >
> > > I think a clean break w/ the message 4.x === 4.x, coupled with many
> > > webviews and we have a very solid forward looking release.
> > >
> > > On Tue, Jan 13, 2015 at 10:10 AM, Michal Mocny 
> > > wrote:
> > >
> > > > Does it really matter?  I think Joe summarized it best, we can only
> > claim
> > > > to support what is actually being supported (aka actively tested,
> > > actively
> > > > maintained).  Market share doesn't impact that.
> > > >
> > > > Not that we should not actively break 2.3 support, but with 3.7 on
> the
> > > > horizon, and big changes coming in 4.0, it would be nice to signal
> that
> > > as
> > > > the last version supporting 2.3 and have us be free to make changes
> > that
> > > > cannot be compatible with the older version.
> > > >
> > > > -Michal
> > > >
> > > > On Tue, Jan 13, 2015 at 12:22 PM, Joe Bowser 
> > wrote:
> > > >
> > > > > So, where are these numbers coming from?  Can we get a breakdown by
> > > > region?
> > > > >
> > > > > On Tue Jan 13 2015 at 3:30:23 AM Marcel Kinard  >
> > > > wrote:
> > > > >
> > > > > > Another stat: Forbes estimates that the existing number of
> Android
> > > > phones
> > > > > > is 1.56 billion. Five percent of that is 78 million.
> > > > > >
> > > > > > > On Jan 13, 2015, at 1:14 AM, Ally Ogilvie  >
> > > > wrote:
> > > > > > >
> > > > > > > moar stats:
> > > > > > > https://mixpanel.com/trends/#report/android_os_adoption/
> > > > > > from_date:-365,to_date:0
> > > > > >
> > > > > >
> > > > > > 
> > > -
> > > > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > > > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
>
>
> --
> Victor Adrian Sosa Herrera
> IBM Software Engineer
> Guadalajara, Jalisco
>

Re: Deprecation Wars: ICS vs Gingerbread

[Victor Sosa]

Well... Not trying to create a polemic here, but you can ask that to
persons who earn $10USD a day, and yes, many of these persons have a
very-old-yet-cheap smartphone

2015-01-13 12:33 GMT-06:00 Joe Bowser :

> Agreed.  That would mean that 3.7.x would be the last release where we
> support Android 2.3.x.  I don't think that MozillaView is in a good enough
> state for us to recommend that path to users.  At this point, I can say
> that the owners of these 78 million phones should buy a new phone.  It's
> not like a phone running KitKat can't be bought for $100.
>
> On Tue Jan 13 2015 at 10:26:17 AM Brian LeRoux  wrote:
>
> > I agree, we're not really supporting these devices, and it is
> disingenuous
> > of the project to advertise that we do. Any apps concerning themselves
> with
> > privacy/security won't be targeting or testing on those devices either.
> >
> > I think a clean break w/ the message 4.x === 4.x, coupled with many
> > webviews and we have a very solid forward looking release.
> >
> > On Tue, Jan 13, 2015 at 10:10 AM, Michal Mocny 
> > wrote:
> >
> > > Does it really matter?  I think Joe summarized it best, we can only
> claim
> > > to support what is actually being supported (aka actively tested,
> > actively
> > > maintained).  Market share doesn't impact that.
> > >
> > > Not that we should not actively break 2.3 support, but with 3.7 on the
> > > horizon, and big changes coming in 4.0, it would be nice to signal that
> > as
> > > the last version supporting 2.3 and have us be free to make changes
> that
> > > cannot be compatible with the older version.
> > >
> > > -Michal
> > >
> > > On Tue, Jan 13, 2015 at 12:22 PM, Joe Bowser 
> wrote:
> > >
> > > > So, where are these numbers coming from?  Can we get a breakdown by
> > > region?
> > > >
> > > > On Tue Jan 13 2015 at 3:30:23 AM Marcel Kinard 
> > > wrote:
> > > >
> > > > > Another stat: Forbes estimates that the existing number of Android
> > > phones
> > > > > is 1.56 billion. Five percent of that is 78 million.
> > > > >
> > > > > > On Jan 13, 2015, at 1:14 AM, Ally Ogilvie 
> > > wrote:
> > > > > >
> > > > > > moar stats:
> > > > > > https://mixpanel.com/trends/#report/android_os_adoption/
> > > > > from_date:-365,to_date:0
> > > > >
> > > > >
> > > > > 
> > -
> > > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > > > >
> > > > >
> > > >
> > >
> >
>



-- 
Victor Adrian Sosa Herrera
IBM Software Engineer
Guadalajara, Jalisco

[GitHub] cordova-lib pull request: CB-8168 --list support for cordova-lib

[muratsu]

Github user muratsu commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/145#discussion_r22883426
  
--- Diff: cordova-lib/src/cordova/targets.js ---
@@ -0,0 +1,65 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var cordova_util = require('./util'),
+Q = require('q'),
+superspawn = require('./superspawn'),
+path = require('path');
+
+function handleError(error) {
+if (error.code === 'ENOENT') {
+console.log('Platform not supported');
--- End diff --

fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Deprecation Wars: ICS vs Gingerbread

[Joe Bowser]

Agreed.  That would mean that 3.7.x would be the last release where we
support Android 2.3.x.  I don't think that MozillaView is in a good enough
state for us to recommend that path to users.  At this point, I can say
that the owners of these 78 million phones should buy a new phone.  It's
not like a phone running KitKat can't be bought for $100.

On Tue Jan 13 2015 at 10:26:17 AM Brian LeRoux  wrote:

> I agree, we're not really supporting these devices, and it is disingenuous
> of the project to advertise that we do. Any apps concerning themselves with
> privacy/security won't be targeting or testing on those devices either.
>
> I think a clean break w/ the message 4.x === 4.x, coupled with many
> webviews and we have a very solid forward looking release.
>
> On Tue, Jan 13, 2015 at 10:10 AM, Michal Mocny 
> wrote:
>
> > Does it really matter?  I think Joe summarized it best, we can only claim
> > to support what is actually being supported (aka actively tested,
> actively
> > maintained).  Market share doesn't impact that.
> >
> > Not that we should not actively break 2.3 support, but with 3.7 on the
> > horizon, and big changes coming in 4.0, it would be nice to signal that
> as
> > the last version supporting 2.3 and have us be free to make changes that
> > cannot be compatible with the older version.
> >
> > -Michal
> >
> > On Tue, Jan 13, 2015 at 12:22 PM, Joe Bowser  wrote:
> >
> > > So, where are these numbers coming from?  Can we get a breakdown by
> > region?
> > >
> > > On Tue Jan 13 2015 at 3:30:23 AM Marcel Kinard 
> > wrote:
> > >
> > > > Another stat: Forbes estimates that the existing number of Android
> > phones
> > > > is 1.56 billion. Five percent of that is 78 million.
> > > >
> > > > > On Jan 13, 2015, at 1:14 AM, Ally Ogilvie 
> > wrote:
> > > > >
> > > > > moar stats:
> > > > > https://mixpanel.com/trends/#report/android_os_adoption/
> > > > from_date:-365,to_date:0
> > > >
> > > >
> > > > 
> -
> > > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > > >
> > > >
> > >
> >
>

Re: Deprecation Wars: ICS vs Gingerbread

[Brian LeRoux]

I agree, we're not really supporting these devices, and it is disingenuous
of the project to advertise that we do. Any apps concerning themselves with
privacy/security won't be targeting or testing on those devices either.

I think a clean break w/ the message 4.x === 4.x, coupled with many
webviews and we have a very solid forward looking release.

On Tue, Jan 13, 2015 at 10:10 AM, Michal Mocny  wrote:

> Does it really matter?  I think Joe summarized it best, we can only claim
> to support what is actually being supported (aka actively tested, actively
> maintained).  Market share doesn't impact that.
>
> Not that we should not actively break 2.3 support, but with 3.7 on the
> horizon, and big changes coming in 4.0, it would be nice to signal that as
> the last version supporting 2.3 and have us be free to make changes that
> cannot be compatible with the older version.
>
> -Michal
>
> On Tue, Jan 13, 2015 at 12:22 PM, Joe Bowser  wrote:
>
> > So, where are these numbers coming from?  Can we get a breakdown by
> region?
> >
> > On Tue Jan 13 2015 at 3:30:23 AM Marcel Kinard 
> wrote:
> >
> > > Another stat: Forbes estimates that the existing number of Android
> phones
> > > is 1.56 billion. Five percent of that is 78 million.
> > >
> > > > On Jan 13, 2015, at 1:14 AM, Ally Ogilvie 
> wrote:
> > > >
> > > > moar stats:
> > > > https://mixpanel.com/trends/#report/android_os_adoption/
> > > from_date:-365,to_date:0
> > >
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > >
> > >
> >
>

Re: Deprecation Wars: ICS vs Gingerbread

[Michal Mocny]

Does it really matter?  I think Joe summarized it best, we can only claim
to support what is actually being supported (aka actively tested, actively
maintained).  Market share doesn't impact that.

Not that we should not actively break 2.3 support, but with 3.7 on the
horizon, and big changes coming in 4.0, it would be nice to signal that as
the last version supporting 2.3 and have us be free to make changes that
cannot be compatible with the older version.

-Michal

On Tue, Jan 13, 2015 at 12:22 PM, Joe Bowser  wrote:

> So, where are these numbers coming from?  Can we get a breakdown by region?
>
> On Tue Jan 13 2015 at 3:30:23 AM Marcel Kinard  wrote:
>
> > Another stat: Forbes estimates that the existing number of Android phones
> > is 1.56 billion. Five percent of that is 78 million.
> >
> > > On Jan 13, 2015, at 1:14 AM, Ally Ogilvie  wrote:
> > >
> > > moar stats:
> > > https://mixpanel.com/trends/#report/android_os_adoption/
> > from_date:-365,to_date:0
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>

RE: [DISCUSS] Cordova-Android 3.7.0 Release

[Sergey Grebnov (Akvelon)]

+1 Could someone also take a look on the following pending PR and merge it 
before starting release if possible

CB-8201 Add support for auth dialogs into Cordova Android
https://github.com/apache/cordova-android/pull/143

Thx!
Sergey
-Original Message-
From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve
Sent: Tuesday, January 13, 2015 6:17 PM
To: dev
Subject: Re: [DISCUSS] Cordova-Android 3.7.0 Release

+1

On Mon, Jan 12, 2015 at 6:04 PM, Shazron  wrote:

> +1
>
> On Mon, Jan 12, 2015 at 12:15 PM, Steven Gill 
> wrote:
> > Do it! +1
> >
> > On Mon, Jan 12, 2015 at 10:44 AM, Joe Bowser  wrote:
> >
> >> Hey
> >>
> >> How do people feel about releasing 3.7.0 this week.  I'm trying to give
> as
> >> much notice as possible since that's my style and this is January.
> 3.7.0
> >> will be our very last 3.x release, and we should try to make sure that
> it's
> >> good for the next six months of support.
> >>
> >> Thoughts?
> >>
> >> Joe
> >>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

Re: Deprecation Wars: ICS vs Gingerbread

[Joe Bowser]

So, where are these numbers coming from?  Can we get a breakdown by region?

On Tue Jan 13 2015 at 3:30:23 AM Marcel Kinard  wrote:

> Another stat: Forbes estimates that the existing number of Android phones
> is 1.56 billion. Five percent of that is 78 million.
>
> > On Jan 13, 2015, at 1:14 AM, Ally Ogilvie  wrote:
> >
> > moar stats:
> > https://mixpanel.com/trends/#report/android_os_adoption/
> from_date:-365,to_date:0
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[GitHub] cordova-lib pull request: Generate apk name

[fabiomontefuscolo]

GitHub user fabiomontefuscolo opened a pull request:

https://github.com/apache/cordova-lib/pull/147

Generate apk name

After update the phonegap for my app, the build always generate an APK file 
named CordovaApp.apk. Is this a good way to solve this?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fabiomontefuscolo/cordova-lib patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/147.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #147


commit 8d99d85ac34715522fb94e32267f269c5cb8c413
Author: Fabio Montefuscolo 
Date:   2015-01-13T17:02:37Z

Generate apk name

After update the phonegap for my app, the build always generate an APK file 
named CordovaApp.apk. Is this a good way to solve this?




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: CB-8296 add check at re...

[eymorale]

Github user eymorale commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/57#issuecomment-69776455
  
The crash in spec "filetransfer.spec.25 should handle unknown host" was 
caused in removeTargetFile. For spec25, the path at that point was an empty 
string which was causing an invalid argument exception for removeItemAtPath. I 
added a check to see if the path that is being removed exists.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: CB-8296 add check at re...

[eymorale]

GitHub user eymorale opened a pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/57

CB-8296 add check at removeTargetFile to see if file exists



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/eymorale/cordova-plugin-file-transfer CB-8296

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file-transfer/pull/57.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #57


commit fd03aee8c2d8d072ef14dbfc4bd4481ba6a59f94
Author: Edna Morales 
Date:   2015-01-13T16:43:06Z

CB-8296 add check at removeTargetFile to see if file exists




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-8168 --list support for cordova-lib

[agrieve]

Github user agrieve commented on the pull request:

https://github.com/apache/cordova-lib/pull/145#issuecomment-69772400
  
LGTM save the one comment!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-8168 --list support for cordova-lib

[agrieve]

Github user agrieve commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/145#discussion_r22873213
  
--- Diff: cordova-lib/src/cordova/targets.js ---
@@ -0,0 +1,65 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var cordova_util = require('./util'),
+Q = require('q'),
+superspawn = require('./superspawn'),
+path = require('path');
+
+function handleError(error) {
+if (error.code === 'ENOENT') {
+console.log('Platform not supported');
--- End diff --

You should use the events.emit function rather than console.log'ing things.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: platforms/plugins save and restore from config.xml

[Treggiari, Leo]

I agree with always saving and automatically re-fetching sources and platforms 
when needed.  With regards to the other conversation going on re: automatic add 
of a platform, I think the CLI should automatically do things when it is 
reasonably unambiguous what the user wants - e.g. if they explicitly say build 
for iOS then CLI adds the platform if it is needed.  If you are on Windows and 
you say build for iOS, you get an error, which you would even if CLI had 
allowed you to add the platform - e.g. for a cross platform, multi-developer 
scenario.

If save/restore are 'optional', then as others have pointed out, other problems 
cannot be solved unless the user has used the save and restore command/options. 
 I don't want my IDE to be saying:  "didn't I tell you that you need to use the 
save/restore command options if you want to do any operations outside of the 
IDE!".

Leo

-Original Message-
From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve
Sent: Tuesday, January 13, 2015 6:57 AM
To: Gorkem Ercan
Cc: dev; Andrew Grieve; Michael Brooks
Subject: Re: platforms/plugins save and restore from config.xml

Saving all the time certainly would make this simpler. If we save all of
the time, we can also make uninstall a part of prepare. E.g. If users edits
their config.xml and removes a , then prepare can detect that and
plugman uninstall it before building. If we don't always save, then editing
your config.xml wouldn't be that meaningful unless you delete & recreate
platforms every time.

On Mon, Jan 12, 2015 at 10:29 PM, Gorkem Ercan 
wrote:

>
>
> On 12 Jan 2015, at 22:09, Andrew Grieve wrote:
>
>  Related to this, but maybe can be discussed outside of the doc just fine:
>>
>> https://issues.apache.org/jira/browse/CB-4275
>>
>> Right now when we add a new platform, we do a for-each on directories
>> within plugins/ and add them as well. This causes all plugins to wind up
>> as
>> top-level plugins even when they are dependent plugins on existing
>> platforms.
>>
>> Having plugins listed in config.xml, I think it would make sense to change
>> this logic to plugin add based on plugins within config.xml rather than
>> directories that exist within plugins. We could potentially still add all
>> of them if no plugins are listed in config.xml for backwards compat.
>>
>>
> Related to that, I was looking at CB-8278[1] this bug not only causes the
> variables to be lost also it causes the top-level plugin info to vanish as
> well.
> We could also fix this problem easier too if we are saving plugins to
> config.xml all the time. Which means no save command or --save.
>
> [1] https://issues.apache.org/jira/browse/CB-8278
>
>
>
>>
>> On Mon, Jan 12, 2015 at 9:19 PM, Andrew Grieve 
>> wrote:
>>
>>  Thanks for putting the doc together. Added some comments to it.
>>>
>>> On Mon, Jan 12, 2015 at 5:39 PM, Mefire O. 
>>> wrote:
>>>
>>>  Google docs link :
 https://docs.google.com/document/d/1qKjhzSf48ybGg2GFZPtjXP8dkF4Z5
 Jnc7FU41V3-jFc/edit

 Thanks,
 Mefire

 -Original Message-
 From: Mefire O. [mailto:ommen...@microsoft.com]
 Sent: Monday, January 12, 2015 2:12 PM
 To: dev@cordova.apache.org
 Cc: Michael Brooks
 Subject: RE: platforms/plugins save and restore from config.xml

 Here's what I propose, let me know what you think :

 'cordova platform add'
  * No -save flag, No 'autosave' setting in
 project_dir/.cordova/config.json
  1. 'cordova platform add android' => restores the android
 platform from config.xml. If config.xml doesn't have any android engine,
 falls back to using the pinned CLI version.
  * With -save flag or 'autosave' setting in
 project_dir/.cordova/config.json
  1. 'cordova platform add
 https://github.com/apache/cordova-android.git -save' => clones the git
 repo and adds the android platform to the project, then updates
 config.xml
 and point its version to the specified git-url.
  2. 'cordova platform add android@
 https://github.com/apache/cordova-android.git -save' => clones the git
 repo and adds the android platform to the project, then updates
 config.xml
 and point its version to the specified git-url.
  3. 'cordova platform add C:/path/to/android/platform
 -save' => adds the android platform to the project, then updates
 config.xml
 and point its version to the specified folder location.
  * --Save flag is used in CLI-based workflows, and 'autosave'
 (project_dir/.cordova/config.json) is used in IDE-based workflows.

 'cordova save platforms'
  In its current behavior, 'cordova save platforms' retrieves all
 the platforms currently installed on the project, and saves them to
 config.xml. However, unlike 'cordova save plugins', it does not save the
 source of the platform (i.e: git-url, folder location), it on

Re: [DISCUSS] Cordova-Android 3.7.0 Release

[Andrew Grieve]

+1

On Mon, Jan 12, 2015 at 6:04 PM, Shazron  wrote:

> +1
>
> On Mon, Jan 12, 2015 at 12:15 PM, Steven Gill 
> wrote:
> > Do it! +1
> >
> > On Mon, Jan 12, 2015 at 10:44 AM, Joe Bowser  wrote:
> >
> >> Hey
> >>
> >> How do people feel about releasing 3.7.0 this week.  I'm trying to give
> as
> >> much notice as possible since that's my style and this is January.
> 3.7.0
> >> will be our very last 3.x release, and we should try to make sure that
> it's
> >> good for the next six months of support.
> >>
> >> Thoughts?
> >>
> >> Joe
> >>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[GitHub] cordova-cli pull request: CB-8301 Added CI configuration files

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-cli/pull/206


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-8208 Made CI systems to get cordova-j...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/146


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: platforms/plugins save and restore from config.xml

[Andrew Grieve]

Saving all the time certainly would make this simpler. If we save all of
the time, we can also make uninstall a part of prepare. E.g. If users edits
their config.xml and removes a , then prepare can detect that and
plugman uninstall it before building. If we don't always save, then editing
your config.xml wouldn't be that meaningful unless you delete & recreate
platforms every time.

On Mon, Jan 12, 2015 at 10:29 PM, Gorkem Ercan 
wrote:

>
>
> On 12 Jan 2015, at 22:09, Andrew Grieve wrote:
>
>  Related to this, but maybe can be discussed outside of the doc just fine:
>>
>> https://issues.apache.org/jira/browse/CB-4275
>>
>> Right now when we add a new platform, we do a for-each on directories
>> within plugins/ and add them as well. This causes all plugins to wind up
>> as
>> top-level plugins even when they are dependent plugins on existing
>> platforms.
>>
>> Having plugins listed in config.xml, I think it would make sense to change
>> this logic to plugin add based on plugins within config.xml rather than
>> directories that exist within plugins. We could potentially still add all
>> of them if no plugins are listed in config.xml for backwards compat.
>>
>>
> Related to that, I was looking at CB-8278[1] this bug not only causes the
> variables to be lost also it causes the top-level plugin info to vanish as
> well.
> We could also fix this problem easier too if we are saving plugins to
> config.xml all the time. Which means no save command or --save.
>
> [1] https://issues.apache.org/jira/browse/CB-8278
>
>
>
>>
>> On Mon, Jan 12, 2015 at 9:19 PM, Andrew Grieve 
>> wrote:
>>
>>  Thanks for putting the doc together. Added some comments to it.
>>>
>>> On Mon, Jan 12, 2015 at 5:39 PM, Mefire O. 
>>> wrote:
>>>
>>>  Google docs link :
 https://docs.google.com/document/d/1qKjhzSf48ybGg2GFZPtjXP8dkF4Z5
 Jnc7FU41V3-jFc/edit

 Thanks,
 Mefire

 -Original Message-
 From: Mefire O. [mailto:ommen...@microsoft.com]
 Sent: Monday, January 12, 2015 2:12 PM
 To: dev@cordova.apache.org
 Cc: Michael Brooks
 Subject: RE: platforms/plugins save and restore from config.xml

 Here's what I propose, let me know what you think :

 'cordova platform add'
  * No -save flag, No 'autosave' setting in
 project_dir/.cordova/config.json
  1. 'cordova platform add android' => restores the android
 platform from config.xml. If config.xml doesn't have any android engine,
 falls back to using the pinned CLI version.
  * With -save flag or 'autosave' setting in
 project_dir/.cordova/config.json
  1. 'cordova platform add
 https://github.com/apache/cordova-android.git -save' => clones the git
 repo and adds the android platform to the project, then updates
 config.xml
 and point its version to the specified git-url.
  2. 'cordova platform add android@
 https://github.com/apache/cordova-android.git -save' => clones the git
 repo and adds the android platform to the project, then updates
 config.xml
 and point its version to the specified git-url.
  3. 'cordova platform add C:/path/to/android/platform
 -save' => adds the android platform to the project, then updates
 config.xml
 and point its version to the specified folder location.
  * --Save flag is used in CLI-based workflows, and 'autosave'
 (project_dir/.cordova/config.json) is used in IDE-based workflows.

 'cordova save platforms'
  In its current behavior, 'cordova save platforms' retrieves all
 the platforms currently installed on the project, and saves them to
 config.xml. However, unlike 'cordova save plugins', it does not save the
 source of the platform (i.e: git-url, folder location), it only saves
 the
 version. This behavior is different from the one that 'cordova save
 plugins' implements.
  * 'cordova save platforms'  => it should retrieve the sources of
 all the installed platforms from .fetch.json, and save them in
 config.xml.
 This requires making changes to the way that 'cordova platform add'
 works,
 it should always save the source in .fetch.json.
  * In case of conflict with the config.xml, 'cordova save
 platforms' should error out. The -force option shall be used if we want
 it
 to override config.xml content.

 'cordova restore platforms'
  It reads the config.xml file and install all the platforms
 specified there.

 'cordova save'
  Saves all installed platforms and plugins into config.xml

 'cordova restore'
  Restores all platforms and plugins from config.xml. similar to
 'npm install'.

 Here the link to the google docs :

 Thanks,
 Mefire

 -Original Message-
 From: Parashuram N (MS OPEN TECH) [mailto:panar...@microsoft.com]
 Sent: Friday, January 9,

[GitHub] cordova-plugin-inappbrowser pull request: Added option to disable/...

[andjo]

Github user andjo commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/60#issuecomment-69746517
  
Any particular reason this isn't merged already? Updated documentation 
perhaps?

It was the second thing after removing the location bar that I wanted to 
configure after using this plugin for the first time. The zoom controls just 
looks hideous and like remains of a pre-historic version of Android.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Deprecation Wars: ICS vs Gingerbread

[Marcel Kinard]

Another stat: Forbes estimates that the existing number of Android phones is 
1.56 billion. Five percent of that is 78 million.

> On Jan 13, 2015, at 1:14 AM, Ally Ogilvie  wrote:
> 
> moar stats:
> https://mixpanel.com/trends/#report/android_os_adoption/from_date:-365,to_date:0


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-js pull request: CB-8300 Added CI configuration files

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-js/pull/100


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Plugins Release

[Maxim Ermilov]

Hi,

Could someone review following changes before release?

https://github.com/apache/cordova-plugin-media-capture/pull/30
https://github.com/apache/cordova-plugin-camera/pull/62

-Maxim


On Tue, Jan 13, 2015 at 6:12 AM, Andrew Grieve  wrote:

> Only concern is: https://issues.apache.org/jira/browse/CB-8284 :(
>
> On Sat, Jan 10, 2015 at 6:36 AM, julio cesar sanchez <
> jcesarmob...@gmail.com
> > wrote:
>
> > Well, if somebody can review the pull request I did some months ago for
> the
> > dialogs plugin I'll be grateful
> > https://github.com/apache/cordova-plugin-dialogs/pull/39
> >
> > I tested it on xcode 5 and xcode 6, on iOS 6, iOS 7 and iOS 8, it fixes a
> > repported bug (CB-7734) and changes the UIAlertView to UIAlerController
> > when available (it was necessary to fix the bug and makes the plugin
> future
> > proof)
> >
> > El sábado, 10 de enero de 2015, Steven Gill 
> > escribió:
> >
> > > I noticed Shaz cleaned up the iOS camera plugin. I figure other plugins
> > > might be ready for a release soon too.
> > >
> > > Let me know if you have any thoughts or concerns. I will look at doing
> > this
> > > release next week.
> > >
> >
>

[GitHub] cordova-plugin-media-capture pull request: ubuntu: use content hub...

[Zaspire]

GitHub user Zaspire opened a pull request:

https://github.com/apache/cordova-plugin-media-capture/pull/30

ubuntu: use content hub on device



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Zaspire/cordova-plugin-media-capture master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media-capture/pull/30.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #30


commit b10cce566d6594835e5012b63d0cf5b8fc45c81d
Author: Maxim Ermilov 
Date:   2014-11-10T11:12:02Z

ubuntu: use content hub on device




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: ubuntu: use content hub on dev...

[Zaspire]

GitHub user Zaspire opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/62

ubuntu: use content hub on device



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Zaspire/cordova-plugin-camera master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/62.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #62


commit a7150687386f41c22ae5064c6fcffd0e371526ca
Author: Maxim Ermilov 
Date:   2014-11-06T09:43:15Z

ubuntu: use content hub on device




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-8301 Added CI configuration files

[alsorokin]

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-cli/pull/206

CB-8301 Added CI configuration files

JIRA Issue: https://issues.apache.org/jira/browse/CB-8301

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-cli ci

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/206.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #206


commit 28574c27bce3e8fd2156d218046add34777b09c8
Author: alsorokin 
Date:   2015-01-13T09:48:39Z

CB-8301 Added CI configuration files




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-js pull request: CB-8300 Added CI configuration files

[alsorokin]

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-js/pull/100

CB-8300 Added CI configuration files

Jira issue: https://issues.apache.org/jira/browse/CB-8300

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-js ci

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-js/pull/100.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #100


commit 0e0a697add70bf2a3f4c8a698634bd989bf9166f
Author: alsorokin 
Date:   2015-01-13T09:45:00Z

CB-8300 Added CI configuration files




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-8208 Made CI systems to get cordova-j...

[alsorokin]

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-lib/pull/146

CB-8208 Made CI systems to get cordova-js dependency from gihub

JIRA issue: https://issues.apache.org/jira/browse/CB-8208

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-lib CB-8208

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/146.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #146


commit d263fe9070e69c5aac24095d6a28b2f2be4749e2
Author: alsorokin 
Date:   2015-01-13T09:36:31Z

CB-8208 Made CI systems to get cordova-js dependency from gihub




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org