[GitHub] cordova-plugin-file pull request: Implementation of read only acce...
Github user mlegenhausen commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/84#issuecomment-70627512 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: CB-8131 Rewrote non plugin auto ...
Github user alsorokin commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/113#issuecomment-70627597 I've played with it for some time and found that `pending()` actually throws an exception that must be handled by Jasmine and spec should terminate. In this case it didn't terminate because we threw `pending()` from `describe` and not from `it`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8330 Added new unit tests
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-windows/pull/54 CB-8330 Added new unit tests JIRA item: https://issues.apache.org/jira/browse/CB-8330 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-windows sanity-tests Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/54.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #54 commit a3a60ec617aeb7ef716ec633c75c985a882152e7 Author: alsorokin alexander.soro...@akvelon.com Date: 2015-01-20T12:37:03Z CB-8330 Added new unit tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: cordova-android 4.0 JUnit tests
The tests don't work with Crosswalk because Crosswalk's main class doesn't inherit from a view. This is why we had to change the CordovaWebView from being a class to being an Interface in the first place. I don't think there is a way for these tests to work with Crosswalk because of this incompatibility. I don't think there is a way to re-use these tests because of this fundamental change. On Tue Jan 20 2015 at 5:11:54 AM Fu, Junwei junwei...@intel.com wrote: Hi, I pulled cordova-android 4.0 branch, and running JUnit test in /test directory, but there are compiled error as below, and I want reuse the JUnit tests to test Crosswalk pluggable webView, so I request a PR https://github.com/apache/cordova-android/pull/140, could someone help me to review and merge it. /test/menus.java:37: error: method registerForContextMenu in class Activity cannot be applied to given types; [javac] super.registerForContextMenu(super.appView); reason: actual argument CordovaWebView cannot be converted to View by method invocation conversion test/splashscreen.java:33: error: method loadUrl in class CordovaActivity cannot be applied to given types; [javac] super.loadUrl(file:///android_asset/www/splashscreen/index.html, 2000); reason: actual and formal argument lists differ in length Thanks, Junwei. - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
cordova-android 4.0 JUnit tests
Hi, I pulled cordova-android 4.0 branch, and running JUnit test in /test directory, but there are compiled error as below, and I want reuse the JUnit tests to test Crosswalk pluggable webView, so I request a PR https://github.com/apache/cordova-android/pull/140, could someone help me to review and merge it. /test/menus.java:37: error: method registerForContextMenu in class Activity cannot be applied to given types; [javac] super.registerForContextMenu(super.appView); reason: actual argument CordovaWebView cannot be converted to View by method invocation conversion test/splashscreen.java:33: error: method loadUrl in class CordovaActivity cannot be applied to given types; [javac] super.loadUrl(file:///android_asset/www/splashscreen/index.html, 2000); reason: actual and formal argument lists differ in length Thanks, Junwei. - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-medic pull request: CB-8045 Fixed wrong name of activity t...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-medic/pull/20#issuecomment-70653444 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-5696 find ios project directory using...
Github user ligaz commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/151#discussion_r23237848
--- Diff: cordova-lib/src/plugman/platforms/ios.js ---
@@ -29,8 +29,8 @@ var path = require('path')
, plist = require('plist')
, shell = require('shelljs')
, events = require('../../events')
- , cachedProjectFiles = {}
- ;
+ , _ = require('underscore')
+ , cachedProjectFiles = {};
--- End diff --
You can follow the current coding convention and put the semicolon on a new
line :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-5696 find ios project directory using...
Github user ligaz commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/151#discussion_r23238546
--- Diff: cordova-lib/src/plugman/platforms/ios.js ---
@@ -184,22 +184,16 @@ module.exports = {
var xcodeproj = xcode.project(pbxPath);
xcodeproj.parseSync();
-// grab and parse plist file or config.xml
-var config_files = (glob.sync(path.join(project_dir, '**',
'{PhoneGap,Cordova}.plist')).length === 0 ?
-glob.sync(path.join(project_dir, '**',
'config.xml')) :
-glob.sync(path.join(project_dir, '**',
'{PhoneGap,Cordova}.plist'))
- );
-
-config_files = config_files.filter(function (val) {
-return !(/^build\//.test(val))
!(/\/www\/config.xml$/.test(val));
-});
+var xcBuildConfiguration =
xcodeproj['hash']['project']['objects']['XCBuildConfiguration'];
+var plist_file_entry = _.find(xcBuildConfiguration, function
(entry) { return entry[buildSettings]
entry[buildSettings][INFOPLIST_FILE] });
+var plist_file = path.join(project_dir,
plist_file_entry[buildSettings][INFOPLIST_FILE].replace(/^(.*)$/g, $1));
+var config_file = path.join(path.dirname(plist_file),
'config.xml');
-if (config_files.length === 0) {
-throw new Error('could not find PhoneGap/Cordova plist file,
or config.xml file.');
+if (!fs.existsSync(plist_file) || !fs.existsSync(config_file)) {
+throw new Error(could not find -Info.plist file, or
config.xml file.);
--- End diff --
Should we throw `CordovaError` here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
Re: cordova-android 4.0 JUnit tests
I think Junwei is saying that he has got them to work in his PR. I looked at this a while ago, but couldn't figure out how to get the tests to run in the Android Studio / Gradle world. I'll have another crack at it. On Tue, Jan 20, 2015 at 8:37 AM, Joe Bowser bows...@gmail.com wrote: The tests don't work with Crosswalk because Crosswalk's main class doesn't inherit from a view. This is why we had to change the CordovaWebView from being a class to being an Interface in the first place. I don't think there is a way for these tests to work with Crosswalk because of this incompatibility. I don't think there is a way to re-use these tests because of this fundamental change. On Tue Jan 20 2015 at 5:11:54 AM Fu, Junwei junwei...@intel.com wrote: Hi, I pulled cordova-android 4.0 branch, and running JUnit test in /test directory, but there are compiled error as below, and I want reuse the JUnit tests to test Crosswalk pluggable webView, so I request a PR https://github.com/apache/cordova-android/pull/140, could someone help me to review and merge it. /test/menus.java:37: error: method registerForContextMenu in class Activity cannot be applied to given types; [javac] super.registerForContextMenu(super.appView); reason: actual argument CordovaWebView cannot be converted to View by method invocation conversion test/splashscreen.java:33: error: method loadUrl in class CordovaActivity cannot be applied to given types; [javac] super.loadUrl(file:///android_asset/www/splashscreen/index.html, 2000); reason: actual and formal argument lists differ in length Thanks, Junwei. - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Crowdin and translation process
Andrey~ I'm a little confused by your request. Are you saying that you make changes to the translation outside of the Crowdin tool? If that's the case, yes, all of your changes are going to be lost every time. You'll need to make the changes within Crowdin. When the script is ran to make sure the latest documentation is pushed to the Crowdin tool it doesn't override any translations that have already been done. It just adds updates to the documentation (new sentences, new code, etc) or changes that were made. So unless sections of the english version of the documentation has been changes your Russian updates shouldn't be affected. I see no reason why you couldn't own the Russian part of the translation process. Whenever Victor goes to pull down the translations if the Russian translations aren't at 100% he can talk to you. Does that sound reasonable? Did I understand your concern correctly? Lisa From: Andrey Kurdumov kant2...@googlemail.com To: dev@cordova.apache.org, Victor Adrian Sosa Herrera sosah.vic...@gmail.com Date: 01/20/2015 01:22 AM Subject:Crowdin and translation process Hi, I start working on the improving Cordova documentation for Russian language. Earlier I put fix for the YAML license headers directly to Github for all translations. Right now after I put documentation translation checker tool, I see issues which I would like to improve Russian translation. I download latest translation from Crowdin and compare that field with docs in the source control. What I found is that YAML fixes is not in CrowdIn. 1. This raises question how we could could work on translation with Victor together effectively, not impacting each other? When documentation files is uploaded to the Crowdin? When translation is collected from Crowdin? Are there any rules which could be used, so I could prepare to these cycles? 2. Current script just download everything and commit it in the cordova-docs repository. What I think is that it could be effective is that I take responsibility for maintaining Russian translation and Victor would maintain other translations, like it was before. And downloading script could be modified to include language which should be downloaded, so this allow explicit control which languages is created. I recently cleanup a lot of files from probably Crowdin mistakes, and don't want that this would be introduced again.
Re: platforms/plugins save and restore from config.xml
Indeed! Heres a gdoc for agenda: https://docs.google.com/document/d/1h4KKT0oc70BE57eJ7Bmn4c-at7dH20g0KxTKvlyvIZU/edit?usp=sharing We can plan the time in a separate thread. On Mon, Jan 19, 2015 at 10:10 PM, Andrew Grieve agri...@chromium.org wrote: Hangout sounds great. On Mon, Jan 19, 2015 at 5:21 PM, Jesse purplecabb...@gmail.com wrote: +1 to a hangout! We are overdue. @purplecabbage risingj.com On Mon, Jan 19, 2015 at 1:23 PM, Parashuram N (MS OPEN TECH) panar...@microsoft.com wrote: I also added some comments. I think we have had a lot of good discussion on this, and should we looking at closing the proposal and working on an implementation ? We could resolve the open issues using a hangout - I also realize that we did not have a hangout for January. Would this be a good excuse to set up a hangout ? I could volunteer to start the doodle and set up the date and time if people agree that we should do a hangout. This would be one of the topics we could discuss. On 1/17/15, 6:01 PM, Andrew Grieve agri...@chromium.org wrote: Both proposals are sounding quite good to me at this point! There's merit to both for sure. I left a few more comments, but the only one I actually feel strongly about is about storing .fetch.json for platforms within the existing platform.json files rather than a separate file. On Thu, Jan 15, 2015 at 8:08 PM, Mefire O. ommen...@microsoft.com wrote: True. I'm still diving into the details of plugins and will update the doc accordingly. Sent from my Verizon Wireless 4G LTE smartphone Original message From: Gorkem Ercan Date:01/15/2015 4:56 PM (GMT-08:00) To: dev@cordova.apache.org Subject: Re: platforms/plugins save and restore from config.xml The proposal(s) seems to only cover the platforms. Although the behaviours are very similar there will be details that should be addressed. For instance how to handle the search path for plugins -- Gorkem On 15 Jan 2015, at 19:33, Mefire O. wrote: After some suggestions to instead move to autosaving to config.xml, I've made modifications the document : It now includes two proposals : --save vs autosave Please review and make suggestions : https://docs.google.com/document/d/1qKjhzSf48ybGg2GFZPtjXP8dkF4Z5Jnc7FU41 V3-jFc/edit Thanks, Mefire -Original Message- From: Mefire O. [mailto:ommen...@microsoft.com] Sent: Wednesday, January 14, 2015 4:44 PM To: dev@cordova.apache.org Subject: RE: platforms/plugins save and restore from config.xml All, I have incorporated feedback into the Google docs as suggested by others. Please, cast another look. For reviews/ comments/suggestions, please take a look at : https://docs.google.com/document/d/1qKjhzSf48ybGg2GFZPtjXP8dkF4Z5Jnc7FU41 V3-jFc/edit It seems to me like most people agree with the proposed behavior of --save. So, could anyone please review these pull requests that include that functionality ? : - https://github.com/apache/cordova-lib/pull/144 - https://github.com/apache/cordova-cli/pull/203 Also, we have another related pull request that introduce git urls support to 'cordova platform add' : - https://github.com/apache/cordova-lib/pull/148 Thanks for all the feedback so far ! I'll be creating JIRA issues for all the suggestions (those that have been agreed on). And start working on some of them... Thanks, Mefire -Original Message- From: Chuck Lantz [mailto:cla...@microsoft.com] Sent: Wednesday, January 14, 2015 1:15 PM To: dev@cordova.apache.org Subject: RE: platforms/plugins save and restore from config.xml For those joining the thread late - Here's the Google doc link that's trying to consolidate the conversation: https://docs.google.com/document/d/1qKjhzSf48ybGg2GFZPtjXP8dkF4Z5Jnc7FU41 V3-jFc/edit -Chuck -Original Message- From: Chuck Lantz [mailto:cla...@microsoft.com] Sent: Wednesday, January 14, 2015 1:11 PM To: dev@cordova.apache.org Subject: RE: platforms/plugins save and restore from config.xml You may also want to mention you tried to factor this conversation into the google doc and repoint them to it once you're done editing. Before you do that, I'd also add our proposed plugin syntax in that section before you send it out. Maybe use strikethrough on the XML section with the feature elements and add the plugin id=... syntax below it. -Chuck -Original Message- From: Mefire O. [mailto:ommen...@microsoft.com] Sent: Tuesday, January
Re: Documentation on Android/Cordova Webview
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, I've now gotten from a blank command line to having a working testable project with an embedded Cordova WebView and plugins installing; 1. Use the normal Cordova CLI to create a project 2. Use Android CLI to create a new Android project; set the Cordova CLI generated project as a library to the new Android Project. 3. Copy Cordova CLI generated project www folder to the android project 4. Use plugman to add/remove plugins within the Android project 5. Create an Android testing project using the Android CLI Does this sound like the right way to recommend for people using Cordova embedded for Android? If so I'll put this together as a fork of the documentation project as per the contribution procedures. Regards, - -Mike On 01/12/2015 08:39 PM, Joe Bowser wrote: There is no jar, Cordova is now an Android Library, and it gets included in the generated project like how most Android projects work. Using the CLI is what people recommend, but you should either use that or the create scripts themselves to create your project. On Mon Jan 12 2015 at 11:35:36 AM Mike Dawson m...@ustadmobile.com wrote: Hi, Many thanks for the info here; perhaps someone from cordova-android can specify if using cordova create or download the jar is best practice? I can then fork it to update webview.md; check it all the way through and then contribute it. Thanks! -Mike On 01/12/2015 08:24 PM, Josh Soref wrote: Mike Dawson wrote: I'm looking to build a Hybrid app version and tried following: http://cordova.apache.org/docs/en/4.0.0/guide_platforms_android_webview.md .html#Android%20WebViews I think this might be a bit out of date. Well, it isn't technically wrong, IMO it could definitely use some love. I am running Cordova 4.2 and compiling with API Level 19; all on Ubuntu 14.10 which is all running fine for normal cordova and android development. The documentation says to unzip the download (whereas the main site recommends the normal installation using npm). 1. To follow these instructions, make sure you have the latest Cordova distribution. Download it from cordova.apache.org and unzip its Android package. Technically this isn't wrong, if you manage to figure out how to follow it, you would end up w/ cordova-android as opposed to cordova-cli. Personally, I'd favor changing the instructions to use the normal `cordova create` and `cordova platform add android`... That said, I don't work on cordova-android. Is there any more up to date documentation on this? Probably not I did a quick google but couldn't find anything. If not once I get through this I'd be happy to contribute a revised version of the documentation. In general, patches are welcome. https://github.com/apache/cordova-docs/blob/master/docs/ en/edge/guide/platf orms/android/webview.md Is the file, fork the repository, write replacement content, Follow the instructions starting from: http://wiki.apache.org/cordova/ContributorWorkflow - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - -- Mike Dawson CEO Ustad Mobile Email: m...@ustadmobile.com Phone: +971 555 99 7043 Web: www.ustadmobile.com Twitter: @ustadmobile Facebook: www.facebook.com/Ustad.Mobile -BEGIN PGP SIGNATURE- Version: GnuPG v1 iQIcBAEBAgAGBQJUvoB/AAoJEMDbIyechsEfiioP/2J47B8lf/boEqmCW0cotId3 kd6wAs9ov9Kaji3M5wTcOmA5ik/cr99wpuXOg/Xnz8LjwTg+egHPVIKtebW76qv7 e9inC7+52g5nk8Rvctybw+8YT2FmRPQhCaJtXlXGy8ti+6e1Xjld8kiaMLIEHpuB RreCGY52EneppQbv65V1wttrEr+Z7slDF76wIJIoEqHlqPq71hvdj2LF+yBP8UuN P4b5EwordPysu4KpjR1fiikGI+w1IQADREcHoZL0c7YwTbrLqtPaq9m/7Ti5As3R gLuAFr6my2wfJM5yPt/wapk0754lygC2obJ9FLpw1w2HwgIE90KI85dBWUxnzLRj CciOoJ1CFNXMD5MkFlL81LOmlWEZnIlmbeXLhuYlPGU6NiMVqDGRzYA6g6UPHj1W zDdN+pnSx6PtGRCsuwL7ajDi6L5c8QU4Pv4eVcJ+9UtqsihAW+bUihhqGXCWhJVW f/qRNHp2ooykui91kcBJ9OXpRPuUe8W4mJZXzAtVacM4Sf6ESJd20/wj320T3XkP dj37x3sT9ipRv+/8WFmKdverkM7PEkTtw3FjBhOYpMNsl/GAdvDdIbH2KexkYYuJ s4yrkDcmxjz0vA5mm2ZH9ZUbkZPrwYzybpow72O1xeKBHWXw8xdss28S0WSg2toG Y9mZSeVQaadRQhFZn3ou =6p1B -END PGP SIGNATURE-
[GitHub] cordova-lib pull request: CB-5696 find ios project directory using...
GitHub user Mitko-Kerezov opened a pull request: https://github.com/apache/cordova-lib/pull/151 CB-5696 find ios project directory using the xcode project file Add unit tests for future reassurance Fix incorrect name ChildApp in .pbxproj files to SampleApp Related to https://issues.apache.org/jira/browse/CB-5696 You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-lib CB-5696 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/151.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #151 commit dab19300fc2a07c92a2d10373bc9290e15637e5d Author: Dimitar Kerezov dimitar.kere...@telerik.com Date: 2015-01-20T14:44:52Z CB-5696 find ios project directory using the xcode project file Add unit tests for future reassurance Fix incorrect name ChildApp in .pbxproj files to SampleApp Related to https://issues.apache.org/jira/browse/CB-5696 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Cordova-Android 3.7.0 Release
I think the docs plan is to do an update of them along with the CLI release that sets the new platform version as pinned (sound right?) On Tue, Jan 20, 2015 at 12:59 AM, Andrey Kurdumov kant2...@googlemail.com wrote: I want ask a question. Does something related to docs would be published with this release? If so, then I want to make sure I could put more translation together with this release. For example could translate and proofread Android section. 2015-01-20 9:31 GMT+06:00 Andrew Grieve agri...@chromium.org: It hadn't been pulled in, but now has! One more we might want to merge in: https://github.com/apache/cordova-android/pull/149 (probably fine without it as well though) There's nothing else left that I know of that is outstanding. On Mon, Jan 19, 2015 at 7:23 PM, Joe Bowser bows...@gmail.com wrote: I think we could probably start the vote thread based on the last few commits. On Mon Jan 19 2015 at 3:24:52 PM Joe Bowser bows...@gmail.com wrote: So, has this been pulled in? Can I tag the release so that we can start the vote thread? On Thu Jan 15 2015 at 5:48:33 PM Andrew Grieve agri...@chromium.org wrote: all looks to me! We've only just cut the release branch, so I don't see any harm in cherry-picking it in once you submit it. On Thu, Jan 15, 2015 at 1:26 PM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: Thank you, Andrew. Addressed all CR notes (including webview abstraction), pls let me know if it looks good now and could be included to release. https://github.com/apache/cordova-android/pull/143 Thx! Sergey -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Tuesday, January 13, 2015 10:31 PM To: dev Subject: Re: [DISCUSS] Cordova-Android 3.7.0 Release Left some comments On Tue, Jan 13, 2015 at 12:49 PM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: +1 Could someone also take a look on the following pending PR and +merge it before starting release if possible CB-8201 Add support for auth dialogs into Cordova Android https://github.com/apache/cordova-android/pull/143 Thx! Sergey -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Tuesday, January 13, 2015 6:17 PM To: dev Subject: Re: [DISCUSS] Cordova-Android 3.7.0 Release +1 On Mon, Jan 12, 2015 at 6:04 PM, Shazron shaz...@gmail.com wrote: +1 On Mon, Jan 12, 2015 at 12:15 PM, Steven Gill stevengil...@gmail.com wrote: Do it! +1 On Mon, Jan 12, 2015 at 10:44 AM, Joe Bowser bows...@gmail.com wrote: Hey How do people feel about releasing 3.7.0 this week. I'm trying to give as much notice as possible since that's my style and this is January. 3.7.0 will be our very last 3.x release, and we should try to make sure that it's good for the next six months of support. Thoughts? Joe - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-8317: Make it work to load about:...
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/149#discussion_r23228419
--- Diff: framework/src/org/apache/cordova/CordovaWebViewClient.java ---
@@ -171,8 +171,13 @@ public void onPageStarted(WebView view, String url,
Bitmap favicon) {
public void onPageFinished(WebView view, String url) {
super.onPageFinished(view, url);
// Ignore excessive calls.
-if (!isCurrentlyLoading) {
-return;
+// On KitKat, loading about:blank does not invoke
WebViewClient#onPageStarted
+// So do not check isCurrentLoading if app is running on KitKat
+// https://code.google.com/p/android/issues/detail?id=65701
+if (android.os.Build.VERSION.SDK_INT !=
android.os.Build.VERSION_CODES.KITKAT){
--- End diff --
You don't need to re-request a PR, but you do need to make the change an
upload it to github (either as a separate commit, or by force-pushing an
ammended commit). Then, add a comment to let me know you've done so and I'll
pull it in (once you do it, it should show up on this interface).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Cordova-Android 3.7.0 Release
Yup! We will do a docs update with the next tools release that will follow after the android and ios releases. On Jan 20, 2015 9:47 AM, Andrey Kurdumov kant2...@googlemail.com wrote: Thanks. 20 Янв 2015 г. 21:27 пользователь Andrew Grieve agri...@chromium.org написал: I think the docs plan is to do an update of them along with the CLI release that sets the new platform version as pinned (sound right?) On Tue, Jan 20, 2015 at 12:59 AM, Andrey Kurdumov kant2...@googlemail.com wrote: I want ask a question. Does something related to docs would be published with this release? If so, then I want to make sure I could put more translation together with this release. For example could translate and proofread Android section. 2015-01-20 9:31 GMT+06:00 Andrew Grieve agri...@chromium.org: It hadn't been pulled in, but now has! One more we might want to merge in: https://github.com/apache/cordova-android/pull/149 (probably fine without it as well though) There's nothing else left that I know of that is outstanding. On Mon, Jan 19, 2015 at 7:23 PM, Joe Bowser bows...@gmail.com wrote: I think we could probably start the vote thread based on the last few commits. On Mon Jan 19 2015 at 3:24:52 PM Joe Bowser bows...@gmail.com wrote: So, has this been pulled in? Can I tag the release so that we can start the vote thread? On Thu Jan 15 2015 at 5:48:33 PM Andrew Grieve agri...@chromium.org wrote: all looks to me! We've only just cut the release branch, so I don't see any harm in cherry-picking it in once you submit it. On Thu, Jan 15, 2015 at 1:26 PM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: Thank you, Andrew. Addressed all CR notes (including webview abstraction), pls let me know if it looks good now and could be included to release. https://github.com/apache/cordova-android/pull/143 Thx! Sergey -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Tuesday, January 13, 2015 10:31 PM To: dev Subject: Re: [DISCUSS] Cordova-Android 3.7.0 Release Left some comments On Tue, Jan 13, 2015 at 12:49 PM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: +1 Could someone also take a look on the following pending PR and +merge it before starting release if possible CB-8201 Add support for auth dialogs into Cordova Android https://github.com/apache/cordova-android/pull/143 Thx! Sergey -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Tuesday, January 13, 2015 6:17 PM To: dev Subject: Re: [DISCUSS] Cordova-Android 3.7.0 Release +1 On Mon, Jan 12, 2015 at 6:04 PM, Shazron shaz...@gmail.com wrote: +1 On Mon, Jan 12, 2015 at 12:15 PM, Steven Gill stevengil...@gmail.com wrote: Do it! +1 On Mon, Jan 12, 2015 at 10:44 AM, Joe Bowser bows...@gmail.com wrote: Hey How do people feel about releasing 3.7.0 this week. I'm trying to give as much notice as possible since that's my style and this is January. 3.7.0 will be our very last 3.x release, and we should try to make sure that it's good for the next six months of support. Thoughts? Joe - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: File Transfer plugin and Crosswalk engine cookies
I think we should make the File Transfer plugin not need a CookieManager. It sounds like that's the bigger problem than it having to be tied to a particular implementation of Cookies. On Tue Jan 20 2015 at 10:32:25 AM Darryl Pogue dvpdin...@gmail.com wrote: With the idea of preparing Cordova Android 4.0.x for release starting to come up in discussions, I thought it was worth raising this as a potential blocker. The file transfer plugin uses the Android webview cookie manager. When you're using a Crosswalk webview (or GeckoView presumably), in the best case there are no cookies with file transfer requests and in the worst case it will cause the app to crash on Android 4.2.x. There are a few existing bug reports and PRs related to this, but none of them propose a general solution for different webviews. [1] [2] [3] [4] I was looking at this problem last week and the only general solution I could think of would involve adding a CordovaCookieManager interface and implementing it for each webview engine, which didn't seem to be the most idea situation. I can write that interface and make a PR for it, but I'd rather hear if anyone has better ideas before starting to make changes across multiple repos. [1]: https://github.com/crosswalk-project/crosswalk-cordova- android/pull/38 [2]: https://github.com/apache/cordova-plugin-file-transfer/pull/8 [3]: https://github.com/MobileChromeApps/mobile-chrome-apps/issues/464 [4]: https://github.com/gaochun/cordova-plugin-file-transfer/commit/ 0063249e279b99a0feb4601650fc3a4c9e8a8ed2 - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
File Transfer plugin and Crosswalk engine cookies
With the idea of preparing Cordova Android 4.0.x for release starting to come up in discussions, I thought it was worth raising this as a potential blocker. The file transfer plugin uses the Android webview cookie manager. When you're using a Crosswalk webview (or GeckoView presumably), in the best case there are no cookies with file transfer requests and in the worst case it will cause the app to crash on Android 4.2.x. There are a few existing bug reports and PRs related to this, but none of them propose a general solution for different webviews. [1] [2] [3] [4] I was looking at this problem last week and the only general solution I could think of would involve adding a CordovaCookieManager interface and implementing it for each webview engine, which didn't seem to be the most idea situation. I can write that interface and make a PR for it, but I'd rather hear if anyone has better ideas before starting to make changes across multiple repos. [1]: https://github.com/crosswalk-project/crosswalk-cordova-android/pull/38 [2]: https://github.com/apache/cordova-plugin-file-transfer/pull/8 [3]: https://github.com/MobileChromeApps/mobile-chrome-apps/issues/464 [4]: https://github.com/gaochun/cordova-plugin-file-transfer/commit/0063249e279b99a0feb4601650fc3a4c9e8a8ed2 - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: Adding ability to add any platform on any OS
I'll rebase it and send PR tomorrow. I'll need to ensure that `--list` option integrated and working. --- Best regards, Vladimir -Original Message- From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com] Sent: Monday, 19 January, 2015 23:13 To: dev@cordova.apache.org Subject: RE: Adding ability to add any platform on any OS I believe this is the JIRA that tracks the work: https://issues.apache.org/jira/browse/CB-8197 It looks like Vladimir has done most of the work: https://github.com/MSOpenTech/cordova-ios/compare/CB-8197 - it probably needs to be re-sync'd and sent out as a PR. Thanks, Nikhil -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Monday, January 19, 2015 8:59 AM To: dev Subject: Re: Adding ability to add any platform on any OS Wondering if there's been progress for rewriting ios scripts in node? Is there a JIRA for it? On Fri, Nov 7, 2014 at 9:42 AM, Marcel Kinard cmarc...@gmail.com wrote: Exactly. On Nov 5, 2014, at 6:44 PM, Andrew Grieve agri...@chromium.org wrote: That's my understanding. Don't do check_reqs until the start of an operation that depends on the reqs (e.g. a build) - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: cordova-android 4.0 JUnit tests
It was easier to get the tests to run in Android Studio than it was to get Cordova itself to run. You just import them in as an Eclipse project and it just works. I was surprised when I did this a few days ago. I don't like this pull request because it removes all tests of the AndroidWebView component itself, and instead makes the tests conform to the way that XWalk is designed. I think that we need a full re-write of the JUnit tests, but that can wait until after 4.0.x is released. On Tue Jan 20 2015 at 9:30:14 AM Andrew Grieve agri...@chromium.org wrote: I think Junwei is saying that he has got them to work in his PR. I looked at this a while ago, but couldn't figure out how to get the tests to run in the Android Studio / Gradle world. I'll have another crack at it. On Tue, Jan 20, 2015 at 8:37 AM, Joe Bowser bows...@gmail.com wrote: The tests don't work with Crosswalk because Crosswalk's main class doesn't inherit from a view. This is why we had to change the CordovaWebView from being a class to being an Interface in the first place. I don't think there is a way for these tests to work with Crosswalk because of this incompatibility. I don't think there is a way to re-use these tests because of this fundamental change. On Tue Jan 20 2015 at 5:11:54 AM Fu, Junwei junwei...@intel.com wrote: Hi, I pulled cordova-android 4.0 branch, and running JUnit test in /test directory, but there are compiled error as below, and I want reuse the JUnit tests to test Crosswalk pluggable webView, so I request a PR https://github.com/apache/cordova-android/pull/140, could someone help me to review and merge it. /test/menus.java:37: error: method registerForContextMenu in class Activity cannot be applied to given types; [javac] super.registerForContextMenu(super.appView); reason: actual argument CordovaWebView cannot be converted to View by method invocation conversion test/splashscreen.java:33: error: method loadUrl in class CordovaActivity cannot be applied to given types; [javac] super.loadUrl(file:///android_asset/www/splashscreen/index.html, 2000); reason: actual and formal argument lists differ in length Thanks, Junwei. - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: cordova-android 4.0 JUnit tests
Nice. I've got a gradle file that now at least builds the application, so not far off of having it run the tests. Totally on board with re-writing the unit tests (they have an unfortunate number of Thread.sleep() in them). But this PR at least makes them compile on 4.0.x. Maybe add some comments to the PR where you think it's not testing AndroidWebView? Just had another look and the only thing that I think changes is that it's creating the webview in code rather than by inflating. CordovaInterface hides the fact that AndroidWebView is a View anyways, so I don't think Crosswalk not being a view should make a difference (you just call .getView() in both cases). On Tue, Jan 20, 2015 at 12:40 PM, Joe Bowser bows...@gmail.com wrote: It was easier to get the tests to run in Android Studio than it was to get Cordova itself to run. You just import them in as an Eclipse project and it just works. I was surprised when I did this a few days ago. I don't like this pull request because it removes all tests of the AndroidWebView component itself, and instead makes the tests conform to the way that XWalk is designed. I think that we need a full re-write of the JUnit tests, but that can wait until after 4.0.x is released. On Tue Jan 20 2015 at 9:30:14 AM Andrew Grieve agri...@chromium.org wrote: I think Junwei is saying that he has got them to work in his PR. I looked at this a while ago, but couldn't figure out how to get the tests to run in the Android Studio / Gradle world. I'll have another crack at it. On Tue, Jan 20, 2015 at 8:37 AM, Joe Bowser bows...@gmail.com wrote: The tests don't work with Crosswalk because Crosswalk's main class doesn't inherit from a view. This is why we had to change the CordovaWebView from being a class to being an Interface in the first place. I don't think there is a way for these tests to work with Crosswalk because of this incompatibility. I don't think there is a way to re-use these tests because of this fundamental change. On Tue Jan 20 2015 at 5:11:54 AM Fu, Junwei junwei...@intel.com wrote: Hi, I pulled cordova-android 4.0 branch, and running JUnit test in /test directory, but there are compiled error as below, and I want reuse the JUnit tests to test Crosswalk pluggable webView, so I request a PR https://github.com/apache/cordova-android/pull/140, could someone help me to review and merge it. /test/menus.java:37: error: method registerForContextMenu in class Activity cannot be applied to given types; [javac] super.registerForContextMenu(super.appView); reason: actual argument CordovaWebView cannot be converted to View by method invocation conversion test/splashscreen.java:33: error: method loadUrl in class CordovaActivity cannot be applied to given types; [javac] super.loadUrl(file:///android_asset/www/splashscreen/index.html, 2000); reason: actual and formal argument lists differ in length Thanks, Junwei. - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Cordova-Android 3.7.0 Release
Thanks. 20 Янв 2015 г. 21:27 пользователь Andrew Grieve agri...@chromium.org написал: I think the docs plan is to do an update of them along with the CLI release that sets the new platform version as pinned (sound right?) On Tue, Jan 20, 2015 at 12:59 AM, Andrey Kurdumov kant2...@googlemail.com wrote: I want ask a question. Does something related to docs would be published with this release? If so, then I want to make sure I could put more translation together with this release. For example could translate and proofread Android section. 2015-01-20 9:31 GMT+06:00 Andrew Grieve agri...@chromium.org: It hadn't been pulled in, but now has! One more we might want to merge in: https://github.com/apache/cordova-android/pull/149 (probably fine without it as well though) There's nothing else left that I know of that is outstanding. On Mon, Jan 19, 2015 at 7:23 PM, Joe Bowser bows...@gmail.com wrote: I think we could probably start the vote thread based on the last few commits. On Mon Jan 19 2015 at 3:24:52 PM Joe Bowser bows...@gmail.com wrote: So, has this been pulled in? Can I tag the release so that we can start the vote thread? On Thu Jan 15 2015 at 5:48:33 PM Andrew Grieve agri...@chromium.org wrote: all looks to me! We've only just cut the release branch, so I don't see any harm in cherry-picking it in once you submit it. On Thu, Jan 15, 2015 at 1:26 PM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: Thank you, Andrew. Addressed all CR notes (including webview abstraction), pls let me know if it looks good now and could be included to release. https://github.com/apache/cordova-android/pull/143 Thx! Sergey -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Tuesday, January 13, 2015 10:31 PM To: dev Subject: Re: [DISCUSS] Cordova-Android 3.7.0 Release Left some comments On Tue, Jan 13, 2015 at 12:49 PM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: +1 Could someone also take a look on the following pending PR and +merge it before starting release if possible CB-8201 Add support for auth dialogs into Cordova Android https://github.com/apache/cordova-android/pull/143 Thx! Sergey -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Tuesday, January 13, 2015 6:17 PM To: dev Subject: Re: [DISCUSS] Cordova-Android 3.7.0 Release +1 On Mon, Jan 12, 2015 at 6:04 PM, Shazron shaz...@gmail.com wrote: +1 On Mon, Jan 12, 2015 at 12:15 PM, Steven Gill stevengil...@gmail.com wrote: Do it! +1 On Mon, Jan 12, 2015 at 10:44 AM, Joe Bowser bows...@gmail.com wrote: Hey How do people feel about releasing 3.7.0 this week. I'm trying to give as much notice as possible since that's my style and this is January. 3.7.0 will be our very last 3.x release, and we should try to make sure that it's good for the next six months of support. Thoughts? Joe - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: cordova-android 4.0 JUnit tests
It's an issue because this test was supposed to be testing the embedding of a WebView via layout. That's why the inflate exists in the code. By creating the webview directly, it's not actually testing anything of value. We actually lose test coverage with this change. On Tue Jan 20 2015 at 9:58:19 AM Andrew Grieve agri...@chromium.org wrote: Nice. I've got a gradle file that now at least builds the application, so not far off of having it run the tests. Totally on board with re-writing the unit tests (they have an unfortunate number of Thread.sleep() in them). But this PR at least makes them compile on 4.0.x. Maybe add some comments to the PR where you think it's not testing AndroidWebView? Just had another look and the only thing that I think changes is that it's creating the webview in code rather than by inflating. CordovaInterface hides the fact that AndroidWebView is a View anyways, so I don't think Crosswalk not being a view should make a difference (you just call .getView() in both cases). On Tue, Jan 20, 2015 at 12:40 PM, Joe Bowser bows...@gmail.com wrote: It was easier to get the tests to run in Android Studio than it was to get Cordova itself to run. You just import them in as an Eclipse project and it just works. I was surprised when I did this a few days ago. I don't like this pull request because it removes all tests of the AndroidWebView component itself, and instead makes the tests conform to the way that XWalk is designed. I think that we need a full re-write of the JUnit tests, but that can wait until after 4.0.x is released. On Tue Jan 20 2015 at 9:30:14 AM Andrew Grieve agri...@chromium.org wrote: I think Junwei is saying that he has got them to work in his PR. I looked at this a while ago, but couldn't figure out how to get the tests to run in the Android Studio / Gradle world. I'll have another crack at it. On Tue, Jan 20, 2015 at 8:37 AM, Joe Bowser bows...@gmail.com wrote: The tests don't work with Crosswalk because Crosswalk's main class doesn't inherit from a view. This is why we had to change the CordovaWebView from being a class to being an Interface in the first place. I don't think there is a way for these tests to work with Crosswalk because of this incompatibility. I don't think there is a way to re-use these tests because of this fundamental change. On Tue Jan 20 2015 at 5:11:54 AM Fu, Junwei junwei...@intel.com wrote: Hi, I pulled cordova-android 4.0 branch, and running JUnit test in /test directory, but there are compiled error as below, and I want reuse the JUnit tests to test Crosswalk pluggable webView, so I request a PR https://github.com/apache/cordova-android/pull/140, could someone help me to review and merge it. /test/menus.java:37: error: method registerForContextMenu in class Activity cannot be applied to given types; [javac] super.registerForContextMenu(super.appView); reason: actual argument CordovaWebView cannot be converted to View by method invocation conversion test/splashscreen.java:33: error: method loadUrl in class CordovaActivity cannot be applied to given types; [javac] super.loadUrl(file:///android_asset/www/splashscreen/index.html, 2000); reason: actual and formal argument lists differ in length Thanks, Junwei. - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: cordova-android 4.0 JUnit tests
Also - maybe leave the inflate test using AndroidWebView, and make the other ones create dynamically? On Tue, Jan 20, 2015 at 2:59 PM, Andrew Grieve agri...@chromium.org wrote: gotcha. I've now got tests building running with gradle (painful learning curve...). I'm going to pull in the changes from this PR that fix the compile, but will leave the rest. Junwei - do the tests pass for you? I certainly can't get most of them to (running on KitKat) :( On Tue, Jan 20, 2015 at 1:00 PM, Joe Bowser bows...@gmail.com wrote: It's an issue because this test was supposed to be testing the embedding of a WebView via layout. That's why the inflate exists in the code. By creating the webview directly, it's not actually testing anything of value. We actually lose test coverage with this change. On Tue Jan 20 2015 at 9:58:19 AM Andrew Grieve agri...@chromium.org wrote: Nice. I've got a gradle file that now at least builds the application, so not far off of having it run the tests. Totally on board with re-writing the unit tests (they have an unfortunate number of Thread.sleep() in them). But this PR at least makes them compile on 4.0.x. Maybe add some comments to the PR where you think it's not testing AndroidWebView? Just had another look and the only thing that I think changes is that it's creating the webview in code rather than by inflating. CordovaInterface hides the fact that AndroidWebView is a View anyways, so I don't think Crosswalk not being a view should make a difference (you just call .getView() in both cases). On Tue, Jan 20, 2015 at 12:40 PM, Joe Bowser bows...@gmail.com wrote: It was easier to get the tests to run in Android Studio than it was to get Cordova itself to run. You just import them in as an Eclipse project and it just works. I was surprised when I did this a few days ago. I don't like this pull request because it removes all tests of the AndroidWebView component itself, and instead makes the tests conform to the way that XWalk is designed. I think that we need a full re-write of the JUnit tests, but that can wait until after 4.0.x is released. On Tue Jan 20 2015 at 9:30:14 AM Andrew Grieve agri...@chromium.org wrote: I think Junwei is saying that he has got them to work in his PR. I looked at this a while ago, but couldn't figure out how to get the tests to run in the Android Studio / Gradle world. I'll have another crack at it. On Tue, Jan 20, 2015 at 8:37 AM, Joe Bowser bows...@gmail.com wrote: The tests don't work with Crosswalk because Crosswalk's main class doesn't inherit from a view. This is why we had to change the CordovaWebView from being a class to being an Interface in the first place. I don't think there is a way for these tests to work with Crosswalk because of this incompatibility. I don't think there is a way to re-use these tests because of this fundamental change. On Tue Jan 20 2015 at 5:11:54 AM Fu, Junwei junwei...@intel.com wrote: Hi, I pulled cordova-android 4.0 branch, and running JUnit test in /test directory, but there are compiled error as below, and I want reuse the JUnit tests to test Crosswalk pluggable webView, so I request a PR https://github.com/apache/cordova-android/pull/140, could someone help me to review and merge it. /test/menus.java:37: error: method registerForContextMenu in class Activity cannot be applied to given types; [javac] super.registerForContextMenu(super.appView); reason: actual argument CordovaWebView cannot be converted to View by method invocation conversion test/splashscreen.java:33: error: method loadUrl in class CordovaActivity cannot be applied to given types; [javac] super.loadUrl(file:///android_asset/www/splashscreen/index.html, 2000); reason: actual and formal argument lists differ in length Thanks, Junwei. - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: File Transfer plugin and Crosswalk engine cookies
I was planning on doing exactly what Darryl described. Would love such a PR! Note that we've just used this approach for the new WebView security hooks: https://github.com/apache/cordova-android/commit/623b394c830b8a83b5c2f16624d8013b6f851cd9 https://github.com/apache/cordova-android/commit/11002d4a56a4901087f514e2d01f8db392d0abe1 CookieManager has been exposed to plugins for a long time, and it would be crippling if FileTransfer could not set cookies. On Tue, Jan 20, 2015 at 1:48 PM, Joe Bowser bows...@gmail.com wrote: I think we should make the File Transfer plugin not need a CookieManager. It sounds like that's the bigger problem than it having to be tied to a particular implementation of Cookies. On Tue Jan 20 2015 at 10:32:25 AM Darryl Pogue dvpdin...@gmail.com wrote: With the idea of preparing Cordova Android 4.0.x for release starting to come up in discussions, I thought it was worth raising this as a potential blocker. The file transfer plugin uses the Android webview cookie manager. When you're using a Crosswalk webview (or GeckoView presumably), in the best case there are no cookies with file transfer requests and in the worst case it will cause the app to crash on Android 4.2.x. There are a few existing bug reports and PRs related to this, but none of them propose a general solution for different webviews. [1] [2] [3] [4] I was looking at this problem last week and the only general solution I could think of would involve adding a CordovaCookieManager interface and implementing it for each webview engine, which didn't seem to be the most idea situation. I can write that interface and make a PR for it, but I'd rather hear if anyone has better ideas before starting to make changes across multiple repos. [1]: https://github.com/crosswalk-project/crosswalk-cordova- android/pull/38 [2]: https://github.com/apache/cordova-plugin-file-transfer/pull/8 [3]: https://github.com/MobileChromeApps/mobile-chrome-apps/issues/464 [4]: https://github.com/gaochun/cordova-plugin-file-transfer/commit/ 0063249e279b99a0feb4601650fc3a4c9e8a8ed2 - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8223 Expose config.xml in the Browser...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/149 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Generate apk name
Github user agrieve commented on the pull request: https://github.com/apache/cordova-lib/pull/147#issuecomment-70736038 Certainly is annoying, but I think changing the name of the activity will cause it to not find the associated `.java` file. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-8317: Make it work to load about:...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/149 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-wp8 pull request: CB-8325 Implemented end-to-end and unit ...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-wp8/pull/71 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-browser pull request: CB-8182 - port 'cordova serve' to 'c...
GitHub user kirkshoop opened a pull request: https://github.com/apache/cordova-browser/pull/9 CB-8182 - port 'cordova serve' to 'cordova run browser' This ports the code to serve a project from ```cordova serve``` The result is that ```--disable-web-security``` is no longer required and all other side-effects of using a real http url instead of a file url can be observed when testing a project. This and #8 will conflict. Nikhil or I will rebase the second PR onto whichever is first to be accepted. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-browser CB-8182 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-browser/pull/9.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #9 commit 724587ae0779cd3e2abf4c7a8124c7ae3d2448d5 Author: Kirk Shoop (MS OPEN TECH) kirk.sh...@microsoft.com Date: 2015-01-14T16:12:28Z CB-8182 - add dependencies on d8 and mime libraries commit 9c755d59a52246cc6f9ef1136508002aadd7cf7d Author: Kirk Shoop (MS OPEN TECH) kirk.sh...@microsoft.com Date: 2015-01-14T16:22:44Z CB-8182 - port 'cordova serve' to 'cordova run browser' --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-wp8 pull request: CB-8310: Fix to cordova run wp8 to attem...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-wp8/pull/70 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: Monthly Hangouts - Jan 2015 Edition
Here is the Doodle - http://doodle.com/a3kr2kek4a5spxpr. Please mark your availability. I added this for the next week, guessing that it would be super hard to finalize this week. If next week does not work, we could make do this in Feb. - ADMIN STUFF P.S: If anyone wants to administer the poll to change the time, or add additional days, here is the admin link. http://doodle.com/a3kr2kek4a5spxpr6c9pf857/admin#admin. DO NOT use this link for scheduling, only use it to make changes or administer the doodle. -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Tuesday, January 20, 2015 1:07 PM To: dev Subject: Re: Monthly Hangouts - Jan 2015 Edition There's no account. (don't think doodle requires sign-up) On Tue, Jan 20, 2015 at 3:33 PM, Parashuram N (MS OPEN TECH) panar...@microsoft.com wrote: Hi, It has been a while since we had a hangouts, and a lot of folks have suggested that there are topics that could use a hangout. Thanks Michael for creating the agenda doc. https://docs.google.com/document/d/1h4KKT0oc70BE57eJ7Bmn4c-at7dH20g0KxTKvlyvIZU/edit?usp=sharing Do we have an official account where we set up the doodle? If not, I could set up a doodle for this. - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-8317: Make it work to load about:...
Github user shingotoda commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/149#discussion_r23269220
--- Diff: framework/src/org/apache/cordova/CordovaWebViewClient.java ---
@@ -171,8 +171,13 @@ public void onPageStarted(WebView view, String url,
Bitmap favicon) {
public void onPageFinished(WebView view, String url) {
super.onPageFinished(view, url);
// Ignore excessive calls.
-if (!isCurrentlyLoading) {
-return;
+// On KitKat, loading about:blank does not invoke
WebViewClient#onPageStarted
+// So do not check isCurrentLoading if app is running on KitKat
+// https://code.google.com/p/android/issues/detail?id=65701
+if (android.os.Build.VERSION.SDK_INT !=
android.os.Build.VERSION_CODES.KITKAT){
--- End diff --
Thank you. I've uploaded it. Is it OK?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: indented scriptContent.
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/127 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Monthly Hangouts - Jan 2015 Edition
There's no account. (don't think doodle requires sign-up) On Tue, Jan 20, 2015 at 3:33 PM, Parashuram N (MS OPEN TECH) panar...@microsoft.com wrote: Hi, It has been a while since we had a hangouts, and a lot of folks have suggested that there are topics that could use a hangout. Thanks Michael for creating the agenda doc. https://docs.google.com/document/d/1h4KKT0oc70BE57eJ7Bmn4c-at7dH20g0KxTKvlyvIZU/edit?usp=sharing Do we have an official account where we set up the doodle? If not, I could set up a doodle for this.
[GitHub] cordova-cli pull request: CB-8168 --list support for CLI
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/205 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8168 --list support for cordova-lib
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/145 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Medic Improvements Coming
Hi list, I'm writing here to let you know that improvements to Cordova CI and testing are coming soon (within the timeframe of two weeks). We've been working with Apache Infra to get nightly runs of mobile-spec happening, and we're currently just ironing out some bugs. This will give us similar coverage to what we have running on Travis and AppVeyor for Cordova tools, but for plugins, and will give a better sense of code health when PRs are made. On a related note, there is a parallel effort at Adobe (Steven Gill, CC'd) to get nightly builds of certain Cordova packages into npm, which we can use in the nightly runs. To those involved in the effort, could you please say what its current status is? Kindly, Dmitry
Re: Crowdin and translation process
My main concern is that current translation not good. Proof: http://cordova.apache.org/docs/es/edge/index.html or http://cordova.apache.org/docs/ru/edge/index.html These links contain two major issues with translated docs. a) License headers b) Missing links which could lead to missing parts of docs. other issues are also present which also introduced by our tools. First kind of errors was introduced as of Cordova 3.4 or like that. There no way fix that using CrowdIn, so I fix that in the Git repo byt sending pull request https://github.com/apache/cordova-docs/pull/250 Example of changes https://github.com/apache/cordova-docs/commit/691f0f016ef4932e9cd224f49bb9641161b726e1 Second kind of errors (missing links) could be verified by running new tool ./bin/translationreport ru edge -v or ./bin/translationreport ru edge for more details. Really I don't trust output of CrowdIn due to way we generate documentation. It is very easy translate sentence and broke our autolinking in the documentation. Current process is not enough for me, since before commit changes to Git for Russian translation I want to manually generate Russian documentation and verify quality of produced output using automated-tools and by manual spot-checking. If any of tools report about problem with translation I would not commit any changes until I resolve issue. If that mean that I have to manually insert blank lines after pulling changes from CrowdIn, I will do that. I have doubts that this is practical follow this approach for other languages, that's why separation. If you are ready to go with that approach for all other languages, I would be more then happy not to separate Russian. I want find solution/process where all we would work with same set of tools, plus I will use additional tools to raise quality bar for Russian. Want to notice that I don't want to dump CrowdIn from the process, it is very good to for translation, but not for the verification of the translated results. Reason that I made pull request on GitHub directly, it is because CrowdIn does not allow do what I need. Hopefully this is clears picture from my side. BTW: another problem is that I GMT +6 which is 11 hours different from East side of US and 14 from West side of US. Add some communication problems. 2015-01-20 22:43 GMT+06:00 Lisa Seacat DeLuca ldel...@us.ibm.com: Andrey~ I'm a little confused by your request. Are you saying that you make changes to the translation outside of the Crowdin tool? If that's the case, yes, all of your changes are going to be lost every time. You'll need to make the changes within Crowdin. When the script is ran to make sure the latest documentation is pushed to the Crowdin tool it doesn't override any translations that have already been done. It just adds updates to the documentation (new sentences, new code, etc) or changes that were made. So unless sections of the english version of the documentation has been changes your Russian updates shouldn't be affected. I see no reason why you couldn't own the Russian part of the translation process. Whenever Victor goes to pull down the translations if the Russian translations aren't at 100% he can talk to you. Does that sound reasonable? Did I understand your concern correctly? Lisa [image: Inactive hide details for Andrey Kurdumov ---01/20/2015 01:22:53 AM---Hi, I start working on the improving Cordova documentatio]Andrey Kurdumov ---01/20/2015 01:22:53 AM---Hi, I start working on the improving Cordova documentation for Russian language. From: Andrey Kurdumov kant2...@googlemail.com To: dev@cordova.apache.org, Victor Adrian Sosa Herrera sosah.vic...@gmail.com Date: 01/20/2015 01:22 AM Subject: Crowdin and translation process -- Hi, I start working on the improving Cordova documentation for Russian language. Earlier I put fix for the YAML license headers directly to Github for all translations. Right now after I put documentation translation checker tool, I see issues which I would like to improve Russian translation. I download latest translation from Crowdin and compare that field with docs in the source control. What I found is that YAML fixes is not in CrowdIn. 1. This raises question how we could could work on translation with Victor together effectively, not impacting each other? When documentation files is uploaded to the Crowdin? When translation is collected from Crowdin? Are there any rules which could be used, so I could prepare to these cycles? 2. Current script just download everything and commit it in the cordova-docs repository. What I think is that it could be effective is that I take responsibility for maintaining Russian translation and Victor would maintain other translations, like it was before. And
RE: platforms/plugins save and restore from config.xml
+1 for a hangout. Thanks, Mefire -Original Message- From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal Mocny Sent: Tuesday, January 20, 2015 8:15 AM To: dev Subject: Re: platforms/plugins save and restore from config.xml Indeed! Heres a gdoc for agenda: https://docs.google.com/document/d/1h4KKT0oc70BE57eJ7Bmn4c-at7dH20g0KxTKvlyvIZU/edit?usp=sharing We can plan the time in a separate thread. On Mon, Jan 19, 2015 at 10:10 PM, Andrew Grieve agri...@chromium.org wrote: Hangout sounds great. On Mon, Jan 19, 2015 at 5:21 PM, Jesse purplecabb...@gmail.com wrote: +1 to a hangout! We are overdue. @purplecabbage risingj.com On Mon, Jan 19, 2015 at 1:23 PM, Parashuram N (MS OPEN TECH) panar...@microsoft.com wrote: I also added some comments. I think we have had a lot of good discussion on this, and should we looking at closing the proposal and working on an implementation ? We could resolve the open issues using a hangout - I also realize that we did not have a hangout for January. Would this be a good excuse to set up a hangout ? I could volunteer to start the doodle and set up the date and time if people agree that we should do a hangout. This would be one of the topics we could discuss. On 1/17/15, 6:01 PM, Andrew Grieve agri...@chromium.org wrote: Both proposals are sounding quite good to me at this point! There's merit to both for sure. I left a few more comments, but the only one I actually feel strongly about is about storing .fetch.json for platforms within the existing platform.json files rather than a separate file. On Thu, Jan 15, 2015 at 8:08 PM, Mefire O. ommen...@microsoft.com wrote: True. I'm still diving into the details of plugins and will update the doc accordingly. Sent from my Verizon Wireless 4G LTE smartphone Original message From: Gorkem Ercan Date:01/15/2015 4:56 PM (GMT-08:00) To: dev@cordova.apache.org Subject: Re: platforms/plugins save and restore from config.xml The proposal(s) seems to only cover the platforms. Although the behaviours are very similar there will be details that should be addressed. For instance how to handle the search path for plugins -- Gorkem On 15 Jan 2015, at 19:33, Mefire O. wrote: After some suggestions to instead move to autosaving to config.xml, I've made modifications the document : It now includes two proposals : --save vs autosave Please review and make suggestions : https://docs.google.com/document/d/1qKjhzSf48ybGg2GFZPtjXP8dkF4Z5Jnc7F U41 V3-jFc/edit Thanks, Mefire -Original Message- From: Mefire O. [mailto:ommen...@microsoft.com] Sent: Wednesday, January 14, 2015 4:44 PM To: dev@cordova.apache.org Subject: RE: platforms/plugins save and restore from config.xml All, I have incorporated feedback into the Google docs as suggested by others. Please, cast another look. For reviews/ comments/suggestions, please take a look at : https://docs.google.com/document/d/1qKjhzSf48ybGg2GFZPtjXP8dkF4Z5Jnc7F U41 V3-jFc/edit It seems to me like most people agree with the proposed behavior of --save. So, could anyone please review these pull requests that include that functionality ? : - https://github.com/apache/cordova-lib/pull/144 - https://github.com/apache/cordova-cli/pull/203 Also, we have another related pull request that introduce git urls support to 'cordova platform add' : - https://github.com/apache/cordova-lib/pull/148 Thanks for all the feedback so far ! I'll be creating JIRA issues for all the suggestions (those that have been agreed on). And start working on some of them... Thanks, Mefire -Original Message- From: Chuck Lantz [mailto:cla...@microsoft.com] Sent: Wednesday, January 14, 2015 1:15 PM To: dev@cordova.apache.org Subject: RE: platforms/plugins save and restore from config.xml For those joining the thread late - Here's the Google doc link that's trying to consolidate the conversation: https://docs.google.com/document/d/1qKjhzSf48ybGg2GFZPtjXP8dkF4Z5Jnc7F U41 V3-jFc/edit -Chuck -Original Message- From: Chuck Lantz [mailto:cla...@microsoft.com] Sent: Wednesday, January 14, 2015 1:11 PM To: dev@cordova.apache.org Subject: RE: platforms/plugins save and restore from config.xml You may also want to mention you tried to factor this conversation into the google doc and repoint them to it once you're done editing. Before you do that, I'd
[GitHub] cordova-windows pull request: CB-8307 - new 10yr cert and tools to...
GitHub user kirkshoop opened a pull request: https://github.com/apache/cordova-windows/pull/55 CB-8307 - new 10yr cert and tools to generate as needed This change introduces a new certificate valid for 10 years. The certificate will be updated for another 10 years on each 'npm install' (with no arguments) The idea is to ensure that each published release contains a certificate that will be valid for 10 years from the release. The keys are included because generating new keys is slow. Generating a new cert is fast. The keys can be regenerated, and used to make a new certificate, with 'npm run-script generatekey' You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-windows CB-8307 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/55.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #55 commit 7261deb6cf194f2c8118b4f35ccf4edcfb3b4386 Author: Kirk Shoop (MS OPEN TECH) kirk.sh...@microsoft.com Date: 2015-01-14T18:51:12Z CB-8307 - new 10yr cert and tools to generate as needed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Monthly Hangouts - Jan 2015 Edition
Hi, It has been a while since we had a hangouts, and a lot of folks have suggested that there are topics that could use a hangout. Thanks Michael for creating the agenda doc. https://docs.google.com/document/d/1h4KKT0oc70BE57eJ7Bmn4c-at7dH20g0KxTKvlyvIZU/edit?usp=sharing Do we have an official account where we set up the doodle? If not, I could set up a doodle for this.
[GitHub] cordova-mobile-spec pull request: CB-8131 Rewrote non plugin auto ...
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/113#issuecomment-70712736 Oh, ok. Nice catch. Do you think we should submit a fix? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
