Re: [DISCUSS] Cordova-Android 4.0.0 Release
Sorry, didn't mean to ignore it. There's no change in that scenario though
(you still need to provide a separate CordovaInterface of you don't extend
CordovaActivity, just as before), except now it's a bit easier to do so,
since you can new leverage the CordovaInterfaceImpl helper class. Does that
make sense?
On Fri, Jan 30, 2015 at 10:45 AM, Joe Bowser bows...@gmail.com wrote:
You still haven't answered the question about dual inheritance, and how
people are supposed to use the embedded use case, or you're choosing to
ignore it. How are people supposed to inherit from the activity if they
are already inheriting from another activity, and how are they supposed to
use a CordovaWebView in that case?
On Fri Jan 30 2015 at 7:29:39 AM Andrew Grieve agri...@chromium.org
wrote:
Just ran them and see no difference in failures with/without change. Did
need to update two spots which were assuming Activity==Interface, but
that's kind of the point.
On Thu, Jan 29, 2015 at 9:39 PM, Joe Bowser bows...@gmail.com wrote:
And did you run any of the existing tests? This is only the feature that
caused the JUnit tests to exist in the first place.
On Thu, Jan 29, 2015, 6:12 PM Andrew Grieve agri...@chromium.org
wrote:
On Wed, Jan 28, 2015 at 3:32 PM, Andrew Grieve agri...@chromium.org
wrote:
On Wed, Jan 28, 2015 at 1:44 PM, Joe Bowser bows...@gmail.com
wrote:
On Wed Jan 28 2015 at 10:38:07 AM Andrew Grieve
agri...@chromium.org
wrote:
- Make CordovaActivity not implement CordovaInterface, but instead
provide
CordovaInterface via an inner class (to solidify that you can't
cast the
activity to CordovaInterface and expect that to work - some used
to do
this
but I think we've cleaned it all up now)
This literally came out of nowhere. Why are you trying so hard to
remove
the embedded view use case? What if someone is implementing an
activity
that inherits from another activity like MapActivity? This API
change
came
without any discussion.
I meant for this to be discussion. Certainly this is non-critical,
but I
think it makes the embedded use-case easier not harder. Will do it in
a PR
for review.
Here's the issue: https://issues.apache.org/jira/browse/CB-8382
and PR: https://github.com/apache/cordova-android/pull/152
All of this can be done in a few days, but I'd also like to see the
dust
settle a bit before going forward with 4.0.0 release. E.g. At
least wait
until we do a blog post for 3.7.0 (are you doing this?), and have
done a
tools release that updates the pinned version to 3.7.0
If someone else wants to do the blog post on that, that's fine. And
I
agree that there should be a tools release with 3.7.0 pinned, even
though
3.7.0 is really just a technicality so we can get 4.0.0 out IMO.
3.7.0 adds Lollipop support. That's pretty big! I won't have time to
get
to it this week if there are any other takers?
On Wed, Jan 28, 2015 at 12:52 PM, Joe Bowser bows...@gmail.com
wrote:
Reminder: failures with plugins are not blockers. I've run into
that
contact issue numerous times when testing with my personal
device. I
recommend making sure that your contacts are completely clean so
that
you
don't get these weird results.
The file failures have been happening for quite a while, and
those are
not
blockers for the platform release either. Do these failures
happen
on a
platform other than ICS?
On Wed, Jan 28, 2015, 9:06 AM Murat Sutunc
mura...@microsoft.com
wrote:
I’ve ran the mobile-spec tests on android 4.0.3 with 4.0.x and
there
are
some failures. I’ve searched the jira for issues but wasn’t
able to
find
any. Has anyone else ran into these issues before?
org.apache.cordova.contacts.tests.tests Contacts
(navigator.contacts)
Round trip Contact tests (creating + save + delete + find).
Contacts.spec.24 Creating, saving, finding a contact should
work,
after
which we should not be able to find it, and we should not be
able to
delete
it again.
• Expected 2 to be 1
• Expected 1 to be 0
it(contacts.spec.24 Creating, saving, finding a
contact
should
work, removing it should work, after which we should not be
able to
find
it, and we should not be able to delete it again., function
(done)
{
// Save method is not supported on Windows
platform
if (isWindows) {
pending();
return;
}
if (isWindowsPhone8) {
done();
return;
}
gContactObj = new Contact();
gContactObj.name = new ContactName();
gContactObj.name.familyName = DeleteMe;
[GitHub] cordova-plugin-test-framework pull request: CB-8388 Prevent Window...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/9 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-network-information pull request: CB-8384 Add Windo...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-network-information/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-browser pull request: CB-8224: Add support to launch a spe...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-browser/pull/8#issuecomment-72233705 @stevengill I noticed you have made some changes in this area. Wondering if you can help review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Plugin management ?
I published a node module a while back that does it. I originally published it as cordova-create, but changed it to cdva-create so I wouldn't disturb anything the Cordova team did in the future. https://www.npmjs.com/package/cdva-create On 1/22/2015 5:36 AM, Stéphane Wirtel wrote: Hi all, In my project, I use a lot of plugins. So, is there a small tool or a config file where I can specify my dependencies (plugins) and just with a command line, install all my plugins ? I think to grunt (Gruntfile.js), bower (bower.json) and npm (package.json) Thank you, Stephane -- Stéphane Wirtel - http://wirtel.be - @matrixise - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org .
Cordova android native test
Hi all, Recently tested cordova-android master branch and found out a commit that it's triggering an issue that it got solved a while ago indirectly. Info: CB-8317 ccceaeaca Link: https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commit;h=ccceaeaca2d72fb9708100ab2f70adb903a27d66 breaks: CB-7371 To avoid future regressions, Joe suggest to create a native test that would recreate the conditions to verify that the issue is not present. Here's the deal, the current Cordova Native test suite, with the app itself, I can't recreate it, MainTestActivity class doesn't get affect at all, although with a cordova project that uses a single activity it can be recreate easily. If I go to any of the other activities and recreate it, that activity gets destroyed and gets back to the first one(MainTestActivity). The only way to recreate the problem using that test suite is by using Error URL (errorurl class) test, which triggers a destroy of the previous activity caused by not locate the html resource in the path provided. In that specific test, in that activity and after the previous activity is closed, in there I can perform the manual test and recreate the problem. I've added the code to change the configuration and perform a recreation in that specific test, but that would mean, that it can't go back to the previous one where all other test live. Another would be call the activity to perform config changes, pause the main, and get back to it, apply the configuration in that one and then trigger the recreation onResume, by listening the configuration changes, or adding a broadcastreceiver. Test sample project with a single activity: --Change the config --Triger recreation. Expected: it should recreate the activity Result (current master): it crash the app. steps to recreate manually: 1.- Create a project 2.- platform add cordova-android (master) 3.- build deploy 4.- once launched, minimize it go to settings 5.- Select another language, and then resume the app, by using the home button. At that point crashes Does anybody have any idea, to perform such as test without having to kill the main activity? any other ideas about how to recreate the scenario? Thanks devs. -- Regards, Martin Gonzalez
Re: Cordova plugin namespace
Before the end of the year, that url referenced a page. It was a live link, not a reference. John M. Wargo On Jan 28, 2015, at 9:47 AM, Andrew Grieve agri...@chromium.org wrote: I don't think the URL ever existed. XML namespace URLs don't need to actually exist IIRC. They are just identifiers. On Tue, Jan 27, 2015 at 6:07 PM, John M. Wargo j...@johnwargo.com wrote: Looking at the plugin guide at http://cordova.apache.org/ docs/en/4.0.0/plugin_ref_spec.md.html the first sentence on the page refers to a Cordova Plugin Namespace page that no longer exists: http://apache.org/cordova/ns/plugins/1.0. Anyone know what happened to it? -- *John M. Wargo* www.johnwargo.com - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Cordova-Android 4.0.0 Release
You still haven't answered the question about dual inheritance, and how
people are supposed to use the embedded use case, or you're choosing to
ignore it. How are people supposed to inherit from the activity if they
are already inheriting from another activity, and how are they supposed to
use a CordovaWebView in that case?
On Fri Jan 30 2015 at 7:29:39 AM Andrew Grieve agri...@chromium.org wrote:
Just ran them and see no difference in failures with/without change. Did
need to update two spots which were assuming Activity==Interface, but
that's kind of the point.
On Thu, Jan 29, 2015 at 9:39 PM, Joe Bowser bows...@gmail.com wrote:
And did you run any of the existing tests? This is only the feature that
caused the JUnit tests to exist in the first place.
On Thu, Jan 29, 2015, 6:12 PM Andrew Grieve agri...@chromium.org wrote:
On Wed, Jan 28, 2015 at 3:32 PM, Andrew Grieve agri...@chromium.org
wrote:
On Wed, Jan 28, 2015 at 1:44 PM, Joe Bowser bows...@gmail.com wrote:
On Wed Jan 28 2015 at 10:38:07 AM Andrew Grieve agri...@chromium.org
wrote:
- Make CordovaActivity not implement CordovaInterface, but instead
provide
CordovaInterface via an inner class (to solidify that you can't
cast the
activity to CordovaInterface and expect that to work - some used to
do
this
but I think we've cleaned it all up now)
This literally came out of nowhere. Why are you trying so hard to
remove
the embedded view use case? What if someone is implementing an
activity
that inherits from another activity like MapActivity? This API change
came
without any discussion.
I meant for this to be discussion. Certainly this is non-critical, but
I
think it makes the embedded use-case easier not harder. Will do it in
a PR
for review.
Here's the issue: https://issues.apache.org/jira/browse/CB-8382
and PR: https://github.com/apache/cordova-android/pull/152
All of this can be done in a few days, but I'd also like to see the
dust
settle a bit before going forward with 4.0.0 release. E.g. At least
wait
until we do a blog post for 3.7.0 (are you doing this?), and have
done a
tools release that updates the pinned version to 3.7.0
If someone else wants to do the blog post on that, that's fine. And I
agree that there should be a tools release with 3.7.0 pinned, even
though
3.7.0 is really just a technicality so we can get 4.0.0 out IMO.
3.7.0 adds Lollipop support. That's pretty big! I won't have time to
get
to it this week if there are any other takers?
On Wed, Jan 28, 2015 at 12:52 PM, Joe Bowser bows...@gmail.com
wrote:
Reminder: failures with plugins are not blockers. I've run into
that
contact issue numerous times when testing with my personal
device. I
recommend making sure that your contacts are completely clean so
that
you
don't get these weird results.
The file failures have been happening for quite a while, and
those are
not
blockers for the platform release either. Do these failures
happen
on a
platform other than ICS?
On Wed, Jan 28, 2015, 9:06 AM Murat Sutunc mura...@microsoft.com
wrote:
I’ve ran the mobile-spec tests on android 4.0.3 with 4.0.x and
there
are
some failures. I’ve searched the jira for issues but wasn’t
able to
find
any. Has anyone else ran into these issues before?
org.apache.cordova.contacts.tests.tests Contacts
(navigator.contacts)
Round trip Contact tests (creating + save + delete + find).
Contacts.spec.24 Creating, saving, finding a contact should
work,
after
which we should not be able to find it, and we should not be
able to
delete
it again.
• Expected 2 to be 1
• Expected 1 to be 0
it(contacts.spec.24 Creating, saving, finding a
contact
should
work, removing it should work, after which we should not be
able to
find
it, and we should not be able to delete it again., function
(done)
{
// Save method is not supported on Windows
platform
if (isWindows) {
pending();
return;
}
if (isWindowsPhone8) {
done();
return;
}
gContactObj = new Contact();
gContactObj.name = new ContactName();
gContactObj.name.familyName = DeleteMe;
gContactObj.save(function(c_obj) {
var findWin = function(cs) {
expect(cs.length).toBe(1);
// update to have proper saved id
gContactObj = cs[0];
gContactObj.remove(function() {
var findWinAgain = function(seas) {
Re: [DISCUSS] Cordova-Android 4.0.0 Release
Just ran them and see no difference in failures with/without change. Did
need to update two spots which were assuming Activity==Interface, but
that's kind of the point.
On Thu, Jan 29, 2015 at 9:39 PM, Joe Bowser bows...@gmail.com wrote:
And did you run any of the existing tests? This is only the feature that
caused the JUnit tests to exist in the first place.
On Thu, Jan 29, 2015, 6:12 PM Andrew Grieve agri...@chromium.org wrote:
On Wed, Jan 28, 2015 at 3:32 PM, Andrew Grieve agri...@chromium.org
wrote:
On Wed, Jan 28, 2015 at 1:44 PM, Joe Bowser bows...@gmail.com wrote:
On Wed Jan 28 2015 at 10:38:07 AM Andrew Grieve agri...@chromium.org
wrote:
- Make CordovaActivity not implement CordovaInterface, but instead
provide
CordovaInterface via an inner class (to solidify that you can't cast
the
activity to CordovaInterface and expect that to work - some used to
do
this
but I think we've cleaned it all up now)
This literally came out of nowhere. Why are you trying so hard to
remove
the embedded view use case? What if someone is implementing an activity
that inherits from another activity like MapActivity? This API change
came
without any discussion.
I meant for this to be discussion. Certainly this is non-critical, but I
think it makes the embedded use-case easier not harder. Will do it in a
PR
for review.
Here's the issue: https://issues.apache.org/jira/browse/CB-8382
and PR: https://github.com/apache/cordova-android/pull/152
All of this can be done in a few days, but I'd also like to see the
dust
settle a bit before going forward with 4.0.0 release. E.g. At least
wait
until we do a blog post for 3.7.0 (are you doing this?), and have
done a
tools release that updates the pinned version to 3.7.0
If someone else wants to do the blog post on that, that's fine. And I
agree that there should be a tools release with 3.7.0 pinned, even
though
3.7.0 is really just a technicality so we can get 4.0.0 out IMO.
3.7.0 adds Lollipop support. That's pretty big! I won't have time to get
to it this week if there are any other takers?
On Wed, Jan 28, 2015 at 12:52 PM, Joe Bowser bows...@gmail.com
wrote:
Reminder: failures with plugins are not blockers. I've run into
that
contact issue numerous times when testing with my personal
device. I
recommend making sure that your contacts are completely clean so
that
you
don't get these weird results.
The file failures have been happening for quite a while, and those
are
not
blockers for the platform release either. Do these failures happen
on a
platform other than ICS?
On Wed, Jan 28, 2015, 9:06 AM Murat Sutunc mura...@microsoft.com
wrote:
I’ve ran the mobile-spec tests on android 4.0.3 with 4.0.x and
there
are
some failures. I’ve searched the jira for issues but wasn’t able
to
find
any. Has anyone else ran into these issues before?
org.apache.cordova.contacts.tests.tests Contacts
(navigator.contacts)
Round trip Contact tests (creating + save + delete + find).
Contacts.spec.24 Creating, saving, finding a contact should work,
after
which we should not be able to find it, and we should not be
able to
delete
it again.
• Expected 2 to be 1
• Expected 1 to be 0
it(contacts.spec.24 Creating, saving, finding a contact
should
work, removing it should work, after which we should not be able
to
find
it, and we should not be able to delete it again., function
(done)
{
// Save method is not supported on Windows platform
if (isWindows) {
pending();
return;
}
if (isWindowsPhone8) {
done();
return;
}
gContactObj = new Contact();
gContactObj.name = new ContactName();
gContactObj.name.familyName = DeleteMe;
gContactObj.save(function(c_obj) {
var findWin = function(cs) {
expect(cs.length).toBe(1);
// update to have proper saved id
gContactObj = cs[0];
gContactObj.remove(function() {
var findWinAgain = function(seas) {
expect(seas.length).toBe(0);
gContactObj.remove(function() {
throw(success callback called
after
non-existent Contact object called remove(). Test failed.);
}, function(e) {
expect(e.code).toBe(ContactErr
or.UNKNOWN_ERROR);
[GitHub] cordova-plugin-test-framework pull request: CB-8388 Prevent Window...
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/9 CB-8388 Prevent Windows app from crashing on test failure You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-test-framework CB-8388 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-test-framework/pull/9.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #9 commit 395d3458a45b162a5aa0278d7fd4d2b322a1ad51 Author: Nikhil Khandelwal nikhi...@microsoft.com Date: 2015-01-30T16:42:32Z CB-8388 Prevent Windows app from crashing on test failure --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CB-5059 Add a CookieMan...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/60 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/140 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-wp8 pull request: Improved console logging
Github user oliversalzburg commented on the pull request: https://github.com/apache/cordova-wp8/pull/66#issuecomment-72178283 @purplecabbage I'll take care of it right away. Thanks for the heads-up. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-network-information pull request: CB-8384 Add Windo...
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/24 CB-8384 Add Windows platform support to Network Information plugin https://issues.apache.org/jira/browse/CB-8384 You can merge this pull request into a Git repository by running: $ git pull https://github.com/sgrebnov/cordova-plugin-network-information CB-8384 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-network-information/pull/24.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #24 commit fb608698e5c97e18da8bb1d6f73621bb3676ebfe Author: sgrebnov v-seg...@microsoft.com Date: 2015-01-30T11:57:10Z CB-8384 Add Windows section to Network Information plugin commit c8281535160a547a367b7c820360e711c59d4cc9 Author: sgrebnov v-seg...@microsoft.com Date: 2015-01-30T12:33:36Z CB-8384 Add Windows platform quirks commit d8a714757fae0ac615224a7a0daabaa88c8e2581 Author: sgrebnov v-seg...@microsoft.com Date: 2015-01-30T12:37:16Z CB-8384 Fixes the way we detect online status on Windows --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
