[GitHub] cordova-plugin-inappbrowser pull request: CB 8467: provide hide() ...
Github user herrevilkitten closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/81 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-8467 provide hide met...
GitHub user herrevilkitten opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/101 CB-8467 provide hide method to hide browser window Added support for hiding the web view container. This maintains the browser session without closing it. The browser window can be repeatedly hidden and shown. ** This has only been tested on android and ios ** amazon/android: An additional `hide` action was added to `InAppBrowser#execute`. It is identical to `show`, except that it calls `dialog.hide()` instead. blackberry10: no changes firefoxos: Added a `hide` method that is identical to `show`, indicating it is not supported. ios: Added a `hide` method that is identical to `show`, except that it uses `dismissViewControllerAnimated`. It checks the value of `_previousStatusBarStyle`. If it is `-1`, the method returns with no action performed. If it is not, it is set to `-1.` ubuntu: Added a `hide` method that sets `CordovaWrapper.global.inappbrowser.visible` to `false`. windows: Added a `hide` method that sets `browserWrap.style.display` to `none`. wp: Added a `hide` method that is identical to `show`, except that it sets `browser.Visibility` to `Visibility.Collapsed` and sets `AppBar.IsVisible` to `false`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/herrevilkitten/cordova-plugin-inappbrowser CB-8467_provide_hide_method_to_hide_browser_window Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/101.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #101 commit 573b1bdc777370a8af860a5b6044e8ddb3f69932 Author: ekidder3 Date: 2015-02-05T12:20:57Z CB-8467 Added support for hiding the web view container. This maintains the browser session without closing it. The browser window can be repeatedly hidden and shown. ** This has only been tested on android and ios ** amazon/android: An additional `hide` action was added to `InAppBrowser#execute`. It is identical to `show`, except that it calls `dialog.hide()` instead. blackberry10: no changes firefoxos: Added a `hide` method that is identical to `show`, indicating it is not supported. ios: Added a `hide` method that is identical to `show`, except that it uses `dismissViewControllerAnimated`. It checks the value of `_previousStatusBarStyle`. If it is `-1`, the method returns with no action performed. If it is not, it is set to `-1.` ubuntu: Added a `hide` method that sets `CordovaWrapper.global.inappbrowser.visible` to `false`. windows: Added a `hide` method that sets `browserWrap.style.display` to `none`. wp: Added a `hide` method that is identical to `show`, except that it sets `browser.Visibility` to `Visibility.Collapsed` and sets `AppBar.IsVisible` to `false`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-7204 Fixed race condi...
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-89458111 This could be it: 1. https://github.com/apache/cordova-plugin-splashscreen/blob/d2e62a551c950041cb4c9683624a04d931f4bee3/src/ios/CDVSplashScreen.m#L295-L296 2. https://github.com/apache/cordova-plugin-splashscreen/blob/d2e62a551c950041cb4c9683624a04d931f4bee3/src/ios/CDVSplashScreen.m#L300 All three instances in the blocks create strong references to self, which should be weak. Here is my attempt at a patch: https://gist.github.com/shazron/e45705f76bef4448139a Try it out. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8753 Maintain splash ...
Github user AlexTalis commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/43#issuecomment-89449833 @agrieve, I believe I implemented all the changes we discussed. Can you accept the pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-7204 Fixed race condi...
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-89449427 @jacobg not too sure what's going on here. Post the full crash log somewhere? (shot in the dark). I'll review the code again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[VOTE] 3.8.1 Windows Release
Please review and vote on this 3.8.1 Windows Release. Release issue: https://issues.apache.org/jira/browse/CB-8796 Repos ready to be released have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8796 The package was published from its corresponding git tag: cordova-windows: 3.8.1 (9b003319c6) Upon a successful vote I will upload the archive to dist/, and publish it to NPM. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses
Re: [Vote] 3.8.0 WP8 Release (Attempt 2)
The vote has now closed. The results are: Positive Binding Votes: 4 Steve Gill Parashuram N Sergey Grebnov Jesse Macfadyen The vote has passed. I will publish to dist and npm On Wed, Apr 1, 2015 at 1:04 PM, Jesse wrote: > +1 > - coho verify-archive > - manually verified version numbers throughout packaged files > (PLATFORM_VERSION_BUILD_LABEL) > - smoke tested building/running an app > > @purplecabbage > risingj.com > > On Wed, Apr 1, 2015 at 11:43 AM, Sergey Grebnov (Akvelon) < > v-seg...@microsoft.com> wrote: > > > I vote +1: > > > > * Manually verified platform can be added, built and run > > * Run mobile spec auto tests on emulator > > > > Thx! > > Sergey > > > > -Original Message- > > From: Parashuram N (MS OPEN TECH) [mailto:panar...@microsoft.com] > > Sent: Wednesday, April 1, 2015 6:48 PM > > To: dev@cordova.apache.org > > Subject: Re: [Vote] 3.8.0 WP8 Release (Attempt 2) > > > > Voting +1 > > > > * Verified archives via 'coho verify-archive' > > * Verified tags manually > > * Verified platform version > > * Verified blank app creates correctly with platform > > * Verified blank app can be successfully run and built > > * Checked whitespace issues > > * Checked Unicode issues > > * Ran smoke testing of mobilespec app (ran autotests) > > > > > > > > > > On 3/31/15, 3:10 PM, "Steven Gill" wrote: > > > > >Please review and vote on this 3.8.0 WP8 Release. > > > > > >Release issue: https://issues.apache.org/jira/browse/CB-8748 > > > > > >Repos ready to be released have been published to > > >dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8748 > > > > > >The package was published from its corresponding git tag: > > >cordova-wp8: 3.8.0 (dcd035bed4) > > > > > >Upon a successful vote I will upload the archive to dist/ and publish > > >it to NPM. > > >Voting guidelines: > > >https://github.com/apache/cordova-coho/blob/master/docs/release-voting. > > >md Voting will go on for a minimum of 48 hours. > > > > > >I vote +1: > > >* Ran coho audit-license-headers over the relevant repos > > >* Ran coho check-license to ensure all dependencies and subdependencies > > >have Apache-compatible licenses > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > >
Latest --browserify status?
Hi folks,
Is there a single issue or location for tracking the latest status on the
-browserify functionality in cordova? I've got cordova 4.3.0 installed and have
been playing with this a bit, as it's a feature I'd very much like to use for
our app! But, I have a few questions on how it's working, and couldn't find any
official documentation on the current status and what should work/what doesn't.
I'm not intimately familiar with the cordova code, but I'm happy to contribute
back anything I can do to help make this work better.
Here's what I'm currently running into:
1) When I run 'cordova prepare -browserify', all I see is the original
plugin JS files (in /plugins//www/) end up with the following appended to
them (note, each time you prepare, it continues to append another iteration):
window.navigator = window.navigator || {};
window.navigator.camera = window.navigator.camera || {};
require('cordova/builder').assignOrWrapInDeprecateGetter(window.navigator,
'camera', module.exports);
It's usually duplicated in there 2-3 additional times after each run of
prepare. Is that expected?
2) cordova.define() doesn't seem to be defined in the browserify model. Is
this a legacy plugin definition approach? I couldn't find any documentation
about it, but I don't see it being used in any of the current Apache plugins.
I'm running into it with the barcodescanner plugin
(https://github.com/wildabeast/BarcodeScanner/blob/master/www/barcodescanner.js#L132);
commenting it out seems to work fine. Does this need to be translated in the
browserify code?
3) Minor: the plugin www directories still exist in the output www folder,
even though the JS isn't in there (since it is bundled into cordova.js).
I'm not on the mailing list, so please include me directly in any replies.
Thanks,
Dan
[GitHub] cordova-plugin-camera pull request: CB-8706, CB-8707 saveToPhotoAl...
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27744691
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePicture: function (successCallback, errorCallback, args) {
-var encodingType = args[5];
-var targetWidth = args[3];
-var targetHeight = args[4];
var sourceType = args[2];
-var destinationType = args[1];
-var mediaType = args[6];
-var allowCrop = !!args[7];
-var saveToPhotoAlbum = args[9];
-var cameraDirection = args[11];
-
-// resize method :)
-var resizeImage = function (file) {
-var tempPhotoFileName = "";
-if (encodingType == Camera.EncodingType.PNG) {
-tempPhotoFileName = "camera_cordova_temp_return.png";
-} else {
-tempPhotoFileName = "camera_cordova_temp_return.jpg";
-}
-
-var storageFolder =
Windows.Storage.ApplicationData.current.localFolder;
-file.copyAsync(storageFolder, file.name,
Windows.Storage.NameCollisionOption.replaceExisting).then(function
(storageFile) {
-
Windows.Storage.FileIO.readBufferAsync(storageFile).then(function(buffer) {
-var strBase64 =
Windows.Security.Cryptography.CryptographicBuffer.encodeToBase64String(buffer);
-var imageData = "data:" + file.contentType +
";base64," + strBase64;
-var image = new Image();
-image.src = imageData;
-image.onload = function() {
-var imageWidth = targetWidth,
-imageHeight = targetHeight;
-var canvas = document.createElement('canvas');
-
-canvas.width = imageWidth;
-canvas.height = imageHeight;
-canvas.getContext("2d").drawImage(this, 0, 0,
imageWidth, imageHeight);
-
-var fileContent =
canvas.toDataURL(file.contentType).split(',')[1];
-
-var storageFolder =
Windows.Storage.ApplicationData.current.localFolder;
+if (sourceType != Camera.PictureSourceType.CAMERA) {
+takePictureFromFile(successCallback, errorCallback, args);
+} else {
+takePictureFromCamera(successCallback, errorCallback, args);
+}
+}
+};
-storageFolder.createFileAsync(tempPhotoFileName,
Windows.Storage.CreationCollisionOption.generateUniqueName).done(function
(storagefile) {
-var content =
Windows.Security.Cryptography.CryptographicBuffer.decodeFromBase64String(fileContent);
-
Windows.Storage.FileIO.writeBufferAsync(storagefile, content).then(function () {
-successCallback("ms-appdata:///local/" +
storagefile.name);
-}, function () {
-errorCallback("Resize picture error.");
-});
-});
-};
-});
-}, function () {
-errorCallback("Can't access localStorage folder");
-});
-};
+// Resize method
+function resizeImage(successCallback, errorCallback, file, targetWidth,
targetHeight, encodingType) {
+var tempPhotoFileName = "";
+if (encodingType == Camera.EncodingType.PNG) {
+tempPhotoFileName = "camera_cordova_temp_return.png";
+} else {
+tempPhotoFileName = "camera_cordova_temp_return.jpg";
+}
-// because of asynchronous method, so let the successCallback be
called in it.
-var resizeImageBase64 = function (file) {
+var storageFolder =
Windows.Storage.ApplicationData.current.localFolder;
+file.copyAsync(storageFolder, file.name,
Windows.Storage.NameCollisionOption.replaceExisting)
+.then(function (storageFile) { return
Windows.Storage.FileIO.readBufferAsync(storageFile); })
+.then(function(buffer) {
+var strBase64 =
Windows.Security.Cryptography.CryptographicBuffer.encodeToBase64String(buffer);
+var imageData = "data:" + file.contentType + ";base64," +
strBase64;
+var image = new Image();
+image.src = imageData;
+image.onload = function() {
+var imageWidth = targetWidth,
+imageHeight = targetHeight;
+var canvas = docume
[GitHub] cordova-plugin-camera pull request: CB-8706, CB-8707 saveToPhotoAl...
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27744687
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePicture: function (successCallback, errorCallback, args) {
-var encodingType = args[5];
-var targetWidth = args[3];
-var targetHeight = args[4];
var sourceType = args[2];
-var destinationType = args[1];
-var mediaType = args[6];
-var allowCrop = !!args[7];
-var saveToPhotoAlbum = args[9];
-var cameraDirection = args[11];
-
-// resize method :)
-var resizeImage = function (file) {
-var tempPhotoFileName = "";
-if (encodingType == Camera.EncodingType.PNG) {
-tempPhotoFileName = "camera_cordova_temp_return.png";
-} else {
-tempPhotoFileName = "camera_cordova_temp_return.jpg";
-}
-
-var storageFolder =
Windows.Storage.ApplicationData.current.localFolder;
-file.copyAsync(storageFolder, file.name,
Windows.Storage.NameCollisionOption.replaceExisting).then(function
(storageFile) {
-
Windows.Storage.FileIO.readBufferAsync(storageFile).then(function(buffer) {
-var strBase64 =
Windows.Security.Cryptography.CryptographicBuffer.encodeToBase64String(buffer);
-var imageData = "data:" + file.contentType +
";base64," + strBase64;
-var image = new Image();
-image.src = imageData;
-image.onload = function() {
-var imageWidth = targetWidth,
-imageHeight = targetHeight;
-var canvas = document.createElement('canvas');
-
-canvas.width = imageWidth;
-canvas.height = imageHeight;
-canvas.getContext("2d").drawImage(this, 0, 0,
imageWidth, imageHeight);
-
-var fileContent =
canvas.toDataURL(file.contentType).split(',')[1];
-
-var storageFolder =
Windows.Storage.ApplicationData.current.localFolder;
+if (sourceType != Camera.PictureSourceType.CAMERA) {
+takePictureFromFile(successCallback, errorCallback, args);
+} else {
+takePictureFromCamera(successCallback, errorCallback, args);
+}
+}
+};
-storageFolder.createFileAsync(tempPhotoFileName,
Windows.Storage.CreationCollisionOption.generateUniqueName).done(function
(storagefile) {
-var content =
Windows.Security.Cryptography.CryptographicBuffer.decodeFromBase64String(fileContent);
-
Windows.Storage.FileIO.writeBufferAsync(storagefile, content).then(function () {
-successCallback("ms-appdata:///local/" +
storagefile.name);
-}, function () {
-errorCallback("Resize picture error.");
-});
-});
-};
-});
-}, function () {
-errorCallback("Can't access localStorage folder");
-});
-};
+// Resize method
+function resizeImage(successCallback, errorCallback, file, targetWidth,
targetHeight, encodingType) {
+var tempPhotoFileName = "";
+if (encodingType == Camera.EncodingType.PNG) {
+tempPhotoFileName = "camera_cordova_temp_return.png";
+} else {
+tempPhotoFileName = "camera_cordova_temp_return.jpg";
+}
-// because of asynchronous method, so let the successCallback be
called in it.
-var resizeImageBase64 = function (file) {
+var storageFolder =
Windows.Storage.ApplicationData.current.localFolder;
+file.copyAsync(storageFolder, file.name,
Windows.Storage.NameCollisionOption.replaceExisting)
+.then(function (storageFile) { return
Windows.Storage.FileIO.readBufferAsync(storageFile); })
+.then(function(buffer) {
+var strBase64 =
Windows.Security.Cryptography.CryptographicBuffer.encodeToBase64String(buffer);
+var imageData = "data:" + file.contentType + ";base64," +
strBase64;
+var image = new Image();
+image.src = imageData;
+image.onload = function() {
+var imageWidth = targetWidth,
+imageHeight = targetHeight;
+var canvas = docume
[GitHub] cordova-plugin-camera pull request: CB-8706, CB-8707 saveToPhotoAl...
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27744671
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePicture: function (successCallback, errorCallback, args) {
-var encodingType = args[5];
-var targetWidth = args[3];
-var targetHeight = args[4];
var sourceType = args[2];
-var destinationType = args[1];
-var mediaType = args[6];
-var allowCrop = !!args[7];
-var saveToPhotoAlbum = args[9];
-var cameraDirection = args[11];
-
-// resize method :)
-var resizeImage = function (file) {
-var tempPhotoFileName = "";
-if (encodingType == Camera.EncodingType.PNG) {
-tempPhotoFileName = "camera_cordova_temp_return.png";
-} else {
-tempPhotoFileName = "camera_cordova_temp_return.jpg";
-}
-
-var storageFolder =
Windows.Storage.ApplicationData.current.localFolder;
-file.copyAsync(storageFolder, file.name,
Windows.Storage.NameCollisionOption.replaceExisting).then(function
(storageFile) {
-
Windows.Storage.FileIO.readBufferAsync(storageFile).then(function(buffer) {
-var strBase64 =
Windows.Security.Cryptography.CryptographicBuffer.encodeToBase64String(buffer);
-var imageData = "data:" + file.contentType +
";base64," + strBase64;
-var image = new Image();
-image.src = imageData;
-image.onload = function() {
-var imageWidth = targetWidth,
-imageHeight = targetHeight;
-var canvas = document.createElement('canvas');
-
-canvas.width = imageWidth;
-canvas.height = imageHeight;
-canvas.getContext("2d").drawImage(this, 0, 0,
imageWidth, imageHeight);
-
-var fileContent =
canvas.toDataURL(file.contentType).split(',')[1];
-
-var storageFolder =
Windows.Storage.ApplicationData.current.localFolder;
+if (sourceType != Camera.PictureSourceType.CAMERA) {
+takePictureFromFile(successCallback, errorCallback, args);
+} else {
+takePictureFromCamera(successCallback, errorCallback, args);
+}
+}
+};
-storageFolder.createFileAsync(tempPhotoFileName,
Windows.Storage.CreationCollisionOption.generateUniqueName).done(function
(storagefile) {
-var content =
Windows.Security.Cryptography.CryptographicBuffer.decodeFromBase64String(fileContent);
-
Windows.Storage.FileIO.writeBufferAsync(storagefile, content).then(function () {
-successCallback("ms-appdata:///local/" +
storagefile.name);
-}, function () {
-errorCallback("Resize picture error.");
-});
-});
-};
-});
-}, function () {
-errorCallback("Can't access localStorage folder");
-});
-};
+// Resize method
+function resizeImage(successCallback, errorCallback, file, targetWidth,
targetHeight, encodingType) {
+var tempPhotoFileName = "";
+if (encodingType == Camera.EncodingType.PNG) {
+tempPhotoFileName = "camera_cordova_temp_return.png";
+} else {
+tempPhotoFileName = "camera_cordova_temp_return.jpg";
+}
-// because of asynchronous method, so let the successCallback be
called in it.
-var resizeImageBase64 = function (file) {
+var storageFolder =
Windows.Storage.ApplicationData.current.localFolder;
+file.copyAsync(storageFolder, file.name,
Windows.Storage.NameCollisionOption.replaceExisting)
+.then(function (storageFile) { return
Windows.Storage.FileIO.readBufferAsync(storageFile); })
+.then(function(buffer) {
+var strBase64 =
Windows.Security.Cryptography.CryptographicBuffer.encodeToBase64String(buffer);
+var imageData = "data:" + file.contentType + ";base64," +
strBase64;
+var image = new Image();
+image.src = imageData;
+image.onload = function() {
+var imageWidth = targetWidth,
+imageHeight = targetHeight;
+var canvas = docume
[GitHub] cordova-plugin-camera pull request: CB-8706, CB-8707 saveToPhotoAl...
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27744681
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePicture: function (successCallback, errorCallback, args) {
-var encodingType = args[5];
-var targetWidth = args[3];
-var targetHeight = args[4];
var sourceType = args[2];
-var destinationType = args[1];
-var mediaType = args[6];
-var allowCrop = !!args[7];
-var saveToPhotoAlbum = args[9];
-var cameraDirection = args[11];
-
-// resize method :)
-var resizeImage = function (file) {
-var tempPhotoFileName = "";
-if (encodingType == Camera.EncodingType.PNG) {
-tempPhotoFileName = "camera_cordova_temp_return.png";
-} else {
-tempPhotoFileName = "camera_cordova_temp_return.jpg";
-}
-
-var storageFolder =
Windows.Storage.ApplicationData.current.localFolder;
-file.copyAsync(storageFolder, file.name,
Windows.Storage.NameCollisionOption.replaceExisting).then(function
(storageFile) {
-
Windows.Storage.FileIO.readBufferAsync(storageFile).then(function(buffer) {
-var strBase64 =
Windows.Security.Cryptography.CryptographicBuffer.encodeToBase64String(buffer);
-var imageData = "data:" + file.contentType +
";base64," + strBase64;
-var image = new Image();
-image.src = imageData;
-image.onload = function() {
-var imageWidth = targetWidth,
-imageHeight = targetHeight;
-var canvas = document.createElement('canvas');
-
-canvas.width = imageWidth;
-canvas.height = imageHeight;
-canvas.getContext("2d").drawImage(this, 0, 0,
imageWidth, imageHeight);
-
-var fileContent =
canvas.toDataURL(file.contentType).split(',')[1];
-
-var storageFolder =
Windows.Storage.ApplicationData.current.localFolder;
+if (sourceType != Camera.PictureSourceType.CAMERA) {
+takePictureFromFile(successCallback, errorCallback, args);
+} else {
+takePictureFromCamera(successCallback, errorCallback, args);
+}
+}
+};
-storageFolder.createFileAsync(tempPhotoFileName,
Windows.Storage.CreationCollisionOption.generateUniqueName).done(function
(storagefile) {
-var content =
Windows.Security.Cryptography.CryptographicBuffer.decodeFromBase64String(fileContent);
-
Windows.Storage.FileIO.writeBufferAsync(storagefile, content).then(function () {
-successCallback("ms-appdata:///local/" +
storagefile.name);
-}, function () {
-errorCallback("Resize picture error.");
-});
-});
-};
-});
-}, function () {
-errorCallback("Can't access localStorage folder");
-});
-};
+// Resize method
+function resizeImage(successCallback, errorCallback, file, targetWidth,
targetHeight, encodingType) {
+var tempPhotoFileName = "";
+if (encodingType == Camera.EncodingType.PNG) {
+tempPhotoFileName = "camera_cordova_temp_return.png";
+} else {
+tempPhotoFileName = "camera_cordova_temp_return.jpg";
+}
-// because of asynchronous method, so let the successCallback be
called in it.
-var resizeImageBase64 = function (file) {
+var storageFolder =
Windows.Storage.ApplicationData.current.localFolder;
+file.copyAsync(storageFolder, file.name,
Windows.Storage.NameCollisionOption.replaceExisting)
+.then(function (storageFile) { return
Windows.Storage.FileIO.readBufferAsync(storageFile); })
+.then(function(buffer) {
+var strBase64 =
Windows.Security.Cryptography.CryptographicBuffer.encodeToBase64String(buffer);
+var imageData = "data:" + file.contentType + ";base64," +
strBase64;
+var image = new Image();
+image.src = imageData;
+image.onload = function() {
+var imageWidth = targetWidth,
+imageHeight = targetHeight;
+var canvas = docume
[GitHub] cordova-plugin-camera pull request: CB-8706, CB-8707 saveToPhotoAl...
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27744642
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePicture: function (successCallback, errorCallback, args) {
-var encodingType = args[5];
-var targetWidth = args[3];
-var targetHeight = args[4];
var sourceType = args[2];
-var destinationType = args[1];
-var mediaType = args[6];
-var allowCrop = !!args[7];
-var saveToPhotoAlbum = args[9];
-var cameraDirection = args[11];
-
-// resize method :)
-var resizeImage = function (file) {
-var tempPhotoFileName = "";
-if (encodingType == Camera.EncodingType.PNG) {
-tempPhotoFileName = "camera_cordova_temp_return.png";
-} else {
-tempPhotoFileName = "camera_cordova_temp_return.jpg";
-}
-
-var storageFolder =
Windows.Storage.ApplicationData.current.localFolder;
-file.copyAsync(storageFolder, file.name,
Windows.Storage.NameCollisionOption.replaceExisting).then(function
(storageFile) {
-
Windows.Storage.FileIO.readBufferAsync(storageFile).then(function(buffer) {
-var strBase64 =
Windows.Security.Cryptography.CryptographicBuffer.encodeToBase64String(buffer);
-var imageData = "data:" + file.contentType +
";base64," + strBase64;
-var image = new Image();
-image.src = imageData;
-image.onload = function() {
-var imageWidth = targetWidth,
-imageHeight = targetHeight;
-var canvas = document.createElement('canvas');
-
-canvas.width = imageWidth;
-canvas.height = imageHeight;
-canvas.getContext("2d").drawImage(this, 0, 0,
imageWidth, imageHeight);
-
-var fileContent =
canvas.toDataURL(file.contentType).split(',')[1];
-
-var storageFolder =
Windows.Storage.ApplicationData.current.localFolder;
+if (sourceType != Camera.PictureSourceType.CAMERA) {
+takePictureFromFile(successCallback, errorCallback, args);
+} else {
+takePictureFromCamera(successCallback, errorCallback, args);
+}
+}
+};
-storageFolder.createFileAsync(tempPhotoFileName,
Windows.Storage.CreationCollisionOption.generateUniqueName).done(function
(storagefile) {
-var content =
Windows.Security.Cryptography.CryptographicBuffer.decodeFromBase64String(fileContent);
-
Windows.Storage.FileIO.writeBufferAsync(storagefile, content).then(function () {
-successCallback("ms-appdata:///local/" +
storagefile.name);
-}, function () {
-errorCallback("Resize picture error.");
-});
-});
-};
-});
-}, function () {
-errorCallback("Can't access localStorage folder");
-});
-};
+// Resize method
+function resizeImage(successCallback, errorCallback, file, targetWidth,
targetHeight, encodingType) {
+var tempPhotoFileName = "";
+if (encodingType == Camera.EncodingType.PNG) {
+tempPhotoFileName = "camera_cordova_temp_return.png";
+} else {
+tempPhotoFileName = "camera_cordova_temp_return.jpg";
+}
-// because of asynchronous method, so let the successCallback be
called in it.
-var resizeImageBase64 = function (file) {
+var storageFolder =
Windows.Storage.ApplicationData.current.localFolder;
+file.copyAsync(storageFolder, file.name,
Windows.Storage.NameCollisionOption.replaceExisting)
+.then(function (storageFile) { return
Windows.Storage.FileIO.readBufferAsync(storageFile); })
+.then(function(buffer) {
+var strBase64 =
Windows.Security.Cryptography.CryptographicBuffer.encodeToBase64String(buffer);
+var imageData = "data:" + file.contentType + ";base64," +
strBase64;
+var image = new Image();
+image.src = imageData;
+image.onload = function() {
+var imageWidth = targetWidth,
+imageHeight = targetHeight;
+var canvas = docume
[GitHub] cordova-plugin-camera pull request: CB-8706, CB-8707 saveToPhotoAl...
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27744665
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePicture: function (successCallback, errorCallback, args) {
-var encodingType = args[5];
-var targetWidth = args[3];
-var targetHeight = args[4];
var sourceType = args[2];
-var destinationType = args[1];
-var mediaType = args[6];
-var allowCrop = !!args[7];
-var saveToPhotoAlbum = args[9];
-var cameraDirection = args[11];
-
-// resize method :)
-var resizeImage = function (file) {
-var tempPhotoFileName = "";
-if (encodingType == Camera.EncodingType.PNG) {
-tempPhotoFileName = "camera_cordova_temp_return.png";
-} else {
-tempPhotoFileName = "camera_cordova_temp_return.jpg";
-}
-
-var storageFolder =
Windows.Storage.ApplicationData.current.localFolder;
-file.copyAsync(storageFolder, file.name,
Windows.Storage.NameCollisionOption.replaceExisting).then(function
(storageFile) {
-
Windows.Storage.FileIO.readBufferAsync(storageFile).then(function(buffer) {
-var strBase64 =
Windows.Security.Cryptography.CryptographicBuffer.encodeToBase64String(buffer);
-var imageData = "data:" + file.contentType +
";base64," + strBase64;
-var image = new Image();
-image.src = imageData;
-image.onload = function() {
-var imageWidth = targetWidth,
-imageHeight = targetHeight;
-var canvas = document.createElement('canvas');
-
-canvas.width = imageWidth;
-canvas.height = imageHeight;
-canvas.getContext("2d").drawImage(this, 0, 0,
imageWidth, imageHeight);
-
-var fileContent =
canvas.toDataURL(file.contentType).split(',')[1];
-
-var storageFolder =
Windows.Storage.ApplicationData.current.localFolder;
+if (sourceType != Camera.PictureSourceType.CAMERA) {
+takePictureFromFile(successCallback, errorCallback, args);
+} else {
+takePictureFromCamera(successCallback, errorCallback, args);
+}
+}
+};
-storageFolder.createFileAsync(tempPhotoFileName,
Windows.Storage.CreationCollisionOption.generateUniqueName).done(function
(storagefile) {
-var content =
Windows.Security.Cryptography.CryptographicBuffer.decodeFromBase64String(fileContent);
-
Windows.Storage.FileIO.writeBufferAsync(storagefile, content).then(function () {
-successCallback("ms-appdata:///local/" +
storagefile.name);
-}, function () {
-errorCallback("Resize picture error.");
-});
-});
-};
-});
-}, function () {
-errorCallback("Can't access localStorage folder");
-});
-};
+// Resize method
+function resizeImage(successCallback, errorCallback, file, targetWidth,
targetHeight, encodingType) {
+var tempPhotoFileName = "";
+if (encodingType == Camera.EncodingType.PNG) {
+tempPhotoFileName = "camera_cordova_temp_return.png";
+} else {
+tempPhotoFileName = "camera_cordova_temp_return.jpg";
+}
-// because of asynchronous method, so let the successCallback be
called in it.
-var resizeImageBase64 = function (file) {
+var storageFolder =
Windows.Storage.ApplicationData.current.localFolder;
+file.copyAsync(storageFolder, file.name,
Windows.Storage.NameCollisionOption.replaceExisting)
+.then(function (storageFile) { return
Windows.Storage.FileIO.readBufferAsync(storageFile); })
+.then(function(buffer) {
+var strBase64 =
Windows.Security.Cryptography.CryptographicBuffer.encodeToBase64String(buffer);
+var imageData = "data:" + file.contentType + ";base64," +
strBase64;
+var image = new Image();
+image.src = imageData;
+image.onload = function() {
+var imageWidth = targetWidth,
+imageHeight = targetHeight;
+var canvas = docume
[GitHub] cordova-plugin-camera pull request: CB-8706, CB-8707 saveToPhotoAl...
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27744649
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePicture: function (successCallback, errorCallback, args) {
-var encodingType = args[5];
-var targetWidth = args[3];
-var targetHeight = args[4];
var sourceType = args[2];
-var destinationType = args[1];
-var mediaType = args[6];
-var allowCrop = !!args[7];
-var saveToPhotoAlbum = args[9];
-var cameraDirection = args[11];
-
-// resize method :)
-var resizeImage = function (file) {
-var tempPhotoFileName = "";
-if (encodingType == Camera.EncodingType.PNG) {
-tempPhotoFileName = "camera_cordova_temp_return.png";
-} else {
-tempPhotoFileName = "camera_cordova_temp_return.jpg";
-}
-
-var storageFolder =
Windows.Storage.ApplicationData.current.localFolder;
-file.copyAsync(storageFolder, file.name,
Windows.Storage.NameCollisionOption.replaceExisting).then(function
(storageFile) {
-
Windows.Storage.FileIO.readBufferAsync(storageFile).then(function(buffer) {
-var strBase64 =
Windows.Security.Cryptography.CryptographicBuffer.encodeToBase64String(buffer);
-var imageData = "data:" + file.contentType +
";base64," + strBase64;
-var image = new Image();
-image.src = imageData;
-image.onload = function() {
-var imageWidth = targetWidth,
-imageHeight = targetHeight;
-var canvas = document.createElement('canvas');
-
-canvas.width = imageWidth;
-canvas.height = imageHeight;
-canvas.getContext("2d").drawImage(this, 0, 0,
imageWidth, imageHeight);
-
-var fileContent =
canvas.toDataURL(file.contentType).split(',')[1];
-
-var storageFolder =
Windows.Storage.ApplicationData.current.localFolder;
+if (sourceType != Camera.PictureSourceType.CAMERA) {
+takePictureFromFile(successCallback, errorCallback, args);
+} else {
+takePictureFromCamera(successCallback, errorCallback, args);
+}
+}
+};
-storageFolder.createFileAsync(tempPhotoFileName,
Windows.Storage.CreationCollisionOption.generateUniqueName).done(function
(storagefile) {
-var content =
Windows.Security.Cryptography.CryptographicBuffer.decodeFromBase64String(fileContent);
-
Windows.Storage.FileIO.writeBufferAsync(storagefile, content).then(function () {
-successCallback("ms-appdata:///local/" +
storagefile.name);
-}, function () {
-errorCallback("Resize picture error.");
-});
-});
-};
-});
-}, function () {
-errorCallback("Can't access localStorage folder");
-});
-};
+// Resize method
+function resizeImage(successCallback, errorCallback, file, targetWidth,
targetHeight, encodingType) {
+var tempPhotoFileName = "";
+if (encodingType == Camera.EncodingType.PNG) {
+tempPhotoFileName = "camera_cordova_temp_return.png";
+} else {
+tempPhotoFileName = "camera_cordova_temp_return.jpg";
+}
-// because of asynchronous method, so let the successCallback be
called in it.
-var resizeImageBase64 = function (file) {
+var storageFolder =
Windows.Storage.ApplicationData.current.localFolder;
+file.copyAsync(storageFolder, file.name,
Windows.Storage.NameCollisionOption.replaceExisting)
+.then(function (storageFile) { return
Windows.Storage.FileIO.readBufferAsync(storageFile); })
+.then(function(buffer) {
+var strBase64 =
Windows.Security.Cryptography.CryptographicBuffer.encodeToBase64String(buffer);
+var imageData = "data:" + file.contentType + ";base64," +
strBase64;
+var image = new Image();
+image.src = imageData;
+image.onload = function() {
+var imageWidth = targetWidth,
+imageHeight = targetHeight;
+var canvas = docume
[GitHub] cordova-plugin-camera pull request: CB-8706, CB-8707 saveToPhotoAl...
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27744001
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePicture: function (successCallback, errorCallback, args) {
-var encodingType = args[5];
-var targetWidth = args[3];
-var targetHeight = args[4];
var sourceType = args[2];
-var destinationType = args[1];
-var mediaType = args[6];
-var allowCrop = !!args[7];
-var saveToPhotoAlbum = args[9];
-var cameraDirection = args[11];
-
-// resize method :)
-var resizeImage = function (file) {
-var tempPhotoFileName = "";
-if (encodingType == Camera.EncodingType.PNG) {
-tempPhotoFileName = "camera_cordova_temp_return.png";
-} else {
-tempPhotoFileName = "camera_cordova_temp_return.jpg";
-}
-
-var storageFolder =
Windows.Storage.ApplicationData.current.localFolder;
-file.copyAsync(storageFolder, file.name,
Windows.Storage.NameCollisionOption.replaceExisting).then(function
(storageFile) {
-
Windows.Storage.FileIO.readBufferAsync(storageFile).then(function(buffer) {
-var strBase64 =
Windows.Security.Cryptography.CryptographicBuffer.encodeToBase64String(buffer);
-var imageData = "data:" + file.contentType +
";base64," + strBase64;
-var image = new Image();
-image.src = imageData;
-image.onload = function() {
-var imageWidth = targetWidth,
-imageHeight = targetHeight;
-var canvas = document.createElement('canvas');
-
-canvas.width = imageWidth;
-canvas.height = imageHeight;
-canvas.getContext("2d").drawImage(this, 0, 0,
imageWidth, imageHeight);
-
-var fileContent =
canvas.toDataURL(file.contentType).split(',')[1];
-
-var storageFolder =
Windows.Storage.ApplicationData.current.localFolder;
+if (sourceType != Camera.PictureSourceType.CAMERA) {
+takePictureFromFile(successCallback, errorCallback, args);
+} else {
+takePictureFromCamera(successCallback, errorCallback, args);
+}
+}
+};
-storageFolder.createFileAsync(tempPhotoFileName,
Windows.Storage.CreationCollisionOption.generateUniqueName).done(function
(storagefile) {
-var content =
Windows.Security.Cryptography.CryptographicBuffer.decodeFromBase64String(fileContent);
-
Windows.Storage.FileIO.writeBufferAsync(storagefile, content).then(function () {
-successCallback("ms-appdata:///local/" +
storagefile.name);
-}, function () {
-errorCallback("Resize picture error.");
-});
-});
-};
-});
-}, function () {
-errorCallback("Can't access localStorage folder");
-});
-};
+// Resize method
+function resizeImage(successCallback, errorCallback, file, targetWidth,
targetHeight, encodingType) {
--- End diff --
I'll make this change in a separate commit I think.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
RE: Cordova Monthly Hangouts - April Edition
Bumping this thread up one last time. Will close the results for the hangout, and send out a date later today PST. -Original Message- From: Parashuram N (MS OPEN TECH) [mailto:panar...@microsoft.com] Sent: Thursday, April 2, 2015 3:04 PM To: dev@cordova.apache.org Subject: Cordova Monthly Hangouts - April Edition Wanted to bump up the thread about Cordova hangouts. We have 10 responses so far. I plan to close the poll early tomorrow morning so that we have enough time to schedule the hangout and folks can make it. If you have not yet responded to the time, please add your preference here http://doodle.com/kydhnyzzwge92hsu - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8043 CB-6462 CB-6105 Refactor orienta...
Github user mmrko commented on the pull request: https://github.com/apache/cordova-lib/pull/128#issuecomment-89337363 Okay, makes sense. Thanks! I'll look into this over the weekend. Or, if you find the time feel free to put up a PR for this :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8043 CB-6462 CB-6105 Refactor orienta...
Github user VincentFTS commented on the pull request: https://github.com/apache/cordova-lib/pull/128#issuecomment-89336760 Yes I do, same issue. I've just seen that in the plist file, man can find the UISupportedInterfaceOrientations~ipad key which correspond to the UISupportedInterfaceOrientations for iPad. Maybe cordova should modify both. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8043 CB-6462 CB-6105 Refactor orienta...
Github user mmrko commented on the pull request: https://github.com/apache/cordova-lib/pull/128#issuecomment-89336092 Thanks for reporting this @VincentFTS. Doesn't seem to work for me either using the iOS Simulator. Have you tested this on a device? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: plugins, npm, and package.json …other art
Brian now that I see this, your twitter stream on the topic makes sense now (uff bundler) I was not aware they were already this far hitting plugin wall, it didn't took too much time :-) I'm guessing that the nativescript looks more similar to cordova (i.e. talking about "platforms" to refer to ios and android), maybe the some guys from telerik that work on cordova are also helping out with nativescript. At least here is my thoughts and even before looking at they were doing, here at IBM we we hitting the problem about sharing native ios libraries between plugins, and these libraries we are releasing as cocoapods [1] where we are going to have a couple of cordova plugins, but these plugins depend on some common cocoapods libraries. So we don't want to ship the same cocoapod multiple times for each cordova plugin. The same goes with Android to not ship same libraries in multiple libraries, and instead add the dependencies in gradle.build to fetch them - Move plugins.xml to package.json (keeping some backwards compatibility for a while) - Leverage npm to host, find, download, cache, install* - Plugins like they also realize, can only have one level of nesting - Package.json (i.e. plugin.xml) to support declared dependencies for gradle, pods, etc... similar to the proposed by nativescript package.json - Leverage/delegate as much as possible on pod (as tool, or library) to deal with ios libraries/frameworks including when two plugins depend on the same pod with conflicting versions, maybe also create podspec on the fly when plugin includes native code in source code format, or like Shaz proposed create a framework on the fly, regardless a podspec can be created for a local set of source code and/or frameworks. I'm not 100% in favor or frameworks as I like the openess of having the power to debug and put brakepoints on others code. Most of the cocoapods I have dealt are release as source where the source is also in github. easy to debug a open source library. - I like the idea from nativescript to have Info.plist and AndroidManifest.xml as portions to merge for the given plugin Sorry for all the noise :-( on this emai [1]: http://cocoapods.org/?q=IMF On Fri, Apr 3, 2015 at 5:05 AM, tommy-carlos williams wrote: > I guess that’s because Android hasn’t been released. Maybe they feel they > can’t reveal much about it yet :( > > -- > tommy-carlos williams > > On 3 April 2015 at 17:41:51, Jesse (purplecabb...@gmail.com) wrote: > > Yeah, the more I look at these, the more overlap I see. > I am surprised how narrowly scoped the react discussion is. iOS only? Is > Android not even on their radar? > > @purplecabbage > risingj.com > > On Thu, Apr 2, 2015 at 5:51 PM, Brian LeRoux wrote: > > > both reactnative [1] and nativescript [2] treading into the territory > > > > fleeting hope we could share work/code but probably good everyone does a > > bit of homework on the topic > > > > [1] https://github.com/facebook/react-native/issues/235 > > [2] https://github.com/NativeScript/NativeScript/issues/25 > > > -- Carlos Santana
[GitHub] cordova-lib pull request: CB-8043 CB-6462 CB-6105 Refactor orienta...
Github user VincentFTS commented on the pull request: https://github.com/apache/cordova-lib/pull/128#issuecomment-89316079 Hello, I'm using cordova 4.3.0 and I can't get orientation lock working on ipad. What am I missing ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: 3.7.x
GitHub user shufanshijie opened a pull request: https://github.com/apache/cordova-android/pull/172 3.7.x You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/cordova-android 3.7.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/172.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #172 commit 3e07f26bc40d4ab4d484ebbfe335995e448b5443 Author: Joe Bowser Date: 2015-01-12T22:55:48Z Update JS snapshot to version 3.7.0 (via coho) commit 7320ce8ea75ad65b35824eae60ba1d75a5bf35a0 Author: Joe Bowser Date: 2015-01-12T22:55:48Z Set VERSION to 3.7.0 (via coho) commit 72e947e5c73398c723b52baf2ad6182fe831798d Author: Murat Sutunc Date: 2015-01-13T06:54:37Z CB-4914 Fix build whitespace issue commit cfc36140bccf892dad9c275f63144f692e7fd56b Author: Andrew Grieve Date: 2015-01-19T18:42:11Z CB-8280 android: Don't apply SplashScreenDelay when .show() is called explicitly commit 9be110683b31a9ce491d97386a29d716a3379438 Author: Andrew Grieve Date: 2015-01-19T21:13:48Z CB-8329 Cancel outstanding ActivityResult requests when a new startActivityForResult occurs commit 5538a231a8395a2512743d62785f022fb2711e42 Author: Andrew Grieve Date: 2015-01-19T21:15:25Z CB-8017 Add support for `` for Lollipop Also refactors a bit to remove related special-case code from CordovaActivity commit 1427c13504adce91e091ab6111f380d3273acbd3 Author: Andrew Grieve Date: 2015-01-20T02:49:36Z Allow `--ant`, `--gradle` for `cordova/run` commit 7375154228f96671fc3af9df2f7ad80c08518103 Author: Andrew Grieve Date: 2015-01-20T02:50:14Z Fix exception for unknown flag in `cordova/run` commit 8c14e33bb62f415c4d9eda78dcd1b71a1f7d909f Author: Andrew Grieve Date: 2015-01-20T02:51:57Z Fix `cordova/run` not finding apk when multi-arch is specified but only arch-independent apk exists commit 1f735935b9730814a64206afa29ecb47f06bd843 Author: Andrew Grieve Date: 2015-01-20T02:53:08Z Fix `cordova/build` not printing out all gradle args in console message commit 33614d12731caa631e80567c04a5886d4d7986c5 Author: Andrew Grieve Date: 2015-01-20T02:54:29Z CB-8255 Fix `cordova/build --gradleVar=--foo=bar` stripping off `=bar` commit cf0fdf5ac02723fac99e9157ae9768c4a70b951f Author: Andrew Grieve Date: 2015-01-20T02:56:46Z CB-8255 Pass `arch` to gradle regardless of `cdvBuildMultipleApks` This also pushes the "which target to build" logic into gradle, since build.js doesn't actually know the value of `cdvBuildMultipleApks`. commit 6b3ef117156e1ae8dacc55fbdbc8366de0dff211 Author: Andrew Grieve Date: 2015-01-20T02:59:02Z Adds `cdvPrintProps` gradle task: dumps out all cdv properties Useful for debugging. commit e4e04927b6f0617c58a81f32cda60c1ab44bd808 Author: sgrebnov Date: 2015-01-16T10:04:01Z CB-8201 Add support for auth dialogs into Cordova Android commit 26f0401fdae333098ccd409d01a96c9692700387 Author: Marcus Pridham Date: 2015-01-16T19:48:19Z CB-8328 Allow plugins to handle certificate challenges (close #150) This is a new API for Lollipop commit 050dd088cf589d5a81ac7a62563cc77e59ad8dc5 Author: Andrew Grieve Date: 2015-01-20T15:49:19Z gradle: Fix incorrect buildTools dependencies in framework's build.gradle (although it didn't seem to hurt anything?) commit 9514a3ed94a36d9a313857ae6efe77312040dad2 Author: Andrew Grieve Date: 2015-01-20T16:03:26Z Move cordova.gradle from project template to CordovaLib Make it easier to share with tests project. Also, one less file in the project template is a good thing. commit c3bdebdb83c67f7eaefeb798ab1679629622e6e8 Author: Andrew Grieve Date: 2015-01-20T16:33:55Z CB-8026 Remove default target value from gradle file Wasn't being used anyways, and it still referenced android-19 This also switches to using a Properties object rather than a RegEx for parsing project.properties commit d7fc37d365f066b22ebe5dc37eccf3a6e8323206 Author: shingotoda Date: 2015-01-16T06:40:54Z CB-8317 Make it work to load about:blank and to dispatch exit message (close #149) commit f3885692d9c4138d3547d5071de7db9a81d1b733 Author: Joe Bowser Date: 2015-01-20T18:23:08Z Updating RELASENOTES.md, this is in a weird spot, since you need the branch to exist to generate the notes commit 2829ed77ccd19f277e9234566eed304fbeeb3851 Author: Andrew Grieve Date: 2015-02-03T21:00:56Z CB-8411 Initialize plugins only after createViews() is called commit c5ffdff49b1ceb44a6dbd21e7e0f1056378f8c10 Author: Andrew Grieve Date: 2015-02-03T19:47:42Z Prune 3.7.0 RELEASENOTES to a more glanceable list commit 3bc755de7c8cea8bfeaa0cfa73a1c4ad611e13d2 Author: Andrew Grieve Date
RE: Add Windows on OSX system fails in cordova 4.3 (window 3.8)
Fantastic! Thanks. Jeff Burtoft * Developer Experience * Web Apps -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, April 2, 2015 12:21 PM To: dev@cordova.apache.org Subject: Re: Add Windows on OSX system fails in cordova 4.3 (window 3.8) Cool. Will start a discuss thread for 3.8.1. Agreed we need to do a tools release very soon. Lots of changes in the next one. On Wed, Apr 1, 2015 at 9:25 PM, Parashuram N (MS OPEN TECH) < panar...@microsoft.com> wrote: > +1 to start a 3.8.1 > > We will also have a bunch of platforms that would have released, so we > could do a CLI release too. > > On 4/1/15, 2:40 PM, "Jesse" wrote: > > >Might as well start a 3.8.1 release for this, I think it is worth it. > > > >@purplecabbage > >risingj.com > > > >On Wed, Apr 1, 2015 at 2:29 PM, Sergey Grebnov (Akvelon) < > >v-seg...@microsoft.com> wrote: > > > >> Just tried and confirm this has been fixed in master after release. > >> > >> -Sergey > >> -Original Message- > >> From: Sergey Grebnov (Akvelon) > >> Sent: Wednesday, April 1, 2015 10:53 PM > >> To: dev@cordova.apache.org > >> Subject: RE: Add Windows on OSX system fails in cordova 4.3 (window > >> 3.8) > >> > >> Hi Jeff, > >> > >> I think this was fixed after release: > >> > >> > >> > https://github.com/apache/cordova-windows/commit/030be05e7fc83408bcf5a > 74f > >>05ab7a0a6ca335aa > >> > >> I'll be able to try and report back later today, but if you want > >> try it > >> yourself: > >> >cordova platform add https://github.com/apache/cordova-windows.git > >> > >> -Sergey > >> -Original Message- > >> From: Jeff Burtoft [mailto:jeffb...@microsoft.com] > >> Sent: Wednesday, April 1, 2015 8:43 PM > >> To: dev@cordova.apache.org > >> Subject: Add Windows on OSX system fails in cordova 4.3 (window > >> 3.8) > >> > >> Hi, > >> Is anyone else having a problem adding Windows platform on an OSX > >>machine > >> > >> > >> > >> > >> > >> Rupert:WATDocs fernando$ cordova platform add windows > >> > >> WARNING: Applications for platform windows can not be built on this > >> OS - darwin. > >> > >> Adding windows project... > >> > >> Error: > >> > >>/Users/fernando/.cordova/lib/npm_cache/cordova-windows/3.8.0/package > >>/bin/ > >>create: > >> Command failed with exit code EACCES > >> > >> at ChildProcess.whenDone > >> > >>(/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/co > >>rdova > >>/superspawn.js:131:23) > >> > >> at ChildProcess.emit (events.js:95:17) > >> > >> at Process.ChildProcess._handle.onexit > >> (child_process.js:818:12) > >> > >> > >> > >> I'm not trying to build it, only create the package. Am I doing > >>something wrong or is this a bug? > >> > >> Thanks, > >> Jeff > >> > >> > >> Jeff Burtoft * Developer Experience * Web Apps > >> > >> > >> --- > >> -- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > >> For additional commands, e-mail: dev-h...@cordova.apache.org > >> > >> > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: catch and ignore OutOfMemoryEr...
Github user kworam commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/3#issuecomment-89294298 Thanks for closing the pull request on my behalf agrieve, I got distracted and forgot all about this for a while. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-wp8/pull/79#issuecomment-89258100 :+1: lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: plugins, npm, and package.json …other art
I guess that’s because Android hasn’t been released. Maybe they feel they can’t reveal much about it yet :( -- tommy-carlos williams On 3 April 2015 at 17:41:51, Jesse (purplecabb...@gmail.com) wrote: Yeah, the more I look at these, the more overlap I see. I am surprised how narrowly scoped the react discussion is. iOS only? Is Android not even on their radar? @purplecabbage risingj.com On Thu, Apr 2, 2015 at 5:51 PM, Brian LeRoux wrote: > both reactnative [1] and nativescript [2] treading into the territory > > fleeting hope we could share work/code but probably good everyone does a > bit of homework on the topic > > [1] https://github.com/facebook/react-native/issues/235 > [2] https://github.com/NativeScript/NativeScript/issues/25 >
[GitHub] cordova-wp8 pull request: Added Newtonsoft json dll
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-wp8/pull/79 Added Newtonsoft json dll Included license files, and meta. You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-wp8 NewtonsoftJson-DLL Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-wp8/pull/79.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #79 commit 418e51ea4f6c6cb644f18f0660efdd8b058644a5 Author: Brett Rudd Date: 2015-04-02T00:00:20Z Move to Newstonsoft.JSON for JSON serialisation commit b7c17b2f60ccc63f30f84645ba882996c69f4793 Author: Jesse MacFadyen Date: 2015-04-03T08:10:28Z add meta commit aed59ff8b18a93db9a20cb937615f23bbd070169 Author: Jesse MacFadyen Date: 2015-04-03T08:23:14Z Add Newtonsoft license files --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8791 Recognize UAP as a valid TargetP...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/201 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: plugins, npm, and package.json ...other art
thanks for sharing Brian. I posted the nativescript one in the whitelist release vote thread a few days ago. Not the most visible place. I really like the nativescript proposal. Specifically the engine tag to manage versions of supported platforms and how they are proposing to handle platform configuration (json transformation + separate configuration files that get merged in). I also like how they are giving each platform a dependency manager instead of relying on npm for dependency management. The current npm dependency system won't work for our plugins. Peer dependencies have been turned into warnings instead of installing the plugin as a sibling. If we nest dependencies, we will start seeing problems of two different versions of one plugin being installed. Causing all sorts of havoc. On Thu, Apr 2, 2015 at 11:39 PM, Jesse wrote: > Yeah, the more I look at these, the more overlap I see. > I am surprised how narrowly scoped the react discussion is. iOS only? Is > Android not even on their radar? > > @purplecabbage > risingj.com > > On Thu, Apr 2, 2015 at 5:51 PM, Brian LeRoux wrote: > > > both reactnative [1] and nativescript [2] treading into the territory > > > > fleeting hope we could share work/code but probably good everyone does a > > bit of homework on the topic > > > > [1] https://github.com/facebook/react-native/issues/235 > > [2] https://github.com/NativeScript/NativeScript/issues/25 > > >
