[GitHub] cordova-lib pull request: The concat() method returns a new array.
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/216#issuecomment-101574980 This should probably also use __.uniq Instead of the double loop, or __.union --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: solves CB-8804 https://github....
Any chance this PR https://github.com/apache/cordova-plugin-camera/pull/83 https://github.com/apache/cordova-plugin-camera/pull/83 could get merged in? regards Serge a.k.a: thehuijb signature.asc Description: Message signed with OpenPGP using GPGMail
[GitHub] cordova-lib pull request: The concat() method returns a new array.
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/216#issuecomment-101572757 +1 'concat does not alter this or any of the arrays ... ' https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/concat --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: fix wp8.1 UI, added wp8.1 focu...
Github user Gillardo commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/77#issuecomment-101711464 Found an issue though that if you zoom in, then the buttons disappear and you cannot take the photo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Cordova 5.0 user feedback - move to npm whitelist plugin
Ah interesting. Where is the default config.xml actually defined? I assume it is baked in and a user can't change the default used? On Tue, May 12, 2015 at 11:02 AM, Andrew Grieve agri...@chromium.org wrote: if you use --copy-from and the template doesn't already have a config.xml, then the default config.xml will be used. I wouldn't expect what you describe if your template already had a config.xml On Tue, May 12, 2015 at 10:46 AM, Raymond Camden raymondcam...@gmail.com wrote: So query - I thought the whitelist plugin was being added because it was in the default Cordova sample config.xml - but when I built a new project and used --copy-from, it *also* installed the plugin. So is it just *always* added? On Tue, May 12, 2015 at 9:21 AM, Andrew Grieve agri...@chromium.org wrote: On Mon, May 11, 2015 at 1:56 PM, Nikhil Khandelwal nikhi...@microsoft.com wrote: Responses inline. -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, May 7, 2015 6:17 PM To: dev@cordova.apache.org Subject: Re: Cordova 5.0 user feedback - move to npm whitelist plugin (1) older versions of our docs point to plugins.cordova.io for plugin documentation. We haven't pointed people to github for plugin docs. Those docs are accurate with the ID of the plugin. Adding a section to the readme about needing cordova 5+ isn't a bad idea. [NK] There are places that this is not true. http://cordova.apache.org/docs/en/4.0.0/guide_support_index.md.html#Platform%20Support . The plan is to switch our tools to grab from npm first and CPR second. I believe we discussed doing this around the time CPR goes read only. Giving IDE's and people using older versions a chance to upgrade. We can publish updated plugins to CPR, but it is going to be quite a bit of work. I created old-id branches for our core plugins that revert the commits changing the ID and the commits where I change internal plugin references from org.apache.cordova.* to cordova-plugin-*. It was a fairly large change. The reason for the major jump was the plugin id change. I'd recommend them sticking the versioning they are on instead of copying the version of the npm series. The major version bump wasn't due to a change in functionality in the plugins themselves. If we want to release updated plugins to CPR, someone will need to do the work to cherry-pick the new commits into old-id and do a separate vote for them. [NK] I understand this is a lot of work. Alternatlively, shall we change the behavior of the CLI to use npm first - even for old ids - perhaps, as part of 5.1 tools release? There is not much value in old Ids causing stale, old version of plugin getting downloaded from CPR. (2) It is a fairly recent change. Any new app made with cordova-cli 5+ will auto include the whitelist plugin due to the hello world config.xml including it as a dependency. I think we need to document it more and make more noise within the community about it. iOS 4.0 will also require the whitelist plugin when it gets released. The more prepared we are, the better. As for re-enabling network access by default, I wasn't really part of the original thread so I will leave it to the people who were to discuss that further. [NK] I agree that making more noise is the right short term move to help people upgrading to 5.0 realize this. I still believe that network access should be enabled in the platform by default without any plugins. For controlling network access, devs should either use CSP or a whitelist plugin that gets the chance to override the networking behavior. Andrew, Michael, and Ian are most familiar with the decision around this. http://markmail.org/search/?q=Android%27s+new+Whitelist+Plugins#query:Android%27s%20new%20Whitelist%20Plugins+page:1+mid:z2r2sj5e3kvrnqv6+state:results Additionally, on prepare, platforms should see the use of access tags and encourage users to use one of the whitelist plugins if they have not already done so. I agree that needing the new whitelist plugin to make network calls is unfortunate. I know Ian really wanted everything to secure by default, and having network access via a plugin means you can update the plugin separately if there are bugs. I think it might be a bit late to change things now though. Better to just stick with it rather than changing things again and again. On Thu, May 7, 2015 at 8:55 AM, Nikhil Khandelwal nikhi...@microsoft.com wrote: There is a bunch of confusion with Cordova 5.0 users because of these two changes: 1. Move to npm for plugins (There have been multiple PRs trying to update plugin docs to reference the old id instead of the new one - because people are still using the old version of the CLI) 2. No network access in Android 4.0 without whitelist plugin: -
Re: Cordova 5.0 user feedback - move to npm whitelist plugin
It's here: cordova-lib/cordova-lib/node_modules/cordova-app-hello-world/config.xml A use can change the defaults by providing a config.xml within their own template (--copy-from target) On Wed, May 13, 2015 at 10:51 AM, Raymond Camden raymondcam...@gmail.com wrote: Ah interesting. Where is the default config.xml actually defined? I assume it is baked in and a user can't change the default used? On Tue, May 12, 2015 at 11:02 AM, Andrew Grieve agri...@chromium.org wrote: if you use --copy-from and the template doesn't already have a config.xml, then the default config.xml will be used. I wouldn't expect what you describe if your template already had a config.xml On Tue, May 12, 2015 at 10:46 AM, Raymond Camden raymondcam...@gmail.com wrote: So query - I thought the whitelist plugin was being added because it was in the default Cordova sample config.xml - but when I built a new project and used --copy-from, it *also* installed the plugin. So is it just *always* added? On Tue, May 12, 2015 at 9:21 AM, Andrew Grieve agri...@chromium.org wrote: On Mon, May 11, 2015 at 1:56 PM, Nikhil Khandelwal nikhi...@microsoft.com wrote: Responses inline. -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, May 7, 2015 6:17 PM To: dev@cordova.apache.org Subject: Re: Cordova 5.0 user feedback - move to npm whitelist plugin (1) older versions of our docs point to plugins.cordova.io for plugin documentation. We haven't pointed people to github for plugin docs. Those docs are accurate with the ID of the plugin. Adding a section to the readme about needing cordova 5+ isn't a bad idea. [NK] There are places that this is not true. http://cordova.apache.org/docs/en/4.0.0/guide_support_index.md.html#Platform%20Support . The plan is to switch our tools to grab from npm first and CPR second. I believe we discussed doing this around the time CPR goes read only. Giving IDE's and people using older versions a chance to upgrade. We can publish updated plugins to CPR, but it is going to be quite a bit of work. I created old-id branches for our core plugins that revert the commits changing the ID and the commits where I change internal plugin references from org.apache.cordova.* to cordova-plugin-*. It was a fairly large change. The reason for the major jump was the plugin id change. I'd recommend them sticking the versioning they are on instead of copying the version of the npm series. The major version bump wasn't due to a change in functionality in the plugins themselves. If we want to release updated plugins to CPR, someone will need to do the work to cherry-pick the new commits into old-id and do a separate vote for them. [NK] I understand this is a lot of work. Alternatlively, shall we change the behavior of the CLI to use npm first - even for old ids - perhaps, as part of 5.1 tools release? There is not much value in old Ids causing stale, old version of plugin getting downloaded from CPR. (2) It is a fairly recent change. Any new app made with cordova-cli 5+ will auto include the whitelist plugin due to the hello world config.xml including it as a dependency. I think we need to document it more and make more noise within the community about it. iOS 4.0 will also require the whitelist plugin when it gets released. The more prepared we are, the better. As for re-enabling network access by default, I wasn't really part of the original thread so I will leave it to the people who were to discuss that further. [NK] I agree that making more noise is the right short term move to help people upgrading to 5.0 realize this. I still believe that network access should be enabled in the platform by default without any plugins. For controlling network access, devs should either use CSP or a whitelist plugin that gets the chance to override the networking behavior. Andrew, Michael, and Ian are most familiar with the decision around this. http://markmail.org/search/?q=Android%27s+new+Whitelist+Plugins#query:Android%27s%20new%20Whitelist%20Plugins+page:1+mid:z2r2sj5e3kvrnqv6+state:results Additionally, on prepare, platforms should see the use of access tags and encourage users to use one of the whitelist plugins if they have not already done so. I agree that needing the new whitelist plugin to make network calls is unfortunate. I know Ian really wanted everything to secure by default, and having network access via a plugin means you can update the plugin separately if there are bugs. I think it might be a bit late to change things now though. Better to just stick with it rather than changing things again and again. On Thu, May 7, 2015 at 8:55 AM, Nikhil Khandelwal
[GitHub] cordova-windows pull request: CB-9015: Merge windows10 support to ...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/76 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-8879 fix stripe issue with ...
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/94#discussion_r30262108
--- Diff: src/windows/CameraProxy.js ---
@@ -337,28 +336,48 @@ function takePictureFromCameraWP(successCallback,
errorCallback, args) {
}
});
-capture.initializeAsync(captureSettings).done(function () {
-//
msdn.microsoft.com/en-us/library/windows/apps/hh452807.aspx
-capturePreview.msZoom = true;
-capturePreview.src = URL.createObjectURL(capture);
-capturePreview.play();
+captureSettings.photoCaptureSource =
Windows.Media.Capture.PhotoCaptureSource.photo;
-// Insert preview frame and controls into page
-document.body.appendChild(capturePreview);
-document.body.appendChild(captureCancelButton);
+return capture.initializeAsync(captureSettings);
+}).then(function () {
+// msdn.microsoft.com/en-us/library/windows/apps/hh452807.aspx
+capturePreview.msZoom = true;
+capturePreview.src = URL.createObjectURL(capture);
+capturePreview.play();
-// Bind events to controls
-window.addEventListener('deviceorientation',
cameraPreviewOrientation, false);
-capturePreview.addEventListener('click', captureAction);
-captureCancelButton.addEventListener('click', function () {
-destroyCameraPreview();
-errorCallback('Cancelled');
-}, false);
-}, function (err) {
+// Insert preview frame and controls into page
+document.body.appendChild(capturePreview);
+document.body.appendChild(captureCancelButton);
+
+// Bind events to controls
+window.addEventListener('deviceorientation',
cameraPreviewOrientation, false);
+capturePreview.addEventListener('click', captureAction);
+captureCancelButton.addEventListener('click', function () {
destroyCameraPreview();
-errorCallback('Camera intitialization error ' + err);
-});
-}, errorCallback);
+errorCallback('Cancelled');
+}, false);
+
+// Get available aspect ratios
+var aspectRatios = getAspectRatios(capture);
+
+// Couldn't find a good ratio
+if (aspectRatios.length === 0) {
+destroyCameraPreview();
+errorCallback('There\'s not a good aspect ratio
available');
+return;
+}
+
+// Default aspect ratio 1.78 (16:9 hd video standard)
+if (aspectRatios.indexOf(1.8) -1) {
--- End diff --
i need to add jshint later to this repo
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-8879 fix stripe issue with ...
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/94#discussion_r30262317
--- Diff: src/windows/CameraProxy.js ---
@@ -438,6 +457,61 @@ function takePictureFromCameraWP(successCallback,
errorCallback, args) {
});
};
+var getAspectRatios = function (capture) {
+var photoAspectRatios =
capture.videoDeviceController.getAvailableMediaStreamProperties(Windows.Media.Capture.MediaStreamType.photo).map(function
(element) {
+return (element.width / element.height).toFixed(1);
+}).filter(function (element, index, array) { if (index ===
array.indexOf(element)) return 1; return 0; });
+
+var videoAspectRatios =
capture.videoDeviceController.getAvailableMediaStreamProperties(Windows.Media.Capture.MediaStreamType.videoRecord).map(function
(element) {
+return (element.width / element.height).toFixed(1);
+}).filter(function (element, index, array) { if (index ===
array.indexOf(element)) return 1; return 0; });
+
+var videoPreviewAspectRatios =
capture.videoDeviceController.getAvailableMediaStreamProperties(Windows.Media.Capture.MediaStreamType.videoPreview).map(function
(element) {
+return (element.width / element.height).toFixed(1);
+}).filter(function (element, index, array) { if (index ===
array.indexOf(element)) return 1; return 0; });
+
+var allAspectRatios = [].concat(photoAspectRatios,
videoAspectRatios, videoPreviewAspectRatios);
+
+var aspectObj = allAspectRatios.reduce(function (map, item) {
+if (!map[item]) {
+map[item] = 0;
+}
+map[item]++;
+return map;
+}, {});
+
+return Object.keys(aspectObj).filter(function (k) {
+return aspectObj[k] === 3;
--- End diff --
this is by design. all of the capture modes should be set to the same ratio
otherwise there are artifacts on the captured image. this is a platform
limitation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: CB-8987: Support for save an...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/62 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: plugins.cordova.io
Good idea. Maybe also file an issue under the 'cordova-registry-web' component On Wed, May 13, 2015 at 12:42 PM, Josh Soref jso...@blackberry.com wrote: I think it'd be helpful if plugins.cordova.io included a banner informing people that it's going away. Preferably w/ a link to something explaining the transition plan+schedule. - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-8879 fix stripe issue with ...
Github user muratsu closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/94 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9015: Merge windows10 support to ...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/76#issuecomment-101816672 Looks good to me too! +1 to merge. I am not yet completely setup to test win10, so I am taking some things on faith, but looking over the code it all looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101816514 Is this required for development time experience or every app needs access to localhost port 8472 to run on the phone? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
Github user jsoref commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101817138 It's required for runtime if an app (running on BlackBerry 10) has any plugins. The app doesn't actually talk to port 8472, it's just magically intercepted. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Cordova-Windows Release
Rob, I am looking through it now and will get back to you later today. I'll start a new thread on it too. Cheers, Jesse @purplecabbage risingj.com On Tue, May 12, 2015 at 1:59 PM, Rob Paveza rob.pav...@microsoft.com wrote: Jesse, where have we landed on the issue of the local-notifications plugin change? It seems to me that whatever change we make isn't particularly relevant to other platforms. Since Windows Cordova apps are entirely in JS, the solution has to be in JS. Why focus on it being an event-based change, instead of a persistent property? From the app developer perspective, the additional event is entirely duplicative (from an API perspective), but the new event you proposed never fires for Android or iOS until it gets implemented. What I had proposed (cordova.env) is just empty on those environments until it got implemented. -Original Message- From: Jesse [mailto:purplecabb...@gmail.com] Sent: Tuesday, May 12, 2015 11:49 AM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Cordova-Windows Release +1 The less branches we maintain the better. @purplecabbage risingj.com On Tue, May 12, 2015 at 11:44 AM, Parashuram N (MS OPEN TECH) panar...@microsoft.com wrote: +1 to merging Cordova-windows10 in master. I don't think it breaks anything existing, and windows10 support seems to be enabled only via flags or cli args. I think merging it into master will make developing windows 10 easier. -Original Message- From: Rob Paveza [mailto:rob.pav...@microsoft.com] Sent: Tuesday, May 12, 2015 11:39 AM To: dev@cordova.apache.org Subject: [DISCUSS] Cordova-Windows Release Does anyone have a reason to delay a cordova-windows platform release? Any outstanding patches to land? I'm looking to merge Windows 10 support into main and release 4.0.0. If not, I will start a release tomorrow. Thanks, -Rob - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-10142 9782 Problem: As is, today, Cordova projects created w/ the default cordova hello-world template which have any plugins won't work on BlackBerry 10 at-all My fix is to add a CSP whitelist for the BlackBerry 10 magic port... Steve Gill commented on the pull request: As long as this doesn't negatively impact other platforms, merge away. The only downside is that if someone manages to have another application running on that port on a non blackberry platform, and if someone writes a buggy application which can be taken over, then that buggy application could talk to the other application w/ that port on that non blackberry platform it's pretty obscure, but... Are people OK with this? The section we're changing has a bunch of platform specific notes, it seems like it's really asking for a pre-processor of some sort to magically stitch up this field... Does anyone have an alternative proposal? If not, I'm planning to merge my PR on Monday. smime.p7s Description: S/MIME cryptographic signature
Re: [DISCUSS] Dropping the -dev suffix
I think -dev is working fine and doing what it's supposed to do. The logic
of -label is subtle:
var sem = require('semver')
undefined
sem.satisfies('4.0.0-dev', '=4.0.0')
false
sem.satisfies('4.0.0-dev', '=4.0')
true
So, the engine check should just to =4.0, or =4.0.0-dev
On Wed, May 13, 2015 at 1:39 PM, So, Byoungro byoungro...@intel.com wrote:
Sorry, I got the other way around. :)
4.0.0-dev is 4.0.0.
Byoungro So
SSG / DPD / Mobile Computing and Compilers
Intel Corporation
-Original Message-
From: So, Byoungro
Sent: Wednesday, May 13, 2015 10:37 AM
To: dev@cordova.apache.org
Subject: RE: [DISCUSS] Dropping the -dev suffix
Semver should be able to understand '4.0.0-dev' as the valid version
string.
There could be some other requirement problems, like =, .
For example, 4.0.0-dev is 4.0.0.
So, if the requirement is =4.0.0, then the version string '4.0.0-dev'
will fail to satisfy the requirement.
Byoungro So
SSG / DPD / Mobile Computing and Compilers Intel Corporation
-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com]
Sent: Wednesday, May 13, 2015 10:21 AM
To: dev@cordova.apache.org
Subject: [DISCUSS] Dropping the -dev suffix
Recently, a issue (CB-9021) popped up where mobile spec was failing
because the semver check failed on a platform due to `-dev` being in the
version and not valid.
I think we should remove -dev from our versions. Right now, after we do a
release, we add -dev to show that the repo is in development and hasn't
been released. I think we can accomplish the same by just bumping the
version (minor?) in the package.json and just know it isn't released by
seeing what is published on npm.
Thoughts?
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Docs release
Pushed a 5.0.0 for russian docs, updated edge docs for others On Mon, May 11, 2015 at 10:52 AM, Steven Gill stevengil...@gmail.com wrote: Thanks Andrey, I'll regenerate 5.0.0 and push an update later today. -Steve On Mon, May 11, 2015 at 6:53 AM, Andrey Kurdumov kant2...@googlemail.com wrote: I just finish the translation of main docs to Russian. Changes are here: https://github.com/apache/cordova-docs/pull/286 Do I need copy of docs/ru/edge to docs/ru/5.0.0 or that will be done by someone who publish the website? 2015-04-24 6:30 GMT+06:00 Victor Sosa sosah.vic...@gmail.com: Cool! I'm working on translations right now 2015-04-23 19:22 GMT-05:00 Steven Gill stevengil...@gmail.com: 5.0.0 for docs has been published. We can update it again later once we have translations ready to go. http://docs.cordova.io On Thu, Apr 23, 2015 at 2:50 PM, Victor Sosa sosah.vic...@gmail.com wrote: Hi Andrey. As we chatted on Hangout, I'll update the Russian docs but it'll take some time, please be patient. @Steven: I'll check those changes in other languages (as much as I can) 2015-04-23 13:19 GMT-05:00 Steven Gill stevengil...@gmail.com: I changed all references to org.apache.cordova.* to cordova-plugin-*. Docs look good to publish I think. On Wed, Apr 22, 2015 at 8:31 PM, Andrey Kurdumov kant2...@googlemail.com wrote: Could Viktor or Lisa update all untranslated Russian in CrowdIn. If I understand correclty, they could just use Microsoft translator for that and do that automatically. I have to do that manually, and I don't have cycles to fully translate/proofread language for this release. 2015-04-22 7:43 GMT+06:00 Sergey Grebnov (Akvelon) v-seg...@microsoft.com : I've sent a PR to update platform guides as per discussion in a separate thread; it will be great if we can review and include it to docs release https://github.com/apache/cordova-docs/pull/279 Thx! Sergey -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Tuesday, April 21, 2015 5:49 PM To: dev@cordova.apache.org Subject: [DISCUSS] Docs release I'm going to look into doing this. Any blockers, let me know Don't believe we have to vote on this one. - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org -- Victor Adrian Sosa Herrera IBM Software Engineer Guadalajara, Jalisco -- Victor Adrian Sosa Herrera IBM Software Engineer Guadalajara, Jalisco
plugins.cordova.io
I think it'd be helpful if plugins.cordova.io included a banner informing people that it's going away. Preferably w/ a link to something explaining the transition plan+schedule. smime.p7s Description: S/MIME cryptographic signature
Re: [GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...
Can we use a plugin hook to modify the csp in the bb10 start html page? localhost is not defined on most platforms afaik, so it may be less of an issue. @purplecabbage risingj.com On Wed, May 13, 2015 at 1:00 PM, Josh Soref jso...@blackberry.com wrote: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-10142 9782 Problem: As is, today, Cordova projects created w/ the default cordova hello-world template which have any plugins won't work on BlackBerry 10 at-all My fix is to add a CSP whitelist for the BlackBerry 10 magic port... Steve Gill commented on the pull request: As long as this doesn't negatively impact other platforms, merge away. The only downside is that if someone manages to have another application running on that port on a non blackberry platform, and if someone writes a buggy application which can be taken over, then that buggy application could talk to the other application w/ that port on that non blackberry platform it's pretty obscure, but... Are people OK with this? The section we're changing has a bunch of platform specific notes, it seems like it's really asking for a pre-processor of some sort to magically stitch up this field... Does anyone have an alternative proposal? If not, I'm planning to merge my PR on Monday.
[GitHub] cordova-windows pull request: CB-9015: Merge windows10 support to ...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/76#issuecomment-101816033 LGTM for merge! @purplecabbage for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Dropping the -dev suffix
It is and it is failing currently. In the file-transfer plugin [1]
engine name=cordova-wp8 version==4.0.0/
...
Failed to install 'cordova-plugin-file-transfer':CordovaError: Plugin
doesn't support this project's cordova-wp8 version. cordova-wp8: 4.0.0-dev,
failed version requirement: 1.0.0
...
which fails in plugman install [2]
On closer inspection, this appears to be an issue with plugman, and not our
use of semver. I'll look more.
[1]
https://github.com/apache/cordova-plugin-file-transfer/blob/master/plugin.xml#L36
[2]
https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/install.js#L108
@purplecabbage
risingj.com
On Wed, May 13, 2015 at 1:33 PM, Andrew Grieve agri...@chromium.org wrote:
I think -dev is working fine and doing what it's supposed to do. The logic
of -label is subtle:
var sem = require('semver')
undefined
sem.satisfies('4.0.0-dev', '=4.0.0')
false
sem.satisfies('4.0.0-dev', '=4.0')
true
So, the engine check should just to =4.0, or =4.0.0-dev
On Wed, May 13, 2015 at 1:39 PM, So, Byoungro byoungro...@intel.com
wrote:
Sorry, I got the other way around. :)
4.0.0-dev is 4.0.0.
Byoungro So
SSG / DPD / Mobile Computing and Compilers
Intel Corporation
-Original Message-
From: So, Byoungro
Sent: Wednesday, May 13, 2015 10:37 AM
To: dev@cordova.apache.org
Subject: RE: [DISCUSS] Dropping the -dev suffix
Semver should be able to understand '4.0.0-dev' as the valid version
string.
There could be some other requirement problems, like =, .
For example, 4.0.0-dev is 4.0.0.
So, if the requirement is =4.0.0, then the version string '4.0.0-dev'
will fail to satisfy the requirement.
Byoungro So
SSG / DPD / Mobile Computing and Compilers Intel Corporation
-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com]
Sent: Wednesday, May 13, 2015 10:21 AM
To: dev@cordova.apache.org
Subject: [DISCUSS] Dropping the -dev suffix
Recently, a issue (CB-9021) popped up where mobile spec was failing
because the semver check failed on a platform due to `-dev` being in the
version and not valid.
I think we should remove -dev from our versions. Right now, after we do a
release, we add -dev to show that the repo is in development and hasn't
been released. I think we can accomplish the same by just bumping the
version (minor?) in the package.json and just know it isn't released by
seeing what is published on npm.
Thoughts?
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request: CB-9016: Added template-packaged WinJS re...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/111 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: plugins.cordova.io
https://issues.apache.org/jira/browse/CB-9026 -Original Message- From: Shazron [mailto:shaz...@gmail.com] Sent: Wednesday, May 13, 2015 4:19 PM To: dev@cordova.apache.org Subject: Re: plugins.cordova.io Good idea. Maybe also file an issue under the 'cordova-registry-web' component On Wed, May 13, 2015 at 12:42 PM, Josh Soref jso...@blackberry.com wrote: I think it'd be helpful if plugins.cordova.io included a banner informing people that it's going away. Preferably w/ a link to something explaining the transition plan+schedule. - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org smime.p7s Description: S/MIME cryptographic signature
Re: [DISCUSS] Dropping the -dev suffix
switching engine to =4.0 (no patch version) seems to make the most sense for this problem. On Wed, May 13, 2015 at 4:21 PM, Jesse purplecabb...@gmail.com wrote: Yes, I just verified the same. Changing the plugin.xml engine to : cordova-wp8 =4.0.0-- will allow install for both wp8@4.0.0 and wp8@4.0.0-dev @purplecabbage risingj.com On Wed, May 13, 2015 at 4:18 PM, Tim Barham tim.bar...@microsoft.com wrote: No, you were correct - any sort of pre-release identifier makes the version less than the version without the pre-release identifier (since it signifies a pre-release). Hence '4.0.0-dev', '4.0.0-alpha', '4.0.0-0.0.1' and '4.0.0-iwishiwasarealreease' are all 4.0.0. It seems to me the problem is with the plugin since it requires cordova-wp8 =4.0.0, and there is no cordova-wp8 release (or yet to be released version on github) that satisfies that requirement. From: So, Byoungro byoungro...@intel.com Sent: Thursday, May 14, 2015 3:39 AM To: dev@cordova.apache.org Subject: RE: [DISCUSS] Dropping the -dev suffix Sorry, I got the other way around. :) 4.0.0-dev is 4.0.0. Byoungro So SSG / DPD / Mobile Computing and Compilers Intel Corporation -Original Message- From: So, Byoungro Sent: Wednesday, May 13, 2015 10:37 AM To: dev@cordova.apache.org Subject: RE: [DISCUSS] Dropping the -dev suffix Semver should be able to understand '4.0.0-dev' as the valid version string. There could be some other requirement problems, like =, . For example, 4.0.0-dev is 4.0.0. So, if the requirement is =4.0.0, then the version string '4.0.0-dev' will fail to satisfy the requirement. Byoungro So SSG / DPD / Mobile Computing and Compilers Intel Corporation -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Wednesday, May 13, 2015 10:21 AM To: dev@cordova.apache.org Subject: [DISCUSS] Dropping the -dev suffix Recently, a issue (CB-9021) popped up where mobile spec was failing because the semver check failed on a platform due to `-dev` being in the version and not valid. I think we should remove -dev from our versions. Right now, after we do a release, we add -dev to show that the repo is in development and hasn't been released. I think we can accomplish the same by just bumping the version (minor?) in the package.json and just know it isn't released by seeing what is published on npm. Thoughts? - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Dropping the -dev suffix
So back to the initial discussion, should we keep our -dev suffixes? If so we need to be sure to use engine tags like '=4.0' or if you specifically want to force a specific min patch, and still allow the dev suffix, you can do '=4.0.0--' And of course this should be documented. @purplecabbage risingj.com On Wed, May 13, 2015 at 4:21 PM, Jesse purplecabb...@gmail.com wrote: Yes, I just verified the same. Changing the plugin.xml engine to : cordova-wp8 =4.0.0-- will allow install for both wp8@4.0.0 and wp8@4.0.0-dev @purplecabbage risingj.com On Wed, May 13, 2015 at 4:18 PM, Tim Barham tim.bar...@microsoft.com wrote: No, you were correct - any sort of pre-release identifier makes the version less than the version without the pre-release identifier (since it signifies a pre-release). Hence '4.0.0-dev', '4.0.0-alpha', '4.0.0-0.0.1' and '4.0.0-iwishiwasarealreease' are all 4.0.0. It seems to me the problem is with the plugin since it requires cordova-wp8 =4.0.0, and there is no cordova-wp8 release (or yet to be released version on github) that satisfies that requirement. From: So, Byoungro byoungro...@intel.com Sent: Thursday, May 14, 2015 3:39 AM To: dev@cordova.apache.org Subject: RE: [DISCUSS] Dropping the -dev suffix Sorry, I got the other way around. :) 4.0.0-dev is 4.0.0. Byoungro So SSG / DPD / Mobile Computing and Compilers Intel Corporation -Original Message- From: So, Byoungro Sent: Wednesday, May 13, 2015 10:37 AM To: dev@cordova.apache.org Subject: RE: [DISCUSS] Dropping the -dev suffix Semver should be able to understand '4.0.0-dev' as the valid version string. There could be some other requirement problems, like =, . For example, 4.0.0-dev is 4.0.0. So, if the requirement is =4.0.0, then the version string '4.0.0-dev' will fail to satisfy the requirement. Byoungro So SSG / DPD / Mobile Computing and Compilers Intel Corporation -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Wednesday, May 13, 2015 10:21 AM To: dev@cordova.apache.org Subject: [DISCUSS] Dropping the -dev suffix Recently, a issue (CB-9021) popped up where mobile spec was failing because the semver check failed on a platform due to `-dev` being in the version and not valid. I think we should remove -dev from our versions. Right now, after we do a release, we add -dev to show that the repo is in development and hasn't been released. I think we can accomplish the same by just bumping the version (minor?) in the package.json and just know it isn't released by seeing what is published on npm. Thoughts? - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Dropping the -dev suffix
No, you were correct - any sort of pre-release identifier makes the version less than the version without the pre-release identifier (since it signifies a pre-release). Hence '4.0.0-dev', '4.0.0-alpha', '4.0.0-0.0.1' and '4.0.0-iwishiwasarealreease' are all 4.0.0. It seems to me the problem is with the plugin since it requires cordova-wp8 =4.0.0, and there is no cordova-wp8 release (or yet to be released version on github) that satisfies that requirement. From: So, Byoungro byoungro...@intel.com Sent: Thursday, May 14, 2015 3:39 AM To: dev@cordova.apache.org Subject: RE: [DISCUSS] Dropping the -dev suffix Sorry, I got the other way around. :) 4.0.0-dev is 4.0.0. Byoungro So SSG / DPD / Mobile Computing and Compilers Intel Corporation -Original Message- From: So, Byoungro Sent: Wednesday, May 13, 2015 10:37 AM To: dev@cordova.apache.org Subject: RE: [DISCUSS] Dropping the -dev suffix Semver should be able to understand '4.0.0-dev' as the valid version string. There could be some other requirement problems, like =, . For example, 4.0.0-dev is 4.0.0. So, if the requirement is =4.0.0, then the version string '4.0.0-dev' will fail to satisfy the requirement. Byoungro So SSG / DPD / Mobile Computing and Compilers Intel Corporation -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Wednesday, May 13, 2015 10:21 AM To: dev@cordova.apache.org Subject: [DISCUSS] Dropping the -dev suffix Recently, a issue (CB-9021) popped up where mobile spec was failing because the semver check failed on a platform due to `-dev` being in the version and not valid. I think we should remove -dev from our versions. Right now, after we do a release, we add -dev to show that the repo is in development and hasn't been released. I think we can accomplish the same by just bumping the version (minor?) in the package.json and just know it isn't released by seeing what is published on npm. Thoughts? - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Dropping the -dev suffix
Yes, I just verified the same. Changing the plugin.xml engine to : cordova-wp8 =4.0.0-- will allow install for both wp8@4.0.0 and wp8@4.0.0-dev @purplecabbage risingj.com On Wed, May 13, 2015 at 4:18 PM, Tim Barham tim.bar...@microsoft.com wrote: No, you were correct - any sort of pre-release identifier makes the version less than the version without the pre-release identifier (since it signifies a pre-release). Hence '4.0.0-dev', '4.0.0-alpha', '4.0.0-0.0.1' and '4.0.0-iwishiwasarealreease' are all 4.0.0. It seems to me the problem is with the plugin since it requires cordova-wp8 =4.0.0, and there is no cordova-wp8 release (or yet to be released version on github) that satisfies that requirement. From: So, Byoungro byoungro...@intel.com Sent: Thursday, May 14, 2015 3:39 AM To: dev@cordova.apache.org Subject: RE: [DISCUSS] Dropping the -dev suffix Sorry, I got the other way around. :) 4.0.0-dev is 4.0.0. Byoungro So SSG / DPD / Mobile Computing and Compilers Intel Corporation -Original Message- From: So, Byoungro Sent: Wednesday, May 13, 2015 10:37 AM To: dev@cordova.apache.org Subject: RE: [DISCUSS] Dropping the -dev suffix Semver should be able to understand '4.0.0-dev' as the valid version string. There could be some other requirement problems, like =, . For example, 4.0.0-dev is 4.0.0. So, if the requirement is =4.0.0, then the version string '4.0.0-dev' will fail to satisfy the requirement. Byoungro So SSG / DPD / Mobile Computing and Compilers Intel Corporation -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Wednesday, May 13, 2015 10:21 AM To: dev@cordova.apache.org Subject: [DISCUSS] Dropping the -dev suffix Recently, a issue (CB-9021) popped up where mobile spec was failing because the semver check failed on a platform due to `-dev` being in the version and not valid. I think we should remove -dev from our versions. Right now, after we do a release, we add -dev to show that the repo is in development and hasn't been released. I think we can accomplish the same by just bumping the version (minor?) in the package.json and just know it isn't released by seeing what is published on npm. Thoughts? - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [CI] WP8 mobilespec failing to get created (CB-9021)
+1 for dropping the suffix - if there is no real good reason for it. I will
make the change to WP8 as it's blocking WP8 CI testing.
Thanks,
Nikhil
-Original Message-
From: Jesse [mailto:purplecabb...@gmail.com]
Sent: Tuesday, May 12, 2015 5:15 PM
To: dev@cordova.apache.org
Subject: Re: [CI] WP8 mobilespec failing to get created (CB-9021)
On the flip side, if we do not update cordova-js with the latest on
its
master, we would have found this bug CB-8996 much later
Yeah, true.
Ultimately I would like to see the entire matrix of possibilities.
cordova-wp8@npm-published-version + cordova-js@master cordova-wp8@master
cordova-wp8@master + cordova-js@master ... multiply by all platforms Some
things we would expect to fail, others not.
I also would prefer we run individual plugin tests, but that gets messy real
fast.
Should the code for cordova-lib be updated to strip out '-dev' suffix?
Yes. I never liked having a version suffix, I never understood why we needed
it. I would prefer we discuss removing it entirely instead of working around
it. Am I missing something?
@purplecabbage
risingj.com
On Tue, May 12, 2015 at 4:44 PM, Nikhil Khandelwal nikhi...@microsoft.com
wrote:
On the flip side, if we do not update cordova-js with the latest on
its master, we would have found this bug
https://issues.apache.org/jira/browse/CB-8996 much later - only when
the cordova.js would have merged to the platform repo - which I
believe happens only around the time of a release?
Here's the real failure:
Failed to install 'cordova-plugin-file-transfer':CordovaError: Plugin
doesn't support this project's cordova-wp8 version. cordova-wp8:
4.0.0-dev, failed version requirement: =4.0.0
Looks like cordova-lib's version comparison using semver, which does
not recognize 'dev' in the version of WP8 and fails:
if ( semver.satisfies(engine.currentVersion,
engine.minVersion) || engine.currentVersion === null ) {
// engine ok!
} else {
var msg = 'Plugin doesn\'t support this project\'s ' +
engine.name + ' version. ' +
engine.name + ': ' + engine.currentVersion +
', failed version requirement: ' + engine.minVersion;
return Q.reject(new CordovaError(msg));
}
Should the code for cordova-lib be updated to strip out '-dev' suffix?
-Nikhil
-Original Message-
From: Jesse [mailto:purplecabb...@gmail.com]
Sent: Tuesday, May 12, 2015 4:30 PM
To: dev@cordova.apache.org
Subject: Re: [CI] WP8 mobilespec failing to get created (CB-9021)
I am not entirely sure what the best approach is, personally I would
just expect it to build with the cordova.js installed by the version.
There is no guarantee that platforms and cordova-js are in sync at any
given time. Maybe we should put this behind a flag and have the CI
run it both with and without ... not sure.
@purplecabbage
risingj.com
On Tue, May 12, 2015 at 3:56 PM, Dmitry Blotsky
dblot...@microsoft.com
wrote:
Mobilespec builds it by design, I think, to use the latest version
of cordova.js. Is that undesired behaviour? We're always using the
master version of cordova-wp8 in periodic CI builds.
Kindly,
Dmitry
On May 12, 2015, at 3:22 PM, Jesse purplecabb...@gmail.com wrote:
What version of cordova-wp8 are you testing?
The failure seems like is doing what it should ...
cordova-wp8@4.0.0 should not be able to install
cordova-plugin-file-transfer@4.0.0
Also, why is createmobilespec always building cordova-js? I would
expect this to sporadically break.
@purplecabbage
risingj.com
On Tue, May 12, 2015 at 2:58 PM, Dmitry Blotsky
dblot...@microsoft.com
wrote:
Hi all,
Mobilespec is failing to get created on WP8 because there is an
issue
with
dependencies in package.json. I’ve created a JIRA:
https://issues.apache.org/jira/browse/CB-9021.
Kindly,
Dmitry
- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-8879 fix stripe issue with ...
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/94#discussion_r30254781
--- Diff: src/windows/CameraProxy.js ---
@@ -337,28 +336,48 @@ function takePictureFromCameraWP(successCallback,
errorCallback, args) {
}
});
-capture.initializeAsync(captureSettings).done(function () {
-//
msdn.microsoft.com/en-us/library/windows/apps/hh452807.aspx
-capturePreview.msZoom = true;
-capturePreview.src = URL.createObjectURL(capture);
-capturePreview.play();
+captureSettings.photoCaptureSource =
Windows.Media.Capture.PhotoCaptureSource.photo;
-// Insert preview frame and controls into page
-document.body.appendChild(capturePreview);
-document.body.appendChild(captureCancelButton);
+return capture.initializeAsync(captureSettings);
+}).then(function () {
+// msdn.microsoft.com/en-us/library/windows/apps/hh452807.aspx
+capturePreview.msZoom = true;
+capturePreview.src = URL.createObjectURL(capture);
+capturePreview.play();
-// Bind events to controls
-window.addEventListener('deviceorientation',
cameraPreviewOrientation, false);
-capturePreview.addEventListener('click', captureAction);
-captureCancelButton.addEventListener('click', function () {
-destroyCameraPreview();
-errorCallback('Cancelled');
-}, false);
-}, function (err) {
+// Insert preview frame and controls into page
+document.body.appendChild(capturePreview);
+document.body.appendChild(captureCancelButton);
+
+// Bind events to controls
+window.addEventListener('deviceorientation',
cameraPreviewOrientation, false);
+capturePreview.addEventListener('click', captureAction);
+captureCancelButton.addEventListener('click', function () {
destroyCameraPreview();
-errorCallback('Camera intitialization error ' + err);
-});
-}, errorCallback);
+errorCallback('Cancelled');
+}, false);
+
+// Get available aspect ratios
+var aspectRatios = getAspectRatios(capture);
+
+// Couldn't find a good ratio
+if (aspectRatios.length === 0) {
+destroyCameraPreview();
+errorCallback('There\'s not a good aspect ratio
available');
+return;
+}
+
+// Default aspect ratio 1.78 (16:9 hd video standard)
+if (aspectRatios.indexOf(1.8) -1) {
--- End diff --
jshint rule violation: should be single quotes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[DISCUSS] Dropping the -dev suffix
Recently, a issue (CB-9021) popped up where mobile spec was failing because the semver check failed on a platform due to `-dev` being in the version and not valid. I think we should remove -dev from our versions. Right now, after we do a release, we add -dev to show that the repo is in development and hasn't been released. I think we can accomplish the same by just bumping the version (minor?) in the package.json and just know it isn't released by seeing what is published on npm. Thoughts?
RE: [DISCUSS] Dropping the -dev suffix
Semver should be able to understand '4.0.0-dev' as the valid version string. There could be some other requirement problems, like =, . For example, 4.0.0-dev is 4.0.0. So, if the requirement is =4.0.0, then the version string '4.0.0-dev' will fail to satisfy the requirement. Byoungro So SSG / DPD / Mobile Computing and Compilers Intel Corporation -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Wednesday, May 13, 2015 10:21 AM To: dev@cordova.apache.org Subject: [DISCUSS] Dropping the -dev suffix Recently, a issue (CB-9021) popped up where mobile spec was failing because the semver check failed on a platform due to `-dev` being in the version and not valid. I think we should remove -dev from our versions. Right now, after we do a release, we add -dev to show that the repo is in development and hasn't been released. I think we can accomplish the same by just bumping the version (minor?) in the package.json and just know it isn't released by seeing what is published on npm. Thoughts? - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [CI] WP8 mobilespec failing to get created (CB-9021)
I will create a new thread for dropping the suffix
On Wed, May 13, 2015 at 9:20 AM, Nikhil Khandelwal nikhi...@microsoft.com
wrote:
+1 for dropping the suffix - if there is no real good reason for it. I
will make the change to WP8 as it's blocking WP8 CI testing.
Thanks,
Nikhil
-Original Message-
From: Jesse [mailto:purplecabb...@gmail.com]
Sent: Tuesday, May 12, 2015 5:15 PM
To: dev@cordova.apache.org
Subject: Re: [CI] WP8 mobilespec failing to get created (CB-9021)
On the flip side, if we do not update cordova-js with the latest on
its
master, we would have found this bug CB-8996 much later
Yeah, true.
Ultimately I would like to see the entire matrix of possibilities.
cordova-wp8@npm-published-version + cordova-js@master cordova-wp8@master
cordova-wp8@master + cordova-js@master ... multiply by all platforms Some
things we would expect to fail, others not.
I also would prefer we run individual plugin tests, but that gets messy
real fast.
Should the code for cordova-lib be updated to strip out '-dev' suffix?
Yes. I never liked having a version suffix, I never understood why we
needed it. I would prefer we discuss removing it entirely instead of
working around it. Am I missing something?
@purplecabbage
risingj.com
On Tue, May 12, 2015 at 4:44 PM, Nikhil Khandelwal nikhi...@microsoft.com
wrote:
On the flip side, if we do not update cordova-js with the latest on
its master, we would have found this bug
https://issues.apache.org/jira/browse/CB-8996 much later - only when
the cordova.js would have merged to the platform repo - which I
believe happens only around the time of a release?
Here's the real failure:
Failed to install 'cordova-plugin-file-transfer':CordovaError: Plugin
doesn't support this project's cordova-wp8 version. cordova-wp8:
4.0.0-dev, failed version requirement: =4.0.0
Looks like cordova-lib's version comparison using semver, which does
not recognize 'dev' in the version of WP8 and fails:
if ( semver.satisfies(engine.currentVersion,
engine.minVersion) || engine.currentVersion === null ) {
// engine ok!
} else {
var msg = 'Plugin doesn\'t support this project\'s ' +
engine.name + ' version. ' +
engine.name + ': ' + engine.currentVersion +
', failed version requirement: ' +
engine.minVersion;
return Q.reject(new CordovaError(msg));
}
Should the code for cordova-lib be updated to strip out '-dev' suffix?
-Nikhil
-Original Message-
From: Jesse [mailto:purplecabb...@gmail.com]
Sent: Tuesday, May 12, 2015 4:30 PM
To: dev@cordova.apache.org
Subject: Re: [CI] WP8 mobilespec failing to get created (CB-9021)
I am not entirely sure what the best approach is, personally I would
just expect it to build with the cordova.js installed by the version.
There is no guarantee that platforms and cordova-js are in sync at any
given time. Maybe we should put this behind a flag and have the CI
run it both with and without ... not sure.
@purplecabbage
risingj.com
On Tue, May 12, 2015 at 3:56 PM, Dmitry Blotsky
dblot...@microsoft.com
wrote:
Mobilespec builds it by design, I think, to use the latest version
of cordova.js. Is that undesired behaviour? We're always using the
master version of cordova-wp8 in periodic CI builds.
Kindly,
Dmitry
On May 12, 2015, at 3:22 PM, Jesse purplecabb...@gmail.com wrote:
What version of cordova-wp8 are you testing?
The failure seems like is doing what it should ...
cordova-wp8@4.0.0 should not be able to install
cordova-plugin-file-transfer@4.0.0
Also, why is createmobilespec always building cordova-js? I would
expect this to sporadically break.
@purplecabbage
risingj.com
On Tue, May 12, 2015 at 2:58 PM, Dmitry Blotsky
dblot...@microsoft.com
wrote:
Hi all,
Mobilespec is failing to get created on WP8 because there is an
issue
with
dependencies in package.json. I've created a JIRA:
https://issues.apache.org/jira/browse/CB-9021.
Kindly,
Dmitry
- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [DISCUSS] Dropping the -dev suffix
Sorry, I got the other way around. :) 4.0.0-dev is 4.0.0. Byoungro So SSG / DPD / Mobile Computing and Compilers Intel Corporation -Original Message- From: So, Byoungro Sent: Wednesday, May 13, 2015 10:37 AM To: dev@cordova.apache.org Subject: RE: [DISCUSS] Dropping the -dev suffix Semver should be able to understand '4.0.0-dev' as the valid version string. There could be some other requirement problems, like =, . For example, 4.0.0-dev is 4.0.0. So, if the requirement is =4.0.0, then the version string '4.0.0-dev' will fail to satisfy the requirement. Byoungro So SSG / DPD / Mobile Computing and Compilers Intel Corporation -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Wednesday, May 13, 2015 10:21 AM To: dev@cordova.apache.org Subject: [DISCUSS] Dropping the -dev suffix Recently, a issue (CB-9021) popped up where mobile spec was failing because the semver check failed on a platform due to `-dev` being in the version and not valid. I think we should remove -dev from our versions. Right now, after we do a release, we add -dev to show that the repo is in development and hasn't been released. I think we can accomplish the same by just bumping the version (minor?) in the package.json and just know it isn't released by seeing what is published on npm. Thoughts? - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-7204 Fixed race condi...
Github user jacobg commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-101761529 Hi @shazron: I'm still getting the same crash from users after applied the latest fix. Any ideas? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [ios-deploy] version 1.6.0 released
If any of you downloaded 1.6.0, sorry -- please download the latest 1.6.1 https://github.com/phonegap/ios-deploy/issues/129 On Tue, May 12, 2015 at 3:39 PM, Shazron shaz...@gmail.com wrote: Release notes: https://github.com/phonegap/ios-deploy/releases/tag/1.6.0 - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: cordova-plugin-background-app
Here we go! https://github.com/MobileChromeApps/cordova-plugin-background-app/tree/master/example-app Also makes use of CLI's ability to store plugins platforms in config.xml :) On Tue, May 5, 2015 at 2:50 PM, Andrew Grieve agri...@chromium.org wrote: Hmm, just have mobile chrome apps' mobilespec equivalent. It'd be worth creating a smaller just-uses-local-notifications-or-alarms app to show it off. I'll try and do that some time this week. On Tue, May 5, 2015 at 11:52 AM, Raymond Camden raymondcam...@gmail.com wrote: Do you have an example appl? On Tue, May 5, 2015 at 10:20 AM, Andrew Grieve agri...@chromium.org wrote: Wanted to draw attention to a new plugin we've created for allowing Android apps to behave as a service on Android (without actually being a service!) https://github.com/MobileChromeApps/cordova-plugin-background-app We use it as part of our chrome.gcm, chrome.notifications, and chrome.alarms plugins. Under-the-hood, it uses less-well-known Android features to have an Activity start without any visual cues, then have it be able to switch to the foreground through task reparenting. Crazy stuff, but nice results :) -- === Raymond Camden, Developer Advocate for MobileFirst at IBM Email : raymondcam...@gmail.com Blog : www.raymondcamden.com Twitter: raymondcamden - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: CB-8987: Support for save an...
Github user robpaveza commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/62#issuecomment-101757332 Ping Can I get a merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: CB-8987: Support for save an...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/62#issuecomment-101766786 LGTM. I'm sure Dooney Evans would approve. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device pull request: Update README.md
Github user deslee closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/33 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: The concat() method returns a new array.
GitHub user 007slm opened a pull request: https://github.com/apache/cordova-lib/pull/216 The concat() method returns a new array. the ios plist file can not add more than one dict CFBundleURLTypes arrays when use cordova plugman add plugin in ios platform. You can merge this pull request into a Git repository by running: $ git pull https://github.com/007slm/cordova-lib master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/216.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #216 commit da243dfaaecb7a83858ea8563ea7f9c9f3fc3563 Author: 007slm 007...@163.com Date: 2015-05-13T07:07:54Z The concat() method returns a new array. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: The concat() method returns a new array.
Github user shazron commented on the pull request: https://github.com/apache/cordova-lib/pull/216#issuecomment-101544132 Can you briefly describe what bug this bug fix solves? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-8879 fix stripe issue with ...
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/94#discussion_r30210499
--- Diff: src/windows/CameraProxy.js ---
@@ -438,6 +457,61 @@ function takePictureFromCameraWP(successCallback,
errorCallback, args) {
});
};
+var getAspectRatios = function (capture) {
+var photoAspectRatios =
capture.videoDeviceController.getAvailableMediaStreamProperties(Windows.Media.Capture.MediaStreamType.photo).map(function
(element) {
+return (element.width / element.height).toFixed(1);
+}).filter(function (element, index, array) { if (index ===
array.indexOf(element)) return 1; return 0; });
+
+var videoAspectRatios =
capture.videoDeviceController.getAvailableMediaStreamProperties(Windows.Media.Capture.MediaStreamType.videoRecord).map(function
(element) {
+return (element.width / element.height).toFixed(1);
+}).filter(function (element, index, array) { if (index ===
array.indexOf(element)) return 1; return 0; });
+
+var videoPreviewAspectRatios =
capture.videoDeviceController.getAvailableMediaStreamProperties(Windows.Media.Capture.MediaStreamType.videoPreview).map(function
(element) {
+return (element.width / element.height).toFixed(1);
+}).filter(function (element, index, array) { if (index ===
array.indexOf(element)) return 1; return 0; });
+
+var allAspectRatios = [].concat(photoAspectRatios,
videoAspectRatios, videoPreviewAspectRatios);
+
+var aspectObj = allAspectRatios.reduce(function (map, item) {
+if (!map[item]) {
+map[item] = 0;
+}
+map[item]++;
+return map;
+}, {});
+
+return Object.keys(aspectObj).filter(function (k) {
+return aspectObj[k] === 3;
+});
+};
+
+var setAspectRatio = function (capture, aspect) {
+// Max photo resolution with desired aspect ratio
+var photoResolution =
capture.videoDeviceController.getAvailableMediaStreamProperties(Windows.Media.Capture.MediaStreamType.photo).filter(function
(elem) {
+return ((elem.width / elem.height).toFixed(1) === aspect) ? 1
: 0;
--- End diff --
nit: `return (elem.width / elem.height).toFixed(1) === aspect)` is
sufficient for filtering, ternary operator is excess.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-8879 fix stripe issue with ...
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/94#discussion_r30210493
--- Diff: src/windows/CameraProxy.js ---
@@ -438,6 +457,61 @@ function takePictureFromCameraWP(successCallback,
errorCallback, args) {
});
};
+var getAspectRatios = function (capture) {
+var photoAspectRatios =
capture.videoDeviceController.getAvailableMediaStreamProperties(Windows.Media.Capture.MediaStreamType.photo).map(function
(element) {
+return (element.width / element.height).toFixed(1);
+}).filter(function (element, index, array) { if (index ===
array.indexOf(element)) return 1; return 0; });
--- End diff --
nit: it should be enough simply return result of comparison from filter
function, like `return index === array.indexOf(element)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-8879 fix stripe issue with ...
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/94#discussion_r30210477
--- Diff: src/windows/CameraProxy.js ---
@@ -438,6 +457,61 @@ function takePictureFromCameraWP(successCallback,
errorCallback, args) {
});
};
+var getAspectRatios = function (capture) {
+var photoAspectRatios =
capture.videoDeviceController.getAvailableMediaStreamProperties(Windows.Media.Capture.MediaStreamType.photo).map(function
(element) {
+return (element.width / element.height).toFixed(1);
+}).filter(function (element, index, array) { if (index ===
array.indexOf(element)) return 1; return 0; });
+
+var videoAspectRatios =
capture.videoDeviceController.getAvailableMediaStreamProperties(Windows.Media.Capture.MediaStreamType.videoRecord).map(function
(element) {
+return (element.width / element.height).toFixed(1);
+}).filter(function (element, index, array) { if (index ===
array.indexOf(element)) return 1; return 0; });
+
+var videoPreviewAspectRatios =
capture.videoDeviceController.getAvailableMediaStreamProperties(Windows.Media.Capture.MediaStreamType.videoPreview).map(function
(element) {
+return (element.width / element.height).toFixed(1);
+}).filter(function (element, index, array) { if (index ===
array.indexOf(element)) return 1; return 0; });
+
+var allAspectRatios = [].concat(photoAspectRatios,
videoAspectRatios, videoPreviewAspectRatios);
+
+var aspectObj = allAspectRatios.reduce(function (map, item) {
+if (!map[item]) {
+map[item] = 0;
+}
+map[item]++;
+return map;
+}, {});
+
+return Object.keys(aspectObj).filter(function (k) {
+return aspectObj[k] === 3;
--- End diff --
You are restricting aspect ratios to those which only supported by __all__
capture modes (picture, video and videoPreview). Not sure if it is by intent.
Probably it makes sense to respect __current__ capture mode and return
aspect ratios for this capture mode. Potentially there could be a situation
when device's camera support a different aspect ratios for video and image
capture.
For example video is captured only in 640*480, which is equal to 1.3 aspect
ratio, and for image there could be a number of other aspect ratios). This
logic will return only '1.3' or even an empty set.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-8879 fix stripe issue with ...
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/94#discussion_r30210599
--- Diff: src/windows/CameraProxy.js ---
@@ -337,28 +336,48 @@ function takePictureFromCameraWP(successCallback,
errorCallback, args) {
}
});
-capture.initializeAsync(captureSettings).done(function () {
-//
msdn.microsoft.com/en-us/library/windows/apps/hh452807.aspx
-capturePreview.msZoom = true;
-capturePreview.src = URL.createObjectURL(capture);
-capturePreview.play();
+captureSettings.photoCaptureSource =
Windows.Media.Capture.PhotoCaptureSource.photo;
-// Insert preview frame and controls into page
-document.body.appendChild(capturePreview);
-document.body.appendChild(captureCancelButton);
+return capture.initializeAsync(captureSettings);
+}).then(function () {
+// msdn.microsoft.com/en-us/library/windows/apps/hh452807.aspx
+capturePreview.msZoom = true;
+capturePreview.src = URL.createObjectURL(capture);
+capturePreview.play();
-// Bind events to controls
-window.addEventListener('deviceorientation',
cameraPreviewOrientation, false);
-capturePreview.addEventListener('click', captureAction);
-captureCancelButton.addEventListener('click', function () {
-destroyCameraPreview();
-errorCallback('Cancelled');
-}, false);
-}, function (err) {
+// Insert preview frame and controls into page
+document.body.appendChild(capturePreview);
+document.body.appendChild(captureCancelButton);
+
+// Bind events to controls
+window.addEventListener('deviceorientation',
cameraPreviewOrientation, false);
+capturePreview.addEventListener('click', captureAction);
+captureCancelButton.addEventListener('click', function () {
destroyCameraPreview();
-errorCallback('Camera intitialization error ' + err);
-});
-}, errorCallback);
+errorCallback('Cancelled');
+}, false);
+
+// Get available aspect ratios
+var aspectRatios = getAspectRatios(capture);
+
+// Couldn't find a good ratio
+if (aspectRatios.length === 0) {
+destroyCameraPreview();
+errorCallback('There\'s not a good aspect ratio
available');
+return;
+}
+
+// Default aspect ratio 1.78 (16:9 hd video standard)
+if (aspectRatios.indexOf(1.8) -1) {
--- End diff --
IMO it will be better to use constant here instead: `DEFAULT_ASPECT_RATIO =
1.8`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Hi Everyone
Hi Rakesh, Good to have you on board. You won't have direct repo access -- instead send a pull request against the repos: https://github.com/apache?utf8=✓query=cordova- On Wed, May 13, 2015 at 7:01 AM, Rakesh Kalyankar k.rakesh...@gmail.com wrote: Hello Community I am Rakesh. I am currently working with Meteor and Cordova to build a realtime app at MotoBite.com I would like to access repos for some of the cordova plugins which are used in my app Rakesh Kalyankar k.rakesh...@gmail.com - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
