Re: Facebook infer on Cordova / plugins
+1 On Wed, Jun 17, 2015 at 12:09 PM, Dmitry Blotsky dblot...@microsoft.com wrote: We could incorporate this into our CI. I've also been reading about Infer recently. Folks: thoughts? Kindly, Dmitry -Original Message- From: Axel Nennker [mailto:ignisvul...@gmail.com] Sent: Tuesday, June 16, 2015 3:39 PM To: dev Subject: Facebook infer on Cordova / plugins Hi, I ran infer on one of my projects and get the output below. I looked only at the first issue reported and it I think it is an issue and easy to fix. http://fbinfer.com/docs/hello-world.html#hello-world-android Maybe this should be run on all Android plugins and Cordova Android code from time to time? cheers Axel Maybe I am using older versions on some plugins. Have not checked. /home/ignisvulpis/development/nur_der_hsv/app/platforms/android/src/org/apache/cordova/camera/CameraLauncher.java:210: error: NULL_DEREFERENCE object returned by queryImgDB(this,whichContentStore(this)) could be null and is dereferenced at line 210 /home/ignisvulpis/development/nur_der_hsv/app/platforms/android/src/org/apache/cordova/camera/CameraLauncher.java:210: error: RESOURCE_LEAK resource acquired by call to queryImgDB(...) at line 210 is not released after line 210 /home/ignisvulpis/development/nur_der_hsv/app/platforms/android/src/org/apache/cordova/camera/CameraLauncher.java:1007: error: NULL_DEREFERENCE object cursor last assigned on line 1006 could be null and is dereferenced at line 1007 /home/ignisvulpis/development/nur_der_hsv/app/platforms/android/src/org/apache/cordova/camera/CameraLauncher.java:1024: error: RESOURCE_LEAK resource acquired by call to queryImgDB(...) at line 1006 is not released after line 1024 /home/ignisvulpis/development/nur_der_hsv/app/platforms/android/src/org/apache/cordova/camera/FileHelper.java:97: error: NULL_DEREFERENCE object cursor last assigned on line 94 could be null and is dereferenced at line 97 /home/ignisvulpis/development/nur_der_hsv/app/platforms/android/src/org/apache/cordova/camera/FileHelper.java:135: error: NULL_DEREFERENCE object cursor last assigned on line 134 could be null and is dereferenced at line 135 /home/ignisvulpis/development/nur_der_hsv/app/platforms/android/src/org/apache/cordova/camera/FileHelper.java:137: error: RESOURCE_LEAK resource acquired by call to query(...) at line 134 is not released after line 137 /home/ignisvulpis/development/nur_der_hsv/app/platforms/android/src/org/apache/cordova/file/LocalFilesystem.java:340: error: RESOURCE_LEAK resource acquired to istream by call to FileInputStream(...) at line 327 is not released after line 340 /home/ignisvulpis/development/nur_der_hsv/app/platforms/android/src/org/apache/cordova/file/LocalFilesystem.java:340: error: RESOURCE_LEAK resource acquired by call to FileOutputStream(...) at line 328 is not released after line 340 /home/ignisvulpis/development/nur_der_hsv/app/platforms/android/src/org/apache/cordova/filetransfer/FileTransfer.java:554: error: RESOURCE_LEAK resource acquired by call to getInputStream() at line 554 is not released after line 554 - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-8728 fix write after seek on ...
Github user aroberson commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/106#issuecomment-112909588 Is anyone looking at the pull requests to determine if they should be merged or not. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Update plugin's package.json git url to github mirrors.
How do people feel about changing the repo field in the package.json for our plugins to point to the github mirror instead of apache git repo? The url gets listed at https://www.npmjs.com/package/cordova-plugin-camera on the left. The github mirror is much nicer looking and we receive all of our PRs on github too. Thoughts?
[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/86#discussion_r32667023
--- Diff: src/audit-license-headers.js ---
@@ -44,11 +46,27 @@ var COMMON_RAT_EXCLUDES = [
'*.xcworkspacedata',
'*.xccheckout',
'*.xcscheme',
-];
+];
+
+var RAT_IGNORE_PATH = '.ratignore';
+var RATIGNORE_COMMENT_PREFIX = '#';
+
+var RAT_NAME = 'apache-rat-0.10';
+var RAT_URL =
'https://dist.apache.org/repos/dist/release/creadur/apache-rat-0.10/apache-rat-0.10-bin.tar.gz';
+
+function startsWith(string, prefix) {
+return string.lastIndexOf(prefix, 0) === 0;
--- End diff --
It works because `lastIndexOf` searches backwards. That's definitely an
implementation detail, and I shouldn't rely on it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: fix warning message
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: Update readme with correct ...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/23 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: update docs for StatusBarBa...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Update plugin's package.json git url to github mirrors.
+1 this will drive more contribution. Keeping it to Apache git doesn't help the project -- since the committers already know where the main repo is, but this would confuse others. Not sure about multiple repository fields, I suppose it's possible... On Wed, Jun 17, 2015 at 11:37 AM, Steven Gill stevengil...@gmail.com wrote: How do people feel about changing the repo field in the package.json for our plugins to point to the github mirror instead of apache git repo? The url gets listed at https://www.npmjs.com/package/cordova-plugin-camera on the left. The github mirror is much nicer looking and we receive all of our PRs on github too. Thoughts?
[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/86#discussion_r32664260
--- Diff: src/audit-license-headers.js ---
@@ -44,11 +46,27 @@ var COMMON_RAT_EXCLUDES = [
'*.xcworkspacedata',
'*.xccheckout',
'*.xcscheme',
-];
+];
+
+var RAT_IGNORE_PATH = '.ratignore';
+var RATIGNORE_COMMENT_PREFIX = '#';
+
+var RAT_NAME = 'apache-rat-0.10';
+var RAT_URL =
'https://dist.apache.org/repos/dist/release/creadur/apache-rat-0.10/apache-rat-0.10-bin.tar.gz';
+
+function startsWith(string, prefix) {
+return string.lastIndexOf(prefix, 0) === 0;
--- End diff --
Because `lastIndexOf` searches backwards, meaning that if it starts at `0`,
it will check for one occurrence and return right away. Arguably, regular
`indexOf` would be clearer though. Thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/86#discussion_r32664301
--- Diff: src/audit-license-headers.js ---
@@ -44,11 +46,27 @@ var COMMON_RAT_EXCLUDES = [
'*.xcworkspacedata',
'*.xccheckout',
'*.xcscheme',
-];
+];
+
+var RAT_IGNORE_PATH = '.ratignore';
+var RATIGNORE_COMMENT_PREFIX = '#';
+
+var RAT_NAME = 'apache-rat-0.10';
+var RAT_URL =
'https://dist.apache.org/repos/dist/release/creadur/apache-rat-0.10/apache-rat-0.10-bin.tar.gz';
+
+function startsWith(string, prefix) {
+return string.lastIndexOf(prefix, 0) === 0;
+}
+
+function isComment(pattern) {
+return startsWith(pattern, RATIGNORE_COMMENT_PREFIX) ;
--- End diff --
Good call! Fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Plugins Release
Updated RELEASENOTES as a comment on the issue. https://issues.apache.org/jira/browse/CB-9192 On Tue, Jun 2, 2015 at 11:50 PM, Serge Huijben s.huij...@gmail.com wrote: https://github.com/apache/cordova-plugin-camera/pull/97, if you please Serge Op di 2 jun. 2015 om 20:15 schreef Joe Bowser bows...@gmail.com: Is there a test attached to that PR? This seems like something that would break again. On Tue, Jun 2, 2015 at 11:11 AM Steven Gill stevengil...@gmail.com wrote: Thanks Darryl! Merged. On Tue, Jun 2, 2015 at 10:57 AM, Darryl Pogue dar...@dpogue.ca wrote: https://github.com/apache/cordova-plugin-file-transfer/pull/68 This bug is causing app crashes on older OS versions for anyone using FileTransfer on Android with Crosswalk. On 2 June 2015 at 10:50, Steven Gill stevengil...@gmail.com wrote: Going to start a plugins release tomorrow. If you have PRs you want me to review, please bring them up in this thread. -Steve - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Update plugin's package.json git url to github mirrors.
+1 easier onboarding of contributors My team is hiring! @purplecabbage risingj.com On Wed, Jun 17, 2015 at 11:54 AM, Shazron shaz...@gmail.com wrote: +1 this will drive more contribution. Keeping it to Apache git doesn't help the project -- since the committers already know where the main repo is, but this would confuse others. Not sure about multiple repository fields, I suppose it's possible... On Wed, Jun 17, 2015 at 11:37 AM, Steven Gill stevengil...@gmail.com wrote: How do people feel about changing the repo field in the package.json for our plugins to point to the github mirror instead of apache git repo? The url gets listed at https://www.npmjs.com/package/cordova-plugin-camera on the left. The github mirror is much nicer looking and we receive all of our PRs on github too. Thoughts?
RE: Update plugin's package.json git url to github mirrors.
Yes +1 ! Now if only we could move our bugs as well :P -Original Message- From: Jesse [mailto:purplecabb...@gmail.com] Sent: Wednesday, June 17, 2015 11:57 AM To: dev@cordova.apache.org Subject: Re: Update plugin's package.json git url to github mirrors. +1 easier onboarding of contributors My team is hiring! @purplecabbage risingj.com On Wed, Jun 17, 2015 at 11:54 AM, Shazron shaz...@gmail.com wrote: +1 this will drive more contribution. Keeping it to Apache git doesn't help the project -- since the committers already know where the main repo is, but this would confuse others. Not sure about multiple repository fields, I suppose it's possible... On Wed, Jun 17, 2015 at 11:37 AM, Steven Gill stevengil...@gmail.com wrote: How do people feel about changing the repo field in the package.json for our plugins to point to the github mirror instead of apache git repo? The url gets listed at https://www.npmjs.com/package/cordova-plugin-camera on the left. The github mirror is much nicer looking and we receive all of our PRs on github too. Thoughts?
[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/86#discussion_r32665147
--- Diff: src/audit-license-headers.js ---
@@ -44,11 +46,27 @@ var COMMON_RAT_EXCLUDES = [
'*.xcworkspacedata',
'*.xccheckout',
'*.xcscheme',
-];
+];
+
+var RAT_IGNORE_PATH = '.ratignore';
+var RATIGNORE_COMMENT_PREFIX = '#';
+
+var RAT_NAME = 'apache-rat-0.10';
+var RAT_URL =
'https://dist.apache.org/repos/dist/release/creadur/apache-rat-0.10/apache-rat-0.10-bin.tar.gz';
+
+function startsWith(string, prefix) {
+return string.lastIndexOf(prefix, 0) === 0;
--- End diff --
using lastIndexOf will fail with this won't it?
startsWith(boomboom,boom); // false?
string.indexOf(prefix) === 0 is not only correct, but easier to understand
too
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-coho/pull/86#issuecomment-112934635 Looks good (well, apart from those blank lines you insist on adding at the beginning of blocks :smile:). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...
Github user stevengill commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-112923305 @thehuijb hey. I will need to review this and see if it has any impact for other platforms before I can merge it in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-registry-web pull request: CB-9195 Sorting platforms and a...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-registry-web/pull/14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Javascript - Infinite cycle
Thank you Tim, There are several known issues around search on the plugins.cordova.io site, this is probably related to https://issues.apache.org/jira/browse/CB-8141 You are probably better off searching npmjs.org as we are moving to use npm as our plugin registry. @purplecabbage risingj.com On Wed, Jun 17, 2015 at 4:07 AM, Тимур Сейидов t...@ethics.su wrote: hello. I bring apologies for my English. On the site http://plugins.cordova.io/ if we assign in the search phrase in the Russian language, javascript infinitely changes url and leads to the crash of the supplementary sheet of the browser - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Update plugin's package.json git url to github mirrors.
On Wed, Jun 17, 2015 at 11:37 AM, Steven Gill stevengil...@gmail.com wrote: How do people feel about changing the repo field in the package.json for our plugins to point to the github mirror instead of apache git repo? The url gets listed at https://www.npmjs.com/package/cordova-plugin-camera on the left. The github mirror is much nicer looking and we receive all of our PRs on github too. On the right not left... Thoughts?
[GitHub] cordova-registry-web pull request: CB-9204 Adding mouseover to mor...
GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-registry-web/pull/15 CB-9204 Adding mouseover to more button You can merge this pull request into a Git repository by running: $ git pull https://github.com/rakatyal/cordova-registry-web raghav/click Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-registry-web/pull/15.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #15 commit a89be5920d75c6b0e4edda065e47e280d65f9186 Author: Raghav Katyal rakat...@microsoft.com Date: 2015-06-17T21:09:51Z CB-9204 Adding mouseover to more button --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-9158 - InAppBrowser z...
Github user syndbg commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/104#issuecomment-112974072 @purplecabbage Good catch. In the JIRA ticket, unfortunately I've pasted the wrong option parameter, `location`, when in fact I meant `zoom`. This PR fixes `zoom=true` or `zoom=false` not making a difference in the android app. Can we agree on the fact that fixing (in my opinion) non-formatted code, even in the iOS section of the plugin, should not be a blocker to merge this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-registry-web pull request: Updated the look and feel of th...
GitHub user cpsloal opened a pull request: https://github.com/apache/cordova-registry-web/pull/18 Updated the look and feel of the plugin card You can merge this pull request into a Git repository by running: $ git pull https://github.com/cpsloal/cordova-registry-web master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-registry-web/pull/18.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #18 commit 89875ebfe74e0d9524ed38ddc551f9308fef54d6 Author: Ali Satter cpsl...@yahoo.com Date: 2015-06-17T22:00:26Z Updated the look and feel of the plugin card --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: [CB-8838]Moved commandQueue push into no...
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/136#issuecomment-112975173 FYI this is in 4.0.x, will be auto-closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-medic pull request: CB-9196 Medic cleanup
Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/56 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-registry-web pull request: CB-9209 add link from old page ...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-registry-web/pull/17#issuecomment-112985415 This should only be merged once we have done [DISCUSS] on the new search page and got buy off to release. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: proof of concept for proposal discussed ...
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/119#issuecomment-112975897 Auto-closing since 4.0.x method has a transformURL method in the CommandDelegate that plugins check --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-8728 fix write after seek on ...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/106 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-7428: Enable Swift development of Plu...
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/133#issuecomment-112976058 Auto-closing since it has been merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-7428: Enable Swift development of Plu...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/133 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: proof of concept for proposal discussed ...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/119 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: [CB-8838]Moved commandQueue push into no...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/136 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: Created strongly typed configuration cla...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/98 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-registry-web pull request: CB-9209 add link from old page ...
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-registry-web/pull/17 CB-9209 add link from old page to new Create a link from old page to new:  You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-registry-web CB-9209 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-registry-web/pull/17.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #17 commit bd296cab699214b5ea62fa857b0c5f7eb8260ad6 Author: Murat Sutunc sut...@gmail.com Date: 2015-06-18T00:07:34Z CB-9209 add link from old page to new --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Implications of Apple iOS 9 statements on IPv6
Hi Apple has been reported to say in http://arstechnica.com/apple/2015/06/apple-to-ios-devs-ipv6-only-cell-service-is-coming-soon-get-your-apps-ready/ http://arstechnica.com/apple/2015/06/apple-to-ios-devs-ipv6-only-cell-service-is-coming-soon-get-your-apps-ready/ that IPv6 support will be an iOS 9 App Store submission criteria. What if any implications does this have on Cordova for iOS. Cheers, Shane
[GitHub] cordova-registry-web pull request: CB-9209 add link from old page ...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-registry-web/pull/17#issuecomment-112984913 Consider re-wording: Cordova plugin registry is moving to npm. Go the [new plugin search page](http://plugins.cordova.io/npm/index.html). I think we do not need to reference the announcement as you include it in the new website already. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-9158 - InAppBrowser z...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/104#issuecomment-112974712 It is a blocker typically. Modifications should be restricted to resolving the issue at hand, or at the bare minimum whitespace/formatting changes should be in their own commit. Reviewing pull requests is enough work without the overhead of having to manually sort through what is relevant. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: Created strongly typed configuration cla...
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/98#issuecomment-112975445 Thanks but due to the pluggable webview feature, each WebView plugin has its own configuration now (4.0.x branch). This PR will be auto-closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/86 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: cordova-plugin-file-transfer travis CI failing
No, the Travis integration is only meaningful if it is green on master, which it is not file-transfer. Also, the travis integration is only testing the plugin's tests on an iOS simulator, so these are really just smoke tests in most cases anyway. @purplecabbage risingj.com On Wed, Jun 17, 2015 at 2:33 AM, Marco Laponder marco.lapon...@mendix.com wrote: Hi everyone, Yesterday we submitted a pull request for cordova-plugin-file-transfer. After having submitted the request, we noticed that TravisCI failed on our code. We tried to replicate the failure locally and found out that the failure also occurs on master. Should we file a ticket for this? Will this block the review of our pull request? Regards, Marco Laponder and Leroy van Engelen
RE: Facebook infer on Cordova / plugins
We could incorporate this into our CI. I've also been reading about Infer recently. Folks: thoughts? Kindly, Dmitry -Original Message- From: Axel Nennker [mailto:ignisvul...@gmail.com] Sent: Tuesday, June 16, 2015 3:39 PM To: dev Subject: Facebook infer on Cordova / plugins Hi, I ran infer on one of my projects and get the output below. I looked only at the first issue reported and it I think it is an issue and easy to fix. http://fbinfer.com/docs/hello-world.html#hello-world-android Maybe this should be run on all Android plugins and Cordova Android code from time to time? cheers Axel Maybe I am using older versions on some plugins. Have not checked. /home/ignisvulpis/development/nur_der_hsv/app/platforms/android/src/org/apache/cordova/camera/CameraLauncher.java:210: error: NULL_DEREFERENCE object returned by queryImgDB(this,whichContentStore(this)) could be null and is dereferenced at line 210 /home/ignisvulpis/development/nur_der_hsv/app/platforms/android/src/org/apache/cordova/camera/CameraLauncher.java:210: error: RESOURCE_LEAK resource acquired by call to queryImgDB(...) at line 210 is not released after line 210 /home/ignisvulpis/development/nur_der_hsv/app/platforms/android/src/org/apache/cordova/camera/CameraLauncher.java:1007: error: NULL_DEREFERENCE object cursor last assigned on line 1006 could be null and is dereferenced at line 1007 /home/ignisvulpis/development/nur_der_hsv/app/platforms/android/src/org/apache/cordova/camera/CameraLauncher.java:1024: error: RESOURCE_LEAK resource acquired by call to queryImgDB(...) at line 1006 is not released after line 1024 /home/ignisvulpis/development/nur_der_hsv/app/platforms/android/src/org/apache/cordova/camera/FileHelper.java:97: error: NULL_DEREFERENCE object cursor last assigned on line 94 could be null and is dereferenced at line 97 /home/ignisvulpis/development/nur_der_hsv/app/platforms/android/src/org/apache/cordova/camera/FileHelper.java:135: error: NULL_DEREFERENCE object cursor last assigned on line 134 could be null and is dereferenced at line 135 /home/ignisvulpis/development/nur_der_hsv/app/platforms/android/src/org/apache/cordova/camera/FileHelper.java:137: error: RESOURCE_LEAK resource acquired by call to query(...) at line 134 is not released after line 137 /home/ignisvulpis/development/nur_der_hsv/app/platforms/android/src/org/apache/cordova/file/LocalFilesystem.java:340: error: RESOURCE_LEAK resource acquired to istream by call to FileInputStream(...) at line 327 is not released after line 340 /home/ignisvulpis/development/nur_der_hsv/app/platforms/android/src/org/apache/cordova/file/LocalFilesystem.java:340: error: RESOURCE_LEAK resource acquired by call to FileOutputStream(...) at line 328 is not released after line 340 /home/ignisvulpis/development/nur_der_hsv/app/platforms/android/src/org/apache/cordova/filetransfer/FileTransfer.java:554: error: RESOURCE_LEAK resource acquired by call to getInputStream() at line 554 is not released after line 554 - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/86#discussion_r3248
--- Diff: src/audit-license-headers.js ---
@@ -44,11 +46,27 @@ var COMMON_RAT_EXCLUDES = [
'*.xcworkspacedata',
'*.xccheckout',
'*.xcscheme',
-];
+];
+
+var RAT_IGNORE_PATH = '.ratignore';
+var RATIGNORE_COMMENT_PREFIX = '#';
+
+var RAT_NAME = 'apache-rat-0.10';
+var RAT_URL =
'https://dist.apache.org/repos/dist/release/creadur/apache-rat-0.10/apache-rat-0.10-bin.tar.gz';
+
+function startsWith(string, prefix) {
+return string.lastIndexOf(prefix, 0) === 0;
--- End diff --
You're right, `indexOf` is much more clear.
`startsWith(boomboom,boom);` actually is `true`, because it's doing
`lastIndexOf` starting at **0**, but it's clearly confusing. Fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-registry-web pull request: CB-9206 add search icon to sear...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-registry-web/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores
Github user stevengill commented on the pull request: https://github.com/apache/cordova-coho/pull/86#issuecomment-112943481 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix returning native url on wi...
GitHub user vldmrrr opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/102 Fix returning native url on windows. Fix code changed after first pull request for this CB was created. You can merge this pull request into a Git repository by running: $ git pull https://github.com/vldmrrr/cordova-plugin-camera CB-8498-take2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/102.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #102 commit 363dd025845bf290190b754b1d6fa3c11fd08438 Author: vladimir vladimir@elitebook Date: 2015-06-17T21:14:58Z Fix returning native url on windows. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-registry-web pull request: CB-9206 add search icon to sear...
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-registry-web/pull/16 CB-9206 add search icon to search box You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-registry-web CB-9206 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-registry-web/pull/16.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #16 commit 037c7f87bed89f00ee265820673c54bff2bd62e0 Author: Murat Sutunc sut...@gmail.com Date: 2015-06-17T22:22:03Z CB-9206 add search icon to search box --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-112941486 I think we should wait for @purplecabbage's design to improve the resume behavior for apps. This API looks very leaky and specific to Android - there is a similar scenario in Windows and it would be nice to tackle it fully. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-registry-web pull request: CB-9204 Adding mouseover to mor...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-registry-web/pull/15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...
Github user thehuijb commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-113041333 @stevengill, I would appreciate the review. @nikhilkh, this API is indeed specific to Android but I don't know what you mean by it looks very leaky, doesn't feel leaky to me. I think it would give the developers a means to handle this particular situation without to much trouble. And although @purplecabbage is most likely going to produce a wonderful solution across the board (no pressure ;) it isn't quite there yet. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[DISCUSS] Organizing CI
Hi all, With commits triggering builds, we're starting to hit scaling problems on our CI: https://paste.apache.org/ktJr. We have some awesome new things for which we can use the CI: - Static analysis (FB Infer) - Automated releases - Documentation generation - Testing on more emulators, platforms, and devices - Moving our platform and tools builds, so all our builds are on Apache infrastructure To keep up with our own pace, we should spend some time optimizing our CI process. So, here is some food for thought: - Builds can be greatly sped up if we can alleviate the path-length limit issue that prevents us from packaging up a Cordova build o Does anyone know of a tool that can zip up too-long paths? o Does anyone know if we can reduce our path lengths? o Does anyone know where we can store a buffer of builds? Cordova-vm is an option (~30GB of space). - We can run more builds in parallel if folks connect more slaves to the CI (instructions here: https://github.com/apache/cordova-medic/blob/master/SLAVES.md) - We can split the build process into levels (e.g. smoke, regression, end-to-end) and run them on different occasions Kindly, Dmitry
[GitHub] cordova-plugin-file-transfer pull request: Fixed Browser to set wi...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/89 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix returning native url on wi...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/102 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[VOTE] Plugins Release June 17th, 2015
Please review and vote on the release of this plugins release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9192 The plugins have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9192/ The packages were published from their corresponding git tags: cordova-plugin-battery-status: 1.1.0 (8f3f8a8d66) cordova-plugin-camera: 1.2.0 (437cf3d93a) cordova-plugin-console: 1.0.1 (f055daec45) cordova-plugin-contacts: 1.1.0 (e47559b0d4) cordova-plugin-device: 1.0.1 (b3da8484ec) cordova-plugin-device-motion: 1.1.1 (28394c4607) cordova-plugin-device-orientation: 1.0.1 (427d49f612) cordova-plugin-dialogs: 1.1.1 (b698f3a7b5) cordova-plugin-file: 2.1.0 (6276d06d7a) cordova-plugin-file-transfer: 1.2.0 (b01ab78fec) cordova-plugin-geolocation: 1.0.1 (e529db6abd) cordova-plugin-globalization: 1.0.1 (cd9d52355a) cordova-plugin-inappbrowser: 1.0.1 (47e332fc92) cordova-plugin-legacy-whitelist: 1.1.0 (d5af95b3ab) cordova-plugin-media: 1.0.1 (b3056343fc) cordova-plugin-media-capture: 1.0.1 (9af90d8540) cordova-plugin-network-information: 1.0.1 (d8bdb0e953) cordova-plugin-splashscreen: 2.1.0 (4b1df233ae) cordova-plugin-statusbar: 1.0.1 (5e96b2a345) cordova-plugin-test-framework: 1.0.1 (0167a2f9ab) cordova-plugin-vibration: 1.2.0 (274003cb33) cordova-plugin-whitelist: 1.1.0 (521e62b0fd) Upon a successful vote I will upload the archives to dist/, upload them to npm, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Built and ran mobilespec on android and ios
Re: [VOTE] Plugins Release
I swear I created a new thread for this with [VOTE] as the heading. Will try again. On Wed, Jun 17, 2015 at 6:03 PM, Steven Gill stevengil...@gmail.com wrote: Please review and vote on the release of this plugins release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9192 The plugins have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9192/ The packages were published from their corresponding git tags: cordova-plugin-battery-status: 1.1.0 (8f3f8a8d66) cordova-plugin-camera: 1.2.0 (437cf3d93a) cordova-plugin-console: 1.0.1 (f055daec45) cordova-plugin-contacts: 1.1.0 (e47559b0d4) cordova-plugin-device: 1.0.1 (b3da8484ec) cordova-plugin-device-motion: 1.1.1 (28394c4607) cordova-plugin-device-orientation: 1.0.1 (427d49f612) cordova-plugin-dialogs: 1.1.1 (b698f3a7b5) cordova-plugin-file: 2.1.0 (6276d06d7a) cordova-plugin-file-transfer: 1.2.0 (b01ab78fec) cordova-plugin-geolocation: 1.0.1 (e529db6abd) cordova-plugin-globalization: 1.0.1 (cd9d52355a) cordova-plugin-inappbrowser: 1.0.1 (47e332fc92) cordova-plugin-legacy-whitelist: 1.1.0 (d5af95b3ab) cordova-plugin-media: 1.0.1 (b3056343fc) cordova-plugin-media-capture: 1.0.1 (9af90d8540) cordova-plugin-network-information: 1.0.1 (d8bdb0e953) cordova-plugin-splashscreen: 2.1.0 (4b1df233ae) cordova-plugin-statusbar: 1.0.1 (5e96b2a345) cordova-plugin-test-framework: 1.0.1 (0167a2f9ab) cordova-plugin-vibration: 1.2.0 (274003cb33) cordova-plugin-whitelist: 1.1.0 (521e62b0fd) Upon a successful vote I will upload the archives to dist/, upload them to npm, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Built and ran mobilespec on android and ios
[VOTE] Plugins Release
Please review and vote on the release of this plugins release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9192 The plugins have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9192/ The packages were published from their corresponding git tags: cordova-plugin-battery-status: 1.1.0 (8f3f8a8d66) cordova-plugin-camera: 1.2.0 (437cf3d93a) cordova-plugin-console: 1.0.1 (f055daec45) cordova-plugin-contacts: 1.1.0 (e47559b0d4) cordova-plugin-device: 1.0.1 (b3da8484ec) cordova-plugin-device-motion: 1.1.1 (28394c4607) cordova-plugin-device-orientation: 1.0.1 (427d49f612) cordova-plugin-dialogs: 1.1.1 (b698f3a7b5) cordova-plugin-file: 2.1.0 (6276d06d7a) cordova-plugin-file-transfer: 1.2.0 (b01ab78fec) cordova-plugin-geolocation: 1.0.1 (e529db6abd) cordova-plugin-globalization: 1.0.1 (cd9d52355a) cordova-plugin-inappbrowser: 1.0.1 (47e332fc92) cordova-plugin-legacy-whitelist: 1.1.0 (d5af95b3ab) cordova-plugin-media: 1.0.1 (b3056343fc) cordova-plugin-media-capture: 1.0.1 (9af90d8540) cordova-plugin-network-information: 1.0.1 (d8bdb0e953) cordova-plugin-splashscreen: 2.1.0 (4b1df233ae) cordova-plugin-statusbar: 1.0.1 (5e96b2a345) cordova-plugin-test-framework: 1.0.1 (0167a2f9ab) cordova-plugin-vibration: 1.2.0 (274003cb33) cordova-plugin-whitelist: 1.1.0 (521e62b0fd) Upon a successful vote I will upload the archives to dist/, upload them to npm, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Built and ran mobilespec on android and ios
Re: [VOTE] Plugins Release
Please review blog post https://github.com/cordova/apache-blog-posts/blob/master/2015-06-19-plugins.release.md On Wed, Jun 17, 2015 at 6:05 PM, Steven Gill stevengil...@gmail.com wrote: I swear I created a new thread for this with [VOTE] as the heading. Will try again. On Wed, Jun 17, 2015 at 6:03 PM, Steven Gill stevengil...@gmail.com wrote: Please review and vote on the release of this plugins release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9192 The plugins have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9192/ The packages were published from their corresponding git tags: cordova-plugin-battery-status: 1.1.0 (8f3f8a8d66) cordova-plugin-camera: 1.2.0 (437cf3d93a) cordova-plugin-console: 1.0.1 (f055daec45) cordova-plugin-contacts: 1.1.0 (e47559b0d4) cordova-plugin-device: 1.0.1 (b3da8484ec) cordova-plugin-device-motion: 1.1.1 (28394c4607) cordova-plugin-device-orientation: 1.0.1 (427d49f612) cordova-plugin-dialogs: 1.1.1 (b698f3a7b5) cordova-plugin-file: 2.1.0 (6276d06d7a) cordova-plugin-file-transfer: 1.2.0 (b01ab78fec) cordova-plugin-geolocation: 1.0.1 (e529db6abd) cordova-plugin-globalization: 1.0.1 (cd9d52355a) cordova-plugin-inappbrowser: 1.0.1 (47e332fc92) cordova-plugin-legacy-whitelist: 1.1.0 (d5af95b3ab) cordova-plugin-media: 1.0.1 (b3056343fc) cordova-plugin-media-capture: 1.0.1 (9af90d8540) cordova-plugin-network-information: 1.0.1 (d8bdb0e953) cordova-plugin-splashscreen: 2.1.0 (4b1df233ae) cordova-plugin-statusbar: 1.0.1 (5e96b2a345) cordova-plugin-test-framework: 1.0.1 (0167a2f9ab) cordova-plugin-vibration: 1.2.0 (274003cb33) cordova-plugin-whitelist: 1.1.0 (521e62b0fd) Upon a successful vote I will upload the archives to dist/, upload them to npm, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Built and ran mobilespec on android and ios
Apache git servers are not writable
https://issues.apache.org/jira/browse/INFRA-9838
Re: Apache git servers are not writable
The INFRA guys just fixed and resolved it - that was fast On Wed, Jun 17, 2015 at 10:35 AM, Shazron shaz...@gmail.com wrote: https://issues.apache.org/jira/browse/INFRA-9838
[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...
Github user stevengill commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-112943279 Sounds good. Thanks for the input @nikhilkh --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-medic pull request: CB-9196 Medic cleanup
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-medic/pull/56 CB-9196 Medic cleanup CB-9196 Adding JSHint config for medic. Making medic-log return an error code. Making `medic-clean`'s `--exclude` flag repeatable. Making `medic-clean` take a target directory. Fixing JSHint-detected errors. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-medic CB-9196 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-medic/pull/56.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #56 commit e145e0fae5d2316e341c1b3deb808c383d17612b Author: Dmitry Blotsky dmitry.blot...@gmail.com Date: 2015-06-17T06:24:16Z CB-9196 Adding JSHint config for medic. Making medic-log return an error code. Making medic-clean --exclude repeatable. Making medic-clean take a target directory. Fixing JSHint-detected errors. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: NPE fix
GitHub user Greunlis opened a pull request: https://github.com/apache/cordova-plugin-file/pull/117 NPE fix Our application suddenly stopped working on Android, I found out, it was because of this NullPointerException. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Greunlis/cordova-plugin-file master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/117.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #117 commit 152d9dc68d00bee9b9d60832f3c1e03f1db4058c Author: Jakub H. holot...@gmail.com Date: 2015-06-17T06:35:41Z NPE fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
cordova-plugin-file-transfer travis CI failing
Hi everyone, Yesterday we submitted a pull request for cordova-plugin-file-transfer. After having submitted the request, we noticed that TravisCI failed on our code. We tried to replicate the failure locally and found out that the failure also occurs on master. Should we file a ticket for this? Will this block the review of our pull request? Regards, Marco Laponder and Leroy van Engelen
Re: [iOS] Remove non-CLI template
I think the difference between the two templates is that the CLI template adds extra navigator entries to point to ../../www and ../../config.xml. Might still be worth not keeping two templates though, and just have these entries be red for non-CLI projects (doesn't break builds). On Tue, Jun 16, 2015 at 2:18 PM, Shazron shaz...@gmail.com wrote: I propose to remove the non-CLI template starting in cordova-ios 4.0.0. It was originally used to easily test your own plugins, but now we have the alternative using the CLI: cordova plugin add --link path/to/your/plugin
[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/86#discussion_r32650218
--- Diff: src/audit-license-headers.js ---
@@ -44,11 +46,27 @@ var COMMON_RAT_EXCLUDES = [
'*.xcworkspacedata',
'*.xccheckout',
'*.xcscheme',
-];
+];
+
+var RAT_IGNORE_PATH = '.ratignore';
+var RATIGNORE_COMMENT_PREFIX = '#';
+
+var RAT_NAME = 'apache-rat-0.10';
+var RAT_URL =
'https://dist.apache.org/repos/dist/release/creadur/apache-rat-0.10/apache-rat-0.10-bin.tar.gz';
+
+function startsWith(string, prefix) {
+return string.lastIndexOf(prefix, 0) === 0;
--- End diff --
Why `lastIndexOf`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/86#discussion_r32650376
--- Diff: src/audit-license-headers.js ---
@@ -44,11 +46,27 @@ var COMMON_RAT_EXCLUDES = [
'*.xcworkspacedata',
'*.xccheckout',
'*.xcscheme',
-];
+];
+
+var RAT_IGNORE_PATH = '.ratignore';
+var RATIGNORE_COMMENT_PREFIX = '#';
+
+var RAT_NAME = 'apache-rat-0.10';
+var RAT_URL =
'https://dist.apache.org/repos/dist/release/creadur/apache-rat-0.10/apache-rat-0.10-bin.tar.gz';
+
+function startsWith(string, prefix) {
+return string.lastIndexOf(prefix, 0) === 0;
+}
+
+function isComment(pattern) {
+return startsWith(pattern, RATIGNORE_COMMENT_PREFIX) ;
--- End diff --
Perhaps trim leading white-space from pattern (not particularly likely in
an ignore file, but to be strictly correct)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-medic pull request: CB-9196 Medic cleanup
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-medic/pull/56#issuecomment-112836441 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Javascript - Infinite cycle
hello. I bring apologies for my English. On the site http://plugins.cordova.io/ if we assign in the search phrase in the Russian language, javascript infinitely changes url and leads to the crash of the supplementary sheet of the browser - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
