[GitHub] cordova-android pull request: CB-9185 Fix signed release build exc...
GitHub user josschne opened a pull request: https://github.com/apache/cordova-android/pull/193 CB-9185 Fix signed release build exception You can merge this pull request into a Git repository by running: $ git pull https://github.com/josschne/cordova-android master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/193.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #193 commit f9af3a2acc3140581125c22d15dfdae37c59691b Author: Joe Schneider jossc...@gmail.com Date: 2015-07-01T08:01:42Z CB-9185 Fix signed release build exception commit 27b2290e4b0349276b05182151d545afec025577 Author: Joe Schneider jossc...@gmail.com Date: 2015-07-07T06:00:24Z Merge branch 'master' of github.com:apache/cordova-android --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Introduction
We experimented with Promise polyfills and had nothing but trouble. I'd like to preface by saying: lets not get into a theory war. Some people like promises (fine) and some do not (also fine). My stance is that we should leave that choice up to our end users. Lets throw some facts out to colour things. 1. Promises are a spec that will land in browsers natively [1] 2. Promises as a concept have MANY polyfill implementations 3. The polyfill landscape is largely divergent and implement different flavors of the concept Since we implement a User Agent we *could* polyfill to spec. As a plugin. (Jake's is probably best [2]) I'd be in favor of this and making that THE plugin dep for companion plugins that require Promises. The problem with this is #3. If we have a window.Promise it could be clobbered by a user that is not super aware of how things are composed under the hood. If it *could* happen guess what: it will. Some frameworks even force the idea of Promises that may not be totally on spec. Older jQuery and Ember come to mind. The other way to solve this problem is patience. This is the path I am most in favor of. Lets wait out the native implementation to land in the various webviews and at such time we can start using those. Plugins really should wrap device and operating system API's (in my opinion) and we should leave library code for the user land to figure out. The Promise API *is a library* until such time as it has been implemented into the language runtimes natively (and not just speculatively standardized). Ok I guess faltered into the theory war part there. ;) [1] https://promisesaplus.com/ [2] https://github.com/jakearchibald/es6-promise On Mon, Jul 6, 2015 at 6:45 PM, Murat Sutunc mura...@microsoft.com wrote: Hey Paul, Welcome to Cordova! I've looked at your changes on github and have some early feedback. 1) As per spec you return a Promise on battery.js but to my knowledge we don't have a fallback for ES6 Promises on platforms that don't support it yet. I would like to know what other committers think about this problem. 2) I think the old API and the new API can co-exist for a while before we deprecate and remove the old one. I see that the new spec uses a different method name so we should be fine here. Thanks, Murat -Original Message- From: Paul Contat [mailto:contat.p...@gmail.com] Sent: Wednesday, July 1, 2015 12:38 AM To: dev@cordova.apache.org Subject: Introduction Hello everyone, My name is Paul Contat, and I'm an engineering student and currently doing an internship at W3C focusing on aligning cordova API with W3C ones where applicable, as part of the HTML5Apps EU project ( http://html5apps-project.eu/2014/08/27/aligning-cordova-and-w3c-device-apis/ ) For my internship, I’m planning to contribute to the cordova project, starting by the BatteryStatus API ( https://issues.apache.org/jira/browse/CB-6065) if it’s possible. I've just signed the ICLA, created an account on Apache JIRA so I’m ready to start and submitted my first pull request: https://github.com/apache/cordova-plugin-battery-status/pull/24 I’m looking forward to feedback on whether I’m on the right path for updating the Battery plugin API; I’m in particular interested to understand if and how the current API should be deprecated once we get to a stage where the new API is deemed in a good enough shape. Best regards, Paul
[GitHub] cordova-docs pull request: CB-9295 Add GA analytics code on the Co...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/295#issuecomment-119256641 Any ideas on how we can update older versions of the docs to use this new ID? Is it just a find and replace job? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-8222 Background threading fo...
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/60#issuecomment-119106407 This resolves the same issue as PR #12, as that has been hanging for a LONG time I have created a new pull request. The Jira ID for this issue is : CB-8222 my jira login is ghenry22 I have just completed the CLA and emailed it back so that should also not be an issue. This resolves the issue with the media plugin blocking the UI when loading media. Especially noticeable when loading from a URL as it will cause a long delay. Should resolve the Media should use a background thread warnings in Xcode as well as they are tied to the time the plugin blocks to load media. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9235 Adds more checks based on th...
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/92#discussion_r34019903
--- Diff: bin/lib/check_reqs.js ---
@@ -19,15 +19,226 @@
/*jshint node:true*/
-var Q = require('Q');
+var Q = require('q');
+var os= require('os');
+var path = require('path');
+var shell = require('shelljs');
-var MSBuildTools;
+var ConfigParser, MSBuildTools, Version, exec;
try {
+ConfigParser = require('../../template/cordova/lib/ConfigParser');
MSBuildTools = require('../../template/cordova/lib/MSBuildTools');
+exec = require('../../template/cordova/lib/exec');
+Version = require('../../template/cordova/lib/Version');
} catch (ex) {
// If previous import fails, we're probably running this script
// from installed platform and the module location is different.
+ConfigParser = require('./ConfigParser');
MSBuildTools = require('./MSBuildTools');
+exec = require('./exec');
+Version = require('./Version');
+}
+
+// The constant for VS2013 Upd2 PackageVersion. See MSDN for
+// reference:
https://msdn.microsoft.com/en-us/library/bb164659(v=vs.120).aspx
+var VS2013_UPDATE2_RC = new Version(12, 0, 30324);
+var REQUIRED_VERSIONS = {
+'8.0': {
+os: '6.1',
+msbuild: '11.0',
+visualstudio: '11.0',
+windowssdk: '8.0'
+},
+'8.1': {
+os: '6.2',
+msbuild: '12.0',
+visualstudio: '12.0',
+windowssdk: '8.1',
+phonesdk: '8.1'
+},
+'10.0': {
+os: '6.2',
+msbuild: '14.0',
+visualstudio: '14.0',
+windowssdk: '10.0',
+phonesdk: '10.0'
+}
+};
+
+function getMinimalRequiredVersionFor (requirement) {
+var config = new ConfigParser(path.join(__dirname, '..', '..',
'config.xml'));
+
+var windowsTargetVersion = config.getWindowsTargetVersion();
+var windowsPhoneTargetVersion = config.getWindowsPhoneTargetVersion();
+var windowsReqVersion =
Version.tryParse(REQUIRED_VERSIONS[windowsTargetVersion][requirement]);
+var phoneReqVersion =
Version.tryParse(REQUIRED_VERSIONS[windowsPhoneTargetVersion][requirement]);
+
+// If we're searching for Windows SDK, we're not
+// interested in Phone's version and and vice versa.
+if (requirement === 'windowssdk') return windowsReqVersion;
+if (requirement === 'phonesdk') return phoneReqVersion;
+
+// If both windowsReqVersion and phoneReqVersion is valid Versions,
choose the max one
+if (windowsReqVersion phoneReqVersion) {
+return windowsReqVersion.gt(phoneReqVersion) ?
+windowsReqVersion :
+phoneReqVersion;
+}
+
+// Otherwise return that one which is defined and valid
+return windowsReqVersion || phoneReqVersion;
+}
+
+function getHighestAppropriateVersion (versions, requiredVersion) {
+return versions.map(function (version) {
+return Version.tryParse(version);
+})
+.sort(Version.comparer)
+.filter(function (toolVersion) {
+return toolVersion.gte(requiredVersion);
+})[0];
+}
+
+/**
+ * Return Version object for current Windows version. User 'ver' binary or
+ * os.release() in case of errors.
+ *
+ * @return {Version} Version information for current OS.
+ */
+function getWindowsVersion() {
+return exec('ver').then(function (output) {
+var match = /\[Version (.*)\]\s*$/.exec(output);
+return Version.fromString(match[1]);
+}).fail(function () {
+return Version.fromString(os.release());
+});
+}
+
+/**
+ * Lists all Visual Studio versions insalled. For VS 2013 if it present,
alao
+ * checks if Update 2 is installed.
+ *
+ * @return {String[]} List of installed Visual Studio versions.
+ */
+function getInstalledVSVersions() {
+// Query all keys with Install value equal to 1, then filter out
+// those, which are not related to VS itself
+return exec('reg query
HKLM\\SOFTWARE\\Microsoft\\DevDiv\\vs\\Servicing /s /v Install /f 1 /d /e
/reg:32')
+.fail(function () { return ''; })
+.then(function (output) {
+return output.split('\n')
+.reduce(function (installedVersions, line) {
+var match =
/(\d+\.\d+)\\(ultimate|professional|premium|community)/.exec(line);
+if (match match[1] installedVersions.indexOf(match[1])
=== -1)
+installedVersions.push(match[1]);
+return installedVersions;
+}, []);
+})
+
[GitHub] cordova-plugin-media pull request: CB-8222 Background threading fo...
GitHub user ghenry22 opened a pull request: https://github.com/apache/cordova-plugin-media/pull/60 CB-8222 Background threading for Audio Plugin Start playback with background thread so that UI is not blocked when playing sounds with the media plugin. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ghenry22/cordova-plugin-media CB-8222-background-threads-for-media-plugin Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-media/pull/60.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #60 commit afb82b4bb841258408242409adcfe77557888459 Author: ghenry22 ghenr...@gmail.com Date: 2015-07-07T07:27:35Z Add background threading to play command --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-9185 Fix signed release build exc...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-android/pull/193#issuecomment-119293443 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Introduction
I hate to dash your hopes, but I think that we should probably not have a Battery Status plugin and defer to browser behaviour on Android, since Battery Status is supported on the browser with the latest Android WebViews, and with Crosswalk. Any plugin should just be glue code for facilitating this behaviour, similar to how we deprecated the Geolocation plugin on Android in favour to Browser Geolocation. That's my two cents on the issue right now. On Tue, Jul 7, 2015 at 11:17 AM Brian LeRoux b...@brian.io wrote: exactly so and by all means please feel free to use that, bluebird, rsvp, q, jakes es6 polyfill or any of the 5000+ libs for Promises [1] though I suggest one limits the scope to the other 200+ libraries claiming A+ support! [2] ;P [1] https://www.npmjs.com/search?q=Promise [2] https://www.npmjs.com/search?q=Promise+A%2B On Tue, Jul 7, 2015 at 10:53 AM, Tyler Freeman ty...@tappur.co wrote: I'd just like to mention that jQuery has promises built-in as the $.Deferred object. It's not quite the same as the official Promises spec, but can be used similarly in most cases. On July 7, 2015 9:42:10 AM PDT, Brian LeRoux b...@brian.io wrote: We experimented with Promise polyfills and had nothing but trouble. I'd like to preface by saying: lets not get into a theory war. Some people like promises (fine) and some do not (also fine). My stance is that we should leave that choice up to our end users. Lets throw some facts out to colour things. 1. Promises are a spec that will land in browsers natively [1] 2. Promises as a concept have MANY polyfill implementations 3. The polyfill landscape is largely divergent and implement different flavors of the concept Since we implement a User Agent we *could* polyfill to spec. As a plugin. (Jake's is probably best [2]) I'd be in favor of this and making that THE plugin dep for companion plugins that require Promises. The problem with this is #3. If we have a window.Promise it could be clobbered by a user that is not super aware of how things are composed under the hood. If it *could* happen guess what: it will. Some frameworks even force the idea of Promises that may not be totally on spec. Older jQuery and Ember come to mind. The other way to solve this problem is patience. This is the path I am most in favor of. Lets wait out the native implementation to land in the various webviews and at such time we can start using those. Plugins really should wrap device and operating system API's (in my opinion) and we should leave library code for the user land to figure out. The Promise API *is a library* until such time as it has been implemented into the language runtimes natively (and not just speculatively standardized). Ok I guess faltered into the theory war part there. ;) [1] https://promisesaplus.com/ [2] https://github.com/jakearchibald/es6-promise On Mon, Jul 6, 2015 at 6:45 PM, Murat Sutunc mura...@microsoft.com wrote: Hey Paul, Welcome to Cordova! I've looked at your changes on github and have some early feedback. 1) As per spec you return a Promise on battery.js but to my knowledge we don't have a fallback for ES6 Promises on platforms that don't support it yet. I would like to know what other committers think about this problem. 2) I think the old API and the new API can co-exist for a while before we deprecate and remove the old one. I see that the new spec uses a different method name so we should be fine here. Thanks, Murat -Original Message- From: Paul Contat [mailto:contat.p...@gmail.com] Sent: Wednesday, July 1, 2015 12:38 AM To: dev@cordova.apache.org Subject: Introduction Hello everyone, My name is Paul Contat, and I'm an engineering student and currently doing an internship at W3C focusing on aligning cordova API with W3C ones where applicable, as part of the HTML5Apps EU project ( http://html5apps-project.eu/2014/08/27/aligning-cordova-and-w3c-device-apis/ ) For my internship, I’m planning to contribute to the cordova project, starting by the BatteryStatus API ( https://issues.apache.org/jira/browse/CB-6065) if it’s possible. I've just signed the ICLA, created an account on Apache JIRA so I’m ready to start and submitted my first pull request: https://github.com/apache/cordova-plugin-battery-status/pull/24 I’m looking forward to feedback on whether I’m on the right path for updating the Battery plugin API; I’m in particular interested to understand if and how the current API should be deprecated once we get to a stage where the new API is deemed in a good enough shape. Best regards, Paul -- Tyler Freeman CTO, Tappur http://tappur.co Sent from mobile
[GitHub] cordova-android pull request: CB-9185 Fix signed release build exc...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/193 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Introduction
IMHO, no-one uses this api so this would be an extremely low risk project. Please, before providing a Promise polyfil, verify that it is not already defined by the browser. ... and before providing the Battery api, verify that it is not already defined by the browser. Personally, I think if you wanted to take on a project that would get used, the Contacts API is dangling there for the taking, and a much better candidate. My team is hiring! @purplecabbage risingj.com On Tue, Jul 7, 2015 at 12:01 PM, julio cesar sanchez jcesarmob...@gmail.com wrote: It's only supported by android 5 webview (12% share right now), so I think the plugin makes sense for now even if it's going to be deprecated in the future and replaced by the browser battery status when more people have android 5 or greater But the discussion about this should be better on the cordova-discuss https://github.com/cordova/cordova-discuss/issues 2015-07-07 20:42 GMT+02:00 Joe Bowser bows...@gmail.com: I hate to dash your hopes, but I think that we should probably not have a Battery Status plugin and defer to browser behaviour on Android, since Battery Status is supported on the browser with the latest Android WebViews, and with Crosswalk. Any plugin should just be glue code for facilitating this behaviour, similar to how we deprecated the Geolocation plugin on Android in favour to Browser Geolocation. That's my two cents on the issue right now. On Tue, Jul 7, 2015 at 11:17 AM Brian LeRoux b...@brian.io wrote: exactly so and by all means please feel free to use that, bluebird, rsvp, q, jakes es6 polyfill or any of the 5000+ libs for Promises [1] though I suggest one limits the scope to the other 200+ libraries claiming A+ support! [2] ;P [1] https://www.npmjs.com/search?q=Promise [2] https://www.npmjs.com/search?q=Promise+A%2B On Tue, Jul 7, 2015 at 10:53 AM, Tyler Freeman ty...@tappur.co wrote: I'd just like to mention that jQuery has promises built-in as the $.Deferred object. It's not quite the same as the official Promises spec, but can be used similarly in most cases. On July 7, 2015 9:42:10 AM PDT, Brian LeRoux b...@brian.io wrote: We experimented with Promise polyfills and had nothing but trouble. I'd like to preface by saying: lets not get into a theory war. Some people like promises (fine) and some do not (also fine). My stance is that we should leave that choice up to our end users. Lets throw some facts out to colour things. 1. Promises are a spec that will land in browsers natively [1] 2. Promises as a concept have MANY polyfill implementations 3. The polyfill landscape is largely divergent and implement different flavors of the concept Since we implement a User Agent we *could* polyfill to spec. As a plugin. (Jake's is probably best [2]) I'd be in favor of this and making that THE plugin dep for companion plugins that require Promises. The problem with this is #3. If we have a window.Promise it could be clobbered by a user that is not super aware of how things are composed under the hood. If it *could* happen guess what: it will. Some frameworks even force the idea of Promises that may not be totally on spec. Older jQuery and Ember come to mind. The other way to solve this problem is patience. This is the path I am most in favor of. Lets wait out the native implementation to land in the various webviews and at such time we can start using those. Plugins really should wrap device and operating system API's (in my opinion) and we should leave library code for the user land to figure out. The Promise API *is a library* until such time as it has been implemented into the language runtimes natively (and not just speculatively standardized). Ok I guess faltered into the theory war part there. ;) [1] https://promisesaplus.com/ [2] https://github.com/jakearchibald/es6-promise On Mon, Jul 6, 2015 at 6:45 PM, Murat Sutunc mura...@microsoft.com wrote: Hey Paul, Welcome to Cordova! I've looked at your changes on github and have some early feedback. 1) As per spec you return a Promise on battery.js but to my knowledge we don't have a fallback for ES6 Promises on platforms that don't support it yet. I would like to know what other committers think about this problem. 2) I think the old API and the new API can co-exist for a while before we deprecate and remove the old one. I see that the new spec uses a different method name so we should be fine here. Thanks, Murat -Original Message- From: Paul Contat [mailto:contat.p...@gmail.com] Sent: Wednesday, July 1, 2015 12:38 AM To: dev@cordova.apache.org Subject:
Re: Introduction
We decided to try github (cordova-discuss) out a while ago as a replacement for google doc proposals we were using. This way we could revise a document in one place and also not have to search around our email for the link to the google doc. Proposals are supposed to be shared on the list when first created and throughout the process when asking for feedback. Final decision should always happen on the list. With google doc, a lot of the fine tuning of the proposal happened in comments on the document. Now that fine tuning is happening on the issue/PR. I have seen links on our mailing list for both platformAPI and cordova-docs proposals. You can view them at https://github.com/cordova/cordova-discuss/pulls We have also been using cordova github repo for a while now to draft and get review on blog posts https://github.com/cordova/apache-blog-posts On Tue, Jul 7, 2015 at 12:25 PM, Joe Bowser bows...@gmail.com wrote: When did we start discussing these proposals on GitHub instead of the dev list? That's kind of what the dev list is for, and I'm pretty sure it's not the Apache Way to do this. In fact, I wasn't aware that we were using our GitHub org for anything until now. On Tue, Jul 7, 2015, 12:01 PM julio cesar sanchez jcesarmob...@gmail.com wrote: It's only supported by android 5 webview (12% share right now), so I think the plugin makes sense for now even if it's going to be deprecated in the future and replaced by the browser battery status when more people have android 5 or greater But the discussion about this should be better on the cordova-discuss https https://github.com/cordova/cordova-discuss/issues:// https://github.com/cordova/cordova-discuss/issuesgithub.com https://github.com/cordova/cordova-discuss/issues/ https://github.com/cordova/cordova-discuss/issuescordova https://github.com/cordova/cordova-discuss/issues/ https://github.com/cordova/cordova-discuss/issuescordova-discuss https://github.com/cordova/cordova-discuss/issues/issues https://github.com/cordova/cordova-discuss/issues 2015-07-07 20:42 GMT+02:00 Joe Bowser bows...@gmail.com: I hate to dash your hopes, but I think that we should probably not have a Battery Status plugin and defer to browser behaviour on Android, since Battery Status is supported on the browser with the latest Android WebViews, and with Crosswalk. Any plugin should just be glue code for facilitating this behaviour, similar to how we deprecated the Geolocation plugin on Android in favour to Browser Geolocation. That's my two cents on the issue right now. On Tue, Jul 7, 2015 at 11:17 AM Brian LeRoux b...@brian.io wrote: exactly so and by all means please feel free to use that, bluebird, rsvp, q, jakes es6 polyfill or any of the 5000+ libs for Promises [1] though I suggest one limits the scope to the other 200+ libraries claiming A+ support! [2] ;P [1] https://www.npmjs.com/search?q=Promise [2] https://www.npmjs.com/search?q=Promise+A%2B On Tue, Jul 7, 2015 at 10:53 AM, Tyler Freeman ty...@tappur.co wrote: I'd just like to mention that jQuery has promises built-in as the $.Deferred object. It's not quite the same as the official Promises spec, but can be used similarly in most cases. On July 7, 2015 9:42:10 AM PDT, Brian LeRoux b...@brian.io wrote: We experimented with Promise polyfills and had nothing but trouble. I'd like to preface by saying: lets not get into a theory war. Some people like promises (fine) and some do not (also fine). My stance is that we should leave that choice up to our end users. Lets throw some facts out to colour things. 1. Promises are a spec that will land in browsers natively [1] 2. Promises as a concept have MANY polyfill implementations 3. The polyfill landscape is largely divergent and implement different flavors of the concept Since we implement a User Agent we *could* polyfill to spec. As a plugin. (Jake's is probably best [2]) I'd be in favor of this and making that THE plugin dep for companion plugins that require Promises. The problem with this is #3. If we have a window.Promise it could be clobbered by a user that is not super aware of how things are composed under the hood. If it *could* happen guess what: it will. Some frameworks even force the idea of Promises that may not be totally on spec. Older jQuery and Ember come to mind. The other way to solve this problem is patience. This is the path I am most in favor of. Lets wait out the native implementation to land in the various webviews and at such time we can start using those. Plugins really should wrap device and operating system API's (in my opinion) and we should leave library code for the user land to figure out. The Promise API *is a library* until such time as it has been implemented
Re: Introduction
It's only supported by android 5 webview (12% share right now), so I think the plugin makes sense for now even if it's going to be deprecated in the future and replaced by the browser battery status when more people have android 5 or greater But the discussion about this should be better on the cordova-discuss https://github.com/cordova/cordova-discuss/issues 2015-07-07 20:42 GMT+02:00 Joe Bowser bows...@gmail.com: I hate to dash your hopes, but I think that we should probably not have a Battery Status plugin and defer to browser behaviour on Android, since Battery Status is supported on the browser with the latest Android WebViews, and with Crosswalk. Any plugin should just be glue code for facilitating this behaviour, similar to how we deprecated the Geolocation plugin on Android in favour to Browser Geolocation. That's my two cents on the issue right now. On Tue, Jul 7, 2015 at 11:17 AM Brian LeRoux b...@brian.io wrote: exactly so and by all means please feel free to use that, bluebird, rsvp, q, jakes es6 polyfill or any of the 5000+ libs for Promises [1] though I suggest one limits the scope to the other 200+ libraries claiming A+ support! [2] ;P [1] https://www.npmjs.com/search?q=Promise [2] https://www.npmjs.com/search?q=Promise+A%2B On Tue, Jul 7, 2015 at 10:53 AM, Tyler Freeman ty...@tappur.co wrote: I'd just like to mention that jQuery has promises built-in as the $.Deferred object. It's not quite the same as the official Promises spec, but can be used similarly in most cases. On July 7, 2015 9:42:10 AM PDT, Brian LeRoux b...@brian.io wrote: We experimented with Promise polyfills and had nothing but trouble. I'd like to preface by saying: lets not get into a theory war. Some people like promises (fine) and some do not (also fine). My stance is that we should leave that choice up to our end users. Lets throw some facts out to colour things. 1. Promises are a spec that will land in browsers natively [1] 2. Promises as a concept have MANY polyfill implementations 3. The polyfill landscape is largely divergent and implement different flavors of the concept Since we implement a User Agent we *could* polyfill to spec. As a plugin. (Jake's is probably best [2]) I'd be in favor of this and making that THE plugin dep for companion plugins that require Promises. The problem with this is #3. If we have a window.Promise it could be clobbered by a user that is not super aware of how things are composed under the hood. If it *could* happen guess what: it will. Some frameworks even force the idea of Promises that may not be totally on spec. Older jQuery and Ember come to mind. The other way to solve this problem is patience. This is the path I am most in favor of. Lets wait out the native implementation to land in the various webviews and at such time we can start using those. Plugins really should wrap device and operating system API's (in my opinion) and we should leave library code for the user land to figure out. The Promise API *is a library* until such time as it has been implemented into the language runtimes natively (and not just speculatively standardized). Ok I guess faltered into the theory war part there. ;) [1] https://promisesaplus.com/ [2] https://github.com/jakearchibald/es6-promise On Mon, Jul 6, 2015 at 6:45 PM, Murat Sutunc mura...@microsoft.com wrote: Hey Paul, Welcome to Cordova! I've looked at your changes on github and have some early feedback. 1) As per spec you return a Promise on battery.js but to my knowledge we don't have a fallback for ES6 Promises on platforms that don't support it yet. I would like to know what other committers think about this problem. 2) I think the old API and the new API can co-exist for a while before we deprecate and remove the old one. I see that the new spec uses a different method name so we should be fine here. Thanks, Murat -Original Message- From: Paul Contat [mailto:contat.p...@gmail.com] Sent: Wednesday, July 1, 2015 12:38 AM To: dev@cordova.apache.org Subject: Introduction Hello everyone, My name is Paul Contat, and I'm an engineering student and currently doing an internship at W3C focusing on aligning cordova API with W3C ones where applicable, as part of the HTML5Apps EU project ( http://html5apps-project.eu/2014/08/27/aligning-cordova-and-w3c-device-apis/ ) For my internship, I’m planning to contribute to the cordova project, starting by the BatteryStatus API ( https://issues.apache.org/jira/browse/CB-6065) if it’s possible. I've just signed the ICLA, created an account on Apache JIRA so I’m ready to start and submitted my first pull request:
Re: Introduction
When did we start discussing these proposals on GitHub instead of the dev list? That's kind of what the dev list is for, and I'm pretty sure it's not the Apache Way to do this. In fact, I wasn't aware that we were using our GitHub org for anything until now. On Tue, Jul 7, 2015, 12:01 PM julio cesar sanchez jcesarmob...@gmail.com wrote: It's only supported by android 5 webview (12% share right now), so I think the plugin makes sense for now even if it's going to be deprecated in the future and replaced by the browser battery status when more people have android 5 or greater But the discussion about this should be better on the cordova-discuss https https://github.com/cordova/cordova-discuss/issues:// https://github.com/cordova/cordova-discuss/issuesgithub.com https://github.com/cordova/cordova-discuss/issues/ https://github.com/cordova/cordova-discuss/issuescordova https://github.com/cordova/cordova-discuss/issues/ https://github.com/cordova/cordova-discuss/issuescordova-discuss https://github.com/cordova/cordova-discuss/issues/issues https://github.com/cordova/cordova-discuss/issues 2015-07-07 20:42 GMT+02:00 Joe Bowser bows...@gmail.com: I hate to dash your hopes, but I think that we should probably not have a Battery Status plugin and defer to browser behaviour on Android, since Battery Status is supported on the browser with the latest Android WebViews, and with Crosswalk. Any plugin should just be glue code for facilitating this behaviour, similar to how we deprecated the Geolocation plugin on Android in favour to Browser Geolocation. That's my two cents on the issue right now. On Tue, Jul 7, 2015 at 11:17 AM Brian LeRoux b...@brian.io wrote: exactly so and by all means please feel free to use that, bluebird, rsvp, q, jakes es6 polyfill or any of the 5000+ libs for Promises [1] though I suggest one limits the scope to the other 200+ libraries claiming A+ support! [2] ;P [1] https://www.npmjs.com/search?q=Promise [2] https://www.npmjs.com/search?q=Promise+A%2B On Tue, Jul 7, 2015 at 10:53 AM, Tyler Freeman ty...@tappur.co wrote: I'd just like to mention that jQuery has promises built-in as the $.Deferred object. It's not quite the same as the official Promises spec, but can be used similarly in most cases. On July 7, 2015 9:42:10 AM PDT, Brian LeRoux b...@brian.io wrote: We experimented with Promise polyfills and had nothing but trouble. I'd like to preface by saying: lets not get into a theory war. Some people like promises (fine) and some do not (also fine). My stance is that we should leave that choice up to our end users. Lets throw some facts out to colour things. 1. Promises are a spec that will land in browsers natively [1] 2. Promises as a concept have MANY polyfill implementations 3. The polyfill landscape is largely divergent and implement different flavors of the concept Since we implement a User Agent we *could* polyfill to spec. As a plugin. (Jake's is probably best [2]) I'd be in favor of this and making that THE plugin dep for companion plugins that require Promises. The problem with this is #3. If we have a window.Promise it could be clobbered by a user that is not super aware of how things are composed under the hood. If it *could* happen guess what: it will. Some frameworks even force the idea of Promises that may not be totally on spec. Older jQuery and Ember come to mind. The other way to solve this problem is patience. This is the path I am most in favor of. Lets wait out the native implementation to land in the various webviews and at such time we can start using those. Plugins really should wrap device and operating system API's (in my opinion) and we should leave library code for the user land to figure out. The Promise API *is a library* until such time as it has been implemented into the language runtimes natively (and not just speculatively standardized). Ok I guess faltered into the theory war part there. ;) [1] https://promisesaplus.com/ [2] https://github.com/jakearchibald/es6-promise On Mon, Jul 6, 2015 at 6:45 PM, Murat Sutunc mura...@microsoft.com wrote: Hey Paul, Welcome to Cordova! I've looked at your changes on github and have some early feedback. 1) As per spec you return a Promise on battery.js but to my knowledge we don't have a fallback for ES6 Promises on platforms that don't support it yet. I would like to know what other committers think about this problem. 2) I think the old API and the new API can co-exist for a while before we deprecate and remove the old one. I see that the new spec uses a different method name so we should be fine here. Thanks, Murat -Original Message- From: Paul Contat [mailto:contat.p...@gmail.com] Sent: Wednesday, July 1, 2015 12:38 AM
Re: Introduction
If someone wants to take a stab at coming up with a proposal, go for it. Sounds like we need to have more discussion on what that should look like. I like Jesse's suggestions of looking for browser implementations first. You could look into adding a promise polyfill as a cordova plugins and have it as a dependency. I found [1] after a quick google search. [1] https://github.com/vstirbu/PromisesPlugin/ On Tue, Jul 7, 2015 at 12:01 PM, julio cesar sanchez jcesarmob...@gmail.com wrote: It's only supported by android 5 webview (12% share right now), so I think the plugin makes sense for now even if it's going to be deprecated in the future and replaced by the browser battery status when more people have android 5 or greater But the discussion about this should be better on the cordova-discuss https://github.com/cordova/cordova-discuss/issues 2015-07-07 20:42 GMT+02:00 Joe Bowser bows...@gmail.com: I hate to dash your hopes, but I think that we should probably not have a Battery Status plugin and defer to browser behaviour on Android, since Battery Status is supported on the browser with the latest Android WebViews, and with Crosswalk. Any plugin should just be glue code for facilitating this behaviour, similar to how we deprecated the Geolocation plugin on Android in favour to Browser Geolocation. That's my two cents on the issue right now. On Tue, Jul 7, 2015 at 11:17 AM Brian LeRoux b...@brian.io wrote: exactly so and by all means please feel free to use that, bluebird, rsvp, q, jakes es6 polyfill or any of the 5000+ libs for Promises [1] though I suggest one limits the scope to the other 200+ libraries claiming A+ support! [2] ;P [1] https://www.npmjs.com/search?q=Promise [2] https://www.npmjs.com/search?q=Promise+A%2B On Tue, Jul 7, 2015 at 10:53 AM, Tyler Freeman ty...@tappur.co wrote: I'd just like to mention that jQuery has promises built-in as the $.Deferred object. It's not quite the same as the official Promises spec, but can be used similarly in most cases. On July 7, 2015 9:42:10 AM PDT, Brian LeRoux b...@brian.io wrote: We experimented with Promise polyfills and had nothing but trouble. I'd like to preface by saying: lets not get into a theory war. Some people like promises (fine) and some do not (also fine). My stance is that we should leave that choice up to our end users. Lets throw some facts out to colour things. 1. Promises are a spec that will land in browsers natively [1] 2. Promises as a concept have MANY polyfill implementations 3. The polyfill landscape is largely divergent and implement different flavors of the concept Since we implement a User Agent we *could* polyfill to spec. As a plugin. (Jake's is probably best [2]) I'd be in favor of this and making that THE plugin dep for companion plugins that require Promises. The problem with this is #3. If we have a window.Promise it could be clobbered by a user that is not super aware of how things are composed under the hood. If it *could* happen guess what: it will. Some frameworks even force the idea of Promises that may not be totally on spec. Older jQuery and Ember come to mind. The other way to solve this problem is patience. This is the path I am most in favor of. Lets wait out the native implementation to land in the various webviews and at such time we can start using those. Plugins really should wrap device and operating system API's (in my opinion) and we should leave library code for the user land to figure out. The Promise API *is a library* until such time as it has been implemented into the language runtimes natively (and not just speculatively standardized). Ok I guess faltered into the theory war part there. ;) [1] https://promisesaplus.com/ [2] https://github.com/jakearchibald/es6-promise On Mon, Jul 6, 2015 at 6:45 PM, Murat Sutunc mura...@microsoft.com wrote: Hey Paul, Welcome to Cordova! I've looked at your changes on github and have some early feedback. 1) As per spec you return a Promise on battery.js but to my knowledge we don't have a fallback for ES6 Promises on platforms that don't support it yet. I would like to know what other committers think about this problem. 2) I think the old API and the new API can co-exist for a while before we deprecate and remove the old one. I see that the new spec uses a different method name so we should be fine here. Thanks, Murat -Original Message- From: Paul Contat [mailto:contat.p...@gmail.com] Sent: Wednesday, July 1, 2015 12:38 AM To: dev@cordova.apache.org Subject: Introduction Hello everyone, My name is Paul Contat, and
Re: Introduction
exactly so and by all means please feel free to use that, bluebird, rsvp, q, jakes es6 polyfill or any of the 5000+ libs for Promises [1] though I suggest one limits the scope to the other 200+ libraries claiming A+ support! [2] ;P [1] https://www.npmjs.com/search?q=Promise [2] https://www.npmjs.com/search?q=Promise+A%2B On Tue, Jul 7, 2015 at 10:53 AM, Tyler Freeman ty...@tappur.co wrote: I'd just like to mention that jQuery has promises built-in as the $.Deferred object. It's not quite the same as the official Promises spec, but can be used similarly in most cases. On July 7, 2015 9:42:10 AM PDT, Brian LeRoux b...@brian.io wrote: We experimented with Promise polyfills and had nothing but trouble. I'd like to preface by saying: lets not get into a theory war. Some people like promises (fine) and some do not (also fine). My stance is that we should leave that choice up to our end users. Lets throw some facts out to colour things. 1. Promises are a spec that will land in browsers natively [1] 2. Promises as a concept have MANY polyfill implementations 3. The polyfill landscape is largely divergent and implement different flavors of the concept Since we implement a User Agent we *could* polyfill to spec. As a plugin. (Jake's is probably best [2]) I'd be in favor of this and making that THE plugin dep for companion plugins that require Promises. The problem with this is #3. If we have a window.Promise it could be clobbered by a user that is not super aware of how things are composed under the hood. If it *could* happen guess what: it will. Some frameworks even force the idea of Promises that may not be totally on spec. Older jQuery and Ember come to mind. The other way to solve this problem is patience. This is the path I am most in favor of. Lets wait out the native implementation to land in the various webviews and at such time we can start using those. Plugins really should wrap device and operating system API's (in my opinion) and we should leave library code for the user land to figure out. The Promise API *is a library* until such time as it has been implemented into the language runtimes natively (and not just speculatively standardized). Ok I guess faltered into the theory war part there. ;) [1] https://promisesaplus.com/ [2] https://github.com/jakearchibald/es6-promise On Mon, Jul 6, 2015 at 6:45 PM, Murat Sutunc mura...@microsoft.com wrote: Hey Paul, Welcome to Cordova! I've looked at your changes on github and have some early feedback. 1) As per spec you return a Promise on battery.js but to my knowledge we don't have a fallback for ES6 Promises on platforms that don't support it yet. I would like to know what other committers think about this problem. 2) I think the old API and the new API can co-exist for a while before we deprecate and remove the old one. I see that the new spec uses a different method name so we should be fine here. Thanks, Murat -Original Message- From: Paul Contat [mailto:contat.p...@gmail.com] Sent: Wednesday, July 1, 2015 12:38 AM To: dev@cordova.apache.org Subject: Introduction Hello everyone, My name is Paul Contat, and I'm an engineering student and currently doing an internship at W3C focusing on aligning cordova API with W3C ones where applicable, as part of the HTML5Apps EU project ( http://html5apps-project.eu/2014/08/27/aligning-cordova-and-w3c-device-apis/ ) For my internship, I’m planning to contribute to the cordova project, starting by the BatteryStatus API ( https://issues.apache.org/jira/browse/CB-6065) if it’s possible. I've just signed the ICLA, created an account on Apache JIRA so I’m ready to start and submitted my first pull request: https://github.com/apache/cordova-plugin-battery-status/pull/24 I’m looking forward to feedback on whether I’m on the right path for updating the Battery plugin API; I’m in particular interested to understand if and how the current API should be deprecated once we get to a stage where the new API is deemed in a good enough shape. Best regards, Paul -- Tyler Freeman CTO, Tappur http://tappur.co Sent from mobile
[GitHub] cordova-android pull request: Update licenses
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/190 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[DISCUSS] Cordova-Android 4.0.3 Release
Hey I discovered that on the 4.0.x branch, we're still setting the minSdkTarget to 10, even though we don't support Gingerbread anymore. I think we should release a 4.0.3 version where we set it to 13. This is a trivial change, and it's already been done on master. Thoughts?? Joe
[GitHub] cordova-plugin-network-information pull request: CB-9302 remove tr...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-network-information/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device-motion pull request: CB-9305 remove travis-c...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: Introduction
Coming back to Joe's point of if the browser has the API, then the plugin should not implement it. Is there a way for a plugin to not clobber the namespace if the browser already implements it? This would be a nice way to support Android 5+ with the browser implementation and the older version with a custom Cordova implementation - considering they have the *same* behavior. +1 to having a promise polyfill implementation in a shared plugin. Also, there is the orientation spec - which would be great to implement in Cordova: http://www.w3.org/TR/screen-orientation/ Thanks, Nikhil -Original Message- From: brian.ler...@gmail.com [mailto:brian.ler...@gmail.com] On Behalf Of Brian LeRoux Sent: Tuesday, July 7, 2015 1:20 PM To: dev@cordova.apache.org Cc: Tyler Freeman Subject: Re: Introduction Yes, lets not bikeshed block and tackle for things that are very solved (async) even if the aesthetics are not to everyone's taste or on trend. Contacts API is heavily broken, used and needed. Its a great suggestion for something that would be high impact and actually important to userland. On Tue, Jul 7, 2015 at 1:06 PM, Steven Gill stevengil...@gmail.com wrote: If someone wants to take a stab at coming up with a proposal, go for it. Sounds like we need to have more discussion on what that should look like. I like Jesse's suggestions of looking for browser implementations first. You could look into adding a promise polyfill as a cordova plugins and have it as a dependency. I found [1] after a quick google search. [1] https://github.com/vstirbu/PromisesPlugin/ On Tue, Jul 7, 2015 at 12:01 PM, julio cesar sanchez jcesarmob...@gmail.com wrote: It's only supported by android 5 webview (12% share right now), so I think the plugin makes sense for now even if it's going to be deprecated in the future and replaced by the browser battery status when more people have android 5 or greater But the discussion about this should be better on the cordova-discuss https://github.com/cordova/cordova-discuss/issues 2015-07-07 20:42 GMT+02:00 Joe Bowser bows...@gmail.com: I hate to dash your hopes, but I think that we should probably not have a Battery Status plugin and defer to browser behaviour on Android, since Battery Status is supported on the browser with the latest Android WebViews, and with Crosswalk. Any plugin should just be glue code for facilitating this behaviour, similar to how we deprecated the Geolocation plugin on Android in favour to Browser Geolocation. That's my two cents on the issue right now. On Tue, Jul 7, 2015 at 11:17 AM Brian LeRoux b...@brian.io wrote: exactly so and by all means please feel free to use that, bluebird, rsvp, q, jakes es6 polyfill or any of the 5000+ libs for Promises [1] though I suggest one limits the scope to the other 200+ libraries claiming A+ support! [2] ;P [1] https://www.npmjs.com/search?q=Promise [2] https://www.npmjs.com/search?q=Promise+A%2B On Tue, Jul 7, 2015 at 10:53 AM, Tyler Freeman ty...@tappur.co wrote: I'd just like to mention that jQuery has promises built-in as the $.Deferred object. It's not quite the same as the official Promises spec, but can be used similarly in most cases. On July 7, 2015 9:42:10 AM PDT, Brian LeRoux b...@brian.io wrote: We experimented with Promise polyfills and had nothing but trouble. I'd like to preface by saying: lets not get into a theory war. Some people like promises (fine) and some do not (also fine). My stance is that we should leave that choice up to our end users. Lets throw some facts out to colour things. 1. Promises are a spec that will land in browsers natively [1] 2. Promises as a concept have MANY polyfill implementations 3. The polyfill landscape is largely divergent and implement different flavors of the concept Since we implement a User Agent we *could* polyfill to spec. As a plugin. (Jake's is probably best [2]) I'd be in favor of this and making that THE plugin dep for companion plugins that require Promises. The problem with this is #3. If we have a window.Promise it could be clobbered by a user that is not super aware of how things are composed under the hood. If it *could* happen guess what: it will. Some frameworks even force the idea of Promises that may not be totally on spec. Older jQuery and Ember come to mind. The other way to solve this problem is patience. This is the path I am most in favor of. Lets wait out the native implementation to land in the various webviews and at such time we can start using those. Plugins really should wrap device and
Re: [DISCUSS] Cordova-Android 4.0.3 Release
13? That's honeycomb, I think it should be 14 El 7/7/2015 23:23, Joe Bowser bows...@gmail.com escribió: Hey I discovered that on the 4.0.x branch, we're still setting the minSdkTarget to 10, even though we don't support Gingerbread anymore. I think we should release a 4.0.3 version where we set it to 13. This is a trivial change, and it's already been done on master. Thoughts?? Joe
Re: [DISCUSS] Cordova-Android 4.0.3 Release
+1 to that. The min SDK level of 10 is causing problems when I try to add support libraries for the push plugin. Simon Mac Donald http://hi.im/simonmacdonald On Tue, Jul 7, 2015 at 5:33 PM, Joe Bowser bows...@gmail.com wrote: Sorry, that was a typo, yes it should be 14. On Tue, Jul 7, 2015 at 2:26 PM julio cesar sanchez jcesarmob...@gmail.com wrote: 13? That's honeycomb, I think it should be 14 El 7/7/2015 23:23, Joe Bowser bows...@gmail.com escribió: Hey I discovered that on the 4.0.x branch, we're still setting the minSdkTarget to 10, even though we don't support Gingerbread anymore. I think we should release a 4.0.3 version where we set it to 13. This is a trivial change, and it's already been done on master. Thoughts?? Joe
[GitHub] cordova-plugin-media-capture pull request: Remove TravisCI integra...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/39 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device-motion pull request: CB-9305 remove travis-c...
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-device-motion/pull/31 CB-9305 remove travis-ci integration You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-plugin-device-motion CB-9305 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-device-motion/pull/31.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #31 commit e62e3fe891041b707c9aa39f0e430de64dd662cc Author: Jesse MacFadyen purplecabb...@gmail.com Date: 2015-07-07T22:01:33Z remove travis-ci integration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Introduction
Yes, lets not bikeshed block and tackle for things that are very solved (async) even if the aesthetics are not to everyone's taste or on trend. Contacts API is heavily broken, used and needed. Its a great suggestion for something that would be high impact and actually important to userland. On Tue, Jul 7, 2015 at 1:06 PM, Steven Gill stevengil...@gmail.com wrote: If someone wants to take a stab at coming up with a proposal, go for it. Sounds like we need to have more discussion on what that should look like. I like Jesse's suggestions of looking for browser implementations first. You could look into adding a promise polyfill as a cordova plugins and have it as a dependency. I found [1] after a quick google search. [1] https://github.com/vstirbu/PromisesPlugin/ On Tue, Jul 7, 2015 at 12:01 PM, julio cesar sanchez jcesarmob...@gmail.com wrote: It's only supported by android 5 webview (12% share right now), so I think the plugin makes sense for now even if it's going to be deprecated in the future and replaced by the browser battery status when more people have android 5 or greater But the discussion about this should be better on the cordova-discuss https://github.com/cordova/cordova-discuss/issues 2015-07-07 20:42 GMT+02:00 Joe Bowser bows...@gmail.com: I hate to dash your hopes, but I think that we should probably not have a Battery Status plugin and defer to browser behaviour on Android, since Battery Status is supported on the browser with the latest Android WebViews, and with Crosswalk. Any plugin should just be glue code for facilitating this behaviour, similar to how we deprecated the Geolocation plugin on Android in favour to Browser Geolocation. That's my two cents on the issue right now. On Tue, Jul 7, 2015 at 11:17 AM Brian LeRoux b...@brian.io wrote: exactly so and by all means please feel free to use that, bluebird, rsvp, q, jakes es6 polyfill or any of the 5000+ libs for Promises [1] though I suggest one limits the scope to the other 200+ libraries claiming A+ support! [2] ;P [1] https://www.npmjs.com/search?q=Promise [2] https://www.npmjs.com/search?q=Promise+A%2B On Tue, Jul 7, 2015 at 10:53 AM, Tyler Freeman ty...@tappur.co wrote: I'd just like to mention that jQuery has promises built-in as the $.Deferred object. It's not quite the same as the official Promises spec, but can be used similarly in most cases. On July 7, 2015 9:42:10 AM PDT, Brian LeRoux b...@brian.io wrote: We experimented with Promise polyfills and had nothing but trouble. I'd like to preface by saying: lets not get into a theory war. Some people like promises (fine) and some do not (also fine). My stance is that we should leave that choice up to our end users. Lets throw some facts out to colour things. 1. Promises are a spec that will land in browsers natively [1] 2. Promises as a concept have MANY polyfill implementations 3. The polyfill landscape is largely divergent and implement different flavors of the concept Since we implement a User Agent we *could* polyfill to spec. As a plugin. (Jake's is probably best [2]) I'd be in favor of this and making that THE plugin dep for companion plugins that require Promises. The problem with this is #3. If we have a window.Promise it could be clobbered by a user that is not super aware of how things are composed under the hood. If it *could* happen guess what: it will. Some frameworks even force the idea of Promises that may not be totally on spec. Older jQuery and Ember come to mind. The other way to solve this problem is patience. This is the path I am most in favor of. Lets wait out the native implementation to land in the various webviews and at such time we can start using those. Plugins really should wrap device and operating system API's (in my opinion) and we should leave library code for the user land to figure out. The Promise API *is a library* until such time as it has been implemented into the language runtimes natively (and not just speculatively standardized). Ok I guess faltered into the theory war part there. ;) [1] https://promisesaplus.com/ [2] https://github.com/jakearchibald/es6-promise On Mon, Jul 6, 2015 at 6:45 PM, Murat Sutunc mura...@microsoft.com wrote: Hey Paul, Welcome to Cordova! I've looked at your changes on github and have some early feedback. 1) As per spec you return a Promise on battery.js but to my knowledge we don't have a fallback for ES6 Promises on platforms that don't support it yet. I would like to know what other committers think
[GitHub] cordova-plugin-media-capture pull request: Remove TravisCI integra...
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/39 Remove TravisCI integration You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-plugin-media-capture CB-9301 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-media-capture/pull/39.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #39 commit 2c5617c746dac5d0f330175773d0d55fb4f43bdf Author: Jesse MacFadyen purplecabb...@gmail.com Date: 2015-07-07T21:24:26Z Remove TravisCI integration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Update min SDK version to 14
Github user macdonst closed the pull request at: https://github.com/apache/cordova-android/pull/194 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-network-information pull request: CB-9302 remove tr...
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/28 CB-9302 remove travis-ci integration You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-plugin-network-information CB-9302 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-network-information/pull/28.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #28 commit 0464a97742bd5727061f5e0680dfae9048e334fd Author: Jesse MacFadyen purplecabb...@gmail.com Date: 2015-07-07T21:52:25Z remove travis-ci integration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: Cordova July Hangout
In case you are interested in this and have not responded. Here's the doodle link: http://doodle.com/vut5qrb4gy7dtmw9 I plan to close this by tomorrow and send out the final date/time. Thanks! Thanks, Nikhil -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Monday, July 6, 2015 10:16 AM To: dev@cordova.apache.org Subject: Re: Cordova July Hangout Let's do it! On Jul 1, 2015 10:57 AM, Nikhil Khandelwal nikhi...@microsoft.com wrote: I was wondering if it is a good time for a hangout. Here are few good topics for discussion: 1. Re-working cordova-lib - cordova platform interactions. Review new API - Vladimir https://github.com/cordova/cordova-discuss/pull/9 2. Status of testing infrastructure - what are the next steps here ? Is there scope for consolidation fixing failing tests? Better release testing. - Dmitry 3. Documentation website and workflow improvements - Dmitry https://github.com/cordova/cordova-discuss/pull/11 4. iOS 4 release - status update - Shazron 5. Browserify updates - Steve Gill 6. Cordova plugin npm search - Demo next steps - Murat https://github.com/cordova/cordova-discuss/issues/7 Feel free to add to this list: https://docs.google.com/document/d/1Ig-qAyIbqKPtTCGkYaqJ2VYufPweTGDm5A w-dFGpjRc/edit I propose we meet in the week of 7/13. Here's the doodle for this: http://doodle.com/vut5qrb4gy7dtmw9 Thanks, Nikhil (I understand folks for Adobe are out this week - hopefully we can see some responses next week to meet the week after) - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-9185 Fix signed release build exc...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-android/pull/193#issuecomment-119340436 Thanks for making the PR! :clap: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Cordova-Android 4.0.3 Release
Sorry, that was a typo, yes it should be 14. On Tue, Jul 7, 2015 at 2:26 PM julio cesar sanchez jcesarmob...@gmail.com wrote: 13? That's honeycomb, I think it should be 14 El 7/7/2015 23:23, Joe Bowser bows...@gmail.com escribió: Hey I discovered that on the 4.0.x branch, we're still setting the minSdkTarget to 10, even though we don't support Gingerbread anymore. I think we should release a 4.0.3 version where we set it to 13. This is a trivial change, and it's already been done on master. Thoughts?? Joe
[GitHub] cordova-plugin-console pull request: CB-9303 remove travi-ci integ...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-console/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-console pull request: CB-9303 remove travi-ci integ...
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-console/pull/12 CB-9303 remove travi-ci integration You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-plugin-console CB-9303 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-console/pull/12.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12 commit 9ad6b60a3d64b79081f72580392c3bc4986f140c Author: Jesse MacFadyen purplecabb...@gmail.com Date: 2015-07-07T21:56:05Z remove travi-ci integration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: CB-9304 remove travis-ci int...
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/66 CB-9304 remove travis-ci integration You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-plugin-contacts CB-9304 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-contacts/pull/66.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #66 commit 426285615b69bce3c8d5a53bb544fdaa62beb199 Author: Jesse MacFadyen purplecabb...@gmail.com Date: 2015-07-07T21:58:58Z remove travis-ci integration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: CB-9304 remove travis-ci int...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/66 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Internal routing error on plugins.cordova.io
plugins.cordova.io is back up. On 7/7/15, 10:07 AM, Homer, Tony tony.ho...@intel.com wrote: Anyone know who can investigate and fix? - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-globalization pull request: CB-9309 remove travis-c...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-globalization/pull/37 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34101903
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ License); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+
+var Q = require('q'),
+fs= require('fs'),
+/* jshint ignore:start */ // 'path' only used in ignored blocks
+path = require('path'),
+/* jshint ignore:end */
+proc = require('child_process');
+
+// neither 'exec' nor 'spawn' was sufficient because we need to pass
arguments via spawn
+// but also need to be able to capture stdout / stderr
+function run(cmd, args, opt_cwd) {
+var d = Q.defer();
+try {
+var child = proc.spawn(cmd, args, {cwd: opt_cwd, maxBuffer:
1024000});
+var stdout = '', stderr = '';
+child.stdout.on('data', function(s) { stdout += s; });
+child.stderr.on('data', function(s) { stderr += s; });
+child.on('exit', function(code) {
+if (code) {
+d.reject(stderr);
+} else {
+d.resolve(stdout);
+}
+});
+} catch(e) {
+console.error('error caught: ' + e);
+d.reject(e);
+}
+return d.promise;
+}
+
+function DeploymentTool() {
+
+}
+
+/**
+ * Determines whether the requested version of the deployment tool is
available.
+ * @returns True if the deployment tool can function; false if not.
+ */
+DeploymentTool.prototype.isAvailable = function() {
+return fs.existsSync(this.path);
+};
+
+/**
+ * Enumerates devices attached to the development machine.
+ * @returns A Promise for an array of objects, which should be passed into
other functions to represent the device.
+ * @remarks The returned objects contain 'index', 'name', and 'type'
properties indicating basic information about them,
+ *which is limited to the information provided by the system. Other
properties may also be included, but they are
+ *specific to the deployment tool which created them and are likely
used internally.
+ */
+DeploymentTool.prototype.enumerateDevices = function() {
+return Q.reject('May not use DeploymentTool directly, instead get an
instance from DeploymentTool.getDeploymentTool()');
+};
+
+/**
+ * Installs an app package to the target device.
+ * @returns A Promise which will be fulfilled on success or rejected on
failure.
+ * @param pathToAppxPackage The path to the .appx package to install.
+ * @param targetDevice An object returned from a successful call to
enumerateDevices.
+ * @shouldLaunch Indicates whether to launch the app after installing it.
+ * @shouldUpdate Indicates whether to explicitly update the app, or
install clean.
+ * @pin Optionally provided if the device requires pairing for deployment.
+ */
+DeploymentTool.prototype.installAppPackage = function(pathToAppxPackage,
targetDevice, shouldLaunch, shouldUpdate, pin) {
+return Q.reject('May not use DeploymentTool directly, instead get an
instance from DeploymentTool.getDeploymentTool()');
+};
+
+/**
+ * Uninstalls an app package from the target device.
+ * @returns A Promise which will be fulfilled on success or rejected on
failure.
+ * @param packageInfo The app package name or Phone GUID representing the
app.
+ * @param targetDevice An object returned from a successful call to
enumerateDevices.
+ */
+DeploymentTool.prototype.uninstallAppPackage = function(packageInfo,
targetDevice) {
+return Q.reject('Unable to uninstall any app packages because that
feature is not supported.');
+};
+
+/**
+ * Gets a list of installed apps on the target device. This function is
not supported for
+ * Windows Phone 8.1.
+ * @param targetDevice {Object} An object returned from a successful
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34101879
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ License); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+
+var Q = require('q'),
+fs= require('fs'),
+/* jshint ignore:start */ // 'path' only used in ignored blocks
+path = require('path'),
+/* jshint ignore:end */
+proc = require('child_process');
+
+// neither 'exec' nor 'spawn' was sufficient because we need to pass
arguments via spawn
+// but also need to be able to capture stdout / stderr
+function run(cmd, args, opt_cwd) {
+var d = Q.defer();
+try {
+var child = proc.spawn(cmd, args, {cwd: opt_cwd, maxBuffer:
1024000});
+var stdout = '', stderr = '';
+child.stdout.on('data', function(s) { stdout += s; });
+child.stderr.on('data', function(s) { stderr += s; });
+child.on('exit', function(code) {
+if (code) {
+d.reject(stderr);
+} else {
+d.resolve(stdout);
+}
+});
+} catch(e) {
+console.error('error caught: ' + e);
+d.reject(e);
+}
+return d.promise;
+}
+
+function DeploymentTool() {
+
+}
+
+/**
+ * Determines whether the requested version of the deployment tool is
available.
+ * @returns True if the deployment tool can function; false if not.
+ */
+DeploymentTool.prototype.isAvailable = function() {
+return fs.existsSync(this.path);
+};
+
+/**
+ * Enumerates devices attached to the development machine.
+ * @returns A Promise for an array of objects, which should be passed into
other functions to represent the device.
+ * @remarks The returned objects contain 'index', 'name', and 'type'
properties indicating basic information about them,
+ *which is limited to the information provided by the system. Other
properties may also be included, but they are
+ *specific to the deployment tool which created them and are likely
used internally.
+ */
+DeploymentTool.prototype.enumerateDevices = function() {
+return Q.reject('May not use DeploymentTool directly, instead get an
instance from DeploymentTool.getDeploymentTool()');
+};
+
+/**
+ * Installs an app package to the target device.
+ * @returns A Promise which will be fulfilled on success or rejected on
failure.
+ * @param pathToAppxPackage The path to the .appx package to install.
+ * @param targetDevice An object returned from a successful call to
enumerateDevices.
+ * @shouldLaunch Indicates whether to launch the app after installing it.
+ * @shouldUpdate Indicates whether to explicitly update the app, or
install clean.
+ * @pin Optionally provided if the device requires pairing for deployment.
+ */
+DeploymentTool.prototype.installAppPackage = function(pathToAppxPackage,
targetDevice, shouldLaunch, shouldUpdate, pin) {
+return Q.reject('May not use DeploymentTool directly, instead get an
instance from DeploymentTool.getDeploymentTool()');
+};
+
+/**
+ * Uninstalls an app package from the target device.
+ * @returns A Promise which will be fulfilled on success or rejected on
failure.
+ * @param packageInfo The app package name or Phone GUID representing the
app.
+ * @param targetDevice An object returned from a successful call to
enumerateDevices.
+ */
+DeploymentTool.prototype.uninstallAppPackage = function(packageInfo,
targetDevice) {
+return Q.reject('Unable to uninstall any app packages because that
feature is not supported.');
+};
+
+/**
+ * Gets a list of installed apps on the target device. This function is
not supported for
--- End diff --
nit: trailing whitespace
---
If your project is set up for it, you can
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34101895
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ License); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+
+var Q = require('q'),
+fs= require('fs'),
+/* jshint ignore:start */ // 'path' only used in ignored blocks
+path = require('path'),
+/* jshint ignore:end */
+proc = require('child_process');
+
+// neither 'exec' nor 'spawn' was sufficient because we need to pass
arguments via spawn
+// but also need to be able to capture stdout / stderr
+function run(cmd, args, opt_cwd) {
+var d = Q.defer();
+try {
+var child = proc.spawn(cmd, args, {cwd: opt_cwd, maxBuffer:
1024000});
+var stdout = '', stderr = '';
+child.stdout.on('data', function(s) { stdout += s; });
+child.stderr.on('data', function(s) { stderr += s; });
+child.on('exit', function(code) {
+if (code) {
+d.reject(stderr);
+} else {
+d.resolve(stdout);
+}
+});
+} catch(e) {
+console.error('error caught: ' + e);
+d.reject(e);
+}
+return d.promise;
+}
+
+function DeploymentTool() {
+
+}
+
+/**
+ * Determines whether the requested version of the deployment tool is
available.
+ * @returns True if the deployment tool can function; false if not.
+ */
+DeploymentTool.prototype.isAvailable = function() {
+return fs.existsSync(this.path);
+};
+
+/**
+ * Enumerates devices attached to the development machine.
+ * @returns A Promise for an array of objects, which should be passed into
other functions to represent the device.
+ * @remarks The returned objects contain 'index', 'name', and 'type'
properties indicating basic information about them,
+ *which is limited to the information provided by the system. Other
properties may also be included, but they are
+ *specific to the deployment tool which created them and are likely
used internally.
+ */
+DeploymentTool.prototype.enumerateDevices = function() {
+return Q.reject('May not use DeploymentTool directly, instead get an
instance from DeploymentTool.getDeploymentTool()');
+};
+
+/**
+ * Installs an app package to the target device.
+ * @returns A Promise which will be fulfilled on success or rejected on
failure.
+ * @param pathToAppxPackage The path to the .appx package to install.
+ * @param targetDevice An object returned from a successful call to
enumerateDevices.
+ * @shouldLaunch Indicates whether to launch the app after installing it.
+ * @shouldUpdate Indicates whether to explicitly update the app, or
install clean.
+ * @pin Optionally provided if the device requires pairing for deployment.
+ */
+DeploymentTool.prototype.installAppPackage = function(pathToAppxPackage,
targetDevice, shouldLaunch, shouldUpdate, pin) {
+return Q.reject('May not use DeploymentTool directly, instead get an
instance from DeploymentTool.getDeploymentTool()');
+};
+
+/**
+ * Uninstalls an app package from the target device.
+ * @returns A Promise which will be fulfilled on success or rejected on
failure.
+ * @param packageInfo The app package name or Phone GUID representing the
app.
+ * @param targetDevice An object returned from a successful call to
enumerateDevices.
+ */
+DeploymentTool.prototype.uninstallAppPackage = function(packageInfo,
targetDevice) {
+return Q.reject('Unable to uninstall any app packages because that
feature is not supported.');
+};
+
+/**
+ * Gets a list of installed apps on the target device. This function is
not supported for
+ * Windows Phone 8.1.
+ * @param targetDevice {Object} An object returned from a successful
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34101887
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ License); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+
+var Q = require('q'),
+fs= require('fs'),
+/* jshint ignore:start */ // 'path' only used in ignored blocks
+path = require('path'),
+/* jshint ignore:end */
+proc = require('child_process');
+
+// neither 'exec' nor 'spawn' was sufficient because we need to pass
arguments via spawn
+// but also need to be able to capture stdout / stderr
+function run(cmd, args, opt_cwd) {
+var d = Q.defer();
+try {
+var child = proc.spawn(cmd, args, {cwd: opt_cwd, maxBuffer:
1024000});
+var stdout = '', stderr = '';
+child.stdout.on('data', function(s) { stdout += s; });
+child.stderr.on('data', function(s) { stderr += s; });
+child.on('exit', function(code) {
+if (code) {
+d.reject(stderr);
+} else {
+d.resolve(stdout);
+}
+});
+} catch(e) {
+console.error('error caught: ' + e);
+d.reject(e);
+}
+return d.promise;
+}
+
+function DeploymentTool() {
+
+}
+
+/**
+ * Determines whether the requested version of the deployment tool is
available.
+ * @returns True if the deployment tool can function; false if not.
+ */
+DeploymentTool.prototype.isAvailable = function() {
+return fs.existsSync(this.path);
+};
+
+/**
+ * Enumerates devices attached to the development machine.
+ * @returns A Promise for an array of objects, which should be passed into
other functions to represent the device.
+ * @remarks The returned objects contain 'index', 'name', and 'type'
properties indicating basic information about them,
+ *which is limited to the information provided by the system. Other
properties may also be included, but they are
+ *specific to the deployment tool which created them and are likely
used internally.
+ */
+DeploymentTool.prototype.enumerateDevices = function() {
+return Q.reject('May not use DeploymentTool directly, instead get an
instance from DeploymentTool.getDeploymentTool()');
+};
+
+/**
+ * Installs an app package to the target device.
+ * @returns A Promise which will be fulfilled on success or rejected on
failure.
+ * @param pathToAppxPackage The path to the .appx package to install.
+ * @param targetDevice An object returned from a successful call to
enumerateDevices.
+ * @shouldLaunch Indicates whether to launch the app after installing it.
+ * @shouldUpdate Indicates whether to explicitly update the app, or
install clean.
+ * @pin Optionally provided if the device requires pairing for deployment.
+ */
+DeploymentTool.prototype.installAppPackage = function(pathToAppxPackage,
targetDevice, shouldLaunch, shouldUpdate, pin) {
+return Q.reject('May not use DeploymentTool directly, instead get an
instance from DeploymentTool.getDeploymentTool()');
+};
+
+/**
+ * Uninstalls an app package from the target device.
+ * @returns A Promise which will be fulfilled on success or rejected on
failure.
+ * @param packageInfo The app package name or Phone GUID representing the
app.
+ * @param targetDevice An object returned from a successful call to
enumerateDevices.
+ */
+DeploymentTool.prototype.uninstallAppPackage = function(packageInfo,
targetDevice) {
+return Q.reject('Unable to uninstall any app packages because that
feature is not supported.');
+};
+
+/**
+ * Gets a list of installed apps on the target device. This function is
not supported for
+ * Windows Phone 8.1.
+ * @param targetDevice {Object} An object returned from a successful
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34102430
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ License); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+
+var Q = require('q'),
+fs= require('fs'),
+/* jshint ignore:start */ // 'path' only used in ignored blocks
+path = require('path'),
+/* jshint ignore:end */
+proc = require('child_process');
+
+// neither 'exec' nor 'spawn' was sufficient because we need to pass
arguments via spawn
+// but also need to be able to capture stdout / stderr
+function run(cmd, args, opt_cwd) {
+var d = Q.defer();
+try {
+var child = proc.spawn(cmd, args, {cwd: opt_cwd, maxBuffer:
1024000});
+var stdout = '', stderr = '';
+child.stdout.on('data', function(s) { stdout += s; });
+child.stderr.on('data', function(s) { stderr += s; });
+child.on('exit', function(code) {
+if (code) {
+d.reject(stderr);
+} else {
+d.resolve(stdout);
+}
+});
+} catch(e) {
+console.error('error caught: ' + e);
+d.reject(e);
+}
+return d.promise;
+}
+
+function DeploymentTool() {
+
+}
+
+/**
+ * Determines whether the requested version of the deployment tool is
available.
+ * @returns True if the deployment tool can function; false if not.
+ */
+DeploymentTool.prototype.isAvailable = function() {
+return fs.existsSync(this.path);
+};
+
+/**
+ * Enumerates devices attached to the development machine.
+ * @returns A Promise for an array of objects, which should be passed into
other functions to represent the device.
+ * @remarks The returned objects contain 'index', 'name', and 'type'
properties indicating basic information about them,
+ *which is limited to the information provided by the system. Other
properties may also be included, but they are
+ *specific to the deployment tool which created them and are likely
used internally.
+ */
+DeploymentTool.prototype.enumerateDevices = function() {
+return Q.reject('May not use DeploymentTool directly, instead get an
instance from DeploymentTool.getDeploymentTool()');
+};
+
+/**
+ * Installs an app package to the target device.
+ * @returns A Promise which will be fulfilled on success or rejected on
failure.
+ * @param pathToAppxPackage The path to the .appx package to install.
+ * @param targetDevice An object returned from a successful call to
enumerateDevices.
+ * @shouldLaunch Indicates whether to launch the app after installing it.
+ * @shouldUpdate Indicates whether to explicitly update the app, or
install clean.
+ * @pin Optionally provided if the device requires pairing for deployment.
+ */
+DeploymentTool.prototype.installAppPackage = function(pathToAppxPackage,
targetDevice, shouldLaunch, shouldUpdate, pin) {
+return Q.reject('May not use DeploymentTool directly, instead get an
instance from DeploymentTool.getDeploymentTool()');
+};
+
+/**
+ * Uninstalls an app package from the target device.
+ * @returns A Promise which will be fulfilled on success or rejected on
failure.
+ * @param packageInfo The app package name or Phone GUID representing the
app.
+ * @param targetDevice An object returned from a successful call to
enumerateDevices.
+ */
+DeploymentTool.prototype.uninstallAppPackage = function(packageInfo,
targetDevice) {
+return Q.reject('Unable to uninstall any app packages because that
feature is not supported.');
+};
+
+/**
+ * Gets a list of installed apps on the target device. This function is
not supported for
+ * Windows Phone 8.1.
+ * @param targetDevice {Object} An object returned from a successful
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34104776
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ License); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+
+var Q = require('q'),
+fs= require('fs'),
+/* jshint ignore:start */ // 'path' only used in ignored blocks
+path = require('path'),
+/* jshint ignore:end */
+proc = require('child_process');
+
+// neither 'exec' nor 'spawn' was sufficient because we need to pass
arguments via spawn
+// but also need to be able to capture stdout / stderr
+function run(cmd, args, opt_cwd) {
+var d = Q.defer();
+try {
+var child = proc.spawn(cmd, args, {cwd: opt_cwd, maxBuffer:
1024000});
+var stdout = '', stderr = '';
+child.stdout.on('data', function(s) { stdout += s; });
+child.stderr.on('data', function(s) { stderr += s; });
+child.on('exit', function(code) {
+if (code) {
+d.reject(stderr);
+} else {
+d.resolve(stdout);
+}
+});
+} catch(e) {
+console.error('error caught: ' + e);
+d.reject(e);
+}
+return d.promise;
+}
+
+function DeploymentTool() {
+
+}
+
+/**
+ * Determines whether the requested version of the deployment tool is
available.
+ * @returns True if the deployment tool can function; false if not.
+ */
+DeploymentTool.prototype.isAvailable = function() {
+return fs.existsSync(this.path);
+};
+
+/**
+ * Enumerates devices attached to the development machine.
+ * @returns A Promise for an array of objects, which should be passed into
other functions to represent the device.
+ * @remarks The returned objects contain 'index', 'name', and 'type'
properties indicating basic information about them,
+ *which is limited to the information provided by the system. Other
properties may also be included, but they are
+ *specific to the deployment tool which created them and are likely
used internally.
+ */
+DeploymentTool.prototype.enumerateDevices = function() {
+return Q.reject('May not use DeploymentTool directly, instead get an
instance from DeploymentTool.getDeploymentTool()');
+};
+
+/**
+ * Installs an app package to the target device.
+ * @returns A Promise which will be fulfilled on success or rejected on
failure.
+ * @param pathToAppxPackage The path to the .appx package to install.
+ * @param targetDevice An object returned from a successful call to
enumerateDevices.
+ * @shouldLaunch Indicates whether to launch the app after installing it.
+ * @shouldUpdate Indicates whether to explicitly update the app, or
install clean.
+ * @pin Optionally provided if the device requires pairing for deployment.
+ */
+DeploymentTool.prototype.installAppPackage = function(pathToAppxPackage,
targetDevice, shouldLaunch, shouldUpdate, pin) {
+return Q.reject('May not use DeploymentTool directly, instead get an
instance from DeploymentTool.getDeploymentTool()');
+};
+
+/**
+ * Uninstalls an app package from the target device.
+ * @returns A Promise which will be fulfilled on success or rejected on
failure.
+ * @param packageInfo The app package name or Phone GUID representing the
app.
+ * @param targetDevice An object returned from a successful call to
enumerateDevices.
+ */
+DeploymentTool.prototype.uninstallAppPackage = function(packageInfo,
targetDevice) {
+return Q.reject('Unable to uninstall any app packages because that
feature is not supported.');
+};
+
+/**
+ * Gets a list of installed apps on the target device. This function is
not supported for
+ * Windows Phone 8.1.
+ * @param targetDevice {Object} An object returned from a successful
[GitHub] cordova-plugin-file pull request: CB-6703cordova-plugin-file
GitHub user ghenry22 opened a pull request: https://github.com/apache/cordova-plugin-file/pull/124 CB-6703cordova-plugin-file Fix as discussed in the comments on this Jira issue. Fix getFreeSpace always returns 0 on iOS Works on emulator and device now. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ghenry22/cordova-plugin-file CB-6703cordova-plugin-file Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/124.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #124 commit 655ab124586a0431e21431f28ba02db1718fdeb3 Author: ghenry22 ghenr...@gmail.com Date: 2015-07-07T10:29:28Z CB-6703cordova-plugin-file Fix getFreeSpace always returns 0 on iOS --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: CB-9308 remove travis-ci ...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-geolocation/pull/44 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: CB-9308 remove travis-ci ...
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/44 CB-9308 remove travis-ci integration You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-plugin-geolocation CB-9308 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-geolocation/pull/44.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #44 commit 239751944f6ae7332cb82562a625fe8a10cf0b04 Author: Jesse MacFadyen purplecabb...@gmail.com Date: 2015-07-07T22:09:48Z remove travis-ci integration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34101792
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ License); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+
+var Q = require('q'),
+fs= require('fs'),
+/* jshint ignore:start */ // 'path' only used in ignored blocks
--- End diff --
nit: trailing whitespace
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34101845
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ License); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+
+var Q = require('q'),
+fs= require('fs'),
+/* jshint ignore:start */ // 'path' only used in ignored blocks
+path = require('path'),
+/* jshint ignore:end */
+proc = require('child_process');
+
+// neither 'exec' nor 'spawn' was sufficient because we need to pass
arguments via spawn
+// but also need to be able to capture stdout / stderr
+function run(cmd, args, opt_cwd) {
+var d = Q.defer();
+try {
+var child = proc.spawn(cmd, args, {cwd: opt_cwd, maxBuffer:
1024000});
+var stdout = '', stderr = '';
+child.stdout.on('data', function(s) { stdout += s; });
+child.stderr.on('data', function(s) { stderr += s; });
+child.on('exit', function(code) {
+if (code) {
+d.reject(stderr);
+} else {
+d.resolve(stdout);
+}
+});
+} catch(e) {
+console.error('error caught: ' + e);
+d.reject(e);
+}
+return d.promise;
+}
+
+function DeploymentTool() {
+
+}
+
+/**
+ * Determines whether the requested version of the deployment tool is
available.
+ * @returns True if the deployment tool can function; false if not.
+ */
+DeploymentTool.prototype.isAvailable = function() {
+return fs.existsSync(this.path);
+};
+
+/**
--- End diff --
nit: trailing whitespace
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34103420
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ License); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+
+var Q = require('q'),
+fs= require('fs'),
+/* jshint ignore:start */ // 'path' only used in ignored blocks
+path = require('path'),
+/* jshint ignore:end */
+proc = require('child_process');
+
+// neither 'exec' nor 'spawn' was sufficient because we need to pass
arguments via spawn
+// but also need to be able to capture stdout / stderr
+function run(cmd, args, opt_cwd) {
+var d = Q.defer();
+try {
+var child = proc.spawn(cmd, args, {cwd: opt_cwd, maxBuffer:
1024000});
+var stdout = '', stderr = '';
+child.stdout.on('data', function(s) { stdout += s; });
+child.stderr.on('data', function(s) { stderr += s; });
+child.on('exit', function(code) {
+if (code) {
+d.reject(stderr);
+} else {
+d.resolve(stdout);
+}
+});
+} catch(e) {
+console.error('error caught: ' + e);
+d.reject(e);
+}
+return d.promise;
+}
+
+function DeploymentTool() {
+
+}
+
+/**
+ * Determines whether the requested version of the deployment tool is
available.
+ * @returns True if the deployment tool can function; false if not.
+ */
+DeploymentTool.prototype.isAvailable = function() {
+return fs.existsSync(this.path);
+};
+
+/**
+ * Enumerates devices attached to the development machine.
+ * @returns A Promise for an array of objects, which should be passed into
other functions to represent the device.
+ * @remarks The returned objects contain 'index', 'name', and 'type'
properties indicating basic information about them,
+ *which is limited to the information provided by the system. Other
properties may also be included, but they are
+ *specific to the deployment tool which created them and are likely
used internally.
+ */
+DeploymentTool.prototype.enumerateDevices = function() {
+return Q.reject('May not use DeploymentTool directly, instead get an
instance from DeploymentTool.getDeploymentTool()');
+};
+
+/**
+ * Installs an app package to the target device.
+ * @returns A Promise which will be fulfilled on success or rejected on
failure.
+ * @param pathToAppxPackage The path to the .appx package to install.
+ * @param targetDevice An object returned from a successful call to
enumerateDevices.
+ * @shouldLaunch Indicates whether to launch the app after installing it.
+ * @shouldUpdate Indicates whether to explicitly update the app, or
install clean.
+ * @pin Optionally provided if the device requires pairing for deployment.
+ */
+DeploymentTool.prototype.installAppPackage = function(pathToAppxPackage,
targetDevice, shouldLaunch, shouldUpdate, pin) {
+return Q.reject('May not use DeploymentTool directly, instead get an
instance from DeploymentTool.getDeploymentTool()');
+};
+
+/**
+ * Uninstalls an app package from the target device.
+ * @returns A Promise which will be fulfilled on success or rejected on
failure.
+ * @param packageInfo The app package name or Phone GUID representing the
app.
+ * @param targetDevice An object returned from a successful call to
enumerateDevices.
+ */
+DeploymentTool.prototype.uninstallAppPackage = function(packageInfo,
targetDevice) {
+return Q.reject('Unable to uninstall any app packages because that
feature is not supported.');
+};
+
+/**
+ * Gets a list of installed apps on the target device. This function is
not supported for
+ * Windows Phone 8.1.
+ * @param targetDevice {Object} An object returned from a successful
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user robpaveza commented on the pull request: https://github.com/apache/cordova-windows/pull/96#issuecomment-119379779 The siblings work as expected, although they only support Windows 8.1. We'll have to make a decision about how to invoke the Windows 10 equivalent. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-9318 remove travis-ci integ...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/105 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-9318 remove travis-ci integ...
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/105 CB-9318 remove travis-ci integration You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-plugin-camera CB-9318 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/105.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #105 commit 11eaaa8b9f1779dc2bd389459d633fbef9a4 Author: Jesse MacFadyen purplecabb...@gmail.com Date: 2015-07-08T00:36:10Z remove travis-ci integration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-9307 remove travis-ci integra...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/123 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-9307 remove travis-ci integra...
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-file/pull/123 CB-9307 remove travis-ci integration You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-plugin-file CB-9307 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/123.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #123 commit 0d605bdf8b56a010488678d2d8162d5349d0d89e Author: Jesse MacFadyen purplecabb...@gmail.com Date: 2015-07-07T22:07:22Z remove travis-ci integration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[DISCUSS] Release Cordova Plugin npm Search
Hey Everyone, I've been working on Cordova Plugin npm Search over the last few weeks. I feel we're now in a good shape to get this released. Please give it a spin: http://people.apache.org/~muratsu/ and use this thread to bring up any release blocking issues. My current thinking is that we handle the migration in two phases: Phase 1: - Create a new URL for the npm search - http://plugins.cordova.io/npm - Add a banner to the current CPR search re-directing traffic use the new npm search - https://github.com/apache/cordova-registry-web/pull/17 - Continue making improvements based on feedback to npm search Phase 2: (NPM search is default) - July 20th - Move http://plugins.cordova.io URL to the npm plugin search page. - Move current CPR search http://plugins.cordova.io/lecacy/ PS: A special thank you to all who provided feedback on https://github.com/cordova/cordova-discuss/issues/7 and sent PRs Thanks, Murat
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34103587
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ License); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+
+var Q = require('q'),
+fs= require('fs'),
+/* jshint ignore:start */ // 'path' only used in ignored blocks
+path = require('path'),
+/* jshint ignore:end */
+proc = require('child_process');
+
+// neither 'exec' nor 'spawn' was sufficient because we need to pass
arguments via spawn
+// but also need to be able to capture stdout / stderr
+function run(cmd, args, opt_cwd) {
+var d = Q.defer();
+try {
+var child = proc.spawn(cmd, args, {cwd: opt_cwd, maxBuffer:
1024000});
+var stdout = '', stderr = '';
+child.stdout.on('data', function(s) { stdout += s; });
+child.stderr.on('data', function(s) { stderr += s; });
+child.on('exit', function(code) {
+if (code) {
+d.reject(stderr);
+} else {
+d.resolve(stdout);
+}
+});
+} catch(e) {
+console.error('error caught: ' + e);
+d.reject(e);
+}
+return d.promise;
+}
+
+function DeploymentTool() {
+
+}
+
+/**
+ * Determines whether the requested version of the deployment tool is
available.
+ * @returns True if the deployment tool can function; false if not.
+ */
+DeploymentTool.prototype.isAvailable = function() {
+return fs.existsSync(this.path);
+};
+
+/**
+ * Enumerates devices attached to the development machine.
+ * @returns A Promise for an array of objects, which should be passed into
other functions to represent the device.
+ * @remarks The returned objects contain 'index', 'name', and 'type'
properties indicating basic information about them,
+ *which is limited to the information provided by the system. Other
properties may also be included, but they are
+ *specific to the deployment tool which created them and are likely
used internally.
+ */
+DeploymentTool.prototype.enumerateDevices = function() {
+return Q.reject('May not use DeploymentTool directly, instead get an
instance from DeploymentTool.getDeploymentTool()');
+};
+
+/**
+ * Installs an app package to the target device.
+ * @returns A Promise which will be fulfilled on success or rejected on
failure.
+ * @param pathToAppxPackage The path to the .appx package to install.
+ * @param targetDevice An object returned from a successful call to
enumerateDevices.
+ * @shouldLaunch Indicates whether to launch the app after installing it.
+ * @shouldUpdate Indicates whether to explicitly update the app, or
install clean.
+ * @pin Optionally provided if the device requires pairing for deployment.
+ */
+DeploymentTool.prototype.installAppPackage = function(pathToAppxPackage,
targetDevice, shouldLaunch, shouldUpdate, pin) {
+return Q.reject('May not use DeploymentTool directly, instead get an
instance from DeploymentTool.getDeploymentTool()');
+};
+
+/**
+ * Uninstalls an app package from the target device.
+ * @returns A Promise which will be fulfilled on success or rejected on
failure.
+ * @param packageInfo The app package name or Phone GUID representing the
app.
+ * @param targetDevice An object returned from a successful call to
enumerateDevices.
+ */
+DeploymentTool.prototype.uninstallAppPackage = function(packageInfo,
targetDevice) {
+return Q.reject('Unable to uninstall any app packages because that
feature is not supported.');
+};
+
+/**
+ * Gets a list of installed apps on the target device. This function is
not supported for
+ * Windows Phone 8.1.
+ * @param targetDevice {Object} An object returned from a successful
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34104122
--- Diff: template/cordova/lib/target-list.js ---
@@ -17,20 +17,21 @@
under the License.
*/
-var devices = require('./package'),
+var deploy = require('./deployment'),
args = process.argv.slice(2);
// help/usage function
function help() {
console.log('');
-console.log('Usage: node target-list.js [ --emulators | --devices |
--started_emulators | --all ]');
+console.log('Usage: node target-list.js [--win10] [ --emulators |
--devices | --started_emulators | --all ]');
+console.log('--win10 : Chooses to list Windows 10
devices (Windows 8.1 is default).');
console.log('--emulators : List the possible target
emulators availible.');
-console.log('--devices : List the possible target
devices availible. *NOT IMPLEMENTED YET*');
+console.log('--devices : List the possible target
devices availible.');
console.log('--started_emulators : List any started emulators
availible. *NOT IMPLEMENTED YET*');
console.log('--all : List all available devices');
console.log('examples:');
-console.log('node target-list.js --emulators');
-console.log('node target-list.js --devices');
+console.log('node target-list.js --win8.1 --emulators');
--- End diff --
--win8.1 flag is unhandled
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34104129
--- Diff: template/cordova/lib/target-list.js ---
@@ -40,10 +41,42 @@ function help() {
if (['--help', '/?', '-h', 'help', '-help', '/help'].indexOf(args[0])
-1) {
help();
} else {
-devices.listDevices()
-.then(function (deviceList) {
+
+var version = '8.1';
+if (args.indexOf('--win10') = 0) {
+version = '10.0';
+}
+
+var onlyDevices = false;
+if (args.indexOf('--devices') = 0) {
+onlyDevices = true;
+}
+
+var onlyEmulators = false;
+if (args.indexOf('--emulators') = 0) {
+onlyEmulators = true;
+}
+
+if (onlyDevices onlyEmulators) {
+console.warn('Error: Cannot specify both --emulators and
--devices');
+help();
+return;
+}
+
--- End diff --
nit: trailing whitespace
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34104478
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ License); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+
+var Q = require('q'),
+fs= require('fs'),
+/* jshint ignore:start */ // 'path' only used in ignored blocks
+path = require('path'),
+/* jshint ignore:end */
+proc = require('child_process');
+
+// neither 'exec' nor 'spawn' was sufficient because we need to pass
arguments via spawn
+// but also need to be able to capture stdout / stderr
+function run(cmd, args, opt_cwd) {
+var d = Q.defer();
+try {
+var child = proc.spawn(cmd, args, {cwd: opt_cwd, maxBuffer:
1024000});
+var stdout = '', stderr = '';
+child.stdout.on('data', function(s) { stdout += s; });
+child.stderr.on('data', function(s) { stderr += s; });
+child.on('exit', function(code) {
+if (code) {
+d.reject(stderr);
+} else {
+d.resolve(stdout);
+}
+});
+} catch(e) {
+console.error('error caught: ' + e);
+d.reject(e);
+}
+return d.promise;
+}
+
+function DeploymentTool() {
+
+}
+
+/**
+ * Determines whether the requested version of the deployment tool is
available.
+ * @returns True if the deployment tool can function; false if not.
+ */
+DeploymentTool.prototype.isAvailable = function() {
+return fs.existsSync(this.path);
+};
+
+/**
+ * Enumerates devices attached to the development machine.
+ * @returns A Promise for an array of objects, which should be passed into
other functions to represent the device.
+ * @remarks The returned objects contain 'index', 'name', and 'type'
properties indicating basic information about them,
+ *which is limited to the information provided by the system. Other
properties may also be included, but they are
+ *specific to the deployment tool which created them and are likely
used internally.
+ */
+DeploymentTool.prototype.enumerateDevices = function() {
+return Q.reject('May not use DeploymentTool directly, instead get an
instance from DeploymentTool.getDeploymentTool()');
+};
+
+/**
+ * Installs an app package to the target device.
+ * @returns A Promise which will be fulfilled on success or rejected on
failure.
+ * @param pathToAppxPackage The path to the .appx package to install.
+ * @param targetDevice An object returned from a successful call to
enumerateDevices.
+ * @shouldLaunch Indicates whether to launch the app after installing it.
+ * @shouldUpdate Indicates whether to explicitly update the app, or
install clean.
+ * @pin Optionally provided if the device requires pairing for deployment.
+ */
+DeploymentTool.prototype.installAppPackage = function(pathToAppxPackage,
targetDevice, shouldLaunch, shouldUpdate, pin) {
+return Q.reject('May not use DeploymentTool directly, instead get an
instance from DeploymentTool.getDeploymentTool()');
+};
+
+/**
+ * Uninstalls an app package from the target device.
+ * @returns A Promise which will be fulfilled on success or rejected on
failure.
+ * @param packageInfo The app package name or Phone GUID representing the
app.
+ * @param targetDevice An object returned from a successful call to
enumerateDevices.
+ */
+DeploymentTool.prototype.uninstallAppPackage = function(packageInfo,
targetDevice) {
+return Q.reject('Unable to uninstall any app packages because that
feature is not supported.');
+};
+
+/**
+ * Gets a list of installed apps on the target device. This function is
not supported for
+ * Windows Phone 8.1.
+ * @param targetDevice {Object} An object returned from a successful
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user muratsu commented on the pull request: https://github.com/apache/cordova-windows/pull/96#issuecomment-119376109 Can you check template/cordova/lib/list-devices.bat and it's siblings to see if they still work as expected? This is a big refactor. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-battery-status pull request: CB-9317 remove travis-...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-battery-status/pull/25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-battery-status pull request: CB-9317 remove travis-...
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-battery-status/pull/25 CB-9317 remove travis-ci integration You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-plugin-battery-status CB-9317 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-battery-status/pull/25.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #25 commit 2214699491f697113f204ea384558e15be52c4b5 Author: Jesse MacFadyen purplecabb...@gmail.com Date: 2015-07-08T00:33:47Z remove travis-ci integration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CB-9306 remove travis-c...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/93 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34105951
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ License); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+
+var Q = require('q'),
+fs= require('fs'),
+/* jshint ignore:start */ // 'path' only used in ignored blocks
+path = require('path'),
+/* jshint ignore:end */
+proc = require('child_process');
+
+// neither 'exec' nor 'spawn' was sufficient because we need to pass
arguments via spawn
+// but also need to be able to capture stdout / stderr
+function run(cmd, args, opt_cwd) {
+var d = Q.defer();
+try {
+var child = proc.spawn(cmd, args, {cwd: opt_cwd, maxBuffer:
1024000});
+var stdout = '', stderr = '';
+child.stdout.on('data', function(s) { stdout += s; });
+child.stderr.on('data', function(s) { stderr += s; });
+child.on('exit', function(code) {
+if (code) {
+d.reject(stderr);
+} else {
+d.resolve(stdout);
+}
+});
+} catch(e) {
+console.error('error caught: ' + e);
+d.reject(e);
+}
+return d.promise;
+}
+
+function DeploymentTool() {
+
+}
+
+/**
+ * Determines whether the requested version of the deployment tool is
available.
+ * @returns True if the deployment tool can function; false if not.
+ */
+DeploymentTool.prototype.isAvailable = function() {
+return fs.existsSync(this.path);
+};
+
+/**
+ * Enumerates devices attached to the development machine.
+ * @returns A Promise for an array of objects, which should be passed into
other functions to represent the device.
+ * @remarks The returned objects contain 'index', 'name', and 'type'
properties indicating basic information about them,
+ *which is limited to the information provided by the system. Other
properties may also be included, but they are
+ *specific to the deployment tool which created them and are likely
used internally.
+ */
+DeploymentTool.prototype.enumerateDevices = function() {
+return Q.reject('May not use DeploymentTool directly, instead get an
instance from DeploymentTool.getDeploymentTool()');
+};
+
+/**
+ * Installs an app package to the target device.
+ * @returns A Promise which will be fulfilled on success or rejected on
failure.
+ * @param pathToAppxPackage The path to the .appx package to install.
+ * @param targetDevice An object returned from a successful call to
enumerateDevices.
+ * @shouldLaunch Indicates whether to launch the app after installing it.
+ * @shouldUpdate Indicates whether to explicitly update the app, or
install clean.
+ * @pin Optionally provided if the device requires pairing for deployment.
+ */
+DeploymentTool.prototype.installAppPackage = function(pathToAppxPackage,
targetDevice, shouldLaunch, shouldUpdate, pin) {
+return Q.reject('May not use DeploymentTool directly, instead get an
instance from DeploymentTool.getDeploymentTool()');
+};
+
+/**
+ * Uninstalls an app package from the target device.
+ * @returns A Promise which will be fulfilled on success or rejected on
failure.
+ * @param packageInfo The app package name or Phone GUID representing the
app.
+ * @param targetDevice An object returned from a successful call to
enumerateDevices.
+ */
+DeploymentTool.prototype.uninstallAppPackage = function(packageInfo,
targetDevice) {
+return Q.reject('Unable to uninstall any app packages because that
feature is not supported.');
+};
+
+/**
+ * Gets a list of installed apps on the target device. This function is
not supported for
+ * Windows Phone 8.1.
+ * @param targetDevice {Object} An object returned from a successful
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34105916
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ License); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+
+var Q = require('q'),
+fs= require('fs'),
+/* jshint ignore:start */ // 'path' only used in ignored blocks
+path = require('path'),
+/* jshint ignore:end */
+proc = require('child_process');
+
+// neither 'exec' nor 'spawn' was sufficient because we need to pass
arguments via spawn
+// but also need to be able to capture stdout / stderr
+function run(cmd, args, opt_cwd) {
--- End diff --
True. We could create a separate jira (I don't want to dot out of
cordova-windows to access superspawn here) to do this refactor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34105978
--- Diff: template/cordova/lib/target-list.js ---
@@ -17,20 +17,21 @@
under the License.
*/
-var devices = require('./package'),
+var deploy = require('./deployment'),
args = process.argv.slice(2);
// help/usage function
function help() {
console.log('');
-console.log('Usage: node target-list.js [ --emulators | --devices |
--started_emulators | --all ]');
+console.log('Usage: node target-list.js [--win10] [ --emulators |
--devices | --started_emulators | --all ]');
+console.log('--win10 : Chooses to list Windows 10
devices (Windows 8.1 is default).');
console.log('--emulators : List the possible target
emulators availible.');
-console.log('--devices : List the possible target
devices availible. *NOT IMPLEMENTED YET*');
+console.log('--devices : List the possible target
devices availible.');
console.log('--started_emulators : List any started emulators
availible. *NOT IMPLEMENTED YET*');
console.log('--all : List all available devices');
console.log('examples:');
-console.log('node target-list.js --emulators');
-console.log('node target-list.js --devices');
+console.log('node target-list.js --win8.1 --emulators');
--- End diff --
Good catch, it had been dropped.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: CB-9306 remove travis-c...
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/93 CB-9306 remove travis-ci integration You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-plugin-file-transfer CB-9306 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file-transfer/pull/93.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #93 commit f0209a2f756c21a423852ada317d821db80613c1 Author: Jesse MacFadyen purplecabb...@gmail.com Date: 2015-07-07T22:04:20Z remove travis-ci integration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [DISCUSS] Cordova-Android 4.0.3 Release
Should we also release the current master for Android as 4.1? It's long overdue. Though one advantage of doing 4.0.3 is that it does not require an accompanying TOOLS release as we use support patch version semver upgrades in the previous version of the TOOLS. Thanks, Nikhil -Original Message- From: Simon MacDonald [mailto:simon.macdon...@gmail.com] Sent: Tuesday, July 7, 2015 2:38 PM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Cordova-Android 4.0.3 Release +1 to that. The min SDK level of 10 is causing problems when I try to +add support libraries for the push plugin. Simon Mac Donald http://hi.im/simonmacdonald On Tue, Jul 7, 2015 at 5:33 PM, Joe Bowser bows...@gmail.com wrote: Sorry, that was a typo, yes it should be 14. On Tue, Jul 7, 2015 at 2:26 PM julio cesar sanchez jcesarmob...@gmail.com wrote: 13? That's honeycomb, I think it should be 14 El 7/7/2015 23:23, Joe Bowser bows...@gmail.com escribió: Hey I discovered that on the 4.0.x branch, we're still setting the minSdkTarget to 10, even though we don't support Gingerbread anymore. I think we should release a 4.0.3 version where we set it to 13. This is a trivial change, and it's already been done on master. Thoughts?? Joe
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34101423
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ License); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+
+var Q = require('q'),
+fs= require('fs'),
+/* jshint ignore:start */ // 'path' only used in ignored blocks
+path = require('path'),
+/* jshint ignore:end */
+proc = require('child_process');
+
+// neither 'exec' nor 'spawn' was sufficient because we need to pass
arguments via spawn
+// but also need to be able to capture stdout / stderr
+function run(cmd, args, opt_cwd) {
--- End diff --
I see this function everywhere in cordova codebase. We should really make a
npm module out of it and publish it.
Better(?) version of this function is available at
cordova-lib\cordova-lib\src\cordova\superspawn.js
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34103731
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ License); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+
+var Q = require('q'),
+fs= require('fs'),
+/* jshint ignore:start */ // 'path' only used in ignored blocks
+path = require('path'),
+/* jshint ignore:end */
+proc = require('child_process');
+
+// neither 'exec' nor 'spawn' was sufficient because we need to pass
arguments via spawn
+// but also need to be able to capture stdout / stderr
+function run(cmd, args, opt_cwd) {
+var d = Q.defer();
+try {
+var child = proc.spawn(cmd, args, {cwd: opt_cwd, maxBuffer:
1024000});
+var stdout = '', stderr = '';
+child.stdout.on('data', function(s) { stdout += s; });
+child.stderr.on('data', function(s) { stderr += s; });
+child.on('exit', function(code) {
+if (code) {
+d.reject(stderr);
+} else {
+d.resolve(stdout);
+}
+});
+} catch(e) {
+console.error('error caught: ' + e);
+d.reject(e);
+}
+return d.promise;
+}
+
+function DeploymentTool() {
+
+}
+
+/**
+ * Determines whether the requested version of the deployment tool is
available.
+ * @returns True if the deployment tool can function; false if not.
+ */
+DeploymentTool.prototype.isAvailable = function() {
+return fs.existsSync(this.path);
+};
+
+/**
+ * Enumerates devices attached to the development machine.
+ * @returns A Promise for an array of objects, which should be passed into
other functions to represent the device.
+ * @remarks The returned objects contain 'index', 'name', and 'type'
properties indicating basic information about them,
+ *which is limited to the information provided by the system. Other
properties may also be included, but they are
+ *specific to the deployment tool which created them and are likely
used internally.
+ */
+DeploymentTool.prototype.enumerateDevices = function() {
+return Q.reject('May not use DeploymentTool directly, instead get an
instance from DeploymentTool.getDeploymentTool()');
+};
+
+/**
+ * Installs an app package to the target device.
+ * @returns A Promise which will be fulfilled on success or rejected on
failure.
+ * @param pathToAppxPackage The path to the .appx package to install.
+ * @param targetDevice An object returned from a successful call to
enumerateDevices.
+ * @shouldLaunch Indicates whether to launch the app after installing it.
+ * @shouldUpdate Indicates whether to explicitly update the app, or
install clean.
+ * @pin Optionally provided if the device requires pairing for deployment.
+ */
+DeploymentTool.prototype.installAppPackage = function(pathToAppxPackage,
targetDevice, shouldLaunch, shouldUpdate, pin) {
+return Q.reject('May not use DeploymentTool directly, instead get an
instance from DeploymentTool.getDeploymentTool()');
+};
+
+/**
+ * Uninstalls an app package from the target device.
+ * @returns A Promise which will be fulfilled on success or rejected on
failure.
+ * @param packageInfo The app package name or Phone GUID representing the
app.
+ * @param targetDevice An object returned from a successful call to
enumerateDevices.
+ */
+DeploymentTool.prototype.uninstallAppPackage = function(packageInfo,
targetDevice) {
+return Q.reject('Unable to uninstall any app packages because that
feature is not supported.');
+};
+
+/**
+ * Gets a list of installed apps on the target device. This function is
not supported for
+ * Windows Phone 8.1.
+ * @param targetDevice {Object} An object returned from a successful
[GitHub] cordova-plugin-device pull request: CB-9320 remove travis-ci
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-device/pull/34 CB-9320 remove travis-ci You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-plugin-device CB-9320 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-device/pull/34.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #34 commit 3ed9bee552267f683326e394fce48095e5f90fec Author: Jesse MacFadyen purplecabb...@gmail.com Date: 2015-07-08T00:41:29Z remove travis-ci --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device pull request: CB-9320 remove travis-ci
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34107527
--- Diff: spec/unit/deployment.spec.js ---
@@ -0,0 +1,282 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+License); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var rewire = require('rewire'),
+deployment = rewire('../../template/cordova/lib/deployment'),
+run= deployment.__get__('run'),
+Q = require('q'),
+
+AppDeployCmdTool = deployment.__get__('AppDeployCmdTool'),
+WinAppDeployCmdTool = deployment.__get__('WinAppDeployCmdTool');
+
+var TEST_APP_PACKAGE_NAME = 'c:\\testapppackage.appx',
+TEST_APP_PACKAGE_ID = '12121212-3434-3434-3434-567856785678';
+
+describe('The correct version of the app deployment tool is obtained.',
function() {
+
+it('Provides an AppDeployCmdTool when 8.1 is requested.', function() {
+
+var tool = deployment.getDeploymentTool('8.1');
+expect(tool instanceof AppDeployCmdTool).toBe(true);
+
+});
+
+it('Provides a WinAppDeployCmdTool when 10.0 is requested.',
function() {
+
+var tool = deployment.getDeploymentTool('10.0');
+expect(tool instanceof WinAppDeployCmdTool).toBe(true);
+
+});
+
+});
+
+describe('Windows 10 deployment interacts with the file system as
expected.', function() {
+
+function runMock(cmd, args, cwd) {
+expect(cmd).toBe('c:\\Program Files (x86)\\Windows
Kits\\10\\bin\\x86\\WinAppDeployCmd.exe');
+switch (args[0]) {
+case 'devices':
+var output = 'Windows App Deployment Tool\r\nVersion
10.0.0.0\r\nCopyright (c) Microsoft Corporation. All rights
reserved.\r\n\r\nDiscovering devices...\r\nIP Address GUID
Model/Name\r\n127.0.0.1
0015-b21e-0da9--Lumia 1520 (RM-940)\r\n10.120.70.172
----00155d61953200155D619532\r\n10.120.68.150
----00155d01176500155D011765\r\nDone.';
+return Q(output);
+
+case 'update':
+case 'install':
+expect(args[2]).toBe(TEST_APP_PACKAGE_NAME);
+expect(args[4]).toBe('127.0.0.1');
+return Q('');
+
+case 'uninstall':
+expect(args[2]).toBe(TEST_APP_PACKAGE_ID);
+expect(args[4]).toBe('10.120.68.150');
+return Q('');
+
+}
+}
+
+var mockedProgramFiles = process.env['ProgramFiles(x86)'];
+beforeEach(function() {
+deployment.__set__('run', runMock);
+process.env['ProgramFiles(x86)'] = 'c:\\Program Files (x86)';
+});
+afterEach(function() {
+deployment.__set__('run', run);
+if (mockedProgramFiles) {
+process.env['ProgramFiles(x86)'] = mockedProgramFiles;
+} else {
+delete process.env['ProgramFiles(x86)'];
+}
+});
+
+it('enumerateDevices returns a valid set of objects', function() {
+var deploymentTool = deployment.getDeploymentTool('10.0');
+var done = false;
+deploymentTool.enumerateDevices().then(function(deviceList) {
+
+expect(deviceList.length).toBe(3);
+expect(deviceList[0].name).toBe('Lumia 1520 (RM-940)');
+expect(deviceList[0].index).toBe(0);
+expect(deviceList[0].type).toBe('device');
+
+done = true;
+
+});
+
+waitsFor(function() { return done; });
+});
+
+it('installAppPackage passes the correct set of parameters',
function() {
+var deploymentTool = deployment.getDeploymentTool('10.0');
+var done = false;
+deploymentTool.enumerateDevices().then(function(deviceList) {
+
[GitHub] cordova-plugin-dialogs pull request: CB-9321 remove travis-ci
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/53 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-9323 remove travis-ci
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/108 CB-9323 remove travis-ci You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-plugin-inappbrowser CB-9323 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/108.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #108 commit 5c7a9d95a8eea3b87b29eb4502b4b03d2e432ec8 Author: Jesse MacFadyen purplecabb...@gmail.com Date: 2015-07-08T00:52:53Z remove travis-ci --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-9324 remove travis-ci
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/51 CB-9324 remove travis-ci You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-plugin-splashscreen CB-9324 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-splashscreen/pull/51.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #51 commit 0916db61b417723bf2338c053925f67c3d8c6803 Author: Jesse MacFadyen purplecabb...@gmail.com Date: 2015-07-08T00:55:55Z remove travis-ci --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-9324 remove travis-ci
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/51 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34109092
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,272 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ License); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+
+var Q = require('q'),
+fs= require('fs'),
+/* jshint ignore:start */ // 'path' only used in ignored blocks
+path = require('path'),
+/* jshint ignore:end */
+proc = require('child_process');
+
+// neither 'exec' nor 'spawn' was sufficient because we need to pass
arguments via spawn
+// but also need to be able to capture stdout / stderr
+function run(cmd, args, opt_cwd) {
--- End diff --
@vladimir-kotikov is working on cordova-common module that all platforms
and cordova-lib could take a dependency on. At that point supersawn could be
one of those things we could share.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34109755
--- Diff: template/cordova/lib/package.js ---
@@ -130,58 +145,47 @@ module.exports.findDevice = function (target) {
};
// returns array of available devices names
-module.exports.listDevices = function () {
-return utils.getAppDeployUtils().then(function(appDeployUtils) {
-return exec('' + appDeployUtils + '
/enumeratedevices').then(function(output) {
-return Q.resolve(output.split('\n').map(function(line) {
-var match = /\s*(\d)+\s+(.*)/.exec(line);
-return match match[2];
-}).filter(function (line) {
-return line;
-}));
+module.exports.listDevices = function (deploymentTool) {
+
+return deploymentTool.enumerateDevices().then(function(deviceList) {
+return deviceList.map(function(device) {
+return device.toString();
});
-});
-};
-
-function installAppToPhone(appDeployUtils, package, target, update) {
-// /installlaunch option sometimes fails with 'Error: The parameter is
incorrect.'
-// so we use separate steps to /install or /update and then /launch
-var cmd = update ? '/update' : '/install';
-console.log('Installing application...');
-return spawn(appDeployUtils, [cmd, package.appx, '/targetdevice:' +
target]);
-}
+}, function(e) {
+console.warn('Failed to enumerate devices');
+console.warn(e);
-function runAppOnPhone(appDeployUtils, target) {
-return Q().then(function() {
-return module.exports.getAppId(path.join(__dirname, '..', '..'));
-}).then(function(appId) {
-console.log('Running application... ');
-return spawn(appDeployUtils, ['/launch', appId, '/targetdevice:' +
target]);
+throw e;
});
-}
+};
+
function uninstallAppFromPhone(appDeployUtils, package, target) {
console.log('Attempting to remove previously installed
application...');
-return spawn(appDeployUtils, ['/uninstall', package.phoneId,
'/targetdevice:' + target]);
+return appDeployUtils.uninstallAppPackage(package.phoneId, target);
}
// deploys specified phone package to device/emulator and launches it
-module.exports.deployToPhone = function (package, deployTarget,
targetWindows10) {
-var getTarget = deployTarget == 'device' ? Q('de') :
-deployTarget == 'emulator' ? Q('xd') :
module.exports.findDevice(deployTarget);
-
-return getTarget.then(function(target) {
-return
utils.getAppDeployUtils(targetWindows10).then(function(appDeployUtils) {
+module.exports.deployToPhone = function (package, deployTarget,
targetWindows10, deploymentTool) {
+var deployment;
+if (deploymentTool) {
+deployment = Q(deploymentTool);
+}
+else {
+deployment = utils.getAppDeployUtils(targetWindows10);
+}
-return uninstallAppFromPhone(appDeployUtils, package,
target).then(
+return deployment.then(function(deploymentTool) {
+return module.exports.findDevice(deploymentTool,
deployTarget).then(function(target) {
+return uninstallAppFromPhone(deploymentTool, package,
target).then(
function() {}, function() {}).then(function() {
-return installAppToPhone(appDeployUtils, package,
target, false);
-}).then(function() {
-return runAppOnPhone(appDeployUtils, target);
-}, function(error) {
+// shouldUpdate = false because we've already
uninstalled
+return deploymentTool.installAppPackage(package.appx,
target, true, false);
--- End diff --
It helps readability to have simple comments /*shouldLaunch=*/ true.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34109798
--- Diff: template/cordova/lib/package.js ---
@@ -130,58 +145,47 @@ module.exports.findDevice = function (target) {
};
// returns array of available devices names
-module.exports.listDevices = function () {
-return utils.getAppDeployUtils().then(function(appDeployUtils) {
-return exec('' + appDeployUtils + '
/enumeratedevices').then(function(output) {
-return Q.resolve(output.split('\n').map(function(line) {
-var match = /\s*(\d)+\s+(.*)/.exec(line);
-return match match[2];
-}).filter(function (line) {
-return line;
-}));
+module.exports.listDevices = function (deploymentTool) {
+
+return deploymentTool.enumerateDevices().then(function(deviceList) {
+return deviceList.map(function(device) {
+return device.toString();
});
-});
-};
-
-function installAppToPhone(appDeployUtils, package, target, update) {
-// /installlaunch option sometimes fails with 'Error: The parameter is
incorrect.'
-// so we use separate steps to /install or /update and then /launch
-var cmd = update ? '/update' : '/install';
-console.log('Installing application...');
-return spawn(appDeployUtils, [cmd, package.appx, '/targetdevice:' +
target]);
-}
+}, function(e) {
+console.warn('Failed to enumerate devices');
+console.warn(e);
-function runAppOnPhone(appDeployUtils, target) {
-return Q().then(function() {
-return module.exports.getAppId(path.join(__dirname, '..', '..'));
-}).then(function(appId) {
-console.log('Running application... ');
-return spawn(appDeployUtils, ['/launch', appId, '/targetdevice:' +
target]);
+throw e;
});
-}
+};
+
function uninstallAppFromPhone(appDeployUtils, package, target) {
console.log('Attempting to remove previously installed
application...');
-return spawn(appDeployUtils, ['/uninstall', package.phoneId,
'/targetdevice:' + target]);
+return appDeployUtils.uninstallAppPackage(package.phoneId, target);
}
// deploys specified phone package to device/emulator and launches it
-module.exports.deployToPhone = function (package, deployTarget,
targetWindows10) {
-var getTarget = deployTarget == 'device' ? Q('de') :
-deployTarget == 'emulator' ? Q('xd') :
module.exports.findDevice(deployTarget);
-
-return getTarget.then(function(target) {
-return
utils.getAppDeployUtils(targetWindows10).then(function(appDeployUtils) {
+module.exports.deployToPhone = function (package, deployTarget,
targetWindows10, deploymentTool) {
+var deployment;
+if (deploymentTool) {
+deployment = Q(deploymentTool);
+}
+else {
+deployment = utils.getAppDeployUtils(targetWindows10);
+}
-return uninstallAppFromPhone(appDeployUtils, package,
target).then(
+return deployment.then(function(deploymentTool) {
+return module.exports.findDevice(deploymentTool,
deployTarget).then(function(target) {
+return uninstallAppFromPhone(deploymentTool, package,
target).then(
function() {}, function() {}).then(function() {
-return installAppToPhone(appDeployUtils, package,
target, false);
-}).then(function() {
-return runAppOnPhone(appDeployUtils, target);
-}, function(error) {
+// shouldUpdate = false because we've already
uninstalled
+return deploymentTool.installAppPackage(package.appx,
target, true, false);
+}).then(function() { }, function(error) {
+console.dir(error);
--- End diff --
should the console.dir be removed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34110493
--- Diff: template/cordova/lib/target-list.js ---
@@ -17,20 +17,21 @@
under the License.
*/
-var devices = require('./package'),
+var deploy = require('./deployment'),
args = process.argv.slice(2);
// help/usage function
function help() {
console.log('');
-console.log('Usage: node target-list.js [ --emulators | --devices |
--started_emulators | --all ]');
+console.log('Usage: node target-list.js [--win10] [ --emulators |
--devices | --started_emulators | --all ]');
+console.log('--win10 : Chooses to list Windows 10
devices (Windows 8.1 is default).');
console.log('--emulators : List the possible target
emulators availible.');
-console.log('--devices : List the possible target
devices availible. *NOT IMPLEMENTED YET*');
+console.log('--devices : List the possible target
devices availible.');
console.log('--started_emulators : List any started emulators
availible. *NOT IMPLEMENTED YET*');
console.log('--all : List all available devices');
console.log('examples:');
console.log('node target-list.js --emulators');
-console.log('node target-list.js --devices');
+console.log('node target-list.js --win10 --devices');
--- End diff --
does the cordova run --list command need an update? It will be nice to list
both set of devices/emulators for Win10 Win8.1 rather than have to specify an
argument to pick and chose for listing purposes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-9295 Add GA analytics code on the Co...
Github user kant2002 commented on the pull request: https://github.com/apache/cordova-docs/pull/295#issuecomment-11939 If I will use code in the index.js, we have to update only index.js files across all versions and we are all set. (not sure about very old (2.0) English versions. I will move code from index.html to index.js. This should be enough. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device-orientation pull request: CB-9319 remove tra...
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-device-orientation/pull/20 CB-9319 remove travis-ci You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-plugin-device-orientation CB-9319 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-device-orientation/pull/20.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #20 commit 4271adb2c44bd2c2e1ed632a060f3a9500fab28f Author: Jesse MacFadyen purplecabb...@gmail.com Date: 2015-07-08T00:39:16Z remove travis-ci --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: CB-9325 remove travis-ci
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/28 CB-9325 remove travis-ci You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-plugin-statusbar CB-9325 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-statusbar/pull/28.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #28 commit 1dfc83d57ddaab4f0ecced0d58a11ade94a52843 Author: Jesse MacFadyen purplecabb...@gmail.com Date: 2015-07-08T01:00:25Z remove travis-ci --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: CB-9325 remove travis-ci
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34109357
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,275 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ License); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+
+var Q = require('q'),
+fs= require('fs'),
+/* jshint ignore:start */ // 'path' only used in ignored blocks
+path = require('path'),
+/* jshint ignore:end */
+proc = require('child_process');
+
+// neither 'exec' nor 'spawn' was sufficient because we need to pass
arguments via spawn
+// but also need to be able to capture stdout / stderr
+function run(cmd, args, opt_cwd) {
+var d = Q.defer();
+try {
+var child = proc.spawn(cmd, args, {cwd: opt_cwd, maxBuffer:
1024000});
+var stdout = '', stderr = '';
+child.stdout.on('data', function(s) { stdout += s; });
+child.stderr.on('data', function(s) { stderr += s; });
+child.on('exit', function(code) {
+if (code) {
+d.reject(stderr);
+} else {
+d.resolve(stdout);
+}
+});
+} catch(e) {
+console.error('error caught: ' + e);
--- End diff --
Should this method be responsible for logging error or the caller?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34109679
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,275 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ License); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+
+var Q = require('q'),
+fs= require('fs'),
+/* jshint ignore:start */ // 'path' only used in ignored blocks
+path = require('path'),
+/* jshint ignore:end */
+proc = require('child_process');
+
+// neither 'exec' nor 'spawn' was sufficient because we need to pass
arguments via spawn
+// but also need to be able to capture stdout / stderr
+function run(cmd, args, opt_cwd) {
+var d = Q.defer();
+try {
+var child = proc.spawn(cmd, args, {cwd: opt_cwd, maxBuffer:
1024000});
+var stdout = '', stderr = '';
+child.stdout.on('data', function(s) { stdout += s; });
+child.stderr.on('data', function(s) { stderr += s; });
+child.on('exit', function(code) {
+if (code) {
+d.reject(stderr);
+} else {
+d.resolve(stdout);
+}
+});
+} catch(e) {
+console.error('error caught: ' + e);
+d.reject(e);
+}
+return d.promise;
+}
+
+function DeploymentTool() {
+
+}
+
+/**
+ * Determines whether the requested version of the deployment tool is
available.
+ * @returns True if the deployment tool can function; false if not.
+ */
+DeploymentTool.prototype.isAvailable = function() {
+return fs.existsSync(this.path);
+};
+
+/**
+ * Enumerates devices attached to the development machine.
+ * @returns A Promise for an array of objects, which should be passed into
other functions to represent the device.
+ * @remarks The returned objects contain 'index', 'name', and 'type'
properties indicating basic information about them,
+ *which is limited to the information provided by the system. Other
properties may also be included, but they are
+ *specific to the deployment tool which created them and are likely
used internally.
+ */
+DeploymentTool.prototype.enumerateDevices = function() {
+return Q.reject('May not use DeploymentTool directly, instead get an
instance from DeploymentTool.getDeploymentTool()');
+};
+
+/**
+ * Installs an app package to the target device.
+ * @returns A Promise which will be fulfilled on success or rejected on
failure.
+ * @param pathToAppxPackage The path to the .appx package to install.
+ * @param targetDevice An object returned from a successful call to
enumerateDevices.
+ * @shouldLaunch Indicates whether to launch the app after installing it.
+ * @shouldUpdate Indicates whether to explicitly update the app, or
install clean.
+ * @pin Optionally provided if the device requires pairing for deployment.
+ */
+DeploymentTool.prototype.installAppPackage = function(pathToAppxPackage,
targetDevice, shouldLaunch, shouldUpdate, pin) {
+return Q.reject('May not use DeploymentTool directly, instead get an
instance from DeploymentTool.getDeploymentTool()');
+};
+
+/**
+ * Uninstalls an app package from the target device.
+ * @returns A Promise which will be fulfilled on success or rejected on
failure.
+ * @param packageInfo The app package name or Phone GUID representing the
app.
+ * @param targetDevice An object returned from a successful call to
enumerateDevices.
+ */
+DeploymentTool.prototype.uninstallAppPackage = function(packageInfo,
targetDevice) {
+return Q.reject('Unable to uninstall any app packages because that
feature is not supported.');
+};
+
+/**
+ * Gets a list of installed apps on the target device. This function is
not supported for
+ * Windows Phone 8.1.
+ * @param targetDevice {Object} An object returned from a successful
Re: [DISCUSS] Cordova-Android 4.0.3 Release
We could do a 4.1.0 release, but I don't think I'd say it was overdue. I'm not even sure if there's any real reason to do a 4.1.x release other than cadence, which we stopped following when we adopted The Apache Way. On Tue, Jul 7, 2015 at 3:21 PM Nikhil Khandelwal nikhi...@microsoft.com wrote: Should we also release the current master for Android as 4.1? It's long overdue. Though one advantage of doing 4.0.3 is that it does not require an accompanying TOOLS release as we use support patch version semver upgrades in the previous version of the TOOLS. Thanks, Nikhil -Original Message- From: Simon MacDonald [mailto:simon.macdon...@gmail.com] Sent: Tuesday, July 7, 2015 2:38 PM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Cordova-Android 4.0.3 Release +1 to that. The min SDK level of 10 is causing problems when I try to +add support libraries for the push plugin. Simon Mac Donald http://hi.im/simonmacdonald On Tue, Jul 7, 2015 at 5:33 PM, Joe Bowser bows...@gmail.com wrote: Sorry, that was a typo, yes it should be 14. On Tue, Jul 7, 2015 at 2:26 PM julio cesar sanchez jcesarmob...@gmail.com wrote: 13? That's honeycomb, I think it should be 14 El 7/7/2015 23:23, Joe Bowser bows...@gmail.com escribió: Hey I discovered that on the 4.0.x branch, we're still setting the minSdkTarget to 10, even though we don't support Gingerbread anymore. I think we should release a 4.0.3 version where we set it to 13. This is a trivial change, and it's already been done on master. Thoughts?? Joe
[GitHub] cordova-plugin-vibration pull request: CB-9326 remove travis-ci
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-vibration/pull/36 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-vibration pull request: CB-9326 remove travis-ci
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-vibration/pull/36 CB-9326 remove travis-ci You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-plugin-vibration CB-9326 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-vibration/pull/36.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #36 commit cc8d8031aba903fb9811d70deb46e4ac19f58689 Author: Jesse MacFadyen purplecabb...@gmail.com Date: 2015-07-08T01:04:09Z remove travis-ci --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34109871
--- Diff: template/cordova/lib/run.js ---
@@ -155,7 +155,8 @@ module.exports.help = function () {
console.log('--appx=8.1-win|8.1-phone|uap');
console.log(' : Overrides windows-target-version to
build Windows 8.1, ');
console.log(' Windows Phone 8.1, or
Windows 10.');
-console.log('');
+console.log('--win10tools : Uses Windows 10 deployment tools
(used for a Windows 8.1 app when');
--- End diff --
Why do we need to expose this as an option to the user?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34110160
--- Diff: template/cordova/lib/package.js ---
@@ -113,16 +112,32 @@ function getPackageName(platformPath) {
// returns one of available devices which name match with provided string
// return rejected promise if device with name specified not found
-module.exports.findDevice = function (target) {
+module.exports.findDevice = function (deploymentTool, target) {
target = target.toLowerCase();
-return module.exports.listDevices().then(function(deviceList) {
+return deploymentTool.enumerateDevices().then(function(deviceList) {
// CB-7617 since we use partial match shorter names should go
first,
// example case is ['Emulator 8.1 WVGA 4 inch 512MB', 'Emulator
8.1 WVGA 4 inch']
-var sortedList = deviceList.concat().sort(function (l, r) { return
l.length r.length; });
-for (var idx in sortedList){
-if (sortedList[idx].toLowerCase().indexOf(target) -1) {
-// we should return index based on original list
-return Q.resolve(deviceList.indexOf(sortedList[idx]));
+// In CB-9283, we need to differentiate between emulator, device,
and target.
+// So, for emulators to honor the above CB-7617, we preserve the
original behavior.
+// Else, we choose either the target by ID (DeviceInfo.index) or
if it's just device,
+// we choose the default (aka first) device.
+if (target === 'emulator') {
+var sortedList = deviceList.concat().sort(function (l, r) {
return l.toString().length r.toString().length; });
--- End diff --
I know this is existing code - but why would you `concat` here to nothing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34110226
--- Diff: template/cordova/lib/package.js ---
@@ -113,16 +112,32 @@ function getPackageName(platformPath) {
// returns one of available devices which name match with provided string
// return rejected promise if device with name specified not found
-module.exports.findDevice = function (target) {
+module.exports.findDevice = function (deploymentTool, target) {
target = target.toLowerCase();
-return module.exports.listDevices().then(function(deviceList) {
+return deploymentTool.enumerateDevices().then(function(deviceList) {
// CB-7617 since we use partial match shorter names should go
first,
// example case is ['Emulator 8.1 WVGA 4 inch 512MB', 'Emulator
8.1 WVGA 4 inch']
-var sortedList = deviceList.concat().sort(function (l, r) { return
l.length r.length; });
-for (var idx in sortedList){
-if (sortedList[idx].toLowerCase().indexOf(target) -1) {
-// we should return index based on original list
-return Q.resolve(deviceList.indexOf(sortedList[idx]));
+// In CB-9283, we need to differentiate between emulator, device,
and target.
+// So, for emulators to honor the above CB-7617, we preserve the
original behavior.
+// Else, we choose either the target by ID (DeviceInfo.index) or
if it's just device,
+// we choose the default (aka first) device.
+if (target === 'emulator') {
+var sortedList = deviceList.concat().sort(function (l, r) {
return l.toString().length r.toString().length; });
+for (var idx in sortedList){
--- End diff --
If I understand correctly, `sortedList` is an array and foreach is quite a
bad practice for arrays - unless we really have a case of a sparse array.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-9295 Add GA analytics code on the Co...
Github user kant2002 commented on the pull request: https://github.com/apache/cordova-docs/pull/295#issuecomment-119400706 I also change from the old GA format to new. But we have to verify that both codes working. and as around about PhoneGap tracking code, do Adobe still use it? One more thing which I could implement is add recording of events on following occasions 1. User change language 2. User select topic in the subheader select. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device-orientation pull request: CB-9319 remove tra...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-orientation/pull/20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: CB-9321remove travis-ci
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/53 CB-9321remove travis-ci You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-plugin-dialogs CB-9321 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-dialogs/pull/53.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #53 commit fb994515f0b8ff054482ebd5740964204c17c3b3 Author: Jesse MacFadyen purplecabb...@gmail.com Date: 2015-07-08T00:47:32Z remove travis-ci --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34109990
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,275 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ License); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+
+var Q = require('q'),
+fs= require('fs'),
+/* jshint ignore:start */ // 'path' only used in ignored blocks
+path = require('path'),
+/* jshint ignore:end */
+proc = require('child_process');
+
+// neither 'exec' nor 'spawn' was sufficient because we need to pass
arguments via spawn
+// but also need to be able to capture stdout / stderr
+function run(cmd, args, opt_cwd) {
+var d = Q.defer();
+try {
+var child = proc.spawn(cmd, args, {cwd: opt_cwd, maxBuffer:
1024000});
+var stdout = '', stderr = '';
+child.stdout.on('data', function(s) { stdout += s; });
+child.stderr.on('data', function(s) { stderr += s; });
+child.on('exit', function(code) {
+if (code) {
+d.reject(stderr);
+} else {
+d.resolve(stdout);
+}
+});
+} catch(e) {
+console.error('error caught: ' + e);
+d.reject(e);
+}
+return d.promise;
+}
+
+function DeploymentTool() {
+
+}
+
+/**
+ * Determines whether the requested version of the deployment tool is
available.
+ * @returns True if the deployment tool can function; false if not.
+ */
+DeploymentTool.prototype.isAvailable = function() {
+return fs.existsSync(this.path);
+};
+
+/**
+ * Enumerates devices attached to the development machine.
+ * @returns A Promise for an array of objects, which should be passed into
other functions to represent the device.
+ * @remarks The returned objects contain 'index', 'name', and 'type'
properties indicating basic information about them,
+ *which is limited to the information provided by the system. Other
properties may also be included, but they are
+ *specific to the deployment tool which created them and are likely
used internally.
+ */
+DeploymentTool.prototype.enumerateDevices = function() {
+return Q.reject('May not use DeploymentTool directly, instead get an
instance from DeploymentTool.getDeploymentTool()');
+};
+
+/**
+ * Installs an app package to the target device.
+ * @returns A Promise which will be fulfilled on success or rejected on
failure.
+ * @param pathToAppxPackage The path to the .appx package to install.
+ * @param targetDevice An object returned from a successful call to
enumerateDevices.
+ * @shouldLaunch Indicates whether to launch the app after installing it.
+ * @shouldUpdate Indicates whether to explicitly update the app, or
install clean.
+ * @pin Optionally provided if the device requires pairing for deployment.
+ */
+DeploymentTool.prototype.installAppPackage = function(pathToAppxPackage,
targetDevice, shouldLaunch, shouldUpdate, pin) {
+return Q.reject('May not use DeploymentTool directly, instead get an
instance from DeploymentTool.getDeploymentTool()');
+};
+
+/**
+ * Uninstalls an app package from the target device.
+ * @returns A Promise which will be fulfilled on success or rejected on
failure.
+ * @param packageInfo The app package name or Phone GUID representing the
app.
+ * @param targetDevice An object returned from a successful call to
enumerateDevices.
+ */
+DeploymentTool.prototype.uninstallAppPackage = function(packageInfo,
targetDevice) {
+return Q.reject('Unable to uninstall any app packages because that
feature is not supported.');
+};
+
+/**
+ * Gets a list of installed apps on the target device. This function is
not supported for
+ * Windows Phone 8.1.
+ * @param targetDevice {Object} An object returned from a successful
[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34110425
--- Diff: template/cordova/lib/deployment.js ---
@@ -0,0 +1,275 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ License); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+
+var Q = require('q'),
+fs= require('fs'),
+/* jshint ignore:start */ // 'path' only used in ignored blocks
+path = require('path'),
+/* jshint ignore:end */
+proc = require('child_process');
+
+// neither 'exec' nor 'spawn' was sufficient because we need to pass
arguments via spawn
+// but also need to be able to capture stdout / stderr
+function run(cmd, args, opt_cwd) {
+var d = Q.defer();
+try {
+var child = proc.spawn(cmd, args, {cwd: opt_cwd, maxBuffer:
1024000});
+var stdout = '', stderr = '';
+child.stdout.on('data', function(s) { stdout += s; });
+child.stderr.on('data', function(s) { stderr += s; });
+child.on('exit', function(code) {
+if (code) {
+d.reject(stderr);
+} else {
+d.resolve(stdout);
+}
+});
+} catch(e) {
+console.error('error caught: ' + e);
+d.reject(e);
+}
+return d.promise;
+}
+
+function DeploymentTool() {
+
+}
+
+/**
+ * Determines whether the requested version of the deployment tool is
available.
+ * @returns True if the deployment tool can function; false if not.
+ */
+DeploymentTool.prototype.isAvailable = function() {
+return fs.existsSync(this.path);
+};
+
+/**
+ * Enumerates devices attached to the development machine.
+ * @returns A Promise for an array of objects, which should be passed into
other functions to represent the device.
+ * @remarks The returned objects contain 'index', 'name', and 'type'
properties indicating basic information about them,
+ *which is limited to the information provided by the system. Other
properties may also be included, but they are
+ *specific to the deployment tool which created them and are likely
used internally.
+ */
+DeploymentTool.prototype.enumerateDevices = function() {
+return Q.reject('May not use DeploymentTool directly, instead get an
instance from DeploymentTool.getDeploymentTool()');
+};
+
+/**
+ * Installs an app package to the target device.
+ * @returns A Promise which will be fulfilled on success or rejected on
failure.
+ * @param pathToAppxPackage The path to the .appx package to install.
+ * @param targetDevice An object returned from a successful call to
enumerateDevices.
+ * @shouldLaunch Indicates whether to launch the app after installing it.
+ * @shouldUpdate Indicates whether to explicitly update the app, or
install clean.
+ * @pin Optionally provided if the device requires pairing for deployment.
+ */
+DeploymentTool.prototype.installAppPackage = function(pathToAppxPackage,
targetDevice, shouldLaunch, shouldUpdate, pin) {
+return Q.reject('May not use DeploymentTool directly, instead get an
instance from DeploymentTool.getDeploymentTool()');
+};
+
+/**
+ * Uninstalls an app package from the target device.
+ * @returns A Promise which will be fulfilled on success or rejected on
failure.
+ * @param packageInfo The app package name or Phone GUID representing the
app.
+ * @param targetDevice An object returned from a successful call to
enumerateDevices.
+ */
+DeploymentTool.prototype.uninstallAppPackage = function(packageInfo,
targetDevice) {
+return Q.reject('Unable to uninstall any app packages because that
feature is not supported.');
+};
+
+/**
+ * Gets a list of installed apps on the target device. This function is
not supported for
+ * Windows Phone 8.1.
+ * @param targetDevice {Object} An object returned from a successful
[GitHub] cordova-windows pull request: CB-9235 Adds more checks based on th...
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/92#discussion_r34035987
--- Diff: bin/lib/check_reqs.js ---
@@ -19,15 +19,226 @@
/*jshint node:true*/
-var Q = require('Q');
+var Q = require('q');
+var os= require('os');
+var path = require('path');
+var shell = require('shelljs');
-var MSBuildTools;
+var ConfigParser, MSBuildTools, Version, exec;
try {
+ConfigParser = require('../../template/cordova/lib/ConfigParser');
MSBuildTools = require('../../template/cordova/lib/MSBuildTools');
+exec = require('../../template/cordova/lib/exec');
+Version = require('../../template/cordova/lib/Version');
} catch (ex) {
// If previous import fails, we're probably running this script
// from installed platform and the module location is different.
+ConfigParser = require('./ConfigParser');
MSBuildTools = require('./MSBuildTools');
+exec = require('./exec');
+Version = require('./Version');
+}
+
+// The constant for VS2013 Upd2 PackageVersion. See MSDN for
+// reference:
https://msdn.microsoft.com/en-us/library/bb164659(v=vs.120).aspx
+var VS2013_UPDATE2_RC = new Version(12, 0, 30324);
+var REQUIRED_VERSIONS = {
+'8.0': {
+os: '6.1',
+msbuild: '11.0',
+visualstudio: '11.0',
+windowssdk: '8.0'
+},
+'8.1': {
+os: '6.2',
+msbuild: '12.0',
+visualstudio: '12.0',
+windowssdk: '8.1',
+phonesdk: '8.1'
+},
+'10.0': {
+os: '6.2',
--- End diff --
I've realized that there is another mistake from my side: there should be
something like:
```javascript
'8.0': {
os: '6.2', // instead of 6.1
...
},
'8.1': {
os: '6.3', // instead of 6.2
...
},
'10.0': {
os: '6.3', // Note that Windows 10 target is supported on Windows 7.
...// This case get handled in checkOS function separately
...
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
Internal routing error on plugins.cordova.io
Anyone know who can investigate and fix? - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
