[GitHub] cordova-windows pull request: CB-9335: Windows quality-of-life imp...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/98 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9335: Windows quality-of-life improve...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/257 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Fix prepare to wait the promise from plu...
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/259#issuecomment-121459962 Thanks @giuseppelt. Saw your ICLA came through. Change is merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Fix prepare to wait the promise from plu...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/259 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8674 - activationContext
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/97 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8674 - activationContext
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/97#issuecomment-121430365 This is merged and should close soon. The mirrors are slow today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request: CB-8972 Added common 'activated' channel
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/119 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request: CB-9368 remove old debug build steps
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/120 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request: CB-9368 remove old debug build steps
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-js/pull/120 CB-9368 remove old debug build steps You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-js CB-9368 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-js/pull/120.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #120 commit 77c1d9b72c28bec78dcedcd0636be3aa995794a5 Author: Jesse MacFadyen Date: 2015-07-14T22:44:12Z remove old debug build steps --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[Android] Working with M - An update
So, since Cordova-Android wasn't completely killed off by Google at the last Google IO like I thought it would be, we're going to have to make sure it's compatible with Android M (Marshmellow? Marzipan?). The good news is that this only affects the following plugins: MediaRecorder Contacts File FileTransfer Geolocation Now, for the really bad news. We might have to write a Geolocation plugin for Android again, because Google's Android WebView doesn't play nice with Android's new permission system, and even when you do grant the application containing the process permission to use geolocation, you still get a location error. I still have to test this further, but it also may be possible that file URIs no longer have the ability to get the geolocation either, which would be weird, since this would be a Chrome thing and not an Android thing. Given our poor track record of maintaining plugins in general, and the weird errors with Geolocation, I'm not really wanting to bring back the code, so I'm hoping that this gets resolved in M3 with the next dev version of M. But so far, I have the changes that I made to Cordova on a private branch on Github that people can see here: https://github.com/infil00p/cordova-android/tree/m-compat Let me know if you have any questions. I'm not sure whether this makes perfect sense yet, but I think these API changes indicate that we should probably bump the version to 5.0 once M comes out. Thoughts? Questions?
[GitHub] cordova-js pull request: CB-8972 Added common 'activated' channel
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-js/pull/119 CB-8972 Added common 'activated' channel You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-js CB-8972 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-js/pull/119.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #119 commit a8a3218c41ea05382818cd01b9bd4964af313ad3 Author: Jesse MacFadyen Date: 2015-07-14T20:35:15Z Added common 'activated' channel --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Correct image resolution selec...
Github user muratsu commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/56#issuecomment-121375282 @kiwinewt thanks for the contribution. The right approach here is to take into account the max num of pixels instead of a certain height or width limit. VeryLarge5M = 5 * 1000 * 1000; Large3M = 3 * 1000 * 1000; MediumXga = 1024 * 768; SmallVga = 640 * 480; VerySmallQvga = 320 * 240; If you can modify the code as such, I'll be glad to accept your PR - thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: custom label for phoneNumber
Github user typevitor commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/67#issuecomment-121346507 Sorry, my mistake the removed hasPhoneNumber. I'll start a discussion then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-registry-web pull request: CB-9209 add link from old page ...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-registry-web/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-6190 - iOS camera plugin ig...
GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/108 CB-6190 - iOS camera plugin ignores quality parameter CB-6190 - iOS camera plugin ignores quality parameter in some circunstances Added a check to not downscale if quality is 100 or sourceType != UIImagePickerControllerSourceTypeCamera (according to the docs, images from gallery arenât downscaled) You can merge this pull request into a Git repository by running: $ git pull https://github.com/jcesarmobile/cordova-plugin-camera CB-6190 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/108.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #108 commit 6746b8c1445d7a70e039a9bd5ce36ea010747989 Author: Julio César Date: 2015-07-14T18:53:40Z CB-6190 - iOS camera plugin ignores quality parameter CB-6190 - iOS camera plugin ignores quality parameter in some circunstances Added a check to not downscale if quality is 100 or sourceType != UIImagePickerControllerSourceTypeCamera (according to the docs, images from gallery arenât downscaled) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request: CB-9366 Log error.stack as it helps with ...
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-js/pull/118#issuecomment-121336324
I would leave this to userland.
```window.onerror = function(err,filename,lineNumber) {
...
}```
Also, on iOS this is going to look like :
callMe@file:///Users/purplecabbage/Library/Application%20Support/iPhone%20Simulator/7.1/Applications/F40363A6-5AFE-4E19-8125-A1A4C928595D/HelloCordova.app/www/js/index.js:12:13
iAmFunky@file:///Users/purplecabbage/Library/Application%20Support/iPhone%20Simulator/7.1/Applications/F40363A6-5AFE-4E19-8125-A1A4C928595D/HelloCordova.app/www/js/index.js:26:33
fire@file:///Users/purplecabbage/Library/Application%20Support/iPhone%20Simulator/7.1/Applications/F40363A6-5AFE-4E19-8125-A1A4C928595D/HelloCordova.app/www/cordova.js:750:28
file:///Users/purplecabbage/Library/Application%20Support/iPhone%20Simulator/7.1/Applications/F40363A6-5AFE-4E19-8125-A1A4C928595D/HelloCordova.app/www/cordova.js:223:53
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-js pull request: CB-9366 Log error.stack as it helps with ...
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-js/pull/118 CB-9366 Log error.stack as it helps with diagnosing the source of the⦠⦠error You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-js errorStack Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-js/pull/118.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #118 commit 174ff92ae52493711e59d144949cc1f62bcb2cad Author: Nikhil Khandelwal Date: 2015-07-14T18:18:02Z CB-9366 Log error.stack as it helps with diagnosing the source of the error --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9239 Fixes issue with windows pre...
Github user robpaveza commented on the pull request: https://github.com/apache/cordova-windows/pull/99#issuecomment-121325599 I like the change overall but I need to still merge it with my latest to make sure it functionally works as expected. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...
Github user robpaveza commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/58#issuecomment-121324570 Pending my other comments, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: custom label for phoneNumber
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/67#issuecomment-121323697 Um, no. You just removed the hasPhoneNumber functionality which was just added a couple weeks ago? You need to consider more than just Android if you want to get this API in, start a discussion on the dev list or at https://github.com/cordova/cordova-discuss/issues --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9239 Fixes issue with windows pre...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/99#issuecomment-121308567 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: custom label for phoneNumber
GitHub user typevitor opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/67 custom label for phoneNumber writing the possibility for adding custom label for phoneNumbers. You can merge this pull request into a Git repository by running: $ git pull https://github.com/typevitor/cordova-plugin-contacts master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-contacts/pull/67.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #67 commit 3a6d671ffd410b9d8c96fb389e2b03ed34b15cfc Author: Vitor Leal Date: 2015-07-14T16:03:48Z custom label for phoneNumber --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Fix prepare to wait the promise from plu...
Github user giuseppelt commented on the pull request: https://github.com/apache/cordova-lib/pull/259#issuecomment-121279489 I made the changes to use the promise. I signed the icla and mailed to secretary at apache. Do I have to do further actions? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Fix prepare to wait the promise from plu...
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/259#discussion_r34565570
--- Diff: cordova-lib/src/cordova/prepare.js ---
@@ -106,28 +106,29 @@ function prepare(options) {
if (options.browserify) {
plugman.prepare = require('../plugman/prepare-browserify');
}
-plugman.prepare(platformPath, platform, plugins_dir, null,
true, pluginInfoProvider);
-
-// Make sure that config changes for each existing plugin is
in place
-var platformJson = PlatformJson.load(plugins_dir, platform);
-var munger = new PlatformMunger(platform, platformPath,
plugins_dir, platformJson, pluginInfoProvider);
-munger.reapply_global_munge();
-munger.save_all();
-
-// Update platform config.xml based on top level config.xml
-var cfg = new ConfigParser(xml);
-var platform_cfg = new ConfigParser(parser.config_xml());
-exports._mergeXml(cfg.doc.getroot(),
platform_cfg.doc.getroot(), platform, true);
-
-// CB-6976 Windows Universal Apps. For smooth transition and
to prevent mass api failures
-// we allow using windows8 tag for new windows platform
-if (platform == 'windows') {
-exports._mergeXml(cfg.doc.getroot(),
platform_cfg.doc.getroot(), 'windows8', true);
-}
-
-platform_cfg.write();
-
-return parser.update_project(cfg);
+var preparePromise = plugman.prepare(platformPath, platform,
plugins_dir, null, true, pluginInfoProvider);
+return Q(preparePromise).then(function () {
--- End diff --
Yep, realized that eventually - sorry about that :smile:.
However, because ultimately the goal will be to replace the current prepare
with browserify prepare , I'd prefer to keep this code simple and consistent
with how browserify prepare works, and modify the `plugman.prepare` to return a
promise. Then when the regular prepare goes away, we won't be left with
unnecessary complexity here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9239 Fixes issue with windows pre...
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-windows/pull/99#issuecomment-121214310 @nikhilkh, i've added tests + Travis config. See https://github.com/vladimir-kotikov/cordova-windows/pull/1 for build status. Not sure about adding e2e tests, since they will require additional software installation and will take more time. P.S.: The appveyor builds are failing due to UAC disabled on build machines. See https://ci.appveyor.com/project/Humbedooh/cordova-windows/build/1.0.223. There is already ticket for this: https://github.com/appveyor/ci/issues/201 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Fix prepare to wait the promise from plu...
Github user giuseppelt commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/259#discussion_r34558047
--- Diff: cordova-lib/src/cordova/prepare.js ---
@@ -106,28 +106,29 @@ function prepare(options) {
if (options.browserify) {
plugman.prepare = require('../plugman/prepare-browserify');
}
-plugman.prepare(platformPath, platform, plugins_dir, null,
true, pluginInfoProvider);
-
-// Make sure that config changes for each existing plugin is
in place
-var platformJson = PlatformJson.load(plugins_dir, platform);
-var munger = new PlatformMunger(platform, platformPath,
plugins_dir, platformJson, pluginInfoProvider);
-munger.reapply_global_munge();
-munger.save_all();
-
-// Update platform config.xml based on top level config.xml
-var cfg = new ConfigParser(xml);
-var platform_cfg = new ConfigParser(parser.config_xml());
-exports._mergeXml(cfg.doc.getroot(),
platform_cfg.doc.getroot(), platform, true);
-
-// CB-6976 Windows Universal Apps. For smooth transition and
to prevent mass api failures
-// we allow using windows8 tag for new windows platform
-if (platform == 'windows') {
-exports._mergeXml(cfg.doc.getroot(),
platform_cfg.doc.getroot(), 'windows8', true);
-}
-
-platform_cfg.write();
-
-return parser.update_project(cfg);
+var preparePromise = plugman.prepare(platformPath, platform,
plugins_dir, null, true, pluginInfoProvider);
+return Q(preparePromise).then(function () {
--- End diff --
I used Q, because I checked the standard plugman prepare, and it doesn't
return a promise. Instead browserify prepare returns a promise.
So, to avoid the edit of the standard prepare to add a last line of 'return
q.resolve', I decided to wrap with Q to handle "to promise or to not promise"
business.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Fix prepare to wait the promise from plu...
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/259#discussion_r34557772
--- Diff: cordova-lib/src/cordova/prepare.js ---
@@ -106,28 +106,29 @@ function prepare(options) {
if (options.browserify) {
plugman.prepare = require('../plugman/prepare-browserify');
}
-plugman.prepare(platformPath, platform, plugins_dir, null,
true, pluginInfoProvider);
-
-// Make sure that config changes for each existing plugin is
in place
-var platformJson = PlatformJson.load(plugins_dir, platform);
-var munger = new PlatformMunger(platform, platformPath,
plugins_dir, platformJson, pluginInfoProvider);
-munger.reapply_global_munge();
-munger.save_all();
-
-// Update platform config.xml based on top level config.xml
-var cfg = new ConfigParser(xml);
-var platform_cfg = new ConfigParser(parser.config_xml());
-exports._mergeXml(cfg.doc.getroot(),
platform_cfg.doc.getroot(), platform, true);
-
-// CB-6976 Windows Universal Apps. For smooth transition and
to prevent mass api failures
-// we allow using windows8 tag for new windows platform
-if (platform == 'windows') {
-exports._mergeXml(cfg.doc.getroot(),
platform_cfg.doc.getroot(), 'windows8', true);
-}
-
-platform_cfg.write();
-
-return parser.update_project(cfg);
+var preparePromise = plugman.prepare(platformPath, platform,
plugins_dir, null, true, pluginInfoProvider);
+return Q(preparePromise).then(function () {
--- End diff --
Oh, that's right. My bad. I had looked at this previously and forgot that I
had updated `plugman.prepare()` to `return Q()` so I could use the simpler
logic here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Fix prepare to wait the promise from plu...
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/259#discussion_r34557461
--- Diff: cordova-lib/src/cordova/prepare.js ---
@@ -106,28 +106,29 @@ function prepare(options) {
if (options.browserify) {
plugman.prepare = require('../plugman/prepare-browserify');
}
-plugman.prepare(platformPath, platform, plugins_dir, null,
true, pluginInfoProvider);
-
-// Make sure that config changes for each existing plugin is
in place
-var platformJson = PlatformJson.load(plugins_dir, platform);
-var munger = new PlatformMunger(platform, platformPath,
plugins_dir, platformJson, pluginInfoProvider);
-munger.reapply_global_munge();
-munger.save_all();
-
-// Update platform config.xml based on top level config.xml
-var cfg = new ConfigParser(xml);
-var platform_cfg = new ConfigParser(parser.config_xml());
-exports._mergeXml(cfg.doc.getroot(),
platform_cfg.doc.getroot(), platform, true);
-
-// CB-6976 Windows Universal Apps. For smooth transition and
to prevent mass api failures
-// we allow using windows8 tag for new windows platform
-if (platform == 'windows') {
-exports._mergeXml(cfg.doc.getroot(),
platform_cfg.doc.getroot(), 'windows8', true);
-}
-
-platform_cfg.write();
-
-return parser.update_project(cfg);
+var preparePromise = plugman.prepare(platformPath, platform,
plugins_dir, null, true, pluginInfoProvider);
+return Q(preparePromise).then(function () {
--- End diff --
Actually `plugman.prepare` doesn't return promise, but `prepare-browserify`
does. To handle both of them we need to wrap call into promise forcibly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Fix prepare to wait the promise from plu...
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/259#issuecomment-121200391 Thanks @giuseppelt. Looks good to me apart from the one stylistic comment. @stevengill does this look right to you? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Fix prepare to wait the promise from plu...
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/259#discussion_r34556418
--- Diff: cordova-lib/src/cordova/prepare.js ---
@@ -106,28 +106,29 @@ function prepare(options) {
if (options.browserify) {
plugman.prepare = require('../plugman/prepare-browserify');
}
-plugman.prepare(platformPath, platform, plugins_dir, null,
true, pluginInfoProvider);
-
-// Make sure that config changes for each existing plugin is
in place
-var platformJson = PlatformJson.load(plugins_dir, platform);
-var munger = new PlatformMunger(platform, platformPath,
plugins_dir, platformJson, pluginInfoProvider);
-munger.reapply_global_munge();
-munger.save_all();
-
-// Update platform config.xml based on top level config.xml
-var cfg = new ConfigParser(xml);
-var platform_cfg = new ConfigParser(parser.config_xml());
-exports._mergeXml(cfg.doc.getroot(),
platform_cfg.doc.getroot(), platform, true);
-
-// CB-6976 Windows Universal Apps. For smooth transition and
to prevent mass api failures
-// we allow using windows8 tag for new windows platform
-if (platform == 'windows') {
-exports._mergeXml(cfg.doc.getroot(),
platform_cfg.doc.getroot(), 'windows8', true);
-}
-
-platform_cfg.write();
-
-return parser.update_project(cfg);
+var preparePromise = plugman.prepare(platformPath, platform,
plugins_dir, null, true, pluginInfoProvider);
+return Q(preparePromise).then(function () {
--- End diff --
Since plugman.prepare() returns a promise, you should just be able to do
this:
```js
return plugman.prepare(platformPath, platform, plugins_dir, null, true,
pluginInfoProvider)
.then(function () {
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: Cb 9239
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-windows/pull/100 Cb 9239 You can merge this pull request into a Git repository by running: $ git pull https://github.com/vladimir-kotikov/cordova-windows CB-9239 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/100.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #100 commit dc06a8dff0dba8f43e855bed3ac0d1fd73f1c746 Author: Vladimir Kotikov Date: 2015-07-14T10:39:31Z Adds tests for findUAPVersions and Travis config commit 182425e1923e66e1da11a46a28efc5bb1168e6ec Author: Vladimir Kotikov Date: 2015-07-14T10:40:13Z Rework applyPlatformConfig to call jsproj update on Windows only --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: Cb 9239
Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-windows/pull/100 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-media pull request: iOS: Add support for playing no...
Github user foxgeere commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/39#issuecomment-121192973 Is this going to be merged in any time soon? Really need to be able to play sound effects in app without it stopping system music in its tracks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Fix prepare to wait the promise from plu...
GitHub user giuseppelt opened a pull request: https://github.com/apache/cordova-lib/pull/259 Fix prepare to wait the promise from plugman prepare. This fixes the issue where after_prepare hook is fired before the prepare process ends. You can merge this pull request into a Git repository by running: $ git pull https://github.com/giuseppelt/cordova-lib prepare-plugman-promise-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/259.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #259 commit 17217b584d84afd5845208741a5fb3b5ebf99669 Author: giuseppelt Date: 2015-07-14T08:48:44Z Fix prepare to wait the promise from plugman prepare. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
