[GitHub] cordova-plugin-media pull request: Add Media.prototype.setRate met...

[whitecolor]

Github user whitecolor commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/40#issuecomment-122615862
  
Great. When it is going to be available via PG build?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-9384 Plugman should be able to checko...

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-lib/pull/265#issuecomment-122602056
  
Awesome ! Thanks !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Introducing Myself

[Buddhika Jayawardhana]

Hi all,

I am an Undergraduate from Department if Computer Science and Engineering,
University of Moratuwa, Sri Lanka. I am really interested in Apache Cordova
project and I would like to contribute as much as I can. I have basic
knowledge in few programming languages including C, C++ and javascript.
Since I have never contributed to an open source project before, I would
much appreciate if you can send me few guidelines to get started with the
project

Best Regards
-- 
*Buddhika Jayawardhana*
Undergraduate | Department of Computer Science & Engineering
University of Moratuwa
*buddhika...@cse.mrt.ac.lk * | LinkedIn

[GitHub] cordova-wp8 pull request: Get rid of Math.random() when making a r...

[scale-tone]

GitHub user scale-tone opened a pull request:

https://github.com/apache/cordova-wp8/pull/86

Get rid of Math.random() when making a request ID

Math.random() takes several seconds to work (at least on my Lumia 820)! 
That's why, when using AngularJS routing I experienced huge delays when loading 
partial views. This little change fixed that.

Can't file an issue in JIRA, because it fails to load in my browser. So 
just proposing this pull request...

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/scale-tone/cordova-wp8 patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-wp8/pull/86.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #86


commit 5bb96ca4b40c655a1dfea073faf61b6e86f367c2
Author: Konstantin Lepeshenkov 
Date:   2015-07-18T21:12:25Z

Get rid of Math.random() when making a request ID

Math.random() takes several seconds to work (at least on my Lumia 820)! 
That's why, when using AngularJS routing I experienced huge delays when loading 
partial views. This little change fixed that.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Discuss Android plugin compatibility problem

[Mefire O .]

Cool,
As agreed, I've created a JIRA issue to track this :
https://issues.apache.org/jira/browse/CB-9387

I've assigned it to you, Sergey. Feel free to make necessary modifications.

Thanks,
Mefire


From: Carlos Santana 
Sent: Friday, July 17, 2015 6:53 PM
To: dev@cordova.apache.org
Subject: Re: Discuss Android plugin compatibility problem

+1 to doc and maybe add as a comment in plugin template in cli

Having low number of dependencies or not all is something is good that we
aim for.
On Fri, Jul 17, 2015 at 11:59 AM Sergey Grebnov (Akvelon) <
v-seg...@microsoft.com> wrote:

> Agree, sounds like a good plan. I'm going to review and fix this in most
> popular cordova plugins and having this as an official recommendation I can
> refer to will be great (part of Android plugins dev guide).
>
> PS. I've also double checked Cordova core plugins and they are not
> affected (there are actually not so much dependencies at all).
>
> -Original Message-
> From: Mefire O. [mailto:ommen...@microsoft.com]
> Sent: Friday, July 17, 2015 6:39 PM
> To: dev@cordova.apache.org
> Subject: Re: Discuss Android plugin compatibility problem
>
> So, it seems like mechanisms are already in place to enable us to do what
> we wanna do here.
>
> The actionable step I'm seeing here is 'updating the docs to ask plugin
> devs to use plugin.xml to define gradle dependencies'.
>
> If you folks agree with what this actionable item, I will create a jira
> item to track it.
>
> Thanks,
>
> On Jul 17, 2015 7:59 AM, Joe Bowser  wrote:
> I'm fine with it.  I just spaced out and forgot we did that for Crosswalk.
> I thought we had a reference to a gradle file instead.
>
> On Fri, Jul 17, 2015 at 6:14 AM Carlos Santana 
> wrote:
>
> > What's the problem Joe? Having declaring cradle dependencies in
> > plugin.xml I think is a good thing. At high level a plugin should be
> > able to some how declare its dependencies for things located in
> > gradle/maven via plugin.xml, a metada file, or hook.
> > We in IBM are using gradle in plugin.xml for some plugins we do, we
> > want to do the same for iOS with cocoapods
> >
> > On Fri, Jul 17, 2015 at 12:53 AM Joe Bowser  wrote:
> >
> > > Wait, yeah, plugin.xml does handle that.  I was thinking config.xml.
> > WTF?
> > >
> > > On Thu, Jul 16, 2015 at 9:21 PM Carlos Santana
> > > 
> > > wrote:
> > >
> > > > Steve plugin.xml already supports declaring gradle deps
> > > >
> > > > On Thu, Jul 16, 2015 at 1:29 PM Joe Bowser 
> wrote:
> > > >
> > > > > Ideally Maven should handle all this shit, and it should be
> > invisible.
> > > > Our
> > > > > plugin system should not handle Java dependencies or any other
> > platform
> > > > > dependencies, and we should work behind the scenes to make this
> > > > > work
> > > like
> > > > > how Crosswalk works.
> > > > >
> > > > > On Thu, Jul 16, 2015 at 10:18 AM Steven Gill
> > > > >  > >
> > > > > wrote:
> > > > >
> > > > > > Would this be added to plugin.xml?
> > > > > >
> > > > > > On Thu, Jul 16, 2015 at 10:09 AM, Mefire O. <
> > ommen...@microsoft.com>
> > > > > > wrote:
> > > > > >
> > > > > > > +1 on moving deps to gradle.
> > > > > > >
> > > > > > > On Jul 16, 2015 9:37 AM, Carlos Santana
> > > > > > > 
> > > > wrote:
> > > > > > > you mean the scripts in cordova-android right? then yes
> > > > > > >
> > > > > > > +1 create jira bug, enhancements etc.. if doesn't get track
> > > > > > > +it
> > > > doesn't
> > > > > > get
> > > > > > > done
> > > > > > >
> > > > > > > On Thu, Jul 16, 2015 at 12:26 PM Joe Bowser
> > > > > > > 
> > > > wrote:
> > > > > > >
> > > > > > > > Is there a bug created for this? It sounds like we should
> > > > > > > > have
> > > the
> > > > > > local
> > > > > > > > scripts handle dependency adding on Android.
> > > > > > > >
> > > > > > > > On Thu, Jul 16, 2015 at 9:14 AM Carlos Santana <
> > > > csantan...@gmail.com
> > > > > >
> > > > > > > > wrote:
> > > > > > > >
> > > > > > > > > +1 gradle declared dependencies only, cli to warn users
> > > > > > > > > +about
> > > > > plugins
> > > > > > > > > having libraries that will conflict, future is gradle no
> > > > > > > > > ANT
> > > I'm
> > > > ok
> > > > > > to
> > > > > > > > > start deprecating ant going forward.
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > On Thu, Jul 16, 2015 at 11:27 AM Sergey Grebnov
> > > > > > > > > (Akvelon) < v-seg...@microsoft.com> wrote:
> > > > > > > > >
> > > > > > > > > > Hi guys, I want to raise the following question - what
> > > > > > > > > > we
> > > > should
> > > > > > > > > > recommend  plugin developers to avoid 'Multiple dex
> > > > > > > > > > files
> > > > > defined'
> > > > > > > > issue
> > > > > > > > > on
> > > > > > > > > > Android, for example [3]
> > > > > > > > > >
> > > > > > > > > > UNEXPECTED TOP-LEVEL EXCEPTION:
> > > > > > > > > > com.android.dex.DexException: Multiple dex
> > > > > > > > > > files
> > > define
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > 

[GitHub] cordova-lib pull request: CB-9384 Plugman should be able to checko...

[purplecabbage]

Github user purplecabbage commented on the pull request:

https://github.com/apache/cordova-lib/pull/265#issuecomment-122583017
  
Yeah. I'll add it to the docs too


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-9384 Plugman should be able to checko...

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-lib/pull/265#issuecomment-122580433
  
@purplecabbage LGTM !
But could you also add a comment to specify all the forms that 'git_ref' 
could assume ? (branch, commit SHA, etc...). That might prevent attempts at 
optimizations that will break this scenario again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-9384 Plugman should be able to checko...

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-lib/pull/265#issuecomment-122580399
  
I wasn't a fan of the `cryptic` optimizations we were doing to begin with, 
as it rendered the code more cryptic than it needed to be.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device pull request: Change UUID to use [UIDevice i...

[tenfef]

Github user tenfef commented on the pull request:


https://github.com/apache/cordova-plugin-device/pull/36#issuecomment-122514250
  
Have made said changes to documentation. 
https://github.com/apache/cordova-plugin-device/pull/36/files#diff-04c6e90faac2675aa89e2176d2eec7d8R173


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [CI] iOS build breaking

[Shazron]

Not sure what's going on here that line does not exist in master:
https://github.com/apache/cordova-plugin-camera/blob/master/src/ios/CDVCamera.m#L23

I fixed this bug 23 days ago:
https://github.com/apache/cordova-plugin-camera/commit/63110ea54c16d1e0958f0986b3d5a43b254df13a

Perhaps the CI is getting the released version (r1.2.0) instead of master?



On Fri, Jul 17, 2015 at 2:13 PM, Dmitry Blotsky 
wrote:

>
> https://ci.apache.org/builders/cordova-ios/builds/36/steps/running-tests/logs/stdio
>
>
> CDVCamera.m:23:9: fatal error: 'Cordova/NSData+Base64.h' file not found
> #import 
> ^
> 1 error generated.
>
>
> Kindly,
> Dmitry
>

[GitHub] cordova-plugin-device pull request: Change UUID to use [UIDevice i...

[jcesarmobile]

Github user jcesarmobile commented on the pull request:


https://github.com/apache/cordova-plugin-device/pull/36#issuecomment-122512809
  
I think you should add to the readme that users with the app installed will 
get the previous stored UUID instead of the identifierForVendor


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device pull request: Change UUID to use [UIDevice i...

[tenfef]

Github user tenfef commented on the pull request:


https://github.com/apache/cordova-plugin-device/pull/36#issuecomment-122511314
  
I have made the adjustments above to the documentation and also restored 
the use of NSUserDefaults to maintain backwards compatibility.
Jira issue is here: https://issues.apache.org/jira/browse/CB-9386


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org