[GitHub] cordova-lib pull request: CB-9421 Fixed searchpath parameter being...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/269 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device-orientation pull request: CB-9426 Fix except...
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-plugin-device-orientation/pull/21 CB-9426 Fix exception using device orientation plugin on browser platform Initially reported for the `device motion` plugin, the same problem exists for the `device orientation` plugin. The plugin's `plugin.xml` defines a general `` with the name `compass`. It defines another `` for the `browser` platform (that merges with the general module) with the same name. Modules with the same name are not allowed, so Cordova throws an exception at runtime when trying to define the browser version of the module. Since the only difference in the browser version of the module is to fake up `deviceorientation` events, I've deleted the browser version and added that logic to the general module, with the following change: rather than starting a new event timer every time `watchHeading()` is called (which could happen multiple times resulting in multiple superfluous timers), we have a single event timer going as long as there are active watchers. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-device-orientation CB-9426 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-device-orientation/pull/21.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #21 commit eb976dc650d954c721967e2a26808f1cd15635c5 Author: Tim Barham Date: 2015-07-29T05:40:06Z CB-9426 Fix exception when using device orientation plugin on browser platform. The plugin's plugin.xml defines a general with the name 'compass'. It defines another for the browser platform (that merges with the general module) with the same name. Modules with the same name is not allowed, so Cordova throws an exception at runtime when trying to define the browser version of the module. Since the only difference in the browser version of the module is to fake up deviceorientation events, I've deleted the browser version and added that logic to the general module, with the following change: rather than starting a new event timer everytime watchHeading() is called (which could happen multiple times resulting in multiple superfluous timers), we have a single event timer going as long as there are active watchers. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: Fix Q include in check_reqs.js
Github user tohagan commented on the pull request: https://github.com/apache/cordova-ios/pull/132#issuecomment-12582 +1 Still can't build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device-motion pull request: CB-9426 Fix exception u...
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/33#issuecomment-125805744 Ok, I've deleted the browser specific implementation and moved the browser specific logic into the general implementation, and also added some logic to avoid multiple event timers being triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device-motion pull request: CB-9426 Fix exception u...
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/33#issuecomment-125794448 Yeah, I have just been wondering the same thing. The only `browser` specific thing is that it starts firing the `devicemotion` event when you call `watchAcceleration()` (and turns it off when you call `clearWatch()`) - that could easily be included in the general `accelerometer.js`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device-motion pull request: CB-9426 Fix exception u...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/33#issuecomment-125793282 Actually, on second thought ... I don't think there is much reason for the browser implementation to have it's own version of accelerometer.js This file is virtually identical to the one at www/accelerometer.js so maybe it is time for a quick refactor. Your understanding of merges and uniqueness of name are correct though. ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device-motion pull request: CB-9426 Fix exception u...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/33#issuecomment-125792526 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[DISCUSS] cordova-browser 3.7.0 release
It seems to me like it would be good to get a cordova-browser release out. There have been a few changes since the last release - most significantly launching from a server rather than the local file system, which I think is an important change to release. Any objections? Would 3.7.0 be the appropriate version? Thanks! Tim
[GitHub] cordova-plugin-device-motion pull request: CB-9426 Fix exception u...
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/33#issuecomment-125791006 @stevengill and @purplecabbage - interested in whether this fix looks right to you guys, since I've not worked in this code much before. Certainly after my change the functionality seems correct - the `browser` specific module is a merge, with the same target that the general module clobbers. Without my change, we don't get the merge. With my change, I verified we do. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device-motion pull request: CB-9426 Fix exception u...
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-plugin-device-motion/pull/33 CB-9426 Fix exception using device motion plugin on browser platform The plugin's `plugin.xml` defines a general `` with the name `accelerometer`. It defines another `` for the `browser` platform with the same name. Modules with the same name are not allowed, so Cordova throws an exception at runtime when trying to define the browser version of the module. Fix is to rename the browser version of the module `browser-accelerometer`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-device-motion CB-9426 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-device-motion/pull/33.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #33 commit 15ab61a5b15487fc79e657f973fd5a8bcac0cdbf Author: Tim Barham Date: 2015-07-29T00:19:43Z CB-9426 Fix exception when using device motion plugin on browser platform. The plugin's plugin.xml defines a general with the name 'accelerometer'. It defines another for the browser platform (that merges with the general module) with the same name. Modules with the same name is not allowed, so Cordova throws an exception at runtime when trying to define the browser version of the module. Fix is to rename the browser module 'browser-accelerometer'. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Update xcode dependency to latest stable...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/272 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Update ubuntu.js
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/255#issuecomment-125785840 Plugins don't have to have the id XXX-XXX-XXX. They can be anything now. Does this change account for that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[ANNOUNCEMENT] Cordova Android 4.1.0 Released!
http://cordova.apache.org/announcements/2015/07/21/cordova-android-4.1.0.html Tweet: https://twitter.com/apachecordova/status/626174226962227200
[GitHub] cordova-js pull request: CB-7847 Page Visibility API should be sup...
Github user morenoh149 commented on the pull request: https://github.com/apache/cordova-js/pull/86#issuecomment-125773476 Any word on this from 2015? This PR should be closed if it's been decided the api's dont concern the same thing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9420 Fixes malformed require calls in...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/270 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-network-information pull request: Performance-relat...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-network-information/pull/30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-network-information pull request: Performance-relat...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-network-information/pull/30#issuecomment-125736123 Thanks, I am planning to remove all string comparisons one day and actually use the defined types, but this does help in the meantime. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-network-information pull request: Performance-relat...
GitHub user SidFerreira opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/30 Performance-related fix Move all conversions to line 236, saving ~14 tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/SidFerreira/cordova-plugin-network-information patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-network-information/pull/30.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #30 commit 6550b937d0d437183984437deb452cbdd653ac18 Author: Sid Ferreira Date: 2015-07-28T19:55:07Z Performance-related fix Move all conversions to line 236, saving ~14 tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-network-information pull request: Solved toLowerCas...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-network-information/pull/29#issuecomment-125734549 Send a pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-network-information pull request: Solved toLowerCas...
Github user SidFerreira commented on the pull request: https://github.com/apache/cordova-plugin-network-information/pull/29#issuecomment-125732348 Why not make the toLowerCase on the line #236 and saving all the conversion and tests on the other lines? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9420 Fixes malformed require calls in...
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/270#issuecomment-125729265 LGTM! I'll test and merge it in! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: removed broken link in ...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/96 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: README :: remove duplic...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/92 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-device pull request: Change UUID to use [UIDevice i...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/36 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-network-information pull request: [CB-7301] Adding ...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-network-information/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-network-information pull request: Update index.md f...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-network-information/pull/22#issuecomment-125700329 If that is the case, then it is a separate defect, however, I do not believe this is happening. Please revisit/close this pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-network-information pull request: Fixing early call...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-network-information/pull/23#issuecomment-125699962 This pr is hopelessly out of sync. Please fix it if you still think it is valid, or close it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9421 Fixed searchpath parameter being...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/269#issuecomment-125695914 lgtm! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-network-information pull request: Solved toLowerCas...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-network-information/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: CB-9214 - [iOS] Landscape w...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/27 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9405 Limit WMAppManifest description ...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/267 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Make Android default persistent ...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/127#issuecomment-125668467 When I say user, I mean someone with an app on their phone. Either we migrate the users files, or we make app developers do it. The major version bump is a good first indication of the significance of the change, but we need to be sure we document it well and perhaps even provide a sample workaround for debs who need it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Make Android default persistent ...
Github user macdonst commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/127#issuecomment-125647394 @purplecabbage I don't think we need to do this as a user of an older version of this plugin only needs to set the preference "AndroidPersistentFileLocation" to "Compatibility" in config.xml and their files will re-appear. I feel adding 'first run logic' just adds code complexity when it can be handled by documentation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Update xcode dependency to latest stable...
GitHub user galexandrov opened a pull request: https://github.com/apache/cordova-lib/pull/272 Update xcode dependency to latest stable version Update to latest stable version, because new features and bug fixes are introduced in it You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-lib galexandrov/update-xcode-dependency Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/272.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #272 commit dfb2b7904d3564a11f9761edd6618d28ba34afaa Author: Georgi Alexandrov Date: 2015-07-28T14:28:57Z Update xcode dependency to latest stable version --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Add platform project instance in hook op...
Github user galexandrov commented on the pull request: https://github.com/apache/cordova-lib/pull/271#issuecomment-125624618 run ci --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Add platform project instance in hook op...
GitHub user galexandrov opened a pull request: https://github.com/apache/cordova-lib/pull/271 Add platform project instance in hook options context Add platform project instance in hook options context for install/uninstall plugman commands. This is handy when you need to make changes on the project from the hook script. Sample scenario is when you need to change project file from hook script. With this change it will be possible to get the parsed project file ``` javascript var projectRoot = context.opts.projectRoot, projectFile = context.opts.cordova.project.parseProjectFile(projectRoot); ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/Icenium/cordova-lib galexandrov/extend-hook-options Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/271.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #271 commit 2e3451a8fb0d8a146a30b8d7fc8175d04f8d8e8d Author: Georgi Alexandrov Date: 2015-07-28T12:58:31Z Add platform project instance in hook options context for install/uninstall plugman commands --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9420 Fixes malformed require calls in...
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/270 CB-9420 Fixes malformed require calls in browserify bundle This fixes browserify bundle generation problems, desctibed in [CB-9420](https://issues.apache.org/jira/browse/CB-9420) You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-9420 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/270.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #270 commit 08406d568aea542e47afbc93a8a21294ebb3b23b Author: Vladimir Kotikov Date: 2015-07-28T12:14:56Z CB-9420 Fixes malformed require calls in browserify bundle --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9421 Fixed searchpath parameter being...
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/269#discussion_r35641611
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -236,7 +236,7 @@ function findLocalPlugin(plugin_src, searchpath,
pluginInfoProvider) {
versions.forEach(function(pinfo) {
// Ignore versions that don't satisfy the the requested version
range.
-if (!semver.satisfies(pinfo.version, versionspec)) {
+if (!semver.satisfies(pinfo.version.replace(/-dev$/, ''),
versionspec)) {
--- End diff --
This is not obvious, why this change is required. Could you please add a
link to JIRA/semver docs or short explanation, why this needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9421 Fixed searchpath parameter being...
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-lib/pull/269 CB-9421 Fixed searchpath parameter being ignored https://issues.apache.org/jira/browse/CB-9421 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-9421 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/269.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #269 commit b0f724ef127cdb212444faf11496fa90948a2110 Author: alsorokin Date: 2015-07-28T12:34:11Z CB-9421 Fixed searchpath parameter being ignored --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[Vote] 3.9.0 iOS Release
Please review and vote on this 3.9.0 iOS Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9406 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-9406 The package was published from its corresponding git tag: cordova-ios: 3.9.0 (209c1e9e02) Note that you can test it out via: cordova platform add https://github.com/apache/cordova-ios#3.9.0 Blog post to review will be sent by separate email to Discuss thread. Upon a successful vote I will upload the archive to dist/ and publish it to NPM Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Performed manual smoke testing: platform could be added and built -Sergey Grebnov - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Change cordova-lib to execute plugin hoo...
Github user galexandrov commented on the pull request:
https://github.com/apache/cordova-lib/pull/236#issuecomment-125530595
In our case we don't use the Cordova CLI we use cordova-{platform} scripts
for project creation and that's why we don't have the Cordova CLI Project
structure. But it seems that the hooks execution is tightly bound with the
Cordova Project structure and more specific with the existence of cordova
folder.
The condition for hook execution in plugmna was cordovaUtil.isCordova(),
which means that when we use cordova-{platform} scripts for project creation
and cordova-plugman for plugin management the hooks will not be executed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9239 Fixes issue with windows pre...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/99 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9235 Adds more checks based on th...
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-windows/pull/92#issuecomment-125482377 This was merged in 9be50cd43a893f6af532b585baa7fa00e71772c9 but not auto-closed. Closing it now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9235 Adds more checks based on th...
Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-windows/pull/92 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9239 Fixes issue with windows pre...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/99#issuecomment-125480365 lgtm :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9235 Adds more checks based on th...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/92#issuecomment-125480333 lgtm :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-9404 Fixed an exception when path...
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/203#issuecomment-125478024 @alsorokin, please delete MSOT branch, if not needed anymore. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-9404 Fixed an exception when path...
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/203#issuecomment-125472941 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
