Re: cordova platfor update DOA for cordova-android@4.1.0

2015-07-30 Thread julio cesar sanchez
+1 to Joe, this update is 4.1.0 (major version bump) because the support
for API Level 10 was removed

BTW, Carlos, I've seen that you changed the issue priority from Minor to
Critical, I set it to Minor because there is an easy workaround, just tell
the user to add the android-minSdkVersion preference with value 14 or
greater on the config.xml  but


2015-07-31 5:40 GMT+02:00 Joe Bowser :

> Enhance update script and notify user.  We do not support API Level 10.
>
> On Thu, Jul 30, 2015, 8:49 PM Carlos Santana  wrote:
>
> > Is still not clear to me what's the proper fix, to revert back both
> minsdk
> > to level 10, or enhance update script to check if app minsdk have lower
> > level than 14 making incompatible with new cordovalib and update it to 14
> > for the user?
> >
> > On Thu, Jul 30, 2015 at 9:57 PM Murat Sutunc 
> > wrote:
> >
> > > Good catch! +1 on 4.1.1
> > >
> > > > On Jul 30, 2015, at 6:41 PM, Steven Gill 
> > wrote:
> > > >
> > > > +1. I can get a vote out for it tomorrow
> > > >> On Jul 30, 2015 6:20 PM, "Carlos Santana" 
> > wrote:
> > > >>
> > > >> I think we need to fix and release a 4.1.1 this CB-9428 fixed before
> > new
> > > >> cordova-cli get's released.
> > > >>
> > > >> the update logic lives in the platform update script, not the
> cordova
> > > cli
> > > >>
> > > >> https://issues.apache.org/jira/browse/CB-9428
> > > >>
> > > >> basically doing an upgrade today like "cordova platform update
> > > >> android@4.1.0"
> > > >> is DOA when trying to build because the minSDK for CordovaLib get's
> > > updated
> > > >> to 14, but the minSDK for the App remains untouched to 10
> > > >>
> > > >> if a new cordova-cli get's released with android 4.1.0 pinned, then
> > the
> > > >> default platform update "cordova platform update"  problem will be
> > more
> > > >> prevalent and spread
> > > >>
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > >
> > >
> >
>


[GitHub] cordova-plugin-statusbar pull request: CB-9076 Fixed StatusBarOver...

2015-07-30 Thread miscer
Github user miscer commented on the pull request:


https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126570699
  
Running `cordova prepare` fixes the order for me too, thanks for the tip 
@jcesarmobile.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-statusbar pull request: CB-9076 Fixed StatusBarOver...

2015-07-30 Thread miscer
Github user miscer closed the pull request at:

https://github.com/apache/cordova-plugin-statusbar/pull/30


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: cordova platfor update DOA for cordova-android@4.1.0

2015-07-30 Thread Joe Bowser
Enhance update script and notify user.  We do not support API Level 10.

On Thu, Jul 30, 2015, 8:49 PM Carlos Santana  wrote:

> Is still not clear to me what's the proper fix, to revert back both minsdk
> to level 10, or enhance update script to check if app minsdk have lower
> level than 14 making incompatible with new cordovalib and update it to 14
> for the user?
>
> On Thu, Jul 30, 2015 at 9:57 PM Murat Sutunc 
> wrote:
>
> > Good catch! +1 on 4.1.1
> >
> > > On Jul 30, 2015, at 6:41 PM, Steven Gill 
> wrote:
> > >
> > > +1. I can get a vote out for it tomorrow
> > >> On Jul 30, 2015 6:20 PM, "Carlos Santana" 
> wrote:
> > >>
> > >> I think we need to fix and release a 4.1.1 this CB-9428 fixed before
> new
> > >> cordova-cli get's released.
> > >>
> > >> the update logic lives in the platform update script, not the cordova
> > cli
> > >>
> > >> https://issues.apache.org/jira/browse/CB-9428
> > >>
> > >> basically doing an upgrade today like "cordova platform update
> > >> android@4.1.0"
> > >> is DOA when trying to build because the minSDK for CordovaLib get's
> > updated
> > >> to 14, but the minSDK for the App remains untouched to 10
> > >>
> > >> if a new cordova-cli get's released with android 4.1.0 pinned, then
> the
> > >> default platform update "cordova platform update"  problem will be
> more
> > >> prevalent and spread
> > >>
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>


Re: cordova platfor update DOA for cordova-android@4.1.0

2015-07-30 Thread Carlos Santana
Is still not clear to me what's the proper fix, to revert back both minsdk
to level 10, or enhance update script to check if app minsdk have lower
level than 14 making incompatible with new cordovalib and update it to 14
for the user?

On Thu, Jul 30, 2015 at 9:57 PM Murat Sutunc  wrote:

> Good catch! +1 on 4.1.1
>
> > On Jul 30, 2015, at 6:41 PM, Steven Gill  wrote:
> >
> > +1. I can get a vote out for it tomorrow
> >> On Jul 30, 2015 6:20 PM, "Carlos Santana"  wrote:
> >>
> >> I think we need to fix and release a 4.1.1 this CB-9428 fixed before new
> >> cordova-cli get's released.
> >>
> >> the update logic lives in the platform update script, not the cordova
> cli
> >>
> >> https://issues.apache.org/jira/browse/CB-9428
> >>
> >> basically doing an upgrade today like "cordova platform update
> >> android@4.1.0"
> >> is DOA when trying to build because the minSDK for CordovaLib get's
> updated
> >> to 14, but the minSDK for the App remains untouched to 10
> >>
> >> if a new cordova-cli get's released with android 4.1.0 pinned, then the
> >> default platform update "cordova platform update"  problem will be more
> >> prevalent and spread
> >>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>


Re: cordova platfor update DOA for cordova-android@4.1.0

2015-07-30 Thread Murat Sutunc
Good catch! +1 on 4.1.1

> On Jul 30, 2015, at 6:41 PM, Steven Gill  wrote:
> 
> +1. I can get a vote out for it tomorrow
>> On Jul 30, 2015 6:20 PM, "Carlos Santana"  wrote:
>> 
>> I think we need to fix and release a 4.1.1 this CB-9428 fixed before new
>> cordova-cli get's released.
>> 
>> the update logic lives in the platform update script, not the cordova cli
>> 
>> https://issues.apache.org/jira/browse/CB-9428
>> 
>> basically doing an upgrade today like "cordova platform update
>> android@4.1.0"
>> is DOA when trying to build because the minSDK for CordovaLib get's updated
>> to 14, but the minSDK for the App remains untouched to 10
>> 
>> if a new cordova-cli get's released with android 4.1.0 pinned, then the
>> default platform update "cordova platform update"  problem will be more
>> prevalent and spread
>> 

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: cordova platfor update DOA for cordova-android@4.1.0

2015-07-30 Thread Steven Gill
+1. I can get a vote out for it tomorrow
On Jul 30, 2015 6:20 PM, "Carlos Santana"  wrote:

> I think we need to fix and release a 4.1.1 this CB-9428 fixed before new
> cordova-cli get's released.
>
> the update logic lives in the platform update script, not the cordova cli
>
> https://issues.apache.org/jira/browse/CB-9428
>
> basically doing an upgrade today like "cordova platform update
> android@4.1.0"
> is DOA when trying to build because the minSDK for CordovaLib get's updated
> to 14, but the minSDK for the App remains untouched to 10
>
> if a new cordova-cli get's released with android 4.1.0 pinned, then the
> default platform update "cordova platform update"  problem will be more
> prevalent and spread
>


cordova platfor update DOA for cordova-android@4.1.0

2015-07-30 Thread Carlos Santana
I think we need to fix and release a 4.1.1 this CB-9428 fixed before new
cordova-cli get's released.

the update logic lives in the platform update script, not the cordova cli

https://issues.apache.org/jira/browse/CB-9428

basically doing an upgrade today like "cordova platform update android@4.1.0"
is DOA when trying to build because the minSDK for CordovaLib get's updated
to 14, but the minSDK for the App remains untouched to 10

if a new cordova-cli get's released with android 4.1.0 pinned, then the
default platform update "cordova platform update"  problem will be more
prevalent and spread


[GitHub] cordova-docs pull request: CB-9398: Added documentation for Window...

2015-07-30 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/298#discussion_r35933864
  
--- Diff: docs/en/edge/guide/platforms/win8/index.md ---
@@ -272,4 +272,18 @@ command-line tools or the SDK in your workflow. The 
Cordova CLI relies
 on cross-platform source code that routinely overwrites the
 platform-specific files used by the SDK. If you want to use the SDK to
 modify the project, use the lower-level shell tools as an alternative
-to the CLI.
\ No newline at end of file
+to the CLI.
+
+## Supporting Toasts
+
+Windows requires an app manifest capability declaration in order to 
support 
+toast notifications.  When using the `cordova-plugin-local-notifications` 
--- End diff --

Yes, it is allowed to add preferences.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-windows pull request: CB-9410: Added preferences for Windo...

2015-07-30 Thread robpaveza
Github user robpaveza commented on the pull request:

https://github.com/apache/cordova-windows/pull/106#issuecomment-126521787
  
I'm game.  Let's make a Jira for it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-windows pull request: CB-9410: Added preferences for Windo...

2015-07-30 Thread nikhilkh
Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-windows/pull/106#issuecomment-126521511
  
Ah makes sense - thanks. At what point can we remove this code from 
cordova-lib - not sure if support for older project template is that relevant 
now? We could display for people to update their `windows` platform project.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-windows pull request: CB-9410: Added preferences for Windo...

2015-07-30 Thread robpaveza
Github user robpaveza commented on the pull request:

https://github.com/apache/cordova-windows/pull/106#issuecomment-126520990
  
It only goes into the case if it's an "old project template."  This change 
is only expected for newer Cordova projects.  
(src/cordova/metadata/windows_parser.js line 73).  In other words, if you have 
an out-of-date cordova-windows, you don't get the updated behavior.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-windows pull request: CB-9410: Added preferences for Windo...

2015-07-30 Thread nikhilkh
Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-windows/pull/106#issuecomment-126520317
  
@robpaveza - Did you get a chance to look at the comment I mentioned?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-windows pull request: CB-9410: Added preferences for Windo...

2015-07-30 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/106


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib pull request: CB-9278: BugFix: Restoring multiple plat...

2015-07-30 Thread nikhilkh
Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-lib/pull/266#issuecomment-126519728
  
Thinking about it - wonder if you can add test case for this to prevent 
future regression. It's really a basic use case here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib pull request: CB-9278: BugFix: Restoring multiple plat...

2015-07-30 Thread omefire
Github user omefire commented on the pull request:

https://github.com/apache/cordova-lib/pull/266#issuecomment-126516900
  
@nikhilkh , it's ready to be merged in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request: CB-9398: Added documentation for Window...

2015-07-30 Thread robpaveza
Github user robpaveza commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/298#discussion_r35931879
  
--- Diff: docs/en/edge/guide/platforms/win8/index.md ---
@@ -272,4 +272,18 @@ command-line tools or the SDK in your workflow. The 
Cordova CLI relies
 on cross-platform source code that routinely overwrites the
 platform-specific files used by the SDK. If you want to use the SDK to
 modify the project, use the lower-level shell tools as an alternative
-to the CLI.
\ No newline at end of file
+to the CLI.
+
+## Supporting Toasts
+
+Windows requires an app manifest capability declaration in order to 
support 
+toast notifications.  When using the `cordova-plugin-local-notifications` 
--- End diff --

Sure, if a plugin is allowed to modify config.xml, then yes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib pull request: CB-9278: BugFix: Restoring multiple plat...

2015-07-30 Thread nikhilkh
Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-lib/pull/266#issuecomment-126516413
  
@omefire - Is this ready to be merged? It will be good to get this merged 
before the next cordova-lib release.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-docs pull request: CB-9398: Added documentation for Window...

2015-07-30 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/298#discussion_r35931710
  
--- Diff: docs/en/edge/guide/platforms/win8/index.md ---
@@ -272,4 +272,18 @@ command-line tools or the SDK in your workflow. The 
Cordova CLI relies
 on cross-platform source code that routinely overwrites the
 platform-specific files used by the SDK. If you want to use the SDK to
 modify the project, use the lower-level shell tools as an alternative
-to the CLI.
\ No newline at end of file
+to the CLI.
+
+## Supporting Toasts
+
+Windows requires an app manifest capability declaration in order to 
support 
+toast notifications.  When using the `cordova-plugin-local-notifications` 
--- End diff --

Ideally, the plugin should do this addition as part of plugin.xml no?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-windows pull request: CB-9410: Added preferences for Windo...

2015-07-30 Thread nikhilkh
Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-windows/pull/106#issuecomment-126515663
  
cordova-lib does some replacement using the `displayname` and it might not 
work with this change. I'm not tally familiar with what cordova-lib is doing - 
but would be good to review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-windows pull request: CB-9408: Added a `windows-packageVer...

2015-07-30 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/105


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...

2015-07-30 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/96


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-js pull request: CB-9429 Enables jsdom/browser tests for b...

2015-07-30 Thread stevengill
Github user stevengill commented on the pull request:

https://github.com/apache/cordova-js/pull/123#issuecomment-126489678
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-statusbar pull request: CB-9076 Fixed StatusBarOver...

2015-07-30 Thread jcesarmobile
Github user jcesarmobile commented on the pull request:


https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126487866
  
BTW, I checked what you commented about the default value not being the 
first one, and it isn't the first one when you add the platform, but as soon as 
you do a cordova prepare or cordova run it will become the first one again, so 
it will be ignored.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-statusbar pull request: CB-9076 Fixed StatusBarOver...

2015-07-30 Thread jcesarmobile
Github user jcesarmobile commented on the pull request:


https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126475712
  
Sorry, I proposed this change because I didn't know the reason for the 
default preferences. I'm closing CB-9076 now.

Please @miscer, close this pull request and stay tunned to 
https://issues.apache.org/jira/browse/CB-9264 to check the status of the 
duplicate entries issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-statusbar pull request: CB-9076 Fixed StatusBarOver...

2015-07-30 Thread purplecabbage
Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126447487
  
Okay, then it is cordova-lib specific, or platform specific.  But still it 
is not specific to this plugin, and this pull request does not address the 
issue.
The reason default values are added to config.xml is so that developers can 
see that they are available to be changed.
Please close this pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-camera pull request: CB-9151 Trigger captureAction ...

2015-07-30 Thread muratsu
Github user muratsu commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/110#issuecomment-126443320
  
I think the logic has to stay in onClick event for easy cleanup purposes. 
I've made the event handlers seperate functions. It's much cleaner now. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-statusbar pull request: CB-9076 Fixed StatusBarOver...

2015-07-30 Thread jcesarmobile
Github user jcesarmobile commented on the pull request:


https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126413242
  
It happens even without adding a plugin, if you put one of the default 
preferences with another value, both will show (see CB-9264)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-statusbar pull request: CB-9076 Fixed StatusBarOver...

2015-07-30 Thread purplecabbage
Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126395802
  
The issue is plugman specific and just happens to show up here. 
Create a jira for 'Cordova plugin add ' creates duplicate config 
preferences. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Re: org.apache.cordova.camera: Selecting the front-facing camera on Android

2015-07-30 Thread Joe Bowser
It's not guaranteed to work and it doesn't work past 2.3.

On Thu, Jul 30, 2015, 8:49 AM Anders Borg (Abiro) 
wrote:

> The Android API does have support for forcing (or maybe gently suggest)
> that
> the front-facing camera should be used if available, supposedly since 2.3.
>
> The documentation for the plugin specifically says nothing will happen, and
> I've checked that it's true, so ipso facto.
>
> Any hard reason this would not work, provided it was added? To support
> lower
> versions?
>
> I found this to be enlightening (note: 2.3):
>
> http://stackoverflow.com/questions/2779002/how-to-open-front-camera-on-andro
> id-platform
> 
>
> The plugin doesn't use Camera or CameraInfo at all. Rather it issues an
> IMAGE_CAPTURE intent.
>
> IMAGE_CAPTURE doesn't officially support such selection according to this:
>
> http://stackoverflow.com/questions/24413029/how-to-choose-front-camera-on-ne
> w-intent
> 
>
> Time to switch to direct API use?
>
> Cheers,
> Anders
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>


org.apache.cordova.camera: Selecting the front-facing camera on Android

2015-07-30 Thread Anders Borg (Abiro)
The Android API does have support for forcing (or maybe gently suggest) that
the front-facing camera should be used if available, supposedly since 2.3.

The documentation for the plugin specifically says nothing will happen, and
I've checked that it's true, so ipso facto.

Any hard reason this would not work, provided it was added? To support lower
versions?

I found this to be enlightening (note: 2.3):
http://stackoverflow.com/questions/2779002/how-to-open-front-camera-on-andro
id-platform

The plugin doesn't use Camera or CameraInfo at all. Rather it issues an
IMAGE_CAPTURE intent.

IMAGE_CAPTURE doesn't officially support such selection according to this:
http://stackoverflow.com/questions/24413029/how-to-choose-front-camera-on-ne
w-intent

Time to switch to direct API use?

Cheers,
Anders


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-file pull request: Make Android default persistent ...

2015-07-30 Thread macdonst
Github user macdonst commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/127#issuecomment-126341456
  
@purplecabbage we make developers migrate the files if they want to go 
through the trouble. If they don't want to do that they can always get the old 
behaviour by setting the correct preference. Do we really need to write some 
code to show devs how to copy files from one location to another using the 
FileSystem API?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-lib pull request: CB-9407 FFOS permissions missing in mani...

2015-07-30 Thread zalun
GitHub user zalun opened a pull request:

https://github.com/apache/cordova-lib/pull/274

CB-9407 FFOS permissions missing in manifest

CB-9407
running an update on platform_cfg allows permissions from plugins to feed 
the manifest.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zalun/cordova-lib cb-9407-ffos-fix-permission

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/274.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #274


commit 5b6184946d4f82baf14e11bc81b9cf395ff917d7
Author: Piotr Zalewa 
Date:   2015-07-30T12:43:48Z

CB-9407 running an update on platform_cfg allows permissions from plugins 
to feed the manifest.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



Issue with firefoxos permission

2015-07-30 Thread Piotr Zalewa
https://issues.apache.org/jira/browse/CB-9407

For some reason permission is an empty array

config.doc.findall('permission');

https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/metadata/firefoxos_parser.js#L134

although the permission exists in ``this.config_path``





RE: [DISCUSS] cordova-ios 3.9.0 release

2015-07-30 Thread Sergey Grebnov (Akvelon)
Release blog post for review:
https://github.com/cordova/apache-blog-posts/pull/42

Thx!
Sergey
-Original Message-
From: Sergey Grebnov (Akvelon) 
Sent: Monday, July 27, 2015 5:03 PM
To: dev@cordova.apache.org
Subject: RE: [DISCUSS] cordova-ios 3.9.0 release

Please review prepared release branch[1] and release notes[2].
Does anyone have any reason to delay a cordova-ios platform release? Any 
outstanding patches to land?

If not, I will start the release voting tomorrow.

[1] https://github.com/apache/cordova-ios/commits/3.9.x 
[2] 
https://github.com/apache/cordova-ios/commit/a89fe4ed3550527eea51d6b2015e42d6398c9733
 

Thx!
Sergey
-Original Message-
From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com] 
Sent: Friday, July 17, 2015 7:27 PM
To: dev@cordova.apache.org
Subject: RE: [DISCUSS] cordova-ios 3.9.0 release

+1. Yes, let's do it. Thanks, Shaz! 

Let me know if I can help here - though I still don’t have good judgement on 
iOS on what should go out and what should not.

Thanks,
Nikhil


-Original Message-
From: julio cesar sanchez [mailto:jcesarmob...@gmail.com] 
Sent: Thursday, July 16, 2015 11:27 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] cordova-ios 3.9.0 release

+1

2015-07-17 6:24 GMT+02:00 Carlos Santana :

> +1 I think MS mentioned they wanted to cherry pick the signing using
> build.json
>
> On Thu, Jul 16, 2015 at 7:25 PM Shazron  wrote:
>
> > From the hangout today someone mentioned fixes that need to go out, 4.x
> was
> > holding this back (and won't be ready at least not within the next 4
> wks).
> > I'll be away for the next few weeks so I can't help out on this.
> >
> > I'd say branch off 3.8.x and cherry-pick commits in.
> >
> > Thoughts?
> >
>
B�CB��[��X��ܚX�KK[XZ[
�]�][��X��ܚX�P�ܙݘK�\X�K�ܙ�B��܈Y][ۘ[��[X[��K[XZ[
�]�Z[�ܙݘK�\X�K�ܙ�B

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org


[GitHub] cordova-medic pull request: CB-8936 Gathering logs on Windows

2015-07-30 Thread alsorokin
Github user alsorokin closed the pull request at:

https://github.com/apache/cordova-medic/pull/58


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-statusbar pull request: CB-9076 Fixed StatusBarOver...

2015-07-30 Thread jcesarmobile
Github user jcesarmobile commented on the pull request:


https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126208513
  
Ok, I'll take a look, thanks



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-statusbar pull request: CB-9076 Fixed StatusBarOver...

2015-07-30 Thread miscer
Github user miscer commented on the pull request:


https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126207327
  
Yes, it does ignore the first preference, but sometimes the default value 
from plugin.xml is not first, but second in the code. In my case it happened 
when adding the iOS platform after installing the plugin:

(in config.xml)
```xml

```

(in CLI)
```
cordova plugin add cordova-plugin-statusbar
cordova platform add ios
```

(resulting config.xml in platforms/ios)
```xml

...


```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org



[GitHub] cordova-plugin-statusbar pull request: CB-9076 Fixed StatusBarOver...

2015-07-30 Thread jcesarmobile
Github user jcesarmobile commented on the pull request:


https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126205747
  
Hi, I told you on the JIRA page that I could reproduce the preference being 
duplicated, but I couldn't reproduce your problem, in my tests it ignores the 
first preference if there is a second one, can you check again?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org