RE: [VOTE] Tools Release (attempt 3)
+1 * Verified ability to install/uninstall Cordova on Windows * Verified blank app could be created * Verified iOS, Android, Windows platforms could be added and built (iOS prepare only ) * Reviewed release notes * Verified cordova run --list -Sergey Grebnov -Original Message- From: Parashuram N [mailto:panar...@microsoft.com] Sent: Friday, November 6, 2015 12:50 AM To: dev@cordova.apache.org Subject: Re: [VOTE] Tools Release (attempt 3) I vote +1. * Verified tags * Ability to install/uninstall Cordova * Ability to update Cordova * Ability to create blank app for Windows, WP8, Android * Ability to build/run apps * Reviewed release notes * Verified versions * Verified line breaks * Verified 'cordova serve' * Verified that browserified app builds and runs correctly On 11/5/15, 5:04 AM, "Alexander Sorokin (Akvelon)" wrote: >I vote +1. > >* Verified tags >* Ability to install/uninstall Cordova >* Ability to update Cordova >* Ability to create blank app for Windows, WP8, Android >* Ability to build/run apps >* Reviewed release notes >* Verified versions >* Verified line breaks >* Verified 'cordova serve' >* Verified that browserified app builds and runs correctly > >-Original Message- >From: Steven Gill [mailto:stevengil...@gmail.com] >Sent: Thursday, November 5, 2015 12:14 AM >To: dev@cordova.apache.org >Subject: [VOTE] Tools Release (attempt 3) > >Please review and vote on this Tools Release by replying to this email >(and keep discussion on the DISCUSS thread) > >Release issue: >https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues >.apache.org%2fjira%2fbrowse%2fCB-9903&data=01%7c01%7cv-alsoro%40microso >ft.com%7c2896234d7f1e4ec5e8bc08d2e55cfb97%7c72f988bf86f141af91ab2d7cd01 >1db47%7c1&sdata=4sUp2hjJV7Tc47wBBfO0TZKfWIgLY5pH3RVN8W1lWBM%3d > >Tools have been published to >dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9903/ > >The packages were published from their corresponding git tags: > >cordova-js: 4.1.2 (90546bd136) >cordova-lib: 5.4.0 (f977a71539) >cordova-plugman: 1.0.5 (3449d5b251) >cordova-cli: 5.4.0 (81716f6599) > >Upon a successful vote I will upload the archives to dist/, publish them to >npm, and post the corresponding blog post. > >Voting guidelines: >https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub >.com%2fapache%2fcordova-coho%2fblob%2fmaster%2fdocs%2frelease-voting.md >&data=01%7c01%7cv-alsoro%40microsoft.com%7c2896234d7f1e4ec5e8bc08d2e55c >fb97%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=NxhEbqqhiuJlpTwTuQlUb >owcqe65lbJWFsPfpWWYJVc%3d > >Voting will go on for a minimum of 48 hours. > >I vote +1: >* Ran coho audit-license-headers over the relevant repos >* Ran coho check-license to ensure all dependencies and subdependencies >have Apache-compatible licenses >* Created and ran mobilespec on android >?B >CB ? ?[ X ܚX K??K[XZ[? ??] ][ X ܚX P? ܙ?ݘK \?X ?K ܙ B ܈?Y??]?[ۘ[?? > [X[ ? ??K[XZ[? ??] Z?[??? ܙ?ݘK \?X ?K ܙ B - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...
Github user infil00p commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/119#discussion_r44106504 --- Diff: src/android/ContentFilesystem.java --- @@ -18,22 +18,19 @@ Licensed to the Apache Software Foundation (ASF) under one */ package org.apache.cordova.file; -import java.io.File; -import java.io.FileNotFoundException; -import java.io.IOException; -import java.io.OutputStream; - -import org.apache.cordova.CordovaResourceApi; -import org.json.JSONArray; -import org.json.JSONException; -import org.json.JSONObject; - import android.content.ContentResolver; import android.content.Context; import android.database.Cursor; import android.net.Uri; +import android.provider.DocumentsContract; import android.provider.MediaStore; import android.provider.OpenableColumns; +import java.io.File; +import java.io.FileNotFoundException; +import java.io.IOException; +import org.apache.cordova.CordovaResourceApi; +import org.json.JSONException; +import org.json.JSONObject; --- End diff -- LULZ! They follow the "Android Studio/Eclipse put it there for me style". Seriously, Cordova, Android and Java imports should be grouped separately, but I'm not completely concerned about the order of the groupings. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [GitHub] cordova-ios pull request: CB-9883 - Remove unused iOS bridges
And that we need to watch what others commit. More review would have stopped this in the first place. > On Nov 5, 2015, at 6:33 PM, csantanapr wrote: > > Github user csantanapr commented on the pull request: > >https://github.com/apache/cordova-ios/pull/178#issuecomment-154265526 > >@shazron is this a lesson learned that certain experimental things should > be kept in experimental branches and not in master :+1: > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > with INFRA. > --- > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9883 - Remove unused iOS bridges
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-ios/pull/178#issuecomment-154265526 @shazron is this a lesson learned that certain experimental things should be kept in experimental branches and not in master :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-9960 android: Fixed FileNot...
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/135#discussion_r44093710
--- Diff: src/android/CameraLauncher.java ---
@@ -547,7 +547,7 @@ private String ouputModifiedBitmap(Bitmap bitmap, Uri
uri) throws IOException {
String realPath = FileHelper.getRealPath(uri, this.cordova);
// Get filename from uri
-String fileName = realPath != null ?
+String fileName = realPath != null && !realPath.isEmpty() ?
--- End diff --
Looks like TextUtils.isEmpty is not currently used anywhere in Cordova
Android code, so I'm OK with leaving this as-is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-9883 - Remove unused iOS bridges
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/178 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-9960 android: Fixed FileNot...
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/135#discussion_r44093297
--- Diff: src/android/CameraLauncher.java ---
@@ -547,7 +547,7 @@ private String ouputModifiedBitmap(Bitmap bitmap, Uri
uri) throws IOException {
String realPath = FileHelper.getRealPath(uri, this.cordova);
// Get filename from uri
-String fileName = realPath != null ?
+String fileName = realPath != null && !realPath.isEmpty() ?
--- End diff --
This is fine, but you may also consider [TextUtils.isEmpty(realPath)]
(http://developer.android.com/reference/android/text/TextUtils.html#isEmpty(java.lang.CharSequence))
-- that is the recommended way in Android to check if a string is null or
empty.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-9960 android: Fixed FileNot...
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/135 CB-9960 android: Fixed FileNotFoundException for some gallery images Certain gallery applications (such as Google Photos) return `content://` URIs that our method of getting a file path (`FileHelper.getRealPath()`) fails to properly dereference. Using these applications with `cameraOptions` that cause the image to be edited (width/height, correctOrientation, allowEdit, etc.) would trigger a FileNotFoundException and cause the plugin to fail because it is unable to grab the original filename. This checks the result of `FileHelper.getRealPath()` and if it fails to grab a path instead uses the generic filename "modified.jpg" for the local file (which was the intended behavior before, we were just checking the result of `getRealPath()` incorrectly). Note: These images will lose their EXIF data (the Exifinterface needs a local file path, I think) You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-camera CB-9960 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/135.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #135 commit 338785b527e9a767fe717f95c920cda69e203ef6 Author: riknoll Date: 2015-11-05T23:03:35Z CB-9960 android: Fixed FileNotFoundException for some gallery images --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [DISCUSS] Plugins release
I think this PR should get in the release: https://github.com/apache/cordova-plugin-file/pull/146 It might be considered a blocker, because it is a regression that could cause loss of data when upgrading apps which relied on the default AndroidPersistentFileLocation value. This would be a good one also, as it fixes a significant failure working with some kinds of files on Android 5.0: https://github.com/apache/cordova-plugin-file/pull/119 Jason -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, November 5, 2015 3:09 PM To: dev@cordova.apache.org Subject: [DISCUSS] Plugins release I plan on starting a plugins release on Monday. It is going to be a big one. Please review and close as many PRs as you can before than. If you have PR that is ready and needs someone to look at + merge, please share it in this thread and we will try to get to it before the release. You could also share it on slack[1] in the #plugins channel. Let me know if we have any blockers. Cheers, -Steve [1] https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fslack.cordova.io&data=01%7c01%7cjasongin%40microsoft.com%7c6bb15854633242978d6208d2e636167f%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=QY3Nj3rIJVCSOuncqfAqTul2GKH9L0Z7FQ3oaln4vg4%3d
[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...
Github user jasongin commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154226660 Looks good to me other than the minor style issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...
Github user jasongin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/119#discussion_r44084198 --- Diff: src/android/ContentFilesystem.java --- @@ -18,22 +18,19 @@ Licensed to the Apache Software Foundation (ASF) under one */ package org.apache.cordova.file; -import java.io.File; -import java.io.FileNotFoundException; -import java.io.IOException; -import java.io.OutputStream; - -import org.apache.cordova.CordovaResourceApi; -import org.json.JSONArray; -import org.json.JSONException; -import org.json.JSONObject; - import android.content.ContentResolver; import android.content.Context; import android.database.Cursor; import android.net.Uri; +import android.provider.DocumentsContract; import android.provider.MediaStore; import android.provider.OpenableColumns; +import java.io.File; +import java.io.FileNotFoundException; +import java.io.IOException; +import org.apache.cordova.CordovaResourceApi; +import org.json.JSONException; +import org.json.JSONObject; --- End diff -- Please keep the import statements separated into groups. Ideally I think they should follow the [Android style](http://source.android.com/source/code-style.html#order-import-statements), but not all of Cordova's Android code follows that now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[DISCUSS] Plugins release
I plan on starting a plugins release on Monday. It is going to be a big one. Please review and close as many PRs as you can before than. If you have PR that is ready and needs someone to look at + merge, please share it in this thread and we will try to get to it before the release. You could also share it on slack[1] in the #plugins channel. Let me know if we have any blockers. Cheers, -Steve [1] http://slack.cordova.io
[GitHub] cordova-docs pull request: Set proper name in iOS config documenta...
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/414#issuecomment-154225170 Thanks for the PR @asc0de! I merged it in and followed up with a change to all the other languages. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Update to plugin.md regarding Cordova-A...
Github user stevengill commented on the pull request: https://github.com/apache/cordova-docs/pull/409#issuecomment-154222972 I'm also going to add a link to the android permissions doc you wrote after I merge this commit in. That way plugin authors can go update their plugins if needed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Update to plugin.md regarding Cordova-A...
Github user stevengill commented on the pull request: https://github.com/apache/cordova-docs/pull/409#issuecomment-154222843 Agreed, maybe we should say soon and then mention they can install plugins via giturl. Then provide an example: `cordova plugin add https://github.com/apache/cordova-plugin-camera` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Set proper name in iOS config documenta...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/414 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Update to plugin.md regarding Cordova-A...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-docs/pull/409#issuecomment-154222313 @stevengill I was hesitant on that, because we can't make any guarantees about when we release anything due to the apache process. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Update to plugin.md regarding Cordova-A...
Github user stevengill commented on the pull request: https://github.com/apache/cordova-docs/pull/409#issuecomment-154222063 Might be worth it to add a point about which core plugins require the new permission model and mention that we plan on releasing updated versions of plugins next week --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Update to plugin.md regarding Cordova-A...
Github user stevengill commented on the pull request: https://github.com/apache/cordova-docs/pull/409#issuecomment-154218614 Once I merge in the blog, I'm going to add `s to a bunch of code words in the commits section. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: Update to plugin.md regarding Cordova-A...
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/409#discussion_r44080144 --- Diff: www/_posts/2015-11-05-cordova-android-5.0.0.md --- @@ -0,0 +1,57 @@ +--- +layout: post +author: +name:Joe Bowser +url: https://twitter.com/infil00p +title: "Apache Cordova 5.0.0" +categories: announcements +tags: news releases +--- +We are happy to announce that Cordova Android 5.0.0` has been released. --- End diff -- I think you are missing a ` at the start of Cordova Android 5.0.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Cordova-Android 5.0.x
Please review the doc changes + release blog post at https://github.com/apache/cordova-docs/pull/409. Provide feedback on the PR. On Fri, Oct 23, 2015 at 11:20 AM, Jesse wrote: > +! > > > My team is hiring! > @purplecabbage > risingj.com > > On Fri, Oct 23, 2015 at 3:46 AM, Shazron wrote: > > > +1 > > > > On Thu, Oct 22, 2015 at 10:38 AM, Joe Bowser wrote: > > > BUMP! I'd like to start the vote thread on Monday! > > > > > > On Tue, Oct 20, 2015 at 10:01 AM, Joe Bowser > wrote: > > > > > >> Hey > > >> > > >> I would like to release Cordova-Android 5.0.x soon so that I can then > > move > > >> on to releasing each of the plugins that depend on it so we can get > > ready > > >> to release a CLI version by the end of the year. Is there anything > > that's > > >> currently blocking us from doing this other than minor class name > > changes? > > >> > > >> Is there any reason we shouldn't start the release process once we > > change > > >> the name of CordovaWebView to CordovaWebInterface? Respond in this > > thread. > > >> > > >> Thanks > > >> > > >> Joe > > >> > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > >
[GitHub] cordova-docs pull request: CB-9959: Makes plugins search case inse...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/412 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-9959: Makes plugins search case inse...
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/412#issuecomment-154212220 Tested. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: Cb 9964
GitHub user dubeejw opened a pull request: https://github.com/apache/cordova-lib/pull/339 Cb 9964 When providing a --template argument during project creation, users can use templates apps from a local directory, GitHub, or NPM. This makes sharing templates, and example apps much easier. When using a GitHub URL, the user may specific a branch to pull from by appending a "#" followed by a tag name to the Git URL. A version can also be supplied by the user when fetching a template from NPM. This may be done by appending a "@" followed by the NPM version to the NPM package name. î You can merge this pull request into a Git repository by running: $ git pull https://github.com/dubeejw/cordova-lib CB-9964 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/339.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #339 commit 02cfffe05ac5b8002429dd5e78c247ee2ec68819 Author: dubeejw Date: 2015-11-05T21:05:06Z CB-9964 Added --template to Cordova Create - Templates can now be used from GitHub, and NPM commit e9f2298f1722e27f2ecf4bf7bf37eeb036cec46a Author: dubeejw Date: 2015-11-05T21:06:15Z CB-9964 Added --template to Cordova Create - Templates can now be used from GitHub, and NPM commit 303729b64336ceb80a11a4c18adce4f440a28026 Author: dubeejw Date: 2015-11-05T21:07:30Z CB-9964 Added --template to Cordova Create - Automation for new --template arguments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-cli pull request: Cb 9964
GitHub user dubeejw opened a pull request: https://github.com/apache/cordova-cli/pull/226 Cb 9964 When providing a --template argument during project creation, users can use templates apps from a local directory, GitHub, or NPM. This makes sharing templates, and example apps much easier. When using a GitHub URL, the user may specific a branch to pull from by appending a "#" followed by a tag name to the Git URL. A version can also be supplied by the user when fetching a template from NPM. This may be done by appending a "@" followed by the NPM version to the NPM package name. î You can merge this pull request into a Git repository by running: $ git pull https://github.com/dubeejw/cordova-cli CB-9964 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-cli/pull/226.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #226 commit 13fea6898697971f4b412681a8394416e8aa6c1f Author: dubeejw Date: 2015-11-05T21:27:27Z CB-9964 Add --template to Cordova Create - Templates can now be used from GitHub, and NPM commit 427321c0134cb62dc555f67bbe9be542310d71e9 Author: dubeejw Date: 2015-11-05T21:32:28Z CB-9964 Add --template to Cordova Create - Tempalates can now be used from GitHub, and NPM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [VOTE] Tools Release (attempt 3)
I vote +1. * Verified tags * Ability to install/uninstall Cordova * Ability to update Cordova * Ability to create blank app for Windows, WP8, Android * Ability to build/run apps * Reviewed release notes * Verified versions * Verified line breaks * Verified 'cordova serve' * Verified that browserified app builds and runs correctly On 11/5/15, 5:04 AM, "Alexander Sorokin (Akvelon)" wrote: >I vote +1. > >* Verified tags >* Ability to install/uninstall Cordova >* Ability to update Cordova >* Ability to create blank app for Windows, WP8, Android >* Ability to build/run apps >* Reviewed release notes >* Verified versions >* Verified line breaks >* Verified 'cordova serve' >* Verified that browserified app builds and runs correctly > >-Original Message- >From: Steven Gill [mailto:stevengil...@gmail.com] >Sent: Thursday, November 5, 2015 12:14 AM >To: dev@cordova.apache.org >Subject: [VOTE] Tools Release (attempt 3) > >Please review and vote on this Tools Release by replying to this email (and >keep discussion on the DISCUSS thread) > >Release issue: >https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-9903&data=01%7c01%7cv-alsoro%40microsoft.com%7c2896234d7f1e4ec5e8bc08d2e55cfb97%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=4sUp2hjJV7Tc47wBBfO0TZKfWIgLY5pH3RVN8W1lWBM%3d > >Tools have been published to >dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9903/ > >The packages were published from their corresponding git tags: > >cordova-js: 4.1.2 (90546bd136) >cordova-lib: 5.4.0 (f977a71539) >cordova-plugman: 1.0.5 (3449d5b251) >cordova-cli: 5.4.0 (81716f6599) > >Upon a successful vote I will upload the archives to dist/, publish them to >npm, and post the corresponding blog post. > >Voting guidelines: >https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fapache%2fcordova-coho%2fblob%2fmaster%2fdocs%2frelease-voting.md&data=01%7c01%7cv-alsoro%40microsoft.com%7c2896234d7f1e4ec5e8bc08d2e55cfb97%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=NxhEbqqhiuJlpTwTuQlUbowcqe65lbJWFsPfpWWYJVc%3d > >Voting will go on for a minimum of 48 hours. > >I vote +1: >* Ran coho audit-license-headers over the relevant repos >* Ran coho check-license to ensure all dependencies and subdependencies have >Apache-compatible licenses >* Created and ran mobilespec on android >?B�CB�?�?[��X��ܚX�K??K[XZ[?�??]�][��X��ܚX�P?�ܙ?ݘK�\?X�?K�ܙ�B��܈?Y??]?[ۘ[??��[X[�?�??K[XZ[?�??]�Z?[???�ܙ?ݘK�\?X�?K�ܙ�B - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request:
Github user CatinhoCR commented on the pull request: https://github.com/apache/cordova-lib/commit/1b55e26bc5b234aa5c988291eee010607dba7c00#commitcomment-14223450 I'm still having this issue, tried to install node v 4.2.2 as suggested by @mgtorrea but didnt work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...
Github user cjpearson commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154190076 https://issues.apache.org/jira/browse/CB-9965 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...
Github user infil00p commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154187370 Can you create a JIRA issue for this, so I know what I'm testing? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...
Github user didlich commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154184039 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...
Github user cjpearson commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154181249 @infil00p, could you take a look at this PR? I'm running into this issue when I try to open a file that was taken from the camera plugin on Android Lollipop. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [Vote] 5.0.0 Android Release (attempt 2)
The vote has now closed. The results are: Positive Binding Votes: 3 Steve Gill Sergey Grebnov Joe Bowser The vote has passed. I wil now publish to dist and npm. @Frederico, please take the question to the [discuss] android release thread. We still need to do plugin + a new tools release for this to work out of the box On Thu, Nov 5, 2015 at 11:29 AM, Frederico Galvão < frederico.gal...@pontoget.com.br> wrote: > (This is kinda of a +1) > > Before anything else, I wanna make it clear that it is **not my intention > to rush or demand anything at all**. > > Is anything else holding this release back? I have some urgent new project > to go on about and it'd be crazy awesome if I could have 5.0 from the start > so I don't have to update. I've been following the subject for a while and > it seems that there's nothing really wrong with this release candidate... I > just wanna know if I can wait t < 24 hours or if I should proceed with 4.x. > > Thanks again. > > 2015-11-04 21:06 GMT-02:00 Carlos Santana : > > > Sorry Joe, I should know better :-( > > > > On Wed, Nov 4, 2015 at 3:58 PM Joe Bowser wrote: > > > > > This should really go to discuss if this doesn't have the vote in it. > > > > > > On Wed, Nov 4, 2015 at 12:50 PM Steven Gill > > > wrote: > > > > > > > Created an issue: https://issues.apache.org/jira/browse/INFRA-10718 > > > > > > > > On Wed, Nov 4, 2015 at 5:06 AM, Carlos Santana > > > > > wrote: > > > > > > > > > Did someone opened a infra ticket? > > > > > > > > > > Using the git-wip url on platform add should work right? > > > > > I usually use content of dist when verifying and after release just > > use > > > > npm > > > > > > > > > > - Carlos > > > > > @csantanapr > > > > > > > > > > > On Nov 3, 2015, at 4:15 PM, Steven Gill > > > > wrote: > > > > > > > > > > > > The wrappy error still exists on github due to the tag not being > > > > updated. > > > > > > Blame apache infra and the shitty solution to mirror instead of > > using > > > > > > github proper. > > > > > > > > > > > > You can see the difference. > > > > > > Git-wip: > > > > > > > > > > > > > > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=shortlog;h=refs/tags/5.0.0 > > > > > > Github: https://github.com/apache/cordova-android/tree/5.0.0 > > > > > > > > > > > > I recommend cloning android locally from git-wip and checking out > > > 5.0.0 > > > > > and > > > > > > then adding that to your test project. > > > > > > > > > > > > git clone > > > https://git-wip-us.apache.org/repos/asf/cordova-android.git > > > > > > cd cordova-android, git checkout 5.0.0 > > > > > > cd ../testProject && cordova platform add ../cordova-android > > > > > > > > > > > > > > > > > >> On Tue, Nov 3, 2015 at 12:50 PM, Joe Bowser > > > > wrote: > > > > > >> > > > > > >> I vote -1 > > > > > >> > > > > > >> Android itself appears fine, but that stupid wrappy error is > still > > > > > present > > > > > >> in cordova-common. Can we somehow remove cordova-common for > this > > > > > release, > > > > > >> since it seems that PlatformAPI isn't working out right now. > > > > > >> > > > > > >> > > > > > >> > > > > > >> On Tue, Nov 3, 2015 at 9:04 AM Sergey Grebnov (Akvelon) < > > > > > >> v-seg...@microsoft.com> wrote: > > > > > >> > > > > > >>> I vote +1 > > > > > >>> > > > > > >>> * Manually verified platform could be added, built and run > using > > > > blank > > > > > >> app > > > > > >>> * Ran Autotests (mobilespec) > > > > > >>> > > > > > >>> Thx! > > > > > >>> Sergey Grebnov > > > > > >>> > > > > > >>> -Original Message- > > > > > >>> From: Steven Gill [mailto:stevengil...@gmail.com] > > > > > >>> Sent: Tuesday, November 3, 2015 4:19 AM > > > > > >>> To: dev@cordova.apache.org > > > > > >>> Subject: [Vote] 5.0.0 Android Release (attempt 2) > > > > > >>> > > > > > >>> Please review and vote on this 5.0.0 Android Release by > replying > > to > > > > > this > > > > > >>> email (and keep discussion on the DISCUSS thread) > > > > > >>> > > > > > >>> Release issue: > > > > > >> > > > > > > > > > > > > > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-9922&data=01%7c01%7cv-segreb%40microsoft.com%7c82b9c14cfc8c063208d2e3ecc984%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=vchcX0DwUbqji8UFC%2bBNkwv%2b122TVbs2%2fRNmfwxmky0%3d > > > > > >>> > > > > > >>> The archive has been published to dist/dev: > > > > > >> > > > > > > > > > > > > > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist.apache.org%2frepos%2fdist%2fdev%2fcordova%2fCB-9922&data=01%7c01%7cv-segreb%40microsoft.com%7c82b9c14cfc8c063208d2e3ecc984%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=zjIxNYCqSl3%2b9XJXZuGQq4FM9PFBgNMLXRhexCCQaWY%3d > > > > > >>> > > > > > >>> The package was published from its corresponding git tag: > > > > > >>> cordova-android: 5.0.0 (59a0189719) > > > > > >>> > > > > > >>> Note that you can test it out via: > > > > > >>> > > > > > >>>cordova platform a
[GitHub] cordova-docs pull request: CB-9903 added 5.4.0 tools release blog
Github user stevengill commented on the pull request: https://github.com/apache/cordova-docs/pull/411#issuecomment-154164542 oo good point about the cordova-app-hello-world update. I'll add it now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [Vote] 5.0.0 Android Release (attempt 2)
(This is kinda of a +1) Before anything else, I wanna make it clear that it is **not my intention to rush or demand anything at all**. Is anything else holding this release back? I have some urgent new project to go on about and it'd be crazy awesome if I could have 5.0 from the start so I don't have to update. I've been following the subject for a while and it seems that there's nothing really wrong with this release candidate... I just wanna know if I can wait t < 24 hours or if I should proceed with 4.x. Thanks again. 2015-11-04 21:06 GMT-02:00 Carlos Santana : > Sorry Joe, I should know better :-( > > On Wed, Nov 4, 2015 at 3:58 PM Joe Bowser wrote: > > > This should really go to discuss if this doesn't have the vote in it. > > > > On Wed, Nov 4, 2015 at 12:50 PM Steven Gill > > wrote: > > > > > Created an issue: https://issues.apache.org/jira/browse/INFRA-10718 > > > > > > On Wed, Nov 4, 2015 at 5:06 AM, Carlos Santana > > > wrote: > > > > > > > Did someone opened a infra ticket? > > > > > > > > Using the git-wip url on platform add should work right? > > > > I usually use content of dist when verifying and after release just > use > > > npm > > > > > > > > - Carlos > > > > @csantanapr > > > > > > > > > On Nov 3, 2015, at 4:15 PM, Steven Gill > > > wrote: > > > > > > > > > > The wrappy error still exists on github due to the tag not being > > > updated. > > > > > Blame apache infra and the shitty solution to mirror instead of > using > > > > > github proper. > > > > > > > > > > You can see the difference. > > > > > Git-wip: > > > > > > > > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=shortlog;h=refs/tags/5.0.0 > > > > > Github: https://github.com/apache/cordova-android/tree/5.0.0 > > > > > > > > > > I recommend cloning android locally from git-wip and checking out > > 5.0.0 > > > > and > > > > > then adding that to your test project. > > > > > > > > > > git clone > > https://git-wip-us.apache.org/repos/asf/cordova-android.git > > > > > cd cordova-android, git checkout 5.0.0 > > > > > cd ../testProject && cordova platform add ../cordova-android > > > > > > > > > > > > > > >> On Tue, Nov 3, 2015 at 12:50 PM, Joe Bowser > > > wrote: > > > > >> > > > > >> I vote -1 > > > > >> > > > > >> Android itself appears fine, but that stupid wrappy error is still > > > > present > > > > >> in cordova-common. Can we somehow remove cordova-common for this > > > > release, > > > > >> since it seems that PlatformAPI isn't working out right now. > > > > >> > > > > >> > > > > >> > > > > >> On Tue, Nov 3, 2015 at 9:04 AM Sergey Grebnov (Akvelon) < > > > > >> v-seg...@microsoft.com> wrote: > > > > >> > > > > >>> I vote +1 > > > > >>> > > > > >>> * Manually verified platform could be added, built and run using > > > blank > > > > >> app > > > > >>> * Ran Autotests (mobilespec) > > > > >>> > > > > >>> Thx! > > > > >>> Sergey Grebnov > > > > >>> > > > > >>> -Original Message- > > > > >>> From: Steven Gill [mailto:stevengil...@gmail.com] > > > > >>> Sent: Tuesday, November 3, 2015 4:19 AM > > > > >>> To: dev@cordova.apache.org > > > > >>> Subject: [Vote] 5.0.0 Android Release (attempt 2) > > > > >>> > > > > >>> Please review and vote on this 5.0.0 Android Release by replying > to > > > > this > > > > >>> email (and keep discussion on the DISCUSS thread) > > > > >>> > > > > >>> Release issue: > > > > >> > > > > > > > > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-9922&data=01%7c01%7cv-segreb%40microsoft.com%7c82b9c14cfc8c063208d2e3ecc984%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=vchcX0DwUbqji8UFC%2bBNkwv%2b122TVbs2%2fRNmfwxmky0%3d > > > > >>> > > > > >>> The archive has been published to dist/dev: > > > > >> > > > > > > > > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist.apache.org%2frepos%2fdist%2fdev%2fcordova%2fCB-9922&data=01%7c01%7cv-segreb%40microsoft.com%7c82b9c14cfc8c063208d2e3ecc984%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=zjIxNYCqSl3%2b9XJXZuGQq4FM9PFBgNMLXRhexCCQaWY%3d > > > > >>> > > > > >>> The package was published from its corresponding git tag: > > > > >>> cordova-android: 5.0.0 (59a0189719) > > > > >>> > > > > >>> Note that you can test it out via: > > > > >>> > > > > >>>cordova platform add > > > > >> > > > > > > > > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fapache%2fcordova-android%235.0.0&data=01%7c01%7cv-segreb%40microsoft.com%7c82b9c14cfc8c063208d2e3ecc984%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=HmIxvheBA9lvXti6v6WpaSaEPcalduKc7WRFAdPfs8o%3d > > > > >>> > > > > >>> Checkout [1] to find testing instructions. > > > > >>> > > > > >>> Release notes [2] > > > > >>> > > > > >>> Upon a successful vote I will upload the archive to dist/, > publish > > it > > > > to > > > > >>> npm, and post the blog post. > > > > >>> > > > > >>> Voting guidelines: > > > > >> > > > > > > > > > > https://na01.safelinks.protectio
[GitHub] cordova-docs pull request: CB-9903 added 5.4.0 tools release blog
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/411#discussion_r44055345 --- Diff: www/_posts/2015-11-04-tools-release.md --- @@ -0,0 +1,121 @@ +--- +layout: post +author: +name: Steve Gill +url: https://twitter.com/stevesgill +title: "Tools Release: November 4th, 2015" +categories: news +tags: release tools +--- +New versions of cordova tools are now live! + +* [cordova-lib@5.4.0](https://www.npmjs.org/package/cordova-lib) +* [cordova@5.4.0](https://www.npmjs.org/package/cordova) +* [plugman@1.0.5](https://www.npmjs.org/package/plugman) +* [cordova-js@4.1.2](https://www.npmjs.org/package/cordova-js) + +Release highlights: + +* Fixed issues with using **Node 4 & 5** and **npm 3**. +* Cordova will now auto convert old-style plugin IDs to new style plugin IDs when doing a `cordova plugin add`. This only happens if the old-style plugin ID exists in the [registry-mapper](https://github.com/stevengill/cordova-registry-mapper), it will be auto converted to the new ID and fetched from [npm](https://www.npmjs.com) instead. +* Cordova `CLI` will now know if a newer version is available and will prompt users to update. +* Some core utility methods from `cordova-lib` have been moved into a new module named [`cordova-common`](https://github.com/apache/cordova-lib/tree/master/cordova-commo://github.com/apache/cordova-lib/tree/master/cordova-common). `cordova-common` is shared among `cordova-lib` and cordova platforms. + +To update your tools: + + * If you have `cordova` installed: + +npm install -g cordova@latest + + * If you have `plugman` installed: + +npm install -g plugman@latest + + +# Changes include: + +## Platform updates +When adding these platforms to your project, the following versions are now used by default. +These platform versions were released recently, and the tools' defaults were updated: --- End diff -- Makes sense +1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-9903 added 5.4.0 tools release blog
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/411#discussion_r44054631 --- Diff: www/_posts/2015-11-04-tools-release.md --- @@ -0,0 +1,121 @@ +--- +layout: post +author: +name: Steve Gill +url: https://twitter.com/stevesgill +title: "Tools Release: November 4th, 2015" +categories: news +tags: release tools +--- +New versions of cordova tools are now live! + +* [cordova-lib@5.4.0](https://www.npmjs.org/package/cordova-lib) +* [cordova@5.4.0](https://www.npmjs.org/package/cordova) +* [plugman@1.0.5](https://www.npmjs.org/package/plugman) +* [cordova-js@4.1.2](https://www.npmjs.org/package/cordova-js) + +Release highlights: + +* Fixed issues with using **Node 4 & 5** and **npm 3**. +* Cordova will now auto convert old-style plugin IDs to new style plugin IDs when doing a `cordova plugin add`. This only happens if the old-style plugin ID exists in the [registry-mapper](https://github.com/stevengill/cordova-registry-mapper), it will be auto converted to the new ID and fetched from [npm](https://www.npmjs.com) instead. +* Cordova `CLI` will now know if a newer version is available and will prompt users to update. +* Some core utility methods from `cordova-lib` have been moved into a new module named [`cordova-common`](https://github.com/apache/cordova-lib/tree/master/cordova-commo://github.com/apache/cordova-lib/tree/master/cordova-common). `cordova-common` is shared among `cordova-lib` and cordova platforms. + +To update your tools: + + * If you have `cordova` installed: + +npm install -g cordova@latest + + * If you have `plugman` installed: + +npm install -g plugman@latest + + +# Changes include: + +## Platform updates +When adding these platforms to your project, the following versions are now used by default. +These platform versions were released recently, and the tools' defaults were updated: --- End diff -- You are right of course. I just wanted to highlight that 3.9.2 ios is out. Tools defaults weren't updated but platform versions were released. No big deal here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Removal of unused iOS bridges
I will integrate this later today. On Wed, Nov 4, 2015 at 2:18 PM, Carlos Santana wrote: > LGTM left a question. > > On Tue, Nov 3, 2015 at 6:36 PM Shazron wrote: > >> Sent a PR https://github.com/apache/cordova-ios/pull/178 please >> review/comment etc >> >> On Thu, Oct 29, 2015 at 7:27 AM, julio cesar sanchez >> wrote: >> > +1, I first saw the bridges when looking into one issue but didn't know >> if >> > the user configures them or if it was something internal that changed on >> > certain circumstances, so if it isn't used, remove it. >> > >> > >> > 2015-10-29 3:35 GMT+01:00 Carlos Santana : >> > >> >> Sorry late to the bridge dead sentence. >> >> >> >> +1 Strongly agree, some of these feel like old hacks that are not need >> it >> >> anymore, and also not public documented so it's OK for removal. >> >> >> >> >> >> >> >> On Tue, Oct 27, 2015 at 9:06 PM Tommy Williams >> wrote: >> >> >> >> > +1 >> >> > >> >> > >> >> > On 28 October 2015 at 11:45:00, Simon MacDonald ( >> >> simon.macdon...@gmail.com) >> >> > wrote: >> >> > >> >> > +1 >> >> > >> >> > Simon Mac Donald >> >> > http://hi.im/simonmacdonald >> >> > >> >> > >> >> > On Tue, Oct 27, 2015 at 8:13 PM, Tim Barham > > >> >> > wrote: >> >> > > +1 >> >> > > >> >> > > -Original Message- >> >> > > From: Steven Gill [mailto:stevengil...@gmail.com] >> >> > > Sent: Tuesday, October 27, 2015 5:11 PM >> >> > > To: dev@cordova.apache.org >> >> > > Subject: Re: [DISCUSS] Removal of unused iOS bridges >> >> > > >> >> > > +1 >> >> > > >> >> > > On Tue, Oct 27, 2015 at 5:05 PM, Shazron wrote: >> >> > > >> >> > >> Filed >> >> > >> >> >> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue >> >> > >> s.apache.org >> >> %2fjira%2fbrowse%2fCB-9883&data=01%7c01%7cTBARHAM%40064d.m >> >> > >> gd.microsoft.com >> >> %7cfcf3db870c2d4d8b63ac08d2df2c6078%7c72f988bf86f141af >> >> > >> >> 91ab2d7cd011db47%7c1&sdata=GRbmnhveNymzREsn6T4SzKSTSSBtcqijfXhFAEMejNA >> >> > >> %3d >> >> > >> >> >> > >> On Tue, Oct 27, 2015 at 5:00 PM, Shazron >> wrote: >> >> > >> > ## DESCRIPTION >> >> > >> > >> >> > >> > We have 7 bridges in iOS: >> >> > >> > >> >> > >> >> >> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu >> >> > >> b.com >> >> %2fapache%2fcordova-ios%2fblob%2fc0fe92d6c0b91efa2da0d5cec78e0baa >> >> > >> >> 95ce55c9%2fcordova-js-src%2fexec.js%23L36-L43&data=01%7c01%7cTBARHAM%4 >> >> > >> 0064d.mgd.microsoft.com >> >> %7cfcf3db870c2d4d8b63ac08d2df2c6078%7c72f988bf8 >> >> > >> >> 6f141af91ab2d7cd011db47%7c1&sdata=MTwKRVfHlU4fHHI7c8Pa9vEqYELxmJudMWkl >> >> > >> ILrvqAc%3d >> >> > >> > >> >> > >> > IFRAME_NAV is the default, and is actively used. >> >> > >> > WK_WEBVIEW_BINDING will be used by the wkwebview-engine plugin, >> >> > >> > although I really want the plugin itself to inject this, haven't >> >> > >> > explored that yet. >> >> > >> > >> >> > >> > ## PROPOSAL >> >> > >> > >> >> > >> > Remove these bridges: >> >> > >> > >> >> > >> >> >> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu >> >> > >> b.com >> >> %2fapache%2fcordova-ios%2fblob%2fc0fe92d6c0b91efa2da0d5cec78e0baa >> >> > >> >> 95ce55c9%2fcordova-js-src%2fexec.js%23L38-L42&data=01%7c01%7cTBARHAM%4 >> >> > >> 0064d.mgd.microsoft.com >> >> %7cfcf3db870c2d4d8b63ac08d2df2c6078%7c72f988bf8 >> >> > >> >> 6f141af91ab2d7cd011db47%7c1&sdata=M70lyqlz4itP87I1XA%2bSwDpcCu7cfsI%2f >> >> > >> DzjBf63QcAo%3d >> >> > >> > >> >> > >> > XHR_NO_PAYLOAD >> >> > >> > XHR_WITH_PAYLOAD >> >> > >> > XHR_OPTIONAL_PAYLOAD >> >> > >> > IFRAME_HASH_NO_PAYLOAD >> >> > >> > IFRAME_HASH_WITH_PAYLOAD >> >> > >> > >> >> > >> > ... and their associated native code. >> >> > >> >> >> > >> >> - >> >> > >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> >> > >> For additional commands, e-mail: dev-h...@cordova.apache.org >> >> > >> >> >> > >> >> >> > > >> >> > > >> - >> >> > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> >> > > For additional commands, e-mail: dev-h...@cordova.apache.org >> >> > >> >> > - >> >> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> >> > For additional commands, e-mail: dev-h...@cordova.apache.org >> >> > >> >> > >> >> >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >> For additional commands, e-mail: dev-h...@cordova.apache.org >> >> - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support
Github user shazron commented on the pull request: https://github.com/apache/cordova-lib/pull/219#issuecomment-154149943 Thanks. An update on this. I still want to get this in, but I will have to postpone it unless someone else wants to take this up right now. With the merge/rebase etc this is more complex than it seems to review, to make sure this does not affect anything else. This is not your fault -- I wish we had more resources to work on pull requests in a timely manner, but unfortunately we do not and we will have to just carry on as best we can. The newest tools release is coming as we speak so I will aim to get it reviewed and out for the next tools release (currently I'm working on getting cordova-ios 4.0 out). We really value your contribution and I apologize that it has taken months and months to take a look at this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Browser - Camera on top of all...
GitHub user aliokan opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/134
Browser - Camera on top of all!
add CSS style {position: 'relative', z-index: 9} on DOM appended element
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aliokan/cordova-plugin-camera aliokan-patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/134.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #134
commit b2069b67210b68ce39a70e00d0e2513deb6b376c
Author: Laurent Deketelaere
Date: 2015-11-05T18:04:34Z
Browser - Camera on top of all!
add CSS style {position: 'relative', z-index: 9} on DOM appended element
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request: CB-9962 Fixed CI builds
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-coho/pull/103#issuecomment-154065880 lgtm :ship: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-coho pull request: CB-9962 Fixed CI builds
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-coho/pull/103 CB-9962 Fixed CI builds https://issues.apache.org/jira/browse/CB-9962 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-coho CB-9962 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-coho/pull/103.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #103 commit 44b7b3d9f989dca8be771638487115375e428348 Author: Alexander Sorokin Date: 2015-11-05T13:38:17Z CB-9962 Fixed CI builds --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [VOTE] Tools Release (attempt 3)
I vote +1. * Verified tags * Ability to install/uninstall Cordova * Ability to update Cordova * Ability to create blank app for Windows, WP8, Android * Ability to build/run apps * Reviewed release notes * Verified versions * Verified line breaks * Verified 'cordova serve' * Verified that browserified app builds and runs correctly -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, November 5, 2015 12:14 AM To: dev@cordova.apache.org Subject: [VOTE] Tools Release (attempt 3) Please review and vote on this Tools Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-9903&data=01%7c01%7cv-alsoro%40microsoft.com%7c2896234d7f1e4ec5e8bc08d2e55cfb97%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=4sUp2hjJV7Tc47wBBfO0TZKfWIgLY5pH3RVN8W1lWBM%3d Tools have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9903/ The packages were published from their corresponding git tags: cordova-js: 4.1.2 (90546bd136) cordova-lib: 5.4.0 (f977a71539) cordova-plugman: 1.0.5 (3449d5b251) cordova-cli: 5.4.0 (81716f6599) Upon a successful vote I will upload the archives to dist/, publish them to npm, and post the corresponding blog post. Voting guidelines: https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fapache%2fcordova-coho%2fblob%2fmaster%2fdocs%2frelease-voting.md&data=01%7c01%7cv-alsoro%40microsoft.com%7c2896234d7f1e4ec5e8bc08d2e55cfb97%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=NxhEbqqhiuJlpTwTuQlUbowcqe65lbJWFsPfpWWYJVc%3d Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Created and ran mobilespec on android
[GitHub] cordova-docs pull request: Set proper name in iOS config documenta...
GitHub user asc0de opened a pull request: https://github.com/apache/cordova-docs/pull/414 Set proper name in iOS config documentation Correct property name in example is wrong You can merge this pull request into a Git repository by running: $ git pull https://github.com/asc0de/cordova-docs patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/414.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #414 commit d792965c0bec4d995aee3f5168a7e5c8b2061f78 Author: Vladislav Dekhanov Date: 2015-11-05T11:44:45Z Update config.md --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-firefoxos pull request: CB-9836 Add .gitattributes to prev...
GitHub user daserge opened a pull request: https://github.com/apache/cordova-firefoxos/pull/25 CB-9836 Add .gitattributes to prevent CRLF line endings in repos [Jira issue](https://issues.apache.org/jira/browse/CB-9836) You can merge this pull request into a Git repository by running: $ git pull https://github.com/daserge/cordova-firefoxos CB-9836 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-firefoxos/pull/25.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #25 commit 9a73682225843f2e47fdc9ec43cc92736f24419c Author: daserge Date: 2015-11-05T10:51:29Z CB-9836 Add .gitattributes to prevent CRLF line endings in repos --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [DISCUSS] Cordova-Windows Release
I've tested mobilespec build artefacts (uap, win81) using Windows App Cert Kit and all tests pass. I see that we've just merged back button fix for WP8.1 so I plan to test and merge related fix[1] for Windows10 to have full back button support and proceed w/ release. [1] https://github.com/apache/cordova-windows/pull/120 -Sergey -Original Message- From: Carlos Santana [mailto:csantan...@gmail.com] Sent: Thursday, November 5, 2015 1:15 AM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Cordova-Windows Release +1 and do minor release since it include more than bug fixes. On Tue, Nov 3, 2015 at 12:10 PM Jesse wrote: > +1 > Sounds good. I want to test some of the recent line-ending > gitattribute changes with AppStore submission, so a release would be the > perfect test. > > > On Nov 2, 2015, at 11:18 PM, Sergey Grebnov (Akvelon) < > v-seg...@microsoft.com> wrote: > > > > If we agree to do a release: > > > > Most of the changes in master are bugfixes, but there is new Visual > Studio 14 template (version update), Cumulative build and hosted > environments support so I propose to do minor release (4.2.0) instead > of patch (4.1.1). Thoughts? > > > > Thx! > > Sergey > > -Original Message- > > From: Sergey Grebnov (Akvelon) > > Sent: Tuesday, November 3, 2015 10:10 AM > > To: dev@cordova.apache.org > > Subject: [DISCUSS] Cordova-Windows Release > > > > Hi guys, last Windows release was in August and there are important > changes landed to repo master from that time including: > > * Better Windows 10 in hosted environment support > > * Create/prepare fixes for non-Windows env (Linux/OSX) > > * Cumulative build support (windows10 and windows 8.1) > > * Fixes for general build failures > > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgit > > hub.com%2fapache%2fcordova-windows%2fcompare%2f4.1.x...master&data=0 > > 1%7c01%7cv-segreb%40microsoft.com%7c6d60e65c973f45758f2808d2e56574d8 > > %7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=q5Xg3gy10YuO6pqgrhL%2b > > kstxzou35oWmuctQd%2bATgNY%3d > > > > Does anyone have any reason to delay a cordova-windows platform release? > > Any outstanding patches to land? > > > > If not, I will start the release tomorrow. > > > > Thx! > > Sergey > > > > > > > > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > > For additional commands, e-mail: dev-h...@cordova.apache.org > > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: Add support for back button on win10
Github user EionRobb commented on the pull request: https://github.com/apache/cordova-windows/pull/120#issuecomment-154017263 To clarify, the method defines itself as existing, but any attempts to use it will crash the container. There isn't a Jira issue for it, that would be unnecessary duplication. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: Add support for back button on win10
Github user EionRobb commented on the pull request: https://github.com/apache/cordova-windows/pull/120#issuecomment-154016649 Feature detection is broken. It causes the ieframe.dll to crash outside of js and is uncatchable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: Add support for back button on win10
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/120#issuecomment-154014598 I plan to test and merge it. @EionRobb is there associated Jira issue available? Also, is there a special reason we use user agent instead of feature detection (`Windows.UI.Core.SystemNavigationManager.getForCurrentView`)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9836 Add .gitattributes to preven...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/126 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9836 Add .gitattributes to preven...
Github user daserge commented on the pull request: https://github.com/apache/cordova-windows/pull/126#issuecomment-153990376 Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9836 Add .gitattributes to preven...
Github user daserge commented on the pull request: https://github.com/apache/cordova-windows/pull/126#issuecomment-153986893 Will rebase and update it with [common web project template now](https://github.com/apache/cordova-ios/commit/7682bfeecc7a7adaa866ee2b946dcbe3a2696922). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-9836 Add .gitattributes to preven...
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/126#issuecomment-153984003 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
