[GitHub] cordova-lib pull request: add missing package_suffix function on a...

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-lib/pull/343#issuecomment-156878470
  
I think the reason why that function is needed is because of this: 
https://github.com/apache/cordova-lib/blob/cc1ab409f64e16a06b5b495dd7b5bdfac37acda7/cordova-lib/src/plugman/platforms/android.js#L40



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: add missing package_suffix function on a...

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-lib/pull/343#issuecomment-156878477
  
LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-9964 Make --copy-from use --template ...

[dubeejw]

GitHub user dubeejw opened a pull request:

https://github.com/apache/cordova-cli/pull/227

CB-9964 Make --copy-from use --template behavior

- Arguments are now handled for the --template parameter
- --copy-from now uses the same behavior as --template


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dubeejw/cordova-cli master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/227.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #227


commit a885c55118b7637cb483da5b6d32ef85d4949a18
Author: dubeejw 
Date:   2015-11-05T20:55:14Z

CB-9964 Added --template support to Cordova Create

- Templates can now be added to a project from GitHub, and NPM

commit 2b0c16d35077126397d0d9e9f3814bfb3b499f51
Author: dubeejw 
Date:   2015-11-05T21:01:16Z

Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/cordova-cli

commit 0f6fa3808297122013085adb56b363031a9e9bf2
Author: dubeejw 
Date:   2015-11-16T03:25:37Z

CB-9964 Add --template to help, and remove --copy-from

- --template has been add to the help file
- --copy-from has been removed from the help file

commit 5a25f7f3a6a9434664ce9359ce6660b0633c2853
Author: dubeejw 
Date:   2015-11-16T03:37:31Z

CB-9964 Deprecate --copy-from

- Deprecated --copy-from in 'create help'




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: Cb 9964

[dubeejw]

Github user dubeejw commented on the pull request:

https://github.com/apache/cordova-lib/pull/339#issuecomment-156909488
  
New unrelated tests failing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: Cb 9964

[dubeejw]

GitHub user dubeejw reopened a pull request:

https://github.com/apache/cordova-lib/pull/339

Cb 9964


When providing a --template argument during project creation, users can use 
templates apps from a local directory, GitHub, or NPM. This makes sharing 
templates, and example apps much easier.

When using a GitHub URL, the user may specific a branch to pull from by 
appending a "#" followed by a tag name to the Git URL.

A version can also be supplied by the user when fetching a template from 
NPM. This may be done by appending a "@" followed by the NPM version to the NPM 
package name. 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dubeejw/cordova-lib CB-9964

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/339.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #339


commit 6e3b89740aea7717871ad229d3f0e98c41fc3665
Author: dubeejw 
Date:   2015-11-05T21:05:06Z

CB-9964 Added --template to Cordova Create

- Templates can now be used from GitHub, and NPM

commit 3694d0f6ffbd1234bf61f0d9e8750297f0387fb0
Author: dubeejw 
Date:   2015-11-05T21:06:15Z

CB-9964 Added --template to Cordova Create

- Templates can now be used from GitHub, and NPM

commit b46ccc8e5398d65f867abf8f29610d093b78aace
Author: dubeejw 
Date:   2015-11-05T21:07:30Z

CB-9964 Added --template to Cordova Create

- Automation for new --template arguments

commit 09a8513e7cc432cf327ae9d0c62d2d0be56fb6c0
Author: dubeejw 
Date:   2015-11-05T21:58:24Z

CB-9964 Fix test for --template argument

- Ensure temp projects are deleted after use

commit 60fc21679cdf9f9f09e0e45d9547594dd6ed8000
Author: dubeejw 
Date:   2015-11-12T04:29:57Z

CB-9964 Fix tests

- Fix failing tests

commit 9f7c4dd993268cf8124e727f5e48c03429ab5bbf
Author: dubeejw 
Date:   2015-11-16T03:21:16Z

CB-9964 Copy platforms, and plugins directories

- --template will now copy platforms, and plugins directories from
templates




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: Cb 9964

[dubeejw]

Github user dubeejw closed the pull request at:

https://github.com/apache/cordova-lib/pull/339


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] cordova-wp8 patch release 3.8.2

[Mefire O .]

+1
> On Nov 14, 2015, at 3:56 PM, Brett Rudd  wrote:
> 
> +1 
> 
>> On Nov 14, 2015, at 4:45 AM, Sergey Grebnov (Akvelon) 
>>  wrote:
>> 
>> +1
>> 
>> -Original Message-
>> From: Steven Gill [mailto:stevengil...@gmail.com] 
>> Sent: Saturday, November 14, 2015 4:35 AM
>> To: dev@cordova.apache.org
>> Subject: Re: [DISCUSS] cordova-wp8 patch release 3.8.2
>> 
>> +1
>> 
>> On Fri, Nov 13, 2015 at 5:23 PM, Parashuram N 
>> wrote:
>> 
>>> +1.
>>> 
>>> 
>>> 
>>> 
>>> On 11/13/15, 5:19 PM, "Jesse"  wrote:
>>> 
 I have pushed 2 cherry-picked commits to the 3.8.x [1] branch of
>>> cordova-wp8
 wp8 is currently not available as a platform to cordova platform add wp8
>>> on
 some unix based machines because to case-sensitivity issues with the use
>>> of
 the 'Q' module instead of the 'q' module
 
 This should be a quick and easy vote, I would like to push it out asap.
 
 Cheers,
 Jesse
 
 
 [1] https://github.com/apache/cordova-wp8/commits/3.8.x
 
 @purplecabbage
 
>>> https://na01.safelinks.protection.outlook.com/?url=risingj.com=01%7c01%7cpanarasi%40microsoft.com%7c24a948263cff4010257708d2ec91b97f%7c72f988bf86f141af91ab2d7cd011db47%7c1=vSN%2fb5N90Ao5EOFNgqvcJi3aeyuZhrG0xZ0x%2fJtLFeg%3d
>>> 
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org