[GitHub] cordova-plugin-contacts pull request: CB-8156 Call error callback ...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/84#issuecomment-159188305
  
Updated. Thanks for reviewing, @purplecabbage


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-8156 Call error callback ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-contacts/pull/84


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-7906 Prevent app crash wh...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-contacts/pull/85


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Plugins release

[Steven Gill]

Please review the blog post for the plugins release

https://github.com/apache/cordova-docs/pull/431

On Fri, Nov 20, 2015 at 12:43 PM, Steven Gill 
wrote:

> Manually update until we released tools with android 5 pinned.
>
> The failure is expected. Users will have to manually update to android 5
> or use an older version of file.
>
> This was discussed before.
>
> Steps:
> * android 5 release
> * plugins release
> * tools release
> On Nov 20, 2015 8:26 AM, "Alexander Sorokin (Akvelon)" <
> v-als...@microsoft.com> wrote:
>
>> Hi guys,
>>
>> Currently we have Android ~4.1.0 pinned in CLI but the file plugin (and
>> all plugins that depend on file plugin) depends on Android@5.0.0 or
>> higher, so after this release, this will fail:
>>
>> cordova platform add android
>> cordova plugin add cordova-plugin-file
>>
>> The output would be:
>> Installing "cordova-plugin-file" for android
>> Plugin doesn't support this project's cordova-android version.
>> cordova-android: 4.1.1, failed version requirement: >=5.0.0-dev
>> Skipping 'cordova-plugin-file' for android
>>
>> So, should Android@5.0.0 be pinned first or are we expecting users to
>> manually update android to 5.0.0 ?
>>
>> Thanks,
>> Alexander Sorokin
>>
>> -Original Message-
>> From: Steven Gill [mailto:stevengil...@gmail.com]
>> Sent: Friday, November 20, 2015 2:04 AM
>> To: dev@cordova.apache.org
>> Subject: Re: [DISCUSS] Plugins release
>>
>> Thanks Joe!
>>
>> P.S. The "r" prefixed tags messed up my coho commands to create the tgz
>> and print the corresponding tags. I have now fixed that problem by not
>> stripping the "r" for plugin tags so those tags fail the semver check.
>>
>> Attempt 2 for plugins vote is now out.
>>
>>
>> On Thu, Nov 19, 2015 at 11:03 AM, Joe Bowser  wrote:
>>
>> > I just did the test again on this end, and the only test failures I
>> > got were the ones where I was expected to approve permissions.  It
>> > seems that these tests will keep running and that the permission
>> > dialog won't block the UI.  This is the correct behaviour, but it does
>> > mean that we have to make sure that we give the permissions for the
>> > tests to work before we run them.
>> >
>> > After I approved all the permissions, I just get three Contacts
>> > failures and a Media plugin failure.  One of the Contacts failures
>> > comes from running on a device that I use day-to-day, since I don't
>> > get that one on the HTC One M8, but the other three errors are
>> consistent.
>> >
>> > Furthermore, the manual tests for Media work fine, so I don't think
>> > that this should block the release.
>> >
>> > On Wed, Nov 18, 2015 at 11:24 PM, Steven Gill 
>> > wrote:
>> >
>> > > Oh and 1 failing cordova-plugin-file-transfer test.
>> > >
>> > > I'll look more into the failures tomorrow.
>> > >
>> > >
>> > > On Wed, Nov 18, 2015 at 11:12 PM, Steven Gill
>> > > 
>> > > wrote:
>> > >
>> > > > all the plugins have been updated and are ready to be voted on.
>> > > >
>> > > > I am getting 10 failing tests on my nexus 5X
>> > > > (cordova-android@5.0.0, running marshmallow on phone).
>> > > > * contacts (always failing for me)
>> > > > * media
>> > > >
>> > > > Can someone else try running mobile spec and tell me what they are
>> > > seeing?
>> > > >
>> > > > I can start the vote thread once these are resolved or we decide
>> > > > they
>> > are
>> > > > expected. Everything has been tagged but I can easily update tags
>> > > > if
>> > > needed.
>> > > >
>> > > >
>> > > >
>> > > > On Tue, Nov 10, 2015 at 11:50 PM, julio cesar sanchez <
>> > > > jcesarmob...@gmail.com> wrote:
>> > > >
>> > > >> Any more iOS experts can review my pull request?
>> > > >>
>> > > >> 2015-11-11 6:59 GMT+01:00 Steven Gill :
>> > > >>
>> > > >> > Going to move forward with this tomorrow. Any holdups, let me
>> know.
>> > > >> Here or
>> > > >> > #plugins on slack.
>> > > >> >
>> > > >> > On Fri, Nov 6, 2015 at 2:51 PM, Richard Knoll <
>> > rikn...@microsoft.com>
>> > > >> > wrote:
>> > > >> >
>> > > >> > > I plan on merging in
>> > > >> > > https://github.com/apache/cordova-plugin-camera/pull/135 for
>> > > >> > > the
>> > > >> camera
>> > > >> > > plugin if there are no objections.
>> > > >> > >
>> > > >> > > Thanks,
>> > > >> > > Richard
>> > > >> > >
>> > > >> > > -Original Message-
>> > > >> > > From: Steven Gill [mailto:stevengil...@gmail.com]
>> > > >> > > Sent: Friday, November 6, 2015 11:38 AM
>> > > >> > > To: dev@cordova.apache.org
>> > > >> > > Subject: Re: [DISCUSS] Plugins release
>> > > >> > >
>> > > >> > > With plugin changes, it is always nice to get reviews since
>> > > >> > > it
>> > could
>> > > >> > > affect every platform.
>> > > >> > >
>> > > >> > > file:146 is merged
>> > > >> > > file: 119 LGTM
>> > > >> > > Statusbar: 38 could use a review by iOS experts
>> > > >> > >
>> > > >> > > Keep em coming in!
>> > > >> > >
>> > > >> > > -Steve
>> > > >> > >
>> > > >> > > On Fri, Nov 6, 2015 at 5:53 AM, Simon MacDonald <
>> > > >> > simon.macdon...@gmail.com
>> 

[GitHub] cordova-docs pull request: draft of plugins release blog post

[stevengill]

GitHub user stevengill opened a pull request:

https://github.com/apache/cordova-docs/pull/431

draft of plugins release blog post



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stevengill/cordova-docs pluginblog

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/431.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #431


commit 079dd8091a914e4dc1ae64c1acc4734d4ec84bc7
Author: Steve Gill 
Date:   2015-11-24T07:28:13Z

draft of plugins release blog post




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...

[ghenry22]

Github user ghenry22 commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-159179817
  
Ok this discussion isn't really relevant to this PR at all but more related 
to quirks of the file plugin that is used by the media plugin but let me try 
and help you out a bit:

https://github.com/apache/cordova-plugin-file

Read the info about file paths here and how to access persistent storage, 
cache storage etc.

Importantly look at the file paths for android, windows and ios and which 
cordova.file.* value they map to.  If you use cordova.file.dataDirectory for 
example it will work to map to persistent storage across all 3 platforms in a 
consistent way.  If you use file://somedir/someotherdir/etc then it won't work.

If you use file:// you will find that it also doesn't work on windows 
platform as it's native paths us ms-appdata:// prefixes.  Android works because 
it uses file:// paths for local files natively (the path mappings in the file 
plugin readme even show this).

So here's an example that might help you out from my code:

//define a variable to store the resolved path where files will be stored
  var basePath = false;

//get the path to the file to be used for later playback from file system
var musicDirectory = cordova.file.dataDirectory + 'musicCache/';

//resolve the path to a usable internalURL for the current platform
$window.resolveLocalFileSystemURL(musicDirectory, function(dir){
if (!basePath) {
 basePath = dir.toInternalURL();
};
})


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Fixing some styling issues and simplify...

[purplecabbage]

Github user purplecabbage commented on the pull request:

https://github.com/apache/cordova-docs/pull/430#issuecomment-159179389
  
Hint: all repos are listed here, my fave bookmark. 

https://git-wip-us.apache.org/repos/asf?a=project_list&s=cordova-&btnS=Search

When you follow a github link, the first thing you see is a nicely 
formatted readme which is a great introduction. 

I think we should put the slack link *everywhere*, including the top of 
every github repo readme.md


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...

[snstarosciak]

Github user snstarosciak commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-159167419
  
@ghenry22 @dduwab - Hey guys, I'm glad to see I'm not the only one running 
into this issue. I, too, have run into an issue where I can't seem to play an 
mp3 file from my local device after it's been downloaded using the ngCordova 
File Transfer plugin for ionic. I'm using xCode 7.1 and iOS 9 and this is 
happening on both the emulator and my iPhone 6s plus. 

One thing I should note is that it works flawlessly on an android device, 
but for some reason iOS 9 doesn't want to play the audio. I can play the audio 
from an http:// address or from a directory inside www, but when it has file:// 
in front of it, it doesn't play, it doesn't give me an error, in fact, I've 
made a stackoverflow and ionic forum for this issue. I'm all out of options on 
this and I don't know what to do :/

Here is the post: 
http://stackoverflow.com/questions/33837326/ios-9-can-t-play-audio-video-files-that-are-downloaded-to-device

I should also note that I can't seem to play mp4 files in a  tag, 
when the source of the file is from my local device. This is actually separate 
from the media-plugin, but maybe there's some insight to be had from this 
problem as well. File Plugin? File Transfer plugin? I'm not sure. 

Thanks in advance :D


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Fixing some styling issues and simplify...

[stevengill]

Github user stevengill commented on the pull request:

https://github.com/apache/cordova-docs/pull/430#issuecomment-159164612
  
+1 to changing non committers to contributors. That is how apache 
classifies the difference.

I am fine leaving the apache git urls. Most people will click github icon 
anyways.

How do you feel about adding a join us on slack on that page?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Fixing some styling issues and simplify...

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/430#issuecomment-159154220
  
To be honest, it's been helpful even for me to get the ASF Git links by 
going to that page. I'd personally prefer to keep them there, but I don't feel 
too strongly about it. Unless you or others feel strongly about removing them, 
I'd suggest just keeping them there. As for the link, how about "Committers / 
Other Contributors"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Fixing some styling issues and simplify...

[purplecabbage]

Github user purplecabbage commented on the pull request:

https://github.com/apache/cordova-docs/pull/430#issuecomment-159143724
  
nit: Can we also change the 'non-committers' to 'contributors' or 
something, so they still sound like they have commitment?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Fixing some styling issues and simplify...

[purplecabbage]

Github user purplecabbage commented on the pull request:

https://github.com/apache/cordova-docs/pull/430#issuecomment-159143495
  
Looks great!
I think we should also drop the Apache-Git links completely.  All bug 
fixes, and pull requests can be handled completely without ever knowing that we 
are using github mirrors ... and I suspect it might confuse newcomers when they 
are dumped unmercifully into an apache-git page.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[DISCUSS] "Contribute" Page Changes

[Dmitry Blotsky]

Hey folks,

Please review the changes to the Contribute page on the website: 
http://cordova.apache.org/contribute/. They are in this PR, and are not yet in 
master: https://github.com/apache/cordova-docs/pull/430.

Kindly,
Dmitry

[GitHub] cordova-ios pull request: CB-9827 Implement and expose PlatformApi...

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-ios/pull/176#issuecomment-159130245
  
what about the ```cli``` option? It also needs to be sent forward.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Cordova CLI & LIB 5.4.1 Release

[Mefire O .]

+1

Thanks,
Omar Mefire

> On Nov 23, 2015, at 5:16 PM, Steven Gill  wrote:
> 
> Need one more vote for tools release
> 
> On Fri, Nov 20, 2015 at 8:21 AM, David Barth 
> wrote:
> 
>> On Fri, Nov 20, 2015 at 2:31 AM, Steven Gill 
>> wrote:
>> 
>>> [...]
>>> @David, I can review those changes. Can you send it as PRs and send me
>> the
>>> links. They can go out in the next tools release (soon)!
>>> 
>> 
>> Sure,
>> 
>> Pull-requests, re-opened here:
>> https://github.com/apache/cordova-lib/pull/294
>> 
>> and here: https://github.com/apache/cordova-lib/pull/299
>> 
>> David
>> 


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Cordova CLI & LIB 5.4.1 Release

[Steven Gill]

Need one more vote for tools release

On Fri, Nov 20, 2015 at 8:21 AM, David Barth 
wrote:

> On Fri, Nov 20, 2015 at 2:31 AM, Steven Gill 
> wrote:
>
> > [...]
> > @David, I can review those changes. Can you send it as PRs and send me
> the
> > links. They can go out in the next tools release (soon)!
> >
>
> Sure,
>
> Pull-requests, re-opened here:
> https://github.com/apache/cordova-lib/pull/294
> 
> and here: https://github.com/apache/cordova-lib/pull/299
>
> David
>

Pinning Plugins and versioning proposal

[Steven Gill]

Please provide feedback on the PR!

https://github.com/cordova/cordova-discuss/pull/29

[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...

[ghenry22]

Github user ghenry22 commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-159119183
  
@dduwab - this PR does not require any changes to the client at all, it all 
works exactly the same with all the same functions implemented in the same way. 
 You can swap back and forth easily between this PR and the released plugin.

I would suggest checking your file paths as per the file plugin 
documentation (media plugin uses the file plugin to access local files).  You 
don't want to use a full path like you have defined, you really want to use one 
of the cordova.file.* aliases to get the correct path to the file consistently. 
 Either way though you want to have file:// or cdvfile:// at the start of your 
path to the file as the plugin uses the prefix to determine whether the file is 
local or remote (this is the same in the master code as in this PR).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-9827 Implement and expose PlatformApi...

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-ios/pull/176#issuecomment-159113086
  
Instead of relying on 'nopt' default value for its constructor, why don't 
we explicitly use: 'process.args' here ?
Something like:

``` 
var argv = require('nopt') ({
'help' : Boolean,
'cli' : Boolean,
'shared': Boolean,
'link' : Boolean
}, process.argv)```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: CB-9563 Mulptipart form...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/117

CB-9563 Mulptipart form data is used even a header named Content-Type…

… is present

Adds non-multipart implementation for Windows and a corresponding test
Adds a fix for Android for uploadResult.bytesSent = 0 for small files

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-file-transfer 
CB-9563

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file-transfer/pull/117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #117


commit 5a2f1740dcdfd41ee16b4164ef313c4cc25a64b1
Author: daserge 
Date:   2015-11-23T22:20:00Z

CB-9563 Mulptipart form data is used even a header named Content-Type is 
present

Adds non-multipart implementation for Windows and a corresponding test
Adds a fix for Android for uploadResult.bytesSent = 0 for small files




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...

[dduwab]

Github user dduwab commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-159031772
  
@ghenry22 - no success yet, but it may be my problem since I'm still new to 
it.
But I'm wondering, shouldn't your changes not require client changes to be 
compatible with the main branch? Thanks.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-7906 Prevent app crash wh...

[purplecabbage]

Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/85#issuecomment-159017662
  
lgtm


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-8156 Call error callback ...

[purplecabbage]

Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/84#issuecomment-159017060
  
One more thing ...
Please add a test for the new constant to 
`contacts.spec.25 ContactError constants should be defined` at 
/tests/tests.js#L473


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-8156 Call error callback ...

[purplecabbage]

Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/84#issuecomment-159016399
  
Looks good, except for the java implementation (re)used error code 5 
instead of the 6 used everywhere else. The added tests should reveal this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-8156 Call error callback ...

[purplecabbage]

Github user purplecabbage commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/84#discussion_r45637931
  
--- Diff: src/windows/ContactProxy.js ---
@@ -242,7 +242,9 @@ module.exports = {
 pickRequest.done(function (contact) {
 // if contact was not picked
 if (!contact) {
-fail && fail(new Error("User did not pick a contact."));
--- End diff --

This looks good.  The implied check for `fail != null` here was unnecessary 
as ALL calls to exec proxies have valid success/error function passed in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-8156 Call error callback ...

[purplecabbage]

Github user purplecabbage commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/84#discussion_r45637648
  
--- Diff: src/android/ContactManager.java ---
@@ -52,6 +52,7 @@ Licensed to the Apache Software Foundation (ASF) under one
 public static final int PENDING_OPERATION_ERROR = 3;
 public static final int IO_ERROR = 4;
 public static final int NOT_SUPPORTED_ERROR = 5;
+public static final int OPERATION_CANCELLED_ERROR = 5;
--- End diff --

Isn't this supposed to be 6 as above, so below?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [VOTE] Plugins Release! (attempt 2)

[Joe Bowser]

+1
On Nov 23, 2015 7:19 AM, "Alexander Sorokin (Akvelon)" <
v-als...@microsoft.com> wrote:

> I vote +1.
>
> * Verified signatures and hashes
> * Verified tags
> * Verified that plugins can be added correctly to blank app
> * Verified that blank app can be successfully built and ran
> * Ran smoke testing of mobilespec app
>
> -Original Message-
> From: Steven Gill [mailto:stevengil...@gmail.com]
> Sent: Friday, November 20, 2015 2:02 AM
> To: dev@cordova.apache.org
> Subject: [VOTE] Plugins Release! (attempt 2)
>
> Please review and vote on the release of this plugins release by replying
> to this email (and keep discussion on the DISCUSS thread)
>
> Release issue:
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10035&data=01%7c01%7cv-alsoro%40microsoft.com%7cc528c07313f84f8a1f9308d2f1359214%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=4i0JwOJbWV13CYlG6wAK%2bDvo6NSlDGkrsk1kK1vb%2bRg%3d
>
> The plugins have been published to
> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10035/
>
> The packages were published from their corresponding git tags:
> cordova-plugin-battery-status: 1.1.1 (946f15f5be)
> cordova-plugin-camera: 2.0.0 (b3376e2389)
> cordova-plugin-console: 1.0.2 (5800c5c5dc)
> cordova-plugin-contacts: 2.0.0 (f282464d1d)
> cordova-plugin-device: 1.1.0 (aa6a1d3be6)
> cordova-plugin-device-motion: 1.2.0 (e0ca894347)
> cordova-plugin-device-orientation: 1.0.2 (5c9ca663e2)
> cordova-plugin-dialogs: 1.2.0 (c36d1c040d)
> cordova-plugin-file: 4.0.0 (0b9d826416)
> cordova-plugin-file-transfer: 1.4.0 (97031b2d75)
> cordova-plugin-geolocation: 2.0.0 (57eb4dc550)
> cordova-plugin-globalization: 1.0.2 (4e6174a299)
> cordova-plugin-inappbrowser: 1.1.0 (1cd9205eb5)
> cordova-plugin-legacy-whitelist: 1.1.1 (84f4e1242b)
> cordova-plugin-media: 2.0.0 (229ba599b7)
> cordova-plugin-media-capture: 1.1.0 (e1bc40b83f)
> cordova-plugin-network-information: 1.1.0 (f6d2782780)
> cordova-plugin-splashscreen: 3.0.0 (e2239306d6)
> cordova-plugin-statusbar: 2.0.0 (7c27000b3a)
> cordova-plugin-test-framework: 1.1.0 (3ad9964967)
> cordova-plugin-vibration: 2.0.0 (db5313a019)
> cordova-plugin-whitelist: 1.2.0 (9792fc5365)
>
> Upon a successful vote I will upload the archives to dist/, upload them to
> npm and post the corresponding blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and subdependencies
> have Apache-compatible licenses
> * Ran mobilespec on android and ios
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>

RE: [VOTE] Plugins Release! (attempt 2)

[Alexander Sorokin (Akvelon)]

I vote +1.

* Verified signatures and hashes
* Verified tags
* Verified that plugins can be added correctly to blank app
* Verified that blank app can be successfully built and ran
* Ran smoke testing of mobilespec app

-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com] 
Sent: Friday, November 20, 2015 2:02 AM
To: dev@cordova.apache.org
Subject: [VOTE] Plugins Release! (attempt 2)

Please review and vote on the release of this plugins release by replying to 
this email (and keep discussion on the DISCUSS thread)

Release issue: 
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10035&data=01%7c01%7cv-alsoro%40microsoft.com%7cc528c07313f84f8a1f9308d2f1359214%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=4i0JwOJbWV13CYlG6wAK%2bDvo6NSlDGkrsk1kK1vb%2bRg%3d

The plugins have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10035/

The packages were published from their corresponding git tags:
cordova-plugin-battery-status: 1.1.1 (946f15f5be)
cordova-plugin-camera: 2.0.0 (b3376e2389)
cordova-plugin-console: 1.0.2 (5800c5c5dc)
cordova-plugin-contacts: 2.0.0 (f282464d1d)
cordova-plugin-device: 1.1.0 (aa6a1d3be6)
cordova-plugin-device-motion: 1.2.0 (e0ca894347)
cordova-plugin-device-orientation: 1.0.2 (5c9ca663e2)
cordova-plugin-dialogs: 1.2.0 (c36d1c040d)
cordova-plugin-file: 4.0.0 (0b9d826416)
cordova-plugin-file-transfer: 1.4.0 (97031b2d75)
cordova-plugin-geolocation: 2.0.0 (57eb4dc550)
cordova-plugin-globalization: 1.0.2 (4e6174a299)
cordova-plugin-inappbrowser: 1.1.0 (1cd9205eb5)
cordova-plugin-legacy-whitelist: 1.1.1 (84f4e1242b)
cordova-plugin-media: 2.0.0 (229ba599b7)
cordova-plugin-media-capture: 1.1.0 (e1bc40b83f)
cordova-plugin-network-information: 1.1.0 (f6d2782780)
cordova-plugin-splashscreen: 3.0.0 (e2239306d6)
cordova-plugin-statusbar: 2.0.0 (7c27000b3a)
cordova-plugin-test-framework: 1.1.0 (3ad9964967)
cordova-plugin-vibration: 2.0.0 (db5313a019)
cordova-plugin-whitelist: 1.2.0 (9792fc5365)

Upon a successful vote I will upload the archives to dist/, upload them to npm 
and post the corresponding blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies have 
Apache-compatible licenses
* Ran mobilespec on android and ios

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [Vote] Tools Release Cordova 5.4.1

[Alexander Sorokin (Akvelon)]

I vote +1.

* Verified tags
* Ability to install/uninstall Cordova
* Ability to update Cordova
* Ability to create blank app for Windows, WP8, Android
* Ability to build/run apps
* Reviewed release notes
* Verified versions
* Verified line breaks
* Verified 'cordova serve'
* Verified that browserified app builds and runs correctly

-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com] 
Sent: Friday, November 20, 2015 4:27 AM
To: dev@cordova.apache.org
Subject: [Vote] Tools Release Cordova 5.4.1

Please review and vote on this Tools Release by replying to this email (and 
keep discussion on the DISCUSS thread)

Release issue: 
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10049&data=01%7c01%7cv-alsoro%40microsoft.com%7ce81d931a9108419f63f408d2f149bea7%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=4iXT52w3%2b2nkJIdWv20QqWnpaY9SsrdPn8a7MTePAw0%3d

Both tools have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10049/

The packages were published from their corresponding git tags:

cordova-lib: 5.4.1 (720270618c)
cordova-cli: 5.4.1 (e7467123d7)

Upon a successful vote I will upload the archives to dist/, publish them to 
NPM, and post the corresponding blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies have 
Apache-compatible licenses
* Ran npm test
* Upgraded an older cordova project to make sure plugins installed correctly 
when running prepare

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Question about Media Capture

[Raymond Camden]

Thanks Jesse. I'm watching the issue now.

On Mon, Nov 23, 2015 at 1:02 AM, Jesse  wrote:
> https://issues.apache.org/jira/browse/CB-9460
>
> The media-capture was based on a moving target spec, I believe.
> Ultimately though these are features that should be supported, just none of
> the platforms does yet.
>
>
> @purplecabbage
> risingj.com
>
> On Sun, Nov 22, 2015 at 6:36 PM, Raymond Camden 
> wrote:
>
>> Technically this may fall into the "technical support" area and more
>> appropriate for the Google Group, but I figured I'd ask here first in
>> case it was a known issue. Looking at the docs for Media Capture
>> (https://github.com/apache/cordova-plugin-media-capture), the
>> Configuration Data section has this to say:
>>
>> "Not supported by any platform. All configuration data arrays are empty."
>>
>> But there's docs, sample code, etc. So someone wrote a sample for this
>> feature and it doesn't work anywhere? Did it *used* to work someplace?
>>
>> --
>> ===
>> Raymond Camden, Developer Advocate for MobileFirst at IBM
>>
>> Email : raymondcam...@gmail.com
>> Blog : www.raymondcamden.com
>> Twitter: raymondcamden
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>
>>



-- 
===
Raymond Camden, Developer Advocate for MobileFirst at IBM

Email : raymondcam...@gmail.com
Blog : www.raymondcamden.com
Twitter: raymondcamden

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Greek translation added

[Lisa Seacat DeLuca]

A request has been made to add the greek language to our Cordova
translation for docs.  I'm not sure who has been in charge of helping with
the translation of documentation recently but we'll need to add the
language code to the automated scripts to have the translations pulled in
after it gets to 100% translated.

Happy Thanksgiving!



Lisa Seacat DeLuca
Omni-Channel Tech Strategist - IBM Master Inventor
IBM Commerce, ExperienceOne

  

  

  
 Phone: 1-410-332-2128 | Mobile: 1-415-787-4589 
  IBM 
 E-mail: ldel...@us.ibm.com 
  
 personal website: lisaseacat.com   
100 East Pratt St 21-2212 
 Chat:Sametime:  ldel...@us.ibm.com 
 Baltimore, MD 21202-1009 
 Find me on: LinkedIn: http://www.linkedin.com/in/lisaseacat Twitter: 
https://twitter.com/IBMlisa and   United States 
 within IBM on: IBM Connections:
  
 
https://w3-connections.ibm.com/profiles/html/profileView.do?key=2e1afd56-daa9-428e-8f4a-2fa7516940c0
 

  

  

[GitHub] cordova-docs pull request: Added Evothings Studio to Cordova Tools...

[mikaelkindborg]

Github user mikaelkindborg commented on the pull request:

https://github.com/apache/cordova-docs/pull/410#issuecomment-158885351
  
Have you had the time to review this pull request for the Tools section of 
the Cordova home page? Is the format ok?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [oss-security] CVE-2015-5257 - Weak Randomization of BridgeSecret for Apache Cordova Android

[Mark Cox]

Unfortunately Red Hat made a mistake with the kernel issue which was
actually a typo (last two digit transposition).  Mitre have chosen to
keep the CVE for the kernel issue as CVE-2015-5257 because it is more
widely used.

They have allocated CVE-2015-8320 for the Cordova issue.  Please
update the CVE name where you are able to this new name.  Mitre will
add a note to the CVE name CVE-2015-5257 in their database mentioning
Cordova and the new ID as a redirection.

Many apologies for the inconvenience.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: CVE-2015-5257 - Weak Randomization of BridgeSecret for Apache Cordova Android

[cve-assign]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

>> CVE-2015-5257: Weak Randomization of BridgeSecret for Apache Cordova Android

> Is there a typo here? CVE-2015-5257 was already assigned for an issue
> in drivers/usb/serial/whiteheat.c in the Linux kernel. see
> https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2015-5257

The outcome here is that this BridgeSecret vulnerability is now known
as CVE-2015-8320, not CVE-2015-5257. (Nobody working on Cordova was
involved in any typo or misuse of a CVE ID; however, that does not
change the outcome.) CVE-2015-5256 is unaffected by this event.

For additional details, see some or all of the following URLs
later today or tomorrow:

  http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2015-5257

  https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2015-5256
  http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2015-5256

  https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2015-8320
  http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2015-8320

  https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2015-5275
  http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2015-5275

- -- 
CVE assignment team, MITRE CVE Numbering Authority
M/S M300
202 Burlington Road, Bedford, MA 01730 USA
[ PGP key available through http://cve.mitre.org/cve/request_id.html ]
-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iQIcBAEBCAAGBQJWUsYoAAoJEL54rhJi8gl5ymkQAJftRBBnk52E/5xni8vgGSBR
Ar0ihQ2/SwiTh4cu/N2FvxPWtdw1G+xHsFyiknW3tDlUJhVy04HJ23gYf5AJTXn6
31yL1mPZz+AsM87sCupr9lqKzS+/HBbuVBPzz+Zs8Vb4pQYiuz/8Z0yCD4HR6iH8
OGLf9K+mZ07TqyaZkI8a23PjX5BaYqRxNR+vRsRNVuiFTiPq86++mrMUm+AUTNMJ
I1MyOZITMTCdITonmWIZj2XaFjyRZNd285bf/UqSirYAatinyuptEBlgHmgefYyU
UT/hYMnwiE6ajP5Ep8wbWBEmGqq22LFpaEVAkcTg3kFHxnYV/vt3Wt7l33yLPDwL
Gl3sQ71Njf681afx31ztv9CY+No2GTUtUjpUw074d/8SrIj0VWi+uzxNKtHtNaPR
jCfYVWWdbWm7wOfxjRk4O6F0SLh1fnkeVlHUpLTFJ/+j6j3c5BYrnTDL87+Uv/Bc
5WPjQ9xvctATout0bKszsgL70nOpSBYaFhct9wX5cdPgKiWB9upjW0nM25EMPK42
EE4Q2bgeDGGLfUubn//NSR33zI9OrglQNn9VeY9BrvyvKZ97nS2YRs5ZvTpY6miu
YjOe+NTzr0NcurMOVg/8Jx17UNVcbawd8lg0fA7AUqIzIMoJgI6k6MF+sIipfhj0
oEUUJNT0CzLYuIhkEB5n
=MJhw
-END PGP SIGNATURE-

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org