date:20151124

[GitHub] cordova-plugin-media pull request: Fixed the problem with multiple...

2015-11-24 Thread BernsteinA

Github user BernsteinA commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/33#issuecomment-159431126
  
@asfgit looks like you closed the wrong PR by accident


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: Fixed the problem with multiple...

2015-11-24 Thread purplecabbage

Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/33#issuecomment-159452179
  
Thanks @BernsteinA !
asfgit is not a person ... it's a bot that closes prs based on commit 
comments.
This does appear to be an error, although this pull request has issues as 
well ... commenting out code and committing is never the proper way ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: CB-10044 FileTransfer p...

2015-11-24 Thread stevengill

Github user stevengill commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/116#issuecomment-159452714
  
@daserge thoughts on merging this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: Fixed the problem with multiple...

2015-11-24 Thread BernsteinA

Github user BernsteinA commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/33#issuecomment-159453172
  
@purplecabbage can you reopen this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

2015-11-24 Thread Steven Gill

Starting the vote for this

On Tue, Nov 17, 2015 at 9:31 AM, David Barth 
wrote:

> Hey,
>
> I would like to update the 4.x series of cordova-ubuntu with a couple of
> fixes, and make it the last in the series supporting the cordova-cli 4.3.1
> branch as well
>
>- Cb 9868 - Should propose to install missing Ubuntu dependencies on
>platform add 
>- Cb 9694 - Add support for HTTP urls
>
>- Cb 9806 - Add icon to project defaults
>
>
> So here is the traditional:
>
> Does anyone have any reason to delay a cordova-ubuntu platform release?
> Any outstanding patches to land?
>
> If not, I will start the release tomorrow.
>
> David
>

[GitHub] cordova-plugin-media pull request: Fixed the problem with multiple...

2015-11-24 Thread purplecabbage

Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/33#issuecomment-159457232
  
Thanks for posting the JIRA @BernsteinA 
This pull request can't be accepted as is, but I will look into the issue 
soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[VOTE] cordova-ubuntu 4.3.1

2015-11-24 Thread Steven Gill

Please review and vote on this 4.3.1 Ubuntu Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-10030

The archive has been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10030

The package was published from its corresponding git tag:
cordova-ubuntu: 4.3.1 (745697f422)

Note that you can test it out via:

cordova platform add https://github.com/apache/cordova-ubuntu#4.3.1

Upon a successful vote I will upload the archive to dist/ and publish it to npm.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses

[ANNOUNCE] Cordova 5.4.1 released!

2015-11-24 Thread Steven Gill

Tweet: https://twitter.com/apachecordova/status/669333854591692801
Blog: http://cordova.apache.org/news/2015/11/24/tools-release.html

[GitHub] cordova-lib pull request: icon parameter should not be relative to...

2015-11-24 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/299


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-9590 - Ubuntu support for the new plu...

2015-11-24 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/294


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: Fixed the problem with multiple...

2015-11-24 Thread BernsteinA

Github user BernsteinA commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/33#issuecomment-159456824
  
Linking to Jira for posterity: https://issues.apache.org/jira/browse/CB-7684


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: Fixed the problem with multiple...

2015-11-24 Thread purplecabbage

Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/33#issuecomment-159458313
  
Sure. Send a pull request! :smiley_cat: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: Fixed the problem with multiple...

2015-11-24 Thread BernsteinA

Github user BernsteinA commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/33#issuecomment-159457841
  
Thanks. In the meantime could it be listed under iOS Quirks in the readme?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: Fixed the problem with multiple...

2015-11-24 Thread BernsteinA

Github user BernsteinA commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/33#issuecomment-159459013
  
:p how did I know that was going to be the answer


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...

2015-11-24 Thread snstarosciak

Github user snstarosciak commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-159498834
  
@ghenry22 Ahhh thankyou so much man, you've been a huge help :) :+1: Though 
I can get audio to work, I may need to try testing it in an HTML 5 audio player 
to see if it runs into a similar issue as an HTML video player with video 
files, but either way, at least one major problem fixed :P

Thanks dude!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: CB-10044 FileTransfer p...

2015-11-24 Thread daserge

Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/116#issuecomment-159499456
  
@stevengill, There are some questions and proposals on improvement for this 
PR - I believe they should be addressed first.
This is a new feature so it has a lower priority than existing bugs, which 
I'm looking into now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Fixing some styling issues and simplify...

2015-11-24 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/430


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-labs pull request: CB-9563 Mulptipart form data is used ev...

2015-11-24 Thread daserge

Github user daserge commented on the pull request:

https://github.com/apache/cordova-labs/pull/9#issuecomment-159510578
  
@dblotsky, @stevengill, @shazron - Can you please advice on how to handle 
this issue?
Should we switch to manual form parsing or to some lib supporting in-memory 
storing?
I'm also not sure how the security issues need be tracked - should I create 
a Jira for this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...

2015-11-24 Thread ghenry22

Github user ghenry22 commented on the pull request:

https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-159431966

That function just gets the directory that you would store your files in.  
You can then append any file name you want to access.  For example you could 
use the same with say pic.jpg to get a path to an image file to display, it's 
just a path to a file, doesn't matter what type of file.

I imagine you could then just use html5 video tags to play the video file, 
as long as it is in a format that the built in webview on the device can play.  
You'd have to do some research though, I don't play any video in my apps so I 
really don't know the best way to handle it or encoding requirements.

Cheers
Gaven

> On 25 Nov 2015, at 12:32 AM, Stevie Starosciak  
wrote:
> 
> @ghenry22 - If I could hug you...I would squeeze you until you popped, 
like a balloon. I tested a combination of that code out with mine AND IT 
WORKED. I never thought there was light at the end of the tunnel with this 
problem haha thankyou so much :) I will answer this question on stackoverflow 
and accept it so people can also have their problems solved 
> 
> One more thing, does this function:
> 
> $window.resolveLocalFileSystemURL(src, function(dir){
> basePath = dir.toInternalURL();
> });
> 
> Only work for mp3 files or something, because I'm utilizing this for a 
.mov file but that function doesn't seem to resolve the URL for that, but will 
with an mp3 file. Any idea?
> 
> â
> Reply to this email directly or view it on GitHub.
> 

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: draft of plugins release blog post

2015-11-24 Thread stevengill

Github user stevengill closed the pull request at:

https://github.com/apache/cordova-docs/pull/431


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-labs pull request: CB-9563 Mulptipart form data is used ev...

2015-11-24 Thread dblotsky

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-labs/pull/9#issuecomment-159401871
  
Do you think we can have some tests for this file? It's tedious to test it 
manually with `curl`. :/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Plugins release

2015-11-24 Thread julio cesar sanchez

Last update was on june for most plugins and there are a lot of issues
resolved. People is usually complain on stack overflow and phonegap build
forums about issues that are already fixed but not released, so +1 to
release now

El martes, 24 de noviembre de 2015, Simon MacDonald <
simon.macdon...@gmail.com> escribió:

> I agree with Steve. I'm already running into many issues from developers
> not being able to get their code working on Android 6. I really want the
> plugins out to support them.
>
> Simon Mac Donald
> http://hi.im/simonmacdonald
>
> On Tue, Nov 24, 2015 at 1:28 PM, Steven Gill  > wrote:
>
> > I disagree
> >
> > I have been getting pinged for weeks(months even) now to update the
> plugins
> > and don't think we should delay.
> >
> > If we are waiting for cordova 6 to pin cordova-android 5 and cordova-ios
> 4,
> > that will probably take at least a couple of weeks still. I'll make sure
> to
> > link the android 5.0 blog post in the plugins release blog post so users
> > know how to update their cordova-android. The draft I sent out for the
> > plugins blog post already has instructions on how to install older
> versions
> > of plugins.
> >
> > This isn't a problem we can avoid. Many users are going to run into the
> > fact that the plugin they are installing requires updated platforms.
> > Waiting until cordova 6 is unacceptable.
> >
> >
> >
> >
> >
> > On Tue, Nov 24, 2015 at 10:08 AM, Nikhil Khandelwal <
> > nikhi...@microsoft.com >
> > wrote:
> >
> > > Sorry for being late to respond. It will be great if we can publish the
> > > plugins release on npm at the same time as the tools release which pins
> > > android 5.0. Not publishing at the same time will break a very simple
> use
> > > case that Alex described below.
> > >
> > > -Nikhil
> > >
> > >
> > >
> > >
> > > On 11/20/15, 12:43 PM, "Steven Gill"  > wrote:
> > >
> > > >Manually update until we released tools with android 5 pinned.
> > > >
> > > >The failure is expected. Users will have to manually update to
> android 5
> > > or
> > > >use an older version of file.
> > > >
> > > >This was discussed before.
> > > >
> > > >Steps:
> > > >* android 5 release
> > > >* plugins release
> > > >* tools release
> > > >On Nov 20, 2015 8:26 AM, "Alexander Sorokin (Akvelon)" <
> > > >v-als...@microsoft.com > wrote:
> > > >
> > > >> Hi guys,
> > > >>
> > > >> Currently we have Android ~4.1.0 pinned in CLI but the file plugin
> > (and
> > > >> all plugins that depend on file plugin) depends on Android@5.0.0 or
> > > >> higher, so after this release, this will fail:
> > > >>
> > > >> cordova platform add android
> > > >> cordova plugin add cordova-plugin-file
> > > >>
> > > >> The output would be:
> > > >> Installing "cordova-plugin-file" for android
> > > >> Plugin doesn't support this project's cordova-android version.
> > > >> cordova-android: 4.1.1, failed version requirement: >=5.0.0-dev
> > > >> Skipping 'cordova-plugin-file' for android
> > > >>
> > > >> So, should Android@5.0.0 be pinned first or are we expecting users
> to
> > > >> manually update android to 5.0.0 ?
> > > >>
> > > >> Thanks,
> > > >> Alexander Sorokin
> > > >>
> > > >> -Original Message-
> > > >> From: Steven Gill [mailto:stevengil...@gmail.com ]
> > > >> Sent: Friday, November 20, 2015 2:04 AM
> > > >> To: dev@cordova.apache.org 
> > > >> Subject: Re: [DISCUSS] Plugins release
> > > >>
> > > >> Thanks Joe!
> > > >>
> > > >> P.S. The "r" prefixed tags messed up my coho commands to create the
> > tgz
> > > >> and print the corresponding tags. I have now fixed that problem by
> not
> > > >> stripping the "r" for plugin tags so those tags fail the semver
> check.
> > > >>
> > > >> Attempt 2 for plugins vote is now out.
> > > >>
> > > >>
> > > >> On Thu, Nov 19, 2015 at 11:03 AM, Joe Bowser  >
> > wrote:
> > > >>
> > > >> > I just did the test again on this end, and the only test failures
> I
> > > >> > got were the ones where I was expected to approve permissions.  It
> > > >> > seems that these tests will keep running and that the permission
> > > >> > dialog won't block the UI.  This is the correct behaviour, but it
> > does
> > > >> > mean that we have to make sure that we give the permissions for
> the
> > > >> > tests to work before we run them.
> > > >> >
> > > >> > After I approved all the permissions, I just get three Contacts
> > > >> > failures and a Media plugin failure.  One of the Contacts failures
> > > >> > comes from running on a device that I use day-to-day, since I
> don't
> > > >> > get that one on the HTC One M8, but the other three errors are
> > > >> consistent.
> > > >> >
> > > >> > Furthermore, the manual tests for Media work fine, so I don't
> think
> > > >> > that this should block the release.
> > > >> >
> > > >> > On Wed, Nov 18, 2015 at 11:24 PM, Steven Gill <
> >

Re: [DISCUSS] Plugins release

2015-11-24 Thread Simon MacDonald

Yeah, no coffee for developers that don't release because, "Coffee's for
closers!"

Simon Mac Donald
http://hi.im/simonmacdonald

On Tue, Nov 24, 2015 at 4:32 PM, Jesse  wrote:

> +1 to release
> Always Be Releasing!
>
>
> @purplecabbage
> risingj.com
>
> On Tue, Nov 24, 2015 at 1:28 PM, julio cesar sanchez <
> jcesarmob...@gmail.com
> > wrote:
>
> > Last update was on june for most plugins and there are a lot of issues
> > resolved. People is usually complain on stack overflow and phonegap build
> > forums about issues that are already fixed but not released, so +1 to
> > release now
> >
> > El martes, 24 de noviembre de 2015, Simon MacDonald <
> > simon.macdon...@gmail.com> escribió:
> >
> > > I agree with Steve. I'm already running into many issues from
> developers
> > > not being able to get their code working on Android 6. I really want
> the
> > > plugins out to support them.
> > >
> > > Simon Mac Donald
> > > http://hi.im/simonmacdonald
> > >
> > > On Tue, Nov 24, 2015 at 1:28 PM, Steven Gill  > > > wrote:
> > >
> > > > I disagree
> > > >
> > > > I have been getting pinged for weeks(months even) now to update the
> > > plugins
> > > > and don't think we should delay.
> > > >
> > > > If we are waiting for cordova 6 to pin cordova-android 5 and
> > cordova-ios
> > > 4,
> > > > that will probably take at least a couple of weeks still. I'll make
> > sure
> > > to
> > > > link the android 5.0 blog post in the plugins release blog post so
> > users
> > > > know how to update their cordova-android. The draft I sent out for
> the
> > > > plugins blog post already has instructions on how to install older
> > > versions
> > > > of plugins.
> > > >
> > > > This isn't a problem we can avoid. Many users are going to run into
> the
> > > > fact that the plugin they are installing requires updated platforms.
> > > > Waiting until cordova 6 is unacceptable.
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > On Tue, Nov 24, 2015 at 10:08 AM, Nikhil Khandelwal <
> > > > nikhi...@microsoft.com >
> > > > wrote:
> > > >
> > > > > Sorry for being late to respond. It will be great if we can publish
> > the
> > > > > plugins release on npm at the same time as the tools release which
> > pins
> > > > > android 5.0. Not publishing at the same time will break a very
> simple
> > > use
> > > > > case that Alex described below.
> > > > >
> > > > > -Nikhil
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > On 11/20/15, 12:43 PM, "Steven Gill"  > > > wrote:
> > > > >
> > > > > >Manually update until we released tools with android 5 pinned.
> > > > > >
> > > > > >The failure is expected. Users will have to manually update to
> > > android 5
> > > > > or
> > > > > >use an older version of file.
> > > > > >
> > > > > >This was discussed before.
> > > > > >
> > > > > >Steps:
> > > > > >* android 5 release
> > > > > >* plugins release
> > > > > >* tools release
> > > > > >On Nov 20, 2015 8:26 AM, "Alexander Sorokin (Akvelon)" <
> > > > > >v-als...@microsoft.com > wrote:
> > > > > >
> > > > > >> Hi guys,
> > > > > >>
> > > > > >> Currently we have Android ~4.1.0 pinned in CLI but the file
> plugin
> > > > (and
> > > > > >> all plugins that depend on file plugin) depends on Android@5.0.0
> > or
> > > > > >> higher, so after this release, this will fail:
> > > > > >>
> > > > > >> cordova platform add android
> > > > > >> cordova plugin add cordova-plugin-file
> > > > > >>
> > > > > >> The output would be:
> > > > > >> Installing "cordova-plugin-file" for android
> > > > > >> Plugin doesn't support this project's cordova-android version.
> > > > > >> cordova-android: 4.1.1, failed version requirement: >=5.0.0-dev
> > > > > >> Skipping 'cordova-plugin-file' for android
> > > > > >>
> > > > > >> So, should Android@5.0.0 be pinned first or are we expecting
> > users
> > > to
> > > > > >> manually update android to 5.0.0 ?
> > > > > >>
> > > > > >> Thanks,
> > > > > >> Alexander Sorokin
> > > > > >>
> > > > > >> -Original Message-
> > > > > >> From: Steven Gill [mailto:stevengil...@gmail.com
> ]
> > > > > >> Sent: Friday, November 20, 2015 2:04 AM
> > > > > >> To: dev@cordova.apache.org 
> > > > > >> Subject: Re: [DISCUSS] Plugins release
> > > > > >>
> > > > > >> Thanks Joe!
> > > > > >>
> > > > > >> P.S. The "r" prefixed tags messed up my coho commands to create
> > the
> > > > tgz
> > > > > >> and print the corresponding tags. I have now fixed that problem
> by
> > > not
> > > > > >> stripping the "r" for plugin tags so those tags fail the semver
> > > check.
> > > > > >>
> > > > > >> Attempt 2 for plugins vote is now out.
> > > > > >>
> > > > > >>
> > > > > >> On Thu, Nov 19, 2015 at 11:03 AM, Joe Bowser  > > >
> > > > wrote:
> > > > > >>
> > > > > >> > I just did the test again on this end, and the only test
> > failures
> > > I
> > > > > >>

Re: [DISCUSS] Plugins release

2015-11-24 Thread Jesse

+1 to release
Always Be Releasing!


@purplecabbage
risingj.com

On Tue, Nov 24, 2015 at 1:28 PM, julio cesar sanchez  wrote:

> Last update was on june for most plugins and there are a lot of issues
> resolved. People is usually complain on stack overflow and phonegap build
> forums about issues that are already fixed but not released, so +1 to
> release now
>
> El martes, 24 de noviembre de 2015, Simon MacDonald <
> simon.macdon...@gmail.com> escribió:
>
> > I agree with Steve. I'm already running into many issues from developers
> > not being able to get their code working on Android 6. I really want the
> > plugins out to support them.
> >
> > Simon Mac Donald
> > http://hi.im/simonmacdonald
> >
> > On Tue, Nov 24, 2015 at 1:28 PM, Steven Gill  > > wrote:
> >
> > > I disagree
> > >
> > > I have been getting pinged for weeks(months even) now to update the
> > plugins
> > > and don't think we should delay.
> > >
> > > If we are waiting for cordova 6 to pin cordova-android 5 and
> cordova-ios
> > 4,
> > > that will probably take at least a couple of weeks still. I'll make
> sure
> > to
> > > link the android 5.0 blog post in the plugins release blog post so
> users
> > > know how to update their cordova-android. The draft I sent out for the
> > > plugins blog post already has instructions on how to install older
> > versions
> > > of plugins.
> > >
> > > This isn't a problem we can avoid. Many users are going to run into the
> > > fact that the plugin they are installing requires updated platforms.
> > > Waiting until cordova 6 is unacceptable.
> > >
> > >
> > >
> > >
> > >
> > > On Tue, Nov 24, 2015 at 10:08 AM, Nikhil Khandelwal <
> > > nikhi...@microsoft.com >
> > > wrote:
> > >
> > > > Sorry for being late to respond. It will be great if we can publish
> the
> > > > plugins release on npm at the same time as the tools release which
> pins
> > > > android 5.0. Not publishing at the same time will break a very simple
> > use
> > > > case that Alex described below.
> > > >
> > > > -Nikhil
> > > >
> > > >
> > > >
> > > >
> > > > On 11/20/15, 12:43 PM, "Steven Gill"  > > wrote:
> > > >
> > > > >Manually update until we released tools with android 5 pinned.
> > > > >
> > > > >The failure is expected. Users will have to manually update to
> > android 5
> > > > or
> > > > >use an older version of file.
> > > > >
> > > > >This was discussed before.
> > > > >
> > > > >Steps:
> > > > >* android 5 release
> > > > >* plugins release
> > > > >* tools release
> > > > >On Nov 20, 2015 8:26 AM, "Alexander Sorokin (Akvelon)" <
> > > > >v-als...@microsoft.com > wrote:
> > > > >
> > > > >> Hi guys,
> > > > >>
> > > > >> Currently we have Android ~4.1.0 pinned in CLI but the file plugin
> > > (and
> > > > >> all plugins that depend on file plugin) depends on Android@5.0.0
> or
> > > > >> higher, so after this release, this will fail:
> > > > >>
> > > > >> cordova platform add android
> > > > >> cordova plugin add cordova-plugin-file
> > > > >>
> > > > >> The output would be:
> > > > >> Installing "cordova-plugin-file" for android
> > > > >> Plugin doesn't support this project's cordova-android version.
> > > > >> cordova-android: 4.1.1, failed version requirement: >=5.0.0-dev
> > > > >> Skipping 'cordova-plugin-file' for android
> > > > >>
> > > > >> So, should Android@5.0.0 be pinned first or are we expecting
> users
> > to
> > > > >> manually update android to 5.0.0 ?
> > > > >>
> > > > >> Thanks,
> > > > >> Alexander Sorokin
> > > > >>
> > > > >> -Original Message-
> > > > >> From: Steven Gill [mailto:stevengil...@gmail.com ]
> > > > >> Sent: Friday, November 20, 2015 2:04 AM
> > > > >> To: dev@cordova.apache.org 
> > > > >> Subject: Re: [DISCUSS] Plugins release
> > > > >>
> > > > >> Thanks Joe!
> > > > >>
> > > > >> P.S. The "r" prefixed tags messed up my coho commands to create
> the
> > > tgz
> > > > >> and print the corresponding tags. I have now fixed that problem by
> > not
> > > > >> stripping the "r" for plugin tags so those tags fail the semver
> > check.
> > > > >>
> > > > >> Attempt 2 for plugins vote is now out.
> > > > >>
> > > > >>
> > > > >> On Thu, Nov 19, 2015 at 11:03 AM, Joe Bowser  > >
> > > wrote:
> > > > >>
> > > > >> > I just did the test again on this end, and the only test
> failures
> > I
> > > > >> > got were the ones where I was expected to approve permissions.
> It
> > > > >> > seems that these tests will keep running and that the permission
> > > > >> > dialog won't block the UI.  This is the correct behaviour, but
> it
> > > does
> > > > >> > mean that we have to make sure that we give the permissions for
> > the
> > > > >> > tests to work before we run them.
> > > > >> >
> > > > >> > After I approved all the permissions, I just get three Contacts
> > > > >> > failures and a Media plugin

[GitHub] cordova-labs pull request: CB-9563 Mulptipart form data is used ev...

2015-11-24 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-labs/pull/9#discussion_r45791335
  
--- Diff: server.js ---
@@ -4,6 +4,8 @@ var formidable = require('formidable'),
 port = process.env.PORT || 5000;
 stringify = require('json-stringify-safe');
 
+var DIRECT_UPLOAD_LIMIT = 32;
--- End diff --

Please add that in a comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-labs pull request: CB-9563 Mulptipart form data is used ev...

2015-11-24 Thread daserge

Github user daserge commented on a diff in the pull request:

https://github.com/apache/cordova-labs/pull/9#discussion_r45791347
  
--- Diff: server.js ---
@@ -35,15 +37,34 @@ http.createServer(function (req, res) {
 res.writeHead(200, {'Content-Type': 'text/plain'});
 res.end("Hello!\n");
 } else if (req.url == '/upload' && (req.method.toLowerCase() == 'post' 
|| req.method.toLowerCase() == 'put')) {
-var form = new formidable.IncomingForm();
-form.parse(req, function(err, fields, files) {
-res.writeHead(200, {'content-type': 'text/plain'});
-console.log(stringify({fields: fields, files: files}));
+if(req.headers["content-type"].indexOf("multipart/form-data") === 
0) {
+console.log("multipart/form upload");
+var form = new formidable.IncomingForm();
+form.parse(req, function(err, fields, files) {
+res.writeHead(200, {'content-type': 'text/plain'});
+console.log(stringify({fields: fields, files: files}));
+
+res.write(stringify({fields: fields, files: files}));
+console.log
--- End diff --

Thanks, I will remove it. It was there before though, but it makes no sense.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-labs pull request: CB-9563 Mulptipart form data is used ev...

2015-11-24 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-labs/pull/9#discussion_r45791371
  
--- Diff: server.js ---
@@ -4,6 +4,8 @@ var formidable = require('formidable'),
 port = process.env.PORT || 5000;
 stringify = require('json-stringify-safe');
 
+var DIRECT_UPLOAD_LIMIT = 32;
--- End diff --

I.E. The fact that it's bytes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-labs pull request: CB-9563 Mulptipart form data is used ev...

2015-11-24 Thread dblotsky

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-labs/pull/9#issuecomment-159403068
  
The `formidable` package writes `multipart-form` files to a temporary file 
on disk. This is a **huge** security problem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-labs pull request: CB-9563 Mulptipart form data is used ev...

2015-11-24 Thread dblotsky

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-labs/pull/9#issuecomment-159402244
  
Also... hold on... this server actually writes the files to disk. It should 
*not* do that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: draft of plugins release blog post

2015-11-24 Thread stevengill

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/431#discussion_r45786234
  
--- Diff: www/_posts/2015-11-24-plugins-release.md ---
@@ -0,0 +1,330 @@
+---
+layout: post
+author:
+name: Steve Gill
+url: https://twitter.com/stevesgill
+title:  "Plugins Release"
+categories: news
+tags: release plugins
+---
+
+The following plugins were updated today:
+
+* cordova-plugin-battery-status@1.1.1
+* cordova-plugin-camera@2.0.0
+* cordova-plugin-console@1.0.2
+* cordova-plugin-contacts@2.0.0
+* cordova-plugin-device@1.1.0
+* cordova-plugin-device-motion@1.2.0
+* cordova-plugin-device-orientation@1.0.2
+* cordova-plugin-dialogs@1.2.0
+* cordova-plugin-file@4.0.0
+* cordova-plugin-file-transfer@1.4.0
+* cordova-plugin-geolocation@2.0.0
+* cordova-plugin-globalization@1.0.2
+* cordova-plugin-inappbrowser@1.1.0
+* cordova-plugin-legacy-whitelist@1.1.1
+* cordova-plugin-media@2.0.0
+* cordova-plugin-media-capture@1.1.0
+* cordova-plugin-network-information@1.1.0
+* cordova-plugin-splashscreen@3.0.0
+* cordova-plugin-statusbar@2.0.0
+* cordova-plugin-test-framework@1.1.0
+* cordova-plugin-vibration@2.0.0
+* cordova-plugin-whitelist@1.2.0
+
+The following plugins now require `cordova-android@5.0.0`.
+* cordova-plugin-camera
+* cordova-plugin-contacts
+* cordova-plugin-file
+* cordova-plugin-geolocation
+* cordova-plugin-media
+
+If you are using an older version of `cordova-android`, you will have to 
explicitly install older versions of these plugins now.
+
+E.g. 
+
+cordova plugin add cordova-plugin-camera@1.2.0 --save
+
+To see what versions exist for a plugin, run `npm info PLUGINNAME`. 
+
+
+You can update any plugin by removing it, and then re-adding it.
+
+ E.g. To update your camera plugin:
+
+cordova plugin rm cordova-plugin-camera --save
+cordova plugin add cordova-plugin-camera --save
+
+Changes include:
+
+
+cordova-plugin-battery-status@1.1.1
+
+* [CB-10035](https://issues.apache.org/jira/browse/CB-10035) Updated 
`RELEASENOTES` to be newest to oldest
+* Fixing contribute link.
+
+cordova-plugin-camera@2.0.0
+
+* [CB-10035](https://issues.apache.org/jira/browse/CB-10035) Updated 
`RELEASENOTES` to be newest to oldest
+* [CB-8863](https://issues.apache.org/jira/browse/CB-8863) correct block 
usage for `async` calls
+* [CB-5479](https://issues.apache.org/jira/browse/CB-5479) changed 
`saveToPhotoAlbum` to save uncompressed images for **Android**
+* [CB-9169](https://issues.apache.org/jira/browse/CB-9169) Fixed 
`filetype` for uncompressed images and added quirk for **Android**
+* [CB-9446](https://issues.apache.org/jira/browse/CB-9446) Removing 
`CordovaResource` library code in favour of the code we're supposed to be 
deprecating because that at least works.
+* [CB-9942](https://issues.apache.org/jira/browse/CB-9942) Normalize line 
endings in Camera plugin docs
+* [CB-9910](https://issues.apache.org/jira/browse/CB-9910) Add permission 
request for some gallery requests for **Android**
+* [CB-7668](https://issues.apache.org/jira/browse/CB-7668) Adding a 
sterner warning for `allowedit` on **Android**
+* Fixing contribute link.
+* Using the `CordovaResourceApi` to fine paths of files in the background 
thread.  If the file doesn't exist, return the content `URI`. 
+* Add engine tag for **Cordova-Android 5.0.x**
+* [CB-9583](https://issues.apache.org/jira/browse/CB-9583): Added support 
for **Marshmallow** permissions (**Android 6.0**)
+* Try to use `realpath` filename instead of default `modified.jpg`
+* [CB-6190](https://issues.apache.org/jira/browse/CB-6190) **iOS** camera 
plugin ignores quality parameter
+* [CB-9633](https://issues.apache.org/jira/browse/CB-9633) **iOS** Taking 
a Picture With Option `destinationType:NATIVE_URI` doesn't show image
+* [CB-9745](https://issues.apache.org/jira/browse/CB-9745) Camera plugin 
docs should be generated from the source
+* [CB-9622](https://issues.apache.org/jira/browse/CB-9622) **WP8** Camera 
Option `destinationType:NATIVE_URI` is a `NO-OP`
+* [CB-9623](https://issues.apache.org/jira/browse/CB-9623) Fixes various 
issues when `encodingType` set to `png`
+* [CB-9591](https://issues.apache.org/jira/browse/CB-9591) Retaining 
aspect ratio when resizing
+* [CB-9443](https://issues.apache.org/jira/browse/CB-9443) Pick correct 
`maxResolution` 
+* [CB-9151](https://issues.apache.org/jira/browse/CB-9151) Trigger 
`captureAction` only once
+* [CB-9413](https://issues.apache.org/jira/browse/CB-9413) Close 
`RandomAccessStream` once copied
+* [CB-5661](https://issues.apache.org/jira/browse/CB-5661) Remove outdated

[GitHub] cordova-labs pull request: CB-9563 Mulptipart form data is used ev...

2015-11-24 Thread dblotsky

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-labs/pull/9#issuecomment-159411134
  
Please rewrite the form code so that nothing gets written to disk.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-labs pull request: CB-9563 Mulptipart form data is used ev...

2015-11-24 Thread daserge

Github user daserge commented on the pull request:

https://github.com/apache/cordova-labs/pull/9#issuecomment-159402700
  
I usually test it locally or with Heroku along with 
cordova-plugin-test-framework and the plugin auto tests.
What do you mean by writing to disk? Can you please point to the 
corresponding code?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-labs pull request: CB-9563 Mulptipart form data is used ev...

2015-11-24 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-labs/pull/9#discussion_r45790663
  
--- Diff: server.js ---
@@ -35,15 +37,34 @@ http.createServer(function (req, res) {
 res.writeHead(200, {'Content-Type': 'text/plain'});
 res.end("Hello!\n");
 } else if (req.url == '/upload' && (req.method.toLowerCase() == 'post' 
|| req.method.toLowerCase() == 'put')) {
-var form = new formidable.IncomingForm();
-form.parse(req, function(err, fields, files) {
-res.writeHead(200, {'content-type': 'text/plain'});
-console.log(stringify({fields: fields, files: files}));
+if(req.headers["content-type"].indexOf("multipart/form-data") === 
0) {
+console.log("multipart/form upload");
+var form = new formidable.IncomingForm();
+form.parse(req, function(err, fields, files) {
+res.writeHead(200, {'content-type': 'text/plain'});
+console.log(stringify({fields: fields, files: files}));
+
+res.write(stringify({fields: fields, files: files}));
+console.log
--- End diff --

Empty `console.log` here, is it intentional?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-labs pull request: CB-9563 Mulptipart form data is used ev...

2015-11-24 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-labs/pull/9#discussion_r45790741
  
--- Diff: server.js ---
@@ -4,6 +4,8 @@ var formidable = require('formidable'),
 port = process.env.PORT || 5000;
 stringify = require('json-stringify-safe');
 
+var DIRECT_UPLOAD_LIMIT = 32;
--- End diff --

What are the units for this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: CB-8641 Some file-trans...

2015-11-24 Thread daserge

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/118

CB-8641 Some file-transfer plugin tests occasionally fail in mobilespâ¦

â¦ec on Windows Phone 8.1

Increases timeouts for Windows platform in abort tests
Adds implementation for upload operation on Windows to abort right away 
rather than actually performing the upload

[Jira issue](https://issues.apache.org/jira/browse/CB-8641)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-file-transfer 
CB-8641

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file-transfer/pull/118.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #118


commit 0e2a294d490fd003ae796898e34425295fa9d91d
Author: daserge 
Date:   2015-11-24T20:21:43Z

CB-8641 Some file-transfer plugin tests occasionally fail in mobilespec on 
Windows Phone 8.1

Increases timeouts for Windows platform in abort tests
Adds implementation for upload operation on Windows to abort right away 
rather than actually performing the upload




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-labs pull request: CB-9563 Mulptipart form data is used ev...

2015-11-24 Thread daserge

Github user daserge commented on a diff in the pull request:

https://github.com/apache/cordova-labs/pull/9#discussion_r45791254
  
--- Diff: server.js ---
@@ -4,6 +4,8 @@ var formidable = require('formidable'),
 port = process.env.PORT || 5000;
 stringify = require('json-stringify-safe');
 
+var DIRECT_UPLOAD_LIMIT = 32;
--- End diff --

It's bytes; this corresponds to the test: 
https://github.com/apache/cordova-plugin-file-transfer/pull/117/files#diff-2a8a5fef3397df87ab538f028a5c6b50R955
 and the contents: 
https://github.com/apache/cordova-plugin-file-transfer/blob/9e93bad83c9e980cb593dc057fe8af40f35652f1/tests/tests.js#L710,
 which will be 17 bytes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-labs pull request: CB-9563 Mulptipart form data is used ev...

2015-11-24 Thread daserge

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-labs/pull/9

CB-9563 Mulptipart form data is used even a header named Content-Typeâ¦

â¦ is present

Adds direct upload endpoint

[Jira issue](https://issues.apache.org/jira/browse/CB-9563)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/daserge/cordova-labs cordova-filetransfer

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-labs/pull/9.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #9


commit 31aaad447ac7a42558b25898cbcf02636e9f750a
Author: daserge 
Date:   2015-11-24T12:02:04Z

CB-9563 Mulptipart form data is used even a header named Content-Type is 
present

Adds direct upload endpoint




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-labs pull request: CB-9563 Mulptipart form data is used ev...

2015-11-24 Thread daserge

Github user daserge commented on the pull request:

https://github.com/apache/cordova-labs/pull/9#issuecomment-159399788
  
@dblotsky, updated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-labs pull request: CB-9563 Mulptipart form data is used ev...

2015-11-24 Thread dblotsky

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-labs/pull/9#issuecomment-159524926
  
We were only running this on one machine, and we took that machine down and 
requested for it to be rebuilt, so no worries. As for the change, we should 
either look into configuring Formidable not to write to disk, or into using 
another library. Manual parsing would be the least favourable option.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Plugins release

2015-11-24 Thread Steven Gill

I disagree

I have been getting pinged for weeks(months even) now to update the plugins
and don't think we should delay.

If we are waiting for cordova 6 to pin cordova-android 5 and cordova-ios 4,
that will probably take at least a couple of weeks still. I'll make sure to
link the android 5.0 blog post in the plugins release blog post so users
know how to update their cordova-android. The draft I sent out for the
plugins blog post already has instructions on how to install older versions
of plugins.

This isn't a problem we can avoid. Many users are going to run into the
fact that the plugin they are installing requires updated platforms.
Waiting until cordova 6 is unacceptable.





On Tue, Nov 24, 2015 at 10:08 AM, Nikhil Khandelwal 
wrote:

> Sorry for being late to respond. It will be great if we can publish the
> plugins release on npm at the same time as the tools release which pins
> android 5.0. Not publishing at the same time will break a very simple use
> case that Alex described below.
>
> -Nikhil
>
>
>
>
> On 11/20/15, 12:43 PM, "Steven Gill"  wrote:
>
> >Manually update until we released tools with android 5 pinned.
> >
> >The failure is expected. Users will have to manually update to android 5
> or
> >use an older version of file.
> >
> >This was discussed before.
> >
> >Steps:
> >* android 5 release
> >* plugins release
> >* tools release
> >On Nov 20, 2015 8:26 AM, "Alexander Sorokin (Akvelon)" <
> >v-als...@microsoft.com> wrote:
> >
> >> Hi guys,
> >>
> >> Currently we have Android ~4.1.0 pinned in CLI but the file plugin (and
> >> all plugins that depend on file plugin) depends on Android@5.0.0 or
> >> higher, so after this release, this will fail:
> >>
> >> cordova platform add android
> >> cordova plugin add cordova-plugin-file
> >>
> >> The output would be:
> >> Installing "cordova-plugin-file" for android
> >> Plugin doesn't support this project's cordova-android version.
> >> cordova-android: 4.1.1, failed version requirement: >=5.0.0-dev
> >> Skipping 'cordova-plugin-file' for android
> >>
> >> So, should Android@5.0.0 be pinned first or are we expecting users to
> >> manually update android to 5.0.0 ?
> >>
> >> Thanks,
> >> Alexander Sorokin
> >>
> >> -Original Message-
> >> From: Steven Gill [mailto:stevengil...@gmail.com]
> >> Sent: Friday, November 20, 2015 2:04 AM
> >> To: dev@cordova.apache.org
> >> Subject: Re: [DISCUSS] Plugins release
> >>
> >> Thanks Joe!
> >>
> >> P.S. The "r" prefixed tags messed up my coho commands to create the tgz
> >> and print the corresponding tags. I have now fixed that problem by not
> >> stripping the "r" for plugin tags so those tags fail the semver check.
> >>
> >> Attempt 2 for plugins vote is now out.
> >>
> >>
> >> On Thu, Nov 19, 2015 at 11:03 AM, Joe Bowser  wrote:
> >>
> >> > I just did the test again on this end, and the only test failures I
> >> > got were the ones where I was expected to approve permissions.  It
> >> > seems that these tests will keep running and that the permission
> >> > dialog won't block the UI.  This is the correct behaviour, but it does
> >> > mean that we have to make sure that we give the permissions for the
> >> > tests to work before we run them.
> >> >
> >> > After I approved all the permissions, I just get three Contacts
> >> > failures and a Media plugin failure.  One of the Contacts failures
> >> > comes from running on a device that I use day-to-day, since I don't
> >> > get that one on the HTC One M8, but the other three errors are
> >> consistent.
> >> >
> >> > Furthermore, the manual tests for Media work fine, so I don't think
> >> > that this should block the release.
> >> >
> >> > On Wed, Nov 18, 2015 at 11:24 PM, Steven Gill  >
> >> > wrote:
> >> >
> >> > > Oh and 1 failing cordova-plugin-file-transfer test.
> >> > >
> >> > > I'll look more into the failures tomorrow.
> >> > >
> >> > >
> >> > > On Wed, Nov 18, 2015 at 11:12 PM, Steven Gill
> >> > > 
> >> > > wrote:
> >> > >
> >> > > > all the plugins have been updated and are ready to be voted on.
> >> > > >
> >> > > > I am getting 10 failing tests on my nexus 5X
> >> > > > (cordova-android@5.0.0, running marshmallow on phone).
> >> > > > * contacts (always failing for me)
> >> > > > * media
> >> > > >
> >> > > > Can someone else try running mobile spec and tell me what they are
> >> > > seeing?
> >> > > >
> >> > > > I can start the vote thread once these are resolved or we decide
> >> > > > they
> >> > are
> >> > > > expected. Everything has been tagged but I can easily update tags
> >> > > > if
> >> > > needed.
> >> > > >
> >> > > >
> >> > > >
> >> > > > On Tue, Nov 10, 2015 at 11:50 PM, julio cesar sanchez <
> >> > > > jcesarmob...@gmail.com> wrote:
> >> > > >
> >> > > >> Any more iOS experts can review my pull request?
> >> > > >>
> >> > > >> 2015-11-11 6:59 GMT+01:00 Steven Gill :
> >> > > >>
>

Re: [VOTE] Plugins Release! (attempt 2)

2015-11-24 Thread Steven Gill

The vote has now closed. The results are:

Positive Binding Votes: 3

Steve Gill
Alexander Sorokin
Joe Bowser

The vote has passed. I will be publishing the blog post + posting
these to dist and npm later today.


On Mon, Nov 23, 2015 at 10:06 AM, Joe Bowser  wrote:

> +1
> On Nov 23, 2015 7:19 AM, "Alexander Sorokin (Akvelon)" <
> v-als...@microsoft.com> wrote:
>
> > I vote +1.
> >
> > * Verified signatures and hashes
> > * Verified tags
> > * Verified that plugins can be added correctly to blank app
> > * Verified that blank app can be successfully built and ran
> > * Ran smoke testing of mobilespec app
> >
> > -Original Message-
> > From: Steven Gill [mailto:stevengil...@gmail.com]
> > Sent: Friday, November 20, 2015 2:02 AM
> > To: dev@cordova.apache.org
> > Subject: [VOTE] Plugins Release! (attempt 2)
> >
> > Please review and vote on the release of this plugins release by replying
> > to this email (and keep discussion on the DISCUSS thread)
> >
> > Release issue:
> >
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10035=01%7c01%7cv-alsoro%40microsoft.com%7cc528c07313f84f8a1f9308d2f1359214%7c72f988bf86f141af91ab2d7cd011db47%7c1=4i0JwOJbWV13CYlG6wAK%2bDvo6NSlDGkrsk1kK1vb%2bRg%3d
> >
> > The plugins have been published to
> > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10035/
> >
> > The packages were published from their corresponding git tags:
> > cordova-plugin-battery-status: 1.1.1 (946f15f5be)
> > cordova-plugin-camera: 2.0.0 (b3376e2389)
> > cordova-plugin-console: 1.0.2 (5800c5c5dc)
> > cordova-plugin-contacts: 2.0.0 (f282464d1d)
> > cordova-plugin-device: 1.1.0 (aa6a1d3be6)
> > cordova-plugin-device-motion: 1.2.0 (e0ca894347)
> > cordova-plugin-device-orientation: 1.0.2 (5c9ca663e2)
> > cordova-plugin-dialogs: 1.2.0 (c36d1c040d)
> > cordova-plugin-file: 4.0.0 (0b9d826416)
> > cordova-plugin-file-transfer: 1.4.0 (97031b2d75)
> > cordova-plugin-geolocation: 2.0.0 (57eb4dc550)
> > cordova-plugin-globalization: 1.0.2 (4e6174a299)
> > cordova-plugin-inappbrowser: 1.1.0 (1cd9205eb5)
> > cordova-plugin-legacy-whitelist: 1.1.1 (84f4e1242b)
> > cordova-plugin-media: 2.0.0 (229ba599b7)
> > cordova-plugin-media-capture: 1.1.0 (e1bc40b83f)
> > cordova-plugin-network-information: 1.1.0 (f6d2782780)
> > cordova-plugin-splashscreen: 3.0.0 (e2239306d6)
> > cordova-plugin-statusbar: 2.0.0 (7c27000b3a)
> > cordova-plugin-test-framework: 1.1.0 (3ad9964967)
> > cordova-plugin-vibration: 2.0.0 (db5313a019)
> > cordova-plugin-whitelist: 1.2.0 (9792fc5365)
> >
> > Upon a successful vote I will upload the archives to dist/, upload them
> to
> > npm and post the corresponding blog post.
> >
> > Voting guidelines:
> >
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and subdependencies
> > have Apache-compatible licenses
> > * Ran mobilespec on android and ios
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
>

[GitHub] cordova-plugin-contacts pull request: CB-9770 Request user permiss...

2015-11-24 Thread purplecabbage

Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/86#issuecomment-159364907
  
very nice!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [Vote] Tools Release Cordova 5.4.1

2015-11-24 Thread Steven Gill

The vote has now closed. The results are:

Positive Binding Votes: 3

Steve Gill
Alexander Sorokin
Vladimir Kotikov

The vote has passed. I will be publishing to dist + npm later today.
As well as the blog post.


On Tue, Nov 24, 2015 at 12:59 AM, Vladimir Kotikov (Akvelon) <
v-vlk...@microsoft.com> wrote:

> I vote +1
>
> * Ran coho -verify archive over RC archives
> * Ran npm test for relevant repos, checked out to release tag
> * Verified that mobilespec, created with old cli builds and runs
> successfully
>
> -
> Best regards, Vladimir
>
> -Original Message-
> From: Alexander Sorokin (Akvelon) [mailto:v-als...@microsoft.com]
> Sent: Monday, November 23, 2015 6:17 PM
> To: dev@cordova.apache.org
> Subject: RE: [Vote] Tools Release Cordova 5.4.1
>
> I vote +1.
>
> * Verified tags
> * Ability to install/uninstall Cordova
> * Ability to update Cordova
> * Ability to create blank app for Windows, WP8, Android
> * Ability to build/run apps
> * Reviewed release notes
> * Verified versions
> * Verified line breaks
> * Verified 'cordova serve'
> * Verified that browserified app builds and runs correctly
>
> -Original Message-
> From: Steven Gill [mailto:stevengil...@gmail.com]
> Sent: Friday, November 20, 2015 4:27 AM
> To: dev@cordova.apache.org
> Subject: [Vote] Tools Release Cordova 5.4.1
>
> Please review and vote on this Tools Release by replying to this email
> (and keep discussion on the DISCUSS thread)
>
> Release issue:
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10049=01%7c01%7cv-alsoro%40microsoft.com%7ce81d931a9108419f63f408d2f149bea7%7c72f988bf86f141af91ab2d7cd011db47%7c1=4iXT52w3%2b2nkJIdWv20QqWnpaY9SsrdPn8a7MTePAw0%3d
>
> Both tools have been published to
> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10049/
>
> The packages were published from their corresponding git tags:
>
> cordova-lib: 5.4.1 (720270618c)
> cordova-cli: 5.4.1 (e7467123d7)
>
> Upon a successful vote I will upload the archives to dist/, publish them
> to NPM, and post the corresponding blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and subdependencies
> have Apache-compatible licenses
> * Ran npm test
> * Upgraded an older cordova project to make sure plugins installed
> correctly when running prepare
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>

Re: [DISCUSS] Plugins release

2015-11-24 Thread Simon MacDonald

I agree with Steve. I'm already running into many issues from developers
not being able to get their code working on Android 6. I really want the
plugins out to support them.

Simon Mac Donald
http://hi.im/simonmacdonald

On Tue, Nov 24, 2015 at 1:28 PM, Steven Gill  wrote:

> I disagree
>
> I have been getting pinged for weeks(months even) now to update the plugins
> and don't think we should delay.
>
> If we are waiting for cordova 6 to pin cordova-android 5 and cordova-ios 4,
> that will probably take at least a couple of weeks still. I'll make sure to
> link the android 5.0 blog post in the plugins release blog post so users
> know how to update their cordova-android. The draft I sent out for the
> plugins blog post already has instructions on how to install older versions
> of plugins.
>
> This isn't a problem we can avoid. Many users are going to run into the
> fact that the plugin they are installing requires updated platforms.
> Waiting until cordova 6 is unacceptable.
>
>
>
>
>
> On Tue, Nov 24, 2015 at 10:08 AM, Nikhil Khandelwal <
> nikhi...@microsoft.com>
> wrote:
>
> > Sorry for being late to respond. It will be great if we can publish the
> > plugins release on npm at the same time as the tools release which pins
> > android 5.0. Not publishing at the same time will break a very simple use
> > case that Alex described below.
> >
> > -Nikhil
> >
> >
> >
> >
> > On 11/20/15, 12:43 PM, "Steven Gill"  wrote:
> >
> > >Manually update until we released tools with android 5 pinned.
> > >
> > >The failure is expected. Users will have to manually update to android 5
> > or
> > >use an older version of file.
> > >
> > >This was discussed before.
> > >
> > >Steps:
> > >* android 5 release
> > >* plugins release
> > >* tools release
> > >On Nov 20, 2015 8:26 AM, "Alexander Sorokin (Akvelon)" <
> > >v-als...@microsoft.com> wrote:
> > >
> > >> Hi guys,
> > >>
> > >> Currently we have Android ~4.1.0 pinned in CLI but the file plugin
> (and
> > >> all plugins that depend on file plugin) depends on Android@5.0.0 or
> > >> higher, so after this release, this will fail:
> > >>
> > >> cordova platform add android
> > >> cordova plugin add cordova-plugin-file
> > >>
> > >> The output would be:
> > >> Installing "cordova-plugin-file" for android
> > >> Plugin doesn't support this project's cordova-android version.
> > >> cordova-android: 4.1.1, failed version requirement: >=5.0.0-dev
> > >> Skipping 'cordova-plugin-file' for android
> > >>
> > >> So, should Android@5.0.0 be pinned first or are we expecting users to
> > >> manually update android to 5.0.0 ?
> > >>
> > >> Thanks,
> > >> Alexander Sorokin
> > >>
> > >> -Original Message-
> > >> From: Steven Gill [mailto:stevengil...@gmail.com]
> > >> Sent: Friday, November 20, 2015 2:04 AM
> > >> To: dev@cordova.apache.org
> > >> Subject: Re: [DISCUSS] Plugins release
> > >>
> > >> Thanks Joe!
> > >>
> > >> P.S. The "r" prefixed tags messed up my coho commands to create the
> tgz
> > >> and print the corresponding tags. I have now fixed that problem by not
> > >> stripping the "r" for plugin tags so those tags fail the semver check.
> > >>
> > >> Attempt 2 for plugins vote is now out.
> > >>
> > >>
> > >> On Thu, Nov 19, 2015 at 11:03 AM, Joe Bowser 
> wrote:
> > >>
> > >> > I just did the test again on this end, and the only test failures I
> > >> > got were the ones where I was expected to approve permissions.  It
> > >> > seems that these tests will keep running and that the permission
> > >> > dialog won't block the UI.  This is the correct behaviour, but it
> does
> > >> > mean that we have to make sure that we give the permissions for the
> > >> > tests to work before we run them.
> > >> >
> > >> > After I approved all the permissions, I just get three Contacts
> > >> > failures and a Media plugin failure.  One of the Contacts failures
> > >> > comes from running on a device that I use day-to-day, since I don't
> > >> > get that one on the HTC One M8, but the other three errors are
> > >> consistent.
> > >> >
> > >> > Furthermore, the manual tests for Media work fine, so I don't think
> > >> > that this should block the release.
> > >> >
> > >> > On Wed, Nov 18, 2015 at 11:24 PM, Steven Gill <
> stevengil...@gmail.com
> > >
> > >> > wrote:
> > >> >
> > >> > > Oh and 1 failing cordova-plugin-file-transfer test.
> > >> > >
> > >> > > I'll look more into the failures tomorrow.
> > >> > >
> > >> > >
> > >> > > On Wed, Nov 18, 2015 at 11:12 PM, Steven Gill
> > >> > > 
> > >> > > wrote:
> > >> > >
> > >> > > > all the plugins have been updated and are ready to be voted on.
> > >> > > >
> > >> > > > I am getting 10 failing tests on my nexus 5X
> > >> > > > (cordova-android@5.0.0, running marshmallow on phone).
> > >> > > > * contacts (always failing for me)
> > >> > > > * media
> > >> > > >
> > >> > > > Can someone else try running mobile spec and tell me what they
>

[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...

2015-11-24 Thread snstarosciak

Github user snstarosciak commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-159325716
  
@ghenry22 - If I could hug you...I would squeeze you until you popped, like 
a balloon. I tested a combination of that code out with mine AND IT WORKED. I 
never thought there was light at the end of the tunnel with this problem haha 
thankyou so much :) I will answer this question on stackoverflow and accept it 
so people can also have their problems solved :+1: 

One more thing, does this function:

`$window.resolveLocalFileSystemURL(src, function(dir){
  basePath = dir.toInternalURL();
});`

Only work for mp3 files or something, because I'm utilizing this for a .mov 
file but that function doesn't seem to resolve the URL for that, but will with 
an mp3 file. Any idea?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Plugins release

2015-11-24 Thread Nikhil Khandelwal

Sorry for being late to respond. It will be great if we can publish the plugins 
release on npm at the same time as the tools release which pins android 5.0. 
Not publishing at the same time will break a very simple use case that Alex 
described below.

-Nikhil




On 11/20/15, 12:43 PM, "Steven Gill"  wrote:

>Manually update until we released tools with android 5 pinned.
>
>The failure is expected. Users will have to manually update to android 5 or
>use an older version of file.
>
>This was discussed before.
>
>Steps:
>* android 5 release
>* plugins release
>* tools release
>On Nov 20, 2015 8:26 AM, "Alexander Sorokin (Akvelon)" <
>v-als...@microsoft.com> wrote:
>
>> Hi guys,
>>
>> Currently we have Android ~4.1.0 pinned in CLI but the file plugin (and
>> all plugins that depend on file plugin) depends on Android@5.0.0 or
>> higher, so after this release, this will fail:
>>
>> cordova platform add android
>> cordova plugin add cordova-plugin-file
>>
>> The output would be:
>> Installing "cordova-plugin-file" for android
>> Plugin doesn't support this project's cordova-android version.
>> cordova-android: 4.1.1, failed version requirement: >=5.0.0-dev
>> Skipping 'cordova-plugin-file' for android
>>
>> So, should Android@5.0.0 be pinned first or are we expecting users to
>> manually update android to 5.0.0 ?
>>
>> Thanks,
>> Alexander Sorokin
>>
>> -Original Message-
>> From: Steven Gill [mailto:stevengil...@gmail.com]
>> Sent: Friday, November 20, 2015 2:04 AM
>> To: dev@cordova.apache.org
>> Subject: Re: [DISCUSS] Plugins release
>>
>> Thanks Joe!
>>
>> P.S. The "r" prefixed tags messed up my coho commands to create the tgz
>> and print the corresponding tags. I have now fixed that problem by not
>> stripping the "r" for plugin tags so those tags fail the semver check.
>>
>> Attempt 2 for plugins vote is now out.
>>
>>
>> On Thu, Nov 19, 2015 at 11:03 AM, Joe Bowser  wrote:
>>
>> > I just did the test again on this end, and the only test failures I
>> > got were the ones where I was expected to approve permissions.  It
>> > seems that these tests will keep running and that the permission
>> > dialog won't block the UI.  This is the correct behaviour, but it does
>> > mean that we have to make sure that we give the permissions for the
>> > tests to work before we run them.
>> >
>> > After I approved all the permissions, I just get three Contacts
>> > failures and a Media plugin failure.  One of the Contacts failures
>> > comes from running on a device that I use day-to-day, since I don't
>> > get that one on the HTC One M8, but the other three errors are
>> consistent.
>> >
>> > Furthermore, the manual tests for Media work fine, so I don't think
>> > that this should block the release.
>> >
>> > On Wed, Nov 18, 2015 at 11:24 PM, Steven Gill 
>> > wrote:
>> >
>> > > Oh and 1 failing cordova-plugin-file-transfer test.
>> > >
>> > > I'll look more into the failures tomorrow.
>> > >
>> > >
>> > > On Wed, Nov 18, 2015 at 11:12 PM, Steven Gill
>> > > 
>> > > wrote:
>> > >
>> > > > all the plugins have been updated and are ready to be voted on.
>> > > >
>> > > > I am getting 10 failing tests on my nexus 5X
>> > > > (cordova-android@5.0.0, running marshmallow on phone).
>> > > > * contacts (always failing for me)
>> > > > * media
>> > > >
>> > > > Can someone else try running mobile spec and tell me what they are
>> > > seeing?
>> > > >
>> > > > I can start the vote thread once these are resolved or we decide
>> > > > they
>> > are
>> > > > expected. Everything has been tagged but I can easily update tags
>> > > > if
>> > > needed.
>> > > >
>> > > >
>> > > >
>> > > > On Tue, Nov 10, 2015 at 11:50 PM, julio cesar sanchez <
>> > > > jcesarmob...@gmail.com> wrote:
>> > > >
>> > > >> Any more iOS experts can review my pull request?
>> > > >>
>> > > >> 2015-11-11 6:59 GMT+01:00 Steven Gill :
>> > > >>
>> > > >> > Going to move forward with this tomorrow. Any holdups, let me
>> know.
>> > > >> Here or
>> > > >> > #plugins on slack.
>> > > >> >
>> > > >> > On Fri, Nov 6, 2015 at 2:51 PM, Richard Knoll <
>> > rikn...@microsoft.com>
>> > > >> > wrote:
>> > > >> >
>> > > >> > > I plan on merging in
>> > > >> > > https://github.com/apache/cordova-plugin-camera/pull/135 for
>> > > >> > > the
>> > > >> camera
>> > > >> > > plugin if there are no objections.
>> > > >> > >
>> > > >> > > Thanks,
>> > > >> > > Richard
>> > > >> > >
>> > > >> > > -Original Message-
>> > > >> > > From: Steven Gill [mailto:stevengil...@gmail.com]
>> > > >> > > Sent: Friday, November 6, 2015 11:38 AM
>> > > >> > > To: dev@cordova.apache.org
>> > > >> > > Subject: Re: [DISCUSS] Plugins release
>> > > >> > >
>> > > >> > > With plugin changes, it is always nice to get reviews since
>> > > >> > > it
>> > could
>> > > >> > > affect every platform.
>> > > >> > >
>> > > >> > > file:146 is merged
>> > > >> > > file: 119 LGTM
>>

[GitHub] cordova-docs pull request: draft of plugins release blog post

2015-11-24 Thread dpogue

Github user dpogue commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/431#discussion_r45705993
  
--- Diff: www/_posts/2015-11-24-plugins-release.md ---
@@ -0,0 +1,330 @@
+---
+layout: post
+author:
+name: Steve Gill
+url: https://twitter.com/stevesgill
+title:  "Plugins Release"
+categories: news
+tags: release plugins
+---
+
+The following plugins were updated today:
+
+* cordova-plugin-battery-status@1.1.1
+* cordova-plugin-camera@2.0.0
+* cordova-plugin-console@1.0.2
+* cordova-plugin-contacts@2.0.0
+* cordova-plugin-device@1.1.0
+* cordova-plugin-device-motion@1.2.0
+* cordova-plugin-device-orientation@1.0.2
+* cordova-plugin-dialogs@1.2.0
+* cordova-plugin-file@4.0.0
+* cordova-plugin-file-transfer@1.4.0
+* cordova-plugin-geolocation@2.0.0
+* cordova-plugin-globalization@1.0.2
+* cordova-plugin-inappbrowser@1.1.0
+* cordova-plugin-legacy-whitelist@1.1.1
+* cordova-plugin-media@2.0.0
+* cordova-plugin-media-capture@1.1.0
+* cordova-plugin-network-information@1.1.0
+* cordova-plugin-splashscreen@3.0.0
+* cordova-plugin-statusbar@2.0.0
+* cordova-plugin-test-framework@1.1.0
+* cordova-plugin-vibration@2.0.0
+* cordova-plugin-whitelist@1.2.0
+
+The following plugins now require `cordova-android@5.0.0`.
+* cordova-plugin-camera
+* cordova-plugin-contacts
+* cordova-plugin-file
+* cordova-plugin-geolocation
+* cordova-plugin-media
+
+If you are using an older version of `cordova-android`, you will have to 
explicitly install older versions of these plugins now.
+
+E.g. 
+
+cordova plugin add cordova-plugin-camera@1.2.0 --save
+
+To see what versions exist for a plugin, run `npm info PLUGINNAME`. 
+
+
+You can update any plugin by removing it, and then re-adding it.
+
+ E.g. To update your camera plugin:
+
+cordova plugin rm cordova-plugin-camera --save
+cordova plugin add cordova-plugin-camera --save
+
+Changes include:
+
+
+cordova-plugin-battery-status@1.1.1
+
+* [CB-10035](https://issues.apache.org/jira/browse/CB-10035) Updated 
`RELEASENOTES` to be newest to oldest
+* Fixing contribute link.
+
+cordova-plugin-camera@2.0.0
+
+* [CB-10035](https://issues.apache.org/jira/browse/CB-10035) Updated 
`RELEASENOTES` to be newest to oldest
+* [CB-8863](https://issues.apache.org/jira/browse/CB-8863) correct block 
usage for `async` calls
+* [CB-5479](https://issues.apache.org/jira/browse/CB-5479) changed 
`saveToPhotoAlbum` to save uncompressed images for **Android**
+* [CB-9169](https://issues.apache.org/jira/browse/CB-9169) Fixed 
`filetype` for uncompressed images and added quirk for **Android**
+* [CB-9446](https://issues.apache.org/jira/browse/CB-9446) Removing 
`CordovaResource` library code in favour of the code we're supposed to be 
deprecating because that at least works.
+* [CB-9942](https://issues.apache.org/jira/browse/CB-9942) Normalize line 
endings in Camera plugin docs
+* [CB-9910](https://issues.apache.org/jira/browse/CB-9910) Add permission 
request for some gallery requests for **Android**
+* [CB-7668](https://issues.apache.org/jira/browse/CB-7668) Adding a 
sterner warning for `allowedit` on **Android**
+* Fixing contribute link.
+* Using the `CordovaResourceApi` to fine paths of files in the background 
thread.  If the file doesn't exist, return the content `URI`. 
+* Add engine tag for **Cordova-Android 5.0.x**
+* [CB-9583](https://issues.apache.org/jira/browse/CB-9583): Added support 
for **Marshmallow** permissions (**Android 6.0**)
+* Try to use `realpath` filename instead of default `modified.jpg`
+* [CB-6190](https://issues.apache.org/jira/browse/CB-6190) **iOS** camera 
plugin ignores quality parameter
+* [CB-9633](https://issues.apache.org/jira/browse/CB-9633) **iOS** Taking 
a Picture With Option `destinationType:NATIVE_URI` doesn't show image
+* [CB-9745](https://issues.apache.org/jira/browse/CB-9745) Camera plugin 
docs should be generated from the source
+* [CB-9622](https://issues.apache.org/jira/browse/CB-9622) **WP8** Camera 
Option `destinationType:NATIVE_URI` is a `NO-OP`
+* [CB-9623](https://issues.apache.org/jira/browse/CB-9623) Fixes various 
issues when `encodingType` set to `png`
+* [CB-9591](https://issues.apache.org/jira/browse/CB-9591) Retaining 
aspect ratio when resizing
+* [CB-9443](https://issues.apache.org/jira/browse/CB-9443) Pick correct 
`maxResolution` 
+* [CB-9151](https://issues.apache.org/jira/browse/CB-9151) Trigger 
`captureAction` only once
+* [CB-9413](https://issues.apache.org/jira/browse/CB-9413) Close 
`RandomAccessStream` once copied
+* [CB-5661](https://issues.apache.org/jira/browse/CB-5661) Remove outdated 
**iOS**

[GitHub] cordova-docs pull request: draft of plugins release blog post

2015-11-24 Thread dpogue

Github user dpogue commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/431#discussion_r45706005
  
--- Diff: www/_posts/2015-11-24-plugins-release.md ---
@@ -0,0 +1,330 @@
+---
+layout: post
+author:
+name: Steve Gill
+url: https://twitter.com/stevesgill
+title:  "Plugins Release"
+categories: news
+tags: release plugins
+---
+
+The following plugins were updated today:
+
+* cordova-plugin-battery-status@1.1.1
+* cordova-plugin-camera@2.0.0
+* cordova-plugin-console@1.0.2
+* cordova-plugin-contacts@2.0.0
+* cordova-plugin-device@1.1.0
+* cordova-plugin-device-motion@1.2.0
+* cordova-plugin-device-orientation@1.0.2
+* cordova-plugin-dialogs@1.2.0
+* cordova-plugin-file@4.0.0
+* cordova-plugin-file-transfer@1.4.0
+* cordova-plugin-geolocation@2.0.0
+* cordova-plugin-globalization@1.0.2
+* cordova-plugin-inappbrowser@1.1.0
+* cordova-plugin-legacy-whitelist@1.1.1
+* cordova-plugin-media@2.0.0
+* cordova-plugin-media-capture@1.1.0
+* cordova-plugin-network-information@1.1.0
+* cordova-plugin-splashscreen@3.0.0
+* cordova-plugin-statusbar@2.0.0
+* cordova-plugin-test-framework@1.1.0
+* cordova-plugin-vibration@2.0.0
+* cordova-plugin-whitelist@1.2.0
+
+The following plugins now require `cordova-android@5.0.0`.
+* cordova-plugin-camera
+* cordova-plugin-contacts
+* cordova-plugin-file
+* cordova-plugin-geolocation
+* cordova-plugin-media
+
+If you are using an older version of `cordova-android`, you will have to 
explicitly install older versions of these plugins now.
+
+E.g. 
+
+cordova plugin add cordova-plugin-camera@1.2.0 --save
+
+To see what versions exist for a plugin, run `npm info PLUGINNAME`. 
+
+
+You can update any plugin by removing it, and then re-adding it.
+
+ E.g. To update your camera plugin:
+
+cordova plugin rm cordova-plugin-camera --save
+cordova plugin add cordova-plugin-camera --save
+
+Changes include:
+
+
+cordova-plugin-battery-status@1.1.1
+
+* [CB-10035](https://issues.apache.org/jira/browse/CB-10035) Updated 
`RELEASENOTES` to be newest to oldest
+* Fixing contribute link.
+
+cordova-plugin-camera@2.0.0
+
+* [CB-10035](https://issues.apache.org/jira/browse/CB-10035) Updated 
`RELEASENOTES` to be newest to oldest
+* [CB-8863](https://issues.apache.org/jira/browse/CB-8863) correct block 
usage for `async` calls
+* [CB-5479](https://issues.apache.org/jira/browse/CB-5479) changed 
`saveToPhotoAlbum` to save uncompressed images for **Android**
+* [CB-9169](https://issues.apache.org/jira/browse/CB-9169) Fixed 
`filetype` for uncompressed images and added quirk for **Android**
+* [CB-9446](https://issues.apache.org/jira/browse/CB-9446) Removing 
`CordovaResource` library code in favour of the code we're supposed to be 
deprecating because that at least works.
+* [CB-9942](https://issues.apache.org/jira/browse/CB-9942) Normalize line 
endings in Camera plugin docs
+* [CB-9910](https://issues.apache.org/jira/browse/CB-9910) Add permission 
request for some gallery requests for **Android**
+* [CB-7668](https://issues.apache.org/jira/browse/CB-7668) Adding a 
sterner warning for `allowedit` on **Android**
+* Fixing contribute link.
+* Using the `CordovaResourceApi` to fine paths of files in the background 
thread.  If the file doesn't exist, return the content `URI`. 
+* Add engine tag for **Cordova-Android 5.0.x**
+* [CB-9583](https://issues.apache.org/jira/browse/CB-9583): Added support 
for **Marshmallow** permissions (**Android 6.0**)
+* Try to use `realpath` filename instead of default `modified.jpg`
+* [CB-6190](https://issues.apache.org/jira/browse/CB-6190) **iOS** camera 
plugin ignores quality parameter
+* [CB-9633](https://issues.apache.org/jira/browse/CB-9633) **iOS** Taking 
a Picture With Option `destinationType:NATIVE_URI` doesn't show image
+* [CB-9745](https://issues.apache.org/jira/browse/CB-9745) Camera plugin 
docs should be generated from the source
+* [CB-9622](https://issues.apache.org/jira/browse/CB-9622) **WP8** Camera 
Option `destinationType:NATIVE_URI` is a `NO-OP`
+* [CB-9623](https://issues.apache.org/jira/browse/CB-9623) Fixes various 
issues when `encodingType` set to `png`
+* [CB-9591](https://issues.apache.org/jira/browse/CB-9591) Retaining 
aspect ratio when resizing
+* [CB-9443](https://issues.apache.org/jira/browse/CB-9443) Pick correct 
`maxResolution` 
+* [CB-9151](https://issues.apache.org/jira/browse/CB-9151) Trigger 
`captureAction` only once
+* [CB-9413](https://issues.apache.org/jira/browse/CB-9413) Close 
`RandomAccessStream` once copied
+* [CB-5661](https://issues.apache.org/jira/browse/CB-5661) Remove outdated 
**iOS**

RE: [Vote] Tools Release Cordova 5.4.1

2015-11-24 Thread Vladimir Kotikov (Akvelon)

I vote +1

* Ran coho -verify archive over RC archives
* Ran npm test for relevant repos, checked out to release tag
* Verified that mobilespec, created with old cli builds and runs successfully

-
Best regards, Vladimir

-Original Message-
From: Alexander Sorokin (Akvelon) [mailto:v-als...@microsoft.com] 
Sent: Monday, November 23, 2015 6:17 PM
To: dev@cordova.apache.org
Subject: RE: [Vote] Tools Release Cordova 5.4.1

I vote +1.

* Verified tags
* Ability to install/uninstall Cordova
* Ability to update Cordova
* Ability to create blank app for Windows, WP8, Android
* Ability to build/run apps
* Reviewed release notes
* Verified versions
* Verified line breaks
* Verified 'cordova serve'
* Verified that browserified app builds and runs correctly

-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com] 
Sent: Friday, November 20, 2015 4:27 AM
To: dev@cordova.apache.org
Subject: [Vote] Tools Release Cordova 5.4.1

Please review and vote on this Tools Release by replying to this email (and 
keep discussion on the DISCUSS thread)

Release issue: 
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10049=01%7c01%7cv-alsoro%40microsoft.com%7ce81d931a9108419f63f408d2f149bea7%7c72f988bf86f141af91ab2d7cd011db47%7c1=4iXT52w3%2b2nkJIdWv20QqWnpaY9SsrdPn8a7MTePAw0%3d

Both tools have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10049/

The packages were published from their corresponding git tags:

cordova-lib: 5.4.1 (720270618c)
cordova-cli: 5.4.1 (e7467123d7)

Upon a successful vote I will upload the archives to dist/, publish them to 
NPM, and post the corresponding blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies have 
Apache-compatible licenses
* Ran npm test
* Upgraded an older cordova project to make sure plugins installed correctly 
when running prepare

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Plugins release

2015-11-24 Thread Raymond Camden

LGTM

On Tue, Nov 24, 2015 at 1:35 AM, Steven Gill  wrote:
> Please review the blog post for the plugins release
>
> https://github.com/apache/cordova-docs/pull/431
>
> On Fri, Nov 20, 2015 at 12:43 PM, Steven Gill 
> wrote:
>
>> Manually update until we released tools with android 5 pinned.
>>
>> The failure is expected. Users will have to manually update to android 5
>> or use an older version of file.
>>
>> This was discussed before.
>>



-- 
===
Raymond Camden, Developer Advocate for MobileFirst at IBM

Email : raymondcam...@gmail.com
Blog : www.raymondcamden.com
Twitter: raymondcamden

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-9770 Request user permiss...

2015-11-24 Thread vladimir-kotikov

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-plugin-contacts/pull/86

CB-9770 Request user permissions before picking a contact

This fixes [CB-9770](https://issues.apache.org/jira/browse/CB-9770) by 
requesting address book permissions before picker is shown for the first time.

This PR should also fix 
[CB-7838](https://issues.apache.org/jira/browse/CB-7838), where `id ==  -1` for 
any contact in address book is also caused by missing permissions.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-contacts CB-9770

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-contacts/pull/86.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #86


commit 617fb764bf1c7047cfe02cf346771dd7fa38ed40
Author: Vladimir Kotikov 
Date:   2015-11-24T12:46:25Z

CB-9770 Request user permissions before picking a contact




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

51 matches

Mail list logo