Re: [DISCUSS] Deprecate cordova-wp8

[julio cesar sanchez]

+1, I updated my device as soon as I could and all people I know that had
WP8 did the same

2015-12-03 3:38 GMT+01:00 Parashuram N :

> I am in the process of getting number of folks from VS who may be using
> WP8. These numbers should be able to add more data to this decision.
>
>
>
>
> On 12/2/15, 4:05 PM, "Tommy Williams"  wrote:
>
> >+1
> >
> >
> >
> >> On Dec 3 2015, at 10:47 am, Tim Barham 
> >wrote:
> >
> >>
> >
> >> Oh yes please :).
> >
> >>
> >
> >> \-Original Message-
> >From: Anis KADRI [mailto:anis.ka...@gmail.com]
> >Sent: Thursday, December 3, 2015 5:58 AM
> >To: dev@cordova.apache.org
> >Subject: Re: [DISCUSS] Deprecate cordova-wp8
> >
> >>
> >
> >> +1
> >
> >>
> >
> >> On Wed, Dec 2, 2015 at 11:32 AM Steven Gill  >
> >wrote:
> >
> >>
> >
> >> > +1
> >>
> >> On Wed, Dec 2, 2015 at 11:06 AM, Jesse  >
> >wrote:
> >>
> >> > We've talked about it for awhile, but never moved on it.
> cordova-wp8
> >> > has been a work horse that seen us through tough times but the
> sun
> >> > is
> >> setting.
> >> >
> >> > cordova-windows has been a viable alternative for some time
> now, and
> >> allows
> >> > developers to target newer device features from wp8.1 and wp10
> as
> >well.
> >> > Removing the responsibility of implementing changes in this now
> >> > ancient code base will free many of us to focus on making the
> >> > windows universal workflow better.
> >> >
> >> > I would like to see this wrapped up by the end of the year,
> which
> >> > for me
> >> is
> >> > the end of next week.
> >> >
> >> > Some suggestions of what needs to happen next :
> >> > \- display warning message in cli when devs type `cordova
> platform
> >> > add
> >> wp8`
> >> > ( next cordova-lib/cli release )
> >> > \- provide a plugin-dev migration guide outlining how to
> leverage
> >> > existing C# code in a windows-universal application ( I will do
> this
> >> > )
> >> > \- update repos / documentation with polite wording to move on
> >> > \- close a bunch of wp8 related issues in jira with "won't fix'
> >> > \- put wp8 out to pasture
> >> >
> >> > What are your thoughts?
> >> >
> >> >
> >> > Cheers,
> >> > Jesse
> >> >
> >> > @purplecabbage
> >> >
> >https://na01.safelinks.protection.outlook.com/?url=risingj.com&data=
> >> > 01%7c01%7cTBARHAM%40064d.mgd.microsoft.com
> %7ca53ffc23c94641e6e07a08d
> >> >
> >2fb52e381%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=2EjA1XtT2K3Oz
> >> > 3xEt1%2fX9Oq8JkQRl733V4NwkNO7J%2bM%3d
> >> >
> >>
> >
> >>
> >
> >> \-
> >To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> >For additional commands, e-mail: dev-h...@cordova.apache.org
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>

[GitHub] cordova-docs pull request: Update index.md

[h2ospace]

GitHub user h2ospace opened a pull request:

https://github.com/apache/cordova-docs/pull/434

Update index.md



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/h2ospace/cordova-docs patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/434.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #434


commit 152ef5e6a3e8ba3ffb40f8bc0eee5c84ff5dcc4f
Author: h2ospace 
Date:   2015-12-03T06:54:30Z

Update index.md




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [CB-10093][CB-9960][android] f...

[sencenan]

GitHub user sencenan opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/143

[CB-10093][CB-9960][android] fix error resolving content uri to file url

fixing: https://issues.apache.org/jira/browse/CB-10093

Different app returns different uri. This is causing getRealPath() to 
return empty path.

Fixed:

- Gallery: content://media/external/images/media/117209
- Google Photo: embeds a external image link inside another uri
- Dropbox: old school file url

Not fixed:

- Google Drive: document uri, but has no document id, or the id cannot be 
used to query content resolver

Notes:

I have tested with: Gallery, Dropbox, Google Photo, and various file 
manager apps. However, this fix as is still does not address the problem with 
Google Drive.

It seems to me that trying to get real file path from content uri seems to 
be a fundamentally flawed solution. It breaks the google sandbox between apps 
and this is going to get worse when more apps start to return the URL in 
"non-standard" formats.

Use getContentResolver().openInputStream() and read the file directly could 
be a way forward, given that we are copying the image file already.

For reference, I am using this following hack for my own branch to address 
problem with Google Drive:

```java
private String ouputModifiedBitmap(Bitmap bitmap, Uri uri) throws 
IOException {
// Some content: URIs do not map to file paths (e.g. picasa).
String realPath = FileHelper.getRealPath(uri, this.cordova);

//START OF HACK
if (realPath.length() == 0) {
String copiedFilePath = getTempDirectoryPath() + "/"
+ System.currentTimeMillis() + ".copied."
+ (this.encodingType == JPEG ? "jpg" : "png");

InputStream fin = 
this.cordova.getActivity().getContentResolver().openInputStream(uri);
OutputStream fout = new FileOutputStream(copiedFilePath);

byte[] buf = new byte[1024 * 4];
int len;

while ((len = fin.read(buf)) > 0) {
fout.write(buf, 0, len);
}

fin.close();
fout.close();

realPath = copiedFilePath;
}
//END OF HACK

// rest of ouputModifiedBitmap method
}
```


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sencenan/cordova-plugin-camera master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/143.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #143


commit c09a8cf09b371c6071256444b81b18c10b3b70af
Author: sen.ce...@gmail.com 
Date:   2015-11-30T20:18:03Z

m: fix the crash when the uri passed into outputModifiedBitmap() is not a 
document URI

commit 05cdb0133f53fff109298ac2fb10a89026bb6462
Author: sencenan 
Date:   2015-12-01T20:27:10Z

m: response to code reivew on pull request 141

commit 83978ea3736168520eae2935ee0318d6fb9bc7c3
Author: sen.ce...@gmail.com 
Date:   2015-12-03T05:49:47Z

[CB-10093][CB-9960][android] fix error resolving content uri to file url




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [CB-10093][android] fix failur...

[sencenan]

Github user sencenan commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/141#issuecomment-161523938
  
Making a new one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [CB-10093][android] fix failur...

[sencenan]

Github user sencenan closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/141


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [DISCUSS] Release file-transfer, media and media-capture

[Dmitry Blotsky]

Indeed. This also applies to all packages, not just to plugins.

-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com] 
Sent: Tuesday, December 1, 2015 8:49 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Release file-transfer, media and media-capture

+1 on specifying semver info for plugin dependencies

We need to watch out for the use case that plugins don't specify/resolve two 
different versions of the same plugin (i.e. file). For this reason is better to 
use flexible range using carat than specifying fixed version number.


On Tue, Dec 1, 2015 at 8:09 PM Dmitry Blotsky 
wrote:

> I created a task: 
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10110.&data=01%7c01%7cdblotsky%40microsoft.com%7c82b1c4c7ca43408d290808d2fad3e98b%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=T4lNDw9H%2fXCAF9lIQWJNSrPyEapWVG5SBT0vwfpSgeU%3d
>  Also, we should drop _all_ 0.x.x dependencies for sanity’s sake (refer here:
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fnodes
> ource.com%2fblog%2fsemver-tilde-and-caret&data=01%7c01%7cdblotsky%40microsoft.com%7c82b1c4c7ca43408d290808d2fad3e98b%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=E20OnCffiUUPmqAQWFY8CupEepShxawj95Wz7dZYkr8%3d).
>  If we just *must* use software below 1.0.0, we should be using “==“. Any 
> disagreements?
>
> Kindly,
> Dmitry
>
> On Dec 1, 2015, at 4:15 PM, Jesse  purplecabb...@gmail.com>> wrote:
>
> sounds good to me! Sounds like we need to.
>
>
> @purplecabbage
>
> https://na01.safelinks.protection.outlook.com/?url=risingj.com&data=01
> %7c01%7cdblotsky%40microsoft.com%7c1b06326da0414331afbc08d2faadb4f4%7c
> 72f988bf86f141af91ab2d7cd011db47%7c1&sdata=y6ZG90lSRsnDYqKdxmyFW5vOZaB
> j2qMFbwTtN9wkwec%3d
>
> On Tue, Dec 1, 2015 at 3:50 PM, Steven Gill 
> wrote:
>
> Due to file-transfer, media and media-capture having a dependency on 
> the file plugin, I propose we do a few patch/major releases for those plugins.
>
> Currently, the file dependency for these three plugins was set to grab 
> new majors automatically. This was a pretty big problem when people 
> working with cordova-android@4.x installed file-transfer and it was 
> grabbing a version of file that wasn't compatible.
>
> I updated the deps so it would only grab minor and patch changes. See
>
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue
> s.apache.org%2fjira%2fbrowse%2fCB-10100&data=01%7c01%7cdblotsky%40micr
> osoft.com%7c1b06326da0414331afbc08d2faadb4f4%7c72f988bf86f141af91ab2d7
> cd011db47%7c1&sdata=xPcujZgkOvm2k8EdpliawjaU0QhdEDBzCAS7MtkeKMI%3d
>
> I suggest we do the following releases where 1.x.x would have file 
> ^3.0.0 and 2.x.x would have file ^4.0.0:
> File-transfer@1.4.1 & 2.0.0.
> media@1.0.2 & 2.0.1
> media-capture@1.1.1 & 2.0.0
>
>
>

[GitHub] cordova-ios pull request: CB-9827 Implement and expose PlatformApi...

[shazron]

Github user shazron commented on the pull request:

https://github.com/apache/cordova-ios/pull/176#issuecomment-161500951
  
I've already pulled in this change, it's in the Apache git repos and 
somehow it hasn't mirrored yet: 
https://git1-us-west.apache.org/repos/asf?p=cordova-ios.git;a=commit;h=26cca47e3c1fa85f9f06232bfe099f9d4c9c8e40


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Deprecate cordova-wp8

[Parashuram N]

I am in the process of getting number of folks from VS who may be using WP8. 
These numbers should be able to add more data to this decision. 




On 12/2/15, 4:05 PM, "Tommy Williams"  wrote:

>+1
>
>  
>
>> On Dec 3 2015, at 10:47 am, Tim Barham 
>wrote:  
>
>>
>
>> Oh yes please :).
>
>>
>
>> \-Original Message-  
>From: Anis KADRI [mailto:anis.ka...@gmail.com]  
>Sent: Thursday, December 3, 2015 5:58 AM  
>To: dev@cordova.apache.org  
>Subject: Re: [DISCUSS] Deprecate cordova-wp8
>
>>
>
>> +1
>
>>
>
>> On Wed, Dec 2, 2015 at 11:32 AM Steven Gill 
>wrote:
>
>>
>
>> > +1  
>>  
>> On Wed, Dec 2, 2015 at 11:06 AM, Jesse 
>wrote:  
>>  
>> > We've talked about it for awhile, but never moved on it. cordova-wp8 
> 
>> > has been a work horse that seen us through tough times but the sun  
>> > is  
>> setting.  
>> >  
>> > cordova-windows has been a viable alternative for some time now, and 
> 
>> allows  
>> > developers to target newer device features from wp8.1 and wp10 as
>well.  
>> > Removing the responsibility of implementing changes in this now  
>> > ancient code base will free many of us to focus on making the  
>> > windows universal workflow better.  
>> >  
>> > I would like to see this wrapped up by the end of the year, which  
>> > for me  
>> is  
>> > the end of next week.  
>> >  
>> > Some suggestions of what needs to happen next :  
>> > \- display warning message in cli when devs type `cordova platform  
>> > add  
>> wp8`  
>> > ( next cordova-lib/cli release )  
>> > \- provide a plugin-dev migration guide outlining how to leverage  
>> > existing C# code in a windows-universal application ( I will do this 
> 
>> > )  
>> > \- update repos / documentation with polite wording to move on  
>> > \- close a bunch of wp8 related issues in jira with "won't fix'  
>> > \- put wp8 out to pasture  
>> >  
>> > What are your thoughts?  
>> >  
>> >  
>> > Cheers,  
>> > Jesse  
>> >  
>> > @purplecabbage  
>> >
>https://na01.safelinks.protection.outlook.com/?url=risingj.com&data=  
>> > 01%7c01%7cTBARHAM%40064d.mgd.microsoft.com%7ca53ffc23c94641e6e07a08d 
> 
>> >
>2fb52e381%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=2EjA1XtT2K3Oz  
>> > 3xEt1%2fX9Oq8JkQRl733V4NwkNO7J%2bM%3d  
>> >  
>>
>
>>
>
>> \-  
>To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org  
>For additional commands, e-mail: dev-h...@cordova.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] cordova-ios-4.x release (for real)

[Shazron]

Regarding Platform API, Vladimir Kotikov and Sergey Grebnov agree in
the PR comments that the changes can go in to cordova-ios-4.x:
https://github.com/apache/cordova-ios/pull/176

On Wed, Dec 2, 2015 at 5:38 PM, Shazron  wrote:
> Also, check footnote 3 above.
>
> Yes, WebKit defines window.openDatabase but it doesn't do anything.
> Not sure why their tests didn't catch this... (see footnote for the
> bug)
>
> With CSP off to rule things out:
> XHR to yourself of course works, but doesn't really make sense for
> real-world use. XHR to a sibling file, parent file, or any child file
> results in the error ""Cross origin requests are only supported for
> HTTP”.
>
> To illustrate:
>
>   |
> parent.xml
>   |
> www
>   | index.html (file currently loaded)
>   | sibling.xml
>   | child-folder
>   |   | child.xml
>
> index.html is the currently loaded file in the WebView. From it, you
> can't load parent.xml, sibling.xml nor child.xml using XHR according
> to my tests.
>
> Regarding *why* we have these storage tests, that is out of scope for
> this discussion, but I agree.
>
>
> On Wed, Dec 2, 2015 at 6:37 AM, Carlos Santana  wrote:
>> I'm guessing "pending" is the same as skipping the test.
>> I'm guessing WKWebView doesn't support Web SQL, but window.openDatabase
>> exist but it doesn't do anything?
>> I ask because I only saw the pending for wkwebview spec.18 for using it,
>> not for spec.9 where it checks that exists.
>> Anyway after all questions, why the we are still testing for storage APIs?
>> Cordova doesn't supported code to provide this storage APIs.
>> I think we should remove the storage tests all together, this is
>> webview/browser testing space.
>>
>> As for local xhr, is the problem only with specifying "../" relative path
>> in the xhr url and not local resources?
>> I see that doing xhr "index.html" that's a local resource and it works, and
>> also "./" also passes.
>> Aren't all this relative paths transform into full urls, and they will have
>> file:// in the final path used?
>> This means that xhr "folder1/data.json" works, but xhr
>> "../someparent/data.json" doesn't?
>>
>>
>> On Wed, Dec 2, 2015 at 4:52 AM Shazron  wrote:
>>
>>> Marked the two known failures as pending. Now everything is green (and
>>> yellow) across the board for UIWebView and WKWebView.
>>>
>>> On Tue, Dec 1, 2015 at 11:49 PM, Jesse  wrote:
>>> >>> Or should I just let it fail still?
>>> > It depends how long it'll be until we fix them.  The build will be broken
>>> > in the CI until it is fixed so probably marking them as pending is the
>>> > better option.
>>> >
>>> >
>>> > @purplecabbage
>>> > risingj.com
>>> >
>>> > On Tue, Dec 1, 2015 at 10:42 PM, Shazron  wrote:
>>> >
>>> >> Couldn't wait. All file-transfer specs now pass for uiwebview and
>>> >> wkwebview.
>>> >>
>>> >> For those two WKWebView tests that are failing, but are expected to
>>> >> fail -- I'll try to modify the tests to mark the test as pending if
>>> >> the platform is iOS and the WKWebView bridge is found.
>>> >>
>>> >> Or should I just let it fail still?
>>> >>
>>> >> On Tue, Dec 1, 2015 at 9:49 PM, Shazron  wrote:
>>> >> > Thanks! - yeah after I posted it, of course I realized it is all open
>>> >> > source (duh) and I can run a local server or throw it on a
>>> >> > digitalocean instance or something :)
>>> >> > I'll do that tomorrow...
>>> >> >
>>> >> > On Tue, Dec 1, 2015 at 9:24 PM, Carlos Santana 
>>> >> wrote:
>>> >> >> For a second I read "the bar is clear", but then I went to my fridge
>>> and
>>> >> >> saw I still have some beer left :-)
>>> >> >>
>>> >> >> How long before the INFRA provides the VM for the file transfer, I
>>> >> looked
>>> >> >> the JIRA and it mentioned something like "complete" and "we are in
>>> >> holding
>>> >> >> because of capacity" in the same comment, and I was like stupid
>>> because
>>> >> I
>>> >> >> didn't understand :-(
>>> >> >>
>>> >> >> If it's going to take a long time, can we do the test with a local
>>> >> machine
>>> >> >> and vet that it works?
>>> >> >>
>>> >> >> For local xhr loading, I left a comment in the JIRA.  I don't think
>>> it's
>>> >> >> need it but I'm curios on how local xhr loading works when fetching
>>> >> normal
>>> >> >> files on a web app, meaning dynamically loading js, css, html in SPA
>>> >> using
>>> >> >> a typical js framework like angular, etc..
>>> >> >>
>>> >> >> Platform API is [5], I think is nice to have but not required for the
>>> >> 4.0
>>> >> >> release.
>>> >> >>
>>> >> >> Oh by the way GREAT PROGRESS !!! and I cheers , I'm having a beer
>>> now.
>>> >> >>
>>> >> >>
>>> >> >>
>>> >> >> On Tue, Dec 1, 2015 at 8:38 PM Shazron  wrote:
>>> >> >>
>>> >> >>> The board is almost clear [1].
>>> >> >>>
>>> >> >>> UIWebView mobile-spec passes, just waiting for INFRA-10831 [2] for
>>> the
>>> >> >>> file-transfer tests.
>>> >> >>> Ditto for WKWebView, it essentially just fails two tests, which are
>>> >> >>> expected [3]
>>> >> >>> (filed a feature request

Re: [DISCUSS] cordova-ios-4.x release (for real)

[Shazron]

Also, check footnote 3 above.

Yes, WebKit defines window.openDatabase but it doesn't do anything.
Not sure why their tests didn't catch this... (see footnote for the
bug)

With CSP off to rule things out:
XHR to yourself of course works, but doesn't really make sense for
real-world use. XHR to a sibling file, parent file, or any child file
results in the error ""Cross origin requests are only supported for
HTTP”.

To illustrate:

  |
parent.xml
  |
www
  | index.html (file currently loaded)
  | sibling.xml
  | child-folder
  |   | child.xml

index.html is the currently loaded file in the WebView. From it, you
can't load parent.xml, sibling.xml nor child.xml using XHR according
to my tests.

Regarding *why* we have these storage tests, that is out of scope for
this discussion, but I agree.


On Wed, Dec 2, 2015 at 6:37 AM, Carlos Santana  wrote:
> I'm guessing "pending" is the same as skipping the test.
> I'm guessing WKWebView doesn't support Web SQL, but window.openDatabase
> exist but it doesn't do anything?
> I ask because I only saw the pending for wkwebview spec.18 for using it,
> not for spec.9 where it checks that exists.
> Anyway after all questions, why the we are still testing for storage APIs?
> Cordova doesn't supported code to provide this storage APIs.
> I think we should remove the storage tests all together, this is
> webview/browser testing space.
>
> As for local xhr, is the problem only with specifying "../" relative path
> in the xhr url and not local resources?
> I see that doing xhr "index.html" that's a local resource and it works, and
> also "./" also passes.
> Aren't all this relative paths transform into full urls, and they will have
> file:// in the final path used?
> This means that xhr "folder1/data.json" works, but xhr
> "../someparent/data.json" doesn't?
>
>
> On Wed, Dec 2, 2015 at 4:52 AM Shazron  wrote:
>
>> Marked the two known failures as pending. Now everything is green (and
>> yellow) across the board for UIWebView and WKWebView.
>>
>> On Tue, Dec 1, 2015 at 11:49 PM, Jesse  wrote:
>> >>> Or should I just let it fail still?
>> > It depends how long it'll be until we fix them.  The build will be broken
>> > in the CI until it is fixed so probably marking them as pending is the
>> > better option.
>> >
>> >
>> > @purplecabbage
>> > risingj.com
>> >
>> > On Tue, Dec 1, 2015 at 10:42 PM, Shazron  wrote:
>> >
>> >> Couldn't wait. All file-transfer specs now pass for uiwebview and
>> >> wkwebview.
>> >>
>> >> For those two WKWebView tests that are failing, but are expected to
>> >> fail -- I'll try to modify the tests to mark the test as pending if
>> >> the platform is iOS and the WKWebView bridge is found.
>> >>
>> >> Or should I just let it fail still?
>> >>
>> >> On Tue, Dec 1, 2015 at 9:49 PM, Shazron  wrote:
>> >> > Thanks! - yeah after I posted it, of course I realized it is all open
>> >> > source (duh) and I can run a local server or throw it on a
>> >> > digitalocean instance or something :)
>> >> > I'll do that tomorrow...
>> >> >
>> >> > On Tue, Dec 1, 2015 at 9:24 PM, Carlos Santana 
>> >> wrote:
>> >> >> For a second I read "the bar is clear", but then I went to my fridge
>> and
>> >> >> saw I still have some beer left :-)
>> >> >>
>> >> >> How long before the INFRA provides the VM for the file transfer, I
>> >> looked
>> >> >> the JIRA and it mentioned something like "complete" and "we are in
>> >> holding
>> >> >> because of capacity" in the same comment, and I was like stupid
>> because
>> >> I
>> >> >> didn't understand :-(
>> >> >>
>> >> >> If it's going to take a long time, can we do the test with a local
>> >> machine
>> >> >> and vet that it works?
>> >> >>
>> >> >> For local xhr loading, I left a comment in the JIRA.  I don't think
>> it's
>> >> >> need it but I'm curios on how local xhr loading works when fetching
>> >> normal
>> >> >> files on a web app, meaning dynamically loading js, css, html in SPA
>> >> using
>> >> >> a typical js framework like angular, etc..
>> >> >>
>> >> >> Platform API is [5], I think is nice to have but not required for the
>> >> 4.0
>> >> >> release.
>> >> >>
>> >> >> Oh by the way GREAT PROGRESS !!! and I cheers , I'm having a beer
>> now.
>> >> >>
>> >> >>
>> >> >>
>> >> >> On Tue, Dec 1, 2015 at 8:38 PM Shazron  wrote:
>> >> >>
>> >> >>> The board is almost clear [1].
>> >> >>>
>> >> >>> UIWebView mobile-spec passes, just waiting for INFRA-10831 [2] for
>> the
>> >> >>> file-transfer tests.
>> >> >>> Ditto for WKWebView, it essentially just fails two tests, which are
>> >> >>> expected [3]
>> >> >>> (filed a feature request issue [4] for local xhr loading, if
>> needed).
>> >> >>>
>> >> >>> Platform API [4] could go in this release as well, what do you
>> think?
>> >> >>>
>> >> >>> ---
>> >> >>>
>> >> >>> [1]
>> https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=76
>> >> >>> [2] https://issues.apache.org/jira/browse/INFRA-10831
>> >> >>> [3]
>> >> >>>
>> >>
>> https://issues.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

[Sinistralis]

Github user Sinistralis commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-161487045
  
I never tried this with XWalk but I'm not opposed to checking it out. I'm
at Rich Web right now so give me a few days to look into this
On Dec 2, 2015 8:24 PM, "nicoabie"  wrote:

> Sorry for not being explicit enough, I made a fork of the inappbrowser
> code and applied this pull request. I'm using XWalk and debuggind the code
> I get the cookies for the domain of the IAB but when they are set into the
> XWalk webview, let's say they are not being accepted, it silently fails
>
> —
> Reply to this email directly or view it on GitHub
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

[nicoabie]

Github user nicoabie commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-161486476
  
Sorry for not being explicit enough, I made a fork of the inappbrowser code 
and applied this pull request. I'm using XWalk and debuggind the code I get the 
cookies for the domain of the IAB but when they are set into the XWalk webview, 
let's say they are not being accepted, it silently fails  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10125: Android build fails on read-on...

[jasongin]

GitHub user jasongin opened a pull request:

https://github.com/apache/cordova-lib/pull/351

CB-10125: Android build fails on read-only image files

Ensure image files are writeable before trying to delete them.

I considered an alternative: ensuring files are writeable after copying 
them. But that seemed less robust, and other parts of the build are already 
able to overwrite read-only files due to the use of shell.cp('-f', ...). The 
only reason this code dealing with image files had a problem was because it 
deleted the files before re-copying them.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jasongin/cordova-lib CB-10125

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/351.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #351


commit e5f55415876b819c98189549dbfd231595afdb11
Author: Jason Ginchereau 
Date:   2015-12-03T01:09:04Z

CB-10125: Android build fails on read-only files




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Deprecate cordova-wp8

[Tommy Williams]

+1

  

> On Dec 3 2015, at 10:47 am, Tim Barham 
wrote:  

>

> Oh yes please :).

>

> \-Original Message-  
From: Anis KADRI [mailto:anis.ka...@gmail.com]  
Sent: Thursday, December 3, 2015 5:58 AM  
To: dev@cordova.apache.org  
Subject: Re: [DISCUSS] Deprecate cordova-wp8

>

> +1

>

> On Wed, Dec 2, 2015 at 11:32 AM Steven Gill 
wrote:

>

> > +1  
>  
> On Wed, Dec 2, 2015 at 11:06 AM, Jesse 
wrote:  
>  
> > We've talked about it for awhile, but never moved on it. cordova-wp8  
> > has been a work horse that seen us through tough times but the sun  
> > is  
> setting.  
> >  
> > cordova-windows has been a viable alternative for some time now, and  
> allows  
> > developers to target newer device features from wp8.1 and wp10 as
well.  
> > Removing the responsibility of implementing changes in this now  
> > ancient code base will free many of us to focus on making the  
> > windows universal workflow better.  
> >  
> > I would like to see this wrapped up by the end of the year, which  
> > for me  
> is  
> > the end of next week.  
> >  
> > Some suggestions of what needs to happen next :  
> > \- display warning message in cli when devs type `cordova platform  
> > add  
> wp8`  
> > ( next cordova-lib/cli release )  
> > \- provide a plugin-dev migration guide outlining how to leverage  
> > existing C# code in a windows-universal application ( I will do this  
> > )  
> > \- update repos / documentation with polite wording to move on  
> > \- close a bunch of wp8 related issues in jira with "won't fix'  
> > \- put wp8 out to pasture  
> >  
> > What are your thoughts?  
> >  
> >  
> > Cheers,  
> > Jesse  
> >  
> > @purplecabbage  
> >
https://na01.safelinks.protection.outlook.com/?url=risingj.com&data=  
> > 01%7c01%7cTBARHAM%40064d.mgd.microsoft.com%7ca53ffc23c94641e6e07a08d  
> >
2fb52e381%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=2EjA1XtT2K3Oz  
> > 3xEt1%2fX9Oq8JkQRl733V4NwkNO7J%2bM%3d  
> >  
>

>

> \-  
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org  
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

[ochakov]

Github user ochakov commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161470590
  
Added both fixes to this PR
Camera permission will not be required unless android.permission.CAMERA is 
set in the package.
BTW, barcode scanner and flashlight plugins both set that permission in the 
manifest.

I tested with and without android.permission.CAMERA and it works well in 
both cases, not asking for camera permission in case when both plugins are 
uninstalled.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [DISCUSS] Deprecate cordova-wp8

[Tim Barham]

Oh yes please :).

-Original Message-
From: Anis KADRI [mailto:anis.ka...@gmail.com] 
Sent: Thursday, December 3, 2015 5:58 AM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Deprecate cordova-wp8

+1

On Wed, Dec 2, 2015 at 11:32 AM Steven Gill  wrote:

> +1
>
> On Wed, Dec 2, 2015 at 11:06 AM, Jesse  wrote:
>
> > We've talked about it for awhile, but never moved on it. cordova-wp8 
> > has been a work horse that seen us through tough times but the sun 
> > is
> setting.
> >
> > cordova-windows has been a viable alternative for some time now, and
> allows
> > developers to target newer device features from wp8.1 and wp10 as well.
> > Removing the responsibility of implementing changes in this now 
> > ancient code base will free many of us to focus on making the 
> > windows universal workflow better.
> >
> > I would like to see this wrapped up by the end of the year, which 
> > for me
> is
> > the end of next week.
> >
> > Some suggestions of what needs to happen next :
> > - display warning message in cli when devs type `cordova platform 
> > add
> wp8`
> > ( next cordova-lib/cli release )
> > - provide a plugin-dev migration guide outlining how to leverage 
> > existing C# code in a windows-universal application ( I will do this 
> > )
> > - update repos / documentation with polite wording to move on
> > - close a bunch of wp8 related issues in jira with "won't fix'
> > - put wp8 out to pasture
> >
> > What are your thoughts?
> >
> >
> > Cheers,
> >   Jesse
> >
> > @purplecabbage
> > https://na01.safelinks.protection.outlook.com/?url=risingj.com&data=
> > 01%7c01%7cTBARHAM%40064d.mgd.microsoft.com%7ca53ffc23c94641e6e07a08d
> > 2fb52e381%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=2EjA1XtT2K3Oz
> > 3xEt1%2fX9Oq8JkQRl733V4NwkNO7J%2bM%3d
> >
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: Cb 9590 - Ubuntu support for the new plu...

[TimBarham]

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/349#discussion_r46494465
  
--- Diff: cordova-lib/src/plugman/platforms/ubuntu.js ---
@@ -29,6 +29,54 @@ function toCamelCase(str) {
 }).join('');
 }
 
+function getPluginXml(plugin_dir) {
+var et = require('elementtree'),
+fs = require('fs'),
+path = require('path');
+
+var pluginxml;
+var config_path = path.join(plugin_dir, 'plugin.xml');
+
+if (fs.existsSync(config_path)) {
+// Get the current plugin.xml file
+pluginxml = et.parse(fs.readFileSync(config_path, 'utf-8'));
+}
+ 
+return pluginxml;
+}
+
+function findClassName(pluginxml, plugin_id) {
+var class_name;
+
+// first check if we have a class-name parameter in the plugin config
+if (pluginxml) {
+   var platform = pluginxml.find("./platform/[@name='ubuntu']/");
+   if (platform) {
+   var param = 
platform.find("./config-file/[@target='config.xml']/feature/param/[@name='ubuntu-package']");
+   if (param && param.attrib) {
+   class_name = param.attrib.value;
+   return class_name;
+   }
+   }
+}
+
+// fallback to guess work, based on the plugin package name
+
+if (plugin_id.match(/\.[^.]+$/)) {
+// old-style plugin name
+class_name = plugin_id.match(/\.[^.]+$/)[0].substr(1);
+class_name = toCamelCase(class_name);
+} else {
+   match = plugin_id.match(/cordova\-plugin\-([\w\-]+)$/);
+if (match && match.length > 0)
+   class_name = match[0].substr(15);
+   else
+class_name = toCamelCase(class_name);
+}
+
+return class_name;
+}
--- End diff --

Thanks @david-barth-canonical! Some comments:

* Generally the Cordova codebase uses curly braces even around single line 
blocks.
* There are some tabs in there that should be converted to spaces.
* The `match` variable needs a `var`.
* Should be calling `toCamelCase()` for the scenario where we match 
`cordova-plugin-...`
* Where we don't match `cordova-plugin-...`, `class_name` is not defined 
(should be using `plugin_id`).
* Since we will always end up calling `toCamelCase()`, the logic for the 
second half of this method can be simplified to:

```js
// fallback to guess work, based on the plugin package name
if (plugin_id.match(/\.[^.]+$/)) {
// old-style plugin name
class_name = plugin_id.match(/\.[^.]+$/)[0].substr(1);
} else {
var match = plugin_id.match(/cordova\-plugin\-([\w\-]+)$/);
if (match && match.length > 0) {
class_name = match[0].substr(15);
} else {
class_name = plugin_id;
}
}

return toCamelCase(class_name);
```

Also, since the original PR has been merged, can you recreate this as a new 
PR which will just include the changes in your last commit (and changes in 
response to feedback, of course).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: CB-9891: Fix permission errors d...

[zanemcca]

Github user zanemcca commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/148#issuecomment-161468650
  
@asfgit @stevengill When is the 4.0.0 release expected to be on NPM with 
this fix?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-10039 Accept relative pat...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/94#issuecomment-161466199
  
We really need to get all this file reading code in one place for Android. 
The camera plugin does things a bit differently (see 
[here](https://github.com/apache/cordova-plugin-camera/blob/master/src/android/FileHelper.java)).
 Is this the correct way to interpret relative paths? This assumes that they 
should be based on the assets root directory, but should it act like a web page 
and respect the file structure of the www folder? What do other platforms do? 
@jasongin thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: Removing the '--usegit' flag from `cordo...

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-lib/pull/350#issuecomment-161462802
  
:+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: Removing the '--usegit' flag from `cordo...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/350


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: Removing the '--usegit' flag from `cordo...

[purplecabbage]

Github user purplecabbage commented on the pull request:

https://github.com/apache/cordova-lib/pull/350#issuecomment-161461873
  
lgtm!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Removing the '--usegit' flag from `cordo...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-cli/pull/229


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Removing the '--usegit' flag from `cordo...

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-cli/pull/229#issuecomment-161460255
  
related pull request: https://github.com/apache/cordova-lib/pull/350


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Removing the '--usegit' flag from `cordo...

[omefire]

GitHub user omefire opened a pull request:

https://github.com/apache/cordova-cli/pull/229

Removing the '--usegit' flag from `cordova platform`.

The recommended method is to use `cordova platform add git_url#branch`

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/omefire/cordova-cli remove_use_git_option

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/229.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #229


commit 34f61cdf0afeed0687e3902900e217f811c7b53c
Author: Omar Mefire 
Date:   2015-12-02T22:20:56Z

Removing the '--usegit' flag from `cordova platform`.
Recommended method is to use `cordova platform add git_url#branch`




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: Removing the '--usegit' flag from `cordo...

[omefire]

GitHub user omefire opened a pull request:

https://github.com/apache/cordova-lib/pull/350

Removing the '--usegit' flag from `cordova platform`.

The recommended method is to use `cordova platform add git_url#branch`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/omefire/cordova-lib removing_usegit_flag

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/350.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #350


commit 7af5c536725d2fe74c7fb75d850b552614b066e4
Author: Omar Mefire 
Date:   2015-12-02T22:43:42Z

Removing the '--usegit' flag from `cordova platform`.
Recommended method is to use `cordova platform add git_url#branch`




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-9348 Fetch phoneNumbers a...

[MarsupiL]

Github user MarsupiL commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/88#issuecomment-161456736
  
+1 for resolving this issue.
I am using the ng-cordova plugin to pick contacts and almost every contact 
in my contact book is linked, which directly crashes my app! I couldn't find 
any workaround to it. Any help on this would be great.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [GitHub] cordova-plugin-contacts pull request: CB-8115 Save contact birthda...

[Jesse]

The issue is that the date object is not stored in a method that is
compatible with other applications on the android device.
This is strictly a native issue, and as Vlad said, not testable via our own
automated tests.
We get back exactly what we store, so our current tests all pass.  The
native code just needs to store/retrieve it in a format compatible with
other apps.  This should have zero impact on other platforms and zero
impact on the js code.


@purplecabbage
risingj.com

On Wed, Dec 2, 2015 at 2:14 PM, riknoll  wrote:

> Github user riknoll commented on the pull request:
>
>
> https://github.com/apache/cordova-plugin-contacts/pull/95#issuecomment-161450864
>
> @vladimir-kotikov is the issue that Android saves the date in a
> different format from other platforms? If that is the case, I guess the
> greater issue is lack of consistency in the API as to how contacts are
> presented in the JS. That sounds like a separate issue to me, but one that
> should be addressed.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

RE: Where to download Cordova shell tools?

[Parashuram N]

Robert,

I think you have some wonderful suggestions for making the documentation 
better. Could we request to send in pull request for the changes that you have 
outlined - this way, others could benefit from your input  even more. 
It may be a while before existing committers may be able to get to the 
documentation, and sending in pull request would possibly be the quickest way.

Also, if you are hesitant about sending in a pull request, or are having 
trouble, please let us know - I think we should also work on ensuring that the 
community can edit documents much more easily. 

-Original Message-
From: Robert Hoffmann [mailto:robert.hoffmann@gmail.com] 
Sent: Wednesday, December 2, 2015 3:08 AM
To: dev@cordova.apache.org
Subject: Re: Where to download Cordova shell tools?

Thank you for these links!

Please find below some thoughts... maybe they can help you make the 
documentation and user experience for dummies like me even better :)

In hindsight "npm install cordova-android" seems obvious, but I would not have 
guessed it. Especially because I want to be confident about the version I am 
using.


1) So it is good to know where I can get stable but also previous releases:

1a) Using GitHub e.g. https://github.com/apache/cordova-android

1b) 
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist.apache.org%2frepos%2fdist%2frelease%2fcordova&data=01%7c01%7cpanarasi%40microsoft.com%7c5b9a0fbf473c4194543f08d2fb388ad7%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=jbyGVWr0AU6%2brxlKzLVemfLHMkbC4gbvH8F%2f9FJyW8A%3d


2) Download section

IMHO, from a user (not contributor) perspective a download section should 
basically list Platforms, Plugins, Other (like the Contribute page)... but omit 
the Apache link and instead provide a link to npm (or a popup with the command 
'npm install cordova-android' to copy)

In other words: GitHub for power users. And npm for convenience.

And I would put Download in the top menu left of Contribute, because you surely 
have more downloading users than contributing users.


3) Then "{Platform} Shell Tool Guide" sections in the documentation 
could point to this download section instead of just cordova.apache.org.

Dealing with shell tools seems unavoidable (e.g. for many plugins) so 
they 'deserve' more emphasis.


4) Generally there is this balancing between cli and shell tools, which 
took me some time to grasp. The fact that cli is a shell tool too did 
not help ;)

Maybe "Power Tools" would be a more appropriate?


5) Regarding GitHub

Could you recommend to git clone cordova-android specifically for one 
app project? And then just update it with (git pull) when needed? 
Following with a project update (i.e. "cordova-android/bin/update")


Thank you and best regards,
Robert



On 02/12/15 02:16, Steven Gill wrote:
> Sure. But for the example above, where someone wants cordova-android 
> (especially with the new platform API), we are going to see more 
> people wanting to require('cordova-android'). We should atleast 
> provide links to our official download distributions on our site. If 
> not on the contributions page, somewhere else. Maybe the repos that 
> aren't published to npm just don't get the link?
>
> Another example, how does someone figure out how to install plugman 
> currently?
>
>
> On Tue, Dec 1, 2015 at 5:12 PM, Dmitry Blotsky  > wrote:
>
> Footer sounds good to me.
>
> I’m not a fan of adding NPM links for two reasons though:
> 1). Not every repo should be installed manually via NPM
> 2). The information on the NPM page is already shown on GitHub
>
> Kindly,
> Dmitry
>
> > On Dec 1, 2015, at 4:20 PM, Steven Gill  > wrote:
> >
> > I'd say footer as most of our users aren't going to use dist.
> >
> > I think it is worth adding the npm links for all of our repos at
> >
> 
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fcordova.apache.org%2fcontribute%2f&data=01%7c01%7cdblotsky%40microsoft.com%7c5ec7ab5bff404293b51a08d2faae74f7%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=CN9fj7oBBdz9NjcPtMg9lBwmoGWoR1ckyfdzwvKnDGw%3d
> beside the github and apache git repo
> > links.
> >
> > On Tue, Dec 1, 2015 at 3:59 PM, Dmitry Blotsky
> mailto:dblot...@microsoft.com>>
> > wrote:
> >
> >> We do have “npm install -g cordova” on the front page, but I
> guess there
> >> is no clear link to
> 
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist.apache.org%2frepos%2fdist%2frelease%2fcordova%2f&data=01%7c01%7cdblotsky%40microsoft.com%7c5ec7ab5bff404293b51a08d2faae74f7%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=3DOY5UW13ODLMdOC1igajVAavJjIproR0mWP%2bL46z1E%3d
> >> anywhere. I really like that link and I think it would be great
> to have it
> >> easily accessible. I’m leaning toward the header (a bit loud)
> or the footer
> >> (a bit

[GitHub] cordova-plugin-contacts pull request: CB-8115 Save contact birthda...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/95#issuecomment-161450864
  
@vladimir-kotikov is the issue that Android saves the date in a different 
format from other platforms? If that is the case, I guess the greater issue is 
lack of consistency in the API as to how contacts are presented in the JS. That 
sounds like a separate issue to me, but one that should be addressed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-8115 Save contact birthda...

[riknoll]

Github user riknoll commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/95#discussion_r46483328
  
--- Diff: src/android/ContactAccessorSdk5.java ---
@@ -1854,6 +1859,38 @@ public boolean remove(String id) {
 return (result > 0) ? true : false;
 }
 
+/**
+ * Gets birthday date from contact JSON object
+ * @param contact an object to get birthday from
+ * @return birthday or null, it the field doesn't present in contact 
or malformed
--- End diff --

Grammar nitpick: "If the field isn't present or is malformed in the contact"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [CB-10093][android] fix failur...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/141#issuecomment-161447751
  
@sencenan Sure, go ahead and submit a new PR. Tag both JIRA's in the commit 
message (CB-10093 and CB-9960) if you don't mind.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-9590 - Ubuntu support for the new plu...

[david-barth-canonical]

Github user david-barth-canonical commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/294#discussion_r46471716
  
--- Diff: cordova-lib/src/plugman/platforms/ubuntu.js ---
@@ -29,6 +29,51 @@ function toCamelCase(str) {
 }).join('');
 }
 
+function getPluginXml(plugin_dir) {
+var et = require('elementtree'),
+fs = require('fs'),
+path = require('path');
+
+var pluginxml;
+var config_path = path.join(plugin_dir, 'plugin.xml');
+
+if (fs.existsSync(config_path)) {
+// Get the current plugin.xml file
+pluginxml = et.parse(fs.readFileSync(config_path, 'utf-8'));
+}
+ 
+return pluginxml;
+}
+
+function findClassName(pluginxml, plugin_id) {
+var class_name;
+
+// first check if we have a class-name parameter in the plugin config
+if (pluginxml) {
+   var platform = pluginxml.find("./platform/[@name='ubuntu']/");
+   if (platform) {
+   var param = 
platform.find("./config-file/[@target='config.xml']/feature/param/[@name='ubuntu-package']");
+   if (param && param.attrib) {
+   class_name = param.attrib.value;
+   return class_name;
+   }
+   }
+}
+
+// fallback to guess work, based on the plugin package name
+
+if (plugin_id.match(/\.[^.]+$/)) {
+// old-style plugin name
+class_name = plugin_id.match(/\.[^.]+$/)[0].substr(1);
+class_name = toCamelCase(class_name);
+} else {
+class_name = 
plugin_id.match(/cordova\-plugin\-([\w\-]+)$/)[0].substr(15);
--- End diff --

Thanks! I updated the branch to take that into account. I was forcing 
plugins to upgrade to adding their class name to the XML file, but there is a 
more gradual way ;)

If that PR can't be re-opened I opened 
https://github.com/apache/cordova-lib/pull/349 . Otherwise feel free to close 
this other one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: Cb 9590 - Ubuntu support for the new plu...

[david-barth-canonical]

GitHub user david-barth-canonical opened a pull request:

https://github.com/apache/cordova-lib/pull/349

Cb 9590 - Ubuntu support for the new plugin naming convention

Re-opening the pull request with hopefully a better fix that can handle all 
situations.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cordova-ubuntu/cordova-lib CB-9590

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/349.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #349


commit 187711dd7fb7cd21e9ea276239b2e8b87a9e1ee6
Author: David Barth 
Date:   2015-09-01T17:40:35Z

Ubuntu support for the new plugin naming convention

commit afde15c7e6748dfedbdd9816df199c14f2f7596e
Author: David Barth 
Date:   2015-09-04T11:41:13Z

more robust class name detection

commit 1ae6a8631a92f58020c3b0139931d784843c281e
Author: David Barth 
Date:   2015-11-03T17:13:49Z

take plugin class name from the plugin.xml to avoid class name guess work

commit 1bbf544f3f3cff709d9ee1618b585d4c57e8e62c
Author: David Barth 
Date:   2015-11-19T17:00:35Z

happier jshint

commit 877404bbcb2d84cbb9cade8e692396237cc586f3
Author: David Barth 
Date:   2015-12-02T20:18:28Z

don't crash when parsing general plugin names




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

[ochakov]

Github user ochakov commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161423854
  
riknoll,
Sounds alright. I would also check camera and storage permissions 
separately in case someone will approve one of them, but deny the other. Next 
time, only the missing one should be asked. I will commit another update for 
that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [VOTE] cordova-ubuntu 4.3.1

[David Barth]

+1

On Wed, Nov 25, 2015 at 2:33 AM, Steven Gill  wrote:

> Please review and vote on this 4.3.1 Ubuntu Release
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-10030
>
> The archive has been published to
> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10030
>
> The package was published from its corresponding git tag:
> cordova-ubuntu: 4.3.1 (745697f422)
>
> Note that you can test it out via:
>
> cordova platform add https://github.com/apache/cordova-ubuntu#4.3.1
>
> Upon a successful vote I will upload the archive to dist/ and publish it
> to npm.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and
> subdependencies have Apache-compatible licenses
>

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161423220
  
Agreed. But this PR should be updated to check the PackageInfo first. 
@ochakov does that sound alright to you?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: Added Android cookie sha...

[Sinistralis]

Github user Sinistralis commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/122#issuecomment-161420725
  
When you say you do not get cookies set, are you talking about using this 
code or default functionality? I did not test against XWalk, but I would not be 
opposed to trying it out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

[infil00p]

Github user infil00p commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161417898
  
Right, Barcode Scanner! That thing! So, if there's an app that uses the 
Barcode Scanner and takes a picture, then it can cause a problem. 

I'm still not stoked about this, but this code should probably be added.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161417577
  
Here's one that declares it: 
https://github.com/phonegap/phonegap-plugin-barcodescanner


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161416757
  
I feel like we can easily handle it, though, by programmatically checking 
if the permission was declared before we take a picture and only requesting it 
if it is (looks like it's in the 
[PackageInfo](http://developer.android.com/reference/android/content/pm/PackageInfo.html#requestedPermissions)).
 Plus, we avoid another quirk for the Android platform. Is there any danger in 
requesting that permission if some other plugin is already using it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

[infil00p]

Github user infil00p commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161416812
  
BTW: Do we have a third-party plugin that asks for Camera? And if a 
Third-Party plugin is asking for the CAMERA permission, shouldn't they have 
their own activity that actually uses the camera? This seems like a weird 
hypothetical situation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

[infil00p]

Github user infil00p commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161415816
  
@ochakov 

1. Yes, it still works, because this relies on the permission of the 
Camera, not the permission of the application firing the event.
2. If you don't declare camera permission, the result of 
cordova.hasPermission(CAMERA), assuming CAMERA is the string containing the 
Camera permission, would be false.  We shouldn't request permissions for things 
that we're not actually doing, such as taking a photo.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Deprecate cordova-wp8

[Anis KADRI]

+1

On Wed, Dec 2, 2015 at 11:32 AM Steven Gill  wrote:

> +1
>
> On Wed, Dec 2, 2015 at 11:06 AM, Jesse  wrote:
>
> > We've talked about it for awhile, but never moved on it. cordova-wp8 has
> > been a work horse that seen us through tough times but the sun is
> setting.
> >
> > cordova-windows has been a viable alternative for some time now, and
> allows
> > developers to target newer device features from wp8.1 and wp10 as well.
> > Removing the responsibility of implementing changes in this now ancient
> > code base will free many of us to focus on making the windows universal
> > workflow better.
> >
> > I would like to see this wrapped up by the end of the year, which for me
> is
> > the end of next week.
> >
> > Some suggestions of what needs to happen next :
> > - display warning message in cli when devs type `cordova platform add
> wp8`
> > ( next cordova-lib/cli release )
> > - provide a plugin-dev migration guide outlining how to leverage existing
> > C# code in a windows-universal application ( I will do this )
> > - update repos / documentation with polite wording to move on
> > - close a bunch of wp8 related issues in jira with "won't fix'
> > - put wp8 out to pasture
> >
> > What are your thoughts?
> >
> >
> > Cheers,
> >   Jesse
> >
> > @purplecabbage
> > risingj.com
> >
>

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

[infil00p]

Github user infil00p commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161414891
  
@riknoll Yeah, but that's a problem that should be in the docs, and not in 
this code. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Deprecate cordova-amazon-fireos

[Anis KADRI]

+1

On Wed, Dec 2, 2015 at 11:45 AM Joe Bowser  wrote:

> +1
>
> On Wed, Dec 2, 2015 at 11:40 AM, Steven Gill 
> wrote:
>
> > Issue for deprecation: https://issues.apache.org/jira/browse/CB-10121
> >
> > Cc'ed Archana to see if she has any concerns.
> >
> > On Wed, Dec 2, 2015 at 12:03 AM, julio cesar sanchez <
> > jcesarmob...@gmail.com
> > > wrote:
> >
> > > +1
> > >
> > > 2015-12-02 5:54 GMT+01:00 Simon MacDonald :
> > >
> > > > +1
> > > >
> > > >
> > > > Simon Mac Donald
> > > > http://hi.im/simonmacdonald
> > > >
> > > > On Tue, Dec 1, 2015 at 7:37 PM, Steven Gill 
> > > > wrote:
> > > >
> > > > > About a month ago, we received a PR[1] from amazon noting that
> users
> > > > should
> > > > > use cordova-android for amazon fireos 5.0+ devices (2015 onwards)
> and
> > > not
> > > > > cordova-amazon-fireos.
> > > > >
> > > > > Seeing how cordova-amazon-fireos hasn't had any updates in quite a
> > > > while, I
> > > > > think we should deprecate it.
> > > > >
> > > > > I'm fine leaving it on npm (with a deprecation notice), but I think
> > we
> > > > > should remove it from cordova-lib and the cli.
> > > > >
> > > > > What do we do with repos once we deprecate them? Attic?
> > > > >
> > > > > [1]
> > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/cordova-cli/commit/415e7a6b7da7122bca701c186f09eefcd1443237
> > > > >
> > > >
> > >
> >
>

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161414408
  
In the developer reference: 
http://developer.android.com/reference/android/content/pm/PackageInfo.html#requestedPermissions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161414060
  
@infil00p if a third party plugin declares the permission in their 
plugin.xml so that is inserted into the manifest, then you get a 
SecurityException and a crash. I have reproduced that behavior.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

[infil00p]

Github user infil00p commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161413648
  
You do not need the Camera permission for the Camera plugin because we use 
intents.  Why are we trying to request this permission?  That's the recommended 
way of using the Camera as per the Android Guidelines, and it's so you don't 
have to have the permission in the manifest.

I'm going to close this issue and I don't think we should accept this 
request, since we're requesting a permission that we don't actually need.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

[ochakov]

Github user ochakov commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161412438
  
I have two questions then:
1. When you do not declare camera permission in the manifest, does it work 
on older Android versions?
2. When you do not declare camera permission, what is the result of 
cordova.hasPermission(CAMERA)? We can tweak the function to request only those 
permissions for which cordova.hasPermission returns false.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Deprecate cordova-amazon-fireos

[Joe Bowser]

+1

On Wed, Dec 2, 2015 at 11:40 AM, Steven Gill  wrote:

> Issue for deprecation: https://issues.apache.org/jira/browse/CB-10121
>
> Cc'ed Archana to see if she has any concerns.
>
> On Wed, Dec 2, 2015 at 12:03 AM, julio cesar sanchez <
> jcesarmob...@gmail.com
> > wrote:
>
> > +1
> >
> > 2015-12-02 5:54 GMT+01:00 Simon MacDonald :
> >
> > > +1
> > >
> > >
> > > Simon Mac Donald
> > > http://hi.im/simonmacdonald
> > >
> > > On Tue, Dec 1, 2015 at 7:37 PM, Steven Gill 
> > > wrote:
> > >
> > > > About a month ago, we received a PR[1] from amazon noting that users
> > > should
> > > > use cordova-android for amazon fireos 5.0+ devices (2015 onwards) and
> > not
> > > > cordova-amazon-fireos.
> > > >
> > > > Seeing how cordova-amazon-fireos hasn't had any updates in quite a
> > > while, I
> > > > think we should deprecate it.
> > > >
> > > > I'm fine leaving it on npm (with a deprecation notice), but I think
> we
> > > > should remove it from cordova-lib and the cli.
> > > >
> > > > What do we do with repos once we deprecate them? Attic?
> > > >
> > > > [1]
> > > >
> > > >
> > >
> >
> https://github.com/apache/cordova-cli/commit/415e7a6b7da7122bca701c186f09eefcd1443237
> > > >
> > >
> >
>

[GitHub] cordova-android pull request: CB-10112 Parse additional CLI argume...

[stevengill]

Github user stevengill commented on the pull request:

https://github.com/apache/cordova-android/pull/241#issuecomment-161410824
  
Thanks for the quick fix!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: iOS White Listing documentation

[Steven Gill]

Send a PR please! https://github.com/apache/cordova-docs

On Wed, Dec 2, 2015 at 9:21 AM, Robert Hoffmann <
robert.hoffmann@gmail.com> wrote:

> In the 5.4.0 docs it says under iOS Whitelisting: "As above, see
> cordova-plugin-whitelist for details."
> (
> https://cordova.apache.org/docs/en/5.4.0/guide/appdev/whitelist/index.html
> )
>
> This is confusing because at first I thought this plugin (
> https://github.com/apache/cordova-plugin-whitelist) would also be
> relevant for iOS. But it is not, correct?
>
> The documentation might be clearer, maybe:
> "The iOS platform does not need the above plugin
> cordova-plugin-whitelist(Link), however its configuration details apply to
> iOS too."
>
> best regards -Robert
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

Re: [DISCUSS] Deprecate cordova-amazon-fireos

[Steven Gill]

Issue for deprecation: https://issues.apache.org/jira/browse/CB-10121

Cc'ed Archana to see if she has any concerns.

On Wed, Dec 2, 2015 at 12:03 AM, julio cesar sanchez  wrote:

> +1
>
> 2015-12-02 5:54 GMT+01:00 Simon MacDonald :
>
> > +1
> >
> >
> > Simon Mac Donald
> > http://hi.im/simonmacdonald
> >
> > On Tue, Dec 1, 2015 at 7:37 PM, Steven Gill 
> > wrote:
> >
> > > About a month ago, we received a PR[1] from amazon noting that users
> > should
> > > use cordova-android for amazon fireos 5.0+ devices (2015 onwards) and
> not
> > > cordova-amazon-fireos.
> > >
> > > Seeing how cordova-amazon-fireos hasn't had any updates in quite a
> > while, I
> > > think we should deprecate it.
> > >
> > > I'm fine leaving it on npm (with a deprecation notice), but I think we
> > > should remove it from cordova-lib and the cli.
> > >
> > > What do we do with repos once we deprecate them? Attic?
> > >
> > > [1]
> > >
> > >
> >
> https://github.com/apache/cordova-cli/commit/415e7a6b7da7122bca701c186f09eefcd1443237
> > >
> >
>

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161410634
  
BTW, I created a JIRA for this 
([CB-10120](https://issues.apache.org/jira/browse/CB-10120))


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-161410396
  
Thanks for submitting a PR! I actually just ran into this issue while 
working on [another issue in 
JIRA](https://issues.apache.org/jira/browse/CB-10064). After doing some 
research into this problem, I found that it actually only comes up if you have 
the CAMERA permission declared in your manifest (I have no idea what the 
reasoning behind this behavior is). We don't declare that permission, but third 
party plugins can insert entries into the manifest and so we still need to 
handle the case. Anyway, the question is, should we always request the camera 
permission or should we check the manifest for the permission declaration 
first? I'm leaning towards checking the manifest (we shouldn't get extra 
permissions for no reason). @infil00p thoughts on that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Deprecate cordova-wp8

[Steven Gill]

+1

On Wed, Dec 2, 2015 at 11:06 AM, Jesse  wrote:

> We've talked about it for awhile, but never moved on it. cordova-wp8 has
> been a work horse that seen us through tough times but the sun is setting.
>
> cordova-windows has been a viable alternative for some time now, and allows
> developers to target newer device features from wp8.1 and wp10 as well.
> Removing the responsibility of implementing changes in this now ancient
> code base will free many of us to focus on making the windows universal
> workflow better.
>
> I would like to see this wrapped up by the end of the year, which for me is
> the end of next week.
>
> Some suggestions of what needs to happen next :
> - display warning message in cli when devs type `cordova platform add wp8`
> ( next cordova-lib/cli release )
> - provide a plugin-dev migration guide outlining how to leverage existing
> C# code in a windows-universal application ( I will do this )
> - update repos / documentation with polite wording to move on
> - close a bunch of wp8 related issues in jira with "won't fix'
> - put wp8 out to pasture
>
> What are your thoughts?
>
>
> Cheers,
>   Jesse
>
> @purplecabbage
> risingj.com
>

iOS White Listing documentation

[Robert Hoffmann]

In the 5.4.0 docs it says under iOS Whitelisting: "As above, see 
cordova-plugin-whitelist for details."

(https://cordova.apache.org/docs/en/5.4.0/guide/appdev/whitelist/index.html)

This is confusing because at first I thought this plugin 
(https://github.com/apache/cordova-plugin-whitelist) would also be 
relevant for iOS. But it is not, correct?


The documentation might be clearer, maybe:
"The iOS platform does not need the above plugin 
cordova-plugin-whitelist(Link), however its configuration details apply 
to iOS too."


best regards -Robert



-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[DISCUSS] Deprecate cordova-wp8

[Jesse]

We've talked about it for awhile, but never moved on it. cordova-wp8 has
been a work horse that seen us through tough times but the sun is setting.

cordova-windows has been a viable alternative for some time now, and allows
developers to target newer device features from wp8.1 and wp10 as well.
Removing the responsibility of implementing changes in this now ancient
code base will free many of us to focus on making the windows universal
workflow better.

I would like to see this wrapped up by the end of the year, which for me is
the end of next week.

Some suggestions of what needs to happen next :
- display warning message in cli when devs type `cordova platform add wp8`
( next cordova-lib/cli release )
- provide a plugin-dev migration guide outlining how to leverage existing
C# code in a windows-universal application ( I will do this )
- update repos / documentation with polite wording to move on
- close a bunch of wp8 related issues in jira with "won't fix'
- put wp8 out to pasture

What are your thoughts?


Cheers,
  Jesse

@purplecabbage
risingj.com

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

[Steven Gill]

Okay sweet. Can you add a +1 on the vote thread that is open for Ubuntu. We
need one other committer to give a +1 so I can wrapnit up and publish
On Dec 2, 2015 10:47 AM, "David Barth"  wrote:

> On Tue, Dec 1, 2015 at 10:01 PM, Steven Gill 
> wrote:
>
> > Which raw api changes to cordova@5.3.x make it unusable with ubuntu? As
> > far
> > as I know, cordova-ubuntu should work the same with cordova@4.x and
> > cordova@5.x. The platform API changes aren't necessary to work with
> > cordova@5.x
> >
>
> It worked for most commands, except with options like build --device. This
> is now fixed in 5.4 thanks to the recent cordova-lib commit.
>
>
> >
> > We probably won't do a update to cordova@4.x unless a security concern
> > comes up.
> >
>
> Ok, makes sense. Anyway, I have a distro-patched version available in an
> Ubuntu PPA (personal archive) at :
> https://launchpad.net/~cordova-ubuntu/+archive/ubuntu/ppa, for people who
> want a quick start for Ubuntu only.
>
> I imagine it will be resolved by next month, and then I can propose a
> debian package with cordova-cli 5 or 6 as well.
>
>
> > Good idea to improve CB-9590. We are hoping to get cordova@6 out next
> week
> > sometime. If we can get the fixes in by then, great!
> >
>
> Ok
>
>
> >
> > Let me know how cordova-ubuntu@4.3.1 works with cordova-lib (master). If
> > thinks look good, we should get you and one other person to vote on the
> > vote thread for cordova-ubuntu so I can officially release it on npm.
> >
>
> I have finally been able to test with both cordova-cli @4.3.1 and master,
> ie 5.4.1 as published in npm, all from a clean VM running 14.04.2 LTS, to:
>
> platform add ubuntu
> build --device
> run --device
>
> It is still not super pretty but there are no regressions and bugs are
> fixed.
>
> So I would vote +1 for that cordova-ubuntu@4.3.1 to go in npm.
>
> David
>

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

[David Barth]

On Tue, Dec 1, 2015 at 10:01 PM, Steven Gill  wrote:

> Which raw api changes to cordova@5.3.x make it unusable with ubuntu? As
> far
> as I know, cordova-ubuntu should work the same with cordova@4.x and
> cordova@5.x. The platform API changes aren't necessary to work with
> cordova@5.x
>

It worked for most commands, except with options like build --device. This
is now fixed in 5.4 thanks to the recent cordova-lib commit.


>
> We probably won't do a update to cordova@4.x unless a security concern
> comes up.
>

Ok, makes sense. Anyway, I have a distro-patched version available in an
Ubuntu PPA (personal archive) at :
https://launchpad.net/~cordova-ubuntu/+archive/ubuntu/ppa, for people who
want a quick start for Ubuntu only.

I imagine it will be resolved by next month, and then I can propose a
debian package with cordova-cli 5 or 6 as well.


> Good idea to improve CB-9590. We are hoping to get cordova@6 out next week
> sometime. If we can get the fixes in by then, great!
>

Ok


>
> Let me know how cordova-ubuntu@4.3.1 works with cordova-lib (master). If
> thinks look good, we should get you and one other person to vote on the
> vote thread for cordova-ubuntu so I can officially release it on npm.
>

I have finally been able to test with both cordova-cli @4.3.1 and master,
ie 5.4.1 as published in npm, all from a clean VM running 14.04.2 LTS, to:

platform add ubuntu
build --device
run --device

It is still not super pretty but there are no regressions and bugs are
fixed.

So I would vote +1 for that cordova-ubuntu@4.3.1 to go in npm.

David

[GitHub] cordova-plugin-camera pull request: [CB-10093][android] fix failur...

[purplecabbage]

Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/141#issuecomment-161393743
  
Just make sure your name is on your github profile, which it appears to be. 
:+1: 
We just needed the name at https://github.com/sencenan to also appear at 
https://people.apache.org/committer-index.html so we can cross reference.
Looks good, thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: CB-8641 Some file-trans...

[dblotsky]

Github user dblotsky commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r46454382
  
--- Diff: src/windows/FileTransferProxy.js ---
@@ -49,6 +49,17 @@ function nativePathToCordova(path) {
 return String(path).replace(/\\/g, '/');
 }
 
+function alreadyCancelled(opId, errorCb, filePath, server) {
+var op = fileTransferOps[opId];
+if (op && op.state === FileTransferOperation.CANCELLED) {
+// Here we should call errorCB with ABORT_ERR error
+errorCb(new FTErr(FTErr.ABORT_ERR, nativePathToCordova(filePath), 
server));
--- End diff --

This side effect should not be part of the function. Please place it 
outside, into the calling code. It will be duplicated, but that is still 
somewhat OK; it's definitely better than someone calling if 
`alreadyCancelled()` twice in a row and getting their callback called twice.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-8115 Save contact birthda...

[dblotsky]

Github user dblotsky commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/95#issuecomment-161391018
  
Is it possible to check by loading the contact and comparing the date in a 
human-readable format with a fixed string like `"16-May-1984"`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [CB-10093][android] fix failur...

[sencenan]

Github user sencenan commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/141#issuecomment-161390659
  
How would I associate my full name with my github id? I also fixed the 
problem with Google Photos which touches the same area of code. Should I remove 
this pull request and submit a new one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-10039 Accept relative pat...

[dblotsky]

Github user dblotsky commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/94#issuecomment-161388988
  
Thanks! The change looks much cleaner now. How are this PR and #77 related? 
Will they both be merged in?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-8917: adding docs for Android lifecy...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/428


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-9348 Fetch phoneNumbers a...

[dblotsky]

Github user dblotsky commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/88#issuecomment-161387695
  
I don't understand: so what is the bug, and how are we fixing it? I don't 
have a lot of context on this. Or if we have someone else with a lot of 
knowledge on contacts, just get them to review this and don't mind me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/239


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-9827 Implement and expose PlatformApi...

[sgrebnov]

Github user sgrebnov commented on the pull request:

https://github.com/apache/cordova-ios/pull/176#issuecomment-161378270
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: CB-8641 Some file-trans...

[jasongin]

Github user jasongin commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r46446244
  
--- Diff: tests/tests.js ---
@@ -29,6 +29,7 @@ exports.defineAutoTests = function () {
 
 // constants
 var GRACE_TIME_DELTA = 600; // in milliseconds
+var WINDOWS_GRACE_TIME_DELTA = 3500; // in milliseconds; NOTE: Some 
Windows Phone 8.1 devices need a few seconds to create an upload operation.
--- End diff --

Are you sure it is only WP 8.1? What about Windows 10 mobile or desktop?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: CB-8641 Some file-trans...

[jasongin]

Github user jasongin commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r46445757
  
--- Diff: README.md ---
@@ -230,6 +230,10 @@ __Parameters__:
 
 - Download requests is being cached by native implementation. To avoid 
caching, pass `if-Modified-Since` header to download method.
 
+### Windows Quirks
+
+- Usage of 
[BackgroundDownloader](https://msdn.microsoft.com/en-us/library/windows/apps/windows.networking.backgroundtransfer.backgrounddownloader.aspx)
 entails the latency issues on Windows Phone. You can use XHR or 
[HttpClient](https://msdn.microsoft.com/en-us/library/windows/apps/windows.web.http.httpclient.aspx)
 as a quicker alternative for small downloads.
--- End diff --

Just "Windows", not "Windows Phone". I'm pretty sure this is not a 
phone-only issue since the APIs are the same on Windows desktop.

Also, is the reader going to understand what the "latency issues" are, or 
does it need more explanation here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: ionic pluginFixing issues on An...

[lucViana]

GitHub user lucViana opened a pull request:

https://github.com/apache/cordova-plugin-media/pull/77

ionic pluginFixing issues on Android 6.0



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lucViana/cordova-plugin-media master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-media/pull/77.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #77


commit b6da930531d556e5541dade40d9ba679694c951b
Author: Lucas Viana 
Date:   2015-12-02T17:03:23Z

Fixing issues on Android 6.0




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Where to download Cordova shell tools?

[Robert Hoffmann]

Thank you for these links!

Please find below some thoughts... maybe they can help you make the 
documentation and user experience for dummies like me even better :)


In hindsight "npm install cordova-android" seems obvious, but I would 
not have guessed it. Especially because I want to be confident about the 
version I am using.



1) So it is good to know where I can get stable but also previous releases:

1a) Using GitHub e.g. https://github.com/apache/cordova-android

1b) https://dist.apache.org/repos/dist/release/cordova


2) Download section

IMHO, from a user (not contributor) perspective a download section 
should basically list Platforms, Plugins, Other (like the Contribute 
page)... but omit the Apache link and instead provide a link to npm (or 
a popup with the command 'npm install cordova-android' to copy)


In other words: GitHub for power users. And npm for convenience.

And I would put Download in the top menu left of Contribute, because you 
surely have more downloading users than contributing users.



3) Then "{Platform} Shell Tool Guide" sections in the documentation 
could point to this download section instead of just cordova.apache.org.


Dealing with shell tools seems unavoidable (e.g. for many plugins) so 
they 'deserve' more emphasis.



4) Generally there is this balancing between cli and shell tools, which 
took me some time to grasp. The fact that cli is a shell tool too did 
not help ;)


Maybe "Power Tools" would be a more appropriate?


5) Regarding GitHub

Could you recommend to git clone cordova-android specifically for one 
app project? And then just update it with (git pull) when needed? 
Following with a project update (i.e. "cordova-android/bin/update")



Thank you and best regards,
Robert



On 02/12/15 02:16, Steven Gill wrote:
Sure. But for the example above, where someone wants cordova-android 
(especially with the new platform API), we are going to see more 
people wanting to require('cordova-android'). We should atleast 
provide links to our official download distributions on our site. If 
not on the contributions page, somewhere else. Maybe the repos that 
aren't published to npm just don't get the link?


Another example, how does someone figure out how to install plugman 
currently?



On Tue, Dec 1, 2015 at 5:12 PM, Dmitry Blotsky > wrote:


Footer sounds good to me.

I’m not a fan of adding NPM links for two reasons though:
1). Not every repo should be installed manually via NPM
2). The information on the NPM page is already shown on GitHub

Kindly,
Dmitry

> On Dec 1, 2015, at 4:20 PM, Steven Gill mailto:stevengil...@gmail.com>> wrote:
>
> I'd say footer as most of our users aren't going to use dist.
>
> I think it is worth adding the npm links for all of our repos at
>

https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fcordova.apache.org%2fcontribute%2f&data=01%7c01%7cdblotsky%40microsoft.com%7c5ec7ab5bff404293b51a08d2faae74f7%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=CN9fj7oBBdz9NjcPtMg9lBwmoGWoR1ckyfdzwvKnDGw%3d
beside the github and apache git repo
> links.
>
> On Tue, Dec 1, 2015 at 3:59 PM, Dmitry Blotsky
mailto:dblot...@microsoft.com>>
> wrote:
>
>> We do have “npm install -g cordova” on the front page, but I
guess there
>> is no clear link to

https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist.apache.org%2frepos%2fdist%2frelease%2fcordova%2f&data=01%7c01%7cdblotsky%40microsoft.com%7c5ec7ab5bff404293b51a08d2faae74f7%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=3DOY5UW13ODLMdOC1igajVAavJjIproR0mWP%2bL46z1E%3d
>> anywhere. I really like that link and I think it would be great
to have it
>> easily accessible. I’m leaning toward the header (a bit loud)
or the footer
>> (a bit hard to find). Where do you folks think it should go?
>>
>> Kindly,
>> Dmitry
>>
>> On Dec 1, 2015, at 2:12 PM, Steven Gill mailto:stevengil...@gmail.com>> stevengil...@gmail.com >> wrote:
>>
>> If you want cordova-android, you can download it from
github[1], npm[2] or
>> apache dist[3].
>>
>> We need to add links to npm + dist on the website. Any thoughts
where we
>> should add them? Maybe we should add a download section.
>>
>> [1] https://github.com/apache/cordova-android
>> [2]
>>

https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fwww.npmjs.com%2fpackage%2fcordova-android&data=01%7c01%7cdblotsky%40microsoft.com%7c8b5b6e4b8fa2407e1ec208d2fa9c8e90%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=GGHnAI%2f5yayUamaOj8SMXpoE1DhmGPAt59g8r9yI2JE%3d
>> [3]
>>

https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist.apache.org%2frepos%2fdist%2frelease%2fcordova%2f&data=01%7c01%7cdblotsky%40microsoft.com%7c8b5b6e4b8fa2407e1ec208d2fa9c8e90%7c72f988bf86f141af91ab2d7cd011d

[GitHub] cordova-ios pull request: CB-9827 Implement and expose PlatformApi...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-ios/pull/176#issuecomment-161331277
  
No objections from my side. The PR has passed internal review, all CR notes 
has been addressed. @sgrebnov?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10112 Parse additional CLI argume...

[vladimir-kotikov]

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-android/pull/241

CB-10112 Parse additional CLI arguments properly

This fixes [CB-10112](https://issues.apache.org/jira/browse/CB-10112) by 
updating `build.js` to take an addtional platform options (passed behing `--`) 
from correct options object 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-android CB-10112

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/241.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #241


commit e2a7370ede82733164f903ff2130055e05bd5e20
Author: Vladimir Kotikov 
Date:   2015-12-02T14:46:44Z

CB-10112 Parse additional CLI arguments properly




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

[Carlos Santana]

visual inspection looks good, and only touches ubuntu specific code.
Go ahead and merge it.


On Wed, Dec 2, 2015 at 6:56 AM David Barth 
wrote:

> On Wed, Dec 2, 2015 at 4:38 AM, Carlos Santana 
> wrote:
>
> > David do we need to have the CB-9618 fix in cordova-lib before continuing
> > vote?
> >
>
> Not strictly speaking. You can manage to prep, build and run an app on
> Ubuntu if you add some symlinks or fake icon file to pass the check.
>
>
> > If that so, do you think you have PR ready soon to review and get into
> > master to be able to have a cli that support new ubuntu 4.3.1
> >
>
> In any case, I have re-opened a pull request with the change:
> https://github.com/apache/cordova-lib/pull/347 We can see that in
> parallel.
>
> David
>
>
> > On Tue, Dec 1, 2015 at 4:02 PM Steven Gill 
> wrote:
> >
> > > Which raw api changes to cordova@5.3.x make it unusable with ubuntu?
> As
> > > far
> > > as I know, cordova-ubuntu should work the same with cordova@4.x and
> > > cordova@5.x. The platform API changes aren't necessary to work with
> > > cordova@5.x
> > >
> > > We probably won't do a update to cordova@4.x unless a security concern
> > > comes up.
> > >
> > > Good idea to improve CB-9590. We are hoping to get cordova@6 out next
> > week
> > > sometime. If we can get the fixes in by then, great!
> > >
> > > Let me know how cordova-ubuntu@4.3.1 works with cordova-lib (master).
> If
> > > thinks look good, we should get you and one other person to vote on the
> > > vote thread for cordova-ubuntu so I can officially release it on npm.
> > >
> > > When making changes to cordova-lib, make sure to send them as PRs still
> > so
> > > people can review them. Especially if the change can possible affect
> > other
> > > platforms.
> > >
> > >
> > >
> > >
> > >
> > > On Tue, Dec 1, 2015 at 9:08 AM, David Barth  >
> > > wrote:
> > >
> > > > Re-doing a round of testing right now.
> > > >
> > > > But, to be frank that icon fix in cordova-lib is quite needed,
> > otherwise
> > > > the icon "errors" make it unnecessarily complicated to prepare a
> > project
> > > > for building. ie
> > > > https://github.com/cordova-ubuntu/cordova-lib/commits/CB-9618
> > > >
> > > > At the very least I wanted cordova-ubuntu-4.3.1 to be compatible with
> > > > cordova@4.3.1 and pin the 2 releases together if that's still
> > possible.
> > > > Being fully compatible with the newest cordova@5.3.x is still on my
> > todo
> > > > list, because of the raw api changes.
> > > >
> > > > I'll be improving
> > > > https://github.com/cordova-ubuntu/cordova-lib/commits/CB-9590 just
> > next
> > > > based on the last PR comment.
> > > >
> > > > David
> > > >
> > > > On Tue, Dec 1, 2015 at 2:23 AM, Steven Gill 
> > > > wrote:
> > > >
> > > > > bump. Vote thread is going and needs two votes. David can you test
> it
> > > > with
> > > > > master cli and confirm it is all working?
> > > > >
> > > > > On Tue, Nov 24, 2015 at 5:31 PM, Steven Gill <
> stevengil...@gmail.com
> > >
> > > > > wrote:
> > > > >
> > > > > > Starting the vote for this
> > > > > >
> > > > > > On Tue, Nov 17, 2015 at 9:31 AM, David Barth <
> > > > david.ba...@canonical.com>
> > > > > > wrote:
> > > > > >
> > > > > >> Hey,
> > > > > >>
> > > > > >> I would like to update the 4.x series of cordova-ubuntu with a
> > > couple
> > > > of
> > > > > >> fixes, and make it the last in the series supporting the
> > cordova-cli
> > > > > 4.3.1
> > > > > >> branch as well
> > > > > >>
> > > > > >>- Cb 9868 - Should propose to install missing Ubuntu
> > dependencies
> > > > on
> > > > > >>platform add <
> > > > > https://github.com/cordova-ubuntu/cordova-ubuntu/pull/4>
> > > > > >>- Cb 9694 - Add support for HTTP urls
> > > > > >>
> > > > > >>- Cb 9806 - Add icon to project defaults
> > > > > >>
> > > > > >>
> > > > > >> So here is the traditional:
> > > > > >>
> > > > > >> Does anyone have any reason to delay a cordova-ubuntu platform
> > > > release?
> > > > > >> Any outstanding patches to land?
> > > > > >>
> > > > > >> If not, I will start the release tomorrow.
> > > > > >>
> > > > > >> David
> > > > > >>
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Re: [NOTICE] David Barth has become a committer

[Carlos Santana]

There is no Ubuntu simulator/emulator?
I think I tried to look for one but didn't find. Then I was looking for a
cheap phone for testing and was not able to find one that I could buy
locally.
Any lottery process to get a Free Ubuntu Phone for dev/testing? :-)

On Wed, Dec 2, 2015 at 4:58 AM David Barth 
wrote:

> Thanks everyone for the kind welcome messages.
>
> Yeah, Ubuntu is here, either as a host platform for cordova-android or as a
> target with cordova-ubuntu (desktop, device or as a converged platform). So
> let me know if you have questions or issues you'd like me to look at.
>
> David
>
> On Wed, Dec 2, 2015 at 5:23 AM, Carlos Santana 
> wrote:
>
> > Great idea Steve to do the announcements here. A lot of benefits I think
> > come out of it.
> >
> > Welcome David !  Ubuntu is back !!
> >
> >
> > On Tue, Dec 1, 2015 at 4:31 PM Ryan J. Salva 
> wrote:
> >
> > > Congratulations and welcome, David!
> > >
> > >
> > >
> > > Ryan J. Salva  |  Principal Program Manager Lead
> > > Visual Studio Tools for Apache Cordova
> > > rsa...@microsoft.com
> > > 425 706 5270 office
> > > 206 612 5079 mobile
> > >
> > > Has someone helped you today? Let them (and their manager) know with
> > Kudos.
> > >
> > > 
> > > From: Jesse 
> > > Sent: Tuesday, December 1, 2015 1:04 PM
> > > To: dev@cordova.apache.org
> > > Subject: Re: [NOTICE] David Barth has become a committer
> > >
> > > Congrats and welcome David!
> > >
> > >
> > > @purplecabbage
> > >
> > >
> >
> https://na01.safelinks.protection.outlook.com/?url=risingj.com&data=01%7c01%7crsalva%40microsoft.com%7c7473b4c746db438ffa6508d2fa931136%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=j9utNOtN6Kv84TbpyhCbaSbLX5z7J4KEQw5g41V3TMw%3d
> > >
> > > On Tue, Dec 1, 2015 at 1:03 PM, Steven Gill 
> > > wrote:
> > >
> > > > Hey everyone!
> > > >
> > > > Just wanted to start sending out notices to the dev mailing list when
> > we
> > > > accept a new committer.
> > > >
> > > > David Barth from Canonical has recently been voted in as a committer!
> > He
> > > is
> > > > primarily working on cordova-ubuntu.
> > > >
> > > > Congrats!
> > > >
> > > > Cheers,
> > > > -Steve
> > > >
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > >
> > >
> >
>

Re: [DISCUSS] cordova-ios-4.x release (for real)

[Carlos Santana]

I'm guessing "pending" is the same as skipping the test.
I'm guessing WKWebView doesn't support Web SQL, but window.openDatabase
exist but it doesn't do anything?
I ask because I only saw the pending for wkwebview spec.18 for using it,
not for spec.9 where it checks that exists.
Anyway after all questions, why the we are still testing for storage APIs?
Cordova doesn't supported code to provide this storage APIs.
I think we should remove the storage tests all together, this is
webview/browser testing space.

As for local xhr, is the problem only with specifying "../" relative path
in the xhr url and not local resources?
I see that doing xhr "index.html" that's a local resource and it works, and
also "./" also passes.
Aren't all this relative paths transform into full urls, and they will have
file:// in the final path used?
This means that xhr "folder1/data.json" works, but xhr
"../someparent/data.json" doesn't?


On Wed, Dec 2, 2015 at 4:52 AM Shazron  wrote:

> Marked the two known failures as pending. Now everything is green (and
> yellow) across the board for UIWebView and WKWebView.
>
> On Tue, Dec 1, 2015 at 11:49 PM, Jesse  wrote:
> >>> Or should I just let it fail still?
> > It depends how long it'll be until we fix them.  The build will be broken
> > in the CI until it is fixed so probably marking them as pending is the
> > better option.
> >
> >
> > @purplecabbage
> > risingj.com
> >
> > On Tue, Dec 1, 2015 at 10:42 PM, Shazron  wrote:
> >
> >> Couldn't wait. All file-transfer specs now pass for uiwebview and
> >> wkwebview.
> >>
> >> For those two WKWebView tests that are failing, but are expected to
> >> fail -- I'll try to modify the tests to mark the test as pending if
> >> the platform is iOS and the WKWebView bridge is found.
> >>
> >> Or should I just let it fail still?
> >>
> >> On Tue, Dec 1, 2015 at 9:49 PM, Shazron  wrote:
> >> > Thanks! - yeah after I posted it, of course I realized it is all open
> >> > source (duh) and I can run a local server or throw it on a
> >> > digitalocean instance or something :)
> >> > I'll do that tomorrow...
> >> >
> >> > On Tue, Dec 1, 2015 at 9:24 PM, Carlos Santana 
> >> wrote:
> >> >> For a second I read "the bar is clear", but then I went to my fridge
> and
> >> >> saw I still have some beer left :-)
> >> >>
> >> >> How long before the INFRA provides the VM for the file transfer, I
> >> looked
> >> >> the JIRA and it mentioned something like "complete" and "we are in
> >> holding
> >> >> because of capacity" in the same comment, and I was like stupid
> because
> >> I
> >> >> didn't understand :-(
> >> >>
> >> >> If it's going to take a long time, can we do the test with a local
> >> machine
> >> >> and vet that it works?
> >> >>
> >> >> For local xhr loading, I left a comment in the JIRA.  I don't think
> it's
> >> >> need it but I'm curios on how local xhr loading works when fetching
> >> normal
> >> >> files on a web app, meaning dynamically loading js, css, html in SPA
> >> using
> >> >> a typical js framework like angular, etc..
> >> >>
> >> >> Platform API is [5], I think is nice to have but not required for the
> >> 4.0
> >> >> release.
> >> >>
> >> >> Oh by the way GREAT PROGRESS !!! and I cheers , I'm having a beer
> now.
> >> >>
> >> >>
> >> >>
> >> >> On Tue, Dec 1, 2015 at 8:38 PM Shazron  wrote:
> >> >>
> >> >>> The board is almost clear [1].
> >> >>>
> >> >>> UIWebView mobile-spec passes, just waiting for INFRA-10831 [2] for
> the
> >> >>> file-transfer tests.
> >> >>> Ditto for WKWebView, it essentially just fails two tests, which are
> >> >>> expected [3]
> >> >>> (filed a feature request issue [4] for local xhr loading, if
> needed).
> >> >>>
> >> >>> Platform API [4] could go in this release as well, what do you
> think?
> >> >>>
> >> >>> ---
> >> >>>
> >> >>> [1]
> https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=76
> >> >>> [2] https://issues.apache.org/jira/browse/INFRA-10831
> >> >>> [3]
> >> >>>
> >>
> https://issues.apache.org/jira/browse/CB-7287?focusedCommentId=15034831&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15034831
> >> >>> [4] https://issues.apache.org/jira/browse/CB-10109
> >> >>> [5] https://github.com/apache/cordova-ios/pull/176
> >> >>>
> >> >>>
> -
> >> >>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> >> >>> For additional commands, e-mail: dev-h...@cordova.apache.org
> >> >>>
> >> >>>
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> >> For additional commands, e-mail: dev-h...@cordova.apache.org
> >>
> >>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[GitHub] cordova-lib pull request: CB-10108 Fixes android frameworks instal...

[vladimir-kotikov]

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-lib/pull/348

CB-10108 Fixes android frameworks installation/removal

This fixes [CB-10108](https://issues.apache.org/jira/browse/CB-10108)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-lib CB-10108

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/348.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #348


commit 498ea7de8c711a87db8945ac682793beae79f63e
Author: Vladimir Kotikov 
Date:   2015-12-02T13:35:46Z

CB-10108 Fixes android frameworks installation/removal




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: CB-8641 Some file-trans...

[daserge]

Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/118#issuecomment-161286724
  
@dblotsky, could you please review once more?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-8115 Save contact birthda...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/95#issuecomment-161271526
  
I think this is not possible to cover this issue with our automated tests, 
because, strictly speaking, the plugin code stores and reads birthdays 
correctly - Android just requires that the date should be stored as a string in 
[ISO format](http://dotat.at/tmp/ISO_8601-2004_E.pdf) instead of timestamp.

IMO the only way to test this, is to manually check, if birthday is 
displayed correctly in device's phonebook.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

[David Barth]

On Wed, Dec 2, 2015 at 4:38 AM, Carlos Santana  wrote:

> David do we need to have the CB-9618 fix in cordova-lib before continuing
> vote?
>

Not strictly speaking. You can manage to prep, build and run an app on
Ubuntu if you add some symlinks or fake icon file to pass the check.


> If that so, do you think you have PR ready soon to review and get into
> master to be able to have a cli that support new ubuntu 4.3.1
>

In any case, I have re-opened a pull request with the change:
https://github.com/apache/cordova-lib/pull/347 We can see that in parallel.

David


> On Tue, Dec 1, 2015 at 4:02 PM Steven Gill  wrote:
>
> > Which raw api changes to cordova@5.3.x make it unusable with ubuntu? As
> > far
> > as I know, cordova-ubuntu should work the same with cordova@4.x and
> > cordova@5.x. The platform API changes aren't necessary to work with
> > cordova@5.x
> >
> > We probably won't do a update to cordova@4.x unless a security concern
> > comes up.
> >
> > Good idea to improve CB-9590. We are hoping to get cordova@6 out next
> week
> > sometime. If we can get the fixes in by then, great!
> >
> > Let me know how cordova-ubuntu@4.3.1 works with cordova-lib (master). If
> > thinks look good, we should get you and one other person to vote on the
> > vote thread for cordova-ubuntu so I can officially release it on npm.
> >
> > When making changes to cordova-lib, make sure to send them as PRs still
> so
> > people can review them. Especially if the change can possible affect
> other
> > platforms.
> >
> >
> >
> >
> >
> > On Tue, Dec 1, 2015 at 9:08 AM, David Barth 
> > wrote:
> >
> > > Re-doing a round of testing right now.
> > >
> > > But, to be frank that icon fix in cordova-lib is quite needed,
> otherwise
> > > the icon "errors" make it unnecessarily complicated to prepare a
> project
> > > for building. ie
> > > https://github.com/cordova-ubuntu/cordova-lib/commits/CB-9618
> > >
> > > At the very least I wanted cordova-ubuntu-4.3.1 to be compatible with
> > > cordova@4.3.1 and pin the 2 releases together if that's still
> possible.
> > > Being fully compatible with the newest cordova@5.3.x is still on my
> todo
> > > list, because of the raw api changes.
> > >
> > > I'll be improving
> > > https://github.com/cordova-ubuntu/cordova-lib/commits/CB-9590 just
> next
> > > based on the last PR comment.
> > >
> > > David
> > >
> > > On Tue, Dec 1, 2015 at 2:23 AM, Steven Gill 
> > > wrote:
> > >
> > > > bump. Vote thread is going and needs two votes. David can you test it
> > > with
> > > > master cli and confirm it is all working?
> > > >
> > > > On Tue, Nov 24, 2015 at 5:31 PM, Steven Gill  >
> > > > wrote:
> > > >
> > > > > Starting the vote for this
> > > > >
> > > > > On Tue, Nov 17, 2015 at 9:31 AM, David Barth <
> > > david.ba...@canonical.com>
> > > > > wrote:
> > > > >
> > > > >> Hey,
> > > > >>
> > > > >> I would like to update the 4.x series of cordova-ubuntu with a
> > couple
> > > of
> > > > >> fixes, and make it the last in the series supporting the
> cordova-cli
> > > > 4.3.1
> > > > >> branch as well
> > > > >>
> > > > >>- Cb 9868 - Should propose to install missing Ubuntu
> dependencies
> > > on
> > > > >>platform add <
> > > > https://github.com/cordova-ubuntu/cordova-ubuntu/pull/4>
> > > > >>- Cb 9694 - Add support for HTTP urls
> > > > >>
> > > > >>- Cb 9806 - Add icon to project defaults
> > > > >>
> > > > >>
> > > > >> So here is the traditional:
> > > > >>
> > > > >> Does anyone have any reason to delay a cordova-ubuntu platform
> > > release?
> > > > >> Any outstanding patches to land?
> > > > >>
> > > > >> If not, I will start the release tomorrow.
> > > > >>
> > > > >> David
> > > > >>
> > > > >
> > > > >
> > > >
> > >
> >
>

[GitHub] cordova-lib pull request: Cb 9618 - Icon parameter should not be r...

[david-barth-canonical]

GitHub user david-barth-canonical opened a pull request:

https://github.com/apache/cordova-lib/pull/347

Cb 9618 - Icon parameter should not be relative to the www directory on 
Ubuntu

This patch fixes a long standing issue, whereby the icon parameter in the 
app manifest was prefixed with a www directory while it is not in other parts 
of the tools or runtime.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cordova-ubuntu/cordova-lib CB-9618

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/347.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #347


commit 4aa92493c36fef07415a0d0e6690464b2d21bd51
Author: David Barth 
Date:   2015-09-07T15:38:27Z

change iconPath to be relative to the project root directory, only; ie not 
to the www sub-directory anymore

commit 67d2950d6106eaba031ece18b45cf4f8dea96f21
Author: David Barth 
Date:   2015-09-23T10:50:05Z

sync icon path lookup with the code in the manifest generation

commit 704c13d8616be9036bbcce25238ecd1a3f6731b1
Author: David Barth 
Date:   2015-10-02T13:38:36Z

don't add a leading www to the icon path when generating the desktop file




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-8115 Save contact birthda...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/95#discussion_r46402705
  
--- Diff: src/android/ContactAccessorSdk5.java ---
@@ -451,7 +452,13 @@ else if 
(mimetype.equals(CommonDataKinds.Website.CONTENT_ITEM_TYPE)
 else if 
(mimetype.equals(CommonDataKinds.Event.CONTENT_ITEM_TYPE)) {
 if (isRequired("birthday", populate) &&
 CommonDataKinds.Event.TYPE_BIRTHDAY == 
c.getInt(colEventType)) {
-contact.put("birthday", 
c.getString(colBirthday));
+
+try {
+long timestamp = 
Date.valueOf(c.getString(colBirthday)).getTime();
+contact.put("birthday", timestamp);
+} catch (IllegalArgumentException e) {
+Log.d(LOG_TAG, "Failed to get birthday for 
contact: " + e.getMessage());
+}
--- End diff --

> Also, if there is an IllegalArgumentException, a birthday won't be set at 
all; is this what we define as expected behaviour for this plugin's API?

I don't see any other appropriate options here. If there is an exception, 
this means that the date is probably malformed, and we can't convert it into a 
valid timestamp, which JS side expects to get. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10113 - Browser - Camera on...

[aliokan]

Github user aliokan commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/134#issuecomment-161247566
  
@riknoll I create a JIRA issue and change patch name and increase z-index 
value. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-10039 Accept relative pat...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/94#issuecomment-161247540
  
@dblotsky, updated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [NOTICE] David Barth has become a committer

[David Barth]

Thanks everyone for the kind welcome messages.

Yeah, Ubuntu is here, either as a host platform for cordova-android or as a
target with cordova-ubuntu (desktop, device or as a converged platform). So
let me know if you have questions or issues you'd like me to look at.

David

On Wed, Dec 2, 2015 at 5:23 AM, Carlos Santana  wrote:

> Great idea Steve to do the announcements here. A lot of benefits I think
> come out of it.
>
> Welcome David !  Ubuntu is back !!
>
>
> On Tue, Dec 1, 2015 at 4:31 PM Ryan J. Salva  wrote:
>
> > Congratulations and welcome, David!
> >
> >
> >
> > Ryan J. Salva  |  Principal Program Manager Lead
> > Visual Studio Tools for Apache Cordova
> > rsa...@microsoft.com
> > 425 706 5270 office
> > 206 612 5079 mobile
> >
> > Has someone helped you today? Let them (and their manager) know with
> Kudos.
> >
> > 
> > From: Jesse 
> > Sent: Tuesday, December 1, 2015 1:04 PM
> > To: dev@cordova.apache.org
> > Subject: Re: [NOTICE] David Barth has become a committer
> >
> > Congrats and welcome David!
> >
> >
> > @purplecabbage
> >
> >
> https://na01.safelinks.protection.outlook.com/?url=risingj.com&data=01%7c01%7crsalva%40microsoft.com%7c7473b4c746db438ffa6508d2fa931136%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=j9utNOtN6Kv84TbpyhCbaSbLX5z7J4KEQw5g41V3TMw%3d
> >
> > On Tue, Dec 1, 2015 at 1:03 PM, Steven Gill 
> > wrote:
> >
> > > Hey everyone!
> > >
> > > Just wanted to start sending out notices to the dev mailing list when
> we
> > > accept a new committer.
> > >
> > > David Barth from Canonical has recently been voted in as a committer!
> He
> > is
> > > primarily working on cordova-ubuntu.
> > >
> > > Congrats!
> > >
> > > Cheers,
> > > -Steve
> > >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>

Re: [DISCUSS] cordova-ios-4.x release (for real)

[Shazron]

Marked the two known failures as pending. Now everything is green (and
yellow) across the board for UIWebView and WKWebView.

On Tue, Dec 1, 2015 at 11:49 PM, Jesse  wrote:
>>> Or should I just let it fail still?
> It depends how long it'll be until we fix them.  The build will be broken
> in the CI until it is fixed so probably marking them as pending is the
> better option.
>
>
> @purplecabbage
> risingj.com
>
> On Tue, Dec 1, 2015 at 10:42 PM, Shazron  wrote:
>
>> Couldn't wait. All file-transfer specs now pass for uiwebview and
>> wkwebview.
>>
>> For those two WKWebView tests that are failing, but are expected to
>> fail -- I'll try to modify the tests to mark the test as pending if
>> the platform is iOS and the WKWebView bridge is found.
>>
>> Or should I just let it fail still?
>>
>> On Tue, Dec 1, 2015 at 9:49 PM, Shazron  wrote:
>> > Thanks! - yeah after I posted it, of course I realized it is all open
>> > source (duh) and I can run a local server or throw it on a
>> > digitalocean instance or something :)
>> > I'll do that tomorrow...
>> >
>> > On Tue, Dec 1, 2015 at 9:24 PM, Carlos Santana 
>> wrote:
>> >> For a second I read "the bar is clear", but then I went to my fridge and
>> >> saw I still have some beer left :-)
>> >>
>> >> How long before the INFRA provides the VM for the file transfer, I
>> looked
>> >> the JIRA and it mentioned something like "complete" and "we are in
>> holding
>> >> because of capacity" in the same comment, and I was like stupid because
>> I
>> >> didn't understand :-(
>> >>
>> >> If it's going to take a long time, can we do the test with a local
>> machine
>> >> and vet that it works?
>> >>
>> >> For local xhr loading, I left a comment in the JIRA.  I don't think it's
>> >> need it but I'm curios on how local xhr loading works when fetching
>> normal
>> >> files on a web app, meaning dynamically loading js, css, html in SPA
>> using
>> >> a typical js framework like angular, etc..
>> >>
>> >> Platform API is [5], I think is nice to have but not required for the
>> 4.0
>> >> release.
>> >>
>> >> Oh by the way GREAT PROGRESS !!! and I cheers , I'm having a beer now.
>> >>
>> >>
>> >>
>> >> On Tue, Dec 1, 2015 at 8:38 PM Shazron  wrote:
>> >>
>> >>> The board is almost clear [1].
>> >>>
>> >>> UIWebView mobile-spec passes, just waiting for INFRA-10831 [2] for the
>> >>> file-transfer tests.
>> >>> Ditto for WKWebView, it essentially just fails two tests, which are
>> >>> expected [3]
>> >>> (filed a feature request issue [4] for local xhr loading, if needed).
>> >>>
>> >>> Platform API [4] could go in this release as well, what do you think?
>> >>>
>> >>> ---
>> >>>
>> >>> [1] https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=76
>> >>> [2] https://issues.apache.org/jira/browse/INFRA-10831
>> >>> [3]
>> >>>
>> https://issues.apache.org/jira/browse/CB-7287?focusedCommentId=15034831&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15034831
>> >>> [4] https://issues.apache.org/jira/browse/CB-10109
>> >>> [5] https://github.com/apache/cordova-ios/pull/176
>> >>>
>> >>> -
>> >>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> >>> For additional commands, e-mail: dev-h...@cordova.apache.org
>> >>>
>> >>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>
>>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-9348 Fetch phoneNumbers a...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/88#issuecomment-161241738
  
> Is this bug saying that the method can't find phone numbers from linked 
contacts, or that it can't find phone numbers at all?

I wasn't able to reproduce the situation, when the main contact have a 
phone number and picked contact's `phoneNumber` is empty. The only way, i can 
repro this is to link two contacts with phone numbers into another, _third_ 
contact that _doesn't have_ a phone number.

> returning a combined contact by aggregating all contacts on the device is 
not the correct behaviour

Why it is not correct? The problem with `pickContact` is that if any 
contact have some other contact linked, native picker on iOS shows only this 
main 'unified' contact, so there is no way to get properties from linked 
contacts using 'pickContact' - the only way is to use `search`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-9348 Fetch phoneNumbers a...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/88#discussion_r46394555
  
--- Diff: README.md ---
@@ -217,6 +217,10 @@ function specified by the __contactSuccess__ parameter.
 - Windows 8
 - Windows
 
+### iOS Quirks
+
+- On iOS, contact object, passed to `contactSuccess` will also contain 
some properties, such as `phoneNumbers`, `emails` and `ims`, fetched from 
contacts, linked to one, which was picked by user. However these fields from 
linked contacts won't be saved to device's address book. This is made 
intentionally to prevent creating lots of fields duplicates in both unified and 
linked contact.
+
--- End diff --

The change fixes the behaviour of `pickContact` so it's reasonable to put 
this into iOS quirks for `pickContact`. However this possibly might affect the 
code that dealing with `save`, so IMO it is convenient to emphasise this there 
as well, so the end user won't need to search for this through the whole doc.

if you think that one of these sections is excess, i'll remove that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: Solved problem add Contact p...

[vincipop]

Github user vincipop commented on the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/77#issuecomment-161224895
  
@vladimir-kotikov, I tried out #94 and it works for me. 
Perfect,  thanks !



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Deprecate cordova-amazon-fireos

[julio cesar sanchez]

+1

2015-12-02 5:54 GMT+01:00 Simon MacDonald :

> +1
>
>
> Simon Mac Donald
> http://hi.im/simonmacdonald
>
> On Tue, Dec 1, 2015 at 7:37 PM, Steven Gill 
> wrote:
>
> > About a month ago, we received a PR[1] from amazon noting that users
> should
> > use cordova-android for amazon fireos 5.0+ devices (2015 onwards) and not
> > cordova-amazon-fireos.
> >
> > Seeing how cordova-amazon-fireos hasn't had any updates in quite a
> while, I
> > think we should deprecate it.
> >
> > I'm fine leaving it on npm (with a deprecation notice), but I think we
> > should remove it from cordova-lib and the cli.
> >
> > What do we do with repos once we deprecate them? Attic?
> >
> > [1]
> >
> >
> https://github.com/apache/cordova-cli/commit/415e7a6b7da7122bca701c186f09eefcd1443237
> >
>