[GitHub] cordova-plugin-camera pull request: CB-10113 - Browser - Camera on...
Github user shprink commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/134#issuecomment-164321840 +1 for this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...
Github user Bnaya commented on the pull request: https://github.com/apache/cordova-android/pull/239#issuecomment-164317441 The app will not crash but just restart itself without the user doing anything. The thing is that, if you want to use the picture he choose before the restart you will need another code path to handle it. the callback you gave to getPicture will not be called. You can try an just let him to select photo again, but then the app might restart soon --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...
Github user Titoine commented on the pull request: https://github.com/apache/cordova-android/pull/239#issuecomment-164317214 Ok! With your fix or in futur update, when the app crash, is the user have to launch it again or does It launch itself ? Or both of the case could happen ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...
Github user Bnaya commented on the pull request: https://github.com/apache/cordova-android/pull/239#issuecomment-164316409 @Titoine This is not a complete fix, and its not released yet There's also corresponding changes to the camera plugin this change When it will be released you will need to update your android platform and your camera plugin. For now, you can try my fix for that issue, which includes more fixes for other edge cases with the plugin https://github.com/photomania/cordova-plugin-camera/commits/prevent-crash-on-external-image-selection Note that its not rebased with the lasted code of the camera plugin but its works ok and we use if in production --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-8917: Added pending plugin callba...
Github user Titoine commented on the pull request: https://github.com/apache/cordova-android/pull/239#issuecomment-164316047 When I try my app with "Don't keep activities" on, my app crash and I have the "unfortunately MyApp has stopped" message. The app doesn't restart. Will it restart with your fix or on some devices the problem still occur ? On Wiko Cink Five with Android 4.1.2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [VOTE] cordova-plugin-inappbrowser 1.1.1 release
I vote +1, too. Hi Shazron, Thanks for fixing the bug I reported so quickly. Now, the mobile spec runs well. Please update the README.md document issue as I mentioned in another email thread, when you have a chance. Great work!! Thanks. Byoungro So SSG / DPD / Mobile Computing and Compilers Intel Corporation On 12/13/15, 11:01 AM, "Alexander Sorokin (Akvelon)" wrote: >I vote +1. > >* Verified signatures and hashes >* Verified tags >* Verified that the plugin can be added correctly to blank app >* Verified that the plugin can be built correctly on cordova-ios <4.0, =4.0, >master >* Ran manual testing of mobilespec app > >-Original Message- >From: Shazron [mailto:shaz...@apache.org] >Sent: Friday, December 11, 2015 3:14 AM >To: dev@cordova.apache.org >Subject: [VOTE] cordova-plugin-inappbrowser 1.1.1 release > >Please review and vote on the release of this plugins release by replying to >this email (and keep discussion on the DISCUSS thread) > >Release issue: >https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10187&data=01%7c01%7cv-alsoro%40microsoft.com%7c43f519dd7b2746aa620408d301c00318%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=REOoy6Z51gxvLQknd%2fPiH69J%2f60UQJ4D%2faduq%2bPxDBE%3d > >The plugins have been published to dist/dev: >https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist.apache.org%2frepos%2fdist%2fdev%2fcordova%2fCB-10187%2f&data=01%7c01%7cv-alsoro%40microsoft.com%7c43f519dd7b2746aa620408d301c00318%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=z9KflDksttj2IWIFaYzHd5LrkwB906wK5D9H0TIVvwU%3d > >The packages were published from their corresponding git tags: >cordova-plugin-inappbrowser: 1.1.1 (ce285e8e06) > >Upon a successful vote I will upload the archives to dist/, upload them to the >Plugins Registry, and post the corresponding blog post. > >Voting guidelines: >https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > >Voting will go on for a minimum of 48 hours. > >I vote +1: >* Ran coho audit-license-headers over the relevant repos >* Ran coho check-license to ensure all dependencies and subdependencies have >Apache-compatible licenses >* Ensured that the plugin could build on cordova-ios-3.9.2 and >cordova-ios-4.0.0 > >- >To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >For additional commands, e-mail: dev-h...@cordova.apache.org > > >- >To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org >For additional commands, e-mail: dev-h...@cordova.apache.org
RE: [VOTE] cordova-plugin-inappbrowser 1.1.1 release
I vote +1. * Verified signatures and hashes * Verified tags * Verified that the plugin can be added correctly to blank app * Verified that the plugin can be built correctly on cordova-ios <4.0, =4.0, master * Ran manual testing of mobilespec app -Original Message- From: Shazron [mailto:shaz...@apache.org] Sent: Friday, December 11, 2015 3:14 AM To: dev@cordova.apache.org Subject: [VOTE] cordova-plugin-inappbrowser 1.1.1 release Please review and vote on the release of this plugins release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10187&data=01%7c01%7cv-alsoro%40microsoft.com%7c43f519dd7b2746aa620408d301c00318%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=REOoy6Z51gxvLQknd%2fPiH69J%2f60UQJ4D%2faduq%2bPxDBE%3d The plugins have been published to dist/dev: https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist.apache.org%2frepos%2fdist%2fdev%2fcordova%2fCB-10187%2f&data=01%7c01%7cv-alsoro%40microsoft.com%7c43f519dd7b2746aa620408d301c00318%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=z9KflDksttj2IWIFaYzHd5LrkwB906wK5D9H0TIVvwU%3d The packages were published from their corresponding git tags: cordova-plugin-inappbrowser: 1.1.1 (ce285e8e06) Upon a successful vote I will upload the archives to dist/, upload them to the Plugins Registry, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ensured that the plugin could build on cordova-ios-3.9.2 and cordova-ios-4.0.0 - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
