[VOTE] Plugins Release! Jan 15, 2016

[Steven Gill]

Please review and vote on the release of this plugins release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-10368

The plugins have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10368/

The packages were published from their corresponding git tags:
cordova-plugin-camera: 2.1.0 (0f32b78c82)
cordova-plugin-contacts: 2.0.1 (e9bbdd299c)
cordova-plugin-device: 1.1.1 (d42fb80ca1)
cordova-plugin-file: 4.1.0 (a4aa9158c3)
cordova-plugin-file-transfer: 1.5.0 (3540af439e)
cordova-plugin-geolocation: 2.1.0 (43ceab3a92)
cordova-plugin-inappbrowser: 1.2.0 (c3ccb694d3)
cordova-plugin-media: 2.1.0 (871bf29a4a)
cordova-plugin-media-capture: 1.2.0 (1ede87258b)
cordova-plugin-network-information: 1.2.0 (b0375e549b)
cordova-plugin-splashscreen: 3.1.0 (0f4a9d3f18)
cordova-plugin-statusbar: 2.1.0 (e6e8c5be10)
cordova-plugin-test-framework: 1.1.1 (c431d1270b)
cordova-plugin-vibration: 2.1.0 (e613e2e318)
cordova-plugin-whitelist: 1.2.1 (c33ea30cf2)

Upon a successful vote I will upload the archives to dist/, upload
them to npm, post the corresponding blog post, and create apache
release tags based on these release tags.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Built mobile-spec and ran on android 6.0.1

[GitHub] cordova-coho pull request: added step to push release branches to ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-coho/pull/109


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request: added step to push release branches to ...

[stevengill]

GitHub user stevengill opened a pull request:

https://github.com/apache/cordova-coho/pull/109

added step to push release branches to apache



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stevengill/cordova-coho patch-46

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-coho/pull/109.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #109


commit 487c99794087f57976ed3c4685a759662735fc38
Author: Steve Gill 
Date:   2016-01-16T01:17:59Z

added step to push release branches to apache




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request: Update plugins-release-process.md

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-coho/pull/108


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request: Update plugins-release-process.md

[stevengill]

GitHub user stevengill opened a pull request:

https://github.com/apache/cordova-coho/pull/108

Update plugins-release-process.md



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stevengill/cordova-coho patch-45

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-coho/pull/108.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #108


commit c9666f636509b6ce9312950969650b3fbabbca58
Author: Steve Gill 
Date:   2016-01-16T01:06:04Z

Update plugins-release-process.md




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-9094: Smarter autohid...

[dpolivy]

Github user dpolivy commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-172130564
  
@daserge That PR looks reasonable to me. I might be able to work around 
this bug by setting `AutoHideSplashScreen` to `false` when it is supported on 
all of my platforms.

However, the bug that I reported with this PR still exists -- if 
`AutoHideSplashScreen` is `true` and someone calls `show()` while it is 
visible, the behavior is unexpected.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-8180: Changing method...

[infil00p]

Github user infil00p commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/136#issuecomment-172109936
  
Neat, that actually worked! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-8180: Changing method...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/136


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10367 Add meaningful names to headin...

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-docs/pull/457#issuecomment-172105070
  
@dblotsky to help review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10367 Add meaningful names to headin...

[nikhilkh]

GitHub user nikhilkh opened a pull request:

https://github.com/apache/cordova-docs/pull/457

CB-10367 Add meaningful names to heading anchors in Docs & show a link on 
hover


![image](https://cloud.githubusercontent.com/assets/2417321/12366203/8fc1c3d2-bb8e-11e5-93fa-517c19dc4246.png)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs anchorLinks

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/457.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #457


commit 9820ad9bd8ede317de6c53b9a1e94a566e2dd3de
Author: Nikhil Khandelwal 
Date:   2016-01-15T21:46:12Z

CB-10367 Add meaningful names to heading anchors in Docs & show a link icon 
on hover




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Core Plugins and Android API 23

[Simon MacDonald]

LGTM

+1

Simon Mac Donald
http://hi.im/simonmacdonald

On Fri, Jan 15, 2016 at 4:32 PM, Joe Bowser  wrote:

> Sorry, wrong PR:
> https://github.com/apache/cordova-plugin-inappbrowser/pull/136
>
> On Fri, Jan 15, 2016 at 11:42 AM, Joe Bowser  wrote:
>
> > So, what does the timeline look like for a Plugins release.  I just did a
> > major change in the InAppBrowser to fix tel: and sms: URIs so they do
> > stuff, and it'd be cool if this also made if this got looked over and
> > landed before the next release.
> >
> > https://github.com/apache/cordova-plugin-inappbrowser/pull/135
> >
> > On Thu, Jan 14, 2016 at 2:02 PM, Carlos Santana 
> > wrote:
> >
> >> I agree with final compromise, I also had a discussion with Nikhil
> during
> >> holiday break offline and understood the situation, some 3rd party
> plugins
> >> are not open source and customers/devs don't move as fast as we wish,
> but
> >> having a CLI 6 with latest plugins being backwards compatible with lower
> >> Android API is good base for developers to start upgrading.
> >>
> >>
> >> On Thu, Jan 14, 2016 at 1:23 PM Steven Gill 
> >> wrote:
> >>
> >> > Awesome! I'll kick up a discuss thread
> >> >
> >> > On Wed, Jan 13, 2016 at 5:42 PM, Richard Knoll  >
> >> > wrote:
> >> >
> >> > > Hey all,
> >> > >
> >> > > This change has been merged into the file, camera, geolocation, and
> >> > > contacts plugins (media did not actually require any change). I was
> >> able
> >> > to
> >> > > build and run mobilespec on cordova-android 4.0.0 and
> >> cordova-android's
> >> > > master. We should probably push for a plugins release soon, since
> >> there
> >> > are
> >> > > also some major bug fixes to the contacts and camera plugins that
> were
> >> > > recently pushed.
> >> > >
> >> > > Thanks,
> >> > > Richard
> >> > >
> >> > > -Original Message-
> >> > > From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com]
> >> > > Sent: Friday, January 8, 2016 12:12 PM
> >> > > To: dev@cordova.apache.org
> >> > > Subject: RE: [DISCUSS] Core Plugins and Android API 23
> >> > >
> >> > > We had a good discussion about this offline with Joe, Simon, Steve,
> >> > Jesse,
> >> > > Parashu and Jason. We came to the following agreement:
> >> > > This is a temporary fix to the plugins which we need to take to
> ensure
> >> > > Cordova 5.x tools behavior of using the edge plugins does not break
> >> for
> >> > our
> >> > > users. We will pursue the change for all the affected plugins. This
> >> will
> >> > go
> >> > > out in the next PLUGINS release which will happen before the Cordova
> >> 6.0
> >> > > release. Since this a temporary fix, we aim to remove it in 6 months
> >> > > (giving reasonable time for our user base to move to Cordova 6.x+
> >> which
> >> > > will have a better plugin version pinning mechanism).
> >> > >
> >> > > Thanks,
> >> > > Nikhil
> >> > >
> >> > > -Original Message-
> >> > > From: Simon MacDonald [mailto:simon.macdon...@gmail.com]
> >> > > Sent: Thursday, January 7, 2016 4:00 PM
> >> > > To: dev@cordova.apache.org
> >> > > Subject: Re: [DISCUSS] Core Plugins and Android API 23
> >> > >
> >> > > I'm going to play devils advocate a bit here:
> >> > >
> >> > >
> >> > > > There are valid reasons why many app developers might not be ready
> >> to
> >> > > > move to API level 23:
> >> > > >   1) They have an app which is stabilizing or in maintenance mode
> >> and
> >> > > > they don't want to risk destabilization by moving to a new major
> >> > > > Cordova version, Cordova Android platform, and Android API level.
> >> > > >
> >> > >
> >> > > If the developer is not ready to move to a new version of Cordova
> >> Android
> >> > > or the Android API would it not also follow that they shouldn't be
> >> > changing
> >> > > their plugin versions?
> >> > >
> >> > >
> >> > > >   2) They are using a 3rd-party plugin which has not yet been
> >> updated
> >> > > > to request Android permissions as required by API level 23. There
> >> are
> >> > > > probably a lot of plugins affected, since access to any of the
> >> > > > following things on Android M requires runtime permission
> requests:
> >> > > > calendar, contacts, phone, camera, microphone, location, beacons,
> >> > > sensors, SMS, storage.
> >> > > >
> >> > >
> >> > > Right, so if the 3rd party plugin they are using doesn't support
> >> Android
> >> > M
> >> > > they should either a) not upgrade or b) send a PR to the plugin
> >> > maintainer
> >> > > so everyone can benefit.
> >> > >
> >> > >
> >> > > >   3) They might not have the capacity or ability to test their app
> >> on
> >> > > > devices running Android M. Because API 23 enables the new
> >> permissions
> >> > > > model only on Android M, it requires testing on that platform.
> >> > > >
> >> > > >
> >> > > Everyone has access to the Android emulator.
> >> > >
> >> > >
> >> > > > In any of the above cases, developers might still like to benefit
> >> from
> >> > > > some of the major bug fixes in those 5 popular core plugins
> >> mentioned

Re: [DISCUSS] Core Plugins and Android API 23

[Joe Bowser]

Sorry, wrong PR:
https://github.com/apache/cordova-plugin-inappbrowser/pull/136

On Fri, Jan 15, 2016 at 11:42 AM, Joe Bowser  wrote:

> So, what does the timeline look like for a Plugins release.  I just did a
> major change in the InAppBrowser to fix tel: and sms: URIs so they do
> stuff, and it'd be cool if this also made if this got looked over and
> landed before the next release.
>
> https://github.com/apache/cordova-plugin-inappbrowser/pull/135
>
> On Thu, Jan 14, 2016 at 2:02 PM, Carlos Santana 
> wrote:
>
>> I agree with final compromise, I also had a discussion with Nikhil during
>> holiday break offline and understood the situation, some 3rd party plugins
>> are not open source and customers/devs don't move as fast as we wish, but
>> having a CLI 6 with latest plugins being backwards compatible with lower
>> Android API is good base for developers to start upgrading.
>>
>>
>> On Thu, Jan 14, 2016 at 1:23 PM Steven Gill 
>> wrote:
>>
>> > Awesome! I'll kick up a discuss thread
>> >
>> > On Wed, Jan 13, 2016 at 5:42 PM, Richard Knoll 
>> > wrote:
>> >
>> > > Hey all,
>> > >
>> > > This change has been merged into the file, camera, geolocation, and
>> > > contacts plugins (media did not actually require any change). I was
>> able
>> > to
>> > > build and run mobilespec on cordova-android 4.0.0 and
>> cordova-android's
>> > > master. We should probably push for a plugins release soon, since
>> there
>> > are
>> > > also some major bug fixes to the contacts and camera plugins that were
>> > > recently pushed.
>> > >
>> > > Thanks,
>> > > Richard
>> > >
>> > > -Original Message-
>> > > From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com]
>> > > Sent: Friday, January 8, 2016 12:12 PM
>> > > To: dev@cordova.apache.org
>> > > Subject: RE: [DISCUSS] Core Plugins and Android API 23
>> > >
>> > > We had a good discussion about this offline with Joe, Simon, Steve,
>> > Jesse,
>> > > Parashu and Jason. We came to the following agreement:
>> > > This is a temporary fix to the plugins which we need to take to ensure
>> > > Cordova 5.x tools behavior of using the edge plugins does not break
>> for
>> > our
>> > > users. We will pursue the change for all the affected plugins. This
>> will
>> > go
>> > > out in the next PLUGINS release which will happen before the Cordova
>> 6.0
>> > > release. Since this a temporary fix, we aim to remove it in 6 months
>> > > (giving reasonable time for our user base to move to Cordova 6.x+
>> which
>> > > will have a better plugin version pinning mechanism).
>> > >
>> > > Thanks,
>> > > Nikhil
>> > >
>> > > -Original Message-
>> > > From: Simon MacDonald [mailto:simon.macdon...@gmail.com]
>> > > Sent: Thursday, January 7, 2016 4:00 PM
>> > > To: dev@cordova.apache.org
>> > > Subject: Re: [DISCUSS] Core Plugins and Android API 23
>> > >
>> > > I'm going to play devils advocate a bit here:
>> > >
>> > >
>> > > > There are valid reasons why many app developers might not be ready
>> to
>> > > > move to API level 23:
>> > > >   1) They have an app which is stabilizing or in maintenance mode
>> and
>> > > > they don't want to risk destabilization by moving to a new major
>> > > > Cordova version, Cordova Android platform, and Android API level.
>> > > >
>> > >
>> > > If the developer is not ready to move to a new version of Cordova
>> Android
>> > > or the Android API would it not also follow that they shouldn't be
>> > changing
>> > > their plugin versions?
>> > >
>> > >
>> > > >   2) They are using a 3rd-party plugin which has not yet been
>> updated
>> > > > to request Android permissions as required by API level 23. There
>> are
>> > > > probably a lot of plugins affected, since access to any of the
>> > > > following things on Android M requires runtime permission requests:
>> > > > calendar, contacts, phone, camera, microphone, location, beacons,
>> > > sensors, SMS, storage.
>> > > >
>> > >
>> > > Right, so if the 3rd party plugin they are using doesn't support
>> Android
>> > M
>> > > they should either a) not upgrade or b) send a PR to the plugin
>> > maintainer
>> > > so everyone can benefit.
>> > >
>> > >
>> > > >   3) They might not have the capacity or ability to test their app
>> on
>> > > > devices running Android M. Because API 23 enables the new
>> permissions
>> > > > model only on Android M, it requires testing on that platform.
>> > > >
>> > > >
>> > > Everyone has access to the Android emulator.
>> > >
>> > >
>> > > > In any of the above cases, developers might still like to benefit
>> from
>> > > > some of the major bug fixes in those 5 popular core plugins
>> mentioned
>> > > > below. Or even if they weren't specifically looking for bug fixes,
>> it
>> > > > would be a much better experience if adding or updating one of those
>> > > > plugins would just work, rather than failing on Android. The
>> > > > explanation for the failure will not be obvious to many users, if
>> they
>> > > > overlooked the warning when installing the plugin or if the

[GitHub] cordova-plugin-inappbrowser pull request: CB-8180: Changing method...

[infil00p]

GitHub user infil00p opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/136

CB-8180: Changing methods of interception in WebViewClient class



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/infil00p/cordova-plugin-inappbrowser 
tel_uri_fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/136.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #136


commit f989ed8d7f51c05e052ce36a1faa2b0d3db8059e
Author: Joe Bowser 
Date:   2016-01-15T21:31:46Z

CB-8180: Changing methods of interception in WebViewClient class




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [Vote] Windwos 4.3.0 Release attempt 3

[Jesse]

+1

* Verified archives via `coho verify-archive`
* Verified that blank app creates correctly with platform
* Verified that blank app can be successfully built and ran
* Verified 'npm i' works


@purplecabbage
risingj.com

On Fri, Jan 15, 2016 at 4:54 AM, Alexander Sorokin (Akvelon) <
v-als...@microsoft.com> wrote:

> I vote +1.
>
> * Verified archives via `coho verify-archive`
> * Verified tags manually
> * Verified that blank app creates correctly with platform
> * Verified that blank app can be successfully built and ran
> * Verified that platform can be updated from previous version
> * Verified compatibility with core plugins (ran autotests for released
> plugin versions)
> * Verified release notes
>
> Additional checks:
> * Verified version
> * Verified line breaks
>
> Thanks,
> Alexander Sorokin
>
> -Original Message-
> From: Sergey Grebnov (Akvelon) [mailto:v-seg...@microsoft.com]
> Sent: Thursday, January 14, 2016 6:06 PM
> To: dev@cordova.apache.org
> Subject: [Vote] Windwos 4.3.0 Release attempt 3
>
> Please review and vote on this 4.3.0 Windows Release (3nd attempt) by
> replying to this email (and keep discussion on the DISCUSS thread)
>
>
>
> Release issue:
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10299&data=01%7c01%7cv-alsoro%40microsoft.com%7cb07752ea8a17434c603108d31cf447d7%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=BT8VhN3oEDVgVvHVo6KCY2m4khhI%2bSY0sazpqDbFtF0%3d
>
>
>
> The archive has been published to dist/dev:
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist.apache.org%2frepos%2fdist%2fdev%2fcordova%2fCB-10299%2f&data=01%7c01%7cv-alsoro%40microsoft.com%7cb07752ea8a17434c603108d31cf447d7%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=tAn7De5vU%2bwJ0l%2bK7NnKeWKv4MVl0YzNYRDFfZJAGFo%3d
>
>
>
> The package was published from its corresponding git tag:
>
> cordova-windows: 4.3.0 (9f3a3b0388)
>
>
>
> Note that you can test it out via:
>
>
>
> cordova platform add windows@
> https://git-wip-us.apache.org/repos/asf/cordova-windows.git#4.3.0 windows@https://git-wip-us.apache.org/repos/asf/cordova-windows.git#4.3.0>
>
>
>
> Upon a successful vote I will upload the archive to dist/, publish it to
> npm, and post the blog post.
>
>
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
>
>
> Voting will go on for a minimum of 48 hours.
>
>
>
> I vote +1:
>
> * Reviewed package diff with 4.3.0 release attempt 2 package
>
> * Created helloworld app, added platform from release package to ensure
> that package is valid
>
> * Ensured continuous build was green when repo was tagged
>
>
>
> -Sergey
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[GitHub] cordova-plugin-inappbrowser pull request: Fix for CB-8180 and CB-1...

[infil00p]

Github user infil00p closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/135


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: Fix lint warnings

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/120


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: Fix lint warnings

[infil00p]

Github user infil00p commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/120#issuecomment-172064857
  
We can't remove the lines, because it screws up the layout of the native ui 
elements.  We have to make sure that we cast these literals to integers to make 
lint happy.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Core Plugins and Android API 23

[Joe Bowser]

So, what does the timeline look like for a Plugins release.  I just did a
major change in the InAppBrowser to fix tel: and sms: URIs so they do
stuff, and it'd be cool if this also made if this got looked over and
landed before the next release.

https://github.com/apache/cordova-plugin-inappbrowser/pull/135

On Thu, Jan 14, 2016 at 2:02 PM, Carlos Santana 
wrote:

> I agree with final compromise, I also had a discussion with Nikhil during
> holiday break offline and understood the situation, some 3rd party plugins
> are not open source and customers/devs don't move as fast as we wish, but
> having a CLI 6 with latest plugins being backwards compatible with lower
> Android API is good base for developers to start upgrading.
>
>
> On Thu, Jan 14, 2016 at 1:23 PM Steven Gill 
> wrote:
>
> > Awesome! I'll kick up a discuss thread
> >
> > On Wed, Jan 13, 2016 at 5:42 PM, Richard Knoll 
> > wrote:
> >
> > > Hey all,
> > >
> > > This change has been merged into the file, camera, geolocation, and
> > > contacts plugins (media did not actually require any change). I was
> able
> > to
> > > build and run mobilespec on cordova-android 4.0.0 and cordova-android's
> > > master. We should probably push for a plugins release soon, since there
> > are
> > > also some major bug fixes to the contacts and camera plugins that were
> > > recently pushed.
> > >
> > > Thanks,
> > > Richard
> > >
> > > -Original Message-
> > > From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com]
> > > Sent: Friday, January 8, 2016 12:12 PM
> > > To: dev@cordova.apache.org
> > > Subject: RE: [DISCUSS] Core Plugins and Android API 23
> > >
> > > We had a good discussion about this offline with Joe, Simon, Steve,
> > Jesse,
> > > Parashu and Jason. We came to the following agreement:
> > > This is a temporary fix to the plugins which we need to take to ensure
> > > Cordova 5.x tools behavior of using the edge plugins does not break for
> > our
> > > users. We will pursue the change for all the affected plugins. This
> will
> > go
> > > out in the next PLUGINS release which will happen before the Cordova
> 6.0
> > > release. Since this a temporary fix, we aim to remove it in 6 months
> > > (giving reasonable time for our user base to move to Cordova 6.x+ which
> > > will have a better plugin version pinning mechanism).
> > >
> > > Thanks,
> > > Nikhil
> > >
> > > -Original Message-
> > > From: Simon MacDonald [mailto:simon.macdon...@gmail.com]
> > > Sent: Thursday, January 7, 2016 4:00 PM
> > > To: dev@cordova.apache.org
> > > Subject: Re: [DISCUSS] Core Plugins and Android API 23
> > >
> > > I'm going to play devils advocate a bit here:
> > >
> > >
> > > > There are valid reasons why many app developers might not be ready to
> > > > move to API level 23:
> > > >   1) They have an app which is stabilizing or in maintenance mode and
> > > > they don't want to risk destabilization by moving to a new major
> > > > Cordova version, Cordova Android platform, and Android API level.
> > > >
> > >
> > > If the developer is not ready to move to a new version of Cordova
> Android
> > > or the Android API would it not also follow that they shouldn't be
> > changing
> > > their plugin versions?
> > >
> > >
> > > >   2) They are using a 3rd-party plugin which has not yet been updated
> > > > to request Android permissions as required by API level 23. There are
> > > > probably a lot of plugins affected, since access to any of the
> > > > following things on Android M requires runtime permission requests:
> > > > calendar, contacts, phone, camera, microphone, location, beacons,
> > > sensors, SMS, storage.
> > > >
> > >
> > > Right, so if the 3rd party plugin they are using doesn't support
> Android
> > M
> > > they should either a) not upgrade or b) send a PR to the plugin
> > maintainer
> > > so everyone can benefit.
> > >
> > >
> > > >   3) They might not have the capacity or ability to test their app on
> > > > devices running Android M. Because API 23 enables the new permissions
> > > > model only on Android M, it requires testing on that platform.
> > > >
> > > >
> > > Everyone has access to the Android emulator.
> > >
> > >
> > > > In any of the above cases, developers might still like to benefit
> from
> > > > some of the major bug fixes in those 5 popular core plugins mentioned
> > > > below. Or even if they weren't specifically looking for bug fixes, it
> > > > would be a much better experience if adding or updating one of those
> > > > plugins would just work, rather than failing on Android. The
> > > > explanation for the failure will not be obvious to many users, if
> they
> > > > overlooked the warning when installing the plugin or if they were
> > > > using another tool to add the plugin where the warning wasn't
> surfaced.
> > > >
> > >
> > >  Seems like you are describing a tooling problem here. If the tool
> > doesn't
> > > surface the warning or allows the user to add a plugin that is
> > incompatible
> > > with the version o

[GitHub] cordova-plugin-inappbrowser pull request: Fix for CB-8180 and CB-1...

[infil00p]

GitHub user infil00p opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/135

Fix for CB-8180 and CB-10104, ids are required for layout

We need to review the URIs before the page loads, not after.  The custom 
URIs should work now.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/infil00p/cordova-plugin-inappbrowser 
custom_uri_fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/135.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #135


commit 26a656422ee99fc2b77bcc6c8ff3d4a3b3463d44
Author: Joe Bowser 
Date:   2016-01-15T19:30:11Z

Fix for CB-8180 and CB-10104, ids are required for layout




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [Vote] Windwos 4.3.0 Release attempt 3

[Alexander Sorokin (Akvelon)]

I vote +1.

* Verified archives via `coho verify-archive`
* Verified tags manually
* Verified that blank app creates correctly with platform
* Verified that blank app can be successfully built and ran
* Verified that platform can be updated from previous version
* Verified compatibility with core plugins (ran autotests for released plugin 
versions)
* Verified release notes

Additional checks:
* Verified version
* Verified line breaks

Thanks,
Alexander Sorokin

-Original Message-
From: Sergey Grebnov (Akvelon) [mailto:v-seg...@microsoft.com] 
Sent: Thursday, January 14, 2016 6:06 PM
To: dev@cordova.apache.org
Subject: [Vote] Windwos 4.3.0 Release attempt 3

Please review and vote on this 4.3.0 Windows Release (3nd attempt) by replying 
to this email (and keep discussion on the DISCUSS thread)



Release issue: 
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10299&data=01%7c01%7cv-alsoro%40microsoft.com%7cb07752ea8a17434c603108d31cf447d7%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=BT8VhN3oEDVgVvHVo6KCY2m4khhI%2bSY0sazpqDbFtF0%3d



The archive has been published to dist/dev: 
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist.apache.org%2frepos%2fdist%2fdev%2fcordova%2fCB-10299%2f&data=01%7c01%7cv-alsoro%40microsoft.com%7cb07752ea8a17434c603108d31cf447d7%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=tAn7De5vU%2bwJ0l%2bK7NnKeWKv4MVl0YzNYRDFfZJAGFo%3d



The package was published from its corresponding git tag:

cordova-windows: 4.3.0 (9f3a3b0388)



Note that you can test it out via:



cordova platform add 
windows@https://git-wip-us.apache.org/repos/asf/cordova-windows.git#4.3.0



Upon a successful vote I will upload the archive to dist/, publish it to npm, 
and post the blog post.



Voting guidelines: 
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md



Voting will go on for a minimum of 48 hours.



I vote +1:

* Reviewed package diff with 4.3.0 release attempt 2 package

* Created helloworld app, added platform from release package to ensure that 
package is valid

* Ensured continuous build was green when repo was tagged



-Sergey


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-9516 Android SplashSc...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-plugin-splashscreen/pull/75

CB-9516 Android SplashScreen - Spinner Does Not Display

[Jira issue](https://issues.apache.org/jira/browse/CB-9516)

Removes spinnerStop call from onMessage("spinner", "stop") as it is called 
when webview is shown and we are hiding spinner manually along with the 
splashscreen dialog.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-splashscreen CB-9516

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-splashscreen/pull/75.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #75


commit c6e8cdc3d184a7a2d02ffbcf8331b110ea13af31
Author: daserge 
Date:   2016-01-15T11:09:37Z

CB-9516 Android SplashScreen - Spinner Does Not Display

Removes spinnerStop call from onMessage("spinner", "stop") as it is called 
when webview is shown and we are hiding spinner manually along with the 
splashscreen dialog.
Updated the docs.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [iOS] Fixed how checks access ...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/146#issuecomment-171915964
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-8396 Add AutoHideSpla...

[sgrebnov]

Github user sgrebnov commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/74#issuecomment-171911919
  
:+1: lgtm


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-9094: Smarter autohid...

[daserge]

Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/49#issuecomment-171906631
  
@dpolivy, yes you are right. 
Could you take a look at this implemented in #74 (based on #66)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-8396 Add AutoHideSpla...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-plugin-splashscreen/pull/74

CB-8396 Add AutoHideSplashScreen logic to Android's Splashscreen

[Jira issue](https://issues.apache.org/jira/browse/CB-8396)

Also initializing the splashscreen image irrespective of firstShow because 
the splashscreen could be shown manually via navigator.splashscreen.show(); 
after exiting the app using BackButton or via navigator.app.exitApp();

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-splashscreen CB-8396

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-splashscreen/pull/74.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #74


commit c580f08c88dff8b0ce4cf103d72761a01152823a
Author: daserge 
Date:   2016-01-15T08:54:21Z

CB-8396 Add AutoHideSplashScreen logic to Android's Splashscreen

Also initializing the splashscreen image irrespective of firstShow because 
the splashscreen could be shown manually via navigator.splashscreen.show(); 
after exiting the app using BackButton or via navigator.app.exitApp();




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10234 Better error message when W...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/138


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org