[VOTE] Cordova windows 4.3.1 release

[Vladimir Kotikov (Akvelon)]

Please review and vote on this cordova-windows 4.3.1 release by replying to 
this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-10495
The archive has been published to dist/dev:  
https://dist.apache.org/repos/dist/dev/cordova/CB-10495 

The package was published from its corresponding git tag:
cordova-windows: 4.3.1 (7ce3444b2e)

Note that you can test it out via:
cordova platform add 
https://git-wip-us.apache.org/repos/asf/cordova-windows.git#4.3.1 

Upon a successful vote I will upload the archive to dist/, publish it to npm, 
and post the blog post.

Voting guidelines: 
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies have 
Apache-compatible licenses
* Created and built mobilespec app to ensure all tests are passing
* Ensured continuous build was green when repo was tagged

-
Best regards, Vladimir


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

[riknoll]

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/474#discussion_r51469779
  
--- Diff: www/docs/en/dev/plugin_ref/spec.md ---
@@ -17,700 +17,489 @@ license: >
 specific language governing permissions and limitations
 under the License.
 
-title: Plugin Specification
+title: Plugin.xml
 ---
 
-# Plugin Specification
-
-The `plugin.xml` file is an XML document in the `plugins` namespace:
-`http://apache.org/cordova/ns/plugins/1.0`. It contains a top-level
-`plugin` element that defines the plugin, and children that define the
-structure of the plugin.
-
-A sample plugin element:
+# Plugin.xml
 
-
-http://apache.org/cordova/ns/plugins/1.0;
-xmlns:android="http://schemas.android.com/apk/res/android;
-id="com.alunny.foo"
-version="1.0.2">
+Plugin.xml file defines the structure and settings required for your 
plugin. It has several elements to provide details about your plugin.
 
-## _plugin_ Element
+## plugin
 
-The `plugin` element is the plugin manifest's top-level element. It
-features the following attributes:
+  The `plugin` element is the plugin manifest's top-level element.
 
-* `xmlns` (required):
-  The plugin namespace, `http://apache.org/cordova/ns/plugins/1.0`. If
-  the document contains XML from other namespaces, such as tags to be
-  added to the `AndroidManifest.xml` file, those namespaces should
-  also be included in the top-level element.
+  Attributes(type) | Description
+   | 
+  xmlns(string) | *Required*  The plugin namespace, 
`http://apache.org/cordova/ns/plugins/1.0`. If the document contains XML from 
other namespaces, such as tags to be added to the `AndroidManifest.xml` file, 
those namespaces should also be included in the  element.
+  id(string) | *Required*  A reverse-domain style identifier for the 
plugin.
+  version(string) | *Required*  A version number for the plugin, that 
matches the following major-minor-patch style regular expression: 
`^\d+[.]\d+[.]\d+$`
 
-* `id` (required):
-  A reverse-domain style identifier for the plugin, such as
-  `com.alunny.foo`
+  Example:
+  ```
+  
+  http://apache.org/cordova/ns/plugins/1.0;
+  xmlns:android="http://schemas.android.com/apk/res/android;
+  id="com.alunny.foo"
+  version="1.0.2">
+  ```
 
-* `version` (required):
-  A version number for the plugin, that matches the following
-  major-minor-patch style regular expression:
+### engines and engine
 
-^\d+[.]\d+[.]\d+$
+  The child elements of the `` element specify versions of Apache 
Cordova-based frameworks that this plugin supports. Plugman aborts with a 
non-zero code for any plugin whose target project does not meet the engine's 
constraints. If no  tags are specified, plugman attempts to install 
into the specified cordova project directory blindly.
 
-## _engines_ and _engine_ Elements
+  Attributes(type) | Description
+   | 
+  name(string) | *Required*  Name of the engine. Here are the default 
engines that are supported :  `cordova`   `cordova-plugman` 
  `cordova-android`   `cordova-ios`   
`cordova-blackberry10`   `cordova-wp8`   `cordova-windows` 
  `android-sdk` // returns the highest Android api level installed 
  `apple-xcode` // returns the xcode version   `apple-ios` // 
returns the highest iOS version installed   `apple-osx` // returns the 
OSX version   `blackberry-ndk` // returns the native blackberry SDK 
version  You can also specify a custom framework apart from the default 
ones.
+  version(string) | *Required*  The version that your framework must 
have in order to install. It should match a major-minor-patch string conforming 
to the regular expression: `^\d+[.]\d+[.]\d+$`
+  scriptSrc(string) | **For custom frameworks only**  *Required* 
  The script file that tells plugman the version of the custom framework. 
Ideally, this file should be within the top level directory of your plugin 
directory.
+  platform(string) | **For custom frameworks only**  *Required*  
The platforms your framework supports. You may use the wildcard `*` to say 
supported for all platforms, specify multiple with a pipe character like 
`android|ios|blackberry10` or just a single platform like `android`.
 
-The child elements of the `` element specify versions of
-Apache Cordova-based frameworks that this plugin supports. An example:
+  Examples:
+  ```
+  
+
+  
+  ```
 
-
-
-
-
-
+  Engine elements may also specify fuzzy matches using '>', '>=' etc. to 
avoid repetition, and to reduce maintenance when the underlying 

[GitHub] cordova-docs pull request: Execute jekyll in the context of the bu...

[zhangkaizhao]

GitHub user zhangkaizhao opened a pull request:

https://github.com/apache/cordova-docs/pull/477

Execute jekyll in the context of the bundle

Execute jekyll in the context of the bundle because jekyll is installed by 
bundle here.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zhangkaizhao/cordova-docs master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/477.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #477


commit fd46c712fbe02b704cbe3bfd12ab3ce4cb26d8c6
Author: zhangkaizhao 
Date:   2016-02-01T19:52:33Z

Execute jekyll in the context of the bundle because jekyll is installed by 
bundle here




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: help running android native tests

[Carlos Santana]

Hi Tony your I tried your PR and now tests pass. I will merge it in


On Fri, Jan 29, 2016 at 9:37 PM Homer, Tony  wrote:

> I thought about the test some more and looked at what happens when a
> missing file is loaded.
> Normally CordovaActivity shows a dialog that exits when the user presses
> ok button.
> I think this test should check that displayError is being called with an
> appropriate message.
> To test this, I overrode displayError in the test activity (showing dialog
> is not very useful in tests).
>
> I submitted a PR with this change.
> Joe and Carlos, please let me know if you think it's a reasonable approach.
>
>
>
> On 1/29/16, 7:19 PM, "Carlos Santana"  wrote:
>
> >you are correct Homer and Joe, I figured it out the test needs some love
> >
> >I added the 
> >
> >
> >On Fri, Jan 29, 2016 at 6:58 PM Joe Bowser  wrote:
> >
> >> Yeah, it looks like the behaviour has changed since this was run.  I
> have a
> >> feeling that someone "refactored" and "cleaned up" the tests and the
> >> original intent of this test was lost.
> >>
> >> So, yeah, this should have an intent provided to it, and this test
> should
> >> fail.  The tests definitely need to be looked at again and their
> usefulness
> >> re-evaluated.
> >>
> >> On Fri, Jan 29, 2016 at 4:35 PM, Homer, Tony 
> wrote:
> >>
> >> > HtmlNotFoundTest fails for me too.
> >> >
> >> > Is it a problem that the CordovaActivity displays an error dialog?
> >> > If it is, we could override displayError in MainTestActivity.
> >> >
> >> > Maybe it's simpler than that - should the test be setting an errorUrl
> and
> >> > then asserting that the errorUrl has been loaded?
> >> > If no errorUrl is set, testActivity.getCordovaWebView().getUrl() would
> >> > still be equal to START_URL, wouldn't it?
> >> >
> >> >
> >> > In that case the current assertion should fail (and the test would
> fail).
> >> >
> >> > On 1/29/16, 5:16 PM, "Joe Bowser"  wrote:
> >> >
> >> > >Run it a few times to be sure it's failing.  This test shouldn't
> fail,
> >> but
> >> > >isn't as stable as it should be.
> >> > >
> >> > >On Fri, Jan 29, 2016, 2:41 PM Carlos Santana 
> >> > wrote:
> >> > >
> >> > >> I working on getting my environment and all test pass except for
> one
> >> > >>
> >> > >> junit.framework.AssertionFailedError
> >> > >> at
> >> >
> org.apache.cordova.test.HtmlNotFoundTest$1.run(HtmlNotFoundTest.java:36)
> >> > >> at
> >> > >>
> >> > >>
> >> >
> >>
> android.test.InstrumentationTestCase$1.run(InstrumentationTestCase.java:138)
> >> > >> at
> >> >
> android.app.Instrumentation$SyncRunnable.run(Instrumentation.java:1871)
> >> > >> at android.os.Handler.handleCallback(Handler.java:739)
> >> > >> at android.os.Handler.dispatchMessage(Handler.java:95)
> >> > >> at android.os.Looper.loop(Looper.java:135)
> >> > >> at android.app.ActivityThread.main(ActivityThread.java:5254)
> >> > >> at
> >> > >>
> >> > >>
> >> >
> >>
> com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
> >> > >> at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)
> >> > >>
> >> > >> Are the tests wrong, or my setup missing something I followed the
> >> > >> instructions in the README.md in the test folder
> >> > >>
> >> > >>
> >> > >> [1]:
> >> > https://github.com/apache/cordova-android/blob/master/test/README.md
> >> > >>
> >> >
> >>
>

[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-medic/pull/73#issuecomment-178139856
  
@dblotsky I think that medic-log and medic-run are both performed in the 
same directory (I got the `getLocaLCLI()` function from medic-run). See [this 
function](https://github.com/apache/cordova-medic/blob/master/buildbot-conf/cordova.conf#L338)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-medic/pull/73#issuecomment-178145536
  
@dblotsky addressed the synchronous `exec` calls


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

[riknoll]

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/474#discussion_r51471937
  
--- Diff: www/docs/en/dev/plugin_ref/spec.md ---
@@ -17,700 +17,489 @@ license: >
 specific language governing permissions and limitations
 under the License.
 
-title: Plugin Specification
+title: Plugin.xml
 ---
 
-# Plugin Specification
-
-The `plugin.xml` file is an XML document in the `plugins` namespace:
-`http://apache.org/cordova/ns/plugins/1.0`. It contains a top-level
-`plugin` element that defines the plugin, and children that define the
-structure of the plugin.
-
-A sample plugin element:
+# Plugin.xml
 
-
-http://apache.org/cordova/ns/plugins/1.0;
-xmlns:android="http://schemas.android.com/apk/res/android;
-id="com.alunny.foo"
-version="1.0.2">
+Plugin.xml file defines the structure and settings required for your 
plugin. It has several elements to provide details about your plugin.
 
-## _plugin_ Element
+## plugin
 
-The `plugin` element is the plugin manifest's top-level element. It
-features the following attributes:
+  The `plugin` element is the plugin manifest's top-level element.
 
-* `xmlns` (required):
-  The plugin namespace, `http://apache.org/cordova/ns/plugins/1.0`. If
-  the document contains XML from other namespaces, such as tags to be
-  added to the `AndroidManifest.xml` file, those namespaces should
-  also be included in the top-level element.
+  Attributes(type) | Description
+   | 
+  xmlns(string) | *Required*  The plugin namespace, 
`http://apache.org/cordova/ns/plugins/1.0`. If the document contains XML from 
other namespaces, such as tags to be added to the `AndroidManifest.xml` file, 
those namespaces should also be included in the  element.
+  id(string) | *Required*  A reverse-domain style identifier for the 
plugin.
+  version(string) | *Required*  A version number for the plugin, that 
matches the following major-minor-patch style regular expression: 
`^\d+[.]\d+[.]\d+$`
 
-* `id` (required):
-  A reverse-domain style identifier for the plugin, such as
-  `com.alunny.foo`
+  Example:
+  ```
+  
+  http://apache.org/cordova/ns/plugins/1.0;
+  xmlns:android="http://schemas.android.com/apk/res/android;
+  id="com.alunny.foo"
+  version="1.0.2">
+  ```
 
-* `version` (required):
-  A version number for the plugin, that matches the following
-  major-minor-patch style regular expression:
+### engines and engine
 
-^\d+[.]\d+[.]\d+$
+  The child elements of the `` element specify versions of Apache 
Cordova-based frameworks that this plugin supports. Plugman aborts with a 
non-zero code for any plugin whose target project does not meet the engine's 
constraints. If no  tags are specified, plugman attempts to install 
into the specified cordova project directory blindly.
 
-## _engines_ and _engine_ Elements
+  Attributes(type) | Description
+   | 
+  name(string) | *Required*  Name of the engine. Here are the default 
engines that are supported :  `cordova`   `cordova-plugman` 
  `cordova-android`   `cordova-ios`   
`cordova-blackberry10`   `cordova-wp8`   `cordova-windows` 
  `android-sdk` // returns the highest Android api level installed 
  `apple-xcode` // returns the xcode version   `apple-ios` // 
returns the highest iOS version installed   `apple-osx` // returns the 
OSX version   `blackberry-ndk` // returns the native blackberry SDK 
version  You can also specify a custom framework apart from the default 
ones.
+  version(string) | *Required*  The version that your framework must 
have in order to install. It should match a major-minor-patch string conforming 
to the regular expression: `^\d+[.]\d+[.]\d+$`
+  scriptSrc(string) | **For custom frameworks only**  *Required* 
  The script file that tells plugman the version of the custom framework. 
Ideally, this file should be within the top level directory of your plugin 
directory.
+  platform(string) | **For custom frameworks only**  *Required*  
The platforms your framework supports. You may use the wildcard `*` to say 
supported for all platforms, specify multiple with a pipe character like 
`android|ios|blackberry10` or just a single platform like `android`.
 
-The child elements of the `` element specify versions of
-Apache Cordova-based frameworks that this plugin supports. An example:
+  Examples:
+  ```
+  
+
+  
+  ```
 
-
-
-
-
-
+  Engine elements may also specify fuzzy matches using '>', '>=' etc. to 
avoid repetition, and to reduce maintenance when the underlying 

[GitHub] cordova-android pull request: fix HtmlNotFoundTest so that it pass...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/256


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-medic/pull/73#issuecomment-178125278
  
@nikhilkh sorry for the delay, addressing the code review now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10499 - --template should pull the la...

[dubeejw]

GitHub user dubeejw opened a pull request:

https://github.com/apache/cordova-lib/pull/372

CB-10499 - --template should pull the latest template from NPM when

version isn't specified

- Pull the latest template if no version is specified

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dubeejw/cordova-lib master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/372.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #372


commit c181d428c22983b8641e61f62bc2444924ec2c58
Author: dubeejw 
Date:   2016-02-01T20:31:26Z

CB-10499 - --template should pull the latest template from NPM when
version isn't specified

- Pull the latest template if no version is specified




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

[rakatyal]

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/474#discussion_r51471311
  
--- Diff: www/docs/en/dev/plugin_ref/spec.md ---
@@ -17,700 +17,489 @@ license: >
 specific language governing permissions and limitations
 under the License.
 
-title: Plugin Specification
+title: Plugin.xml
 ---
 
-# Plugin Specification
-
-The `plugin.xml` file is an XML document in the `plugins` namespace:
-`http://apache.org/cordova/ns/plugins/1.0`. It contains a top-level
-`plugin` element that defines the plugin, and children that define the
-structure of the plugin.
-
-A sample plugin element:
+# Plugin.xml
 
-
-http://apache.org/cordova/ns/plugins/1.0;
-xmlns:android="http://schemas.android.com/apk/res/android;
-id="com.alunny.foo"
-version="1.0.2">
+Plugin.xml file defines the structure and settings required for your 
plugin. It has several elements to provide details about your plugin.
 
-## _plugin_ Element
+## plugin
 
-The `plugin` element is the plugin manifest's top-level element. It
-features the following attributes:
+  The `plugin` element is the plugin manifest's top-level element.
 
-* `xmlns` (required):
-  The plugin namespace, `http://apache.org/cordova/ns/plugins/1.0`. If
-  the document contains XML from other namespaces, such as tags to be
-  added to the `AndroidManifest.xml` file, those namespaces should
-  also be included in the top-level element.
+  Attributes(type) | Description
+   | 
+  xmlns(string) | *Required*  The plugin namespace, 
`http://apache.org/cordova/ns/plugins/1.0`. If the document contains XML from 
other namespaces, such as tags to be added to the `AndroidManifest.xml` file, 
those namespaces should also be included in the  element.
+  id(string) | *Required*  A reverse-domain style identifier for the 
plugin.
+  version(string) | *Required*  A version number for the plugin, that 
matches the following major-minor-patch style regular expression: 
`^\d+[.]\d+[.]\d+$`
 
-* `id` (required):
-  A reverse-domain style identifier for the plugin, such as
-  `com.alunny.foo`
+  Example:
+  ```
+  
+  http://apache.org/cordova/ns/plugins/1.0;
+  xmlns:android="http://schemas.android.com/apk/res/android;
+  id="com.alunny.foo"
+  version="1.0.2">
+  ```
 
-* `version` (required):
-  A version number for the plugin, that matches the following
-  major-minor-patch style regular expression:
+### engines and engine
 
-^\d+[.]\d+[.]\d+$
+  The child elements of the `` element specify versions of Apache 
Cordova-based frameworks that this plugin supports. Plugman aborts with a 
non-zero code for any plugin whose target project does not meet the engine's 
constraints. If no  tags are specified, plugman attempts to install 
into the specified cordova project directory blindly.
 
-## _engines_ and _engine_ Elements
+  Attributes(type) | Description
+   | 
+  name(string) | *Required*  Name of the engine. Here are the default 
engines that are supported :  `cordova`   `cordova-plugman` 
  `cordova-android`   `cordova-ios`   
`cordova-blackberry10`   `cordova-wp8`   `cordova-windows` 
  `android-sdk` // returns the highest Android api level installed 
  `apple-xcode` // returns the xcode version   `apple-ios` // 
returns the highest iOS version installed   `apple-osx` // returns the 
OSX version   `blackberry-ndk` // returns the native blackberry SDK 
version  You can also specify a custom framework apart from the default 
ones.
+  version(string) | *Required*  The version that your framework must 
have in order to install. It should match a major-minor-patch string conforming 
to the regular expression: `^\d+[.]\d+[.]\d+$`
+  scriptSrc(string) | **For custom frameworks only**  *Required* 
  The script file that tells plugman the version of the custom framework. 
Ideally, this file should be within the top level directory of your plugin 
directory.
+  platform(string) | **For custom frameworks only**  *Required*  
The platforms your framework supports. You may use the wildcard `*` to say 
supported for all platforms, specify multiple with a pipe character like 
`android|ios|blackberry10` or just a single platform like `android`.
 
-The child elements of the `` element specify versions of
-Apache Cordova-based frameworks that this plugin supports. An example:
+  Examples:
+  ```
+  
+
+  
+  ```
 
-
-
-
-
-
+  Engine elements may also specify fuzzy matches using '>', '>=' etc. to 
avoid repetition, and to reduce maintenance when the underlying 

[GitHub] cordova-plugin-device pull request: Refactored deviceInfo on iOS f...

[purplecabbage]

Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-plugin-device/pull/47#issuecomment-178261450
  
lgtm! If only we could get rid of all the @'s !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10499 - --template should pull the la...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/372


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10270 android: Added back s...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/160#issuecomment-178228435
  
For reference, 
[this](https://github.com/apache/cordova-plugin-camera/commit/929733b8913311f2cfd504937268a8a1d22f4f9a)
 is the commit I mentioned.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device pull request: Refactored deviceInfo on iOS f...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-device/pull/47


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Sitemap Improvements

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/472#issuecomment-178262039
  
@nikhilkh The plugin does not support adding custom URIs to the sitemap, 
and extending it took more effort than just writing a templated config.xml.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10270 android: Added back s...

[riknoll]

GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/160

CB-10270 android: Added back support for file:// URIs to getRealPath

Our `getRealPath()` function is unable to handle `file: //` URIs, which can 
occasionally lead it to return an empty string for the result URI. These camera 
options reproduce when you select an image from the Gallery app:
```
{
destinationType: Camera.DestinationType.FILE_URI,
sourceType: Camera.PictureSourceType.PHOTOLIBRARY,
allowEdit: true,
correctOrientation: true
}
```
I believe that we used to do something similar to this, but it was removed 
at some point in the past. @infil00p do you have any idea why that was?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-camera CB-10270

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/160.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #160


commit ee06d3efb233d5404d0aeda2abe08e6fd765c7fe
Author: riknoll 
Date:   2016-01-29T23:47:00Z

CB-10270 android: Added back support for file:// URIs to getRealPath




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10499 - --template should pull the la...

[csantanapr]

GitHub user csantanapr opened a pull request:

https://github.com/apache/cordova-lib/pull/373

CB-10499 - --template should pull the latest template from NPM when

version isn't specified

- Pull the latest template if no version is specified
- Rename NPM to npm

rename github to git

This close #372

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/csantanapr/cordova-lib pr-372

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/373.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #373


commit a65333cfe490288dc5bc0ce992c88d4764872a94
Author: dubeejw 
Date:   2016-02-01T20:31:26Z

CB-10499 - --template should pull the latest template from NPM when
version isn't specified

- Pull the latest template if no version is specified
- Rename NPM to npm

rename github to git

This close #372




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10499 - --template should pull the la...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/373


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos

[Steven Gill]

Hey Vlad!

This looks great! You are using istanbul for code coverage it seems.

Why did you remove spec-cordova in your pr? Your [2]

I think it is a great idea to include this in our repos. It would be nice
to track our coverage and work on improving it.

Though I do believe it is important not to chase 100% code coverage.


On Mon, Feb 1, 2016 at 6:21 AM, Vladimir Kotikov (Akvelon) <
v-vlk...@microsoft.com> wrote:

> Hey, guys
>
> I've spent a couple of hours and have a prototype of how we can visualize,
> track and analyze code coverage for our repos.
> Here is the fork of cordova-lib repo integrated with codecov.io [1]
> (notice the coverage badge at the top of README), and a PR with some
> coverage metrics [2]. The coverage summary is placed here [3]
>
> If this proposal get accepted, I'd like to enable this feature for all our
> repos, to encourage contributors to increase current test coverage up to
> appropriate values.
>
> It'd be great if anyone could give any feedback on this
>
> [1] https://github.com/vladimir-kotikov/cordova-lib
> [2] https://github.com/vladimir-kotikov/cordova-lib/pull/2
> [3] https://codecov.io/github/vladimir-kotikov/cordova-lib
>
> -
> Best regards, Vladimir
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

Re: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos

[Jesse]

This looks good, as a metric to add.
What is the impact to our workflow? are we just adding a node dependency,
or are there other config/integration parts that we need to do?




@purplecabbage
risingj.com

On Mon, Feb 1, 2016 at 2:17 PM, Steven Gill  wrote:

> Hey Vlad!
>
> This looks great! You are using istanbul for code coverage it seems.
>
> Why did you remove spec-cordova in your pr? Your [2]
>
> I think it is a great idea to include this in our repos. It would be nice
> to track our coverage and work on improving it.
>
> Though I do believe it is important not to chase 100% code coverage.
>
>
> On Mon, Feb 1, 2016 at 6:21 AM, Vladimir Kotikov (Akvelon) <
> v-vlk...@microsoft.com> wrote:
>
> > Hey, guys
> >
> > I've spent a couple of hours and have a prototype of how we can
> visualize,
> > track and analyze code coverage for our repos.
> > Here is the fork of cordova-lib repo integrated with codecov.io [1]
> > (notice the coverage badge at the top of README), and a PR with some
> > coverage metrics [2]. The coverage summary is placed here [3]
> >
> > If this proposal get accepted, I'd like to enable this feature for all
> our
> > repos, to encourage contributors to increase current test coverage up to
> > appropriate values.
> >
> > It'd be great if anyone could give any feedback on this
> >
> > [1] https://github.com/vladimir-kotikov/cordova-lib
> > [2] https://github.com/vladimir-kotikov/cordova-lib/pull/2
> > [3] https://codecov.io/github/vladimir-kotikov/cordova-lib
> >
> > -
> > Best regards, Vladimir
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>

Re: [VOTE] Cordova windows 4.3.1 release

[Jesse]

+1

- ran coho audit-license-headers
- ran coho check-license
- ran coho verify-archive
- created project and added/ran platform, smoke test


@purplecabbage
risingj.com

On Mon, Feb 1, 2016 at 12:46 PM, Vladimir Kotikov (Akvelon) <
v-vlk...@microsoft.com> wrote:

> Please review and vote on this cordova-windows 4.3.1 release by replying
> to this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-10495
> The archive has been published to dist/dev:
> https://dist.apache.org/repos/dist/dev/cordova/CB-10495
>
> The package was published from its corresponding git tag:
> cordova-windows: 4.3.1 (7ce3444b2e)
>
> Note that you can test it out via:
> cordova platform add
> https://git-wip-us.apache.org/repos/asf/cordova-windows.git#4.3.1
>
> Upon a successful vote I will upload the archive to dist/, publish it to
> npm, and post the blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and subdependencies
> have Apache-compatible licenses
> * Created and built mobilespec app to ensure all tests are passing
> * Ensured continuous build was green when repo was tagged
>
> -
> Best regards, Vladimir
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-medic/pull/73#discussion_r51514684
  
--- Diff: medic/medic-log.js ---
@@ -69,18 +70,72 @@ function logBlackberry() {
 return;
 }
 
-function logIOS() {
-var logScriptpath = path.join("mobilespec", "platforms", "ios", 
"cordova", "console.log");
-var command = "cat " + logScriptpath;
+function logIOS(appPath) {
+// We need to print out the system log for the simulator app. In order 
to figure
+// out the path to that file, we need to find the ID of the simulator 
running
+// mobilespec
+
+// First, figure out the simulator that ran mobilespec. "cordova run"" 
just chooses
+// the last simulator in this list that starts with the word "iPhone"
+shelljs.pushd(appPath);
+
+var findSimCommand = getLocalCLI() + " run --list --emulator | grep 
^iPhone | tail -n1";
--- End diff --

The `grep` and `tail` calls won't work on the Windows build machines. Is it 
a long task to do this in JS? If it's much more difficult, we can just add some 
steps to install Unix tools on Windows for our build machine docs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Multi-level ToC Implementation

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/464#issuecomment-178269844
  
@nikhilkh that is a difficult bug to fix because it relies on knowing that 
all children of "Architecture" also don't have any URIs. It will start to have 
some pages under it very soon, so I think it's ok to have the title be empty in 
the short term.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Cordova iOS build how to enable DEBUG for #ifdef DEBUG in CDVDebug.h

[Shazron]

I'm sure you realize this is an Xcode thing. As such, Google offers
lots of info:
http://stackoverflow.com/questions/1540322/xcode-setting-gcc-preprocessor-definitions-for-different-build-configurations

by default when you build it builds for the Debug config, which has
this macro set.

If you do a `cordova build --help` you can see one of the options is
`--debug` or `--release`.



On Sun, Jan 31, 2016 at 2:41 PM, Shane MacPhillamy
 wrote:
> I'm developing a plugin for iOS Cordova. I've created an iOS Cordova 
> application project using the Cordova CLI tools. I would like to enable the 
> debug macros defined in CDVDebug.h with the -DDEBUG compiler flag. Is there a 
> way I can do this from within Xcode when I have the Cordova project open in 
> Xcode?
>
> Cheers, Shane
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10052 Expose child process' io stream...

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/369#discussion_r51511432
  
--- Diff: cordova-common/src/superspawn.js ---
@@ -113,11 +139,15 @@ exports.spawn = function(cmd, args, opts) {
 child.stdout.setEncoding('utf8');
 child.stdout.on('data', function(data) {
 capturedOut += data;
+d.notify({'stdout': data});
--- End diff --

What is `d`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10430 Allow to modify events source

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-lib/pull/370#issuecomment-178305625
  
Overriding an implementation's logging with your own sounds like a 
roundabout way to get what you need. This sounds like it's exposing internal 
events for the purposes of external debugging, which is best solved by using a 
debugger, not with a custom logging mechanism.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-medic/pull/73#issuecomment-178318882
  
I tried this on my machine and I ran into an issue where it couldn't find 
the deployed simulator because there were other non-deployed simulators 
installed. Is there a way to filter by running emulators? If now, we can still 
work around this by ensuring that there are no more than one simulators 
installed on the build machine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-10405 - Connectivity issue to Cordo...

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-medic/pull/74#issuecomment-178267638
  
Does this need to be fixed? It's an intermittent connectivity issue and 
already gets polled, so if some polls fail it's not a problem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging

[riknoll]

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-medic/pull/73#discussion_r51514920
  
--- Diff: medic/medic-log.js ---
@@ -69,18 +70,72 @@ function logBlackberry() {
 return;
 }
 
-function logIOS() {
-var logScriptpath = path.join("mobilespec", "platforms", "ios", 
"cordova", "console.log");
-var command = "cat " + logScriptpath;
+function logIOS(appPath) {
+// We need to print out the system log for the simulator app. In order 
to figure
+// out the path to that file, we need to find the ID of the simulator 
running
+// mobilespec
+
+// First, figure out the simulator that ran mobilespec. "cordova run"" 
just chooses
+// the last simulator in this list that starts with the word "iPhone"
+shelljs.pushd(appPath);
+
+var findSimCommand = getLocalCLI() + " run --list --emulator | grep 
^iPhone | tail -n1";
--- End diff --

I don't think any part of this will work on Windows. Every command is 
either Unix or OSX specific.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging

[riknoll]

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-medic/pull/73#discussion_r51514960
  
--- Diff: medic/medic-log.js ---
@@ -69,18 +70,72 @@ function logBlackberry() {
 return;
 }
 
-function logIOS() {
-var logScriptpath = path.join("mobilespec", "platforms", "ios", 
"cordova", "console.log");
-var command = "cat " + logScriptpath;
+function logIOS(appPath) {
+// We need to print out the system log for the simulator app. In order 
to figure
+// out the path to that file, we need to find the ID of the simulator 
running
+// mobilespec
+
+// First, figure out the simulator that ran mobilespec. "cordova run"" 
just chooses
+// the last simulator in this list that starts with the word "iPhone"
+shelljs.pushd(appPath);
+
+var findSimCommand = getLocalCLI() + " run --list --emulator | grep 
^iPhone | tail -n1";
--- End diff --

Why would the Windows build machines run this? It's iOS


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-medic/pull/73#issuecomment-178333571
  
@dblotsky I'm not sure; I copied `cordova run's logic for choosing the 
emulator. This does not support choosing a specific simulator, just the 
default. I'll look into ios-sim to see if it has any sort of API to get the 
running one. Otherwise, we can configure medic to always launch to a 
preconfigured simulator (say iPhone 6s) and pass that into `run` and `log` as 
flags.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-medic/pull/73#issuecomment-178267393
  
@riknoll: The value returned by `getLocalCLI()` is used after 
`shell.pushd()` is called [here][pushd] to get into the `mobilespec` app 
directory in `medic-run`, and in `medic-log` this does not happen. Sorry, this 
is was a result of my unclear coding.

[pushd]: 
https://github.com/apache/cordova-medic/blob/master/medic/medic-run.js#L389


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Cordova-Ubuntu Release

[Steven Gill]

Hey David,

I think you need to add your gpg key to dist/keys

Can you run through
https://github.com/apache/cordova-coho/blob/master/docs/setting-up-gpg.md
up to the point of adding your key to dist/keys?

I was trying to verify your archive and ran into it not being able to find
the public key.

On Wed, Jan 27, 2016 at 7:50 AM, Mefire O.  wrote:

> +1
>
> On Jan 27, 2016 7:19 AM, Steven Gill  wrote:
> +1
> On Jan 27, 2016 4:28 AM, "David Barth"  wrote:
>
> > Hi,
> >
> > I need to do another quick interim release of Cordova-Ubuntu to address a
> > significant bug with the use of a deprecated Oxide API.
> >
> > This should become cordova-ubuntu@4.3.3
> >
> > Does anyone have any reason to delay a cordova-ubuntu platform release?
> > Any outstanding patches to land?
> >
> > I am starting the release process today.
> >
> > David
> >
>

[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-medic/pull/73#issuecomment-178293314
  
@dblotsky no problem; we need to be in a cordova project for that command 
(`cordova run --list`) to work anyway, so I'll just call `pushd` here as well. 
Thanks for investigating!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-medic/pull/73#discussion_r51515589
  
--- Diff: medic/medic-log.js ---
@@ -69,18 +70,72 @@ function logBlackberry() {
 return;
 }
 
-function logIOS() {
-var logScriptpath = path.join("mobilespec", "platforms", "ios", 
"cordova", "console.log");
-var command = "cat " + logScriptpath;
+function logIOS(appPath) {
+// We need to print out the system log for the simulator app. In order 
to figure
+// out the path to that file, we need to find the ID of the simulator 
running
+// mobilespec
+
+// First, figure out the simulator that ran mobilespec. "cordova run"" 
just chooses
+// the last simulator in this list that starts with the word "iPhone"
+shelljs.pushd(appPath);
+
+var findSimCommand = getLocalCLI() + " run --list --emulator | grep 
^iPhone | tail -n1";
--- End diff --

I only just realised this. Please disregard my comment. :P


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Cordova iOS build how to enable DEBUG for #ifdef DEBUG in CDVDebug.h

[Shane MacPhillamy]

Thank you Shazron.

> On 2 Feb 2016, at 12:23 PM, Shazron  wrote:
> 
> I'm sure you realize this is an Xcode thing. As such, Google offers
> lots of info:
> http://stackoverflow.com/questions/1540322/xcode-setting-gcc-preprocessor-definitions-for-different-build-configurations
> 
> by default when you build it builds for the Debug config, which has
> this macro set.
> 
> If you do a `cordova build --help` you can see one of the options is
> `--debug` or `--release`.
> 
> 
> 
> On Sun, Jan 31, 2016 at 2:41 PM, Shane MacPhillamy
>  wrote:
>> I'm developing a plugin for iOS Cordova. I've created an iOS Cordova 
>> application project using the Cordova CLI tools. I would like to enable the 
>> debug macros defined in CDVDebug.h with the -DDEBUG compiler flag. Is there 
>> a way I can do this from within Xcode when I have the Cordova project open 
>> in Xcode?
>> 
>> Cheers, Shane
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
>> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-medic/pull/73#issuecomment-178308453
  
@dblotsky updated


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10052 Expose child process' io stream...

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-lib/pull/369#issuecomment-178308498
  
Why not return the stdout and stderr objects on which calling code can 
subscribe to the `"data"` events directly?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Can you help me test/review this commit? ( ios statusbar plugin iPad multitask )

[Carlos Santana]

Julio I tested on my iPad Air 2 used ios@4.0.1 the buttons show up, buttons
work, I can do splitview no crashes


On Mon, Feb 1, 2016 at 10:36 AM julio cesar sanchez 
wrote:

> cordova should support launch storyboards
> https://issues.apache.org/jira/browse/CB-7521
> https://issues.apache.org/jira/browse/CB-9161
>
> and "Requires full Screen" should be configurable, right now is set to true
> (this is the JIRA item that set it to true
> https://issues.apache.org/jira/browse/CB-9690, AFAIK, there nos issue for
> making it configurable )
>
>
>
> 2016-02-01 15:07 GMT+01:00 Carlos Santana :
>
> > I have an iPad that supports multitasking but it's at home, I can test it
> > tonight if no one else have gotten to it first
> >
> > You said "cordova doesn't officially support multitasking yet"  Do you
> have
> > a JIRA item describing what would be necessary to have support?
> >
> >
> > On Sun, Jan 31, 2016 at 5:15 PM julio cesar sanchez <
> > jcesarmob...@gmail.com>
> > wrote:
> >
> > > I'm trying to fix https://issues.apache.org/jira/browse/CB-10288
> > >
> > > I've tested on simulators and seems to work fine, but I don't have any
> > real
> > > iPad with multitasking support to test.
> > >
> > > As cordova doesn't officially support multitasking yet, you have to
> > follow
> > > these steps to add the support.
> > >
> > > On an empty project with ios platform (tested on cordova ios 3.9.2,
> but I
> > > think it should work on 4)
> > >
> > > Add all orientatios
> > > 
> > >
> > > add my commit of statusbar plugin
> > >
> > > cordova plugin add
> > > https://github.com/jcesarmobile/cordova-plugin-statusbar#578fa1b
> > >
> > > Open the xcode project and create a new "Launch Screen" file
> > > On the target "General" screen, set the file as "Launch Screen File"
> and
> > > uncheck "Requires full screen"
> > >
> > > I use this as the index.html but you can use your own
> > > https://gist.github.com/jcesarmobile/114fdb8b771837440752
> > >
> >
>

RE: [DISCUSS] Cordova windows 4.3.1 release

[Sergey Grebnov (Akvelon)]

+1

-Sergey

-Original Message-
From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] 
Sent: Saturday, January 30, 2016 1:23 AM
To: dev@cordova.apache.org
Subject: [DISCUSS] Cordova windows 4.3.1 release

Hi all



We're planning to do a patch release of cordova-windows (proposed version is 
4.3.1) to address some regressions.

Here is the patches to be included in this release:



  * CB-10394 Do not cache manifest file while getting package name

  * CB-10446 Windows 10 Cordova Application restart instead of resume

  * CB-10440 Add CSS color names support for BackgroundColor on Windows

  * CB-10234 Better error message when Windows10 requires 'arch' flag

  * CB-10381 fix the bug when removing a plugin with a  tag



Does anyone have any reason to delay this release? Any other patches to land?



-

Best regards, Vladimir


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Do not escape markdown code for relativ...

[mikrobi]

GitHub user mikrobi opened a pull request:

https://github.com/apache/cordova-docs/pull/476

Do not escape markdown code for relative links

The links were not clickable. The markdown code was just shown in plaintext.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mikrobi/cordova-docs patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/476.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #476


commit 27d0af0640a7eddcac5d14c95de751e1147be197
Author: Jakob Class 
Date:   2016-02-01T08:58:03Z

Do not escape markdown code for relative links

The links were not clickable. The markdown code was just shown in plaintext.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10487 WindowsStoreIdentityName sh...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/146


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10332 Android Guide Improvements

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-docs/pull/471#issuecomment-177849723
  
@riknoll, +1, makes sense


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: Fix/file locations for Chrome

[davetayls]

Github user davetayls commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/159#issuecomment-177888223
  
:+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-10456 InAppBrowser is...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/143#issuecomment-177913909
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-6702 InAppBrowser han...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/144


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-10456 InAppBrowser is...

[sgrebnov]

Github user sgrebnov closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/143


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-10441 Add auto tests ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/142


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: CB-10441 Add auto tests ...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/142#issuecomment-177913876
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10430 Allow to modify events source

[vladimir-kotikov]

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-lib/pull/370

CB-10430 Allow to modify events source

This fixes [CB-10430](https://issues.apache.org/jira/browse/CB-10430).
This change is needed to allow other tools to replace default 
`EventEmitter` instance to custom one (e.g. platform might want to replace 
default `EventEmitter` with the one provided by caller in order to pass these 
events to upstream code)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-lib CB-10430

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/370.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #370


commit 66ee6a90ad30b708c1ebcf2abf01773d8ab42c6e
Author: Vladimir Kotikov 
Date:   2016-01-12T07:56:59Z

CB-10430 Allow to modify events source




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10052 Expose child process' io stream...

[vladimir-kotikov]

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-lib/pull/369

CB-10052 Expose child process' io streams via promise progress notification

This implements [CB-10052](https://issues.apache.org/jira/browse/CB-10052).

The `superspawn.spawn` promise now emits notifications, which caller can 
subscribe to using `progress` method:

```
superspawn.spawn('adb', ['devices'])
.progress(function(data){
if (data.stderr) console.error('"adb devices" raised an error: ' + 
data.stderr);
})
.then(function(devices){
// Do something...
})
```

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-lib CB-10052

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/369.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #369


commit 5a37978e9aeeeda4f71e876299fce4358f4ed2fd
Author: Vladimir Kotikov 
Date:   2016-01-22T13:39:13Z

CB-10052 Expose child process' io streams via promise progress notification




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Can you help me test/review this commit? ( ios statusbar plugin iPad multitask )

[Carlos Santana]

I have an iPad that supports multitasking but it's at home, I can test it
tonight if no one else have gotten to it first

You said "cordova doesn't officially support multitasking yet"  Do you have
a JIRA item describing what would be necessary to have support?


On Sun, Jan 31, 2016 at 5:15 PM julio cesar sanchez 
wrote:

> I'm trying to fix https://issues.apache.org/jira/browse/CB-10288
>
> I've tested on simulators and seems to work fine, but I don't have any real
> iPad with multitasking support to test.
>
> As cordova doesn't officially support multitasking yet, you have to follow
> these steps to add the support.
>
> On an empty project with ios platform (tested on cordova ios 3.9.2, but I
> think it should work on 4)
>
> Add all orientatios
> 
>
> add my commit of statusbar plugin
>
> cordova plugin add
> https://github.com/jcesarmobile/cordova-plugin-statusbar#578fa1b
>
> Open the xcode project and create a new "Launch Screen" file
> On the target "General" screen, set the file as "Launch Screen File" and
> uncheck "Requires full screen"
>
> I use this as the index.html but you can use your own
> https://gist.github.com/jcesarmobile/114fdb8b771837440752
>

[GitHub] cordova-windows pull request: CB-10480 Remove Windows 8 template f...

[csantanapr]

Github user csantanapr commented on the pull request:

https://github.com/apache/cordova-windows/pull/147#issuecomment-178054738
  
For what version is this for? cordova-windows@5.0.0 ?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10480 Remove Windows 8 template f...

[daserge]

Github user daserge commented on the pull request:

https://github.com/apache/cordova-windows/pull/147#issuecomment-178059859
  
This will be a breaking change, so yes, probably for cordova-windows@5.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

[Titoine]

Github user Titoine commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-177920211
  
I'm testing it with the developper option "Don't keep activities" and this 
isn't working everytime.
After a camera camera getPicture, I get the 'resume' event, and the next 
build, it isn't launched anymore..only the deviceready.

My existing app isn't really prepare for a solution like this and It take 
time to rebuild everything (webview etc.) so I'm searching an alternative. If 
anybody have any idea, I'll take it.

There is a solution for camera part with the CordovaCameraPreview plugin 
(https://github.com/mbppower/CordovaCameraPreview). But I didn't find a 
solution for image selection in the gallery and the foreground gallery doesn't 
seem to work anymore (It crash with "Don't keep activities").


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [DISCUSS] inAppBrowser plugin release

[Sergey Grebnov (Akvelon)]

Does anyone have any reason to delay InAppBrowser 1.2.1. patch release?
If not, I will start the release tomorrow.

To be released:

General:
CB-10428 Fix syntax error when browserifying inAppBrowser plugin
Android:
CB-10407 InAppBrowser not firing loadstart event on android
CB-6702 InAppBrowser hangs when opening more than one instance
CB-10456 InAppBrowser is not closed if I close it programmatically on 
Android
Windows:
CB-10454 InAppBrowser: 'loaderror' event does not have code and message on 
Windows
CB-10452 InAppBrowser: 'exit' event is not triggered on Windows
CB-10451 InAppBrowser: loadstart event is not triggered on Windows
CB-10450 InAppBrowser: Unable to get property 'canGoBack' of undefined on 
Windows

-Sergey
-Original Message-
From: Sergey Grebnov (Akvelon) 
Sent: Thursday, January 28, 2016 7:21 PM
To: 'dev@cordova.apache.org' 
Subject: RE: [DISCUSS] inAppBrowser plugin release

JFYI  - I've addressed new issues found, could someone review PRs please. 

CB-10456 InAppBrowser is not closed if I close it programmatically on Android
https://github.com/apache/cordova-plugin-inappbrowser/pull/143/files?w=1

CB-6702 InAppBrowser hangs when opening more than one instance on Android
https://github.com/apache/cordova-plugin-inappbrowser/pull/144/files?w=1

InAppBrowser bugfixing on Windows: CB-10451, CB-10452, CB-10454
https://github.com/apache/cordova-plugin-inappbrowser/pull/145/files?w=1

-Sergey
-Original Message-
From: Sergey Grebnov (Akvelon)
Sent: Wednesday, January 27, 2016 5:28 PM
To: 'dev@cordova.apache.org' 
Subject: RE: [DISCUSS] inAppBrowser plugin release

I've implemented unit tests for plugin core functionality and events (see PR 
[1]) and reported new bugs below. There is only one bad issue on Android which 
leads to InAppBrowser window hang (CB-10456, CB-6702), a few issues on Windows; 
iOS is doing well. I'm going to address them tomorrow so propose to wait one 
more day and do another plugin release. 


CB-10456 InAppBrowser hangs if I close it programmatically on Android
CB-6702 InAppBrowser hangs when opening more than one instance
CB-10454 InAppBrowser: 'loaderror' event does not have code and message on 
Windows
CB-10452 InAppBrowser: 'exit' event is not triggered on Windows
CB-10451 InAppBrowser: loadstart event is not triggered on Windows
CB-10450 InAppBrowser: Unable to get property 'canGoBack' of undefined on 
Windows

[1] https://github.com/apache/cordova-plugin-inappbrowser/pull/142 

-Sergey
-Original Message-
From: Sergey Grebnov (Akvelon)
Sent: Tuesday, January 26, 2016 4:19 PM
To: dev@cordova.apache.org
Subject: RE: [DISCUSS] inAppBrowser plugin release

Looks like we don't have auto tests for InAppBrowser plugin at all. We should 
write sanity test to ensure plugin is successfully initialized at least (there 
is cordova.InAppBrowser.open method available). I also think that it is doable 
to write auto tests for main events (load start/stop, etc) as well.

PS. CB-10428 has been resolved by the following PR: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/141/files?w=1 

-Sergey
-Original Message-
From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com]
Sent: Tuesday, January 26, 2016 12:43 AM
To: dev@cordova.apache.org
Subject: RE: [DISCUSS] inAppBrowser plugin release

Looks like there is another regression w.r.t. browserify workflow CB-10428 for 
Cordova-inappbrowser.

And this one for cordova-plugin-file: 
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10419=01%7c01%7cv-segreb%40microsoft.com%7c87655d4803a54891496f08d325d090c1%7c72f988bf86f141af91ab2d7cd011db47%7c1=VT5z308fXUhduPr40kC6zA0IsPT4apTeA%2fnStCYkFG8%3d

We might to rev those and re-release.

-Nikhil

-Original Message-
From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com]
Sent: Monday, January 25, 2016 10:23 AM
To: dev@cordova.apache.org
Subject: RE: [DISCUSS] inAppBrowser plugin release

I'm curious what caused the regression? Why do we not have tests for this 
important scenario?

-Nikhil

-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com]
Sent: Monday, January 25, 2016 1:19 AM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] inAppBrowser plugin release

+1 Lets do it!

On Mon, Jan 25, 2016 at 1:00 AM, julio cesar sanchez  wrote:

> On latest release of inAppBrowser plugin the loadstart event stopped 
> working on android.
> It has been fixed on the 1.2.1-dev.
> Should we release it?
>
> I think loadstart is very important and a lot of apps rely on it for 
> closing the window.
>
B CB  [  
X  ܚX KK[XZ[  ] ][  X  ܚX P ܙݘK \X K ܙ B  ܈Y][ۘ[  [X[  K[XZ[  
] Z[ ܙݘK \X K ܙ B B 
CB  [  X  
ܚX KK[XZ[  

[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...

[TimBarham]

Github user TimBarham commented on the pull request:

https://github.com/apache/cordova-windows/pull/139#issuecomment-177957240
  
I've taken a look too, and I agree this seems the best approach. Changes 
look good to me, except I agree with your comment @sgrebnov that we should use 
a relative path rather than absolute.

Regarding the red "x" on the folder name: this seems to be a limitation of 
a `jsproj` (that they don't fully support links, at least in the VS UI). If you 
create an equivalent link in a `csproj`, you don't get the red "x". If it 
indeed builds fine, then we can live with that.

However, there is one way we can avoid the red "x": actually create any 
folder defined in the `target` path (if there is one). It would be empty, but 
would make for less confusion in the VS UI.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: InAppBrowser bugfixing o...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/145


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: Prefer .bat over .cmd on windows platfor...

[pbakondy]

GitHub user pbakondy opened a pull request:

https://github.com/apache/cordova-lib/pull/371

Prefer .bat over .cmd on windows platform

Fixes ant-running issue on windows platform.

Originally I wanted to build android platform with ant:

```
cordova build android -- --ant
```

The downloadable Ant distribution package contains `ant.bat` and `ant.cmd` 
files in the `bin` directory.

The `resolveWindowsExe()` function resolves `ant` to 
`%ANT_HOME%\\bin\\ant.cmd`.

In case of ant this is not correct because `ant.cmd` is made for OS/2 
platform ( see: https://ant.apache.org/manual/running.html )

`child_process.spawn()` should run `ant.bat` file instead of `ant.cmd`.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pbakondy/cordova-lib master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/371.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #371


commit 9ffcdcc3a00bbc90cdd4f45c29be0d5d2465a023
Author: Peter Bakondy 
Date:   2016-02-01T17:22:22Z

Prefer .bat over .cmd on windows platform

Fixes ant-running issue on windows platform.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10113 - Browser - Camera on...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/134


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10052 Expose child process' io stream...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/369#discussion_r51532148
  
--- Diff: cordova-common/src/superspawn.js ---
@@ -113,11 +139,15 @@ exports.spawn = function(cmd, args, opts) {
 child.stdout.setEncoding('utf8');
 child.stdout.on('data', function(data) {
 capturedOut += data;
+d.notify({'stdout': data});
--- End diff --

`d` is a `Deferred` object. See 
https://github.com/apache/cordova-lib/blob/master/cordova-common/src/superspawn.js#L68


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos

[Vladimir Kotikov (Akvelon)]

> What is the impact to our workflow? are we just adding a node dependency, or 
> are there other config/integration parts that we need to do?
The only thing, required from our side is to replace `npm test` (or the 
command, that executes jasmine tests) witn `npm run cover` in Travis 
configuration (the coverage reports are already enabled for the most important 
repos). However, some help from infra side is required to setup Github <-> 
codecov.io integration.

> You are using istanbul for code coverage it seems.
Yup. 

> Why did you remove spec-cordova in your pr? Your [2]
Only for demo purposes. I wanted to see how it will look like :)

> I think it is a great idea to include this in our repos. It would be nice to 
> track our coverage and work on improving it.
> Though I do believe it is important not to chase 100% code coverage.
Agree here, 100 %  coverage is not the goal, We can just reach an agreement on 
a minimal appropriate value and try to not to drop coverage below this bar.

-
Best regards, Vladimir 


-Original Message-
From: Jesse [mailto:purplecabb...@gmail.com] 
Sent: Tuesday, February 2, 2016 2:22 AM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Enabling coverage reports collection and analysis for 
cordova repos

This looks good, as a metric to add.
What is the impact to our workflow? are we just adding a node dependency, or 
are there other config/integration parts that we need to do?




@purplecabbage
https://na01.safelinks.protection.outlook.com/?url=risingj.com=01%7c01%7cv-vlkoti%40064d.mgd.microsoft.com%7c3ea9a18f25ee43194ac808d32b5e79c2%7c72f988bf86f141af91ab2d7cd011db47%7c1=1SLJ4U2YHSQpiukrYipGlq7uBfl4uQNHxSE8q1JspDQ%3d

On Mon, Feb 1, 2016 at 2:17 PM, Steven Gill  wrote:

> Hey Vlad!
>
> This looks great! You are using istanbul for code coverage it seems.
>
> Why did you remove spec-cordova in your pr? Your [2]
>
> I think it is a great idea to include this in our repos. It would be 
> nice to track our coverage and work on improving it.
>
> Though I do believe it is important not to chase 100% code coverage.
>
>
> On Mon, Feb 1, 2016 at 6:21 AM, Vladimir Kotikov (Akvelon) < 
> v-vlk...@microsoft.com> wrote:
>
> > Hey, guys
> >
> > I've spent a couple of hours and have a prototype of how we can
> visualize,
> > track and analyze code coverage for our repos.
> > Here is the fork of cordova-lib repo integrated with 
> > https://na01.safelinks.protection.outlook.com/?url=codecov.io=0
> > 1%7c01%7cv-vlkoti%40064d.mgd.microsoft.com%7c3ea9a18f25ee43194ac808d
> > 32b5e79c2%7c72f988bf86f141af91ab2d7cd011db47%7c1=0oRS0Omv1Bac3
> > OVYlTyT08ENLSP15s1%2fw%2fvXxcO39ZA%3d [1] (notice the coverage badge 
> > at the top of README), and a PR with some coverage metrics [2]. The 
> > coverage summary is placed here [3]
> >
> > If this proposal get accepted, I'd like to enable this feature for 
> > all
> our
> > repos, to encourage contributors to increase current test coverage 
> > up to appropriate values.
> >
> > It'd be great if anyone could give any feedback on this
> >
> > [1] https://github.com/vladimir-kotikov/cordova-lib
> > [2] https://github.com/vladimir-kotikov/cordova-lib/pull/2
> > [3] 
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fcod
> > ecov.io%2fgithub%2fvladimir-kotikov%2fcordova-lib=01%7c01%7cv-v
> > lkoti%40064d.mgd.microsoft.com%7c3ea9a18f25ee43194ac808d32b5e79c2%7c
> > 72f988bf86f141af91ab2d7cd011db47%7c1=mtQlIC3U2lyzKA%2byFchr1zl
> > Yp9PuEUsFRH74kUaqLxg%3d
> >
> > -
> > Best regards, Vladimir
> >
> > 
> > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>

[GitHub] cordova-plugin-camera pull request: Chrome , Uncaught TypeError: l...

[TimBarham]

Github user TimBarham commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/154#issuecomment-178404256
  
Ah sorry @fattalgazi - I just fixed this and missed that you already had a 
PR open. Fixed now in #161.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10113 - Browser - Camera on...

[TimBarham]

Github user TimBarham commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/134#issuecomment-178412993
  
Thanks for this @aliokan. I've tweaked the commit a bit to store the magic 
number in a constant, and I'll merge it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10430 Allow to modify events source

[purplecabbage]

Github user purplecabbage commented on the pull request:

https://github.com/apache/cordova-lib/pull/370#issuecomment-178414449
  
Yeah, I too am not entirely behind this.
It seems like an anti-pattern here, and a consequence of 
require('../events') only being executed once per module.  This essentially 
makes it a global object that may change at runtime.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: handle app store urls in...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/133


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10052 Expose child process' io stream...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-lib/pull/369#issuecomment-178421841
  
Returning data instead of raw eventEmitter is IMO just less complex for 
caller API, because you, as a caller, do not need to create handlers, 
subscribe, unsubscribe, etc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10502 Fix camera plugin exc...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/161


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Sitemap Improvements

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-docs/pull/472#issuecomment-178340343
  
Fair enough - let's get it in!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10502 Fix camera plugin exc...

[TimBarham]

GitHub user TimBarham opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/161

CB-10502 Fix camera plugin exception in Chrome when click capture.

The `MediaStream.stop()` method has been deprecated as of Chrome 47. We 
were using it, and it was generating an exception.

If `stop()` method is not found, instead stop each individual track (the 
new way of doing it).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TimBarham/cordova-plugin-camera CB-10502

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/161.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #161


commit e48a7e5c5cffe8d9bab6eeff33feeb2747930ace
Author: Tim Barham 
Date:   2016-02-02T06:25:00Z

CB-10502 Fix camera plugin exception in Chrome when click capture.

The MediaStream.stop() method has been deprecated as of Chrome 47. We were 
using it, and it was generating an exception.

If stop() method is not found, instead stop each individual track (the new 
way of doing it).




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: handle app store urls in...

[magnusburton]

Github user magnusburton commented on the pull request:


https://github.com/apache/cordova-plugin-inappbrowser/pull/133#issuecomment-178395468
  
Looks great!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10459: cordova platform list should m...

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-lib/pull/368#issuecomment-178344384
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Multi-level ToC Implementation

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-docs/pull/464#issuecomment-178351575
  
Could you comment "Architecture" and it's sub-sections? We might not get to 
write these topics till April or something. It's best to not to have empty 
non-clickable placeholders in TOC.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-10474: Fix cordova-ios logging

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-medic/pull/73#issuecomment-178123204
  
@riknoll What's required to get this merged in? Let's try to get this asap 
as without this we don't understand why cordova-ios is failing: 
https://ci.apache.org/builders/cordova-ios.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

[adamduren]

Github user adamduren commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-178123878
  
@Titoine I experienced this as well. I thought it was a device specific bug 
but it was resolved by attaching the listeners as soon as possible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[DISCUSS] Enabling coverage reports collection and analysis for cordova repos

[Vladimir Kotikov (Akvelon)]

Hey, guys

I've spent a couple of hours and have a prototype of how we can visualize, 
track and analyze code coverage for our repos.
Here is the fork of cordova-lib repo integrated with codecov.io [1] (notice the 
coverage badge at the top of README), and a PR with some coverage metrics [2]. 
The coverage summary is placed here [3]

If this proposal get accepted, I'd like to enable this feature for all our 
repos, to encourage contributors to increase current test coverage up to 
appropriate values.

It'd be great if anyone could give any feedback on this

[1] https://github.com/vladimir-kotikov/cordova-lib 
[2] https://github.com/vladimir-kotikov/cordova-lib/pull/2
[3] https://codecov.io/github/vladimir-kotikov/cordova-lib 

-
Best regards, Vladimir

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Can you help me test/review this commit? ( ios statusbar plugin iPad multitask )

[julio cesar sanchez]

cordova should support launch storyboards
https://issues.apache.org/jira/browse/CB-7521
https://issues.apache.org/jira/browse/CB-9161

and "Requires full Screen" should be configurable, right now is set to true
(this is the JIRA item that set it to true
https://issues.apache.org/jira/browse/CB-9690, AFAIK, there nos issue for
making it configurable )



2016-02-01 15:07 GMT+01:00 Carlos Santana :

> I have an iPad that supports multitasking but it's at home, I can test it
> tonight if no one else have gotten to it first
>
> You said "cordova doesn't officially support multitasking yet"  Do you have
> a JIRA item describing what would be necessary to have support?
>
>
> On Sun, Jan 31, 2016 at 5:15 PM julio cesar sanchez <
> jcesarmob...@gmail.com>
> wrote:
>
> > I'm trying to fix https://issues.apache.org/jira/browse/CB-10288
> >
> > I've tested on simulators and seems to work fine, but I don't have any
> real
> > iPad with multitasking support to test.
> >
> > As cordova doesn't officially support multitasking yet, you have to
> follow
> > these steps to add the support.
> >
> > On an empty project with ios platform (tested on cordova ios 3.9.2, but I
> > think it should work on 4)
> >
> > Add all orientatios
> > 
> >
> > add my commit of statusbar plugin
> >
> > cordova plugin add
> > https://github.com/jcesarmobile/cordova-plugin-statusbar#578fa1b
> >
> > Open the xcode project and create a new "Launch Screen" file
> > On the target "General" screen, set the file as "Launch Screen File" and
> > uncheck "Requires full screen"
> >
> > I use this as the index.html but you can use your own
> > https://gist.github.com/jcesarmobile/114fdb8b771837440752
> >
>

[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...

[biasmv]

Github user biasmv commented on the pull request:

https://github.com/apache/cordova-windows/pull/139#issuecomment-178005303
  
Thanks for taking a look! I agree that it would be better to use relative 
paths. At the moment, csproj files are also referenced using absolute paths, so 
one would have to convert them to relative paths, too before being able to move 
around the generated projects.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10480 Remove Windows 8 template f...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-windows/pull/147

CB-10480 Remove Windows 8 template from cordova-windows

[Jira issue](https://issues.apache.org/jira/browse/CB-10480)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-windows CB-10480

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/147.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #147


commit 8fdd8d01b89aac98a583f58a00051c0ce6fadb38
Author: daserge 
Date:   2016-01-29T16:52:59Z

CB-10480 Remove Windows 8 template from cordova-windows

commit 426ac4abb5abea3347dd722f32a47f9e60bec822
Author: daserge 
Date:   2016-01-29T18:36:07Z

CB-10480 Remove Windows 8 template from cordova-windows

Updated the tests

commit c1cfa3b5a92d6f64d9257a82a2f51a80ee7ebcb4
Author: daserge 
Date:   2016-02-01T15:41:33Z

CB-10480 Remove Windows 8 template from cordova-windows

Adds a friendly error message for windows-target-version = 8.0
Updated check_reqs
Updated the docs




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-178109811
  
@Titoine you may be seeing a known issue in the fix (see 
[CB-10498](https://issues.apache.org/jira/browse/CB-10498)). Basically, it is 
possible in some circumstances to "miss" the resume event if you don't add 
event handlers in time. Let me know if you keep seeing the issue (and comment 
on the linked JIRA).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org