[GitHub] cordova-plugin-dialogs pull request: CB-9347 - fix to allow to sta...

[jcesarmobile]

Github user jcesarmobile commented on the pull request:


https://github.com/apache/cordova-plugin-dialogs/pull/54#issuecomment-183218924
  
It's supposed to be recursive. If count > 1 it just stores it on the array 
(line 100), then, once it's presented (line 230), removes the presented 
alertController from the array (line 231), and if the array contains any other 
alertController on the array (line 232), it calls presentAlertcontroller again 
(line 233).

I've tested and the problem is on the barcode scanner plugin, it returns 
the success or error callbacks right after calling 
dismissViewControllerAnimated, and dismissViewControllerAnimated takes a while, 
so the alert tries to present the dialog on the CDVbcsViewController that is 
being dismissed, so you get this error:
Warning: Attempt to present  on 
 whose view is not in the window hierarchy!

The solution should be not to return the callbacks until the 
CDVbcsViewController is dismissed. Than can be done with a block like this:

`- (void)barcodeScanDone:(void (^)(void))callbackBlock {
self.capturing = NO;
[self.captureSession stopRunning];
[self.parentViewController dismissViewControllerAnimated:YES 
completion:callbackBlock];

// viewcontroller holding onto a reference to us, release them so they
// will release us
self.viewController = nil;
}`

and every call to barcodeScanDone should pass the block as parameter

example:

`[self barcodeScanDone:^{
 [self.plugin returnSuccess:text format:format cancelled:FALSE 
flipped:FALSE callback:self.callback];
}];`

I'll try to send a pull request to the barcode scanner plugin with this fix 
this afternoon.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10592 Don't quote platform specific a...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/386#discussion_r52712187
  
--- Diff: cordova-lib/src/cordova/util.js ---
@@ -297,7 +297,7 @@ function ensurePlatformOptionsCompatible 
(platformOptions) {
 }).map(function (arg) {
 return opts[arg] === true ?
 '--' + arg :
-'--' + arg + '="' + opts[arg].toString() + '"';
+'--' + arg + '=' + opts[arg].toString();
--- End diff --

Because these quotes distorts arguments values e.g. `['--appx=uap']` 
becomes `['--appx="uap"']` and then (after parsing by `nopt` in platform) - 
`{appx: "\"uap"\"}` - notice that quotes now included as a part of `appx` 
option value.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Added instructions for adding redirects...

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/494#issuecomment-183215858
  
@riknoll: updated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Renamed 6.0.0 to 6.x

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/499#discussion_r52703243
  
--- Diff: www/.htaccess ---
@@ -41,6 +41,9 @@ RewriteRule ^.*docs/(\w\w)/latest$ 
{{site.baseurl}}/docs/$1/latest/ [R=302,L]
 #   resource, but the browser won't change the URI (no redirects 
followed).
 RewriteRule ^.*docs/(\w\w)/latest/(.*)$ 
{{site.baseurl}}/docs/$1/{{site.latest_docs_version}}/$2 [L]
 
+# rewrite 6.0.0 links to point to 6.x links
+RewriteRule ^.*docs/(\w\w)/6.0.0/(.*)$ {{site.baseurl}}/docs/$1/6.x/$2 [L]
--- End diff --

Please make this a 301 redirect.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Renamed 6.0.0 to 6.x

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/499#discussion_r52703222
  
--- Diff: tools/bin/incrementversion.js ---
@@ -71,10 +73,10 @@ function main () {
 }
 
 // only create greater versions
-if (!semver.gt(newVersion, oldVersion)) {
+/*if (!semver.gt(newVersion, oldVersion)) {
--- End diff --

Please make this a simple function: something like just a check for greater 
major version number.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Renamed 6.0.0 to 6.x

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/499#discussion_r52703206
  
--- Diff: tools/bin/incrementversion.js ---
@@ -36,9 +36,11 @@ function isValidVersion(version) {
 if (version == DEV_VERSION_NAME) {
 return false;
 }
+/*
 if (!semver.valid(version)) {
--- End diff --

Please add a `validVersion` function here, just with some simpler logic. A 
test `\d\.x` should probably be fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Renamed 6.0.0 to 6.x

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/499#discussion_r52703124
  
--- Diff: www/_data/toc/zh-6-x-manual.yml ---
@@ -0,0 +1,19 @@
+- {name: "\u8F14\u52A9\u7DDA", url: !!python/unicode '/docs/zh/6.x/'}
+- {name: "\u6982\u8FF0", url: !!python/unicode 
'/docs/zh/6.x/guide/overview/index.html'}
+- {name: "\u5E73\u81FA\u652F\u63F4", url: !!python/unicode 
'/docs/zh/6.x/guide/support/index.html'}
+- {name: "\u547D\u4EE4\u5217\u4ECB\u9762", url: !!python/unicode 
'/docs/zh/6.x/guide/cli/index.html'}
+- {name: "\u5E73\u81FA\u6307\u5357", url: !!python/unicode 
'/docs/zh/6.x/guide/platforms/index.html'}
+- {name: "\u4F7F\u7528 Plugman 
\u4F86\u7BA1\u7406\u5916\u639B\u7A0B\u5F0F", url: !!python/unicode 
'/docs/zh/6.x/plugin_ref/plugman.html'}
+- {name: "Config.xml \u6A94", url: !!python/unicode 
'/docs/zh/6.x/config_ref/index.html'}
+- {name: "\u5716\u793A\u548C\u555F\u52D5\u756B\u9762", url: 
!!python/unicode '/docs/zh/6.x/config_ref/images.html'}
+- {name: "\u5D4C\u5165 WebViews", url: !!python/unicode 
'/docs/zh/6.x/guide/hybrid/webviews/index.html'}
+- {name: "\u5916\u639B\u7A0B\u5F0F\u958B\u767C\u6307\u5357", url: 
!!python/unicode '/docs/zh/6.x/guide/hybrid/plugins/index.html'}
+- {name: "\u5916\u639B\u7A0B\u5F0F\u898F\u7BC4", url: !!python/unicode 
'/docs/zh/6.x/plugin_ref/spec.html'}
+- {name: "\u96B1\u79C1\u6307\u5357", url: !!python/unicode 
'/docs/zh/6.x/guide/appdev/privacy/index.html'}
+- {name: "\u5B89\u5168\u6307\u5357", url: !!python/unicode 
'/docs/zh/6.x/guide/appdev/security/index.html'}
+- {name: 
"\u5E73\u81FA\u548C\u5916\u639B\u7A0B\u5F0F\u7248\u672C\u7BA1\u7406", url: 
!!python/unicode '/docs/zh/6.x/platform_plugin_versioning_ref/index.html'}
+- {name: "\u767D\u540D\u55AE\u6307\u5357", url: !!python/unicode 
'/docs/zh/6.x/guide/appdev/whitelist/index.html'}
+- {name: "\u5B58\u5132", url: !!python/unicode 
'/docs/zh/6.x/cordova/storage/storage.html'}
+- {name: "\u4E8B\u4EF6", url: !!python/unicode 
'/docs/zh/6.x/cordova/events/events.html'}
+- {name: "\u5916\u639B\u7A0B\u5F0F\u7684 Api", url: !!python/unicode 
'/docs/zh/6.x/cordova/plugins/pluginapis.html'}
+- {name: "\u95DC\u9375\u5B57\u7D22\u5F15", url: !!python/unicode 
'/docs/zh/6.x/page_index.html'}
--- End diff --

This change should only be a rename: there are no `/docs/XX/YYY/` prefixes 
in the ToC files anymore.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-dialogs pull request: CB-9347 - fix to allow to sta...

[tony--]

Github user tony-- commented on the pull request:


https://github.com/apache/cordova-plugin-dialogs/pull/54#issuecomment-183153364
  
@jcesarmobile - With regard to 
phonegap-plugin-barcodescanner+cordova-plugin-dialogs, I was chatting with 
@imaffett about this.  He found that reverting from 
cordova-plugin-dialogs@1.2.0 to cordova-plugin-dialogs@1.1.1 fixed the issue he 
was seeing.  I was comparing the code from the 2 versions and am wondering 
about 
[this](https://github.com/apache/cordova-plugin-dialogs/pull/54/files#diff-b1298bd2cd777b56752fccb1b2faf4abR102).
  What should happen when `[alertList count] > 1`?  Maybe I am reading it 
wrong, but it seems like the way it is now, it will silently fail.  Is that the 
intended behavior? Am I misunderstanding what will happen?  Thanks in advance 
for help with improving my understanding!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10521 Add OS X platform to docs

[tripodsan]

Github user tripodsan commented on the pull request:

https://github.com/apache/cordova-docs/pull/496#issuecomment-183150004
  
ok, I added the OS X specific preferences in the config reference.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Renamed 6.0.0 to 6.x

[stevengill]

Github user stevengill commented on the pull request:

https://github.com/apache/cordova-docs/pull/499#issuecomment-183146630
  
Still need to finish incorporating feedback from #484


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Renamed 6.0.0 to 6.x

[stevengill]

GitHub user stevengill opened a pull request:

https://github.com/apache/cordova-docs/pull/499

Renamed 6.0.0 to 6.x



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stevengill/cordova-docs V6

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/499.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #499


commit 740e12c6aa43d84d8ef7148d4f33d64cfef456b7
Author: Steve Gill 
Date:   2016-02-04T19:19:35Z

added version 6.x, removed version 6.0.0

commit ebf9db69910a19773301f4cd7c544075468a4046
Author: Steve Gill 
Date:   2016-02-04T19:20:07Z

added 6.0.0 redirect to 6.x, updated incrementversion.js

commit 12f02fcf48755855b7872f0e640ea713ddac23b4
Author: Steve Gill 
Date:   2016-02-12T01:45:37Z

deleted zh 6-0-0 manual toc




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: added version 6.x

[stevengill]

Github user stevengill commented on the pull request:

https://github.com/apache/cordova-docs/pull/484#issuecomment-183145913
  
Opening a new PR since I moved this work to a branch


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: added version 6.x

[stevengill]

Github user stevengill closed the pull request at:

https://github.com/apache/cordova-docs/pull/484


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [Vote] 5.0.0 OSX Release

[Steven Gill]

Err, found a issue with the readme. Going to close this vote, retag and
send it out again. Also, subject should be 4.0.0 not 5.0.0

On Thu, Feb 11, 2016 at 5:19 PM, Steven Gill  wrote:

> Please review and vote on this 4.0.0 OSX Release
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-10597
>
> The archive has been published to 
> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10597
>
> The package was published from its corresponding git tag:
> cordova-osx: 4.0.0 (c02e81fae3)
>
> Note that you can test it out via:
>
> cordova platform add https://github.com/apache/cordova-osx#4.0.0
>
> Upon a successful vote I will upload the archive to dist/, publish it to npm, 
> and post the blog post.
>
> Voting guidelines: 
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and subdependencies have 
> Apache-compatible licenses
> * Ran mobile-spec and ran npm test
>
>

[GitHub] cordova-plugin-geolocation pull request: CB-10574: MobileSpec can'...

[dblotsky]

Github user dblotsky commented on the pull request:


https://github.com/apache/cordova-plugin-geolocation/pull/70#issuecomment-183142774
  
It looks like reusing the `Geolocator` object was done *by design*, as is 
suggested by the naming of `ensureLocator`. Also it is assumed to be a 
singleton, so creating a new one on every call to `getLocation` will lead to 
incorrect behaviour.

What exactly causes the crash when the `loc` object is reused? Does 
`addEventListener` not allow for more than one listener?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[Vote] 5.0.0 OSX Release

[Steven Gill]

Please review and vote on this 4.0.0 OSX Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-10597

The archive has been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10597

The package was published from its corresponding git tag:
cordova-osx: 4.0.0 (c02e81fae3)

Note that you can test it out via:

cordova platform add https://github.com/apache/cordova-osx#4.0.0

Upon a successful vote I will upload the archive to dist/, publish it
to npm, and post the blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ran mobile-spec and ran npm test

[GitHub] cordova-docs pull request: CB-10521 Add OS X platform to docs

[rakatyal]

Github user rakatyal commented on the pull request:

https://github.com/apache/cordova-docs/pull/496#issuecomment-183139758
  
Yes. We don't have a standard way of doing it for now. For now it's okay to 
specify it in bold.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10521 Add OS X platform to docs

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/496#issuecomment-183138964
  
Good point! @rakatyal do we have a standard way of doing that? Elsewhere in 
the docs we generally just mention it in the text and make the version bold, I 
think.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10521 Add OS X platform to docs

[tripodsan]

Github user tripodsan commented on the pull request:

https://github.com/apache/cordova-docs/pull/496#issuecomment-183138268
  
thank's @riknoll, I will incorporate the changes. one question: why don't 
we include the version of the platform when the attribute/feature was included? 
I think this could be pretty useful for developers to figure out, why a certain 
attribute doesn't work...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Added instructions for adding redirects...

[stevengill]

Github user stevengill commented on the pull request:

https://github.com/apache/cordova-docs/pull/494#issuecomment-183135910
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10521 Add OS X platform to docs

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/496#issuecomment-183134067
  
Hello again @tripodsan! There is currently an effort going on to reorganize 
a lot of stuff in the docs to fit the new [information 
architecture](https://github.com/cordova/cordova-discuss/pull/31) and one of 
the things that is changing is that all of the platform specific config.xml 
specifications are being combined into one reference. The [dev version of the 
config 
reference](https://github.com/apache/cordova-docs/blob/master/www/docs/en/dev/config_ref/index.md)
 has been updated to include all of the config.xml preferences for all of the 
platforms. It would be great to see the preferences you give here make their 
way into the main reference page. We have formatting for XML references defined 
in the [docs 
styleguide](https://github.com/apache/cordova-docs/blob/master/doc/docs-STYLEGUIDE.md#xml-references)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-geolocation pull request: CB-10574: MobileSpec can'...

[sarangan12]

GitHub user sarangan12 opened a pull request:

https://github.com/apache/cordova-plugin-geolocation/pull/70

CB-10574: MobileSpec can't get results for WP8.1 Builds

The MobileSpec can't get results for WP8.1 Builds. 

**Why?**
Because, one of the tests in the geolocation plugin is failing and causes 
the app to crash. This test gets the "0x80004004 - JavaScript runtime error: 
Operation aborted" error. So, the app crashes. The issue around this test must 
be fixed for the CI to finish successfully for Windows Phone 8.1. 

**What is the scenario for the crash?**
The scenario could be seen manually also. When you run the mobilespec test 
for geolocatio API, try the following steps:

1. Start Watching 
2. Stop Watching
3. Start Watching
4. Start Watching 

The app will crash in step 4. But it will not crash on step 3.  

**Why does the app crash on step 4?**

Per code, the loc object (instance of 
Windows.Devices.Geolocation.Geolocator object) is being reused in both the 
steps - which causes the crash. 

**What is the fix?**

The current fix is to create  a new instance of the object instead of 
resuing the same object. I have validated the fix by running the geolocation 
tests and all of them are passing. 


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sarangan12/cordova-plugin-geolocation CB-10574

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-geolocation/pull/70.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #70


commit fbe3bdaef60155cefe2cf789cc62cb27e5a8a3af
Author: Sarangan Rajamanickam 
Date:   2016-02-12T00:19:04Z

CB-10574: MobileSpec can't get results for WP8.1 Builds

MobileSpec can't get results for WP8.1 Builds




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[DISCUSS] Cordova-OSX Release

[Steven Gill]

Does anyone have any reason to delay a cordova-osx platform release?
Any outstanding patches to land?

If not, I will start the release.

[GitHub] cordova-docs pull request: added version 6.x

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/484#issuecomment-183122341
  
@stevengill there isn't really any redirect work: it's just docs. When 
you're back to this PR, please rebase and address the comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10552: Pull all the plugin docs to C...

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/493#discussion_r52689249
  
--- Diff: tools/bin/fetch_docs.js ---
@@ -0,0 +1,144 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+"use strict";
+
+var fs= require("fs");
+var fse   = require("fs-extra");
+var https = require("https");
+var path  = require("path");
+var child_process = require("child_process");
+var yaml  = require("js-yaml");
+
+// constants
+var DEFAULT_REPO_PATH = "README.md";
+
+function generateFrontMatter (useDirectSrcURI, filePath, name, version) {
+var obj = {};
+
+if(useDirectSrcURI) {
+filePath= 
filePath.replace("https://raw.githubusercontent.com/";, "");
+var filePathSplit   = filePath.split("/");
+name= filePathSplit[0] + "/" + filePathSplit[1];
+version = filePathSplit[2];
+filePath= filePathSplit.slice(3).join("/");
+}
+
+obj.edit_link   = getRepoURIForFrontMatter(name, version, 
filePath);
+obj.note_link   = "https://github.com/"; + name + "/releases";
+obj.note= "This documentation is for the " + version + 
" version of the " + name + ".";
+obj.note_link_text  = "Visit Github for other versions.";
--- End diff --

Please move this logic to the Jekyll side. Instead set a variable called 
something like `plugin_version`, and construct the link in HTML.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10552: Pull all the plugin docs to C...

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/493#discussion_r52689198
  
--- Diff: www/_layouts/docs.html ---
@@ -183,6 +183,21 @@ {{ page.toc_text }}
 
 {% endif %}
 
+
+{% if page.note_link and page.note_link_text %}
+
+
+
+×
+
+{{ page.note }}
+
+{{ page.note_link_text }}
+
+
+
+{% endif %}
--- End diff --

Please adjust this code with respect to the comment on `fetch_docs.js`, and 
to trigger when `plugin_version` is specified.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: added version 6.x

[stevengill]

Github user stevengill commented on the pull request:

https://github.com/apache/cordova-docs/pull/484#issuecomment-183119365
  
@dblotsky getting back to this. Should I wait for your redirect work to 
land or move forward with this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10552: Pull all the plugin docs to C...

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/493#discussion_r52688661
  
--- Diff: tools/bin/fetch_docs.js ---
@@ -0,0 +1,144 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+"use strict";
+
+var fs= require("fs");
+var fse   = require("fs-extra");
+var https = require("https");
+var path  = require("path");
+var child_process = require("child_process");
+var yaml  = require("js-yaml");
+
+// constants
+var DEFAULT_REPO_PATH = "README.md";
+
+function generateFrontMatter (useDirectSrcURI, filePath, name, version) {
+var obj = {};
+
+if(useDirectSrcURI) {
+filePath= 
filePath.replace("https://raw.githubusercontent.com/";, "");
+var filePathSplit   = filePath.split("/");
+name= filePathSplit[0] + "/" + filePathSplit[1];
+version = filePathSplit[2];
+filePath= filePathSplit.slice(3).join("/");
+}
--- End diff --

Please use a regex here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-mobile-spec pull request: CB-10572 Mobilespec tests not wo...

[tripodsan]

Github user tripodsan commented on a diff in the pull request:

https://github.com/apache/cordova-mobile-spec/pull/137#discussion_r52687280
  
--- Diff: cordova-plugin-mobilespec-tests/tests/datauri.tests.js ---
@@ -27,6 +27,7 @@ exports.defineAutoTests = function () {
 
 function onMessage(done, msg) {
 if (msg.data == 'foo') {
+expect('Suppress SPEC HAS NO EXPECTATIONS').toBeDefined();
--- End diff --

it's not my code...I just fixed the warning :-) I think the test has no 
expectations because it just needs to wait for the async() to finish. Also, I 
think this warning was fixed in a more modern jasmine version.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Added instructions for adding redirects...

[stevengill]

Github user stevengill commented on the pull request:

https://github.com/apache/cordova-docs/pull/494#issuecomment-183107543
  
I'm looking at this right now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10552: Pull all the plugin docs to C...

[stevengill]

Github user stevengill commented on the pull request:

https://github.com/apache/cordova-docs/pull/493#issuecomment-183105034
  
Just finished my run through. 

LGTM.

It is nice to not leave the site to see the docs. I also like how it pulls 
the latest release and warns users about the version. More useful than npm's 
readme. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Added instructions for adding redirects...

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/494#issuecomment-183103865
  
Minor nitpick: I would mention on the deprecated page that 6.0.0 is the 
latest version of the docs. It's not super clear where you got that version 
from, especially when you offer a redirect to "latest" below it. Maybe rephrase 
it as "This content is deprecated in the latest documentation (version 6.0.0)" 
or something like that. Makes it clear that those two versions are the same. 
Rest of the pr LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10552: Pull all the plugin docs to C...

[purplecabbage]

Github user purplecabbage commented on the pull request:

https://github.com/apache/cordova-docs/pull/493#issuecomment-183101764
  
Looks good!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Added instructions for adding redirects...

[purplecabbage]

Github user purplecabbage commented on the pull request:

https://github.com/apache/cordova-docs/pull/494#issuecomment-18317
  
lgtm!


@purplecabbage
risingj.com

On Thu, Feb 11, 2016 at 3:07 PM, Richard Knoll 
wrote:

> @dblotsky  reviewing now
>
> —
> Reply to this email directly or view it on GitHub
> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-9393: Documenting how to embed a Sys...

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/498#issuecomment-183097926
  
Awesome! I'll give this a try when I get a moment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10552: Pull all the plugin docs to C...

[stevengill]

Github user stevengill commented on the pull request:

https://github.com/apache/cordova-docs/pull/493#issuecomment-183096395
  
BTW, I had a merge conflict when pulling this in. Need to rebase this off 
the latest master I believe. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[ANNOUNCE] Plugins Release

[Steven Gill]

Blog: http://cordova.apache.org/news/2016/02/09/plugins-release.html
Tweet: https://twitter.com/apachecordova/status/697919989190258688

[GitHub] cordova-docs pull request: CB-10552: Pull all the plugin docs to C...

[stevengill]

Github user stevengill commented on the pull request:

https://github.com/apache/cordova-docs/pull/493#issuecomment-183095394
  
I'm testing this now. Just pulled it into my local copy


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Added instructions for adding redirects...

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/494#issuecomment-183094788
  
@dblotsky reviewing now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Added instructions for adding redirects...

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/494#issuecomment-183093041
  
@riknoll any feedback on the new deprecated page?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10552: Pull all the plugin docs to C...

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/493#issuecomment-183092935
  
@sarangan12 looks like the mailing list is quiet about this. @riknoll any 
feedback?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-mobile-spec pull request: CB-10572 Mobilespec tests not wo...

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-mobile-spec/pull/137#discussion_r52680237
  
--- Diff: cordova-plugin-mobilespec-tests/tests/datauri.tests.js ---
@@ -27,6 +27,7 @@ exports.defineAutoTests = function () {
 
 function onMessage(done, msg) {
 if (msg.data == 'foo') {
+expect('Suppress SPEC HAS NO EXPECTATIONS').toBeDefined();
--- End diff --

Why don't the tests themselves have any `expect`s? Also, there are two 
identical `describe`s in this file. Is that expected?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-geolocation pull request: CB-10594 geolocation.spec...

[dblotsky]

Github user dblotsky commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-geolocation/pull/69#discussion_r52679939
  
--- Diff: tests/tests.js ---
@@ -174,8 +174,12 @@ exports.defineAutoTests = function () {
 describe('error callback', function () {
 
 var errorWatch = null;
-afterEach(function () {
-navigator.geolocation.clearWatch(errorWatch);
+afterEach(function (done) {
+// Workaround to avoid the crash "0x80004004 - JavaScript 
runtime error: Operation aborted" on Windows
+setTimeout(function () {
+navigator.geolocation.clearWatch(errorWatch);
+done();
+}, 100);
--- End diff --

This looks like magic. Why does 100ms fix the issue?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-mobile-spec pull request: CB-10572 Mobilespec tests not wo...

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-mobile-spec/pull/137#discussion_r52677657
  
--- Diff: createmobilespec/createmobilespec.js ---
@@ -498,6 +522,15 @@ function pluginIdToDirName(id) {
 // install plugins for each platform
 function installPlugins() {
 var plugins = DEFAULT_PLUGINS;
+
+// special override for osx
+if (argv.osx) {
+if (platforms.length > 1) {
--- End diff --

@tripodsan thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-mobile-spec pull request: CB-10572 Mobilespec tests not wo...

[tripodsan]

Github user tripodsan commented on a diff in the pull request:

https://github.com/apache/cordova-mobile-spec/pull/137#discussion_r52677350
  
--- Diff: createmobilespec/createmobilespec.js ---
@@ -498,6 +522,15 @@ function pluginIdToDirName(id) {
 // install plugins for each platform
 function installPlugins() {
 var plugins = DEFAULT_PLUGINS;
+
+// special override for osx
+if (argv.osx) {
+if (platforms.length > 1) {
--- End diff --

ok. I'll change it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-mobile-spec pull request: CB-10572 Mobilespec tests not wo...

[tripodsan]

Github user tripodsan commented on a diff in the pull request:

https://github.com/apache/cordova-mobile-spec/pull/137#discussion_r52677263
  
--- Diff: cordova-plugin-mobilespec-tests/tests/datauri.tests.js ---
@@ -27,6 +27,7 @@ exports.defineAutoTests = function () {
 
 function onMessage(done, msg) {
 if (msg.data == 'foo') {
+expect('Suppress SPEC HAS NO EXPECTATIONS').toBeDefined();
--- End diff --

without it, the tests show the "Spec has no Expectation" warnings. this 
fixes it.
see 
http://stackoverflow.com/questions/27016235/angular-js-unit-testing-httpbackend-spec-has-no-expectations


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10592 Don't quote platform specific a...

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/386#discussion_r52677192
  
--- Diff: cordova-lib/src/cordova/util.js ---
@@ -297,7 +297,7 @@ function ensurePlatformOptionsCompatible 
(platformOptions) {
 }).map(function (arg) {
 return opts[arg] === true ?
 '--' + arg :
-'--' + arg + '="' + opts[arg].toString() + '"';
+'--' + arg + '=' + opts[arg].toString();
--- End diff --

Why is this no longer escaped?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-mobile-spec pull request: CB-10572 Mobilespec tests not wo...

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-mobile-spec/pull/137#discussion_r52676901
  
--- Diff: createmobilespec/createmobilespec.js ---
@@ -498,6 +522,15 @@ function pluginIdToDirName(id) {
 // install plugins for each platform
 function installPlugins() {
 var plugins = DEFAULT_PLUGINS;
+
+// special override for osx
+if (argv.osx) {
+if (platforms.length > 1) {
--- End diff --

This will override the plugins for all platforms, which is incorrect 
behaviour. Perhaps make the logic override plugins when OSX is the *only* 
specified platform?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-mobile-spec pull request: CB-10572 Mobilespec tests not wo...

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-mobile-spec/pull/137#discussion_r52676734
  
--- Diff: cordova-plugin-mobilespec-tests/tests/datauri.tests.js ---
@@ -27,6 +27,7 @@ exports.defineAutoTests = function () {
 
 function onMessage(done, msg) {
 if (msg.data == 'foo') {
+expect('Suppress SPEC HAS NO EXPECTATIONS').toBeDefined();
--- End diff --

What does this expect do?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10510: Add an optional timeout to...

[riknoll]

GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-android/pull/258

CB-10510: Add an optional timeout to emu start script

The `emulator.js` script waits forever for the emulator to boot. If the 
emulator gets stuck, it will never terminate. The reason for adding this 
timeout is that the Android emulator on Windows occasionally hangs while 
booting up. This causes problems in our CI, where the run step would go on 
forever until buildbot eventually cut it off (see 
[here](https://ci.apache.org/builders/cordova-android-win/builds/1588/steps/running-tests/logs/stdio)
 for an example run). I have an upcoming PR for cordova-medic that switches 
from using `cordova run` to start the emulator to requiring this script 
directly so that we can add retry logic for the emulator start. I don't think 
it really makes sense to expose the timeout option in the CLI itself, so this 
PR does not alter the CLI's behavior at all (it will still hang). I'm not sure 
if we should add in a default timeout or not.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-android CB-10510

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/258.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #258


commit 723393168127524f5f23d931bbcf171edbd08d39
Author: riknoll 
Date:   2016-02-11T21:37:00Z

CB-10510: Add an optional timeout to emu start script

The script used to wait forever for the emulator to boot.
If the emulator got stuck, it would never terminate.
This timeout is being added to support cordova-medic and
the CI.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-9393: Documenting how to embed a Sys...

[infil00p]

GitHub user infil00p opened a pull request:

https://github.com/apache/cordova-docs/pull/498

CB-9393: Documenting how to embed a SystemWebView 

This is designed with Android Studio in mind.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/infil00p/cordova-docs master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/498.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #498


commit d9bf99a51dae980a30e55c1510548f6245c05332
Author: Joe Bowser 
Date:   2016-02-11T21:35:56Z

CB-9393: Documenting how to embed a SystemWebView in an Android Studio 
project




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-10535: Fix Plugin Media cras...

[omefire]

Github user omefire closed the pull request at:

https://github.com/apache/cordova-plugin-media/pull/82


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-10535: Fix Plugin Media cras...

[omefire]

Github user omefire commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/82#issuecomment-183021655
  
Closing this PR as it has just been merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-10535: Fix Plugin Media cras...

[omefire]

Github user omefire commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/82#issuecomment-183009872
  
@shazron , I don't think we need to put this in the docs. I didn't see the 
issue manifest itself when played right away, just when seeked right away.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media pull request: CB-10535: Fix Plugin Media cras...

[omefire]

Github user omefire commented on the pull request:


https://github.com/apache/cordova-plugin-media/pull/82#issuecomment-182996869
  
@ghenry22 ok, thanks for the explanation. 
In this case, waiting for mediaStatus to hit 2 won't help. As a matter of 
fact, the tests as they currently stand do just that.

The issue is related to seeking when not everything has been buffered yet. 
playing in that case won't elicit this behavior.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-mobile-spec pull request: CB-10572 Mobilespec tests not wo...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-mobile-spec/pull/137


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-geolocation pull request: CB-10594 geolocation.spec...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-plugin-geolocation/pull/69

CB-10594 geolocation.spec.10 crashes Windows Phone 8.1

[Jira issue](https://issues.apache.org/jira/browse/CB-10594)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-geolocation CB-10594

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-geolocation/pull/69.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #69


commit 15ff13bb7828334cd50850cc49949046a93a9a19
Author: daserge 
Date:   2016-02-11T15:25:59Z

CB-10594 geolocation.spec.10 crashes Windows Phone 8.1




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10592 Don't quote platform specific a...

[vladimir-kotikov]

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-lib/pull/386

CB-10592 Don't quote platform specific args values

See JIRA [CB-10592](https://issues.apache.org/jira/browse/CB-10592)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-lib CB-10592

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/386.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #386


commit 7e3100492adfc87af6175117e976565e27a3
Author: Vladimir Kotikov 
Date:   2016-02-11T12:28:03Z

CB-10592 Don't quote platform specific args values

commit 87b8bedc29e867d7da2745ff36a3107c7b15bc80
Author: Vladimir Kotikov 
Date:   2016-02-11T14:03:45Z

CB-10592 Add tests to cover the argiments compatibility logic




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: CB-10411 Error in file.spec.129 ...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-plugin-file/pull/163

CB-10411 Error in file.spec.129 of cordova-plugin-file

Check if external storage is available

[Jira issue](https://issues.apache.org/jira/browse/CB-10411)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-file CB-10411

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file/pull/163.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #163


commit f231e7c001b5fb79b96bbad71d465d79f6d25855
Author: daserge 
Date:   2016-02-11T14:26:51Z

CB-10411 Error in file.spec.129 of cordova-plugin-file

Check if external storage is available




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [VOTE] Plugins Release

[Vladimir Kotikov (Akvelon)]

The vote has now closed. The results are:

Positive Binding Votes: 3

Vladimir Kotikov
Alexander Sorokin
Sergey Grebnov

The vote has passed

-
Best regards, Vladimir

-Original Message-
From: Sergey Grebnov (Akvelon) [mailto:v-seg...@microsoft.com] 
Sent: Thursday, February 11, 2016 11:45 AM
To: dev@cordova.apache.org
Subject: RE: [VOTE] Plugins Release

I vote +1

* Run auto-tests
* Verified release notes

-Sergey Grebnov
-Original Message-
From: Alexander Sorokin (Akvelon) [mailto:v-als...@microsoft.com] 
Sent: Wednesday, February 10, 2016 6:16 PM
To: dev@cordova.apache.org
Subject: RE: [VOTE] Plugins Release

I vote +1.

* Verified signatures and hashes
* Verified tags
* Verified that plugins can be added correctly to blank app
* Verified that blank app can be successfully built and ran
* Verified that browserified app can be successfully built and ran (found 1 
issue, see below)
* Ran smoke testing of mobilespec app
* Verified release notes

While testing I've found another issue with browserify: when running 
browserified app with splashscreen plugin on windows 10, it crashes:
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10584&data=01%7c01%7cv-segreb%40microsoft.com%7c1df93b4093834bd5180608d3322d2529%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=8B9vJWMxJcIxrNBkxZAGOViXbGCufwaWNKdPWi5fOxI%3d

It looks like this issue was present in previous releases so I think it is not 
a blocker for this one.

Thanks,
Alexander Sorokin

-Original Message-
From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] 
Sent: Tuesday, February 9, 2016 10:08 PM
To: dev@cordova.apache.org
Subject: [VOTE] Plugins Release

Please review and vote on the release of this plugins release by replying to 
this email (and keep discussion on the DISCUSS thread)

Release issue: 
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10557&data=01%7c01%7cv-alsoro%40microsoft.com%7c5003c1bcd6cb46dc2aa608d331846868%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=VXTVNXa2zoh82EwWGRRnHHm3hX%2bX8mfxgQ1R43EmELo%3d

The plugins have been published to dist/dev:
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist.apache.org%2frepos%2fdist%2fdev%2fcordova%2fCB-10557&data=01%7c01%7cv-alsoro%40microsoft.com%7c5003c1bcd6cb46dc2aa608d331846868%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=LoKpv39%2ba5PRjo5LQd4VBR0tSw4ihrdf2aWofkQdfw8%3d

The packages were published from their corresponding git tags:
cordova-plugin-file: 4.1.1 (23f10a1317)
cordova-plugin-inappbrowser: 1.3.0 (5cbd28edb0)
cordova-plugin-media: 2.2.0 (e9df2cbfb3)
cordova-plugin-splashscreen: 3.2.0 (5af0016c67)
cordova-plugin-statusbar: 2.1.1 (573176e3a7)
cordova-plugin-wkwebview-engine: 1.0.2 (7f1409ec6c)

Upon a successful vote I will upload the archives to dist/, upload them to the 
Plugins Registry, and post the corresponding blog post.

Voting guidelines: 
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies have 
Apache-compatible licenses
* Created and ran mobilespec app to ensure tests are passing

-
Best regards, Vladimjr

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10557 Adds plugins release blog post

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/495


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [VOTE] Plugins Release

[Sergey Grebnov (Akvelon)]

I vote +1

* Run auto-tests
* Verified release notes

-Sergey Grebnov
-Original Message-
From: Alexander Sorokin (Akvelon) [mailto:v-als...@microsoft.com] 
Sent: Wednesday, February 10, 2016 6:16 PM
To: dev@cordova.apache.org
Subject: RE: [VOTE] Plugins Release

I vote +1.

* Verified signatures and hashes
* Verified tags
* Verified that plugins can be added correctly to blank app
* Verified that blank app can be successfully built and ran
* Verified that browserified app can be successfully built and ran (found 1 
issue, see below)
* Ran smoke testing of mobilespec app
* Verified release notes

While testing I've found another issue with browserify: when running 
browserified app with splashscreen plugin on windows 10, it crashes:
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10584&data=01%7c01%7cv-segreb%40microsoft.com%7c1df93b4093834bd5180608d3322d2529%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=8B9vJWMxJcIxrNBkxZAGOViXbGCufwaWNKdPWi5fOxI%3d

It looks like this issue was present in previous releases so I think it is not 
a blocker for this one.

Thanks,
Alexander Sorokin

-Original Message-
From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] 
Sent: Tuesday, February 9, 2016 10:08 PM
To: dev@cordova.apache.org
Subject: [VOTE] Plugins Release

Please review and vote on the release of this plugins release by replying to 
this email (and keep discussion on the DISCUSS thread)

Release issue: 
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10557&data=01%7c01%7cv-alsoro%40microsoft.com%7c5003c1bcd6cb46dc2aa608d331846868%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=VXTVNXa2zoh82EwWGRRnHHm3hX%2bX8mfxgQ1R43EmELo%3d

The plugins have been published to dist/dev:
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist.apache.org%2frepos%2fdist%2fdev%2fcordova%2fCB-10557&data=01%7c01%7cv-alsoro%40microsoft.com%7c5003c1bcd6cb46dc2aa608d331846868%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=LoKpv39%2ba5PRjo5LQd4VBR0tSw4ihrdf2aWofkQdfw8%3d

The packages were published from their corresponding git tags:
cordova-plugin-file: 4.1.1 (23f10a1317)
cordova-plugin-inappbrowser: 1.3.0 (5cbd28edb0)
cordova-plugin-media: 2.2.0 (e9df2cbfb3)
cordova-plugin-splashscreen: 3.2.0 (5af0016c67)
cordova-plugin-statusbar: 2.1.1 (573176e3a7)
cordova-plugin-wkwebview-engine: 1.0.2 (7f1409ec6c)

Upon a successful vote I will upload the archives to dist/, upload them to the 
Plugins Registry, and post the corresponding blog post.

Voting guidelines: 
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies have 
Apache-compatible licenses
* Created and ran mobilespec app to ensure tests are passing

-
Best regards, Vladimjr

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: don't copy resource-files at plugin ...

[sgrebnov]

Github user sgrebnov commented on the pull request:

https://github.com/apache/cordova-windows/pull/139#issuecomment-182766890
  
I'll test new version and merge later today


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: bug? Launch freeze/crash on manual splash screen hiding

[Frederico Galvão]

I can confirm this is an issue. Also, in my case, if I run it from the
command line with `cordova emulate ios` it works, but if I run it from
XCode it fails as described in the issue.

2016-02-03 20:08 GMT-02:00 Zarko Hristovski :

> Experiencing a rather critical issue since getting on Cordova 6.0.0 for
> iOS. We have a scenario where we hide the Cordova splash screen manually
> relatively shortly after app launch. The problem is that quite often during
> launch the app just stays on the splash screen instead of continuing after
> hiding it, and eventually crashes. It looks like some sort of race
> condition at least from a user perspective.
>
> https://github.com/driftyco/ionic/issues/5324
>
> If any comment please have the discussion over at Github or if pure
> Cordova bug in your own Jira. This mailing list can be a bit hard to handle.
>
> Thanks
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>


-- 

*Frederico Galvão*

Diretor de Tecnologia

PontoGet Inovação Web


( +55(62) 8131-5720

* www.pontoget.com.br