Re: [Android] CB-10625 Google Photos update breaks Camera's Gallery API

[julio cesar sanchez]

Sure, I can send it this weekend.

2016-02-18 18:49 GMT+01:00 Joe Bowser :

> Cool, want to send a PR so we can get this resolved? I tried string
> manipulation, but for some reason it didn't work.
>
> On Thu, Feb 18, 2016 at 1:22 AM, julio cesar sanchez <
> jcesarmob...@gmail.com
> > wrote:
>
> > I already answered on CB-10625
> >
> > When android 4.4 broke input type file support I wrote a plugin at work
> to
> > use a file picker instead.
> >
> > For google Photos I use this code:
> >
> > if (isGooglePhotosUri(uri))
> > return uri.getLastPathSegment();
> >
> > Where isGooglePhotosUri is
> >
> > public static boolean isGooglePhotosUri(Uri uri) {
> > return
> > "com.google.android.apps.photos.content".equals(uri.getAuthority());
> > }
> >
> > I tried it on the camera plugin and worked.
> >
> >
> > The plugin is based on this android library
> > https://github.com/iPaulPro/aFileChooser
> >
> > The relevant class is
> >
> >
> https://github.com/iPaulPro/aFileChooser/blob/master/aFileChooser/src/com/ipaulpro/afilechooser/utils/FileUtils.java
> >
> >
> >
> >
> > 2016-02-17 1:41 GMT+01:00 Joe Bowser :
> >
> > > Hey
> > >
> > > https://issues.apache.org/jira/browse/CB-10625
> > >
> > > For some reason Google Photos breaks the Camera's Gallery API, and I'm
> > > having trouble trying to fix this one.  For some reason I can't get the
> > > FileHelper to work with the new file URI that's being provided by an
> > > application.  Is there something obvious that we're missing here?
> > >
> > > Any thoughts?
> > >
> >
>

[GitHub] cordova-plugin-geolocation pull request: background location under...

[alejandromagnorsky]

Github user alejandromagnorsky commented on the pull request:


https://github.com/apache/cordova-plugin-geolocation/pull/51#issuecomment-186101074
  
I confirm that THIS plugin unexpectedly disabled another background 
geolocation plugin I'm using.
But @mauron85 fork (cordova-plugin-geolocation-ios9-fix) fixs it. So, 
please, if this pull request is equivalent to the fork, go for it since I need 
this update.
Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10521 Add OS X platform to docs

[tripodsan]

Github user tripodsan commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/496#discussion_r53429424
  
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -216,11 +220,13 @@ platform. See [Icons and Splash Screens](images.html) 
for more information.
DefaultVolumeStream(string) | *Default: default*  ==Android== 
Added in cordova-android 3.7.0, This preference sets which volume the hardware 
volume buttons link to. By default this is "call" for phones and "media" for 
tablets. Set this to "media" to have your app's volume buttons always change 
the media volume. Note that when using Cordova's media plugin, the volume 
buttons will dynamically change to controlling the media volume when any Media 
objects are active.
DisallowOverscroll(boolean) | *Default: false*  ==iOS== 
==Android==  Set to **true** if you don't want the interface to display 
any feedback when users scroll past the beginning or end of content. On iOS, 
overscroll gestures cause content to bounce back to its original position. on 
Android, they produce a more subtle glowing effect along the top or bottom edge 
of the content. 
EnableViewportScale(boolean) | *Default: false*   ==iOS==  
Set to true to allow a viewport meta tag to either disable or restrict the 
range of user scaling, which is enabled by default. Place a viewport such as 
the following in the HTML to disable scaling and fit content flexibly within 
the rendering WebView:  ``
+   EnableWebGL(boolean) | *Default: false*   ==OS X **4.0.0**==  
Set to true to enable WebGL on the web view.
--- End diff --

this is an OSX WebView preference. I'm not sure about others: 
http://stackoverflow.com/questions/13659133/enable-webgl-in-the-mac-os-application-on-webkit


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10521 Add OS X platform to docs

[tripodsan]

Github user tripodsan commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/496#discussion_r53429286
  
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -58,7 +58,8 @@ platform. See [Icons and Splash Screens](images.html) for 
more information.
id(string) | *Required*  Specifies the app's reverse-domain 
identifier, and the `version` its full version number expressed in 
major/minor/patch notation.
version(string) | *Required*  Full version number expressed in 
major/minor/patch notation.
versionCode(string) | ==Android==  Alternative version for 
Android. For further details, see [Android 
versioning](http://developer.android.com/tools/publishing/versioning.html)
-   CFBundleVersion(string) |  ==iOS==  Alternative version for iOS. 
For further details, see [iOS 
versioning](https://developer.apple.com/library/ios/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html#//apple_ref/doc/uid/20001431-102364).
+   ios-CFBundleVersion(string) |  ==iOS==  Alternative version for 
iOS. For further details, see [iOS 
versioning](https://developer.apple.com/library/ios/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html#//apple_ref/doc/uid/20001431-102364).
+   osx-CFBundleVersion(string) |  ==OS X==  Alternative version for 
OS X. For further details, see [OS X 
versioning](https://developer.apple.com/library/prerelease/mac/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html#//apple_ref/doc/uid/20001431-102364).
--- End diff --

cordova-ios uses `ios-CFBundleVersion` (which is wrong in the current doc), 
so I thought it would be weird to use the same for osx. I'm all for having the 
same attribute for both platforms.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10552 Replacing images in R...

[daserge]

Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/172#issuecomment-186081564
  
We could also add a Travis build step verifying that the `npm run gen-docs 
> TEMP_README.md` equals `README.md`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10552 Replacing images in R...

[daserge]

Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/172#issuecomment-186075786
  
@dblotsky, docs generation will run automatically as a pre-commit hook but 
you need to do `npm install` first. I agree this is not very intuitive though, 
and the corresponding dicsussion is 
[here](https://github.com/cordova/cordova-discuss/pull/16) in case you have 
some thoughts on improving the process.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-whitelist pull request: CB-10624 remove error messa...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-whitelist/pull/17


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-windows/pull/152#issuecomment-186026434
  
1. Why does running the script manually print repeatedly? Is that a use 
case?
2. What is the 2-second delay for? It doesn't wait on Ctrl-C if the script 
was run from Bash.
3. Running this using medic silently fails for me: 
`../cordova-medic/medic/medic.js log --platform windows`.
4. The `Dumping logs starting from 90` message is not very informative. 
Is there a way to print a more human-readable timeframe?
5. Are there any tests for this? Specifically, it would be good to verify 
that the timeouts passed around are correct.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-windows/pull/152#issuecomment-186026681
  
I just realized that a lot of my above comments apply to the logging script 
in general, not to this specific fix. This fix seems to work, so it LGTM. Only 
one question there: it doesn't work unless I run it with Administrator 
privileges first; is this expected?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-whitelist pull request: CB-10624 remove error messa...

[csantanapr]

Github user csantanapr commented on the pull request:


https://github.com/apache/cordova-plugin-whitelist/pull/17#issuecomment-186021548
  
Thanks @jcesarmobile for commenting we wanted someone to review it before 
we took it out.

@eymorale looks like it's OK to go ahead and remove then.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: Github issue and PR templates

[Dmitry Blotsky]

I like the idea. I suggest starting small and expanding as necessary. Right now 
the two most important pieces of information that I think our PRs could use are:

Did you sign the ICLA? [ ] Yes / [ ] No
Related JIRA: CB-[ ]

Kindly,
Dmitry

-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com] 
Sent: Thursday, February 18, 2016 5:55 PM
To: dev@cordova.apache.org
Subject: Re: Github issue and PR templates

I agree, Running tests as easy as npm install && npm run config && npm test
 :-)


On Thu, Feb 18, 2016 at 4:40 PM Nikhil Khandelwal 
wrote:

> I think for plugins, platform name should be required as part of title 
> of the PR and commit message in addition to JIRA number.
>
> Checklist:
> [ ] Tests that were added or run for a new feature/regressions [ ] 
> Does the new feature broadly apply to multiple platforms?
>
> We probably need to make it easier for contributors to run tests for 
> plugins.
>
> -Nikhil
>
> -Original Message-
> From: Steven Gill [mailto:stevengil...@gmail.com]
> Sent: Wednesday, February 17, 2016 1:42 PM
> To: dev@cordova.apache.org
> Subject: Github issue and PR templates
>
> Cool new feature from github!
> https://github.com/blog/2111-issue-and-pull-request-templates
>
> Since we don't do issues on github, that feature isn't useful to us. 
> But providing PR templates sounds like a good idea. Just need to add a 
> PULL_REQUEST_TEMPLATE.md to the root of our repos.
>
> What type of information would we ask for from PRs?
>
> * Issue number
>
> If it is a plugin
> * which platforms
>
> Thoughts?
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10521 Add OS X platform to docs

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/496#discussion_r53415988
  
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -216,11 +220,13 @@ platform. See [Icons and Splash Screens](images.html) 
for more information.
DefaultVolumeStream(string) | *Default: default*  ==Android== 
Added in cordova-android 3.7.0, This preference sets which volume the hardware 
volume buttons link to. By default this is "call" for phones and "media" for 
tablets. Set this to "media" to have your app's volume buttons always change 
the media volume. Note that when using Cordova's media plugin, the volume 
buttons will dynamically change to controlling the media volume when any Media 
objects are active.
DisallowOverscroll(boolean) | *Default: false*  ==iOS== 
==Android==  Set to **true** if you don't want the interface to display 
any feedback when users scroll past the beginning or end of content. On iOS, 
overscroll gestures cause content to bounce back to its original position. on 
Android, they produce a more subtle glowing effect along the top or bottom edge 
of the content. 
EnableViewportScale(boolean) | *Default: false*   ==iOS==  
Set to true to allow a viewport meta tag to either disable or restrict the 
range of user scaling, which is enabled by default. Place a viewport such as 
the following in the HTML to disable scaling and fit content flexibly within 
the rendering WebView:  ``
+   EnableWebGL(boolean) | *Default: false*   ==OS X **4.0.0**==  
Set to true to enable WebGL on the web view.
--- End diff --

Is this not supported by other platforms?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10521 Add OS X platform to docs

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/496#discussion_r53415915
  
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -58,7 +58,8 @@ platform. See [Icons and Splash Screens](images.html) for 
more information.
id(string) | *Required*  Specifies the app's reverse-domain 
identifier, and the `version` its full version number expressed in 
major/minor/patch notation.
version(string) | *Required*  Full version number expressed in 
major/minor/patch notation.
versionCode(string) | ==Android==  Alternative version for 
Android. For further details, see [Android 
versioning](http://developer.android.com/tools/publishing/versioning.html)
-   CFBundleVersion(string) |  ==iOS==  Alternative version for iOS. 
For further details, see [iOS 
versioning](https://developer.apple.com/library/ios/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html#//apple_ref/doc/uid/20001431-102364).
+   ios-CFBundleVersion(string) |  ==iOS==  Alternative version for 
iOS. For further details, see [iOS 
versioning](https://developer.apple.com/library/ios/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html#//apple_ref/doc/uid/20001431-102364).
+   osx-CFBundleVersion(string) |  ==OS X==  Alternative version for 
OS X. For further details, see [OS X 
versioning](https://developer.apple.com/library/prerelease/mac/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html#//apple_ref/doc/uid/20001431-102364).
--- End diff --

@tripodsan Why do these need to be two different settings in `config.xml`? 
The linked Apple docs have identical descriptions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10530 - App freezes sometimes directl...

[csantanapr]

Github user csantanapr commented on the pull request:

https://github.com/apache/cordova-ios/pull/193#issuecomment-186017788
  
Thanks @mhartington for testing you were able to recreate very easy in your 
setup.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Removing keyword index.

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/508#issuecomment-186014176
  
@stevengill just removing code that's not needed anymore. The search box at 
the top basically obsoletes it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Github issue and PR templates

[Carlos Santana]

I agree, Running tests as easy as npm install && npm run config && npm test
 :-)


On Thu, Feb 18, 2016 at 4:40 PM Nikhil Khandelwal 
wrote:

> I think for plugins, platform name should be required as part of title of
> the PR and commit message in addition to JIRA number.
>
> Checklist:
> [ ] Tests that were added or run for a new feature/regressions
> [ ] Does the new feature broadly apply to multiple platforms?
>
> We probably need to make it easier for contributors to run tests for
> plugins.
>
> -Nikhil
>
> -Original Message-
> From: Steven Gill [mailto:stevengil...@gmail.com]
> Sent: Wednesday, February 17, 2016 1:42 PM
> To: dev@cordova.apache.org
> Subject: Github issue and PR templates
>
> Cool new feature from github!
> https://github.com/blog/2111-issue-and-pull-request-templates
>
> Since we don't do issues on github, that feature isn't useful to us. But
> providing PR templates sounds like a good idea. Just need to add a
> PULL_REQUEST_TEMPLATE.md to the root of our repos.
>
> What type of information would we ask for from PRs?
>
> * Issue number
>
> If it is a plugin
> * which platforms
>
> Thoughts?
>

[GitHub] cordova-ios pull request: CB-10530 - App freezes sometimes directl...

[thomasMary]

Github user thomasMary commented on the pull request:

https://github.com/apache/cordova-ios/pull/193#issuecomment-186005928
  
Works for me. Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10336: Adding platform and plugin gu...

[rakatyal]

Github user rakatyal commented on the pull request:

https://github.com/apache/cordova-docs/pull/507#issuecomment-185996114
  
Merged 
[here](https://github.com/apache/cordova-docs/commit/f8e4b8b8ee0c9f0a8afef27a7d9a9c48b9274d36).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10336: Adding platform and plugin gu...

[rakatyal]

Github user rakatyal closed the pull request at:

https://github.com/apache/cordova-docs/pull/507


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Removing keyword index.

[rakatyal]

Github user rakatyal commented on the pull request:

https://github.com/apache/cordova-docs/pull/508#issuecomment-185993325
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Removing keyword index.

[stevengill]

Github user stevengill commented on the pull request:

https://github.com/apache/cordova-docs/pull/508#issuecomment-185991371
  
Looks fine to me. 

I don't know the context behind the change though. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Removing keyword index.

[dblotsky]

GitHub user dblotsky opened a pull request:

https://github.com/apache/cordova-docs/pull/508

Removing keyword index.

It has been replaced by search.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs no-keyword-index

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/508.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #508


commit a9a95453674e2a8cfca663d89ee18c40f5d1836e
Author: Dmitry Blotsky 
Date:   2016-02-18T23:35:33Z

Removing keyword index. It has been replaced by search.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Removing keyword index.

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/508#issuecomment-185980598
  
@rakatyal @stevengill please review when you have a moment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10336: Adding platform and plugin gu...

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-docs/pull/507#issuecomment-185978070
  
LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10336: Adding platform and plugin gu...

[rakatyal]

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/507#discussion_r53397157
  
--- Diff: www/_data/toc/de-dev-manual.yml ---
@@ -1,21 +1,37 @@
--   name: "Overview"
-url: "guide/overview/index.html"
-# -   name: "Architecture"
-# children:
-# -   name: "Runtime Architecture"
-# url:
-# -   name: "Tooling Architecture"
-# url:
+-   name: "Introduction"
+children:
+-   name: "Overview"
+url: "guide/overview/index.html"
+#   -   name: "Runtime Architecture"
+#   url:
+#   -   name: "Tooling Architecture"
+#   url:
 -   name: "Create apps"
 children:
 -   name: "Create your first app"
 url:
+-   name: "Platform support"
+url: "guide/support/index.html"
 -   name: "Develop for platforms"
-url: "guide/platforms/index.html"
+children:
+-   name: "Android"
+url: "guide/platforms/android/index.html"
+-   name: "Blackberry 10"
+url: "guide/platforms/blackberry10/home.html"
+-   name: "iOS"
+url: "guide/platforms/ios/index.html"
+-   name: "Ubuntu"
+url: "guide/platforms/ubuntu/index.html"
+-   name: "Windows"
+url: "guide/platforms/win8/index.html"
+-   name: "WP8"
+url: "guide/platforms/wp8/home.html"   

--- End diff --

That's still in PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10336: Adding platform and plugin gu...

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/507#discussion_r53396702
  
--- Diff: www/_data/toc/de-dev-manual.yml ---
@@ -1,21 +1,37 @@
--   name: "Overview"
-url: "guide/overview/index.html"
-# -   name: "Architecture"
-# children:
-# -   name: "Runtime Architecture"
-# url:
-# -   name: "Tooling Architecture"
-# url:
+-   name: "Introduction"
+children:
+-   name: "Overview"
+url: "guide/overview/index.html"
+#   -   name: "Runtime Architecture"
+#   url:
+#   -   name: "Tooling Architecture"
+#   url:
 -   name: "Create apps"
 children:
 -   name: "Create your first app"
 url:
+-   name: "Platform support"
+url: "guide/support/index.html"
 -   name: "Develop for platforms"
-url: "guide/platforms/index.html"
+children:
+-   name: "Android"
+url: "guide/platforms/android/index.html"
+-   name: "Blackberry 10"
+url: "guide/platforms/blackberry10/home.html"
+-   name: "iOS"
+url: "guide/platforms/ios/index.html"
+-   name: "Ubuntu"
+url: "guide/platforms/ubuntu/index.html"
+-   name: "Windows"
+url: "guide/platforms/win8/index.html"
+-   name: "WP8"
+url: "guide/platforms/wp8/home.html"   

--- End diff --

Is OS X supposed to be in this list, or has that content not made it in yet?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10336: Adding platform and plugin gu...

[rakatyal]

GitHub user rakatyal opened a pull request:

https://github.com/apache/cordova-docs/pull/507

CB-10336: Adding platform and plugin guides and other articles to TOC



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs raghav-toc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/507.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #507


commit 8c884767dfd017576a32e15b14ffa088a017cc96
Author: Raghav Katyal 
Date:   2016-02-18T22:30:23Z

Adding platform and plugin guides and other articles to TOC




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10530 - App freezes sometimes directl...

[mhartington]

Github user mhartington commented on the pull request:

https://github.com/apache/cordova-ios/pull/193#issuecomment-185951944
  
Same here, couldn't get anything to break for me. Thanks! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10530 - App freezes sometimes directl...

[dpogue]

Github user dpogue commented on the pull request:

https://github.com/apache/cordova-ios/pull/193#issuecomment-185951530
  
:+1: from me. I have not seen the splashscreen hanging bug while testing 
this branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10526: iOS Guide Improvements

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/505#discussion_r53392433
  
--- Diff: www/_data/redirects.yml ---
@@ -6,6 +6,8 @@ general:
 
 # redirects paths relative to /docs/XX/
 docs:
+- {old: "dev/guide/platforms/ios/tools.html", new: 
"dev/guide/platforms/ios/index.html"}
+- {old: "dev/guide/platforms/ios/config.html", new: 
"dev/config_ref/index.html"}
 
--- End diff --

Please also add redirects for `/latest/`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10526: iOS Guide Improvements

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/505#discussion_r53392250
  
--- Diff: www/_data/redirects.yml ---
@@ -166,3 +166,5 @@ docs-global:
 - {old: "guide_plugin-development_blackberry10_index.md.html", new: 
"guide/plugin-development/blackberry10/index.html"}
 - {old: "guide_privacy_index.md.html", new: "guide/privacy/index.html"}
 - {old: "guide_upgrading_windows-8_index.md.html", new: 
"guide/upgrading/windows-8/index.html"}
+- {old: "dev/guide/platforms/ios/tools.html", new: 
"dev/guide/platforms/ios/index.html"}
+- {old: "dev/guide/platforms/ios/config.html", new: 
"dev/config_ref/index.html"}
--- End diff --

@omefire By "version-specific", I mean redirects that hold across all 
languages but not across all versions (e.g. pages that are removed after a 
given version). The alternative is "global", which applies to redirects that 
hold across all languages and versions (e.g. renaming `index.html` to 
`index.htm` in all versions).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10526: iOS Guide Improvements

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/505#discussion_r53391759
  
--- Diff: www/_data/redirects.yml ---
@@ -6,6 +6,8 @@ general:
 
 # redirects paths relative to /docs/XX/
 docs:
+- {old: "dev/guide/platforms/ios/tools.html", new: 
"dev/guide/platforms/ios/index.html"}
+- {old: "dev/guide/platforms/ios/config.html", new: 
"dev/config_ref/index.html"}
 
--- End diff --

Should there also be a redirect for the upgrade page?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request: Fix for CB-10288

[jamessharp]

Github user jamessharp closed the pull request at:

https://github.com/apache/cordova-plugin-statusbar/pull/47


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request: Fix for CB-10288

[jamessharp]

Github user jamessharp commented on the pull request:


https://github.com/apache/cordova-plugin-statusbar/pull/47#issuecomment-185945597
  
Scrap that - no it doesn't - more work needed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10552 Replacing images in R...

[dblotsky]

Github user dblotsky commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/172#issuecomment-185941604
  
@daserge thanks for pointing that out. I made the change in the source. 
However, this was not a very intuitive process. Can this be done automatically?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Add cordova CLI readme docs

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-cli/pull/233#issuecomment-185939263
  
Merged here: 6b090dcf50da26ede6e9e642bd74bf2c9f7caa41


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: Add cordova CLI readme docs

[nikhilkh]

Github user nikhilkh closed the pull request at:

https://github.com/apache/cordova-cli/pull/233


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: Github issue and PR templates

[Nikhil Khandelwal]

I think for plugins, platform name should be required as part of title of the 
PR and commit message in addition to JIRA number. 

Checklist:
[ ] Tests that were added or run for a new feature/regressions
[ ] Does the new feature broadly apply to multiple platforms?

We probably need to make it easier for contributors to run tests for plugins.

-Nikhil

-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com] 
Sent: Wednesday, February 17, 2016 1:42 PM
To: dev@cordova.apache.org
Subject: Github issue and PR templates

Cool new feature from github!
https://github.com/blog/2111-issue-and-pull-request-templates

Since we don't do issues on github, that feature isn't useful to us. But 
providing PR templates sounds like a good idea. Just need to add a 
PULL_REQUEST_TEMPLATE.md to the root of our repos.

What type of information would we ask for from PRs?

* Issue number

If it is a plugin
* which platforms

Thoughts?

[GitHub] cordova-medic pull request: CB-10510: Reapply Android Emulator ret...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-medic/pull/80


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10644 Adds deprecation message about ...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/394#discussion_r53380925
  
--- Diff: cordova-lib/src/platforms/platforms.js ---
@@ -48,11 +48,17 @@ function getPlatformApi(platform, platformRootDir) {
 var PlatformApi;
 try {
 // First we need to find whether platform exposes its' API via js 
module
-// If it has, then we have to require it and extend BasePlatformApi
-// with platform's API.
+// If it does, then we require and instantiate it.
 var platformApiModule = path.join(platformRootDir, 'cordova', 
'Api.js');
 PlatformApi = require(platformApiModule);
 } catch (err) {
+// Check if platform already compatible w/ PlatformApi and show 
deprecation warning
+if (err && err.code === 'MODULE_NOT_FOUND' && 
platforms[platform].apiCompatibleSince) {
+events.emit('warn', 'The support for cordova-' + platform + ' 
via PlatformApi polyfill ' +
--- End diff --

instead of leaking internal implementation detail we should consider 
re-phrasing this as:
"Using this version of cordova CLI with older version of cordova- 
is being deprecated. Consider upgrading to..."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request: Fix for CB-10288

[jamessharp]

GitHub user jamessharp opened a pull request:

https://github.com/apache/cordova-plugin-statusbar/pull/47

Fix for CB-10288

The statusbar plugin was causing some weird sizing issues when multitasking 
on ipads etc. I think this fixes it. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ortoo/cordova-plugin-statusbar master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-statusbar/pull/47.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #47


commit 2f8a8a52f2c0bf1957b9dd7f00ec417f5da9ddd7
Author: James Sharp 
Date:   2016-02-18T19:42:29Z

Fix split screen issues in iOS 9




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

[sarangan12]

GitHub user sarangan12 opened a pull request:

https://github.com/apache/cordova-windows/pull/152

CB-10640: Windows logging is broken

**Issue**
In the current system, the logs which are collected in the events must be 
listed in the CI logs is broken. For example, if there is a syntax error in one 
of the plugins, mobilespec(during testing) will crash the app. This information 
is available in event logs. This must be collected in the '[Gathering 
logs](https://ci.apache.org/builders/cordova-windows-store8.1/builds/1660/steps/gathering-logs/logs/stdio)'
 step and be available in CI logs. But, that is not happening and must be 
fixed.  

**Root Cause**
The issue is traced to 2 cause. 

1. **Query** 
The query format that was used to retrieve the event logs is incorrect. For 
example, even when the 'View Events Logs' tool reports the error, if you run 
the exact command in command line, it just returns empty results. This query 
format must be fixed. 

2. **spawn**
The _wevtutil_ command is invoked through spawn (for collecting the event 
logs). This same approach is used in the same program at 4 different places 
(for various reasons). In all other scenarios, the output is correct, But, 
while collecting the event logs, the output is empty. This must be fixed. 

**Fix**
For Issue 1, the query format has been modified to use _timediff_ 
parameter. This is the approach that is used by the 'View Events Logs' tool. 
The resulting query is executed on both command line and through the script and 
confirmed that it is working fine. 

For Issue 2, I suspect that the root cause of the issue might be related to 
sending the parameters with '/'. But this theory could not be confirmed and 
modifying this did not work. Instead, the execSync approach did work fine. The 
same has been used. 

**Testing**
Two scenarios has been tested.

1.  **log using the medic.js**
This approach gets the logs for the last 27 minutes. It produces correct 
results as expected. 

2.  **Execute log directly without dump option**
In this scenario, it has to continuously display the logs repeatedly with 1 
second interval (until manually interrupted).It produces correct results as 
expected. 

@dblotsky @riknoll @nikhilkh @rakatyal @alsorokin Can you please review and 
merge this PR?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sarangan12/cordova-windows CB-10640

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/152.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #152


commit f54639b02cf226e4a96937935e6474c531fe502f
Author: Sarangan Rajamanickam 
Date:   2016-02-17T22:58:30Z

CB-10640: Windows logging is broken

Fixing the logging query




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10526: iOS Guide Improvements

[omefire]

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/505#discussion_r53368735
  
--- Diff: www/_data/redirects.yml ---
@@ -166,3 +166,5 @@ docs-global:
 - {old: "guide_plugin-development_blackberry10_index.md.html", new: 
"guide/plugin-development/blackberry10/index.html"}
 - {old: "guide_privacy_index.md.html", new: "guide/privacy/index.html"}
 - {old: "guide_upgrading_windows-8_index.md.html", new: 
"guide/upgrading/windows-8/index.html"}
+- {old: "dev/guide/platforms/ios/tools.html", new: 
"dev/guide/platforms/ios/index.html"}
+- {old: "dev/guide/platforms/ios/config.html", new: 
"dev/config_ref/index.html"}
--- End diff --

2. The redirects are necessary. For Example, The config.html file is not 
platform-specific anymore and has been turned into a reference doc. We need to 
redirect old urls to the new file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10526: iOS Guide Improvements

[omefire]

Github user omefire commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/505#discussion_r53367760
  
--- Diff: www/_data/redirects.yml ---
@@ -166,3 +166,5 @@ docs-global:
 - {old: "guide_plugin-development_blackberry10_index.md.html", new: 
"guide/plugin-development/blackberry10/index.html"}
 - {old: "guide_privacy_index.md.html", new: "guide/privacy/index.html"}
 - {old: "guide_upgrading_windows-8_index.md.html", new: 
"guide/upgrading/windows-8/index.html"}
+- {old: "dev/guide/platforms/ios/tools.html", new: 
"dev/guide/platforms/ios/index.html"}
+- {old: "dev/guide/platforms/ios/config.html", new: 
"dev/config_ref/index.html"}
--- End diff --

1. Thanks for pointing this out, Moving to ```docs``` section.
By being version-specific, you mean the redirects will only apply in the 
case of the dev/latest version ? (Just making sure).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [Android] CB-8976, CB-8453 and is there anyone building multiple APKs

[Darryl Pogue]

Not intentionally on my end, but when I add the CrossWalk plugin I
seem to get two APKs as output (one for armv7, one for x86).

On 18 February 2016 at 11:05, Joe Bowser  wrote:
>
> Hey
>
> Based on the feedback on those two issues, and other places, I think that
> most hated change from Cordova-Android 4.0 that we didn't fix in
> Cordova-Android 5.0 was the fact that we have an undocumented way of
> generating an arbitrary build number that makes absolutely no sense.
> Furthermore, this screws up people's automated builds, and can cause the
> version code to reach MAX_INT.
>
> If you want to know why nobody has touched it until now, it's because
> everyone hates working with Gradle.  I can say the exact same thing about
> why we're not using ProGuard.
>
> Now, I'm starting on my flensing of the gradle files that we have in here,
> trying to figure out what we can rip out and I'm wondering if anyone is
> actually using the multiple APK generation before I remove it. If people
> are, I'm going to have to figure out another way for this to happen,
> because this is definitely breaking people's applications, and using random
> hooks isn't a good answer.
>
> So, is anyone using this, or can this feature die!
>
> Joe

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [Android] CB-8976, CB-8453 and is there anyone building multiple APKs

[Carlos Santana]

Might want to check with CrossWalk plugin, I think they generate multiple
APKs but is good to check if they depend on cordova for this or they handle
on their own.


On Thu, Feb 18, 2016 at 2:05 PM Joe Bowser  wrote:

> Hey
>
> Based on the feedback on those two issues, and other places, I think that
> most hated change from Cordova-Android 4.0 that we didn't fix in
> Cordova-Android 5.0 was the fact that we have an undocumented way of
> generating an arbitrary build number that makes absolutely no sense.
> Furthermore, this screws up people's automated builds, and can cause the
> version code to reach MAX_INT.
>
> If you want to know why nobody has touched it until now, it's because
> everyone hates working with Gradle.  I can say the exact same thing about
> why we're not using ProGuard.
>
> Now, I'm starting on my flensing of the gradle files that we have in here,
> trying to figure out what we can rip out and I'm wondering if anyone is
> actually using the multiple APK generation before I remove it. If people
> are, I'm going to have to figure out another way for this to happen,
> because this is definitely breaking people's applications, and using random
> hooks isn't a good answer.
>
> So, is anyone using this, or can this feature die!
>
> Joe
>

[Android] CB-8976, CB-8453 and is there anyone building multiple APKs

[Joe Bowser]

Hey

Based on the feedback on those two issues, and other places, I think that
most hated change from Cordova-Android 4.0 that we didn't fix in
Cordova-Android 5.0 was the fact that we have an undocumented way of
generating an arbitrary build number that makes absolutely no sense.
Furthermore, this screws up people's automated builds, and can cause the
version code to reach MAX_INT.

If you want to know why nobody has touched it until now, it's because
everyone hates working with Gradle.  I can say the exact same thing about
why we're not using ProGuard.

Now, I'm starting on my flensing of the gradle files that we have in here,
trying to figure out what we can rip out and I'm wondering if anyone is
actually using the multiple APK generation before I remove it. If people
are, I'm going to have to figure out another way for this to happen,
because this is definitely breaking people's applications, and using random
hooks isn't a good answer.

So, is anyone using this, or can this feature die!

Joe

[GitHub] cordova-android pull request: CB-10628 Fix emulate android --targe...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/260


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: New plugin version selection implementat...

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-lib/pull/363#issuecomment-185850104
  
@TimBarham thanks for the review; I'll update the PR in a bit!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: New plugin version selection implementat...

[riknoll]

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/363#discussion_r53358585
  
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
 
 return null;
 }
+
+/**
+ * Gets the version of a plugin that should be fetched for a given project 
based
+ * on the plugin's engine information from NPM and the platforms/plugins 
installed
+ * in the project
+ *
+ * @param {string}  projectRoot The path to the root directory of the 
project
+ * @param {object}  pluginInfo  The NPM info of the plugin be fetched 
(e.g. the
+ *  result of calling `registry.info()`)
+ * @param {string}  cordovaVersion  The semver version of cordova-lib
+ *
+ * @return {Promise}A promise that will resolve to either 
a string
+ *  if there is a version of the plugin 
that this
+ *  project satisfies or null if there is 
not
+ */
+function getFetchVersion(projectRoot, pluginInfo, cordovaVersion) {
+// Figure out the project requirements
+if (pluginInfo.engines && pluginInfo.engines.cordovaDependencies) {
+var pluginList = getInstalledPlugins(projectRoot);
+var pluginMap = {};
+
+for(var i = 0; i < pluginList.length; i++) {
+pluginMap[pluginList[i].id] = pluginList[i].version;
+}
+
+return cordova_util.getInstalledPlatformsWithVersions(projectRoot)
+.then(function(platformVersions) {
+return determinePluginVersionToFetch(
+pluginInfo.versions,
+pluginInfo.engines.cordovaDependencies,
+pluginMap,
+platformVersions,
+cordovaVersion);
+});
+} else {
+// If we have no engine, we want to fall back to the default 
behavior
+return Q.fcall(function() {
+return null;
+});
+}
+}
+
+function determinePluginVersionToFetch(allVersions, engine, pluginMap, 
platformMap, cordovaVersion) {
+var upperBounds = [];
+var versions = [];
+
+for(var version in engine) {
+if(version.indexOf('<') === 0 && 
semver.valid(version.substring(1))) {
+// We only care about upper bounds that our project does not 
support
+if(!satisfiesProjectRequirements(engine[version], pluginMap, 
platformMap, cordovaVersion)) {
+upperBounds.push(version);
+}
+} else if(semver.valid(version) && allVersions.indexOf(version) 
!== -1) {
+versions.push(version);
+}
+}
+
+// Sort in descending order; we want to start at latest and work back
+versions.sort(semver.rcompare);
+
+for(var i = 0; i < versions.length; i++) {
+for(var j = 0; j < upperBounds.length; j++) {
+if(semver.satisfies(versions[i], upperBounds[j])) {
+// Because we sorted in desc. order, if we find an upper 
bound
+// that applies to this version (and the ones below) we 
can just
+// quit (we already filtered out ones that our project 
supports)
+return null;
+}
+}
+
+// Check the version constraint
+if(satisfiesProjectRequirements(engine[versions[i]], pluginMap, 
platformMap, cordovaVersion)) {
+// Because we sorted in descending order, we can stop 
searching once
+// we hit a satisfied constraint
+var index = versions.indexOf(versions[i]);
+if(index > 0) {
+// Return the highest plugin version below the next highest
+// constrainted version
+var nextHighest = versions[index - 1];
+return allVersions[allVersions.indexOf(nextHighest) - 1];
+} else {
+// Return the latest plugin version
+return allVersions[allVersions.length - 1];
+}
+}
+}
+
+// No constraints were satisfied
+return null;
+}
+
+function satisfiesProjectRequirements(reqs, pluginMap, platformMap, 
cordovaVersion) {
+for (var req in reqs) {
+var okay = true;
+
+if(pluginMap[req]) {
+okay = semver.satisfies(pluginMap[req], reqs[req]);
+} else if(req === 'cordova') {
+okay = semver.satisfies(cordovaVersion, reqs[req]);
+} else if(req.indexOf('cordova-') === 0) {
+// Might be a platform constraint
--- End diff --

I origin

[GitHub] cordova-docs pull request: CB-10332 Android Guide Improvements

[rakatyal]

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/471#discussion_r53357772
  
--- Diff: www/docs/en/dev/guide/platforms/android/plugin.md ---
@@ -23,24 +23,17 @@ title: Android Plugins
 # Android Plugins
 
 This section provides details for how to implement native plugin code
-on the Android platform. Before reading this, see Application Plugins
+on the Android platform. Before reading this, see the [Plugin Development 
Guide][plugin-dev]
--- End diff --

I am okay with anything as long as it's consistent. 'Android Development 
Guide' and 'Android Plugin Development Guide' and so on for each platform?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [Android] CB-10625 Google Photos update breaks Camera's Gallery API

[Joe Bowser]

Cool, want to send a PR so we can get this resolved? I tried string
manipulation, but for some reason it didn't work.

On Thu, Feb 18, 2016 at 1:22 AM, julio cesar sanchez  wrote:

> I already answered on CB-10625
>
> When android 4.4 broke input type file support I wrote a plugin at work to
> use a file picker instead.
>
> For google Photos I use this code:
>
> if (isGooglePhotosUri(uri))
> return uri.getLastPathSegment();
>
> Where isGooglePhotosUri is
>
> public static boolean isGooglePhotosUri(Uri uri) {
> return
> "com.google.android.apps.photos.content".equals(uri.getAuthority());
> }
>
> I tried it on the camera plugin and worked.
>
>
> The plugin is based on this android library
> https://github.com/iPaulPro/aFileChooser
>
> The relevant class is
>
> https://github.com/iPaulPro/aFileChooser/blob/master/aFileChooser/src/com/ipaulpro/afilechooser/utils/FileUtils.java
>
>
>
>
> 2016-02-17 1:41 GMT+01:00 Joe Bowser :
>
> > Hey
> >
> > https://issues.apache.org/jira/browse/CB-10625
> >
> > For some reason Google Photos breaks the Camera's Gallery API, and I'm
> > having trouble trying to fix this one.  For some reason I can't get the
> > FileHelper to work with the new file URI that's being provided by an
> > application.  Is there something obvious that we're missing here?
> >
> > Any thoughts?
> >
>

[GitHub] cordova-android pull request: CB-10628 Fix emulate android --targe...

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-android/pull/260#issuecomment-185830008
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: Give option for Splashsc...

[daserge]

Github user daserge commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/83#issuecomment-185826893
  
@dhams, Travis CI has been setup for Device plugin as of now, so you can 
disregard the CI message.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: Use of .travis.yml file

[Sergey Shakhnazarov (Akvelon)]

Hello,

Travis CI has been enabled for all the plugins recently in order to run JSHint 
[1] validation.

.travis.yml setup has been done and merged for cordova-plugin-device as of now, 
other plugins will be updated soon.

[1]: https://issues.apache.org/jira/browse/CB-10636 

Please let me know if you have any questions or considerations.

Best regards,
Sergey Shakhnazarov.

-Original Message-
From: dharmendra sharma [mailto:dharam.in...@gmail.com] 
Sent: Thursday, February 18, 2016 17:05
To: dev@cordova.apache.org
Subject: Use of .travis.yml file

I am trying to commit some code in Splashscreen plugin . but its giving error 
like "Travis can suddenly not find .travis.yml even though it exists"
while I try to submit the pull request..

Can someone plz tell me how to add .travis.yml file where to add this ?

--
Thank you
Dharmendra sharma

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10641 Run prepare _after_ plugins wer...

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-lib/pull/393#issuecomment-185819372
  
Is this fixing a regression in behavior from previous versions? Let's make 
sure we label the associated JIRAs as such.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Update to starter template

[Raymond Camden]

Big plus one to Jesse's comment. I've felt like the template is too
over complex for quite some time.

On Tue, Feb 16, 2016 at 3:21 PM, Ryan J. Salva  wrote:
> Check out the default template we use in TACO-CLI.
>
> Index.js is a lot simpler and we adopted the new Cordova typeface. If folks 
> like this template, we could issue a PR for it.
>
> rjs
>
>
> Ryan J. Salva  |  Principal PM Manager
> Visual Studio Tools for Apache Cordova
> rsa...@microsoft.com
> 425 706 5270 office
> 206 612 5079 mobile
>
> -Original Message-
> From: Parashuram N [mailto:panar...@microsoft.com]
> Sent: Tuesday, February 16, 2016 12:46 PM
> To: dev@cordova.apache.org
> Subject: RE: [DISCUSS] Update to starter template
>
> I do agree that our starter app needs to change. However, we encountered this 
> when we were looking at documenting, and our object of concern was the way 
> events are bound. My suggestion would be to simply fix the event binding so 
> that the docs are less confusing.
>
> We could then look at re-writing the starter-app itself.
>
> -Original Message-
> From: Jesse [mailto:purplecabb...@gmail.com]
> Sent: Tuesday, February 16, 2016 12:28 PM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Update to starter template
>
> Personally, I think we should rewrite/simplify that template ALOT.
> The app binding stuff is confusing to users, but not potentially any less 
> confusing with PR#15. The use of an object is the issue in my mind.
>
> Also, if this is the starting point for a new developer, they will soon 
> wonder why everything they add to the page is UPPERCASE, part of the css, but 
> potentially confusing.
>
> Ultimately, I think the whole starting point is over-organized with it's 
> multiple folders.  PR#5 is closer to the goal I think, although I would still 
> leave js in an external file, and not directly in index.html and I would 
> leave quotes on html tag attributes.
>
>
>
>
>
> @purplecabbage
> https://na01.safelinks.protection.outlook.com/?url=risingj.com&data=01%7c01%7cpanarasi%40microsoft.com%7ca55c7ca45ac24069c54708d337118610%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=%2bCP4GywoLaqppsEXaqZxo%2br%2baBb0%2b%2babaAImEmW4ZMg%3d
>
> On Tue, Feb 16, 2016 at 11:07 AM, Parashuram N 
> wrote:
>
>> Will do.
>>
>> -Original Message-
>> From: Steven Gill [mailto:stevengil...@gmail.com]
>> Sent: Tuesday, February 16, 2016 10:44 AM
>> To: dev@cordova.apache.org
>> Subject: Re: [DISCUSS] Update to starter template
>>
>> LGTM
>>
>> Could you also add the keyword 'cordova:template' to package.json?
>>
>> On Tue, Feb 16, 2016 at 9:58 AM, Parashuram N 
>> wrote:
>>
>> > :) Sounds good
>> >
>> > Anyone else have any objections to the change ?
>> >
>> > -Original Message-
>> > From: Carlos Santana [mailto:csantan...@gmail.com]
>> > Sent: Monday, February 15, 2016 7:51 PM
>> > To: dev@cordova.apache.org
>> > Subject: Re: [DISCUSS] Update to starter template
>> >
>> > I'm always in favor of having simple answers and guidelines, and we
>> > can take this as a good convention/practice
>> >
>> > "Always bind/attach after deviceready even and you will be in a
>> > happy place"
>> >
>> > But between you and me you know that we can attach before, will
>> > leave that little secret between us :-)
>> >
>> >
>> > On Mon, Feb 15, 2016 at 10:44 PM Parashuram N
>> > 
>> > wrote:
>> >
>> > > The reason to say that all events are fired after device ready is
>> > > just to make it simpler. As you say, events by webviews are indeed
>> > > fired before that, but I think it is safe to say that if we attach
>> > > listeners after deviceready, we are guaranteed to have the plugins
>> > > also initialized. This makes for a more consistent story.
>> > >
>> > >
>> > >
>> > > On 2/15/16, 7:25 PM, "Carlos Santana"  wrote:
>> > >
>> > > >Why do you think that binding is required after "deviceready" ?
>> > > >
>> > > >Attaching before "deviceready" fires is still supported for
>> > > >events like resume, pause, offline, online, etc.. At least that's
>> > > >always being my impression for a long time
>> > > >
>> > > >The only thing I would think it could be a potential confusion
>> > > >that would benefit to attached after "deviceready" is that if
>> > > >there is an "online" or "offline" event fire by webview [1], [2]
>> > > >and not plugin those handlers
>> > > will
>> > > >fire but will not be from the network plugin.
>> > > >
>> > > >One thing I like thought about the PR is making index.js less
>> > > >verbose and simpler to follow +1
>> > > >
>> > > >[1]:
>> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fd
>> > > ev
>> > > el
>> > > oper.mozilla.org%2fen-US%2fdocs%2fWeb%2fEvents%2foffline&data=01%7
>> > > c0
>> > > 1%
>> > > 7cpanarasi%40microsoft.com%7c54f8ca7873ae4337a50608d33680f157%7c72
>> > > f9
>> > > 88
>> > > bf86f141af91ab2d7cd011db47%7c1&sdata=8%2b4NzK8zAB%2ffqryeM%2fN9XYn
>> > > mu
>> > > lm
>> > > bzlAeIogT9H1b4ic%3d
>> > > >[2]:
>> > > https://na01.safelinks.protectio

[GitHub] cordova-plugin-battery-status pull request: CB-10645 The battery s...

[aaront]

Github user aaront commented on the pull request:


https://github.com/apache/cordova-plugin-battery-status/pull/31#issuecomment-185781196
  
JIRA link: https://issues.apache.org/jira/browse/CB-10645


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-battery-status pull request: CB-10645 The battery s...

[aaront]

GitHub user aaront opened a pull request:

https://github.com/apache/cordova-plugin-battery-status/pull/31

CB-10645 The battery status handler doesn't reinitialize on Android after 
window.location.reload()

Instead of throwing an error, rather remove the status handler and 
re-initialize.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Geotab/cordova-plugin-battery-status 
CB-10645cordova-plugin-battery-status

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-battery-status/pull/31.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #31


commit cddf8daefc07471a13405e4ff2b8fed4e1b378f8
Author: Aaron Toth 
Date:   2016-02-18T15:23:47Z

The battery status handler doesn't reinitialize on Android after 
window.reload(). Instead of throwing an error, rather remove the status handler 
and re-initialize.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [DISCUSS] Old platforms support deprecation

[Vladimir Kotikov (Akvelon)]

Hey, guys.

I've opened a PR that adds a message about deprecation. Could anybody please 
review that? 

The only question I wanted to know your opinion on is where we should print 
this message. In the PR above cordova-lib will show it each time when polyfill 
is instantiated and this might be annoying a bit.
Another approach could be similar to deprecation messages for "wp8" and 
"amazon-fireos" - show message only when platform is added to project.

Thoughts?

-
Best regards, Vladimir


-Original Message-
From: David Barth [mailto:david.ba...@canonical.com] 
Sent: Wednesday, January 27, 2016 5:39 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Old platforms support deprecation

On Mon, Jan 25, 2016 at 8:16 PM, Steven Gill  wrote:

> Nikhil, sounds reasonable.
>
> I originally misunderstood Vlads message. He isn't proposing the 
> PlatformAPI Polyfill for deprecation. This is the code which is used 
> by platforms that haven't released a platform API implementation.
>
> He is suggesting removing code from cordova-lib that supports
> * cordova-android < 5
> * cordova-ios < 4
> * cordova-windows < 4.3.0
> * cordova-osx < 4
>
> Platforms that haven't implemented PlatformAPI Pollyfill
> * Browser
> * BlackBerry
> * WP8 (In deprecation mode)
> * WebOS
> * Ubuntu
>

Just to chime in for Ubuntu to say that we're moving to the new PlatformAPI, 
but not ready just yet.

David

[GitHub] cordova-lib pull request: CB-10519 Wrap all sync calls inside of `...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-lib/pull/384#issuecomment-185747825
  
The return value of `Q.then(thePromise)` is the same as for `thePromise()` 
due to its' (promise) nature, so i think there is nothing changed for caller.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10644 Adds deprecation message about ...

[vladimir-kotikov]

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-lib/pull/394

CB-10644 Adds deprecation message about old platforms support removal

JIRA: [CB-10644](https://issues.apache.org/jira/browse/CB-10644)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-lib CB-10644

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/394.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #394


commit ed9b586dc0df3743864aa5f5bc6e8837513eb4fd
Author: Vladimir Kotikov 
Date:   2016-01-22T11:22:35Z

CB-10644 Adds deprecation message about old platforms support removal




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Use of .travis.yml file

[dharmendra sharma]

I am trying to commit some code in Splashscreen plugin . but its giving
error like
"Travis can suddenly not find .travis.yml even though it exists"
while I try to submit the pull request..

Can someone plz tell me how to add .travis.yml file where to add this ?

-- 
Thank you
Dharmendra sharma

[GitHub] cordova-lib pull request: CB-10641 Run prepare _after_ plugins wer...

[TimBarham]

Github user TimBarham commented on the pull request:

https://github.com/apache/cordova-lib/pull/393#issuecomment-185729885
  
Yep, that looks right to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10519 Wrap all sync calls inside of `...

[TimBarham]

Github user TimBarham commented on the pull request:

https://github.com/apache/cordova-lib/pull/384#issuecomment-185719821
  
Oops, sorry :smile: ... LGTM. There's nowhere we call these directly 
internally and expect an actual value in return?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Remote site plugin

[Brad Reynolds]

Thanks for the reply Parashuram.  I hadn't looked at ManifoldJS but now
that I have I don't think that's the route I want to take, for my use case
a least.  The plugin was quite helpful.  This was what I was looking for on
the iOS side:

https://github.com/manifoldjs/ManifoldCordova/blob/master/src/ios/CDVHostedWebApp.m#L93

I was hoping I could avoid wrapping the webview delegate but it appears
there isn't another way to get at these events (according to this plugin).
It's a bit of a hack but I think it's one I could live.

Thanks for the help.

Brad


On Wed, Feb 17, 2016 at 3:59 PM Parashuram N  wrote:

> Hey Brad,
>
> This sounds pretty cool. Have you also looked at projects like ManifoldJS
> - http://manifoldjs.com/? They also do almost the same thing. They also
> have a Cordova plugin that displays an error page when you go offline. Note
> that Manifold is not a plugin, but a tool built on top of Cordova.
>
> Here is a link to the plugin that does the online-offline scenario -
> https://github.com/manifoldjs/ManifoldCordova.
>
> -Original Message-
> From: Brad Reynolds [mailto:bradleyja...@gmail.com]
> Sent: Wednesday, February 17, 2016 11:29 AM
> To: dev@cordova.apache.org
> Subject: Remote site plugin
>
> We built a Cordova app that wraps a remote site.  The only HTML page
> bundled in our app redirects to our remote site on load.  I was new to
> Cordova at the time and was looking for the fastest way possible to get the
> app out the door.  To do so I modified the generated iOS and Android
> projects with the hooks I felt I needed in order to inject Cordova
> components and plugins into the remote site.  It seems to be working for us
> and has been accepted by both app stores.
>
> I'd like to package up the modifications for this as a plugin as we plan
> to build other apps in the same manner.  I've been familiarizing myself
> with the plugin architecture and am not sure if what I need is exposed on
> both platforms and thus this email to the dev list.  I'm looking for
> guidance on how to implement the hooks I've listed below as a plugin.  The
> end goal is to inject the Cordova components and plugins and allow the user
> to retry loading the site upon error.  Below are details of the changes I
> made.  I'm going to keep digging on my own but any direction would be
> greatly appreciated.
>
> Thanks,
> Brad Reynolds
>
> ## iOS
>
> iOS was pretty simple to get up and running.  The generated
> MainViewController had page life cycle methods that I was able to easily
> hook into and inject Cordova.
>
> ### MainViewController.m Changes:
>
> 1. Implemented `webViewDidFinishLoad:(UIWebView *)theWebView` to inject
> Cordova components.
>
> To allow the user to retry reloading the current page upon failure:
>
> 1. Implemented `webView:(UIWebView *)theWebView
> didFailLoadWithError:(NSError *)error`.
>
> ## Android
>
> Android was more difficult or at least I had to look for something other
> than page events.  The end result was I used Android's
> `@JavascriptInterface` mechanism to make a JS object available that would
> inject Cordova into the current page.  As a result all loaded pages needed
> to look for this object and invoke an initialization function on it.
>
> 1. Subclassed SystemWebViewEngine and added config.xml entry to use our
> engine.
> 2. Subclassed SystemWebView and returned from our engine.
> 3. Within our SystemWebView subclass added a JavascriptInterface providing
> a hook back into Android. When invoked this told the Adroid code it was
> time to inject Cordova.
>
> To allow the user to retry reloading the current page:
>
> 1. Implemented MainActivity.onReceivedError(...).
>

[GitHub] cordova-plugin-splashscreen pull request: Give option for Splashsc...

[dhams]

Github user dhams commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/83#issuecomment-185711822
  
trying to correct travis-ci issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: Give option for Splashsc...

[dhams]

Github user dhams closed the pull request at:

https://github.com/apache/cordova-plugin-splashscreen/pull/83


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10303 Add tests to cover argument...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/145


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10641 Run prepare _after_ plugins wer...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-lib/pull/393#issuecomment-185703790
  
@TimBarham, could you please take a look


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10519 Wrap all sync calls inside of `...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-lib/pull/384#issuecomment-185703661
  
@TimBarham, ping


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: Give option for Splashsc...

[dhams]

GitHub user dhams opened a pull request:

https://github.com/apache/cordova-plugin-splashscreen/pull/83

Give option for Splashscreen spinner cancelable event

Added option to choose user whether they want cancelable dialog or not 
while loading splashscreen.
I added preference ` 
`where user can choose this. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accenture/cordova-plugin-splashscreen 
CB-10643splashscreen

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-splashscreen/pull/83.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #83


commit d82b76cba98915612be960d9f66891584dfb215b
Author: bbadrinath 
Date:   2016-02-10T06:56:29Z

Merge pull request #1 from apache/master

Rebasing the forked branch from 3.1.1 to current master branch 3.2.0

commit 803d52fc4a7349be131650c615723477e6e534a4
Author: Sharma 
Date:   2016-02-10T08:41:24Z

Fixed doccument issue

commit ab1b3815d7991bdb76b73d35c3bbfb0e1cc82bb8
Author: Sharma 
Date:   2016-02-18T12:12:20Z

Added new prefrence choose dialog cancelable or not




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10628 Fix emulate android --targe...

[daserge]

Github user daserge commented on the pull request:

https://github.com/apache/cordova-android/pull/260#issuecomment-185698067
  
@nikhilkh, please take a look.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10636 Add JSHint for plugin...

[daserge]

Github user daserge commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/173#discussion_r53307265
  
--- Diff: src/windows/CameraProxy.js ---
@@ -19,7 +19,7 @@
  *
 */
 
-/*jshint unused:true, undef:true, browser:true */
+/*jshint unused:true, undef:true, browser:true, latedef: false  */
--- End diff --

I'm going to reconsider this later today.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10636 Add JSHint for plugin...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/173

CB-10636 Add JSHint for plugins

[Jira issue](https://issues.apache.org/jira/browse/CB-10636)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/daserge/cordova-plugin-camera CB-10636

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/173.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #173


commit ad21352a1d95e69505198745a0bd84367b91027d
Author: daserge 
Date:   2016-02-18T12:18:09Z

CB-10636 Add JSHint for plugins




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Cordova-common 1.1.0 release

[Carlos Santana]

I agree shrinkwrap is better technical, it was just buggy in the past and now I 
think is more stable. 

Also in the past there was a debate if the shrinkwrap goes in git, as it 
confuse some committers when they updated a dependency in package.json then npm 
install nothing got updated, why? because package.json got ignore and 
shrinkwrap was in place

The are multiple goals not just that dependencies don't change, but also Legal

We don't want to a hard dependency on package that has a license that prevents 
a downstream (i.e. Worklight) to redistribute or build software with such 
dependency packages with not healthy licenses. 

That's why one of the reasons we do bundling today in git of 3rd party npm 
packages for platform repos, better chance and more eyes on the license of this 
packages on what's included when we do a release. 

I don't mind changing how we build software we just need to be mindful 

- Carlos
@csantanapr

> On Feb 18, 2016, at 3:18 AM, Vladimir Kotikov (Akvelon) 
>  wrote:
> 
> I don’t have a strict opinion about dynamic vs static dependencies, but IMO 
> if we want to pin the version of every subdependency, shrinkwrap is better 
> than bundling. At least it would be less prone to human errors (missing 
> packages' files, line endings in subpackages - we'd ran into all of this 
> already).
> -
> Best regards, Vladimir 
> 
> -Original Message-
> From: Carlos Santana [mailto:csantan...@gmail.com] 
> Sent: Tuesday, February 16, 2016 7:23 PM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Cordova-common 1.1.0 release
> 
> Sorry for the typo. I meant
> If I install a piece of software component version 1.2.3 today, and install 
> version 1.2.3 a week after I'm expecting to reproduce the same environment.
> 
> Net is that a user complains to us about problem, we should be able to 
> reproduce it if we know the version number, and not just tell them try to npm 
> install again and the problem might go away, and some times the reason it 
> goes away and starts working is because one of the dependencies changed and 
> the software is not longer the same as the one he as having problems.
> 
> On Tue, Feb 16, 2016 at 11:20 AM Carlos Santana 
> wrote:
> 
>> I'm not big fan of dynamic dependencies, but I'm fan a predictable and 
>> reproducible environments
>> 
>> managing dependencies during development is much different than 
>> managing dependencies when go live into production.
>> 
>> Take into account that not just the cordova code that runs on the 
>> phone runtime I consider as production code, the cordova code that 
>> users get for tooling I also consider as production code as it's used in 
>> devops systems.
>> 
>> That's why is best practice to bundle all the code that the nodejs 
>> server is going to need when going into production, and recently have 
>> heard that folks are using docker images that build nodejs  core 
>> binary with static libraries to not rely on the dynamic libraries from the 
>> operating system.
>> 
>> If I install a piece of software component version 1.2.3 today, and 
>> install version 2.3.0 a week after I'm expecting to reproduce the same 
>> environment.
>> With the way npm handles dependecies, and folks declare dependencies 
>> in pacakge.json we can cordova can only control one level down in 
>> dependency tree.
>> 
>> That's why npmshrinkwrap is used when producing release build or just 
>> bundle dependency with release build.
>> 
>> I think in npm3 npmshrinkwrap function was improved to be more 
>> deterministic
>> 
>> 
>> 
>> On Tue, Feb 16, 2016 at 7:50 AM Vladimir Kotikov (Akvelon) < 
>> v-vlk...@microsoft.com> wrote:
>> 
>>> Yes, a new patch release, I think.
>>> Can't wait when we start to install platforms as packages - then we 
>>> won't need to bundle everything :)
>>> 
>>> -
>>> Best regards, Vladimir
>>> 
>>> -Original Message-
>>> From: Carlos Santana [mailto:csantan...@gmail.com]
>>> Sent: Tuesday, February 16, 2016 3:23 PM
>>> To: dev@cordova.apache.org
>>> Subject: Re: [DISCUSS] Cordova-common 1.1.0 release
>>> 
>>> Vladimir,
>>>  I forgot about that it's a bundled dependency. No blog is need it 
>>> then
>>> 
>>> But a new Windows platform release will be required to be able to 
>>> pick up the new cordova-commons release right?
>>> 
>>> - Carlos
>>> @csantanapr
>>> 
>>> On Feb 16, 2016, at 5:23 AM, Vladimir Kotikov (Akvelon) < 
>>> v-vlk...@microsoft.com> wrote:
>>> 
> cordova-windows won't as it has the dependency listed as ^1.0.0 
> which
>>> includes minor releases.
 IMO since cordova-common is a bundled dependency, we still need for 
 new
>>> release to bundle new version.
 
 A small question - do we need for blog post for this release? I'd 
 say
>>> no, as we releasing something for internal use, but what is your thoughts?
 
 -
 Best regards, Vladimir
 
 -Original Message-
 From: Steven Gill [mailto:stevengil...@gmail.com]
 Sent: Tuesday, Febr

[GitHub] cordova-lib pull request: New plugin version selection implementat...

[TimBarham]

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/363#discussion_r53305903
  
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
 
 return null;
 }
+
+/**
+ * Gets the version of a plugin that should be fetched for a given project 
based
+ * on the plugin's engine information from NPM and the platforms/plugins 
installed
+ * in the project
+ *
+ * @param {string}  projectRoot The path to the root directory of the 
project
+ * @param {object}  pluginInfo  The NPM info of the plugin be fetched 
(e.g. the
+ *  result of calling `registry.info()`)
+ * @param {string}  cordovaVersion  The semver version of cordova-lib
+ *
+ * @return {Promise}A promise that will resolve to either 
a string
+ *  if there is a version of the plugin 
that this
+ *  project satisfies or null if there is 
not
+ */
+function getFetchVersion(projectRoot, pluginInfo, cordovaVersion) {
+// Figure out the project requirements
+if (pluginInfo.engines && pluginInfo.engines.cordovaDependencies) {
+var pluginList = getInstalledPlugins(projectRoot);
+var pluginMap = {};
+
+for(var i = 0; i < pluginList.length; i++) {
+pluginMap[pluginList[i].id] = pluginList[i].version;
+}
+
+return cordova_util.getInstalledPlatformsWithVersions(projectRoot)
+.then(function(platformVersions) {
+return determinePluginVersionToFetch(
+pluginInfo.versions,
+pluginInfo.engines.cordovaDependencies,
+pluginMap,
+platformVersions,
+cordovaVersion);
+});
+} else {
+// If we have no engine, we want to fall back to the default 
behavior
+return Q.fcall(function() {
+return null;
+});
+}
+}
+
+function determinePluginVersionToFetch(allVersions, engine, pluginMap, 
platformMap, cordovaVersion) {
+var upperBounds = [];
+var versions = [];
+
+for(var version in engine) {
+if(version.indexOf('<') === 0 && 
semver.valid(version.substring(1))) {
+// We only care about upper bounds that our project does not 
support
+if(!satisfiesProjectRequirements(engine[version], pluginMap, 
platformMap, cordovaVersion)) {
+upperBounds.push(version);
+}
+} else if(semver.valid(version) && allVersions.indexOf(version) 
!== -1) {
+versions.push(version);
+}
+}
+
+// Sort in descending order; we want to start at latest and work back
+versions.sort(semver.rcompare);
+
+for(var i = 0; i < versions.length; i++) {
+for(var j = 0; j < upperBounds.length; j++) {
+if(semver.satisfies(versions[i], upperBounds[j])) {
+// Because we sorted in desc. order, if we find an upper 
bound
+// that applies to this version (and the ones below) we 
can just
+// quit (we already filtered out ones that our project 
supports)
+return null;
+}
+}
+
+// Check the version constraint
+if(satisfiesProjectRequirements(engine[versions[i]], pluginMap, 
platformMap, cordovaVersion)) {
+// Because we sorted in descending order, we can stop 
searching once
+// we hit a satisfied constraint
+var index = versions.indexOf(versions[i]);
+if(index > 0) {
+// Return the highest plugin version below the next highest
+// constrainted version
+var nextHighest = versions[index - 1];
+return allVersions[allVersions.indexOf(nextHighest) - 1];
+} else {
+// Return the latest plugin version
+return allVersions[allVersions.length - 1];
+}
+}
+}
+
+// No constraints were satisfied
+return null;
+}
+
+function satisfiesProjectRequirements(reqs, pluginMap, platformMap, 
cordovaVersion) {
+for (var req in reqs) {
+var okay = true;
+
+if(pluginMap[req]) {
+okay = semver.satisfies(pluginMap[req], reqs[req]);
+} else if(req === 'cordova') {
+okay = semver.satisfies(cordovaVersion, reqs[req]);
+} else if(req.indexOf('cordova-') === 0) {
+// Might be a platform constraint
--- End diff --

Should

[GitHub] cordova-lib pull request: New plugin version selection implementat...

[TimBarham]

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/363#discussion_r53305804
  
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
 
 return null;
 }
+
+/**
+ * Gets the version of a plugin that should be fetched for a given project 
based
+ * on the plugin's engine information from NPM and the platforms/plugins 
installed
+ * in the project
+ *
+ * @param {string}  projectRoot The path to the root directory of the 
project
+ * @param {object}  pluginInfo  The NPM info of the plugin be fetched 
(e.g. the
+ *  result of calling `registry.info()`)
+ * @param {string}  cordovaVersion  The semver version of cordova-lib
+ *
+ * @return {Promise}A promise that will resolve to either 
a string
+ *  if there is a version of the plugin 
that this
+ *  project satisfies or null if there is 
not
+ */
+function getFetchVersion(projectRoot, pluginInfo, cordovaVersion) {
+// Figure out the project requirements
+if (pluginInfo.engines && pluginInfo.engines.cordovaDependencies) {
+var pluginList = getInstalledPlugins(projectRoot);
+var pluginMap = {};
+
+for(var i = 0; i < pluginList.length; i++) {
+pluginMap[pluginList[i].id] = pluginList[i].version;
+}
+
+return cordova_util.getInstalledPlatformsWithVersions(projectRoot)
+.then(function(platformVersions) {
+return determinePluginVersionToFetch(
+pluginInfo.versions,
+pluginInfo.engines.cordovaDependencies,
+pluginMap,
+platformVersions,
+cordovaVersion);
+});
+} else {
+// If we have no engine, we want to fall back to the default 
behavior
+return Q.fcall(function() {
+return null;
+});
+}
+}
+
+function determinePluginVersionToFetch(allVersions, engine, pluginMap, 
platformMap, cordovaVersion) {
+var upperBounds = [];
+var versions = [];
+
+for(var version in engine) {
+if(version.indexOf('<') === 0 && 
semver.valid(version.substring(1))) {
+// We only care about upper bounds that our project does not 
support
+if(!satisfiesProjectRequirements(engine[version], pluginMap, 
platformMap, cordovaVersion)) {
+upperBounds.push(version);
+}
+} else if(semver.valid(version) && allVersions.indexOf(version) 
!== -1) {
+versions.push(version);
+}
+}
+
+// Sort in descending order; we want to start at latest and work back
+versions.sort(semver.rcompare);
+
+for(var i = 0; i < versions.length; i++) {
+for(var j = 0; j < upperBounds.length; j++) {
+if(semver.satisfies(versions[i], upperBounds[j])) {
+// Because we sorted in desc. order, if we find an upper 
bound
+// that applies to this version (and the ones below) we 
can just
+// quit (we already filtered out ones that our project 
supports)
+return null;
+}
+}
+
+// Check the version constraint
+if(satisfiesProjectRequirements(engine[versions[i]], pluginMap, 
platformMap, cordovaVersion)) {
+// Because we sorted in descending order, we can stop 
searching once
+// we hit a satisfied constraint
+var index = versions.indexOf(versions[i]);
+if(index > 0) {
+// Return the highest plugin version below the next highest
+// constrainted version
+var nextHighest = versions[index - 1];
+return allVersions[allVersions.indexOf(nextHighest) - 1];
+} else {
+// Return the latest plugin version
+return allVersions[allVersions.length - 1];
+}
+}
+}
+
+// No constraints were satisfied
+return null;
+}
+
+function satisfiesProjectRequirements(reqs, pluginMap, platformMap, 
cordovaVersion) {
+for (var req in reqs) {
+var okay = true;
+
+if(pluginMap[req]) {
+okay = semver.satisfies(pluginMap[req], reqs[req]);
+} else if(req === 'cordova') {
+okay = semver.satisfies(cordovaVersion, reqs[req]);
+} else if(req.indexOf('cordova-') === 0) {
+// Might be a platform constraint
+var platform = req

[GitHub] cordova-lib pull request: New plugin version selection implementat...

[TimBarham]

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/363#discussion_r53305710
  
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -154,6 +135,38 @@ module.exports = function plugin(command, targets, 
opts) {
 is_top_level: true
 };
 
+// If no version is specified, retrieve the 
version (or source) from config.xml
+if (!version && !cordova_util.isUrl(id) && 
!cordova_util.isDirectory(id)) {
+events.emit('verbose', 'no version specified, 
retrieving version from config.xml');
+var ver = getVersionFromConfigFile(id, cfg);
+
+if (cordova_util.isUrl(ver) || 
cordova_util.isDirectory(ver)) {
+target = ver;
+} else if (ver) {
+// If version exists in config.xml, use 
that
+target = ver ? (id + '@' + ver) : target;
+} else {
+// If no version is given at all, We need 
to decide what version to
+// fetch based on the current project
+return registry.info([id])
+.then(function(pluginInfo) {
+return getFetchVersion(projectRoot, 
pluginInfo, pkgJson.version);
+})
+.then(function(fetchVersion) {
+// Fallback to pinned version if 
available
+fetchVersion = fetchVersion ? 
fetchVersion : pkgJson.cordovaPlugins[id];
--- End diff --

`getFetchVersion()` could return null in two scenarios:
* The plugin didn't specify any constraints.
* The plugin specifies constraints and we fail to meet them.

It seems we really should be able to differentiate between these two 
scenarios. For example:
* Should we only fall back on pinned version if the plugin doesn't define 
constraints?
* If the plugin does define constraints and we fail to meet them, should we 
display a warning that we're picking a plugin version that might not work?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Android and iOS bug release

[Carlos Santana]

Frederico 

I didn't want unnecessary pressure on anyone to work on a bug by putting a 
release  on hold. 

I spent some time with Mike from Ionic and I was not able to reproduce or make 
heads or tail out of this bug. 

I'm glad to hear progress on the bug, thanks to Torsten and Shaz :-)

- Carlos
@csantanapr

> On Feb 17, 2016, at 4:34 AM, Frederico Galvão 
>  wrote:
> 
> It seems Shaz sorted the bug out already [1]. And I agree with and
> understand every point you made, Carlos. Thank you.
> 
> 
> [1] - https://github.com/apache/cordova-ios/pull/193
> 
> 2016-02-16 16:22 GMT-02:00 Carlos Santana :
> 
>> Cutting releases don't cost $$, just some time
>> 
>> We just try to minimize effort and consolidate many bugs that are ready for
>> one release.
>> 
>> if we have a fix that can make it in the release window that's OK to wait,
>> but we can always do a bug release today, and another bug release when that
>> bug is fix
>> 
>> If there is outlook to get the bug fix soon, I would say we wait but if not
>> then we just pick it up on the next bug release.
>> 
>> Looking at the JIRA the bug is still under investigation
>> 
>> 
>> 
>> On Tue, Feb 16, 2016 at 9:18 AM Frederico Galvão <
>> frederico.gal...@pontoget.com.br> wrote:
>> 
>>> https://issues.apache.org/jira/browse/CB-10530 is a showstopper for
>> quite
>>> a
>>> few people. If that ever requires changes to cordova-ios, I'm voting that
>>> the bugfix releases wait for it or that we find a workaround that isn't
>>> uninstalling every plugin.
>>> 
>>> 2016-02-16 1:58 GMT-02:00 Carlos Santana :
>>> 
 Tomorrow is my birthday, I will take them as gifts :-)
 
 
 On Mon, Feb 15, 2016 at 10:55 PM Steven Gill 
 wrote:
 
> Yeah, I can start these releases. Hopefully tomorrow.
> 
> -Steve
> 
> On Mon, Feb 15, 2016 at 7:46 PM, Carlos Santana <
>> csantan...@gmail.com>
> wrote:
> 
>> +1
>> Steve would you mind doing these bug release?
>> 
>> Should we wait to see what happens with the ios freeze bug [1],? or
 just
> do
>> a bug release now, and then do another later when that one is
>>> resolved
> and
>> keep the train going
>> 
>> [1] : https://issues.apache.org/jira/browse/CB-10530
>> 
>> 
>>> On Mon, Feb 15, 2016 at 6:01 PM Dan Polivy 
>> wrote:
>> 
>>> Is there any progress on an android bugfix release? It looks like
>>> Richard's PR has been merged in, and I'm waiting for that (and
>> the
 fix
>> for
>>> CB-10138) to be pushed out in a production release.
>>> 
>>> Thanks,
>>> Dan
>>> 
>>> -Original Message-
>>> From: Carlos Santana [mailto:csantan...@gmail.com]
>>> Sent: Thursday, February 04, 2016 5:23 PM
>>> To: dev@cordova.apache.org
>>> Subject: Re: Android and iOS bug release
>>> 
>>> I will take a look
>>> 
>>> On Thu, Feb 4, 2016 at 1:23 PM Richard Knoll <
>>> rikn...@microsoft.com>
>>> wrote:
>>> 
 I have a PR open in cordova-android that should probably be
>>> merged
>> first.
 It addresses a bug in the save/restore API that a few people
>> are
>>> hitting. I
 still have some updates/testing to do but I hope to merge it in
 soon.
>>> Would
 love some feedback if anyone has a chance to review.
 
 The PR is here:
 https://github.com/apache/cordova-android/pull/257
 
 And the JIRA is here:
 https://issues.apache.org/jira/browse/CB-10498
 
 Thanks,
 Richard
 
 -Original Message-
 From: Carlos Santana [mailto:csantan...@gmail.com]
 Sent: Thursday, February 4, 2016 4:56 AM
 To: dev@cordova.apache.org
 Subject: Android and iOS bug release
 
 Should we do a patch releaseand pick up a few bugs seating
>>> master?
 -
 To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
 For additional commands, e-mail: dev-h...@cordova.apache.org
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>> 
>>> 
>>> 
>>> --
>>> 
>>> *Frederico Galvão*
>>> 
>>> Diretor de Tecnologia
>>> 
>>> PontoGet Inovação Web
>>> 
>>> 
>>> ( +55(62) 8131-5720
>>> 
>>> * www.pontoget.com.br 
> 
> 
> 
> -- 
> 
> *Frederico Galvão*
> 
> Diretor de Tecnologia
> 
> PontoGet Inovação Web
> 
> 
> ( +55(62) 8131-5720
> 
> * www.pontoget.com.br 

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: New plugin version selection implementat...

[TimBarham]

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/363#discussion_r53305319
  
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
 
 return null;
 }
+
+/**
+ * Gets the version of a plugin that should be fetched for a given project 
based
+ * on the plugin's engine information from NPM and the platforms/plugins 
installed
+ * in the project
+ *
+ * @param {string}  projectRoot The path to the root directory of the 
project
+ * @param {object}  pluginInfo  The NPM info of the plugin be fetched 
(e.g. the
+ *  result of calling `registry.info()`)
+ * @param {string}  cordovaVersion  The semver version of cordova-lib
+ *
+ * @return {Promise}A promise that will resolve to either 
a string
+ *  if there is a version of the plugin 
that this
+ *  project satisfies or null if there is 
not
+ */
+function getFetchVersion(projectRoot, pluginInfo, cordovaVersion) {
+// Figure out the project requirements
+if (pluginInfo.engines && pluginInfo.engines.cordovaDependencies) {
+var pluginList = getInstalledPlugins(projectRoot);
+var pluginMap = {};
+
+for(var i = 0; i < pluginList.length; i++) {
+pluginMap[pluginList[i].id] = pluginList[i].version;
+}
+
+return cordova_util.getInstalledPlatformsWithVersions(projectRoot)
+.then(function(platformVersions) {
+return determinePluginVersionToFetch(
+pluginInfo.versions,
+pluginInfo.engines.cordovaDependencies,
+pluginMap,
+platformVersions,
+cordovaVersion);
+});
+} else {
+// If we have no engine, we want to fall back to the default 
behavior
+return Q.fcall(function() {
+return null;
+});
+}
+}
+
+function determinePluginVersionToFetch(allVersions, engine, pluginMap, 
platformMap, cordovaVersion) {
+var upperBounds = [];
+var versions = [];
+
+for(var version in engine) {
+if(version.indexOf('<') === 0 && 
semver.valid(version.substring(1))) {
+// We only care about upper bounds that our project does not 
support
+if(!satisfiesProjectRequirements(engine[version], pluginMap, 
platformMap, cordovaVersion)) {
+upperBounds.push(version);
+}
+} else if(semver.valid(version) && allVersions.indexOf(version) 
!== -1) {
+versions.push(version);
+}
+}
+
+// Sort in descending order; we want to start at latest and work back
+versions.sort(semver.rcompare);
+
+for(var i = 0; i < versions.length; i++) {
+for(var j = 0; j < upperBounds.length; j++) {
+if(semver.satisfies(versions[i], upperBounds[j])) {
+// Because we sorted in desc. order, if we find an upper 
bound
+// that applies to this version (and the ones below) we 
can just
+// quit (we already filtered out ones that our project 
supports)
+return null;
+}
+}
+
+// Check the version constraint
+if(satisfiesProjectRequirements(engine[versions[i]], pluginMap, 
platformMap, cordovaVersion)) {
+// Because we sorted in descending order, we can stop 
searching once
+// we hit a satisfied constraint
+var index = versions.indexOf(versions[i]);
+if(index > 0) {
+// Return the highest plugin version below the next highest
+// constrainted version
+var nextHighest = versions[index - 1];
+return allVersions[allVersions.indexOf(nextHighest) - 1];
+} else {
+// Return the latest plugin version
+return allVersions[allVersions.length - 1];
+}
+}
+}
+
+// No constraints were satisfied
+return null;
--- End diff --

Weren't we going to display a warning in this scenario?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apach

[GitHub] cordova-lib pull request: New plugin version selection implementat...

[TimBarham]

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/363#discussion_r53304887
  
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
 
 return null;
 }
+
+/**
+ * Gets the version of a plugin that should be fetched for a given project 
based
+ * on the plugin's engine information from NPM and the platforms/plugins 
installed
+ * in the project
+ *
+ * @param {string}  projectRoot The path to the root directory of the 
project
+ * @param {object}  pluginInfo  The NPM info of the plugin be fetched 
(e.g. the
+ *  result of calling `registry.info()`)
+ * @param {string}  cordovaVersion  The semver version of cordova-lib
+ *
+ * @return {Promise}A promise that will resolve to either 
a string
+ *  if there is a version of the plugin 
that this
+ *  project satisfies or null if there is 
not
+ */
+function getFetchVersion(projectRoot, pluginInfo, cordovaVersion) {
+// Figure out the project requirements
+if (pluginInfo.engines && pluginInfo.engines.cordovaDependencies) {
+var pluginList = getInstalledPlugins(projectRoot);
+var pluginMap = {};
+
+for(var i = 0; i < pluginList.length; i++) {
+pluginMap[pluginList[i].id] = pluginList[i].version;
+}
+
+return cordova_util.getInstalledPlatformsWithVersions(projectRoot)
+.then(function(platformVersions) {
+return determinePluginVersionToFetch(
+pluginInfo.versions,
+pluginInfo.engines.cordovaDependencies,
+pluginMap,
+platformVersions,
+cordovaVersion);
+});
+} else {
+// If we have no engine, we want to fall back to the default 
behavior
+return Q.fcall(function() {
+return null;
+});
+}
+}
+
+function determinePluginVersionToFetch(allVersions, engine, pluginMap, 
platformMap, cordovaVersion) {
+var upperBounds = [];
+var versions = [];
+
+for(var version in engine) {
+if(version.indexOf('<') === 0 && 
semver.valid(version.substring(1))) {
+// We only care about upper bounds that our project does not 
support
+if(!satisfiesProjectRequirements(engine[version], pluginMap, 
platformMap, cordovaVersion)) {
+upperBounds.push(version);
+}
+} else if(semver.valid(version) && allVersions.indexOf(version) 
!== -1) {
+versions.push(version);
+}
+}
+
+// Sort in descending order; we want to start at latest and work back
+versions.sort(semver.rcompare);
+
+for(var i = 0; i < versions.length; i++) {
+for(var j = 0; j < upperBounds.length; j++) {
+if(semver.satisfies(versions[i], upperBounds[j])) {
+// Because we sorted in desc. order, if we find an upper 
bound
+// that applies to this version (and the ones below) we 
can just
+// quit (we already filtered out ones that our project 
supports)
+return null;
+}
+}
+
+// Check the version constraint
+if(satisfiesProjectRequirements(engine[versions[i]], pluginMap, 
platformMap, cordovaVersion)) {
+// Because we sorted in descending order, we can stop 
searching once
+// we hit a satisfied constraint
+var index = versions.indexOf(versions[i]);
+if(index > 0) {
+// Return the highest plugin version below the next highest
+// constrainted version
--- End diff --

Typo ("constrained").


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: New plugin version selection implementat...

[TimBarham]

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/363#discussion_r53304649
  
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
 
 return null;
 }
+
+/**
+ * Gets the version of a plugin that should be fetched for a given project 
based
+ * on the plugin's engine information from NPM and the platforms/plugins 
installed
+ * in the project
+ *
+ * @param {string}  projectRoot The path to the root directory of the 
project
+ * @param {object}  pluginInfo  The NPM info of the plugin be fetched 
(e.g. the
+ *  result of calling `registry.info()`)
+ * @param {string}  cordovaVersion  The semver version of cordova-lib
+ *
+ * @return {Promise}A promise that will resolve to either 
a string
+ *  if there is a version of the plugin 
that this
+ *  project satisfies or null if there is 
not
+ */
+function getFetchVersion(projectRoot, pluginInfo, cordovaVersion) {
+// Figure out the project requirements
+if (pluginInfo.engines && pluginInfo.engines.cordovaDependencies) {
+var pluginList = getInstalledPlugins(projectRoot);
+var pluginMap = {};
+
+for(var i = 0; i < pluginList.length; i++) {
+pluginMap[pluginList[i].id] = pluginList[i].version;
+}
+
+return cordova_util.getInstalledPlatformsWithVersions(projectRoot)
+.then(function(platformVersions) {
+return determinePluginVersionToFetch(
+pluginInfo.versions,
+pluginInfo.engines.cordovaDependencies,
+pluginMap,
+platformVersions,
+cordovaVersion);
+});
+} else {
+// If we have no engine, we want to fall back to the default 
behavior
+return Q.fcall(function() {
+return null;
+});
+}
+}
+
+function determinePluginVersionToFetch(allVersions, engine, pluginMap, 
platformMap, cordovaVersion) {
+var upperBounds = [];
+var versions = [];
+
+for(var version in engine) {
+if(version.indexOf('<') === 0 && 
semver.valid(version.substring(1))) {
+// We only care about upper bounds that our project does not 
support
+if(!satisfiesProjectRequirements(engine[version], pluginMap, 
platformMap, cordovaVersion)) {
+upperBounds.push(version);
+}
+} else if(semver.valid(version) && allVersions.indexOf(version) 
!== -1) {
+versions.push(version);
+}
+}
--- End diff --

So do we only support version ranges in the form of `

[GitHub] cordova-android pull request: CB-10628 Fix emulate android --targe...

[daserge]

Github user daserge commented on the pull request:

https://github.com/apache/cordova-android/pull/260#issuecomment-185680615
  
Worked on this with @vladimir-kotikov - there is a way to solve this using 
`require.cache` but it looks like an overkill for this case. 
Decided to require `check_reqs` at runtime instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10641 Run prepare _after_ plugins wer...

[vladimir-kotikov]

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-lib/pull/393

CB-10641 Run prepare _after_ plugins were installed

This is a fix for 
[CB-10641](https://issues.apache.org/jira/browse/CB-10641) and 
[CB-10586](https://issues.apache.org/jira/browse/CB-10586)
 
This PR changes order of operations in `cordova.raw.platform('add', ...)` 
method so `cordova.raw.prepare` is called after all plugins installed into 
platform. Also apart from resolving the issue above, the new flow 
(`platform_add -> install_plugins -> prepare`) looks semantically more correct.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-lib CB-10641

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/393.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #393


commit 3b9face5187857d354d85f3e3f4316cbace100db
Author: Vladimir Kotikov 
Date:   2016-02-17T15:48:31Z

CB-10641 Run prepare _after_ plugins were installed

commit b04db5feaf5516836c8a157cc3331b75d6dca0eb
Author: Vladimir Kotikov 
Date:   2016-02-18T10:08:47Z

CB-10641 Adds tests for order of operations in platform add




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: New plugin version selection implementat...

[TimBarham]

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/363#discussion_r53302711
  
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
 
 return null;
 }
+
+/**
+ * Gets the version of a plugin that should be fetched for a given project 
based
+ * on the plugin's engine information from NPM and the platforms/plugins 
installed
+ * in the project
+ *
+ * @param {string}  projectRoot The path to the root directory of the 
project
+ * @param {object}  pluginInfo  The NPM info of the plugin be fetched 
(e.g. the
+ *  result of calling `registry.info()`)
+ * @param {string}  cordovaVersion  The semver version of cordova-lib
+ *
+ * @return {Promise}A promise that will resolve to either 
a string
+ *  if there is a version of the plugin 
that this
+ *  project satisfies or null if there is 
not
+ */
+function getFetchVersion(projectRoot, pluginInfo, cordovaVersion) {
+// Figure out the project requirements
+if (pluginInfo.engines && pluginInfo.engines.cordovaDependencies) {
--- End diff --

Could you document in the comments what we expect `cordovaDependencies` to 
look like? It would make this code a lot easier to understand.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: New plugin version selection implementat...

[TimBarham]

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/363#discussion_r53301932
  
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
 
 return null;
 }
+
+/**
+ * Gets the version of a plugin that should be fetched for a given project 
based
+ * on the plugin's engine information from NPM and the platforms/plugins 
installed
+ * in the project
+ *
+ * @param {string}  projectRoot The path to the root directory of the 
project
+ * @param {object}  pluginInfo  The NPM info of the plugin be fetched 
(e.g. the
+ *  result of calling `registry.info()`)
+ * @param {string}  cordovaVersion  The semver version of cordova-lib
+ *
+ * @return {Promise}A promise that will resolve to either 
a string
+ *  if there is a version of the plugin 
that this
+ *  project satisfies or null if there is 
not
+ */
+function getFetchVersion(projectRoot, pluginInfo, cordovaVersion) {
+// Figure out the project requirements
+if (pluginInfo.engines && pluginInfo.engines.cordovaDependencies) {
+var pluginList = getInstalledPlugins(projectRoot);
+var pluginMap = {};
+
+for(var i = 0; i < pluginList.length; i++) {
+pluginMap[pluginList[i].id] = pluginList[i].version;
+}
+
+return cordova_util.getInstalledPlatformsWithVersions(projectRoot)
+.then(function(platformVersions) {
+return determinePluginVersionToFetch(
+pluginInfo.versions,
+pluginInfo.engines.cordovaDependencies,
+pluginMap,
+platformVersions,
+cordovaVersion);
+});
+} else {
+// If we have no engine, we want to fall back to the default 
behavior
+return Q.fcall(function() {
+return null;
+});
--- End diff --

I think here you just need `return Q(null);` (returns a promise fulfilled 
with `null`).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: New plugin version selection implementat...

[TimBarham]

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/363#discussion_r53301382
  
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
 
 return null;
 }
+
+/**
+ * Gets the version of a plugin that should be fetched for a given project 
based
+ * on the plugin's engine information from NPM and the platforms/plugins 
installed
+ * in the project
+ *
+ * @param {string}  projectRoot The path to the root directory of the 
project
+ * @param {object}  pluginInfo  The NPM info of the plugin be fetched 
(e.g. the
+ *  result of calling `registry.info()`)
+ * @param {string}  cordovaVersion  The semver version of cordova-lib
+ *
+ * @return {Promise}A promise that will resolve to either 
a string
+ *  if there is a version of the plugin 
that this
+ *  project satisfies or null if there is 
not
+ */
+function getFetchVersion(projectRoot, pluginInfo, cordovaVersion) {
+// Figure out the project requirements
+if (pluginInfo.engines && pluginInfo.engines.cordovaDependencies) {
+var pluginList = getInstalledPlugins(projectRoot);
+var pluginMap = {};
+
+for(var i = 0; i < pluginList.length; i++) {
+pluginMap[pluginList[i].id] = pluginList[i].version;
+}
--- End diff --

Minor nit, but this would be cleaner if you used `pluginList.forEach()` (or 
even `pluginList.reduce()`).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: New plugin version selection implementat...

[TimBarham]

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/363#discussion_r53300652
  
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -154,6 +135,38 @@ module.exports = function plugin(command, targets, 
opts) {
 is_top_level: true
 };
 
+// If no version is specified, retrieve the 
version (or source) from config.xml
+if (!version && !cordova_util.isUrl(id) && 
!cordova_util.isDirectory(id)) {
+events.emit('verbose', 'no version specified, 
retrieving version from config.xml');
+var ver = getVersionFromConfigFile(id, cfg);
+
+if (cordova_util.isUrl(ver) || 
cordova_util.isDirectory(ver)) {
+target = ver;
+} else if (ver) {
+// If version exists in config.xml, use 
that
+target = ver ? (id + '@' + ver) : target;
--- End diff --

I know this isn't your code - but would be good to clean this up while 
we're here... We already know `ver` has a value (since that is the condition of 
the `if` statement), so this should just be `target = id + '@' + ver`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: New plugin version selection implementat...

[TimBarham]

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/363#discussion_r53300300
  
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -154,6 +135,38 @@ module.exports = function plugin(command, targets, 
opts) {
 is_top_level: true
 };
 
+// If no version is specified, retrieve the 
version (or source) from config.xml
+if (!version && !cordova_util.isUrl(id) && 
!cordova_util.isDirectory(id)) {
+events.emit('verbose', 'no version specified, 
retrieving version from config.xml');
+var ver = getVersionFromConfigFile(id, cfg);
+
+if (cordova_util.isUrl(ver) || 
cordova_util.isDirectory(ver)) {
+target = ver;
+} else if (ver) {
+// If version exists in config.xml, use 
that
+target = ver ? (id + '@' + ver) : target;
+} else {
+// If no version is given at all, We need 
to decide what version to
+// fetch based on the current project
+return registry.info([id])
+.then(function(pluginInfo) {
+return getFetchVersion(projectRoot, 
pluginInfo, pkgJson.version);
+})
+.then(function(fetchVersion) {
+// Fallback to pinned version if 
available
+fetchVersion = fetchVersion ? 
fetchVersion : pkgJson.cordovaPlugins[id];
--- End diff --

Simplify to `fetchVersion = fetchVersion || pkgJson.cordovaPlugins[id];` 
:smile: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: New plugin version selection implementat...

[TimBarham]

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/363#discussion_r53300134
  
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -154,6 +135,38 @@ module.exports = function plugin(command, targets, 
opts) {
 is_top_level: true
 };
 
+// If no version is specified, retrieve the 
version (or source) from config.xml
+if (!version && !cordova_util.isUrl(id) && 
!cordova_util.isDirectory(id)) {
+events.emit('verbose', 'no version specified, 
retrieving version from config.xml');
+var ver = getVersionFromConfigFile(id, cfg);
+
+if (cordova_util.isUrl(ver) || 
cordova_util.isDirectory(ver)) {
+target = ver;
+} else if (ver) {
+// If version exists in config.xml, use 
that
+target = ver ? (id + '@' + ver) : target;
+} else {
+// If no version is given at all, We need 
to decide what version to
+// fetch based on the current project
+return registry.info([id])
+.then(function(pluginInfo) {
+return getFetchVersion(projectRoot, 
pluginInfo, pkgJson.version);
+})
+.then(function(fetchVersion) {
+// Fallback to pinned version if 
available
+fetchVersion = fetchVersion ? 
fetchVersion : pkgJson.cordovaPlugins[id];
+target = fetchVersion ? (id + '@' + 
fetchVersion) : target;
+
+events.emit('verbose', 'Calling 
plugman.fetch on plugin "' + target + '"');
+return plugman.raw.fetch(target, 
pluginPath, fetchOptions);
+})
+.then(function (directory) {
+return 
pluginInfoProvider.get(directory);
+});
--- End diff --

We don't want this code duplicating the code below. It's only a couple of 
lines now, but it leaves us open to problems later on if changes are made to 
what we do here. Instead, I'd suggest moving this whole `if` block (that is, 
`if (!version && !cordova_util.isUrl(id) && !cordova_util.isDirectory(id)) { 
... }`) to a separate method that returns a promise for a version. Then you can 
have a single `plugman.raw.fetch()` and `pluginInfoProvider.get()` regardless 
of whether the operation to determine the version is sync or async.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: New plugin version selection implementat...

[TimBarham]

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/363#discussion_r53299072
  
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -154,6 +135,38 @@ module.exports = function plugin(command, targets, 
opts) {
 is_top_level: true
 };
 
+// If no version is specified, retrieve the 
version (or source) from config.xml
+if (!version && !cordova_util.isUrl(id) && 
!cordova_util.isDirectory(id)) {
+events.emit('verbose', 'no version specified, 
retrieving version from config.xml');
+var ver = getVersionFromConfigFile(id, cfg);
--- End diff --

I know this is just moved code, but while you're here could you make that 
sentence start with an uppercase "N" (as in "No version specified...")? :smile: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: New plugin version selection implementat...

[TimBarham]

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/363#discussion_r53298695
  
--- Diff: cordova-lib/src/cordova/util.js ---
@@ -185,6 +187,31 @@ function listPlatforms(project_dir) {
 });
 }
 
+function getInstalledPlatformsWithVersions(project_dir) {
+var platforms_on_fs = listPlatforms(project_dir);
+
+return Q.all(platforms_on_fs.map(function(p) {
+return superspawn.maybeSpawn(path.join(project_dir, 'platforms', 
p, 'cordova', 'version'), [], { chmod: true })
+.then(function(v) {
+return {
+platform: p,
+version: v ? v : null
--- End diff --

Minor nit, but `v ? v : null` can be simplified to `v || null`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: New plugin version selection implementat...

[TimBarham]

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/363#discussion_r53298645
  
--- Diff: cordova-lib/src/cordova/util.js ---
@@ -185,6 +187,31 @@ function listPlatforms(project_dir) {
 });
 }
 
+function getInstalledPlatformsWithVersions(project_dir) {
+var platforms_on_fs = listPlatforms(project_dir);
+
+return Q.all(platforms_on_fs.map(function(p) {
+return superspawn.maybeSpawn(path.join(project_dir, 'platforms', 
p, 'cordova', 'version'), [], { chmod: true })
+.then(function(v) {
+return {
+platform: p,
+version: v ? v : null
+};
+}, function(v) {
+return {
+platform: p,
+version: 'broken'
+};
+});
+})).then(function(platformVersions) {
+var result = {};
+for(var i = 0; i < platformVersions.length; i++) {
+result[platformVersions[i].platform] = 
platformVersions[i].version;
+}
+return result;
+});
+}
--- End diff --

The above method would be simplified if you just accumulated the `result` 
object as you go... As in... initialize `result` before the `Q.all()` call, 
then instead of, for example, `return { platform: p, version: v ? v : null };` 
you would just do `result[p] = v || null;`. In the final then, you would ignore 
the parameter and just return `result`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: New plugin version selection implementat...

[TimBarham]

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/363#discussion_r53297519
  
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -492,17 +492,13 @@ function list(hooksRunner, projectRoot, opts) {
 var platforms_on_fs = cordova_util.listPlatforms(projectRoot);
 return hooksRunner.fire('before_platform_ls', opts)
--- End diff --

You don't need `platforms_on_fs` anymore, since you get equivalent 
information from your call to `getInstalledPlatformsWithVersions()` (so you can 
use `platformMap` below instead of `platforms_on_fs`).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [Android] CB-10625 Google Photos update breaks Camera's Gallery API

[julio cesar sanchez]

I already answered on CB-10625

When android 4.4 broke input type file support I wrote a plugin at work to
use a file picker instead.

For google Photos I use this code:

if (isGooglePhotosUri(uri))
return uri.getLastPathSegment();

Where isGooglePhotosUri is

public static boolean isGooglePhotosUri(Uri uri) {
return "com.google.android.apps.photos.content".equals(uri.getAuthority());
}

I tried it on the camera plugin and worked.


The plugin is based on this android library
https://github.com/iPaulPro/aFileChooser

The relevant class is
https://github.com/iPaulPro/aFileChooser/blob/master/aFileChooser/src/com/ipaulpro/afilechooser/utils/FileUtils.java




2016-02-17 1:41 GMT+01:00 Joe Bowser :

> Hey
>
> https://issues.apache.org/jira/browse/CB-10625
>
> For some reason Google Photos breaks the Camera's Gallery API, and I'm
> having trouble trying to fix this one.  For some reason I can't get the
> FileHelper to work with the new file URI that's being provided by an
> application.  Is there something obvious that we're missing here?
>
> Any thoughts?
>

[GitHub] cordova-plugin-whitelist pull request: CB-10624 remove error messa...

[jcesarmobile]

Github user jcesarmobile commented on the pull request:


https://github.com/apache/cordova-plugin-whitelist/pull/17#issuecomment-185598264
  
+1
In addition, it's not consistent with other platforms. Android is the only 
one that shows this warning.
We should encorage users to use the CSP, but not sure if showing a warning 
is the best way of doing it.
Most answers on stackoverflow questiongs about this warning just tell how 
to use an empty CSP so it stops complaining or use CSP that allows everything.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10526: iOS Guide Improvements

[jcesarmobile]

Github user jcesarmobile commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/505#discussion_r53283872
  
--- Diff: www/docs/en/dev/guide/platforms/ios/index.md ---
@@ -74,190 +67,123 @@ There are two ways to download Xcode:
 Once Xcode is installed, several command-line tools need to be enabled
 for Cordova to run. From the __Xcode__ menu, select __Preferences__,
 then the __Downloads__ tab. From the __Components__ panel, press the
-__Install__ button next to the __Command Line Tools__ listing.
+__Install__ button next to the __Command Line Tools__ listing. 
 
-## Install Deploy Tools
+### Deployment Tools
 
-Run from comman-line terminal:
+The [ios-sim](https://www.npmjs.org/package/ios-sim) and 
+[ios-deploy](https://www.npmjs.org/package/ios-deploy) tools - allows you
+to launch iOS apps into the iOS Simulator and iOS Device from the 
command-line.
+
+To install them, run the following from command-line terminal:
 
 $ npm install -g ios-sim
 $ npm install -g ios-deploy
 
-## Create a New Project
-
-Use the `cordova` utility to set up a new project, as described in The
-Cordova [The Command-Line Interface](../../cli/index.html). For example, 
in a source-code directory:
+## Project Configuration
 
-$ cordova create hello com.example.hello "HelloWorld"
-$ cd hello
-$ cordova platform add ios
-$ cordova prepare  # or "cordova build"
+Installing Xcode will mostly set everything needed to get started.
 
-## Deploy the app
-
-To deploy the app on a connected iOS device:
-
-$ cordova run ios --device
-To deploy the app on a default iOS emulator:
-
-$ cordova emulate ios
-
-You can use __cordova run ios --list__ to see all available targets and 
-__cordova run ios --target=target_name__ to run application on a specific 
-device or emulator (for example,  `cordova run ios --target="iPhone-6"`).
-
-You can also use __cordova run --help__ to see additional build and run
-options.
-
-## Open a Project in the SDK
-
-Once ios platform is added to your project, you can open it from 
-within Xcode. Double-click to open the 
`hello/platforms/ios/hello.xcodeproj`
-file. The screen should look like this:
-
-![]({{ site.baseurl 
}}/static/img/guide/platforms/ios/helloworld_project.png)
+## Signing an App
 
-## Deploy to Emulator
+First, you should read through the [Code Signing Support 
Page](https://developer.apple.com/support/code-signing/) 
+and the [App Distribution 
Workflows](https://developer.apple.com/library/prerelease/ios/documentation/IDEs/Conceptual/AppDistributionGuide/Introduction/Introduction.html).
 
-To preview the app in the iOS emulator:
+### Using Flags
 
-1. Make sure the _.xcodeproj_ file is selected in the left panel.
+To sign an app, you need the following parameters:
 
-2. Select the __hello__ app in the panel immediately to the right.
+| Parameter| Flag | Description

+|--|--|---
+| Code Sign Identity   | `--codeSignIdentity` | Code signing 
identity to use for signing. It can be created with Xcode and added to your 
keychain.
+| Provisioning Profile | `--provisioningProfile`  | GUID of the 
provisioning profile to be used for signing. It is copied here on your Mac: 
~/Library/MobileDevice/Provisioning\ Profiles/. Opening it in a text editor, 
you can find the GUID which needs to be specified here.
+| Code Sign Resource Rules | `--codesignResourceRules`| (Optional) Used to 
control which files in a bundle should be sealed by a code signature. For more 
details, read [The OS X Code Signing In Depth 
article](https://developer.apple.com/library/mac/technotes/tn2206/_index.html#//apple_ref/doc/uid/DTS40007919-CH1-TNTAG206)
 
 
-3. Select the intended device from the toolbar's __Scheme__ menu, such
-   as the iPhone 6.0 Simulator as highlighted here:
+### Using build.json
 
-   ![]({{ site.baseurl 
}}/static/img/guide/platforms/ios/select_xcode_scheme.png)
+Alternatively, you could specify them in a build configuration file 
(`build.json`)
+using the `--buildConfig` argument to the same commands. Here's a sample 
of a
+build configuration file:
 
-4. Press the __Run__ button that appears in the same toolbar to the
-   left of the __Scheme__. That builds, deploys and runs the
-   application in the emulator. A separate emulator application opens
-   to display the app:
+{
--- End diff --

I think it's still missing a `,` after "iPhone Distribution"


---
If your project is set up for it, you can repl

RE: [DISCUSS] Cordova-common 1.1.0 release

[Vladimir Kotikov (Akvelon)]

I don’t have a strict opinion about dynamic vs static dependencies, but IMO if 
we want to pin the version of every subdependency, shrinkwrap is better than 
bundling. At least it would be less prone to human errors (missing packages' 
files, line endings in subpackages - we'd ran into all of this already).
-
Best regards, Vladimir 

-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com] 
Sent: Tuesday, February 16, 2016 7:23 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Cordova-common 1.1.0 release

Sorry for the typo. I meant
If I install a piece of software component version 1.2.3 today, and install 
version 1.2.3 a week after I'm expecting to reproduce the same environment.

Net is that a user complains to us about problem, we should be able to 
reproduce it if we know the version number, and not just tell them try to npm 
install again and the problem might go away, and some times the reason it goes 
away and starts working is because one of the dependencies changed and the 
software is not longer the same as the one he as having problems.

On Tue, Feb 16, 2016 at 11:20 AM Carlos Santana 
wrote:

> I'm not big fan of dynamic dependencies, but I'm fan a predictable and 
> reproducible environments
>
> managing dependencies during development is much different than 
> managing dependencies when go live into production.
>
> Take into account that not just the cordova code that runs on the 
> phone runtime I consider as production code, the cordova code that 
> users get for tooling I also consider as production code as it's used in 
> devops systems.
>
> That's why is best practice to bundle all the code that the nodejs 
> server is going to need when going into production, and recently have 
> heard that folks are using docker images that build nodejs  core 
> binary with static libraries to not rely on the dynamic libraries from the 
> operating system.
>
> If I install a piece of software component version 1.2.3 today, and 
> install version 2.3.0 a week after I'm expecting to reproduce the same 
> environment.
> With the way npm handles dependecies, and folks declare dependencies 
> in pacakge.json we can cordova can only control one level down in 
> dependency tree.
>
> That's why npmshrinkwrap is used when producing release build or just 
> bundle dependency with release build.
>
> I think in npm3 npmshrinkwrap function was improved to be more 
> deterministic
>
>
>
> On Tue, Feb 16, 2016 at 7:50 AM Vladimir Kotikov (Akvelon) < 
> v-vlk...@microsoft.com> wrote:
>
>> Yes, a new patch release, I think.
>> Can't wait when we start to install platforms as packages - then we 
>> won't need to bundle everything :)
>>
>> -
>> Best regards, Vladimir
>>
>> -Original Message-
>> From: Carlos Santana [mailto:csantan...@gmail.com]
>> Sent: Tuesday, February 16, 2016 3:23 PM
>> To: dev@cordova.apache.org
>> Subject: Re: [DISCUSS] Cordova-common 1.1.0 release
>>
>> Vladimir,
>>   I forgot about that it's a bundled dependency. No blog is need it 
>> then
>>
>> But a new Windows platform release will be required to be able to 
>> pick up the new cordova-commons release right?
>>
>> - Carlos
>> @csantanapr
>>
>> On Feb 16, 2016, at 5:23 AM, Vladimir Kotikov (Akvelon) < 
>> v-vlk...@microsoft.com> wrote:
>>
>> >> cordova-windows won't as it has the dependency listed as ^1.0.0 
>> >> which
>> includes minor releases.
>> > IMO since cordova-common is a bundled dependency, we still need for 
>> > new
>> release to bundle new version.
>> >
>> > A small question - do we need for blog post for this release? I'd 
>> > say
>> no, as we releasing something for internal use, but what is your thoughts?
>> >
>> > -
>> > Best regards, Vladimir
>> >
>> > -Original Message-
>> > From: Steven Gill [mailto:stevengil...@gmail.com]
>> > Sent: Tuesday, February 16, 2016 7:49 AM
>> > To: dev@cordova.apache.org
>> > Subject: Re: [DISCUSS] Cordova-common 1.1.0 release
>> >
>> > Yes. I'd like us to go ^1.0.0 and include minors. Just need to be
>> careful when doing minor common releases to not break platforms.
>> >> On Feb 15, 2016 8:11 PM, "Carlos Santana" 
>> wrote:
>> >>
>> >> Should we be consistent about how we declare the dependency for 
>> >> platforms against cordova-common ?
>> >>
>> >>
>> >>
>> >> On Mon, Feb 15, 2016 at 11:04 PM Steven Gill 
>> >> 
>> >> wrote:
>> >>
>> >>> Sounds good.
>> >>>
>> >>> Cordova-lib, Cordova-android and cordova-ios will need to have 
>> >>> releases with this updated cordova-common.
>> >>>
>> >>> cordova-windows won't as it has the dependency listed as ^1.0.0 
>> >>> which includes minor releases.
>> >>>
>> >>> On Mon, Feb 15, 2016 at 6:29 AM, Vladimir Kotikov (Akvelon) < 
>> >>> v-vlk...@microsoft.com> wrote:
>> >>>
>>  Hi, guys.
>>  I'm planning to do a minor release for cordova-common.
>> 
>>  Here is the list of JIRAs to be resolved in this release (aka
>>  RELEASENOTES):
>> 
>>  * CB-10052 Improve superspawn to allow to h