date:20160223

[GitHub] cordova-docs pull request: Making windows guide single page

2016-02-23 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/512#discussion_r53748270
  
--- Diff: www/_data/redirects.yml ---
@@ -13,6 +13,8 @@ docs:
 - {old: "dev/guide/platforms/ios/config.html", new: 
"dev/config_ref/index.html"}
 - {old: "latest/guide/platforms/ios/tools.html", new: 
"latest/guide/platforms/ios/index.html"}
 - {old: "latest/guide/platforms/ios/config.html", new: 
"latest/config_ref/index.html"}
+- {old: "dev/guide/platforms/win8/packaging.html", new: 
"dev/guide/platforms/win8/index.html#signing-an-app"}
+- {old: "dev/guide/platforms/win8/win10-support.html", new: 
"dev/guide/platforms/win8/index.html"}
--- End diff --

Yeah, either published to the site or printed in a blog post. My 
understanding is that the current `dev` redirects are there because there was a 
blog post about Android stuff that linked to `dev`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...

2016-02-23 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/511#discussion_r53748431
  
--- Diff: www/_data/toc/en-dev-manual.yml ---
@@ -25,12 +25,12 @@
 -   name: "Windows"
 url: "guide/platforms/win8/index.html"
 -   name: "WP8"
-url: "guide/platforms/wp8/home.html"   

+url: "guide/platforms/wp8/home.html"
 -   name: "Manage versions and platforms"
 url: "platform_plugin_versioning_ref/index.html"
 -   name: "Debug and test"
 url:
--   name: "Use icons and splash screens"
+-   name: "Use Icons"
--- End diff --

@nikhilkh it's not strictly necessary right now, since they're untranslated 
in other languages. But if it's not too much work, I guess @rakatyal please do 
update the other languages as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10530 - App freezes sometimes directl...

2016-02-23 Thread michschu

Github user michschu commented on the pull request:

https://github.com/apache/cordova-ios/pull/193#issuecomment-187600116
  
Not having a problem with 
_cordova-plugin-splashscreen 3.1.0 "Splashscreen"_
However
_cordova-plugin-inappbrowser 1.2.1 "InAppBrowser"
cc.fovea.cordova.purchase 4.0.0 "Purchase"_
seem not to work anymore.

Currently no time to provide a test scenario. Anybody having a chance to 
confirm (or not)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: New plugin version selection implementat...

2016-02-23 Thread TimBarham

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/363#discussion_r53779104
  
--- Diff: cordova-lib/src/cordova/util.js ---
@@ -185,6 +187,22 @@ function listPlatforms(project_dir) {
 });
 }
 
+function getInstalledPlatformsWithVersions(project_dir) {
+var result = {};
+var platforms_on_fs = listPlatforms(project_dir);
+
+return Q.all(platforms_on_fs.map(function(p) {
+return superspawn.maybeSpawn(path.join(project_dir, 'platforms', 
p, 'cordova', 'version'), [], { chmod: true })
+.then(function(v) {
+result[p] = v || null;
+}, function(v) {
+result[p] = v || 'broken';
--- End diff --

Is this what you intended? The parameter `v` here will actually be the 
error. In the previous version, `v` was simply ignored (so "version" was always 
set to "broken").


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: New plugin version selection implementat...

2016-02-23 Thread TimBarham

Github user TimBarham commented on the pull request:

https://github.com/apache/cordova-lib/pull/363#issuecomment-187701057
  
Other than one small remaining question, looks great! Thanks @riknoll!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Hamronize CFBudleIndtifier

2016-02-23 Thread julio cesar sanchez

+1 to prefixed versions

I always use the same bundle identifier/package name for the same app, but
I sometimes have to use a different version for the android or iOS app, so
it's better if I can set them directly from the config.xml and not use a
hook.


2016-02-23 7:54 GMT+01:00 Tobias Bocanegra :

> Hi,
>
> he current commons code uses ios-CFBundleVersion and
> ios-CFBundleIdentifier: [0], [1]
>
> Now with OSX in the game there could be similar new attributes
> osx-CFBundleVersion and osx-CFBundleIdentifier or we could deprecate
> the ios-* ones and just use their plain names without prefix.
>
> suggest:
> - use CFBundleVersion and CFBundleIdentifier for iOS and OSX platform.
> - deprecate ios-CFBundleVersion and ios-CFBundleIdentifier
>
> drawback:
>   using the un-prefixed attribute names would prevent a project of
> having different versions/identifiers for the ios and osx platforms.
> if one wants to evolve them separately, he would then need to use some
> hooks to tweak the config.xml.
>
> counter argument:
>   windows and android also use prefixed versions, so maybe its better
> to keep this pattern consistent.
>
> see [2].
>
> regards, toby
>
> [0]
> https://github.com/apache/cordova-lib/blob/6.0.0/cordova-common/src/ConfigParser/ConfigParser.js#L106
> [1]
> https://github.com/apache/cordova-lib/blob/6.0.0/cordova-common/src/ConfigParser/ConfigParser.js#L132
> [2] https://issues.apache.org/jira/browse/CB-10603
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[GitHub] cordova-plugins pull request: Fix Keyboard Shrink View without Acc...

2016-02-23 Thread kaynz

Github user kaynz commented on the pull request:

https://github.com/apache/cordova-plugins/pull/14#issuecomment-187738268
  
up


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Fixed Typo: ccordova to cordova

2016-02-23 Thread Samshal

GitHub user Samshal opened a pull request:

https://github.com/apache/cordova-docs/pull/515

Fixed Typo: ccordova to cordova



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Samshal/cordova-docs patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/515.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #515


commit 2d7b928d14997209bd1bf9a50d6e835b8d03a532
Author: Samuel Adeshina 
Date:   2016-02-23T15:39:41Z

Fixed Typo: ccordova to cordova




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Docs fetching improvements

2016-02-23 Thread nikhilkh

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/514#discussion_r53813684
  
--- Diff: tools/bin/fetch_docs.js ---
@@ -25,42 +25,103 @@ var child_process = require("child_process");
 var yaml  = require("js-yaml");
 
 // constants
-var DEFAULT_REPO_PATH = "README.md";
+var DEFAULT_REPO_PATH= "README.md";
+var DEFAULT_PERMALINK_PREFIX = "/gen/";
 
-function generateFrontMatter (useDirectSrcURI, filePath, name, version) {
-var obj = {};
+function generateFrontMatter(fetchedFile) {
 
-if(useDirectSrcURI) {
-var p   = 
/https:\/\/raw.githubusercontent.com\/([^\/]+)\/([^\/]+)\/([^\/]+)\/(.+)/;
-var filePathSplit   = filePath.match(p);
-name= filePathSplit[1] + "/" + filePathSplit[2];
-version = filePathSplit[3];
-filePath= filePathSplit.slice(4).join("/");
+var frontMatterConfig = {};
+
+frontMatterConfig.edit_link = fetchedFile.editLink;
+frontMatterConfig.permalink = fetchedFile.permalink;
+
+// set special values for plugins
+if (isPluginName(fetchedFile.packageName)) {
+frontMatterConfig.plugin_name= fetchedFile.packageName;
+frontMatterConfig.plugin_version = fetchedFile.version;
 }
 
-obj.edit_link   = getRepoURIForFrontMatter(name, version, 
filePath);
-obj.plugin_name = name;
-obj.plugin_version  = version;
+// return front matter as a string
+var frontMatterString = "---\n" + yaml.dump(frontMatterConfig) + 
"---\n\n";
+return frontMatterString;
+}
 
-var frontMatter = "---\n" + yaml.dump(obj) + "\n---\n\n";
-return frontMatter;
+function isPluginName(packageName) {
+return packageName.match(/cordova-plugin-.*/);
 }
 
-function getRepoFileURI (name, version, filePath) {
-return "https://raw.githubusercontent.com/"; + name + "/" + version + 
"/" + filePath;
+function getRepoFileURI(repoName, commit, filePath) {
+return "https://raw.githubusercontent.com/"; + repoName + "/" + commit 
+ "/" + filePath;
 }
 
-function getRepoURIForFrontMatter (name, version, filePath) {
-return "https://github.com/"; + name + "/blob/" + version + "/"+ 
filePath
+function getRepoEditURI(repoName, commit, filePath) {
+return "https://github.com/"; + repoName + "/blob/" + commit + "/"+ 
filePath
 }
 
-function getLatestRelease (packageName) {
+function getLatestRelease(packageName) {
 var latestRelease = child_process.execSync("npm info " + packageName + 
" dist-tags.latest");
 return latestRelease.toString().trim();
 }
 
-function getPackageName (fileConfigSrc) {
-return fileConfigSrc.packageName || 
fileConfigSrc.repoName.split('/')[1];
+function packageNameFromRepoName(repoName) {
+var repoSplit  = repoName.split('/');
+var repoOwner  = repoSplit[0];
+var actualRepoName = repoSplit[1];
+return actualRepoName;
+}
+
+function getFetchedFile(entry) {
+
+// get entry components
+var srcConfig  = entry.src;
+var destConfig = entry.dest;
+
+// validate entry
+if (!srcConfig) {
+console.error("entry '" + entry.toString() + "' missing 'src'");
+return;
+}
+
+if (!srcConfig.repoName) {
+console.error("entry '" + entry.toString() + "' missing 'repoName' 
in 'src'");
+return;
+}
+
+if (!destConfig) {
+console.error("entry '" + entry.toString() + "' missing 'dest'");
+return;
+}
+
+// complete src config
+if (!srcConfig.packageName) {
+srcConfig.packageName = 
packageNameFromRepoName(srcConfig.repoName);
+}
+
+if (!srcConfig.path) {
+srcConfig.path = DEFAULT_REPO_PATH;
+}
+
+if (!srcConfig.commit) {
+srcConfig.commit = getLatestRelease(srcConfig.packageName);
+}
+
+// complete dest config
+if (!destConfig.permalink) {
+destConfig.permalink = DEFAULT_PERMALINK_PREFIX + 
srcConfig.packageName + "/";
--- End diff --

We error our when there is no `destconfig` - however, there is a default 
behavior when the only property of destconfig not present. Either remove this 
default or remove failing on absence of `destconfig`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org

[GitHub] cordova-docs pull request: Docs fetching improvements

2016-02-23 Thread nikhilkh

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/514#discussion_r53813916
  
--- Diff: tools/bin/fetch_docs.js ---
@@ -25,42 +25,103 @@ var child_process = require("child_process");
 var yaml  = require("js-yaml");
 
 // constants
-var DEFAULT_REPO_PATH = "README.md";
+var DEFAULT_REPO_PATH= "README.md";
+var DEFAULT_PERMALINK_PREFIX = "/gen/";
 
-function generateFrontMatter (useDirectSrcURI, filePath, name, version) {
-var obj = {};
+function generateFrontMatter(fetchedFile) {
 
-if(useDirectSrcURI) {
-var p   = 
/https:\/\/raw.githubusercontent.com\/([^\/]+)\/([^\/]+)\/([^\/]+)\/(.+)/;
-var filePathSplit   = filePath.match(p);
-name= filePathSplit[1] + "/" + filePathSplit[2];
-version = filePathSplit[3];
-filePath= filePathSplit.slice(4).join("/");
+var frontMatterConfig = {};
+
+frontMatterConfig.edit_link = fetchedFile.editLink;
+frontMatterConfig.permalink = fetchedFile.permalink;
+
+// set special values for plugins
+if (isPluginName(fetchedFile.packageName)) {
+frontMatterConfig.plugin_name= fetchedFile.packageName;
+frontMatterConfig.plugin_version = fetchedFile.version;
 }
 
-obj.edit_link   = getRepoURIForFrontMatter(name, version, 
filePath);
-obj.plugin_name = name;
-obj.plugin_version  = version;
+// return front matter as a string
+var frontMatterString = "---\n" + yaml.dump(frontMatterConfig) + 
"---\n\n";
+return frontMatterString;
+}
 
-var frontMatter = "---\n" + yaml.dump(obj) + "\n---\n\n";
-return frontMatter;
+function isPluginName(packageName) {
+return packageName.match(/cordova-plugin-.*/);
 }
 
-function getRepoFileURI (name, version, filePath) {
-return "https://raw.githubusercontent.com/"; + name + "/" + version + 
"/" + filePath;
+function getRepoFileURI(repoName, commit, filePath) {
+return "https://raw.githubusercontent.com/"; + repoName + "/" + commit 
+ "/" + filePath;
 }
 
-function getRepoURIForFrontMatter (name, version, filePath) {
-return "https://github.com/"; + name + "/blob/" + version + "/"+ 
filePath
+function getRepoEditURI(repoName, commit, filePath) {
+return "https://github.com/"; + repoName + "/blob/" + commit + "/"+ 
filePath
 }
 
-function getLatestRelease (packageName) {
+function getLatestRelease(packageName) {
 var latestRelease = child_process.execSync("npm info " + packageName + 
" dist-tags.latest");
 return latestRelease.toString().trim();
 }
 
-function getPackageName (fileConfigSrc) {
-return fileConfigSrc.packageName || 
fileConfigSrc.repoName.split('/')[1];
+function packageNameFromRepoName(repoName) {
+var repoSplit  = repoName.split('/');
+var repoOwner  = repoSplit[0];
+var actualRepoName = repoSplit[1];
+return actualRepoName;
+}
+
+function getFetchedFile(entry) {
+
+// get entry components
+var srcConfig  = entry.src;
+var destConfig = entry.dest;
+
+// validate entry
+if (!srcConfig) {
+console.error("entry '" + entry.toString() + "' missing 'src'");
--- End diff --

Nit: Consider throwing an error object with appropriate message - throwing 
often has the nice side effect of presenting a stack. Also, the caller does not 
have to account for no return value.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Docs fetching improvements

2016-02-23 Thread nikhilkh

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/514#discussion_r53814215
  
--- Diff: tools/bin/fetch_docs.js ---
@@ -25,42 +25,103 @@ var child_process = require("child_process");
 var yaml  = require("js-yaml");
 
 // constants
-var DEFAULT_REPO_PATH = "README.md";
+var DEFAULT_REPO_PATH= "README.md";
+var DEFAULT_PERMALINK_PREFIX = "/gen/";
 
-function generateFrontMatter (useDirectSrcURI, filePath, name, version) {
-var obj = {};
+function generateFrontMatter(fetchedFile) {
 
-if(useDirectSrcURI) {
-var p   = 
/https:\/\/raw.githubusercontent.com\/([^\/]+)\/([^\/]+)\/([^\/]+)\/(.+)/;
-var filePathSplit   = filePath.match(p);
-name= filePathSplit[1] + "/" + filePathSplit[2];
-version = filePathSplit[3];
-filePath= filePathSplit.slice(4).join("/");
+var frontMatterConfig = {};
+
+frontMatterConfig.edit_link = fetchedFile.editLink;
+frontMatterConfig.permalink = fetchedFile.permalink;
+
+// set special values for plugins
+if (isPluginName(fetchedFile.packageName)) {
+frontMatterConfig.plugin_name= fetchedFile.packageName;
+frontMatterConfig.plugin_version = fetchedFile.version;
 }
 
-obj.edit_link   = getRepoURIForFrontMatter(name, version, 
filePath);
-obj.plugin_name = name;
-obj.plugin_version  = version;
+// return front matter as a string
+var frontMatterString = "---\n" + yaml.dump(frontMatterConfig) + 
"---\n\n";
+return frontMatterString;
+}
 
-var frontMatter = "---\n" + yaml.dump(obj) + "\n---\n\n";
-return frontMatter;
+function isPluginName(packageName) {
+return packageName.match(/cordova-plugin-.*/);
 }
 
-function getRepoFileURI (name, version, filePath) {
-return "https://raw.githubusercontent.com/"; + name + "/" + version + 
"/" + filePath;
+function getRepoFileURI(repoName, commit, filePath) {
+return "https://raw.githubusercontent.com/"; + repoName + "/" + commit 
+ "/" + filePath;
 }
 
-function getRepoURIForFrontMatter (name, version, filePath) {
-return "https://github.com/"; + name + "/blob/" + version + "/"+ 
filePath
+function getRepoEditURI(repoName, commit, filePath) {
+return "https://github.com/"; + repoName + "/blob/" + commit + "/"+ 
filePath
 }
 
-function getLatestRelease (packageName) {
+function getLatestRelease(packageName) {
 var latestRelease = child_process.execSync("npm info " + packageName + 
" dist-tags.latest");
 return latestRelease.toString().trim();
 }
 
-function getPackageName (fileConfigSrc) {
-return fileConfigSrc.packageName || 
fileConfigSrc.repoName.split('/')[1];
+function packageNameFromRepoName(repoName) {
+var repoSplit  = repoName.split('/');
+var repoOwner  = repoSplit[0];
+var actualRepoName = repoSplit[1];
+return actualRepoName;
+}
+
+function getFetchedFile(entry) {
+
+// get entry components
+var srcConfig  = entry.src;
+var destConfig = entry.dest;
+
+// validate entry
+if (!srcConfig) {
+console.error("entry '" + entry.toString() + "' missing 'src'");
+return;
+}
+
+if (!srcConfig.repoName) {
+console.error("entry '" + entry.toString() + "' missing 'repoName' 
in 'src'");
+return;
+}
+
+if (!destConfig) {
+console.error("entry '" + entry.toString() + "' missing 'dest'");
+return;
+}
+
+// complete src config
+if (!srcConfig.packageName) {
+srcConfig.packageName = 
packageNameFromRepoName(srcConfig.repoName);
--- End diff --

Nit: The JS way of writing this is: `srcConfig.packageName = 
srcConfig.packageName || packageNameFromRepoName(srcConfig.repoName);`
I like it because it's more compact too. This method seems long with a lot 
of whitespaces making it hard to eyeball - but all of this is just stylistic 
and not a big deal IMO.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Docs fetching improvements

2016-02-23 Thread nikhilkh

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/514#discussion_r53814811
  
--- Diff: www/_data/fetched-files.yml ---
@@ -1,153 +1,146 @@
+# REFERENCE ENTRY:
+#
+# -
+# src:# 
required
+# repoName:"apache/cordova-cli"   # 
required
+# packageName: "cordova"  # if 
empty: second part of repoName
+# commit:  "master"   # if 
empty: latest in NPM
+# path:"relative/path/to/file/in/repo.md" # if 
empty: "README.md"
+# dest:   # 
required
+# permalink:   "/absolute/path/on/cordova/site/index.html"# if 
empty: "/gen/" + packageName + "/"
+#
+
 -
 src:
 repoName: "apache/cordova-cli"
 packageName: "cordova"
+commit: "master"
 path: "doc/bash.md"
-dest: "cordova-cli/index.md"
+dest:
+permalink: "/docs/en/dev/cordova-cli/index.html"
 -
 src:
-repoName: apache/cordova-plugin-battery-status
-packageName: cordova-plugin-battery-status
-displayName: Battery Status
-description: Monitor the status of the device's battery.
-dest: cordova-plugin-battery-status/index.md
+repoName: "apache/cordova-plugin-battery-status"
+packageName: "cordova-plugin-battery-status"
+dest:
+permalink: "/docs/en/dev/cordova-plugin-battery-status/index.html"
--- End diff --

Nit: It might be nice to move all plugin docs into one directory "plugins"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Improve gulp watch perf and add --nofet...

2016-02-23 Thread nikhilkh

GitHub user nikhilkh opened a pull request:

https://github.com/apache/cordova-docs/pull/516

Improve gulp watch perf and add --nofetch option

Improves by reducing the set of files that we watch. Also, 'watch' was 
broken because of fetching behavior resulting an endless watch - change loop.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs gulp-updates

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/516.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #516


commit fdbb6827db937651e70f695cd01f507418e3f85c
Author: Nikhil Khandelwal 
Date:   2016-02-23T17:30:18Z

Improve gulp watch perf and add --nofetch option




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Improve gulp watch perf and add --nofet...

2016-02-23 Thread nikhilkh

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-docs/pull/516#issuecomment-187806485
  
@riknoll @dblotsky 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10668 Moved node_modules to root

2016-02-23 Thread nikhilkh

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-ios/pull/196#issuecomment-187815938
  
I'm curious - Is this required for the new npm fetch work? Does it mean 
older versions of cordova-ios will stop working with the new npm fetch approach?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Create Pictures directory if i...

2016-02-23 Thread TheBosZ

GitHub user TheBosZ opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/178

Create Pictures directory if it doesn't exist.

Possibly should throw an exception if the directory can't be created. A log 
message is emitted and behavior is no worse than current code.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TheBosZ/cordova-plugin-camera patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/178.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #178


commit df1ac44916863acedf3643093024fdfdccc5122e
Author: Nathan 
Date:   2016-02-23T17:59:50Z

Create Pictures directory if it doesn't exist.

Possibly should throw an exception if the directory can't be created. A log 
message is emitted and behavior is no worse than current code.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Making windows guide single page

2016-02-23 Thread rakatyal

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/512#discussion_r53826023
  
--- Diff: www/_data/redirects.yml ---
@@ -13,6 +13,8 @@ docs:
 - {old: "dev/guide/platforms/ios/config.html", new: 
"dev/config_ref/index.html"}
 - {old: "latest/guide/platforms/ios/tools.html", new: 
"latest/guide/platforms/ios/index.html"}
 - {old: "latest/guide/platforms/ios/config.html", new: 
"latest/config_ref/index.html"}
+- {old: "dev/guide/platforms/win8/packaging.html", new: 
"dev/guide/platforms/win8/index.html#signing-an-app"}
+- {old: "dev/guide/platforms/win8/win10-support.html", new: 
"dev/guide/platforms/win8/index.html"}
--- End diff --

Okay. The packaging one has been live since long so I will keep that one. 
Win10 support didn't went out so I will change it to latest.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...

2016-02-23 Thread sarangan12

GitHub user sarangan12 opened a pull request:

https://github.com/apache/cordova-docs/pull/517

CB-10347: Remove 'Add icons and splash screen' article

Changed contents for other languages

@rakatyal Can you review and merge this PR?

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sarangan12/cordova-docs CB-10347

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/517.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #517


commit d06b53f1ecededb2b1f7ff3412a04d139204d114
Author: Sarangan Rajamanickam 
Date:   2016-02-23T19:14:00Z

CB-10347: Remove 'Add icons and splash screen' article

Changed contents for other languages




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10680 Expose useHttpAuthUsernameP...

2016-02-23 Thread marcuspridham

GitHub user marcuspridham opened a pull request:

https://github.com/apache/cordova-android/pull/262

CB-10680 Expose useHttpAuthUsernamePassword in ICordovaHttpAuthHandler



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/marcuspridham/cordova-android CB-10680

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/262.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #262


commit 52ca3ef200c49fd45dc93b6469c8ed20588c4f6c
Author: Marcus Pridham 
Date:   2016-02-23T19:10:41Z

CB-10680 Expose useHttpAuthUsernamePassword in ICordovaHttpAuthHandler




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10639 Appium tests: Added s...

2016-02-23 Thread vladimir-kotikov

Github user vladimir-kotikov commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/177#discussion_r53833681
  
--- Diff: appium-tests/android/android.spec.js ---
@@ -1,28 +1,34 @@
-/*jslint node: true, plusplus: true */
+/*jshint node: true */
 /*global beforeEach, afterEach */
--- End diff --

Minor nit: this might be easier to use something like `/*jshint node:true, 
jasmine: true*/` to avoid declaring all Jasmine globals


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...

2016-02-23 Thread rakatyal

Github user rakatyal commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/517#discussion_r53833896
  
--- Diff: www/_data/toc/de-dev-manual.yml ---
@@ -25,12 +25,12 @@
 -   name: "Windows"
 url: "guide/platforms/win8/index.html"
 -   name: "WP8"
-url: "guide/platforms/wp8/home.html"   

+url: "guide/platforms/wp8/home.html"
 -   name: "Manage versions and platforms"
 url: "platform_plugin_versioning_ref/index.html"
 -   name: "Debug and test"
 url:
--   name: "Use icons and splash screens"
--- End diff --

The guideline is to keep the first letter in caps only for the first word 
and to have the remaining words begin in smallcase. Can you please also change 
it for other occurrences in the TOC?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...

2016-02-23 Thread sarangan12

Github user sarangan12 commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/517#discussion_r53834939
  
--- Diff: www/_data/toc/de-dev-manual.yml ---
@@ -25,12 +25,12 @@
 -   name: "Windows"
 url: "guide/platforms/win8/index.html"
 -   name: "WP8"
-url: "guide/platforms/wp8/home.html"   

+url: "guide/platforms/wp8/home.html"
 -   name: "Manage versions and platforms"
 url: "platform_plugin_versioning_ref/index.html"
 -   name: "Debug and test"
 url:
--   name: "Use icons and splash screens"
--- End diff --

Done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine pull request: The webView should r...

2016-02-23 Thread accomplix

Github user accomplix commented on the pull request:


https://github.com/apache/cordova-plugin-wkwebview-engine/pull/5#issuecomment-187867060
  
Tested and working ! Thanks, this is a life saver.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10639 Appium tests: Added s...

2016-02-23 Thread vladimir-kotikov

Github user vladimir-kotikov commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/177#discussion_r53838196
  
--- Diff: appium-tests/android/android.spec.js ---
@@ -295,13 +318,35 @@ describe('Camera tests Android.', function () {
 .then(function () {
 return driver; // no-op
 }, function (error) {
-expect(true).toFailWithMessage(error);
+if (error.message.indexOf('Error response status: 
6') >= 0) {
+// the session has expired but we can fix this!
+console.log('The session has expired. Trying 
to start a new one...');
+return getDriver();
+} else {
+expect(true).toFailWithMessage(error);
+}
 })
-.execute('document.getElementById("info").innerHTML = 
"' + startingMessage + '";')
+.execute('document.getElementById("info").innerHTML = 
"' + STARTING_MESSAGE + '";')
 .finally(done);
 }
 done();
-}, 60);
+}, 3 * MINUTE);
+
+afterEach(function (done) {
+// recreate the session if there was a critical error in the 
spec
+if (stopFlag) {
+return driver
--- End diff --

This is not obvious that you're `return`'ing a promise here just to avoid 
second `done` call at the end of `afterEach`

I'd recommend you to reverse `if` condition to enclose the shortest code 
path and reduce nesting, and to explicitly do a return after `done`. Something 
like:
```javascript
if (!stopFlag) {
done();
return;
}
// promise chain here 
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10668 Moved node_modules to root

2016-02-23 Thread stevengill

Github user stevengill commented on the pull request:

https://github.com/apache/cordova-ios/pull/196#issuecomment-187873089
  
Nothing to do with fetch. We noticed `npm pack` was not properly adding in 
nested node_modules for the latest `cordova-osx` release. I took this 
opportunity to quickly update both osx and ios to use `package.json` to manage 
dependencies like our other platforms. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: New plugin version selection implementat...

2016-02-23 Thread riknoll

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/363#discussion_r53838895
  
--- Diff: cordova-lib/src/cordova/util.js ---
@@ -185,6 +187,22 @@ function listPlatforms(project_dir) {
 });
 }
 
+function getInstalledPlatformsWithVersions(project_dir) {
+var result = {};
+var platforms_on_fs = listPlatforms(project_dir);
+
+return Q.all(platforms_on_fs.map(function(p) {
+return superspawn.maybeSpawn(path.join(project_dir, 'platforms', 
p, 'cordova', 'version'), [], { chmod: true })
+.then(function(v) {
+result[p] = v || null;
+}, function(v) {
+result[p] = v || 'broken';
--- End diff --

Good catch! Fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: New plugin version selection implementat...

2016-02-23 Thread riknoll

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-lib/pull/363#issuecomment-187874856
  
Fixed jasmine tests and created a JIRA for this 
([CB-10679](https://issues.apache.org/jira/browse/CB-10679))


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Docs fetching improvements

2016-02-23 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/514#discussion_r53840883
  
--- Diff: tools/bin/fetch_docs.js ---
@@ -25,42 +25,103 @@ var child_process = require("child_process");
 var yaml  = require("js-yaml");
 
 // constants
-var DEFAULT_REPO_PATH = "README.md";
+var DEFAULT_REPO_PATH= "README.md";
+var DEFAULT_PERMALINK_PREFIX = "/gen/";
 
-function generateFrontMatter (useDirectSrcURI, filePath, name, version) {
-var obj = {};
+function generateFrontMatter(fetchedFile) {
 
-if(useDirectSrcURI) {
-var p   = 
/https:\/\/raw.githubusercontent.com\/([^\/]+)\/([^\/]+)\/([^\/]+)\/(.+)/;
-var filePathSplit   = filePath.match(p);
-name= filePathSplit[1] + "/" + filePathSplit[2];
-version = filePathSplit[3];
-filePath= filePathSplit.slice(4).join("/");
+var frontMatterConfig = {};
+
+frontMatterConfig.edit_link = fetchedFile.editLink;
+frontMatterConfig.permalink = fetchedFile.permalink;
+
+// set special values for plugins
+if (isPluginName(fetchedFile.packageName)) {
+frontMatterConfig.plugin_name= fetchedFile.packageName;
+frontMatterConfig.plugin_version = fetchedFile.version;
 }
 
-obj.edit_link   = getRepoURIForFrontMatter(name, version, 
filePath);
-obj.plugin_name = name;
-obj.plugin_version  = version;
+// return front matter as a string
+var frontMatterString = "---\n" + yaml.dump(frontMatterConfig) + 
"---\n\n";
+return frontMatterString;
+}
 
-var frontMatter = "---\n" + yaml.dump(obj) + "\n---\n\n";
-return frontMatter;
+function isPluginName(packageName) {
+return packageName.match(/cordova-plugin-.*/);
 }
 
-function getRepoFileURI (name, version, filePath) {
-return "https://raw.githubusercontent.com/"; + name + "/" + version + 
"/" + filePath;
+function getRepoFileURI(repoName, commit, filePath) {
+return "https://raw.githubusercontent.com/"; + repoName + "/" + commit 
+ "/" + filePath;
 }
 
-function getRepoURIForFrontMatter (name, version, filePath) {
-return "https://github.com/"; + name + "/blob/" + version + "/"+ 
filePath
+function getRepoEditURI(repoName, commit, filePath) {
+return "https://github.com/"; + repoName + "/blob/" + commit + "/"+ 
filePath
 }
 
-function getLatestRelease (packageName) {
+function getLatestRelease(packageName) {
 var latestRelease = child_process.execSync("npm info " + packageName + 
" dist-tags.latest");
 return latestRelease.toString().trim();
 }
 
-function getPackageName (fileConfigSrc) {
-return fileConfigSrc.packageName || 
fileConfigSrc.repoName.split('/')[1];
+function packageNameFromRepoName(repoName) {
+var repoSplit  = repoName.split('/');
+var repoOwner  = repoSplit[0];
+var actualRepoName = repoSplit[1];
+return actualRepoName;
+}
+
+function getFetchedFile(entry) {
+
+// get entry components
+var srcConfig  = entry.src;
+var destConfig = entry.dest;
+
+// validate entry
+if (!srcConfig) {
+console.error("entry '" + entry.toString() + "' missing 'src'");
+return;
+}
+
+if (!srcConfig.repoName) {
+console.error("entry '" + entry.toString() + "' missing 'repoName' 
in 'src'");
+return;
+}
+
+if (!destConfig) {
+console.error("entry '" + entry.toString() + "' missing 'dest'");
+return;
+}
+
+// complete src config
+if (!srcConfig.packageName) {
+srcConfig.packageName = 
packageNameFromRepoName(srcConfig.repoName);
+}
+
+if (!srcConfig.path) {
+srcConfig.path = DEFAULT_REPO_PATH;
+}
+
+if (!srcConfig.commit) {
+srcConfig.commit = getLatestRelease(srcConfig.packageName);
+}
+
+// complete dest config
+if (!destConfig.permalink) {
+destConfig.permalink = DEFAULT_PERMALINK_PREFIX + 
srcConfig.packageName + "/";
--- End diff --

Yeah, it does seem paradoxical, but I made `dest` necessary because it 
could in the future have required arguments. I couldn't decide before, but 
you're right that it seems wacky. I will just make `permalink` mandatory as 
well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at i

[GitHub] cordova-docs pull request: Docs fetching improvements

2016-02-23 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/514#discussion_r53841393
  
--- Diff: tools/bin/fetch_docs.js ---
@@ -25,42 +25,103 @@ var child_process = require("child_process");
 var yaml  = require("js-yaml");
 
 // constants
-var DEFAULT_REPO_PATH = "README.md";
+var DEFAULT_REPO_PATH= "README.md";
+var DEFAULT_PERMALINK_PREFIX = "/gen/";
 
-function generateFrontMatter (useDirectSrcURI, filePath, name, version) {
-var obj = {};
+function generateFrontMatter(fetchedFile) {
 
-if(useDirectSrcURI) {
-var p   = 
/https:\/\/raw.githubusercontent.com\/([^\/]+)\/([^\/]+)\/([^\/]+)\/(.+)/;
-var filePathSplit   = filePath.match(p);
-name= filePathSplit[1] + "/" + filePathSplit[2];
-version = filePathSplit[3];
-filePath= filePathSplit.slice(4).join("/");
+var frontMatterConfig = {};
+
+frontMatterConfig.edit_link = fetchedFile.editLink;
+frontMatterConfig.permalink = fetchedFile.permalink;
+
+// set special values for plugins
+if (isPluginName(fetchedFile.packageName)) {
+frontMatterConfig.plugin_name= fetchedFile.packageName;
+frontMatterConfig.plugin_version = fetchedFile.version;
 }
 
-obj.edit_link   = getRepoURIForFrontMatter(name, version, 
filePath);
-obj.plugin_name = name;
-obj.plugin_version  = version;
+// return front matter as a string
+var frontMatterString = "---\n" + yaml.dump(frontMatterConfig) + 
"---\n\n";
+return frontMatterString;
+}
 
-var frontMatter = "---\n" + yaml.dump(obj) + "\n---\n\n";
-return frontMatter;
+function isPluginName(packageName) {
+return packageName.match(/cordova-plugin-.*/);
 }
 
-function getRepoFileURI (name, version, filePath) {
-return "https://raw.githubusercontent.com/"; + name + "/" + version + 
"/" + filePath;
+function getRepoFileURI(repoName, commit, filePath) {
+return "https://raw.githubusercontent.com/"; + repoName + "/" + commit 
+ "/" + filePath;
 }
 
-function getRepoURIForFrontMatter (name, version, filePath) {
-return "https://github.com/"; + name + "/blob/" + version + "/"+ 
filePath
+function getRepoEditURI(repoName, commit, filePath) {
+return "https://github.com/"; + repoName + "/blob/" + commit + "/"+ 
filePath
 }
 
-function getLatestRelease (packageName) {
+function getLatestRelease(packageName) {
 var latestRelease = child_process.execSync("npm info " + packageName + 
" dist-tags.latest");
 return latestRelease.toString().trim();
 }
 
-function getPackageName (fileConfigSrc) {
-return fileConfigSrc.packageName || 
fileConfigSrc.repoName.split('/')[1];
+function packageNameFromRepoName(repoName) {
+var repoSplit  = repoName.split('/');
+var repoOwner  = repoSplit[0];
+var actualRepoName = repoSplit[1];
+return actualRepoName;
+}
+
+function getFetchedFile(entry) {
+
+// get entry components
+var srcConfig  = entry.src;
+var destConfig = entry.dest;
+
+// validate entry
+if (!srcConfig) {
+console.error("entry '" + entry.toString() + "' missing 'src'");
--- End diff --

I opted for the "callee prints error and returns null, caller checks for 
null" instead of the "callee throws exception, caller catches it" pattern. Is 
one more advantageous than the other?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Docs fetching improvements

2016-02-23 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/514#discussion_r53841732
  
--- Diff: tools/bin/fetch_docs.js ---
@@ -25,42 +25,103 @@ var child_process = require("child_process");
 var yaml  = require("js-yaml");
 
 // constants
-var DEFAULT_REPO_PATH = "README.md";
+var DEFAULT_REPO_PATH= "README.md";
+var DEFAULT_PERMALINK_PREFIX = "/gen/";
 
-function generateFrontMatter (useDirectSrcURI, filePath, name, version) {
-var obj = {};
+function generateFrontMatter(fetchedFile) {
 
-if(useDirectSrcURI) {
-var p   = 
/https:\/\/raw.githubusercontent.com\/([^\/]+)\/([^\/]+)\/([^\/]+)\/(.+)/;
-var filePathSplit   = filePath.match(p);
-name= filePathSplit[1] + "/" + filePathSplit[2];
-version = filePathSplit[3];
-filePath= filePathSplit.slice(4).join("/");
+var frontMatterConfig = {};
+
+frontMatterConfig.edit_link = fetchedFile.editLink;
+frontMatterConfig.permalink = fetchedFile.permalink;
+
+// set special values for plugins
+if (isPluginName(fetchedFile.packageName)) {
+frontMatterConfig.plugin_name= fetchedFile.packageName;
+frontMatterConfig.plugin_version = fetchedFile.version;
 }
 
-obj.edit_link   = getRepoURIForFrontMatter(name, version, 
filePath);
-obj.plugin_name = name;
-obj.plugin_version  = version;
+// return front matter as a string
+var frontMatterString = "---\n" + yaml.dump(frontMatterConfig) + 
"---\n\n";
+return frontMatterString;
+}
 
-var frontMatter = "---\n" + yaml.dump(obj) + "\n---\n\n";
-return frontMatter;
+function isPluginName(packageName) {
+return packageName.match(/cordova-plugin-.*/);
 }
 
-function getRepoFileURI (name, version, filePath) {
-return "https://raw.githubusercontent.com/"; + name + "/" + version + 
"/" + filePath;
+function getRepoFileURI(repoName, commit, filePath) {
+return "https://raw.githubusercontent.com/"; + repoName + "/" + commit 
+ "/" + filePath;
 }
 
-function getRepoURIForFrontMatter (name, version, filePath) {
-return "https://github.com/"; + name + "/blob/" + version + "/"+ 
filePath
+function getRepoEditURI(repoName, commit, filePath) {
+return "https://github.com/"; + repoName + "/blob/" + commit + "/"+ 
filePath
 }
 
-function getLatestRelease (packageName) {
+function getLatestRelease(packageName) {
 var latestRelease = child_process.execSync("npm info " + packageName + 
" dist-tags.latest");
 return latestRelease.toString().trim();
 }
 
-function getPackageName (fileConfigSrc) {
-return fileConfigSrc.packageName || 
fileConfigSrc.repoName.split('/')[1];
+function packageNameFromRepoName(repoName) {
+var repoSplit  = repoName.split('/');
+var repoOwner  = repoSplit[0];
+var actualRepoName = repoSplit[1];
+return actualRepoName;
+}
+
+function getFetchedFile(entry) {
+
+// get entry components
+var srcConfig  = entry.src;
+var destConfig = entry.dest;
+
+// validate entry
+if (!srcConfig) {
+console.error("entry '" + entry.toString() + "' missing 'src'");
+return;
+}
+
+if (!srcConfig.repoName) {
+console.error("entry '" + entry.toString() + "' missing 'repoName' 
in 'src'");
+return;
+}
+
+if (!destConfig) {
+console.error("entry '" + entry.toString() + "' missing 'dest'");
+return;
+}
+
+// complete src config
+if (!srcConfig.packageName) {
+srcConfig.packageName = 
packageNameFromRepoName(srcConfig.repoName);
--- End diff --

I prefer very clear `if` statements because with long method/variable names 
sometimes the `||` is possible to miss. I opted for the former in this case 
because the names here are quite long.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Docs fetching improvements

2016-02-23 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/514#discussion_r53842147
  
--- Diff: www/_data/fetched-files.yml ---
@@ -1,153 +1,146 @@
+# REFERENCE ENTRY:
+#
+# -
+# src:# 
required
+# repoName:"apache/cordova-cli"   # 
required
+# packageName: "cordova"  # if 
empty: second part of repoName
+# commit:  "master"   # if 
empty: latest in NPM
+# path:"relative/path/to/file/in/repo.md" # if 
empty: "README.md"
+# dest:   # 
required
+# permalink:   "/absolute/path/on/cordova/site/index.html"# if 
empty: "/gen/" + packageName + "/"
+#
+
 -
 src:
 repoName: "apache/cordova-cli"
 packageName: "cordova"
+commit: "master"
 path: "doc/bash.md"
-dest: "cordova-cli/index.md"
+dest:
+permalink: "/docs/en/dev/cordova-cli/index.html"
 -
 src:
-repoName: apache/cordova-plugin-battery-status
-packageName: cordova-plugin-battery-status
-displayName: Battery Status
-description: Monitor the status of the device's battery.
-dest: cordova-plugin-battery-status/index.md
+repoName: "apache/cordova-plugin-battery-status"
+packageName: "cordova-plugin-battery-status"
+dest:
+permalink: "/docs/en/dev/cordova-plugin-battery-status/index.html"
--- End diff --

Each string here is custom and totally up to change. For example the 
`/docs/en/dev/` part will have to go once we have translation. I figured the 
`plugin` part would be redundant since the word is already in the plugin's ID. 
I can change it to `plugin` though, if you'd prefer. I don't have much of a 
preference.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Improve gulp watch perf and add --nofet...

2016-02-23 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/516#discussion_r53842391
  
--- Diff: gulpfile.js ---
@@ -236,7 +239,7 @@ gulp.task("serve", ["build"], function () {
 });
 });
 
-gulp.task("build", ["configs", "data", "styles", "plugins"], function 
(done) {
+gulp.task("build", [ "configs", "data", "styles", "plugins"], function 
(done) {
--- End diff --

Extra space there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Improve gulp watch perf and add --nofet...

2016-02-23 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/516#discussion_r53842352
  
--- Diff: gulpfile.js ---
@@ -249,7 +252,14 @@ gulp.task("regen", ["jekyll"], function () {
 });
 
 gulp.task("fetch", function (done) {
-exec("node", [bin("fetch_docs.js"), FETCH_CONFIG, FETCH_DIR], done);
+if (!argv.nofetch) {
--- End diff --

This could also just check if the fetch directory exists. If you want to 
re-fetch, just run `gulp clean`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Improve gulp watch perf and add --nofet...

2016-02-23 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/516#discussion_r53842656
  
--- Diff: gulpfile.js ---
@@ -24,6 +24,8 @@ var uglify = require("gulp-uglify");
 var envify = require("envify");
 var htmllint   = require("gulp-htmllint");
 var crawler= require("simplecrawler");
+var argv   = require('yargs').argv;
+var yaml   = require('js-yaml');
--- End diff --

These aren't used in the file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Improve gulp watch perf and add --nofet...

2016-02-23 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/516#discussion_r53842863
  
--- Diff: gulpfile.js ---
@@ -24,6 +24,8 @@ var uglify = require("gulp-uglify");
 var envify = require("envify");
 var htmllint   = require("gulp-htmllint");
 var crawler= require("simplecrawler");
+var argv   = require('yargs').argv;
--- End diff --

This file uses `gutil.env` for args parsing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Improve gulp watch perf and add --nofet...

2016-02-23 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/516#discussion_r53843081
  
--- Diff: gulpfile.js ---
@@ -210,9 +213,9 @@ gulp.task("watch", ["serve"], function () {
 );
 gulp.watch(
 [
-path.join(ROOT_DIR, "**", "*.yml"),
-path.join(SOURCE_DIR, "**", "*.html"),
-path.join(SOURCE_DIR, "**", "*.md"),
+path.join(DATA_DIR, "**", "*.yml"),
+path.join(SOURCE_DIR, "**", "*.html") + "!" + 
path.join(DOCS_DIR, "**"),
+path.join(SOURCE_DIR, "**", "*.md") + "!" + 
path.join(DOCS_DIR, "**") ,
--- End diff --

This won't regenerate the site if the docs change. Perhaps wrap this in `if 
(gutil.env.nodocs)`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Improve gulp watch perf and add --nofet...

2016-02-23 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/516#discussion_r53843179
  
--- Diff: gulpfile.js ---
@@ -210,9 +213,9 @@ gulp.task("watch", ["serve"], function () {
 );
 gulp.watch(
 [
-path.join(ROOT_DIR, "**", "*.yml"),
-path.join(SOURCE_DIR, "**", "*.html"),
-path.join(SOURCE_DIR, "**", "*.md"),
+path.join(DATA_DIR, "**", "*.yml"),
--- End diff --

We want to regenerate the site if the configs change too, and `DATA_DIR` 
doesn't include `CONFIG_DIR`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Making windows guide single page

2016-02-23 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/512#discussion_r53843320
  
--- Diff: www/_data/redirects.yml ---
@@ -13,6 +13,8 @@ docs:
 - {old: "dev/guide/platforms/ios/config.html", new: 
"dev/config_ref/index.html"}
 - {old: "latest/guide/platforms/ios/tools.html", new: 
"latest/guide/platforms/ios/index.html"}
 - {old: "latest/guide/platforms/ios/config.html", new: 
"latest/config_ref/index.html"}
+- {old: "dev/guide/platforms/win8/packaging.html", new: 
"dev/guide/platforms/win8/index.html#signing-an-app"}
+- {old: "dev/guide/platforms/win8/win10-support.html", new: 
"dev/guide/platforms/win8/index.html"}
--- End diff --

For what it's worth, you can just add both.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Making windows guide single page

2016-02-23 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/512#discussion_r53843979
  
--- Diff: www/_data/redirects.yml ---
@@ -13,6 +13,8 @@ docs:
 - {old: "dev/guide/platforms/ios/config.html", new: 
"dev/config_ref/index.html"}
 - {old: "latest/guide/platforms/ios/tools.html", new: 
"latest/guide/platforms/ios/index.html"}
 - {old: "latest/guide/platforms/ios/config.html", new: 
"latest/config_ref/index.html"}
+- {old: "dev/guide/platforms/win8/packaging.html", new: 
"dev/guide/platforms/win8/index.html#signing-an-app"}
+- {old: "dev/guide/platforms/win8/win10-support.html", new: 
"dev/guide/platforms/win8/index.html"}
--- End diff --

@rakatyal: @r@riknoll just pointed out to me that adding `/latest/` 
redirects before we do the whole `6.x` thing will kill pages in `6.0.0`. Please 
then add the `/latest/` redirects commented-out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding latest redirects for windows gui...

2016-02-23 Thread rakatyal

GitHub user rakatyal opened a pull request:

https://github.com/apache/cordova-docs/pull/518

Adding latest redirects for windows guide

@dblotsky, @riknoll to review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs raghav-latest

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/518.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #518


commit 61af67a7b9803a6bed9eeeb4c0957c5a7a01da4b
Author: Raghav Katyal 
Date:   2016-02-23T20:36:09Z

Adding latest redirects for windows guide




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding latest redirects for windows gui...

2016-02-23 Thread riknoll

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/518#issuecomment-187892289
  
Relevant JIRA: https://issues.apache.org/jira/browse/CB-10672


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding latest redirects for windows gui...

2016-02-23 Thread riknoll

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/518#issuecomment-187892982
  
Might as well add comments for all the platform guides while you're here. 
For iOS and Android, it's just switching the dev redirects to latest redirects


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

2016-02-23 Thread alsorokin

Github user alsorokin commented on the pull request:

https://github.com/apache/cordova-windows/pull/152#issuecomment-187893159
  
@dblotsky when I was writing this code, I made continuous logging the 
default behavior because the log script for Android platform is continuously 
printing the logcat output.
The ios log command tries to output the log file by using `tail -f` command 
which should print file contents continuously too.

I think that for the sake of consistency cordova-windows should behave like 
the other platforms do.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding latest redirects for windows gui...

2016-02-23 Thread rakatyal

Github user rakatyal commented on the pull request:

https://github.com/apache/cordova-docs/pull/518#issuecomment-187893217
  
Alright.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10530 - App freezes sometimes directl...

2016-02-23 Thread rpayanm

Github user rpayanm commented on the pull request:

https://github.com/apache/cordova-ios/pull/193#issuecomment-187893848
  
:+1:  Works for me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding latest redirects for windows gui...

2016-02-23 Thread riknoll

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/518#issuecomment-187897554
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...

2016-02-23 Thread rakatyal

Github user rakatyal commented on the pull request:

https://github.com/apache/cordova-docs/pull/517#issuecomment-187898038
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Docs fetching improvements

2016-02-23 Thread nikhilkh

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/514#discussion_r53848104
  
--- Diff: tools/bin/fetch_docs.js ---
@@ -25,42 +25,103 @@ var child_process = require("child_process");
 var yaml  = require("js-yaml");
 
 // constants
-var DEFAULT_REPO_PATH = "README.md";
+var DEFAULT_REPO_PATH= "README.md";
+var DEFAULT_PERMALINK_PREFIX = "/gen/";
 
-function generateFrontMatter (useDirectSrcURI, filePath, name, version) {
-var obj = {};
+function generateFrontMatter(fetchedFile) {
 
-if(useDirectSrcURI) {
-var p   = 
/https:\/\/raw.githubusercontent.com\/([^\/]+)\/([^\/]+)\/([^\/]+)\/(.+)/;
-var filePathSplit   = filePath.match(p);
-name= filePathSplit[1] + "/" + filePathSplit[2];
-version = filePathSplit[3];
-filePath= filePathSplit.slice(4).join("/");
+var frontMatterConfig = {};
+
+frontMatterConfig.edit_link = fetchedFile.editLink;
+frontMatterConfig.permalink = fetchedFile.permalink;
+
+// set special values for plugins
+if (isPluginName(fetchedFile.packageName)) {
+frontMatterConfig.plugin_name= fetchedFile.packageName;
+frontMatterConfig.plugin_version = fetchedFile.version;
 }
 
-obj.edit_link   = getRepoURIForFrontMatter(name, version, 
filePath);
-obj.plugin_name = name;
-obj.plugin_version  = version;
+// return front matter as a string
+var frontMatterString = "---\n" + yaml.dump(frontMatterConfig) + 
"---\n\n";
+return frontMatterString;
+}
 
-var frontMatter = "---\n" + yaml.dump(obj) + "\n---\n\n";
-return frontMatter;
+function isPluginName(packageName) {
+return packageName.match(/cordova-plugin-.*/);
 }
 
-function getRepoFileURI (name, version, filePath) {
-return "https://raw.githubusercontent.com/"; + name + "/" + version + 
"/" + filePath;
+function getRepoFileURI(repoName, commit, filePath) {
+return "https://raw.githubusercontent.com/"; + repoName + "/" + commit 
+ "/" + filePath;
 }
 
-function getRepoURIForFrontMatter (name, version, filePath) {
-return "https://github.com/"; + name + "/blob/" + version + "/"+ 
filePath
+function getRepoEditURI(repoName, commit, filePath) {
+return "https://github.com/"; + repoName + "/blob/" + commit + "/"+ 
filePath
 }
 
-function getLatestRelease (packageName) {
+function getLatestRelease(packageName) {
 var latestRelease = child_process.execSync("npm info " + packageName + 
" dist-tags.latest");
 return latestRelease.toString().trim();
 }
 
-function getPackageName (fileConfigSrc) {
-return fileConfigSrc.packageName || 
fileConfigSrc.repoName.split('/')[1];
+function packageNameFromRepoName(repoName) {
+var repoSplit  = repoName.split('/');
+var repoOwner  = repoSplit[0];
+var actualRepoName = repoSplit[1];
+return actualRepoName;
+}
+
+function getFetchedFile(entry) {
+
+// get entry components
+var srcConfig  = entry.src;
+var destConfig = entry.dest;
+
+// validate entry
+if (!srcConfig) {
+console.error("entry '" + entry.toString() + "' missing 'src'");
--- End diff --

In this case you would not catch - it's a truly exceptional case and you 
can't handle it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10639 Appium tests: Added s...

2016-02-23 Thread alsorokin

Github user alsorokin commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/177#discussion_r53848875
  
--- Diff: appium-tests/android/android.spec.js ---
@@ -1,28 +1,34 @@
-/*jslint node: true, plusplus: true */
+/*jshint node: true */
 /*global beforeEach, afterEach */
 /*global describe, it, xit, expect, jasmine */
-'use strict';
 
 // these tests are meant to be executed by Cordova Medic Appium runner
 // you can find it here: https://github.com/apache/cordova-medic/
 // it is not necessary to do a full CI setup to run these tests
 // just run "node cordova-medic/medic/medic.js appium --platform android 
--plugins cordova-plugin-camera"
 
+'use strict';
+
 var wdHelper = require('../helpers/wdHelper');
 var wd = wdHelper.getWD();
 var cameraConstants = require('../../www/CameraConstants');
 var cameraHelper = require('../helpers/cameraHelper');
+var screenshotHelper = require('../helpers/screenshotHelper');
 
 describe('Camera tests Android.', function () {
+
+var STARTING_MESSAGE = 'Ready for action!',
+RETRY_COUNT = 3, // how many times to retry taking a picture 
before failing
+MINUTE = 60 * 1000;
+
 var driver,
-startingMessage = 'Ready for action!',
 // the name of webview context, it will be changed to match needed 
context if there are named ones:
 webviewContext = 'WEBVIEW',
-// this indicates if device library has test picture:
+// this indicates if device library has the test picture:
 isTestPictureSaved = false,
-// this indecates that there was critical error and tests cannot 
continue:
+// this indecates that there was a critical error and tests cannot 
continue:
 stopFlag = false,
-// we need to know the screen width and height to properly click 
on the first image in the gallery
+// we need to know the screen width and height to properly click 
on an image in the gallery
 screenWidth = 360,
 screenHeight = 567;
--- End diff --

No, these values can change when we determining the real device resolution.
These are just default values.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

2016-02-23 Thread dblotsky

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-windows/pull/152#issuecomment-187914846
  
@alsorokin those other commands print only new messages continuously. The 
Windows script prints existing messages over and over again, which is a 
different behavior. We should either make it behave the same, or put the 
looping behavior behind a flag.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Docs fetching improvements

2016-02-23 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/514#discussion_r53852122
  
--- Diff: tools/bin/fetch_docs.js ---
@@ -25,42 +25,103 @@ var child_process = require("child_process");
 var yaml  = require("js-yaml");
 
 // constants
-var DEFAULT_REPO_PATH = "README.md";
+var DEFAULT_REPO_PATH= "README.md";
+var DEFAULT_PERMALINK_PREFIX = "/gen/";
 
-function generateFrontMatter (useDirectSrcURI, filePath, name, version) {
-var obj = {};
+function generateFrontMatter(fetchedFile) {
 
-if(useDirectSrcURI) {
-var p   = 
/https:\/\/raw.githubusercontent.com\/([^\/]+)\/([^\/]+)\/([^\/]+)\/(.+)/;
-var filePathSplit   = filePath.match(p);
-name= filePathSplit[1] + "/" + filePathSplit[2];
-version = filePathSplit[3];
-filePath= filePathSplit.slice(4).join("/");
+var frontMatterConfig = {};
+
+frontMatterConfig.edit_link = fetchedFile.editLink;
+frontMatterConfig.permalink = fetchedFile.permalink;
+
+// set special values for plugins
+if (isPluginName(fetchedFile.packageName)) {
+frontMatterConfig.plugin_name= fetchedFile.packageName;
+frontMatterConfig.plugin_version = fetchedFile.version;
 }
 
-obj.edit_link   = getRepoURIForFrontMatter(name, version, 
filePath);
-obj.plugin_name = name;
-obj.plugin_version  = version;
+// return front matter as a string
+var frontMatterString = "---\n" + yaml.dump(frontMatterConfig) + 
"---\n\n";
+return frontMatterString;
+}
 
-var frontMatter = "---\n" + yaml.dump(obj) + "\n---\n\n";
-return frontMatter;
+function isPluginName(packageName) {
+return packageName.match(/cordova-plugin-.*/);
 }
 
-function getRepoFileURI (name, version, filePath) {
-return "https://raw.githubusercontent.com/"; + name + "/" + version + 
"/" + filePath;
+function getRepoFileURI(repoName, commit, filePath) {
+return "https://raw.githubusercontent.com/"; + repoName + "/" + commit 
+ "/" + filePath;
 }
 
-function getRepoURIForFrontMatter (name, version, filePath) {
-return "https://github.com/"; + name + "/blob/" + version + "/"+ 
filePath
+function getRepoEditURI(repoName, commit, filePath) {
+return "https://github.com/"; + repoName + "/blob/" + commit + "/"+ 
filePath
 }
 
-function getLatestRelease (packageName) {
+function getLatestRelease(packageName) {
 var latestRelease = child_process.execSync("npm info " + packageName + 
" dist-tags.latest");
 return latestRelease.toString().trim();
 }
 
-function getPackageName (fileConfigSrc) {
-return fileConfigSrc.packageName || 
fileConfigSrc.repoName.split('/')[1];
+function packageNameFromRepoName(repoName) {
+var repoSplit  = repoName.split('/');
+var repoOwner  = repoSplit[0];
+var actualRepoName = repoSplit[1];
+return actualRepoName;
+}
+
+function getFetchedFile(entry) {
+
+// get entry components
+var srcConfig  = entry.src;
+var destConfig = entry.dest;
+
+// validate entry
+if (!srcConfig) {
+console.error("entry '" + entry.toString() + "' missing 'src'");
--- End diff --

The current behavior is to ignore malformed entries and continue running.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding latest redirects for platform gu...

2016-02-23 Thread dblotsky

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/518#issuecomment-187937121
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Adding latest redirects for platform gu...

2016-02-23 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/518


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Improve gulp watch perf and add --nofet...

2016-02-23 Thread nikhilkh

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/516#discussion_r53862395
  
--- Diff: gulpfile.js ---
@@ -210,9 +213,9 @@ gulp.task("watch", ["serve"], function () {
 );
 gulp.watch(
 [
-path.join(ROOT_DIR, "**", "*.yml"),
-path.join(SOURCE_DIR, "**", "*.html"),
-path.join(SOURCE_DIR, "**", "*.md"),
+path.join(DATA_DIR, "**", "*.yml"),
--- End diff --

Fair enough - I removed this change as it was not helping the perf.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Hamronize CFBudleIndtifier

2016-02-23 Thread Steven Gill

+1

On Tue, Feb 23, 2016 at 6:24 AM, julio cesar sanchez  wrote:

> +1 to prefixed versions
>
> I always use the same bundle identifier/package name for the same app, but
> I sometimes have to use a different version for the android or iOS app, so
> it's better if I can set them directly from the config.xml and not use a
> hook.
>
>
> 2016-02-23 7:54 GMT+01:00 Tobias Bocanegra :
>
> > Hi,
> >
> > he current commons code uses ios-CFBundleVersion and
> > ios-CFBundleIdentifier: [0], [1]
> >
> > Now with OSX in the game there could be similar new attributes
> > osx-CFBundleVersion and osx-CFBundleIdentifier or we could deprecate
> > the ios-* ones and just use their plain names without prefix.
> >
> > suggest:
> > - use CFBundleVersion and CFBundleIdentifier for iOS and OSX platform.
> > - deprecate ios-CFBundleVersion and ios-CFBundleIdentifier
> >
> > drawback:
> >   using the un-prefixed attribute names would prevent a project of
> > having different versions/identifiers for the ios and osx platforms.
> > if one wants to evolve them separately, he would then need to use some
> > hooks to tweak the config.xml.
> >
> > counter argument:
> >   windows and android also use prefixed versions, so maybe its better
> > to keep this pattern consistent.
> >
> > see [2].
> >
> > regards, toby
> >
> > [0]
> >
> https://github.com/apache/cordova-lib/blob/6.0.0/cordova-common/src/ConfigParser/ConfigParser.js#L106
> > [1]
> >
> https://github.com/apache/cordova-lib/blob/6.0.0/cordova-common/src/ConfigParser/ConfigParser.js#L132
> > [2] https://issues.apache.org/jira/browse/CB-10603
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>

[GitHub] cordova-plugin-camera pull request: CB-10639 Appium tests: Added s...

2016-02-23 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/177#discussion_r53877650
  
--- Diff: appium-tests/android/android.spec.js ---
@@ -1,28 +1,34 @@
-/*jslint node: true, plusplus: true */
+/*jshint node: true */
 /*global beforeEach, afterEach */
 /*global describe, it, xit, expect, jasmine */
-'use strict';
 
 // these tests are meant to be executed by Cordova Medic Appium runner
 // you can find it here: https://github.com/apache/cordova-medic/
 // it is not necessary to do a full CI setup to run these tests
 // just run "node cordova-medic/medic/medic.js appium --platform android 
--plugins cordova-plugin-camera"
 
+'use strict';
+
 var wdHelper = require('../helpers/wdHelper');
 var wd = wdHelper.getWD();
 var cameraConstants = require('../../www/CameraConstants');
 var cameraHelper = require('../helpers/cameraHelper');
+var screenshotHelper = require('../helpers/screenshotHelper');
 
 describe('Camera tests Android.', function () {
+
+var STARTING_MESSAGE = 'Ready for action!',
+RETRY_COUNT = 3, // how many times to retry taking a picture 
before failing
+MINUTE = 60 * 1000;
+
 var driver,
-startingMessage = 'Ready for action!',
 // the name of webview context, it will be changed to match needed 
context if there are named ones:
 webviewContext = 'WEBVIEW',
-// this indicates if device library has test picture:
+// this indicates if device library has the test picture:
 isTestPictureSaved = false,
-// this indecates that there was critical error and tests cannot 
continue:
+// this indecates that there was a critical error and tests cannot 
continue:
--- End diff --

"indecates" -> "indicates"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10639 Appium tests: Added s...

2016-02-23 Thread dblotsky

Github user dblotsky commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/177#issuecomment-187991977
  
Thanks for fixing some of the grammar errors in the comments, btw!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10639 Appium tests: Added s...

2016-02-23 Thread dblotsky

Github user dblotsky commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/177#discussion_r53878681
  
--- Diff: appium-tests/android/android.spec.js ---
@@ -1,28 +1,34 @@
-/*jslint node: true, plusplus: true */
+/*jshint node: true */
 /*global beforeEach, afterEach */
 /*global describe, it, xit, expect, jasmine */
-'use strict';
 
 // these tests are meant to be executed by Cordova Medic Appium runner
 // you can find it here: https://github.com/apache/cordova-medic/
 // it is not necessary to do a full CI setup to run these tests
 // just run "node cordova-medic/medic/medic.js appium --platform android 
--plugins cordova-plugin-camera"
 
+'use strict';
+
 var wdHelper = require('../helpers/wdHelper');
 var wd = wdHelper.getWD();
 var cameraConstants = require('../../www/CameraConstants');
 var cameraHelper = require('../helpers/cameraHelper');
+var screenshotHelper = require('../helpers/screenshotHelper');
 
 describe('Camera tests Android.', function () {
+
+var STARTING_MESSAGE = 'Ready for action!',
+RETRY_COUNT = 3, // how many times to retry taking a picture 
before failing
+MINUTE = 60 * 1000;
+
 var driver,
-startingMessage = 'Ready for action!',
 // the name of webview context, it will be changed to match needed 
context if there are named ones:
 webviewContext = 'WEBVIEW',
-// this indicates if device library has test picture:
+// this indicates if device library has the test picture:
 isTestPictureSaved = false,
-// this indecates that there was critical error and tests cannot 
continue:
+// this indecates that there was a critical error and tests cannot 
continue:
 stopFlag = false,
-// we need to know the screen width and height to properly click 
on the first image in the gallery
+// we need to know the screen width and height to properly click 
on an image in the gallery
 screenWidth = 360,
 screenHeight = 567;
--- End diff --

Please then set the defaults to be constants at the top just so we don't 
have seemingly magic values in the code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10347: Remove 'Add icons and splash ...

2016-02-23 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/517


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10337: Changing whitelist guide to r...

2016-02-23 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/509


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Docs fetching improvements

2016-02-23 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/514


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: Android and iOS bug release

2016-02-23 Thread Nikhil Khandelwal

Where are we with releases here? Can we still do a patch release (not requiring 
a TOOLS update)?

Looks like there is also this JIRA: 
https://issues.apache.org/jira/browse/CB-10493 which is causing iOS apps to be 
rejected.

Thanks,
Nikhil

-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com] 
Sent: Thursday, February 18, 2016 4:05 AM
To: dev@cordova.apache.org
Subject: Re: Android and iOS bug release

Frederico 

I didn't want unnecessary pressure on anyone to work on a bug by putting a 
release  on hold. 

I spent some time with Mike from Ionic and I was not able to reproduce or make 
heads or tail out of this bug. 

I'm glad to hear progress on the bug, thanks to Torsten and Shaz :-)

- Carlos
@csantanapr

> On Feb 17, 2016, at 4:34 AM, Frederico Galvão 
>  wrote:
> 
> It seems Shaz sorted the bug out already [1]. And I agree with and 
> understand every point you made, Carlos. Thank you.
> 
> 
> [1] - https://github.com/apache/cordova-ios/pull/193
> 
> 2016-02-16 16:22 GMT-02:00 Carlos Santana :
> 
>> Cutting releases don't cost $$, just some time
>> 
>> We just try to minimize effort and consolidate many bugs that are 
>> ready for one release.
>> 
>> if we have a fix that can make it in the release window that's OK to 
>> wait, but we can always do a bug release today, and another bug 
>> release when that bug is fix
>> 
>> If there is outlook to get the bug fix soon, I would say we wait but 
>> if not then we just pick it up on the next bug release.
>> 
>> Looking at the JIRA the bug is still under investigation
>> 
>> 
>> 
>> On Tue, Feb 16, 2016 at 9:18 AM Frederico Galvão < 
>> frederico.gal...@pontoget.com.br> wrote:
>> 
>>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fiss
>>> ues.apache.org%2fjira%2fbrowse%2fCB-10530&data=01%7c01%7cnikhilkh%40
>>> microsoft.com%7cf84eec968ce545b6208f08d3385bc476%7c72f988bf86f141af9
>>> 1ab2d7cd011db47%7c1&sdata=QTC05NEPHkr99mis1G6Rfg1fLpLXYUMTI2UsnRsxNN
>>> k%3d is a showstopper for
>> quite
>>> a
>>> few people. If that ever requires changes to cordova-ios, I'm voting 
>>> that the bugfix releases wait for it or that we find a workaround 
>>> that isn't uninstalling every plugin.
>>> 
>>> 2016-02-16 1:58 GMT-02:00 Carlos Santana :
>>> 
 Tomorrow is my birthday, I will take them as gifts :-)
 
 
 On Mon, Feb 15, 2016 at 10:55 PM Steven Gill 
 
 wrote:
 
> Yeah, I can start these releases. Hopefully tomorrow.
> 
> -Steve
> 
> On Mon, Feb 15, 2016 at 7:46 PM, Carlos Santana <
>> csantan...@gmail.com>
> wrote:
> 
>> +1
>> Steve would you mind doing these bug release?
>> 
>> Should we wait to see what happens with the ios freeze bug [1],? 
>> or
 just
> do
>> a bug release now, and then do another later when that one is
>>> resolved
> and
>> keep the train going
>> 
>> [1] : 
>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2f
>> issues.apache.org%2fjira%2fbrowse%2fCB-10530&data=01%7c01%7cnikhi
>> lkh%40microsoft.com%7cf84eec968ce545b6208f08d3385bc476%7c72f988bf
>> 86f141af91ab2d7cd011db47%7c1&sdata=QTC05NEPHkr99mis1G6Rfg1fLpLXYU
>> MTI2UsnRsxNNk%3d
>> 
>> 
>>> On Mon, Feb 15, 2016 at 6:01 PM Dan Polivy 
>>> 
>> wrote:
>> 
>>> Is there any progress on an android bugfix release? It looks 
>>> like Richard's PR has been merged in, and I'm waiting for that 
>>> (and
>> the
 fix
>> for
>>> CB-10138) to be pushed out in a production release.
>>> 
>>> Thanks,
>>> Dan
>>> 
>>> -Original Message-
>>> From: Carlos Santana [mailto:csantan...@gmail.com]
>>> Sent: Thursday, February 04, 2016 5:23 PM
>>> To: dev@cordova.apache.org
>>> Subject: Re: Android and iOS bug release
>>> 
>>> I will take a look
>>> 
>>> On Thu, Feb 4, 2016 at 1:23 PM Richard Knoll <
>>> rikn...@microsoft.com>
>>> wrote:
>>> 
 I have a PR open in cordova-android that should probably be
>>> merged
>> first.
 It addresses a bug in the save/restore API that a few people
>> are
>>> hitting. I
 still have some updates/testing to do but I hope to merge it in
 soon.
>>> Would
 love some feedback if anyone has a chance to review.
 
 The PR is here:
 https://github.com/apache/cordova-android/pull/257
 
 And the JIRA is here:
 https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%
 2fissues.apache.org%2fjira%2fbrowse%2fCB-10498&data=01%7c01%7cn
 ikhilkh%40microsoft.com%7cf84eec968ce545b6208f08d3385bc476%7c72
 f988bf86f141af91ab2d7cd011db47%7c1&sdata=DSCu44DFTYYL9D1VsoxsjJ
 xWNTejAPzVeApam9CKtd8%3d
 
 Thanks,
 Richard
 
 -Original Message-
 From: Carlos Santana [mailto:csantan...@gmail.com]
 Sent: Thursday, February 4,

Re: Hamronize CFBudleIndtifier

2016-02-23 Thread Tobias Bocanegra

On Tue, Feb 23, 2016 at 4:16 PM, Steven Gill  wrote:
> +1

+1 to what? keep the prefixes or remove them? :-))

regards, toby

>
> On Tue, Feb 23, 2016 at 6:24 AM, julio cesar sanchez > wrote:
>
>> +1 to prefixed versions
>>
>> I always use the same bundle identifier/package name for the same app, but
>> I sometimes have to use a different version for the android or iOS app, so
>> it's better if I can set them directly from the config.xml and not use a
>> hook.
>>
>>
>> 2016-02-23 7:54 GMT+01:00 Tobias Bocanegra :
>>
>> > Hi,
>> >
>> > he current commons code uses ios-CFBundleVersion and
>> > ios-CFBundleIdentifier: [0], [1]
>> >
>> > Now with OSX in the game there could be similar new attributes
>> > osx-CFBundleVersion and osx-CFBundleIdentifier or we could deprecate
>> > the ios-* ones and just use their plain names without prefix.
>> >
>> > suggest:
>> > - use CFBundleVersion and CFBundleIdentifier for iOS and OSX platform.
>> > - deprecate ios-CFBundleVersion and ios-CFBundleIdentifier
>> >
>> > drawback:
>> >   using the un-prefixed attribute names would prevent a project of
>> > having different versions/identifiers for the ios and osx platforms.
>> > if one wants to evolve them separately, he would then need to use some
>> > hooks to tweak the config.xml.
>> >
>> > counter argument:
>> >   windows and android also use prefixed versions, so maybe its better
>> > to keep this pattern consistent.
>> >
>> > see [2].
>> >
>> > regards, toby
>> >
>> > [0]
>> >
>> https://github.com/apache/cordova-lib/blob/6.0.0/cordova-common/src/ConfigParser/ConfigParser.js#L106
>> > [1]
>> >
>> https://github.com/apache/cordova-lib/blob/6.0.0/cordova-common/src/ConfigParser/ConfigParser.js#L132
>> > [2] https://issues.apache.org/jira/browse/CB-10603
>> >
>> > -
>> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> > For additional commands, e-mail: dev-h...@cordova.apache.org
>> >
>> >
>>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Hamronize CFBudleIndtifier

2016-02-23 Thread Steven Gill

Oops. My +1 was for removing them in this case. But I don't have a issue
with keeping them either. Let's see what Shaz says when he manages to feel
better. He has been sick the last few days.
On Feb 23, 2016 6:39 PM, "Tobias Bocanegra"  wrote:

> On Tue, Feb 23, 2016 at 4:16 PM, Steven Gill 
> wrote:
> > +1
>
> +1 to what? keep the prefixes or remove them? :-))
>
> regards, toby
>
> >
> > On Tue, Feb 23, 2016 at 6:24 AM, julio cesar sanchez <
> jcesarmob...@gmail.com
> >> wrote:
> >
> >> +1 to prefixed versions
> >>
> >> I always use the same bundle identifier/package name for the same app,
> but
> >> I sometimes have to use a different version for the android or iOS app,
> so
> >> it's better if I can set them directly from the config.xml and not use a
> >> hook.
> >>
> >>
> >> 2016-02-23 7:54 GMT+01:00 Tobias Bocanegra :
> >>
> >> > Hi,
> >> >
> >> > he current commons code uses ios-CFBundleVersion and
> >> > ios-CFBundleIdentifier: [0], [1]
> >> >
> >> > Now with OSX in the game there could be similar new attributes
> >> > osx-CFBundleVersion and osx-CFBundleIdentifier or we could deprecate
> >> > the ios-* ones and just use their plain names without prefix.
> >> >
> >> > suggest:
> >> > - use CFBundleVersion and CFBundleIdentifier for iOS and OSX platform.
> >> > - deprecate ios-CFBundleVersion and ios-CFBundleIdentifier
> >> >
> >> > drawback:
> >> >   using the un-prefixed attribute names would prevent a project of
> >> > having different versions/identifiers for the ios and osx platforms.
> >> > if one wants to evolve them separately, he would then need to use some
> >> > hooks to tweak the config.xml.
> >> >
> >> > counter argument:
> >> >   windows and android also use prefixed versions, so maybe its better
> >> > to keep this pattern consistent.
> >> >
> >> > see [2].
> >> >
> >> > regards, toby
> >> >
> >> > [0]
> >> >
> >>
> https://github.com/apache/cordova-lib/blob/6.0.0/cordova-common/src/ConfigParser/ConfigParser.js#L106
> >> > [1]
> >> >
> >>
> https://github.com/apache/cordova-lib/blob/6.0.0/cordova-common/src/ConfigParser/ConfigParser.js#L132
> >> > [2] https://issues.apache.org/jira/browse/CB-10603
> >> >
> >> > -
> >> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> >> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >> >
> >> >
> >>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

RE: Android and iOS bug release

2016-02-23 Thread Steven Gill

Sorry, yes. I'll send out votes for both tomorrow. Android can be a patch I
believe. IOS we will have to review.

-Steve
On Feb 23, 2016 6:26 PM, "Nikhil Khandelwal"  wrote:

> Where are we with releases here? Can we still do a patch release (not
> requiring a TOOLS update)?
>
> Looks like there is also this JIRA:
> https://issues.apache.org/jira/browse/CB-10493 which is causing iOS apps
> to be rejected.
>
> Thanks,
> Nikhil
>
> -Original Message-
> From: Carlos Santana [mailto:csantan...@gmail.com]
> Sent: Thursday, February 18, 2016 4:05 AM
> To: dev@cordova.apache.org
> Subject: Re: Android and iOS bug release
>
> Frederico
>
> I didn't want unnecessary pressure on anyone to work on a bug by putting a
> release  on hold.
>
> I spent some time with Mike from Ionic and I was not able to reproduce or
> make heads or tail out of this bug.
>
> I'm glad to hear progress on the bug, thanks to Torsten and Shaz :-)
>
> - Carlos
> @csantanapr
>
> > On Feb 17, 2016, at 4:34 AM, Frederico Galvão <
> frederico.gal...@pontoget.com.br> wrote:
> >
> > It seems Shaz sorted the bug out already [1]. And I agree with and
> > understand every point you made, Carlos. Thank you.
> >
> >
> > [1] - https://github.com/apache/cordova-ios/pull/193
> >
> > 2016-02-16 16:22 GMT-02:00 Carlos Santana :
> >
> >> Cutting releases don't cost $$, just some time
> >>
> >> We just try to minimize effort and consolidate many bugs that are
> >> ready for one release.
> >>
> >> if we have a fix that can make it in the release window that's OK to
> >> wait, but we can always do a bug release today, and another bug
> >> release when that bug is fix
> >>
> >> If there is outlook to get the bug fix soon, I would say we wait but
> >> if not then we just pick it up on the next bug release.
> >>
> >> Looking at the JIRA the bug is still under investigation
> >>
> >>
> >>
> >> On Tue, Feb 16, 2016 at 9:18 AM Frederico Galvão <
> >> frederico.gal...@pontoget.com.br> wrote:
> >>
> >>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fiss
> >>> ues.apache.org%2fjira%2fbrowse%2fCB-10530&data=01%7c01%7cnikhilkh%40
> >>> microsoft.com%7cf84eec968ce545b6208f08d3385bc476%7c72f988bf86f141af9
> >>> 1ab2d7cd011db47%7c1&sdata=QTC05NEPHkr99mis1G6Rfg1fLpLXYUMTI2UsnRsxNN
> >>> k%3d is a showstopper for
> >> quite
> >>> a
> >>> few people. If that ever requires changes to cordova-ios, I'm voting
> >>> that the bugfix releases wait for it or that we find a workaround
> >>> that isn't uninstalling every plugin.
> >>>
> >>> 2016-02-16 1:58 GMT-02:00 Carlos Santana :
> >>>
>  Tomorrow is my birthday, I will take them as gifts :-)
> 
> 
>  On Mon, Feb 15, 2016 at 10:55 PM Steven Gill
>  
>  wrote:
> 
> > Yeah, I can start these releases. Hopefully tomorrow.
> >
> > -Steve
> >
> > On Mon, Feb 15, 2016 at 7:46 PM, Carlos Santana <
> >> csantan...@gmail.com>
> > wrote:
> >
> >> +1
> >> Steve would you mind doing these bug release?
> >>
> >> Should we wait to see what happens with the ios freeze bug [1],?
> >> or
>  just
> > do
> >> a bug release now, and then do another later when that one is
> >>> resolved
> > and
> >> keep the train going
> >>
> >> [1] :
> >> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2f
> >> issues.apache.org%2fjira%2fbrowse%2fCB-10530&data=01%7c01%7cnikhi
> >> lkh%40microsoft.com%7cf84eec968ce545b6208f08d3385bc476%7c72f988bf
> >> 86f141af91ab2d7cd011db47%7c1&sdata=QTC05NEPHkr99mis1G6Rfg1fLpLXYU
> >> MTI2UsnRsxNNk%3d
> >>
> >>
> >>> On Mon, Feb 15, 2016 at 6:01 PM Dan Polivy
> >>> 
> >> wrote:
> >>
> >>> Is there any progress on an android bugfix release? It looks
> >>> like Richard's PR has been merged in, and I'm waiting for that
> >>> (and
> >> the
>  fix
> >> for
> >>> CB-10138) to be pushed out in a production release.
> >>>
> >>> Thanks,
> >>> Dan
> >>>
> >>> -Original Message-
> >>> From: Carlos Santana [mailto:csantan...@gmail.com]
> >>> Sent: Thursday, February 04, 2016 5:23 PM
> >>> To: dev@cordova.apache.org
> >>> Subject: Re: Android and iOS bug release
> >>>
> >>> I will take a look
> >>>
> >>> On Thu, Feb 4, 2016 at 1:23 PM Richard Knoll <
> >>> rikn...@microsoft.com>
> >>> wrote:
> >>>
>  I have a PR open in cordova-android that should probably be
> >>> merged
> >> first.
>  It addresses a bug in the save/restore API that a few people
> >> are
> >>> hitting. I
>  still have some updates/testing to do but I hope to merge it in
>  soon.
> >>> Would
>  love some feedback if anyone has a chance to review.
> 
>  The PR is here:
>  https://github.com/apache/cordova-android/pull/257
> 
>  And the JIRA is here:
>  https://na01.safelinks.protection.outlook.com/?url=https%3a%2f

[GitHub] cordova-ios pull request: CB-10530 - App freezes sometimes directl...

2016-02-23 Thread adyz

Github user adyz commented on the pull request:

https://github.com/apache/cordova-ios/pull/193#issuecomment-188126958
  
Works for me too


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request: CB-10636 CB-10683 Add JSHin...

2016-02-23 Thread daserge

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-plugin-statusbar/pull/49

CB-10636 CB-10683 Add JSHint for plugins

[CB-10636 Add JSHint for 
plugins](https://issues.apache.org/jira/browse/CB-10636)
[CB-10683 Fix wrong StatusBar.isVisible initial value on 
Windows](https://issues.apache.org/jira/browse/CB-10683)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/daserge/cordova-plugin-statusbar CB-10636

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-statusbar/pull/49.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #49


commit 8a3f9edb9d3a32db89f42e8ae3b08185533dc19c
Author: daserge 
Date:   2016-02-24T07:28:04Z

CB-10636 Add JSHint for plugins

commit bf7869cec7a46e0a538c2e4d61ffa28ddba135cf
Author: daserge 
Date:   2016-02-24T07:32:46Z

CB-10683 Fix wrong StatusBar.isVisible initial value on Windows




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10640: Windows logging is broken

2016-02-23 Thread alsorokin

Github user alsorokin commented on the pull request:

https://github.com/apache/cordova-windows/pull/152#issuecomment-188131082
  
@dblotsky ouch. That's clearly a bug. It shouldn't do that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

68 matches

Mail list logo