[GitHub] cordova-plugin-media-capture pull request: add JIRA issue tracker ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-media-capture/pull/45


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media-capture pull request: CB-10690 windows: fix c...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-media-capture/pull/56


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10660 fixed the exception when re...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-android/pull/261


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-10660 fixed the exception when re...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-android/pull/261#issuecomment-189149877
  
LGTM, merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10314 avoid fetching plugins when old...

[bso-intel]

Github user bso-intel commented on the pull request:

https://github.com/apache/cordova-lib/pull/396#issuecomment-189123404
  
@vladimir-kotikov 
Could you review this?
Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-inappbrowser pull request: Should the README design...

[josh-m-sharpe]

GitHub user josh-m-sharpe opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/152

Should the README designate where general discussions take place?



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/josh-m-sharpe/cordova-plugin-inappbrowser 
readme_update

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/152.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #152


commit ac3d6b77f27631f9bfd3815b1f3bd8dc0c05d176
Author: Josh Sharpe 
Date:   2016-02-26T02:54:22Z

Should the README designate where general discussions take place?




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-9254 copy over templates/PROJECT_NAME...

[stevengill]

Github user stevengill commented on the pull request:

https://github.com/apache/cordova-ios/pull/198#issuecomment-189082380
  
Okay, updated the PR. Take a look @shazron 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Docs Touch-Up

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/523#issuecomment-189076643
  
@nikhilkh @riknoll please review this when you have a moment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Docs Touch-Up

[dblotsky]

GitHub user dblotsky opened a pull request:

https://github.com/apache/cordova-docs/pull/523

Docs Touch-Up

- Refactoring front matter merging
- Moving some functionality into util.js
- Reverting some unintended gulpfile changes
- Removing Segoe UI from font-family
- Making doc ToC slightly less bold

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs dblotsky-refactor

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/523.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #523


commit e504efab6fc281a9d21b3f7e91b181b769617d87
Author: Dmitry Blotsky 
Date:   2016-02-25T03:27:33Z

Refactoring front matter merging, moving some functionality into util.js. 
Reverting some unintended gulpfile changes. Removing Segoe UI from font-family 
and making doc ToC slightly less bold.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [DISCUSS] Cordova-iOS release

[Nikhil Khandelwal]

Since this is a bug we encountered previously as well - should we block on it? 
Also, looks like it will not be a patch release and we may need an accompanying 
tools release. Is that correct?

-Nikhil

-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com] 
Sent: Wednesday, February 24, 2016 7:00 PM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Cordova-iOS release

Ran into a bug while testing upgrading from 3.9.2 to 4.1.0

https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-9254=01%7c01%7cnikhilkh%40microsoft.com%7caa36706be39e4022069108d33d8fd2f9%7c72f988bf86f141af91ab2d7cd011db47%7c1=zLWtMl89ZwXQIJcBpcZ2XnBlqMfO4OcwJKBN2xEvhDA%3d



On Wed, Feb 24, 2016 at 5:00 PM, Steven Gill  wrote:

> Changes:
>
> * CB-10693 added missing header license
> * CB-10693 Updated checked-in node_modules
> * CB-10530 - Updated cordova.js. This closes #193
> * CB-10530 - App freezes sometimes directly after starting on iOS
> * CB-10668 checked in node_modules
> * CB-10668 removed bin/node_modules
> * CB-10668 updated create.js to grab node_modules from root, updated
> package.json
> * CB-10138  Adds missing plugin metadata to plugin_list module
> * CB-10493: [iOS] Missing icon.png
> * CB-10184: Images.xcassets: A 83.5x83.5@2x app icon is required for iPad
> apps targeting iOS 9.0 and later
> * Disable ios-deploy wifi mode when deploying to a device
> * CB-10272 - Improve  and  error logs
> * Updated bundled iso-sim to 5.0.6
> * CB-10233: Support different config.xml file per CDVViewController
> instance
> * Add additional valid targets for simulation
> * Trigger mirror push of tag
> * Update JS snapshot to version 4.1.0-dev (via coho)
> * Updated CDV version macro to 4.0.1
> * CB-10185 - Update CordovaLib.xcodeproj to recommended settings in Xcode
> 7.2
> * CB-10171 - WebKit Error after migration to iOS@4.0.0
> * CB-10155 - DisallowOverscroll not working
> * CB-10168: CDVViewController appURL is nil if wwwFolderName is the path
> to a resource bundle
> * CB-10162 update reference url for icon images (closes #182)
> * CB-10162 correct the paths for iOS icon and splashscreen resources
> * This closes #172
> * Update JS snapshot to version 4.1.0-dev (via coho)
> * Set VERSION to 4.1.0-dev (via coho)
>
> I'm going to set the version to 4.1.0
>
> On Wed, Feb 24, 2016 at 4:03 PM, Steven Gill 
> wrote:
>
>> Merged it in after chatting with Shaz
>>
>> On Wed, Feb 24, 2016 at 12:55 PM, Darryl Pogue  wrote:
>>
>>> I think we're still waiting for
>>> https://github.com/apache/cordova-ios/pull/193 to land (but it's
>>> probably
>>> good to merge)
>>>
>>> On 24 February 2016 at 12:53, Steven Gill 
>>> wrote:
>>>
>>> > Any blockers? Going to aim to send this out this afternoon.
>>> >
>>> >
>>> > -Steve
>>> >
>>>
>>
>>
>

[GitHub] cordova-lib pull request: New plugin version selection implementat...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/363#discussion_r54193600
  
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +535,175 @@ function versionString(version) {
 
 return null;
 }
+
+/**
+ * Gets the version of a plugin that should be fetched for a given project 
based
+ * on the plugin's engine information from NPM and the platforms/plugins 
installed
+ * in the project. The cordovaDependencies object in the package.json's 
engines
+ * entry takes the form of an object that maps plugin versions to a series 
of
+ * constraints and semver ranges. For example:
+ *
+ * { plugin-version: { constraint: semver-range, ...}, ...}
+ *
+ * Constraint can be a plugin, platform, or cordova version. Plugin-version
+ * can be either a single version (e.g. 3.0.0) or an upper bound (e.g. 
<3.0.0)
+ *
+ * @param {string}  projectRoot The path to the root directory of the 
project
+ * @param {object}  pluginInfo  The NPM info of the plugin be fetched 
(e.g. the
+ *  result of calling `registry.info()`)
+ * @param {string}  cordovaVersion  The semver version of cordova-lib
+ *
+ * @return {Promise}A promise that will resolve to either 
a string
+ *  if there is a version of the plugin 
that this
+ *  project satisfies or null if there is 
not
+ */
+function getFetchVersion(projectRoot, pluginInfo, cordovaVersion) {
+// Figure out the project requirements
+if (pluginInfo.engines && pluginInfo.engines.cordovaDependencies) {
+var pluginList = getInstalledPlugins(projectRoot);
+var pluginMap = {};
+
+pluginList.forEach(function(plugin) {
+pluginMap[plugin.id] = plugin.version;
+});
+
+return cordova_util.getInstalledPlatformsWithVersions(projectRoot)
+.then(function(platformVersions) {
+return determinePluginVersionToFetch(
+pluginInfo.versions,
+pluginInfo.engines.cordovaDependencies,
+pluginMap,
+platformVersions,
+cordovaVersion);
+});
+} else {
+// If we have no engine, we want to fall back to the default 
behavior
+events.emit('verbose', 'No plugin engine info found, falling back 
to latest or pinned version');
+return Q(null);
+}
+}
+
+function determinePluginVersionToFetch(allVersions, engine, pluginMap, 
platformMap, cordovaVersion) {
+var versions = [];
+var latest = allVersions[allVersions.length - 1];
+var upperBound = null;
+var upperBoundRange = null;
+
+for(var version in engine) {
+if(version.indexOf('<') === 0 && 
semver.valid(version.substring(1))) {
--- End diff --

It might be a good idea to be more robust with whitespaces here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Minor changes to TOC styling

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/522


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Renaming 6.0.0 to 6.x.

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/520


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Minor changes to TOC styling

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/522#issuecomment-189059339
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-10671 and CB-10699: Android Windows...

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-medic/pull/83#issuecomment-189059097
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Minor changes to TOC styling

[rakatyal]

GitHub user rakatyal opened a pull request:

https://github.com/apache/cordova-docs/pull/522

Minor changes to TOC styling

@dblotsky , @riknoll : Please review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs raghav-toc-style

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/522.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #522


commit 1c5164002c7901f1860f73574e7105743ab23fe4
Author: Raghav Katyal 
Date:   2016-02-26T00:55:28Z

Minor changes to TOC styling




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10622 fix target attribute being igno...

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-lib/pull/392#issuecomment-189058742
  
@vladimir-kotikov to review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media-capture pull request: [CB-10554] Fix null ref...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-media-capture/pull/51#issuecomment-189025565
  
Thanks for doing this! LGTM, I just need to test it. Can you add a note to 
the README about this quirk? Something like 
https://github.com/apache/cordova-plugin-camera#android-quirks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: fix formating issues from pull request 1...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/192


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media-capture pull request: [CB-10554] Fix null ref...

[nikhilkh]

Github user nikhilkh commented on the pull request:


https://github.com/apache/cordova-plugin-media-capture/pull/51#issuecomment-189000686
  
@riknoll to review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Rebased ochakov's branch to th...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/174#issuecomment-188971773
  
Rebased and updated in #179 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10120 android: Camera permi...

[riknoll]

GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/179

CB-10120 android: Camera permission must be requested when present in 
Manifest

Because three PRs are better than one.

This provides fixes for #142 and is based on top of the rebase in #174 

I will merge this in later today

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-camera 
CB-10120rebase

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/179.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #179


commit 345647586b6d2bf410b1ebf16f631e5a8cf9a591
Author: ochakov 
Date:   2015-12-01T21:10:43Z

CB-10120 android: Fix missing CAMERA permission for Android M

According to the PR conversation, when android.permission.CAMERA
is not set in the package, there is no need to ask for the
camera permission. Also, checking now camera and storage
permissions separately, so if only one of them is missing, the
other one will be requested and not both.

Rebased by MatthewBooth and riknoll

This closes #142, closes #174

commit fe02f182d7a157856ec71cca33923c84aba92406
Author: riknoll 
Date:   2016-02-24T22:51:52Z

CB-10120 android: Fixing use of constants and PermissionHelper




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-media-capture pull request: [CB-10554] Fix null ref...

[adamduren]

Github user adamduren commented on the pull request:


https://github.com/apache/cordova-plugin-media-capture/pull/51#issuecomment-188962549
  
@stevengill What additional steps do I need to take to get this resolved?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[Vote] 5.1.1 Android Release (attempt 2)

[Steven Gill]

Please review and vote on this 5.1.1 Android Release
by replying to this email (and keep discussion on the DISCUSS thread)

Release issue: https://issues.apache.org/jira/browse/CB-10687

The archive has been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10687

The package was published from its corresponding git tag:
cordova-android: 5.1.1 (4a085c14e6)

Note that you can test it out via:

cordova platform add https://github.com/apache/cordova-android#5.1.1

Upon a successful vote I will upload the archive to dist/, publish it
to npm, and post the blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and
subdependencies have Apache-compatible licenses
* Ran through all testing steps at
https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md#what-to-test

[GitHub] cordova-docs pull request: CB-10679: Adding docs for new plugin ve...

[riknoll]

GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-docs/pull/521

CB-10679: Adding docs for new plugin version fetching implementation

**DO NOT MERGE! This PR is documenting 
https://github.com/apache/cordova-lib/pull/363 which has yet to be merged**

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/riknoll/cordova-docs CB-10679

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/521.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #521


commit 437836050c2983cd2a4d578d6acdae6c6a85721a
Author: riknoll 
Date:   2016-02-24T21:25:40Z

CB-10679: Adding docs for new plugin version fetching implementation




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-10671 and CB-10699: Android Windows...

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-medic/pull/83#issuecomment-188944883
  
Also, the Android emulator medic-run code really needs to be refactored, 
but I didn't want to add that to this PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-10671 and CB-10699: Android Windows...

[riknoll]

GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-medic/pull/83

CB-10671 and CB-10699: Android Windows CI fixes for logging and run

This addresses two JIRAs: 
[CB-10671](https://issues.apache.org/jira/browse/CB-10671) and 
[CB-10699](https://issues.apache.org/jira/browse/CB-10699). I am submitting 
this as one PR rather than two because CB-10699 was somewhat blocked on 
CB-10671.

The CB-10671 fix adds the command `adb kill-server` to medic-kill for 
Android so as to clear out all of the mysterious "host" emulators that have 
been cropping up and causing medic-log to fail. Not sure what is causing those 
entries to appear (and only on Windows), but this seems to get rid of them

The CB-10699 fix tries to uninstall mobilespec before using `cordova run` 
because the command that `cordova run` uses to install the app sometimes fails 
if the app will not uninstall. That causes the run step to fail (and every run 
step thereafter until someone uninstalls the app).

@sarangan12 @dblotsky please review.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-medic CB-10699

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-medic/pull/83.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #83


commit e583d860204fe02f633fcbfde6e5be2f29cc2e55
Author: riknoll 
Date:   2016-02-25T19:17:52Z

CB-10671: Killing adb server as part of Android medic-kill step

commit cea6c852e39766aa54032e75879b50912f1541ba
Author: riknoll 
Date:   2016-02-25T19:18:43Z

CB-10699: Attempt to uninstall mobilespec on Android emulator before run




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-9254 copy over templates/PROJECT_NAME...

[stevengill]

Github user stevengill commented on the pull request:

https://github.com/apache/cordova-ios/pull/198#issuecomment-188936225
  
Chatted with Shaz. Going to update this PR to do most of the steps create 
does during update. Safest way


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Renaming 6.0.0 to 6.x.

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-docs/pull/520#issuecomment-188892886
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Fix missing CAMERA permission ...

[dieppe]

Github user dieppe commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/142#issuecomment-188872652
  
You can also check this fork https://github.com/jnuine/cordova-plugin-camera

It includes a major refactor of the iOS plugin which fixes some bugs, 
checks for option consistency and allows access to the picture metadata in all 
cases that make sense (available as a 
[PR](https://github.com/apache/cordova-plugin-camera/pull/101) since June last 
year, but I guess merging PR is not cordova's team strong suit).

On Android, it includes these commits and also handles better the kitkat+ 
gallery (sadly not the images from Google Drive).

We use it in an app used daily both on Android and iOS.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-console pull request: CB-10636 Add JSHint for plugi...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-plugin-console/pull/16

CB-10636 Add JSHint for plugins

[Jira issue](https://issues.apache.org/jira/browse/CB-10636)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/daserge/cordova-plugin-console CB-10636

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-console/pull/16.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #16


commit 35c28ccc9956bc036e47f38bc0fa15eebb807e00
Author: daserge 
Date:   2016-02-25T15:43:42Z

CB-10636 Add JSHint for plugins




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: fix formating issues from pull request 1...

[stevengill]

Github user stevengill commented on a diff in the pull request:

https://github.com/apache/cordova-ios/pull/192#discussion_r54118663
  
--- Diff: 
bin/templates/project/__PROJECT_NAME__/Images.xcassets/AppIcon.appiconset/Contents.json
 ---
@@ -121,6 +121,12 @@
   "scale" : "2x"
 },
 {
+  "idiom" : "ipad",
+  "size" : "83.5x83.5",
--- End diff --

I think this might be a mistake. Formatting is messed up on line 117. Lines 
123-128 look like a copy of lines 117-122


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [Vote] 5.1.1 Android Release

[Steven Gill]

This vote has failed. I'll send a new one today.
On Feb 24, 2016 12:52 PM, "Steven Gill"  wrote:

> Please review and vote on this 5.1.1 Android Release
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-10687
>
> The archive has been published to 
> dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10687
>
> The package was published from its corresponding git tag:
> cordova-android: 5.1.1 (f852857093)
>
> Note that you can test it out via:
>
> cordova platform add https://github.com/apache/cordova-android#5.1.1
>
> Upon a successful vote I will upload the archive to dist/, publish it to npm, 
> and post the blog post.
>
> Voting guidelines: 
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and subdependencies have 
> Apache-compatible licenses
> * Ran through all testing steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md#what-to-test
>
>

RE: [DISCUSS] Cordova-Android 5.2.0 Release

[Steven Gill]

Ahh your right. Looks like since 5.1.x existed I needed to manually
cherry-pick changes into it instead of relying on coho prepare-release
command.  I'll send a new vote today.
On Feb 25, 2016 6:19 AM, "Alexander Sorokin (Akvelon)" <
v-als...@microsoft.com> wrote:

> I think there's something wrong with the package: it doesn't contain any
> of the changes described in the release notes, only increased version.
>
> -Original Message-
> From: Steven Gill [mailto:stevengil...@gmail.com]
> Sent: Thursday, February 25, 2016 5:59 AM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release
>
> I added them today :D
>
> On Wed, Feb 24, 2016 at 6:39 PM, Nikhil Khandelwal  >
> wrote:
>
> > These commands look great - it will be good to add them to release
> > process docs if they are not already there.
> >
> > -Nikhil
> >
> > -Original Message-
> > From: Steven Gill [mailto:stevengil...@gmail.com]
> > Sent: Wednesday, February 24, 2016 10:03 AM
> > To: dev@cordova.apache.org
> > Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release
> >
> > Definitely. Already committed the update.
> >
> > My new strategy with bundled/checked in dependencies
> >
> > * update package.json dep version if required
> > * rm -rf node_modules
> > * npm install --production (skips dev dependencies)
> > * git add node_modules/* (checkin all modules needed for platform add
> > git
> > url)
> > * git commit
> > * npm install (Readd dev dependencies for ability to run tests
> > locally)
> >
> >
> >
> > On Wed, Feb 24, 2016 at 9:52 AM, Vladimir Kotikov (Akvelon) <
> > v-vlk...@microsoft.com> wrote:
> >
> > > Steve, do you plan to update bundled `cordova-common` as a part of
> > > this release?
> > >
> > > -
> > > Best regards, Vladimir
> > >
> > > -Original Message-
> > > From: Steven Gill [mailto:stevengil...@gmail.com]
> > > Sent: Wednesday, February 24, 2016 8:12 PM
> > > To: dev@cordova.apache.org
> > > Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release
> > >
> > > Issue:
> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fiss
> > > ue
> > > s.apache.org%2fjira%2fbrowse%2fCB-10687=01%7c01%7cv-vlkoti%4006
> > > 4d
> > > .mgd.microsoft.com%7ccae1efca7e784a54d81808d33d3da913%7c72f988bf86f1
> > > 41
> > > af91ab2d7cd011db47%7c1=vfYpULSQtiavVeNfQeua394TiKTci0OfKXWRYxX
> > > dH
> > > fE%3d
> > >
> > > I'm going to make this version 5.1.1. I'll update here if I decide
> > > to go with 5.2.0 instead.
> > >
> > > On Wed, Feb 17, 2016 at 10:49 AM, Joe Bowser 
> wrote:
> > >
> > > > OK, are we sure we didn't add any new minor features?
> > > >
> > > > On Wed, Feb 17, 2016 at 10:47 AM, Steven Gill
> > > > 
> > > > wrote:
> > > >
> > > > > Well we should be following semver.
> > > > >
> > > > >
> > > > >- Bug fixes and other minor changes: Patch release, increment
> > > > > the
> > > last
> > > > >number, e.g. 1.0.1
> > > > >- New features which don't break existing features: Minor
> release,
> > > > >increment the middle number, e.g. 1.1.0
> > > > >- Changes which break backwards compatibility: Major release,
> > > > increment
> > > > >the first number, e.g. 2.0.0
> > > > >
> > > > >
> > > > > On Wed, Feb 17, 2016 at 9:09 AM, Carlos Santana
> > > > > 
> > > > > wrote:
> > > > >
> > > > > > +1 to wait for cordova-common, then to platforms
> > > > > >
> > > > > >
> > > > > >
> > > > > > On Tue, Feb 16, 2016 at 7:48 PM Steven Gill
> > > > > > 
> > > > > > wrote:
> > > > > >
> > > > > > > Any issues with me starting this release?
> > > > > > >
> > > > > > > I think I will wait for the cordova-common release to finish
> > > > > > > so I can bundle it in.
> > > > > > >
> > > > > > > Changes:
> > > > > > > * CB-10510: Add an optional timeout to emu start script
> > > > > > > * CB-10498: Resume event should be sticky if it has a plugin
> > > > > > > result
> > > > > > > * fix HtmlNotFoundTest so that it passes when file not found
> > > > > > > is
> > > > handled
> > > > > > > correctly This Closes #256
> > > > > > > * CB-10472 NullPointerException:
> > > > > > > org.apache.cordova.PluginManager.onSaveInstanceState check
> > > > > > > if
> > > > > > pluginManager
> > > > > > > is null before using it This closes #255
> > > > > > > * CB-10138 Adds missing plugin metadata to plugin_list module.
> > > > > > > This
> > > > > > closes
> > > > > > > #254
> > > > > > > * CB-10443 Pass original options instead of remaining
> > > > > > > * CB-10443 Fix `this.root` null reference
> > > > > > > * CB-10421 Fixes exception when calling run script with
> > > > > > > --help option
> > > > > > > * updated .gitignore
> > > > > > > * CB-10406 Fixes an exception, thrown when building using Ant.
> > > > > > > This
> > > > > > closes
> > > > > > > #250
> > > > > > > * CB-10157 Uninstall app from device/emulator only when
> > > > > > > signed apk is already installed
> > > > > 

[GitHub] cordova-lib pull request: CB-10583 Protect plugin preferences from...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/400


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [DISCUSS] Cordova-Android 5.2.0 Release

[Alexander Sorokin (Akvelon)]

I think there's something wrong with the package: it doesn't contain any of the 
changes described in the release notes, only increased version.

-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com] 
Sent: Thursday, February 25, 2016 5:59 AM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release

I added them today :D

On Wed, Feb 24, 2016 at 6:39 PM, Nikhil Khandelwal 
wrote:

> These commands look great - it will be good to add them to release 
> process docs if they are not already there.
>
> -Nikhil
>
> -Original Message-
> From: Steven Gill [mailto:stevengil...@gmail.com]
> Sent: Wednesday, February 24, 2016 10:03 AM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release
>
> Definitely. Already committed the update.
>
> My new strategy with bundled/checked in dependencies
>
> * update package.json dep version if required
> * rm -rf node_modules
> * npm install --production (skips dev dependencies)
> * git add node_modules/* (checkin all modules needed for platform add 
> git
> url)
> * git commit
> * npm install (Readd dev dependencies for ability to run tests 
> locally)
>
>
>
> On Wed, Feb 24, 2016 at 9:52 AM, Vladimir Kotikov (Akvelon) < 
> v-vlk...@microsoft.com> wrote:
>
> > Steve, do you plan to update bundled `cordova-common` as a part of 
> > this release?
> >
> > -
> > Best regards, Vladimir
> >
> > -Original Message-
> > From: Steven Gill [mailto:stevengil...@gmail.com]
> > Sent: Wednesday, February 24, 2016 8:12 PM
> > To: dev@cordova.apache.org
> > Subject: Re: [DISCUSS] Cordova-Android 5.2.0 Release
> >
> > Issue:
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fiss
> > ue 
> > s.apache.org%2fjira%2fbrowse%2fCB-10687=01%7c01%7cv-vlkoti%4006
> > 4d
> > .mgd.microsoft.com%7ccae1efca7e784a54d81808d33d3da913%7c72f988bf86f1
> > 41 
> > af91ab2d7cd011db47%7c1=vfYpULSQtiavVeNfQeua394TiKTci0OfKXWRYxX
> > dH
> > fE%3d
> >
> > I'm going to make this version 5.1.1. I'll update here if I decide 
> > to go with 5.2.0 instead.
> >
> > On Wed, Feb 17, 2016 at 10:49 AM, Joe Bowser  wrote:
> >
> > > OK, are we sure we didn't add any new minor features?
> > >
> > > On Wed, Feb 17, 2016 at 10:47 AM, Steven Gill 
> > > 
> > > wrote:
> > >
> > > > Well we should be following semver.
> > > >
> > > >
> > > >- Bug fixes and other minor changes: Patch release, increment 
> > > > the
> > last
> > > >number, e.g. 1.0.1
> > > >- New features which don't break existing features: Minor release,
> > > >increment the middle number, e.g. 1.1.0
> > > >- Changes which break backwards compatibility: Major release,
> > > increment
> > > >the first number, e.g. 2.0.0
> > > >
> > > >
> > > > On Wed, Feb 17, 2016 at 9:09 AM, Carlos Santana 
> > > > 
> > > > wrote:
> > > >
> > > > > +1 to wait for cordova-common, then to platforms
> > > > >
> > > > >
> > > > >
> > > > > On Tue, Feb 16, 2016 at 7:48 PM Steven Gill 
> > > > > 
> > > > > wrote:
> > > > >
> > > > > > Any issues with me starting this release?
> > > > > >
> > > > > > I think I will wait for the cordova-common release to finish 
> > > > > > so I can bundle it in.
> > > > > >
> > > > > > Changes:
> > > > > > * CB-10510: Add an optional timeout to emu start script
> > > > > > * CB-10498: Resume event should be sticky if it has a plugin 
> > > > > > result
> > > > > > * fix HtmlNotFoundTest so that it passes when file not found 
> > > > > > is
> > > handled
> > > > > > correctly This Closes #256
> > > > > > * CB-10472 NullPointerException:
> > > > > > org.apache.cordova.PluginManager.onSaveInstanceState check 
> > > > > > if
> > > > > pluginManager
> > > > > > is null before using it This closes #255
> > > > > > * CB-10138 Adds missing plugin metadata to plugin_list module.
> > > > > > This
> > > > > closes
> > > > > > #254
> > > > > > * CB-10443 Pass original options instead of remaining
> > > > > > * CB-10443 Fix `this.root` null reference
> > > > > > * CB-10421 Fixes exception when calling run script with 
> > > > > > --help option
> > > > > > * updated .gitignore
> > > > > > * CB-10406 Fixes an exception, thrown when building using Ant.
> > > > > > This
> > > > > closes
> > > > > > #250
> > > > > > * CB-10157 Uninstall app from device/emulator only when 
> > > > > > signed apk is already installed
> > > > > >
> > > > >
> > > >
> > >
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>

[GitHub] cordova-lib pull request: CB-10583 Protect plugin preferences from...

[sgrebnov]

Github user sgrebnov commented on the pull request:

https://github.com/apache/cordova-lib/pull/400#issuecomment-188757069
  
:+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-battery-status pull request: CB-10636 Add JSHint fo...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-plugin-battery-status/pull/32

CB-10636 Add JSHint for plugins

[Jira issue](https://issues.apache.org/jira/browse/CB-10636)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/daserge/cordova-plugin-battery-status CB-10636

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-battery-status/pull/32.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #32


commit f7c136301527745c82bbb6d6fae9739c4e7f4847
Author: daserge 
Date:   2016-02-25T11:57:23Z

CB-10636 Add JSHint for plugins




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10662 Use project's config.xml as a f...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/398


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer pull request: CB-10636 Add JSHint for...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-plugin-file-transfer/pull/127

CB-10636 Add JSHint for plugins

[Jira issue](https://issues.apache.org/jira/browse/CB-10636)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/daserge/cordova-plugin-file-transfer CB-10636

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file-transfer/pull/127.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #127


commit bc1bddd23143732c76df47049d7d4d949c4ecb4a
Author: daserge 
Date:   2016-02-25T11:30:21Z

CB-10636 Add JSHint for plugins




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10662 Use project's config.xml as a f...

[vladimir-kotikov]

Github user vladimir-kotikov commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/398#discussion_r54081599
  
--- Diff: cordova-lib/src/plugman/platforms/browser.js ---
@@ -31,25 +29,7 @@ module.exports = {
 return path.join(project_dir, 'www');
 },
 package_name:function(project_dir) {
-// preferred location if cordova >= 3.4
-var preferred_path = path.join(project_dir, 'config.xml');
-var config_path;
-
-if (!fs.existsSync(preferred_path)) {
-// older location
-var old_config_path = 
path.join(module.exports.www_dir(project_dir), 'config.xml');
-if (!fs.existsSync(old_config_path)) {
-// output newer location and fail reading
-config_path = preferred_path;
-events.emit('verbose', 'unable to find '+config_path);
-} else {
-config_path = old_config_path;
-}
-} else {
-config_path = preferred_path;
-}
-var widget_doc = xml_helpers.parseElementtreeSync(config_path);
-return widget_doc._root.attrib['id'];
+return common.package_name(project_dir);
--- End diff --

Agree about `firefoxos` and `webos` (I'd add here `tizen` as well)

As for `blackberry10` - it does not rely on configs other than the one at 
the platform `www` dir, so using common `package_name` might lead to unexpected 
results. Also seems that it doesn't affected by this bug as it always copying 
own `config.xml` at `create`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10662 Use project's config.xml as a f...

[TimBarham]

Github user TimBarham commented on the pull request:

https://github.com/apache/cordova-lib/pull/398#issuecomment-188730806
  
Thanks @vladimir-kotikov - looks good. Just a couple of suggestions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10662 Use project's config.xml as a f...

[TimBarham]

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/398#discussion_r54079687
  
--- Diff: cordova-lib/src/plugman/platforms/browser.js ---
@@ -31,25 +29,7 @@ module.exports = {
 return path.join(project_dir, 'www');
 },
 package_name:function(project_dir) {
-// preferred location if cordova >= 3.4
-var preferred_path = path.join(project_dir, 'config.xml');
-var config_path;
-
-if (!fs.existsSync(preferred_path)) {
-// older location
-var old_config_path = 
path.join(module.exports.www_dir(project_dir), 'config.xml');
-if (!fs.existsSync(old_config_path)) {
-// output newer location and fail reading
-config_path = preferred_path;
-events.emit('verbose', 'unable to find '+config_path);
-} else {
-config_path = old_config_path;
-}
-} else {
-config_path = preferred_path;
-}
-var widget_doc = xml_helpers.parseElementtreeSync(config_path);
-return widget_doc._root.attrib['id'];
+return common.package_name(project_dir);
--- End diff --

Perhaps should make the same change for `firefoxos` and `webos` (and maybe 
`blackberry10`) too?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10662 Use project's config.xml as a f...

[TimBarham]

Github user TimBarham commented on a diff in the pull request:

https://github.com/apache/cordova-lib/pull/398#discussion_r54079611
  
--- Diff: cordova-lib/src/plugman/platforms/common.js ---
@@ -22,7 +22,39 @@ var shell = require('shelljs'),
 fs= require('fs'),
 common;
 
+var cordovaUtil = require('../../cordova/util');
+var CordovaError = require('cordova-common').CordovaError;
+var xmlHelpers = require('cordova-common').xmlHelpers;
+
 module.exports = common = {
+package_name: function(project_dir) {
+
+var configPaths = [
+// preferred location if cordova >= 3.4
+path.join(project_dir, 'config.xml'),
+// older location
+path.join(project_dir, 'www/config.xml'),
+];
+
+var cordovaRoot = cordovaUtil.isCordova();
+if (cordovaRoot) {
+// CB-10662 If we're in cli project then add project's config 
as a fallback
+configPaths.push(path.join(cordovaRoot, 'config.xml'));
+}
+
+for (var i = 0; i < configPaths.length; i++) {
+var configPath = configPaths[i];
+// If no config there try next path
+if (!fs.existsSync(configPath)) continue;
+
+var widget_doc = xmlHelpers.parseElementtreeSync(configPath);
+return widget_doc._root.attrib.id;
+}
+
+// No configs found - fail with meaningful error message
+throw new CordovaError('Unable to find project\'s config in none 
of ' +
+'the following directories:\n\t' + configPaths.join('\n\t'));
--- End diff --

I would suggest "any" instead of "none".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-10638 Appium runner: Fixed build co...

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-medic/pull/82#issuecomment-188721218
  
@alsorokin I'll test this locally tomorrow (i.e. in about 10 hours) and 
I'll give any remaining feedback, if there is any. Thanks again for the 
improvements!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-medic pull request: CB-10652 Added the instruction on how ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-medic/pull/81


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10662 Apply project config to platfor...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-lib/pull/398#issuecomment-188710263
  
Thanks for advice, @TimBarham. Updated


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine pull request: CB-10636 Add JSHint ...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/6

CB-10636 Add JSHint for plugins

[Jira issue](https://issues.apache.org/jira/browse/CB-10636)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/daserge/cordova-plugin-wkwebview-engine 
CB-10636

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/6.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #6


commit 73118f95e7e1a3bd8fc9ce3475cffea7153593d9
Author: daserge 
Date:   2016-02-23T13:27:01Z

CB-10636 Add JSHint for plugins




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10583 Protect plugin preferences from...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-lib/pull/400#issuecomment-188674424
  
@sgrebnov, could you take a look please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10583 Protect plugin preferences from...

[vladimir-kotikov]

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-lib/pull/400

CB-10583 Protect plugin preferences from adding extra Array properties

JIRA [CB-10583](https://issues.apache.org/jira/browse/CB-10583)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-lib CB-10583

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/400.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #400


commit 882297b6d98f758b0be318580413304128f77dd1
Author: Vladimir Kotikov 
Date:   2016-02-25T08:45:22Z

CB-10583 Protect plugin preferences from adding extra Array properties




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org