Re: [DRAFT] [REPORT] Cordova - March 2016

[julio cesar sanchez]

LGTM

2016-03-11 3:28 GMT+01:00 Carlos Santana :

> LGTM
>
> - Carlos
> @csantanapr
>
> > On Mar 10, 2016, at 8:28 PM, Shazron  wrote:
> >
> > Please read and review. I'm sending this out later tonight.
> >
> >
> https://github.com/cordova/apache-board-reports/blob/master/2016/2016-03.md
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[GitHub] cordova-ios pull request: CB-10769 Move plugin handlers tests into...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/200


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10838 Use logger from cordova-com...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/158


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10769 Move plugin handlers tests into...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-ios/pull/200#issuecomment-195226834
  
@dblotsky, updated/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Adding DATA_URL warnings to RE...

[nikhilkh]

Github user nikhilkh commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/193#issuecomment-195220562
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: [CB-10600] 'cordova run --release' u...

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-android/pull/273#issuecomment-195215718
  
@daserge Can you please review?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Fix syntax highlighting within the Andr...

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-docs/pull/549#issuecomment-195213880
  
Merged with 49710a0026137da0da6a7bcab91304bebe7528f2


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Fix syntax highlighting within the Andr...

[nikhilkh]

Github user nikhilkh closed the pull request at:

https://github.com/apache/cordova-docs/pull/549


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-paramedic pull request: Real time logging and other improv...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-paramedic/pull/1#discussion_r55791682
  
--- Diff: sample-config/.paramedic-core-plugins.config.js ---
@@ -0,0 +1,51 @@
+module.exports = {
+//"externalServerUrl": "http://10.0.8.254; ,
+"useTunnel": true,
+"plugins": [
+"https://github.com/apache/cordova-plugin-battery-status;,
+"https://github.com/apache/cordova-plugin-camera;,
+"https://github.com/apache/cordova-plugin-console;,
+"https://github.com/apache/cordova-plugin-contacts;,
+"https://github.com/apache/cordova-plugin-device;,
+"https://github.com/apache/cordova-plugin-device-motion;,
+"https://github.com/apache/cordova-plugin-device-orientation;,
+"https://github.com/apache/cordova-plugin-dialogs;,
+"https://github.com/apache/cordova-plugin-file;,
+"https://github.com/apache/cordova-plugin-file-transfer;,
+"https://github.com/apache/cordova-plugin-geolocation;,
+"https://github.com/apache/cordova-plugin-globalization;,
+"https://github.com/apache/cordova-plugin-inappbrowser;,
+"https://github.com/apache/cordova-plugin-media;,
+"https://github.com/apache/cordova-plugin-media-capture;,
+"https://github.com/apache/cordova-plugin-network-information;,
+"https://github.com/apache/cordova-plugin-splashscreen;,
+"https://github.com/apache/cordova-plugin-statusbar;,
+"https://github.com/apache/cordova-plugin-vibration;
+],
+"targets": [
+{
+"platform": "ios@https://github.com/apache/cordova-ios.git;,
+"action": "run",
+ "args": "--device"
+},
+{
+"platform": 
"android@https://github.com/apache/cordova-android.git;,
+"action": "run",
+ "args": "--device"
+},
+{// Windows 8.1 Desktop(anycpu)
+"platform": 
"windows@https://github.com/apache/cordova-windows.git;,
+"action": "run"
+},
+{   // Windows 10 Desktop(x64)
+"platform": 
"windows@https://github.com/apache/cordova-windows.git;,
+"action": "run",
+"args": "--archs=x64 -- --appx=uap"
--- End diff --

@sarangan12 Looks like paramedic already supports passing arbitrary args to 
`cordova run`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10829 Fixing reference links.

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/554#issuecomment-195164298
  
@riknoll please review when you have a moment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10829 Fixing reference links.

[dblotsky]

GitHub user dblotsky opened a pull request:

https://github.com/apache/cordova-docs/pull/554

CB-10829 Fixing reference links.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs CB-10829

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/554.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #554


commit c2a221c05a3dd60e6a4f78315b8e6e68cff64275
Author: Dmitry Blotsky 
Date:   2016-03-11T03:37:19Z

CB-10829 Fixing reference links.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Simplifying cordova-cli README

[Tommy Williams]

Might want to add the --template stuff?




> On 11 Mar 2016, at 1:31 PM, Carlos Santana  wrote:
> 
> Thanks Nikhil this looks very clean now
> 
> +1
> 
> - Carlos
> @csantanapr
> 
>> On Mar 10, 2016, at 8:22 PM, Nikhil Khandelwal  
>> wrote:
>> 
>> Our cordova-cli readme has become super long & not been maintained over the 
>> years. It repeats a lot of content from the docs. I have simplified it 
>> significantly by linking to relevant getting started, filing issues, 
>> contribution etc. sections that are part of our website. This should help 
>> maintenance as we do not repeat ourselves. However, there is a loss of some 
>> inline content.
>> 
>> Please review and comment on this PR: 
>> https://github.com/apache/cordova-cli/pull/240/files
>> 
>> -Nikhil
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
> 



signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: Simplifying cordova-cli README

[Carlos Santana]

Thanks Nikhil this looks very clean now

+1

- Carlos
@csantanapr

> On Mar 10, 2016, at 8:22 PM, Nikhil Khandelwal  wrote:
> 
> Our cordova-cli readme has become super long & not been maintained over the 
> years. It repeats a lot of content from the docs. I have simplified it 
> significantly by linking to relevant getting started, filing issues, 
> contribution etc. sections that are part of our website. This should help 
> maintenance as we do not repeat ourselves. However, there is a loss of some 
> inline content.
> 
> Please review and comment on this PR: 
> https://github.com/apache/cordova-cli/pull/240/files
> 
> -Nikhil

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Removing plugin pinning

[Carlos Santana]

+1

- Carlos
@csantanapr

> On Mar 10, 2016, at 8:36 PM, Shazron  wrote:
> 
> +1
> 
>> On Thu, Mar 10, 2016 at 1:16 PM, Richard Knoll  wrote:
>> Hey everyone,
>> 
>> With the new plugin version selection code merged into cordova-lib, are 
>> there any objections to removing plugin pinning? I plan to open PRs soon on 
>> the core plugins to move engine info into each plugin's package.json.
>> 
>> Thanks,
>> Richard
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
> 

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DRAFT] [REPORT] Cordova - March 2016

[Carlos Santana]

LGTM

- Carlos
@csantanapr

> On Mar 10, 2016, at 8:28 PM, Shazron  wrote:
> 
> Please read and review. I'm sending this out later tonight.
> 
> https://github.com/cordova/apache-board-reports/blob/master/2016/2016-03.md
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
> 

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-paramedic pull request: Real time logging and other improv...

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-paramedic/pull/1#discussion_r55781222
  
--- Diff: lib/Tunnel.js ---
@@ -0,0 +1,19 @@
+ var exec = require('./utils').exec;
+ var path = require('path');
+ var Q = require('Q');
+
+function Tunnel(port) {
+this.port = port;
+}
+
+Tunnel.prototype.createTunnel = function() {
+var self = this;
+//TODO: use localtunnel module instead of shell
+return Q.Promise(function(resolve, reject) {
+exec(path.resolve(__dirname, '../node_modules/.bin/lt') + ' --port 
' + self.port, null, function(output) {
+resolve(output.split(' ')[3]);
+});
+});
+};
+
+module.exports = Tunnel;
--- End diff --

Newline at the end of the file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

[dblotsky]

Github user dblotsky commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55781014
  
--- Diff: appium-tests/helpers/wdHelper.js ---
@@ -0,0 +1,68 @@
+/* jshint node: true */
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+*/
+
+'use strict';
+
+var wd = global.WD || require('wd');
+var driver;
+
+module.exports.getDriver = function (platform, callback) {
+var serverConfig = {
+host: 'localhost',
+port: 4723
--- End diff --

Please factor these out into constants.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

[dblotsky]

Github user dblotsky commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780934
  
--- Diff: appium-tests/helpers/contactsHelper.js ---
@@ -0,0 +1,222 @@
+/* jshint node: true */
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+*/
+
+'use strict';
+
+function prepare(item) {
+if (typeof item === 'object') {
+return JSON.stringify(item);
+}
+if (typeof item === 'string') {
+return '"' + item + '"';
+}
+return undefined;
+}
+
+module.exports.getContactName = function (firstName, lastName) {
+return {
+formatted: firstName == lastName === undefined ? null : firstName 
+ ' ' + lastName,
+familyName: lastName,
+givenName: firstName,
+middleName: ''
+};
+};
+
+module.exports.getAddContactCode = function (displayName, contactName, 
phoneNumber) {
+var preparedDisplayName = prepare(displayName);
+console.log('preparedDisplayName is ' + preparedDisplayName);
+var preparedContactName = prepare(contactName);
+var preparedPhoneNumber = prepare(phoneNumber);
+
+var result =
+'try {\n' +
+'var results = document.getElementById("info");\n' +
+'var contact = navigator.contacts.create({ "displayName": ' + 
preparedDisplayName + ', "name": ' + preparedContactName + ', "note": 
"DeleteMe" });\n' +
+
+'var phoneNumbers = [1];\n' +
+'phoneNumbers[0] = new ContactField("work", ' + 
preparedPhoneNumber + ', true);\n' +
+'contact.phoneNumbers = phoneNumbers;\n' +
+
+'contact.save(function() {\n' +
+'results.innerHTML = "' + (displayName || 'Nameless 
contact') + ' saved.";\n' +
+'}, function(e) {\n' +
+'if (e.code === ContactError.NOT_SUPPORTED_ERROR) {\n' +
+'results.innerHTML = "Saving contacts not 
supported.";\n' +
+'} else {\n' +
+'results.innerHTML = "Contact save failed: error " + 
e.code;\n' +
+'}\n' +
+'});\n' +
+'} catch (e) {\n' +
+'var results = document.getElementById("info");\n' +
+'results.innerHTML = "ERROR: " + e.code;\n' +
+'}\n';
+
+return result;
+};
+
+module.exports.getGetContactsCode = function (filter) {
+var preparedFilter = prepare(filter);
+
+var result =
+'var results = document.getElementById("info");\n' +
+'var obj = new ContactFindOptions();\n' +
+'if (' + preparedFilter + ') {\n' +
+'obj.filter = ' + preparedFilter + ';\n' +
+'}\n' +
+'obj.multiple = true;\n' +
+'navigator.contacts.find(["displayName", "name", "phoneNumbers", 
"emails", "urls", "note"], function(contacts) {\n' +
+'var s = "";\n' +
+'if (contacts.length === 0) {\n' +
+'s = "No contacts found";\n' +
+'} else {\n' +
+'s = "Number of contacts: " + contacts.length + 
"NamePhoneEmail";\n' +
+'for (var i = 0; i < contacts.length; i++) {\n' +
+'var contact = contacts[i];\n' +
+'var contactNameTag = contact.name ? "" + 
contact.name.formatted + "" : "(No Name)";\n' +
+'s = s + contactNameTag;\n' +
+'if (contact.phoneNumbers && 
contact.phoneNumbers.length > 0) {\n' +
+'s = s + contact.phoneNumbers[0].value;\n' +
+'}\n' +
+'s = s + "";\n' +
+'if (contact.emails && contact.emails.length > 0) {\n' 
+
+'s = s + contact.emails[0].value;\n' +
+'}\n' +
+'s = s + "";\n' +
+'

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

[dblotsky]

Github user dblotsky commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780861
  
--- Diff: appium-tests/helpers/contactsHelper.js ---
@@ -0,0 +1,222 @@
+/* jshint node: true */
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+*/
+
+'use strict';
+
+function prepare(item) {
--- End diff --

Please give this function a more descriptive name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

[dblotsky]

Github user dblotsky commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780842
  
--- Diff: appium-tests/android/android.spec.js ---
@@ -0,0 +1,338 @@
+/*jshint node: true, jasmine: true */
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+*/
+
+// these tests are meant to be executed by Cordova Medic Appium runner
+// you can find it here: https://github.com/apache/cordova-medic/
+// it is not necessary to do a full CI setup to run these tests
+// just run "node cordova-medic/medic/medic.js appium --platform android 
--plugins cordova-plugin-contacts"
+
+'use strict';
+
+var wdHelper = require('../helpers/wdHelper');
+var screenshotHelper = require('../helpers/screenshotHelper');
+var contactsHelper = require('../helpers/contactsHelper');
+
+var STARTING_MESSAGE = 'Ready for action!';
+var MINUTE = 60 * 1000;
+var DEFAULT_WEBVIEW_CONTEXT = 'WEBVIEW';
+
+describe('Contacts Android', function () {
+var driver;
+// the name of webview context, it will be changed to match needed 
context if there are named ones:
+var webviewContext = DEFAULT_WEBVIEW_CONTEXT;
+// this indicates that there was a critical error and we should try to 
recover:
+var errorFlag = false;
+// this indicates that we couldn't restore Appium session and should 
fail fast:
+var stopFlag = false;
+
+function win() {
+expect(true).toBe(true);
+}
+
+function fail(error) {
+if (error === 'rethrow') {
+throw error;
+}
+if (error && error.message) {
+console.log('An error occured: ' + error.message);
+if (error.stack) {
+console.log(error.stack);
+}
+expect(true).toFailWithMessage(error.message);
+} else if (error && typeof error === 'string') {
+console.log('Failed expectation: ' + error);
+expect(true).toFailWithMessage(error);
+} else {
+// no message provided :(
+expect(true).toBe(false);
+}
+return screenshotHelper
+.saveScreenshot(driver)
+.finally(function() {
+throw 'rethrow';
+});
+}
+
+function enterTest() {
+return driver
+// trying to determine where we are
+.context(webviewContext)
+.fail(function (error) {
+return fail(error);
+})
+.elementById('info')
+.then(function () {
+return driver; //we're already on the test screen
+}, function () {
+return driver
+.elementById('middle')
+.then(function () {
+return driver
+// we're on autotests page, we should go to 
start page
+.execute('window.location = "../index.html"')
+.sleep(5000)
+.fail(function () {
+errorFlag = true;
+throw 'Couldn\'t find start page.';
+});
+}, function () {
+return; // no-op
+})
+// unknown starting page: no 'info' div
+// adding it manually
+.execute('var info = document.createElement("div"); ' +
+ 'info.id = "info"; ' +
+ 'document.body.appendChild(info);');
+})
+.sleep(5000);
+}
+
+function getDriver() {
+driver = wdHelper.getDriver('Android');
+return driver;
+}

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

[dblotsky]

Github user dblotsky commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780731
  
--- Diff: appium-tests/android/android.spec.js ---
@@ -0,0 +1,338 @@
+/*jshint node: true, jasmine: true */
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+*/
+
+// these tests are meant to be executed by Cordova Medic Appium runner
+// you can find it here: https://github.com/apache/cordova-medic/
+// it is not necessary to do a full CI setup to run these tests
+// just run "node cordova-medic/medic/medic.js appium --platform android 
--plugins cordova-plugin-contacts"
+
+'use strict';
+
+var wdHelper = require('../helpers/wdHelper');
+var screenshotHelper = require('../helpers/screenshotHelper');
+var contactsHelper = require('../helpers/contactsHelper');
+
+var STARTING_MESSAGE = 'Ready for action!';
+var MINUTE = 60 * 1000;
+var DEFAULT_WEBVIEW_CONTEXT = 'WEBVIEW';
+
+describe('Contacts Android', function () {
+var driver;
+// the name of webview context, it will be changed to match needed 
context if there are named ones:
+var webviewContext = DEFAULT_WEBVIEW_CONTEXT;
+// this indicates that there was a critical error and we should try to 
recover:
+var errorFlag = false;
+// this indicates that we couldn't restore Appium session and should 
fail fast:
+var stopFlag = false;
+
+function win() {
+expect(true).toBe(true);
+}
+
+function fail(error) {
+if (error === 'rethrow') {
+throw error;
+}
+if (error && error.message) {
+console.log('An error occured: ' + error.message);
+if (error.stack) {
+console.log(error.stack);
+}
+expect(true).toFailWithMessage(error.message);
+} else if (error && typeof error === 'string') {
+console.log('Failed expectation: ' + error);
+expect(true).toFailWithMessage(error);
+} else {
+// no message provided :(
+expect(true).toBe(false);
+}
+return screenshotHelper
+.saveScreenshot(driver)
+.finally(function() {
+throw 'rethrow';
+});
+}
+
+function enterTest() {
+return driver
+// trying to determine where we are
+.context(webviewContext)
+.fail(function (error) {
+return fail(error);
+})
+.elementById('info')
+.then(function () {
+return driver; //we're already on the test screen
+}, function () {
+return driver
+.elementById('middle')
+.then(function () {
+return driver
+// we're on autotests page, we should go to 
start page
+.execute('window.location = "../index.html"')
+.sleep(5000)
+.fail(function () {
+errorFlag = true;
+throw 'Couldn\'t find start page.';
+});
+}, function () {
+return; // no-op
+})
+// unknown starting page: no 'info' div
+// adding it manually
+.execute('var info = document.createElement("div"); ' +
+ 'info.id = "info"; ' +
+ 'document.body.appendChild(info);');
+})
+.sleep(5000);
+}
+
+function getDriver() {
+driver = wdHelper.getDriver('Android');
+return driver;
+}

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

[dblotsky]

Github user dblotsky commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780654
  
--- Diff: appium-tests/android/android.spec.js ---
@@ -0,0 +1,338 @@
+/*jshint node: true, jasmine: true */
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+*/
+
+// these tests are meant to be executed by Cordova Medic Appium runner
+// you can find it here: https://github.com/apache/cordova-medic/
+// it is not necessary to do a full CI setup to run these tests
+// just run "node cordova-medic/medic/medic.js appium --platform android 
--plugins cordova-plugin-contacts"
+
+'use strict';
+
+var wdHelper = require('../helpers/wdHelper');
+var screenshotHelper = require('../helpers/screenshotHelper');
+var contactsHelper = require('../helpers/contactsHelper');
+
+var STARTING_MESSAGE = 'Ready for action!';
+var MINUTE = 60 * 1000;
+var DEFAULT_WEBVIEW_CONTEXT = 'WEBVIEW';
+
+describe('Contacts Android', function () {
+var driver;
+// the name of webview context, it will be changed to match needed 
context if there are named ones:
+var webviewContext = DEFAULT_WEBVIEW_CONTEXT;
+// this indicates that there was a critical error and we should try to 
recover:
+var errorFlag = false;
+// this indicates that we couldn't restore Appium session and should 
fail fast:
+var stopFlag = false;
+
+function win() {
+expect(true).toBe(true);
+}
+
+function fail(error) {
+if (error === 'rethrow') {
+throw error;
+}
+if (error && error.message) {
+console.log('An error occured: ' + error.message);
+if (error.stack) {
+console.log(error.stack);
+}
+expect(true).toFailWithMessage(error.message);
+} else if (error && typeof error === 'string') {
+console.log('Failed expectation: ' + error);
+expect(true).toFailWithMessage(error);
+} else {
+// no message provided :(
+expect(true).toBe(false);
+}
+return screenshotHelper
+.saveScreenshot(driver)
+.finally(function() {
+throw 'rethrow';
+});
+}
+
+function enterTest() {
+return driver
+// trying to determine where we are
+.context(webviewContext)
+.fail(function (error) {
+return fail(error);
+})
+.elementById('info')
+.then(function () {
+return driver; //we're already on the test screen
+}, function () {
+return driver
+.elementById('middle')
+.then(function () {
+return driver
+// we're on autotests page, we should go to 
start page
+.execute('window.location = "../index.html"')
+.sleep(5000)
+.fail(function () {
+errorFlag = true;
+throw 'Couldn\'t find start page.';
+});
+}, function () {
+return; // no-op
+})
+// unknown starting page: no 'info' div
+// adding it manually
+.execute('var info = document.createElement("div"); ' +
+ 'info.id = "info"; ' +
+ 'document.body.appendChild(info);');
+})
+.sleep(5000);
+}
+
+function getDriver() {
+driver = wdHelper.getDriver('Android');
+return driver;
+}

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

[dblotsky]

Github user dblotsky commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780482
  
--- Diff: appium-tests/android/android.spec.js ---
@@ -0,0 +1,338 @@
+/*jshint node: true, jasmine: true */
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+*/
+
+// these tests are meant to be executed by Cordova Medic Appium runner
+// you can find it here: https://github.com/apache/cordova-medic/
+// it is not necessary to do a full CI setup to run these tests
+// just run "node cordova-medic/medic/medic.js appium --platform android 
--plugins cordova-plugin-contacts"
+
+'use strict';
+
+var wdHelper = require('../helpers/wdHelper');
+var screenshotHelper = require('../helpers/screenshotHelper');
+var contactsHelper = require('../helpers/contactsHelper');
+
+var STARTING_MESSAGE = 'Ready for action!';
+var MINUTE = 60 * 1000;
+var DEFAULT_WEBVIEW_CONTEXT = 'WEBVIEW';
+
+describe('Contacts Android', function () {
+var driver;
+// the name of webview context, it will be changed to match needed 
context if there are named ones:
+var webviewContext = DEFAULT_WEBVIEW_CONTEXT;
+// this indicates that there was a critical error and we should try to 
recover:
+var errorFlag = false;
+// this indicates that we couldn't restore Appium session and should 
fail fast:
+var stopFlag = false;
+
+function win() {
+expect(true).toBe(true);
+}
+
+function fail(error) {
+if (error === 'rethrow') {
+throw error;
+}
+if (error && error.message) {
+console.log('An error occured: ' + error.message);
+if (error.stack) {
+console.log(error.stack);
+}
+expect(true).toFailWithMessage(error.message);
+} else if (error && typeof error === 'string') {
+console.log('Failed expectation: ' + error);
+expect(true).toFailWithMessage(error);
+} else {
+// no message provided :(
+expect(true).toBe(false);
+}
+return screenshotHelper
+.saveScreenshot(driver)
+.finally(function() {
+throw 'rethrow';
+});
+}
+
+function enterTest() {
+return driver
+// trying to determine where we are
+.context(webviewContext)
+.fail(function (error) {
+return fail(error);
+})
+.elementById('info')
+.then(function () {
+return driver; //we're already on the test screen
+}, function () {
+return driver
+.elementById('middle')
+.then(function () {
+return driver
+// we're on autotests page, we should go to 
start page
+.execute('window.location = "../index.html"')
+.sleep(5000)
+.fail(function () {
+errorFlag = true;
+throw 'Couldn\'t find start page.';
+});
+}, function () {
+return; // no-op
+})
+// unknown starting page: no 'info' div
+// adding it manually
+.execute('var info = document.createElement("div"); ' +
+ 'info.id = "info"; ' +
+ 'document.body.appendChild(info);');
+})
+.sleep(5000);
+}
+
+function getDriver() {
+driver = wdHelper.getDriver('Android');
+return driver;
+}

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

[dblotsky]

Github user dblotsky commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780306
  
--- Diff: appium-tests/ios/ios.spec.js ---
@@ -0,0 +1,352 @@
+/*jshint node: true, jasmine: true */
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+*/
+
+// these tests are meant to be executed by Cordova Medic Appium runner
+// you can find it here: https://github.com/apache/cordova-medic/
+// it is not necessary to do a full CI setup to run these tests
+// just run "node cordova-medic/medic/medic.js appium --platform ios 
--plugins cordova-plugin-contacts"
+
+'use strict';
+
+var wdHelper = require('../helpers/wdHelper');
+var screenshotHelper = require('../helpers/screenshotHelper');
+var contactsHelper = require('../helpers/contactsHelper');
+var unorm = global.unorm || require("unorm");
+
+var STARTING_MESSAGE = 'Ready for action!';
+var MINUTE = 60 * 1000;
+var DEFAULT_WEBVIEW_CONTEXT = 'WEBVIEW_1';
+
+describe('contacts tests iOS', function () {
+var driver;
+// the name of webview context, it will be changed to match needed 
context if there are named ones:
+var webviewContext = DEFAULT_WEBVIEW_CONTEXT;
+// this indicates that there was a critical error and we should try to 
recover:
+var errorFlag = false;
+// this indicates that we couldn't restore Appium session and should 
fail fast:
+var stopFlag = false;
+
+function win() {
+expect(true).toBe(true);
+}
+
+function fail(error) {
+if (error === 'rethrow') {
+throw error;
+}
+if (error && error.message) {
+console.log('An error occured: ' + error.message);
+if (error.stack) {
+console.log(error.stack);
+}
+expect(true).toFailWithMessage(error.message);
+} else if (error && typeof error === 'string') {
+console.log('Failed expectation: ' + error);
+expect(true).toFailWithMessage(error);
+} else {
+// no message provided :(
+expect(true).toBe(false);
+}
+return screenshotHelper
+.saveScreenshot(driver)
+.finally(function() {
+throw 'rethrow';
+});
+}
+
+function enterTest() {
+return driver
+// trying to determine where we are
+.context(webviewContext)
+.fail(function (error) {
+return fail(error);
+})
+.elementById('info')
+.then(function () {
+return driver; //we're already on the test screen
+}, function () {
+return driver
+.elementById('middle')
+.then(function () {
+return driver
+// we're on autotests page, we should go to 
start page
+.execute('window.location = "../index.html"')
+.sleep(5000)
+.fail(function () {
+errorFlag = true;
+throw 'Couldn\'t find start page.';
+});
+}, function () {
+return; // no-op
+})
+// unknown starting page: no 'info' div
+// adding it manually
+.execute('var info = document.createElement("div"); ' +
+ 'info.id = "info"; ' +
+ 'document.body.appendChild(info);');
+})
+.then(win, fail)
+.sleep(5000);
+}
+
+function getDriver() {
+driver 

[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests

[dblotsky]

Github user dblotsky commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/101#discussion_r55780286
  
--- Diff: appium-tests/ios/ios.spec.js ---
@@ -0,0 +1,352 @@
+/*jshint node: true, jasmine: true */
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+*/
+
+// these tests are meant to be executed by Cordova Medic Appium runner
+// you can find it here: https://github.com/apache/cordova-medic/
+// it is not necessary to do a full CI setup to run these tests
+// just run "node cordova-medic/medic/medic.js appium --platform ios 
--plugins cordova-plugin-contacts"
+
+'use strict';
+
+var wdHelper = require('../helpers/wdHelper');
+var screenshotHelper = require('../helpers/screenshotHelper');
+var contactsHelper = require('../helpers/contactsHelper');
+var unorm = global.unorm || require("unorm");
+
+var STARTING_MESSAGE = 'Ready for action!';
+var MINUTE = 60 * 1000;
+var DEFAULT_WEBVIEW_CONTEXT = 'WEBVIEW_1';
+
+describe('contacts tests iOS', function () {
+var driver;
+// the name of webview context, it will be changed to match needed 
context if there are named ones:
+var webviewContext = DEFAULT_WEBVIEW_CONTEXT;
+// this indicates that there was a critical error and we should try to 
recover:
+var errorFlag = false;
+// this indicates that we couldn't restore Appium session and should 
fail fast:
+var stopFlag = false;
+
+function win() {
+expect(true).toBe(true);
+}
+
+function fail(error) {
+if (error === 'rethrow') {
+throw error;
+}
+if (error && error.message) {
+console.log('An error occured: ' + error.message);
+if (error.stack) {
+console.log(error.stack);
+}
+expect(true).toFailWithMessage(error.message);
+} else if (error && typeof error === 'string') {
+console.log('Failed expectation: ' + error);
+expect(true).toFailWithMessage(error);
+} else {
+// no message provided :(
+expect(true).toBe(false);
+}
+return screenshotHelper
+.saveScreenshot(driver)
+.finally(function() {
+throw 'rethrow';
+});
+}
+
+function enterTest() {
+return driver
+// trying to determine where we are
+.context(webviewContext)
+.fail(function (error) {
+return fail(error);
+})
+.elementById('info')
+.then(function () {
+return driver; //we're already on the test screen
+}, function () {
+return driver
+.elementById('middle')
+.then(function () {
+return driver
+// we're on autotests page, we should go to 
start page
+.execute('window.location = "../index.html"')
+.sleep(5000)
+.fail(function () {
+errorFlag = true;
+throw 'Couldn\'t find start page.';
+});
+}, function () {
+return; // no-op
+})
+// unknown starting page: no 'info' div
+// adding it manually
+.execute('var info = document.createElement("div"); ' +
+ 'info.id = "info"; ' +
+ 'document.body.appendChild(info);');
+})
+.then(win, fail)
+.sleep(5000);
+}
+
+function getDriver() {
+driver 

Re: [DISCUSS] Removing plugin pinning

[Shazron]

+1

On Thu, Mar 10, 2016 at 1:16 PM, Richard Knoll  wrote:
> Hey everyone,
>
> With the new plugin version selection code merged into cordova-lib, are there 
> any objections to removing plugin pinning? I plan to open PRs soon on the 
> core plugins to move engine info into each plugin's package.json.
>
> Thanks,
> Richard

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10819 Adding snapshotting and improv...

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/553#issuecomment-195134620
  
@riknoll @rakatyal please review when you have a moment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [iOS] Fixed authorization erro...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/144#issuecomment-195134078
  
Hey @nleclerc, mind closing this PR? #146 was merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10819 Adding snapshotting and improv...

[dblotsky]

GitHub user dblotsky opened a pull request:

https://github.com/apache/cordova-docs/pull/553

CB-10819 Adding snapshotting and improving build system

- Added 'snap' command to Makefile and gulpfile. 
- Fixed 'newversion' command.
- Made fetched files live under /reference/. 
- Refactored and removed incrementversion.js in favour of simple FS 
commands.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs CB-10819

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/553.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #553


commit dc75ae90c2ed53410668c28f081d74ef7c270f61
Author: Dmitry Blotsky 
Date:   2016-03-08T02:21:40Z

CB-10819 Added 'snap' command to Makefile and gulpfile. Fixed 'newversion' 
command. Made fetched files live under /reference/. Refactored and removed 
incrementversion.js in favour of simple FS commands.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[DRAFT] [REPORT] Cordova - March 2016

[Shazron]

Please read and review. I'm sending this out later tonight.

https://github.com/cordova/apache-board-reports/blob/master/2016/2016-03.md

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Simplifying cordova-cli README

[Nikhil Khandelwal]

Our cordova-cli readme has become super long & not been maintained over the 
years. It repeats a lot of content from the docs. I have simplified it 
significantly by linking to relevant getting started, filing issues, 
contribution etc. sections that are part of our website. This should help 
maintenance as we do not repeat ourselves. However, there is a loss of some 
inline content.

Please review and comment on this PR: 
https://github.com/apache/cordova-cli/pull/240/files

-Nikhil

[GitHub] cordova-docs pull request: Clean up plugin publishing guide

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/548#issuecomment-195129017
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Clean up plugin publishing guide

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-docs/pull/548#issuecomment-195125079
  
@riknoll can you take a quick look as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [Android] New Bridge: evaluateJavascript

[Joe Bowser]

On Thu, Mar 10, 2016 at 3:54 PM, Darryl Pogue  wrote:

> If it's an addition to one of the public interfaces, doesn't that require a
> major bump because every existing implementation of the interface would now
> cause errors due to missing methods?
>
>
Yeah, I hate semver.  Right now we only have one existing implementation
(Crosswalk), and that's the only thing that's affected by it.  If people
didn't think "Oh, it's a major version, everything is going to be
broken!!!" just because we added literally one call, I'd probably not have
an issue with the practice, but because of semver, this change is going to
probably be delayed because people don't want to jump another major version
so soon.

As far as avoiding it, well, you kind of can't without using reflection to
determine whether your view has that method it begin with.  Having to come
up with a technical solution to people's fear of bigger version numbers is
how we get more bugs in our code.

Semver aside, this change sounds good to me. I've definitely encountered
> some bizarre issues with the online/offline events being used for bridge
> communication (like navigator.online getting permanently toggled to false).
>

Can you reproduce this reliably? I've asked for repro code from the person
who mentioned this, but I can't get it for unknown reasons.



>
> On 10 March 2016 at 15:48, Carlos Santana  wrote:
>
> > I didn't say it was a private API what I meant is that based on what you
> > shared that this Will be a new public API another bridge people can use
> > with the current API not broken.
> >
> > So a minor bump on the version is OK
> >
> > - Carlos
> > @csantanapr
> >
> > > On Mar 10, 2016, at 4:03 PM, Joe Bowser  wrote:
> > >
> > > Well, If they add the method, the latest version of their plugin should
> > > still work with older versions of Cordova.  So, is this really the same
> > > thing?
> > >
> > > On Thu, Mar 10, 2016 at 12:18 PM, Simon MacDonald <
> > simon.macdon...@gmail.com
> > >> wrote:
> > >
> > >> I think we are okay bumping the minor for this change not the major.
> > >>
> > >> I'm in favour of this bridge as long as we don't need to guard all the
> > code
> > >> with reflection. Using reflection to call evaluateJavascript would
> > negate
> > >> any performance bonus. So if we can use evaluateJavascript on Android
> > 4.4
> > >> and above and then revert to LoadUrl on Android 4.3 and earlier for
> this
> > >> bridge I say we go for it.
> > >>
> > >> I think we can give CrossWalk enough time so this doesn't completely
> > screw
> > >> them over. Also, if we give them a heads up they can make it so the
> > plugin
> > >> only installs on Cordova Android 5.1.1 and earlier.
> > >>
> > >>
> > >> Simon Mac Donald
> > >> http://hi.im/simonmacdonald
> > >>
> > >>> On Thu, Mar 10, 2016 at 2:51 PM, Joe Bowser 
> wrote:
> > >>>
> > >>> On Thu, Mar 10, 2016 at 11:48 AM, Carlos Santana <
> csantan...@gmail.com
> > >
> > >>> wrote:
> > >>>
> >  I don't think we need to bump major number, there is no public API
> > >> brake
> > >>> This isn't a private API.  This API is how third parties like Intel
> can
> > >>> make things like Crosswalk.
> > >>>
> > >>>
> >  we are just added a feature, old stuff will still work.
> > >>>
> > >>> Except that Crosswalk now has to implement evaluateJavascript on
> their
> > >>> XWalkEngine class.  At least this won't need a crap ton of reflection
> > >> code
> > >>> like the last API change.
> > >>>
> > >>>
> > 
> > > On Thu, Mar 10, 2016 at 2:41 PM Joe Bowser 
> > wrote:
> > >
> > > Well, since the problem is with ONLINE_EVENT having a race
> condition,
> > > earlier versions of Android would have to use the slower LOAD_URL
> > >> with
> > > known issues related to the input fields.  There's more testing
> that
> >  needs
> > > to be done, obviously, but it's worth adding the third bridge in
> the
> > >>> next
> > > major release.
> > >
> > > I'm just wondering how people feel about bumping another version.
> I
> >  don't
> > > think our users understand that we use semver at all, which makes
> > >>> things
> > > extremely frustrating.
> > >
> > >
> > >
> > > On Thu, Mar 10, 2016 at 11:30 AM, Carlos Santana <
> > >> csantan...@gmail.com
> > 
> > > wrote:
> > >
> > >> But what about 4.3 and lower versions of Android? How do we
> support
> >  them?
> > >> Do we use ONLINE_EVENT if we detect were are running on those
> > >>> versions
> >  of
> > >> Android?
> > >>
> > >>
> > >> On Thu, Mar 10, 2016 at 1:36 PM Joe Bowser 
> > >>> wrote:
> > >>
> > >>> So, apparently some people are reporting that the ONLINE_EVENT
> > >>> bridge
> > >> that
> > >>> we currently use by default in Android has a race condition when
> > >>> you
> > >> start
> > >>> using more 

Re: [Android] New Bridge: evaluateJavascript

[Darryl Pogue]

If it's an addition to one of the public interfaces, doesn't that require a
major bump because every existing implementation of the interface would now
cause errors due to missing methods?

Semver aside, this change sounds good to me. I've definitely encountered
some bizarre issues with the online/offline events being used for bridge
communication (like navigator.online getting permanently toggled to false).

On 10 March 2016 at 15:48, Carlos Santana  wrote:

> I didn't say it was a private API what I meant is that based on what you
> shared that this Will be a new public API another bridge people can use
> with the current API not broken.
>
> So a minor bump on the version is OK
>
> - Carlos
> @csantanapr
>
> > On Mar 10, 2016, at 4:03 PM, Joe Bowser  wrote:
> >
> > Well, If they add the method, the latest version of their plugin should
> > still work with older versions of Cordova.  So, is this really the same
> > thing?
> >
> > On Thu, Mar 10, 2016 at 12:18 PM, Simon MacDonald <
> simon.macdon...@gmail.com
> >> wrote:
> >
> >> I think we are okay bumping the minor for this change not the major.
> >>
> >> I'm in favour of this bridge as long as we don't need to guard all the
> code
> >> with reflection. Using reflection to call evaluateJavascript would
> negate
> >> any performance bonus. So if we can use evaluateJavascript on Android
> 4.4
> >> and above and then revert to LoadUrl on Android 4.3 and earlier for this
> >> bridge I say we go for it.
> >>
> >> I think we can give CrossWalk enough time so this doesn't completely
> screw
> >> them over. Also, if we give them a heads up they can make it so the
> plugin
> >> only installs on Cordova Android 5.1.1 and earlier.
> >>
> >>
> >> Simon Mac Donald
> >> http://hi.im/simonmacdonald
> >>
> >>> On Thu, Mar 10, 2016 at 2:51 PM, Joe Bowser  wrote:
> >>>
> >>> On Thu, Mar 10, 2016 at 11:48 AM, Carlos Santana  >
> >>> wrote:
> >>>
>  I don't think we need to bump major number, there is no public API
> >> brake
> >>> This isn't a private API.  This API is how third parties like Intel can
> >>> make things like Crosswalk.
> >>>
> >>>
>  we are just added a feature, old stuff will still work.
> >>>
> >>> Except that Crosswalk now has to implement evaluateJavascript on their
> >>> XWalkEngine class.  At least this won't need a crap ton of reflection
> >> code
> >>> like the last API change.
> >>>
> >>>
> 
> > On Thu, Mar 10, 2016 at 2:41 PM Joe Bowser 
> wrote:
> >
> > Well, since the problem is with ONLINE_EVENT having a race condition,
> > earlier versions of Android would have to use the slower LOAD_URL
> >> with
> > known issues related to the input fields.  There's more testing that
>  needs
> > to be done, obviously, but it's worth adding the third bridge in the
> >>> next
> > major release.
> >
> > I'm just wondering how people feel about bumping another version.  I
>  don't
> > think our users understand that we use semver at all, which makes
> >>> things
> > extremely frustrating.
> >
> >
> >
> > On Thu, Mar 10, 2016 at 11:30 AM, Carlos Santana <
> >> csantan...@gmail.com
> 
> > wrote:
> >
> >> But what about 4.3 and lower versions of Android? How do we support
>  them?
> >> Do we use ONLINE_EVENT if we detect were are running on those
> >>> versions
>  of
> >> Android?
> >>
> >>
> >> On Thu, Mar 10, 2016 at 1:36 PM Joe Bowser 
> >>> wrote:
> >>
> >>> So, apparently some people are reporting that the ONLINE_EVENT
> >>> bridge
> >> that
> >>> we currently use by default in Android has a race condition when
> >>> you
> >> start
> >>> using more than one WebView in an application.  Even though we
>  decided
> > to
> >>> not support the case of having multiple webviews in an
> >> Application,
> > it's
> >>> still being used this way.
> >>>
> >>> Ideally, I would like to see us figure out how we can change the
>  bridge
> >>> modes so that we don't have so many static classes, or at least
>  change
> >> them
> >>> such that we're not tracing mutable states in static classes.
>  However,
> >>> someone asked about evaluateJavascript and using that for the
> >>> bridge.
> > I
> >>> implemented that really quick here:
> >> https://github.com/infil00p/cordova-android/tree/building_bridges
> >>>
> >>> Basically, this should get around the whole bridge state problem
>  since
> >>> we're executing the JS on the right webview every time instead of
> > trying
> >> to
> >>> manipulate a static variable that may or may not correspond to
> >> the
> >> webview
> >>> that we're using.  Also, the benchmarking on this initially seems
> >>> comparable to ONLINE_EVENT.
> >>>
> >>> There's also the fact 

Re: [Android] New Bridge: evaluateJavascript

[Carlos Santana]

I didn't say it was a private API what I meant is that based on what you shared 
that this Will be a new public API another bridge people can use with the 
current API not broken. 

So a minor bump on the version is OK

- Carlos
@csantanapr

> On Mar 10, 2016, at 4:03 PM, Joe Bowser  wrote:
> 
> Well, If they add the method, the latest version of their plugin should
> still work with older versions of Cordova.  So, is this really the same
> thing?
> 
> On Thu, Mar 10, 2016 at 12:18 PM, Simon MacDonald > wrote:
> 
>> I think we are okay bumping the minor for this change not the major.
>> 
>> I'm in favour of this bridge as long as we don't need to guard all the code
>> with reflection. Using reflection to call evaluateJavascript would negate
>> any performance bonus. So if we can use evaluateJavascript on Android 4.4
>> and above and then revert to LoadUrl on Android 4.3 and earlier for this
>> bridge I say we go for it.
>> 
>> I think we can give CrossWalk enough time so this doesn't completely screw
>> them over. Also, if we give them a heads up they can make it so the plugin
>> only installs on Cordova Android 5.1.1 and earlier.
>> 
>> 
>> Simon Mac Donald
>> http://hi.im/simonmacdonald
>> 
>>> On Thu, Mar 10, 2016 at 2:51 PM, Joe Bowser  wrote:
>>> 
>>> On Thu, Mar 10, 2016 at 11:48 AM, Carlos Santana 
>>> wrote:
>>> 
 I don't think we need to bump major number, there is no public API
>> brake
>>> This isn't a private API.  This API is how third parties like Intel can
>>> make things like Crosswalk.
>>> 
>>> 
 we are just added a feature, old stuff will still work.
>>> 
>>> Except that Crosswalk now has to implement evaluateJavascript on their
>>> XWalkEngine class.  At least this won't need a crap ton of reflection
>> code
>>> like the last API change.
>>> 
>>> 
 
> On Thu, Mar 10, 2016 at 2:41 PM Joe Bowser  wrote:
> 
> Well, since the problem is with ONLINE_EVENT having a race condition,
> earlier versions of Android would have to use the slower LOAD_URL
>> with
> known issues related to the input fields.  There's more testing that
 needs
> to be done, obviously, but it's worth adding the third bridge in the
>>> next
> major release.
> 
> I'm just wondering how people feel about bumping another version.  I
 don't
> think our users understand that we use semver at all, which makes
>>> things
> extremely frustrating.
> 
> 
> 
> On Thu, Mar 10, 2016 at 11:30 AM, Carlos Santana <
>> csantan...@gmail.com
 
> wrote:
> 
>> But what about 4.3 and lower versions of Android? How do we support
 them?
>> Do we use ONLINE_EVENT if we detect were are running on those
>>> versions
 of
>> Android?
>> 
>> 
>> On Thu, Mar 10, 2016 at 1:36 PM Joe Bowser 
>>> wrote:
>> 
>>> So, apparently some people are reporting that the ONLINE_EVENT
>>> bridge
>> that
>>> we currently use by default in Android has a race condition when
>>> you
>> start
>>> using more than one WebView in an application.  Even though we
 decided
> to
>>> not support the case of having multiple webviews in an
>> Application,
> it's
>>> still being used this way.
>>> 
>>> Ideally, I would like to see us figure out how we can change the
 bridge
>>> modes so that we don't have so many static classes, or at least
 change
>> them
>>> such that we're not tracing mutable states in static classes.
 However,
>>> someone asked about evaluateJavascript and using that for the
>>> bridge.
> I
>>> implemented that really quick here:
>> https://github.com/infil00p/cordova-android/tree/building_bridges
>>> 
>>> Basically, this should get around the whole bridge state problem
 since
>>> we're executing the JS on the right webview every time instead of
> trying
>> to
>>> manipulate a static variable that may or may not correspond to
>> the
>> webview
>>> that we're using.  Also, the benchmarking on this initially seems
>>> comparable to ONLINE_EVENT.
>>> 
>>> There's also the fact that it's a lot less code than
>> ONLINE_EVENT,
 due
> to
>>> the whole state thing.  The main thing that ONLINE_EVENT has over
>>> evaluateJavascript is that it works on Jellybean (4.3 and lower).
>>> 
>>> This branch does add a method to the API, and Crosswalk would
>> have
>>> to
> add
>>> the same two lines of code to their WebView to allow
 evaluateJavascript
>> to
>>> work there as well as it does here.  I did check to make sure
>> their
 API
>>> does support it before I added it.
>>> 
>>> So, is this useful? Should we merge it in? Do we increment a
>> major
>> version
>>> number for this?
>>> 
>>> Joe
>> 

Re: Edit to Edit on Github for Docs

[Carlos Santana]

I agree Robert 

This points out that [1] Contribute page is missing the Edit button :-). If it 
was there you  could've submitted the change 

Add to the list another way to help the project by clicking that Edit link and 
help out

Advertise the "Edit Source on Github" link with some info how easy and how the 
changes will eventually make it in

[1] http://cordova.apache.org/contribute/

- Carlos
@csantanapr

> On Mar 10, 2016, at 5:50 PM, Robert Posener  wrote:
> 
> In my confused mode (as documented in my last e-mail) when I was wondering
> what does this "Edit" button do? I went looking for an answer on different
> Cordova documentation and contributor web pages.  No answer was found.  I
> would have thought it should be explained under "Contributing" somewhere
> and saying that you don't need to be a committer or have a login and that
> you can't stuff anything up and whatever you contribute will be reviewed by
> a knowledgeable person before it is committed.
> 
> Rob
> 
> Regards
> *Rob Posener*
> 0419 012 627
> 
>> On 10 March 2016 at 23:47, Dmitry Blotsky  wrote:
>> 
>> Hey Robert,
>> 
>> What do you mean by the “Edit” button being documented?
>> 
>> Also folks: here is a PR with a change addressing this discussion and a
>> bit more: https://github.com/apache/cordova-docs/pull/551/files.
>> 
>> Kindly,
>> Dmitry
>> 
>> On Mar 9, 2016, at 2:19 PM, Robert Posener  rposen...@gmail.com>> wrote:
>> 
>> Also, can we add "Edit on GitHub" to Blog and Plugin pages, please.
>> 
>> Regards
>> *Rob Posener*
>> 0419 012 627
>> 
>> On 10 March 2016 at 09:14, Robert Posener  rposen...@gmail.com>> wrote:
>> 
>> I like "Edit on GitHub".
>> 
>> I was never sure how far into "editing" clicking on the "Edit" button
>> would take me before I hit some roadblock (like needing to be a committer,
>> like having a GitHub login, like being part of the cordova in-crowd, etc)
>> that meant that I had wasted my time.  It would be nice to clarify this
>> (eg, a hover tip like "No login necessary - Will be queued for review by
>> committers").
>> Also... where is the "Edit" button documented?
>> 
>> Rob
>> 
>> Regards
>> *Rob Posener*
>> 0419 012 627
>> 
>> On 9 March 2016 at 10:29, Dmitry Blotsky  dblot...@microsoft.com>> wrote:
>> 
>> I don't know if we have A/B testing capabilities, but I'm cool with
>> changing the text to "Edit on GitHub". Also, we have like 10 open PRs for
>> docs from contributors, so the buttons definitely work. :)
>> 
>> I'll make the change for "Edit on GitHub" unless someone objects.
>> 
>> Kindly,
>> Dmitry
>> 
>> -Original Message-
>> From: Jesse [mailto:purplecabb...@gmail.com]
>> Sent: Tuesday, March 8, 2016 11:26 AM
>> To: dev@cordova.apache.org
>> Subject: Re: Edit to Edit on Github for Docs
>> 
>> +1 to AB testing!
>> 
>> 
>> On Mar 8, 2016, at 11:02 AM, Steven Gill  stevengil...@gmail.com>>
>> wrote:
>> 
>> Look at us talking UX. Lets do some AB testing while we are at ;)
>> 
>> On Tue, Mar 8, 2016 at 10:54 AM, Nikhil Khandelwal
>> >
>> wrote:
>> 
>> +1 for trying "Edit on Github" - anything that _may_ increase
>> contributions to the docs is welcome. :)
>> 
>> -Nikhil
>> 
>> -Original Message-
>> From: Shazron [mailto:shaz...@gmail.com]
>> Sent: Tuesday, March 8, 2016 10:26 AM
>> To: dev@cordova.apache.org
>> Subject: Re: Edit to Edit on Github for Docs
>> 
>> I'm ambivalent. "Edit" is concise, and I would think most are curious
>> enough to just click and see?
>> 
>> On Tue, Mar 8, 2016 at 8:50 AM, Carlos Santana > >
>> wrote:
>> The other day I was looking like crazy the doc source code that
>> corresponded to the page that a user was asking here in dev list
>> where was the source code, so I assume he also didn't see the "Edit"
>> 
>> Then someone pointed out there is an "Edit" link/button at the top
>> right side of each page.
>> 
>> Then I saw another website, can't remember now, but they had "Edit
>> on Github" and having the "on Github" capture my attention.
>> 
>> What you guys think about change it from "Edit" to "Edit on Github"
>> is that a good change or it's just me
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org> dev-unsubscr...@cordova.apache.org>
>> For additional commands, e-mail: dev-h...@cordova.apache.org> dev-h...@cordova.apache.org>
>> 
>> 
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org> dev-unsubscr...@cordova.apache.org>
>> For additional commands, e-mail: dev-h...@cordova.apache.org> dev-h...@cordova.apache.org>
>> 
>> 
>> 

[GitHub] cordova-docs pull request: Fix typo for orientation property portr...

[insane210]

GitHub user insane210 opened a pull request:

https://github.com/apache/cordova-docs/pull/552

Fix typo for orientation property portrait.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/insane210/cordova-docs patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/552.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #552


commit 26de371befd65dbfe49bfbdc7137ba635d405245
Author: insane210 
Date:   2016-03-10T23:26:53Z

Fix typo for orientation property portrait.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-10679: Documenting how the CLI choose...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/241#discussion_r55768334
  
--- Diff: doc/readme.md ---
@@ -337,6 +337,18 @@ There are a number of ways to specify a plugin:
 | commit-ish  | Commit/tag/branch reference. If none is specified, 
'master' is used
 | subdir  | Sub-directory to find plugin.xml for the specified plugin.
 
+### Algorithm for choosing which plugin version to fetch from npm
+
+When adding a plugin to a project from npm, the CLI will choose which 
version
+of the plugin to fetch based on the following criteria (listed in order of
+precedence):
+
+1. The plugin version specified in the command (e.g. `cordova plugin add 
plugin@version`)
+2. The plugin version saved in config.xml (i.e. if the plugin was 
previously added with `--save`)
+3. The latest plugin version that the current project can support (only 
applies to plugins that list their [Cordova dependencies] in their 
`package.json`)
--- End diff --

"As for version 6.1, ..."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-10679: Documenting how the CLI choose...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/241#discussion_r55767811
  
--- Diff: doc/readme.md ---
@@ -337,6 +337,18 @@ There are a number of ways to specify a plugin:
 | commit-ish  | Commit/tag/branch reference. If none is specified, 
'master' is used
 | subdir  | Sub-directory to find plugin.xml for the specified plugin.
 
+### Algorithm for choosing which plugin version to fetch from npm
+
+When adding a plugin to a project from npm, the CLI will choose which 
version
+of the plugin to fetch based on the following criteria (listed in order of
+precedence):
+
+1. The plugin version specified in the command (e.g. `cordova plugin add 
plugin@version`)
--- End diff --

Consider changing `version` to `plugin-spec`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-10679: Documenting how the CLI choose...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-cli/pull/241#discussion_r55766818
  
--- Diff: doc/readme.md ---
@@ -337,6 +337,18 @@ There are a number of ways to specify a plugin:
 | commit-ish  | Commit/tag/branch reference. If none is specified, 
'master' is used
 | subdir  | Sub-directory to find plugin.xml for the specified plugin.
 
+### Algorithm for choosing which plugin version to fetch from npm
+
+When adding a plugin to a project from npm, the CLI will choose which 
version
+of the plugin to fetch based on the following criteria (listed in order of
+precedence):
+
+1. The plugin version specified in the command (e.g. `cordova plugin add 
plugin@version`)
+2. The plugin version saved in config.xml (i.e. if the plugin was 
previously added with `--save`)
+3. The latest plugin version that the current project can support (only 
applies to plugins that list their [Cordova dependencies] in their 
`package.json`)
+4. The plugin version pinned by your installed CLI version (only applies 
to [Apache-developed plugins])
--- End diff --

This will likely need an update in a couple of days - when you remove 
plugin pinning.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Removing plugin pinning

[Steven Gill]

No objection here
On Mar 10, 2016 1:17 PM, "Richard Knoll"  wrote:

> Hey everyone,
>
> With the new plugin version selection code merged into cordova-lib, are
> there any objections to removing plugin pinning? I plan to open PRs soon on
> the core plugins to move engine info into each plugin's package.json.
>
> Thanks,
> Richard
>

[GitHub] cordova-plugin-camera pull request: Android FileHelper modificatio...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-195093360
  
I just got a Jellybean device, so I'm going to verify that there is no 
issue there first


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Android FileHelper modificatio...

[nikhilkh]

Github user nikhilkh commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-195092845
  
Shall we close this PR now? :boom:  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Edit to Edit on Github for Docs

[Robert Posener]

In my confused mode (as documented in my last e-mail) when I was wondering
what does this "Edit" button do? I went looking for an answer on different
Cordova documentation and contributor web pages.  No answer was found.  I
would have thought it should be explained under "Contributing" somewhere
and saying that you don't need to be a committer or have a login and that
you can't stuff anything up and whatever you contribute will be reviewed by
a knowledgeable person before it is committed.

Rob

Regards
*Rob Posener*
0419 012 627

On 10 March 2016 at 23:47, Dmitry Blotsky  wrote:

> Hey Robert,
>
> What do you mean by the “Edit” button being documented?
>
> Also folks: here is a PR with a change addressing this discussion and a
> bit more: https://github.com/apache/cordova-docs/pull/551/files.
>
> Kindly,
> Dmitry
>
> On Mar 9, 2016, at 2:19 PM, Robert Posener > wrote:
>
> Also, can we add "Edit on GitHub" to Blog and Plugin pages, please.
>
> Regards
> *Rob Posener*
> 0419 012 627
>
> On 10 March 2016 at 09:14, Robert Posener > wrote:
>
> I like "Edit on GitHub".
>
> I was never sure how far into "editing" clicking on the "Edit" button
> would take me before I hit some roadblock (like needing to be a committer,
> like having a GitHub login, like being part of the cordova in-crowd, etc)
> that meant that I had wasted my time.  It would be nice to clarify this
> (eg, a hover tip like "No login necessary - Will be queued for review by
> committers").
> Also... where is the "Edit" button documented?
>
> Rob
>
> Regards
> *Rob Posener*
> 0419 012 627
>
> On 9 March 2016 at 10:29, Dmitry Blotsky > wrote:
>
> I don't know if we have A/B testing capabilities, but I'm cool with
> changing the text to "Edit on GitHub". Also, we have like 10 open PRs for
> docs from contributors, so the buttons definitely work. :)
>
> I'll make the change for "Edit on GitHub" unless someone objects.
>
> Kindly,
> Dmitry
>
> -Original Message-
> From: Jesse [mailto:purplecabb...@gmail.com]
> Sent: Tuesday, March 8, 2016 11:26 AM
> To: dev@cordova.apache.org
> Subject: Re: Edit to Edit on Github for Docs
>
> +1 to AB testing!
>
>
> On Mar 8, 2016, at 11:02 AM, Steven Gill >
> wrote:
>
> Look at us talking UX. Lets do some AB testing while we are at ;)
>
> On Tue, Mar 8, 2016 at 10:54 AM, Nikhil Khandelwal
> >
> wrote:
>
> +1 for trying "Edit on Github" - anything that _may_ increase
> contributions to the docs is welcome. :)
>
> -Nikhil
>
> -Original Message-
> From: Shazron [mailto:shaz...@gmail.com]
> Sent: Tuesday, March 8, 2016 10:26 AM
> To: dev@cordova.apache.org
> Subject: Re: Edit to Edit on Github for Docs
>
> I'm ambivalent. "Edit" is concise, and I would think most are curious
> enough to just click and see?
>
> On Tue, Mar 8, 2016 at 8:50 AM, Carlos Santana  >
> wrote:
> The other day I was looking like crazy the doc source code that
> corresponded to the page that a user was asking here in dev list
> where was the source code, so I assume he also didn't see the "Edit"
>
> Then someone pointed out there is an "Edit" link/button at the top
> right side of each page.
>
> Then I saw another website, can't remember now, but they had "Edit
> on Github" and having the "on Github" capture my attention.
>
> What you guys think about change it from "Edit" to "Edit on Github"
> is that a good change or it's just me
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org dev-unsubscr...@cordova.apache.org>
> For additional commands, e-mail: dev-h...@cordova.apache.org dev-h...@cordova.apache.org>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org dev-unsubscr...@cordova.apache.org>
> For additional commands, e-mail: dev-h...@cordova.apache.org dev-h...@cordova.apache.org>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org dev-unsubscr...@cordova.apache.org>
> For additional commands, e-mail: dev-h...@cordova.apache.org dev-h...@cordova.apache.org>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org dev-unsubscr...@cordova.apache.org>
> For additional commands, e-mail: dev-h...@cordova.apache.org dev-h...@cordova.apache.org>
>
>
>
>
>

[GitHub] cordova-plugin-camera pull request: CB-10270 android: Added back s...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/160#issuecomment-195084460
  
@jcesarmobile I don't even know if this is an issue in Jelly Bean. Do you 
have a device to test with?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10769 Move plugin handlers tests into...

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-ios/pull/200#discussion_r55762230
  
--- Diff: .jshintignore ---
@@ -1,2 +1,3 @@
 bin/node_modules/*
 bin/templates/project/*
+tests/spec/unit/fixtures/*
--- End diff --

Please add a newline at the end of the file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-ios pull request: CB-10769 Move plugin handlers tests into...

[dblotsky]

Github user dblotsky commented on a diff in the pull request:

https://github.com/apache/cordova-ios/pull/200#discussion_r55762207
  
--- Diff: .gitignore ---
@@ -7,3 +7,4 @@ tmp
 xcuserdata
 console.log
 node_modules/
+npm-debug.log
--- End diff --

Please add a newline at the end of the file.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10270 android: Added back s...

[jcesarmobile]

Github user jcesarmobile commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/160#issuecomment-195082019
  
#175 only fixes it on API 19 and greater, maybe it should be moved outside. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Android FileHelper modificatio...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/149#issuecomment-195080403
  
I can confirm this is no longer an issue on Marshmallow. I tested all of 
the permutations of camera options with both the stock gallery app and Google 
Photos and they all return a non-empty URI for videos. I have not tested videos 
on any other API level yet


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-9960 android: Fixed FileNot...

[riknoll]

Github user riknoll closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/135


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10270 android: Added back s...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/160#issuecomment-195077141
  
Seems to have been fixed by #175, so I'm closing this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-10270 android: Added back s...

[riknoll]

Github user riknoll closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/160


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10760: Document plugin element

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/536#issuecomment-195072875
  
:+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10760: Document plugin element

[omefire]

Github user omefire commented on the pull request:

https://github.com/apache/cordova-docs/pull/536#issuecomment-195072354
  
@riknoll :+1: 
handled.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Documenting some missing prefs: Windows...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/534


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10836 Improving "Edit" links

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-docs/pull/551#issuecomment-195061572
  
@nikhilkh @rakatyal @stevengill please review when you have a moment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-10679: Documenting how the CLI choose...

[dblotsky]

Github user dblotsky commented on the pull request:

https://github.com/apache/cordova-cli/pull/241#issuecomment-195060242
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10760: Document plugin element

[riknoll]

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-docs/pull/536#issuecomment-195059738
  
I know this was merged, but there was another part to the JIRA. The example 
config.xml at the bottom of the file uses the plugin tag incorrectly (`version` 
should be `spec`)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10760: Document plugin element

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/536


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [iOS] Major refactor

[omefire]

Github user omefire commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r55750647
  
--- Diff: src/ios/CDVCamera.m ---
@@ -398,10 +437,82 @@ - (NSString*)tempFilePath:(NSString*)extension
 do {
 filePath = [NSString stringWithFormat:@"%@/%@%03d.%@", docsPath, 
CDV_PHOTO_PREFIX, i++, extension];
 } while ([fileMgr fileExistsAtPath:filePath]);
-
+
 return filePath;
 }
 
+- (BOOL) needsResize:(CDVPictureOptions*)options
+{
+return (options.targetSize.height > 0 && options.targetSize.width > 0);
+}
+
+- (BOOL) needsEdit:(UIImage*)image options:(CDVPictureOptions*)options
+{
+return options.correctOrientation || [self needsResize:options];
+}
+
+- (BOOL) needsSavingToPhotoAlbum:(UIImage*)image 
options:(CDVPictureOptions*)options
+{
+/*
+ We save to the photo album if:
+ - the option is set
+ - the image is fetch from the camera OR the image has been edited (no 
need to duplicate image in the library)
+ */
+BOOL isSourceCamera = options.sourceType == 
UIImagePickerControllerSourceTypeCamera;
+BOOL saveToPhotoAlbum = options.saveToPhotoAlbum && ([self 
needsEdit:image options:options] || isSourceCamera);
+
+return saveToPhotoAlbum;
+}
+
+- (void)didReceiveImage:(CDVPictureOptions*)options 
info:(NSDictionary*)info
+{
+UIImage* image = [self retrieveImage:info options:options];
+
+/*
+ We can send the result immediately if:
+ - we fetch the picture from the PhotoLibrary or the SavedPhotoAlbum,
+ - we don't do any editing (orientation or resize),
+ - we pass down the result as a NATIVE_URI
+ */
+BOOL needsEdit = [self needsEdit:image options:options];
+BOOL isSourceCamera = (options.sourceType == 
UIImagePickerControllerSourceTypeCamera);
+BOOL isDestinationNativeUri = (options.destinationType == 
DestinationTypeNativeUri);
+BOOL needsMetadata = (needsEdit || isSourceCamera || 
!isDestinationNativeUri);
--- End diff --

I feel like the description given in the 'Metadata' section here could help 
clarify things better here, can we add it ?

https://github.com/apache/cordova-plugin-camera/pull/101

"Regarding metadata, we do not need it in only one case, when the 
destination type is NATIVE_URI, the source is the library, and no edits have to 
be done."




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [Android] New Bridge: evaluateJavascript

[Joe Bowser]

Well, If they add the method, the latest version of their plugin should
still work with older versions of Cordova.  So, is this really the same
thing?

On Thu, Mar 10, 2016 at 12:18 PM, Simon MacDonald  wrote:

> I think we are okay bumping the minor for this change not the major.
>
> I'm in favour of this bridge as long as we don't need to guard all the code
> with reflection. Using reflection to call evaluateJavascript would negate
> any performance bonus. So if we can use evaluateJavascript on Android 4.4
> and above and then revert to LoadUrl on Android 4.3 and earlier for this
> bridge I say we go for it.
>
> I think we can give CrossWalk enough time so this doesn't completely screw
> them over. Also, if we give them a heads up they can make it so the plugin
> only installs on Cordova Android 5.1.1 and earlier.
>
>
> Simon Mac Donald
> http://hi.im/simonmacdonald
>
> On Thu, Mar 10, 2016 at 2:51 PM, Joe Bowser  wrote:
>
> > On Thu, Mar 10, 2016 at 11:48 AM, Carlos Santana 
> > wrote:
> >
> > > I don't think we need to bump major number, there is no public API
> brake
> > >
> > >
> > This isn't a private API.  This API is how third parties like Intel can
> > make things like Crosswalk.
> >
> >
> > > we are just added a feature, old stuff will still work.
> > >
> >
> > Except that Crosswalk now has to implement evaluateJavascript on their
> > XWalkEngine class.  At least this won't need a crap ton of reflection
> code
> > like the last API change.
> >
> >
> > >
> > > On Thu, Mar 10, 2016 at 2:41 PM Joe Bowser  wrote:
> > >
> > > > Well, since the problem is with ONLINE_EVENT having a race condition,
> > > > earlier versions of Android would have to use the slower LOAD_URL
> with
> > > > known issues related to the input fields.  There's more testing that
> > > needs
> > > > to be done, obviously, but it's worth adding the third bridge in the
> > next
> > > > major release.
> > > >
> > > > I'm just wondering how people feel about bumping another version.  I
> > > don't
> > > > think our users understand that we use semver at all, which makes
> > things
> > > > extremely frustrating.
> > > >
> > > >
> > > >
> > > > On Thu, Mar 10, 2016 at 11:30 AM, Carlos Santana <
> csantan...@gmail.com
> > >
> > > > wrote:
> > > >
> > > > > But what about 4.3 and lower versions of Android? How do we support
> > > them?
> > > > > Do we use ONLINE_EVENT if we detect were are running on those
> > versions
> > > of
> > > > > Android?
> > > > >
> > > > >
> > > > > On Thu, Mar 10, 2016 at 1:36 PM Joe Bowser 
> > wrote:
> > > > >
> > > > > > So, apparently some people are reporting that the ONLINE_EVENT
> > bridge
> > > > > that
> > > > > > we currently use by default in Android has a race condition when
> > you
> > > > > start
> > > > > > using more than one WebView in an application.  Even though we
> > > decided
> > > > to
> > > > > > not support the case of having multiple webviews in an
> Application,
> > > > it's
> > > > > > still being used this way.
> > > > > >
> > > > > > Ideally, I would like to see us figure out how we can change the
> > > bridge
> > > > > > modes so that we don't have so many static classes, or at least
> > > change
> > > > > them
> > > > > > such that we're not tracing mutable states in static classes.
> > > However,
> > > > > > someone asked about evaluateJavascript and using that for the
> > bridge.
> > > > I
> > > > > > implemented that really quick here:
> > > > > >
> > > > > >
> https://github.com/infil00p/cordova-android/tree/building_bridges
> > > > > >
> > > > > > Basically, this should get around the whole bridge state problem
> > > since
> > > > > > we're executing the JS on the right webview every time instead of
> > > > trying
> > > > > to
> > > > > > manipulate a static variable that may or may not correspond to
> the
> > > > > webview
> > > > > > that we're using.  Also, the benchmarking on this initially seems
> > > > > > comparable to ONLINE_EVENT.
> > > > > >
> > > > > > There's also the fact that it's a lot less code than
> ONLINE_EVENT,
> > > due
> > > > to
> > > > > > the whole state thing.  The main thing that ONLINE_EVENT has over
> > > > > > evaluateJavascript is that it works on Jellybean (4.3 and lower).
> > > > > >
> > > > > > This branch does add a method to the API, and Crosswalk would
> have
> > to
> > > > add
> > > > > > the same two lines of code to their WebView to allow
> > > evaluateJavascript
> > > > > to
> > > > > > work there as well as it does here.  I did check to make sure
> their
> > > API
> > > > > > does support it before I added it.
> > > > > >
> > > > > > So, is this useful? Should we merge it in? Do we increment a
> major
> > > > > version
> > > > > > number for this?
> > > > > >
> > > > > > Joe
> > > > > >
> > > > >
> > > >
> > >
> >
>

[GitHub] cordova-plugin-camera pull request: [iOS] Major refactor

[omefire]

Github user omefire commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r55746231
  
--- Diff: src/ios/CDVCamera.m ---
@@ -145,9 +198,38 @@ - (void)takePicture:(CDVInvokedUrlCommand*)command
 [self.commandDelegate runInBackground:^{
--- End diff --

Never mind, I see it below.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [iOS] Major refactor

[omefire]

Github user omefire commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r55746150
  
--- Diff: src/ios/CDVCamera.m ---
@@ -145,9 +198,38 @@ - (void)takePicture:(CDVInvokedUrlCommand*)command
 [self.commandDelegate runInBackground:^{
 
 CDVPictureOptions* pictureOptions = [CDVPictureOptions 
createFromTakePictureArguments:command];
+
+/*
+ FIXME #1
+ What to do about quality?
+ If the option is set and the image is retrieved from the 
PhotoLibrary or SavedAlbum with a NATIVE_URI, no editing,
+ and is not saved to the photo album, then we return the "wrong" 
image.
+ However, the doc says "quality of the **saved** image", so it 
might be fine.
+ */
+/*
+ FIXME #2
+ The doc says: "Rotate the image to correct for the orientation of 
the device **during capture**."
+ Is capture <=> sourceType == CAMERA ?
+ */
+// Check for option compatibility
+BOOL isDestinationNativeUri = (pictureOptions.destinationType == 
DestinationTypeNativeUri);
+
+BOOL needsResize = [self needsResize:pictureOptions];
+BOOL needsOrientationCorrection = 
pictureOptions.correctOrientation;
+BOOL isSourceCamera = (pictureOptions.sourceType == 
UIImagePickerControllerSourceTypeCamera);
+BOOL allowsEditing = pictureOptions.allowsEditing;
+BOOL needsSavingToPhotoAlbum = (needsResize || 
needsOrientationCorrection || allowsEditing);
+
+// if one wants an edited image and a NATIVE_URI, the edited image 
must be in the assets library therefore one must set the saveToPhotoAlbum 
option to true.
+if (!pictureOptions.saveToPhotoAlbum && isDestinationNativeUri && 
needsSavingToPhotoAlbum) {
+NSLog(@"Incompatible options, cannot return native URI if 
image is not in the assets library");
--- End diff --

+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [iOS] Major refactor

[omefire]

Github user omefire commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r55746051
  
--- Diff: src/ios/CDVCamera.m ---
@@ -145,9 +198,38 @@ - (void)takePicture:(CDVInvokedUrlCommand*)command
 [self.commandDelegate runInBackground:^{
 
 CDVPictureOptions* pictureOptions = [CDVPictureOptions 
createFromTakePictureArguments:command];
+
+/*
+ FIXME #1
+ What to do about quality?
+ If the option is set and the image is retrieved from the 
PhotoLibrary or SavedAlbum with a NATIVE_URI, no editing,
+ and is not saved to the photo album, then we return the "wrong" 
image.
+ However, the doc says "quality of the **saved** image", so it 
might be fine.
+ */
+/*
+ FIXME #2
+ The doc says: "Rotate the image to correct for the orientation of 
the device **during capture**."
+ Is capture <=> sourceType == CAMERA ?
+ */
+// Check for option compatibility
+BOOL isDestinationNativeUri = (pictureOptions.destinationType == 
DestinationTypeNativeUri);
+
+BOOL needsResize = [self needsResize:pictureOptions];
--- End diff --

Please, change 'selft' => 'weakSelf". possible retain cycle.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: [iOS] Major refactor

[omefire]

Github user omefire commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r55745359
  
--- Diff: src/ios/CDVCamera.m ---
@@ -145,9 +198,38 @@ - (void)takePicture:(CDVInvokedUrlCommand*)command
 [self.commandDelegate runInBackground:^{
--- End diff --

We used to carry check whether the camera/photoAlbum/sourceType was 
available, can we put it back?

https://github.com/apache/cordova-plugin-camera/blob/master/src/ios/CDVCamera.m#L152


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [Android] New Bridge: evaluateJavascript

[Simon MacDonald]

I think we are okay bumping the minor for this change not the major.

I'm in favour of this bridge as long as we don't need to guard all the code
with reflection. Using reflection to call evaluateJavascript would negate
any performance bonus. So if we can use evaluateJavascript on Android 4.4
and above and then revert to LoadUrl on Android 4.3 and earlier for this
bridge I say we go for it.

I think we can give CrossWalk enough time so this doesn't completely screw
them over. Also, if we give them a heads up they can make it so the plugin
only installs on Cordova Android 5.1.1 and earlier.


Simon Mac Donald
http://hi.im/simonmacdonald

On Thu, Mar 10, 2016 at 2:51 PM, Joe Bowser  wrote:

> On Thu, Mar 10, 2016 at 11:48 AM, Carlos Santana 
> wrote:
>
> > I don't think we need to bump major number, there is no public API brake
> >
> >
> This isn't a private API.  This API is how third parties like Intel can
> make things like Crosswalk.
>
>
> > we are just added a feature, old stuff will still work.
> >
>
> Except that Crosswalk now has to implement evaluateJavascript on their
> XWalkEngine class.  At least this won't need a crap ton of reflection code
> like the last API change.
>
>
> >
> > On Thu, Mar 10, 2016 at 2:41 PM Joe Bowser  wrote:
> >
> > > Well, since the problem is with ONLINE_EVENT having a race condition,
> > > earlier versions of Android would have to use the slower LOAD_URL with
> > > known issues related to the input fields.  There's more testing that
> > needs
> > > to be done, obviously, but it's worth adding the third bridge in the
> next
> > > major release.
> > >
> > > I'm just wondering how people feel about bumping another version.  I
> > don't
> > > think our users understand that we use semver at all, which makes
> things
> > > extremely frustrating.
> > >
> > >
> > >
> > > On Thu, Mar 10, 2016 at 11:30 AM, Carlos Santana  >
> > > wrote:
> > >
> > > > But what about 4.3 and lower versions of Android? How do we support
> > them?
> > > > Do we use ONLINE_EVENT if we detect were are running on those
> versions
> > of
> > > > Android?
> > > >
> > > >
> > > > On Thu, Mar 10, 2016 at 1:36 PM Joe Bowser 
> wrote:
> > > >
> > > > > So, apparently some people are reporting that the ONLINE_EVENT
> bridge
> > > > that
> > > > > we currently use by default in Android has a race condition when
> you
> > > > start
> > > > > using more than one WebView in an application.  Even though we
> > decided
> > > to
> > > > > not support the case of having multiple webviews in an Application,
> > > it's
> > > > > still being used this way.
> > > > >
> > > > > Ideally, I would like to see us figure out how we can change the
> > bridge
> > > > > modes so that we don't have so many static classes, or at least
> > change
> > > > them
> > > > > such that we're not tracing mutable states in static classes.
> > However,
> > > > > someone asked about evaluateJavascript and using that for the
> bridge.
> > > I
> > > > > implemented that really quick here:
> > > > >
> > > > > https://github.com/infil00p/cordova-android/tree/building_bridges
> > > > >
> > > > > Basically, this should get around the whole bridge state problem
> > since
> > > > > we're executing the JS on the right webview every time instead of
> > > trying
> > > > to
> > > > > manipulate a static variable that may or may not correspond to the
> > > > webview
> > > > > that we're using.  Also, the benchmarking on this initially seems
> > > > > comparable to ONLINE_EVENT.
> > > > >
> > > > > There's also the fact that it's a lot less code than ONLINE_EVENT,
> > due
> > > to
> > > > > the whole state thing.  The main thing that ONLINE_EVENT has over
> > > > > evaluateJavascript is that it works on Jellybean (4.3 and lower).
> > > > >
> > > > > This branch does add a method to the API, and Crosswalk would have
> to
> > > add
> > > > > the same two lines of code to their WebView to allow
> > evaluateJavascript
> > > > to
> > > > > work there as well as it does here.  I did check to make sure their
> > API
> > > > > does support it before I added it.
> > > > >
> > > > > So, is this useful? Should we merge it in? Do we increment a major
> > > > version
> > > > > number for this?
> > > > >
> > > > > Joe
> > > > >
> > > >
> > >
> >
>

FYI: new Apache Help Wanted site

[Shazron]

https://helpwanted.apache.org/

We could populate some tasks there and put the widget on our homepage somewhere.

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Adding DATA_URL warnings to RE...

[riknoll]

GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/193

Adding DATA_URL warnings to README

Adding clearer warning messages to the README about DATA_URL, because that 
option provides us with a steady stream of JIRAs.

@nikhilkh please take a look

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-camera DATA_URL

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/193.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #193






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] another problem with in-call status bar on iOS (inAppBrowser)

[Shazron]

Apache mailserver has stripped your post of images, so we can't see
anything. My point in listening for that delegate function is so we don't
rely on the hardcoded 20.

On Thu, Mar 10, 2016 at 7:40 AM, julio cesar sanchez  wrote:

> But the problem here is not when the frame changes, is when the toolbar
> used as a fake statusbar is created when the in-call statusbar is present.
>
> If inAppBrowser is opened with toolbar on top while in-call statusbar is
> present. See the gray bar between in-call statusbar and inAppBrowser
> toolbar. And the webview has 20 points behind the in-call statusbar, notice
> that the house icon is partially hidden.
>
> [image: Imágenes integradas 10]
>
> And it remains when the in-call statusbar disappears.
>
> [image: Imágenes integradas 9]
>
> If toolbar is at the bottom the only issue is the one I mentioned before,
> the webview has 20 points behind the toolbar (house icon hidden)
>
> [image: Imágenes integradas 7][image: Imágenes integradas 8]
>
> Hardcoding the height of the toolbar used as a fake statusbar to be always
> 20.0 the problem disappears.
>
> [image: Imágenes integradas 1][image: Imágenes integradas 2][image:
> Imágenes integradas 4][image: Imágenes integradas 3]
>
>
> Listening the statusbar size changes will only solve the problems when the
> in-call statusbar hides, as the height is 20 again, but when it shows it
> will be 40 and will create the problems mentioned earlier.
>
>
>
> 2016-03-08 2:44 GMT+01:00 Shazron :
>
>> We should leave this be, we can fix and think about it when its
>> actually a problem.
>>
>> Ideally, it should listen to (UIApplicationDelegate):
>>application:willChangeStatusBarFrame:
>>application:didChangeStatusBarFrame:
>>
>> ... for the actual status bar frame changes.
>>
>>
>> On Mon, Mar 7, 2016 at 1:42 AM, julio cesar sanchez
>>  wrote:
>> > I've been looking into this issue
>> > https://issues.apache.org/jira/browse/CB-10799
>> >
>> > The problem is that the inAppBrowser creates a "fake" statusbar using a
>> > toolbar so the statusbar seems opaque. That toolbar is created with the
>> > size of the statusbar, and when the in-call statusbar is present it's 40
>> > points instead of 20 points, and when the in-call statusbar is present,
>> the
>> > app is pushed 20 points down so we see the remaining 20 points of that
>> > toolbar.
>> >
>> > Hardcoding it to 20 points in a few places fix the issue, but there is a
>> > comment on the code
>> >
>> >
>> > *The height of it could be hardcoded as 20 pixels, but that would assume
>> > that the upcoming releases of iOS won't change that value.*
>> >
>> > So what can we do? hardcode it and hope it doesn't change in the future?
>> > Any other idea to fix this without hardcoding?
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
>> For additional commands, e-mail: dev-h...@cordova.apache.org
>>
>>
>

Re: [Android] New Bridge: evaluateJavascript

[Carlos Santana]

I don't think we need to bump major number, there is no public API brake

we are just added a feature, old stuff will still work.

On Thu, Mar 10, 2016 at 2:41 PM Joe Bowser  wrote:

> Well, since the problem is with ONLINE_EVENT having a race condition,
> earlier versions of Android would have to use the slower LOAD_URL with
> known issues related to the input fields.  There's more testing that needs
> to be done, obviously, but it's worth adding the third bridge in the next
> major release.
>
> I'm just wondering how people feel about bumping another version.  I don't
> think our users understand that we use semver at all, which makes things
> extremely frustrating.
>
>
>
> On Thu, Mar 10, 2016 at 11:30 AM, Carlos Santana 
> wrote:
>
> > But what about 4.3 and lower versions of Android? How do we support them?
> > Do we use ONLINE_EVENT if we detect were are running on those versions of
> > Android?
> >
> >
> > On Thu, Mar 10, 2016 at 1:36 PM Joe Bowser  wrote:
> >
> > > So, apparently some people are reporting that the ONLINE_EVENT bridge
> > that
> > > we currently use by default in Android has a race condition when you
> > start
> > > using more than one WebView in an application.  Even though we decided
> to
> > > not support the case of having multiple webviews in an Application,
> it's
> > > still being used this way.
> > >
> > > Ideally, I would like to see us figure out how we can change the bridge
> > > modes so that we don't have so many static classes, or at least change
> > them
> > > such that we're not tracing mutable states in static classes.  However,
> > > someone asked about evaluateJavascript and using that for the bridge.
> I
> > > implemented that really quick here:
> > >
> > > https://github.com/infil00p/cordova-android/tree/building_bridges
> > >
> > > Basically, this should get around the whole bridge state problem since
> > > we're executing the JS on the right webview every time instead of
> trying
> > to
> > > manipulate a static variable that may or may not correspond to the
> > webview
> > > that we're using.  Also, the benchmarking on this initially seems
> > > comparable to ONLINE_EVENT.
> > >
> > > There's also the fact that it's a lot less code than ONLINE_EVENT, due
> to
> > > the whole state thing.  The main thing that ONLINE_EVENT has over
> > > evaluateJavascript is that it works on Jellybean (4.3 and lower).
> > >
> > > This branch does add a method to the API, and Crosswalk would have to
> add
> > > the same two lines of code to their WebView to allow evaluateJavascript
> > to
> > > work there as well as it does here.  I did check to make sure their API
> > > does support it before I added it.
> > >
> > > So, is this useful? Should we merge it in? Do we increment a major
> > version
> > > number for this?
> > >
> > > Joe
> > >
> >
>

Re: [Android] New Bridge: evaluateJavascript

[Joe Bowser]

Well, since the problem is with ONLINE_EVENT having a race condition,
earlier versions of Android would have to use the slower LOAD_URL with
known issues related to the input fields.  There's more testing that needs
to be done, obviously, but it's worth adding the third bridge in the next
major release.

I'm just wondering how people feel about bumping another version.  I don't
think our users understand that we use semver at all, which makes things
extremely frustrating.



On Thu, Mar 10, 2016 at 11:30 AM, Carlos Santana 
wrote:

> But what about 4.3 and lower versions of Android? How do we support them?
> Do we use ONLINE_EVENT if we detect were are running on those versions of
> Android?
>
>
> On Thu, Mar 10, 2016 at 1:36 PM Joe Bowser  wrote:
>
> > So, apparently some people are reporting that the ONLINE_EVENT bridge
> that
> > we currently use by default in Android has a race condition when you
> start
> > using more than one WebView in an application.  Even though we decided to
> > not support the case of having multiple webviews in an Application, it's
> > still being used this way.
> >
> > Ideally, I would like to see us figure out how we can change the bridge
> > modes so that we don't have so many static classes, or at least change
> them
> > such that we're not tracing mutable states in static classes.  However,
> > someone asked about evaluateJavascript and using that for the bridge.  I
> > implemented that really quick here:
> >
> > https://github.com/infil00p/cordova-android/tree/building_bridges
> >
> > Basically, this should get around the whole bridge state problem since
> > we're executing the JS on the right webview every time instead of trying
> to
> > manipulate a static variable that may or may not correspond to the
> webview
> > that we're using.  Also, the benchmarking on this initially seems
> > comparable to ONLINE_EVENT.
> >
> > There's also the fact that it's a lot less code than ONLINE_EVENT, due to
> > the whole state thing.  The main thing that ONLINE_EVENT has over
> > evaluateJavascript is that it works on Jellybean (4.3 and lower).
> >
> > This branch does add a method to the API, and Crosswalk would have to add
> > the same two lines of code to their WebView to allow evaluateJavascript
> to
> > work there as well as it does here.  I did check to make sure their API
> > does support it before I added it.
> >
> > So, is this useful? Should we merge it in? Do we increment a major
> version
> > number for this?
> >
> > Joe
> >
>

Re: [Android] New Bridge: evaluateJavascript

[Carlos Santana]

But what about 4.3 and lower versions of Android? How do we support them?
Do we use ONLINE_EVENT if we detect were are running on those versions of
Android?


On Thu, Mar 10, 2016 at 1:36 PM Joe Bowser  wrote:

> So, apparently some people are reporting that the ONLINE_EVENT bridge that
> we currently use by default in Android has a race condition when you start
> using more than one WebView in an application.  Even though we decided to
> not support the case of having multiple webviews in an Application, it's
> still being used this way.
>
> Ideally, I would like to see us figure out how we can change the bridge
> modes so that we don't have so many static classes, or at least change them
> such that we're not tracing mutable states in static classes.  However,
> someone asked about evaluateJavascript and using that for the bridge.  I
> implemented that really quick here:
>
> https://github.com/infil00p/cordova-android/tree/building_bridges
>
> Basically, this should get around the whole bridge state problem since
> we're executing the JS on the right webview every time instead of trying to
> manipulate a static variable that may or may not correspond to the webview
> that we're using.  Also, the benchmarking on this initially seems
> comparable to ONLINE_EVENT.
>
> There's also the fact that it's a lot less code than ONLINE_EVENT, due to
> the whole state thing.  The main thing that ONLINE_EVENT has over
> evaluateJavascript is that it works on Jellybean (4.3 and lower).
>
> This branch does add a method to the API, and Crosswalk would have to add
> the same two lines of code to their WebView to allow evaluateJavascript to
> work there as well as it does here.  I did check to make sure their API
> does support it before I added it.
>
> So, is this useful? Should we merge it in? Do we increment a major version
> number for this?
>
> Joe
>

[GitHub] cordova-plugin-file pull request: CB-10577: Windows resolveLocalFi...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-file/pull/169


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: CB-10577: Windows resolveLocalFi...

[riknoll]

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/169#issuecomment-195004006
  
LGTM. Tested on windows phone 8.1 emulator and Windows 10


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: CB-7862: FileReader reads large ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-file/pull/168


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: Prevent edited image to replac...

[t-nonque]

GitHub user t-nonque opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/192

Prevent edited image to replace the previous one



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/t-nonque/cordova-plugin-camera patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/192.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #192


commit 43e60d6e29773cd62a50e11a502e1ca1818de189
Author: Thomas Nonque 
Date:   2016-03-10T18:44:53Z

Prevent edited image to replace the previous one




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Fix syntax highlighting within the Andr...

[nikhilkh]

Github user nikhilkh commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/549#discussion_r55727012
  
--- Diff: www/docs/en/dev/guide/platforms/android/plugin.md ---
@@ -284,72 +302,87 @@ documentation [here][permissions-guide].
 
 As far as a plugin is concerned, the permission can be requested by 
calling the permission method, which signature is as follows:
 
-cordova.requestPermission(CordovaPlugin plugin, int requestCode, 
String permission);
+```java
+cordova.requestPermission(CordovaPlugin plugin, int requestCode, String 
permission);
+```
 
 To cut down on verbosity, it's standard practice to assign this to a local 
static variable:
 
-public static final String READ = Manifest.permission.READ_CONTACTS;
+```
--- End diff --

Good catch - missed it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-cli pull request: CB-10679: Documenting how the CLI choose...

[riknoll]

GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-cli/pull/241

CB-10679: Documenting how the CLI chooses plugin versions

Now in the README! Note that this relies on the documentation in 
https://github.com/apache/cordova-docs/pull/521 being merged.

@nikhilkh @dblotsky please take a look.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-cli CB-10679redo

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-cli/pull/241.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #241


commit 1a8be501d31aeba99d56fd3280c39693941a99fb
Author: Richard Knoll 
Date:   2016-03-10T18:32:14Z

CB-10679: Documenting how the CLI chooses plugin versions




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[Android] New Bridge: evaluateJavascript

[Joe Bowser]

So, apparently some people are reporting that the ONLINE_EVENT bridge that
we currently use by default in Android has a race condition when you start
using more than one WebView in an application.  Even though we decided to
not support the case of having multiple webviews in an Application, it's
still being used this way.

Ideally, I would like to see us figure out how we can change the bridge
modes so that we don't have so many static classes, or at least change them
such that we're not tracing mutable states in static classes.  However,
someone asked about evaluateJavascript and using that for the bridge.  I
implemented that really quick here:

https://github.com/infil00p/cordova-android/tree/building_bridges

Basically, this should get around the whole bridge state problem since
we're executing the JS on the right webview every time instead of trying to
manipulate a static variable that may or may not correspond to the webview
that we're using.  Also, the benchmarking on this initially seems
comparable to ONLINE_EVENT.

There's also the fact that it's a lot less code than ONLINE_EVENT, due to
the whole state thing.  The main thing that ONLINE_EVENT has over
evaluateJavascript is that it works on Jellybean (4.3 and lower).

This branch does add a method to the API, and Crosswalk would have to add
the same two lines of code to their WebView to allow evaluateJavascript to
work there as well as it does here.  I did check to make sure their API
does support it before I added it.

So, is this useful? Should we merge it in? Do we increment a major version
number for this?

Joe

[GitHub] cordova-docs pull request: Fix syntax highlighting within the Andr...

[riknoll]

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/549#discussion_r55724956
  
--- Diff: www/docs/en/dev/guide/platforms/android/plugin.md ---
@@ -284,72 +302,87 @@ documentation [here][permissions-guide].
 
 As far as a plugin is concerned, the permission can be requested by 
calling the permission method, which signature is as follows:
 
-cordova.requestPermission(CordovaPlugin plugin, int requestCode, 
String permission);
+```java
+cordova.requestPermission(CordovaPlugin plugin, int requestCode, String 
permission);
+```
 
 To cut down on verbosity, it's standard practice to assign this to a local 
static variable:
 
-public static final String READ = Manifest.permission.READ_CONTACTS;
+```
--- End diff --

Why not tag these as Java?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: [CB-10600] 'cordova run --release' u...

[dpolivy]

GitHub user dpolivy opened a pull request:

https://github.com/apache/cordova-android/pull/273

[CB-10600] 'cordova run --release' uses wrong apk

When doing `cordova run android --release`, the CLI attempts to use the
android-release-unsigned.apk, which naturally fails to install on the
device because it is unsigned. The release build does also generate the
properly signed android-release.apk, and that should be used instead.

The apk-finding logic for "debug" excludes unsigned builds, so the
"release" logic should follow a similar pattern.

Fixes https://issues.apache.org/jira/browse/CB-10600

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dpolivy/cordova-android CB10600

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/273.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #273


commit c788355ab1cb6234441166bbc92ca7b5c6c4c52b
Author: Dan Polivy 
Date:   2016-03-10T18:05:52Z

[CB-10600] 'cordova run --release' uses wrong apk

When doing `cordova run android --release`, the CLI attempts to use the
android-release-unsigned.apk, which naturally fails to install on the
device because it is unsigned. The release build does also generate the
properly signed android-release.apk, and that should be used instead.

The apk-finding logic for "debug" excludes unsigned builds, so the
"release" logic should follow a similar pattern.

Fixes https://issues.apache.org/jira/browse/CB-10600




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10838 Use logger from cordova-com...

[nikhilkh]

Github user nikhilkh commented on the pull request:

https://github.com/apache/cordova-windows/pull/158#issuecomment-194969878
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: fix issue with app_name containing a...

[revolunet]

Github user revolunet commented on the pull request:

https://github.com/apache/cordova-android/pull/272#issuecomment-194966222
  
tried to add a unit test for this but i need guidance


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: fix issue with app_name containing a...

[revolunet]

GitHub user revolunet opened a pull request:

https://github.com/apache/cordova-android/pull/272

fix issue with app_name containing apostrophes

When the app name has an apostrophe defined in config.xml, this cause an 
issue on Android when building

cordova build android result :

```
:processDebugManifest UP-TO-DATE

:processDebugResources/Users/juju/Documents/projects/synchronized/test-cordova/cordova/platforms/android/build/intermediates/res/merged/debug/values/values.xml:4
 : AAPT: Apostrophe not preceded by \ (in L'HelloCordova)

 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':processDebugResources'.
> com.android.ide.common.process.ProcessException: 
org.gradle.process.internal.ExecException: Process 'command 
'/Applications/android-sdk-macosx/build-tools/20.0.0/aapt'' finished with 
non-zero exit value 1

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or 
--debug option to get more log output.

BUILD FAILED

Total time: 2.967 secs
ERROR building one of the platforms: Error code 1 for command: 
/Users/juju/Documents/projects/synchronized/test-cordova/cordova/platforms/android/gradlew
 with args: 
cdvBuildDebug,-b,/Users/juju/Documents/projects/synchronized/test-cordova/cordova/platforms/android/build.gradle,-Dorg.gradle.daemon=true,-Pandroid.useDeprecatedNdk=true
You may not have the required environment or OS to build this project
Error: Error code 1 for command: 
/Users/juju/Documents/projects/synchronized/test-cordova/cordova/platforms/android/gradlew
 with args: 
cdvBuildDebug,-b,/Users/juju/Documents/projects/synchronized/test-cordova/cordova/platforms/android/build.gradle,-Dorg.gradle.daemon=true,-Pandroid.useDeprecatedNdk=true
```

This fix just escape the apostrophe on Android so it can build


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/revolunet/cordova-android 
fix-appname-apostrophe

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/272.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #272


commit ea66012901a842e4bdda110ecfa073592a628829
Author: Julien Bouquillon 
Date:   2016-03-10T17:17:42Z

fix issue with app_name containing apostrophes




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-10562 hide() not work...

[nikhilkh]

Github user nikhilkh commented on the pull request:


https://github.com/apache/cordova-plugin-splashscreen/pull/91#issuecomment-194966042
  
Can we add test cases for this area? Looks like we regressed behavior here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [VOTE] Plugins Release camera@2.1.1 globalization@1.0.3 splashscreen@3.2.1 statusbar@2.1.2

[Edna Y Morales]

+1


* Ran mobilespec plugin tests (ios)
* Verified that hello world app be can built and run with plugins (ios)
* Verified tags with 'coho verify-tags'

Thanks,
Edna Morales



From:   "Alexander Sorokin (Akvelon)" 
To: "dev@cordova.apache.org" 
Date:   03/10/2016 05:20 AM
Subject:RE: [VOTE] Plugins Release camera@2.1.1 globalization@1.0.3
splashscreen@3.2.1 statusbar@2.1.2



I vote +1.

* Verified signatures and hashes
* Verified tags
* Verified that plugins can be added correctly to blank app
* Verified that blank app can be successfully built and ran (windows and
android)
* Verified that browserified app can be successfully built and ran (windows
and android)
* Ran smoke testing of mobilespec app (windows and android)
* Verified release notes

-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com]
Sent: Thursday, March 10, 2016 6:59 AM
To: dev@cordova.apache.org
Subject: [VOTE] Plugins Release camera@2.1.1 globalization@1.0.3
splashscreen@3.2.1 statusbar@2.1.2

Please review and vote on the release of this plugins release by replying
to this email (and keep discussion on the DISCUSS thread)

Release issue:
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10820=01%7c01%7cv-alsoro%40microsoft.com%7c3bb1f1c33f834014cb0308d348985372%7c72f988bf86f141af91ab2d7cd011db47%7c1=KzCVERC8MyeVLeVpWIcRSl7gTsv524%2fdYEr%2bi8t1450%3d


The plugins have been published to dist/dev:
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist.apache.org%2frepos%2fdist%2fdev%2fcordova%2fCB-10820%2f=01%7c01%7cv-alsoro%40microsoft.com%7c3bb1f1c33f834014cb0308d348985372%7c72f988bf86f141af91ab2d7cd011db47%7c1=NA3rwF0RFbHpxo9nxYHPAwKggnKk3d5ORuKcL%2bAwkas%3d


The packages were published from their corresponding git tags:
cordova-plugin-camera: 2.1.1 (37dd471d0e)
cordova-plugin-statusbar: 2.1.2 (f1aa062557)
cordova-plugin-globalization: 1.0.3 (37c3e61e12)
cordova-plugin-splashscreen: 3.2.1 (e877722bac)

Upon a successful vote I will upload the archives to dist/, upload them to
the Plugins Registry, and post the corresponding blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies
have Apache-compatible licenses
* Ran mobilespec with new plugins

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Blog post for Plugin release 03 12

[csantanapr]

Github user csantanapr commented on the pull request:

https://github.com/apache/cordova-docs/pull/550#issuecomment-194888965
  
@dpogue weird I didn't catch this I was using VSCode preview and they 
looked fine, it could a difference in markdown with Github, I fixed, thanks for 
the review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Blog post for Plugin release 03 12

[csantanapr]

Github user csantanapr commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/550#discussion_r55690550
  
--- Diff: www/_posts/2016-03-12-plugin-release.md ---
@@ -0,0 +1,74 @@
+---
+layout: post
+author:
+name: Carlos Santana
+url: https://twitter.com/csantanapr
+title:  "Plugins Release"
+categories: news
+tags: release plugins
+---
+
+The following plugins were updated today:
+
+* cordova-plugin-camera@2.1.1
+* cordova-plugin-statusbar@2.1.2
+* cordova-plugin-globalization@1.0.3
+* cordova-plugin-splashscreen@3.2.1
+
+
+
+You can update any plugin by removing it, and then re-adding it.
+
+ E.g. To update your media plugin:
+
+cordova plugin rm cordova-plugin-camera --save
+cordova plugin add cordova-plugin-camera@2.1.1 --save
+
+Changes include:
+
+
+cordova-plugin-camera@2.1.1
+* [CB-10825](https://issues.apache.org/jira/browse/CB-10825) android: 
Always request READ permission for gallery source
--- End diff --

@dpogue weird I didn't catch this I was using VSCode preview and they 
looked fine, it could a difference in markdown with Github, I fixed, thanks for 
the review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10679: Improving version choosing log...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/406


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10791 Add adjustLoggerLevel to cordov...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/405


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-splashscreen pull request: CB-10562 hide() not work...

[daserge]

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-plugin-splashscreen/pull/91

CB-10562 hide() not working in latest splashscreen plug in 3.1.0 in iOS

[Jira issue](https://issues.apache.org/jira/browse/CB-10562)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-splashscreen 
CB-10562

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-splashscreen/pull/91.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #91


commit ee5be0413e2e2300cb0e8ed58ad13898cd18d968
Author: daserge 
Date:   2016-03-10T12:38:32Z

CB-10562 hide() not working in latest splashscreen plug in 3.1.0 in iOS




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: CB-10838 Use logger from cordova-com...

[vladimir-kotikov]

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-windows/pull/158

CB-10838 Use logger from cordova-common

This implements https://issues.apache.org/jira/browse/CB-10838

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-windows CB-10838

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-windows/pull/158.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #158


commit 166ec9ad34760b50699da3bd2ae3af277fefe5a2
Author: Vladimir Kotikov 
Date:   2016-03-10T12:37:11Z

CB-10838 Upgrade cordova-common to 1.1.0

commit f8958213983bc1b80b85e2c5de85e4238d7b172c
Author: Vladimir Kotikov 
Date:   2016-03-10T13:10:08Z

CB-10838 Use logger from cordova-common




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Edit to Edit on Github for Docs

[Dmitry Blotsky]

Hey Robert,

What do you mean by the “Edit” button being documented?

Also folks: here is a PR with a change addressing this discussion and a bit 
more: https://github.com/apache/cordova-docs/pull/551/files.

Kindly,
Dmitry

On Mar 9, 2016, at 2:19 PM, Robert Posener 
> wrote:

Also, can we add "Edit on GitHub" to Blog and Plugin pages, please.

Regards
*Rob Posener*
0419 012 627

On 10 March 2016 at 09:14, Robert Posener 
> wrote:

I like "Edit on GitHub".

I was never sure how far into "editing" clicking on the "Edit" button
would take me before I hit some roadblock (like needing to be a committer,
like having a GitHub login, like being part of the cordova in-crowd, etc)
that meant that I had wasted my time.  It would be nice to clarify this
(eg, a hover tip like "No login necessary - Will be queued for review by
committers").
Also... where is the "Edit" button documented?

Rob

Regards
*Rob Posener*
0419 012 627

On 9 March 2016 at 10:29, Dmitry Blotsky 
> wrote:

I don't know if we have A/B testing capabilities, but I'm cool with
changing the text to "Edit on GitHub". Also, we have like 10 open PRs for
docs from contributors, so the buttons definitely work. :)

I'll make the change for "Edit on GitHub" unless someone objects.

Kindly,
Dmitry

-Original Message-
From: Jesse [mailto:purplecabb...@gmail.com]
Sent: Tuesday, March 8, 2016 11:26 AM
To: dev@cordova.apache.org
Subject: Re: Edit to Edit on Github for Docs

+1 to AB testing!


On Mar 8, 2016, at 11:02 AM, Steven Gill 
>
wrote:

Look at us talking UX. Lets do some AB testing while we are at ;)

On Tue, Mar 8, 2016 at 10:54 AM, Nikhil Khandelwal
>
wrote:

+1 for trying "Edit on Github" - anything that _may_ increase
contributions to the docs is welcome. :)

-Nikhil

-Original Message-
From: Shazron [mailto:shaz...@gmail.com]
Sent: Tuesday, March 8, 2016 10:26 AM
To: dev@cordova.apache.org
Subject: Re: Edit to Edit on Github for Docs

I'm ambivalent. "Edit" is concise, and I would think most are curious
enough to just click and see?

On Tue, Mar 8, 2016 at 8:50 AM, Carlos Santana 
>
wrote:
The other day I was looking like crazy the doc source code that
corresponded to the page that a user was asking here in dev list
where was the source code, so I assume he also didn't see the "Edit"

Then someone pointed out there is an "Edit" link/button at the top
right side of each page.

Then I saw another website, can't remember now, but they had "Edit
on Github" and having the "on Github" capture my attention.

What you guys think about change it from "Edit" to "Edit on Github"
is that a good change or it's just me

-
To unsubscribe, e-mail: 
dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: 
dev-h...@cordova.apache.org


-
To unsubscribe, e-mail: 
dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: 
dev-h...@cordova.apache.org


-
To unsubscribe, e-mail: 
dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: 
dev-h...@cordova.apache.org


-
To unsubscribe, e-mail: 
dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: 
dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: CB-10836 Improving "Edit" links

[dblotsky]

GitHub user dblotsky opened a pull request:

https://github.com/apache/cordova-docs/pull/551

CB-10836 Improving "Edit" links

# Changes

- Added links to Crowdin translation on appropriate pages
- Changed "Edit" links for translated content to point to English sources
- Changed "Edit" links for current content to point to /dev/ sources
- Changed all other "Edit" links point to their respective files

# Examples (the resulting link is at the top of each example)

### DEV ENGLISH

https://cloud.githubusercontent.com/assets/405489/13669630/a6fe0446-e679-11e5-83c7-eb7f7d28d28b.png;>

### LATEST ENGLISH

https://cloud.githubusercontent.com/assets/405489/13669640/ac9c2b9e-e679-11e5-9d78-502c43f898a3.png;>

### OLD ENGLISH

https://cloud.githubusercontent.com/assets/405489/13669642/b08e2db0-e679-11e5-9690-a447006e3843.png;>

### DEV FRENCH SOURCE

https://cloud.githubusercontent.com/assets/405489/13669649/b7e62a18-e679-11e5-97a2-fadf5006ec39.png;>

### DEV FRENCH TRANSLATION

https://cloud.githubusercontent.com/assets/405489/13669651/ba4bcefc-e679-11e5-8361-6300e931e066.png;>

### LATEST FRENCH SOURCE

https://cloud.githubusercontent.com/assets/405489/13669655/be5548ac-e679-11e5-8a32-fc372e130335.png;>

### LATEST FRENCH TRANSLATION

https://cloud.githubusercontent.com/assets/405489/13669659/c17f6cf6-e679-11e5-8e1a-be5338e44eef.png;>

### OLD FRENCH

https://cloud.githubusercontent.com/assets/405489/13669662/c41645de-e679-11e5-86e8-a59d35160841.png;>


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-docs CB-10836

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/551.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #551


commit f3b61eed30900737e9a083e183079ee54ddc3932
Author: Dmitry Blotsky 
Date:   2016-03-10T12:11:27Z

CB-10836 Adding translation links and making 'Edit' links point to correct 
edit locations.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10822 Manage plugins/modules metadata...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-lib/pull/408#issuecomment-194806460
  
The related changes for cordova android can be found here: 
https://github.com/apache/cordova-android/compare/master...MSOpenTech:CB-10822?expand=1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10822 Manage plugins/modules metadata...

[vladimir-kotikov]

Github user vladimir-kotikov commented on the pull request:

https://github.com/apache/cordova-lib/pull/408#issuecomment-194804304
  

https://github.com/apache/cordova-lib/commit/317cfdb374b9dfa215de77c617db0c373dc098c6
 is seen here due to ASF git and Github is out of sync.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10822 Manage plugins/modules metadata...

[vladimir-kotikov]

GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-lib/pull/408

CB-10822 Manage plugins/modules metadata using PlatformJson

JIRA https://issues.apache.org/jira/browse/CB-10822

This PR adds brings logic for storing and generating plugin metadata into 
PlatformJson class. The logic is fairly similar for all platforms and relies on 
PlatformJson as a storage.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-lib CB-10822

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/408.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #408


commit 317cfdb374b9dfa215de77c617db0c373dc098c6
Author: riknoll 
Date:   2016-03-08T00:10:22Z

CB-10679: Improving version choosing logic test coverage

This closes #406

commit ca4f68bae3c4bdefab984855804d9cc72612abaa
Author: Vladimir Kotikov 
Date:   2016-03-10T11:03:11Z

CB-10822 Manage plugins/modules metadata using PlatformJson




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request: New feature 'styleAndroidTr...

[aegliv]

GitHub user aegliv opened a pull request:

https://github.com/apache/cordova-plugin-statusbar/pull/51

New feature 'styleAndroidTranslucent'

Replaces the need for following plugin: ekuwang / cordova-plugin-statusbar

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aegliv/cordova-plugin-statusbar 
styleAndroidTranslucent

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-statusbar/pull/51.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #51


commit ccacb8bf76e45d486152b96726c0afa9d0ff5bdb
Author: aegliv 
Date:   2016-03-10T11:14:47Z

Added new feature 'styleAndroidTranslucent'




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [VOTE] Plugins Release camera@2.1.1 globalization@1.0.3 splashscreen@3.2.1 statusbar@2.1.2

[Alexander Sorokin (Akvelon)]

I vote +1.

* Verified signatures and hashes
* Verified tags
* Verified that plugins can be added correctly to blank app
* Verified that blank app can be successfully built and ran (windows and 
android)
* Verified that browserified app can be successfully built and ran (windows and 
android)
* Ran smoke testing of mobilespec app (windows and android)
* Verified release notes

-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com] 
Sent: Thursday, March 10, 2016 6:59 AM
To: dev@cordova.apache.org
Subject: [VOTE] Plugins Release camera@2.1.1 globalization@1.0.3 
splashscreen@3.2.1 statusbar@2.1.2

Please review and vote on the release of this plugins release by replying to 
this email (and keep discussion on the DISCUSS thread)

Release issue: 
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10820=01%7c01%7cv-alsoro%40microsoft.com%7c3bb1f1c33f834014cb0308d348985372%7c72f988bf86f141af91ab2d7cd011db47%7c1=KzCVERC8MyeVLeVpWIcRSl7gTsv524%2fdYEr%2bi8t1450%3d

The plugins have been published to dist/dev:
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist.apache.org%2frepos%2fdist%2fdev%2fcordova%2fCB-10820%2f=01%7c01%7cv-alsoro%40microsoft.com%7c3bb1f1c33f834014cb0308d348985372%7c72f988bf86f141af91ab2d7cd011db47%7c1=NA3rwF0RFbHpxo9nxYHPAwKggnKk3d5ORuKcL%2bAwkas%3d

The packages were published from their corresponding git tags:
cordova-plugin-camera: 2.1.1 (37dd471d0e)
cordova-plugin-statusbar: 2.1.2 (f1aa062557)
cordova-plugin-globalization: 1.0.3 (37c3e61e12)
cordova-plugin-splashscreen: 3.2.1 (e877722bac)

Upon a successful vote I will upload the archives to dist/, upload them to the 
Plugins Registry, and post the corresponding blog post.

Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md

Voting will go on for a minimum of 48 hours.

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies have 
Apache-compatible licenses
* Ran mobilespec with new plugins

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org