Re: [DISCUSS] Plugins release
At least this 3 have changes: cordova-plugin-inappbrowser cordova-plugin-statusbar cordova-plugin-dialogs If this can wait, I want to add a small change on dialogs plugin this afternoon. I have another change almost ready for the inappbrowser, but might take a while, so I can add it for the next release. 2016-04-05 19:59 GMT+02:00 Simon MacDonald : > Hey all, > > I'd like to start the ball rolling for a new plugin release. I've done the > necessary changes to remove the need to copy PermissionHelper.java into > every new Cordova Android Plugin. Now these plugins depend on > cordova-plugin-compat to provide that class. > > It would mean new minor versions of: > >- cordova-plugin-camera >- cordova-plugin-contacts >- cordova-plugin-file >- cordova-plugin-geolocation >- cordova-plugin-media >- cordova-plugin-media-capture >- cordova-plugin-compat > > Check out the background as to why were are doing this in this thread: > > http://markmail.org/message/cmmxrxqftlktkccg#query:+page:1+mid:e6dooljwv2l6orig+state:results > > Are there any objections towards moving to a new plugin release? Are there > other plugins that need to be bumped? > > > Simon Mac Donald > http://hi.im/simonmacdonald >
[GitHub] cordova-docs pull request: Adding both Chinese versions.
Github user dblotsky closed the pull request at: https://github.com/apache/cordova-docs/pull/569 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: CB-10985 Android sets type t...
Github user tobiasmuecksch commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/116#issuecomment-206258396 Well that might fix the -1 issue. But the android version of this plugin behaves very differently from the ios Version. The iOS Version returns the custom label (if there is one set) for the type. Android simply returns "Custom". I don't think that's intended. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: CB-10985 Android sets type t...
Github user tobiasmuecksch commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/116#issuecomment-206265136 I've openend an Issue on that: https://issues.apache.org/jira/browse/CB-11028 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-ios pull request: CB-11019 Handle app name change more acc...
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-ios/pull/213 CB-11019 Handle app name change more accurately This PR fixes potential bug in 'prepare' functionality, when changing application name (which assumes renaming of some folders inside of platform directory) does not update project's directories locations properly. Also, the `projectFile` cache needs to be invalidated because it could contain instance that refers the old paths. See [CB-11019](https://issues.apache.org/jira/browse/CB-11019) for more details You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-ios CB-11019 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-ios/pull/213.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #213 commit 070ef3b0dd145780d639a16dfca21ce0a503706a Author: Vladimir Kotikov Date: 2016-04-05T14:41:10Z CB-11019 Handle changes of app name gracefully commit f71dbc3726b6ddabaa7330e61f56e766d7f5aa22 Author: Vladimir Kotikov Date: 2016-04-06T10:28:39Z CB-11019 Update tests to validate project name updates --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-paramedic pull request: Paramedic improvements
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r58688217
--- Diff: paramedic-plugin/paramedic.js ---
@@ -0,0 +1,74 @@
+var io = cordova.require('cordova-plugin-paramedic.socket.io');
--- End diff --
This is cordovaRequire (paramedic.js is plugin script, not a node module )
which works slightly different.
The _require("socket.io")_ and _require("./socket.io")_ won't work in this
case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-paramedic pull request: Paramedic improvements
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r58692216
--- Diff: lib/LocalServer.js ---
@@ -0,0 +1,122 @@
+var Q = require('q'),
--- End diff --
Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-paramedic pull request: Paramedic improvements
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r58692210
--- Diff: lib/paramedic.js ---
@@ -0,0 +1,205 @@
+#!/usr/bin/env node
+
+var exec = require('./utils').exec,
+shell = require('shelljs'),
+Server = require('./LocalServer'),
+Q = require('q'),
+tmp = require('tmp'),
+PluginsManager = require('./PluginsManager'),
+path = require('path'),
+Q = require('q'),
+fs = require('fs'),
+getReporters = require('./Reporters'),
+logger = require('./utils').logger;
+
+function ParamedicRunner(config, _callback) {
+this.tempFolder = null;
+this.pluginsManager = null;
+
+this.config = config;
+
+exec.setVerboseLevel(config.isVerbose());
+}
+
+ParamedicRunner.prototype.run = function() {
+var self = this;
+
+return Q().then(function() {
+self.createTempProject();
+self.prepareProjectToRunTests();
+return Server.startServer(self.config.getPorts(),
self.config.getExternalServerUrl(), self.config.getUseTunnel());
+})
+.then(function(server) {
+self.server = server;
+
+self.injectReporters();
+self.subcribeForEvents();
+
+var connectionUrl = server.getConnectionUrl() ||
+
server.getStandartUrlForPlatform(self.config.getPlatformId());
+self.writeMedicConnectionUrl(connectionUrl);
+
+return self.runTests();
+})
+.fin(function() {
+self.cleanUpProject();
+});
+};
+
+ParamedicRunner.prototype.createTempProject = function() {
+this.tempFolder = tmp.dirSync();
+tmp.setGracefulCleanup();
+logger.info("cordova-paramedic: creating temp project at " +
this.tempFolder.name);
+exec('cordova create ' + this.tempFolder.name);
+shell.pushd(this.tempFolder.name);
+};
+
+ParamedicRunner.prototype.prepareProjectToRunTests = function() {
+this.installPlugins();
+this.setUpStartPage();
+this.installPlatform();
+this.checkPlatformRequirements();
+};
+
+ParamedicRunner.prototype.installPlugins = function() {
+logger.info("cordova-paramedic: installing plugins");
+this.pluginsManager = new PluginsManager(this.tempFolder.name,
this.storedCWD);
+this.pluginsManager.installPlugins(this.config.getPlugins());
+this.pluginsManager.installTestsForExistingPlugins();
+
this.pluginsManager.installSinglePlugin('cordova-plugin-test-framework');
+this.pluginsManager.installSinglePlugin('cordova-plugin-device');
+this.pluginsManager.installSinglePlugin(path.join(__dirname,
'../paramedic-plugin'));
+};
+
+ParamedicRunner.prototype.setUpStartPage = function() {
+logger.normal("cordova-paramedic: setting app start page to test
page");
+shell.sed('-i', 'src="index.html"', 'src="cdvtests/index.html"',
'config.xml');
+};
+
+ParamedicRunner.prototype.installPlatform = function() {
+logger.normal("cordova-paramedic: adding platform : " +
this.config.getPlatform());
+exec('cordova platform add ' + this.config.getPlatform());
+};
+
+ParamedicRunner.prototype.checkPlatformRequirements = function() {
+logger.normal("cordova-paramedic: checking requirements for platform "
+ this.config.getPlatformId());
+var result = exec('cordova requirements ' +
this.config.getPlatformId());
+
+if (result.code !== 0)
+throw new Error('Platform requirements check has failed!');
+};
+
+ParamedicRunner.prototype.injectReporters = function() {
+var self = this;
+var reporters = getReporters(self.config.getReportSavePath());
+
+['jasmineStarted', 'specStarted', 'specDone',
+'suiteStarted', 'suiteDone', 'jasmineDone'].forEach(function(route) {
+reporters.forEach(function(reporter) {
+if (reporter[route] instanceof Function)
+self.server.on(route, reporter[route].bind(reporter));
+});
+});
+};
+
+ParamedicRunner.prototype.subcribeForEvents = function() {
+this.server.on('deviceLog', function(data) {
+logger.verbose('device|console.' + data.type + ': ' +
data.msg[0]);
+});
+
+this.server.on('deviceInfo', function(data) {
+logger.info('cordova-paramedic: Device info: ' +
JSON.stringify(data));
+});
+};
+
+ParamedicRunner.prototype.writeMedicConnectionUrl = function(url) {
+logger.normal("cordova-paramedic: writing medic log url to project " +
url);
+fs.writeFileSync(path.join("www","medic.json"),
JSON.stringify({logurl:url}));
+};
[GitHub] cordova-lib pull request: CB-10975 Allow plugin path to be relativ...
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/421 CB-10975 Allow plugin path to be relative to current directory JIRA: [CB-10975](https://issues.apache.org/jira/browse/CB-10975) You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-10975 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/421.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #421 commit 1ae162fbc7960e9eb3ceb438d372c15a41567afa Author: Vladimir Kotikov Date: 2016-04-06T12:43:12Z CB-10975 Allow plugin path to be relative to current directory --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-10964 build.js script under "plat...
GitHub user daserge opened a pull request: https://github.com/apache/cordova-android/pull/286 CB-10964 build.js script under "platforms\android\cordova\lib" can no⦠â¦t handle build.json file starting with a BOM [Jira issue](https://issues.apache.org/jira/browse/CB-10964) You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-android CB-10964 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/286.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #286 commit e08ba99f40799882bd0d03be62bdf2ceaba2e356 Author: daserge Date: 2016-04-06T13:36:43Z CB-10964 build.js script under "platforms\android\cordova\lib" can not handle build.json file starting with a BOM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: CB-10862 Cannot set minsdkversion
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-android/pull/284#issuecomment-206418145 Another scenario where we need a test case - perhaps an end-to-end one - thoughts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: trigger file upload dialog aut...
GitHub user robertarnesson opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/200 trigger file upload dialog automatically on browser platform When using getPicture with source Camera.PictureSourceType.PHOTOLIBRARY on browser platform, a file upload input field is inserted into the DOM. This change hides the input field and triggers the file upload window when getPicture() is called, making the process super smooth and seamless You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertarnesson/cordova-plugin-camera master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-camera/pull/200.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #200 commit 49faaaf0f571dbd363ca271e9bde5ae6c8e866f0 Author: Robert Arnesson Date: 2016-04-06T15:49:24Z trigger file upload dialog automatically on browser platform --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/101 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [DISCUSS] Plugins release
Yeah, it can wait. It's just something I would like to get in to reduce code duplication. I'm also working on CB-10776 as well. Simon Mac Donald http://hi.im/simonmacdonald On Wed, Apr 6, 2016 at 4:11 AM, julio cesar sanchez wrote: > At least this 3 have changes: > > cordova-plugin-inappbrowser > cordova-plugin-statusbar > cordova-plugin-dialogs > > If this can wait, I want to add a small change on dialogs plugin this > afternoon. > > I have another change almost ready for the inappbrowser, but might take a > while, so I can add it for the next release. > > > > 2016-04-05 19:59 GMT+02:00 Simon MacDonald : > > > Hey all, > > > > I'd like to start the ball rolling for a new plugin release. I've done > the > > necessary changes to remove the need to copy PermissionHelper.java into > > every new Cordova Android Plugin. Now these plugins depend on > > cordova-plugin-compat to provide that class. > > > > It would mean new minor versions of: > > > >- cordova-plugin-camera > >- cordova-plugin-contacts > >- cordova-plugin-file > >- cordova-plugin-geolocation > >- cordova-plugin-media > >- cordova-plugin-media-capture > >- cordova-plugin-compat > > > > Check out the background as to why were are doing this in this thread: > > > > > http://markmail.org/message/cmmxrxqftlktkccg#query:+page:1+mid:e6dooljwv2l6orig+state:results > > > > Are there any objections towards moving to a new plugin release? Are > there > > other plugins that need to be bumped? > > > > > > Simon Mac Donald > > http://hi.im/simonmacdonald > > >
[GitHub] cordova-docs pull request: CB-11021 Changing docs styling
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/567#issuecomment-206459071 @dblotsky Is there a reason this suddenly has 1,634 changed files? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9434: Adding a ToDO. 'cordova run' sh...
Github user omefire closed the pull request at: https://github.com/apache/cordova-lib/pull/280 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: Remove logging
Github user omefire commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/117#issuecomment-206471960 @sarangan12 errors fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Revert "CB-10881: Logging to further...
GitHub user omefire opened a pull request: https://github.com/apache/cordova-android/pull/287 Revert "CB-10881: Logging to further investigations" This reverts commit 1b43bc99a1c50e5ab30347ec9ca5af8cf22d3e85. You can merge this pull request into a Git repository by running: $ git pull https://github.com/omefire/cordova-android CB-10881 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/287.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #287 commit 0deaba0920e6daec67dac29b9cb953336edfe175 Author: Omar Mefire Date: 2016-04-06T17:21:40Z Revert "CB-10881: Logging to further investigations" This reverts commit 1b43bc99a1c50e5ab30347ec9ca5af8cf22d3e85. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-android pull request: Revert "CB-10881: Logging to further...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/287 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: Remove logging
Github user sarangan12 commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/117#issuecomment-206509564 Lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: Remove logging
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/117 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-paramedic pull request: Paramedic improvements
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r58771547
--- Diff: lib/LocalServer.js ---
@@ -0,0 +1,141 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var Q = require('q'),
+io = require('socket.io'),
+logger = require('./utils').logger,
+exec = require('./utils').exec,
+path = require('path'),
+util = require('util'),
+portChecker = require('tcp-port-used'),
+EventEmitter = require('events').EventEmitter;
+
+function LocalServer(port, externalServerUrl) {
+this.port = port;
+this.externalServerUrl = externalServerUrl;
+}
+
+util.inherits(LocalServer, EventEmitter);
+
+LocalServer.startServer = function(ports, externalServerUrl, useTunnel) {
+logger.normal("local-server: scanning ports from " + ports.start + "
to " + ports.end);
+
+return LocalServer.getFirstAvailablePort(ports.start, ports.end)
+.then(function(port) {
+logger.normal("local-server: port " + port + " is available");
+logger.info("local-server: starting local medic server");
+
+var localServer = new LocalServer(port, externalServerUrl);
+localServer.createSocketListener();
+
+if (useTunnel) {
+return Q.promise(function(resolve) {
+localServer.createTunnel().then(function(){
+resolve(localServer);
+});
+});
+}
+
+return localServer;
+});
+};
+
+LocalServer.getFirstAvailablePort = function(startPort, endPort) {
+var ports = Array.apply(null, Array(endPort - startPort +
1)).map(function(element, index) {
+return startPort + index;
+});
+
+return Q.promise(function(resolve, reject) {
+ports.reduce(function(promise, port){
+return promise.then(function(isPortUsed) {
+if (!isPortUsed) {
+resolve(port - 1);
+return false;
+} else {
+return portChecker.check(port);
+}
+});
+}, Q(true));
+});
+};
+
+LocalServer.prototype.createTunnel = function() {
+logger.info('cordova-paramedic: attempt to create local tunnel');
+var self = this;
+
+//TODO: use localtunnel module instead of shell
+return Q.Promise(function(resolve, reject) {
+exec(path.resolve(__dirname, '../node_modules/.bin/lt') + ' --port
' + self.port, null, function(output) {
+var tunneledUrl = output.split(' ')[3];
+self.tunneledUrl = tunneledUrl;
+logger.info('cordova-paramedic: using tunneled url ' +
tunneledUrl);
+resolve();
+});
+});
+};
+
+LocalServer.prototype.createSocketListener = function() {
+var listener = io.listen(this.port, {
+pingTimeout: 6, // how many ms without a pong packet to
consider the connection closed
+pingInterval: 25000 // how many ms before sending a new ping packet
--- End diff --
Please factor these values out into comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-paramedic pull request: Paramedic improvements
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r58771505
--- Diff: lib/LocalServer.js ---
@@ -0,0 +1,141 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var Q = require('q'),
+io = require('socket.io'),
+logger = require('./utils').logger,
+exec = require('./utils').exec,
+path = require('path'),
+util = require('util'),
+portChecker = require('tcp-port-used'),
+EventEmitter = require('events').EventEmitter;
+
+function LocalServer(port, externalServerUrl) {
+this.port = port;
+this.externalServerUrl = externalServerUrl;
+}
+
+util.inherits(LocalServer, EventEmitter);
+
+LocalServer.startServer = function(ports, externalServerUrl, useTunnel) {
+logger.normal("local-server: scanning ports from " + ports.start + "
to " + ports.end);
+
+return LocalServer.getFirstAvailablePort(ports.start, ports.end)
+.then(function(port) {
+logger.normal("local-server: port " + port + " is available");
+logger.info("local-server: starting local medic server");
+
+var localServer = new LocalServer(port, externalServerUrl);
+localServer.createSocketListener();
+
+if (useTunnel) {
+return Q.promise(function(resolve) {
+localServer.createTunnel().then(function(){
+resolve(localServer);
+});
+});
+}
+
+return localServer;
+});
+};
+
+LocalServer.getFirstAvailablePort = function(startPort, endPort) {
+var ports = Array.apply(null, Array(endPort - startPort +
1)).map(function(element, index) {
+return startPort + index;
+});
+
+return Q.promise(function(resolve, reject) {
+ports.reduce(function(promise, port){
+return promise.then(function(isPortUsed) {
+if (!isPortUsed) {
+resolve(port - 1);
+return false;
+} else {
+return portChecker.check(port);
+}
+});
+}, Q(true));
+});
+};
+
+LocalServer.prototype.createTunnel = function() {
+logger.info('cordova-paramedic: attempt to create local tunnel');
+var self = this;
+
+//TODO: use localtunnel module instead of shell
--- End diff --
Is this a big change? Would it be feasible to resolve it in this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-paramedic pull request: Paramedic improvements
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r58771737
--- Diff: lib/LocalServer.js ---
@@ -0,0 +1,141 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var Q = require('q'),
+io = require('socket.io'),
+logger = require('./utils').logger,
+exec = require('./utils').exec,
+path = require('path'),
+util = require('util'),
+portChecker = require('tcp-port-used'),
+EventEmitter = require('events').EventEmitter;
+
+function LocalServer(port, externalServerUrl) {
+this.port = port;
+this.externalServerUrl = externalServerUrl;
+}
+
+util.inherits(LocalServer, EventEmitter);
+
+LocalServer.startServer = function(ports, externalServerUrl, useTunnel) {
+logger.normal("local-server: scanning ports from " + ports.start + "
to " + ports.end);
+
+return LocalServer.getFirstAvailablePort(ports.start, ports.end)
+.then(function(port) {
+logger.normal("local-server: port " + port + " is available");
+logger.info("local-server: starting local medic server");
+
+var localServer = new LocalServer(port, externalServerUrl);
+localServer.createSocketListener();
+
+if (useTunnel) {
+return Q.promise(function(resolve) {
+localServer.createTunnel().then(function(){
+resolve(localServer);
+});
+});
+}
+
+return localServer;
+});
+};
+
+LocalServer.getFirstAvailablePort = function(startPort, endPort) {
+var ports = Array.apply(null, Array(endPort - startPort +
1)).map(function(element, index) {
+return startPort + index;
+});
+
+return Q.promise(function(resolve, reject) {
+ports.reduce(function(promise, port){
+return promise.then(function(isPortUsed) {
+if (!isPortUsed) {
+resolve(port - 1);
+return false;
+} else {
+return portChecker.check(port);
+}
+});
+}, Q(true));
+});
+};
+
+LocalServer.prototype.createTunnel = function() {
+logger.info('cordova-paramedic: attempt to create local tunnel');
+var self = this;
+
+//TODO: use localtunnel module instead of shell
+return Q.Promise(function(resolve, reject) {
+exec(path.resolve(__dirname, '../node_modules/.bin/lt') + ' --port
' + self.port, null, function(output) {
+var tunneledUrl = output.split(' ')[3];
+self.tunneledUrl = tunneledUrl;
+logger.info('cordova-paramedic: using tunneled url ' +
tunneledUrl);
+resolve();
+});
+});
+};
+
+LocalServer.prototype.createSocketListener = function() {
+var listener = io.listen(this.port, {
+pingTimeout: 6, // how many ms without a pong packet to
consider the connection closed
+pingInterval: 25000 // how many ms before sending a new ping packet
+});
+
+var self = this;
+
+listener.on('connection', function(socket) {
+logger.info('local-server: new socket connection');
+self.connection = socket;
+
+// server methods
+['deviceLog', 'disconnect', 'deviceInfo',
+'jasmineStarted', 'specStarted', 'specDone',
+'suiteStarted', 'suiteDone',
'jasmineDone'].forEach(function(route) {
+socket.on(route, function(data) {
+self.emit(route, data);
+});
+});
+});
+};
+
+LocalServer.prototype.getConnectionUrl = function() {
+return this.tunneledUrl ||
+ (this.externalServerUrl ? this.ext
[GitHub] cordova-plugin-dialogs pull request: CB-10097 dialog doesn't show ...
GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/70 CB-10097 dialog doesn't show on iOS when called from a select list onChange event Changed getTopPresentedViewController to not set the presentingViewController to a ViewController that is being dismissed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jcesarmobile/cordova-plugin-dialogs CB-10097-cordova-plugin-dialogs-ios Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-dialogs/pull/70.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #70 commit 1485667c80cbc34da5cf69df174290502eb79b66 Author: Julio César Date: 2016-04-06T20:42:25Z CB-10097 dialog doesn't show on iOS when called from a select list onChange event Changed getTopPresentedViewController to not set the presentingViewController to a ViewController that is being dismissed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: CB-10097 dialog doesn't show ...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/70 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: On iOS8+ allow this dialog to...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/57 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-paramedic pull request: Paramedic improvements
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r58785033
--- Diff: lib/paramedic.js ---
@@ -0,0 +1,232 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var exec = require('./utils').exec,
+shell = require('shelljs'),
+Server = require('./LocalServer'),
+Q = require('q'),
+tmp = require('tmp'),
+PluginsManager = require('./PluginsManager'),
+path = require('path'),
+Q = require('q'),
+fs = require('fs'),
+getReporters = require('./Reporters'),
+logger = require('./utils').logger;
+
+// Time to wait for initial device connection.
+// If device has not connected within this interval the tests are stopped.
+var INITIAL_CONNECTION_TIMEOUT = 30; // 5mins
+
+function ParamedicRunner(config, _callback) {
+this.tempFolder = null;
+this.pluginsManager = null;
+
+this.config = config;
+
+exec.setVerboseLevel(config.isVerbose());
+}
+
+ParamedicRunner.prototype.run = function() {
+var self = this;
+
+return Q().then(function() {
+self.createTempProject();
+self.prepareProjectToRunTests();
+return Server.startServer(self.config.getPorts(),
self.config.getExternalServerUrl(), self.config.getUseTunnel());
+})
+.then(function(server) {
+self.server = server;
+
+self.injectReporters();
+self.subcribeForEvents();
+
+var connectionUrl = server.getConnectionUrl() ||
+
server.getStandartUrlForPlatform(self.config.getPlatformId());
+self.writeMedicConnectionUrl(connectionUrl);
+
+return self.runTests();
+})
+.fin(function() {
+self.cleanUpProject();
+});
+};
+
+ParamedicRunner.prototype.createTempProject = function() {
+this.tempFolder = tmp.dirSync();
+tmp.setGracefulCleanup();
+logger.info("cordova-paramedic: creating temp project at " +
this.tempFolder.name);
+exec('cordova create ' + this.tempFolder.name);
+shell.pushd(this.tempFolder.name);
+};
+
+ParamedicRunner.prototype.prepareProjectToRunTests = function() {
+this.installPlugins();
+this.setUpStartPage();
+this.installPlatform();
+this.checkPlatformRequirements();
+};
+
+ParamedicRunner.prototype.installPlugins = function() {
+logger.info("cordova-paramedic: installing plugins");
+this.pluginsManager = new PluginsManager(this.tempFolder.name,
this.storedCWD);
+this.pluginsManager.installPlugins(this.config.getPlugins());
+this.pluginsManager.installTestsForExistingPlugins();
+
this.pluginsManager.installSinglePlugin('cordova-plugin-test-framework');
+this.pluginsManager.installSinglePlugin('cordova-plugin-device');
+this.pluginsManager.installSinglePlugin(path.join(__dirname,
'../paramedic-plugin'));
+};
+
+ParamedicRunner.prototype.setUpStartPage = function() {
+logger.normal("cordova-paramedic: setting app start page to test
page");
+shell.sed('-i', 'src="index.html"', 'src="cdvtests/index.html"',
'config.xml');
+};
+
+ParamedicRunner.prototype.installPlatform = function() {
+logger.info("cordova-paramedic: adding platform : " +
this.config.getPlatform());
+exec('cordova platform add ' + this.config.getPlatform());
+};
+
+ParamedicRunner.prototype.checkPlatformRequirements = function() {
+logger.normal("cordova-paramedic: checking requirements for platform "
+ this.config.getPlatformId());
+var result = exec('cordova requirements ' +
this.config.getPlatformId());
+
+if (result.code !== 0)
+throw new Error('Platform requirements check has failed!');
+};
+
+ParamedicRunner.prototype.injectReporters = function() {
+var self = this;
+var report
[GitHub] cordova-paramedic pull request: Paramedic improvements
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r58785263
--- Diff: lib/utils/execWrapper.js ---
@@ -0,0 +1,39 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var shelljs = require('shelljs');
+var verbose;
+
+function exec(cmd, onFinish, onData) {
+if (onFinish instanceof Function || onFinish === null) {
+var result = shelljs.exec(cmd, {async: true, silent: !verbose},
onFinish);
+
+if (onData instanceof Function) {
+result.stdout.on('data', onData);
+}
+} else {
+return shelljs.exec(cmd, {silent: !verbose});
+}
+}
+
+exec.setVerboseLevel = function(_verbose) {
+verbose = _verbose;
+};
+
+module.exports = exec;
--- End diff --
What purpose does the wrapper serve?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-paramedic pull request: Paramedic improvements
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r58785401
--- Diff: paramedic-plugin/paramedic.js ---
@@ -0,0 +1,93 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var io = cordova.require('cordova-plugin-paramedic.socket.io');
+
+var PARAMEDIC_SERVER_DEFAULT_URL = 'http://127.0.0.1:8008';
+
+function Paramedic() {
+
+}
+
+Paramedic.prototype.initialize = function() {
+var me = this;
+var connectionUri = loadParamedicServerUrl();
+this.socket = io.connect(connectionUri);
+
+this.socket.on('connect', function () {
+console.log("Paramedic has been susccessfully connected to
server");
+if (typeof device != 'undefined') me.socket.emit('deviceInfo',
device);
+});
+
+this.overrideConsole();
+this.injectJasmineReporter();
+};
+
+
+Paramedic.prototype.overrideConsole = function () {
+
+var origConsole = window.console;
+var me = this;
+
+function createCustomLogger(type) {
+return function () {
+origConsole[type].apply(origConsole, arguments);
+
+me.socket.emit('deviceLog', { type: type, msg:
Array.prototype.slice.apply(arguments) });
+};
+}
+window.console = {
+log: createCustomLogger('log'),
+warn: createCustomLogger('warn'),
+error: createCustomLogger('error'),
+};
+console.log('Paramedic console has been installed.');
+};
+
+Paramedic.prototype.injectJasmineReporter = function () {
+var JasmineParamedicProxy =
require('cordova-plugin-paramedic.JasmineParamedicProxy');
+var jasmineProxy = new JasmineParamedicProxy(this.socket);
+var testsModule =
cordova.require("cordova-plugin-test-framework.cdvtests");
+var defineAutoTestsOriginal = testsModule.defineAutoTests;
+
+testsModule.defineAutoTests = function () {
+defineAutoTestsOriginal();
+jasmine.getEnv().addReporter(jasmineProxy);
+};
+};
+
+new Paramedic().initialize();
+
+function loadParamedicServerUrl() {
+
+try {
+// attempt to synchronously load medic config
+var xhr = new XMLHttpRequest();
+xhr.open("GET", "../medic.json", false);
--- End diff --
Please factor out the string into a constant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-paramedic pull request: Paramedic improvements
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r58785566
--- Diff: paramedic-plugin/paramedic.js ---
@@ -0,0 +1,93 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var io = cordova.require('cordova-plugin-paramedic.socket.io');
+
+var PARAMEDIC_SERVER_DEFAULT_URL = 'http://127.0.0.1:8008';
+
+function Paramedic() {
+
+}
+
+Paramedic.prototype.initialize = function() {
+var me = this;
+var connectionUri = loadParamedicServerUrl();
+this.socket = io.connect(connectionUri);
+
+this.socket.on('connect', function () {
+console.log("Paramedic has been susccessfully connected to
server");
+if (typeof device != 'undefined') me.socket.emit('deviceInfo',
device);
+});
+
+this.overrideConsole();
+this.injectJasmineReporter();
+};
+
+
+Paramedic.prototype.overrideConsole = function () {
+
+var origConsole = window.console;
+var me = this;
+
+function createCustomLogger(type) {
+return function () {
+origConsole[type].apply(origConsole, arguments);
+
+me.socket.emit('deviceLog', { type: type, msg:
Array.prototype.slice.apply(arguments) });
+};
+}
+window.console = {
+log: createCustomLogger('log'),
+warn: createCustomLogger('warn'),
+error: createCustomLogger('error'),
+};
+console.log('Paramedic console has been installed.');
+};
+
+Paramedic.prototype.injectJasmineReporter = function () {
+var JasmineParamedicProxy =
require('cordova-plugin-paramedic.JasmineParamedicProxy');
+var jasmineProxy = new JasmineParamedicProxy(this.socket);
+var testsModule =
cordova.require("cordova-plugin-test-framework.cdvtests");
+var defineAutoTestsOriginal = testsModule.defineAutoTests;
+
+testsModule.defineAutoTests = function () {
+defineAutoTestsOriginal();
+jasmine.getEnv().addReporter(jasmineProxy);
+};
+};
+
+new Paramedic().initialize();
+
+function loadParamedicServerUrl() {
+
+try {
+// attempt to synchronously load medic config
+var xhr = new XMLHttpRequest();
+xhr.open("GET", "../medic.json", false);
+xhr.send(null);
+var cfg = JSON.parse(xhr.responseText);
+
+return cfg.logurl || PARAMEDIC_SERVER_DEFAULT_URL;
+
+} catch (ex) {}
--- End diff --
Please log the error here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-paramedic pull request: Paramedic improvements
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r58786335
--- Diff: lib/LocalServer.js ---
@@ -0,0 +1,141 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var Q = require('q'),
+io = require('socket.io'),
+logger = require('./utils').logger,
+exec = require('./utils').exec,
+path = require('path'),
+util = require('util'),
+portChecker = require('tcp-port-used'),
+EventEmitter = require('events').EventEmitter;
+
+function LocalServer(port, externalServerUrl) {
+this.port = port;
+this.externalServerUrl = externalServerUrl;
+}
+
+util.inherits(LocalServer, EventEmitter);
+
+LocalServer.startServer = function(ports, externalServerUrl, useTunnel) {
+logger.normal("local-server: scanning ports from " + ports.start + "
to " + ports.end);
+
+return LocalServer.getFirstAvailablePort(ports.start, ports.end)
+.then(function(port) {
+logger.normal("local-server: port " + port + " is available");
+logger.info("local-server: starting local medic server");
+
+var localServer = new LocalServer(port, externalServerUrl);
+localServer.createSocketListener();
+
+if (useTunnel) {
+return Q.promise(function(resolve) {
+localServer.createTunnel().then(function(){
+resolve(localServer);
+});
+});
--- End diff --
You can just return `localServer.createTunnel()` here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-paramedic pull request: Paramedic improvements
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r58786905
--- Diff: lib/LocalServer.js ---
@@ -0,0 +1,141 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var Q = require('q'),
+io = require('socket.io'),
+logger = require('./utils').logger,
+exec = require('./utils').exec,
+path = require('path'),
+util = require('util'),
+portChecker = require('tcp-port-used'),
+EventEmitter = require('events').EventEmitter;
+
+function LocalServer(port, externalServerUrl) {
+this.port = port;
+this.externalServerUrl = externalServerUrl;
+}
+
+util.inherits(LocalServer, EventEmitter);
+
+LocalServer.startServer = function(ports, externalServerUrl, useTunnel) {
+logger.normal("local-server: scanning ports from " + ports.start + "
to " + ports.end);
+
+return LocalServer.getFirstAvailablePort(ports.start, ports.end)
+.then(function(port) {
+logger.normal("local-server: port " + port + " is available");
+logger.info("local-server: starting local medic server");
+
+var localServer = new LocalServer(port, externalServerUrl);
+localServer.createSocketListener();
+
+if (useTunnel) {
+return Q.promise(function(resolve) {
+localServer.createTunnel().then(function(){
+resolve(localServer);
+});
+});
+}
+
+return localServer;
+});
+};
+
+LocalServer.getFirstAvailablePort = function(startPort, endPort) {
+var ports = Array.apply(null, Array(endPort - startPort +
1)).map(function(element, index) {
+return startPort + index;
+});
--- End diff --
Nitpick: it would be more readable to define a `range` function that
returns an array of numbers from `start` to `end` and to have `var ports =
range(startPort, endPort + 1)`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-paramedic pull request: Paramedic improvements
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/3#discussion_r58787128
--- Diff: lib/LocalServer.js ---
@@ -0,0 +1,141 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var Q = require('q'),
+io = require('socket.io'),
+logger = require('./utils').logger,
+exec = require('./utils').exec,
+path = require('path'),
+util = require('util'),
+portChecker = require('tcp-port-used'),
+EventEmitter = require('events').EventEmitter;
+
+function LocalServer(port, externalServerUrl) {
+this.port = port;
+this.externalServerUrl = externalServerUrl;
+}
+
+util.inherits(LocalServer, EventEmitter);
+
+LocalServer.startServer = function(ports, externalServerUrl, useTunnel) {
+logger.normal("local-server: scanning ports from " + ports.start + "
to " + ports.end);
+
+return LocalServer.getFirstAvailablePort(ports.start, ports.end)
+.then(function(port) {
+logger.normal("local-server: port " + port + " is available");
+logger.info("local-server: starting local medic server");
+
+var localServer = new LocalServer(port, externalServerUrl);
+localServer.createSocketListener();
+
+if (useTunnel) {
+return Q.promise(function(resolve) {
+localServer.createTunnel().then(function(){
+resolve(localServer);
+});
+});
+}
+
+return localServer;
+});
+};
+
+LocalServer.getFirstAvailablePort = function(startPort, endPort) {
+var ports = Array.apply(null, Array(endPort - startPort +
1)).map(function(element, index) {
+return startPort + index;
+});
+
+return Q.promise(function(resolve, reject) {
+ports.reduce(function(promise, port){
+return promise.then(function(isPortUsed) {
+if (!isPortUsed) {
+resolve(port - 1);
+return false;
+} else {
+return portChecker.check(port);
+}
+});
+}, Q(true));
+});
+};
+
+LocalServer.prototype.createTunnel = function() {
+logger.info('cordova-paramedic: attempt to create local tunnel');
+var self = this;
+
+//TODO: use localtunnel module instead of shell
+return Q.Promise(function(resolve, reject) {
+exec(path.resolve(__dirname, '../node_modules/.bin/lt') + ' --port
' + self.port, null, function(output) {
+var tunneledUrl = output.split(' ')[3];
+self.tunneledUrl = tunneledUrl;
+logger.info('cordova-paramedic: using tunneled url ' +
tunneledUrl);
+resolve();
+});
+});
+};
+
+LocalServer.prototype.createSocketListener = function() {
+var listener = io.listen(this.port, {
+pingTimeout: 6, // how many ms without a pong packet to
consider the connection closed
+pingInterval: 25000 // how many ms before sending a new ping packet
+});
+
+var self = this;
+
+listener.on('connection', function(socket) {
+logger.info('local-server: new socket connection');
+self.connection = socket;
+
+// server methods
+['deviceLog', 'disconnect', 'deviceInfo',
+'jasmineStarted', 'specStarted', 'specDone',
+'suiteStarted', 'suiteDone',
'jasmineDone'].forEach(function(route) {
+socket.on(route, function(data) {
+self.emit(route, data);
+});
+});
+});
+};
+
+LocalServer.prototype.getConnectionUrl = function() {
+return this.tunneledUrl ||
+ (this.externalServerUrl ? this.ext
RE: [VOTE] Cordova-windows 4.3.2 release
+1 * Tested blank app * Tested compatibility with core plugins * Ran mobilespec * Ran coho verify-tags * Verified builds are passing * Verified platform updates from previous version * Reviewed release notes -Raghav -Original Message- From: Alexander Sorokin (Akvelon) [mailto:v-als...@microsoft.com] Sent: Tuesday, April 5, 2016 8:31 AM To: dev@cordova.apache.org Subject: RE: [VOTE] Cordova-windows 4.3.2 release I vote +1. * Verified archives via `coho verify-archive` * Verified tags manually * Verified that blank app creates correctly with platform * Verified that blank app can be successfully built and ran * Verified that platform can be updated from previous version * Verified compatibility with core plugins (ran autotests for released and edge plugin versions) * Verified release notes * Verified version * Verified line breaks * Created the archive with coho and compared it to the release candidate Thanks, Alexander Sorokin -Original Message- From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] Sent: Tuesday, April 5, 2016 10:34 AM To: dev@cordova.apache.org Subject: [VOTE] Cordova-windows 4.3.2 release Please review and vote on this Cordova-windows 4.3.2 release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10999&data=01%7c01%7cv-alsoro%40microsoft.com%7c72a7856f193c44f728ff08d35d24a24b%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=O8CP4kfRbhrUI7DLs90V7yf7tzmOpzyWYGBlj2lY%2bSs%3d The archive has been published to dist/dev: https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist.apache.org%2frepos%2fdist%2fdev%2fcordova%2fCB-10999&data=01%7c01%7cv-alsoro%40microsoft.com%7c72a7856f193c44f728ff08d35d24a24b%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=a%2fL61GHgDnVviiFwLHN%2fiSMJA5D4EDKu6XBYYIu0I3Q%3d The package was published from its corresponding git tag: cordova-windows: 4.3.2 (0225b859fa) Note that you can test it out via: cordova platform add https://github.com/apache/cordova-windows#4.3.2 Upon a successful vote I will upload the archive to dist/, publish it to npm, and post the blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md Voting will go on for a minimum of 48 hours. I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ran platform tests * Ran mobilespec to ensure no tests failing * Created and ran blank app via both cli and platform scripts - Best regards, Vladimir - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[Android] Library Project/AAR alternatives to current plugin situation
Hey I recently looked at how native Android developers could use the current Cordova code with their projects, and I've noticed that there's some major problems with our current approach of just copying the Java classes into a project, such as resources getting merged together, and other related issues, so I created a project that instead uses the InAppBrowser source as an Android Library instead of just code thrown over the wall. The main advantage of this approach is that we can now build the library as an AAR and distribute the plugins and the platform using jcenter and mavenCentral and allow more Android developers to be able to use Cordova in their apps and make their apps more hybrid. Anyway, the example code is here. https://github.com/infil00p/Library-Dev-Project I used a Cordova application to demonstrate this, but I could have easily used a vanilla Android project. Hopefully this also allows for certain plugins like the InAppBrowser to be a lot more managable and will also allow us to add more unit tests to our projects. Any thoughts on this approach versus our current one?
[GitHub] cordova-ios pull request: CB-10962 CB-10945 removes justlaunch fla...
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/212#issuecomment-20663 Update (good news?): https://github.com/phonegap/ios-deploy/pull/218#issuecomment-206597622 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-11021 Changing docs styling
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/567#issuecomment-206601373 @riknoll yeah. The latest merge to the ASF Git master hasn't reflected in the GitHub master yet because it was a large commit. Sorry, the best way to see the diff for now is probably to check out the branch and do the diff locally. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [Android] Library Project/AAR alternatives to current plugin situation
Does this aligns in a similar way as how phonegap is recommending for iOS on using Cocoapods [1] to embed the Cordova WebView into an existing iOS App? Looking only from a Native Android developer eyes this will be the approach I would like if I have a pure native android app and for some reason I want to add a Cordova webview to a portion of my App. [1]: http://docs.phonegap.com/develop/1-embed-webview/ios/#pods On Wed, Apr 6, 2016 at 5:52 PM Joe Bowser wrote: > Hey > > I recently looked at how native Android developers could use the current > Cordova code with their projects, and I've noticed that there's some major > problems with our current approach of just copying the Java classes into a > project, such as resources getting merged together, and other related > issues, so I created a project that instead uses the InAppBrowser source as > an Android Library instead of just code thrown over the wall. > > The main advantage of this approach is that we can now build the library as > an AAR and distribute the plugins and the platform using jcenter and > mavenCentral and allow more Android developers to be able to use Cordova in > their apps and make their apps more hybrid. > > Anyway, the example code is here. > > https://github.com/infil00p/Library-Dev-Project > > I used a Cordova application to demonstrate this, but I could have easily > used a vanilla Android project. Hopefully this also allows for certain > plugins like the InAppBrowser to be a lot more managable and will also > allow us to add more unit tests to our projects. > > Any thoughts on this approach versus our current one? >
[GitHub] cordova-docs pull request: CB-11021 Changing docs styling
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/567 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [VOTE] Cordova-windows 4.3.2 release
+1 * Ran coho verify-archive * Ran coho audit-license-headers * Ran coho check-license * Created and ran blank app via cli @purplecabbage risingj.com On Wed, Apr 6, 2016 at 2:52 PM, Raghav Katyal wrote: > +1 > > * Tested blank app > * Tested compatibility with core plugins > * Ran mobilespec > * Ran coho verify-tags > * Verified builds are passing > * Verified platform updates from previous version > * Reviewed release notes > > -Raghav > > -Original Message- > From: Alexander Sorokin (Akvelon) [mailto:v-als...@microsoft.com] > Sent: Tuesday, April 5, 2016 8:31 AM > To: dev@cordova.apache.org > Subject: RE: [VOTE] Cordova-windows 4.3.2 release > > I vote +1. > > * Verified archives via `coho verify-archive` > * Verified tags manually > * Verified that blank app creates correctly with platform > * Verified that blank app can be successfully built and ran > * Verified that platform can be updated from previous version > * Verified compatibility with core plugins (ran autotests for released and > edge plugin versions) > * Verified release notes > * Verified version > * Verified line breaks > * Created the archive with coho and compared it to the release candidate > > Thanks, > Alexander Sorokin > > -Original Message- > From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] > Sent: Tuesday, April 5, 2016 10:34 AM > To: dev@cordova.apache.org > Subject: [VOTE] Cordova-windows 4.3.2 release > > Please review and vote on this Cordova-windows 4.3.2 release by replying > to this email (and keep discussion on the DISCUSS thread) > > Release issue: > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10999&data=01%7c01%7cv-alsoro%40microsoft.com%7c72a7856f193c44f728ff08d35d24a24b%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=O8CP4kfRbhrUI7DLs90V7yf7tzmOpzyWYGBlj2lY%2bSs%3d > The archive has been published to dist/dev: > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist.apache.org%2frepos%2fdist%2fdev%2fcordova%2fCB-10999&data=01%7c01%7cv-alsoro%40microsoft.com%7c72a7856f193c44f728ff08d35d24a24b%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=a%2fL61GHgDnVviiFwLHN%2fiSMJA5D4EDKu6XBYYIu0I3Q%3d > > The package was published from its corresponding git tag: > cordova-windows: 4.3.2 (0225b859fa) > > Note that you can test it out via: > cordova platform add https://github.com/apache/cordova-windows#4.3.2 > > Upon a successful vote I will upload the archive to dist/, publish it to > npm, and post the blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and subdependencies > have Apache-compatible licenses > * Ran platform tests > * Ran mobilespec to ensure no tests failing > * Created and ran blank app via both cli and platform scripts > > - > Best regards, Vladimir > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
Re: [Android] Library Project/AAR alternatives to current plugin situation
On Wed, Apr 6, 2016 at 4:08 PM, Carlos Santana wrote: > Does this aligns in a similar way as how phonegap is recommending for iOS > on using Cocoapods [1] to embed the Cordova WebView into an existing iOS > App? > Yes, except that I don't think it will be nearly as complex as the iOS approach is. > > Looking only from a Native Android developer eyes this will be the approach > I would like if I have a pure native android app and for some reason I want > to add a Cordova webview to a portion of my App. > > [1]: http://docs.phonegap.com/develop/1-embed-webview/ios/#pods > > > On Wed, Apr 6, 2016 at 5:52 PM Joe Bowser wrote: > > > Hey > > > > I recently looked at how native Android developers could use the current > > Cordova code with their projects, and I've noticed that there's some > major > > problems with our current approach of just copying the Java classes into > a > > project, such as resources getting merged together, and other related > > issues, so I created a project that instead uses the InAppBrowser source > as > > an Android Library instead of just code thrown over the wall. > > > > The main advantage of this approach is that we can now build the library > as > > an AAR and distribute the plugins and the platform using jcenter and > > mavenCentral and allow more Android developers to be able to use Cordova > in > > their apps and make their apps more hybrid. > > > > Anyway, the example code is here. > > > > https://github.com/infil00p/Library-Dev-Project > > > > I used a Cordova application to demonstrate this, but I could have easily > > used a vanilla Android project. Hopefully this also allows for certain > > plugins like the InAppBrowser to be a lot more managable and will also > > allow us to add more unit tests to our projects. > > > > Any thoughts on this approach versus our current one? > > >
New Docs Look
Check it out! http://cordova.apache.org/docs/
Re: [VOTE] 4.1.1 iOS Release - Take 2
+1 - Ran coho audit-license-headers - Ran coho check-license - Ran coho verify archive - Ran iOS native tests > Good signature from "Edna Morales" - Created and ran hello world iOS app with CLI @purplecabbage risingj.com On Tue, Apr 5, 2016 at 10:51 AM, Edna Y Morales wrote: > > > Please review and vote on this 4.1.1 iOS Release > by replying to this email (and keep discussion on the DISCUSS thread) > > Release issue: https://issues.apache.org/jira/browse/CB-11006 > > The archive has been published to dist/dev: > https://dist.apache.org/repos/dist/dev/cordova/CB-11006/ > > The package was published from its corresponding git tag: > cordova-ios: 4.1.1 (c5c33bad30) > > Note that you can test it out via: > > cordova platform add https://github.com/apache/cordova-ios#4.1.1 > > Upon a successful vote I will upload the archive to dist/, publish it to > npm, and post the blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and subdependencies > have Apache-compatible licenses > * Ensured continuous build was green when repo was tagged > * Ran mobile-spec (iOS) > * Created and ran hello world iOS app with CLI > * Created and ran hello world iOS app non-CLI > * Tested ./bin/create script > * Tested project upgrade from 4.1.0 to 4.1.1 with CLI > * Tested project upgrade from 4.1.0 to 4.1.1 non-CLI > * Ran cordova-lib tests > * Ran iOS native tests > * Ran coho verify-archive > > Thanks, > Edna Morales >
RE: [VOTE] Cordova-windows 4.3.2 release
The vote has now closed. The results are: Positive Binding Votes: 4 Vladimir Kotikov Alexander Sorokin Raghav Katyal Jesse MacFadyen The vote has passed. - Best regards, Vladimir -Original Message- From: Jesse [mailto:purplecabb...@gmail.com] Sent: Thursday, April 7, 2016 3:08 AM To: dev@cordova.apache.org Subject: Re: [VOTE] Cordova-windows 4.3.2 release +1 * Ran coho verify-archive * Ran coho audit-license-headers * Ran coho check-license * Created and ran blank app via cli @purplecabbage https://na01.safelinks.protection.outlook.com/?url=risingj.com&data=01%7c01%7cv-vlkoti%40microsoft.com%7c5c42a39a5e1e4fb76d5a08d35e78ba2d%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=yyepZeTUBhwlfTMbZFGkHqrCCT6QYgAFhFlHFQ9Xn%2b8%3d On Wed, Apr 6, 2016 at 2:52 PM, Raghav Katyal wrote: > +1 > > * Tested blank app > * Tested compatibility with core plugins > * Ran mobilespec > * Ran coho verify-tags > * Verified builds are passing > * Verified platform updates from previous version > * Reviewed release notes > > -Raghav > > -Original Message- > From: Alexander Sorokin (Akvelon) [mailto:v-als...@microsoft.com] > Sent: Tuesday, April 5, 2016 8:31 AM > To: dev@cordova.apache.org > Subject: RE: [VOTE] Cordova-windows 4.3.2 release > > I vote +1. > > * Verified archives via `coho verify-archive` > * Verified tags manually > * Verified that blank app creates correctly with platform > * Verified that blank app can be successfully built and ran > * Verified that platform can be updated from previous version > * Verified compatibility with core plugins (ran autotests for released > and edge plugin versions) > * Verified release notes > * Verified version > * Verified line breaks > * Created the archive with coho and compared it to the release > candidate > > Thanks, > Alexander Sorokin > > -Original Message- > From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] > Sent: Tuesday, April 5, 2016 10:34 AM > To: dev@cordova.apache.org > Subject: [VOTE] Cordova-windows 4.3.2 release > > Please review and vote on this Cordova-windows 4.3.2 release by > replying to this email (and keep discussion on the DISCUSS thread) > > Release issue: > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissue > s.apache.org%2fjira%2fbrowse%2fCB-10999&data=01%7c01%7cv-alsoro%40micr > osoft.com%7c72a7856f193c44f728ff08d35d24a24b%7c72f988bf86f141af91ab2d7 > cd011db47%7c1&sdata=O8CP4kfRbhrUI7DLs90V7yf7tzmOpzyWYGBlj2lY%2bSs%3d > The archive has been published to dist/dev: > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fdist. > apache.org%2frepos%2fdist%2fdev%2fcordova%2fCB-10999&data=01%7c01%7cv- > alsoro%40microsoft.com%7c72a7856f193c44f728ff08d35d24a24b%7c72f988bf86 > f141af91ab2d7cd011db47%7c1&sdata=a%2fL61GHgDnVviiFwLHN%2fiSMJA5D4EDKu6 > XBYYIu0I3Q%3d > > The package was published from its corresponding git tag: > cordova-windows: 4.3.2 (0225b859fa) > > Note that you can test it out via: > cordova platform add > https://github.com/apache/cordova-windows#4.3.2 > > Upon a successful vote I will upload the archive to dist/, publish it > to npm, and post the blog post. > > Voting guidelines: > https://github.com/apache/cordova-coho/blob/master/docs/release-voting > .md > > Voting will go on for a minimum of 48 hours. > > I vote +1: > * Ran coho audit-license-headers over the relevant repos > * Ran coho check-license to ensure all dependencies and > subdependencies have Apache-compatible licenses > * Ran platform tests > * Ran mobilespec to ensure no tests failing > * Created and ran blank app via both cli and platform scripts > > - > Best regards, Vladimir > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-docs pull request: CB-10999 Adds windows@4.3.2 release blo...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/572 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
