[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...
Github user androdel commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/94#issuecomment-215651859 But where is the fix for iOS? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Added FLAG_SECURE suppor...
GitHub user Alex-Sessler opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/164 Added FLAG_SECURE support I'm using this Plugin together with the Privacyscreen Plugin (https://github.com/devgeeks/PrivacyScreenPlugin), which sets the FLAG_SECURE on the main window, which disallows screenshots and makes sure a blank page is shown in the recent apps. When the IAB is open, the IAB Dialog needs to have those flags as well (when set on the main window). You can merge this pull request into a Git repository by running: $ git pull https://github.com/Alex-Sessler/cordova-plugin-inappbrowser flag_secure Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/164.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #164 commit 15e2a22e3c99ad065653252f8c1207edaefe26e6 Author: Alexander Sessler Date: 2016-04-29T10:25:46Z make sure FLAG_SECURE is respected when set on main window --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Added FLAG_SECURE suppor...
Github user devgeeks commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/164#issuecomment-215685335 Nice, I'll try to have a look at this as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: CB-3360: Set custom inap...
GitHub user cjpearson reopened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/94 CB-3360: Set custom inappbrowser user agent for ios This uses the same OverrideUserAgent and AppendUserAgent properties as the pull requests for cordova-ios and cordova-android. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-plugin-inappbrowser ios-user-agent Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-inappbrowser/pull/94.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #94 commit df2e82fb92be83e18dda5c9dd0a5604c58ff58d3 Author: Connor Pearson Date: 2015-03-13T17:52:30Z CB-3360: Set custom inappbrowser user agent for ios --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-11174 Resolve symlinked path before g...
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/433 CB-11174 Resolve symlinked path before getting PlatformApi instance This PR the issue when `getPlatformApi` method in cordova-lib returns a different instances for two paths pointing to the same destination, This also fixes 'npm test' failures on OS X. See JIRA [CB-11174](https://issues.apache.org/jira/browse/CB-11174) for background and details. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-11174 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/433.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #433 commit e2380dc0bb370980311a0001a738654046f36630 Author: Vladimir Kotikov Date: 2016-04-29T09:23:29Z CB-11174 Resolve symlinked path before getting PlatformApi instance --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: help with "npm test" for cordova-lib
Done. Please see PR [1] and JIRA [2]
This happens due to some caching issues with `getPlatformApi` method which
doesn't respect symlinked paths.
The reason why tests are not failing on Travis and Appveyor is that they run in
environments, where the test directory isn't symlinked. However, on OS X '/var'
dir where test directory is located is a symlink to '/private/var'.
Regarding 'npm run ci' - it calls 'cover' npm task that calls 'jasmine-node
spec-cordova spec plugman' - so in fact we're running the same set of tests as
in 'npm test'
-
[1] https://github.com/apache/cordova-lib/pull/433
[2] https://issues.apache.org/jira/browse/CB-11174
-
Best regards, Vladimir
-Original Message-
From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com]
Sent: Friday, April 29, 2016 9:37 AM
To: dev@cordova.apache.org
Subject: RE: help with "npm test" for cordova-lib
Yeah, I was planning to look into this today.
-
Best regards, Vladimir
-Original Message-
From: Shazron [mailto:shaz...@gmail.com]
Sent: Friday, April 29, 2016 3:50 AM
To: dev@cordova.apache.org
Subject: Re: help with "npm test" for cordova-lib
Can someone help, perhaps Vladimir who wrote the tests can shed some light on
how to fix this issue?
On Mon, Apr 25, 2016 at 10:57 AM, Carlos Santana
wrote:
> It's jasmine test that is failing [1]
>
> Does this means that jasmine tests are not running in a continuously?
> Any reason why are they not running in Travis?
>
> I can't figure out what is the test trying to test:
> it('should successfully add a plugin using relative path when running
> from subdir inside of project',
>
> So I need some help trying to fix it.
>
> [1]:
>
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/spec-cor
> dova/plugin.spec.js#L171
>
>
> On Mon, Apr 25, 2016 at 12:51 PM Jesse wrote:
>
> > Travis is running this:
> > - git clone https://github.com/apache/cordova-js --depth 10
> > - cd cordova-lib
> > - npm link ../cordova-js
> > - npm link ../cordova-common
> > - npm link ../cordova-serve
> > - npm install
> > - "(cd ../cordova-common && npm test)"
> > - "npm run ci"
> >
> > There are a lot of different things that could affect the tests,
> > which cordova-js&|common&|serve you have installed/linked and so on.
> > Travis is essentially doing 'npm run ci' which does not run jasmine,
> > so
> the
> > issue is probably a failing jasmine test.
> > Can you try running 'npm run ci' and seeing if that passes?
> >
> >
> >
> > @purplecabbage
> > risingj.com
> >
> > On Sat, Apr 23, 2016 at 1:53 PM, Carlos Santana
> >
> > wrote:
> >
> > > I do't get it then, Travis is green, so Travis not running same
> > > test
> > suite
> > > as "npm test"?
> > >
> > > On Fri, Apr 22, 2016 at 9:11 PM Shazron wrote:
> > >
> > > > I'm seeing the same. Using node 0.12.7
> > > >
> > > >
> > > > On Fri, Apr 22, 2016 at 12:44 PM, Carlos Santana <
> csantan...@gmail.com
> > >
> > > > wrote:
> > > >
> > > > > I'm seeing 2 test failures when I do "npm test"
> > > > >
> > > > > Anyone seeing the same? Wonder what I have setup wrong here:
> > > > >
> > > > > Here is a paste
> > > > > https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%
> > > > > 2fpastebin.com%2f4E4c40X5&data=01%7c01%7cv-vlkoti%40microsoft.
> > > > > com%7c0b976f09a98748ccaf1c08d36fc84313%7c72f988bf86f141af91ab2
> > > > > d7cd011db47%7c1&sdata=05hD%2f6dwDQ7y4Vgxfx9eYsrzZnHuXFe2pwFIY9
> > > > > P92wQ%3d of my output
> > > > >
> > > > > I thought it was node 5, but then swift to node 4 and the same.
> > > > > This is after making sure all npm links are correct with "coho
> > > npm-link"
> > > > >
> > > >
> > >
> >
>
[GitHub] cordova-android pull request: CB-11138 Reuse PluginManager from co...
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/301 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Close function (Android only)
GitHub user androdel opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/73 Close function (Android only) Only did it for Android because the problem only occurred here. You can merge this pull request into a Git repository by running: $ git pull https://github.com/androdel/cordova-plugin-dialogs master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-dialogs/pull/73.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #73 commit 7ebab3412b1c46d6eb2c594c774b457d70e9ecf5 Author: Andro Delrue Date: 2016-01-29T13:32:20Z Update Notification.java added a separate function to dismiss dialogs commit fadb689974094658e4f890e3730fb3bc785dbada Author: Andro Delrue Date: 2016-01-29T13:33:32Z Update notification.js make dismiss function accessable for js commit 931e9f594c93746ce4470ce22815b689876a59b2 Author: Andro Delrue Date: 2016-01-29T13:39:32Z Update notification.js added missing comma commit 239363d28b12e7ee469b12155ff1e8b2e34db5d8 Author: Andro Delrue Date: 2016-02-03T08:23:33Z Update Notification.java replaced dlg with this.dlg where needed commit 98d5d6a9f80e31b4d28a44b6546d39f0ed21f4b9 Author: Andro Delrue Date: 2016-02-03T08:33:21Z Update Notification.java commit f6df68d54e03d9e9867c5031ef2cb28eba50b3e5 Author: Andro Delrue Date: 2016-02-03T08:44:18Z Update Notification.java commit 258ca82735985ca5b840b962a4c96e823bb954bd Author: Andro Delrue Date: 2016-02-03T09:38:54Z Update Notification.java Implemented new way to close dialogs commit 38b2e64548c82dbb33b6497b5bdbeb775ef639df Author: Andro Delrue Date: 2016-02-03T09:47:53Z Update Notification.java added Vector class import commit cbfe3beec13b595dd566b41017644f7f0decc6f7 Author: Andro Delrue Date: 2016-02-03T09:53:24Z Update notification.js --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Added FLAG_SECURE suppor...
Github user devgeeks commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/164#issuecomment-215697044 Well, it certainly works as advertised with the PrivacyScreenPlugin, anyway. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request: CB-11074: Ensure set...
Github user ephemer commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/8#issuecomment-215702371
@shazron in that case we'd have to remove the configuration code from
updateWithInfo because we've already established that it doesn't do anything
anyway. It'd be very frustrating for a new developer to see that code and
wonder why it does nothing at all. As far as I can see it will never work,
wkWebView.configuration is listed as `read-only` in Apple's docs. I'd also
rename `updateWithInfo` to `updateDelegates` or similar unless it breaks
something else.
If we just inited the WKWebView once in `pluginInitialize`, I'm pretty
certain the `CDVViewController.m` would fail at the `canLoadRequest:` check and
then proceed to replace the `WKWebViewEngine` with `defaultWebViewEngineClass`,
as commented in #7:
if ( (...) || ![self.webViewEngine canLoadRequest:[NSURLRequest
requestWithURL:self.appUrl]]) {
self.webViewEngine = [[NSClassFromString(defaultWebViewEngineClass)
alloc] initWithFrame:bounds];
}
Specifically this is due to the following code in `CDVWKWebViewEngine`:
https://github.com/apache/cordova-plugin-wkwebview-engine/blob/33a75172a1450e8922788cd23382cc6ec33845c7/src/ios/CDVWKWebViewEngine.m#L136
`_engineWebView` would still be nil here (because `pluginInitialize`
wouldn't have been called), which would as far as I understand (I'm
Swift-first, ObjC when necessary) be coerced to `NO`, making the above check
fail.
As far as I can see, the only clean solution to this would be to pass
`settings` into the WebViewEngine's `init` method. That is probably also the
most logical and explicit way about getting the settings from `config.xml` into
the WebView.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-11176 Fix windows-splashscreen co...
GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/172 CB-11176 Fix windows-splashscreen compatibility with older plugin ver⦠â¦sions [Jira issue with details](https://issues.apache.org/jira/browse/CB-11176) You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-windows CB-11176 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/172.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #172 commit 16ad1fd151e1b64631588790d6225b44b5297f1f Author: daserge Date: 2016-04-29T13:19:32Z CB-11176 Fix windows-splashscreen compatibility with older plugin versions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8056 Updated the depe...
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/100 CB-8056 Updated the dependency version, added it to the docs Related to https://github.com/apache/cordova-windows/pull/172 You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-splashscreen CB-8056 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-splashscreen/pull/100.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #100 commit 3d924fce1bc1d6b1d1d6414ad93fb7fe3f6b111a Author: daserge Date: 2016-04-29T13:26:20Z CB-8056 Updated the dependency version, added it to the docs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Users mailing list
If the idea is a list for users to help each other (taking that from the httpd list), then why isn't the PG Google Group appropriate for that already? If the idea is for important announcements (Robert's comment), then we have a mechanism for that now - the blog. On Fri, Apr 29, 2016 at 1:42 AM, Robert Posener wrote: > Do some persona modelling... devs are different users. > Slack is full of drivel for the normal user. > You could use the users mailing list to quickly notify ALL users of > critical bugs that have been identified. > Rob > > Regards > *Rob Posener* > 0419 012 627 > > On 29 April 2016 at 10:50, Jesse wrote: > >> Or slack, but slack is only searchable back the last 10k messages. >> >> >> @purplecabbage >> risingj.com >> >> On Thu, Apr 28, 2016 at 5:36 PM, Shazron wrote: >> >> > Perhaps it's time for a users mailing list. No dev is expected to answer >> > questions on it. >> > >> > Example: https://httpd.apache.org/userslist.html >> > >> > Right now we push people off to either: >> > 1. Stack Overflow >> > 2. PhoneGap Google Groups >> > 3. Adobe PhoneGap Forums >> > >> > Thoughts? >> > >> -- === Raymond Camden, Developer Advocate for StrongLoop at IBM Email : raymondcam...@gmail.com Blog : www.raymondcamden.com Twitter: raymondcamden - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Users mailing list
+1 to Raymond, if the idea is asking and answering questions, I think there are enough options right now and for announcements we have the blog 2016-04-29 15:44 GMT+02:00 Raymond Camden : > If the idea is a list for users to help each other (taking that from > the httpd list), then why isn't the PG Google Group appropriate for > that already? > > If the idea is for important announcements (Robert's comment), then we > have a mechanism for that now - the blog. > > On Fri, Apr 29, 2016 at 1:42 AM, Robert Posener > wrote: > > Do some persona modelling... devs are different users. > > Slack is full of drivel for the normal user. > > You could use the users mailing list to quickly notify ALL users of > > critical bugs that have been identified. > > Rob > > > > Regards > > *Rob Posener* > > 0419 012 627 > > > > On 29 April 2016 at 10:50, Jesse wrote: > > > >> Or slack, but slack is only searchable back the last 10k messages. > >> > >> > >> @purplecabbage > >> risingj.com > >> > >> On Thu, Apr 28, 2016 at 5:36 PM, Shazron wrote: > >> > >> > Perhaps it's time for a users mailing list. No dev is expected to > answer > >> > questions on it. > >> > > >> > Example: https://httpd.apache.org/userslist.html > >> > > >> > Right now we push people off to either: > >> > 1. Stack Overflow > >> > 2. PhoneGap Google Groups > >> > 3. Adobe PhoneGap Forums > >> > > >> > Thoughts? > >> > > >> > > > > -- > === > Raymond Camden, Developer Advocate for StrongLoop at IBM > > Email : raymondcam...@gmail.com > Blog : www.raymondcamden.com > Twitter: raymondcamden > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
Re: Users mailing list
On Apr 28, 2016 5:37 PM, "Shazron" wrote: > > Perhaps it's time for a users mailing list. No dev is expected to answer > questions on it. > I like this expectation. With the migration to the PhoneGap Adobe Forum from the defunct Google Group, a users list now makes sense. The expectation that it's be a peer group with no guarantees of dev involvement is very important, since that was not made clear on the Google group and made a lot of people upset. The only thing I dislike about this is that there's some Apache asshole that's going to come in and gloat. > Example: https://httpd.apache.org/userslist.html > > Right now we push people off to either: > 1. Stack Overflow > 2. PhoneGap Google Groups > 3. Adobe PhoneGap Forums > > Thoughts?
Re: Users mailing list
The Google Group is defunct? On Fri, Apr 29, 2016 at 9:08 AM, Joe Bowser wrote: > On Apr 28, 2016 5:37 PM, "Shazron" wrote: >> >> Perhaps it's time for a users mailing list. No dev is expected to answer >> questions on it. >> > > I like this expectation. With the migration to the PhoneGap Adobe Forum > from the defunct Google Group, a users list now makes sense. > > The expectation that it's be a peer group with no guarantees of dev > involvement is very important, since that was not made clear on the Google > group and made a lot of people upset. > > The only thing I dislike about this is that there's some Apache asshole > that's going to come in and gloat. > >> Example: https://httpd.apache.org/userslist.html >> >> Right now we push people off to either: >> 1. Stack Overflow >> 2. PhoneGap Google Groups >> 3. Adobe PhoneGap Forums >> >> Thoughts? -- === Raymond Camden, Developer Advocate for StrongLoop at IBM Email : raymondcam...@gmail.com Blog : www.raymondcamden.com Twitter: raymondcamden - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Users mailing list
On Fri, Apr 29, 2016 at 9:09 AM, Raymond Camden wrote: > >> The expectation that it's be a peer group with no guarantees of dev >> involvement is very important, since that was not made clear on the Google >> group and made a lot of people upset. The top post on the GG has: "One last thing: the people on this list are volunteers. Do not assume that the Cordova developers are actively reading this group -- if you have a bug to report or feature request, do so at the Cordova Issue Tracker. " As the last sentence. Of course people don't read - but that would apply to some new list too. -- === Raymond Camden, Developer Advocate for StrongLoop at IBM Email : raymondcam...@gmail.com Blog : www.raymondcamden.com Twitter: raymondcamden - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-11179 Extend the wind...
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/101 CB-11179 Extend the windows-splashscreen docs You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin-splashscreen CB-11179 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-splashscreen/pull/101.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #101 commit d271cb74eb455dd4b1d678accab3826c670030b5 Author: daserge Date: 2016-04-29T14:23:19Z CB-11179 Extend the windows-splashscreen docs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Users mailing list
That message is relatively new, was included because a lot of people was expecting adobe support. I don't think the google group is defunct, last time I checked it still had more daily messages than the new adobe forums (but less than the old phonegap build community) 2016-04-29 16:11 GMT+02:00 Raymond Camden : > On Fri, Apr 29, 2016 at 9:09 AM, Raymond Camden > wrote: > > > >> The expectation that it's be a peer group with no guarantees of dev > >> involvement is very important, since that was not made clear on the > Google > >> group and made a lot of people upset. > > The top post on the GG has: > > "One last thing: the people on this list are volunteers. Do not assume > that the Cordova developers are actively reading this group -- if you > have a bug to report or feature request, do so at the Cordova Issue > Tracker. " > > As the last sentence. Of course people don't read - but that would > apply to some new list too. > > > > > > -- > === > Raymond Camden, Developer Advocate for StrongLoop at IBM > > Email : raymondcam...@gmail.com > Blog : www.raymondcamden.com > Twitter: raymondcamden > > - > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org > For additional commands, e-mail: dev-h...@cordova.apache.org > >
[GitHub] cordova-plugin-contacts pull request: CB-11166 Added an Appium tes...
Github user alsorokin commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/123#issuecomment-215745788 @riknoll Addressed your comment. Also as a minor change, switched to `tapElementByXPath` function for iOS. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Buildbot: buildslave cordova-windows-slave was lost
The Buildbot working for '' has noticed that the buildslave named cordova-windows-slave went away It last disconnected at Fri Apr 29 15:05:45 2016 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky '. Sincerely, The Buildbot https://ci.apache.org/ https://ci.apache.org/buildslaves/cordova-windows-slave - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: [Android] Need a solution to config.xml and AndroidManifest.xml feature requests
Can I get someone to review my PR? https://github.com/apache/cordova-lib/pull/432 Thanks, Karen Tran On Thu, Apr 21, 2016 at 11:02 AM, Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com> wrote: > Exactly. Multiple tags is also possible with this syntax. > > - > Best regards, Vladimir > > -Original Message- > From: Karen Tran [mailto:ktop...@gmail.com] > Sent: Thursday, April 21, 2016 5:20 PM > To: dev@cordova.apache.org > Subject: Re: [Android] Need a solution to config.xml and > AndroidManifest.xml feature requests > > @Vladimir, in your suggestion, is this what you were going for? Being able > to add multiple attributes to any direct children node of the parent? > > > /> > > > > > Regards, > Karen Tran > > On Thu, Apr 21, 2016 at 3:58 AM, Vladimir Kotikov (Akvelon) < > v-vlk...@microsoft.com> wrote: > > > Another proposal about syntax which allows to specify multiple > > attributes at once and does not require parsing attributes from plain > text: > > > > > > > > > > Also I've took a quick look at the implementation and it looks good > > apart from one minor issue - when we're grafting attributes we > > probably do not need to create an element to graft attributes to if it > > doesn't exist, otherwise after adding and then removing the plugin > > created xml element will remain in modified file. > > > > - > > Best regards, Vladimir > > > > -Original Message- > > From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com] > > Sent: Thursday, April 21, 2016 3:24 AM > > To: dev@cordova.apache.org > > Subject: RE: [Android] Need a solution to config.xml and > > AndroidManifest.xml feature requests > > > > Oh great! I have not taken a close look at the implementation itself. > > Perhaps you already had some of this in mind. > > > > As for the syntax for changing attributes, I would recommend something > > like this: > > > > > attributeName="android:name" attirbuteValue="MyApplication"/> > > > > Also, we should always prioritize config.xml edits over plugin.xml > > (giving the end developer the full control). In case of conflicts, > > between plugins & config.xml we should warn and mention which one we > > picked (config.xml) > > > > Thanks, > > Nikhil > > > > -Original Message- > > From: Karen Tran [mailto:ktop...@gmail.com] > > Sent: Wednesday, April 20, 2016 12:40 PM > > To: dev@cordova.apache.org > > Subject: Re: [Android] Need a solution to config.xml and > > AndroidManifest.xml feature requests > > > > Hi, > > > > I made an attempt at the functionality of being able to add attributes > > with the config-file tag. It's not completed yet, but I wanted to get > > some review before I proceed. > > With my changes, you can add an attribute through the config-file tag > > in plugin.xml when the plugin is added, and when the plugin is > > removed, the attribute will get removed. > > https://github.com/ktop/cordova-lib/tree/cb-11023 > > > > This is what the tag looks like: > > * > parent="/manifest/application" attr="true">* > > *android:name="MyApplication"* > > > > ** > > > > Added *attr* attribute to let Config-File know that we want to add an > > attribute. Default should be false and will expect an element rather > > than an attribute. > > > > One issue I have is that it can only add 1 attribute per config-file tag. > > This is the part that I still need to fix. > > > > Can someone review what I have so far? > > > > Thanks, > > Karen > > > > On Tue, Apr 5, 2016 at 6:54 PM, Simon MacDonald > > > > > > wrote: > > > > > I would love to but I have a few other things to handle first. If > > > someone else picks it up before I get to it then that's cool with me. > > > > > > > > > Simon Mac Donald > > > https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fhi.i > > > m% > > > 2fsimonmacdonald&data=01%7c01%7cnikhilkh%40microsoft.com%7c379bf4c2d > > > ae > > > 4454ee13008d369539a2b%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=T > > > vJ lf2LDyl%2bfSbRMDPjmLe%2fMBQf7PnAzRao5QANRrH4%3d > > > > > > On Tue, Apr 5, 2016 at 6:51 PM, Carlos Santana > > > > > > wrote: > > > > > > > Oh so it means you don't want to work on the code :-p > > > > > > > > > > > > On Tue, Apr 5, 2016 at 6:50 PM Simon MacDonald < > > > simon.macdon...@gmail.com> > > > > wrote: > > > > > > > > > Thanks, I put a watch on that. > > > > > > > > > > > > > > > Simon Mac Donald > > > > > https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2f > > > > > hi > > > > > .im%2fsimonmacdonald&data=01%7c01%7cnikhilkh%40microsoft.com%7c3 > > > > > 79 > > > > > bf4c2dae4454ee13008d369539a2b%7c72f988bf86f141af91ab2d7cd011db47 > > > > > %7 c1&sdata=TvJlf2LDyl%2bfSbRMDPjmLe%2fMBQf7PnAzRao5QANRrH4%3d > > > > > > > > > > On Tue, Apr 5, 2016 at 6:48 PM, Carlos Santana > > > > > > > > > > wrote: > > > > > > > > > > > Simon, I was not able to find a JIRA, I created a new JIRA [1] > > > > > > to > > > > enhance > > > > > > plugin.xml to allow to add attributes > > > > > > >
[GitHub] cordova-plugin-media pull request: Fix for CB-10882 : Plugin Media...
Github user bau720123 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/87#issuecomment-215755338 hi @ThillaiganeshChan and @vladimir-kotikov is there anything update ? or ... https://issues.apache.org/jira/browse/CB-10882 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Buildbot: buildslave cordova-osx-slave was lost
The Buildbot working for '' has noticed that the buildslave named cordova-osx-slave went away It last disconnected at Fri Apr 29 15:21:50 2016 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky '. Sincerely, The Buildbot https://ci.apache.org/ https://ci.apache.org/buildslaves/cordova-osx-slave - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...
Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-215780851 I need to add a workaround for the nodejs bug in setting file timestamps on Windows: https://github.com/nodejs/node/issues/2069 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Added FLAG_SECURE suppor...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/164#issuecomment-215792971 Does it make sense to have this be an iab option? Could a non-secure activity want to display a secure iab? Maybe that is step 2. This looks good though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Users mailing list
Thought I'd throw in my 2¢ worth:
- If a user list is created, I'll gladly participate.
- Having a Cordova-branded user list could be useful from a "branding"
perspective. The Adobe Forums are "PhoneGap" branded, and the Google Group
is named "phonegap" (although the welcome text makes clear that it is for
both environments). Personally, I don't have a problem with the difference
in branding, but for newcomers, I'm sure it raises a few questions ("why am
I going to a phonegap group for a cordova question?").
- As for the blog, as much as I like that the announcements show up there,
not everyone is into feed readers (for whatever reason. I'm not one of of
them -- I'm a feedly addict). For those who prefer email subscriptions, a
user list for announcements would be handy.
- Google Group is still going, but activity is falling off as people
discover the Adobe Forums. The group may need to become r/o at some point
in the future, especially if use declines to next-to-nothing.
- Getting people to read is always the catch -- they just don't. Sometimes
I'm guilty of the same. Human nature, I suspect!
~ Kerri
On Fri, Apr 29, 2016 at 9:26 AM, julio cesar sanchez wrote:
> ...
>
[GitHub] cordova-plugin-contacts pull request: CB-11166 Added an Appium tes...
Github user riknoll commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/123#issuecomment-215809141 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-contacts pull request: CB-11166 Added an Appium tes...
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/123#discussion_r61609305
--- Diff: appium-tests/common/common.spec.js ---
@@ -133,7 +136,7 @@ describe('Contacts Android', function () {
function renameContact(oldName, newGivenName, newFamilyName) {
return driver
.context(webviewContext)
-.setAsyncScriptTimeout(4 * MINUTE)
+.setAsyncScriptTimeout(7 * MINUTE)
--- End diff --
Yeah, I agree. We should figure out what's going on
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...
Github user macdonst commented on the pull request: https://github.com/apache/cordova-lib/pull/432#issuecomment-215811240 @ktop Yeah, I have the `attr="true"` in my plugin.xml and it still gets added instead of merged. ``` ``` I'm not sure why it's not working for me ð¢ Regardless, I have some other comments. What if I put config-file statements in config.xml? Which change takes precedence? Also, instead of using `attr="true"` would it make more sense to use a more granular approach like `mode="add|replace|merge|delete"` where: - add will append to the inner xml of the parent - replace will completely overwrite the parent's inner xml with your declaration - merge will attempt to find elements of the same name and merge their attributes - delete will search for elements matching the specified name and attributes and delete them --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Added FLAG_SECURE suppor...
Github user devgeeks commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/164#issuecomment-215812203 +1 for option. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-inappbrowser pull request: Added FLAG_SECURE suppor...
Github user Alex-Sessler commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/164#issuecomment-215814096 I think i could have time to add this some time this weekend. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Users mailing list
I’m hearing two purposes of a user list:
- Key announcements
- Self-help for users
I’m not totally convinced that slack + stack overflow are not sufficient for
finding resources & common answers for cordova issues. Creating another channel
will just fragment the community.
FWIW, our blog got about 50K pageviews for all blog entries (and blog listing)
in the last month or so. That’s very low compared to over a million hits on our
docs. I agree that we need to find better ways to reach out to users with key
announcements. Perhaps the blog needs to be improved – write more engaging
content, find opportunities for guest posts (cross posting – Raymond?), have an
option to subscribe for notifications to it. We’ve added disqus to our blogs
already – but we need to probably route the disqus comments to the “dev” list
or slack to ensure enough people get to see it and we respond to those comments.
On a related note, we might want to consider a user list for plugin developers.
In particular, we need to have conversations and discussions about breaking
changes, design discussions etc. with this highly important, smaller target
audience. There is no targeted forum for these developers currently.
-Nikhil
On 4/29/16, 9:31 AM, "kerrisho...@gmail.com on behalf of Kerri Shotts"
wrote:
>Thought I'd throw in my 2¢ worth:
>
>- If a user list is created, I'll gladly participate.
>
>- Having a Cordova-branded user list could be useful from a "branding"
>perspective. The Adobe Forums are "PhoneGap" branded, and the Google Group
>is named "phonegap" (although the welcome text makes clear that it is for
>both environments). Personally, I don't have a problem with the difference
>in branding, but for newcomers, I'm sure it raises a few questions ("why am
>I going to a phonegap group for a cordova question?").
>
>- As for the blog, as much as I like that the announcements show up there,
>not everyone is into feed readers (for whatever reason. I'm not one of of
>them -- I'm a feedly addict). For those who prefer email subscriptions, a
>user list for announcements would be handy.
>
>- Google Group is still going, but activity is falling off as people
>discover the Adobe Forums. The group may need to become r/o at some point
>in the future, especially if use declines to next-to-nothing.
>
>- Getting people to read is always the catch -- they just don't. Sometimes
>I'm guilty of the same. Human nature, I suspect!
>
>~ Kerri
>
>
>On Fri, Apr 29, 2016 at 9:26 AM, julio cesar sanchez > wrote:
>
>> ...
>>
RE: Buildbot: buildslave cordova-osx-slave was lost
Sorry everyone! The build machines were accidentally unplugged this morning, but they're back up now. Thanks, Richard -Original Message- From: build...@apache.org [mailto:build...@apache.org] Sent: Friday, April 29, 2016 8:27 AM To: dev@cordova.apache.org Subject: Buildbot: buildslave cordova-osx-slave was lost The Buildbot working for '' has noticed that the buildslave named cordova-osx-slave went away It last disconnected at Fri Apr 29 15:21:50 2016 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky '. Sincerely, The Buildbot https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fci.apache.org%2f&data=01%7c01%7criknoll%40microsoft.com%7cf4ebdce63bfc4b65954e08d37042b192%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=GxNY3zwLczz1RyDoxGCCnty2WO3QFtyr9niFIebM9fc%3d https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fci.apache.org%2fbuildslaves%2fcordova-osx-slave&data=01%7c01%7criknoll%40microsoft.com%7cf4ebdce63bfc4b65954e08d37042b192%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=mEZ%2bz5AQteuFUQ6NzgtVoJbGUMU6RPkNkjnwrfaZlu4%3d - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-215817627 Simultaneously, lets ask libuv to make the fix for this issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-11176 Fix windows-splashscreen co...
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/172#discussion_r61619913
--- Diff: cordova-js-src/exec.js ---
@@ -41,6 +41,20 @@ var execProxy = require('cordova/exec/proxy');
*/
module.exports = function (success, fail, service, action, args) {
+// Handle the case when we have an old version of splashscreen plugin
to avoid the API calls failures
+if (service === 'SplashScreen') {
+var pluginsVersions = require("cordova/plugin_list").metadata;
+var splashscreenVersion =
pluginsVersions['cordova-plugin-splashscreen'];
+var MIN_SPLASHSCREEN_SUPPORTED_VER = 4;
+if (splashscreenVersion && parseInt(splashscreenVersion[0], 10) <
MIN_SPLASHSCREEN_SUPPORTED_VER) {
--- End diff --
Is it supposed to not work for 4.x versions as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-11176 Fix windows-splashscreen co...
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/172#discussion_r61621269
--- Diff: cordova-js-src/exec.js ---
@@ -41,6 +41,20 @@ var execProxy = require('cordova/exec/proxy');
*/
module.exports = function (success, fail, service, action, args) {
+// Handle the case when we have an old version of splashscreen plugin
to avoid the API calls failures
+if (service === 'SplashScreen') {
+var pluginsVersions = require("cordova/plugin_list").metadata;
+var splashscreenVersion =
pluginsVersions['cordova-plugin-splashscreen'];
+var MIN_SPLASHSCREEN_SUPPORTED_VER = 4;
+if (splashscreenVersion && parseInt(splashscreenVersion[0], 10) <
MIN_SPLASHSCREEN_SUPPORTED_VER) {
+console.log('Warning: cordova-plugin-splashscreen has been
hooked into for compatibility reasons. Update the plugin to version >= 4.');
--- End diff --
Consider updating the message to something like: "A more recent version of
cordova-plugin-splashscreen has been hooked into..."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-11176 Fix windows-splashscreen co...
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-windows/pull/172#issuecomment-215833144 Minor comments. Otherwise LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8056 Updated the depe...
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/100#issuecomment-215833256 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-11179 Extend the wind...
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/101#discussion_r61622534 --- Diff: README.md --- @@ -222,6 +222,10 @@ __Note__: `SplashScreen` value should be absolute in order to work in a sub-page +- Extended splashscreen on Windows does not require the plugin (as opposed to Android and iOS) in case you don't use the plugin API. To disable the splashscreen add the following preference to config.xml: --- End diff -- We shouldn't be documenting this under quirks. Also does the disabling preference applies only to 'Windows' platform? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
RE: Buildbot: buildslave cordova-osx-slave was lost
I need to move the machines, so be advised that both build machines are going to go offline again for a bit. Thanks, Richard -Original Message- From: Richard Knoll [mailto:rikn...@microsoft.com] Sent: Friday, April 29, 2016 10:06 AM To: dev@cordova.apache.org Subject: RE: Buildbot: buildslave cordova-osx-slave was lost Sorry everyone! The build machines were accidentally unplugged this morning, but they're back up now. Thanks, Richard -Original Message- From: build...@apache.org [mailto:build...@apache.org] Sent: Friday, April 29, 2016 8:27 AM To: dev@cordova.apache.org Subject: Buildbot: buildslave cordova-osx-slave was lost The Buildbot working for '' has noticed that the buildslave named cordova-osx-slave went away It last disconnected at Fri Apr 29 15:21:50 2016 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky '. Sincerely, The Buildbot https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fci.apache.org%2f&data=01%7c01%7criknoll%40microsoft.com%7cf4ebdce63bfc4b65954e08d37042b192%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=GxNY3zwLczz1RyDoxGCCnty2WO3QFtyr9niFIebM9fc%3d https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fci.apache.org%2fbuildslaves%2fcordova-osx-slave&data=01%7c01%7criknoll%40microsoft.com%7cf4ebdce63bfc4b65954e08d37042b192%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=mEZ%2bz5AQteuFUQ6NzgtVoJbGUMU6RPkNkjnwrfaZlu4%3d - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Buildbot: buildslave cordova-osx-slave was lost
The Buildbot working for '' has noticed that the buildslave named cordova-osx-slave went away It last disconnected at Fri Apr 29 18:28:25 2016 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky '. Sincerely, The Buildbot https://ci.apache.org/ https://ci.apache.org/buildslaves/cordova-osx-slave - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Buildbot: buildslave cordova-windows-slave was lost
The Buildbot working for '' has noticed that the buildslave named cordova-windows-slave went away It last disconnected at Fri Apr 29 18:28:40 2016 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky '. Sincerely, The Buildbot https://ci.apache.org/ https://ci.apache.org/buildslaves/cordova-windows-slave - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Users mailing list
On Fri, Apr 29, 2016 at 10:05 AM, Nikhil Khandelwal
wrote:
> I’m hearing two purposes of a user list:
> - Key announcements
> - Self-help for users
>
> I’m not totally convinced that slack + stack overflow are not sufficient
> for finding resources & common answers for cordova issues. Creating another
> channel will just fragment the community.
>
>
I would love to suggest Stack Overflow only because social voting tends to
elect the most correct answer. I personally hate mailing lists for trying
to figure out how to use something because the answer gets buried way too
deep. I think that the main reason I would like to see a user list is
because
> FWIW, our blog got about 50K pageviews for all blog entries (and blog
> listing) in the last month or so. That’s very low compared to over a
> million hits on our docs. I agree that we need to find better ways to reach
> out to users with key announcements. Perhaps the blog needs to be improved
> – write more engaging content, find opportunities for guest posts (cross
> posting – Raymond?), have an option to subscribe for notifications to it.
> We’ve added disqus to our blogs already – but we need to probably route the
> disqus comments to the “dev” list or slack to ensure enough people get to
> see it and we respond to those comments.
>
>
Do we know which part of our docs are getting the most hits? I honestly
don't think that generic announcements are the best way to reach out to
users, but that would mean that we change how we use the blog, and that we
decide on what content we should post to it. Right now, I'm pretty happy
with it just being announcements.
On a related note, we might want to consider a user list for plugin
> developers. In particular, we need to have conversations and discussions
> about breaking changes, design discussions etc. with this highly important,
> smaller target audience. There is no targeted forum for these developers
> currently.
>
That should be happening on this list, but this list gets flooded with
people looking for answers for their Cordova problems instead, which may be
why we need a users list, since we're already kinda fractured. :/
-Nikhil
>
> On 4/29/16, 9:31 AM, "kerrisho...@gmail.com on behalf of Kerri Shotts" <
> kerrisho...@gmail.com on behalf of ke...@photokandy.com> wrote:
>
> >Thought I'd throw in my 2¢ worth:
> >
> >- If a user list is created, I'll gladly participate.
> >
> >- Having a Cordova-branded user list could be useful from a "branding"
> >perspective. The Adobe Forums are "PhoneGap" branded, and the Google Group
> >is named "phonegap" (although the welcome text makes clear that it is for
> >both environments). Personally, I don't have a problem with the difference
> >in branding, but for newcomers, I'm sure it raises a few questions ("why
> am
> >I going to a phonegap group for a cordova question?").
> >
> >- As for the blog, as much as I like that the announcements show up there,
> >not everyone is into feed readers (for whatever reason. I'm not one of of
> >them -- I'm a feedly addict). For those who prefer email subscriptions, a
> >user list for announcements would be handy.
> >
> >- Google Group is still going, but activity is falling off as people
> >discover the Adobe Forums. The group may need to become r/o at some point
> >in the future, especially if use declines to next-to-nothing.
> >
> >- Getting people to read is always the catch -- they just don't. Sometimes
> >I'm guilty of the same. Human nature, I suspect!
> >
> >~ Kerri
> >
> >
> >On Fri, Apr 29, 2016 at 9:26 AM, julio cesar sanchez <
> jcesarmob...@gmail.com
> >> wrote:
> >
> >> ...
> >>
>
>
Re: Users mailing list
On Fri, Apr 29, 2016 at 11:40 AM, Joe Bowser wrote:
>
>
> On Fri, Apr 29, 2016 at 10:05 AM, Nikhil Khandelwal <
> nikhi...@microsoft.com> wrote:
>
>> I’m hearing two purposes of a user list:
>> - Key announcements
>> - Self-help for users
>>
>> I’m not totally convinced that slack + stack overflow are not sufficient
>> for finding resources & common answers for cordova issues. Creating another
>> channel will just fragment the community.
>>
>>
> I would love to suggest Stack Overflow only because social voting tends to
> elect the most correct answer. I personally hate mailing lists for trying
> to figure out how to use something because the answer gets buried way too
> deep. I think that the main reason I would like to see a user list is
> because
>
because we get flooded with users on the dev list. I should have finished
this thought before skipping to the next one.
>
>
>> FWIW, our blog got about 50K pageviews for all blog entries (and blog
>> listing) in the last month or so. That’s very low compared to over a
>> million hits on our docs. I agree that we need to find better ways to reach
>> out to users with key announcements. Perhaps the blog needs to be improved
>> – write more engaging content, find opportunities for guest posts (cross
>> posting – Raymond?), have an option to subscribe for notifications to it.
>> We’ve added disqus to our blogs already – but we need to probably route the
>> disqus comments to the “dev” list or slack to ensure enough people get to
>> see it and we respond to those comments.
>>
>>
> Do we know which part of our docs are getting the most hits? I honestly
> don't think that generic announcements are the best way to reach out to
> users, but that would mean that we change how we use the blog, and that we
> decide on what content we should post to it. Right now, I'm pretty happy
> with it just being announcements.
>
> On a related note, we might want to consider a user list for plugin
>> developers. In particular, we need to have conversations and discussions
>> about breaking changes, design discussions etc. with this highly important,
>> smaller target audience. There is no targeted forum for these developers
>> currently.
>>
>
> That should be happening on this list, but this list gets flooded with
> people looking for answers for their Cordova problems instead, which may be
> why we need a users list, since we're already kinda fractured. :/
>
> -Nikhil
>>
>> On 4/29/16, 9:31 AM, "kerrisho...@gmail.com on behalf of Kerri Shotts" <
>> kerrisho...@gmail.com on behalf of ke...@photokandy.com> wrote:
>>
>> >Thought I'd throw in my 2¢ worth:
>> >
>> >- If a user list is created, I'll gladly participate.
>> >
>> >- Having a Cordova-branded user list could be useful from a "branding"
>> >perspective. The Adobe Forums are "PhoneGap" branded, and the Google
>> Group
>> >is named "phonegap" (although the welcome text makes clear that it is for
>> >both environments). Personally, I don't have a problem with the
>> difference
>> >in branding, but for newcomers, I'm sure it raises a few questions ("why
>> am
>> >I going to a phonegap group for a cordova question?").
>> >
>> >- As for the blog, as much as I like that the announcements show up
>> there,
>> >not everyone is into feed readers (for whatever reason. I'm not one of of
>> >them -- I'm a feedly addict). For those who prefer email subscriptions, a
>> >user list for announcements would be handy.
>> >
>> >- Google Group is still going, but activity is falling off as people
>> >discover the Adobe Forums. The group may need to become r/o at some point
>> >in the future, especially if use declines to next-to-nothing.
>> >
>> >- Getting people to read is always the catch -- they just don't.
>> Sometimes
>> >I'm guilty of the same. Human nature, I suspect!
>> >
>> >~ Kerri
>> >
>> >
>> >On Fri, Apr 29, 2016 at 9:26 AM, julio cesar sanchez <
>> jcesarmob...@gmail.com
>> >> wrote:
>> >
>> >> ...
>> >>
>>
>>
>
[GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...
Github user ktop commented on the pull request: https://github.com/apache/cordova-lib/pull/432#issuecomment-215857823 @macdonst I had Edna test the first time around before I opened the PR and she was able to get it working, so that is weird that it is adding a new element for you. Was config-file functional in config.xml before? Or was that something to be done as part of this jira issue? I was only focused on getting it working in plugin.xml, so I can work on it if it isn't implemented yet. Should config.xml handle config-file during prepare? The mode suggestion sounds good. It will give users a lot of utility for modifying xml files. I have just few clarification questions: - If no mode is specified, is the default to add? - For replace, if there is nothing to replace, should it still try to add? - And for delete, should it delete an element even if the element has children? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...
Github user riknoll commented on the pull request: https://github.com/apache/cordova-lib/pull/432#issuecomment-215866756 @ktop config-file wasn't in config.xml before, but we wanted to add it because the number of config.xml attributes that just edit various native xml files is getting unsustainable. I think that config.xml's config-file modifications should happen during the same step as the plugins' modifications do, but they should definitely be applied after all of the plugin.xml ones. That way, the app developer always has the option to override whatever the plugins are doing. I think the mode flag is a good idea, but I worry about allowing it in plugin.xml. If plugins are able to do things other than add elements, does that mean we have the opportunity for plugins to overwrite each other's modifications depending on the order in which their config-file attributes are resolved? That might get weird. Definitely makes sense to have it in config.xml though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
Re: Users mailing list
The reason I brought up notifications about critical errors is that that is
NOT happening now. There have been a number of instances recently, where
there has been discussion about regression errors that have not been
announced to the wider community (eg, via the blog) and cordova users have
been in the dark about for as long as 2 weeks before a patch release has
been issued.
By all means, use the blog for this, but DO IT... don't just say it could
be used for this.
Rob
Regards
*Rob Posener*
0419 012 627
On 30 April 2016 at 04:41, Joe Bowser wrote:
> On Fri, Apr 29, 2016 at 11:40 AM, Joe Bowser wrote:
>
> >
> >
> > On Fri, Apr 29, 2016 at 10:05 AM, Nikhil Khandelwal <
> > nikhi...@microsoft.com> wrote:
> >
> >> I’m hearing two purposes of a user list:
> >> - Key announcements
> >> - Self-help for users
> >>
> >> I’m not totally convinced that slack + stack overflow are not sufficient
> >> for finding resources & common answers for cordova issues. Creating
> another
> >> channel will just fragment the community.
> >>
> >>
> > I would love to suggest Stack Overflow only because social voting tends
> to
> > elect the most correct answer. I personally hate mailing lists for
> trying
> > to figure out how to use something because the answer gets buried way too
> > deep. I think that the main reason I would like to see a user list is
> > because
> >
>
> because we get flooded with users on the dev list. I should have finished
> this thought before skipping to the next one.
>
>
> >
> >
> >> FWIW, our blog got about 50K pageviews for all blog entries (and blog
> >> listing) in the last month or so. That’s very low compared to over a
> >> million hits on our docs. I agree that we need to find better ways to
> reach
> >> out to users with key announcements. Perhaps the blog needs to be
> improved
> >> – write more engaging content, find opportunities for guest posts (cross
> >> posting – Raymond?), have an option to subscribe for notifications to
> it.
> >> We’ve added disqus to our blogs already – but we need to probably route
> the
> >> disqus comments to the “dev” list or slack to ensure enough people get
> to
> >> see it and we respond to those comments.
> >>
> >>
> > Do we know which part of our docs are getting the most hits? I honestly
> > don't think that generic announcements are the best way to reach out to
> > users, but that would mean that we change how we use the blog, and that
> we
> > decide on what content we should post to it. Right now, I'm pretty happy
> > with it just being announcements.
> >
> > On a related note, we might want to consider a user list for plugin
> >> developers. In particular, we need to have conversations and discussions
> >> about breaking changes, design discussions etc. with this highly
> important,
> >> smaller target audience. There is no targeted forum for these developers
> >> currently.
> >>
> >
> > That should be happening on this list, but this list gets flooded with
> > people looking for answers for their Cordova problems instead, which may
> be
> > why we need a users list, since we're already kinda fractured. :/
> >
> > -Nikhil
> >>
> >> On 4/29/16, 9:31 AM, "kerrisho...@gmail.com on behalf of Kerri Shotts"
> <
> >> kerrisho...@gmail.com on behalf of ke...@photokandy.com> wrote:
> >>
> >> >Thought I'd throw in my 2¢ worth:
> >> >
> >> >- If a user list is created, I'll gladly participate.
> >> >
> >> >- Having a Cordova-branded user list could be useful from a "branding"
> >> >perspective. The Adobe Forums are "PhoneGap" branded, and the Google
> >> Group
> >> >is named "phonegap" (although the welcome text makes clear that it is
> for
> >> >both environments). Personally, I don't have a problem with the
> >> difference
> >> >in branding, but for newcomers, I'm sure it raises a few questions
> ("why
> >> am
> >> >I going to a phonegap group for a cordova question?").
> >> >
> >> >- As for the blog, as much as I like that the announcements show up
> >> there,
> >> >not everyone is into feed readers (for whatever reason. I'm not one of
> of
> >> >them -- I'm a feedly addict). For those who prefer email
> subscriptions, a
> >> >user list for announcements would be handy.
> >> >
> >> >- Google Group is still going, but activity is falling off as people
> >> >discover the Adobe Forums. The group may need to become r/o at some
> point
> >> >in the future, especially if use declines to next-to-nothing.
> >> >
> >> >- Getting people to read is always the catch -- they just don't.
> >> Sometimes
> >> >I'm guilty of the same. Human nature, I suspect!
> >> >
> >> >~ Kerri
> >> >
> >> >
> >> >On Fri, Apr 29, 2016 at 9:26 AM, julio cesar sanchez <
> >> jcesarmob...@gmail.com
> >> >> wrote:
> >> >
> >> >> ...
> >> >>
> >>
> >>
> >
>
[GitHub] cordova-ios pull request: CB-11161 Reuse PluginManager from common...
Github user jasongin commented on the pull request: https://github.com/apache/cordova-ios/pull/219#issuecomment-215890484 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-11139 Use PluginManager from comm...
Github user jasongin commented on the pull request: https://github.com/apache/cordova-windows/pull/171#issuecomment-215891369 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/432#issuecomment-215892244 I would put the mode flag as out-of-scope for now, we can re-asses later if need be. I could not get this to work, can you please post instructions for verifying it? My steps were: ``` cordova create newproject cordova platform add android // modified the root config.xml with the fragment from above cordova prepare // checked androidmanifest.xml for changes, none seen ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-11174 Resolve symlinked path before g...
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/433#discussion_r61653369
--- Diff: cordova-lib/spec-cordova/platforms/platforms.spec.js ---
@@ -17,19 +17,25 @@
under the License.
*/
+var fs = require('fs');
+var os = require('os');
var path = require('path');
var rewire = require('rewire');
+var shell = require('shelljs');
var util = require('../../src/cordova/util');
var platforms = rewire('../../src/platforms/platforms');
var CORDOVA_ROOT = path.join(__dirname,
'../fixtures/projects/platformApi');
var PLATFORM_WITH_API = path.join(CORDOVA_ROOT, 'platforms/windows');
var PLATFORM_WOUT_API = path.join(CORDOVA_ROOT, 'platforms/android');
+var PLATFORM_SYMLINK = path.join(os.tmpdir(), 'cordova_windows_symlink');
-var MockPlatformApi = require(path.join(PLATFORM_WITH_API, 'cordova',
'Api'));
+var MockPlatformApi = require(fs.realpathSync(path.join(PLATFORM_WITH_API,
'cordova/Api.js')));
var PlatformApiPoly = require('../../src/platforms/PlatformApiPoly');
+shell.ln('-sf', PLATFORM_WITH_API, PLATFORM_SYMLINK);
+
--- End diff --
Have you tested on Windows? (I see the bug is just about OS X.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-11174 Resolve symlinked path before g...
Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/433#issuecomment-215898416 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10653 Making the windows activati...
GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-windows/pull/173 CB-10653 Making the windows activation context complete The current implementation doesn't capture details for all the activation options for UWP apps. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-windows raghav/active Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/173.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #173 commit 91cf287658a4e4bd8a64cd40367211cb4aa568eb Author: Raghav Katyal Date: 2016-04-29T22:44:55Z CB-10653 Making the windows activation context complete --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-11174 Resolve symlinked path before g...
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/433#discussion_r61655336
--- Diff: cordova-lib/spec-cordova/platforms/platforms.spec.js ---
@@ -17,19 +17,25 @@
under the License.
*/
+var fs = require('fs');
+var os = require('os');
var path = require('path');
var rewire = require('rewire');
+var shell = require('shelljs');
var util = require('../../src/cordova/util');
var platforms = rewire('../../src/platforms/platforms');
var CORDOVA_ROOT = path.join(__dirname,
'../fixtures/projects/platformApi');
var PLATFORM_WITH_API = path.join(CORDOVA_ROOT, 'platforms/windows');
var PLATFORM_WOUT_API = path.join(CORDOVA_ROOT, 'platforms/android');
+var PLATFORM_SYMLINK = path.join(os.tmpdir(), 'cordova_windows_symlink');
-var MockPlatformApi = require(path.join(PLATFORM_WITH_API, 'cordova',
'Api'));
+var MockPlatformApi = require(fs.realpathSync(path.join(PLATFORM_WITH_API,
'cordova/Api.js')));
var PlatformApiPoly = require('../../src/platforms/PlatformApiPoly');
+shell.ln('-sf', PLATFORM_WITH_API, PLATFORM_SYMLINK);
+
--- End diff --
I've tested this on both OS X and Windows. Tests are passing in both cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10653 Making the windows activati...
Github user codecov-io commented on the pull request: https://github.com/apache/cordova-windows/pull/173#issuecomment-215903575 ## [Current coverage][cc-pull] is **73.49%** > Merging [#173][cc-pull] into [master][cc-base-branch] will increase coverage by **-26.51%** ```diff @@ master #173 diff @@ == Files14 14 Lines 3202 1852 -1350 Methods 339340 +1 Messages 0 0 Branches451379 -72 == - Hits 3202 1361 -1841 - Misses0491+491 Partials 0 0 ``` 1. 14 files (not in diff) in `template/cordova/lib` were modified. [more](https://codecov.io/gh/apache/cordova-windows/commit/7d02a1ac6bbeccf8bcc3783bd93086c8eab1ceaa/changes?src=pr#74656D706C6174652F636F72646F76612F6C6962) - Misses `+491` - Hits `-1841` > Powered by [Codecov](https://codecov.io?src=pr). Last updated by [bbd8de7...7d02a1a][cc-compare] [cc-base-branch]: https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr [cc-compare]: https://codecov.io/gh/apache/cordova-windows/compare/bbd8de71dbfa8c3b03f5e67c60a63f6818ca42eb...7d02a1ac6bbeccf8bcc3783bd93086c8eab1ceaa [cc-pull]: https://codecov.io/gh/apache/cordova-windows/pull/173?src=pr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10653 Making the windows activati...
Github user riknoll commented on the pull request: https://github.com/apache/cordova-windows/pull/173#issuecomment-215905585 Was there a reason we weren't saving all of the detail information before? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10653 Making the windows activati...
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-windows/pull/173#issuecomment-215905896 Not sure about that. May be it wasn't needed at that time since the activation events were limited. With UWP there are more activation kinds introduced. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10653 Making the windows activati...
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/173#issuecomment-215908246 @purplecabbage who was involved in some of the original code here. @daserge @vladimir-kotikov to review as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...
Github user jasongin commented on the pull request: https://github.com/apache/cordova-lib/pull/429#issuecomment-215911697 @nikhilkh As we discussed, this workaround was the best I could find. The command script approach has similar performance to just copying files via the node fs APIs, and it correctly copies the file times, enabling incremental builds to work correctly. My biggest remaining concern is any errors during the copy will not pinpoint a specific file, but that should be an extremely rare issue. I also tried using a generated PowerShell script to just update the file times after copying in nodejs, but that was too slow, both in PS startup cost and per-file cost. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r61659743
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,499 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+"use strict";
+
+var fs = require("fs");
+var path = require("path");
+var shell = require("shelljs");
+var minimatch = require("minimatch");
+
+var isWindows = (process.platform === "win32");
+var child_process = (isWindows ? require("child_process") : null);
+
+/**
+ * Logging callback used in the FileUpdater methods.
+ * @callback loggingCallback
+ * @param {string} message A message describing a single file update
operation.
+ */
+
+/**
+ * Updates a target file or directory with a source file or directory.
(Directory updates are
+ * not recursive.) Stats for target and source items must be passed in.
This is an internal
+ * helper function used by other methods in this module.
+ *
+ * @param {?string} sourcePath Source file or directory to be used to
update the
+ * destination. If the source is null, then the destination is deleted
if it exists.
+ * @param {?fs.Stats} sourceStats An instance of fs.Stats for the source
path, or null if
+ * the source does not exist.
+ * @param {string} targetPath Required destination file or directory to be
updated. If it does
+ * not exist, it will be created.
+ * @param {?fs.Stats} targetStats An instance of fs.Stats for the target
path, or null if
+ * the target does not exist.
+ * @param {Object} [options] Optional additional parameters for the update.
+ * @param {string} [options.rootDir] Optional root directory (such as a
project) to which target
+ * and source path parameters are relative; may be omitted if the
paths are absolute. The
+ * rootDir is always omitted from any logged paths, to make the logs
easier to read.
+ * @param {boolean} [options.all] If true, all files are copied regardless
of last-modified times.
+ * @param {boolean} [options.newer] If true (and all is not specified),
only files with newer
+ * last-modified times are copied. By default, only files with
different times are copied.
+ * @param {loggingCallback} [log] Optional logging callback that takes a
string message
+ * describing any file operations that are performed.
+ * @param {Object} context Context object for tracking file operations.
+ * @return {boolean} true if any changes were made, or false if the force
flag is not set
+ * and everything was up to date
+ */
+function updatePathWithStats(
+sourcePath, sourceStats, targetPath, targetStats, options, log,
context) {
+var updated = false;
+
+var rootDir = (options && options.rootDir) || "";
+var copyAll = (options && options.all) || false;
+var copyNewer = (options && options.newer) || false;
+
+var targetFullPath = path.join(rootDir || "", targetPath);
+
+if (sourceStats) {
+var sourceFullPath = path.join(rootDir || "", sourcePath);
+
+if (targetStats) {
+// The target exists. But if the directory status doesn't
match the source, delete it.
+if (targetStats.isDirectory() && !sourceStats.isDirectory()) {
+log("rmdir " + targetPath + " (source is a file)");
--- End diff --
Rest of our code uses event emitter - is there a reason why we don't use
that here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordo
[GitHub] cordova-lib pull request: CB-11023 Add attribute through config-fi...
Github user macdonst commented on the pull request: https://github.com/apache/cordova-lib/pull/432#issuecomment-215915464 @ktop @riknoll yeah, config.xml should be part of this. Anything in config.xml should trump whatever is specified in the plugin.xml. If we do modes then default mode would be `add`, if nothing to `replace` then it becomes an `add` and `delete` could take out the entire element. We can work on flags later but getting attribute level manipulation into config.xml and plugin.xml parsing would be amazing. @purplecabbage you need to add: ``` ``` into the plugin.xml of a plugin you are including in the project. So... ``` cordova create newproject cordova platform add android cordova plugin add cordova-plugin-one-I-just-made-up // modified the plugin.xml with the fragment from above cordova prepare // checked androidmanifest.xml for changes ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work
Github user codecov-io commented on the pull request: https://github.com/apache/cordova-lib/pull/407#issuecomment-215918679 ## [Current coverage][cc-pull] is **13.19%** > Merging [#407][cc-pull] into [master][cc-base-branch] will increase coverage by **-86.81%** ```diff @@ master #407 diff @@ == Files69 34 -35 Lines 9878 3261 -6617 Methods 841525-316 Messages 0 0 Branches 1271636-635 == - Hits 9878430 -9448 - Misses0 2831 +2831 Partials 0 0 ``` 1. 3 files (not in diff) in `cordova-lib/src/util` were modified. [more](https://codecov.io/gh/apache/cordova-lib/commit/b61258fd4d50e6f1b71b55a6200a4e73b7d1857f/changes?src=pr#636F72646F76612D6C69622F7372632F7574696C) - Misses `+46` - Hits `-86` 1. 4 files (not in diff) in `...dova-lib/src/plugman` were modified. [more](https://codecov.io/gh/apache/cordova-lib/commit/b61258fd4d50e6f1b71b55a6200a4e73b7d1857f/changes?src=pr#636F72646F76612D6C69622F7372632F706C75676D616E) - Misses `+219` - Hits `-437` 1. 2 files (not in diff) in `...va-lib/src/platforms` were modified. [more](https://codecov.io/gh/apache/cordova-lib/commit/b61258fd4d50e6f1b71b55a6200a4e73b7d1857f/changes?src=pr#636F72646F76612D6C69622F7372632F706C6174666F726D73) - Misses `+234` - Hits `-444` 1. 3 files (not in diff) in `...ordova-lib/src/hooks` were modified. [more](https://codecov.io/gh/apache/cordova-lib/commit/b61258fd4d50e6f1b71b55a6200a4e73b7d1857f/changes?src=pr#636F72646F76612D6C69622F7372632F686F6F6B73) - Misses `+159` - Hits `-315` 1. 2 files (not in diff) in `...etadata/parserhelper` were modified. [more](https://codecov.io/gh/apache/cordova-lib/commit/b61258fd4d50e6f1b71b55a6200a4e73b7d1857f/changes?src=pr#636F72646F76612D6C69622F7372632F636F72646F76612F6D657461646174612F70617273657268656C706572) - Misses `+24` - Hits `-84` 1. 9 files (not in diff) in `...src/cordova/metadata` were modified. [more](https://codecov.io/gh/apache/cordova-lib/commit/b61258fd4d50e6f1b71b55a6200a4e73b7d1857f/changes?src=pr#636F72646F76612D6C69622F7372632F636F72646F76612F6D65746164617461) - Misses `+859` - Hits `-1578` 1. 7 files (not in diff) in `...dova-lib/src/cordova` were modified. [more](https://codecov.io/gh/apache/cordova-lib/commit/b61258fd4d50e6f1b71b55a6200a4e73b7d1857f/changes?src=pr#636F72646F76612D6C69622F7372632F636F72646F7661) - Misses `+440` - Hits `-855` 1. 1 files (not in diff) in `cordova-lib/src` were modified. [more](https://codecov.io/gh/apache/cordova-lib/commit/b61258fd4d50e6f1b71b55a6200a4e73b7d1857f/changes?src=pr#636F72646F76612D6C69622F737263) - Misses `+22` - Hits `-42` 1. 2 files in `...dova-lib/src/cordova` were modified. [more](https://codecov.io/gh/apache/cordova-lib/commit/b61258fd4d50e6f1b71b55a6200a4e73b7d1857f/changes?src=pr#636F72646F76612D6C69622F7372632F636F72646F7661) - Misses `+716` - Hits `-1327` 1. 1 files in `cordova-lib/src` were modified. [more](https://codecov.io/gh/apache/cordova-lib/commit/b61258fd4d50e6f1b71b55a6200a4e73b7d1857f/changes?src=pr#636F72646F76612D6C69622F737263) - Misses `+73` - Hits `-136` > Powered by [Codecov](https://codecov.io?src=pr). Last updated by [5867657...b61258f][cc-compare] [cc-base-branch]: https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr [cc-compare]: https://codecov.io/gh/apache/cordova-lib/compare/5867657d989b136702fe2f14172661ca489573ed...b61258fd4d50e6f1b71b55a6200a4e73b7d1857f [cc-pull]: https://codecov.io/gh/apache/cordova-lib/pull/407?src=pr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-11174 Resolve symlinked path before g...
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/433#issuecomment-215922979 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-lib pull request: CB-11117: Add FileUpdater module to cord...
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/429#discussion_r61665459
--- Diff: cordova-common/src/FileUpdater.js ---
@@ -0,0 +1,499 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+"use strict";
+
+var fs = require("fs");
+var path = require("path");
+var shell = require("shelljs");
+var minimatch = require("minimatch");
+
+var isWindows = (process.platform === "win32");
+var child_process = (isWindows ? require("child_process") : null);
+
+/**
+ * Logging callback used in the FileUpdater methods.
+ * @callback loggingCallback
+ * @param {string} message A message describing a single file update
operation.
+ */
+
+/**
+ * Updates a target file or directory with a source file or directory.
(Directory updates are
+ * not recursive.) Stats for target and source items must be passed in.
This is an internal
+ * helper function used by other methods in this module.
+ *
+ * @param {?string} sourcePath Source file or directory to be used to
update the
+ * destination. If the source is null, then the destination is deleted
if it exists.
+ * @param {?fs.Stats} sourceStats An instance of fs.Stats for the source
path, or null if
+ * the source does not exist.
+ * @param {string} targetPath Required destination file or directory to be
updated. If it does
+ * not exist, it will be created.
+ * @param {?fs.Stats} targetStats An instance of fs.Stats for the target
path, or null if
+ * the target does not exist.
+ * @param {Object} [options] Optional additional parameters for the update.
+ * @param {string} [options.rootDir] Optional root directory (such as a
project) to which target
+ * and source path parameters are relative; may be omitted if the
paths are absolute. The
+ * rootDir is always omitted from any logged paths, to make the logs
easier to read.
+ * @param {boolean} [options.all] If true, all files are copied regardless
of last-modified times.
+ * @param {boolean} [options.newer] If true (and all is not specified),
only files with newer
+ * last-modified times are copied. By default, only files with
different times are copied.
+ * @param {loggingCallback} [log] Optional logging callback that takes a
string message
+ * describing any file operations that are performed.
+ * @param {Object} context Context object for tracking file operations.
+ * @return {boolean} true if any changes were made, or false if the force
flag is not set
+ * and everything was up to date
+ */
+function updatePathWithStats(
+sourcePath, sourceStats, targetPath, targetStats, options, log,
context) {
+var updated = false;
+
+var rootDir = (options && options.rootDir) || "";
+var copyAll = (options && options.all) || false;
+var copyNewer = (options && options.newer) || false;
+
+var targetFullPath = path.join(rootDir || "", targetPath);
+
+if (sourceStats) {
+var sourceFullPath = path.join(rootDir || "", sourcePath);
+
+if (targetStats) {
+// The target exists. But if the directory status doesn't
match the source, delete it.
+if (targetStats.isDirectory() && !sourceStats.isDirectory()) {
+log("rmdir " + targetPath + " (source is a file)");
--- End diff --
Yes. Basically I wanted to enable callers to choose whether they want any
logging and what level and format. I expect these functions could be useful in
more than one scenario, so logging requirements may be different.
Initially I am passing in events.emit.bind('verbose') as the logging
callback to these functions in the updates I'm making to each platform's
prepare code. But I know we may want to adjust logging levels and styles soon
in the platform code, and it will be easier to do that if we don't have to
update cordova-common also.
---
If your project is set
[GitHub] cordova-windows pull request: CB-10653 Making the windows activati...
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/173#discussion_r61665566
--- Diff: cordova-js-src/platform.js ---
@@ -56,9 +57,10 @@ module.exports = {
// OR cordova.require('cordova/platform').activationContext
// activationContext:{type: actType, args: args};
var activationHandler = function (e) {
-var args = e.detail.arguments;
-var actType = e.detail.type;
-platform.activationContext = { type: actType, args: args };
+// Making all the details available as activationContext
+platform.activationContext = utils.clone(e.detail);
+platform.activationContext.args = e.detail.arguments;
/* for backwards compatibility */
+platform.activationContext.actType = e.detail.type;
/* for backwards compatibility */
--- End diff --
I think you don't need an actType property for back-compat. The property
(not the variable) was previously named just "type".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10653 Making the windows activati...
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/173#discussion_r61665577
--- Diff: template/www/cordova.js ---
@@ -1508,9 +1509,10 @@ module.exports = {
// OR cordova.require('cordova/platform').activationContext
// activationContext:{type: actType, args: args};
var activationHandler = function (e) {
-var args = e.detail.arguments;
-var actType = e.detail.type;
-platform.activationContext = { type: actType, args: args };
+// Making all the details available as activationContext
+platform.activationContext = utils.clone(e.detail);
+platform.activationContext.args = e.detail.arguments;
/* for backwards compatibility */
+platform.activationContext.actType = e.detail.type;
/* for backwards compatibility */
--- End diff --
Same here with actType.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org
